Commit Graph
153 Commits
Author SHA1 Message Date
Atsushi Eno 1f4684cd40 2010-06-17 Atsushi Enomoto <[email protected]>
* ServiceHostBase.cs : retrieve MessageVersion and raise an error
	  if there is none. (Check this earlier than building a listener.)

	* ChannelDispatcher.cs : MessageVersion check is moved to
	  ServiceHostBase.

	* ServiceMetadataExtension.cs : overwrite MessageVersion to use None.
	  (The only special case I found for ChannelDispatcher.MessageVersion.)

	* CustomBindingTest.cs : add tests for MessageVersion check on Open().

	* MetadataExchangeBindingsTest.cs : make sure that special casing of
	  MessageVersion does not happen at this layer.


svn path=/trunk/mcs/; revision=159061
2010-06-17 10:48:55 +00:00
Atsushi Eno da02d7672c 2010-06-14 Atsushi Enomoto <[email protected]>
* OperationInvokerHandler.cs, MessageProcessingContext.cs :
	  ChannelDispatcher may be null, so check its availability before
	  using it. Don't use it, when possible.
	* DispatchOperation.cs : remove unused member.


svn path=/trunk/mcs/; revision=158871
2010-06-14 11:45:04 +00:00
Atsushi Eno eed5cddbae 2010-06-04 Atsushi Enomoto <[email protected]>
* OperationDescription.cs : add contract origin flags to identify
	  which operation should be used for client operations (and dispatch
	  too in the future).
	* MessageDescription.cs : add IsRequest flag to indicate if it is
	  for request or not.
	* ServiceContractGenerator.cs, ContractDescriptionGenerator.cs :
	  make use of above changes.
	* ContractDescription.cs : don't create extraneous ClientOperations
	  in irrelevant message direction.

	* EndpointDispatcher.cs, BaseMessagesFormatter.cs:
	  Now MessageDescription.Direction is differentiated from "IsRequest"
	  property, to precisely identify request/reply in callbacks. Also
	  now we don't have to create extraneous ContractDescription for
	  callbacks.

	* DuplexClientRuntimeChannel.cs : do not create and use extraneous
	  ContractDescription for callback contract. Non-callback ones now
	  works fine.

	This fixes service part of bug #567672, IsOneWay = true case.


svn path=/trunk/mcs/; revision=158454
2010-06-04 08:40:36 +00:00
Atsushi Eno 3966750e29 2010-06-03 Atsushi Enomoto <[email protected]>
* ContractDescriptionGenerator.cs : Now callback contract methods are
	  also reflected into OperationDescription as well as those from non-
	  callback contract. Callback methods have reverse MessageDirection,
	  so adjust them.
	* ContractDescription.cs, ServiceEndpoint.cs, TypedMessageConverter.cs :
	  A bit of renaming / reflect method call changes.

	* EndpointDispatcher.cs, DispatchRuntime.cs, ClientRuntime.cs :
	  now Callback[Dispatch|Client]Runtime properties are always filled
	  so that users can configure the callback runtimes (not sure such
	  configured runtimes work fine yet, but it is a required step).
	* InputOrReplyRequestProcessor.cs : instead of HasCallbackRuntime
	  hack, use CallbackClientRuntime.CallbackContractType for checking
	  callback existence.

	* ClientProxyGenerator.cs : CreateProxyType now carefully considers
	  requested proxy type, contract type and callback contract type.
	  i.e. now the resulting proxy has implemented methods for callbacks
	  that are also filled at ContractDescription.
	* ClientRuntimeChannel.cs : reflect some method call changes.


svn path=/trunk/mcs/; revision=158412
2010-06-03 16:33:31 +00:00
Atsushi Eno 87eb8ffb54 2010-05-28 Atsushi Enomoto <[email protected]>
* ClientOperation.cs, DispatchOperation.cs : remove extra fields.


svn path=/trunk/mcs/; revision=158084
2010-05-28 08:04:06 +00:00
Atsushi Eno c0e0e3f66e 2010-05-28 Atsushi Enomoto <[email protected]>
* ContractDescription.cs : fill ClientOperation.Formatter here.
	  (It is hacky, see additional comment.)

	* ClientRuntimeChannel.cs : replace GetFormatter() with Formatter.

	* ClientOperation.cs : do the same for client side too.


svn path=/trunk/mcs/; revision=158083
2010-05-28 07:52:10 +00:00
Atsushi Eno 193f438706 2010-05-28 Atsushi Enomoto <[email protected]>
* DispatchOperation.cs : on callback channels ChannelDispatcher is
	  not available. Wait for something like ClientRuntime.ChannelFactory.


svn path=/trunk/mcs/; revision=158082
2010-05-28 07:48:56 +00:00
Atsushi Eno ba2d156ba4 2010-05-28 Atsushi Enomoto <[email protected]>
* EndpointDispatcher.cs : some comments.
	* DispatchOperation.cs : remove on-the-fly dependency on 
	  OperationDescription. Add immutable check on each property.


svn path=/trunk/mcs/; revision=158080
2010-05-28 07:08:00 +00:00
Atsushi Eno bcf2dad8d0 2010-05-27 Atsushi Enomoto <[email protected]>
* EndpointDispatcher.cs : fill CallbackDispatchRuntime. Add some
	  FIXME comments for ongoing fixes.


svn path=/trunk/mcs/; revision=158048
2010-05-27 17:17:12 +00:00
Atsushi Eno efd7c155a3 2010-05-26 Atsushi Enomoto <[email protected]>
* TcpDuplexSessionChannel.cs, TcpReplyChannel.cs : do not set RelatesTo
	  here. If the contract is not one-way (IsOneWay = false) and there is
	  a callback, the callback message sent to the client should *not* be
	  assigned RelatesTo header here. Just do it in the request-reply
	  context. Do it in OperationInvokerHandler.

	* OperationInvokerHandler.cs : assign RelatesTo header item here.


svn path=/trunk/mcs/; revision=157950
2010-05-26 10:46:32 +00:00
Atsushi Eno 9e08c76462 2010-05-21 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : disable slottling again :( It still fails
	  to process concurrent requests if there is service metadata channel
	  and MaxConcurrentSessions > 1 on non-ASP.NET channels.


svn path=/trunk/mcs/; revision=157670
2010-05-21 09:16:37 +00:00
Atsushi Eno 79a9bcb766 2010-05-21 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : enable throttling again. Though issues
	  regarding parallel request is not here (multiple dispatchers
	  can accept a channels for each), and HTTP channels do not accept
	  more than one channel at a time anyways.


svn path=/trunk/mcs/; revision=157662
2010-05-21 04:48:10 +00:00
Atsushi Eno 277acc8496 2010-04-28 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : add workaround to set ChannelDispatcher
	  to IChannelListener. Avoid null ChannelDispatcher in http listener.

	* HttpChannelListener.cs, HttpListenerManager.cs :
	  Fix NRE issue in olive/samples/wcf/web-http-binding/samplesvc3.exe.


svn path=/trunk/mcs/; revision=156344
2010-04-28 16:25:01 +00:00
Atsushi Eno d677acfe78 2010-04-20 Atsushi Enomoto <[email protected]>
* OperationInvokerHandler.cs : workaround NRE issue in AsyncCallTest.
	  The original code was worse than this workaround.


svn path=/trunk/mcs/; revision=155788
2010-04-20 09:43:19 +00:00
Atsushi Eno da6fdf34e6 2010-04-05 Atsushi Enomoto <[email protected]>
* EndpointAddressMessageFilter.cs : check null arg. Return false for
	  no To header case and do not result in NRE.f

	* EndpointAddressMessageFilterTest.cs :
	  Add null arg case. Enable working test.


svn path=/trunk/mcs/; revision=154787
2010-04-05 09:11:12 +00:00
Atsushi Eno 4e1c23bf2b 2010-04-05 Atsushi Enomoto <[email protected]>
* BaseMessagesFormatter.cs : hasParameter check is incorrectly
	  restrictive to reject some kinds of pairs.

	* CustomPeerResolverServiceTest.cs : enabled all disabled tests.


svn path=/trunk/mcs/; revision=154781
2010-04-05 07:45:21 +00:00
Atsushi Eno a4c1625957 2010-04-02 Atsushi Enomoto <[email protected]>
* ClientRuntimeChannel.cs :
	  use DataContractSerializer.IsStartObject() to check if the fault
	  detail reader is for the fault contract, in addition to Action.

	* FaultContractInfo.cs : add serializer property.


svn path=/trunk/mcs/; revision=154712
2010-04-02 12:20:47 +00:00
Atsushi Eno f3a83a8e54 2010-04-02 Atsushi Enomoto <[email protected]>
* ClientOperation.cs : do not automatically fill FaultContractInfos.


svn path=/trunk/mcs/; revision=154693
2010-04-02 09:00:18 +00:00
Atsushi Eno e50d376520 2010-04-02 Atsushi Enomoto <[email protected]>
* OperationInvokerHandler.cs : implement FaultContractInfos support.
	* ErrorProcessingHandler.cs : update comment. It is not relevant.


svn path=/trunk/mcs/; revision=154692
2010-04-02 06:19:47 +00:00
Atsushi Eno 642bfdb13c 2010-04-02 Atsushi Enomoto <[email protected]>
* EndpointDispatcher.cs : fill FaultContractInfos.
	* DispatchOperation.cs : do not fill them dynamically/automatically.
	* ErrorProcessingHandler.cs : added some FIXME notes.


svn path=/trunk/mcs/; revision=154690
2010-04-02 05:43:44 +00:00
Atsushi Eno a286cc646c 2010-03-30 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : differentiate EndpointNotFound and
	  ActionNotSupported so that FaultConverter can create appropriate
	  fault messages. Removed extra filter condition on null To item.
	  And create fault messages on *any* server side error, do not let
	  request client infinitely wait for the response until timeout.

	  (RunDestinationUnreachableTest() is still not working but it works
	  when it is SOAP 1.2.)


svn path=/trunk/mcs/; revision=154439
2010-03-30 10:28:51 +00:00
Atsushi Eno 3d135ccba1 2010-03-30 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : for faults, use fault namespace, not that of
	  ReplyAction. Added FIXME comment regarding dispatcher.


svn path=/trunk/mcs/; revision=154427
2010-03-30 07:35:56 +00:00
Atsushi Eno b67cee8408 2010-03-25 Atsushi Enomoto <[email protected]>
* OperationInvokerHandler.cs : removed unused code.


svn path=/trunk/mcs/; revision=154200
2010-03-25 15:27:36 +00:00
Atsushi Eno 0dcd75c5fc 2010-03-24 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : return EndpointDispatcher at initializing
	  for internal use. Add some locks. Patch by Matt Dargavel.

	* ServiceHostBase.cs : if there is an existing ChannelDispatcher
	  for the same endpoint URI, reuse it. Patch by Matt Dargavel.


svn path=/trunk/mcs/; revision=154114
2010-03-24 07:12:29 +00:00
Atsushi Eno 5049788319 2010-03-24 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : fix wrong method call in open_delegate.
	  Patch by Matt Dargavel.


svn path=/trunk/mcs/; revision=154111
2010-03-24 06:07:09 +00:00
Atsushi Eno 93dc6116a5 2010-03-24 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : give the actual exception message instead
	  of "error occured".


svn path=/trunk/mcs/; revision=154110
2010-03-24 06:04:22 +00:00
Atsushi Eno 9248aceeaf 2010-03-18 Atsushi Enomoto <[email protected]>
* XPathMessageContext.cs : implement.
	* XPathMessageFilterTable.cs : add some missing overloads.

	* Constants.cs : add more.

	* System.ServiceModel_test.dll.sources :
	  Add Constants.cs and XPathMessageContextTest.cs.

	* XPathMessageContextTest.cs : new.

	* Constants.cs : copied from the lib itself.


svn path=/trunk/mcs/; revision=153833
2010-03-18 13:02:16 +00:00
Atsushi Eno 9f2af8d5a1 2010-03-11 Atsushi Enomoto <[email protected]>
* BaseMessagesFormatter.cs : add internal OperationFormatter type
	  for moonlight/silverlight-sdk compatibility. It mostly wraps
	  the existing the return value by BaseMessagesFormatter.Create().
	* DispatchOperation.cs, ClientOperation.cs, EndpointDispatcher.cs:
	  use above new type.


svn path=/trunk/mcs/; revision=153493
2010-03-12 07:27:23 +00:00
Atsushi Eno d7a25cf1a4 2010-02-26 Atsushi Enomoto <[email protected]>
* ServiceRuntimeChannel.cs, ServiceProxyGenerator.cs:
	  make them public and add Contract property for service callback
	  proxies too for the same reason.

	* InputOrReplyRequestProcessor.cs : now ServiceRuntimeChannel is
	  moved to fake public namespace.


svn path=/trunk/mcs/; revision=152523
2010-02-26 05:12:22 +00:00
Atsushi Eno dd3adaa509 2010-02-18 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : revert previous change - it could result
	  in blocking some threads and block nunit completion.


svn path=/trunk/mcs/; revision=151960
2010-02-18 08:20:36 +00:00
Atsushi Eno 6032fc1874 2010-02-04 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : now I can enable service throttling to
	  handle more than one concurrent channels as ASP.NET reply channel
	  got fixed.

	* HTTP_listener_notes.txt: Fixed some wrong description, simplified
	  some, and updated some.


svn path=/trunk/mcs/; revision=150851
2010-02-04 11:52:57 +00:00
Atsushi Eno fb89844a39 2010-01-25 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : actually instance context provider could be
	  null through the entire service run.

	  Fixed all current nunit failures!


svn path=/trunk/mcs/; revision=150110
2010-01-25 09:01:04 +00:00
Atsushi Eno 79c79e577b 2010-01-22 Atsushi Enomoto <[email protected]>
* DuplexClientRuntimeChannel.cs : do not try to iterate channel
	  acceptor when it is being closed.

	* ChannelDispatcher.cs : do not try to iterate channel acceptor when
	  it is being closed.


svn path=/trunk/mcs/; revision=150047
2010-01-22 08:18:19 +00:00
Atsushi Eno 47f6d5587c 2010-01-19 Atsushi Enomoto <[email protected]>
* CommunicationObject.cs : when process state changes, lock the
	  object to make sure the state transition is valid.
	  Change OnClosed/OnClosing to do the way OnOpened/OnOpening does.

	* ChannelDispatcher.cs : another error audit.


svn path=/trunk/mcs/; revision=149793
2010-01-19 10:15:25 +00:00
Atsushi Eno 4a82278269 2010-01-13 Atsushi Enomoto <[email protected]>
* ContractDescriptionGenerator.cs : fill Operation.Faults.

	* FaultContractInfo.cs : implement.
	* DispatchOperation.cs, ClientOperation.cs: fill Faults.

	* net_2_1_raw_System.ServiceModel.dll.sources :
	  add FaultContractInfo.cs.


svn path=/trunk/mcs/; revision=149445
2010-01-13 10:37:41 +00:00
Atsushi Eno 5c3aa1b73a 2010-01-08 Atsushi Enomoto <[email protected]>
* ContractDescriptionGenerator.cs : fix GetCallbackContract() to
	  correctly retrieve ServiceContractAttribute from the service type,
	  not the callback type. This ended up to get the bug #567672 sample
	  working (but it will break at some stage as it involves some
	  non-implemented classes).

	* EndpointDispatcher.cs, InputOrReplyRequestProcessor.cs :
	  Pass service type to correctly retrieve ServiceContractAttribute
	  from the service type, not callback type.

	* ServiceProxyGenerator.cs, ServiceRuntimeChannel.cs :
	  Pass service type to correctly retrieve ServiceContractAttribute
	  from the service type, not callback type.

	* CallbackBehaviorAttributeTest.cs : added callback example from
	  bug #567672.


svn path=/trunk/mcs/; revision=149226
2010-01-08 10:40:46 +00:00
Atsushi Eno 3626d9fdcd 2010-01-07 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : make sure to unlock channel acceptor wait
	  handle when the delegated method resulted in an error.


svn path=/trunk/mcs/; revision=149162
2010-01-07 08:25:51 +00:00
Atsushi Eno 577d5f7da8 2009-12-26 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : close such channels that failed to receive
	  request or input.


svn path=/trunk/mcs/; revision=148902
2009-12-26 08:55:21 +00:00
Atsushi Eno 3d60c24a10 2009-12-26 Atsushi Enomoto <[email protected]>
* DispatchRuntime.cs : shortened code and scattered monotodos.


svn path=/trunk/mcs/; revision=148898
2009-12-26 03:07:26 +00:00
Atsushi Eno e1ae570a9b 2009-12-10 Atsushi Enomoto <[email protected]>
* OperationInvokerHandler.cs : fix async operation handling. Since
	  the entire handler chain is designed to be in synchronous, one
	  single handler must not leave its work incomplete (async). Just
	  wait for the async process completion within the handler.


svn path=/trunk/mcs/; revision=148021
2009-12-10 11:38:05 +00:00
Atsushi Eno 07d0ed89df 2009-12-07 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : fix regression; ServiceBehaviorAttribute
	  could be set explicitly null.


svn path=/trunk/mcs/; revision=147782
2009-12-07 15:50:08 +00:00
Atsushi Eno 0c9426582b 2009-12-07 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : handle AddressFilterMode (.Any only yet).
	* OperationInvokerHandler.cs : fix wrong IAsyncResult use.


svn path=/trunk/mcs/; revision=147781
2009-12-07 15:40:13 +00:00
Atsushi Eno 85f58a5b94 2009-12-07 Atsushi Enomoto <[email protected]>
* ServiceHostBase.cs : in AddBaseAddress(), use base_addresses
	  instead of Description. It could be called in InitializeDescription.

	* InstanceBehavior.cs : allow nonpublic instance.
	* DefaultOperationInvoker.cs : do use IsSynchronous correctly.


svn path=/trunk/mcs/; revision=147774
2009-12-07 14:02:59 +00:00
Atsushi Eno 9f41ecccde 2009-10-22 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : disable concurrent channel acceptance
	  until it gets working fine.


svn path=/trunk/mcs/; revision=144657
2009-10-22 18:08:45 +00:00
Atsushi Eno be14cb07f3 2009-10-16 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : fix warnings.


svn path=/trunk/mcs/; revision=144260
2009-10-16 11:23:34 +00:00
Atsushi Eno 6a913053e4 2009-10-16 Atsushi Enomoto <[email protected]>
* ClientOperation.cs, ClientRuntime.cs : another couple of changes
	  are required to not use non-SL types.


svn path=/trunk/mcs/; revision=144252
2009-10-16 05:30:59 +00:00
Atsushi Eno 13661222e6 2009-10-16 Atsushi Enomoto <[email protected]>
* ClientRuntime.cs : enable Operations property on monotouch.
	  Hopefully it will enable us to build WebHttpBinding.


svn path=/trunk/mcs/; revision=144251
2009-10-16 05:23:42 +00:00
Atsushi Eno e4fe97dc46 2009-10-09 Atsushi Enomoto <[email protected]>
* CommunicationObject.cs : OnOpening() and OnOpened() require calls
	  to base methods. This resulted in not a few changes everywhere.

	 * ChannelDispatcher.cs : OnOpened/OnOpening constraints related
	   changes were required here too. Actually it simplified code.

	* InstanceContext.cs : new constraints on CommunicationObject
	  required calls to base methods.
	* ChannelFactory.cs : ditto. Actually changed timing to call
	  Open() on the internal factory.
	* ServiceHostBase.cs : removed DoOpen() which is almost extra now.
	  Added temporary IMetadataExchange workaround.


svn path=/trunk/mcs/; revision=143829
2009-10-09 07:30:39 +00:00
Atsushi Eno 6c77634162 2009-10-06 Atsushi Enomoto <[email protected]>
* OperationInvokerHandler.cs : a bit more explaining message.


svn path=/trunk/mcs/; revision=143552
2009-10-06 19:16:43 +00:00
Atsushi Eno 487b8d3e04 2009-10-05 Atsushi Enomoto <[email protected]>
* ChannelDispatcher.cs : make sure to close, *and* abort channels
	  in case they failed to close. Also consider close timeouts.
	  Rename a field to make less confusing.


svn path=/trunk/mcs/; revision=143431
2009-10-05 18:18:32 +00:00