Commit Graph
470 Commits
Author SHA1 Message Date
justremotephone eb3f7312bd [System.ServiceModel] Fix a race condition in HttpRequestChannel. (#13304)
Concurrent request completions could cause following exception:

```
    FATAL UNHANDLED EXCEPTION: System.ArgumentOutOfRangeException:
        Index was out of range. Must be non-negative and less than
        the size of the collection.
        Parameter name: index
       at System.Collections.Generic.List`1[T].RemoveAt (System.Int32 index) [0x00009] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Collections.Generic.List`1[T].Remove (T item) [0x0000c] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.ServiceModel.Channels.HttpRequestChannel+HttpChannelRequestAsyncResult.Cleanup () [0x00011] in <28c4695205ef47378f5370502b066592>:0
       at System.ServiceModel.Channels.HttpRequestChannel+HttpChannelRequestAsyncResult.set_IsCompleted (System.Boolean value) [0x00034] in <28c4695205ef47378f5370502b066592>:0
       at System.ServiceModel.Channels.HttpRequestChannel+HttpChannelRequestAsyncResult.Complete (System.Exception ex) [0x0001a] in <28c4695205ef47378f5370502b066592>:0
       at System.ServiceModel.Channels.HttpRequestChannel+<>c__DisplayClass7_1.<BeginProcessRequest>b__0 (System.IAsyncResult r) [0x000bd] in <28c4695205ef47378f5370502b066592>:0

    This stack was captured after some changes in AwaitTaskContinuation.RunOrScheduleAction.
    Unfortunately the current implementation of AwaitTaskContinuation.RunOrScheduleAction re-throws the above
    exception with a wrong stack:

       at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction (System.Action action, System.Boolean allowInlining, System.Threading.Tasks.Task& currentTask) [0x00023] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishContinuations () [0x00052] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishStageThree () [0x0003c] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishStageTwo () [0x000a1] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.Finish (System.Boolean bUserDelegateExecuted) [0x00003] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.TrySetException (System.Object exceptionObject) [0x00023] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[TResult].SetException (System.Exception exception) [0x00029] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Net.HttpWebRequest+<RunWithTimeoutWorker>d__241`1[T].MoveNext () [0x000e0] in <3e9b3e26c4694baab3f689687ad40612>:0
       at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext (System.Object stateMachine) [0x00000] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00071] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run () [0x00024] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction (System.Action action, System.Boolean allowInlining, System.Threading.Tasks.Task& currentTask) [0x00023] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishContinuations () [0x00052] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishStageThree () [0x0003c] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task`1[TResult].TrySetResult (TResult result) [0x0004f] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[TResult].SetResult (TResult result) [0x0003d] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Net.ServicePointScheduler+<WaitAsync>d__45.MoveNext () [0x000f7] in <3e9b3e26c4694baab3f689687ad40612>:0
       at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext (System.Object stateMachine) [0x00000] in <4a8a0
```

On an Android Xamarin installation this causes an app crash. Since no user code is active the exception cannot be caught.
2019-03-06 01:07:29 +01:00
Mads Kruse Johnsen 0ade173b9b [wcf] pass on the ContentType of MTOM message response (#11664) 2018-11-14 11:50:48 +01:00
Joshua Peterson e11c793663 Expose two public types (#8470)
* Expose two public types

These types are public in the .NET 4.7.1 profile, so they should be
public in Mono as well.

* Bump API snapshot submodule
2018-04-27 03:10:30 +02:00
pascalhaakmat 3fa3592376 Uncomment and fix ServiceHost creation via ServiceFactory in SvcHttpHandler.cs (#3465)
This commit allows customization of WCF service creation via the Factory attribute in an .svc file:

`<%@ ServiceHost Language="C#" Service="CustomService" Factory="CustomServiceHostFactory" %>`

All the patch does is uncomment a few lines that were already there and fix a small error. I am not sure why these lines were commented. Possibly the code is not sufficiently robust or it was just never given another look. But this works for me and it seems better than no support at all. For example, a custom ServiceHostFactory appears to be the only way to create a WCF service in a managed host which customizes EndpointDispatcher.AddressFilter and EndpointDispatcher.ContractFilter. This in turn is useful for proxied WCF services.

See also http://mono.1490590.n4.nabble.com/Mono-WCF-ServiceHost-Factory-option-td4251992.html (from 2012; never posted on the mailing list for some reason).
2018-03-21 18:09:45 +01:00
Paul Fertser e2e66cb4f8 [wcf] use ConcurrentDictionary for wait handles (#7265)
SvcHttpHandler is supposed to be thread-safe so it shouldn't use plain
Dictionary without additional locking.

The problem is apparent when running test app from issue #7134 with
hyperfastcgi as the following exception sometimes surfaces:

```
[System.NullReferenceException]: Object reference not set to an instance of an object
  at System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) [0x00111] in .../mono/external/corefx/src/Common/src/CoreLib/System/Collections/Generic/Dictionary.cs:441
  at System.Collections.Generic.Dictionary`2[TKey,TValue].set_Item (TKey key, TValue value) [0x00000] in .../mono/external/corefx/src/Common/src/CoreLib/System/Collections/Generic/Dictionary.cs:223
  at System.ServiceModel.Channels.SvcHttpHandler.ProcessRequest (System.Web.HttpContext context) [0x00048] in .../mono/mcs/class/System.ServiceModel/System.ServiceModel.Channels/SvcHttpHandler.cs:82
  at System.Web.HttpApplication+<Pipeline>d__225.MoveNext () [0x008fd] in .../mono/mcs/class/System.Web/System.Web/HttpApplication.cs:1338
  at System.Web.HttpApplication.Tick () [0x00000] in .../mono/mcs/class/System.Web/System.Web/HttpApplication.cs:927
```
2018-02-26 12:59:15 +01:00
Marek Safar 71ad99f720 [build] Narrow recursive dependencies 2018-02-08 23:49:44 -05:00
Manuel de la Pena 12d676563e [Tests] Skip System.ServiceModel tests that are not supported on XamMac 4.5 (#6574) 2018-01-18 19:08:03 +01:00
Alexander Köplinger 9e91b6687e [System.ServiceModel] Don't use DateTime.Now for measuring elapsed time
Use Stopwatch or DateTime.UtcNow instead which aren't affected
by things like daylight-saving time
2017-07-02 23:31:34 +02:00
Alexander Köplinger cd57ffcd04 [System.ServiceModel] Rename method parameters to match .NET contract 2017-03-16 13:02:09 +01:00
Alexander Köplinger 69b3397c8e [System.ServiceModel] Recognize 'faultactor' in SOAP fault message
It's an optional element according to [1] and we were simply
throwing a NotImplementedException when encountering it.

Fixed by reading the element value instead. I noticed that we
had a 'details' variable that was never assigned, so the check
for `details == null` was always true and can be removed.
This makes inlining the body of the CreateFault() call easier
since we no longer need to choose different overloads and makes
the code consistent with the CreateFault12 method.
Also added a better exception in case of an unrecognized element.

The CreateFault12 method (handles SOAP 1.2) does not need a similar
fix since actor is not an element in that version [2].

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=42226

[1] https://www.w3.org/TR/soap11/#_Toc478383507
[2] https://www.w3.org/TR/soap12/#soapfault
2016-11-04 16:18:46 +01:00
Pozdeev b7754c85fd [System] Set KeepAlive flag for HttpWebRequest 2016-08-30 13:36:21 +05:00
Alexander Köplinger c4692001a9 [bcl] Fix method parameter names to match .NET
The names were fixed only for the subset of methods that are included in netstandard,
and in cases where netstandard differs from Desktop .NET we match with .NET.
2016-08-26 17:49:03 +02:00
Ludovic Henry 249daf43de [mcs] Replace NET_2_1 by MOBILE
NET_2_1 is also defined whenever we define MOBILE, so they have the same effect. Silverlight was 2.1 but it's been dead for a while now, and we do not even support it.
2016-08-18 16:34:36 +02:00
Alexander Köplinger 3c3ef17376 [bcl] Update to match NETStandard 1.6 members 2016-08-11 20:53:38 +02:00
Marek Safar 10c5e72512 [bcl] netstandart 1.6 support 2016-07-13 11:02:10 +02:00
Alexander Köplinger b03e606287 Remove ChangeLog files from the repo
They weren't updated in the last 6 years and aren't helpful anymore (e.g. by causing unrelated matches during git grep searches).
2016-01-29 19:17:06 +01:00
Miguel de Icaza 559ad5b34b Merge pull request #463 from strawd/concurrent-requests
Handle multiple concurrent calls to BeginTryReceiveRequest
2015-09-23 14:37:01 -04:00
Chris Hamons b044a27fe0 Create xammac_net_4_5 profile for XM 4.5 Unified to remove references to unshippable assmblies 2015-06-18 13:31:04 -05:00
Atsushi Eno 63a8b865f7 [WCF] bonus, NET_2_1 is blocking set_Timeout. It didn't exist in Moonlight. 2015-05-22 01:23:27 +08:00
Atsushi Eno d2cdee078d [WCF] XmlReader from GetReaderAtBodyContents() should not be missing xmlns-es.
The namespace declarations existed when the entire Message is read but not
in the partial body contents. They caused regressions when we use
serialization stack from referencesource.

It is possible that more namespaces may be requied, but we will be importing
System.ServiceModel later on and then the issue will go away.
So far we don't want regression as long as they show up in our NUnit tests.
2015-04-24 14:36:58 +09:00
Atsushi Eno e94bc465ca [WCF] referencesource XmlBinaryWriter closes stream by default, so keep it open.
Otherwise MemoryStream.Position complains that it is already disposed.
2015-04-24 14:36:57 +09:00
Atsushi Eno b40dd06602 [WCF] fix mobile builds. Mono.Xml.XPath is gone. 2015-03-02 11:36:42 +08:00
Atsushi Eno 3001bd0d94 [WCF] for certain kind of Messages, do now write BodyContents twice. 2015-02-21 03:28:07 +08:00
Miguel de Icaza 5715cdc582 [System.ServiceModel] Prevent server crash when client disconnect
This patch is an updated version of a pull request (377) from Rob
Wilkens to fix #5926
2015-02-16 10:01:22 -05:00
Zoltan Varga c1b4366932 [bcl] Remove NET_4_5 defines from class libs. 2015-01-13 16:34:23 -05:00
Zoltan Varga 032f313d5f [bcl] Remove NET_4_0 defines from class libs. 2015-01-13 16:06:31 -05:00
Miguel de Icaza 8d15c21023 [WCF] Make BasicHttpBinding.AllowCookies work
This patch is from Brendan Zagaeski and fixes bug 11307

The description of the problem was:

In Mono 2.10.12, the BasicHttpBinding property no longer supports
EnableHttpCookieContainer because it is Depreciated. The replacement
is AllowCookies, but this property does not work. Upon inspection of
the source source, we find that the HttpCookieContainerBindingElement
is added in accordance with EnableHttpCookieContainer, but not
AllowCookies.

The conditional compile logic at [1] is no longer needed for
Xamarin.iOS or Xamarin.Android.
2014-06-19 17:45:15 -04:00
Atsushi Eno c67aed9a47 fix build. 2014-01-10 20:42:25 +09:00
Atsushi Eno 2fd8da4920 Fix bug #11336. 2014-01-10 19:03:33 +09:00
Martin Baulig 1ae87e9ee9 [WCF]: Add stubs for some missing .NET 4.0/4.5 APIs. 2013-09-02 21:52:13 +02:00
Martin Baulig 97d52b2237 [WCF]: Implement cookie support in .NET 4.0. 2013-03-22 04:08:10 +01:00
Martin Baulig d2d903f1d2 [WCF]: 2nd part of bug #5827, set CheckCharacters = false in TextMessageEncoder. 2013-03-22 01:57:37 +01:00
Martin Baulig dfc1434f41 Add stubs for some new .NET 4.0/4.5 WCF APIs. 2013-03-12 17:23:01 -04:00
Rodrigo Kumpera a0d28b2587 Kill the MOONLIGHT define in System.ServiceModel. 2013-02-11 13:01:11 -05:00
Martin Baulig e3ad9bbaec [WCF]: Minor NetTcpBinding fixes. 2013-01-21 19:27:22 +01:00
Martin Baulig 6805b32a1a [WCF]: Import ServiceEndpoint.Address for all bindings. 2013-01-21 19:25:40 +01:00
Martin Baulig ea2f2cde42 [WCF]: Fix MessageEncoder.IsContentTypeSupported().
Use the internal 'Channels.ContentType' class to parse the
content type, make then comparision case-insensitive and ignore
missing parameters.
2012-12-22 05:14:26 +01:00
Atsushi Eno 47b3bb2eb2 Fix mobile builds. 2012-12-07 18:05:57 +09:00
Martin Baulig c1b505c0ca [WCF]: Implement and improve missing WsdlExporter pieces.
* We now export simple <wsp:Policy>, currently supporting only
  those elements that WsdlImporter can import.

  WsdlImporter:
  https://github.com/mono/mono/commit/cdc98dba1b83341c25a1daab4ae7c217d4961ad1

* Implement `MetadataExporter.Errors' and use it for error
  reporting.

* Fixed WsdlExporter's caching to correclty deal with duplicate
  ExportContract() and ExportEndpoint() calls.

* Emit <soap12:operation> depending on the binding's MessageVersion.
  (FIXME: I didn't implement soap faults yet).

* MetadataTests: Check whether the policy elements are correct.

* MetadataTests: Add test containing simple [OperationContract] method
  for http and net.tcp; checks the <soap:operation> / <soap12:operation>
  elements.

* New test to check WsdlExporter's behavior regarding duplicate
  contracts and endpoints.

* ConnectionOrientedTransportBindingElement.cs, CustomBindingTests.cs,
  HttpTransportBindingElementTest.cs: Added test for custom message
  encodings.
2012-12-05 23:58:12 +01:00
Martin Baulig cdc98dba1b [WCF]: Implement missing WsdlImporter pieces.
The WsdlImporter can now import Bindings and Endpoints
from the WSDL, currently supporting BasicHttpBinding,
BasicHttpsBinding and NetTcpBinding.

There is also - limited and still experimental - support
for WS-Policy 1.5.  I only did the very basic pieces so
far, for instance things like TransportWithMessageCredentials
are not supported yet.

The policy importer will emit lots of warnings via
`MetadataImporter.Errors` (as warnings, not errors) whenever
it encounters something that it doesn't understand and
is also forgiving towards unknown and/or mal-formed
policy assertions.

This behavior is different from the MS runtime, which is
very strict, but there are simply too many missing pieces
to be more pedentic here.  Check whether Errors.Count == 0
to see whether all policy assertions have been correctly
imported.

There are also a few metadata samples, which are part of the
new nunit tests.  These are currently working:

  BasicHttp.xml, BasicHttp_Mtom.xml, BasicHttp_NtlmAuth.xml,
  BasicHttp_TransportSecurity.xml, BasicHttps.xml,
  BasicHttps_NtlmAuth.xml, NetTcp.xml, NetTcp_TransferMode.xml,
  NetTcp_TransportSecurity.xml

There are a few more in the Tests/MetadataTests/Resources/
directory which demonstrate missing pieces.
2012-11-27 02:30:54 +01:00
David Straw 14b42141c0 Handle multiple concurrent calls to BeginTryReceiveRequest 2012-09-17 11:39:30 -06:00
Martin Baulig 25f9a11c6e [#6515][WCF]: Enable custom headers for NET_2_1.
This allows

	HttpRequestMessageProperty request = new HttpRequestMessageProperty ();
	request.Headers.Add ("Foo", "Bar");

	OperationContext.Current.OutgoingMessageProperties.Add (HttpRequestMessageProperty.Name, request);

The code was already there, but disabled for the NET_2_1 profile.
2012-09-17 17:31:44 +02:00
Martin Baulig d2d43552c2 [#6201][WCF]: Don't crash if we don't have a client certificate. 2012-09-15 21:10:36 +02:00
Miguel de Icaza b1e73aa3e2 Make this build on the MOBILE profile 2011-10-21 11:50:17 -04:00
Miguel de Icaza abbb1550d3 Apply patch from Mario Kosmiskaso fix bug 1207: Throw the correct exception when a REST request returns a 404
.NET throws a EndpointNotFoundException encapsulating a WebException when a
REST request returns a 404.

The attached patch tests for a 404 and throws the same exception chain thrown
by .NET.
2011-10-16 11:46:00 -04:00
Miguel de Icaza 1b47742b05 Apply patch from Mario Kosmiskaso fix bug 1207: Check reference before copying values from Headers
OutgoingWebRequestContext throws a NullReferenceException when making a REST
call. The exception is thrown because there are no Headers in the context.

Attached patch simply tests for null before copying values from Headers.
2011-10-16 11:46:00 -04:00
Miguel de Icaza f17f74024a Apply patch from Mario Kosmiskaso fix bug 1204: Add certificate to the HttpWebRequest if configured
System.ServiceModel.Channels.HttpRequestChannel never added the configured
certificate to the HttpWebRequest which prevented client side authentication.

The attached patch does exactly that if a certificate has been configured.
2011-10-16 11:45:59 -04:00
Miguel de Icaza 96e0bed4c8 Fix bug 1203, relaxes the test for the protocol to allow https endpoints 2011-10-16 11:45:58 -04:00
Atsushi Eno 189da5d408 Add ProtectionTokenParameter for mutual nego. Patch by Alexander Riman. 2011-10-04 00:00:43 +09:00
Michael Stoll 114fb284e8 Fixed coding style for BasicHttpBinding and SecurityBindingElement 2011-08-02 10:23:24 +02:00