Compare commits

...
4921 Commits
Author SHA1 Message Date
Alex Corrado 3f71a4bfc2 Update fsharp.py 2019-11-24 14:06:21 -05:00
Alex Corrado 394ed52275 Update fsharp.py 2019-11-23 21:12:53 -05:00
Alex Corrado 8a2d0cb8a7 Update fsharp.py 2019-11-22 23:25:41 -05:00
Alex Corrado 670e1ea3cb [fsharp] Remove failing patch 2019-11-22 18:35:53 -05:00
Alex Corrado c759092277 [fsharp] Try to build with F# 4.7 2019-11-22 14:58:32 -05:00
Zoltan Varga 93e46c687b [runtime] Treat calling a non-virtual method through an open delegate the same as the normal case instead of the OPEN_VIRTUAL case. (#17832)
* [runtime] Treat calling a non-virtual method through an open delegate the same as the normal case instead of the OPEN_VIRTUAL case.

* [amd64] Fix the return value mapping in gsharedvt calls, the return address might be in different registers in the caller and callee.

* [runtime] Always initialize del->method_ptr even if interp_method is set, JITted code makes calls through it in mixed mode.

* Add a test for open delegates and gsharedvt.

* Increase nrgctx trampoline count, its needed by dynamic-method-churn.exe in full-aot-interp mode.
2019-11-22 20:34:14 +01:00
Jonathan Chambers cc137237d8 Replace embedded libgc with Unity fork of recent Boehm (bdwgc) (#16832)
* Initial commit to migrate libgc to bdwgc.

* Fix submodule url

* Don't force Boehm as runtime wrapper. Was just for testing locally.

* Build bdwgc as single object file. Helps with performance.

* Bump bdwgc submodule.

* Attempt to fix windows MSVC based build.

* Remove any references to GC_INSIDE_DLL as we manually managed threads on Windows.

* Allow building boehm on Windows amd64.

* Allow building boehm with msvc.

* Bump bdwgc to fix line endings

* Use LF for sh, am, m4, and ac files in bdwgc

* Bump bdwgc & libatomic_ops with fix for cygwin

* Bump bdwgc to fix mono-boehm being generated as libtool wrapper script.

* Link the static boehm library.

* Revert "Link the static boehm library."

This reverts commit 1f90d81d08308a61c890743cd79d8f6bb791bc99.

* Use --export-all-symbols on cygwin/mingw to fix issues with boehm causing mono symbols not to be exported.

* Fix
2019-11-22 18:03:23 +01:00
Filip Navara 0fed03ed63 Fix InternalGetHashCode for boehm/null GC (#17859)
It was unintentionally shifting the address to left instead of right. It should be shift right to get rid of zeroes from the alignment.
2019-11-22 07:51:43 -05:00
Alexander Köplinger 5fedc42ccf Fix automake warning 2019-11-22 13:18:10 +01:00
Kenneth Pouncey 9e1d59b8cc Remove unused GetHttpMessageHandler from WebAssembly.Net.Http.
- Remove linker.xml from project
2019-11-22 13:12:17 +01:00
Zoltan Varga ecd67a91c4 [wasm] Add aot+netcore support. (#17798)
* [wasm] Compile corelib as 32 bit.

* [wasm] Add a netcore cross compiler.

* [wasm] Add netcore+aot support.

* [aot] Load the dedup module lazily instead of at startup.

The previous version didn't work on netcore because it couldn't resolve references to corlib etc.
since they were not yet registered in the root domain at the time of loading.

* Add more icall trampoline signatures.

* Add more netcore pinvokes.

* Fix the build.

* Add more icall trampoline signatures.

* Add an --embed-file option to the packager.

* Add more netcore pinvokes.

* [interp] Return FALSE for IsDynamicCodeCompiled.

* Add a netcore project and targets for running BenchmarkDotNet.

* Fix pinvoke tables.

* Add missing files.

* Fix make clean.

* Add a comment.

* Revert "Fix pinvoke tables."

This reverts commit 998065e77614b7e621d2873510aabc3930669ca9.

* Make xunit-runner into a dotnet project. Add a netcore version.
2019-11-22 12:42:55 +01:00
Egor Bogatov 6a5c44b15e [netcore] Run tests with Interpreter (#17862)
* Run tests with interp and llvm

* fix build

* Run tests with llvm

* Add a few tests to rsp for LLVM
2019-11-22 09:14:23 +01:00
Kenneth Pouncey 202cb6a648 Add more descriptive message to the PlatformNotSupportedException (#17864) 2019-11-22 08:40:30 +01:00
Jay Krell dadc3d3117 Remove handles/MonoError from Mono.RuntimeGPtrArrayHandle. (#17806) 2019-11-21 14:15:29 -05:00
Jo Shields 9e00330af3 Stop referencing files from Mono BCL in Netcore System.Private.CoreLib (#17866) 2019-11-21 19:48:00 +01:00
Bernhard Urban-Forster 058d157648 [interp] fix array_element_size intrinsic (#17857)
[interp] fix array_element_size intrinsic

`mono_class_array_element_size` gives us the size of the provided MonoClass if it would be an array element. But here we want the element size of a given array's MonoClass. That's what `mono_array_element_size` is returning.

This leads to all kind of weird crashes otherwise, specifically here:
https://github.com/mono/mono/blob/2c20649539ac16e069a65f2a750c793eb341e50f/netcore/System.Private.CoreLib/src/System/Array.Mono.cs#L64

Which is then used later to compute the size to memset in order to clear the content of an array. If it's larger than it should be, then this will cause memory corruption. For example this would crash eventually:

```csharp
using System;
using System.Collections.Generic;

namespace HelloWorld {
    class Program {
        static void Main(string[] args) {
            for (int j = 0; j < 0x1000; j++) {
                var d = new Dictionary<string, string> ();
                for (int i = 0; i < 197; i++)
                    d.Add (i + "", i + "foo");
                d.Clear ();
            }
        }
    }
}
```

Thanks to @EgorBo for reporting.
2019-11-21 11:56:03 +01:00
Alexander Köplinger b6e4ddd73c [metadata] Remove native threadpool from netcore build (#17856)
We use the managed threadpool there.
2019-11-21 10:01:39 +01:00
Egor Bogatov 2c20649539 [llvm] Recognize GEP (#17844)
* initial impl

* improve jit

* fix copy-paste

* disable for non-netcore

* clean up
2019-11-20 21:25:24 +01:00
Zoltan Varga 4961d411e7 [interp] Move the freeing of interp method info into a callback. (#17852)
[interp] Move the freeing of interp method info into a callback.
2019-11-20 19:56:09 +01:00
Egor Bogatov 27e6e812f1 enable gss on android (#17838) 2019-11-20 10:53:14 -05:00
Alexander Köplinger 0396037d31 [debugger-agent] Fix CMD_VM_ALL_THREADS returning wrong value due to unitialized variable (#17847)
`remove_gc_finalizing` wasn't initialized so its value is undefined.
The `count_thread_check_gc_finalizer()` function only sets it in some cases so we could end up with the variable having an undefined (and probably not 0) value.
This resulted in the returned thread count from the debuggee being wrong because we'd decrement `count` even though we shouldn't.

Regression from https://github.com/mono/mono/pull/15618
2019-11-20 08:28:58 +01:00
dotnet-maestro[bot] a6db160596 [master] Update dependencies from dotnet/arcade dotnet/core-setup dotnet/corefx (#17690)
* Update dependencies from https://github.com/dotnet/arcade build 20191102.1

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19552.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19552.1

* Update dependencies from https://github.com/dotnet/core-setup build 20191104.1

- Microsoft.NETCore.App - 5.0.0-alpha.1.19554.1

* Update dependencies from https://github.com/dotnet/corefx build 20191103.8

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19553.8

* Update dependencies from https://github.com/dotnet/arcade build 20191108.11

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19558.11
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19558.11

* Update dependencies from https://github.com/dotnet/core-setup build 20191109.5

- Microsoft.NETCore.App - 5.0.0-alpha.1.19559.5

* Update dependencies from https://github.com/dotnet/corefx build 20191109.6

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19559.6

* Update dependencies from https://github.com/dotnet/arcade build 20191117.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19567.2
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19567.2

* Update dependencies from https://github.com/dotnet/core-setup build 20191114.1

- Microsoft.NETCore.App - 5.0.0-alpha.1.19564.1

* Update dependencies from https://github.com/dotnet/corefx build 20191113.6

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19563.6

* Use NETCoreApp version 5.0.0-alpha.1.19563.3

Later versions have an issue and the new dotnet/runtime assets aren't ready yet.

* Disable failing tests

* Fix merge error
2019-11-19 16:47:57 +01:00
Steve Pfister 0c3ffb9cc9 Fixes https://github.com/mono/mono/issues/15805 at least in terms of what may be making it crash. (#17270)
Adds a null check around the sslStream before trying to dispose.
2019-11-19 14:23:51 +01:00
Zoltan Varga b8fe43da3e [interp] Add some missing netcore intrinsics. (#17782) 2019-11-18 13:55:15 +01:00
Steve Pfister 0269f7b479 Bump corefx to pick up https://github.com/mono/corefx/pull/370 (#17758)
Backport of https://github.com/dotnet/corefx/pull/34560

Added HAVE_LCHFLAGS & HAVE_STAT_FLAGS to configure.
2019-11-18 12:13:16 +01:00
Filip Navara e2ccdac3f4 [llvm] Add support for LLVM JIT on ARM64 (#17827)
* [llvm] Add support for LLVM JIT on ARM64

* Fix tabs
2019-11-18 00:24:11 +01:00
Jérôme Laban 965efade84 Update emscripten to 1.39.3 (#17816)
Includes updates for https://github.com/emscripten-core/emscripten/issues/9562 and side modules.
2019-11-16 13:59:28 +01:00
Dotnet-GitSync-Bot 6785b27567 Mirror changes from mono/runtime (#17803)
It looks like the mirror didn't fully quiesce prior to snapping coreclr/corefx for the runtime consolidation.  As a result the libraries build is breaking.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-16 11:27:32 +01:00
Nikolay Sivov 18dd48cad8 [mini] Fix NULL pointer crash in mono_decompose_vtype_opts(). (#17801)
* [mini] Fix NULL pointer crash in mono_decompose_vtype_opts().

All other call sites for mono_type_size() are already passing non-null pointer there.

* [mini] Rename variable dummy -> align.
2019-11-15 17:56:55 +01:00
Marcos Cobeña Morián 92dd4d3883 [Wasm] Forced filesystem creation (#17789)
* Forced filesystem creation

* [Wasm] Added new hello-io sample
- Goal is testing file preloading through System.IO
- Filesystem is now always forced to support later file preloading
- build-io-sample target showcases such

* Added --enable-fs flag to packager.exe

* Update packager.md
2019-11-15 15:24:50 +01:00
Jan Kotas 3ceecb8db0 Fix build breaks
Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
Carlos Sanchez Lopez d3fbf4a1d3 Fix NetStandard issue in System.IO.FileSystem.AccessControl in 5.0 (#42546)
Fix NetStandard issue in System.IO.FileSystem.AccessControl

We built the fix incorrectly so that it would only apply for netcoreapp3.0 but customer needs it on netstandard2.0 (desktop + core).  Customer impact is that they’ll see a PlatformNotSupported exception rather than the new API.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
Stephen Toub 00b0170bdc Fix StyleCop rule SA1129 ("Do not use default value type constructor") (#42531)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
Tanner Gooding c93801d458 Adding tests for the new apis to convert between S.Numerics and S.R.Intrinsic vectors (#27481)
* Updating Vector128.AsVector3 to have a functioning implementation

* Adding test template metadata covering the new methods for converting between S.Numerics and S.R.Intrinsics

* Regenerating the existing tests

* Generating the new Vector conversion tests

Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
Emmanuel AndréandStephen Toub 5645032fc6 Add span-based CopyTo and CopyToAsync methods (dotnet/coreclr#27639)
* Add span-based CopyTo and CopyToAsync methods

* Update according to feedback

* Add span-based CopyTo overrides for MemoryStream

* Improve span-based CopyTo arguments validation

To avoid code duplication

* Update according to second review

Stream API is changed

* Resolve InternalReadSpan/Memory inlining

* Refactor ValidateCopyToArgs

* Update according to third review

* Update after fourth review

* Override span CopyTo for UnmanagedMemoryStream

* Apply suggestions from code review

Co-Authored-By: Stephen Toub <[email protected]>

* Update after fifth review

* Add cross sync/async support for span-based CopyTo

* Call sync action directly in async context

* Rework cross sync/async support for span-based CopyTo

Co-Authored-By: Stephen Toub <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
John adcaf88db0 Fix Vector128 and Vector256 WithUpper documentation (dotnet/coreclr#27274)
* Update Vector128.cs

* Update Vector256.cs

* Update Vector128.cs

* Update Vector128.cs

* Update Vector256.cs

* Update Vector128.cs

* Update Vector256.cs

Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
Elinor Fung 1f2f9b929b Add tracing for handling of dependencies for Assembly.LoadFrom (#27833)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
Elinor Fung 3242b5f354 Add tracing for Resolving/AssemblyResolve event handler invocation (#27788)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
ts2do 35d94dc8ff Address bugs in BigInteger (dotnet/coreclr#27280)
* Method Add(ref BigInteger lhs, uint value, ref BigInteger result) would store most of the result blocks into lhs instead of result.
* Method ShiftLeft(ulong input, uint shift, ref BigInteger output) with a shift argument exceeding 32 would generally compute the higher blocks incorrectly.
* Multiply(ref BigInteger lhs, uint value, ref BigInteger result) would not set result._length in some cases.
* IsZero() would incorrectly return false for non-canonical zeros with _length > 0.

Fix:
* Inline Add(ref BigInteger, uint, ref BigInteger) into Add(uint).
* Inline ShiftLeft(ulong, uint, ref BigInteger) into Pow2.
* Inline ExtendBlock and ExtendBlocks into Pow2.
* Properly handle 0 in SetUInt32 and SetUInt64.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
Stephen Toub 2a108e958f Use Stream's BeginReadInternal from FileStream (dotnet/coreclr#27737)
FileStream has two modes, decided upon at construction time.  When it's created in non-async mode, the Read/WriteAsync methods end up queueing work items to invoke the synchronous Read/Write methods.  To do this, the base methods on Stream delegate to Begin/EndRead/Write (since they were around first) and then the resulting IAsyncResult is wrapped.  However, Stream has an optimization that checks to see whether the derived stream actually overrides Begin/EndXx, and if it doesn't, then it skips using those and goes straight to queueing a work item to Read/Write.  However, FileStream does override those, but when it delegates to the base implementation because it's in non-async mode (rather than because it's a type derived from FileStream), going through Begin/EndXx is just unnecessary overhead.  So, in the right circumstances, we can call to Stream's special helper instead.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-15 13:29:04 +01:00
Zoltan Varga 25b7e6bd42 [runtime] Add MONO_EMPTY_SOURCE_FILE to a couple of files. (#17795)
* [runtime] Add MONO_EMPTY_SOURCE_FILE to a couple of files.

* Fix a typo.

* Revert unrelated changes.
2019-11-15 09:04:35 +01:00
Vsevolod Kukol 805c7f5436 [MacSDK] Bump xamarin-gtk-theme.py to latest revision from private bockbuild (#17785) 2019-11-14 09:27:33 +01:00
Jay Krell 19a44cd32b Remove handles from System.Diagnostics.Debugger. (#17713)
* Remove handles from System.Diagnostics.Debugger.
memset (&x, 0, sizeof (type)) to memset (&x, 0, sizeof (x)).

* Bump API snapshot submodule
2019-11-14 08:18:02 +01:00
Zoltan Varga 1d81534d27 [interp] Add some inline checks from the JIT. (#17784) 2019-11-13 22:34:01 +01:00
Zoltan Varga a0fcc29d5d [runtime] Fix some handle usage in native-library.c (#17781) 2019-11-13 18:12:09 +01:00
Jay Krell 73431403c7 Remove handles from ves_icall_System_Array_CanChangePrimitive. (#17708)
Remove handles from ves_icall_System_Array_CanChangePrimitive.
2019-11-13 17:55:52 +01:00
Thays Grazia dd18ec40dd [debugger] Assert when async debug a generic method (#17727)
* When we try to call a method to get the async_id to do an async debug and we are trying to do this in a generic method like this:

async Task<T> ExecuteAsync_Broken<T>()
 {
            await Task.Delay(2);
            return default;
  }

We need to inflate the generic type before call the method or we will get the error:  Could not execute the method because the containing type 'System.Runtime.CompilerServices.AsyncTaskMethodBuilder1[T_REF]’, is not fully instantiated.

Fixes #17549
Fixes #17569
2019-11-13 16:29:33 +01:00
imhameed fe0f824db5 [llvm] Use explicit null checks with LLVM. (#16954)
* [llvm] Use explicit null checks with LLVM.

When the LLVM backend is used for a method, explicit null checks will
unconditionally be used at the mini IR level. We had previously used
implicit null checks at the mini IR level combined with llvm-volatile
loads and stores to avoid mis-optimization of the generated code.

During AOT compilation, LLVM's `ImplicitNullChecks` pass is enabled.
This conservatively elides these explicit null checks. This pass only
modifies branches tagged with `make.implicit` metadata.

Null check branches are now tagged with `make.implicit` metadata, with
three exceptions:

1. For platforms with backends that do not support zero page fault
handling, null check branches are not tagged with `make.implicit`.

2. This commit also adds a `MONO_DEBUG` option:
`llvm-disable-implicit-null-checks`. When it is enabled, null check
branches are not tagged with `make.implicit`.

3. This commit alters the behavior of the `explicit-null-checks`
`MONO_DEBUG` option. Enabling `explicit-null-checks` also implies
`llvm-disable-implicit-null-checks`, because this option is documented
(e.g. in https://www.mono-project.com/docs/debug+profile/debug/) to
completely disable signal/seh-based null checks.

* Add llvm-disable-implicit-null-checks to the MONO_DEBUG help string.

* Add llvm-disable-implicit-null-checks to mono.1.

* Don't tag null checks in EH regions with `make.implicit`.

This relocates the logic formerly used to guard individual LLVM-level
loads and stores with explicit null checks inside EH regions.

* Use atomic/volatile loads and stores for the terimation flag in thread-suspend-suspended.

LLVM was hoisting the load of and branch against `finished` out of
thread t1's loop, resulting in an infinite spin.

* Use ImplicitNullChecks with LLVM JIT.

* Suppress emission of the .llvm_faultmaps section.

Bump external/llvm to release_60
(7a8dc89adbe7e123220e070a527e096ee91e66d5).

* [ci] use LLVM built from repository
2019-11-13 01:35:44 +01:00
Zoltan Varga eaf895f2d0 [wasm] Change netcore support to use a prebuilt corefx runtime. (#17773)
* [wasm] Change netcore support to use a prebuilt corefx runtime.

* [wasm] Build and test netcore support on CI.

* [wasm] Disable netcore tests on CI for now.

* [wasm] Add an error check.

* [wasm] Add a linker exclusion.

* [wasm] Add netcore runtimes to the nupkg.
2019-11-13 01:30:09 +01:00
Filip Navara bd278dd00d Mirror changes from mono/corefx,coreclr (#17777)
* Rewrite the rest of the array non-generic fast paths in C# (#27703)

* Rewrite the rest of the array non-generic fast paths in C#

* Add missing resource string

* Use CorElementType and handle native ints to match the unmanaged implementation

* Avoid try pattern for Sort and Reverse

* Match the native implementation more closely

Signed-off-by: dotnet-bot <[email protected]>

* Rewrite Enum.CompareTo in C# (dotnet/coreclr#27792)

* Rewrite Enum.CompareTo in C#

* Handle floating point too for match the existing native implementation

Signed-off-by: dotnet-bot <[email protected]>

* Remove unused argument from GetRegionDisplayName (dotnet/coreclr#27806)

* Remove unused argument from GetRegionDisplayName

* Address race conditions in CultureData

While most of the race conditions in this file are benign, in these cases, a thread could end up returning an intermediate value due to multiple potential writes to the same field.

Signed-off-by: dotnet-bot <[email protected]>

* Fix StyleCop rule SA1129 ("Do not use default value type constructor") (#27716)

Will enable the rule in corefx once these changes have propagated.

Signed-off-by: dotnet-bot <[email protected]>

* Remove non-shared Enum.CompareTo/InternalCompareTo implementation, add new Array icalls used by shared code
2019-11-12 18:46:00 +01:00
Bernhard Urban-Forster 4728cec01f [llvm] use multiple cores to build llvm if ninja is not available (#17778) 2019-11-12 18:45:45 +01:00
Jo Shields 8bceb40878 Move zlib to its own directory, and re-enable subdir-objects
This has the following benefits:

* Clearer structure for mirroring
* Slight build time improvement on bundled zlib use (as it only builds once)
* Removes pages of subdir-objects spew from autogen
2019-11-12 09:31:08 +01:00
abrevet-dev 8683fa6db7 [WinForms] Fix #10559 In MaskedTextBox wrong Lines value when Mask setted (#17660)
[WinForms] Fix #10559 In MaskedTextBox wrong Lines value when Mask se…





<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-11-12 01:55:53 +01:00
abrevet-dev 2b4801d9f1 [WinForms]: Fix #17546 Fix TabPage position when enabling MultiLine (#17670)
[WinForms] Fix TabPage position when enabling MultiLine

Fixes #17546
2019-11-12 00:15:51 +01:00
abrevet-dev 61811075ca [WinForms]: Fix #16632 special values (-1 and -2) of ListView Column header Width was not handled when using List.View. (#17669) 2019-11-11 23:00:45 +01:00
abrevet-dev 9eb0bcae57 [WinForms] Fix #12249 scroll orientation was not defined in ScrollEventArgs (#17662)
* [WinForms] Fix #12249 scroll orientation was not defined in ScrollEventArgs of ScrollBar.cs

* [WinForms] Fix 12249 scroll orientation was not defined in ScrollEventArgs of DataGridView.cs
2019-11-11 22:59:53 +01:00
Jo Shields c256fc86b6 Delete some LLVM test cases from make dist (#17772)
Many of the tests from the llvm-project monorepo cause problems to `make dist`
2019-11-11 17:42:51 +01:00
Alexis Christoforides 722c6f7dd5 [netcore] Complete Monitor.LockContentionCount implementation (#17719)
* [netcore] Complete Monitor.LockContentionCount implementation

Fixes https://github.com/mono/mono/pull/16538
2019-11-11 13:03:03 +01:00
Jan Kotas 594bbbef25 Relax visibility
Signed-off-by: dotnet-bot <[email protected]>
2019-11-10 09:29:18 +01:00
Marek Safar d90030d273 Fixes build 2019-11-09 20:45:42 +01:00
Ryan Lucia 9664df7eb3 Move AssemblyLoadContext.GetResolvedUnmanagedDll to shared (#27775)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-09 20:45:42 +01:00
rob313663 e46f29313d Fixed typos in comments. (dotnet/coreclr#27789)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-09 20:45:42 +01:00
Joseph Musser 5bf661d7f9 StackTrace.GetFrames should return an array of non-nullable frames (#27787)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-09 09:37:25 +01:00
Levi Broderick ae02b6677b Improve Encoding.UTF8.GetString / GetChars performance for small inputs (#27268)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-09 08:13:11 +01:00
Alexander Köplinger f9b3b5276d Fix llvm path in CODEOWNERS file 2019-11-09 00:44:57 +01:00
Alexander Köplinger ed2d5f69e0 [netcore] Fix RuntimePropertyInfo.GetValue() in FullAOT scenarios (#17757)
It tried to use dynamic codegen which is not available in FullAOT.
We can use the `RuntimeFeature.IsDynamicCodeSupported` to check for this, added a JIT intrinsic which returns false in FullAOT.

Used a linker friendly way to check for TypeBuilder by adding an `internal virtual IsTypeBuilder` method in the `Type` class which returns false, and overwrote it in `TypeBuilder`.
2019-11-09 00:33:00 +01:00
Zoltan Varga 73b50890cc [wasm] Bump emscripten. (#17748)
* [wasm] Bump emscipten to 1.39.2.

* Disable some code in libtest.c which causes emscripten to fail.

* [wasm] Source emscripten env before make install as well.
2019-11-08 14:43:32 -05:00
Nathan Ricci 5b0a822afb Implement GC.GetGCMemoryInfo (#17607)
Implement the GC.GetGCMemoryInfo API.
2019-11-08 13:58:37 -05:00
Ryan Lucia d5b6cf33b3 [loader] Unmanaged library refactoring and NativeLibrary implementation (#17369) 2019-11-08 13:42:56 -05:00
Ryan Lucia 68d142912d [netcore] Run individual CoreCLR test suites (#17753)
This is implemented in a lazy way for convenience when manually testing until the tests are wired up to xunit
2019-11-08 13:14:06 -05:00
Alexis Christoforides 23f2baa71e [merp] Remove extraneous waitpid invocation (#17723)
The extraneous call basically guarantees that the call right after will fail. Fixes merp stating that its process has failed when it hasn't.
2019-11-08 11:40:04 -05:00
Jo Shields 3948a065af Merge pull request #17749 from directhex/dotnet-llvm-monorepo
[LLVM] Change llvm submodule to dotnet-org fork of official LLVM git repo
2019-11-08 10:42:20 -05:00
lateralusX fad91a1c1e Fix Windows LLVM build using new repository structure. 2019-11-08 09:21:30 -05:00
Dotnet-GitSync-Bot 759a8c1847 Mirror changes from mono/corefx,coreclr,corert (#17761)
* Add EventWaitHandle creation extension method that takes an ACL (#42213)

* Add EventWaitHandle creation extension method that takes an ACL

* Call OpenExisting, add basic unit tests, move MAX_PATH in csproj for all Windows platforms, ensure same exceptions are thrown in both netcore and netfx.

* Address suggestions: using for the created handle, simplify try finally, merge methods, remove an unnecessary Debug.Assert

* simplify using, reorganize PInvokes a bit, let VS format resx as it expects it, remove BOM from csproj

* Add more unit tests

* Save basic access rights in a constant, generate name randomly

* Use FullControl (EVENT_ALL_ACCESS); update unit tests to use EventWaitHandleRights

* Apply suggestion of creating an EWH, then replacing its SWH.

* Remove using causing chaos, add more unit tests, remove null string unit test.

* spacing

* Address comments

* Remove unnecessary checks/exceptions, update unit tests

* Fix netfx x86 ut failure - different exception for mode validation.

* Small documentation fix

* Remove documentation for exception thrown with null security

* more documentation fixes

* New file for unit tests

* Dispose and remove windows only attributes in tests

* suggestion to not use var

* Remove duplicate resx after merge

* Readd cs files lost during merge

* Remove resx modification since it was untouched for this PR

* Address test comments

Signed-off-by: dotnet-bot <[email protected]>

* Move NativeLibrary.Free null check to managed (dotnet/coreclr#27744)

Signed-off-by: dotnet-bot <[email protected]>

* Arm64: Add S.P.CoreLib instrinsics UnzipEven and UnzipOdd (#27731)

Signed-off-by: dotnet-bot <[email protected]>
2019-11-08 07:11:13 -05:00
Tamar Christina 771b5fb18d Arm64: Update S.P.CoreLib for ZipLow and ZipHigh (dotnet/coreclr#27730)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-08 11:01:17 +01:00
Carlos Sanchez Lopez 229d3cc097 Add Semaphore creation extension methods that take an ACL (#42377)
Approved API Proposal: #41662

Description
We don't currently have a way to create a Semaphore with a given ACL in .NET Core. We can modify the ACL, but it would be more secure to have the proper ACL on the object from the start.

Customer impact
Before this change, customers had to create a Semaphore, then set its ACLs. This presents a few problems:
- Potential security hole as semaphores can be accessed between creation and modification.
- Porting difficulties as there isn't a 1-1 API replacement
This change addresses those problems by adding a new extension method that allows creating a Semaphore and ensuring the provided ACLs are set during creation.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-08 01:59:07 +01:00
Zoltan Varga c0a9d6bf76 [aot] Improve the aot mangler a bit, handle bool/char as a primitive type and avoid emitting a System prefix. (#17739) 2019-11-07 18:18:12 -05:00
Tanner Gooding 8637912a99 Updating NumberToFloatingPointBitsSlow to handle the remaining parsed fractional digits being zero. (#27688)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-07 23:39:21 +01:00
Jo Shields 4d579d00ff Bump LLVM submodule 2019-11-07 15:52:56 -05:00
Tamar Christina b924ffa5e0 Arm64: Add S.P.CoreLib for AddV. (dotnet/coreclr#27663)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-07 21:47:22 +01:00
Ryan Lucia 2c22d0de2e [netcore] Propagate ALCs through reflection functions (#16949)
* [reflection] Pass assembly load context through mono_reflection_get_type_with_rootimage

The entry points are mono_reflection_type_from_name_checked and
mono_reflection_get_type_checked which for now pass in an ambient ALC, but
should be updated to take an ALC argument.

Internally mono_reflection_get_type_with_rootimage is recursive through a half
dozen helper functions which all get an ALC argument too.

The principle place where the ALC is used is in
_mono_reflection_get_type_from_info which passes it to
mono_assembly_loaded_internal and to replace the call to mono_assembly_load by
a direct call to mono_assembly_request_byname with an explicit ALC set in the
request.

* Mark mono_assembly_load as external only

* Pass an alc through non-static reflection functions

* Fix usage in wasm debugger

* Relax assertions due to wasm
2019-11-07 15:02:23 -05:00
Marcos Cobeña Morián 8cc0402967 Enabled --preload-files without AOT (#17732) 2019-11-07 15:00:36 -05:00
Jo Shields fe69f5b699 Fix .gitmodules typo 2019-11-07 14:03:06 -05:00
Jo Shields c1c483cef8 LLVM changes for SDKs 2019-11-07 12:16:29 -05:00
Jo Shields d0d779b8d9 Update AzDo pipeine for new LLVM location 2019-11-07 12:09:58 -05:00
Alexander Köplinger 71b78536ad [sdks] Add xunit to iOS test runner and add results reporting (#17744)
- Allows the on-device runner to work with the xunit framework in preparation for netcore.

- Added a simple UI to show the test run progress

- Report the test result XML back to the host so we can process it on Jenkins/AzDO
2019-11-07 18:09:51 +01:00
Jo Shields b61263e994 [llvm] redirect from mono llvm-mirror fork to dotnet llvm-project fork 2019-11-07 12:03:29 -05:00
Jo Shields 9e6b57ce5a delete old llvm 2019-11-07 11:47:32 -05:00
Aleksey Kliger (λgeek) 2c56ac54c0 [profiler] Fix log profiling of native to managed wrappers (#17740)
* [profiler] Add test case for pinvokes and reverse pinvokes

* [profiler] Fix crash in native to managed wrappers

When we call back to managed from a pinvoke, we're in GC Safe mode and the
profiler instrumentation is inserted in the wrapper before it does the
transition to GC Unsafe.  So we need an extra transition before the profiler
calls its locking functions

Fixes https://github.com/mono/mono/issues/17687

* [coop] Mark internal GC Unsafe functions with MONO_PROFILER_API

Allow the profiler to transition to GC Unsafe mode

* [profiler] ptestrunner.pl fix profiler modules directory

we used to specify mono/mini/.libs but that's not where the profiler plugins live, they're in mono/profiler/.libs.   We probably picked up the profiler plugins from the system Mono install.
2019-11-07 11:42:52 -05:00
Thays Grazia 4bdacea237 [embed] Assert when call mono_runtime_object_init (#17589)
* Fix assert when calling externally call mono_runtime_object_init, mono_object_get_domain, mono_string_to_utf8
* Adding samples/embed as unit-test
2019-11-07 11:22:25 -03:00
Carlos Sanchez Lopez 3c84633c7c Add Mutex creation extension methods that take an ACL (#42281)
Approved API Proposal: #41662

Description
We don't currently have a way to create a Mutex with a given ACL in .NET Core. We can modify the ACL, but it would be more secure to have the proper ACL on the object from the start.

Customer impact
Before this change, customers had to create a Mutex, then set its ACLs. This presents a few problems:

Potential security hole as mutexes can be accessed between creation and modification.
Porting difficulties as there isn't a 1-1 API replacement
This change addresses those problems by adding a new extension method that allows creating a Mutex and ensuring the provided ACLs are set during creation.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-07 12:27:50 +01:00
Elinor Fung 0886ddb3a0 Populate properties of AssemblyLoadStart/Stop events (dotnet/coreclr#27558)
* Populate properties of AssemblyLoadStart/Stop events
* Add tests for basic start/stop binder tracing events
* Add property for ALC of requesting assembly

Signed-off-by: dotnet-bot <[email protected]>
2019-11-07 09:54:23 +01:00
Jay Krell 7b4b5e72d9 Remove handles from ves_icall_System_Array_InternalCreate. (#17681)
Remove handles from ves_icall_System_Array_InternalCreate.

Also combine two allocas.
2019-11-07 07:36:07 +01:00
Zoltan Varga 0680073b87 [runtime] Fix locking in mono_get_seq_points (). (#17738)
Fixes https://github.com/mono/mono/issues/17737.
2019-11-06 19:50:59 -05:00
Johan Lorensson bda239f44c Switch away from Start-Process, Wait-Process in build.ps1. (#17730)
Running Start-Process, Wait-Process on msbuild.exe have showed a couple
of hangs in the build script. This is most likely due to msbuild.exe
spawned child processes (like compile servers) running longer than
spawned msbuild.exe process. Since there is no specific requirements
when spawning the process from build.ps1, switch to regular process
exec and LastExitCode.
2019-11-06 16:51:31 +01:00
Johan Lorensson 1a6c092019 Explicit update/init only LLVM BTLS repro on external MSVC build. (#17691)
Reduce the scope of git submodule update --init to only LLVM and/or BTLS
repositories when building external MSVC dependencies.
2019-11-06 16:51:14 +01:00
Marek Safar 965beadc1e [System.Private.CoreLib] Remove unused Array methods 2019-11-06 12:46:30 +01:00
Stephen Toub e506008ebb Add Span.Sort, and make Array.Sort span-based (dotnet/coreclr#27700)
* Add Span<T>.Sort

Shares existing Array-based implementation by changing that implementation to be span based.

* Additional work to enable span-based sorts

- Cleans up changes from the previous commit, e.g. corrects nullable annotations, removes TODOs, using GetRawSzArrayData instead of GetRawArrayData, etc.
- Passes spans around rather than spans+lo+hi.
- Deletes the native TrySZSort, preferring to use the managed implementation in all cases.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-06 12:46:30 +01:00
Bernhard Urban-Forster 29ba75c154 Bump Corefx (#17694)
* Bump Corefx

New commits in mono/corefx:

* mono/corefx@c44efe7297 [mono] limit DegreeOfParallelism to 16 (#369)

Diff: https://github.com/mono/corefx/compare/6e65509a17da898933705899677c22eae437d68a..c44efe7297f8e11cab157c7e96b998dc936d53b7

* another bump
2019-11-06 07:36:17 +01:00
Jay Krell 1e8e357831 Handles reduction -- 4 MERP functions. (#17711)
Handles reduction -- 4 MERP functions.
2019-11-06 03:56:10 +01:00
Jay Krell aa506ca1bb error_init reduction. (#17712) 2019-11-05 16:38:40 -05:00
JesperTreetopandStephen Toub 104abd7fe7 Prevent DivideByZeroException in EventCounter.ToString() (#27581)
* Prevent DivideByZeroException in EventCounter.ToString()

Maybe it should print something other than 0. Maybe "Mean" should be excluded. But at least with this it doesn't divide by zero. Ternary operator in interpolated string is not super readable; didn't know if making the code more descriptive would have performance implications.

* Update src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventCounter.cs

Co-Authored-By: Stephen Toub <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>
2019-11-05 21:18:22 +01:00
Ryan Lucia f477bce548 [loader] Skip the full pinvoke resolution process for __Internal (#17701) 2019-11-05 14:35:00 -05:00
Tanner Gooding 3d4f44d85c Fixing the return type of the ArmBase.ReverseElementBits methods in the PlatformNotSupported file (#27672)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-05 20:20:17 +01:00
Bernhard Urban-Forster 93b97d5582 [mini] Fix Coverity CID 1455161 & 1455162 (#17615)
* [mini] Fix Coverity CID 1455161 & 1455162

> Null-checking "ji" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

* do not rely on assert to guard ji-nullness.  refactor a bit
2019-11-05 19:09:32 +01:00
Johan Lorensson 6f73c2dab8 Fix MSVC intellisense for LLVM sources. (#17706) 2019-11-05 13:16:32 +01:00
Johan Lorensson 44e6226c31 Fix correct accumulated time for parallelized jobs in SGEN. (#17518)
* Fix correct accumulated time for parallelized jobs in SGEN.

Current implementation incorrectly accumulate time for scan jobs for
the follow metrics when running parallel minor GC:

time_minor_scan_major_blocks,
time_minor_scan_los,
time_major_scan_mod_union_blocks,
time_major_scan_mod_union_los

Commit fix so updates are atomic making sure values are correct in cases
where parallel minor GC is used.

* Implement 64-bit atommic add fallback in SGEN.
2019-11-05 01:57:06 -05:00
Nikolay Sivov 95743afa80 [mono] Fix ProcessExit handler argument. (#17680)
Problem was spotted with mono tracing hitting ProcessExit handler,
and crashing on first argument.
2019-11-05 01:56:43 -05:00
Egor Bogatov fdc6495a54 [netcore] Intrinsify Buffer.IsPrimitiveTypeArray (#17438)
* Improve IsPrimitive intrinsic

* Implement it for interpreter

* clean up

* clean up
2019-11-05 01:50:37 -05:00
Zoltan Varga ebb4598096 [wasm] Build the tests with --no-native-strip. (#17698) 2019-11-04 17:46:52 -05:00
Vlad Brezae b3b9960ed1 [interp] Use GetType instrinsic also on net4x (#17654)
We didn't do this because it had some issues when GetType was invoked through reflection. This issue would also be present with jit but, because jit doesn't use direct wrappers, the GetType call can't be intrinsified in that scenario. See https://github.com/mono/mono/pull/5350 for the context of the issue.
2019-11-04 12:58:38 -05:00
Dotnet-GitSync-Bot db49be3cbb Update only S.P.CoreLib for ReverseElementBits (dotnet/coreclr#27582) (#17695)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-04 12:55:57 -05:00
Egor Bogatov cf8495e2f7 [netcore] Copy Array.Clear impl from CoreCLR (#17411)
* Address feedback

* fix build error

* Fix has_reference usage in object.c

* Fix fallback impl

* Rename to ArrayHasReferences

* Rename to ObjectHasReferences

* Rollback to ArrayHasReferences

* Rename to ObjectHasReference

* remove redundant is_array variable

* ObjectHasReferences can accept any object

* undo changes in Program.cs

* undo changes in Program.cs
2019-11-04 12:48:04 -05:00
Filip Navara 07fa0bd3b4 Intrinsify Activator.CreateInstance<T> for value types with no ctor (#17688)
* Intrinsify Activator.CreateInstance<T> for value types with no ctor

* Fix failed test, address feedback
2019-11-04 12:40:13 -05:00
Zoltan Varga 929a8a7fd8 [jit] Allow Unsafe.As<TFrom, TTo> on gsharedvt types. (#17692) 2019-11-04 18:14:59 +01:00
Bernhard Urban-Forster 237f210ea2 [interp] use mask instead of bool expression (#17683)
Discovered by Coverity:
```
>>>     CID 1455205:    (CONSTANT_EXPRESSION_RESULT)
>>>     The expression "flag && 2" is suspicious because it performs a
        Boolean operation on a constant other than 0 or 1.
```
2019-11-04 15:56:46 +01:00
Alexander Köplinger 49d5c4d14d [sdks] Use Xcode 11.2 stable version for iOS/Mac SDKs
As requested by the xamarin-macios team.
2019-11-04 15:27:42 +01:00
Tarek Mahmoud Sayed 6630bcc67f Fix Buggy code in TimeZoneInfo (dotnet/coreclr#27591)
Although couldn’t reach the corner case cause executing the buggy code, the fix here is done according to the similar code in TimeZoneInfo which show the intention of the change

https://github.com/dotnet/coreclr/blob/97c582975eed3260ef21e0bcc55c8c86d1e3bec8/src/System.Private.CoreLib/shared/System/TimeZoneInfo.cs#L1638
https://github.com/dotnet/coreclr/blob/97c582975eed3260ef21e0bcc55c8c86d1e3bec8/src/System.Private.CoreLib/shared/System/TimeZoneInfo.cs#L1568

Signed-off-by: dotnet-bot <[email protected]>
2019-11-04 09:59:54 +01:00
Jan Kotas f3e30a0ad0 Delete two more FCalls (dotnet/coreclr#27640)
Signed-off-by: dotnet-bot <[email protected]>
2019-11-04 08:57:17 +01:00
Jan Kotas deb3115b15 Use simple Array.Copy overload where possible (dotnet/coreclr#27641)
The simple Array.Copy overload does not come with a performance penalty anymore.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-04 08:57:17 +01:00
Jan Kotas 6ecf9e87ba Consolidate *.Fast.cs (dotnet/coreclr#27644)
System.Memory OOB package that this split was originally done for does not exist anymore.

Signed-off-by: dotnet-bot <[email protected]>
2019-11-04 08:57:17 +01:00
Johan Lorensson c0e237b734 Mono NetCore Windows only build/test. (#17646)
Support for Windows Mono NetCore build/test wihtout any need for
cygwin/wsl/automake just MSBuild and MSVC. Windows build support mirror
technologies used by coreclr/aracade builds msbuild + powershell.

Windows only Mono NetCore build, makes a port of existing build.sh and
Makefile, implementing a build.ps1 and build.targets. So far full build
support + execution of corefx test suite is implemented. Other make file
rules can be added when needed.

MSVC build runtime seems to hits a couple of additional test failures
in corefx test suite that needs to be investigated further.

Building NetCore Mono on Windows can now be done without cygwin or wsl.
Build depends on regular VS install (or build tools), if xunit summary
is requested, python needs to be installed.
2019-11-04 08:55:36 +01:00
Egor Bogatov 137ffe8b7c [netcore] Improve Array.CreateInstance (#17673)
* Rewrite Array.CreateInstance

* Rewrite Array.CreateInstance

* Address feedback

* Convert the icall to NOHANDLES

* fix build errors, remove NOHANDLES

* Fix GC.KeepAlive usage

* Remove icall definition for GC.KeepAlive (it's no an icall)

* Fix failing tests (expect details in the AOORE)
2019-11-03 22:39:19 -05:00
Filip Navara 8131518bb1 [netcore] Improve default constructor lookup, (#17666)
* [netcore] Improve default constructor lookup, cache when no default constructor is found (common for struct)

* Address PR feedback
2019-11-03 18:28:32 +01:00
Levi Broderick 8700c04b02 Fix typo in Tuple.cs (dotnet/coreclr#27637)
Reported by https://github.com/dotnet/corefx/issues/42321

Signed-off-by: dotnet-bot <[email protected]>
2019-11-03 18:17:23 +01:00
Alexander Köplinger 4888c49c26 [netcore] Disable shared compilation for System.Private.CoreLib
There's a dotnet process hanging around which seems to lock the build when called from the SDKs Makefiles.
2019-11-03 15:43:40 +01:00
Alexander Köplinger 40c1cd3576 [netcore] Fix strong name key for System.Private.CoreLib
It's using the silverlight key: https://github.com/dotnet/coreclr/blob/34fe045a27e150bde7ee54e0d5f0df635922519d/src/System.Private.CoreLib/System.Private.CoreLib.csproj#L112
2019-11-03 15:43:40 +01:00
Alexander Köplinger d89b96a298 [netcore] Fix out of tree build for netcore/ folder 2019-11-03 15:43:40 +01:00
Jan Kotas ad385f98b3 Normalize trailing whitespaces (dotnet/coreclr#27626)
Normalize trailing whitespaces in frequently changing files (docs and sources)

Signed-off-by: dotnet-bot <[email protected]>
2019-11-02 16:51:03 +01:00
Bernhard Urban-Forster 62ee01b36b [interp] s/MONO_API_ERROR_INIT/error_init_reuse/g (#17650)
[interp] s/MONO_API_ERROR_INIT/error_init_reuse/g
2019-11-02 16:45:36 +01:00
Zoltan Varga 803c657b24 [jit] Call mono_class_setup_fields () before accessing field->offset. (#17667)
Fixes https://github.com/mono/mono/issues/17665.
2019-11-02 03:57:25 -04:00
Manuel de la Pena 36539ed67f [iOS] Match changes done in xamarin-macios in the SDK runtime. (#17664)
* [iOS] Match changes done in xamarin-maciosn in the SDK runtime.

* Address reviews.
2019-11-02 01:40:40 -04:00
Jay Krell 4b9dc08ac1 Move MonoError from managed wrappers to native wrappers. (#15894)
Move MonoError from managed wrappers to native wrappers.

Move MonoError from managed wrappers (ilgen) to native wrappers (C preprocessor).

Alternative to https://github.com/mono/mono/pull/15869.
Which says: Previously, we would emit a call to memset
since the struct is large (> 100 bytes). Only the error code
field needs to be initialized.
Which that PR and this PR both fix, in different ways.

In the past:
- This did not work due to a possible dependency on precise GC,
  interacting with what gets zeroed or not here.
  That is why I put it on the managed side.
  We'll see if that reproduces.
  (https://github.com/mono/mono/pull/11294/files#diff-efe0070415f3f0c0f24ed0221aa1962aR339
  external/coreclr/tests/src/CoreMangLib/cti/system/weakreference/weakreferenceisaliveb.exe.)

- Some indication that embedding API should expose MonoError
  and not set_pending_exception. This does not seem relevant
  presently, and the code seems better structured and
  more efficient this way. It can revisited if/when new public API
  is the dominant concern, or do it this way for these functions,
  and another way for actual public functions.
  (https://github.com/mono/mono/pull/11294#issuecomment-432443485)
2019-11-01 22:36:06 +01:00
Zoltan Varga e9d68e9485 [netcore] Cleanups. (#17661)
* [netcore] Remove the type_info field from RuntimeType, extend the TypeCache structure instead.

* [netcore] Remove some linker exclusions which are not needed.
2019-11-01 12:52:45 -04:00
Steve Pfister b9f185b74a Bump mono/corefx@6e65509 (#17631)
Pulls in PR https://github.com/mono/corefx/pull/368
2019-11-01 11:04:27 -04:00
Jo Shields 16d1a2e6f1 [System.Net.Http]: Bring HttpClient from CoreFX on monotouch and xammac. (#17628) 2019-11-01 10:26:08 -04:00
monojenkins a4790c892d [csproj] Update project files 2019-11-01 14:25:26 +00:00
monojenkins cc28706e58 Bump API snapshot submodule 2019-11-01 14:24:11 +00:00
Vlad Brezae 166fdf60b0 [interp] Handle remoting field access same as jit (#17641)
Doing this we avoid using slow ldrmfld in the common case of loading fields from instance methods, when we execute on the real object. We could do this also for strmfld but we need to track on the stack if the instance object is this, which is not worth the trouble.
2019-11-01 14:55:58 +02:00
Vlad Brezae 170d33c35b [interp] Optimize call path (#17623)
* [interp] Optimize void calls

By avoiding setting of retval

* [interp] Avoid computing param count for every call

* [interp] Remove wrong profiler check

From the times when interp had its own EH mechanism. We raise this event from mono_handle_exception_internal for interp.

* [interp] Remove profiling check code from method exit

We emit MINT_PROF_EXIT opcode when under profiler. Unify profiling enter/exit with tracing enter/exit since they are very similar.
2019-11-01 14:55:27 +02:00
Filip Navara 8aa3654de5 Lower min/max SSE operations on x64 (#17536)
Follow up on #17511.
2019-11-01 13:30:41 +01:00
Zoltan Varga dc8d55d446 [llvm] Fix a case where we treated the dreg of a store_membase instruction as a dreg, its actually the base reg. (#17648) 2019-11-01 03:43:42 -04:00
Steve Pfister 9566027142 Modify run-jenkins.sh to adapt wasm build for the OSX CI lane (#16785)
* Modify run-jenkins.sh to adapt wasm build for the OSX CI lane

* Round 2... Go

* Make ENABLE_WASM_DYNAMIC_RUNTIME conditional on non-OSX

* Add runtime-threads target

* Ignore 'multiple rules generate' on osx

* Fix typo

* Remove blank line

* Exclude CoreXml.Test.XLinq.FunctionalTests.EventsTests.EventsReplaceNodes.XElementReplaceNodes

* Revert "Ignore 'multiple rules generate' on osx"

This reverts commit 5010721bd710d6955aaee47aa7f49ad7845763fc.

* Check if OSX lane can follow general build flow
2019-11-01 01:44:50 -04:00
Stephen Toub 8b86349c2c Disable another static analysis rule (dotnet/corefx#42265)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-31 22:23:35 +01:00
Bernhard Urban-Forster 0be756d609 [threadpool] cache processor count (#17642)
On top of https://github.com/mono/corefx/pull/369 this improves the execution time of `System.Core-xunit` on Linux/ARM64 by 2x, so from:

```console
$ make -C mcs/class/System.Core run-xunit-test
[...]
=== TEST EXECUTION SUMMARY ===
   net_4_x_System.Core_xunit-test  Total: 48774, Errors: 0, Failed: 0, Skipped: 6, Time: 131.143s
```
to
```console
$ make -C mcs/class/System.Core run-xunit-test
[...]
=== TEST EXECUTION SUMMARY ===
   net_4_x_System.Core_xunit-test  Total: 48774, Errors: 0, Failed: 0, Skipped: 6, Time: 74.636s
```

This is only relevant for non-netcore. The CoreCLR folks just recently fixed something similar (thanks to Marek sharing this link): https://github.com/dotnet/coreclr/pull/27543
2019-10-31 22:08:14 +01:00
Vlad Brezae b484979aa9 [interp] Avoid emitting MINT_SAFEPOINT for every single call (#17625) 2019-10-31 16:49:16 +01:00
Jonathan Chambers 3648cb087b Avoid caching of System.dll image and types as they may be unloaded with appdomain. (#17602) 2019-10-31 10:13:01 -04:00
Zoltan Varga dff84a2464 [wasm] Fix xunit test ninja errors. (#17639)
* [wasm] Error out on duplicate assemblies in the packager.

* [wasm] Switch search path order to avoid duplicate references to assemblies.

* Copy all xunit binaries to test_lib_dir.

* Revert "Copy all xunit binaries to test_lib_dir."

This reverts commit b15b03c16b508c04dc6121196fddca0e6d949e2f.
2019-10-31 10:10:51 -04:00
Alexander Köplinger ca72deed17 Fix build 2019-10-31 14:36:53 +01:00
Ben Adams c9b7f767a8 Don't needlessly refresh proc count (dotnet/coreclr#27543)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-31 14:36:53 +01:00
Vlad Brezae 1d043a31e7 [interp] Fix interp logging (#17636)
* [interp] Don't print NOPs during cprop

They can become numerous and distracting.

* [interp] Fix mono_interp_print_code

Regressed after code_size was changed to byte count instead of short count.
2019-10-31 15:32:50 +02:00
abrevet-dev 6b3aa3a05b [WinForms] Change HotkeyPrefix default value in TabControlPainter.cs (#17579)
The default behavior on .NET Framework is _HotkeyPrefix.None_ when creating a _TabControl_ element (ampersands not escaped). 
If an user wants to override this behavior, he has to declare a _DrawItemEventHandler_ (with _DrawMode = OwnerDrawFixed_).

Fixes #16206
2019-10-31 13:48:12 +01:00
Stephen Toub a27aa7afd0 Update analyzer versions (dotnet/corefx#42249)
* Update analyzer packages to latest NuGet versions

* Fix new warnings

Signed-off-by: dotnet-bot <[email protected]>
2019-10-31 11:09:58 +01:00
Stephen Toub 6ae3360342 Clean up Uri.UnescapeDataString (dotnet/corefx#42225)
- Use string.IndexOf rather than an open-coded, unsafe loop.
- Avoid an unnecessary SequenceEquals at the end: we're only at this point if a `%` was found highlighting that something escaped was found.
- Use stack memory for smaller inputs if possible, to avoid unnecessary ArrayPool interaction
- Remove an unnecessary argument to a helper function.
- Fix ValueStringBuilder.Grow to only copy the contained data.

Signed-off-by: dotnet-bot <[email protected]>
2019-10-31 11:09:58 +01:00
Egor Chesakov a94dda5b5a Add BitwiseSelect (dotnet/coreclr#27430)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-31 08:51:46 +01:00
Zoltan Varga dc76a95aa9 [runtime] Add a --enable-minimal=threads configure option to disable threading support. Use it on wasm. (#17611) 2019-10-31 01:33:50 -04:00
Zoltan Varga 5811404e55 [eglib] Assert in g_strlcpy () if src/dest is NULL, instead of printing a warning. (#17507)
Related to https://github.com/mono/mono/issues/17283.
2019-10-30 16:07:44 -04:00
Martin Baulig 578e0df42f [System.Net.Http]: Bring HttpClient from CoreFX on monotouch and xammac. 2019-10-30 15:37:25 -04:00
Jo Shields 27921fbbd0 Rearrange System.Private.CoreLib for easier monorepo integration (#17517)
* [netcore] Move corlib around to match CoreCLR directory layout better

This is a prerequisite to making a sane migration of this whole
directory from mono.git to coreclr.git
2019-10-30 15:09:06 -04:00
Thays Grazia fffb1201bd [dim][regression] Explicit interface override (#17583)
* Precedence order:
-> Override interface method in class
-> Method in class
-> DIM
2019-10-30 14:47:15 -03:00
Egor Chesakov feca5e042d Add ComputeCrc32, ComputeCrc32C (dotnet/coreclr#27421)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-30 18:06:03 +01:00
Egor Chesakov 744d77ea7f Remove unsigned overloads of LeadingSignCount (dotnet/coreclr#27533)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-30 18:06:03 +01:00
Martin Baulig c6f71167a1 Bump CoreFX to pickup corefx PR #367 to fix #17133. (#17590) 2019-10-30 12:32:21 -04:00
Bernhard Urban-Forster 95cad24526 [interp] fix signature mismatch between jit<>interp for string constructor (#17595)
[interp] fix signature mismatch between jit<>interp for string constructor
2019-10-30 16:36:04 +01:00
Marek Safar e4c0b50dec [System.Private.CoreLib] Remove NativeRuntimeEventSource 2019-10-30 16:07:43 +01:00
Jan Kotas c9b88b45fe Move runtime specific methods out of the runtime partition
Signed-off-by: dotnet-bot <[email protected]>
2019-10-30 16:07:43 +01:00
Jay Krell 10ac2750e2 Inline TLS access. (#17119)
Inline TLS access.

This attempt differs from the previous in that the TLS accessor functions are presented to far less code, i.e. not to main.c, so their data references do not need to be resolved so much.

See https://github.com/mono/mono/commit/bffd4c6b99213a0b154d7efac9b0581df67775e8 etc.
2019-10-30 16:06:24 +01:00
Zoltan Varga 79f5e6c288 Remove some unused icalls. (#17612) 2019-10-30 10:08:50 -04:00
Filip Navara 3d397805d4 [netcore] Report errors on Windows CI (#17616)
* [netcore] Report errors on Windows CI

* Fix Windows build
2019-10-30 14:39:47 +01:00
Zoltan Varga 2823ac5d95 [wasm] Print a useful error message instead of a signature mismatch error on missing icalls. (#17600) 2019-10-30 00:04:15 -04:00
Dotnet-GitSync-Bot 3695d8704e Mirror changes from mono/coreclr,corefx (#17609)
* Revert removal of SuppressGCTransition from SystemNative_GetTimestamp() (#27473)

* Revert removal of SuppressGCTransition from SystemNative_GetTimestamp()

* Insert GC_POLL before statement with unmanaged call.

* JIT test for insertion of GCPoll

Signed-off-by: dotnet-bot <[email protected]>

* Add file creation method that takes an ACL (dotnet/corefx#42099)

Approved API Proposal: #41614
Related change for directory creation method that takes an ACL: #41834 -merged and ported to 3.1 Prev2

Description
We have extension methods in System.IO.FileSystem.AclExtensions that let the user get and set ACLs for existing files, but we do not have methods that create files with predefined ACLs.
.NET ACL (Access Control List) support is Windows specific. This change will reside inside the System.IO.FileSystem.AccessControl assembly.

Customer impact
Before this change, customers had to create a file or filestream, then set its ACLs. This presents a few problems:

Potential security hole as files can be accessed between creation and modification.
Porting difficulties as there isn't a 1-1 API replacement
Stability issues with background processes (file filters) can prevent modifying ACLs right after creation (typically surfaces as a security exception).
This change addresses those problems by adding a new extension method that allows creating a file and ensuring the provided ACLs are set during creation.
This change is expected to be backported to 3.1.

Signed-off-by: dotnet-bot <[email protected]>
2019-10-30 00:03:47 -04:00
Zoltan Varga 9adce0b632 [wasm] Fix build problems. (#17596)
* [runtime] Add a stub for MacOsIPInterfaceProperties::ParseRouteInfo icall on non-osx platforms to fix the wasm aot build.

* [wasm] Avoid generating invalid ninja build files if an assembly is specified on the command line and its also an implicit reference.

* Put back and ifdef.

* Fix the windows build.
2019-10-30 00:03:08 -04:00
Filip Navara d49d3efd5d Temporary build fix 2019-10-29 23:34:11 +01:00
Noah Falk 67ff64a381 Support large EventSource filter args (dotnet/coreclr#27500)
1. Fix NullReferenceException. When the filter args exceeded the
hard-coded size limit GetDataFromController would return data = null.
The code previously asserted that data was not null and triggered NRE
when it was. The fix correctly null checks the value instead of
asserting and uses an empty args dictionary in this case, the same as if
filter args had been empty to begin with.

2. ETW has always limited filter args to 1024 bytes but EventPipe has no
such restriction. When using DiagnosticSourceEventSource it can be
useful to specify a larger filter arg blob. I can't do anything about
ETW's restriction but there is no need for the runtime to force
EventPipe to be equally limited. The larger size also reduces the chance
that we need to hit the fallback path above causing filter args to be
ignored.

Signed-off-by: dotnet-bot <[email protected]>
2019-10-29 23:34:11 +01:00
Jan Kotas 8a03f60897 Cleanup (dotnet/coreclr#27502)
* Delete empty FireCustomerDebugProbe FCall

* Delete duplicate C++ compiler command line options

Signed-off-by: dotnet-bot <[email protected]>
2019-10-29 23:34:11 +01:00
Elinor Fung 17cef4c4f9 Basic infrastructure for binder tracing (dotnet/coreclr#27383)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-29 23:34:11 +01:00
Stephen Toub 249522036d Fix StreamReader to pass cancellation token into ReadBufferAsync (#27464)
ReadAsyncInternal is correctly passing its token into the two call sites where it delegates directly to the underlying stream, but in one place it calls through ReadBufferAsync, which is currently not defined to take a token.  Fix that, and pass the token through.

Signed-off-by: dotnet-bot <[email protected]>
2019-10-29 23:34:11 +01:00
Jan Kotas 447cb03399 Delete unnecessary abstraction from stubbed out SecurityElement (#27474)
The stubbed out SecurityElement implementation does not support extensibility that ISecurityElementFactory was designed for.

Signed-off-by: dotnet-bot <[email protected]>
2019-10-29 23:34:11 +01:00
Dan Moseley 9aeef958c6 Add path to not-absolute-path exception (dotnet/coreclr#27470)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-29 23:34:11 +01:00
Filip Navara db02ebc88b Fix building portable thread pool on Windows (dotnet/corert#7849)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-29 23:34:11 +01:00
Stephen Toub f26e73b49b Move PreserveDependencyAttribute to shared (dotnet/corefx#42174)
We need to use it in corelib, too.

Signed-off-by: dotnet-bot <[email protected]>
2019-10-29 23:34:11 +01:00
Bernhard Urban-Forster d274cfbacd [mini] Initial tiered compilation work (#17551)
[mini] Initial tiered compilation work

Enable it with `./autogen.sh --enable-experiment=tiered`.

Let's consider `Simple.cs`:
```csharp
using System.Runtime.CompilerServices;
using System;

public class Simple {
    public static void Main (string []args) {
        HotMethod ();
        Console.WriteLine ("cnt: " + cnt);
        HotMethod ();
        Console.WriteLine ("cnt: " + cnt);
    }

    static int cnt = 0;

    [MethodImplAttribute (MethodImplOptions.NoInlining)]
    public static void HotMethod () {
        for (int i = 0; i <= 1000; i++)
            cnt += i;
    }
}
```

```console
$ csc Simple.cs
$ MONO_LOG_LEVEL=debug MONO_LOG_MASK=tiered ./mono/mini/mono-sgen --trace=M:Simple:HotMethod --interp=-all Simple.exe
[0x10ec275c0: 0.00000 0] ENTER:i Simple:HotMethod ()()
Mono: tiered: queued Simple:HotMethod ()
[0x10ec275c0: 0.00010 0] LEAVE:i Simple:HotMethod ()(
Mono: tiered: patching 0x7fe855803224 with patch_kind=INTERP @ tier_level=0
Mono:   -> caller= Simple:Main (string[]) [{0x7fe85420df88} + 0x34 interp]  (0x7fe8558031f0 0x7fe855803258) [0x7fe85420c880 - Simple.exe]
Mono:   -> callee=Simple:HotMethod ()
Mono: tiered: patching 0x7fe8558031f2 with patch_kind=INTERP @ tier_level=0
Mono:   -> caller= Simple:Main (string[]) [{0x7fe85420df88} + 0x2 interp]  (0x7fe8558031f0 0x7fe855803258) [0x7fe85420c880 - Simple.exe]
Mono:   -> callee=Simple:HotMethod ()
cnt: 500500
[0x10ec275c0: 0.04093 0] ENTER:c Simple:HotMethod ()()
[0x10ec275c0: 0.04095 0] LEAVE:c Simple:HotMethod ()(
cnt: 1001000
```
Note the suffix after `ENTER:`
* `i` indicates it's executed by the interpreter
* `c` indicates it's a compiled method (JIT)

Another example:
```console
$ make -C mono/mini gshared.exe
$ ./mono/mini/mono-sgen --interp=-all --stats ./mono/mini/gshared.exe
Regression tests: 84 ran, 0 failed in Tests
[...]
Tiered statistics
Methods promoted                    : 68
```

It's a basic proof-of-concept for now. An incomplete list of future work items:

* Right now it only works for direct calls, need to expand it to virtual/interface calls.
* Calls of the JIT leading into the interpreter again can't be patched yet.
* Kind of related, no concept of versioning compiled methods does exist yet. The interpreter maintains its own table of "transformed" methods, however, when doing the transition from JIT->interpreter, the wrapper+interpmethod will end up in the JIT table. We need a way to have multiple JIT compilation results for the same MonoMethod exist.
* Investigate actual performance. We might have to optimize the interp<>JIT transition.
* Patching is racy. Need to make that atomic.
* All the FIXMEs in this PR



<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-10-29 22:36:01 +01:00
Alexander Köplinger 1340095581 [acceptance-tests] Bump mono/roslyn to get build fix
See https://github.com/mono/roslyn/commit/6bfcd4e770609a38b8523e83ce1ec943162f30bb
2019-10-29 20:27:09 +01:00
Zoltan Varga b0d966bd7a [eglib] Handle dli.dli_sname being NULL in g_module_address (). (#17592)
Should fix the warnings/assertions in g_strlcpy ().
2019-10-29 09:21:23 -04:00
Aniruddha Shastri 7f91972ded Support platform-independent newlines in line wrapping in Mono… (#17431)
* Add newLine parameter to StringCoda methods

* Update Options.cs to handle both kinds of newlines

* Add test to OptionSetTest

* Directly handle \r\n instead of using the TextWriter.NewLine
2019-10-29 13:53:41 +01:00
dotnet-maestro[bot] cddf90dda4 [master] Update dependencies from dotnet/arcade dotnet/core-setup dotnet/corefx (#17577)
* Update dependencies from https://github.com/dotnet/arcade build 20191027.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19527.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19527.3

* Update dependencies from https://github.com/dotnet/core-setup build 20191027.2

- Microsoft.NETCore.App - 5.0.0-alpha1.19527.2

* Update dependencies from https://github.com/dotnet/corefx build 20191027.5

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19527.5

* Update CoreFX.issues.rsp

GetGCMemoryInfo was moved to GCExtendedTests in https://github.com/dotnet/corefx/commit/d6dac9e6a7875862b91139334c8ec620f599cd4d.

GetTotalAllocatedBytes and GetAllocatedBytesForCurrentThread seem to pass now.
2019-10-29 12:51:33 +01:00
Zoltan Varga e4cc70f4b5 [runtime] Implement support for SuppressGCTransitionAttribute. (#17534)
Fixes https://github.com/mono/mono/issues/17367.
2019-10-28 10:59:52 -04:00
Johan Lorensson c5edcd1ed4 Additional and adjusted logging for parallel minor GC. (#17522)
* Additional and adjusted logging for parallel minor GC.

When running parallel minor GC we currently get incorrect timing
on several loggings and counters due to work being put on thread pool
and accumulated. This commit fix so that the logging is accurate
when running with and without parallelization. In parallel mode a new
logging is also added to show the accumulated split between major and los
remset scan jobs.

The counters time_minor_scan_remsets and time_minor_scan_roots are only
updated when not running parallel GC since they are not correct when
running parallel GC.

* Fix WASM build error.
2019-10-28 15:34:42 +01:00
Alexander Köplinger 450d474684 [netcore] Fix offsets generation when cross compiling
The offsets-tool.py uses some magic to map `typename` to `<underscore>typename` for looking up runtime types.
This caused issues on netcore because we aliased it to a different name.

To fix this let's keep the `_MonoInternalThread` name instead and just fix the one location where `_MonoThread` is used.
2019-10-28 13:57:17 +01:00
Alexander Köplinger fb7b075e49 [netcore] Don't load types in aot-compiler.c that don't exist in corefx
Fixes https://github.com/mono/mono/issues/16026
2019-10-28 13:57:17 +01:00
dotnet-maestro[bot] 6f04054541 Update dependencies from dotnet/corefx (dotnet/coreclr#27431)
* Update dependencies from https://github.com/dotnet/corefx build 20191024.13

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.13
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.13

* Update dependencies from https://github.com/dotnet/corefx build 20191024.14

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19524.14
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19524.14

* Update dependencies from https://github.com/dotnet/corefx build 20191025.6

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.19525.6
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha.1.19525.6

* Workaround https://github.com/dotnet/coreclr/issues/27465

Signed-off-by: dotnet-bot <[email protected]>
2019-10-27 17:54:12 +01:00
Alexis Christoforides db568c6fe0 [merp] Introduce a new 'dump mode' that allows different signal behavior when dumping (#17537)
* dump_native_stacktrace should always register the sigterm handler.

Cherry picked from the https://github.com/mono/mono/pull/17310

* [merp] Introduce a new 'dump mode' that allows different signal behavior when dumping

The primary reason for this is gaining the ability to interpret SIGTERM properly as a crashing signal when outside of 'dump mode', and as a utility signal during the 'thread summarizer' dumping process.
2019-10-26 18:48:40 -04:00
Aleksey Kliger (λgeek) 0e3caf00df [runtime] Unbalanced GC Unsafe transitions before shutdown (#17566)
When embedders call mono_runtime_quit or mono_jit_cleanup, we need to do unbalanced transitions to GC Unsafe, because after mini_cleanup runs we don't have GC thread states anymore and MONO_EXIT_GC_UNSAFE will assert.

* [runtime] Do an unbalanced GC Unsafe transition in mono_jit_cleanup

After mini_cleanup, we don't have GC thread states anymore because all that
stuff was cleaned up, so MONO_EXIT_GC_UNSAFE would assert

* [runtime] Mark mono_runtime_quit external only.

Runtime should use mono_runtime_quit_internal.

After we call the quit_function (aka mini_cleanup) we don't have any GC thread
states anymore because all that stuff got cleaned up.  So MONO_EXIT_GC_UNSAFE
can't work.
2019-10-26 18:45:35 -04:00
Ben Adams 2da4e54a7f Avoid mod operator when fast alternative available (dotnet/coreclr#27299)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-26 19:07:15 +02:00
Jay Krell 5f3446bd12 [cxx][x86] int/ptr casts (#17570)
[cxx][x86] int/ptr casts
2019-10-26 18:26:15 +02:00
Dotnet-GitSync-Bot c5e3ca90de Mirror changes from mono/coreclr (#17571)
* Use ValueStringBuilder instead of StringBuidler{Cache} in multiple places

Signed-off-by: dotnet-bot <[email protected]>

* Avoid unnecessary allocations in Exception.ToString

Signed-off-by: dotnet-bot <[email protected]>
2019-10-26 07:48:46 -04:00
Dotnet-GitSync-Bot fec907397d Mirror changes from mono/coreclr,corert,corefx (#17565)
* Update Corelib to include Stopwatch (dotnet/coreclr#27417)

* Update Corelib to include Stopwatch

* Delete HighPerformanceCounter

Signed-off-by: dotnet-bot <[email protected]>

* Share completed Task between Task and AsyncTaskMethodBuilder (#27437)

Signed-off-by: dotnet-bot <[email protected]>
2019-10-25 21:23:46 -04:00
Caleb Cornett 1801bdad6a Add --preload-file packager option 2019-10-25 14:53:15 -05:00
Leonard 4ec9bd03e5 Fixes #17190: SerializationException on ListViewItemCount (#17195)
* Fix issue #17190: SerializationException on ListViewItemCount

ListViewGroup doesn't (always) have a serialized member "ListViewItemCount".

This patch accounts for that and also adds support for the "ItemsCount"
property that upstream [1] seems to use.

Also items should be initialized regardless of the count, otherwise we get a NPE.

[1] https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Windows/Forms/ListViewGroup.cs#L144
2019-10-25 19:30:08 +02:00
Kenneth Pouncey 1bd76c6069 Spacing 2019-10-25 12:19:54 -05:00
Kenneth Pouncey f1a3f3c58d Add CompileFunction to Runtime that returns a WebAssembly.Core.Function
- The code passed to `CompileFunction` is not a function definition. Instead it must create and return a function instance.
- Solves the problem of accessing `Node.js` functionality as defining a JavaScript function executes in the global space and does not get `Node.js` access.
- Returning a function instance allows the function to initialize and maintain encapsulated state.
2019-10-25 12:19:54 -05:00
Jay Krell 893486638c [cxx] Compile mini-llvm.c as C++ if configure -enable-cxx. (#17558)
[cxx] Compile mini-llvm.c as C++ if configure -enable-cxx.

This is presently catastrophic, because of `MonoJitICallId` varying between C and C++, and therefore the layout of `MonoCallInst`.

Related to:
https://github.com/mono/mono/pull/17557

https://github.com/mono/mono/pull/17445#issuecomment-546175352
2019-10-25 17:46:01 +02:00
Jay Krell 84d64d314b [jit][x86][cxx] int/ptr casts (#17382) 2019-10-25 11:34:50 -04:00
Aleksey Kliger (λgeek) d6ee245c94 [runtime] Make mono_thread_manage external only (#17554)
* [runtime] Make mono_thread_manage external only

runtime should use mono_thread_manage_internal
2019-10-25 11:28:18 -04:00
Vlad Brezae 768fefbad1 [interp] Optimize stelem (#17519)
* [interp] Optimize stelem instructions

* [intepr] Optimize stelem_ref and slowpath casts

mono_object_isinst_checked uses coop handles and is very slow. Attempt to use the straightforward mono_class_is_assignable_from_checked.

Makes stelem_ref 5x faster.
2019-10-25 16:25:08 +02:00
Egor Bogatov dc4a7f5ed7 [llvm] Use -place-safepoints in JIT mode too (#17116)
* always use -place-safepoints pass in JIT mode

* ignore loaded llvm

* remove gc.safepoint_poll after optimizations

* fix typo

* cleanup

* cleanup

* cleanup

* cleanup

* Do not emit safepoints on entry thus simple functions (without calls and loops) won't have them at all

* Undo  -spp-no-entry=true

* fix failing tests

* do not emit sp in Allocators
2019-10-25 16:10:57 +02:00
Kenneth Pouncey 6ac749ed20 [wasm][bcl] Fix System.Diagnostics.Trace.TraceError crash. (#17509)
* Fix `System.Diagnostics.Trace.TraceError` crash.

- WASM does not have access to the command line arguments through the browser so the length is 0 causing index out of range error.
- The zero index of the command line arguments is what decides the `AppName` so under WASM the AppName will be blanks.

* Address review comments

* Remove #ifdef for WASM only.

- Addresses review note.
- As per channel discussion some embedding scenarios might be the same.
2019-10-25 11:17:00 +02:00
Zoltan Varga 9d781eb78c [wasm] Propagate exit code from Main in the test runner. (#17559)
* [wasm] Propagate exit code from Main in the test runner.

* Disable some System tests as they currently fail.
2019-10-25 04:59:30 -04:00
Dotnet-GitSync-Bot 8800bfdf9c Fix build break (#17553)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-24 18:30:09 -04:00
Jay Krell 4ef7c566af [cxx] externC for some icalls, for wasm and ios. (#17444)
Maybe all JIT icalls?
2019-10-24 17:59:11 -04:00
Jay Krell fc390a5f24 Include signal.h unconditionally. (#17430)
Some of the includes already were unconditional, including both on Win32 and Unix.
It is part of ANSI C 89, albeit in a reduced form compared to typical Unix (no sigaction).

Remove configuration of MSG_NOSIGNAL which has no other uses.

Preserve configuration of signal.h temporarily due to other uses of ifdef HAVE_SIGNAL_H.
 i.e. LLVM?
2019-10-24 17:44:57 -04:00
Jay Krell ec81a868a1 [cxx][x86] int/ptr casts. (#17441)
* [cxx][x86] Another int/ptr cast.

* More casts. Notice these are under
`#if defined (MONO_ARCH_USE_SIGACTION) && !defined (MONO_CROSS_COMPILE)`
which would explain them not showing up.
2019-10-24 17:37:12 -04:00
Dotnet-GitSync-Bot aea7214eb4 Optimize GC.AllocateUninitializedArray and use it in StringBuilder (#27364) (#17550)
* use GC.AllocateUninitializedArray for allocating internal char buffers

* force inlining of AllocateUninitializedArray to have no perf hit on the small buffers hot path

* insrease the threshold from 256 to 2048 bytes

* use Unsafe.As instead of a cast

* remove the size precondition from AllocateNewArray method, the called AllocateSzArray is responsible for handling negative size

Signed-off-by: dotnet-bot <[email protected]>
2019-10-24 16:02:11 -04:00
dotnet-maestro[bot] a7287bdae5 [master] Update dependencies from dotnet/arcade dotnet/core-setup dotnet/corefx (#17458)
* Update dependencies from https://github.com/dotnet/arcade build 20191018.2

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19518.2
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19518.2

* Update dependencies from https://github.com/dotnet/core-setup build 20191021.2

- Microsoft.NETCore.App - 5.0.0-alpha1.19521.2

* Update dependencies from https://github.com/dotnet/corefx build 20191020.7

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19520.7

* Update dependencies from https://github.com/dotnet/arcade build 20191023.3

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19523.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19523.3

* Update dependencies from https://github.com/dotnet/core-setup build 20191023.10

- Microsoft.NETCore.App - 5.0.0-alpha1.19523.10

* Update dependencies from https://github.com/dotnet/corefx build 20191023.8

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19523.8

* Disable a file system watcher test on mac

See https://github.com/mono/mono/issues/17547

* Reenable tests that were fixed
2019-10-24 21:06:46 +02:00
Bernhard Urban-Forster 25b53a642b [interp] fix code length for JitInfo (#17538)
* [interp] fix code length for JitInfo

* fix c++ build
2019-10-24 20:13:27 +02:00
Tanner Gooding 0595c0e6d7 Move down S.N.Vector APIs and expose new conversion support (#27401)
* Updating S.P.Corelib to start building Vector2/3/4 and supporting types

* Removing HAS_INTRINSICS usages from Matrix4x4

Signed-off-by: dotnet-bot <[email protected]>
2019-10-24 14:10:07 -04:00
Marek Safar 81a4a19f0a [netcore] Fix corerun build deps 2019-10-24 14:09:14 -04:00
Martin Baulig 1553889bc5 Cleaning up SslStream, MobileAuthenticatedStream and TaskToApm. (#17393)
### Overview

After the removal of the Legacy TLS Provider, we can make some cleanups and improvements to the `SslStream` class.  Since both the remaining providers use the internal `MobileAuthenticatedStream` and support Task-async code, we can get rid of some of the Begin/End async logic and the the underlying
`Stream` class handle it instead.

This also fixes a nasty issue with some of those task objects leaking unobserved exceptions.  The problem was that `SslStream.Dispose()` needs to clear out all resources, but in doing so also nulls out the `Impl` handle to the `MobileAuthenticatedStream` - so a subsequent `End*()` call will not reach it's corresponding `TaskToApm.End()` method.

There are also some cleanups in the internal APIs that were only ever used internally and not intended for public consumption.

### Mono.Security.dll

* `Mono.Security.Interface`: removed internal `ICertificateValidator2` interface.

* `Mono.Security.Interface.IMonoSslStream`: this internal interface is only used by the web-tests, which only use it as a way to get the `SslStream` instance, so all those `Begin/End` async methods are now gone.

* `Mono.Security.Interface.IMonoSslStream2`: removed another internal interface.

* `Mono.Security.Interface.MonoTlsProvider`: removed some `internal abstract` methods; these have been moved into a new `Mono.Net.Security.MobileTlsProvider` inside `System.dll`.

### System.dll

* `Mono.Net.Security.MobileTlsProvider`:
  New abstract internal base class, which received the aforementioned abstract internal methods.  The naming is such to make it consistent with the already existing `MobileTlsContext` and `MobileAuthenticatedStream`.

Since both `AppleTlsProvider` and `BtlsProvider` now have an abstract internal base class inside `System.dll`, they can use the `ChainValidationHelper` class directly and we can also avoid some `Mono.Security` dances like for instance that `MonoSslPolicyErrors` enum.

This will also help make the code easier to read and maintainer.
  
* `Mono.AppleTls.AppleTlsProvider` and `Mono.Btls.MonoBtlsProvider`: change base class into `MobileTlsProvider` and reflect above mentioned overload changes.

* `Mono.AppleTls.AppleCertificateHelper`: use `ChainValidationHelper` as well.

* `Mono.Net.Security.ChainValidationHelper`: only implement `ICertificateValidator`.
  The `ICertificateValidator` interface is still required because it is in use by the web-tests, but the previous `ICertificateValidator2` was an internal dance.

* `Mono.Net.Security.MobileAuthenticatedStream`: largely cleaned up this class.
  - we now implement the current slimmer version of `IMonoSslStream`.
  - moved all those overloads into `SslStream` that only fill in default values for some of their arguments and then call another overloaded version of their own.
  - removed lots of `Begin/End` methods that are not used anymore.

* `Mono.Net.Security.MonoTlsProviderFactory`: use `MobileTlsStream` everywhere.

* `Mono.Net.Security.MonoTlsStream`: cleanup `SslStream` creation logic; instead of going throw `provider.CreateSslStream()`, we can now use an internal constructor directly, thus avoiding the `IMonoSslStream` interface while also making the code a lot easier to read and understand.

* `System.Net.Mail.SmtpClient`: same here.

* `System.Net.HttpWebRequest`: use `MobileTlsProvider`.

* `System.Net.Security.SslStream`: largely cleaned up this class.
  - we now use `MobileAuthenticatedStream` directly instead of the `IMonoSslStream` interface and therefore could also get rid of `IMonoSslStream2`.
  - cleanup constructor logic to allow the internal constructor being used with a `MobileTlsProvider` instead of going through `provider.CreateSslStream()`.
  - all those overloads that are only filling in default values for some of their arguments before calling another overloaded version of their own now live here instead of in the `MobileAuthenticatedStream` class.  The reason is to simply that `MobileAuthenticatedStream` is already quite a complex and difficult class, and removing some of that complexity out of it will make it easier to understand.
  - handle the `TaskToApm.Begin()` / `TaskToApm.End()` here to ensure that we are not leaking any task objects with unobserved exceptions.
  - removed `BeginRead()` and `BeginWrite()` overloads to let the underlying `Stream` class handle these.


* Bump API snapshot submodule

* [csproj] Update project files
2019-10-24 19:42:54 +02:00
Calvin Buckley 638e2c6a86 Fix eglib on AIX/PASE (#17476)
* fix eglib on AIX/PASE

	* Work around access(2) syscall bug on PASE
	  On PASE, X_OK will always returns true. This is contrary to
	  how AIX behaves (though corresponds to documentation!). This
	  is probably because it's an upcall to the ILE version of
	  access, and that seemingly always returns true.

	* Always export the dummy function in the test suite
	  The AIX linker didn't export this properly, without using the
	  giant sledgehammer of -bexpall. Write an export file and use
	  it. This required some build system changes to expose an
	  AIX-only automake conditional.

	* Use a file that exists on PASE for tests
	  PASE doesn't use Unix-style DNS resolution, so /etc/hosts is
	  missing. Use /etc/magic, since that seems to be present.

	* Don't use /bin on AIX/PASE for tests
	  This is a symlink to /usr/bin, and it seems chdir/getcwd
	  follows links. Use /usr instead, that is unlikely to be a
	  symlink.

	* Make a note what directory we're in if we fail test_cwd

* Change manual executable access check change per Jay

* Change test on POSIXy platforms to always use root directory
2019-10-24 18:04:20 +02:00
Vlad Brezae b7ef736338 [interp] Add super instructions for field storing (#17525)
* [interp] Add also floating versions for stloc.np

* [interp] Add super instructions for stfld

When storing into a field of a local or an argument (ldloc/ldarg -> random instructions that end up pushing one value -> stfld). We add this instruction to the cprop pass because the instructions that are optimized together are not consecutive and we need the stack information to be able to access the instruction that loaded the argument / local and to make sure that the local wasn't dirtied. Alternatively we could make the super instruction pass stack aware, which we should probably do if more super instruction candidates turn out to require stack state information.

* [interp] Enable cprop for methods without locals

We do some optimizations here that don't apply to locals.

* [interp] Fix result stack type of CEE_CONV_OVF_I_UN
2019-10-24 18:05:04 +03:00
Vladimir Sadov 6fd07e4745 Moving StopWatch to src\Common\src\Corelib (dotnet/corefx#42072)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-24 16:54:28 +02:00
Egor Bogatov 7952e73780 Bump to mono/corefx@fb41040
Includes upstream corefx changes that makes NTLM auth work for more scenarios.
2019-10-24 10:04:24 -04:00
Bernhard Urban-Forster 861812252a [lldb] another fix for handling interp frames (#17535)
[lldb] another fix for handling interp frames

And improved error message in case it breaks again.
2019-10-24 14:07:22 +02:00
Dotnet-GitSync-Bot 2c8e0f68c1 Add AdvSimd (LeadingZeroCount, LeadingSignCount, PopCount) (#27382) (#17532)
* AdvSimd.LeadingSignCount

* AdvSimd.LeadingZeroCount

* AdvSimd.PopCount

Signed-off-by: dotnet-bot <[email protected]>
2019-10-24 07:16:49 -04:00
Zoltan Varga 951769b279 [netcore] Add a few more missing SSE intrinsics. (#17511)
* [netcore] Add a few more missing SSE intrinsics.

* Disable some intrinsics for non-llvm.
2019-10-24 06:57:13 -04:00
Johan Lorensson fe7654f745 Adjust restart world logging level to match start major/nursery logging. (#17520)
With this change we will get the following logging on level 1:

2019-10-22 15:46:59 Start nursery collection 38898 00000205A0000000-00000205A1000000, size: 16777216
2019-10-22 15:46:59 restarted (pause time: 2728 usec, max: 689233 usec)

showing the pause time and when runtime was restared, before this fix
we will only see the start log message on level 1.
2019-10-24 04:57:55 -04:00
Filip Navara 7a15b71873 [netcore] Managed ThreadPool implementation (#17387)
* Wire up the managed side of the portable thread pool

* Remove old native thread pool code

* Fix non-netcore build

* Fix Thread.IsThreadPoolThread

* Fix MSVC builds

* Code style fix

* Make the locking primitives uninterruptible

* Revert icall changes for non-netcore

* Implement Thread.ResetThreadPoolThread

* Compile out more thread pool code for netcore

* Remove ThreadPoolBoundHandle, it is shared now

* Address PR feedback on code style
2019-10-24 04:56:25 -04:00
Dotnet-GitSync-Bot 2dfd682ac9 Enable pooling for async ValueTask/ValueTask<T> methods (#26310) (#17531)
Today `async ValueTask/ValueTask<T>` methods use builders that special-case the synchronously completing case (to just return a `default(ValueTask)` or `new ValueTask<T>(result))` but defer to the equivalent of `async Task/Task<T>` for when the operation completes asynchronously. This, however, doesn't take advantage of the fact that value tasks can wrap arbitrary `IValueTaskSource/IValueTaskSource<T>` implementations.

This commit gives `AsyncValueTaskMethodBuilder` and `AsyncValueTaskMethodBuilder<T>` the ability to use pooled `IValueTaskSource/IValueTaskSource<T>` instances, such that calls to an `async ValueTask/ValueTask<T>` method incur 0 allocations (ammortized) as long as there's a cached object available.

Currently the pooling is behind a feature flag, requiring opt-in via the DOTNET_SYSTEM_THREADING_POOLASYNCVALUETASKS environment variable (setting it to "true" or "1").  This is done for a few reasons:
- There's a breaking change here, in that while we say/document that `ValueTask/ValueTask<T>`s are more limited in what they can be used for, nothing in the implementation actually stops a `ValueTask` that was wrapping a `Task` from being used as permissively as `Task`, e.g. if you were to `await` such a `ValueTask` multiple times, it would happen to work, even though we say "never do that". This change means that anyone who was relying on such undocumented behaviors will now be broken. I think this is a reasonable thing to do in a major release, but I also want feedback and a lot of runway on it.
- Policy around pooling. Pooling is always a difficult thing to tune. Right now I've chosen a policy that limits the number of pooled objects per state machine type to an arbitrary multiple of the processor count, and that tries to strike a balance between contention and garbage by using a spin lock and if there's any contention while trying to get or return a pooled object, the cache is ignored. We will need to think hard about what policy to use here. It's also possible it could be tuned per state machine, e.g. by having an attribute that's looked up via reflection when creating the cache for a state machine, but that'll add a lot of first-access overhead to any `async ValueTask/ValueTask<T>` method.  For now, it's tunable via the `DOTNET_SYSTEM_THREADING_POOLASYNCVALUETASKSLIMIT` environment variable, which may be set to the maximum number of pooled objects desired per state machine.
- Performance validation.  Preliminary numbers show that this accomplishes its goal, having on-par throughput with the current implementation but with significantly less allocation.  That needs to be validated at scale and across a variety of workloads.
- Diagnostics.  There are several diagnostics-related abilities available for `async Task/Task<T>` methods that are not included here when using `async ValueTask/ValueTask<T>` when pooling.  We need to evaluate these (e.g. tracing) and determine which pieces need to be enabled and which we're fine omitting.

Before shipping .NET 5, we could choose to flip the polarity of the switch (making it opt-out rather than opt-in), remove the fallback altogether and just have it be always on, or revert this change, all based on experimentation and data we receive between now and then.

Signed-off-by: dotnet-bot <[email protected]>
2019-10-24 03:09:50 -04:00
Kenneth Pouncey 1b5658d590 [wasm][sdk] Bump SDK version to 0.2.2 (#17516)
* [wasm][sdk] Bump SDK version to 2.2

* Update SDK version for browser tests
2019-10-24 07:37:28 +02:00
Dotnet-GitSync-Bot e5d88dbd04 Mirror changes from mono/coreclr,corefx,corert (#17526)
* Apply SuppressGCAttribute to some SPCL functions. (dotnet/coreclr#27369)

Apply SuppressGCAttribute to some SPCL functions.

Only insert GC_POLL in first morph call.

Signed-off-by: dotnet-bot <[email protected]>

* Remove unused methods (dotnet/coreclr#27370)

Signed-off-by: dotnet-bot <[email protected]>

* Move Matrix3x2/4x4, Plan, and Quaternion to the shared CoreLib partition (#42021)

Signed-off-by: dotnet-bot <[email protected]>

* Remove Socket.InnerSafeCloseSocket (dotnet/corefx#41888)

* Remove Socket.InnerSafeCloseSocket

* Move IsInvalid checks in SetHandle function

* PR feedback

* Remove unnecessary 'SocketPal.'

* Remove SafeSocketHandle.SetHandle

Signed-off-by: dotnet-bot <[email protected]>
2019-10-23 23:01:00 -04:00
Maxim Lipnin 43a938fefb [wasm][xunit tests] Exclude some System.Data tests (#17527) 2019-10-23 22:55:56 -04:00
Thays Grazia 8fda1738f7 [debugger] Changing how debugger handles exception when hybrid suspend is enabled (#17478)
* Removing all fixes to fix #15203 and #17083, and trying a new approach to fix this #17084, together.

The thing is when we are executing on hybrid suspend the caller is executed inside try catch in the runtime_invoke_ method that is generated. And this try catch should be ignored for the debugger exception, otherwise it's the last try catch in main thread, but should always be considered to generate the stack trace.

Fixes #17084

* This test check the case that we were missing. On preemptive this test always runs perfectly, on Hybrid, never run well until this PR.

* Changing how call unit test.
Changing variable name.
2019-10-23 17:56:58 -03:00
Jay Krell 4d7adf4d2a [cxx] Put extern "C" in MONO_LLVM_INTERNAL. (#17443) 2019-10-23 15:36:35 -04:00
Johan Lorensson df30c7228c Optimize LOS for better parallelization. (#17173)
Scanning LOS list as part of minor GC didn't parallelize well since
all scan jobs needed to walk the complete LOS list. This led to touching
a lot of memory walking the list, increasing minor GC pause times
when the number of items in the LOS list increased. As an example,
stressing LOS data structure using ~600 MB's of random sized byte arrays
caused minor GC pause times between ~20ms without parallelization and ~19ms
with parallelization. NOTE, the more work each job gets (more memory to scan)
we will get a better parallelization, but still a lot of room for improvement.

Changing from a normal linked list to a SgenArrayList makes it more effective
to parallelize the scan jobs and since the list is using sequential
memory, this will also reduce cache misses for each thread iterating LOS
objects. Tagging objects in SgenArrayList with reference information reduce
cache misses dramatically in cases where objects not including references
exists on the list, since scanning jobs can skip these items without any
need to touch object memory causing cache misses.

Same scenario running with fix gives us minor GC pause times, without
parallelization in ~7ms (down from 20~ms) and with parallelization,
< 5ms (down from 19ms). NOTE, the more work each job gets (more memory to scan)
we will get a better result using parallelization, so the delta will increase
between using and not using parallelization, this scenario primarily stress
the extreme case where most LOS objects doesn't have references.

In total, this optimization reduce minor GC pause time 4x, from ~19ms when
using parallelization down to < 5ms.
2019-10-23 14:58:04 -04:00
Zoltan Varga 31b475e25a [wasm] Avoid adding an extra arg to native-to-managed wrappers. (#17508)
[wasm] Avoid adding an extra arg to native-to-managed wrappers.

Fixes https://github.com/mono/mono/issues/17389.




<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-10-23 17:06:18 +02:00
Jay Krell 8b8b8b5010 [coop] Fix big endian problem in MonoThradStateMachine and cleanup. (#17502) 2019-10-23 10:21:54 -04:00
Filip Navara e29f8e32b7 [netcore] Add Unsafe.SkipInit intrinsic 2019-10-23 09:26:09 -04:00
Tanner Gooding e73aa17e23 Adding SkipInit to Internal.Runtime.CompilerServices.Unsafe (#27377)
* Adding SkipInit to Internal.Runtime.CompilerServices.Unsafe

* Updating the runtime to handle Unsafe.SkipInit

* Updating Decimal.DecCalc to use Unsafe.SkipInit

* Removing 'workaround for CS0165' comments

Signed-off-by: dotnet-bot <[email protected]>
2019-10-23 09:26:09 -04:00
Marius Ungureanu bed1b39c6e Bump Bockbuild to pick-up gtk# binding change (#17486)
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1005448
Which causes quite a few broken clipboard bugs and possible memory corruption

(cherry picked from commit 989333d6ae)
2019-10-23 14:36:46 +02:00
Kenneth Pouncey bc769e7376 [wasm] move jsvu repo back after fixes for v8 (#17514) 2019-10-23 13:34:36 +02:00
Kenneth Pouncey cdf8b839ae [wasm][binding] Add bindings for calling the entry point of an '.exe' (#17510)
- Add `mono_bind_assembly_entry_point`
- Add `mono_call_assembly_entry_point`
   - Module.mono_call_assembly_entry_point("WasmHttpStreamSync", []);

Example:

```
   Module.mono_call_assembly_entry_point("WasmHttpStreamSync", []);
```

```
   var main = Module.mono_bind_assembly_entry_point("WasmHttpStreamSync", []);
   main();
```
2019-10-23 12:43:16 +02:00
Vlad Brezae 479d2dff36 [interp] Add a new super instructions pass (#17489)
Together with a few very simple super instructions. We replace common instruction patterns to avoid indirection via interp stack, instruction dispatch overhead and to allow the compiler to generate better code for the instruction.
2019-10-23 11:57:07 +03:00
Vlad Brezae 4419dc919f [interp] Retry cprop pass if killing stloc (#17491)
When replacing a stloc with a pop, we should retry the pass, since it is very likely that we will be able to kill the instruction that pushed that value on the stack.
2019-10-23 10:39:27 +03:00
Jay Krell 92c08fab4d SetLastError slightly later, in case last error not preserved, and it is just as good. (#17483)
SetLastError slightly later, in case last error not preserved, and it is just as good.
2019-10-23 09:36:15 +02:00
Vlad Brezae 6159407846 [interp] Optimize ldelem instructions (#17494)
Remove the switch and have each instruction have its own code. Seems to improve speed on a benchmark that heavily uses ldelem by about 10-20%.
2019-10-23 10:23:49 +03:00
Zoltan Varga a2cd8b2495 [wasm] Enable threads again on CI, it seems to work again. (#17503) 2019-10-23 02:41:46 -04:00
Dotnet-GitSync-Bot b99a3e9514 Move Vector2/3/4 to the shared CoreLib partition (dotnet/corefx#42005) (#17505)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-23 00:36:20 -04:00
Filip Navara 1e60703a19 [netcore] Disable debugging code in lookup_intrins (#17464) 2019-10-23 00:01:51 -04:00
Aaron Robinson 11dca2a3b8 Add documentation for SuppressGCTransition (dotnet/coreclr#27368)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 21:30:52 -04:00
Zoltan Varga 745e5ba3c3 [wasm] Bump emscripten to 1.39.0. (#17484)
* [wasm] Bump emscripten to 1.39.0.

* [wasm] Fix threads build.
2019-10-22 20:09:07 -04:00
Larry Ewing d08713198f [wasm] fix package target 2019-10-22 18:19:19 -05:00
Larry Ewing 433d7c5004 [wasm] Bump DebugProxy to netstandard 2.1 / netcore 3.0.0 2019-10-22 18:19:19 -05:00
Larry Ewing 15d61d3f47 [wasm] work around jsvu / v8 changes 2019-10-22 15:50:18 -05:00
Tanner Gooding 69407517bc Adding back more arm intrinsics that existing before refactoring (#27153)
* Adding AdvSimd.And

* Adding AdvSimd.AndNot

* Adding AdvSimd.Or

* Adding AdvSimd.OrNot

* Adding AdvSimd.Xor

* Adding AdvSimd.Not

* Removing a trailing whitespace from AdvSimd.PlatformNotSupported.cs

* Adding AdvSimd.Subtract

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 14:48:34 -04:00
Filip Navara fdca1630dc Fix nullability error in portable thread pool (dotnet/coreclr#27366)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 14:48:34 -04:00
Jan Kotas b98911d4f8 Delete Uap quirks from CoreLib (dotnet/coreclr#27356)
This matches cleanup done in CoreFX.

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 14:48:34 -04:00
Adam Sitnik 0663433389 remove double bound check from StringBuilder.Append(char) (#27340)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 14:48:34 -04:00
Aleksey Kliger (λgeek) fb5b2c949d [reflection] mono_method_get_base_method on a GTD should use canonical ginst (#17475)
* [test] GetCustomAttributes on generic type definition

* [reflection] mono_method_get_base_method on a GTD should use canonical ginst

The issue is in how we pass along the generic instantiation.  So there are two
parts here: we start with a method on a GTD which has to decompose into the GTD
and it's instantiation with its own generic parameters, and then we go up to
its parent and grandparent inflating and decomposing the resulting
instantiation. The instantiations keep passing the last parameter as the number
of parameters shrinks so that the gparam index from the original type is now
out of bounds for the parent and grandparent.  If we mess up, we'll get a
BadImageFormatException from the runtime

Fixes https://github.com/mono/mono/issues/17278
2019-10-22 14:07:44 -04:00
Maxim Lipnin bc9b64b807 Get resource string 2019-10-22 12:13:38 -05:00
Aleksey Kliger (λgeek) ebb5846e0d [coop] Use bitfields for coop state machine state representation (#17298)
* [checked] Mask the thread state in GC thread state assertions

Because we have extra bits (like suspend count and the no_checkpoints bit) on
the thread state, we have to mask it to get the actual thread state enum value

* [coop] Use bitfields to represent coop thread state

Instead of using a 32-bit int, use bitfields and type-punning through a union
type.  We need to type pun because we need to access the entire state as a 32-bit int so that we can do atomic CAS.

* use atomic load of thread state in unwrap_thread_state.

Saw one stack trace on CI on the full coop lane where check_thread_state saw STATE_RUNNING
but with a positive suspend count.  Another thread was starting a GC a
the time.  Seems like we saw the state as runnning, but the suspend
count as if we were already in async_suspend_requested.

Thread 22 (Thread 0x7f43c03ff700 (LWP 39860)):
2019-10-22 12:14:05 -04:00
Marek Safar f34fd20fbf [System.Private.CoreLib] Remove unused methods 2019-10-22 11:28:22 -04:00
Filip Navara cf1a9e0033 Update Mono for changes in shared CoreLib partition 2019-10-22 09:46:29 -04:00
Jan Kotas 64c3405594 Cleanup memory copy helpers (dotnet/coreclr#27307)
- Merge RuntimeImports that has just a few FCalls into Buffer.
- Delete assembly implementation of memcpy for ARM. The implementation was outdated and it was used only on Windows ARM and only for fraction of memcpy callsites.
- Delete unnecessary PInvoke into SysStringLen. We have a managed equivalent on System.Runtime.InteropServices.Marshal.
- Delete large amount of redundant code between SecureString.Windows.cs and SecureString.Unix.cs, and switch SecureString to use Spans
- Fold null check into IsWin32Atom

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Jan Kotas d4a2f01064 Rewrite Buffer.BlockCopy in C# (dotnet/coreclr#27216)
* Rewrite Buffer.BlockCopy in C#

Fixes #27106

* Workaround to enable type check optimizations for BlockCopy only

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Tanner Gooding 8ea0426488 Improve codegen for IsNan (dotnet/coreclr#27272)
* Updating double.IsNaN and float.IsNaN to just `return x != x`

* Updating x86 codegen to optimize `x != x` for floating-point

* Changing the isnan optimization to only check the operand assigned registers

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Jan Kotas 113d855adb Delete ENABLE_WINRT define (dotnet/coreclr#27240)
.NET Native specific code not needed anymore

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Ben Adams d5b182c6d8 Improve Dictionary TryGetValue size/perfomance (dotnet/coreclr#27195)
* Dictionary avoid second bounds check in Get methods

* Add NullRef methods to Unsafe

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Levi Broderick 274db87e60 Fix DecoderNLS.Convert to out the correct value for 'completed' (#27210)
This is a complementary fix to https://github.com/dotnet/coreclr/issues/23020

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Del Myers 0e02fa55af Enable ETW/EventSource logging of task IDs for boxed state machines (#27115)
* Wrap MoveNext Action for TPL event tracing

Wraps the MoveNext action of the AsyncStateMachineBox in a
continuation wrapper when async causality tracing is on so that the
TPL event source can find the task that is associated with a
continuation. Does not wrap otherwise.

* Clarifying comment

* removing trailing whitespace

* code review feedback.

Makes AsyncMethodBuilderCore.TryFindContinuationTask check to
whether the target of a continuation is itself a task, as a fall-back
to checking to see if the continuation is a ContinuationWrapper

* Got rid of unnecessary null checks

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Levi Broderick 5fdea0b84b Update Utf8String to match latest prototype (dotnet/coreclr#27046)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Stephen Toub d34ba480f9 Use stackalloc expressions with builder ctors (dotnet/coreclr#27194)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Aaron Robinson 296b8d40cf Conditionally remove the GC transition from a P/Invoke (#26458)
* Provide mechanism to remove the GC transition from a P/Invoke.
  New Attribute: 'System.Runtime.InteropServices.SuppressGCTransitionAttribute'

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Jan Kotas cd2388fd6f Replace primitive Array fcalls with managed implementations (#27123)
Prep-work for #27106

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Filip Navara 858fc11900 Move portable thread pool to shared partition (dotnet/corert#7828)
* Move portable thread pool to shared partition

* Rename ClrThreadPool to PortableThreadPool

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Dan Moseley 565b81e26f Annotate System.Resources.ResourceWriter for nullable ref types (#41880)
* Annotate System.Resources.ResourceWriter for nullable ref types

* ref

* Mark common as nullable enable explicitly

* _resourceList

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Eriawan Kusumawardhono f731db32dd Replace tfm based constants with SDK ones (dotnet/corefx#41601)
* replace DefineConstants with SDK ones

Signed-off-by: dotnet-bot <[email protected]>
2019-10-22 09:46:29 -04:00
Zoltan Varga b96260e603 [jit] Avoid running mono_handle_native_crash () on the altstack, it can't produce a backtrace. AMD64 only for now. (#17466)
* [jit] Avoid running mono_handle_native_crash () on the altstack, it can't produce a backtrace. AMD64 only for now.

* Fix checks so stack overflows work again.
2019-10-22 06:31:23 -04:00
Larry Ewing 20752df324 [debugger][wasm] Check the length of the vars array. Fixes #17473 2019-10-21 18:45:57 -05:00
Vlad Brezae c1461e4a2d [interp] Replace loading of static readonly fields with LDC (#17420)
LDC is faster and also allows for constant propagation. Cleanup code a little bit.
2019-10-21 23:42:24 +03:00
Jay Krell fd82c6036e No type_traits on Android.
In file included from /Users/builder/jenkins/workspace/test-mono-pull-request-amd64-osx-products-sdks-android/mono/metadata/icall.c:42:
/Users/builder/jenkins/workspace/test-mono-pull-request-amd64-osx-products-sdks-android/mono/metadata/icall-internals.h:89:10: fatal error: 'type_traits' file not found
2019-10-21 11:15:16 -05:00
Kenneth Pouncey 7e522ef179 Modify the check for streaming to also check that the browser Response object exists. 2019-10-21 10:27:05 -05:00
Jay Krell 21d7d41bfe [cxx][debug-interp] Cast once from void* to non-void*. 2019-10-21 10:22:43 -05:00
Kenneth Pouncey 2cea0a89d1 Fix host object existence check.
- The checking for the existence of the object is incorrect: Missing parens around undefined.
- Modify error description returned back to managed code.
- Fix capitalization in global object check error.
2019-10-21 10:21:16 -05:00
Thays Grazia 0d357c1347 [tests] Replace __WATCHOS__ with MONOTOUCH_WATCH (#17459)
Fixes the conditional from mono/mono#17423, we don't define __WATCHOS__ in the Mono BCL builds. We use MONOTOUCH_WATCH instead.
2019-10-21 16:20:12 +02:00
Kenneth Pouncey f07e93da2f [wasm] Make sure message pump is working when executing via NODEJS (#17453)
- Tests if we are running in ENVIRONMENT_IS_NODE
   - run message pump if we are.

- This also fixes GC not running.

- Clean up some messages.
2019-10-21 14:29:18 +02:00
Kenneth Pouncey 3ff90ac0c2 Export mono_load_runtime_and_bcl so that is available in nodejs. (#17456) 2019-10-21 13:50:57 +02:00
Jay Krell 9f50bdb2d9 [Coop] Unconvert Microsoft.Win32.NativeMethods. (#16992)
* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_CloseProcess.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_GetCurrentProcess.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_GetCurrentProcessId.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_GetExitCodeProcess.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_GetPriorityClass.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_GetProcessTimes.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_GetProcessWorkingSetSize.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_SetPriorityClass.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_SetProcessWorkingSetSize.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_TerminateProcess.

* [Coop] Unconvert ves_icall_Microsoft_Win32_NativeMethods_WaitForInputIdle.
2019-10-21 10:29:39 +02:00
Zoltan Varga 4b9226619c [interp] Small fixes. (#17442)
* [interp] Really abort in ves_real_abort ().

* [interp] Fix stack usage in TRACE_EXIT.

* [interp] Add a callback to free ThreadContext.

* Fix warnings.

* Remove an empty statement.

* Fix a double free.
2019-10-20 23:28:25 -04:00
Filip Navara 32ab6bcf00 [netcore] Implement Array.GetElementSize as intrinsic (#17437)
* [netcore] Implement Array.GetElementSize as intrinsic

* Remove unnecessary icall

* alloc_preg -> alloc_ireg

* Implement Array.GetElementSize as intrinsic in interpreter

* Address PR feedback
2019-10-20 18:39:39 -04:00
Filip Navara 67c8d0d812 [netcore] Remove unused code for Array.Unsafe[Mov/Load/Store] intrinsics 2019-10-20 12:44:52 +02:00
monojenkins 5fcd00669c [csproj] Update project files 2019-10-20 12:43:59 +02:00
monojenkins b19d9aa658 Bump API snapshot submodule 2019-10-20 12:43:59 +02:00
Zoltan Varga 1d44139d01 Bump cecil. 2019-10-20 12:43:59 +02:00
Filip Navara bc678a2c10 Use correct variable in mini_get_cpu_features (#17436)
* Use correct variable in mini_get_cpu_features

* Address PR feedback
2019-10-20 01:26:44 -04:00
Filip Navara 91f10aeee4 Remove dead code left out in #17341 (#17433) 2019-10-20 01:23:05 -04:00
Jay Krell 91413f78f3 [jit][x86][cxx] int/ptr casts in mini-x86.c (#17380) 2019-10-19 19:20:56 +02:00
Jay Krell 84f4e1dcbf Replace ICALL_DECL_EXPORT with ICALL_EXPORT. They are always the same, and it is only used once. (#17429)
Replace ICALL_DECL_EXPORT with ICALL_EXPORT. They are always the same and it is only used once.
2019-10-19 13:25:54 +02:00
Thays Grazia 105ead8707 Changing behavior of some tests in WatchOs
Needs this ifdefs because of this https://github.com/mono/mono/pull/17260. (#17423)
2019-10-18 21:23:44 -04:00
Aleksey Kliger (λgeek) d8ae32a9ee [bcl] Add null reference checks to Interlocked.Exchange<T> (#17400)
* [bcl] Add null reference checks to Interlocked.Exchange<T>

and Interlocked.CompareExchange<T>

This is to mimic the old behavior in unmanaged when the intrinsic cannot be
used.

The issue was detected via the coreclr acceptance test:
https://github.com/mono/coreclr/blob/mono/tests/src/baseservices/threading/interlocked/exchange/exchangetneg.il

* and netcore
2019-10-18 19:11:22 -04:00
Jay Krell a2992d634b [cxx] [wasm] int/ptr casts esp. m2n-gen. (#17379) 2019-10-19 00:03:00 +02:00
Martin Baulig fffad7e3a8 Remove the Legacy TLS Provider. (#17391)
* `MonoTlsProviderFactory` now treats "legacy" as an alias for "default".

* `Mono.Net.Security/LegacySslStream`: Removed.  This class also wasn't using the `MobileAuthenticatedStream` base class, thus preventing cleanups simplifications in that area.

* `Mono.Net.Security/LegacyTlsProvider`: Removed.

* `Mono.Security/Mono.Security.Protocol.Tls*`: Removed all the old legacy code.

* `Mono.Security.Interface.MonoTlsProviderFactory`: Bump internal version to 4.
2019-10-19 00:02:48 +02:00
imhameed 8836231459 Merge pull request #17279 from imhameed/bug-gh-16935-netcore-equalsall-codegen
Generate LLVM IR for OP_XEQUAL that is recognized by LLVM's vector pattern recognizers.
2019-10-18 12:47:41 -07:00
Alex Rønne Petersen d44e0e80d7 Some updates to make RISC-V buildable again. (#17408)
Some updates to make RISC-V buildable again.

Also some updates to the toolchain setup documentation.
2019-10-18 20:16:14 +02:00
Kenneth Pouncey a0c7d73d6f [sdks] add .gitignore python __pycache__ (#17414)
This will ignore the __pycache__ files generated after the tools offset build.
2019-10-18 18:08:57 +02:00
Vlad Brezae 37f628750a [profiler] Fix coverage profiler on macos (#17396)
If we have coverage profiling enabled for a method (mono_profiler_coverage_instrumentation_enabled, with coverage_filter callback), then we should be able to allocate a coverage info structure (mono_profiler_coverage_alloc). After https://github.com/mono/mono/commit/52429673dc617fd437518757c04c7448211075e9, coverage_filter was reporting wrapper methods as ok to profile, while mono_profiler_coverage_alloc was refusing to allocate the necessary structure, leading to crashes.
2019-10-18 16:31:47 +02:00
Jay Krell 958b9b2658 [interp][wasm] Remove more varargs to conserve stack. (#17388) 2019-10-18 10:39:05 +03:00
Egor Bogatov 4908d1f19a Enable GSS on Linux and Android (#17223) 2019-10-17 19:01:44 -04:00
Alexander Köplinger e5721bbb23 [corlib] Mark YieldAwaitable struct readonly (#17386)
* [corlib] Mark YieldAwaitable struct readonly

Make it consistent with .NET Standard/Core which makes future API Compat runs report one less difference.

* Bump API snapshot submodule
2019-10-17 16:01:22 +02:00
Vlad Brezae ec653e70bf [interp] Constant folding for integers (#17362)
* [interp] Move instructions together

For easy check if an instruction is unary or binary operation. We consider conversion instructions to be unary operators and compare instructions to be binary operators.

* [interp] Add stloc.np also for longs

* [interp] Add stats for total number of emitted instructions

Also make the killed_instructions counter actually track the total amount of killed instructions. It was not previously tracking instructions killed as part of addition of stloc.np / movloc.

* [interp] Improve logging during cprop

Make dumping instruction support also InterpInst's not just compacted instructions.

* [interp] Constant folding of common unary operators

* [interp] Constant fold binary operations

* [interp] Remove MINT_CONV_U8_I4 opcode

It is equivalent with MINT_CONV_I8_U4.
2019-10-17 14:23:12 +03:00
Jay Krell e8b6fcc945 [cxx] Int vs. enum, static for efficiency, cleanup, fix typo. (#17377)
[cxx] Int vs. enum, static for efficiency, cleanup, fix typo.
2019-10-17 12:25:18 +02:00
Jay Krell e97e1f994d [cxx][x86] int/ptr casts. (#17345) 2019-10-17 12:24:46 +02:00
Vlad Brezae ae0fbd366e [interp] Always intrinsify MemoryBarrier method
As we do it on jit.
2019-10-17 12:53:19 +03:00
Vlad Brezae 0102263645 [interp] Avoid using full barriers for volatile operations
This commit avoid unnecessary memory barriers on x86 and amd64.

Volatile writes have release semantics, volatile reads have acquire semantics. Organize the code a little bit to indicate this. On x86 and amd64 we don't require barrier for acquire and release semantics since they are provided by the arch, so we can skip them. Ideally we should have 3 memory barrier interp instructions for each type, but, currently, they would all seem to call mono_memory_barrier so it is useless at this point.
2019-10-17 12:53:19 +03:00
Johan Lorensson 4f8a82c9fd Upgrade build scripts to support VS2019. (#17269)
Changes will default Windows SDK version as well as Platform Toolset to
the default versions used in the targeted VS version. If the projects are
opened up in VS2015, it should default to Windows SDK 8.1 and v140, but if
the same projects are opened in VS2019, it will default to latest Windows SDK 10
and v142. This way the project files should adapt to used VS version, meaning
that we could still build them using VS2015 (what's currently used on CI) but also
using VS2017 and VS2019. There should not be a need to install any previous versions
of build tools, unless an older version is targeted. It is also possible to set
PlatformToolset when calling msbuild and that should adapt to corresponding default
Windows SDK version for targeted toolset version.

Commit makes many changes and adjustments, aligning all vcxproj files but changes
should not affect build output.
2019-10-17 08:55:50 +02:00
Jay Krell edafa021d3 Use functions instead of macros for is_in/is_out. (#17350)
Use functions instead of macros for is_in/is_out.
2019-10-17 06:46:03 +02:00
Aleksey Kliger (λgeek) b6388e271f [bcl] Remove CompareExchange_T (#17370)
In https://github.com/mono/mono/pull/17341 we change the caller of
CompareExchange_T<T>(ref T, ...) to call CompareExchange (ref object, ...), but
didn't delete the declaration.

It's already deleted in unmanaged and in the netcore version of this file.
2019-10-16 21:11:36 -04:00
Maxim Lipnin 02bc95a51a [wasm][xunit tests] Disable System.IO.Compression.Tests.BrotliEncoderTests (#17351)
Fixes https://github.com/mono/mono/issues/17053
2019-10-16 18:47:16 -04:00
dotnet-maestro[bot] 1dbad7cd88 [master] Update dependencies from dotnet/core-setup dotnet/corefx (#17355)
* Update dependencies from https://github.com/dotnet/core-setup build 20191015.17

- Microsoft.NETCore.App - 5.0.0-alpha1.19515.17

* Update dependencies from https://github.com/dotnet/corefx build 20191015.14

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19515.14

* Reenable a test that was fixed
2019-10-16 23:12:15 +02:00
Jay Krell c0d50719ea [cxx][x86][amd64] Remove unused STORE_MEM_IMM. (#17347)
[cxx][x86][amd64] Remove unused STORE_MEM_IMM.

And there was an int/ptr cast error within.
2019-10-16 22:26:02 +02:00
Thays Grazia 3f9d501a78 Removing execution of network tests from WatchOs. (#17358) 2019-10-16 17:10:27 -03:00
Aleksey Kliger (λgeek) f017835ac1 [bcl][jit] implement Interlocked.Exchange<T> in terms of object (#17341)
* [bcl][jit] implement Interlocked.Exchange<T> in terms of object

Exchange<T> is supposed to be picked up as an intrinsic.  But if it isn't,
since T has a class constraint, call the `Exchange (ref object, ref object, ref
object)` overload instead.

This works around a limitation in the JIT:
https://github.com/mono/mono/blob/82a07273c22b996b08fa88ee2e6632d782ac2242/mono/mini/mini-trampolines.c#L704-L713

if we're in the common call trampoline, and the caller is generic method and
the callee is a generic method, if we're using generic sharing for the caller,
but there's no generic jit info for the callee, we will not patch the call
site.

In this case we had Exchange<T> calling Exchange_T<T>
where the callee is an icall (and evidently didn't have generic jit info).

So every time we called Exchange<T>, we would go through the trampoline when
trying to call Exchange_T<T> without patching the call site.

Addresses part of https://github.com/mono/mono/issues/17334

* Bump Mono

* Also drop CompareExchange_T<T>

* Sprinkle some Unsafe magic.

Mark the non-icall methods that we expect the JIT to treet as intrinsics with [Intrinsic]

* aot-runtime doesn't need Volatile.Read<T>/Write<T> code

Both of those methods are implemented as calls to the object overload of Volatile.Read/Write
2019-10-16 15:35:49 -04:00
Egor Bogatov 58b53299b7 remove GenericVectorTests from rsp (#17366) 2019-10-16 15:24:16 -04:00
Jay Krell de9ccfa63f [cxx][netcore] Goto around init. (#17348)
[cxx][netcore] Goto around init.
2019-10-16 20:56:09 +02:00
Jay Krell 7067524141 [cxx][x86] ifndef DISABLE_JIT around mono_arch_emit_prolog. (#17346) 2019-10-16 20:28:24 +02:00
Egor Bogatov c13f36bdfe fix netcore build with cygwin (#17361) 2019-10-16 14:20:48 -04:00
Egor Bogatov 886cd73784 [netcore] Implement System.IO.HasOverriddenBeginEndRead(Write)… (#17237)
* Implement HasOverriddenBeginEndRead and HasOverriddenBeginEndWrite

* fix typo

* clean up

* more clean up

* more clean up

* convert into intrinsics

* handle end* methods

* Update intrinsics.c

* make cache_System_IO_Stream_slots static

* fix race condition

* Rollback to icall

* Update icall.c

* Address feedback

* Address feedback
2019-10-16 20:16:51 +02:00
Marek Safar be6f43c80e [System] Add reflection dependency tracking
for built-in type converters
2019-10-16 20:05:03 +02:00
Alexander Köplinger cd6e574b87 [ci] Improve netcore build telemetry by running nupkg and tests through build.sh (#17349)
Follow-up to https://github.com/mono/mono/pull/17331.

We were running nuget pack and tests explicitly in the Azure Pipelines
config so we weren't capturing failure telemetry.
2019-10-16 18:52:13 +02:00
Cody Russell 37dc33a257 [GTK] Bump bockbuild for GtkViewport autoscrolling patch. (#17321) 2019-10-16 16:44:26 +02:00
Jay Krell a03027cab0 Replace mono_assembly_name_free use with mono_assembly_name_free_internal. (#16982)
Replace mono_assembly_name_free use with mono_assembly_name_free_internal.

Maybe just remove the GC mode change and remove the internal form.
We don't really equate malloc/free with GC/locks/hangs, though arguably we should. Arguably this change is right.
2019-10-16 14:25:55 +02:00
Vlad Brezae 0aabccef9b [interp] Add constant propagation of integers (#17326)
* [interp] Make StackValue more intuitive

Replace the opcode field with an enum which will represent what type of value is contained (STACK_VALUE_LOCAL, STACK_VALUE_I4 etc)

* [interp] Add the mint type to the local data

Makes the emitting code easier and we no longer compute the mint type for each local access, which is fairly expensive.

* [interp] Handle indirect locals saner during cprop

Instead of checking for the indirect flag when loading from a local, simply never store a StackValue into such a local since we can't use it. We use the same logic when not pushing on the stack values for such locals.

* [interp] Add constant folding for integers

We decode the values from LDC_I4 and LDC_I8 opcodes and track/propagate the values on the stack and in the locals using the existing infrastructure. When loading a local, we try to load using the known constant value instead, so we might get to kill that local.

* [interp] Similar to stloc.np we can optimize pop/push pairs

If the pushing instruction pushes the same value that was popped by the previous instruction, we can kill them both

* [tests] Remove issue that seems to have been fixed for a while
2019-10-16 13:56:14 +03:00
Jay Krell 7d3fc17e81 Fix C++ WebAssembly build. (#17302) 2019-10-16 10:12:41 +02:00
Filip Navara 0c02bb1207 Fix SafeHandle marshalling in ref/in/out parameters (#17330)
* Fix SafeHandle marshalling in ref/in/out parameters

* Reorder code to make it exception safe, update comments

* Revert the code reordering because it breaks the invariant that new handle returned from native code should always create new SafeHandle on the managed side

* Fix test_0_safehandle_ref test. The test was expecting incorrect behavior, verified on .NET Core 3 and .NET Framework 4.8.

* Address PR feedback

* Fix cut & paste error

* Fix build

* Really fix the test_0_safehandle_ref tests

* Add more tests for SafeHandle marshalling

* Add exclusion for broken CoreFX test
2019-10-16 01:43:42 -04:00
Zoltan Varga d4d93b9699 [wasm] Add a --native-lib option to the packager to allow linking additional native libraries. (#17344) 2019-10-16 01:31:03 -04:00
Kenneth Pouncey 2b4790a1f3 [wasm][tests] WASM Safari browser tests (#16816)
* Add support for tests via safari browser

* Run safari browser tests on CI for Mac lanes

* Update to fix syntax error using UNAME to `if [[ ${CI_TAGS} == *'osx-amd64'* ]];`

* Fix syntax error with `if`
2019-10-16 04:59:55 +02:00
Kenneth Pouncey 2ddcf8cf16 Set default StreamingEnabled property of the WasmHttpMessageHandler to be false. (#17328) 2019-10-16 04:39:06 +02:00
Zoltan Varga 27247739c6 [wasm] Bump emscripten. Remove generated python cache files. (#17340)
* [wasm] Bump emscripten to 1.38.48.

* Remove generated python cache files.
2019-10-15 21:57:52 -04:00
Zoltan Varga 08e8a7f2c3 [jit] Fix is_reference checks for intrinsics with byref parameters. (#17338)
Found by https://github.com/mono/mono/issues/17335.
2019-10-15 21:45:04 -04:00
Ryan Lucia 3fa5f6c66e [loader] Add an explicit define DISABLE_DLLMAP to control dllmap usage (#17315)
* [loader] Add an explicit define ENABLE_DLLMAP to control dllmap usage

* Update configure.ac

* Update configure.ac

* Add dllmap to enable-minimal

* Change to DISABLE_DLLMAP

* Grab some missing MonoDllMap uses
2019-10-15 19:40:24 -04:00
Bernhard Urban-Forster 73ae9dbc36 [bcl] add WriteLine(string) override to CStreamWriter needed due to corefx import (#17336)
In https://github.com/mono/mono/commit/fd424c5dd07b2dbbd4aafbf9165a42166d789438 we switched over to the `TextWriter.cs`/`StreamWriter.cs` implementation of corefx. One subtle difference is that an override for `WriteLine(string)` in `StreamWriter` was introduced:
https://github.com/mono/corefx/blob/8e3b279377d1f01d2d089f24548e33855bf6502e/src/Common/src/CoreLib/System/IO/StreamWriter.cs#L526-L531
Previously the definition in `TextWriter` was used, which would call the base case `Write(char[],int,int)`.  The new override however won't call the base implementation at all, but directly uses the `Span`-variant.

This is a problem for our `CStreamWriter` implementation, since `WriteLine(string)` won't end up in the special handling for `Write(char[],int,int)`, which accounts for terminal cursor changes.

This is the real fix for https://github.com/mono/mono/issues/16701

This also reverts commit 68f5613422. ("[TermInfoDriver] update top/left value on Console.{CursorTop,CursorLeft} access (#16745)")
While it kind of masked the issue, it also posed a performance issue on some terminals (e.g. GNOME Terminal).
2019-10-15 22:29:41 +02:00
Jo Shields dc0eea6fd1 Initial telemetry for netcore builds (#17331)
* Load VSTS telemetry helpers into build.sh script

* First cut adding some basic VSTS-compatible telemetry on failures

* Don't make `ci=true` the default, make it a build.sh flag
2019-10-15 22:21:21 +02:00
Alexander Köplinger 82a07273c2 [ci] Always initialize an AzDO variable
Otherwise the script will not replace the variable and we get confusing error messages like this:

```
[command]/bin/bash --noprofile --norc /home/builder/azdo/_work/_temp/ba0890e7-8c80-4245-b9dc-14253b0d399f.sh
/home/builder/azdo/_work/_temp/ba0890e7-8c80-4245-b9dc-14253b0d399f.sh: line 2: llvm: command not found
/home/builder/azdo/_work/_temp/ba0890e7-8c80-4245-b9dc-14253b0d399f.sh: line 2: [: =: unary operator expected
```
2019-10-15 19:44:03 +02:00
Alexander Köplinger 3b56247afd [ci] Only install android-specific brew packages when building for android 2019-10-15 13:59:34 +02:00
Steve Pfister 806f75fe4f Bumps corefx to mono/corefx@8e3b279 (#17307)
Resolves https://github.com/mono/mono/issues/17288 where RequestUri
in HttpRequestMessage did not allow file:// based Uri's the same
way its constructor did.
2019-10-15 11:06:24 +02:00
Ryan Lucia a2ef1274c3 Update codeowners
Get notifications for various files in metadata
2019-10-15 10:28:31 +02:00
dotnet-maestro[bot] 55e87320f0 Update dependencies from https://github.com/dotnet/corefx build 20191013.1
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19513.1
2019-10-15 09:50:26 +02:00
dotnet-maestro[bot] 61db5aafdd Update dependencies from https://github.com/dotnet/core-setup build 20191014.1
- Microsoft.NETCore.App - 5.0.0-alpha1.19514.1
2019-10-15 09:50:26 +02:00
dotnet-maestro[bot] 140750f543 Update dependencies from https://github.com/dotnet/arcade build 20191011.1
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19511.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19511.1
2019-10-15 09:50:26 +02:00
dotnet-maestro[bot] 5a6fb5abe7 Update dependencies from https://github.com/dotnet/corefx build 20191008.3
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19508.3
2019-10-15 09:50:26 +02:00
dotnet-maestro[bot] f068c89ca2 Update dependencies from https://github.com/dotnet/core-setup build 20191008.2
- Microsoft.NETCore.App - 5.0.0-alpha1.19508.2
2019-10-15 09:50:26 +02:00
Filip Navara ac1d05ad40 Update CoreFX.issues.rsp
See https://github.com/mono/mono/pull/17232#issuecomment-541973035.
2019-10-14 19:46:39 -05:00
Filip Navara a194de4cdf [netcore] Avoid suspending threads in Environment.Exit, it can hang process (#17318)
CoreCLR doesn't suspend threads on exit (https://github.com/dotnet/corefx/pull/41450#issuecomment-536755093, https://github.com/dotnet/coreclr/pull/1813).

Fixes #17317 
Fixes #15006
Fixes #15010
Fixes #15181

Unblocks #17232
2019-10-15 00:35:26 +02:00
Alexander Köplinger 1a21ad7dd0 [ci] Restore previous values for no Xcode in CI_TAGS
It is still used by the non-pipeline PR builds (we should unify this at some point).
2019-10-14 20:38:46 +02:00
Filip Navara 76068d8d61 Remove broken sin/cos optimization for x86 2019-10-14 12:21:15 -05:00
Filip Navara 05df3970c2 Remove broken sin/cos optimization for x64 2019-10-14 12:21:15 -05:00
Kenneth Pouncey 44e99c5eec [wasm] Continue loading app even when .pdb files are not found (#17266)
* This adds the ability to continue loading the application even though the .pdb files are not found.

When uploading an app built with mono-wasm the `.pdb` may not get committed so they will not exist when trying to load them.

- Add new boolean variable to MONO library support to control skipping these files on errors.
	- `mono_wasm_ignore_pdb_load_errors` default is true

- Modify the assembly file fetching routine `mono_load_runtime_and_bcl` within our MONO module.
	- Allows skipping the .pdb files if the `mono_wasm_ignore_pdb_load_errors` flag is true.
2019-10-14 12:10:43 -05:00
Fan Yang dcb522d181 [netcore] Update dotnet sdk version (#17312)
The previous one was broken.
2019-10-14 18:55:39 +02:00
Johan Lorensson 734b776884 Fix msvc build warning, empty source main-core.c. (#17305) 2019-10-14 18:55:07 +02:00
Alexander Köplinger 7de84059b9 [ci] Fix ios versions in Mono SDKs and fix typo 2019-10-14 18:54:25 +02:00
Ryan Lucia e7b199377c [loader] Locking and coop related cleanup; fix leak 2019-10-14 12:51:29 -04:00
Ryan Lucia bf3afd6cad [loader] Move PInvoke and DllMap code into separate source file 2019-10-14 12:51:29 -04:00
Ryan Lucia 80db55591a [netcore] Remove unused InternalLoadUnmanagedDllFromPath
As of https://github.com/dotnet/coreclr/pull/27090
2019-10-14 12:51:29 -04:00
Ryan Lucia 96050effa6 [netcore] Use a single NativeLibrary.cs for all platforms 2019-10-14 12:51:29 -04:00
Alexander Köplinger 850def2f3b [ci] Use Xcode11.1 for XI/XM Mono SDK builds (#17313)
As requested by the xamarin-macios team.
2019-10-14 18:38:06 +02:00
Marek Safar cae52aa4a6 [System.Net.Http] Clean up HttpMessageHandler setup (#17252)
* [System.Net.Http] Clean up HttpMessageHandler setup

to avoid reflection and not to be recursive

Superseded #15051 and #15922

* [csproj] Update project files
2019-10-14 17:19:22 +02:00
Dotnet-GitSync-Bot 4e81814709 Mirror changes from mono/coreclr (#17297)
* Enable fast-paths on Mono for Array (dotnet/coreclr#27144)

Signed-off-by: dotnet-bot <[email protected]>

* [CoreLib] Remove String fields moved to shared

* Stub Array Try* methods
2019-10-12 08:50:00 +02:00
Ryan Lucia 9832bbb0ac [loader] Fix gnu/lib-names.h define (#17294) 2019-10-11 20:49:24 -04:00
Jay Krell 33d62537d4 [runtime] Add portable cached array creation functions and replace gcc-specific impl. (#16855)
* Remove unused mono_class_get_field_from_name_cached.

* Replace gcc-specific:
  mono_array_class_get_cached
  mono_array_new_cached
  mono_array_new_cached_handle

with portable forms that are easy enough to use and general enough.

Before was "easier" because cache provided for you -- possibly multiple.
Before was more general because rank was a parameter -- and had to be a constant.
It was always 1.
2019-10-11 19:47:20 -04:00
Egor Bogatov 9cc5ea3862 Enable more hw intrinsics for AOT (#17160)
* Enable more hw intrinsics for AOT

* Address feedback

* does it fix the failure?

* fix loadedllvm

* Address feedback

* fix copy-paste

* forgot MONO_LLVM_INTERNAL
2019-10-11 15:09:08 -04:00
Aleksey Kliger (λgeek) 7f95f57c43 [sdks] Android runner: properly shutdown runtime for Mono.Debugger.Soft test app (#17261)
* [sdks] properly shutdown runtime for Mono.Debugger.Soft test app

mini_jit_cleanup will cause mono_runtime_try_shutdown to be called before
mono_runtime_quit which will set the shutting down flags in the runtime.

* [test] Re-enable disabled tests
2019-10-11 13:54:19 -04:00
Kyle White 481b3005c6 Update MERP event type to MonoAppCrash (#17131)
* Update parameters in MERP WerReportMetadata xml

To enable backend analysis, we need to update our parameters to match our back end event type, which is MonoAppCrash.

It doesn't make sense to me that the previous implementation constructed the XML here in Mono, but depended on the user (VSMac in this case) to add the "correct" event type.  The parameters in the XML, must match exactly what is expected for the given EventType, and so we should ensure they are always in-sync by defining them here.  Thus, I removed the usage of `eventType` in `mono_merp_enable` and hard coded the expected eventType.

* [merp] Don't pass eventType from managed

The eventType must me MONO_MERP_EVENT_TYPE_STR ("MonoAppCrash") - the backend
determines the format of the other fields based on the event type, so it
doesn't make sense to pass other values from managed since the runtime controls
the other fields.

For compatability Mono.Runtime.EnableMicrosoftTelemetry will still take a
string parameter (now called "unused" instead of "eventType_str") but it will
not pass it down to the internal call.

* Bump corlib version

* [merp] Revert paramerters in WerReportMetadata.xml

Still need event type to be `MonoAppCrash` but the parameters will be the same as before.
2019-10-11 11:15:21 -04:00
Alexander Köplinger d457346e06 [tests] Bump corefx to get Azure testhost change (#17275)
* Bump corefx to get Azure testhost change

See https://github.com/mono/corefx/pull/360

* Update ClientWebSocketTest as well
2019-10-11 09:34:28 +02:00
Tanner Gooding 5784d064e7 Refactoring the ARM intrinsics to match API review and share code with x86 (#25508)
* Rewriting the ARM64 HWIntrinsic JIT infrastructure to share with and mirror the x86 infrastructure where possible.

* Lowercasing the hwintrinsicarm64 and hwintrinsiclistarm64 files.

* Applying formatting patch.

* Fixing up some names in the PAL and VM that were missed.

* Adding support for AdvSimd.Add

* Ensure impSpecialIntrinsic returns nullptr for unsupported base types.

* Rewording various method headers and simplifying some code.

* Fixing getEmitter to GetEmitter

* Adding support for the ld1 instruction

* Applying formatting patch

* Clarifying a todo comment and removing a stray newline

* Fixing the Arm64 impSpecialIntrinsic to not assert for helper intrinsics

* Fixing some intrinsic signatures that were incorrect

* Adding the initial template files for generating Arm HWIntrinsic tests

* Generating the initial batch of Arm HWIntrinsic tests

* Replace gtRegNum with GetRegNum()

* Fixing the test template alignment checks for Arm

* Regenerating the Arm HWIntrinsic tests

* Fixing the namespace checked for Arm intrinsics

* Changing Base to ArmBase and fixing some Arm hwintrinsic metadata

* Fixing the arm emitter and lowering to not assert for hwintrinsics

* Fixing the arm intrinsics to not set the number of vector elements for SIMDScalar intrinsics

* Updating the AdvSimd.Abs tests to use negative input values

* Regenerating the arm hwintrinsic tests

* Fixing the arm hwintrinsic codegen to use the element size for simd scalar operations.

* Fixing the arm scalar intrinsic tests to check for 0 on upper bits

* Regenerating the ARM intrinsic tests

* Fixing AdvSimd.AbsScalar and AdvSimd.AddScalar to be recursive

* Marking AdvSimd.Arm64 and ArmBase.Arm64 as implemented

* Ensure that AdvSimd.Arm64.Abs is marked as variable size

Signed-off-by: dotnet-bot <[email protected]>
2019-10-11 08:14:11 +02:00
Imran Hameed 7c7d406fc0 Generate LLVM IR for OP_XEQUAL that is recognized by LLVM's vector pattern recognizers. 2019-10-10 16:05:34 -07:00
Jo Shields 5567c83049 Update Linker. This fixes a Xamarin.Android breakage (#17272) 2019-10-10 16:26:10 -04:00
Vlad Brezae 165c114aaa [interp] Kill more instructions (#17226)
* [interp] Replace STLOC to dead local with MINT_POP

* [interp] Optimize MINT_POP

It was only used for 0 and 1 values. The implementation for values larger than 1 was broken anyway.

* [interp] Remove unnecessary usage of MINT_POP1

When storing a static field from a CEE_STFLD instruction.

* [interp] Prevent optimizing away the stack, after a branch

We know the contents of the stack following a branch, so we could have optimized away some instructions preceding the branch. We shouldn't do this because the code we are branching to expects a certain stack size.

* [interp] Clear instructions which push unused values on stack

* [interp] Properly initialize stack when pushing local
2019-10-10 21:29:19 +02:00
monojenkins 3ef0544e7a [csproj] Update project files 2019-10-10 19:43:11 +02:00
Marek Safar 502115435d [System.Net.Http] Make HttpClientHandler on WatchOS always fallback
to platform handler. This simplifies HttpClientHandler in shared libraries
and the "default" socket handler would always throw PNSE anyway
2019-10-10 19:43:11 +02:00
Ryan Lucia 1b6bbfaf36 [eglib] Add newline for failure check prints (#17262) 2019-10-10 09:23:16 -04:00
Johan Lorensson 0db52289a3 Incorrect constrained virtual call in method using gsharedvt for reference type. (#17227)
* Incorrect constrained virtual call in method using gsharedvt for reference type.

For generic constrained virtual calls using reference type's, the
virtual call will be dispatched using instance vtable. When the same
virtual call is taking place in a gsharedvt method, mono_gsharedvt_constrained_call
gets called that will assist making the call, the problem is that it will
use the constrained class for reference types meaning that it will not call
the most derived implementation of the method. This difference in the behavior
compared to none gsharedvt versions of methods, gives inconsistent results.

One way this will reproduce is by using Dictionary<Type, EmptyStruct>. For
methods that will take both Type (reference type) and EmptyStruct (value type)
like Add, calling that through IDictionary (hiding details from compiler) will
use the gsharedvt version of the method. Internally that method will call
Type.GetHashCode (), and since Type really is a RuntimeType it overrides
GetHashCode. But since mono_gsharedvt_constrained_call will use the constrained
class instead of the instance class, the called method will be
Object.GetHashCode, that gives a different result. When later ContainsKey
is called using the same Type, it only takes a reference value, so not
using a gsharedvt version of the method, then the most derived version of
GetHashCode will be called, given a different hash, not finding item
in dictionary.

Fix is to make sure behavior in mono_gsharedvt_constrained_call match
behavior for regular constrained virtual calls when having a reference type.
This makes sure we always call the most derived version of the method.

Commit also adds a test for this specific scenario using a dictionary.

* Updated to a more low-level test.
2019-10-10 09:22:54 -04:00
Bernhard Urban-Forster 6ebf07f2cd [mini] trace snippet should restore return value (#17251)
* [mini] trace snippet should restore return value

This is a problem on architectures with a floating point stack (x86).

Without this PR and without `--trace` the managed-to-native wrapper for `Math.Ceiling` has a basic block like this at the end:

```
AFTER LOWER-VTYPE-OPTS  4: [IN:  BB6(5) BB3(1), OUT:  BB1(3) ]
 fmove R34 <- R16
 ldaddr R35 <- R10
 load_membase R37 <- [R35 + 0x0]
 store_membase_reg [R36] <- R37
 il_seq_point il: 0x2d
```

`R16` contains the return value. `ldaddr`/`load_membase`/`store_membase_reg` is the sequence for LMF popping.  `mono_spill_global_vars` does this with it:

```
 SPILL BLOCK 4:
 fmove R34 <- R16
         ff  34 16
        0  loadr8_membase R34 <- [%ebp + 0xffffffd4]
        1  nop
 ldaddr R35 <- R10
         ii  35 5
        1  add_imm R35 <- %ebp [-36] clobbers: 1
 load_membase R37 <- [R35 + 0x0]
         ii  37 35
        1  load_membase R37 <- [R35 + 0x0]
 store_membase_reg [R36] <- R37
          ii -1 37
        1  store_membase_reg [%edi] <- R37
 il_seq_point il: 0x2d
             -1
        1  il_seq_point il: 0x2d
```

The local register allocator takes care of the FP stack handling:

```
processing:     0  loadr8_membase %fr0 <- [%ebp + 0xffffffd4]
        [%fr0]
processing:     0  load_membase %eax <- [%ebp + 0xffffffdc]
        [%fr0]
processing:     0  store_membase_reg [%edi] <- %eax
        [%fr0]
processing:     0  il_seq_point il: 0x2d
        [%fr0]
```

At the end of the basic block we have one value left on the FP stack. That's good as we are in the `cfg->bb_exit` basic block, so this is ought to be the return value.

Let's enable `--trace=M:System.Math:Ceiling`. It will insert some code in order to copy arguments/return value to some datastructure that can then be printed by the trace code:

```
processing:     0  loadr8_membase %fr0 <- [%ebp + 0xffffffd4]
        [%fr0]
processing:     0  iconst %eax <- [11116832]
        [%fr0]
processing:     0  iconst %eax <- [52]
        [%fr0]
processing:     0  localloc_imm %eax <-
        [%fr0]
processing:     0  localloc_imm %ecx <-
        [%fr0]
processing:     0  store_membase_reg [%eax + 0x30] <- %ecx
        [%fr0]
processing:     0  x86_lea_membase %edx <- %ebp
        [%fr0]
processing:     0  store_membase_reg [%ecx] <- %edx
        [%fr0]
processing:     0  store_membase_imm [%eax + 0x28] <- [11116832]
        [%fr0]
processing:     0  storer8_membase_reg [%ebp + 0xffffffcc] <- %fr0
        []
processing:     0  x86_lea_membase %ecx <- %ebp
        []
processing:     0  store_membase_reg [%eax + 0x2c] <- %ecx
        []
processing:     0  store_membase_reg [%esp + 0x4] <- %eax
        []
processing:     0  store_membase_imm [%esp] <- [11116832]
        []
processing:     0  voidcall [mono_trace_leave_method] clobbers: c
        []
processing:     0  x86_lea_membase %eax <- %ebp
        []
processing:     0  load_membase %eax <- [%ebp + 0xffffffdc]
        []
processing:     0  store_membase_reg [%edi] <- %eax
        []
processing:     0  il_seq_point il: 0x2d
        []
```

At the very beginning we push some value on the FP stack, same as before. However the code inserted by the tracing code will pop that value. Now, when returning to the, it will pop again something from the FP stack, but alas it's gonna be garbage.

With this PR it looks like this:

```
processing:     0  loadr8_membase %fr0 <- [%ebp + 0xffffffd4]
        [%fr0]
processing:     0  iconst %eax <- [11116832]
        [%fr0]
processing:     0  iconst %eax <- [52]
        [%fr0]
processing:     0  localloc_imm %eax <-
        [%fr0]
processing:     0  localloc_imm %ecx <-
        [%fr0]
processing:     0  store_membase_reg [%eax + 0x30] <- %ecx
        [%fr0]
processing:     0  x86_lea_membase %edx <- %ebp
        [%fr0]
processing:     0  store_membase_reg [%ecx] <- %edx
        [%fr0]
processing:     0  store_membase_imm [%eax + 0x28] <- [11116832]
        [%fr0]
processing:     0  storer8_membase_reg [%ebp + 0xffffffcc] <- %fr0
        []
processing:     0  x86_lea_membase %ecx <- %ebp
        []
processing:     0  store_membase_reg [%eax + 0x2c] <- %ecx
        []
processing:     0  loadr8_membase %fr0 <- [%ebp + 0xffffffcc]
        [%fr0]
processing:     0  store_membase_reg [%esp + 0x4] <- %eax
        [%fr0]
processing:     0  store_membase_imm [%esp] <- [11116832]
        [%fr0]
processing:     0  voidcall [mono_trace_leave_method] clobbers: c
        [%fr0]
processing:     0  x86_lea_membase %eax <- %ebp
        [%fr0]
processing:     0  load_membase %eax <- [%ebp + 0xffffffdc]
        [%fr0]
processing:     0  store_membase_reg [%edi] <- %eax
        [%fr0]
processing:     0  il_seq_point il: 0x2d
        [%fr0]
```

Leaving us the return value on the FP stack before returning.

Fixes https://github.com/mono/mono/issues/16410
2019-10-10 11:21:23 +02:00
Jay Krell 8c5581a6f2 Fix g_assert_not_reached message regression. (#17263)
Fix g_assert_not_reached message regression.
2019-10-10 10:26:14 +02:00
Vlad Brezae d4fbbed106 [tests] Disable tests that crash on android sdks (#17255)
Running these tests makes the application crash, probably at shutdown. Even if the tests are reported as passing, check if disabling them fixes the suite timeout on android osx sdks.
2019-10-10 10:51:53 +03:00
Jay Krell 8718b75b7a Remove varargs from g_assert and g_assert_not_reachable. (#17254)
Remove varargs from g_assert and g_assert_not_reachable (save 200+ bytes per frame in wasm interp).

g_assertf unchanged.

I have a strong suspicion, this will save approximately 432 - sizeof (InterpFrame) bytes of stack
per function call in the WebAssembly interpreter.

It will not significantly benefit or hurt any other system.
Systems with disabled asserts will receive a small size improvement.

WebAssembly has no provision for varargs.
Emscripten emulates it.
It appears the emulation allocates room in the frame per outgoing varargs call.
No stack packing.
So each g_assert takes space.

Alternative would be to discourage or disable or remove asserts.
2019-10-09 22:56:06 +02:00
David Bueno 7df7ceb6d3 [System.Web] Now IsExpired property for FormsAuthenticationTicket compares two dates with same kind (UTC) to avoid unexpected results (#17162)
Fixes #17161
2019-10-09 20:50:46 +02:00
Steffen Kieß 30886f997f [Mono.Posix] Add support for memfd_create() and file sealing (#17225)
* [Mono.Posix] Add support for memfd_create() and file sealing

Add the linux syscall memfd_create() and add support for file sealing with
fcntl().

* Bump API snapshot submodule
2019-10-09 20:49:14 +02:00
Bernhard Urban-Forster 1cf081529e [mini] print inserted instruction in verbose logging (#17249)
[mini] print inserted instruction in verbose logging

before:
```
 fmove R11 <- R9
         ff  11 9
        1  nop
```

after:
```
 fmove R11 <- R9
         ff  11 9
        0  loadr8_membase R11 <- [%ebp + 0x8]
        1  nop
```
2019-10-09 20:16:04 +02:00
Filip Navara cbc8cc658b [mini] Fix check for FastAllocateString that used old name (#17219)
* Fix check for FastAllocateString that used old name

* Fix linker scripts

* Update the icall name for FastAllocateString to match managed name

* Update size check in managed allocator

* One more 64-bit target fix
2019-10-09 15:47:43 +02:00
Vlad Brezae 8e649c3545 [sgen] Fix invalid value passed to write barrier (#17236)
When doing memory copy dest is the destination address and src is the source address. If we are copying a single reference, we need to emit a write barrier and pass to the write barrier the value, not the pointer where the value is stored.
2019-10-09 14:37:41 +03:00
Alexander Köplinger 1e9ba3a026 Add drawing type converters to mobile profiles (#17238)
* Add drawing type converters to mobile profiles

Needed for https://github.com/xamarin/xamarin-android/issues/3726

* Bump API snapshot submodule

* [csproj] Update project files
2019-10-09 12:17:53 +02:00
Johan Lorensson 7fad4a12e2 Running --enable-msvc-only didn't find jay.vcxproj. (#17228) 2019-10-09 10:06:09 +02:00
Egor Bogatov 12ff246297 Optimize ToString() for byte, ushort, uint and ulong (dotnet/coreclr#27056)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-09 09:25:18 +02:00
Filip Navara 28b3446d9e [netcore] Fix NULL dereference when running LLVM JIT 2019-10-09 08:39:22 +02:00
Ryan Lucia 1cfb39203b Replace InternalLoadUnmanagedDllFromPath with NativeLibrary.Load (#27090)
Both just call into NDirect::LoadLibraryFromPath, and so this simplifies the code by removing a superfluous QCall

Signed-off-by: dotnet-bot <[email protected]>
2019-10-09 08:23:30 +02:00
Jay Krell cacf99b973 Revert mono_runtime_set_main_args in 44ff0597b8. (#17233)
It breaks Xamarin.Android.
2019-10-09 00:54:44 -04:00
Vlad Brezae 579e385b96 [interp] Small cleanups (#17229)
* [intepr] Add define for constant

* [interp] Pass separately pop_vt_sp argument

Cleans up the code a bit. There is no need to do fancy bit operations for such a slow opcode.
2019-10-09 00:08:44 +02:00
Filip Navara 63025d93fd [netcore] Port CoreCLR implementation of Exception.SetCurrentStackTrace (#17243)
* Port CoreCLR implementation of Exception.SetCurrentStackTrace

* Update SerializationRemoteStackTraceString

* Update Exception.cs
2019-10-08 23:45:17 +02:00
Alexander Köplinger 4ca42a933f [man] Update MONO_IOMAP docs as it no longer works with corefx System.IO (#17231)
Fixes https://github.com/mono/mono/issues/15845
2019-10-08 21:39:31 +02:00
Alexander Köplinger 209c4bae3e [netcore] Disable some SafeWaitHandle tests everywhere, not just Linux (#17230)
The tests are kinda bogus since they create a SafeWaitHandle from `new IntPtr(1)` which causes a crash during finalization when releasing that handle.

See https://github.com/mono/mono/issues/17224
2019-10-08 17:39:41 +02:00
dotnet-maestro[bot] 52c4d87633 Update dependencies from https://github.com/dotnet/arcade build 20191006.1 (#17214)
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19506.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19506.1
2019-10-08 13:30:46 +02:00
Filip Navara e8ed2494ca Fix check in fix_libc_name to trigger only for libc, not or other names with same prefix (#17222)
See https://github.com/mono/mono/pull/17210#pullrequestreview-298663220
2019-10-08 13:06:38 +02:00
Alexander Köplinger faf100da27 [support] Make sure map-impl.h ends up in the tarball 2019-10-08 12:05:47 +02:00
Steffen Kieß 8bb7b8645a Clean up map.c /map.h (#16746)
* [Mono.Posix] Move Mono_Posix_{From,To}MremapFlags() to support/sys-mman.c

Since b522eab5ff Mono_Posix_FromMremapFlags()
and Mono_Posix_ToMremapFlags() contain manual changes for NetBSD. Move the
functions from support/map.c to support/sys-mman.c so that they won't be
overwritten when create-native-map is rerun.

* [Mono.Posix] Fix prototypes in support/stdio.c

In ed892ccf27 wrapper functions for several
stdio functions were added, but the prototypes in map.h were manually
written, not using create-native-map. This commit changes the prototypes so
that they match the output of create-native-map.

* [Mono.Posix] Undefine HAVE_STRUCT_SOCKADDR_IN6 in support/map.c on MSVC

In 22b6b95814 a manual change to support/map.c
was added to prevent Mono_Posix_FromSockaddrIn6() and
Mono_Posix_ToSockaddrIn6() from being built for windows even if
HAVE_STRUCT_SOCKADDR_IN6 is defined. Instead undefine it in a header file
to avoid manual changes to map.c.

With this commit map.c, map.h and NativeConvert.generated.cs contain no
manual changes anymore.
2019-10-08 12:04:45 +02:00
monojenkins ad2132e611 [bcl] Update BCL Linked Size 2019-10-08 10:23:41 +02:00
Ryan Lucia 3355d2dd81 [netcore] Add libc name transition 2019-10-08 10:22:18 +02:00
Alexis Christoforides 37c197f225 Remove unused variable 2019-10-07 21:04:47 -05:00
Alexis Christoforides 2ca93bd2f9 [merp] Print missing status marker file for stage 1 (setup) 2019-10-07 21:04:47 -05:00
Alexis Christoforides b18d52bf1c Zeroing is not necessary, snprintf() always null-terminates in this case 2019-10-07 21:04:47 -05:00
Vlad Brezae d9c9a53332 [interp] Rerun cprop pass if stloc.np intructions were eliminated
If we eliminate these instructions, it means we removed instructions that use the top of stack. Without them we might be able to optimize away that stack slot usage. If we retraverse the instruction stream, then we must handle movloc and stloc.np separately.
2019-10-07 19:35:57 -05:00
Vlad Brezae f2006f61dc [interp] Handle more cases for stloc.np optimization
We emit stloc.np if we have "stloc local; ldloc local". Bu we can also emit if we have "stloc loc1; ldloc loc2" and loc2 == loc1.
2019-10-07 19:35:57 -05:00
Vlad Brezae fc100ae043 [interp] Skip NOPs when checking previous instruction
When emitting stloc.np, which looks for stloc/ldloc pair.
2019-10-07 19:35:57 -05:00
Calvin Buckley 01dd63c440 dladdr shim for gmodule; try to enable crash reporter on AIX (#15808)
* Introduce new dladdr wrapper in glib, AIX reimpl, and convert usage

Provides a wrapper around dladdr that should be platform-neutral.

Also provided is a reimplementation for AIX, which should enable
that platform to get some previously dladdr-specific functions like
the crash reporter. It is somewhat flawed in that it only gets info
for symbols in .text, returns non-constant allocated strings, and
allocates heap memory for buffers.

Then convert usages (except a macOS specific one) of dladdr to the
new eglib function. It has a different signature, which should
simplify intent and reduce structiness. Also free memory on AIX due
to limitations of its reimplmenetation.

* Enable (and fix build of) crash reporter on AIX

So far crashes don't seem any different, but the code for it is
built.

* typo fix (guess this isn't compiled on aix)

* attempt to fix macOS and win32 builds

* Implement more of g_module_address on Win32

Implements the filename stuff. Untested; don't have Windows.

* Look for backtrace_symbols in an IBM compat library for i

Enables i to natively dump a stack trace. (AIX "works" too if you
copy the compat lib's code and hack it in - it probably needs to be
in EGlib.) Unfortunately, it's not perfect. The backchain from the
signal handler is empty on i, and AIX sometimes mangles the stack
frame in a way that severely confuses the backtrace code, causing
it to dereference invalid memory by interpreting instructions as a
pointer. (I have seen somewhat similar for the sigaltstack case,
where the native memory dump attempts to read something it should
not.) Perhaps mincore could be used, but that feels like a sloppy
workaround, especially in the "AIX making an invalid stack frame"
case.

* If the file isn't an archive, don't format its name like one

* Fix up search for backtrace_symbols to look in libexecinfo

FreeBSD ships it in base and Haiku has a package; likely others too.

* Win32 suffers in g_module_address as well

* That should habe been guarded with AIX due to limitations

Otherwise seems to free things that shouldn't be freed

* Casting for win32

* Fix up Win32 impl of module address

* Free HMODULE to lower reference count after using it

* Change dladdr based impl to always dup for impl consistency

Means freeing afterwards shouldn't be ifdefable.

* probably shouldn't strdup NULL

Likely why macOS has failures.

* Don't dup/return const strs, but copy to caller-provided buffers

...which can be on the stack. This makes it far less risky to use
in a crash reporter scenario, because malloc can be hosed then.

Also fix profiler up better to work with this new reality.
2019-10-08 00:19:28 +02:00
Zoltan Varga c7f8e5bdb7 [offsets-tool] Update the README. (#17212) 2019-10-07 22:37:09 +02:00
Jo Shields d28d72cb96 Bump version to 6.9 (#17207)
* Bump version to 6.9

* Add missing new linker source file

* [csproj] Update project files

* No monolinker on MCS mode, new linker version needs Roslyn
2019-10-07 22:36:13 +02:00
Ryan Lucia 1d18c27dbe Don't declare mono_get_module* on non-win32 2019-10-07 09:44:41 -05:00
Ryan Lucia ca5926fa3f Use eglib win32 helper functions without MAX_PATH limit 2019-10-07 09:44:41 -05:00
Ryan Lucia d12db16723 Escape type namespaces, document that we aren't escaping names for now 2019-10-07 09:43:47 -05:00
Ryan Lucia 8760cd446c Make the mono identifier escape function work like unescape and public 2019-10-07 09:43:47 -05:00
Ryan Lucia 7c2d2a551c Unescape type names in the managed parser 2019-10-07 09:43:47 -05:00
Ryan Lucia f37c3a649f Make TypeNameParser consistently use tabs
Is this worth the line damage? Unsure.
2019-10-07 09:43:47 -05:00
Ryan Lucia fa8fbbbc36 Partially revert "Remove redundant function call of EscapeTypeName to make (#16425)"
This partially reverts commit abe48e3fd4.
2019-10-07 09:43:47 -05:00
Jay Krell f0ff9f3860 Do not zero localalloc if not asked. (#16881)
Note that we will still touch the pages (mono_emit_stack_alloc).
2019-10-07 09:42:13 -05:00
Jay Krell 957e6fa4dd [Coop] Convert Get/SetGenericValueImpl. (#17034)
This is an alternative to https://github.com/mono/mono/pull/16994
and does *not* depend on
   https://github.com/mono/mono/pull/16987
or https://github.com/mono/mono/pull/17009
or similar.
2019-10-07 09:40:22 -05:00
Alexander Köplinger 495b08a3c7 Default --host in autogen.sh on cygwin when missing. (#17164) 2019-10-07 16:38:49 +02:00
Ryan Lucia 6f72363932 [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17177)
This brings us in line with GetDiskFreeSpaceExW on Windows as well as .NET Core.
2019-10-07 09:38:23 -05:00
Junil Um 026d82fac3 Fixed a bug in mono-service.cs (#17095)
There is a bug in mono-service.cs file.

`setup.ApplicationBase = Environment.CurrentDirectory;`;

General `Environment.CurrentDirectory` does returns `Directory.GetCurrentDirectory()`.
And retuened value 'current path' without last character `/` but `AppDomain.CurrentDomain.BaseDirectory`;

It have a problem in my service application.

In my service application code,

```cs
using System;
using System.IO;

namespace BaseDirTest
{
    internal class Program
    {
        public static void Main(string[] args)
        {
            var baseDir = AppDomain.CurrentDomain.BaseDirectory;
            Console.WriteLine($"baseDir={baseDir}");
            Console.WriteLine($"Path.GetDirectoryName(baseDir)={Path.GetDirectoryName(baseDir)}");
        }
    }
}
```

When I launch `mono app.exe`,
```bash
baseDir=/workspace/test/mono-owin-test/ConsoleApplication1/BaseDirTest/bin/Debug/
Path.GetDirectoryName(baseDir)=/workspace/test/mono-owin-test/ConsoleApplication1/BaseDirTest/bin/Debug
```

But when I launch `mono-service --no-daemon app.exe`,
```bash
eDir=/workspace/test/mono-owin-test/ConsoleApplication1/mono-service-umc/bin/Debug
Path.GetDirectoryName(baseDir)=/workspace/test/mono-owin-test/ConsoleApplication1/mono-service-umc/bin
```

Because my service application can not founds plugin directory and scans it.
2019-10-07 16:28:40 +02:00
Bernhard Urban-Forster 6861610662 [lldb] use mono_method_full_name helper (#16934)
[lldb] use mono_method_full_name helper

Instead of:

```
(lldb) mbt 20
* thread #11
  * frame #0: 0x1bf28f28 libsystem_kernel.dylib`__pthread_kill + 8
    frame #1: 0x1bf9caac libsystem_pthread.dylib`pthread_kill + 300
    frame #2: 0x1be66080 libsystem_c.dylib`abort + 140
    frame #3: 0x024bdfa0 monotouchtest`log_callback(log_domain=0x00000000, log_level="error", message="../../../../../mono/metadata/object.c:1905: Expected GC Unsafe mode but was in STATE_BLOCKING state", fatal=4, user_data=0x00000000) at runtime.m:1251:3
    frame #4: 0x02487f44 monotouchtest`monoeg_g_logv_nofree(log_domain=0x00000000, log_level=G_LOG_LEVEL_ERROR, format=<unavailable>, args=<unavailable>) at goutput.c:149:2 [opt]
    frame #5: 0x02487ee0 monotouchtest`monoeg_g_logv(log_domain=<unavailable>, log_level=<unavailable>, format=<unavailable>, args=<unavailable>) at goutput.c:156:10 [opt]
    frame #6: 0x02487f74 monotouchtest`monoeg_g_log(log_domain=<unavailable>, log_level=<unavailable>, format=<unavailable>) at goutput.c:165:2 [opt]
    frame #7: 0x024694c4 monotouchtest`assert_gc_unsafe_mode(file="../../../../../mono/metadata/object.c", lineno=1905) at checked-build.c:396:3 [opt]
    frame #8: 0x023d2f64 monotouchtest`mono_class_vtable_checked(domain=0x16d64800, klass=0x173c1b98, error=0x194b0ee8) at object.c:1905:2 [opt]
    frame #9: 0x024130a8 monotouchtest`get_current_thread_ptr_for_domain(domain=0x16d64800, thread=0x02db45d0) at threads.c:635:2 [opt]
    frame #10: 0x024119a8 monotouchtest`mono_thread_current at threads.c:2026:23 [opt]
    frame #11: 0x02416998 monotouchtest`mono_thread_interruption_checkpoint_request(bypass_abort_protection=0) at threads.c:5101:35 [opt]
    Messaging::void_objc_msgSendSuper @ 388435850 "calli.nat.fast" || frame #12: 0x024d5de8 monotouchtest`interp_exec_method_full(frame=0x194b11c0, context=<unavailable>, clause_args=<unavailable>, error=<unavailable>) at interp.c:3230:4 [opt]
    ObjCExceptionTest::InvokeManagedExceptionThrower @ 388435752 "vcall" || frame #13: 0x024d64dc monotouchtest`interp_exec_method_full(frame=0x194b1380, context=<unavailable>, clause_args=<unavailable>, error=<unavailable>) at interp.c:3400:4 [opt]
    ExceptionsTest::ManagedExceptionPassthrough @ 388502134 "vcallvirt.fast" || frame #14: 0x024d61c0 monotouchtest`interp_exec_method_full(frame=0x194b14e0, context=<unavailable>, clause_args=<unavailable>, error=<unavailable>) at interp.c:3325:4 [opt]
    Object::runtime_invoke_direct_void__this__ @ 388462550 "vcall" || frame #15: 0x024d64dc monotouchtest`interp_exec_method_full(frame=0x194b1598, context=<unavailable>, clause_args=<unavailable>, error=<unavailable>) at interp.c:3400:4 [opt]
    frame #16: 0x024d46ec monotouchtest`interp_runtime_invoke(method=<unavailable>, obj=0x0302c5f0, params=0x00000000, exc=0x194b166c, error=0x194b18c8) at interp.c:1766:2 [opt]
    frame #17: 0x0232b39c monotouchtest`mono_jit_runtime_invoke(method=0x174fda58, obj=<unavailable>, params=0x00000000, exc=<unavailable>, error=0x194b18c8) at mini-runtime.c:3170:12 [opt]
    frame #18: 0x023d5cc8 monotouchtest`do_runtime_invoke(method=0x174fda58, obj=0x0302c5f0, params=0x00000000, exc=0x00000000, error=0x194b18c8) at object.c:3017:11 [opt]
    frame #19: 0x023d26a0 monotouchtest`mono_runtime_invoke_checked(method=<unavailable>, obj=<unavailable>, params=<unavailable>, error=<unavailable>) at class-getters.h:24:1 [opt] [artificial]
```

It prints now:

```
(lldb) mbt 20
* thread #11
  * frame #0: 0x1bf28f28 libsystem_kernel.dylib`__pthread_kill + 8
    frame #1: 0x1bf9caac libsystem_pthread.dylib`pthread_kill + 300
    frame #2: 0x1be66080 libsystem_c.dylib`abort + 140
    frame #3: 0x024bdfa0 monotouchtest`log_callback(log_domain=0x00000000, log_level="error", message="../../../../../mono/metadata/object.c:1905: Expected GC Unsafe mode but was in STATE_BLOCKING state", fatal=4, user_data=0x00000000) at runtime.m:1251:3
    frame #4: 0x02487f44 monotouchtest`monoeg_g_logv_nofree(log_domain=0x00000000, log_level=G_LOG_LEVEL_ERROR, format=<unavailable>, args=<unavailable>) at goutput.c:149:2 [opt]
    frame #5: 0x02487ee0 monotouchtest`monoeg_g_logv(log_domain=<unavailable>, log_level=<unavailable>, format=<unavailable>, args=<unavailable>) at goutput.c:156:10 [opt]
    frame #6: 0x02487f74 monotouchtest`monoeg_g_log(log_domain=<unavailable>, log_level=<unavailable>, format=<unavailable>) at goutput.c:165:2 [opt]
    frame #7: 0x024694c4 monotouchtest`assert_gc_unsafe_mode(file="../../../../../mono/metadata/object.c", lineno=1905) at checked-build.c:396:3 [opt]
    frame #8: 0x023d2f64 monotouchtest`mono_class_vtable_checked(domain=0x16d64800, klass=0x173c1b98, error=0x194b0ee8) at object.c:1905:2 [opt]
    frame #9: 0x024130a8 monotouchtest`get_current_thread_ptr_for_domain(domain=0x16d64800, thread=0x02db45d0) at threads.c:635:2 [opt]
    frame #10: 0x024119a8 monotouchtest`mono_thread_current at threads.c:2026:23 [opt]
    frame #11: 0x02416998 monotouchtest`mono_thread_interruption_checkpoint_request(bypass_abort_protection=0) at threads.c:5101:35 [opt]
    (wrapper managed-to-native) ApiDefinition.Messaging:void_objc_msgSendSuper (intptr,intptr) @ 388435850 "calli.nat.fast" || frame #12: 0x024d5de8 monotouchtest`interp_exec_method_full(frame=0x194b11c0, context=<unavailable>, clause_args=<unavailable>, error=<unavailable>) at interp.c:3230:4 [opt]
    Bindings.Test.ObjCExceptionTest:InvokeManagedExceptionThrower () @ 388435752 "vcall" || frame #13: 0x024d64dc monotouchtest`interp_exec_method_full(frame=0x194b1380, context=<unavailable>, clause_args=<unavailable>, error=<unavailable>) at interp.c:3400:4 [opt]
    MonoTouchFixtures.ObjCRuntime.ExceptionsTest:ManagedExceptionPassthrough () @ 388502134 "vcallvirt.fast" || frame #14: 0x024d61c0 monotouchtest`interp_exec_method_full(frame=0x194b14e0, context=<unavailable>, clause_args=<unavailable>, error=<unavailable>) at interp.c:3325:4 [opt]
    (wrapper runtime-invoke) object:runtime_invoke_direct_void__this__ (object,intptr,intptr,intptr) @ 388462550 "vcall" || frame #15: 0x024d64dc monotouchtest`interp_exec_method_full(frame=0x194b1598, context=<unavailable>, clause_args=<unavailable>, error=<unavailable>) at interp.c:3400:4 [opt]
    frame #16: 0x024d46ec monotouchtest`interp_runtime_invoke(method=<unavailable>, obj=0x0302c5f0, params=0x00000000, exc=0x194b166c, error=0x194b18c8) at interp.c:1766:2 [opt]
    frame #17: 0x0232b39c monotouchtest`mono_jit_runtime_invoke(method=0x174fda58, obj=<unavailable>, params=0x00000000, exc=<unavailable>, error=0x194b18c8) at mini-runtime.c:3170:12 [opt]
    frame #18: 0x023d5cc8 monotouchtest`do_runtime_invoke(method=0x174fda58, obj=0x0302c5f0, params=0x00000000, exc=0x00000000, error=0x194b18c8) at object.c:3017:11 [opt]
    frame #19: 0x023d26a0 monotouchtest`mono_runtime_invoke_checked(method=<unavailable>, obj=<unavailable>, params=<unavailable>, error=<unavailable>) at class-getters.h:24:1 [opt] [artificial]
```



<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-10-07 16:16:13 +02:00
Thays Grazia 18fac0a241 [debugger][exception] Debugger breaks on handled exceptions (#17106)
* If there is a perform_wait_callback in the stack there will be another catch generated by the owner thread, so we don't need to throw, we can continue and find the next catch.
Fixes #17083

* Reverting unit test changed on commit 405d521.

* Fixing assert when calling mono_jit_info_get_method if it was a trampoline.
2019-10-07 08:22:06 -04:00
Egor Bogatov 35c6b7691f [netcore] Optimize Buffer.BlockCopy and Buffer.IsPrimitiveArray (#16692)
* Optimize Buffer.BlockCopy and IsPrimitiveArray (make them icalls)

* wrap with ENABLE_NETCORE

* fix formatting

* fix check for "is primitive"

* use m_class_is_primitive

* fix build errors

* fix typo

* fix failing test

* use mono_error_set_argument_out_of_range

* fix argument names for exceptions
2019-10-07 12:29:22 +02:00
Steve Pfister 2f6d69e2e6 Re-ordered the * IsValid check in SiteIdentityPermissions. We were throwing an IndexOutOfRangeException
Fixes https://github.com/mono/mono/issues/17017
2019-10-07 09:43:53 +02:00
Jan Kotas c6dcd3de56 More CompareInfo.IndexOf globalization fixes (dotnet/coreclr#27049)
Apply earlier CompareInfo.StartsWith fixes onto CompareInfo.IndexOf as well

Signed-off-by: dotnet-bot <[email protected]>
2019-10-07 09:41:24 +02:00
Zoltan Varga dea3a20b05 [wasm] Bump emscripten version. (#17179)
* [offfsets-tool] Embed a copy of the clang bindings, the version in PIP doesn't work with newer clang versions.

* [wasm] Bump emscripten version to 1.38.47.
2019-10-06 20:10:43 -04:00
Jay Krell f57af77e69 Optimize and extend System.Array intrinsic identification. (#17047)
* Optimize and extend System.Array intrinsic identification.
i.e. do the strcmp last.
Add GetRawArrayData.

* Use [Intrinsic] attribute instead of comment.
2019-10-06 10:27:42 +02:00
Zoltan Varga d2f543b4b1 [mixed] Add interp entry wrappers for devirtualized calls as well. (#17159)
* [mixed] Add interp entry wrappers for devirtualized calls as well.

* [aot] Generate code for string:memcpy/memset/bzero even in profile mode, they are called by the generated code.

* [aot] Treat string:memcpy as always AOTed in mono_aot_can_enter_interp () as well.

* [aot] Always aot string ctors as well, the JIT doesn't generate interp entry code for them.

* [wasm] Update print-table.py.
2019-10-05 20:51:52 -04:00
Aleksey Kliger (λgeek) cb52186661 [merp] Put thread into async context before running summarizer (#17194)
Followup work for https://github.com/mono/mono/pull/17090

In order to get managed method info for unmanaged stacktraces, we call
mini_jit_info_table_find_ext which calls decode_exception_debug_info which may
allocate if it's not in async context.

Do the switch in mono_threads_summarize_execute so that non-supervising threads
all switch when they run the sigterm_signal_handler.  mono_threads_summarize
already does it for the supervisor thread.

Fixes https://github.com/mono/mono/issues/17180
2019-10-05 13:01:56 -04:00
Alexander Köplinger 0600ea1256 Bump libgdiplus to 6.0.4 2019-10-05 17:36:40 +02:00
Aleksey Kliger (λgeek) 2f7fd4f03e [merp] exit_status is 0 if we ran the uploader successfully (#17185)
Not 1 (TRUE)
2019-10-05 09:59:05 -04:00
Marek Safar fce0e64de9 [System.Private.CoreLib] Fixes build 2019-10-05 14:09:54 +02:00
Stephen Toub 2c8d5f0a39 Add ExceptionDispatchInfo.SetCurrentStackTrace (dotnet/coreclr#27004)
* Add ExceptionDispatchInfo.SetCurrentStackTrace

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-10-05 14:09:54 +02:00
Stephen Toub d8c115d07a Fix stackalloc reuse bug in Environment.UserDomainName (#26994)
* Fix stackalloc reuse bug in Environment.UserDomainName

According to the comment, this code is never expected to be used (so it should either be deleted or the comment fixed), but in the meantime, if it were to be executed, things could go badly due to potentially passing the same buffer into LookupAccountNameW for two different arguments.

* Fix existing ValueStringBuilder usage to dispose the builder

Signed-off-by: dotnet-bot <[email protected]>
2019-10-05 14:09:54 +02:00
Stephen Toub 670738b55f Use const internally in corelib for Environment.NewLine (#27013)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-05 14:09:54 +02:00
Stephen Toub 1e3d017479 More corelib cleanup (dotnet/coreclr#26993)
* Make relevant types static (mostly Interop)

* Fix a few stray semicolons

* Remove unnecessary locals

Some can be removed entirely, some can be replaced by discards.

* Remove unnecessary usings

* Move Unix-specific helper method to TimeZoneInfo.Unix.cs

* Remove duplicated code

* Remove duplicative checks

* Remove [ThreadStatic] initialization

These are all the default values and wouldn't be necessary for any static, but inline initialization for [ThreadStatic]s is particularly unuseful (and in non-default cases problematic) because the fields are only set to these values on the initializing thread.

* Fix methods whose return value is never used

* Use string.IsNullOrEmpty

* Remove unnecessary field initialization

All ctors overwrite these values.

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-10-05 14:09:54 +02:00
Boris Parfenenkov 8205424667 Improve TimeSpan precision (dotnet/coreclr#26992)
Change multiplying by (x * (1.0 / BigValue)) on (x / BigValue).

Fix #41380

Signed-off-by: dotnet-bot <[email protected]>
2019-10-05 14:09:54 +02:00
Larry Ewing b45d0a1084 [aprofutil] Add skip regexes to simplify expression of removal matching (#17146)
* [aprofutil] Add skip regexes to simplify expression of removal matching

* [aprofutil] arguments to skip and take by count for automatic profile testing
2019-10-04 22:23:24 +02:00
Maxim Lipnin 06effa7d7e [wasm] Enable CoreXml.Test.XLinq.LoadSaveAsyncTests.RoundtripSyncAsyncMatches_Stream test (#17183) 2019-10-04 12:42:45 -05:00
Ryan Lucia 05217395db [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17175)
* [reflection] only duplicate MonoMarshalSpec strings for custom types

* Add test
2019-10-04 13:41:56 -04:00
Egor Bogatov 26754eecff [llvm] Propogate --enable-llvm-asserts to llvm/build.mk (#17149)
* fix Enable llvm asserts

* fix chmod
2019-10-04 10:27:01 -05:00
Vlad Brezae d1b3ee2e32 [interp] Improve copy propagation (#17154)
* [interp] Refactor tracking of stack/local values

Previously we had just an InterpInst* inside StackContentInfo, which was representing the instruction that pushed a certain local/value on the stack. This makes many things awkward, since an instruction is logically different from a value, that a local or a stack slot have. If we clear an instruction, it doesn't necessarily mean that the value that the instruction produced can't be stored on stack or in a local.

This commit creates a new structure StackValue, which holds the value.

* [interp] Generalize contents of StackValue

StackValue contains an opcode and some data to enable reconstruction of the value. For example instead of doing a LDLOC for a local, we can see if the local has a known value and use it instead (this could be a LDLOC from another local, whose value was propagated, or in the future a LDC). This will make more sense when we also start to track constant values.

Also decouple MOVLOC instructions from the cprop pass. They serve no purpose there. They are useful though when we do deadce, since we currently don't know how to kill instructions that change the stack.

* [interp] Handle dup opcode during copy propagation

* [interp] Avoid losing track of stack values for some opcodes

For some opcodes, that access stack values below the top of the stack, we were assuming they pop everything and then push the stack back, in order to prevent optimizing away instructions that pushed some of these values, since the original instruction expects those values to reside on the stack. We handle these instruction separately and keep track of the values of the stack, so we can further propagate the stack values, even though we currently can't optimize away those instructions.

* [interp] Propagate values for ctor arguments

* [interp] MINT_CASTCLASS no longer clobbers top of stack
2019-10-04 14:20:52 +03:00
Johan Lorensson 2aa7adb269 Always do copy_stack_data on entering GC safe/unsafe mode. (#17150) 2019-10-04 09:16:05 +02:00
Piotr Zierhoffer 4e8c496082 mkbundle: fix 17139 mono aot register module fix definitions (#17152)
* [mkbundle] Fix mono_aot_register_module declaration (#17139)

This change reflects the declaration introduced in jit.h in #15132.

* [mkbundle] Remove spurious function declaration (#17139)

The comment is clearly outdated after the introduction of #15132.
2019-10-04 08:46:58 +02:00
Aleksey Kliger (λgeek) ea2a460cf6 [merp] Don't overrun buffer in copy_summary_string_safe … (#17176)
* [merp] Don't overrun buffer in copy_summary_string_safe

MonoFrameSummary:str_destr is an array of MONO_MAX_SUMMARY_NAME_LEN bytes, not
MONO_MAX_SUMMARY_NAME_LEN + 1 bytes.

Fixes Coverity CID 1454563

* [merp] Use g_strlcpy for copy_summary_string_safe

Fixes Coverity CID 1454563

We would sometimes write to MonoSummaryFrame:str_descr which is
MONO_MAX_SUMMARY_NAME_LEN bytes long at index MONO_MAX_SUMMARY_NAME_LEN which
is one past the end of the array.

* nit: rename confusing parameter names

old names were confusing - we were copying from 'out' to 'in'.  Now we copy to
'dest' from 'src'
2019-10-04 01:17:49 -04:00
Vlad Brezae 8c1ef74bb1 [arm] Fix fetching of method addresses (#17099)
After https://github.com/mono/mono/commit/9ff3b0d65ee4, in an aot image we can emit addresses either as bl offset (which uses 4 bytes) or as ldr pc, =<label>; <addr> (which uses 8 bytes). Before this commit we were dereferencing an instruction pointer, in get_call_table_entry, assuming 8 bytes per entry. This could overflow and crash if we used in fact only 4 bytes per entry. Fix this by including the entry size in the aot image.

Fixes random crashes on arm CI on full-aotmixed suite.
2019-10-03 22:29:55 +03:00
Alexander Köplinger ea9dad7249 Bump ikvm to get https://github.com/mono/ikvm-fork/pull/13 (#17169) 2019-10-03 20:46:37 +02:00
dotnet-maestro[bot] 06c3637681 [master] Update dependencies from dotnet/corefx (#17166)
* Update dependencies from https://github.com/dotnet/corefx build 20191002.6

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19502.6

* Reenable libgdiplus/System.Drawing.Common tests

* Update dependencies from https://github.com/dotnet/corefx build 20191002.7

- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19502.7
2019-10-03 20:45:29 +02:00
Bernhard Urban-Forster 40b6f1ad2b [sdks] .gitignore python virtualenv (#17168) 2019-10-03 20:34:15 +02:00
Alexander Köplinger 43ccc6c26b [netcore] Update .gitignore 2019-10-03 18:45:14 +02:00
Alexander Köplinger 5bf18642ff [netcore] Move ignored test to global ignore file instead of the Linux-specific
It affects all platform
2019-10-03 18:44:07 +02:00
Marek Safar 0ccfd7806c [System.Runtime.Serialization] Make reflection calls linker friendly (#17165)
* [System.Runtime.Serialization] Make reflection calls linker friendly

Fixes #12586

* [csproj] Update project files
2019-10-03 18:40:14 +02:00
Sam Patel 83a5343d12 Merge pull request #17105 from naricc/naricc/UnitializedArray-Comment
Add a comment explaining why GC.AllocateUninitializedArray is not an icall
2019-10-03 10:43:45 -04:00
lateralusX aaa383b3e1 Default --host in autogen.sh on cygwin when missing. 2019-10-03 12:25:30 +02:00
Johan Lorensson 55be8289ff Optional only build MSVC runtime using make file system on Windows. (#16915)
* Build MSVC only runtime using make file system.

Add a new option to only build MSVC version of mono runtime and native
tools, --enable-msvc-only. In the past, --enable-msvc build both
mingw as well as MSVC runtime, this commit adds an option to only build
MSVC version of runtime and native tools using make file system.

Commit updates all native make file making sure mingw/gcc builds are
not done if --enable-msvc-only has been used. It also makes sure we
build and use MSVC based tools as part of build and tests.

Result will be a build without any mingw/gcc artifacts, but where all
existing make files still works with the MSVC build artifacts.

This commits is also preparing to switch the .NETCore build over to use
MSVC build runtime in order to get LLVM support, something that is
currently only supported on Windows MSVC build.

* Add link to mono-sgen.exe and clean windows binaries.

* Fix failures in mono/tests test-aot on Windows.

* Add fullaot-mixed tests on Windows x64.

* Run msbuild in parallel.

* Default to x64 mingw host on cygwin build.
2019-10-03 11:21:36 +02:00
Nathan Ricci d0461a9d8d Spelling corrections. 2019-10-02 13:14:48 -04:00
Jo Shields d8040ba865 Fix missing corerun/ directory in make dist tarballs (#17126)
```
 configure.ac:6695: error: required file 'netcore/corerun/Makefile.in' not found
 Makefile.am:24: error: required directory ./netcore/corerun does not exist
```
2019-10-02 10:46:42 -04:00
Jay Krell 6fb01aa269 Some external_only/internal split, and inlining. (#17012)
mono_type_get_type
 mono_type_get_signature
 mono_type_is_byref
 mono_type_get_class
 mono_type_get_array_type
2019-10-02 12:59:45 +02:00
Jay Krell 8d84b6fd38 [jit amd64] Add const and remove x87. (#16700) 2019-10-02 11:51:59 +02:00
Vlad Brezae 0ce8c78e0c [mini] Use clr memory model by default (#17136)
* [mini] Use clr memory model by default

Otherwise we can have potential crashes in the bcl on arm targets, since a lot of code that assumes this memory model is now shared with mono.

Keep the old clr-memory-model option alive for now, to avoid potential build problems, if building older mono with newer mono.

* [build] Remove clr-memory-model option

It is default now

* [man] Add entry for weak-memory-model
2019-10-02 09:23:45 +02:00
Alexis Christoforides 10e9159eaa [merp] Include any managed methods in the 'unmanaged_frames' portion … (#17090)
* [merp] Include any managed methods in the 'unmanaged_frames' portion of the output also

This can help correlate the two lists when we have mixed managed & unmanaged stacks in our crash output.

* Wehn symbol/function address is not found, still output the IaP

* Don't set native_offset to ip, that's not what it means

* [merp] Bump protocol version

* Minor formatting fix

* Remove paths from assembly image names

* Remove unused var

* Refactor filling in managed info for stack frame

* Revert "Remove paths from assembly image names"

This reverts commit defe86b471f37e12fa66a104747cac932943dca1.
2019-10-02 01:11:35 -04:00
Kyle White 0004522028 [merp] Use macOS version not Darwin version in MERP reports (#17130)
* Use macOS version not Darwin version in MERP

Fixes #17004

* Update mono-merp.c

Ensure this is only for Mac

* Don't allocate in macos_version_string

Use a static buffer.

Also some formatting fixes.
2019-10-01 22:01:35 -04:00
Tanner Gooding c76b84e80c Fixing AdvSimd.Arm64 to have an internal constructor in the "supported" file. (#26953)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-01 19:22:28 +02:00
Maxim Lipnin 41a89af31d [wasm][xunit tests] Exclude some tests due to PNSE-implemented members. (#17137) 2019-10-01 10:13:46 -05:00
Vlad Brezae 5af0ad900c Update codeowners
Get notifications for profiler and exceptions.
2019-10-01 16:40:48 +02:00
Maxim Lipnin db2e8ea79f [wasm][xunit test] Exclude RemoteExecutorTests in bcl profile (#17120)
`System/RemoteExecutorTests.cs` tests are excluded in the mobile test profiles. It makes sense to do the same for wasm.

Fixes https://github.com/mono/mono/issues/17038.
2019-10-01 15:34:49 +02:00
Adam SitnikandJan Kotas 20ab9bf581 allow ASCII equality ordinal fast path for en-* cultures (#26905)
* allow ASCII equality ordinal fast path for en-* cultures

* dont use StartsWith in the initialization execution path

* Update src/System.Private.CoreLib/shared/System/Globalization/CompareInfo.Unix.cs

Co-Authored-By: Jan Kotas <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>
2019-10-01 11:36:07 +02:00
Vlad Brezae f9ca01e3a5 [sgen] Fix allocator spelling (#17111) 2019-10-01 12:09:54 +03:00
Marek Safar e5f218786d [netcore] Update coreclr tests package name 2019-10-01 10:57:02 +02:00
Santiago Fernandez Madero b74f7b936e Make ResolveEventArgs.Name not nullable (dotnet/corefx#41415)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-01 10:13:53 +02:00
Youssef Victor 4d6596359c Typo: retreive => retrieve (dotnet/coreclr#26915)
Signed-off-by: dotnet-bot <[email protected]>
2019-10-01 10:13:53 +02:00
Egor Bogatov 5537a7c2ba Enable hw intrinsics in AOT mode (#17005)
* Introduce -mattr flag

* fix build on arm targets

* remove mono_memory_barrier

* Address feedback

* Address feedback

* cleanup

* fix crash

* fix "bmi" (it's not "bmi1")

* cleanup

* ignore System.Drawing.Tests.IconTests.CorrectColorDepthExtracted test

* fix build on arm

* fix build

* fix build
2019-09-30 21:28:55 -04:00
Maxim Lipnin e416137dfb [wasm][xunit tests] Other fix for "MissingMethodException: Default constructor not found" issue (#17122)
Fixes https://github.com/mono/mono/issues/17040
2019-09-30 15:21:32 -04:00
Ankit Jain 410cb28177 Bump msbuild to track xplat-master (#16975)
.. to pick up https://github.com/mono/msbuild/pull/142 and
https://github.com/mono/msbuild/pull/139 .
2019-09-30 21:11:09 +02:00
Vlad Brezae eb887a8c74 [sgen] Add stats for allocated gchandles (#17074) 2019-09-30 21:15:42 +03:00
dotnet-maestro[bot] 5818100a80 Update dependencies from https://github.com/dotnet/roslyn build 20190926.6 (#17103)
- Microsoft.Net.Compilers - 3.3.1-beta4-19476-06
2019-09-30 18:40:57 +02:00
Egor Bogatov 3768181879 Update NETStandard2.1 APIs (#17080)
Contributes to #17064

* Add System.Data.DataSetExtensions to mobile profiles
2019-09-30 16:07:02 +02:00
Alexander Köplinger 7f37f76b6d [netcore] Disable System.Drawing.Tests.IconTests.CorrectColorDepthExtracted test
It is broken on newer libgdiplus.
2019-09-30 15:32:18 +02:00
Marek Safar f88da6cc14 [netcore] Add target for running coreclr tests 2019-09-27 21:27:08 +02:00
Nathan Ricci bc63dc68f8 Updated comment in GC.cs about unitialized array. 2019-09-27 14:48:00 -04:00
Tanner Gooding bf5f6174ad Refactoring the ARM Hardware Intrinsics based on the latest design decisions. (#26895)
* Moving the Arm64 intrinsic files into the Arm folder.

* Refactoring the ARM Hardware Intrinsics based on the new design.

* Adding support for AdvSimd.Add

* Adding LoadVector64 and LoadVector128 APIs to Arm.AdvSimd

* Marking the LoadVector64 and LoadVector128 methods as unsafe

* Removing the ARM64 HWIntrinsic tests

* Renaming Arm.Base to Arm.ArmBase, as per the design

* Fixing Base.cs to ArmBase.cs in the shared projitems

* Fixing the doc comments for the AdvSimd.LoadVector methods

* Marking various IsSupported methods as new, now that they inherit from ArmBase

* Fixing a malformed doc comment that was missed

* Marking AdvSimd.Arm64 as [Intrinsic] and new

Signed-off-by: dotnet-bot <[email protected]>
2019-09-27 20:47:17 +02:00
Jo Shields 2072e4ce81 Special case in GetFullPath for UNC roots of \\.\ (#17066)
A valid path might be something like \\\\.\\pipe\\pipename (i.e. \\\\.\\ is a valid root). If we blindly strip all instances of `.\\` then we end up confusing our path cleaning algorithm. So permit a directory component of `.` in UNC path roots.

Closes: https://github.com/mono/mono/issues/16460
2019-09-27 13:35:18 -05:00
Zoltan Varga ac2ee5b8fc [wasm] Bump emscripten to 1.38.46. (#17094) 2019-09-27 13:34:02 -05:00
Maxim Lipnin 643bcbc3fc [wasm][xunit tests] Fix issue "System.MissingMethodException: Default constructor not found for type" (#17082)
Fixes https://github.com/mono/mono/issues/16879
2019-09-27 13:59:15 -04:00
Alexander Köplinger 1b9d8ec9eb Fix mono-extensions build (#17100)
It needed an update because https://github.com/mono/mono/commit/5b108b5726ec196f4b61d30f406919ce70211754 touched code the patch modified.
2019-09-27 16:45:57 +02:00
Vlad Brezae 194506d495 [mini] Expand clr-memory-model effect (#17093)
* [mini] Add memory barriers to more stores inside objects

We should now have membars for all stores of an object ref inside another object (for the stores done by the jit). Used by clr-memory-model debug option.

* [mini] Add memory barrier for storing objref in static fields

For clr-memory-model debug option.
2019-09-27 12:36:04 +03:00
dotnet-maestro[bot] ba093a07b7 Update dependencies from https://github.com/dotnet/arcade build 20190923.5
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19473.5
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19473.5
2019-09-27 10:32:57 +02:00
dotnet-maestro[bot] d5c49121b6 Update dependencies from https://github.com/dotnet/corefx build 20190926.2
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19476.2
2019-09-27 10:32:57 +02:00
dotnet-maestro[bot] e062ebf096 Update dependencies from https://github.com/dotnet/core-setup build 20190926.2
- Microsoft.NETCore.App - 5.0.0-alpha1.19476.2
2019-09-27 10:32:57 +02:00
Aleksey Kliger (λgeek) 1dc63ced73 [runtime] Respect runtime_version in mono_init_internal (#17085)
In 6d2c77fb33 we changed the representation of
the runtimes that we will probe from a NULL-terminated array to a linked list.
Unfortunately we made a typo, and in the case where the caller of
mono_init_internal provided a runtime_version, we still picked
DEFAULT_RUNTIME_VERSION instead of the given runtime_version.

This is an issue for embedders like XA that use the "mobile" runtime - all
their assemblies are compiled with the "mobile" version number (2.0.5.0) but
Mono running with the default runtime configuration will remap to 4.0.0.0.  As
a result, when there are references to 2.0.5.0 assemblies, the load requests
will be remapped to 4.0.0.0 which will never see the already loaded 2.0.5.0
assemblies, and we will fall back on the embedder's preload hook or filesystem
probing every single time.  This is a performance fail.
2019-09-26 17:30:37 -04:00
Alexander Köplinger bffd4c6b99 Revert "Inline TLS access. (#16882)" (#17092)
Reverts mono/mono#16882

This broke the Mono Android SDKs build in master though for some reason it doesn't show up in the PR build:

```
[2019-09-26T03:19:55.366Z] Undefined symbols for architecture x86_64:
[2019-09-26T03:19:55.366Z]   "_mono_tls_key_jit_tls", referenced from:
[2019-09-26T03:19:55.366Z]       _mono_tls_get_jit_tls in libmain_a-main-sgen.o
[2019-09-26T03:19:55.366Z]   "_mono_tls_key_lmf_addr", referenced from:
[2019-09-26T03:19:55.366Z]       _mono_tls_get_lmf_addr in libmain_a-main-sgen.o
[2019-09-26T03:19:55.366Z] ld: symbol(s) not found for architecture x86_64
[2019-09-26T03:19:55.366Z] clang: error: linker command failed with exit code 1 (use -v to see invocation)
[2019-09-26T03:19:55.366Z] gmake[6]: *** [Makefile:1634: mono-sgen] Error 1
[2019-09-26T03:19:55.366Z] gmake[6]: Leaving directory '/Users/builder/jenkins/workspace/archive-mono/master/android/debug/sdks/builds/android-host-Darwin-debug/mono/mini'
```.
2019-09-26 23:10:51 +02:00
Vlad Brezae bada362454 [sgen] Report roots from togglerefs (#17063) 2019-09-26 22:38:59 +03:00
Marek Safar 8da9eebcc6 [netcore] Correctly send exit code to the caller 2019-09-26 20:59:50 +02:00
Jan 3132cbd98b Add loading the default Mono configuration file. (#16961)
Add loading the default Mono configuration file.

Add loading the default Mono configuration file in the examples of Mono Embedded.
Also include header in existing usage of `mono_config_parse`.

This fixes problems under Raspbian, when extending the sample with your own code. 

The `teste.c` is still not compiling, because the `mono_set_allocator_vtable` function is not up to date. But I was not able to find the documentation for this function.
2019-09-26 20:46:16 +02:00
Vlad Brezae 470e53f6b4 [sgen] Fix heavy binary protocol build (#17037)
[sgen] Fix heavy binary protocol build
2019-09-26 19:16:04 +02:00
imhameed 5e30301ff3 Merge pull request #17031 from EgorBo/bmi-mulx
[LLVM] Implement Bmi2.MultiplyNoFlags
2019-09-26 09:29:54 -07:00
Alexis Christoforides f52678864d [crashing] Remove Mono signal handlers when starting to handle a crash
Fixes https://github.com/mono/mono/issues/16803
2019-09-26 16:41:35 +02:00
Alexis Christoforides 4727b2475f [merp] Output native library module name when 'whitelist all' mode is enabled (#16899)
Partially fixes https://github.com/mono/mono/issues/16689
2019-09-26 09:30:01 -04:00
Vlad Brezae 4a17f5ca11 [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17020)
* Revert "[Mono.Debugger.Soft] Properly close connections"

This reverts commit 2da7707373.

This was previously reverted because it was causing issues and it still does. It is a hack fix. We signal the connection for closing and next we send the dispose command over the network. This is obviously racy.

* [Mono.Debugger.Soft] Make sure receiving thread always closes

When we want to close the connection, setting the close flag is not enough, because a thread can be already stuck in a blocking receive, without getting to check the flag. We fix this by additionaly breaking the connection, by using socket.Shutdown.

Fixes https://github.com/mono/mono/issues/7377

* Bump API snapshot submodule
2019-09-26 14:40:42 +02:00
Johan Lorensson 9b094e660c BeginConnect complete to early when not using callback. (#17035)
* BeginConnect complete to early when not using callback.

The following commit, https://github.com/mono/mono/commit/068e8fe0424806753d7ab72a7b9bf0e54b58408b#diff-33b28a9dc0b8032650ed77213481a99f
changed the way we do DNS resolve in BeginConnect using host name. Instead
of doing a blocking DNS resolve, it switched to an async DNS resolve, followed
by an async connect. The returned IAsyncResult was just representing the
completion of the DNS resolve task and not the underlying connect. It
also turns out that part of doing EndConnect, we did some validation
of the used IAsyncResult making sure it was an instance of SocketAsyncResult,
meaning that if EndConnect was called on the returned IAsyncResult from
BeginConnect, EndConnect would throw and exception.

NOTE, this only happens if you use pattern like this:

var result = sock.BeginConnect (hostName, port, null, null);
result.AsyncWaitHandle.WaitOne (2000);
sock.EndConnect (result);

It did not happened if you used callbacks, since then EndConnect would
be called as part of callback and that IAsyncResult was of correct type,
or if you did a BeginConnect with an EndPoint or IPAddress[] since that
won't trigger the DNS resolve.

Fix is to make sure we hand out the SocketAsyncResult instance that will
be used in our internal connect calls from BeginConnect. We also make
sure, we chain the DNS resolve task together with a task doing the async
connect (using the same SocketAsyncResult instance). This will make sure
the IAsyncResult returned from BeginConnect is the same one as used in
internal connect call, so it will only complete when the connect call
completes.

* Adding test for BeginConnect using host name.

* Bump API snapshot submodule
2019-09-26 14:34:28 +02:00
monojenkins e5b7473a21 [sdks] Bump min iOS version to 7.0. (#17073)
Because that's the min iOS version in all current versions of Xamarin.iOS.
2019-09-26 14:20:32 +02:00
Bernhard Urban c81b6f5ca9 [interp] always require GC Unsafe mode in exception checkpoint (#17016)
[interp] always require GC Unsafe mode in exception checkpoint

Follow-up for https://github.com/mono/mono/pull/16955

/cc @BrzVlad
2019-09-26 10:45:56 +02:00
Ben Adams 65dc4c364a CollectionsMarshal.AsSpan allow null refs (dotnet/coreclr#26903)
Signed-off-by: dotnet-bot <[email protected]>
2019-09-26 10:10:42 +02:00
Levi Broderick 23fac785db Introduce Utf8Span, which is a span of UTF-8 text (dotnet/coreclr#26711)
Signed-off-by: dotnet-bot <[email protected]>
2019-09-26 10:10:42 +02:00
Vlad Brezae f5bb650f78 [debugger] Properly close debugger thread when connection hangs
When we detach from the debugger, we reset the state by starting a new debugger thread (why don't we just use the existing thread?). As per commit https://github.com/mono/mono/commit/540ef385faa230bc226c7a83bfabd0730520911e we should shut down the debugger thread when the connection drops. However, since that commit was acting as a Dispose command was sent instead, it would end up relentlessly spawning and closing new debugger threads up until the runtime is shut down. This commit makes sure we don't respawn once the connection hangs.
2019-09-26 09:53:36 +02:00
Egor Bogatov 4a72dadb34 LLVM: Add comments (string metadata) for calls (#16956)
* Add string metadata to all calls (comments)

* Update mini-llvm.c

* rename tramp_%d to full name too
2019-09-26 09:51:36 +02:00
Jan Kotas 519380d009 Fix CoreRT build break
Signed-off-by: dotnet-bot <[email protected]>
2019-09-26 08:59:20 +02:00
Bernhard Urban 1faf71f446 [offsets-tool] install clang python package into a virtualenv (#17013)
[offsets-tool] install clang python package into a virtualenv

So it doesn't mess with the Python installation of the user.

/cc @mandel-macaque
2019-09-26 08:55:33 +02:00
Thays Grazia 5b108b5726 [threading] embedded mono hangs (#16907)
* [threading] embedded mono hangs

When embedded mono is executing a C++ code, it didn't start to execute a C# code, we don't need to suspend the thread to run GC.
Fixes #16192
Fixes #14725

* Changing what was discussed with Aleksey during our 1on1

* Changing what was suggested by Aleksey

* Separating mono_init_version that is being used on tests from the embedded ones
2019-09-25 17:12:33 -03:00
Jay Krell ed0fa35dc2 [Coop] Unconvert ves_icall_Mono_TlsProviderFactory_IsBtlsSupported. (#16995) 2019-09-25 14:40:38 -04:00
Stephen Toub c256e409c9 More Corelib cleanup (dotnet/coreclr#26872)
* Remove unnecessary asserts

* Make several classes static

* Use is instead of as+null check

* Use T? instead of Nullable<T>

* more static classes

* Mark locals as const

* Merge declaration and initialization of some variables

* Remove unnecessary casts

* Remove unnecessary "unsafe"s

* Simplify several lambda expressions

* Remove redundant parentheses

* Remove redundant '== true'

* Remove redundant empty lines

* Simplify boolean comparison with '== false'

* Replace if-statement with return statement

* Use while for infinite loop

* Add static to all partial static class declarations

* Use ++/-- operator instead of assignment

* Use string.IsNullOrEmpty

* Use coalesce expression

* Simplify lazy initialization

* Use coalese expression

* Join string expressions

* Use regular string literal instead of verbatim string literal

* Optimize StringBuilder.Append calls

* Remove redundant assignment

* Remove unnecessary unsafe context

* Merge processor directives

* Use String.Equals instead of String.Compare

* Use Debug.Fail instead of Debug.Assert(false

* Remove Attribute suffix

* Use predefined type

* Use compound assignment

* Use while statement to create an infinite loop

* Remove redundant base ctor call

* Avoid using catch (Exception)

* Remove empty regions

* Span comparison to null

* Avoid unnecessary boxing of value type

* Expression is always equal to 'true'

* Remove unused method

* update coalesce assignment

* fix unsafe

* fix redundant parens

* Fix whitespace errors introduced

Signed-off-by: dotnet-bot <[email protected]>
2019-09-25 20:13:47 +02:00
Egor Bogatov 39ff579432 [netcore] Disable annoying SourceLink warrnings (#17055)
Currently netcore-build doesn't need submodules (except LLVM) so a task somewhere in arcade/microsoft.build.tasks.git always complain if those are not cloned.

Set EnableSourceControlManagerQueries=false to ignore the warnings.
2019-09-25 12:28:53 -04:00
Alexander Köplinger ea6ea67351 Bump bockbuild to get recent fixes (#17054)
- https://github.com/mono/bockbuild/pull/121
- https://github.com/mono/bockbuild/pull/122
2019-09-25 16:52:42 +02:00
EgorBo 2ceb062c9b revise all X86 intrinsics 2019-09-25 14:58:53 +03:00
Alexander Köplinger aeca4a6cc3 Update System.csproj 2019-09-25 12:32:42 +02:00
Jay Krell baa9adc06a Fix comment about mono_thread_interruption_request_flag. (#17036)
Fix https://github.com/mono/mono/pull/16906/files#r327660329.
2019-09-25 12:30:27 +02:00
Ben Adams e48a285cfd Add CollectionsMarshal (dotnet/coreclr#26867)
* Add CollectionsMarshal

* Feedback

* Feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-09-25 09:55:20 +02:00
Levi Broderick e082719e3f Pack additional useful data into char's "Unicode categories" RVA static info (#26848)
Also improves the performance of char.IsWhiteSpace / char.IsUpper / char.IsLower

Signed-off-by: dotnet-bot <[email protected]>
2019-09-25 07:48:24 +02:00
EgorBo ba471607a3 Implement Bmi2.MultiplyNoFlags 2019-09-25 04:04:38 +03:00
Steve Pfister da02f1330f Enable additional wasm corefx xunit tests (#16860)
Add the other corefx xunit test assemblies to the build and adjust jenkins to run them on CI.
2019-09-24 17:27:50 -04:00
Egor Bogatov 37e46aa9ae LLVM: Intrinsify MathF.Round (#16840)
* improve MathF.Round

* prefer vroundss

* enable round only for jit
2019-09-24 20:53:23 +02:00
Bernhard Urban 153b5def01 [checked-build] update allowed thread states (#16971) 2019-09-24 14:53:10 -04:00
Marius Ungureanu 394d8d1f21 Add RenamedEvent* to FSW sources from CoreFX (#16755)
* Add RenamedEvent* to FSW sources from CoreFX

Fixes #16486 - This was only partially fixed until now

* [csproj] Update project files

* Add test files which test these code paths on corefx

* Remove old RenamedEvent* files
2019-09-24 20:49:02 +02:00
Egor Bogatov 8f85967612 Add loop related optimizations to LLVM JIT (#16436)
* Add loop-related optimizations

* Update llvm-jit.cpp

* Update llvm-jit.cpp

* Update llvm-jit.cpp
2019-09-24 20:45:32 +02:00
Egor Bogatov ed622e9112 [netcore] Implement missing Bmi1/Bmi2 intrinsics (#16919)
* Finalize BMI1

* cleanup

* Update simd-intrinsics-netcore.c

* Update simd-intrinsics-netcore.c

* fix LLVM-AOT
2019-09-24 20:44:03 +02:00
Stephen Toub c4aa67cbd9 Change several internal/private instance methods to be static (#26835)
* Replace ToLower(CultureInfo.InvariantCulture) with ToLowerInvariant()

* Mark several members static

Signed-off-by: dotnet-bot <[email protected]>
2019-09-24 20:06:06 +02:00
Jan Kotas 639f30f99b Remove IsFastSort optimizations from String (dotnet/coreclr#26759)
* Remove IsFastSort optimizations from String
- Fix bugs in the Span-based globalization fast paths. Note that some of these bug fixes are going to affect performance of the globalization fast paths.
- Use Span-based globalization fast paths for strings
- Avoid static array allocation for HighCharTable

Fixes #26758

Signed-off-by: dotnet-bot <[email protected]>
2019-09-24 20:06:06 +02:00
Maxim Lipnin f91dcb9c10 Fix time zone issue when jumping into DST (#16430)
Addresses an issue with jumping into DST for some time zones when the incorrect date-time offset is returned for date-time in UTC (which comes from DateTime.Now). The fix is to just check if the incoming date-time is in UTC.

Also added a set of tests for some time zones to verify jumping into DST in general.

Fixes https://github.com/mono/mono/issues/16395
2019-09-24 13:58:59 -04:00
Alexander Köplinger 0a3c9c451b [ci] Make ios/mac sdks archive URL more predictable
Requested by xamarin-macios team.
2019-09-24 15:26:32 +02:00
Bernhard UrbanandAleksey Kliger 749493d4b3 [threads] clear small_id_key TLS when unregistering a thread (#16973)
* [threads] clear small_id_key TLS when unregistering a thread

Fixes
```
* thread #12, name = 'tid_a507', stop reason = EXC_BREAKPOINT (code=1, subcode=0x1be66144)
  * frame #0: 0x1be66144 libsystem_c.dylib`__abort + 184
    frame #1: 0x1be6608c libsystem_c.dylib`abort + 152
    frame #2: 0x003e1fa0 monotouchtest`log_callback(log_domain=0x00000000, log_level="error", message="* Assertion at ../../../../../mono/utils/hazard-pointer.c:158, condition `mono_bitset_test_fast (small_id_table, id)' not met\n", fatal=4, user_data=0x00000000) at runtime.m:1251:3
    frame #3: 0x003abf44 monotouchtest`monoeg_g_logv_nofree(log_domain=0x00000000, log_level=G_LOG_LEVEL_ERROR, format=<unavailable>, args=<unavailable>) at goutput.c:149:2 [opt]
    frame #4: 0x003abfb4 monotouchtest`monoeg_assertion_message(format=<unavailable>) at goutput.c:184:22 [opt]
    frame #5: 0x003904dc monotouchtest`mono_thread_small_id_free(id=<unavailable>) at hazard-pointer.c:0:2 [opt]
    frame #6: 0x003a0a74 monotouchtest`unregister_thread(arg=0x15c88400) at mono-threads.c:588:2 [opt]
    frame #7: 0x00336110 monotouchtest`mono_thread_detach_if_exiting at threads.c:1571:4 [opt]
    frame #8: 0x003e7a14 monotouchtest`::xamarin_release_trampoline(self=0x166452f0, sel="release") at trampolines.m:644:3
    frame #9: 0x001cdc40 monotouchtest`::-[__Xamarin_NSTimerActionDispatcher release](self=0x166452f0, _cmd="release") at registrar.m:83445:3
    frame #10: 0x1ce2ae68 Foundation`_timerRelease + 80
    frame #11: 0x1c31b56c CoreFoundation`CFRunLoopTimerInvalidate + 612
    frame #12: 0x1c31a554 CoreFoundation`__CFRunLoopTimerDeallocate + 32
    frame #13: 0x1c31dde4 CoreFoundation`_CFRelease + 220
    frame #14: 0x1c2be6e8 CoreFoundation`__CFArrayReleaseValues + 500
    frame #15: 0x1c2be4c4 CoreFoundation`CFArrayRemoveAllValues + 104
    frame #16: 0x1c31ff64 CoreFoundation`__CFSetApplyFunction_block_invoke + 24
    frame #17: 0x1c3b2e18 CoreFoundation`CFBasicHashApply + 116
    frame #18: 0x1c31ff10 CoreFoundation`CFSetApplyFunction + 160
    frame #19: 0x1c3152cc CoreFoundation`__CFRunLoopDeallocate + 204
    frame #20: 0x1c31dde4 CoreFoundation`_CFRelease + 220
    frame #21: 0x1c304a80 CoreFoundation`__CFTSDFinalize + 144
    frame #22: 0x1bfa324c libsystem_pthread.dylib`_pthread_tsd_cleanup + 644
    frame #23: 0x1bf9cc08 libsystem_pthread.dylib`_pthread_exit + 80
    frame #24: 0x1bf9af24 libsystem_pthread.dylib`pthread_exit + 36
    frame #25: 0x0039df84 monotouchtest`mono_threads_platform_exit(exit_code=<unavailable>) at mono-threads-posix.c:145:2 [opt]
    frame #26: 0x0033bb84 monotouchtest`start_wrapper(data=0x1609e1c0) at threads.c:1296:2 [opt]
    frame #27: 0x1bf9b914 libsystem_pthread.dylib`_pthread_body + 128
    frame #28: 0x1bf9b874 libsystem_pthread.dylib`_pthread_start + 44
    frame #29: 0x1bfa3b94 libsystem_pthread.dylib`thread_start + 4
```

* Update mono/utils/mono-threads.c

Co-Authored-By: Aleksey Kliger (λgeek) <[email protected]>
2019-09-24 13:07:19 +02:00
Maxim Lipnin 9988ebc7f2 [System.Xml] Fix deserialization issue (#16965)
[This ](https://github.com/mono/mono/pull/11194/files#diff-ae54d9565e735005686191de0f19ed50R431-R435)change in `XmlTypeMapElementInfo.GetElement`  introduced the logic for handling the case of derived types deserialization. 
For some cases (like https://github.com/mono/mono/issues/16918) it breaks existing functionality because it returns wrong element for given element name after searching withing derived types collection.

![image](https://user-images.githubusercontent.com/3258267/65416085-bedc0500-ddff-11e9-941c-f24045c64121.png)

Unfortunately, what I can do here is just reverting the related changes.

Fixes https://github.com/mono/mono/issues/16918
2019-09-24 11:35:15 +02:00
Thays Grazia 7e6d863686 [debugger] New way to filter exceptions to support VSWin features (#16825)
* Creating a new version of MOD_KIND_EXCEPTION_ONLY to support VsWin features, discussed with Joaquin Jares.
Because we don't have this functionality of get every other exception that is not specified, VsWin was getting every exception and filtering later. But this causes a slowness during the debugger because we stop all thread on each exception that we get, even if they are caught and we don't want to stop.

* Fixing other unit test because now we have 2 nested classes.
Fixing indentation.

* Creating a flag in the MOD_KIND_EXCEPTION_ONLY protocol event and not creating a new protocol event.

* Changing what was suggested by Zoltan.

* Coding style

* Bump API snapshot submodule
2019-09-23 18:16:59 -03:00
Alexander Köplinger 9b98db9ca9 Correctly check for HAVE_STAT_BIRTHTIME in configure.ac checks for System.Native (#16999)
The check was done incorrectly, the include files need to be separated by newlines otherwise we would get a false negative result.

config.log contained this:

```
conftest.c:279:23: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include <sys/types.h>, #include <sys/stat.h>
                      ^
                      //
```

This means that when doing File.GetCreationTime() we'd fall back to returning the last modified time.

It regressed when we switched to System.IO.File to the CoreFX implementation i.e. System.Native in https://github.com/mono/mono/commit/8f5cef936491e8b20888bbf18d426482c890637c.

Fixes https://github.com/mono/mono/issues/16974
2019-09-23 22:44:59 +02:00
Alexis Christoforides bc43f32c9d [merp] Use function names even in 'private crashes' mode (#16897)
Partially fixes https://github.com/mono/mono/issues/16689
2019-09-23 15:49:53 -04:00
Steve Pfister 15e939d542 Restore Previous ExecutionContext Capture Behavior (#16945)
Restores previous ExecutionContext Capture behavior where we were copying a new SynchronizationContext as opposed to a reference to the existing one.

The old behavior caused SynchronizationContextAwaitTaskContinuations to not post to a SynchronizationContext.

Fixes https://github.com/mono/mono/issues/16759

Reverts a fix for https://github.com/mono/mono/issues/12421
2019-09-23 10:52:23 -04:00
Alexander Köplinger 8db7d198b2 [ci] Fix typo in sdks-archive.groovy 2019-09-23 15:53:57 +02:00
Alexander Köplinger 93c67f2a3c [ci] Fix typo in sdks-archive.groovy 2019-09-23 15:48:43 +02:00
Alexander Köplinger 70e266a3af [ci] Fix typo in sdks-archive.groovy 2019-09-23 15:45:02 +02:00
Alexander Köplinger 6ad929c317 [ci] Build iOS/Mac Mono sdks archive using Xcode 11
This was requested by the xamarin-macios team.
2019-09-23 15:42:36 +02:00
Jo Shields 1a8cc98160 Include Mono.WebBrowser.dll in mkbundle bundles (Closes: #7454) (#16972)
* Include Mono.WebBrowser.dll in mkbundle bundles (Closes: #7454)

Because System.Windows.Forms.dll includes an assemblyref on
Mono.WebBrowser.dll, bundles need to be able to include it
in order for WinForms to work (even if they don't actually
use a browser component)

Compare:

```
$ mkbundle hellowin.exe -o hellowin --cross mono-6.0.0-ubuntu-18.04-x64 --i18n all
From: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64
ERROR: Unable to load assembly `Mono.WebBrowser' referenced by `/home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Windows.Forms.dll'
```

to

```
$ mkbundle hellowin.exe -o hellowin --cross mono-6.0.0-ubuntu-18.04-x64 --i18n all
From: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64
Using runtime: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/bin/mono
     Assembly: /tmp/hellowin.exe
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Windows.Forms.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/mscorlib.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/Mono.Security.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Configuration.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Xml.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Security.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Core.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Numerics.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Drawing.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Runtime.Serialization.Formatters.Soap.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/Accessibility.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/Mono.WebBrowser.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/Mono.Posix.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Data.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.Transactions.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/System.EnterpriseServices.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/I18N.CJK.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/I18N.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/I18N.MidEast.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/I18N.Other.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/I18N.Rare.dll
     Assembly: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/lib/mono/4.5/I18N.West.dll
systemconfig: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/etc/mono/config
machineconfig: /home/directhex/.mono/targets/mono-6.0.0-ubuntu-18.04-x64/etc/mono/4.5/machine.config
Generated hellowin
```

For the test code:
```
using System;
using System.Drawing;
using System.Windows.Forms;

public class HelloWorld : Form
{
    static public void Main ()
    {
        Application.Run (new HelloWorld ());
    }

    public HelloWorld ()
    {
        Button b = new Button ();
        b.Text = "Click Me!";
        b.Click += new EventHandler (Button_Click);
        Controls.Add (b);
    }

    private void Button_Click (object sender, EventArgs e)
    {
        MessageBox.Show ("Button Clicked!");
    }
}
```

* Also add Novell.Directory.Ldap (consumed by System.DirectoryServices)
2019-09-23 09:24:05 -04:00
Jay Krell 7497e4933c [interp] Improve debuggability with enum. (#16721) 2019-09-23 11:10:23 +02:00
Thays Grazia 1a277c31a0 [debugger] Crash when debugging iOS application that throws (#16958)
* Doing the same fix from Android to IOS.
* On mini-exceptions.c check if there is no ji we can continue and generate the exception without checking wrapper_type.

Fixes #16824
2019-09-22 16:12:10 -03:00
EgorBo 6257369adc netcore: fix debug build 2019-09-22 09:09:35 +02:00
Jay Krell aca55a42aa Inline TLS access. (#16882)
The same functions are referenced by JIT and runtime.
The JIT uses cannot be inlined. The runtime can.
Since I could not get anything else to build and the change is simple and mechanical, now two sets of functions are provided, inline and extern. Extern just calls inline.
This PR appears to change all the uses, but it is only the JIT uses. The runtime ones just work and keep the old names.

We should also consider building desktop with LTO/LTCG, which would do all this automatically, smarter, more generally. A quick experiment shows it grows the runtime size, which is why I say desktop.
2019-09-21 18:35:19 +02:00
Jay Krell b20c690e3e Partially inline mono_method_signature_checked/internal. (#16927)
* Inline common fast paths of mono_method_signature_checked and mono_method_signature_internal.

* PR: Restore profilers to use mainstream functions.
2019-09-21 11:09:41 +02:00
Bernhard Urban 0f181a9dc4 [arm64_32] fix pointer size in CallInfo (#16970)
Note that in the output below `a`, `b`, etc. are NSObjects, so they are really passed as pointer.

Before:
```
* thread #1, name = 'tid_303', queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
    frame #0: 0x04f301d4 aWatchOSExtension`::xamarin_localized_string_format_9(format="hello%@%@%@%@%@%@%@%@%@", a=0, b=1, c=2, d=3, e=4, f=5, g=6, h=7, i=0x00000000) at nsstring-localization.m:81:9
   78   void *
   79   xamarin_localized_string_format_9 (NSString *format, id a, id b, id c, id d, id e, id f, id g, id h, id i)
   80   {
-> 81           return [NSString localizedStringWithFormat: format, a, b, c, d, e, f, g, h, i];
   82   }
   83
   84   }
(lldb) mbt 4
* thread #1
  * frame #0: 0x04f301d4 aWatchOSExtension`::xamarin_localized_string_format_9(format="hello%@%@%@%@%@%@%@%@%@", a=0, b=1, c=2, d=3, e=4, f=5, g=6, h=7, i=0x00000000) at nsstring-localization.m:81:9
    frame #1: 0x04d9984c aWatchOSExtension`interp_to_native_trampoline + 156
    frame #2: 0x04f41d5c aWatchOSExtension`ves_pinvoke_method(frame=0x05167af8, sig=0x1518afd0, addr=(aWatchOSExtension`::xamarin_localized_string_format_9(NSString *, id, id, id, id, id, id, id, id, id) at nsstring-localization.m:80), string_ctor=0, context=0x14550960, save_last_error=0) at interp.c:1411:2 [opt]
    NSString::xamarin_localized_string_format_9 @ 68 "calli.nat" || frame #3: 0x04f3bfa4 aWatchOSExtension`interp_exec_method_full(frame=0x05167d38, context=<unavailable>, clause_args=0x00000000, error=0x05168540) at interp.c:3290:5 [opt]
```

After:
```
* thread #1, name = 'tid_303', queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
    frame #0: 0x04c2c1e0 aWatchOSExtension`::xamarin_localized_string_format_9(format="hello%@%@%@%@%@%@%@%@%@", a=0, b=1, c=2, d=3, e=4, f=5, g=6, h=7, i=8) at nsstring-localization.m:81:9
   78   void *
   79   xamarin_localized_string_format_9 (NSString *format, id a, id b, id c, id d, id e, id f, id g, id h, id i)
   80   {
-> 81           return [NSString localizedStringWithFormat: format, a, b, c, d, e, f, g, h, i];
   82   }
   83
   84   }
```
2019-09-20 18:02:20 -04:00
Jay Krell 12d3dcecc6 [Coop] ves_icall_property_info_get_default_value. (#16614)
This includes resolving a somewhat deep problem involving
a void* that is usually to a int/float, but can be a MonoObject** or at least MonoString**.
An additional MonoStringHandleOut parameter is pass around to address this.
Perhaps it should be MonoObjectHandleOut for more generality.
2019-09-20 17:58:16 -04:00
Bernhard Urban e27159174a [interp] avoid exception checkpoint when in thread is in GC Safe state (#16955)
[interp] avoid exception checkpoint when in thread is in GC Safe state 

Usually the interpreter operates in GC Unsafe state. There is an exception however, and that is when it executes a `managed-to-native` wrapper in cooperative (or hybrid) suspend.

The wrapper does essentially:
1. enter GC Safe state via `mono_threads_enter_gc_safe_region_unbalanced`
2. call native function
3. exit GC state via `mono_threads_exit_gc_safe_region_unbalanced`

Usually upon return of a native function call, the interpreter would check for thread interruption and, if applicable, throw an exception.  That, however, would mess with the GC state as the interpreter operates in GC Safe state at this moment.

Note that ignoring thread interruption at that point shouldn't be a problem, because after 3. the `managed-to-native` wrapper will check for thread interruption anyway.

Contributes to https://github.com/mono/mono/issues/16819
2019-09-20 22:15:55 +02:00
Alexander Köplinger 6433ea9cce [ci] Add SymStore directory for netcore publishing stage
It's required by arcade in some channels.
2019-09-20 20:06:11 +02:00
Jay Krell 8b4c1ef828 Use ld -Bsymbolic when linking AOT. (#14511)
The runtime already does this itself.
2019-09-20 13:12:01 -04:00
Alexander Köplinger 6bc988b087 [netcore] Move to new arcade post build using yaml stages (#16966)
This is required by the newer arcade builds.
We can simplify our scripts since we no longer need the special publishwitharcade.proj.

Added copyright and license to the .nuspecs since the new arcade validation now
verifies this against a set of Microsoft policies.

We also need to make the .nupkg pre-release by appending the -preview suffix as stable versions are not permitted in non-stable feeds.
2019-09-20 17:27:15 +02:00
Aleksey Kliger (λgeek) 3757a7296c [System] Make FileSystemWatcher backend non-static (#16922)
* [System] Make FileSystemWatcher backend non-static

The FileSystemWatcher `watcher` field is the backend IFileWatcher that's
supposed to be used for the actual operations.

Each backend has a `bool GetInstance (out watcher)` method that returns a
singleton object, so each new instance of FileSystemWatcher gets the same
IFileWatcher instance.  (They will get different `watcher_handle` instances
which are used by some backends to uniquely identify this FileSystemWatcher).

However when the first FileSystemWatcher instance is `Dispose`d, it will set
`watcher = null` which will prevent the remaining instances from calling

    watcher?.StopDispatching (watcher_handle);
    watcher?.Dispose (watcher_handle);

which means that the backend won't properly cleanup resources for any other FSW
instances that have other `watcher_handle` values.

Addresses https://github.com/mono/mono/issues/16709
2019-09-20 11:21:30 -04:00
Rolf Bjarne Kvinge 95d17b16a8 [offsets-tool] Install clang into the user-specific python directory.
Because the system location isn't world writeable on Catalina.
2019-09-20 16:19:32 +02:00
monojenkins c8450814a2 [bcl] Update BCL Linked Size 2019-09-20 15:02:00 +02:00
Alexander Köplinger 74b9ca426a [ci] Remove more XCODE32_DIR usages (#16964)
Follow-up to https://github.com/mono/mono/pull/16936
2019-09-20 14:00:22 +02:00
Egor Bogatov 32321375ee Implement WriteCore and ReadCore in DeflateStream (#16951)
No idea why these were left unimplemented (probably were not used at that point).
Fixes #16950
2019-09-20 12:06:45 +02:00
Alexander Köplinger 857284b412 Add net_4.8.xml to EXTRA_DIST and bump binary-reference-assemblies again
The file was missed in https://github.com/mono/mono/pull/16912.
Also pull in another reference assemblies update.
2019-09-20 11:59:51 +02:00
Filip Navara 338170ecce Fix check for SafeHandle types 2019-09-20 11:44:25 +02:00
monojenkins 6d3f5732f0 [sdks] Remove the mac32 build. (#16952)
Xamarin.Mac doesn't need nor use it anymore.

This also removes the last part of the mono archive that required Xcode 9.4.
2019-09-19 21:45:57 -05:00
Jay Krell d49d7b4716 [Coop] InterlockedCompare/Exchange (object/T) (#16873)
* [Coop] InterlockedExchange (object and T), InterlockedCompareExchange (object and T).

 - Usually intrinsified.
 - Always?
 - Avoid coop handles by manually always using ref to object.
 - For efficiency on input, and efficiency wrt MonoError.
 - For correctness on output (due to aliasing in the wrappers).
 - To probably avoid assertion failure in runtime around icall marshaling of generics.
 - Unclear on location.

* Balance parens in prints, so they are balanced in the code.

* Reduce local arrays from 16 to auto-sized 1.

* Update and reformat System.Threading.Interlocked signature recognition.

* Rename the generic again to "_T" (or "Generic"?) on the theory
that the aot-runtime.c signature check is too strict/incorrect,
but that if we loosen it, it is not clearly specific to the generic.

* Revise corlib version again.

* Bump API snapshot submodule
2019-09-19 22:36:18 -04:00
Zoltan Varga c730a2a2e3 [llvm] Handle recursive calls as a direct call. (#16944)
Fixes https://github.com/mono/mono/issues/16943.
2019-09-19 21:43:49 -04:00
Jay Krell d02c121f79 Inline mono_thread_interruption_request_flag. (#16906)
Note that the name mono_thread_interruption_request without trailing flag
was already taken.
2019-09-19 15:49:43 -05:00
Filip Navara 81b5819528 [netcore] Show line numbers when xunit tests fail (#16931) 2019-09-19 14:08:07 -04:00
Alexander Köplinger f6a080bb79 Add .NET 4.8 reference assemblies (#16912)
Brings in https://github.com/mono/reference-assemblies/pull/20
2019-09-19 14:06:41 -04:00
Egor Bogatov 5e5033f5e5 Fix StackOverflow in ApplicationTrustEnumerator
ApplicationTrustEnumerator used to call itself. The following snippet crashed with SO:

using System.Security.Policy;
public class Program {
        public static void Main (string[] args)
        {
            ApplicationTrustCollection col = ApplicationSecurityManager.UserApplicationTrusts;
            col.GetEnumerator ();
        }
}
2019-09-19 14:05:15 -04:00
Jay Krell 06a814e66f Balance parens in prints, so they are balanced in the code. (#16930) 2019-09-19 12:19:59 -04:00
Martin Baulig 1256d6c8cf Use NetworkStream from CoreFX. (#16889)
* Use `NetworkStream` from CoreFX.

This brings the `NetworkStream` class and related tests from CoreFX.

* `SocketAsyncEventArgs`: partially replace the following properties
  with the CoreFX version: `Buffer`, `BufferList`, `Offset`, `SetBuffer ()`
  as well as the internal `CopyBufferFrom ()`.

* `SocketAsyncResult`: change `Buffer` from `byte[]` to `Memory<byte>`.

* Add internal `Socket` overloads:
   - `Receive (Memory<byte> buffer, int, int, SocketFlags, out SocketError)`
   - `ReceiveFrom (Memory<byte>, int, int, SocketFlags, ref EndPoint, out SocketError)`
   - `SendTo (Memory<byte>, int, int, SocketFlags, EndPoint)`

* Implement async task overloads from CoreFX (`Socket.Tasks.cs`) to `Socket`:
   - `int Read(Span<byte>)`
   - `Task<int> ReadAsync(byte[], int, int, CancellationToken)`
   - `ValueTask<int> ReadAsync(Memory<byte>, CancellationToken)`
   - `int ReadByte()`
   - `void Write(ReadOnlySpan<byte>)`
   - `Task WriteAsync(byte[], int, int, CancellationToken)`
   - `ValueTask WriteAsync(ReadOnlyMemory<byte>, CancellationToken)`
   - `void WriteByte(byte)`

* remove internal unused `PooledStream` and `ConnectionPool` APIs.

* bring new tests from CoreFX:
  - `System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.cs`
  - `System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.netcoreapp.cs`

* corlib: add `System.IO.FileSystem` and `System.Net.Sockets` resources and update SR.

* Update Socket.cs

* [csproj] Update project files

* Bump API snapshot submodule
2019-09-19 14:46:29 +02:00
Maxim Lipnin 12949cf2e6 [wasm] Switch to PNSE version of FileSystemWatcher and exclude xunit tests (#16892)
Fixes https://github.com/mono/mono/issues/16876
2019-09-19 08:13:02 -04:00
Zoltan Varga a3d05c2f88 [ci] Precompile runtime tests on the mac-sdk lane before running them with llvm. (#16916) 2019-09-19 12:58:31 +02:00
Jay Krell 8d23dc71b6 Inline mono_object_unbox_internal and mono_object_get_data. (#16856) 2019-09-19 12:41:29 +02:00
Filip Navara 85056b086f Implement Marshal.SetLastWin32Error 2019-09-19 09:59:49 +02:00
Johan Lorensson ad997d3725 Fix build warnings in libmonoruntime. (#16802) 2019-09-19 08:45:44 +02:00
Johan Lorensson 077e76c470 Explicit disable hybrid suspend when cooperative suspend is enabled. (#16798)
hybrid suspend won't get disabled when using --enable-cooperative-suspend
triggering configure error:

Hybrid suspend and Cooperative suspend cannot be both enabled.

Fix explicit set hybrid suspend default behavior to no if cooperative
suspend has been configured.
2019-09-19 08:45:00 +02:00
Ryan Lucia 529a11cf5b Make case-insensitive class lookup work correctly with exported types (#16652)
* Make case-insensitive class lookup work correctly with exported types

* Search all matching namespaces

* Skip AOT cache for case-insensitive lookups
2019-09-18 17:18:30 -04:00
Egor Bogatov 9a4a624501 [netcore] Implement more System.Runtime.Intrinsics.X86.Bmi1/Bmi2 (#16891)
* Implement more BMI1/BMI2

* implement more bmi1 intrinsics

* Update simd-intrinsics-netcore.c
2019-09-18 15:08:35 -04:00
Alexander Köplinger 2cc7c410a7 [ci] Allow running only msbuild tests in "OSX Extended" runs
Needed for mono/msbuild CI so we can skip the lengthy runtime LLVM tests.
2019-09-18 17:35:57 +02:00
Neale Ferguson 86f7cef7f4 - Some more prep for SIMD on s390x (#16903)
- Use __builtin_bswapxx for s390x rather than inline assembler
- s390x ABI specifies that %f8-%f15 are protected between calls so avoid using or save/restore as required
- Save the "protected" FP registers in the context structure
2019-09-18 15:54:27 +02:00
Vlad Brezae b2739b5196 [mini] Add missing membars when initializing rgctx entries (#16904)
[mini] Add missing membars when initializing rgctx entries

Whenever we are publishing changes to the rgctx arrays, we are racing with rgctx_lazy_fetch_trampoline, so we need to make sure any pointers we set there must have their contents initialized.
2019-09-18 09:16:17 -04:00
Jay Krell 12c48df242 All existing safepoints appear to be mooted by pinned coop handles. (#16695)
Perhaps they are never needed then.
2019-09-17 23:39:09 +02:00
Александр Хухлаев f91b64d9ad [WinForms] fix #16626 ControlBox property didn`t hide Close button and icon when set to false (#16627) 2019-09-17 14:26:05 -07:00
Alexander Köplinger e1f5738371 [netcore] Fix compiler warnings (#16883)
This fixes the compiler warnings when building netcore-only on macOS.
2019-09-17 21:18:54 +02:00
monojenkins 2b98112ce1 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes xamarin/xamarin-macios#7005. (#16902)
This is the equivalent of
https://github.com/xamarin/xamarin-macios/commit/a9abc07cb357f9f012e3da66c70fa09d96bf02f7,
just for the Mono.frameworks in the mono archive.

Fixes https://github.com/xamarin/xamarin-macios/issues/7005.
2019-09-17 21:18:22 +02:00
Alexander Köplinger f99acb8fa6 [corlib] Fix building nunit-lite twice (#16894)
We sometimes saw the following build error in Mono SDKs builds on Jenkins:

```
[2019-09-16T01:03:30.709Z] CSC     [xammac] nunit-lite-console.exe
[2019-09-16T01:03:30.709Z] error CS0009: Metadata file '/Users/builder/jenkins/workspace/archive-mono/2019-08/mac/release/mcs/class/lib/xammac/nunitlite.dll' could not be opened -- PE image doesn't contain managed metadata.
```

Taking a closer look we found out that nunit-lite was trying to be built twice for the same profile which caused a race where the file was corrupted.

The reason for this is that the corlib Makefile defines two test assemblies: the normal PROFILE_corlib_test.dll and BinarySerializationOverVersionsTest.dll and
integrating the BinarySerializationOverVersionsTest.dll via the `test-vts` target incorrectly overwrote the `test` target instead of using `test-local`.
2019-09-17 20:25:52 +02:00
Vlad Brezae 906c71b8bf [interp] Fix stack size regression (#16887)
Partly revert https://github.com/mono/mono/commit/b18840e92cb5b1afef6c0e5df05cc026eb32efbf
2019-09-17 19:27:51 +03:00
Stephen Toub 569878fe14 Remove allocations from Dns.* (dotnet/corefx#41061)
This started as an effort to reduce the size of System.Net.NameResolution.dll when publishing a trimmed app.  It's not that big to begin with, but it's carrying around a copy of all of the IAsyncResult helper types, because the Get*Async methods are currently wrappers for the Begin/End* methods.

This PR inverts that, wrapping the Begin/End* methods instead around the Get*Async methods, using the same TaskToApm helper we use in other places in corefx for the same purpose.  This makes the Get*Async methods faster and lighterweight, but it does increase the number/amount of allocation in the Begin/End* APIs.  Since these are considered legacy, I normally would consider that a good trade, however we still use these Begin/End methods in a few places in System.Net.Sockets, and I didn't want to regress those use cases.

So, this also then trims some additional fat, which helps the Get*Async cases even further, and gets the Begin/End* to be even better than before the change.  This includes not allocating an IPHostEntry when we're just going to unwrap it and return its addresses, computing the exact IPAddress[] size we need rather than using a List<> to grow it and ToArray to create the actual array, avoiding creating the HostName if we don't need it, and avoiding an unnecessary SafeHandle allocation.

As part of this, I also noticed that we had some bugs in how some of our interop structures on Windows were defined.  In particular, fields that in the native types were size_t were defined as int rather than IntPtr in the managed code.  It appears we were saved by padding, but I fixed it regardless.

And as long as I was changing pretty much everything else, where I was touching code I also cleaned up some legacy style stuff.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-17 16:13:18 +02:00
dotnet-maestro[bot] a195b746c6 Update dependencies from https://github.com/dotnet/roslyn build 20190912.11 (#16885)
- Microsoft.Net.Compilers - 3.3.1-beta4-19462-11
2019-09-17 13:18:45 +02:00
Johan Lorensson e4998f5fc4 Exclude AppleTypes from orbis System.dll. (#16814)
* Exclude AppleTypes from orbis System.dll.

* [csproj] Update project files
2019-09-17 13:03:16 +02:00
Jay Krell fb71d47543 [interp] Use +=, *= etc. Seems to generate identical code though. (#16848)
i.e. a = a op b is *not* double evaluating a.
2019-09-17 13:23:19 +03:00
Ryan Lucia 6252794ebe Temporarily disable embedded ppdb data decompression (#16868)
This addresses #16373. We will work on a proper fix, but this at least unblocks Roslyn CI
2019-09-17 11:23:05 +02:00
Bernhard Urban 578e1a9dda [arm64_32] make "Debug Mode" work on Watch series 4 with --interpreter (#16865)
[arm64_32] make "Debug Mode" work on Watch series 4 with --interpreter

Main objective for reviewers: This PR shouldn't change anything for `arm64`.

Context: "Debug Mode" on the Apple Watch allows execution of regular machine code and thus is pretty similar to FullAOT on iPhone, i.e. it doesn't require bitcode, but _still_ doesn't allow `signal(3)` so cooperative suspend is required.

Apple Watch Series 4 and onward use an ARM64 chip, but with a different ABI, also known as `arm64_32`. This PR changes the AOT compiler and related trampolines so that the AOT compiler can generate all necessary code to run the interpreter on this target.


Changes:

--------------------------------------

[arm64_32] set register size to 8 in cross compiler too 

-----------------------------------------

 [machine] update `target_mgreg_t` definition

`SIZEOF_REGISTER` is usually the same as `TARGET_SIZEOF_VOID_P`, except when `MONO_ARCH_ILP32 is defined.

`target_mgreg_t` should represent the width of the hardware register, that is, `SIZEOF_REGISTER`.

---------------------------------------------

[arm64_32] fix AOT image layout 

---------------------------------------------

 [arm64_32] make trampolines bitwidth aware

* replace pointer loads/stores with bitwidth-dependent macro
* reflect `specific` trampolines so that only two instructions are used for ILP32, since the related pair in the data page only needs 2 * 32bits too
* replace some `sizeof (target_mgreg_t)` with `TARGET_SIZEOF_VOID_P` (former is hardware register size, latter is pointer size)

---------------------------------------------
These regression tests are _not_ passing: https://github.com/mono/mono/issues/16864 Also some of monotouch-tests are crashing, see https://github.com/mono/mono/issues/16819

Here is a screenshot of a debug session in VSMac:
<img width="1321" alt="Screenshot 2019-09-16 at 19 13 22" src="https://user-images.githubusercontent.com/75403/64981326-1dfbc000-d8bc-11e9-9d16-48036f36b638.png">


Contributes to https://github.com/mono/mono/issues/10641
2019-09-17 05:15:19 -04:00
Nikolay Sivov 08521a1c43 [cominterop] Default to [in] parameter direction when not specified explicitly.
Treat [In, Out], [In] and unspecified as input arguments. Important change from
current behavior is to allow parameter without directional attributes.

Use case example is _MethodInfo.Invoke() method called from native client.
2019-09-17 11:06:17 +02:00
Jay Krell af185d2c1e [interp] Cleanup dispatch macros. (#16784)
- Factor out reptition into already existing macros.
 - Remove the default for computed goto which is dead.
   Computed goto has no notion of default. It is just
   an unchecked array access.

Extracted from https://github.com/mono/mono/pull/16721.
2019-09-17 10:55:45 +02:00
monojenkins 16ed5ec3aa [csproj] Update project files 2019-09-17 10:53:46 +02:00
Radek Doulik e7f3db9796 [android sdk] Add aprofutil tool 2019-09-17 10:53:46 +02:00
Zoltan Varga 1031c4650d [llvm] Use IntPtrType () for byref arguments instead of a pointer, the latter causes problems when pointer operations are used along with phi nodes. Fixes https://github.com/mono/mono/issues/16808. (#16874) 2019-09-17 03:53:52 -04:00
Vlad Brezae aaaa2bdd5e [interp] Optimize multidimensional array access (#16822)
* [interp] Pass rank instead to LDELEMA

It feels more intuitive and uses less computations.

* [interp] Avoid unnecessary type check

Loading element address of array requires type checks only if the elements of the array are references.

* [interp] Avoid using MINT_CALLRUN for Get intrinsic

It is very slow. Use ldelema/ldobj pair instead.

* [interp] Optimize MINT_LDELEMA

* [interp] Rename ldelema_fast to ldelema1

ldelema_fast was handling arrays with a single dimension. Rename it to better suggest this.

* [interp] Avoid using MINT_CALLRUN for Set intrinsic

* [interp] Remove some duplicated and confusing code

* [interp] Fix stack type of MINT_NEWARR result
2019-09-17 10:32:20 +03:00
Stephen Toub 87072b55c0 Update typo in comment in CultureInfo.cs
Signed-off-by: dotnet-bot <[email protected]>
2019-09-17 09:19:11 +02:00
Tarek Mahmoud Sayed 77473d11b7 Fix calendar instance inside the culture after cloning (#26721)
When creating a new culture, we’ll have the equality CultureInfo.DateTimeInfo.Calendar == CultureInfo.calendar be true. After cloning such culture, this equality would not be true. The fix here is to ensure if the equality is true before cloning then should be true after cloning.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-17 09:19:11 +02:00
Zoltan Varga 38b2d4f4fe [wasm] Bump emscripten to 1.38.45. (#16871) 2019-09-16 23:37:30 -04:00
Johan Lorensson e8570d9500 Fix warnings in eglib gspawn.c on platforms lacking fork/execv. (#16801) 2019-09-16 17:18:59 -04:00
Filip Navara 17fe4757a3 [netcore] Make Environment calls thread-safe (#16852)
* [netcore] Make Environment calls thread-safe

* Address PR feedback

* Address PR feedback
2019-09-16 17:16:14 -04:00
Ryan Lucia a23da4b8b3 [debugger] remove extraneous ErrorCode declaration (#16862)
With the single point of exit, this means the main ErrorCode isn't being written to and uninitialized memory is returned.
2019-09-16 17:14:42 -04:00
Zoltan Varga 422d559ea4 [wasm] Initial netcore support. (#16718)
* [runtime] Fix configure support for netcore+out of tree builds. Add wasm support for generating netcore/config.make.

* [runtime] Add bundle support for the netcore assembly loader.

* [netcore] Add missing linker exclusion.

* [wasm] Add netcore builds, enabled by defining ENABLE_WASM_NETCORE in Make.config.

The targets are 'package-wasm-runtime-netcore' and 'package-wasm-bcl-netcore'.
The binaries are copied to out/wasm-runtime-netcore-<CONFIG> and out/wasm-bcl/netcore.

* [wasm] Add netcore support to the build system and packager.

* Fix the build.

* Fix the dynamic build.
2019-09-16 15:42:57 -04:00
Kenneth Pouncey e8b2b43f9b Bump sdk and bindings versions (#16809) 2019-09-16 09:34:41 -05:00
Kenneth Pouncey d435a85658 Bump Browser tests Karma version (#16810) 2019-09-16 09:31:44 -05:00
Nikolay Sivov 800e2cc4b4 [corlib] Improve reflection interface definitions (#16324)
* [corlib] Fix _Type interface definition.

* [corlib] Fix Type class attributes.

* [corlib] Fix _MethodInfo interface definition.

* [corlib] Fix MethodInfo class attributes.

* [corlib] Merge MethodInfo partial definitions.

* [corlib] Remove leftovers from testing.

* [corlib] Do not define new attributes for MOBILE build.

* Bump API snapshot submodule

* [corlib] Add explicit _MethodInfo.GetType() implementation.

* Bump API snapshot submodule

* [csproj] Update project files
2019-09-16 13:00:40 +02:00
Jay Krell 9f3effc177 Strike a size and conditional branch balance between (#16836)
https://github.com/mono/mono/pull/16835
and
 https://github.com/mono/mono/pull/16834

The main 4 call opcodes should have no conditionality here.
The non-virtuals no extra branch.
The other opcodes all have one condition and branch into common code.

Everything could be smaller or faster but not both.
2019-09-16 10:10:47 +03:00
Jay Krell 67fb575d11 [Coop] ParseRouteInfo, fix some leaks, cleanup. (#16815) 2019-09-16 00:10:12 -04:00
Johan Lorensson 7fa706a316 Fix infrequent hangs in test-runner. (#16793)
* Fix infrequent hangs in test-runner.

test-runner has been plagued with very infrequent hangs causing long
timeouts on CI. Turns out that there is a race in AsyncStreamReader
used by Process class for handling stdout/stderr when closing down
process. Since AsyncStreamReader::Dispose didn't make sure no pending
async read requests were still in flight before closing the stream
and underlying handle, it led to a race condition deadlocking the
complete process, hanging test-runner. A similar race has also been
observed but instead of causing a deadlock, it could also manifest as an
System.ObjectDisposedException when doing EndRead while another thread
is disposing the underlying stream. Hitting that race didn't deadlock
the process but failed to complete invoke of test-runner.

Fix is to better protect the async callback and the thread doing the
dispose call. In order to make sure we don't close underlying handle
while still having async reads in flight, fix also checks async result
for completion and if not completed when trying to dispose AsyncStreamReader
it will try to cancel outstanding pending IO and wait for completion
before closing the stream.

Since the issue has only been seen on Windows, the fix will try
to cancel pending IO and wait for completion before closing stream
on Windows. On other platforms, old behavior will be preserved, meaning
that the implementation will still be vunarable to race between pending
reads and close of stream, but since problem has not been observed on
other platforms and since there is no good way of cancel outstanding
blocking reads, old behavior is kept.

At some point in future we should look into replacing the implementation
of AsyncStreamReader and use cancelation tokens, but since we don't have
all corefx support around cancelation in Mono BCL, that currently won't
solve the issue, meaning that we need to bring in more classes. Since the
problem also occur in test-runner using the build BCL profile, even more
needs to be added to that profile in order to get similar support. But due
to the infrequency of the problem and that it has only been observed on
Windows, the isolated fix seems more reasonable.

* Build error fix.

* Review feedback.

* Fix type cast not working on linux builds.

* Adjust icall naming in icall-def.h.
2019-09-15 19:51:07 -05:00
Jay Krell 8da3616e7f [Coop] GetValueInternal. (#16811) 2019-09-15 19:50:25 -05:00
Johan Lorensson 9249d38079 Fix warnings in libmono. (#16813) 2019-09-15 19:49:53 -05:00
Zoltan Varga cdb04c042f [netcore] Change an ArrayList to a List<T>. (#16842)
* [netcore] Change an ArrayList to a List<T>.

* [netcore] Call the generic version of Array.IndexOf () in the ICollection wrappers. Update exclusions file.
2019-09-15 20:45:13 -04:00
Egor Bogatov 0438397b8a LLVM: Dump Module instead of Function in JIT mode (#16837)
Since each function has its own module (in JIT mode) it makes sense to dump the whole module for MONO_VERBOSE_METHOD instead of just LLVM::Function.
It adds metadata, attributes and global variables (so it will be possible to copy-paste it to godbolt)

Example

static int Test(int x)
{
    return x / 10;
}

Diff for Unoptimized IR: https://www.diffchecker.com/NrF413Ts
Diff for Optimized IR: https://www.diffchecker.com/jbEkeFFS

So now we can see global variables and metadata for each function (and can easily paste them to godbolt.org)

NOTE: optimized IR for this case contains "dead" variables (dump_module allowed us to see such), we probably need some Module-wide optimizations to strip dead code such as -globaldce

NOTE2: why do we emit exceptions in the first place for this case at all?
2019-09-15 20:43:10 -04:00
Jay Krell 304f3add20 [interp] Speed up passing this parameter. (#16846) 2019-09-15 22:26:41 +03:00
Dotnet-GitSync-Bot 189af5d0c2 Remove some boxing from tuples with >= 8 elements (dotnet/coreclr#26584) (#16844)
Take advantage of https://github.com/dotnet/coreclr/pull/14698 to avoid boxing the TRest argument and improve devirtualization.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-15 12:48:15 -04:00
Calvin Buckley babe881bf2 Fix small sized argument output with tracing enabled (#16841)
This is a legacy of before the profiler was used for the trace
output; it would apparently get the raw stack pointer and try to
dereference things by recalculating the offset as needed (no for
little, yes for big). However, because the profiler returns the
actual fixed-up pointer, this recalculation isn't needed on BE,
but instead grabs garbage a bit ahead on the stack.

To fix, use what was the little endian case unconditionally.

Example before:

[1: 20.70598 14] ENTER: System.Globalization.CultureInfo:.ctor (int,bool,bool)(this:700000000408fb0[System.Globalization.CultureInfo platform.exe], 271824864, -32, -32, )

Example after:

[1: 1.93377 14] ENTER: System.Globalization.CultureInfo:.ctor (int,bool,bool)(this:700000000408fb0[System.Globalization.CultureInfo platform.exe], 127, 0, 1)
2019-09-15 11:50:32 -04:00
Jay Krell 9608debd7b [Coop] ves_icall_InternalExecute. (#16611) 2019-09-13 08:57:45 -05:00
Radek Doulik 131b3a9a92 [aot] Do not wrap tool_prefix path when calling strip (#16792)
[aot] Do not put quotes around wrapped path

Should fix: https://github.com/xamarin/xamarin-android/issues/3619

As it results in double quoting, which vanishes the effect and breaks
AOT for XA on Windows.

The actual error:

    [aot-compiler stdout] Stripping the binary: ""C:\Program Files (x86)\Microsoft Visual Studio\2019\Stable\MSBuild\Xamarin\Android\ndk\arm-linux-androideabi-"strip" --strip-symbol=\$a --strip-symbol=\$d obj\Release\90\aot\armeabi-v7a\libaot-Xamarin.Android.Arch.Core.Common.dll.so.tmp
    [aot-compiler stderr] '""C:\Program' is not recognized as an internal or external command,
    [aot-compiler stderr] operable program or batch file.
    [aot-compiler stderr] AOT of image C:\Users\peter\source\repos\App9\App9\App9.Android\obj\Release\90\android\assets\Xamarin.Android.Support.CoordinaterLayout.dll failed.
2019-09-13 09:05:27 -04:00
Filip Navara 10e72a7ab6 Improve alias analysis for pointer sized variables (#16812) 2019-09-13 08:02:50 -05:00
Vlad Brezae 6908a1941b [interp] Propagate locals and kill dead ones afterwards (#16791)
* [interp] Add flag for locals that have their address taken

The previous handling of LDLOCA was broken because if the address was taken before the instructions that would be optimized we would miss any potential changes to the local value. Right now we just skip optimizing locals that have their address taken. This is achieved simply by not pushing LDLOC on the evaluation stack, for those locals.

* [interp] Add separate counters for optimized instructions

To provide more insight.

* [interp] Propagate locals

Whenever we generate a movloc we remember what local was copied. When loading a local we check if it's currently storing the value of another local, in which case we load the original local instead.

* [interp] Kill instructions that write to dead locals

We track the liveness of a local by counting how many times the local is loaded using ldloc. When such instructions are optimized, the ldloc counter is updated accordingly.

* [interp] Don't optimize code if under debugger
2019-09-13 10:35:44 +03:00
Jay Krell 735b2cd20c [interp] Replace frame_objref with a volatile store to local. (#16790)
* [interp] Replace frame_objref with volatile stores to non-volatile locals.
Non-volatiles subject to volatile read/write still get stack-packed.
Volatiles do not.

This will possibly conserve stack, unless MINT_NEWOBJ_FAST is critical path.
 It looks like it is -- enabling this for Linux/gcc/amd64 grows
  frame from 0x98 to 0xA8.

In either case, it is more efficient as the reads do not have to be volatile.
The value can be on the stack and in registers. The stack value will pin it.

* PR: Comments.

* PR: Rearrange comment for correctness, same length.
2019-09-12 21:39:02 -05:00
Maxim Lipnin fe19944155 [ci][wasm] Use only V8 step to run corlib tests, which can reduce build time 2019-09-12 19:32:01 -05:00
Vlad Brezae aa18379968 [interp] Add percentage to opcode count stats 2019-09-12 19:29:13 -05:00
Vlad Brezae 6d75b066ee [interp] Disable computed goto when debugging interp
It makes tracing and following the code more painful.
2019-09-12 19:29:13 -05:00
Vlad Brezae 54a7e61115 [interp] Fix COUNT_OPS
And make it print the sorted opcode counts when runtime is shutting down
2019-09-12 19:29:13 -05:00
Next Turn 9f93d5d15c Modernize Array constructor (dotnet/coreclr#26684)
Signed-off-by: dotnet-bot <[email protected]>
2019-09-12 19:27:58 -05:00
naricc bfe5e1efd3 Merge pull request #16388 from naricc/naricc/GetTotalAllocatedBytes
Naricc/get total allocated bytes
2019-09-12 18:12:26 -04:00
Jay Krell b2a1c6cd92 [Coop] Debugger single point of exit. (#16620)
* [Coop] Debugger single point of exit.
Extracted from https://github.com/mono/mono/pull/16614.

* Use a label per error for code size.
2019-09-12 17:57:02 -04:00
Sung Yoon Whang 3f26b9aa6c Improve the performance of Environment.WorkingSet in Windows (#26522)
* Use win32 api directly for workingset counter

* Fix build warnings

* Removing useless code

* more cleanup

* remove size annotation

* remove useless comment

* Move all the changes to Environment.WorkingSet and remove it from RuntimeEventSourceHelper

* removing useless usings

* Use kernel32.dll instead of psapi.dll

* Code review feedback

* Remove newline change

* More code review nits

Signed-off-by: dotnet-bot <[email protected]>
2019-09-12 13:27:35 -05:00
Jan Kotas 0055195d1c Change Vector<T> to use more compact code using S.R.CS.Unsafe (#26637)
S.R.CS.Unsafe is used in number of places in Vector<T> already. This change modifies more places to use it to make the code more compact.

Updated Vector.tt template to match while I was on it

Signed-off-by: dotnet-bot <[email protected]>
2019-09-12 13:27:35 -05:00
Marek Safar 43c5aa0dad Remove unused Memcpy methods from shared Buffer implementation (#26586)
Signed-off-by: dotnet-bot <[email protected]>
2019-09-12 13:27:35 -05:00
obligaron 1b48b44661 Improve logging for EventSource.WriteEvent parameter mismatch (#25533)
* improve logging for EventSource.WriteEvent

* Fix IndexOutOfRangeException in SerializeEventArgs when incorrect arguments got passed

* simplify arg-check; remove nullable-todo

* switch from Debugger.Log to ReportOutOfBandMessage

* Remove unused flush-Paramater from ReportOutOfBandMessage

* fix parameter type nullable-check for reference-types

* fix parameter type nullable-check for nullable-types

Signed-off-by: dotnet-bot <[email protected]>
2019-09-12 13:27:35 -05:00
Vlad Brezae 72405f68af [interp] Emit more stloc.np (#16796)
Use STLOC_NP_O also for MINT_TYPE_P. It has the same behavior.
2019-09-12 12:46:22 -05:00
Filip Navara 017f21c2c6 [mini] Fix couple of R4 constant folding checks (#16782)
* Fix couple of R4 constant folding checks

* Address feedback

* Split RMOVE and FMOVE
2019-09-12 12:37:52 -04:00
Jay Krell 9bb3912590 [interp] Remove unused parameters. (#16773) 2019-09-12 15:42:23 +03:00
Jay Krell c7df01524a [interp] Add assert in jmp that sp == stack at start. (#16788)
It makes it true sometimes, only if not calling alloca.
Throwing invalid IL if false might be preferred here.
2019-09-12 15:06:31 +03:00
Egor Bogatov 977a37844b [netcore] Add LLVM to nuget (#16524)
* nuspec for llvm

* Add llvm to matrix

* fix scripts/ci/pipeline-netcore-runtime.yml

* fix scripts/ci/pipeline-netcore-runtime.yml

* fix scripts/ci/pipeline-netcore-runtime.yml

* run tests with llvm

* add macOS lane

* disable llvm tests for now
2019-09-12 13:09:03 +02:00
Maxim Lipnin c241b25bb5 Avoid creating un-representable DateTime for transition point (#16753)
Fixes https://github.com/mono/mono/issues/16742
2019-09-12 05:11:22 -04:00
Steve Pfister 95cd0e74b1 Bump to mono/corefx@e79cf5b 2019-09-12 08:57:15 +02:00
EgorBo 1d324e617a Fix DynamicMethodToString.ToStringTest 2019-09-12 08:55:12 +02:00
EgorBo 313ce184be use full name for llvm ir and asm dumps 2019-09-12 08:55:12 +02:00
Jay Krell 2235e37470 [interp] Fix buffer overreads and overwrites found by valgrind. (#16726)
* [interp] Fix buffer overreads and overwrites found by valgrind.

* Attempt to deal with inlining correctly.

* PR: Dial back IR changes. Only IL relevant.

* PR: Dial back more -- only needed changes to .NET IL manipulation, not interpreter IR manipulation.

* PR: Remove one more line.
2019-09-11 19:35:05 -05:00
Zoltan Varga 6a1ac97dc7 [netcore] Create a separate version of threadpool.c for netcore with the domain support removed. (#16250)
* [netcore] Create a separate version of threadpool.c for netcore with the domain support removed.

* Fix the windows build.

* Fix the build.
2019-09-11 20:04:44 -04:00
Maxim Lipnin a67212d34c [wasm] update run-jenkins.sh (#16771)
* replaced set of run-*-mini targets with more common run-all-mini one;
* removed redundant run-v8-corlib (there is run-all-corlib)
2019-09-11 15:28:07 -04:00
Nathan Ricci 4acfcef038 White space, naming convetions. 2019-09-11 14:43:06 -04:00
Nathan Ricci b88d67d564 White space issues, typos. 2019-09-11 14:28:16 -04:00
Jay Krell f4c1358ed0 [interp] Reduce register pressure in endfinally.
Eventually this could contribute to stack savings. On its own, nothing.
The compiler apparently likes to create temporaries, like ip and ip - 1.
Which then have to survive functions calls, on the stack, if nonvolatile registers are exhausted.
This combats that and in a larger PR helped.
2019-09-11 11:19:44 -05:00
Steve Pfister 5ad1d62367 Use an init-tools script to install a local dotnet for wasm. (#16688)
Similar to what we use in netcore
2019-09-11 09:14:05 -04:00
Zoltan Varga feb0b4ab9a [wasm] Add a separate test for profiled aot. 2019-09-11 07:44:34 -05:00
Zoltan Varga 52d24a57d2 [aot] Emit interp entry code for methods which are not AOTed when using AOT profiling. Also emit most wrappers. 2019-09-11 07:44:34 -05:00
Radek Doulik 52aa2cd3e1 [aprofutil] Add -p and -f options (#16766)
-p PORT allows easier retrieval of AOT profile from the application
 running with aot profiler, using the socket connection on local PORT

-f instructs the tool to try setup adb port forwarding to/from Android
 device or emulator

Example usage, retrieve the AOT profile from Android:

    > mono aprofutil.exe -s -v -f -p 9998 -o my.aprof
    Calling 'adb forward tcp:9998 tcp:9998'...
    Reading from '127.0.0.1:9998'...
    Read total 94903 bytes...
    Summary:
    	Modules:          6
    	Types:          262
    	Methods:      1,162
    Going to write the profile to 'my.aprof'
2019-09-11 07:42:58 -05:00
Tarek Mahmoud Sayed f97ceb5c3e Fix Running .NET Core Under Windows App Compat Shim (dotnet/coreclr#26605)
* Fix Running .NET Core Under Winndows App Compat Shim

.NET Core uses Windows features called sort handles for perf reason to speed up the collation operations (e.g. string comparisons). When enabling Windows app compat shim (e.g. Windows 7 compatibility mode), the calls uses sort handles will fail which cause all collation operations to fail.
The fix here is to detect if the sort handles work before using it to ensure successful run.

* Address the feedback

* More feedback addressing

Signed-off-by: dotnet-bot <[email protected]>
2019-09-11 09:05:40 +02:00
Zoltan Varga 2e78f0c739 [wasm] Add missing aot-profile/runtime.js. (#16762)
* [wasm] Add missing aot-profile/runtime.js.

* [aot] Avoid writing out a zero AOTID in deterministic mode.

* [wasm] Add --aot-profile= option to packager.
2019-09-10 22:24:40 -04:00
Vlad Brezae f1a57de621 [docs] Improve sgen write barrier documentation (#16761) 2019-09-10 20:54:07 -05:00
Zoltan Varga a0ed95fc98 Enable the wasm targets even if ENABLE_WASM is not defined. (#16747) 2019-09-10 20:53:25 -05:00
Larry Ewing b26fd07ff9 [msbuild][roslyn] Bump msbuild and roslyn to pull in new versions (#16744) 2019-09-10 20:30:11 -05:00
Kenneth Pouncey 0847a6d218 [wasm] Dynamic Release RUNTIME configuration (#16749)
* Modify configuration flag `ENABLE_WASM_DYNAMIC_RUMTIME` to `ENABLE_WASM_DYNAMIC_RUNTIME`

* Modify configuration flag `ENABLE_WASM_DYNAMIC_RUMTIME` to `ENABLE_WASM_DYNAMIC_RUNTIME`

* Modify configuration flag `ENABLE_WASM_DYNAMIC_RUMTIME` to `ENABLE_WASM_DYNAMIC_RUNTIME`
2019-09-10 18:04:08 -05:00
Zoltan Varga 697ab15c12 [netcore] Disable more features. (#16748) 2019-09-10 15:36:29 -04:00
Larry Ewing 4790582812 [wasm] test cleanup (#15727)
* [wasm] stop excluding test_0_large_nullable_invoke on wasm

* [wasm] remove wasm exclusion from test_0_simple_double_casts

* Add category MultiThreaded to more of the concurrent collection tests

* Add more MultiThreaded annotations to HttpListener2Test

* Add category MultiThreaded to HttpWebRequestTest

* [wasm] flag more tests that are taking down the runtime

* [wasm] force sockets to throw PNSE in the ctor for now

* [wasm] enable corlib interpreter tests

* [wasm] Increase timeout for corlib tests

* try to fix wasm-cross-win-release-configure on macos
2019-09-10 13:08:58 -04:00
Maxim Lipnin e78ab0b1c0 [wasm] Fix several typos (#16760)
* [wasm] Fix several typos

* add a comment about an error in test class name

* Remove the comment about test class name because it could be passed on xunit command line
2019-09-10 12:36:13 -04:00
Bernhard Urban 68f5613422 [TermInfoDriver] update top/left value on Console.{CursorTop,CursorLeft} access (#16745)
It can be outdated due to writes to `stdout`.

Fixes https://github.com/mono/mono/issues/16701
2019-09-10 17:17:15 +02:00
Kenneth Pouncey eea1ab5994 Remove extraneous -s from EMCC_DEBUG_FLAGS (#16754) 2019-09-10 13:50:20 +02:00
Marek Safar 9894bfa6fa Update tests exclusion 2019-09-10 13:09:56 +02:00
Stephen Toub b434981755 Remove use of WeakReference from corelib (dotnet/coreclr#26597)
Only remaining use is the one place it shows up in public API, in GC.GetGeneration(WeakReference).

Signed-off-by: dotnet-bot <[email protected]>
2019-09-10 13:09:56 +02:00
Tyler Brinkley 05d4f301e9 Make StringComparer.Create throw ArgumentNullException (#26570)
* Make StringComparer.Create throw ArgumentNullException

Throws proper exception.

* Update CoreFX.issues.rsp

Signed-off-by: dotnet-bot <[email protected]>
2019-09-10 13:09:56 +02:00
Stephen Toub 5f9d09bc90 Remove remaining ToLower() use from corelib (dotnet/coreclr#26602)
Also happens to save a string allocation, but that's a drop in the bucket in this function.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-10 13:09:56 +02:00
Stephen Toub 3c503413e0 Remove sub-array allocation from GetManifestResourceNamesList (#26601)
Also removes dependency on System.Range and RuntimeHelpers.GetSubArray in a simple console app such that they can be trimmed away.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-10 13:09:56 +02:00
Marek Safar 96b7fead33 [netcore] Update System.Private.CoreLib public APIs 2019-09-10 12:11:31 +02:00
Bernhard Urban e40e24b4cd [aot] move method_addresses to data.rel.so section to avoid text relocations (#16729)
[aot] move method_addresses to data.rel.so section to avoid text relocations

Another revert of a revert! 🎉 

After some discussions with @grendello and @radekdoulik, we came up with this solution. It's a better attempt to fix https://github.com/mono/mono/issues/16369 as it (1) works within the restrictions of Android 10 and (2) still works for armv7 AOT. 


`.text` relocations aren't allowed in Android 10 (and this change shouldn't hurt on Linux).

AOT compilation:
```console
$ MONO_PATH=/Users/lewurm/Downloads/xamarin.android-oss-v10.0.99.136_Darwin-x86_64_pr_766265b9-Debug/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v1.0/ \
MONO_ENV_OPTIONS="" \
./sdks/out/android-cross-arm-release/bin/armv7-linux-android-mono-sgen \
--aot=keep-temps,outfile=here.dll.so,asmwriter,mtriple=armv7-linux-gnueabi,tool-prefix=/Users/lewurm/android-toolchain/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/bin/arm-linux-androideabi-,ld-flags= \
~/Downloads/xamarin.android-oss-v10.0.99.136_Darwin-x86_64_pr_766265b9-Debug/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v10.0/Mono.Android.dll

Mono Ahead of Time compiler - compiling assembly /Users/lewurm/Downloads/xamarin.android-oss-v10.0.99.136_Darwin-x86_64_pr_766265b9-Debug/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v10.0/Mono.Android.dll
AOTID 7DDD05DA-37E0-813A-8C27-3E1634391BB3
Compiled: 144382/144382
Executing the native assembler: "/Users/lewurm/android-toolchain/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/bin/arm-linux-androideabi-as"   -mfpu=vfp3 -o /var/folders/p3/5279mmgn1p575bz28j0ngfqw0000gn/T/mono_aot_550yHJ.o /var/folders/p3/5279mmgn1p575bz28j0ngfqw0000gn/T/mono_aot_550yHJ
Executing the native linker: "/Users/lewurm/android-toolchain/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/bin/arm-linux-androideabi-ld"  -shared -o here.dll.so.tmp  /var/folders/p3/5279mmgn1p575bz28j0ngfqw0000gn/T/mono_aot_550yHJ.o
Stripping the binary: "/Users/lewurm/android-toolchain/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/bin/arm-linux-androideabi-strip" --strip-symbol=\$a --strip-symbol=\$d here.dll.so.tmp
Retained input file.
JIT time: 15031 ms, Generation time: 7374 ms, Assembly+Link time: 75130 ms.
```

Before:
```console
$ grep -C 6 'method_addresses:' /var/folders/p3/5279mmgn1p575bz28j0ngfqw0000gn/T/mono_aot_550yHJ
        .align 3
jit_code_end:

        .byte 0,0,0,0
.text 1
        .align 3
method_addresses:
        .local method_addresses
        .type method_addresses,#function
ldr pc,=.Lm_0
.ltorg
ldr pc,=.Lm_1
.ltorg
$ arm-linux-androideabi-readelf -a here.dll.so | grep -i textrel
 0x00000016 (TEXTREL)                    0x0
 0x0000001e (FLAGS)                      TEXTREL
```

After switching to `.data.rel.so`:
```console
$ grep -C 6 'method_addresses:' /var/folders/p3/5279mmgn1p575bz28j0ngfqw0000gn/T/mono_aot_1YhAgn  # assembly file produced by AOT compiler
jit_code_end:

        .byte 0,0,0,0
.section ".data.rel.ro"
.subsection 0
        .align 3
method_addresses:
        .local method_addresses
        .type method_addresses,#object
ldr pc,=.Lm_0
.ltorg
ldr pc,=.Lm_1
.ltorg
$ arm-linux-androideabi-readelf -a here.dll.so | grep -i textrel
$ echo $?
1
```
2019-09-10 04:16:07 -04:00
Marek Safar e819930ea2 Disable failing tests 2019-09-10 10:03:42 +02:00
Stephen Toub cfc7988318 Replace HashHelpers.Combine with HashCode.Combine (dotnet/coreclr#26589)
* Replace HashHelpers.Combine with HashCode.Combine

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-09-10 10:03:42 +02:00
Jérôme Laban 11f75e5260 [Wasm] Restore release-dynamic configuration (#16655)
* [Wasm] Restore release-dynamic configuration

* Add conditional dynamic linking support, update documentation
2019-09-09 17:21:51 -04:00
Nathan Ricci f7dcc20bc6 Refactored where the varaibles for allocation count live. 2019-09-09 16:39:51 -04:00
Zoltan Varga f5d43ad341 Enable the wasm targets even if ENABLE_WASM is not defined. Update README. (#16743) 2019-09-09 16:37:05 -04:00
Thays Grazia 055818f344 Vtable [i] can be null so this should be check before use it. (#16733)
Fixes #16712
2019-09-09 17:07:34 -03:00
Maxim Lipnin ba2bb209ba [wasm] update build.sh (#16737) 2019-09-09 12:37:54 -05:00
Jay Krell 83f965eca5 [interp] Let compiler decide clear_resume_state inlining. (#16704)
Manual inlining shows no additional stack use any longer.
2019-09-09 12:31:37 -05:00
Zoltan Varga 798af66137 [llvm] Mark Vector128/Vector256 types as SIMD.
These are not currently supported, but marking them as simd helps llvm eliminate dead variables with these types, since
XZERO is easier to eliminate than VZERO.
2019-09-09 19:09:29 +02:00
dotnet-maestro[bot] e563d3c76c Update dependencies from https://github.com/dotnet/arcade build 20190906.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19456.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19456.2
2019-09-09 19:03:51 +02:00
Nikolay Sivov 8590a25b30 Default to SAFEARRAY(VARIANT) as CCW argument for object[]. (#16673)
* [cominterop] Add a helper to create default marshal spec for ccw arguments.

* [cominterop] Default to SAFEARRAY(VARIANT) as CCW argument for object[].

* [cominterop] Fix build with --enable-cxx.
2019-09-09 19:02:46 +02:00
Jay Krell 1f76ab9270 [interp] Embrace that ip is const guint16* and remove casts to that type, (#16708)
[interp] Embrace that ip is const guint16* and remove casts to that type.

or to gint16*. Or is there a reason for this style?

Maybe could change type but still want to cast for the deref?
2019-09-09 11:06:16 -04:00
Vlad Brezae b9dbd2ff91 [interp] Defer local offset allocation to compacted emit phase (#16714)
Before this commit, the only information associated with a local was just the offset at which it resides and instructions had this offset embedded from the start. This makes it awkward to have data structures indexed on the local, or have additional information per local, which we might care at some point (for example if it is multi basic block local, if the address of the local was taken etc). In addition to this, if we will want to remove some instructions that make some locals dead, it means that we will have to compact the whole locals space and update all the offsets referenced by all instructions. We solve all these problems by resolving (and allocating) the local offset at the latest time, while emitting the instruction in the compacted byte stream. At this point dead locals will remain dead, with no additional work needed to handle them.

For now, IL locals of the current method that we are compiling are immortal. We can address that later if needed.
2019-09-09 17:10:50 +03:00
Filip Navara 320f91129d [netcore] Tweak inlining heurestic for memcpy 2019-09-09 10:56:20 +02:00
David Karlaš 13391beeed Fix Xaml reader to parse escaped values correctly 2019-09-09 10:05:57 +02:00
Michal Strehovský d81ec88406 Mark unsafe intrinsics as reflection blocked
Keeping these reflection enabled pulls in quite a bit of junk (generic dictionaries, standalone method bodies, bookkeeping) that adds up to 1.5% of the size of Hello World...

Signed-off-by: dotnet-bot <[email protected]>
2019-09-09 09:24:01 +02:00
Filip Navara cf2c8575e1 [netcore][x64] Implement lowering of new SIMD OPs into SSE opcodes (#16672)
* [netcore][x64] Implement lowering of new SIMD OPs into SSE2 or SSE4.1 opcodes.

* Implement LZCNT/POPCNT in mini JIT

* Fix C++ build
2019-09-08 14:57:21 -05:00
Stephen Toub e15efa37b7 Fix race conditions in CultureInfo.GetCultureInfoHelper (#26567)
The implementation reads the current value of the static cache field and then later overwrites that field with the originally read value.  If ClearCachedData was called in the interim to clear the cached data, this will end up effectively undoing part of that clearing, as it'll end up restoring the previous cache. The fix is to write back the new reference only when we need to, which we could do when we detect it's null.

There's a secondary race condition this fixes as well.  When a name and an altname are used with CultureInfo.GetCurrentCulture(string, string), the implementation was publishig the newly created instance into the dictionary under the lock, but then after the lock was released, it was setting that TextInfo to be read-only.  That provides a window where another thread could see it as non-read-only and mutate it.  The fix is to ensure it's marked as read-only fully before it's published.

As I was doing this, it struck me that the implementation was overly complicated, trying to merge three different code paths for three different callers, presumably to share code, but most of the code ended up not being shared anyway, which just made the code harder to follow for little gain.  So, I split it back out into the three calling functions and removed the helper.

I also changed the locking mechanism.  It had been using a single shared lock to protect all state, but the purpose of the lock is really just to synchronize access to an individual dictionary, so we can just lock on the relevant dictionary.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-08 11:22:09 +02:00
Jay Krell 8c77bcdfaf [interp] Fix debug build. (#16720) 2019-09-08 09:25:33 +03:00
Zoltan Varga d9aaed760f [sdks] Change the DISABLE_ conditionals to ENABLE_ to avoid building extra stuff. (#16719) 2019-09-07 17:30:48 -04:00
Jay Krell 5ba104cf39 [interp] Fix recent warnings I added. (#16722) 2019-09-07 15:30:47 -04:00
Jay Krell b18840e92c [interp] Assign sp once is enough in leave. (#16694)
Move vt_sp there too.
2019-09-06 20:48:15 -05:00
Dotnet-GitSync-Bot 381c187df9 Mirror changes from mono/coreclr (#16713)
* Remove stale SuppressMessage attributes (dotnet/coreclr#26501)

Signed-off-by: dotnet-bot <[email protected]>

* Use null coalescing assignment operator in more places

There's currently no auto-fix for this, so the fixes were done manually.

Signed-off-by: dotnet-bot <[email protected]>

* Fix IDE0026 (use expression-bodied members for indexers)

Signed-off-by: dotnet-bot <[email protected]>
2019-09-06 15:58:38 -04:00
Alexis Christoforides 18fb728c65 Remove accidentally committed debug line 2019-09-06 14:27:57 -04:00
imhameed b4886817ef [jit][llvm] Track variable nullness separately from array length ranges/index ranges in abcrem. (#16499)
* [jit][llvm] Track variable nullness separately from array length ranges/index ranges in abcrem.

"Nullness" is tracked via a separate field that is stored adjacent
variable/array value ranges; values may be "maybe-null" or "not-null";
the intersection of maybe-null and not-null yields not-null, the union of
maybe-null and not-null yields maybe-null. The existing graph traversal logic
is reused as much as possible, which makes the implementation of this
null value approximation slightly more complicated than it would be
otherwise.

Fixes https://github.com/mono/mono/issues/16310, which was caused by
the use of non-empty array length ranges as a way to encode non-null
values.

This also allows null check elision for zero-sized arrays.

* Fix C++ compatibility. Fix a typo in a comment.

* Add symmetric nullness relations.

* Make ldlen imply that the source register is not-null, similar to CHECK_THIS or any other null check.
2019-09-06 08:55:21 -04:00
Vlad Brezae e49be5b9ec [metadata] Fix leaks when handling a few attributes (#16675)
Callers of mono_reflection_create_custom_attr_data_args_noalloc were leaking some of the returned information. Accessed attributes are FixedBufferAttribute and UnmanagedFunctionPointerAttribute.
2019-09-06 10:31:39 +03:00
Thays Grazia c23a8906f3 [debugger][android] It was not initialising seq_points on MonoCompile on Android, so when was compiling dynamic methods, seq_points wasn't created and we got the assert when try to single step. (#16691) 2019-09-05 22:16:50 -03:00
Vlad Brezae f0dabc6618 [interp] Kill InterpFrame.ex (#16666)
* [interp] Reduce unnecessary uses of frame->ex

* [interp] Remove ex from InterpFrame

We save stack space and move the exception where it belongs, in ThreadContext. It was confusing what frame->ex really meant, it was probably not used / initialized properly. We move it now to ThreadContext where it represents the current exception being thrown during EH (when we have a resume state set).
2019-09-05 23:10:13 +03:00
Filip Navara 673c8835fd [netcore] Bump CoreFX, core-setup dependencies (#16681)
* [netcore] Bump CoreFX, core-setup dependencies

* Update .deps.json hacks

* Update test exclusions
2019-09-05 20:03:47 +02:00
Jay Krell 7fc0f8842e [interp] Localize endfinally_ip to leave, and it cannot be null (barring (#16676)
[interp] Localize endfinally_ip to leave, and it cannot likely be null (unless offset carefully formed).
2019-09-05 13:46:12 -04:00
Jo Shields a67839540e Fix distclean (#16667)
* Disable `subdir-objects` mode in Automake

This forces creation of subdirectories' files (e.g. .deps/*.Plo) in the
parent directory listing the source file. This works around a situation
where two different files specify files in a different parent directory
(i.e. ../../support/adler32.c in mono/metadata/ and adler32.c in
support/) both emit files into the same place (support/.deps), causing
`make distclean` to try and delete support/.deps from two different
places, breaking distclean.

This unfortunately adds a pile of Automake warnings, during autogen.

The "correct" fix is to stop specifying zlib as a pile of flat .c files,
and instead put it in its own subdirectory, conditionally including
its .la files as required.

Partially fixes https://github.com/mono/mono/issues/16605

* Ship netcore/Makefile with an empty distclean rule

We need a netcore/ directory because we write to it during configure,
and we need a netcore/Makefile with a distclean rule, so top-level
recursive distclean doesn't fail. So specify both here.

Partially fixes https://github.com/mono/mono/issues/16605
2019-09-05 13:25:48 -04:00
Fan Yang abe48e3fd4 Remove redundant function call of EscapeTypeName to make (#16425)
* Remove redundant function call

* Remove commented out line of code
2019-09-05 18:12:57 +02:00
Maxim Lipnin f617a2692f [wasm] Add build.sh (#16682) 2019-09-05 11:10:05 -05:00
Jay Krell ee85b695c8 [interp] Remove unused parameter to ves_pinvoke_method. (#16677)
[interp] Remove unused parameter to ves_pinvoke_method.

It might actually cause stack pressure (but on its own, this PR does not save stack).
2019-09-05 11:30:59 -04:00
Zoltan Varga c3541c2738 [netcore] Fix the range checks for Vector.CopyTo(). (#16663)
* [netcore] Fix the range checks for Vector.CopyTo().

* [netcore] Fix Vector.get_Item () for u1/u2, the llvm type is a vector of i1/i2, so we need to zero extend.
2019-09-05 13:55:53 +02:00
Next Turn cb1a228a54 Remove unnecessary !s for [DoesNotReturn] (dotnet/coreclr#26512)
Signed-off-by: dotnet-bot <[email protected]>
2019-09-05 10:46:55 +02:00
Stephen Toub 0770a3d82b Fix StyleCop tuple warnings (dotnet/coreclr#26514)
A few PRs crossed such that PR validation passed but master is issuing lots of warnings-as-errors.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-05 10:46:55 +02:00
Stephen Toub 1dc58da785 Remove readonly from GCHandle field on Gen2GcCallback (#26509)
GCHandle is mutable, and this type does call Free on the handle, but with it marked as readonly, the mutations performed by Free will be done on a copy rather than on the original.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-05 10:46:55 +02:00
Stephen ToubandAdam Sitnik ff7dd88cfa Use expression-bodied members in more places (dotnet/coreclr#26500)
* Fix IDE0027 (use expression body for accessors)

* Fix IDE0023 / IDE0024 (use expression body for operators)

* Apply suggestions from code review

Co-Authored-By: Adam Sitnik <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>
2019-09-05 10:46:55 +02:00
Zoltan Varga db626fe9d3 [llvm] Use branch weight metadata in some cases. (#16668)
* [llvm] Add functions to create weighted branches.

* [llvm] Use weighted branches in GC_SAFE_POINT, some llvm passes doesn't seem to recognize llvm.expect so the LLVM JIT generates the slow inline.
2019-09-04 18:17:07 -04:00
Sam Patel c0a36b62af Update CodeOwners (#16662)
* Update CodeOwners

Add Imraan as code owner for LLVM related files

* Update CODEOWNERS
2019-09-04 19:32:11 +02:00
Jay KrellandLarry Ewing 1f21aae8cb Take stars out of types where they make more sense.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing 9fc2ade131 Take stars out of types where they make more sense.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing 4359ad66d0 Take stars out of types where they make more sense.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing e25d2e5536 Take stars out of types where they make more sense.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing 557645fea3 Take stars out of types where they make more sense.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing b3f996d45d Take stars out of types where they make more sense.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing 8232c85e4c Take stars out of types where they make more sense.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing bd9ae10c7c Take stars out of types where they make more sense.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing b071aa9192 more star placement
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing 46ea28c95b Move stars to sometimes but not always onventional and wierd location. C syntax experiment takes it toll for decades on.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing 90e2563523 Move stars to conventional but wierd place.
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing b8313d586a Update mono/eglib/gmodule-win32.c
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay KrellandLarry Ewing d0817ccdc6 Update mono/eglib/glib.h
Co-Authored-By: Larry Ewing <[email protected]>
2019-09-04 12:31:13 -05:00
Jay Krell a7357e8177 Remove unnecessary cast. 2019-09-04 12:31:13 -05:00
Jay Krell 595b66c0eb Allocate MAX_PATH to start, but it usually wastes memory.
Double later for clarity.
2019-09-04 12:31:13 -05:00
Jay Krell 8723e49b0e Fix C++? 2019-09-04 12:31:13 -05:00
Jay Krell fb6e2c75cd cleanup 2019-09-04 12:31:13 -05:00
Jay Krell da2471d001 Test invalid module. 2019-09-04 12:31:13 -05:00
Jay Krell 74f1312cd3 Skip psapi.dll and go right to the Windows 7 or newer versions in kernel32.dll. 2019-09-04 12:31:13 -05:00
Jay Krell 2db0c8c2d4 Remove cast. 2019-09-04 12:31:13 -05:00
Jay Krell 06f4f93aa5 comments 2019-09-04 12:31:13 -05:00
Jay Krell 3ca5b2687f Remove accident. 2019-09-04 12:31:13 -05:00
Jay Krell f8be8c6de7 MAX_PATH reduction. 2019-09-04 12:31:13 -05:00
Jay Krell a55da2a903 Tweak names and fix preexisting leak under low memory. 2019-09-04 10:31:22 -05:00
Jay Krell 14afe79a0a [Coop] GetStackTraces. 2019-09-04 10:31:22 -05:00
Egor Bogatov 30625b25df Implement more Math LLVM intrinsics (#16578)
* Implement more Math intrinsics

* Test on CI

* Update pipeline-netcore-runtime.yml

* undo "test on CI"
2019-09-04 09:54:52 -04:00
Jay Krell 350dd0e2de [Coop] ves_icall_System_IOSelector_Add 2019-09-04 08:36:42 -05:00
Stephen Toub 036ab58b42 Fix several recently added StyleCop tuple rules (dotnet/corefx#40794)
Signed-off-by: dotnet-bot <[email protected]>
2019-09-04 11:15:23 +02:00
Egor Bogatov 1558316cec Throw NRE if src or dst in Memmove are nulls (#16650) 2019-09-04 11:01:53 +02:00
Zoltan Varga 55ac86fe8b [netcore] Fix the exception thrown by the Vector<T>.CopyTo() intrinsic. (#16618)
Fixes https://github.com/mono/mono/issues/16616.
2019-09-04 10:57:39 +02:00
Dotnet-GitSync-Bot dcb90fa1c0 Mirror changes from mono/coreclr,corefx (#16654)
* Refactor BinaryReader.ReadChars using Span (dotnet/coreclr#26325)

Avoids unsafe code and makes the code simpler

Signed-off-by: dotnet-bot <[email protected]>

* Remove unnecessary parens from `return (true);` and `return (false);` (#26488)

Just a search and replace.

Signed-off-by: dotnet-bot <[email protected]>

* Avoid some unnecessary initialization in DateTimeParse (#26487)

Signed-off-by: dotnet-bot <[email protected]>

* Update analyzer versions (dotnet/corefx#40778)

In particular to pick up StyleCop fixes related to C# 8 and nullability.

Signed-off-by: dotnet-bot <[email protected]>
2019-09-04 00:20:35 -04:00
Jay Krell 82d4d8d81d Fix overly sensitive g_ascii_strncasecmp tests. 2019-09-03 22:46:10 -05:00
Jay Krell b66ec468da Add g_asciiz_equal_caseinsensitive, g_ascii_equal_caseinsensitive, g_asciiz_equal.
The default takes a length.
"z" means zero terminated, the usually slower not preferred.
2019-09-03 22:46:10 -05:00
Jay Krell 8c288f0666 Cleanup and augment string handling based on https://github.com/mono/mono/pull/15522.
1. When comparing strings, check pointer equality.
Faster when they match, slower when they do not.

2. Provide string lowercasing into a provided buffer, which can equal
the input, to avoid extra malloc/free.

3. define G_STRING_CONSTANT_AND_LENGTH(x) (x), G_N_ELEMENTS (x) - 1
e.g. strncmp (foo, G_STRING_CONSTANT_AND_LENGTH ("version"))
2019-09-03 22:46:10 -05:00
Zoltan Varga e1b568b529 [netcore] Enable Vector<T>.get_Item () intrinsics for floats/doubles. 2019-09-03 22:05:15 -05:00
Zoltan Varga 4107a15389 [netcore] Disable socket support to fix warnings. 2019-09-03 21:24:23 -05:00
Alexis Christoforides e50a7360e1 Debugging 2019-09-03 20:30:30 -05:00
Alexis Christoforides 4840f4161f [merp] Fix logic of 'is_managed' attribute 2019-09-03 20:30:30 -05:00
Alexis Christoforides 4a52bd6da0 Fix pointing to stack on string && some add tracing 2019-09-03 20:30:30 -05:00
Alexis Christoforides 8c0dc66d25 Guard writing to out_module 2019-09-03 20:30:30 -05:00
Alexis Christoforides 1b66666cc7 Update MONO_CORLIB_VERSION 2019-09-03 20:30:30 -05:00
Alexis Christoforides 001398e05b Remove problematic assert from SIGILL handler
mono_handle_native_crash() function can actually return if the native crash has triggered or has been trigerred by  more than one signal. So it is possible to reach the point of the assert
2019-09-03 20:30:30 -05:00
Alexis Christoforides 8d4c0f3553 Add stub of new function when crash reporting is disabled 2019-09-03 20:30:30 -05:00
Alexis Christoforides 4b02c3eb9d Set out_module, to avoid getting no useful information in the printout
It seems that without this, most/all entries in the unmanaged frames list are have no useful information.
2019-09-03 20:30:30 -05:00
Alexis Christoforides 40a8d88d8e [merp] Add API method that whitelists all native libraries
This is so that complex consumers such as Visual Studio for Mac can forego attempting to enumerate all loaded libraries, register them one at a time and potentially keep the list updated
2019-09-03 20:30:30 -05:00
Next Turn 0fc4d68d8e Use Span<T> in Encoding (dotnet/coreclr#25860)
Signed-off-by: dotnet-bot <[email protected]>
2019-09-03 19:42:55 -05:00
Zoltan Varga 83953ef83d [wasm] Disable threads tests as well. 2019-09-03 18:06:36 -05:00
Zoltan Varga aad5494258 [wasm] Avoid aligning the stack bounds, they are not page aligned on wasm. 2019-09-03 18:06:36 -05:00
Zoltan Varga ea512c1604 [wasm] Bump emscripten to 1.38.43. 2019-09-03 18:06:36 -05:00
Zoltan Varga 5f79b69e34 [wasm] Disable threads support, it doesn't work with 1.38.42. 2019-09-03 18:06:36 -05:00
Larry Ewing 68b7af0539 [wasm] update emscripten 2019-09-03 18:06:36 -05:00
Jay Krell 1780e1d1f8 [coop] CustomAttributeBuilder_GetBlob, etc. (#16579)
mono_reflection_get_custom_attrs_blob_checked
 ModuleBuilder_WriteToFile
 ModuleBuilder_build_metadata
2019-09-03 18:52:41 -04:00
Jay Krell 651eb7696e [Coop] ves_icall_InternalInvoke. (#16625)
* [Coop] ves_icall_InternalInvoke.

(Part taken from ves_icall_InternalExecute https://github.com/mono/mono/pull/16622.)

* error_init_reuse.

* Remove stars from types.
2019-09-03 17:18:21 -05:00
Thays Grazia 1046dd746f [debugger][android] Fixing single step inside Exception on Android (#16596)
* Fixing single step inside Exception on Android...
The method is null because on ss_create_init_args the IL is -1 when calling method Mono_UnhandledException_internal what I think it's expected, because of that I ignore the single step on android if there is no method. (debugger-engine.c)
After that the sequence point cannot be found because it's calling a method of class DynamicMethodNameCounter what I think it's expected, because of that I remove the assert on android. (debugger-agent.c)
Fixes #14772

* Changing comment to make it clear...
2019-09-03 16:28:37 -04:00
Egor Bogatov 625af20cef [netcore] Use CoreRT's Overlapped (#16106)
Made it Nullability friendly

Interop.MemFree  -> Marshal.FreeHGlobal
Interop.MemAlloc -> Marshal.AllocHGlobal

Fixes https://github.com/mono/mono/issues/15308
Fixes https://github.com/mono/mono/issues/15310

Also, copy ThreadPoolBoundHandle.PlatformNotSupported.cs
2019-09-03 16:22:04 -04:00
Jay Krell 37e49876b9 Fix non-netcore warning about add_assembly_to_alc. (#16622) 2019-09-03 16:09:24 -04:00
Filip Navara 4ae804bb33 [netcore] Add intrinsic implementation for Unsafe.InitBlockUnaligned 2019-09-03 18:40:06 +02:00
Vlad Brezae 930a5d7d44 [interp] Transform ldloc/stloc pairs to a movloc instruction (#16546)
* [interp] Add stack information for each instruction

For each instruction PopN indicates how many values from the top of the stack are used by the instruction. PushN signals how many values are pushed back. These are also used to prevent values from the stack being optimized out, since they might still be used by an instruction. VarPop and VarPush mean that the number is not constant, so we need to inspect the data fields of the instruction (typically for an imethod or csignature) to figure out the stack usage.

* [interp] Convert ldloc/stloc pairs to movloc

The movloc instruction operates directly on locals. This is faster due to avoiding dispatch and stack indirection. More important is that it makes it easy to do copy propagation of locals and it has no stack usage, which means that it could even be killed if the destination local is no longer referenced (as well as STLOC_NP). In the future we could reuse this mechanism of tracking the value of a stack slot to do constant propagation and kill even more instructions (we might need to have _IMM versions of opcodes for this to work).

* [interp] Enable disabling of interp optimization

* [interp] Add time tracking stat for cprop optimizations

* [interp] Move stloc.np transformations to the cprop pass

It makes more sense to do such transformations here and we also don't want transformations in the generate phase prevent us from detecting alternative transformations when running the full pass.

* [interp] Add counter for instructions that were optimized away

* [interp] Make it explicit that we are dealing with IR code

It can be confusing in verbose output.
2019-09-03 19:36:21 +03:00
Nikolay Sivov f8718c7a05 [cominterop] Maintain object domain around ccw wrapper calls. 2019-09-03 18:03:42 +02:00
Ryan Lucia 5377f9655d Remove MAX_PATH usage in w32process (#16553)
* Remove MAX_PATH usage in w32process

* Fixes

* Shrink buffer temporarily

* More fixes

* Reset buffer size to 260

* Fix length check and add notes

* Actually free things

* Add tracing and zero len at start

* Typo

* Fix another leak

* Simplify logic
2019-09-03 11:41:27 -04:00
Zoltan Varga 98a4d5ec1e [llvm] Implement more SIMD intrinsics on netcore. (#16449)
* [netcore] Add intrinsics for Vector128/Vector256.Count.

* [netcore] Implement Vector<T>.get_Item () as an intrinsic.
2019-09-03 08:31:16 -04:00
Egor Bogatov 416a31796e Improve Fast-Math mode for LLVM (#16599)
It turns out it's not enough to set global fast math parameters, it's also required to mark some instructions as "fast" (see https://llvm.org/docs/LangRef.html#fast-math-flags) like, for instance, clang does, see https://godbolt.org/z/U8TFST
E.g. all optimizations inside SimplifyLibCalls pass (it's a subpass of InstCombine) need it.
2019-09-03 08:19:03 -04:00
Egor Bogatov 5692180ea2 [netcore] Makefile clean up (#16630)
Remove ASP.NET sample (we currently have to download apsnet runtime everytime)
instead we can do:

dotnet new webapp

and do make patch-app APP_PATH=/path/to/myasp (works for any kind of apps/templates)
2019-09-03 07:55:22 -04:00
Bernhard Urban f23113afcd Relax assembly checking for 64 bit targets to allow running mixed-mode MSVC code. (#16330)
* [jit] Relax assembly checking for 64 bit targets to allow running mixed-mode MSVC code.

Fixes #37913

* STACK_PTR|I8 should be the same as I8|STACK_PTR tuple

* fix i4 to ptr conv on 64bit
2019-09-03 12:14:02 +02:00
Vlad Brezae f491af13f4 [interp] Remove varargs from InterpFrame and recompute it instead (#16598)
It is a waste of stack space.
2019-09-03 11:21:56 +03:00
Filip Navara b9b13f0fc1 Use CMP_GE/CMP_LE/CMP_GE_UN/CMP_LE_UN instead of manual decomposition 2019-09-03 09:43:17 +02:00
Filip Navara 03899588ba [netcore] Add intrinsics for Vector.GreaterThanOrEqual/LessThanOrEqual 2019-09-03 09:43:17 +02:00
Dotnet-GitSync-Bot a6b91f4295 Mirror changes from mono/coreclr (#16547)
* Move FormatTypeName to Type (dotnet/coreclr#25631)

Signed-off-by: dotnet-bot <[email protected]>

* Fix for mono
2019-09-02 16:02:59 -04:00
Egor Bogatov 73c8017b1f Merge pull request #16624 from filipnavara/hebrew
[corlib] Add hack for Hebrew calendar data
2019-09-02 20:43:08 +03:00
monojenkins eaa525ab41 [csproj] Update project files 2019-09-02 10:33:47 +00:00
Filip Navara 6ca4e84758 Fix month names for the Hebrew calendar 2019-09-02 11:19:24 +02:00
Filip Navara ca389a3cae [corlib] Add hack for Hebrew calendar data 2019-09-02 02:45:45 +02:00
Alexander Köplinger 07b7c7d824 [Coop] Monitor. (#16608)
* [Coop] Monitor.

* PR: Rename function; cleanup slightly.

* PR: And then rename the icall back.

* Rename parameter back.
2019-09-01 15:14:17 +02:00
Jay Krell b3e48bcf95 [Coop] Fully inline NULL_HANDLE (do not even access a global variable). (#16612) 2019-09-01 15:13:20 +02:00
Ryan Lucia c9a6dd351a [netcore] Add handle frame to loop body in GetTopLevelForwardedTypes (#16594)
* [netcore] Add handle frame to loop body in GetTopLevelForwardedTypes

* No early returns

* Move scope of cols

* Fix C++ builds, probably
2019-08-31 21:40:52 -04:00
Egor Bogatov 6327274b54 LLVM: Make Buffer.Memmove intrinsic (#16610)
* Add memmove intrinsic

* Fix typo

* Add -lower-expect
2019-08-31 19:42:44 -04:00
Jay Krell 24180e9106 Rename parameter back. 2019-08-31 10:35:14 -07:00
Jay Krell 5d9ca20646 PR: And then rename the icall back. 2019-08-31 10:34:32 -07:00
Jay Krell ea0db154b4 PR: Rename function; cleanup slightly. 2019-08-31 10:13:47 -07:00
Zoltan Varga fb26a68fd1 [aot] Avoid crashing with --aot=llvm is used in a runtime without llvm support. (#16577) 2019-08-31 09:03:45 -04:00
Jay Krell 91445e2286 [Coop] Monitor. 2019-08-31 05:22:45 -07:00
Jay Krell 9b193b9ec4 [coop] Allow SETUP_ICALL_FRAME (i.e. a loop) to reference calling frame w/o HANDLE_FUNCTION_ENTER or SETUP_ICALL_FUNCTION. (#16498)
This is based on my read of https://github.com/mono/mono/pull/16487.
2019-08-31 14:20:44 +02:00
Nikolay Sivov 2f5c8cba6e [corlib] Simplify file: protocol check in Assembly::Load(). (#16494)
Mirrors change made with 068660732f.
2019-08-31 08:19:41 -04:00
Vlad Brezae bf53a3a53b [interp] Fixes for il_offsets associated with instructions (#16587)
* [interp] Remove some some false is_bb_start markings

Having fewer basic blocks makes potential optimizations more effective.

* [interp] Persist variables in TransformData

Thate are not used by inlined code because we don't inline code that has multiple basic blocks or clauses.

* [interp] Enable emitting of MINT_NOP instruction

This instruction will be optimized away when compacting the instruction stream.

* [interp] Clear instructions insead of removing them

Makes everything easier.

* [interp] Fix some instructions size inconsistencies

* [interp] Add more is_bb_start markings

* [interp] Add nop instead of extending bb

We should always have an IR instruction associated with an IL offset, especially when that instruction is a bb_start since we will need to branch to it and resolve the IR instruction from the il_offset.

* [interp] Simplify resolving in offset

We should always have an in_offset associated with the il_offset we are branching to.

* [interp] Add correct il_offset for all instructions

Except for special prolog instructions that will have -1 as the offset. We don't make much use of il_offset for non bb_start instructions, but they might be useful for debugging.

* [interp] Fix il_offset of some conv opcodes
2019-08-31 13:37:06 +03:00
Jay Krell a768b15330 Follow convention -- "static inline" is only for .h files, "static" is for .c. (#15502)
inlining is up to the compiler to decide.
It is used in .h files for linkage/dedup, not to affect codegen.
2019-08-31 09:40:33 +02:00
Jay Krell cba94f28be [coop] InternalGetHashCode (#16583) 2019-08-31 09:38:12 +02:00
Aleksey Kliger (λgeek) 8bc27f6665 [runtime] Make eglib tests run on CI (#16187)
[runtime] Make eglib tests run on CI

Update mono/eglib SUBDIRS to build tests after eglib is built.

Add a check-local automake rule.

Add CI steps to run the eglib tests.
2019-08-31 02:06:25 -04:00
Jay Krell f735571f27 Cleanup x86_patch and amd64_patch. (#16474)
* Cleanup x86_patch and amd64_patch.

amd64_patch has two incorrect looking probably unused cases.
 g_assert(0) and fix them.
 call and jmp indirect (one case)
 move reg RIP relative

x86_patch is large-ish inline macro.
Presumably for sharing with amd64, not inlining.
Restructure as an inline function, called once.
Try to make the code a little clearer also, with same functionality and efficiency
 (modulo the optimized perf of "if i == 4" vs. "if i")
i.e. speak of instruction_size and offset_size, not pos and boolean size.

Add to x86_patch the ability to patch jmp/call indirect,
as amd64_patch has, but which was incorrect.
This would seem useful for a later change (using "thunks"
to patch nearby data instead of patching aligned instructions,
indirect call/jmp vs. direct).

amd64_patch largely delegates to x86_patch.
One case asserts and delegates.
Move the assert to the x86 side, where an optimizing
compiler should know to remove it for x86 anyway.

Change some assert to g_assert.

Remove some unnecessary casts.

Fix an assert (https://github.com/mono/mono/pull/16471).

* Change g_assert back to assert except where making larger changes
and less expansion.
2019-08-31 00:45:55 +03:00
Bernhard Urban 06e63b345f [mini] publish global patches after JitInfo has been added (#16589)
[mini] publish global patches after JitInfo has been added

Fixes https://github.com/mono/mono/issues/14080

Consider the following example:

```csharp
static void CommonCallTarget () { }

static void TailA () {
    tailcall CommonCallTarget ();
}

static void TailB () {
    tailcall CommonCallTarget ();
}
```

Since `TailA` and `TailB` are tailcalling into `CommonCallTarget`, the resolution at patch-time is a bit tricky, that is, since it's a jump-like instruction the patching machinery won't know where it was called from. That's why we maintain a global hashtable `jump_target_hash` where each jump-site is signed up to be patched. At patch-time we know the target method (in the example `CommonCallTarget`), but since we don't know where we are coming from, we will just apply all patches for that target.

This works since ages, so why did it crash on arm64 sometimes?
When the patching happens, we check if the displacement between jump-site and target fits into it (24bit). If not, which happens not very often, we have to allocate a _thunk_:
https://github.com/mono/mono/blob/36296ce291f8a7b19de3eccb7a32c7e4ed9df8f2/mono/mini/mini-arm64.c#L928-L942

So instead of jumping to the target directly, we'll branch to the thunk. This is a little trampoline that loads the full address of the target and then finally branches to it. This one will live close-by the jump-site, because during compilation we will reserve specifically for that scenario some space after the generated code. For this, however, we need the JitInfo of the jump-site. And that's where the origin of the race is. Let's say:

* Thread A compiles `TailA`, and then jumps into it. Thus one patch point is in the `jump_target_hash`.
* Now Thread B compiles `TailB`, registers the patch point but has _not_ yet registered its JitInfo.
* Then Thread A continues, does the tailcall into `CommonCallTarget`, enters the patching machinery, which sees two patches. Now assume when applying the patch for `TailB` the displacement is too large, thus it tries to allocate a thunk but can't find the relevant JitInfo for it that it needs to emit the thunk. So it crashes as reported in https://github.com/mono/mono/issues/14080

As far as I can tell this only affects ARM64, ARM and PPC.



<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-08-30 16:46:10 -04:00
Steve Pfister dbce6ac447 Turned the compiler server off on Windows because Named Pipes aren't fully working (#16552)
* Turned the compiler server off on Windows because Named Pipes aren't fully working

* Added win32 to the CS is turned off message
2019-08-30 16:27:14 -04:00
Bernhard Urban 5eb67ac88a Revert "[android] add hardware specific workaround for Nexus9 in armv7 mode" (#14691)
Revert "[android] add hardware specific workaround for Nexus9 in armv7 mode"

This reverts commit ee90fc601e (also see https://github.com/mono/mono/pull/4878 ).

The device was released November 2014.  I think it's fair to assume it isn't widely used anymore.
2019-08-30 16:26:12 -04:00
Zoltan Varga 4997d83291 [netcore] Fix make patch-local-dotnet if .dotnet has more than one netcore install. (#16590) 2019-08-30 14:08:41 -04:00
Jay Krell 86c45ff645 [coop] mono_runtime_class_init_full (#16580) 2019-08-30 13:30:58 -04:00
Steffen Kieß 80b7813d54 [Mono.Posix] Add FcntlCommand.F_OFD_{GETLK,SETLK,SETLKW} (#16571)
Add F_OFD_GETLK, F_OFD_SETLK and F_OFD_SETLKW to FcntlCommand. These
commmands are similar to F_GETLK, F_SETLK and F_SETLKW but operate on a
per-open-file-description lock instead of a per-process lock and avoid the
problem that the locks are released when close(dup(fd)) is called. See
https://lwn.net/Articles/586904/ for more information.

This commit also reruns create-native-map but keeps manual changes from
ed892ccf27,
b522eab5ff and
22b6b95814.

In [create-native-map.diff.txt](https://github.com/mono/mono/files/3557077/create-native-map.diff.txt) you can see the difference between the commited `map.[ch]` and the one `create-native-map.exe` wants to create:
- Manually inserted changes for NetBSD (`MAYMOVE` is turned into a negated `FIXED`)
- `Mono_Posix_ToSockaddrIn6()` and friends get skipped for `HOST_WIN32` (not sure why, when `sockaddr_in6` exists then `Mono_Posix_ToSockaddrIn6()` should work)
- At the bottom of `map.h` some functions are reordered and the parameters change (`const char*` vs. `char*`)

Running create-native-map.exe also moved some O_NOATIME-related stuff (from 8b9033e4d2) to the correct position and added it to Mono_Posix_ToOpenFlags(), which I kept in the commit.
2019-08-30 19:13:33 +02:00
Nikolay Sivov c8707c6e84 [cominterop] Respect ComDefaultInterfaceAttribute when constructing ccw. (#16584) 2019-08-30 18:29:54 +02:00
Nikita Voronchev 94797b95d6 [WinForms] Fix UIA event on node insertions into a TreeView object (#16559)
The UIA event doesn't emited by means of insertion a new `TreeNode` to a `TreeNodeCollection` of the respective `TreeNode`.
2019-08-30 18:29:18 +02:00
Jay Krell 9db00e7495 [Coop] ves_icall_RuntimeFieldInfo_GetRawConstantValue. (#16582) 2019-08-30 10:53:40 -04:00
Bernhard Urban 07045604cf [configure] remove autodection of llvm-config in $PATH (#16569)
[configure] remove autodection of llvm-config in $PATH

Instead `./autogen.sh --with-llvm=<path>` should be used if a build from `external/llvm` is not preferred.

The old behavior was confusing when a `llvm-config` is on `$PATH`, which can be the case when you have LLVM packages installed on a Linux distribution. It picked that up when `./autogen.sh --enable-llvm` was used.

/cc @brianrob
2019-08-30 09:16:03 -04:00
Jay Krell 36296ce291 [interp] Compress interpreter opcode names in usual way, offsets vs. pointers. (#16350)
* [interp] Compress the interpreter opcode names in the usual way, by changing
from an array of pointers to an array of 16 bit offsets into one large "string".

* PR: Make mono_interp_opname a function.
2019-08-30 11:27:19 +03:00
Jay Krell 3db78e829c [coop] Convert System_Runtime_Remoting_Messaging_AsyncResult, etc. (#16566)
* [coop] Convert System_Runtime_Remoting_Messaging_AsyncResult_Invoke, etc.

* Remove mono_load_remote_field_checked from this PR.

* Pin ac->msg earlier (should not matter).

* Add missing barrier.

* Pin slightly earlier -- still should not matter.
2019-08-29 22:51:15 -05:00
Jay Krell cbb9c645eb [Coop] mono_runtime_class_init_full mostly single point of exit. 2019-08-29 22:00:46 -05:00
Zoltan Varga 796a575131 Bump ikvm to pick up caa8e7f54279a47422626005d228447f5d3670d5. (#16567)
* Bump ikvm to pick up caa8e7f54279a47422626005d228447f5d3670d5.

* [monodis] Add a missing cattr parent case.
2019-08-29 20:46:30 -04:00
Egor Bogatov c3ccb6e027 Make Math.Pow, Min and Max for doubles intrinsics (#16561)
* Add new Math intrinsics

* call EB.setTargetOptions only for fast-math

* Address feedback

* rename float opcodes

* Rename opcodes

* Update CoreFX.issues.rsp
2019-08-29 19:01:15 -04:00
Zoltan Varga 210b324347 [simd] Implement .ctor(T[]) and CopyTo () as intrinsics. (#16558) 2019-08-29 19:00:59 -04:00
Jay Krell 5390b796dd Cleanup trampoline size checks. (#15624)
Cleanup trampoline size checks.

- named `int` everywhere
- `assert` everywhere
- assert `<=` everywhere instead of `<`
- `const` almost everywhere
Names not consistent, following existing code (`size`, `buf_len`, `kMaxCode`.)

Only touching x86/amd64, granted.

Could be better -- make them two pass and avoid the presizing.
2019-08-29 16:16:14 -04:00
Alexander Köplinger 309cf1bcee Build pkg-config as 64bit only, libtiff as universal and remove gtk-quartz-engine.py (#16548)
See https://github.com/mono/bockbuild/pull/116
2019-08-29 20:24:14 +02:00
Ryan Lucia 3b57849541 [netcore] Implement AssemblyLoadContext.LoadUnmanagedDllFromPath (#16525)
* [netcore] Implement AssemblyLoadContext.LoadUnmanagedDllFromPath

* Fixes
2019-08-29 12:35:15 -04:00
Nikolay Sivov 421bd79f06 [cominterop] Implement native-to-managed safearray marshalling. (#16483)
* [cominterop] Implement native-to-managed safearray marshalling.

* [tests] Fix index variable type.

In attempt ot fix MSVC build failure (int* vs LONG* on Windows).

* [cominterop] Use proper statement block for newly added switch entry.

* [marshal] Conditionally compile in mono_cominterop_emit_marshal_safearray().

Hopefully should fix remaining build failures.

* [cominterop] Don't free user array argument
2019-08-29 08:19:08 -04:00
Jay Krell 52c1d4acfc [Coop] mono_load_remote_field_checked single point of exit. (#16526)
Extracted from earlier version of #16504.
Baby steps.
2019-08-29 11:00:44 +02:00
Egor Bogatov 2e9c5df855 LLVM: Add more Math intrinsics, introduce --cpu flag (#16309)
* Add Math Intrinsics, introduce --cpu flag

* cpu -> mcpu
2019-08-29 04:32:43 -04:00
Jay Krell 2f2d9541e5 [coop] Cleanup mono_reflection_get_custom_attrs_blob_checked. (#16535)
- single point of exit
 - local variable cheaper than strcmp
2019-08-29 04:23:20 -04:00
Jay Krell 07c6b1c9f1 Should fix many warnings: sgen-protocol-def.h adding unsigned long to a string does not append to the string (#16288) 2019-08-29 10:08:42 +03:00
Filip Navara e32fb11dbe [netcore] Add Monitor.LockContentionCount icall (#16538)
* Add Monitor.LockContentionCount icall

* Add NOHANDLES around the new icall
2019-08-28 20:35:07 -04:00
Marius Ungureanu 1d23ca14e1 Use the right FileSystemWatcher sources (#16539)
* Use the right FileSystemWatcher sources

The corefx code for FileSystemEventArgs has some changes to support
constructing one with a null filename.

Fixes #16486

* Remove the mono sources for the newly replaced files

* [csproj] Update project files
2019-08-28 19:45:25 -04:00
Jay Krell 7ca965e09c Read only function pointers (MonoThreadInfoRuntimeCallbacks). (#16545)
Read only memory is preferred, for efficiency and security.

Even if it requires relocation first.

If the runtime is loaded in more than one process, physical pages can be shared (at least on Windows, where the kernel does the relocation).

If there is memory corruption, writes to here will sigsegv/accessviolate.

The older code also copied the pointers. For lifetime purposes that could be useful, but generally is not. i.e. they live with the code they point to.

Writable function pointers are also particularly targets for attackers.
There's been tons of defenses put around them through the years.
Read only ones are not vulnerable -- unless the attacker escalates and calls mprotect first.

When there is a JIT, arguably there is just tons of attack surface.
But there is also AOT.

Structs of function pointers are usually read only in the wider world.
2019-08-29 00:10:40 +02:00
Steve Pfister 7c4c30ec00 Implement Read and WriteAsyncMemory in Mono DeflateStream
Resolves https://github.com/mono/mono/issues/16122

Since we put in the corefx version of GZipStream, it is expected that
our version of DeflateStream actually implements Write+ReadAsyncMemory.

This change does that by just calling the plain WriteAsync & ReadAsync
methods until we decide (or not) to pull in the corefx DeflateStream.
2019-08-28 16:20:09 -04:00
Zoltan Varga c4695b8b44 Merge pull request #16323 from EgorBo/ffast-math
Fast Math mode
2019-08-28 16:16:18 -04:00
Jay Krell 056d5ca545 [interp] Fix remaining MonoError reuse. (#16533)
* [interp] Fix remaining MonoError reuse.

This finishes off:
 https://github.com/mono/mono/commit/38aebeae38704df53ef8f2991ff63e293a3ac4de

which is *ok*, but leaves alone the other approach:
 https://github.com/mono/mono/commit/4d9e6ae20e536394c9ff65c61238045db294c08e
 https://github.com/mono/mono/commit/b654aa1ca858666539a677e96d00f594fd81c630
 https://github.com/mono/mono/commit/fd4956fbf277ec56a13137e01b48efb98a5556f5

Several other options are possible.

* self and peer PR: No need to cleanup successful error.
2019-08-28 21:33:48 +02:00
Jay Krell ff73c84482 Portably pass a full pointer and not just an integer to terminate vararg pointer lists. (#15629)
i.e. because of define NULL 0.
Though I think at least Visual C++ special cases this and passes a full pointer to varargs.
2019-08-28 13:35:10 -04:00
Jay Krell a0ba2cbce5 [interp] Possible code size savings via goto instead of macros. (#16531)
[interp] Possible code size savings via goto instead of macros.

Possibly the compilers do this already.
2019-08-28 12:59:11 -04:00
Egor Bogatov ffc3081c3b Merge remote-tracking branch 'origin/master' into ffast-math 2019-08-28 19:01:34 +03:00
imhameed bd3cc61301 Merge pull request #16242 from lateralusX/lateralusX/windows-fix-local-valuetype-copy-llvm
OP_LLVM_OUTARG_VT doesn't always create temporary vt needed by some ABI's.
2019-08-28 08:23:43 -07:00
Bernhard Urban 71f0f0ff82 [mini] do not re-AOT whole BCL for fullaotcheck targets (#16536)
[mini] do not re-AOT whole BCL for fullaotcheck targets

And enable `llvmfullaotcheck` target on CI.

Fixes https://github.com/mono/mono/issues/15999

On my armv7/linux machine with a `--with-runtime-preset=fullaot_llvm` configured build, before this PR:
```console
$ time make -C mono/mini llvmfullaotcheck -j4
[...]
real    9m42.362s
user    23m2.000s
sys     0m18.480s
```
After:
```console
$ time make -C mono/mini llvmfullaotcheck -j4
[...]
real    3m1.984s
user    4m51.648s
sys     0m8.248s
```
2019-08-28 11:19:39 -04:00
Alexander Köplinger 2152f0a16d [netcore] Add missing 'prepare' dependency to run-tests-corefx 2019-08-28 16:17:31 +02:00
Phil Jaenke 1bee4e354c [corlib] Remove/Update deprecated TZs for #16415 in TimeZoneInfoTests (#16450)
This fixes #16415 

All timezones indicated as deprecated have been updated to the current IANA specification.
2019-08-28 16:08:20 +02:00
Zoltan Varga f562c7ef6a Merge pull request #16517 from vargaz/wasm-xunit4
[wasm] Enable xunit tests for corlib/System.Core.
2019-08-28 09:46:09 -04:00
Jay Krell c80a1eca63 Fix assert in x86_patch regarding second byte of Jcc instructions being 0x80-0x8F vs. 0x70-0x8F (6byte conditional branch with 32bit offset). (#16471) 2019-08-28 15:42:44 +02:00
Aleksey Kliger (λgeek) fc21168065 [merp] Initialize hang_watchdog_path earlier; be lax if it's missing (#16298)
* [merp] Initialize hang_watchdog_path earlier; be lax if it's missing

Initialize hang_watchdog_path earlier - not just when
ves_icall_Mono_Runtime_EnableCrashReportingLog is called.  That function is
only expected to be called by apps that explicitly want progress reports from
MERP when it's collecting a crash report.  But we want the mono-hang-watchdog
to execute for all mono crashes (when crash reporting isn't ifdef'd out).

Also if we try to exec mono-hang-watchdog and fail for some reason, print a
nice message and then exit.  We used to call g_assert_not_reached which would
kick off another MERP of the _forked child process_ which would then get
confused because it really can't run in the forked process at all.
2019-08-28 08:34:30 -04:00
Jay Krell 2ca04a9743 [interp] Outline box. (#16456)
With additional reasonable changes this should conserve stack.
A combined PR that demonstrates actual savings probably should/will be presented.
2019-08-28 13:51:23 +03:00
Jay Krell 56b83f489b [interp] Minor cleanup of stackval_from_data. Compiler can do it. (#16534)
I missed this earlier cleaning stackval_to_data.
2019-08-28 12:11:56 +02:00
Jay Krell c870df0aa7 [interp] Asserts pessimize clang. Removing saves 16 bytes on Linux/amd64/clang. (#16530)
Paired with https://github.com/mono/mono/pull/16456, saves 16 bytes on Linux/amd64/clang.
No change with gcc.
Contributes to https://github.com/mono/mono/issues/16172.
2019-08-28 12:10:30 +02:00
Eric Erhardt 39ddea3983 Don't validate empty TransitionTimes on deserialization. (#26405)
On Unix, TransitionTimes are not used, so they are left empty. When deserializing an empty TransitionTime, it is throwing an exception because those are not normally valid. Fix deserialization to not validate empty TransitionTimes.

Fix dotnet/corefx 40578

Signed-off-by: dotnet-bot <[email protected]>
2019-08-28 11:55:07 +02:00
Jay Krell c534511003 Remove dead Boehm code. (#15224)
* Remove dead Boehm code.

Unity looked similarly dead.

The key points making it dead were:

create_allocator:
  g_assert_not_reached() covering everything but local variables

mono_gc_get_managed_allocator:
  always returning NULL, killing a bunch of code
  after it

mono_gc_is_critical_method:
   looking at data that was never filled in

This should have no impact, not even on Boehm.
Boehm should continue working just the same.

It is nice because it is the few/only uses of CEE_MONO_TLS.
2019-08-28 10:56:08 +02:00
Jay Krell 0375acd7c8 [mini] Cleanup MONO_MMAP_32BIT. (#16469)
- It _presumably_ means nothing on 32bit ARM and 32bit MIPS (was there mono/mips64?).
 - Leaving only PowerPC32 and PowerPC64 (in this vicinity).
   - It presumably means nothing on PowerPC32.
   - Leaving PowerPC64 as the only user in this vicinity -- is it needed?
- Notice this is varyingly absent on x86, arm64, amd64, s390x.
  Subject of another PR maybe.

Perhaps this was to enable the debugger to be 32bit against a 64bit target
on a biarch system, so it could do a cross-process manipulation of these pages?
That makes some sense on Windows at least.
(32bit debugger cannot debug 64bit target as of Vista, but that is using the Win32
"hard" debugger API. Mono could do otherwise).

There remains amd64 mono-codeman.c define ARCH_MAP_FLAGS MONO_MMAP_32BIT left alone.
2019-08-28 10:54:00 +02:00
Zoltan Varga 162849f972 Merge pull request #16520 from vargaz/fix-llvm-2
[llvm] Fix ctlz intrinsics, they have 2 arguments.
2019-08-28 03:24:01 -04:00
Bernhard Urban d6fa5ff9c6 fix cast and signature for mono_rconv_u4 2019-08-27 20:35:42 -05:00
Bernhard Urban 460bfa9beb [amd64] use opcode emulation for fconv/rconv 2019-08-27 20:35:42 -05:00
Bernhard Urban 8e6b967391 [llvmaotcheck] require sse3 being available for regression tests 2019-08-27 20:35:42 -05:00
Bernhard Urban 5b20322a84 [arm] use opcode emulation for fconv/rconv 2019-08-27 20:35:42 -05:00
Bernhard Urban ba824cb921 [arm] account only 4 bytes on stack for single precision arguments
Fixes `test_0_arm64_small_stack_args` in gshared.cs when
* `test_0_arm64_small_stack_args` is compiled with LLVM
* `Foo3.Floats` is compiled with Mini
2019-08-27 20:35:42 -05:00
Bernhard Urban 475defca4d [arm64] use opcode emulation for fconv/rconv
LLVM eagerly optimizes constants such as NaN in a way that does not align with .NET behaviour. In the future we can change it so that we only do opcode emulation when LLVM is used.

Fixes https://github.com/mono/mono/issues/16411
2019-08-27 20:35:42 -05:00
Bernhard Urban d164550a61 [ci] add make -C mono/mini llvmaotcheck to FullAOT LLVM lanes 2019-08-27 20:35:42 -05:00
Jay Krell 645c01066c Cleanup arm64 SeqPointInfo. 2019-08-27 20:34:42 -05:00
Stephen Toub 55002c3e02 Fix pragma warning restore (dotnet/coreclr#26389)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-28 00:16:03 +02:00
Jay Krell f516e79dd9 Inline mono_string_length_internal and mono_string_chars_internal (#16374)
* Inline mono_string_length_internal and mono_string_chars_internal for everyone.

* Add MONO_REQ_GC_UNSAFE_MODE.
2019-08-27 17:39:18 -04:00
Zoltan Varga cb5470b40a Fix timeouts. 2019-08-27 17:37:59 -04:00
Tarek Mahmoud Sayed 9ad1f08077 Fix Abbreviated Genitive Month Names Parsing (dotnet/coreclr#26379)
* Fix Abbreviated Genitive Month Names Parsing

In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names.

* Addressing the feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-08-27 22:56:08 +02:00
Filip Navara f4145ce108 Update version information in System.Private.CoreLib to mimic CoreCLR and make BenchmarkDotNet happy (#16515)
BenchmarkDotNet recently updated the algorithms for .NET version detection (https://github.com/dotnet/BenchmarkDotNet/pull/1230) which made it incompatible with the version presented by Mono.

This updates the value of [ProductName](https://github.com/dotnet/coreclr/blob/1f428dbc5554191dadd27511cd5cd181e4a60efb/Directory.Build.targets#L7) and [Version](https://github.com/dotnet/coreclr/blob/c9007e73286456434ba12744e778e87a89fc1d90/eng/Versions.props#L5) to match what CoreCLR is currently reporting and makes the [BDN detection code](https://github.com/dotnet/BenchmarkDotNet/blob/b6d0e0f1d80ed60aa157149a0dfb704a2da4ca41/src/BenchmarkDotNet/Environments/Runtimes/CoreRuntime.cs#L73-L81) happy.
2019-08-27 22:55:37 +02:00
Ryan Lucia f9f5fff40c [netcore] Change exception thrown for SetTypedReference (#16518)
This brings us in line with CoreCLR behavior.
2019-08-27 22:53:37 +02:00
Zoltan Varga 340289d4ae [llvm] Fix ctlz intrinsics, they have 2 arguments. 2019-08-27 16:34:27 -04:00
Zoltan Varga ab1e9be35e [llvm] Fix the mixing of LLVM modules in the llvm JIT, use ctx->lmodule instead of module->lmodule. 2019-08-27 16:31:18 -04:00
Zoltan Varga 44d33673a5 Fix the netcore build. (#16519) 2019-08-27 22:30:16 +02:00
Zoltan Varga 0c015aa815 [wasm] Enable xunit tests for corlib/System.Core. 2019-08-27 15:46:26 -04:00
Zoltan Varga 3108d43051 Merge pull request #16487 from vargaz/cattr-data-handles
[runtime] Convert mono_reflection_create_custom_attr_data_args () to use handles.
2019-08-27 15:22:30 -04:00
Zoltan Varga 79475574a6 [wasm] Add more xunit test exclusions. 2019-08-27 13:41:11 -05:00
Egor Bogatov e9dff75d2f use gunichar2 2019-08-27 20:21:39 +02:00
Alexander Köplinger f914d900f6 Remove AppContext.cs that was moved to shared 2019-08-27 20:21:39 +02:00
Egor Bogatov f97d699183 Move AppContext.CoreCLR.cs to shared, remove static ctor (#26045)
* Remove AppContext.CoreCLR.cs (move to shared)

Signed-off-by: dotnet-bot <[email protected]>
2019-08-27 20:21:39 +02:00
Steve Pfister 580defd967 Allow file:// based Uri's to be used in HttpClient when the BaseAddress is set
Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582

Bumps the HttpClient part in mono/corefx at: https://github.com/mono/corefx/commit/ee3acec16b37bec5016da129e1e3840097ca629b

The test that would have caught this failure was disabled previously via:
https://github.com/mono/mono/commit/2f411750acfd2132f9b4970ef8cf11d9a0f62df9
2019-08-27 13:54:52 -04:00
Alexander Köplinger 8d422436f5 [acceptance-tests] Bump roslyn test repo to remove a problematic nuget feed 2019-08-27 19:48:08 +02:00
Vlad Brezae ccc4bf8536 [interp] Remove unnecessary recomputation (#16509)
Seems to have been added by mistake in https://github.com/mono/mono/pull/16317, which was meant just to remove the locals variable from InterpFrame.
2019-08-27 20:27:22 +03:00
Jay Krell 00c1ec421a [interp] Error handling refactor (optimize non-exception path) (helps clang save stack) (#16371)
While working on stack reduction, I believe I found that
the compiler could not tell how THROW_EX and/or NULL_CHECK terminate.

That is, essentially, the success paths preserve volatile registers.
They do not have to be spilled/filled.
This tweak should make it clearer to the compiler, optimized common paths, and not slow down uncommon paths.

This also cleans it up a little and reduces macro expansion, and then possibly should allow for reinlining what is now used only once.

Also add some const so it can be casted away less.

Believed to save 32 bytes of stack with Linux/amd64/clang, nothing for gcc.
And a nice cleanup.
2019-08-27 15:31:10 +02:00
Zoltan Varga fa1288794b Merge pull request #16493 from EgorBo/impl-lzcnt
Implement System.Runtime.Intrinsics.X86.Lzcnt
2019-08-27 06:51:03 -04:00
Johan Lorensson 70aba13173 Fix multiple SGEN_LOG to correctly scale elapsed time in usec. (#16485)
Several SGEN_LOG entries logged usec based on result returend from TV_ELAPSED.
On SGEN's implementation of TV_ELAPSED, the result is not scaled to usec
but returned as 100ns ticks. This was not handled correctly by SGEN_LOG,
but other measures, like profile counters and SGEN binary protocol handles
it correctly.

Fix will adjust the SGEN_LOG calls currently presenting usec to correctly
scale the result. Fix also adds one additional logging measuring total
amount of time spend scanning thread data.
2019-08-27 12:14:12 +02:00
Jay Krell bfe1b6182c [interp] Replace imethod with frame->imethod. (#16459)
This conserves stack on Linux/amd64/gcc.
2019-08-27 11:51:21 +02:00
Jay Krell 6cf8b6e738 CodeManager cleanup: (#16468)
- Chunks do not need flags, only codemanagers do.
 - Sort by size to minimize padding for alignment.
 - Booleans only need one bit.
 - Chunk is not spelled chunck.
 - Suggest foo accessors be named foo() and set_foo(), not get_foo() and set_foo().
   i.e. the more common "get" is implied.
- Allow free(0) w/o initialization.
2019-08-27 10:40:35 +02:00
Jay Krell 9f9e5f7803 [monodis] Combine adjacent identical cases. (#16501) 2019-08-27 10:36:59 +02:00
Zoltan Varga c7d785f329 Add SETUP_ICALL_FUNCTION. 2019-08-27 03:57:59 -04:00
Jay Krell 7ca15e5a42 mono_attach_load_agent: Fix leaks, alloc, copy. (#15950)
Extracted and slightly modified from https://github.com/mono/mono/pull/15868.
2019-08-27 09:46:35 +02:00
Stephen Toub a0307b1e34 Fix comment typo in ManualResetValueTaskSourceCore
Signed-off-by: dotnet-bot <[email protected]>
2019-08-27 01:24:57 +02:00
Vladimir Sadov 88ac3856eb Do not use AllocateUninitializedArray in private array pools. (#26338)
User may have extra expectations for the privatly owned array pools.
For example there could be an expectation that array never contains negative numbers (since user never puts them there). Uninitialized allocations can break such expectations.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-27 01:24:57 +02:00
Stephen Toub 82f618023f Disable SA1001 for LocaleData.Unix.cs
Signed-off-by: dotnet-bot <[email protected]>
2019-08-27 01:24:57 +02:00
Stephen Toub 39d62eb8c8 Separate Async*MethodBuilder types into their own files (#26364)
* Separate async method builder types into their own files

* Minor cleanup of AsyncTaskMethodBuilder types

* Split AsyncValueTaskMethodBuilder types into their own files

Signed-off-by: dotnet-bot <[email protected]>
2019-08-27 01:24:57 +02:00
Nikolay Sivov 515ec75154 [git] Set csharp diff pattern for *.cs sources. (#16495) 2019-08-27 01:24:30 +02:00
Jay Krell 67c97d30b4 Add missing const, particularly on functions "like" memcpy. (#16477)
But do not change the signatures of external functions.
2019-08-27 01:04:46 +02:00
Zoltan Varga 4f8c0b9b46 Merge pull request #16451 from vargaz/gc-handle-pin
[runtime] Make the local gc handles pin the object they point to by scanning the handle area conservatively.
2019-08-26 17:31:50 -04:00
Aleksey Kliger (λgeek) 78edafd6e2 [threadpool-io] Throw if backend won't be able to register a FD (#16396)
The poll+select i/o selector backend can't handle file descriptor ids greater
than FD_SETSIZE.  This can happen if too many files are open and we want to
wait on it.

Previously, mono would fail in the i/o selector thread by which point it was
too late to do anything.

With this change we will fail eagerly on the thread that calls IOSelector.Add
by throwing a NotSupportedException.

Addresses https://github.com/mono/mono/issues/15931
2019-08-26 17:13:45 -04:00
Zoltan Varga 65a71a2912 Fix review comments. 2019-08-26 14:17:09 -04:00
Egor Bogatov 044d1519bd Implement Lzcnt hw intrinsics 2019-08-26 21:08:53 +03:00
Egor Bogatov 85265d884c [netcore] Implement missing ThreadPool methods (for metrics) (#16076)
* Implement missing ThreadPool methods

* Address feedback

* ifdef for mono_threadpool_worker_get_completed_threads_count

* remove GetPendingUnmanagedWorkItemCount
2019-08-26 11:35:38 -04:00
Zoltan Varga a908b72037 [runtime] Convert mono_reflection_create_custom_attr_data_args () to use handles. 2019-08-26 11:17:15 -04:00
Johan Lorensson f9be7a67d3 Fix special case tramp assert in x86/amd64. (#16476)
https://github.com/mono/mono/pull/16408 temporary fixed a tramp issue on
x86 (also exist on amd64). This commit fixes the underlying issue and re-enable
the use of noreturn outside of netcore.

The problem hit by the use of OP_NOT_REACHED on x86/amd64 is due to a specific
case when the address to patch happens to fall at the start of a different
managed method. Since the use of OP_NOT_REACHED can end a method
with the call instruction on x86/amd64 in combination with how patch location
(using the return address from stack) is resolved, the implementation in
mono_arch_patch_callsite didn't take this case into account, reading incorrect
patch data, triggering assert oh x86. So, based on timing we could end up with
the following code:

025715B3 call 02570D98
025715B8 push ebp

since the patch target is 025715B8, but also the start of a completely different
method, method_start == origin_code. The fix is to detect this case on x86/amd64
(done on each arch since the way origin_code is detected is arch specific)
and then use a method_start of NULL, that is already a supported scenario.
2019-08-26 16:46:43 +02:00
monojenkins 80504b8c98 [bcl] Update BCL Linked Size (#16427) 2019-08-26 14:01:25 +02:00
Jan Kotas 501b9cc3dd Fix BinaryReader.ReadChars for fragmented Streams (dotnet/coreclr#26324)
BinaryReader.ReadChars incorrectly read more than necessary from the underlying Stream when multi-byte characters straddled the read chunks.

Fixes https://github.com/dotnet/corefx/issues/40455

Signed-off-by: dotnet-bot <[email protected]>
2019-08-26 13:56:53 +02:00
Next Turn 366f2750cd Remove unnecessary !s for [DoesNotReturn] (dotnet/coreclr#26350)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-26 13:56:53 +02:00
Stephen Toub 37c6d154ef Contribute to IDE0055 (fix formatting)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-26 13:56:53 +02:00
Stephen Toub 2f11eff09b Contribute to StyleCop SA1002 (semicolon spacing)
However, I'm not enabling the rule permanently, as it disagrees with VS IDE0055 about the spacing around semicolons at the end of empty while and for loops.

Because this also impacts `for (;;)` loops, I also searched and replaced those with `while (true)`, to standardize on that across the codebase.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-26 13:56:53 +02:00
Stephen Toub a86fb8c847 Fix StyleCop warning SA1001 (spaces around commas)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-26 13:56:53 +02:00
Alexander Köplinger 2f2771fcfa [utils] Don't use MAP_32BIT on Apple platforms, fixes crash with XCode 11 beta6 (#16441)
As of XCode 11 beta6 the MacOSX SDK defines the MAP_32BIT symbol:

```diff
--- /Applications/Xcode11-beta5.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/sys/mman.h    2019-07-25 17:43:49.000000000 -0400
+++ /Applications/Xcode11-beta6.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/sys/mman.h    2019-08-06 21:03:07.000000000 -0400
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000-2002 Apple Computer, Inc. All rights reserved.
+ * Copyright (c) 2000-2019 Apple Computer, Inc. All rights reserved.
  *
  * @APPLE_OSREFERENCE_LICENSE_HEADER_START@
  *
@@ -145,6 +145,10 @@
 #define MAP_RESILIENT_CODESIGN  0x2000 /* no code-signing failures */
 #define MAP_RESILIENT_MEDIA     0x4000 /* no backing-store failures */

+#if !defined(CONFIG_EMBEDDED)
+#define MAP_32BIT       0x8000          /* Return virtual addresses <4G only: Requires entitlement */
+#endif  /* !defined(CONFIG_EMBEDDED) */
+
 #endif  /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */

 /*
```

This causes the mono_valloc() function to try to use the MAP_32BIT flag for mmap().

However as mentioned in the comment for the symbol in mman.h it seems to require a special entitlement
which isn't available/documented anywhere yet.
This in turn causes the mmap call to fail presumably because we're missing that entitlement.

Instead we now skip setting this flag on Apple platforms to make mmap() behave like it did before.
2019-08-26 13:53:40 +02:00
Egor Bogatov 6aaec2fe9b Optimized LLVM IR (#16448)
LLVM JIT: dump IR after optimizations 

```csharp
[MethodImpl(MethodImplOptions.NoInlining)]
static int Test(int a, int b, int c) => a * b + a * c;
```
`MONO_VERBOSE_METHOD="Test"` now prints both unoptimized and optimized IR:
```llvm
*** Unoptimized LLVM IR for P:Test ***

; Function Attrs: noinline uwtable
define monocc i32 @"P:Test (int,int,int)"(i32 %arg_a, i32 %arg_b, i32 %arg_c) #0 {
BB0:
  br label %BB3

BB3:                                              ; preds = %BB0
  br label %BB2

BB2:                                              ; preds = %BB3
  %t22 = mul i32 %arg_a, %arg_b
  %t25 = mul i32 %arg_a, %arg_c
  %t27 = add i32 %t22, %t25
  br label %BB1

BB1:                                              ; preds = %BB2
  ret i32 %t27
}
***


*** Optimized LLVM IR for P:Test ***

; Function Attrs: noinline uwtable
define monocc i32 @"P:Test (int,int,int)"(i32 %arg_a, i32 %arg_b, i32 %arg_c) #0 {
BB0:
  %t251 = add i32 %arg_b, %arg_c
  %t27 = mul i32 %t251, %arg_a
  ret i32 %t27
}
***
```
2019-08-26 07:36:04 -04:00
Jay Krell 6671316e35 [interp] Cleanup stackval_to_data and stackval_to_data_addr. (#16458)
No functional change, except for debugging, look up a frame
for the prior value.
2019-08-26 10:26:07 +02:00
Bernhard Urban b6ca76c484 [android] remove text relocations in AOT/arm32 (#16432)
[android] remove text relocations in AOT/arm32

Remove support for "big assemblies" for AOT on Android running on ARM 32bit. This will remove relocations in `.text` which are not allowed in the upcoming Android Q release anymore.

_If_ a customer should run into this problem, the suggested workarounds are:
* Switch to ARM64, or
* Do not use AOT compilation.

Fixes https://github.com/mono/mono/issues/16369
2019-08-26 03:46:12 -04:00
Ryan Lucia 510f3c7d70 Detect additional invalid assembly names when parsing (#16446) 2019-08-25 23:13:39 -04:00
Jay Krell e95ef822a1 Add MONO_LLVM_INTERNAL to mono_jit_compile_method. (#16463) 2019-08-25 23:52:17 +02:00
Jay Krell 2224d6b55d [interp] Outline mono_interp_box_vt. (#16454)
Contributes to https://github.com/mono/mono/issues/16172.

Seen to reduce frame from 0xB8 to 0xA8 on Linux/amd64/gcc against master.
Possibly similar elsewhere.
(Possibly 8 added to a rounded 8.)

Add const, add braces, they might help compiler and/or programmer.
2019-08-25 19:11:02 +02:00
Zoltan Varga 7d43ffda1a [runtime] Make the local gc handles pin the object they point to by scanning
the handle area conservatively.
2019-08-24 15:46:33 -04:00
Jay Krell 9d1eec6bf8 [interp] Outline STRMFLD_VT. (#16355)
Without being entirely scientific about it, this case seems
to be one that uses more than typical locals and therefore
be on a sort of critical path to reduce frame size.

I have a change that reduces frame to 0x78 bytes (albeit
not yet working) and to achieve that, in this case I refetched
the locals after function calls.

This achieves similar but perhaps more elegantly.

If we rest at larger frame size then this case might not be
on the critical path.

https://github.com/mono/mono/issues/16172
2019-08-24 09:56:40 +02:00
Jay Krell 99e9d80642 [windows gc] Trim one syscall per thread in garbage collection. (#16003)
* Skip one syscall per thread in garbage collection.
Specifically do not query for guard pages.
There are better ways:
 1. Visual C++ specific, __try / __except, get the guard page exception,
    put back the guard page. This is a little slower (exception + two syscalls),
    but exceedinly rare. __try itself is cheap on x86, free on the rest.
    This was also not allowed on UWP. It will be. And is VirtualProtectFromApp.

 2. Record the TEB and get from it the maximum commited page and just use MAX, trivial.

The comments are also not completely clear as to what is going on here, but they were close.
Augment them.
2019-08-24 09:56:00 +02:00
Jay Krell ab6a09741d Remove dlmalloc from Win32. (#15773) 2019-08-24 09:52:30 +02:00
Alexander Köplinger 3a409e8a7f Pass --clr-memory-model in csc/vbc wrapper script (#16439)
Should help with random CSC crashes on ARM (we've been using it in the Mono build for a while).
2019-08-24 00:08:25 +02:00
Zoltan Varga ab9c58d76d Merge pull request #16414 from vargaz/llvm-gc-poll-wrapper
[llvm] Add a mono wrapper method for the gc poll cold cconv wrapper so the EH code can unwind through it.
2019-08-23 18:06:17 -04:00
Ryan Lucia 83cf007ae3 Return an empty string for assemblies loaded from stream (#16345)
* Return an empty string for assemblies loaded from memory

* Blind attempt to fix wasm
2019-08-23 15:58:10 -04:00
Ryan Lucia 7615ba3e45 [netcore] Use requesting assembly's context for InternalLoad calls 2019-08-23 15:30:04 -04:00
Ryan Lucia 0661bf0424 [netcore] Random loader cleanup 2019-08-23 15:30:04 -04:00
Nathan Ricci f6b2befe8d Removed trailing whitespace. 2019-08-23 13:57:01 -04:00
Nathan Ricci 707db63569 Added stub for boehm. 2019-08-23 13:45:23 -04:00
Nathan Ricci cdb77f1391 Fixed fomatting issues. 2019-08-23 13:42:34 -04:00
Tarek Mahmoud Sayed cb1f7c0677 Cleanup GregorianCalendarHelper leap month checks (dotnet/coreclr#26321)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-23 15:43:54 +02:00
Alexander Köplinger 278fd48274 Bump corefx to get https://github.com/mono/corefx/pull/336 2019-08-23 14:43:05 +02:00
Zoltan Varga f0cbb79b7f Merge pull request #16431 from kjpou1/wasm-maindir-cleanup
[wasm] Small cleanup of main wasm directory
2019-08-23 08:13:21 -04:00
Zoltan Varga 97d2d97615 [jit] Make mono_unwind_frame () ignore registers which are greater than NUM_DWARF_REGS.
These registers can be encountered in the unwind info for functions with a cold
cconv, like xmm0 on amd64. Since they are caller saved, they don't have to
be restored during EH.
2019-08-23 07:49:20 -04:00
Zoltan Varga fdd0d7f027 Merge pull request #16429 from vargaz/llvm-jit-module
[llvm] Don't pass a module argument to the code in llvm-jit.cpp, we create a new LLVM module for each method.
2019-08-23 06:40:09 -04:00
Zoltan Varga 81f736e774 Fix the bitcode build. 2019-08-23 06:28:40 -04:00
Zoltan Varga 4ed1c3335f [llvm] Add a cold wrapper and mono wrapper for gc poll for JITted code as well. 2019-08-23 05:34:52 -04:00
Kenneth Pouncey f5717d21bb Address review comments wasm/support to wasm/src 2019-08-23 11:11:57 +02:00
Zoltan Varga 0d603261a0 Fix the build. 2019-08-23 04:41:50 -04:00
Zoltan Varga f6b189ecab [llvm] Add a mono wrapper method for the gc poll cold cconv wrapper so the EH code can unwind through it. 2019-08-23 04:41:50 -04:00
Zoltan Varga 8ace375450 Merge pull request #16407 from vargaz/fix-llvm-simd
[llvm] Fix type issues in the llvm IR emitted for SIMD. Fix a warning.
2019-08-23 04:41:10 -04:00
Zoltan Varga 14a76b03c5 Merge pull request #16408 from vargaz/noreturn-methods
[jit] Special case the ThrowHelper methods only on netcore.
2019-08-23 04:40:28 -04:00
Egor Bogatov 47efe6bab0 Merge pull request #16412 from EgorBo/fix-ci4
[netcore] Fix CI, ignore failing tests
2019-08-23 11:17:31 +03:00
Kenneth Pouncey 8b338a9619 [wasm] Small cleanup of main wasm directory
- Move source support files for custom building the wasm runtimes to a new directory called `wasm/support`
- Modified `packager.exe` to build from this new subdir.
- Updated the README.md to document the change.
2019-08-23 09:59:31 +02:00
Zoltan Varga c357de87ec [llvm] Don't pass a module argument to the code in llvm-jit.cpp, we create a new LLVM module for each method. 2019-08-23 03:27:41 -04:00
Zoltan Varga c97bfe2167 Merge pull request #16379 from EgorBo/improve-dump
Improve MONO_VERBOSE_METHOD
2019-08-23 02:08:12 -04:00
Michal Strehovský 9bffb810ee Mark methods specially handled in JitInterface Intrinsic (#26209)
* Mark methods specially handled in JitInterface Intrinsic

For CPAOT compiler's sake.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-23 00:51:24 +02:00
coypoop f626f3e7aa If either sched_get_priority_{min,max} failed, don't try to set a priority (#15898)
netbsd and linux both require that if SCHED_OTHER is used, a fixed value is used for sched_param ([0 for linux](http://man7.org/linux/man-pages/man7/sched.7.html), -1 for netbsd)

the netbsd case can also be detected by the [POSIX-defined failure](https://pubs.opengroup.org/onlinepubs/007908799/xsh/sched_get_priority_min.html) return value for sched_get_priority_min, a return value of -1.
2019-08-23 00:46:08 +02:00
EgorBo 71dce6502a ignore FSW test 2019-08-23 01:12:47 +03:00
Martin Baulig 473d07a86c Fix issue in SafeHandle.DangerousReleaseInternal() that caused #16034. (#16244)
Using the CoreCLR version of this line fixed the problem and my investigations
also revealed why.

The `SafePipeHandle` contains a reference to both the Socket as well as the
`SafeSocketHandle`, taking ownership of them.  If there are no additional
references to either of them, so that both are collected in the same GC pass,
their finalizer may be invoked in any order.

If the Socket gets finalized first, it's `SafeSocketHandle` will have a `_mstate`
of 8 (two references) at the beginning of `DangerousReleaseInternal()` - which
will set it to 6 (one reference plus disposed flag).

Then when the `SafePipeHandle` gets collected, it will call `DangerousRelease ()`
on it's `SafeSocketHandle`.  As mentioned above, it's `_mstate` will be 6.
Now we own the handle, so we'll decrease it's reference count by one and set the
`Closed` flag - the new `_mstate` should thus be 3.

However, using

    new_state = (old_state & RefCount_Mask) - RefCount_One;

would set it to 1 - thus effectively clearing the `Disposed' flag.  And since it's
reference count is now also zero, the next finalize pass will then throw.

The CoreCLR version of this class uses

    new_state = old_state - RefCount_One;

which fixes this.
2019-08-22 23:46:31 +02:00
Nathan Ricci 93ff9dab7b Removed start/stop the world gc api. 2019-08-22 16:50:58 -04:00
EgorBo 692f70cb67 ignore more tests 2019-08-22 23:08:44 +03:00
EgorBo 40cf68aa98 Disable the whole System.ComponentModel.Composition namespace 2019-08-22 21:47:45 +03:00
Stephen Toub f5a1fa4744 Fix IDE0034 (simplify default expression)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub f256a4525d Fix IDE0054 (use compound assignment)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub e2c7b4200a Fix (mostly) IDE0055 (formatting)
Lots of various spacing issues.  I say "mostly" because I explicitly undid some changes that added to rather than reduced inconsistency, e.g. region indents.  We can revisit that later.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub 9be0c2217c Fix StyleCop warning SA1114 (parameter list should follow declaration)
Fixed just be removing stale/unnecessary comments.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub d3817c9302 Fix StyleCop warning SA1006 (empty statements)
This is just running the rule and auto-fixing everything.  I undid changes that converted e.g. `while (...);` to `while (...) { }`.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub 35d8ca894b Fix StyleCop warning SA1005 (single line comment spacing)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub 55bc2fee8a Fix (mostly) StyleCop warning SA1003 (operator symbol spacing)
The "mostly" here is that I undid changes where it was forcing formatting around a `: this` or `: base` call for a ctor, in particular where it was moving one up from the next line to be at the end of the current line.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub e23c35f730 Fix StyleCop warning SA1024 (colon spacing)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub 26656df25e Fix StyleCop warning SA1015 (closing generic brace spacing)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub f3b0e98aae Fix StyleCop warning SA1013 (closing brace spacing)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub ac42e06fea Fix StyleCop warning SA1012 (opening brace spacing)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub 8c01fd5189 Fix StyleCop warning SA1008 (opening paren spacing)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub f83a8da0ce Fix StyleCop warning SA1002 (semicolon spacing)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Stephen Toub 46302d54aa Fix StyleCop warning SA1001 (commas followed by whitespace)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 20:21:18 +02:00
Nathan Ricci bfce92d9dd Added tracking for detached threads. 2019-08-22 14:14:39 -04:00
EgorBo 7678654781 fix macOS 2019-08-22 20:53:14 +03:00
Steve Pfister fbdad78101 Added a workaround for an issue with the compiler server on 32-bit linux. (#16405)
Currently, if the process is 32-bit, roslyn tries to determine how much
memory is available.  To do that, it tries to pinvoke into GlobalMemoryStatusEx,
which is not supported on mono.

Without it, the compiler server bombs on https://github.com/dotnet/roslyn/blob/0e63260c5afb3fb5b74c357dd250e500172bcd63/src/Compilers/Server/VBCSCompiler/NamedPipeClientConnection.cs#L55-L59
2019-08-22 18:22:22 +02:00
EgorBo 779fda5103 update rsp 2019-08-22 19:02:53 +03:00
EgorBo f809fe55a8 ignore some tests 2019-08-22 18:52:52 +03:00
Stephen Toub 4dd0a137a4 Avoid race condition in DiagnosticCounter (dotnet/coreclr#26260)
* Avoid race condition in DiagnosticCounter

If while a DiagnosticCounter instance is being created the timer fires to process counters, the timer may end up evaluating a DiagnosticCounter whose constructor or derived types' constructor hasn't finished configuring the instance's state yet.

* Remove unnecessary #if

Signed-off-by: dotnet-bot <[email protected]>
2019-08-22 16:59:43 +02:00
Nikolay Sivov 068660732f [corlib] Improve file:// url handling in AppDomainSetup. (#16161)
* [corlib] Improve file:// url handling in AppDomainSetup.

WiX 3 installer toolkit uses file:/// prefix when setting ApplicationBase for newly created domain.
Currently this leads to invalid path exception:

file:///C:\... -> /C:\... -> full path expansion with current workdir on different drive -> Y:\C:\...

Later it fails check for multiple ':' -> NotSupportedException ("The given path's format is not supported.").

This patch uses logic already present in AppDomain::Load().

* [Test] Add a test for file:/// application base.

* [Test] Fix test failure on Windows.

* [corlib] Simplify file: protocol check for AppDomainSetup.
2019-08-22 16:54:32 +02:00
Zoltan Varga 49f913ac8a [jit] Special case the ThrowHelper methods only on netcore. 2019-08-22 10:36:43 -04:00
Zoltan Varga f2f58e522b [llvm] Fix type issues in the llvm IR emitted for SIMD. Fix a warning. 2019-08-22 10:28:47 -04:00
Aleksey Kliger (λgeek) e74736a471 [android] mono_dl_open_file: use g_file_test only on absolute paths (#16387)
The intention of calling `g_file_test (file, G_FILE_TEST_EXISTS)` where file is
the name of a shared library we want to open is to speed up probing for
non-existent libraries.

See https://github.com/mono/mono/pull/12074

The problem is that if file is just a simple "libdl.so" then `dlopen (file)`
doesn't just look for it in the current working directory, it will probe some
other paths too.  (For example on desktop linux you'd also look in all the
directories in LD_LIBRARY_PATH).  So the g_file_test() call is not a robust way
to avoid calling dlopen if the filename is relative.

But it actually broke more things: https://github.com/xamarin/xamarin-android/issues/3388

When probing for "libdl.so" on Android mono_lookup_pinvoke_call will first try
prepending some paths that it knows about and we end up calling
`dlopen ("/system/lib/libdl.so")` which will fail because Bionic has security
restrictions on what code can dlopen something from /system/lib with an
absolute path.  Eventually mono_lookup_pinvoke_call will go back to trying the
bare "libdl.so" which hits `g_file_test` and returns NULL.

The new code only does the file test if we pass it an absolute path, which
gives Bionic's dlopen a chance to deal with relative paths however it needs to.
2019-08-22 10:10:09 -04:00
Zoltan Varga f6b0c9b772 Merge pull request #16300 from EgorBo/llvm-fpm
Use basic LLVM optimizations (PassManager) in JIT mode
2019-08-22 09:07:02 -04:00
Jay Krell 5368fef5ee [interp] Replace endsp with preexisting child_frame.retval which appears equivalent. (#16378)
This should conserve stack. I didn't verify it.
child_frame being address-taken, compiler would struggle to remove it.
So we have the same value in two places.

https://github.com/mono/mono/issues/16172
2019-08-22 14:57:38 +02:00
Zoltan Varga 87a6364d58 Merge pull request #16390 from EgorBo/intptr-intrinsic
Make IntPtr.Zero intrinsic
2019-08-22 08:43:07 -04:00
Zoltan Varga 341cc0dd83 Merge pull request #16386 from vargaz/llvm-inline-limit
[llvm] Use a different inline limit (30) for llvm+aot.
2019-08-22 08:26:10 -04:00
Zoltan Varga 3f21a2c8f3 Merge pull request #16384 from vargaz/fix-16381
[llvm] Fix an assert.
2019-08-22 07:26:36 -04:00
Zoltan Varga 254d6d3758 Merge pull request #16389 from vargaz/fix-16380
[aot] Simplify a check to avoid calling into the assembly loading code while loading the aot image for corlib.
2019-08-22 05:36:17 -04:00
Zoltan Varga b7ca80ed58 Add comments. 2019-08-22 00:34:32 -04:00
Egor Bogatov 279676f43e Update llvm-jit.cpp 2019-08-22 01:46:10 +03:00
Egor Bogatov d02695ef47 cleanup 2019-08-22 01:43:56 +03:00
Egor Bogatov 1822f2faab Merge remote-tracking branch 'origin/master' into llvm-fpm 2019-08-22 00:47:40 +03:00
Nathan Ricci 6caa530970 Removed unneeded declarations. 2019-08-21 17:31:34 -04:00
Bernhard Urban 5c9be2dc2b [netcore] Use Release configuration for default System.Private.CoreLib build (#16391)
It seems the Configuration set inside of the System.Private.CoreLib.csproj is just completely ignored, making it default to "Debug".

Maybe because we're using Microsoft.NET.Sdk ?
2019-08-21 23:16:03 +02:00
Nathan Ricci b65443f324 Added stubs in null, boehm. 2019-08-21 16:55:51 -04:00
Nathan Ricci f913945e76 Implemented precise. 2019-08-21 16:27:02 -04:00
Nathan Ricci dc8aeba593 stopped the world for precise. 2019-08-21 16:05:29 -04:00
Nathan Ricci 56f44379d0 Took changes from miguel's branch. 2019-08-21 15:54:07 -04:00
Nathan Ricci 65360da5d9 Working on precise. 2019-08-21 15:51:45 -04:00
Egor Bogatov cb34178cd6 use EMIT_NEW_PCONST 2019-08-21 21:48:14 +03:00
Egor Bogatov d3ecd70ead Make IntPtr.Zero intrinsic 2019-08-21 21:23:19 +03:00
Zoltan Varga c4de19ef09 [aot] Simplify a check to avoid calling into the assembly loading code while loading the aot image for corlib.
Fixes https://github.com/mono/mono/issues/16380.
2019-08-21 14:15:25 -04:00
Nathan Ricci 0754f5ebe5 Fixed alphabitization error. 2019-08-21 13:59:50 -04:00
Nathan Ricci cfb4afff43 Got rid of some debug code. 2019-08-21 13:55:20 -04:00
Zoltan Varga 433b9a7f70 [llvm] Use a different inline limit (30) for llvm+aot. 2019-08-21 12:20:50 -04:00
Zoltan Varga 0e2da3c2ab [llvm] Fix an assert.
Fixes https://github.com/mono/mono/issues/16381.
2019-08-21 12:03:20 -04:00
Nathan Ricci 53939d0790 Implemeneted imprecise. 2019-08-21 11:20:27 -04:00
EgorBo 26d73b94f6 cleanup 2019-08-21 14:34:00 +03:00
EgorBo 467a561dcb Merge remote-tracking branch 'origin/master' into ffast-math
# Conflicts:
#	mono/mini/llvm-jit.cpp
#	scripts/ci/pipeline-netcore-runtime.yml
2019-08-21 14:30:07 +03:00
EgorBo ad713a70ef Merge remote-tracking branch 'origin/master' into llvm-fpm 2019-08-21 14:20:57 +03:00
Egor Bogatov 50b57fe926 Update mini.c 2019-08-21 14:07:59 +03:00
Egor Bogatov 6bb1e5ffc4 Update mini-llvm.c 2019-08-21 14:07:02 +03:00
Egor Bogatov e5acc9be7a undo change in mini.c 2019-08-21 14:04:57 +03:00
Egor Bogatov b0b3743f36 Improve MONO_VERBOSE_METHOD 2019-08-21 13:35:40 +03:00
Kenneth Pouncey 935d0a54e7 [wasm] Make sure message pump is working when run via webworker. (#16325)
- Tests if we are running in ENVIRONMENT_IS_WORKER
   - run message pump if we are.

- This also fixes gc not running.

issue: https://github.com/mono/mono/issues/16319
2019-08-21 06:24:06 +02:00
Zoltan Varga 977ccf7cb2 Merge pull request #16363 from vargaz/tp-thread-name
[runtime] Avoid resetting the tp thread name on every call to worker_callback ().
2019-08-20 23:14:44 -04:00
Zoltan Varga 285f33efe6 Merge pull request #16286 from vargaz/netcore-simd
[netcore] Add a netcore version of simd-intrinsics.c.
2019-08-20 23:11:27 -04:00
Nathan Ricci 37086aa1c4 Put things in correct order. 2019-08-20 18:28:35 -04:00
Nathan Ricci bf04a1946f Modified sample project. 2019-08-20 17:38:23 -04:00
Nathan Ricci fb7895dddf Added ical to netcore. 2019-08-20 17:37:58 -04:00
Alexander Köplinger 38c524cc2a Fix Windows build 2019-08-20 22:55:39 +02:00
Alexander Köplinger 55f2c4d6ad [profiler] Rename helper functions to have common prefix
Unfortunately https://github.com/mono/mono/pull/16335 didn't fix the new symbols showing up in the log profiler module.
The reason is that we actually pass `--disable-visibility-hidden` for iOS builds in https://github.com/mono/mono/blob/0b6d95e8ce7c882e2db9e89fa0dec850c687f65e/sdks/builds/ios.mk#L98.

Rename the helper functions instead to have a common prefix so they can be ignored in xamarin-macios tests.
2019-08-20 22:55:39 +02:00
Aleksey Kliger ed0063b4d5 [w32socket] Translate some errno codes to WSA_ errors imprecisely.
These aren't a perfect match, but better than falling into the `default` case
where Mono asserts and crashes.

Addresses part of https://github.com/mono/mono/issues/16024
2019-08-20 16:13:41 -04:00
Aleksey Kliger c38044d74f [w32error] Add WSA_INVALID_PARAMETER and WSA_INVALID_HANDLE 2019-08-20 16:13:41 -04:00
Ryan Lucia fc5e3fa039 [netcore] Remove local copy of static alc resolve methods 2019-08-20 21:25:00 +02:00
Ryan Lucia 3b47d28e37 Move AssemblyLoadContext VM-invoked static resolve methods to shared (#26248)
Shared between CoreCLR and Mono. Mono began using a copy of these methods with https://github.com/mono/mono/pull/16256/

Signed-off-by: dotnet-bot <[email protected]>
2019-08-20 21:25:00 +02:00
Nathan Ricci c1d01679c5 Merge branch 'master' of github.com:naricc/mono into naricc/GetTotalAllocatedBytes 2019-08-20 15:22:18 -04:00
Alexander Köplinger a147402d07 [ci] FreeBSD: Make sure we have gmake in /usr/bin 2019-08-20 21:08:54 +02:00
Alexander Köplinger ac3aa7c1c7 Bump corefx to get https://github.com/mono/corefx/pull/332 2019-08-20 20:52:02 +02:00
Stephen Toub 5f38497e19 Remove unused usings from Corlib (dotnet/coreclr#26250)
* Fix IDE0065 (misplaced using)

* Fix IDE0005 (remove unnecessary usings)

Signed-off-by: dotnet-bot <[email protected]>
2019-08-20 19:45:30 +02:00
madmir 4dd016004b Re-enable xunit warning 1019 (dotnet/corefx#40415)
Make MemberData reference IEnumerable<object[]>

Signed-off-by: dotnet-bot <[email protected]>
2019-08-20 19:45:30 +02:00
Ryan Lucia 0b6d95e8ce [netcore] Remove unnecessary calls to mono_domain_get (#16336)
Should use mono_alc_domain where possible
2019-08-20 12:55:54 -04:00
Alexander Köplinger 5dc4a86d9d [netcore] Consolidate running tests between AzDO pipeline and Makefile (#16348)
* [netcore] Consolidate running tests between AzDO pipeline and Makefile

There was some unnecessary duplication between the two that we can remove.

* Add timeout to test execution
2019-08-20 17:59:55 +02:00
Zoltan Varga 8a413fad71 Fix the build. 2019-08-20 11:32:46 -04:00
Zoltan Varga b5cfeb3b5b [runtime] Avoid resetting the tp thread name on every call to worker_callback (). 2019-08-20 11:31:12 -04:00
Phil Jaenke b7dc4f0a46 Fix Jenkins build failure due to missing dependencies (#16362)
Jenkins builds are failing due to missing gettext; also realized that graphics unit tests will fail without some additional packages that will not be pulled in automatically.

Added:
`gettext-runtime gettext-tools cairo libdrm mesa-dri mesa-libs`
2019-08-20 16:19:36 +02:00
Jo Shields 3070ab6a96 Pass -fvisibility=hidden to profiler modules. (#16335)
* Pass -fvisibility=hidden to profiler modules.

This appears to not break the profilers:

```
directhex@breakfast:/tmp$ nm -g /tmp/ponyponyponypony/lib/libmono-profiler-log.so | grep close_socket_fd
directhex@breakfast:/tmp$
directhex@breakfast:/tmp$ /tmp/ponyponyponypony/bin/mono --profile=log:report bottle.exe
99 bottles of beer on the wall, 99 bottles of beer.
Take one down and pass it around, 99 bottles of beer on the wall.

[..]

No more bottles of beer on the wall, no more bottles of beer.
Go to the store and buy some more, 99 bottles of beer on the wall.

Mono log profiler data
	Profiler version: 3.0
	Data version: 17
	Arguments: log:report
	Architecture: x86-64
	Operating system: linux
	Mean timer overhead: 86 nanoseconds
	Program startup: Mon Aug 19 14:18:30 2019
	Program ID: 17715
	Server listening on: 41539

JIT summary
	Compiled methods: 753
	Generated code size: 228046
	JIT helpers: 0
	JIT helpers code size: 0

GC summary
	GC resizes: 0
	Max heap size: 0
	Object moves: 0

Metadata summary
	Loaded images: 3
	Loaded assemblies: 3

Exception summary
	Throws: 0
	Executed finally clauses: 3

Thread summary
	Thread: 0x7fcd968c9700, name: "Finalizer"
	Thread: 0x7fcd966c8700, name: "Profiler Sampler"
	Thread: 0x7fcd9b036780, name: "Main"
	Thread: 0x7fcd964c7700, name: "Profiler Helper"
	Thread: 0x7fcd954c5700, name: "Profiler Dumper"
	Thread: 0x7fcd95cc6700, name: "Profiler Writer"

Domain summary
	Domain: (nil), friendly name: "bottle.exe"

Context summary
	Context: (nil), domain: (nil)

Counters:
	Mono System:
		User Time                      : 70.000ms
		System Time                    : 0.000ms
		Total Time                     : 140.000ms
		Working Set                    : 22032384
		Private Bytes                  : 63455232
		Virtual Bytes                  : 449630208
		Page Faults                    : 3004
		CPU Load Average - 1min        : 1.870000
		CPU Load Average - 5min        : 2.670000
		CPU Load Average - 15min       : 2.900000
	Mono JIT:
		Methods from AOT               : 536
		Methods JITted using mono JIT  : 154
		Methods JITted using LLVM      : 0

```

* Add missing annotations and includes
2019-08-20 16:17:26 +02:00
Calvin Buckley b57d52ce77 Fix minizip compile on Haiku (#16301)
it doesn't have f*64 funcs, it seems
2019-08-20 16:00:24 +02:00
Jay Krell 169205813b [interp] Outline box_nullable. (#16356)
Without being entirely scientific about it, this case seems
to be one that uses more than typical locals and therefore
be on a sort of critical path to reduce frame size.

I have a change that reduces frame to 0x78 bytes (albeit
not yet working) and to achieve that, in this case I refetched
the locals after function calls.

This achieves similar but perhaps more elegantly.
If we rest at larger frame size then this case might not be on the critical path.

https://github.com/mono/mono/issues/16172.
2019-08-20 15:53:25 +02:00
Jan Kotas 1592d2a8fa Change missed by the mirror (dotnet/coreclr#26251)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-20 15:37:10 +02:00
Phil Jaenke 317e741c02 Many updates to freebsd.sh (#16342)
* Many updates to make it better

Too much to list by many measures. This makes sure appropriate kernel modules, file systems, build packages, supplemental packages, and directories are installed or created as appropriate. This also addresses a known failure condition in System.Security-xunit due to a missing directory resulting in ownership problems.

* Make corrections for Azure

I don't have an Azure to test with, so I missed that the script is calling with `-e` and that Azure uses a non-`GENERIC` kernel with procfs baked in (likely required for Azure drivers.)
2019-08-20 15:35:18 +02:00
Egor Bogatov c231a357a7 Merge branch 'master' into ffast-math 2019-08-20 14:19:06 +03:00
Jay Krell ea29349f77 [interp] Reduce register/stack pressure esp. around vtable initialization. (#16349)
Part of #16172 though not necessarily any gain from this change, at this time.
2019-08-20 13:03:12 +02:00
Alexander Köplinger b205f1bd9c [interp] Reduce register/stack pressure slightly, i.e. so that field does not have (#16339)
to be preserved across `mono_get_special_static_data ()` if non-volatile registers
are all otherwise allocated.
2019-08-20 12:04:30 +02:00
Jay Krell 33153ddd2d [interp] Relieve register/stack pressure around mono_thread_internal_current. (#16341)
Part of #16172 though not necessarily any gain from this change, at this time.
We might want to expose ifdef and inline mono_thread_internal_current also or instead.
2019-08-20 12:03:48 +02:00
Alexander Köplinger 5ebce09c51 Bump bockbuild to get gtksharp 2019-08-20 11:54:59 +02:00
Jay Krell bc2accfc7e Fix warnings. (#16287)
debug-mono-ppdb.c ppdb_compressed_size may be used uninitialized
   ppdb_size may be used uninitialized
 image.c iinfo set but not used
 icall.c klass set but not used
2019-08-20 11:47:38 +02:00
Egor Bogatov 8800f7c166 Update pipeline-netcore-runtime.yml 2019-08-20 12:14:23 +03:00
Egor Bogatov 4a5e2a3f79 Update pipeline-netcore-runtime.yml 2019-08-20 12:13:59 +03:00
Alexander Köplinger 9a5ae23f7e [netcore] Use Release configuration for CI builds (#16329)
* [netcore] Use Release configuration for CI builds

Fixes https://github.com/mono/mono/issues/16308

* [ci] Ensure the artifacts/logs/Release folder exists

Some arcade steps need the path to exist and we only create artifacts/logs/Debug right now,
because that folder is created by eng/common/tools.sh used by init-tools.sh defaulting to Debug.
2019-08-19 23:52:01 +02:00
Jay Krell 31aed632ba [interp] Inline MINT_NEWOBJ_VTST_FAST (#16314)
For purposes of stack savings, only MINT_NEWOBJ_VT_FAST w/o the "ST"
needed to be outlined, and inlining also the ST form increased
its stack use, w/o savings elsewhere.

That is, the recursive cases should generally not be outlined.
We were outlining two. We still outline one.

This is partially undoing my recent change, where I outlined both of these, but only one was justified.
2019-08-19 23:48:20 +02:00
Egor Bogatov feac6c0d04 temp: run tests on CI 2019-08-19 23:30:41 +03:00
Jay Krell 2313f1a884 [interp] Reduce register/stack pressure slightly, i.e. so that field does not have
to be preserved across `mono_get_special_static_data ()` if non-volatile registers
are all otherwise allocated.
2019-08-19 13:02:49 -07:00
Ryan Lucia 7c3dfbcbdf [netcore] Update ALC test exclusions (#16332) 2019-08-19 14:50:15 -04:00
Aleksey Kliger (λgeek) 2f0cbb5aa5 [coop] Add a handle frame in construct_culture (#16299)
Otherwise we see warnings like these:

```
ves_icall_System_Globalization_CultureInfo_internal_get_cultures_raw USED 680 handles
```
2019-08-19 11:01:09 -04:00
Alexander Köplinger 0ad1f5cca1 [ci] Add CI VM provisioning script for FreeBSD to the repo (#16326)
We'll download it from GitHub instead of storing it in Jenkins admin config.

Trial run with FreeBSD for moving all the other provisioning scripts to the repo too.
2019-08-19 14:44:00 +02:00
Martin Baulig a3c31b9ef7 Add missing Dispose() call on error in MonoTlsStream.CreateStream(). (#16233)
* Add missing `Dispose()` call on error in `MonoTlsStream.CreateStream()`.

* Remove the `finally` block to make it more easy to read.
2019-08-19 14:23:28 +02:00
Vincent Povirk 9f790cd5e2 eglib: Remove broken executable test on Windows. (#16295)
The strcmp is wrong, and it doesn't test anything meaningful anyway.

This flag is unused since #16156 was merged.
2019-08-19 13:09:14 +02:00
Jan Kotas a723047f68 Fix CoreRT build breaks
Signed-off-by: dotnet-bot <[email protected]>
2019-08-19 13:07:13 +02:00
Stephen Toub ad63045907 Remove useless GetLongPathNameW call (dotnet/coreclr#26210)
Immediately after calling this we're going to loop around and call it again at the beginning of the while loop.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-19 13:07:13 +02:00
Egor Bogatov 77a9c82523 Introduce ffast-math 2019-08-19 13:07:43 +03:00
Jay Krell 8886f71b2c [interp] Remove InterpFrame.locals, replace with reasonably efficient frame_locals macro.o (#16317)
Contributes to #16172.
2019-08-19 11:50:20 +02:00
Alexander Köplinger e754bb1c43 [interp] Put finally data back in locals instead of frame to save 16 bytes of stack. (#16307)
* Put finally data back in locals instead of frame to save 16 bytes of stack.

Partial undo of f8fd60b5c0.

* Add comments explaining goto main_loop vs. MINT_IN_DISPATCH.
2019-08-19 11:24:44 +02:00
Jay Krell 60cd1b3556 [interp] Outline ves_array_element_address to save 16 bytes of stack on Linux/amd64/clang. (#16304)
Contributes to #16172.
2019-08-19 11:24:10 +02:00
Alexander Köplinger 9001c4fa83 thread names: coop, constants, usually ignore-error. (#16272)
- Convert setting thread name to be coop-compatible.

- For constant thread names, just retain the constant, not a copy.
  This includes producing and using constant unicode thread names on Windows.

- Make setting a thread name often non-fatal, except where mandated by public API.

- From earlier PR: mono_free (mono-publib.c) would no longer be referenced and therefore
  no longer exported. That broke profilers and maybe other externals.
  Choices:
     1 Use it instead of g_free randomly sometimes.
     2 Call it randomly sometimes.
     3 include it in external-only.c or object.c
     4 Mark it external only (breaks profiler).
     5 Use a .def file or Unix equivalent.

     5 is best, 2 is done here, the advantages/disadvantages
     among most choices are subtle. 3 is probably better than 2
     but is slightly bigger change, to put off -- you'd stop
     compiling mono-publib.c and move it to include/extra_redist.

     The advantage of not-.def file is perhaps that it is exposed
     by the compiler, so maybe easy to port and work with.
     People are more comfortable with obscure C extensions than
     any linker options, and there are multiple linkers to contend
     with. Arguably there are fewer compilers.
2019-08-19 11:23:23 +02:00
Jay Krell cf0ce4f55a Reduce size of internal MonoErrors by 3 pointers, while trying to be compatible with old size.(#16218)
There is an incompatibility here.

If Mono hands off an InternalError and it is accessed
like an ExternalError, like memset(sizeof()), bad.

Hopefully nobody does that.

There is also compatability -- embedders can continue to embed MonoError
in their own data. Its size and hopefully alignment is unchanged.
2019-08-19 11:20:37 +02:00
Jay Krell 047c7d35fa [interp] Replace frame.args with frame.stack, the same except for type (#16316)
Contributes to #16172.
2019-08-19 11:19:10 +02:00
Vlad Brezae 975b543e92 [interp] Make sure we allocate stack for MINT_LD_DELEGATE_INVOKE_IMPL (#16224)
* [interp] Make sure we allocate stack for MINT_LD_DELEGATE_INVOKE_IMPL

This opcode is pushing a function pointer from the delegate, so it needs to have stack reserved.

* [interp] Fix overflow of stack space
2019-08-19 11:59:21 +03:00
Jay Krell cecea63691 warning: mono-threads-wasm.c no previous prototype for function mono_background_exec (#16289) 2019-08-19 05:22:06 +02:00
Stephen Toub 04909573e7 Undo use of Index/Range in files compiled into netfx-compat assemblies
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 22:12:06 +02:00
Stephen Toub 424af0fb98 Fix DecoderExceptionFallbackBuffer message (dotnet/coreclr#26211)
When the number of unknown bytes is exactly 20, the message includes a misleading " ..." at the end.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 22:12:06 +02:00
Jay Krell d1f47e7b48 [interp] Reduce register/stack pressure slightly. (#16303)
No savings on Linux/amd64/gcc/clang.
2019-08-18 17:36:33 +03:00
Zoltan Varga e1b57c371a Fix the build. 2019-08-18 08:48:15 -04:00
Zoltan Varga 4503b67a0b Implement a subset of Intel BMI1/BMI2 intrinsics used by corelib. 2019-08-18 06:08:31 -04:00
Zoltan Varga 7337a3e405 Add support for Bmi1 instrinsics. 2019-08-18 05:25:04 -04:00
Zoltan Varga 157bb9f4e3 Make simd-methods-netcore.h less verbose. 2019-08-18 05:23:15 -04:00
Zoltan Varga 121d9ca4a9 [jit] Don't mark ThrowForUnsupportedVectorBaseType<T> as do-not-return. Assert that do-not-return methods actually don't return. 2019-08-18 03:18:24 -04:00
Zoltan Varga 7e76abb4ca [llvm] Add support for 32 byte AVX types, not enabled yet. 2019-08-18 02:01:10 -04:00
Zoltan Varga 1a9f9fb927 [llvm] Compute cpu features lazily. 2019-08-18 01:57:14 -04:00
Zoltan Varga 3c6e8de0da [jit] Enable alias analysis dce even if there are no ldaddr instructions eliminated, they could have been eliminated earlier. Enable only for netcore for now. 2019-08-18 01:55:25 -04:00
Zoltan Varga c0e03ef28f [llvm] Fix support for 32 byte simd values. 2019-08-18 01:40:28 -04:00
Stephen Toub c48dd0608d Fix IDE0025 (use expression body for properties)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 2e9134f1a6 Fix IDE0056 (use index operator)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 08b942ab68 Fix IDE0057 (use range operator)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 9595189a0a Fix IDE0054 (use compound assignment)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub c8eb6972b5 Fix IDE0060 (unused parameter)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 64f4ba27f0 Fix IDE0059 (unnecessary assignment)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 71fcdf53e3 Fix IDE0029 (use coalesce expression)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 828f89360f Fix IDE0031 (use null propagation)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 8af19427ad Fix IDE0028 (collection initializers)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 20adb69c73 Fix IDE0008 (use explicit type instead of var)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub 8dd17900cc Fix IDE0065 (using directives should be outside of a namespace)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Stephen Toub c0191b2575 Fix IDE0019/20 (Use pattern matching)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-18 07:01:54 +02:00
Kenneth Pouncey 02126de318 Add regression test for issue https://github.com/mono/mono/issues/12917
- IL Linker not working correctly with IQueryable extensions
2019-08-17 17:50:39 -05:00
Jay Krell 9a24e9a389 Add comments explaining goto main_loop vs. MINT_IN_DISPATCH. 2019-08-17 15:45:21 -07:00
Zoltan Varga 9df02d7a2d Fix the build. 2019-08-17 17:22:41 -04:00
Stephen Toub 2e618f0e63 Fix IDE0066 across corefx (dotnet/corefx#40288)
* Fix IDE0066 across corefx

"Fix all", but then manual tweaking to accommodate places the rule doesn't work quite right.

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-08-17 23:07:24 +02:00
Zoltan Varga 44cfea466f Fix the build. 2019-08-17 12:26:35 -04:00
Zoltan Varga 7418248835 Add support for the System.Runtime.Intrinsics.X86.Popcnt intrinsics. 2019-08-17 12:25:59 -04:00
Zoltan Varga bfe4155083 [llvm] Add support for querying the cpu attributes from the LLVM jit. 2019-08-17 12:25:58 -04:00
Zoltan Varga b39abe5365 Fix the build. 2019-08-17 12:25:31 -04:00
Zoltan Varga 9eb687f2b9 Fix the windows build. 2019-08-17 12:25:31 -04:00
Zoltan Varga 98a02059e8 [jit] Add a netcore version of simd-intrinsics.c.
Differences from the old versions:
- Only Vector<T> from corelib is supported.
- Only LLVM is supported.
- It uses more general opcodes like XBINOP instead of having one opcode
  for every op+type combination which is not useful for LLVM.
2019-08-17 12:25:30 -04:00
Zoltan Varga 2c32eb1fa8 [jit] Optimize away box+unbox combinations which are common in corefx code. 2019-08-17 12:25:30 -04:00
Zoltan Varga 13fb0134a0 Merge pull request #16210 from EgorBo/opt-llvm-jit
Auto-detect current cpu in LLVM JIT
2019-08-17 12:22:07 -04:00
Jay Krell 3fb7834afb Put finally data back in locals instead of frame to save 16 bytes of stack.
Partial undo of f8fd60b5c0.
2019-08-17 00:05:50 -07:00
Jay Krell 0c6cb9fbc3 thread names: coop, constants, usually ignore-error.
- Convert setting thread name to be coop-compatible.

- For constant thread names, just retain the constant, not a copy.
  This includes producing and using constant unicode thread names on Windows.

- Make setting a thread name often non-fatal, except where mandated by public API.

- From earlier PR: mono_free (mono-publib.c) would no longer be referenced and therefore
  no longer exported. That broke profilers and maybe other externals.
  Choices:
     1 Use it instead of g_free randomly sometimes.
     2 Call it randomly sometimes.
     3 include it in external-only.c or object.c
     4 Mark it external only (breaks profiler).
     5 Use a .def file or Unix equivalent.

     5 is best, 2 is done here, the advantages/disadvantages
     among most choices are subtle. 3 is probably better than 2
     but is slightly bigger change, to put off -- you'd stop
     compiling mono-publib.c and move it to include/extra_redist.

     The advantage of not-.def file is perhaps that it is exposed
     by the compiler, so maybe easy to port and work with.
     People are more comfortable with obscure C extensions than
     any linker options, and there are multiple linkers to contend
     with. Arguably there are fewer compilers.
2019-08-16 15:24:30 -07:00
Egor Bogatov 6847508d2a Update llvm-jit.cpp 2019-08-17 00:25:19 +03:00
Jay Krell 16a81cf520 [Coop] Convert mono_attach_load_agent. (#15954)
Based on https://github.com/mono/mono/pull/15868.
Most cleanup and leak fixes moved and expanded to https://github.com/mono/mono/pull/15950.
2019-08-16 17:16:03 -04:00
Ryan Lucia 1e457cdd1e [netcore] Enable netcore resolution logic for mono_assembly_byname_lookup (#16256)
* Use netcore_load_reference in mono_assembly_request_byname

* Add ALC static Resolve event code from CoreCLR

* Wire up the AssemblyResolve event

* Enable newly passing test

* Set requesting assembly in InternalLoad

* Remove infinite recursion

* Only call netcore_load_reference from mono_assembly_request_byname

* Remove test completely
2019-08-16 16:54:47 -04:00
Nathan Ricci 325bbf541b Changes GC.cs 2019-08-16 11:48:35 -04:00
Nathan Ricci 029467271e Implemented imprecise version of get total bytes allocated. 2019-08-16 11:26:39 -04:00
Jay Krell e54f03168d Ignore NULL in mono_marshal_free_dynamic_wrappers and mono_free_method. (#14150) 2019-08-16 09:33:04 -04:00
Jay Krell 66afab5803 Fill in more MONO_PATCH_INFO_NONE support. (#13990) 2019-08-16 09:32:48 -04:00
Jay Krell f52bfb94d5 [interp] Localize c, i32, o as suggested. (#16268)
This saves 16 stack bytes for clang, gcc is unmoved probably figured it out on its own.
2019-08-16 09:32:07 -04:00
Jay Krell 4d9e6ae20e [interp] Fix more MonoError reuse (mono_object_new_checked). (#16263)
* [interp] Fix more MonoError reuse (mono_object_new_checked).

* Inline mono_interp_new/mono_object_new_checked now that we are in outlined mono_interp_newobj.
2019-08-16 16:26:49 +03:00
Steve Pfister da2c0159e9 [corlib] Fix sharing mode validation rules (#16247)
Fixes https://github.com/mono/mono/issues/16032

When we switched to corefx File.Copy on unix, the behavior changed where it opened a source and destination stream in order to pass the safe handles to Interop.Sys.CopyFile. This exposed a flaw in our sharing validation rules in MonoIO.Open, which threw an exception in this scenario:

new FileStream("source.txt", FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.ReadWrite, 2048, FileOptions.DeleteOnClose);
new FileStream("source.txt", FileMode.Open, FileAccess.Read, FileShare.Read, 2048, FileOptions.None);

Simplified the FileShare check down to:

1. If the caller specifies FileShare.None, then it's an exclusive lock and no
   sharing is allowed.

2. If the caller specifies some other FileShare option, then FileShare.None
    cannot be specified.
2019-08-16 07:52:22 -04:00
Egor Bogatov 4dca4f6619 [netcore] Add patch-local-dotnet-aot-llvm rule (#16120)
* Add patch-local-dotnet-aot-llvm rule

* Update Makefile

* Add run-sample-local-dotnet-llvm
2019-08-16 12:43:08 +02:00
Jay Krell 0c637a73a9 intepreter: remove last element from various arrays (#16134)
add const
 combine lines for searchability
2019-08-16 11:37:20 +03:00
Jay Krell 35fc20b637 [interp] Fully outline enum_hasflag to save stack. (#16228)
Alternative to https://github.com/mono/mono/pull/16197.
If you are going outline, you sometimes might as well take it all with you
instead of bouncing back and forth for a partial inlining.
2019-08-16 10:13:22 +03:00
Zoltan Varga 5461fb78c7 Merge pull request #16261 from vargaz/tp-no-random
[runtime] Use a PRNG in the threadpool instead of the os random number generator.
2019-08-15 23:48:35 -04:00
Jo Shields b6c499631e Exclude Authenticode tests on Watch (#16278)
1002a4de2b added Authenticode cert support on non-WatchOS. The tests,
however, were not non-WatchOS-only. Fix this, so Watch doesn't try to
run Authenticode tests.
2019-08-15 22:07:18 -04:00
Zoltan Varga 764091677e Merge pull request #16257 from EgorBo/llvm-ptr
Align C# pointers with LLVM pointers for primitive types
2019-08-15 21:59:42 -04:00
Jay Krell 6c05cfab59 [mini] Cleanup alloca: call twice instead of once, and shrink allocation slightly. (#16158)
It is an actual function call at least on Windows.
2019-08-15 18:14:37 -04:00
Jay Krell b654aa1ca8 [interp] Fix more MonoError reuse. (#16262) 2019-08-16 00:06:50 +02:00
Jay Krell dfbf1a1bd3 [Coop] Convert emit_invoke_call. (#15964)
Removing calls to mono_string_new_checked.
Extracted from https://github.com/mono/mono/pull/15900.
2019-08-15 17:56:33 -04:00
Jay Krell 44ff0597b8 Wrap more external-only functions in GC mode transitions. (#15895)
mono_compile_method
mono_runtime_set_main_args
mono_runtime_run_main
mono_runtime_exec_managed_code
mono_load_remote_field
mono_load_remote_field_new
mono_store_remote_field
mono_store_remote_field_new
2019-08-15 17:48:18 -04:00
Zoltan Varga 870aec4aad Llvm optimizations (#16191)
* [jit] Disable inlining for ThrowHelper methods for non-netcore as well. Add an OP_NOT_REACHED after calls to these methods to let LLVM know they don't return.

* [llvm] Use the cold calling convention instead of the preserveall one, it has the same effect and its better supported.

* [llvm] Call the aot init function using the cold cconv.

* [llvm] Make the condition in the poll function unlikely.

* [llvm] Add a wrapper around the GC poll icall so it can be called with a cold calling convention.

* Move the noreturn check before the code which is shared with calli.
2019-08-15 21:46:00 +02:00
Stephen Toub 133bdb5fa2 Fix non-ASCII characters across corefx (dotnet/corefx#40318)
* Fix several non-visible characters in test files

* Replace Unicode surrogate pairs with escaped hex values

* Fix non-ASCII characters in most C# files

Signed-off-by: dotnet-bot <[email protected]>
2019-08-15 21:44:47 +02:00
Jo Shields 4ec4d7a3b3 Add missing FCONV_TO_U8 on ILP32 (WatchOS 5) (#16276) 2019-08-15 13:56:04 -04:00
Jay Krell 7b64f1cd00 Retain thread names as UTF8 instead of only UTF16. (#15945)
Windows can still have its Unicode thread names, since we have UTF16 initially, just don't retain it.

This does penalize ves_icall_System_Threading_Thread_GetName_internal (non-netcore only),
which has to convert back to UTF16 each time.

But seems like a net win overall.

There is also a little prep work here for constant thread names and some temporary measures as multiple changes head toward the same code.

Rename `mono_thread_set_name_internal` to `mono_thread_set_name`.
Close possible race conditions.

Extracted from https://github.com/mono/mono/pull/15859.
2019-08-15 19:37:34 +02:00
Jay Krell f35c755fea [interp] Outline newobj and newobj_vt. (#16267)
In this variation, the exception handling and resume are split between the main function and the helper function, and no address-taken occurs on ip/sp/vt_sp.

The order is a little tangled but convincing.
The helper function returns MonoException* or checks context->has_resume_state and then returns, and then the caller does the checks again.

Based on past analysis this will conserve stack, but that was not double checked here.
i.e. due to `&valuetype_this`, though it is conditional and the code could be split up into inline and outline.
2019-08-15 19:23:24 +02:00
Egor Bogatov 2f7a06d208 [netcore] Mark "Run Tests" step as failed if there are failures (#16230)
Currently "Run CoreFX tests" step is always green
2019-08-15 18:06:15 +02:00
Jo Shields dd6bd568a0 Fix failing OSX Android lane (#16274)
Linker order matters when using .a files, so zlib.a MUST come after
sgen.a if sgen.a was compiled with support for compressed ppdb
2019-08-15 10:37:04 -04:00
Vlad Brezae 6fc089bf8b [exceptions] Don't debug hang on ThreadAbortException (#16240)
It is pretty much useless.
2019-08-15 14:57:26 +03:00
Jay Krell 63e1828f7e Reduce redundant setting of thread name. (#16253)
Maintain a counter and only set if the counter has changed.
This cannot be fully thread safe, so is not.
Any thread can set any other thread name at any time.
You could be atomic to do better, and loop to do even better,
but the thread name could still be changed again right after the loop exists.

The previous code was also not reliable in this way, since again the name
could be changed right away.

#16248
2019-08-15 10:56:38 +02:00
Jay Krell 5ec452666a [interp] [wasm] p vs. o on newobj (#16264) 2019-08-15 10:42:11 +02:00
Jay Krell fd4956fbf2 [interp] Fix some, not all, of the error management. (#16232)
From #16190.
2019-08-15 10:41:49 +02:00
Jay Krell 7766f9b926 [interp] Short-circuit MINT_STELEM_REF on NULL. (#16229)
Presumably this is not a useful semantic change,
to skip those functions, given NULL.

(We will probably want to outline all of this also, later).
2019-08-15 10:39:45 +02:00
Jay Krell fc724e6cf0 [interp] Compute locals later to reduce register/stack pressure and conserve stack. (#16231)
i.e. do not def before a function call and use after, do both after.
2019-08-15 10:39:27 +02:00
Jay Krell dde3452690 [interp] Split leave into pieces, partially outlined, to conserve stack, (#16213)
but without changing how exception handling macros access labels and locals.

This saves 16 bytes of stack on Linux/amd64/gcc and likely similar everywhere,
as it takes an address-taken local out of interp_exec_method_full (stackval tmp_sp).

See
https://github.com/mono/mono/pull/16171
https://github.com/mono/mono/pull/16171/commits/a6a8f0d5ffa875da9cda63444e401c37810a690f for a
full outlining.
2019-08-15 10:39:03 +02:00
Nikolay Sivov 5b66d3d518 [cominterop] Fix copy-paste error in ComVisibleAttribute testing helper.
This type was introduced with 29a95bafd8.
2019-08-15 09:29:14 +02:00
Thays Grazia dcfec3966c Enable and document debug with sdb with netcore config. 2019-08-15 09:23:02 +02:00
Zoltan Varga 928aab1b84 [runtime] Use a PRNG in the threadpool instead of the os random number generator, its good enough, and its much faster. 2019-08-15 02:14:06 -04:00
Egor Bogatov 93eceec724 address feedback 2019-08-15 02:39:13 +03:00
Jay Krell 2463605f01 Remove ampersand from cfg->error per old agreement. (#16219) 2019-08-15 01:07:56 +02:00
Martin Baulig 934c4f4c87 X509CertificateImplBtls.PrivateKey should allow to actually set the key. (#16212)
The `X509CertificateImplBtls.PrivateKey` property setter was previously ignoring all values and always used `null`.  This should help with #16189.
2019-08-15 01:07:35 +02:00
Egor Bogatov ed4be03b79 handle primitive pointers in llvm 2019-08-15 01:38:58 +03:00
Vlad Brezae 4e793ad30c [interp] Fix icall signature (#16227) 2019-08-15 00:18:45 +03:00
Jo Shields f2d813c90d Fix linking of OS-provided zlib (#16177)
* Fix linking of OS-provided zlib

This is a reduced version of https://github.com/mono/mono/pull/16091
without the Z_PREFIX stuff

* Get rid of HAVE_ZLIB, be explicit about HAVE_SYS_ZLIB vs HAVE_STATIC_ZLIB

* Proposed fixes from Alex
2019-08-14 16:58:07 -04:00
Stephen Toub a103b78163 Delete dead _pauseTicks from TimerQueue (dotnet/coreclr#26160)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-14 21:19:04 +02:00
Jan Kotas e46b3efbd0 Undo readonly on _isLastFrameFromForeignExceptionStackTrace
This makes the field symmetric with other fields and fixes build break for CoreRT

Signed-off-by: dotnet-bot <[email protected]>
2019-08-14 21:19:04 +02:00
Aleksey Kliger (λgeek) ce92c4376f [metadata] Create strongly typed versions of mono_assembly_request_prepare (#16094)
* [metadata] Create strongly typed versions of mono_assembly_request_prepare

Addresses the family of issues similar to Coverity #1443346.

This came up as part of the Coverity review, and Coverity notices that this is
writting beyond the end of the structure.  While this is correct, this requires
that the idiom be properly followed - that is, that the structure being passed
is of the given size.

Replaced instead with a method that eliminates the room for error with methods
that will initialize the whole structure, and the actual size computation is
done inside the method with the proper type sizes.

While I used methods, I feel that this should use macros.
2019-08-14 15:07:26 -04:00
Aleksey Kliger (λgeek) a6b8494f0a (mono.1) Update the MONO_THREADS_SUSPEND description (#16236) 2019-08-14 19:23:36 +02:00
lateralusX 2d06126dc9 OP_LLVM_OUTARG_VT doesn't always create temporary vt needed by some ABI's.
LLVM lowering passes vt as reference to managed methods. On platforms where
the value type ABI is passing an address to the value type, either in register
or on stack (Windows x64) we must make sure we always use a temporary of
the value type or we will be breaking the value type semantics.

In JIT lowering of OP_OUTARG_VT we always make sure we use a temporary
in cases where argument storage is set to ArgValuetypeAddrInIReg/ArgValuetypeAddrOnStack.
On LLVM lowering this was currently not the case, but it still worked in many scenarios.
This was because IL load of arguments before doing a call did a
local copy and then we pass that byref. However, there are cases where this
copy could get optimized away and when that happens, we will change the
local value type in the caller’s frame, breaking the value type semantics.

Added test case in winx64structs hits such a scenario that will generate IL
breaking the value type semantics before the fix:

...
notail call monocc void @winx64_vector3Struct_Add_winx64_vector3Struct_winx64_vector3Struct
(i64 %49, %winx64_vector3Struct* %3, %winx64_vector3Struct* %16)
...
notail call monocc void @winx64_vector3Struct_Add_winx64_vector3Struct_winx64_vector3Struct
(i64 %64, %winx64_vector3Struct* %3, %winx64_vector3Struct* %15)
...

The two add calls will use the same reference (to a local value type in caller frame)
on both calls, this will break the value type semantics since they should both
be temporaries, like second argument is.

After the fix, the same code will be lowered into:

...
notail call monocc void @winx64_vector3Struct_Add_winx64_vector3Struct_winx64_vector3Struct
(i64 %55, %winx64_vector3Struct* %19, %winx64_vector3Struct* %18)
...
notail call monocc void @winx64_vector3Struct_Add_winx64_vector3Struct_winx64_vector3Struct
(i64 %72, %winx64_vector3Struct* %16, %winx64_vector3Struct* %15)
...

Each argument gets its own temporary that, according to the ABI, gets passed
by address down to function.

There will be situations where we could end up with two temporaries, one from
the load and one from the lowering of OP_LLVM_OUTARG_VT (same as we get on JIT),
this will however be detected by LLVM optimization pass, removing one of the copies.
2019-08-14 19:23:32 +02:00
Egor Bogatov abb43f9361 ignore stacktrace tests 2019-08-14 14:33:44 +02:00
Jay Krell d1c0974e46 [interp] Reduce frame size by partially outlining load remote field. (#16196)
Extracted from https://github.com/mono/mono/pull/16171.
Ultimately over 100 bytes can be saved.

Tactically not outlined or indirected:
 vt_sp change
 ip advancement
 error handling

 Also partially fixes the error reuse from https://github.com/mono/mono/pull/16190.
2019-08-14 12:34:54 +02:00
Jay Krell 60ac98ee29 Make small_id_mutex not recursive. (#15485)
(Later non-recursive Windows mutexes should be SRWLOCK and only statically initialized.)
2019-08-14 12:33:58 +02:00
Jay Krell 8c5d0a790e Use ERROR_DECL. (#16220) 2019-08-14 12:28:00 +02:00
Jay Krell 74b0d01e07 [interp] Remove address-taking of vt_sp. (#16215)
Theoretically could help reduce frame size but it has not been seen to.
2019-08-14 12:27:22 +02:00
Zoltan Varga 4c71a3e892 [wasm] Disable running xunit test suites on wasm, its not working reliably yet. (#16223) 2019-08-14 12:26:31 +02:00
Jay Krell 4c17442dc3 [interp] Outline mono_interp_calli_nat_dynamic_pinvoke to reduce stack. (#16201)
Now that we have that function, also change from malloc to alloca.

This is part of #16171 and ultimately over 100 bytes were saved.
2019-08-14 12:25:44 +02:00
Jay Krell 136205ab45 Completely replace mono_error_ok with is_ok and make first external_only. (#16217) 2019-08-14 12:24:50 +02:00
Jay Krell 12de10007c Skip degenerate qsort: num < 2, size == 0, base == 0 (#16016)
Fixes https://github.com/mono/mono/issues/15994

Some is redundant for some qsort implementations.
2019-08-14 12:22:40 +02:00
Jay Krell 6873d5370d Fix warning LNK4221 warning in assembly-load-context.obj (#16004)
LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library
2019-08-14 12:19:08 +02:00
Jay Krell 9123ac0197 [interp] Outline get_virtual_method_fast to save 16 bytes of stack. (#16198)
Ultimately over 100 bytes are savable in a few steps.
2019-08-14 12:17:23 +02:00
Jay Krell dbf13301c8 [interp] Outline set_resume_state to conserve stack in main interpreter loop (#16200)
This is not intuitive but I definitely saw it.
2019-08-14 12:17:01 +02:00
Marek Safar 9ee80c6d3b Bump linker 2019-08-14 10:17:54 +02:00
Stephen Toub 3803a00421 Fix StyleCop warnings for rules enabled in corefx
Signed-off-by: dotnet-bot <[email protected]>
2019-08-14 10:15:38 +02:00
Thays Grazia f812d90fa1 [debugger] Debugger tries to execute a single step when the thread is already terminated (#16208)
* Debugger tries to execute a single step when the thread is already terminated.

* Fixing how to get thread tls.
2019-08-13 22:47:28 -03:00
Stephen Toub 50d3fc69d8 Convert several static readonly byte[]s to ReadOnlySpan<byte> (#26138)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Stephen Toub 9e13a7e097 Fix IDE1005 (simplify delegate invocation)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Stephen Toub db4441bfe7 Fix IDE0062 (make local functions static)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Stephen Toub 15ea431db7 Contribute to IDE0060 (unused argument)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Stephen Toub d927c98e03 Contribute to IDE0059 (unnecessary assignment)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Stephen Toub d82bc555c9 Contribute to IDE0019 (use pattern matching) and IDE0066 (use switch expression)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Stephen Toub e19d95b6de Contribute to IDE0044 (make field readonly)
I used the auto-fix and then undid changes in areas where the fields were potentially mutated in native, e.g. I undid many of the changes in reflection.  We can revisit those individually later.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Stephen Toub 6c95cbadf9 Fix StyleCop warning SA1400 (missing access modifiers)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Stephen Toub 0814b9de4d Enable StyleCop rules 1205, 1411, 1026, and 1000 (dotnet/corefx#40254)
* Fix StyleCop warning SA1411 (attribute ctor shouldn't use unnecessary parens)

* Fix StyleCop warning SA1026 (new[] spacing)

* Fix StyleCop warning SA1000 (consistent spacing around if, for, switch, etc.)

* Fix StyleCop warning SA1205 (partial elements should declare an access modifier)

Signed-off-by: dotnet-bot <[email protected]>
2019-08-13 21:35:04 +02:00
Egor Bogatov 6c51440538 auto-detect cpu in llvm jit 2019-08-13 22:24:54 +03:00
Aleksey Kliger (λgeek) 592de53a1f [runtime] Initialize thread suspend policy at startup, inline getter (#16149)
* [runtime] Initialize thread suspend policy at startup, inline getter

On some benchmarks we saw mono_threads_suspend_policy() using a lot of CPU
time.

Rather than doing an init-on-first-use, initialize the policy once upfront when
the JIT it starting up and make the getter method static inline.

* move mono_threads_suspend_policy_init into mono_thread_info_init

* [mini] Initialize suspend policy for `mono --version`

Need to initialize the suspend policy before printing its name.  Otherwise the
suspend policy is unset since no other runtime initialization is done for `--version`.
2019-08-13 15:16:05 -04:00
Alexander Köplinger ff77b427f4 [netcore] Cleanup System.Private.CoreLib.csproj (#16199)
- The eng/Versions.props was already imported by the arcade targets causing a double-import warning:

> warning MSB4011: "/Users/alexander/dev/mono/eng/Versions.props" cannot be imported again. It was already imported at "/Users/alexander/.nuget/packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.19379.1/tools/DefaultVersions.props (17,3)". This is most likely a build authoring error. This subsequent import will be ignored.

- Remove BaseAddress and TRACE from the project file, this was done upstream at https://github.com/dotnet/coreclr/commit/bc430cdd2010bf7790854a60380d00c506c346a6

- Remove unecessary DebugSymbols/DebugType settings, we already set them in the global PropertyGroup
2019-08-13 16:41:03 +02:00
Aleksey Kliger (λgeek) 1f4ac5d767 [sre] Outline typebuilder_setup_fields loop body (#16184)
The loop body uses coop handles, so wrap it in HANDLE_FUNCTION_ENTER/HANDLE_FUNCTION_RETURN
2019-08-13 09:31:31 -04:00
Jay Krell ef199425a2 [interp] Replace mono_error_ok with is_ok. (#16193)
The locally unknown function, despite being small/fast, forces saving values in stack and nonvolatile registers
around calling it.
Both nonvolatile registers and stack are at a premium here, whereas usually stack is cheap.
The macro is just a read from offset 0 and checking for zero.
2019-08-13 15:30:28 +02:00
Alexander Köplinger b60aaea791 [pkg] Bump libgdiplus to 6.0.2 2019-08-13 12:12:22 +02:00
Egor Bogatov c36f0a126e [netcore] decimal should have alignment=8 (#15666)
* Fix System.Runtime.InteropServices tests

* Update marshal.c

* Update marshal.c

* Update marshal.c
2019-08-12 21:57:47 +02:00
Zoltan Varga 5bc4944bf0 Merge pull request #16151 from spouliot/ios-intr-enable-sre
[sdk] Enable the SRE runtime code inside iOS builds
2019-08-12 14:44:54 -04:00
Stephen Toub b25395bde3 Re-enable StyleCop warning SA1400 (elements should specify access) (#40240)
One of the more common things we "nit" in PRs.  Now the compiler will flag it for us.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-12 19:46:54 +02:00
Aaron Robinson 66f7436d6f Remove unnecessary error check for QueryUnbiasedInterruptTime call (#26120)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-12 19:46:54 +02:00
Stephen Toub 4f821c3e8d Enable FxCop and StyleCop analyzers (dotnet/coreclr#26100)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-12 19:46:54 +02:00
Aleksey Kliger (λgeek) ad64c781eb [interp] Fix stub_get_resume_state write to out parameter (#16145)
Addresses Coverity CID 1452245
2019-08-12 13:09:59 -04:00
Ryan Lucia cadd114f64 [netcore] Pass MONO_ASMCTX_LOADFROM on LoadFrom calls (#16075) 2019-08-12 11:46:12 -04:00
Ankit Jain c028454bef [msbuild] Bump to track xplat-master and update roslyn (#16155)
Prompted by mono/msbuild#126:

This includes:

- merge mono-2019-06
- SDK update to track dotnet release/3.0.100-preview8
- Roslyn updated to 3.3.0-beta2-19381-14
2019-08-12 17:03:13 +02:00
UnknownShadow200 69ebdd8b93 [WinForms] Fix NotifyIcon not showing in systray on 64bit linux (#16164)
https://bugzilla.xamarin.com/show_bug.cgi?id=14976

Credit goes to datnhanlz for noting that removing XChangeProperty(DisplayHandle, hwnd.whole_window, _XEMBED_INFO, _XEMBED_INFO, 32, PropertyMode.Replace, atoms, 2); would also fix the bug. 

Note that the type of Atom is actually unsigned long (see usr/include/X11/X.h), however the code used a C# int for the atoms. As such the code worked without a problem on 32 bit linux, but broke on 64 bit linux.

I switched to using IntPtr instead to make the code also work on 64-bit.
2019-08-12 16:09:08 +02:00
Aleksey Kliger (λgeek) dd3f6e0d31 [debugger] Cleanup MonoError on in isFixedSizeArray (#16146)
Cleanup MonoError on error paths.  Also change `return FALSE` to `return 0`.

Addresses Coverity CID 1452205
2019-08-12 09:50:58 -04:00
Nikolay Sivov 612e0644b6 [mono] Fix some compiler warnings (#16159)
* [mini] Remove unused variables.

* [mini] Remove unused function.

Single call site is conditionally compiled.

* [sgen] Remove unused variable.

* [utils] Fix misleading indentation warnings.
2019-08-12 12:42:59 +02:00
Nikolay Sivov f9052ed78e [System.Drawing] Use CoreFX implementation of BufferedGraphics on Windows (#16163)
The issue was made visible with .NET Core WinForms. Some controls draw text with DrawTextEx to intermediate Graphics based on Bitmap, that later it's moved back to main Graphics with DrawImage. This results in a lost of transparency component along the way, making antialiased glyph bitmaps draw and B/W. Corruption is visible with gray antialiasing, but is more severe in subpixel modes.

I verified that same happens with gdiplus on Windows, code from CoreFX works correctly.
2019-08-12 12:42:07 +02:00
Jay Krell c70b4cc3cc [remoting+interp] [remoting+debugger] Fix use of dangling local. (#16173) 2019-08-12 12:35:30 +02:00
Jay Krell 4e5544f02d [interp] Remove unnecessary loops, that optimizer might handle. (#16169) 2019-08-12 12:34:46 +02:00
Vincent Povirk 7413bb84ec [w32process-win32] Don't duplicate CreateProcess search logic. (#16156)
When given a null application name, CreateProcess already
searches the path and appends .exe in some cases. .NET's
Process class behaves in the same way (see
https://github.com/mono/mono/pull/16089#issuecomment-519984244).

The duplicated logic is unnecessary and broken in several ways.
Failures are ignored and the command line arguments are
executed. Relative paths are expected not to end in "exe".
Many corner cases work differently from .NET and CreateProcess.

This change makes it impossible for process_complete_path to fail,
so I removed the gboolean return and pulled out the output
parameter. Its caller wasn't handling the return value correctly
anyway.
2019-08-12 12:05:05 +02:00
Zoltan Varga 835282004c Merge pull request #16136 from EgorBo/fix-inlining
[netcore] Fix inlining
2019-08-11 22:32:01 -04:00
Zoltan Varga 7c511c9937 Merge pull request #16160 from vargaz/wasm-xunit-4
[wasm] Xunit testing work.
2019-08-10 22:56:05 -04:00
Alexander Köplinger ec73f9ba17 Bump corefx to fix build break 2019-08-10 23:45:11 +02:00
Zoltan Varga c6054d5aa1 [wasm] Run System.Core xunit tests on CI. 2019-08-10 15:18:26 -04:00
Zoltan Varga 95b705d8c1 [wasm] Add argument conversions to the xunit runner. 2019-08-10 15:18:26 -04:00
Alexander Köplinger 738b6988b5 Bump corefx to get https://github.com/mono/corefx/pull/327 2019-08-10 16:19:01 +02:00
Nikita Voronchev 000430002a [System.Drawing.Design] Allow context be a null in the ColorEditor.EditValue (#16141)
If one call `ColorEditor.EditValue(IServiceProvider, Object)` ([MSDN](https://docs.microsoft.com/ru-ru/dotnet/api/system.drawing.design.uitypeeditor.editvalue?view=netframework-4.8#System_Drawing_Design_UITypeEditor_EditValue_System_IServiceProvider_System_Object_)), then `context` is `null` and drop-down menu doesn't appear.
2019-08-10 16:01:37 +02:00
Sebastien Pouliot 360c1c44c7 [sdk] Enable the SRE runtime code inside iOS builds
This will allow the interpreter to use System.Reflection.Emit.

Note: There is a small size increase (about 50kb) for an application
built in release mode with the LLVM backend (even if the interpreter
is now used).
2019-08-09 13:57:54 -04:00
Vlad Brezae b52830cf11 [interp] Fix overflow of execution stack (#16115)
We were not tracking max_stack_height for a few opcodes.
2019-08-09 20:28:30 +03:00
Zoltan Varga 54c07051a8 Merge pull request #16139 from steveisok/run-single-ios-sdk-test
Added the option to run a single test in the iOS SDK
2019-08-09 12:58:01 -04:00
Ryan Lucia a1bb37cd52 [netcore] Make mono_assembly_request_prepare take an ALC (#16061)
* Make mono_assembly_request_prepare take an ALC

* Typo

* Fix pedump

* Use default ALC

* Make v1 preload hook external-only

* Convert pedump and monodis

* fixup: use default ALC in netcore preload hook

trusted platform assemblies should be loaded into the default ALC
2019-08-09 11:44:50 -04:00
Alexander Köplinger 0970996f75 Bump eng/Versions.props again
Try to fix the netcore build.
2019-08-09 17:03:12 +02:00
Alexander Köplinger 75c21692a0 Add mono-hang-watchdog.in to tarball
Remove custom distdir target and use standard EXTRA_DIST to do so.
2019-08-09 16:48:16 +02:00
Stephen Toub 86a0ad2f88 Fix FxCop warning CA1823 (unused fields)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub f39ac1d32d Fix FxCop warning CA2229 (private deserialization ctor)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub 2d3a6ea2bb Fix FxCop warning CA1825 (Array.Empty)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub cce1583769 Fix StyleCop warning SA1620 (generic XML comment ordering)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub 15963fe836 Fix StyleCop warning SA1617 (void return XML comment)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub 4ce53c845b Fix StyleCop warning SA1113 (comma position for parameters)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub 442e9ad144 Fix StyleCop warning SA1206 (modifer ordering)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub 01fa50943f Fix StyleCop warning SA1121 (use built-in types)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub 9c3037fc59 Fix StyleCop warning SA1200 (cref prefixes)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub 1fcf7a1ab4 Fix StyleCop warnings SA1028 and SA1518 (trailing whitespace and blank lines)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Stephen Toub 441257339f Fix FxCop warning CA1018 (attributes should have AttributeUsage)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 16:23:42 +02:00
Alexander Köplinger 74338e0f2d Bump corefx to get https://github.com/mono/corefx/pull/323 2019-08-09 16:21:12 +02:00
Alexander Köplinger 09e7c4509c Update dependencies from corefx (#16137) 2019-08-09 15:19:16 +02:00
Steve Pfister 9e9697c978 Added the option to run a single test in the iOS SDK 2019-08-09 09:10:13 -04:00
Alexander Köplinger f15fe47075 [build] Remove ILDISASM variable from platform Makefiles
It was written by configure.ac to config.make and is unused anyway.
2019-08-09 12:53:14 +02:00
Alexander Köplinger 652f6c64b6 [build] Remove PLATFORM_CORLIB from platform Makefiles
Changing the corlib assembly name isn't supported anywhere else in the build.
2019-08-09 12:53:14 +02:00
Alexander Köplinger e80f3449da [build] Remove MBAS from the platform Makefiles
It no longer exists.
2019-08-09 12:53:14 +02:00
Alexander Köplinger 8697b31082 [build] Remove EXTERNAL_MCS setting in platform Makefiles
Setting an explicit mcs is no longer supported by the rest of the build scripts.
2019-08-09 12:53:14 +02:00
Alexander Köplinger d7174c9aa6 [build] Remove confusing commented out code 2019-08-09 12:53:14 +02:00
Alexander Köplinger ab1d61509d [build] Remove PLATFORM_MAKE_CORLIB_CMP
The corlib_cmp doesn't exist anymore.
2019-08-09 12:53:14 +02:00
Alexander Köplinger 3e77e01071 [build] Replace PLATFORM_ ifdefs with HOST_PLATFORM checks
Building Linux BCL assemblies from a macOS machine didn't work since we
were enabling some Apple features if the build machine was macOS.
2019-08-09 12:53:14 +02:00
Alexander Köplinger 175e345122 [tools] Add .gitignore for mono-hang-watchdog 2019-08-09 12:39:34 +02:00
Stephen Toub 67a89b3a6f Move CodeAnalysis.ruleset to shared (dotnet/corefx#40153)
So that the same settings can be applied to corelib.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 12:30:05 +02:00
Egor Bogatov a7e428d82f fix inlining 2019-08-09 12:55:50 +03:00
Egor Bogatov 7deb53514d Make System.Runtime.Intrinsics.X86.*.IsSupported intrinsic 2019-08-09 09:34:29 +02:00
Egor Bogatov 9442ed95d7 fix minor issues 2019-08-09 09:34:29 +02:00
Alexis Christoforides 2c4b60fe24 [merp] Use a separate program as the hang supervisor. (#15715)
* [merp] Use a separate program as the hang supervisor.

Fixes https://github.com/mono/mono/issues/15646

macOS does not like signals being sent from the forked supervisor process, possibly towards anywhere but definitely when sent to the parent process. The following message is currently spewed after the supervisor process attempting to send a SIGSEGV to a hanged Mono process:
"The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec()."

We follow that direction and introduce a new binary that, when available in the mono executable's binary directory, is used to abort the parent process for us.
2019-08-09 10:31:57 +03:00
Ryan Lucia 6a459c25d7 [netcore] Don't return REFERENCE_MISSING in netcore_load_reference 2019-08-09 09:23:10 +02:00
Jeffrey Zhao a49ecebd4e Catch InvalidCastException properly in Collection (dotnet/coreclr#25953)
The explicit implementations of IList.Add/Insert/Set methods catch
InvalidCastException for casting input argument to type T to throw
an ArgumentException. The issue here is they put the core collection
modification operation in the try block, which could be overridden
by sub-classes and produce an InvalidCastException from user logic,
even the argument passed to IList.Add/Insert/Set is valid.

To fix the issue, we just need to move the collection modification
outside the try block, and leave the casting in try block only. In
this way, we'll get an ArgumentException when the argument type is
invalid, but propagate the InvalidCastException thrown from user
code as it should be.

dotnet/corefx#39919

Signed-off-by: dotnet-bot <[email protected]>
2019-08-09 09:22:28 +02:00
Zoltan Varga e71604d695 Merge pull request #16125 from vargaz/wasm-keep-config-cache
[wasm] Add a KEEP_CONFIG_CACHE option to Make.config to avoid deleting the autoconf cache file on make clean.
2019-08-09 03:20:03 -04:00
monojenkins 1369ebcfaf [bcl] Update BCL Linked Size 2019-08-09 09:19:32 +02:00
Alexander Köplinger fde0a5b628 [ci] Trigger PR builds for netcore only on master branch
The work is happening in master only for now.
2019-08-09 00:53:19 +02:00
Alexander Köplinger 6075417d88 Bump corefx so it points to correct branch 2019-08-09 00:14:18 +02:00
Alexander Köplinger ec35e14636 [tests] Fix accessing field of MarshalByRefObject in remoting1.cs (#16119)
We need to copy it to a local variable first.
This was exposed by a new Roslyn optimization for String.Concat (see https://github.com/dotnet/roslyn/issues/37830).
2019-08-09 00:07:41 +02:00
Stephen Toub da2c1cde97 Re-enable StyleCop warnings SA1028 and SA1518 (trailing whitespace and blank lines) (#40113)
Mechanical/automated change.  The only manual changes were a) removing the two rules from the CodeAnalysis.ruleset file, b) removing spaces from one line of a .targets file that is used to generate a .cs file, and c) reverting the changes in a few test files where the naive replacement happened in the middle of a verbatim string where the whitespace actually mattered.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-08 23:44:46 +02:00
Alexis Christoforides 1127974861 [System] Guard against attempting to creating out-of-range spans in macOS FileSystemWatcher 2019-08-09 00:24:06 +03:00
Zoltan Varga adeef6c0fc [wasm] Add a KEEP_CONFIG_CACHE option to Make.config to avoid deleting the autoconf cache file on make clean. 2019-08-08 17:08:51 -04:00
Aleksey Kliger (λgeek) 36af44e3be [perfcounter] Define mono_perfcounter_foreach even if perfcounters are disabled. (#16100)
Fixes netcore build on win32
2019-08-08 14:06:21 -04:00
monojenkins 18917b885c [csproj] Update project files 2019-08-08 19:10:03 +02:00
Marek Safar 2ef50f54ee Bump corefx for #15259 fix 2019-08-08 19:10:03 +02:00
Adam Sitnik b15518dd5e make DateTime.UtcNow 5% faster to minimize the leap second performance impact (#26046)
* make few methods used by DateTime.UtcNow inlinable to minimize the leap second performance regression impact, related to #25728

* apply suggested micro-optimizations

Signed-off-by: dotnet-bot <[email protected]>
2019-08-08 18:55:19 +02:00
Jan Kotas 7c59cd14fe Cleanup ProjectN ifdefs (dotnet/corert#7675)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-08 18:55:19 +02:00
Alexander Köplinger dfa5a6ce4d [aprofutil] Install the tool correctly (#16112)
It needed a few tweaks to be usable when Mono is installed to the prefix.
2019-08-08 16:46:55 +02:00
Steve Pfister 64ea10fbcd Fixed RuntimeType.GetConstructorCandidates("") to return 0 elements. (#16054)
https://github.com/mono/mono/issues/16010

The current behavior for GetConstructorCandidates when the name is null, "",
or "*" is to return the set of constructors for the type. For "", .NET Core and
.NET Framework return 0 elements.  This PR adds a check for "" to match that
behavior.
2019-08-08 12:14:39 +02:00
Stephen Toub c189afd4f5 Delete PROJECTN ifdefs from Corelib (dotnet/coreclr#26058)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-08 10:10:47 +02:00
Sung Yoon Whang 240202cd90 Improve ArgumentNullExceptions on DiagnosticCounter.DisplayName/Unit (#26035)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-08 10:10:47 +02:00
monojenkins 53b9c88795 [bcl] Update BCL Linked Size 2019-08-08 10:09:17 +02:00
imhameed fc4d234ef6 [sdb][interp] Use the interpreter's resume state to compute the IL offset in compute_frame_info. (#15936)
[sdb][interp] Use the interpreter's resume state to compute the IL offset in compute_frame_info.

This recovers the relevant bits of the "resume state" from the interpreter and uses that to recalculate the `il_offset` for the top frame.

Fixes https://github.com/mono/mono/issues/15687.
2019-08-07 20:05:55 -04:00
imhameed 4462f10fb6 [llvm] Explicitly check for errors when calling LegacyIRCompileLayer::addModule. (#16082)
[llvm] Explicitly check for errors when calling LegacyIRCompileLayer::addModule.

LLVM built with LLVM_ENABLE_ASSERTIONS=On will crash if errors are not
explicitly consumed.
2019-08-07 15:15:55 -04:00
Ryan Lucia aece3efc99 Relax locking (#15986)
* Remove usage of loader lock

Originally added in https://github.com/mono/mono/commit/c4cbd3b700eea52c84c68c9450d80357b3be681d but no longer relevant

* Make get_agent_domain_info lock-free and relax loader lock

* Syntax errors

* Undo first commit, other than the commit message

* Fixes
2019-08-07 14:17:19 -04:00
Marek Safar b3344fa0b2 Bump linker (#16014)
* Bump linker

* Bump api-doc-tools and add NEW_CECIL define to mdoc

* Bump linker

* Bump API snapshot submodule

* [csproj] Update project files
2019-08-07 19:37:19 +02:00
Sylvain 4780486237 Memcpy instead of memcpy1 in System.Buffer.MemoryCopy (void*, void*, long, long). (#16056)
In the same way it is done in System.Buffer.MemoryCopy (void*, void*, ulong, ulong).

Correct what appears to be a typo in System.MemoryCopy with "long, long" size arguments.

Consequently, copy is not done byte per byte for the last int.MaxValue bytes when MemoryCopy is called with long argument (most common case). This should provide noticeable performance increase.
2019-08-07 18:36:47 +02:00
Radek Doulik 1f2b37ed37 [aotprof-tool] Initial import of AOT profiler tool (#15384)
* [aotprof-tool] Initial import

Imported https://github.com/radekdoulik/aotprofile-tool and updated it
to use Mono.Profiler.Log

* [aotprof-tool] Added man page

* [aotprof-tool] Use the shortened name in README.md
2019-08-07 18:24:51 +02:00
Ryan Lucia dcd5715161 [netcore] Re-enable IsAssignableFrom test
This was fixed a while back but never removed from the exclusions
2019-08-07 17:27:35 +02:00
Zoltan Varga d18daefdbc Merge pull request #16085 from kjpou1/wasm-sdk-v0.2.0
[wasm][sdk] Bump SDK Version 0.2.0
2019-08-07 11:17:12 -04:00
Jay Krell e8d28feb1e There is no need to zero static data, and it is racy (#15699)
if there are multiple threads calling (unlikely).
This zeroing was made moot by 470354fa81 January 2019.
2019-08-07 10:40:57 -04:00
Thays Grazia e690fb0240 Allow generating DIM bitcode (#16070) 2019-08-07 11:06:56 -03:00
Kenneth Pouncey 4767c581c7 Update sdk version for tests 2019-08-07 15:57:45 +02:00
Alexander Köplinger 521d4c8395 [utils] Move MAP_ANONYMOUS check after sys/mman.h import
The flag is defined in that header on OSX. Followup to 2abe569ede
2019-08-07 15:54:09 +02:00
Aleksey Kliger (λgeek) aea457cdb3 [w32socket] Translate ELOOP and ENAMETOOLONG (#16039)
Translate to WSAELOOP and WSAENAMETOOLONG, respectively.

See https://docs.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2

Addresses part of https://github.com/mono/mono/issues/16024
2019-08-07 09:42:39 -04:00
Nikolay Sivov 10c5e6407e [trace] Improve enter/leave output formatting (#16036)
* [trace] Use specific integer types for return value traces.

* [trace] Improve argument list formatting for ENTER lines.

Return value changes are especially visible for bools, where currently 4 bytes integers are printed.
2019-08-07 15:05:44 +02:00
Kenneth Pouncey b0611a5ee9 Bump SDK Version 0.2.0 2019-08-07 14:59:53 +02:00
Nikolay Sivov d34381f72e [win32] Fix some compilation warnings (#15956)
* [mini] Remove unused variable.

* [mini] Mark win32 exception handling functions static.

* [mini] Remove unused variable.

* [mini] Suppress unused function warning.

* [metadata] Fix unused function warning for Win32 build.
2019-08-07 14:45:19 +02:00
iamphi 2abe569ede Fix compilation on OSX 10.9 (#14411)
Found solution from: 
https://github.com/eclipse/omr/issues/902#issuecomment-288559044
2019-08-07 14:42:57 +02:00
Alex Thibodeau 24bbb94b6b Swap bytes for tcp port number because windows API gives us port in network order. (#16030)
Addresses the FIXME in Win32IPGlobalProperties.cs :: FillTcpTable

Fixed Unity issue: issuetracker.unity3d.com/issues/ipglobalproperties-dot-getactivetcpconnections-return-different-port-numbers-when-compared-to-cli-netstat-a-output
2019-08-07 14:30:07 +02:00
Zoltan Varga ba1c949a24 [runtime] Fix an autoconf warning. (#16078)
[runtime] Fix an autoconf warning.

<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-08-07 06:06:00 -04:00
Vlad Brezae e702e8286f [interp] Fix DEBUG_INTERP build (#16057) 2019-08-07 12:47:41 +03:00
Marek Safar 25b84915e1 Remove code moved to shared partition 2019-08-07 09:48:03 +02:00
Stephen Toub c5027781de Remove some unused locals (dotnet/corefx#39956)
* Remove some unused locals

Trying out various analyzers, including one to flag unused locals.  There are more than this, but this is a first batch.  Some of these are just clean-up.  Others are saving unnecessary cost.  At least one appears to be a real functional bug.

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-08-07 09:48:03 +02:00
Stephen Toub 824351f49c Fix CounterGroup to use built-in types
Signed-off-by: dotnet-bot <[email protected]>
2019-08-07 09:48:03 +02:00
Aleksey Kliger (λgeek) b2ab9198d3 Move AssemblyLoadContext VM-invoked resolve methods to shared (#25989)
Share between CoreCLR and Mono

Mono began using a copy of these methods with
https://github.com/mono/mono/pull/15946

Signed-off-by: dotnet-bot <[email protected]>
2019-08-07 09:48:03 +02:00
Tanner Gooding 0378116ffc Updating Math.Round and MathF.Round to be IEEE compliant so that the intrinsic and managed form are deterministic. (#25901)
* Updating Math.Round and MathF.Round to be IEEE compliant so that the intrinsic and managed form are deterministic.

* Fixing the Math.Round and MathF.Round handling for values greater than 0.5 and less than 1.0

* Applying formatting patch.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-07 09:48:03 +02:00
John SalemandNoah Falk a76f6fa9b5 Allow for interface implementations in EventSource.WriteEventVarArgs (#25844)
* Allow for interface implementations in EventSource.WriteEventVarArgs

* Also account null ref types and nullable types

* fix error in comment and simplify first part of boolean logic

* Update src/System.Private.CoreLib/shared/System/Diagnostics/Tracing/EventSource.cs

Co-Authored-By: Noah Falk <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>
2019-08-07 09:48:03 +02:00
Ryan Lucia 022fc4ea37 [netcore] Set flag for processor arch when parsing assembly names 2019-08-07 09:22:04 +02:00
Bernhard Urban fe0f311a84 [arm] respect I1 and I2 on gsharedvt out transition (#16000)
[arm] respect I1 and I2 on gsharedvt out transition

In order to trigger the problem, we must call into gsharedvt code ("in" transition) and then escape the gsharedvt world ("out" transition). The bug happens in the latter. Also some other stars need to align (I haven't fully understood it), thus the repro is quite long.

The provided repro only triggers with LLVM, which we don't have enabled on CI yet: https://github.com/mono/mono/issues/15999

Fixes https://github.com/mono/mono/issues/15261
Fixes https://github.com/mono/mono/issues/15262
Fixes https://github.com/mono/mono/issues/15263
Fixes https://github.com/mono/mono/issues/15307
2019-08-06 18:25:51 -04:00
Zoltan Varga add830f9cb Merge pull request #16071 from vargaz/wasm-xunit-3
[wasm] More xunit fixes.
2019-08-06 17:57:22 -04:00
Zoltan Varga 476af240d2 [wasm] Compile interp.c with -mllvm -join-liveintervals=false to fix compilation times. 2019-08-06 16:46:19 -05:00
Jay Krell 9bf703b031 [Coop] Convert mono_object_isinst_icall. (#15963) 2019-08-06 15:26:55 -04:00
Zoltan Varga 59a285a546 [wasm] More xunit fixes. 2019-08-06 15:24:32 -04:00
coypoop 5a4283d1b3 Update NetBSD support (#15938)
Based on the FreeBSD variation.
Needs some additional changes I'm still ironing out.
2019-08-06 20:32:38 +02:00
Ryan Lucia 64bf7ef9db [netcore] Update test exclusions to reflect ALC work (#16059) 2019-08-06 14:08:18 -04:00
Zoltan Varga 3c88e9f251 [netcore] Avoid calling load hooks during AOT.
Fixes https://github.com/mono/mono/issues/16046.
2019-08-06 19:40:23 +02:00
Zoltan Varga 662b72f913 Merge pull request #16058 from vargaz/wasm-requests-2
[wasm] Update WASM-REQUESTS.md.
2019-08-06 12:53:44 -04:00
Zoltan Varga dda05d0a09 [wasm] Update WASM-REQUESTS.md. 2019-08-06 10:48:42 -04:00
Egor Bogatov 0fbc5d8315 DeflateStream: check IsInvalid before disposing (#16048) 2019-08-06 14:53:24 +02:00
Ryan Lucia 85296ef1be [netcore] Make the load hook ALC-aware (#16012)
The meat of this PR is what the title suggests, and with this commit all the basic ALC functionality should be working properly. Probably worth checking if this makes any new tests pass.

Additionally, this PR includes a second commit that switches over the search hook to use loaded_assemblies from the ALCs. This may break some existing tests due to remaining unimplemented ALC behavior, notably the native loading mechanism needed for Openssl in some of the cryptography tests. My inclination is to include the commit regardless and just disable the failing tests so that any future ALC work can watch for regressions in the loader, but I would appreciate input from steveisok on how important those tests are. I've not disabled anything yet in order to see exactly what new failures are introduced.
2019-08-06 12:16:15 +02:00
Jay Krell 474092add6 UWP now allows LoadLibrary. (#16015) 2019-08-06 12:14:38 +02:00
Martin Baulig 1c13b30225 SocketAsyncEventArgs cleanups and preparations for the real thing. (#16001)
Cleaning up the `SocketAsyncEventArgs` class and preparing it for it's eventual
adaption from CoreFX.

There are a few instance fields and property accessors with `internal` visibility,
which the CoreFX version does not have.  Replaced these with accessor methods.

The `PolicyRestricted` property and it's related `SocketAsyncEventArgs (bool)`
constructor is not used anywhere and the CoreFX version has a constructor with the
same signature, but different semantics.

In the CoreFX version, `Complete ()` does not call `DoComplete (this)` - renamed it
into `Complete_internal ()` to avoid any ambiguities and help the transitioning.
2019-08-06 12:13:40 +02:00
Alexander Köplinger 7ab3811b93 Bump api-doc-tools to latest master (#16035)
* Bump api-doc-tools to latest master

Disable building mdoc.exe in mcs mode since it no longer builds because of new C# features.

* Fix mcs build by disabling more mdoc invocations

* Bump monodroid_tools to compile against v4.7 reference assemblies

mdoc needs ValueTuple which is not in v4.6.

* [csproj] Update project files
2019-08-06 10:40:24 +02:00
Zoltan Varga d57f3f55f0 Merge pull request #16043 from kjpou1/wasm-sdk-small-fix
[wasm][sdk] Fix misspelling and trailing comma
2019-08-06 02:29:20 -04:00
Kenneth Pouncey ca51e5b5cc Fix misspelling and trailing comma 2019-08-06 07:30:47 +02:00
Zoltan Varga 9b4bc613e4 Merge pull request #16006 from vargaz/as-gsharedvt
[jit] Avoid asserting on Unsafe.As<T> in gsharedvt methods.
2019-08-05 21:04:44 -04:00
Kenneth Pouncey 69aa5dcaa7 Fix indentation 2019-08-05 15:03:08 -05:00
Kenneth Pouncey 357a3aaec5 [wasm][sdk] Fix issue with WasmLinkAssemblies task wrongly using reference assemblies
The issue is that when executing the `WasmLinkAssemblies` task the reference assemblies are currently used as input to the linker step and output in the published application instead of the actual framework library file.

My findings so far on this is that the package references are resolved in the MSBuild [ResolvePackageAssets](https://github.com/dotnet/sdk/blob/master/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs#L205.)

Those are then remapped from [here](https://github.com/dotnet/sdk/blob/ec9f5fc673f798dd6a89c7d11a4e62727837757c/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.PackageDependencyResolution.targets#L270) to the `RuntimeCopyLocalItems`.

What I did was pass the `RuntimeCopyLocalItems` to the `WasmLinkAssemblies` task and do a remap to the runtime versions.  This works against everything I have thrown at it so far.

Of course this could fail if the nuget has somehow set `copy to local` false maybe but I do not see anything in the code referenced above checking for that.
2019-08-05 15:03:08 -05:00
Jo Shields c8c52f7e9f Bump version to 6.7 (#16031)
* Bump version to 6.7
2019-08-05 15:31:47 -04:00
Alexander Köplinger 807e4b3d6f [ci] Disable 32bit llvm sdks build
It was removed in https://github.com/mono/mono/commit/a6e6c72c8fc3702db37e1572694a49902f63195f
2019-08-05 21:29:51 +02:00
Kenneth Pouncey ac80d041e6 [wasm][sdk] Decoupling the WebAssembly runtime debug and release versions. (#16028)
* Update templates

- Add PropertyGroups for Debug and Release to set the DebugSymbols and DebugType by default.

* Allow the selection of the WebAssembly runtime version Debug | Release

- Decouple the reliance on `_DebugSymbolsProduced` to decide which runtime version to publish.
- Add support for <MonoWasmRuntime>Debug | Release</MonoWasmRuntime>
- Add validation target of the property to Mono.WebAssembly.Build.targets.

* Indentation
2019-08-05 19:03:35 +02:00
Zoltan Varga 93a6bc3151 [netcore] ifdef out unused icalls/files. (#16009)
* [netcore] ifdef out unused icalls/files.

* Add MONO_EMPTY_SOURCE_FILE.
2019-08-05 17:13:40 +02:00
Egor Bogatov d1700fc93f Add finalizer to DeflateStream (#15879)
Fixes #15825
2019-08-05 13:20:29 +02:00
Zoltan Varga 17b35dc4fc Merge pull request #15640 from vargaz/wasm-xunit
Add beginnings of support for running xunit tests.
2019-08-04 17:05:59 -04:00
Zoltan Varga f239e4e68b [wasm] Add basic support for running xunit tests. 2019-08-04 15:59:36 -04:00
Zoltan Varga 60bfa99043 [jit] Avoid asserting on Unsafe.As<T> in gsharedvt methods.
Fixes https://github.com/mono/mono/issues/15992.
2019-08-03 15:06:58 -04:00
Stephen Toub f532f93ea6 Enable stylecop warnings 1205, 1212, and 1617 (dotnet/corefx#39941)
* Enable stylecop warning 1617 (void return value should not be documented)

* Enable stylecop warning 1212 (get/set accessor ordering)

* Enable stylecop warning 1205 (modifier ordering)

Signed-off-by: dotnet-bot <[email protected]>
2019-08-03 20:55:40 +02:00
Stephen Toub 3385433b60 Enable several StyleCopAnalyzers (dotnet/corefx#39921)
* Fix ordering of keywords in member signatures

* Add StyeCop.Analyzers

Most rules are disabled.  Many of them we'll want to leave disabled, however there are a handful it'll be good to enable over time.

* Use built-in type alias

* Fix straggling stylecop warnings in all configurations

* Replace tabs with spaces

Signed-off-by: dotnet-bot <[email protected]>
2019-08-03 20:55:40 +02:00
Stephen Toub 3fde98da3e Re-enable CA1823 (unused private fields) (dotnet/corefx#39899)
Signed-off-by: dotnet-bot <[email protected]>
2019-08-03 20:55:40 +02:00
Sung Yoon Whang 66a7646232 Make counters use dedicated thread instead of timer (dotnet/coreclr#25864)
* Make a dedicated polling thread for EventCounters

* Cleanup

* remove debug prints

* nit

* Fix comment

* addressing issues from code review

* Fix an assertion from getting fired when we have multiple listeners

* Fix a test issue

* code review feedback

* Fix a potential deadlock

* Fix another deadlock

* Allow s_sleepDurationInMilliseconds to be reset to a larger value

* More issues fix

* Let thread wake up from sleep if needed

* Some suggestions for the counters fix.

The resulting behavior should be the same as what is there now (assuming I didn't mess anything up), these are all just code simplifications that hopefully make it easier to review and maintain going forward. In total I think this reduces the change size in CounterGroup.cs by ~30%.
- With the addition of the AutoResetEvent the ManualResetEvent is no longer needed, removed it.
- Removed the various if foo != null checks for the shared state, it is all initialized once when then thread is created and then assumed to be non-null elsewhere.
- Removed a 2nd lock acquisition inside OnTimer
- Replaced an if with Math.Min in PollForValues

* fix test

Signed-off-by: dotnet-bot <[email protected]>
2019-08-03 20:55:40 +02:00
ts2do 5104fd4b2f Eliminate extra time zone conversions in DateTimeOffset (#25658)
* Eliminate extra time zone conversions in DateTimeOffset

Revised members dealing specifically with local time by removing delegation to DateTime methods to avoid an extra call to TimeZoneInfo to determine offset:
Now
FromFileTime(long)
ToLocalTime()

* Fix DateTimeOffset.ToLocalTime(bool)

* Consolidate conversion from UTC DateTime to Local DateTimeOffset

Signed-off-by: dotnet-bot <[email protected]>
2019-08-03 20:55:40 +02:00
Stephen Toub 6345e18108 Fix use of AddTo/RemoveFromActiveTasks in async methods (#25911)
When we rewrote the async methods implementation with AsyncStateMachineBox, we neglected to call AddToActiveTasks if the debugger is paying attention to tasks.  This hasn't mattered as the debugger's support for Tasks hasn't worked for other reasons in .NET Core, but there is now a renewed focus on it, and this is preventing some of that support from working.

This change is a minimal fix to ensure that we're adding the state machine box task when it's created and removing it when it completes.  Post-3.0, we should look at overhauling this, e.g. to clean up a lot of this logging and tracking that's done, to use a weak table in order to avoid keeping task objects alive artificially if they're dropped without completing by the developer code, etc.

This only affects when the debugger is attached, as the s_asyncDebuggingEnabled field is only ever set by the debugger.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-03 20:55:40 +02:00
Stephen Toub fa0c0bb2e2 Fix nullability annotations for static (dotnet/coreclr#25913)
The compiler is now analyzing statics.  Get compliant.

Signed-off-by: dotnet-bot <[email protected]>
2019-08-03 20:55:40 +02:00
Egor Bogatov e08bddaa63 [netcore] Minor fixes around System.Reflection (#15905)
* Minor fixes

* Update HelloWorld.csproj
2019-08-03 20:49:38 +02:00
Ryan Lucia 848811e4b2 [netcore] Enable ALC loaded_assemblies (#15850)
* Typo

* Enable loaded_assemblies and lock

* Make mono_domain_assembly_open_internal ALC-aware

* Populate loaded_assemblies


Switch from prepend to append

* Some notes

* Exclude add_assembly_to_alc on non-netcore

* Cleanup appdomain.c

* Remove mono_alc_cleanup for now

* Update comment

* Disable using loaded_assemblies in the search hook

* Adjust alc cleanup
2019-08-03 20:47:38 +02:00
Peter Collins 920e03f732 [corlib] Ignore TimeZoneTest.TestCtors on Android GMT
TimeZone.CurrentTimeZone.DaylightName returns an empty value on Android
when the system timezone is set to GMT.
2019-08-03 20:35:27 +02:00
Zoltan Varga 9da563509e Remove error_init from native icall wrappers since managed does it. (#15943)
Preferable would be native only, i.e. for interpreter and for when
it is actually unused, but ok for now.

Between removing the managed and the native, managed is preserved
in case there uses of MonoError in C# other than icall wrappers.
Keep them safe.

But again ideally move it to native and remove the managed type,
pending debugging WebAssembly failure doing so.
2019-08-03 12:00:46 -04:00
Kenneth Pouncey a61d8ea767 [wasm][framework] Rework framework linker descriptions (#15952)
- Remove the fully preserved assembly references from `WebAssembly.Bindings` and `WebAssembly.Net.Http`

Close https://github.com/mono/mono/issues/15365
2019-08-03 12:00:19 -04:00
Jb Evain 283c0557d3 Fix usage of mono_debug_get_seq_points to avoid leaks (#15977) 2019-08-03 11:59:25 -04:00
imhameed 3ab93f97e6 [llvm] Add support for JIT + LLVM 9.0. (#15997)
* [llvm] Add support for llvm 9.0.

Works with this branch:
https://github.com/mono/llvm/tree/release_90

* Add support for JIT + LLVM 9.

* Don't assume that all memset targets will be aligned; fixes LLVM 6 on amd64.
2019-08-03 11:58:40 -04:00
Calvin Buckley e70ac8c6ae Enable MONO_ARCH_EMULATE_FCONV_TO_U4 on PPC (#15991)
Fixes regression related to floating point introduced in #15930.

This does mean we have to take a slower path instead of using the
PPC instruction, but it provides consistent results. Other CPUs
have to do this too, so it's not like PPC is impacted unfairly.
(i.e, NaN gives an inconsistent result, at least with POWER7 and
some amd64 CPUs tested)

Fixes #15990.
2019-08-02 19:00:02 -04:00
Jo Shields 9a7b6fd5ee Bump libgdiplus to new release (#15996) 2019-08-03 00:48:26 +02:00
Calvin Buckley 9ea07610ee Don't use clock_nanosleep on PASE (#15988)
* Don't use clock_nanosleep on PASE

PASE exports this AIX syscall so autoconf detects it, but using it
will trigger SIGILL (for unimplemented syscall), which emits a LIC
log entry type of 4700-000F.

* Change ifdef guard for clock_nanosleep in threads

It only used clock_nanosleep on Linux, but enable it for all except
PASE. Android used to be guarded against, but the reasoning was
unknown, so @akoeplinger requested to have that guard removed.
2019-08-02 23:04:50 +02:00
Aleksey Kliger (λgeek) 713df6a9c4 [netcore] Fix comments in ALC to use Mono terminology (#15998) 2019-08-02 16:31:06 -04:00
Martin Baulig 6818163383 Use MultipleConnectAsync from CoreFX. (#15972)
* Use `MultipleConnectAsync` from CoreFX.

* [csproj] Update project files
2019-08-02 15:10:03 -04:00
Alexander Köplinger 2f21664fc2 [ci] Remove the downloaded pr-files.txt 2019-08-02 21:07:06 +02:00
Zoltan Varga 0104cc6a8f [ci] Skip lanes on ppc/wasm changes. (#15995) 2019-08-02 20:56:11 +02:00
Aleksey Kliger (λgeek) 2f2f6c104b [netcore] Implement referenced assembly resolving and ALC.GetLoadContext (#15946)
* [netcore] Implement GetLoadContext

* [netcore] Implement ALC-aware referenced assembly resolution.

The process is described in
https://docs.microsoft.com/en-us/dotnet/api/system.runtime.loader.assemblyloadcontext?view=netcore-3.0#usage-in-the-runtime

We try four things until one of them returns a non-null assembly.

1. Check if the assembly is already loaded in the ALC of the requesting
assembly.
2. If the ALC is not the default ALC, invoke the Load override.
3. Try the default ALC (TPA - trusted platform assemblies) loading.
4. Invoke the Resolving event of the original ALC.

The implementation borrows some managed code from
https://github.com/dotnet/coreclr/blob/8ba2e15201361402acd0ae9710bd37d50785cdfa/src/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.CoreCLR.cs#L84-L187

It would be nice if that code was shared between the runtimes.

* [runtime] Implement mono_assembly_name_culture_is_neutral

* [netcore] Add mono_alc_invoke_resolve_using_resolve_satellite

* [netcore] Use ResolveSatelliteAssembly for satellite assembly refs

* [netcore] Some AssemblyLoadContextTest tests now pass

System.Runtime.Loader.Tests.AssemblyLoadContextTest.PublicConstructor_Default
System.Runtime.Loader.Tests.AssemblyLoadContextTest.GetAssemblyNameTest_NullParameter
System.Runtime.Loader.Tests.AssemblyLoadContextTest.LoadFromAssemblyName_AssemblyNotFound
System.Runtime.Loader.Tests.AssemblyLoadContextTest.PublicConstructor_Theory (with isCollectible: False)
System.Runtime.Loader.Tests.AssemblyLoadContextTest.GetAssemblyNameTest_ValidAssembly
System.Runtime.Loader.Tests.AssemblyLoadContextTest.GetLoadContextTest_SystemPrivateCorelibAssembly
System.Runtime.Loader.Tests.AssemblyLoadContextTest.DefaultAssemblyLoadContext_Properties
System.Runtime.Loader.Tests.AssemblyLoadContextTest.GetAssemblyNameTest_AssemblyNotFound
System.Runtime.Loader.Tests.AssemblyLoadContextTest.GetLoadContextTest_ValidTrustedPlatformAssembly
2019-08-02 14:06:44 -04:00
Thays Grazia 0b8a0e09d3 [Debugger] Fixing test with mcs (#15985) 2019-08-02 18:48:42 +02:00
Alexander Köplinger 67aed94e2b [ci] Set apidiff/csprojdiff statuses even when we're skipping the build
They are required GitHub statuses so we need to set them.
2019-08-02 17:19:14 +02:00
Zoltan Varga 5bb4f1eea8 [ci] Skip jenkins lanes for PRs which only contain changes to the netcore/ subdir. (#15978) 2019-08-02 17:12:46 +02:00
Egor Bogatov d0aa0310ee [netcore] Use mono-netcore to run real world apps using dotnet run (#15942)
So currently we have two .NET Core:

1) `mono-repo/.dotnet` - we use it to bootstrap and build stuff (the SDK version is specified in `global.json`) - if you open `netcore/Makefile` it's referred there as `$(DOTNET)` variable.
2) `mono-repo/netcore/.dotnet` - it's just a runtime + CoreFX libs (it doesn't contain SDK stuff, templates, msbuild, etc) - we use it only to run tests because this runtime is synchronized with corefx tests in `eng/Versions.prop` file which is updated by a bot and `netcore/shared` sources for our System.Private.CoreLib also depend on that exact runtime version (the sources also updated by the bot).

This PR introduces a rule to copy mono bits to the `mono-repo/.dotnet` folder to be able to run real world apps (at your own risk) using mono-netcore (so when you run `mono-root/.dotnet/.dotnet run -c Release` for an app - even MSBuild will use mono runtime to build that app). However in theory we need exact SDK for the runtime version we have but I have no idea where and how to get one.

BTW, currently MSBuild crashes when it's powered by mono on `$(DOTNET) build` command for a hello world.
```
monoeg_assertion_message
mono_domain_assembly_preload
invoke_assembly_preload_hook
...
at <unknown> <0xffffffff>
at System.Reflection.RuntimeAssembly:GetExportedTypes <0x000a2>
at AssemblyInfoToLoadedTypes:ScanAssemblyForPublicTypes <0x0008e>
```
2019-08-02 17:06:37 +02:00
Egor Bogatov 40f28b2e63 Make System.Private.CoreLib.csproj VS friendly (#15965)
Now it's possible to open System.Private.CoreLib.csproj in an IDE and build (use Roslyn version from eng/Versions.props).
2019-08-02 10:05:22 -04:00
Thays Grazia 3a9df67a64 [debugger] Invoke method with fixed size array as an attribute of this (#15766)
Implement debugger invoke when the this has an attribute that is a fixed size array.

Fixes #15556
2019-08-02 15:47:25 +02:00
Vlad Brezae 4883b56c10 [interp] Remove unconditional branches to next instruction (#15939)
[interp] Remove unconditional branches to next instruction

These are very common, at least in debug builds. Optimize them away so it doesn't distort performance numbers.
2019-08-02 05:16:07 -04:00
Kenneth Pouncey 4ed2aadbdf [wasm][sdk] Support for Custom Linker Configuration (#15953)
- Provide extra definitions to the linker to ensure the type, methods and/or fields are not eliminated from your application.

* Use a <LinkDescription> item as follows:

```
  <ItemGroup>
    <LinkDescription Include="customlinker.xml" />
  </ItemGroup>
```

This will then be added to the `WasmLinkAssemblies` step.
2019-08-02 08:58:50 +02:00
Martin Baulig 455b051ce5 Fix compiler warnings in System.dll. (#15971)
* Merge the `System.Diagnostics/ProcessStartInfo.cs` part into the referencesource file to avoid CS0282.

* Remove duplicate `using`.

* Fix unreachable code warning that got introduced in my last PR.
2019-08-01 18:46:15 -04:00
Phil Jaenke fcfd3e54a5 Fix patch step in mdoc tests for non-Linux (#15974)
Non-Linux systems largely do not support `--binary`. Since the patch appears to be text anyway, it's probably safe to remove for all platforms.

With `patch -p0` , mdoc test now provides accurate pass/fail on FreeBSD.
2019-08-01 23:42:05 +02:00
Egor Bogatov 26f3df9881 [netcore] Minor fixes, fix GetTypeTests.GetType_EmptyString (#15933)
* Fixes https://github.com/mono/mono/issues/15023
 
* Fixes https://github.com/mono/mono/issues/15189 (were marked as "require large array
support" in dotnet/corefx by @filipnavara)

* Move InternalGetHashCode to RuntimeHelpers
2019-08-01 16:56:56 -04:00
Zoltan Varga 6f05192669 [netcore] Add a README. (#15934)
* [netcore] Add a README.
2019-08-01 16:27:40 -04:00
Jay Krell 75a99b7e84 Bump monolite version. (#15969)
It got out of sync for some reason.
2019-08-01 21:38:52 +02:00
Vlad Brezae 87ba12e13f [sgen] Fix check-nursery-pinned debug option (#15865)
* [sgen] Remove dead unpin_queue argument

* [sgen] Fix check-nursery-pinned debug option

And rename it to better reflect what is is doing now (which is to check that we don't leave any vtables tagged at the end of a collection). It used to also check that nursery objects are pinned, back when we were doing a nursery collection as part of the finishing pause of a concurrent collection.
2019-08-01 21:48:23 +03:00
Filip Navara 3c92cd8c94 [jit] Align float/double Nan/Inf to uint conversion behavior with CoreCLR/LLVM/Roslyn (#15930)
* [jit] Align float/double Nan/Inf to uint conversion behavior with CoreCLR/LLVM

* Fix float/double -> ulong conversion for edge cases

* Fix mono_fconv_u8 / mono_rconv_u8 to also return 0 for PositiveInfinity

* Enable support for platform specific implementations of OP_RCONV_U8/OP_FCONV_U8/OP_FCONV_U4

* Restore OP emulation on WASM target

* Update tests

* Disable failing tests for now

* Adjust tests

* Adjust tests

* Fix float -> uint conversion on WASM

* Make interpreter consistent with compiled code

* Blind attempt to fix WASM test leg

* Implement remaining conversions in LLVM

* Fix ARM32

* Workaround for Windows x64 FullAOT+LLVM

* Bump AOT version
2019-08-01 13:37:41 -04:00
Maxim Lipnin d72ca69693 Bump corefx (#15932)
This PR brings changes from mono/corefx#313.
Fixes #15887.
2019-08-01 18:36:29 +02:00
Filip Navara 98cb4aed20 [System.Drawing] Fix comparison in MeasureString_Wrapping_Dots test (#15958) 2019-08-01 17:09:38 +02:00
Jay Krell a7b74fc69c Support proper Windows kernel Unicode thread names. (#15919)
These do not require a debugger, can be retrieved, appear in ETW, etc.

Extracted from https://github.com/mono/mono/pull/15859.
2019-08-01 15:53:41 +02:00
Zoltan Varga 6a66472815 [wasm] Add normal GC support. (#15577)
* [llvm] Spill all ref variables to the stack on wasm, so GC stack scanning can scan all references.

* [runtime] Add an option to enable on-demand GC.
2019-08-01 15:50:28 +02:00
Vlad Brezae e3ca891235 [marshal] Free delegates with target that are passed to native code. (#15935)
* [marshal] Always use gchandles in delegate_hash_table

Makes the code easier to follow and it also fixes race from https://github.com/mono/mono/commit/caa4a753ca8e15d43baaa01adb0f56f374b74a2b with boehm.

* [marshal] Free delegates with target that are passed to native code.

For static method delegates, we have a unique delegate_trampoline that is shared among all delegates. We always keep alive the first static method delegate passed to native, by creating a normal gchandle to it and storing it in delegate_hash_table. For instance methods, each delegate will create a separate wrapper and these wrappers are never shared (which was wrongly assumed in https://github.com/mono/mono/commit/caa4a753ca8e15d43baaa01adb0f56f374b74a2b). We shuldn't keep the delegate alive and this commit reverts the behavior for delegate with instance methods introduced in the mentioned commit.

Fixes https://github.com/mono/mono/issues/15751
2019-08-01 16:06:05 +03:00
Vlad Brezae ce398411a0 [mini] Ignore conv.r.un if top of stack is already float (#15818)
Fixes https://github.com/mono/mono/issues/15794
2019-08-01 15:21:50 +03:00
Martin Baulig e92ecdc9ce Fix Socket.ConnectAsync(SocketAsyncEventArgs) behavior. (#15947)
We need to clearly distinguish between synchronous and asynchronous completions
and avoid any ambiguities and race conditions when it comes to error handling.

On synchronous completion, we must not invoke the async completion delegate.

In `System.Net.Sockets/Socket.cs`, the internal `BeginSConnect()` and `BeginMConnect()`
now return a `bool` indicating whether or not an async operation is pending.

If any error happens prior to starting the async operation, then we shall call
`SocketAsyncResult.Complete(..., true)` and return `false`.  And since this is
a synchronous completion, it's `AsyncCallback` will not be invoked.

In `referencesource/System/net/System/Net/Sockets/_MultipleConnectAsync.cs`,
I compared the entire file against the CoreFX version and then copied the
`AttemptConnection()` method from their implementation to adapt their behavior.

The difference is that on synchronous completion, the `InternalConnectCallback(null, args)`
should be invoked.
2019-08-01 12:31:25 +02:00
monojenkins 0e6965f6ba [csproj] Update project files 2019-08-01 07:45:48 +03:00
Alexis Christoforides 4abc400244 [corlib] Allow copying/moving/replacing broken symlinks
Fixes https://github.com/mono/mono/issues/14971
2019-08-01 07:45:48 +03:00
Andy Gocke 863ab55d48 Add Roslyn maestro dependency (#15944)
* Add Roslyn maestro dependency

This should bring down the Microsoft.Net.Compilers package,
which contains the Roslyn binaries needed for mono packaging.

* Add Version to Versions.props as well
2019-08-01 02:04:04 +02:00
Jay Krell 180fcfe1fd Factor copy/pasted code into mono_gstring_append_thread_name. (#15920)
Extracted from https://github.com/mono/mono/pull/15859.
2019-08-01 01:25:31 +02:00
Jay Krell 3db9635bf5 Remove error_init from native icall wrappers since managed does it.
Preferable would be native only, i.e. for interpreter and for when
it is actually unused, but ok for now.

Between removing the managed and the native, managed is preserved
in case there uses of MonoError in C# other than icall wrappers.
Keep them safe.

But again ideally move it to native and remove the managed type,
pending debugging WebAssembly failure doing so.
2019-07-31 15:49:54 -07:00
Vlad Brezae 985a1c33f2 [tests] Bump sleep for pinvoke3 test (#15937)
On some operating systems, this test can take forever because the worker starves the other threads by holding the gc_lock. Bump sleeping so it doesn't rely on OS scheduling that much and guarantees other threads can progress in reasonable amount of time.
2019-08-01 00:24:06 +03:00
Alexander Köplinger cf0e2dd972 [zlib] Fix typo in readme and remove deleted file from msvc projects 2019-07-31 22:58:21 +02:00
Jay Krell 431bb95c71 Update zlib from 1.2.5 to 1.2.11. (#15480)
Circa 2010 to circa 2017.

Retrieved with apt-get source zlib on WSL Ubuntu 18.04.2 LTS.

This matches Debian or Ubuntu (they differ by one commit, and one of them restores a dummy function for compat).

---

* [minizip] Ensure we don't ever accidentally change calling convention

Make sure we always #define ZCALLBACK to empty so we don't change
the calling convention on windows by including a header which defines
'CALLBACK'. This will keep things as cdecl as required by the c#
pinvokes.

* Update zlib readme.

* Update zlib from 1.2.5 to 1.2.11.

* [zlib] Small fix for Visual C++.
see https://github.com/madler/zlib/pull/435/files#diff-0558e84b0c24a83ca790dcb05cd26212R1087
and https://github.com/madler/zlib/pull/435/files#diff-0558e84b0c24a83ca790dcb05cd26212R1104

* Add gzguts.h to Makefiles.

* Add .h files to Visual Studio project files just for GUI purposes.
2019-07-31 22:56:34 +02:00
Zoltan Varga 1d9a87e449 Fix the netcore build. (#15941) 2019-07-31 22:04:37 +02:00
turbo 8b9033e4d2 Add O_NOATIME to OpenFlags (#8993)
O_NOATIME (Linux > 2.6.8): Do not update the file last access time (st_atime in the inode) when the file is read(2). Programs that merely index the existence of a file (backup programs e.g.) can reduce disk load using this flag.
2019-07-31 21:24:53 +02:00
Zoltan Varga 60c277cb4e [runtime] Convert more icalls to use handles. (#15862)
* [runtime] Convert Volatile to use the same approach as the netcore version, get rid of most Volatile icalls.

* [runtime] Reduce the number of handles used by construct_culture ().

* [runtime] Convert some icalls to handles.

* Fix signature of FAMNextEvent.

* [aot] Avoid aoting the gsharedvt versions of Volatile:Read<T>/Write<T>.

* Bump API snapshot submodule

* Convert Marshal:UnsafeAddrOfPinnedArrayElement to use coop handles.
2019-07-31 14:08:50 -04:00
Aleksey Kliger (λgeek) 349a3d5eef [threads] Enter GC Unsafe before pumping HP queue in unregister_thread (#15890)
If the thread info TLS key dtor runs unregister_thread from a foreign thread
and we have work in the hazard pointer queue, we need to first switch to GC
Unsafe mode because some of the free methods passed to
mono_thread_hazardous_try_free need to be coop-aware.

Also, added checked mode assertions that conc_table_free and
jit_info_table_free are called from GC Unsafe mode.

Fixes https://github.com/mono/mono/issues/15878
2019-07-31 13:30:30 -04:00
Jay Krell 499a02d6a1 Cleanup and resynchronize Thread/InternalThread fields. (#15910)
- Remove unused.
- Add missing that just happened to work.
- Synchronize size between netcore and regular. `#if` considered bad.

Extracted from https://github.com/mono/mono/pull/15859.
2019-07-31 18:30:50 +02:00
Jay Krell 9acd4c8004 mono_thread_set_name_internal change unreadable boolean parameters to enum flags. (#15921)
Extracted from https://github.com/mono/mono/pull/15859.
2019-07-31 18:30:28 +02:00
Zoltan Varga 6223e74688 [jit] Optimize the initialize of MonoError locals. (#15869)
Previously, we would emit a call to memset since the struct is large (> 100 bytes). Only the error code field needs to be initialized.
2019-07-31 14:26:24 +02:00
Calvin Buckley 1059b3e6f5 Update Haiku support (#15674)
* Build System.Native.

* Disable `pthread_mutexattr_setprotocol` use, since it returns EINVAL on Haiku.

* Disable the `strerror` cache on Haiku. On Haiku, errors begin at `0x8000_0000` like a Win32 HRESULT. This means the indexing would be on negative numbers, which is a no-no. There are a few alternative ways to keep it though: hashtable, tuple array, offset...

Unfortunately, doesn't build all the way through. Has a tendency to bomb out during building `build-unix`. Will investigate why.
2019-07-31 14:23:48 +02:00
coypoop f86d46d136 configure.ac: Use = as a test(1) operator. (#15876)
== is a bash extension
= is POSIX and equivalent
2019-07-31 14:22:26 +02:00
Zoltan Varga 4170bef2c3 [wasm] Small changes. (#15918)
* [wasm] Touch the dummy .exe files created during linking if they already exist.

* [wasm] Display longer stack traces on v8.

* [wasm] Add a --native-strip option to the packager, defaults to true.

* Add targets for separate interpreter test projects. Normalize main.exe command line arguments.
2019-07-31 14:20:40 +02:00
Jay Krell e0335d3570 Save 64 bytes from most Linux/amd64 interpreter frames. (#15926)
Probably same on all 64bit architectures. half on 32bit.

before:
```
0000000000003ce0 <interp_exec_method_full>:
    3ce0:	55                   	push   %rbp
    3ce1:	48 89 e5             	mov    %rsp,%rbp
    3ce4:	41 57                	push   %r15
    3ce6:	41 56                	push   %r14
    3ce8:	41 55                	push   %r13
    3cea:	41 54                	push   %r12
    3cec:	49 89 f4             	mov    %rsi,%r12
    3cef:	53                   	push   %rbx
    3cf0:	48 89 fb             	mov    %rdi,%rbx
    3cf3:	48 81 ec 78 01 00 00 	sub    $0x178,%rsp
```

after:
```
0000000000003ce0 <interp_exec_method_full>:
    3ce0:	55                   	push   %rbp
    3ce1:	48 89 e5             	mov    %rsp,%rbp
    3ce4:	41 57                	push   %r15
    3ce6:	41 56                	push   %r14
    3ce8:	41 55                	push   %r13
    3cea:	41 54                	push   %r12
    3cec:	49 89 f4             	mov    %rsi,%r12
    3cef:	53                   	push   %rbx
    3cf0:	48 89 fb             	mov    %rdi,%rbx
    3cf3:	48 81 ec 38 01 00 00 	sub    $0x138,%rsp
```

It was 0x158 recently.

Some frames will be larger, i.e. dynamic + pinvoke.

Classic technique:
 pointer instead of struct
 initialized to null
 alloca it when needed and not null

A more detailed analysis might enable better, such as making
the parameter optional, and/or having the callee default it to its
local storage.
2019-07-31 14:20:03 +02:00
Nikolay Sivov c8fd75734b Fix some compiler warnings for Win32/mingw64 build (#15903)
* [mono] Fix unused variable warning in mono_config_parse().

* [ligc] Fix strict prototype warning for Win32 build.

* Add some casts.
2019-07-31 14:18:53 +02:00
coypoop bed4c00e02 Remove unused libdl setting (#15884)
We test dlopen with no library and in libdl later, without the
use of this setting.

Got the hint since I'm building for a configuration which had it set wrong.
2019-07-31 14:17:34 +02:00
coypoop a65eec76be Remove unused declarations (#15907) 2019-07-31 14:16:37 +02:00
Zebediah Figura dc48d9e241 Always marshal a class as a COM interface if it has the InterfaceType attribute set. (#15671)
This fixes Game Maker Studio 2 Desktop under Wine.
2019-07-31 14:15:38 +02:00
Zebediah Figura b51c696081 [cominterop] Handle NULL pointers when marshalling native-to-managed return values. (#15906)
Fixes a bug running Rak24u with wine-mono: bugs.winehq.org/show_bug.cgi?id=47561
2019-07-31 14:14:39 +02:00
Jay Krell c37fc12ca5 Fix race condition and use less memory in mono_lookup_icall_symbol. (#14532)
It is racy because it is doing on-demand initialization, which is often racy.

The rewrite changes the result to be one pointer, atomically swapped, which implies a full barrier and data dependency, so no race.

It could also be fixed by copying and sorting an array of pairs, and one pointer to that.

However in order to save memory I instead use indirect data that is an array of uint16 pointing into the original data. That is a slight memory vs. time tradeoff.

Yes there is debugging code left, under #if, that I prefer to leave, both as evidence that I tested it, and to make it somewhat but ideally testable in future.

The code also was using an unnecessary somewhat risky but probably ok here way to compare pointers, that I fixed.

As well the result is marginally smaller and faster because it was inlining something like bubblesort, now reuses qsort.
2019-07-31 14:13:21 +02:00
Alexander Köplinger 471421023c [ci] Handle master build purging in a separate cleanup job 2019-07-31 13:32:06 +02:00
Jay Krell bd0c46a842 [Coop] Add TYPED_HANDLE_DECL. (#15909)
Extracted from #15900.
2019-07-31 12:35:59 +02:00
Bernhard Urban a6e6c72c8f [sdks] remove 32bit llvm (#15896)
[sdks] remove 32bit llvm

Also switches the MXE cross compilers for Android and WebAssembly to 64bit host.
2019-07-30 19:05:41 -04:00
Alexander Köplinger 2cfbadb0a6 [pkg] Don't keep per-commit master builds in CI
We only want the daily builds.
2019-07-31 00:34:38 +02:00
Filip Navara 60bb726eac Update CoreFX.issues.rsp (#15870)
Removed tests fixed by #13907.
Fixes #14945
Fixes #14946
Fixes #14948
2019-07-30 23:39:34 +02:00
Jay Krell ca8f155983 [Coop] Convert ves_icall_string_new_wrapper_impl. (#15901)
Static analysis prefers not even these short lived raw pointers.
Extracted from #15900.
2019-07-30 23:37:58 +02:00
Jay Krell 56082ab528 [Coop] Convert mono_string_from_byvalwstr_impl. (#15902)
Remove the raw pointer that static analysis will flag.
Extracted from #15900.
2019-07-30 23:37:09 +02:00
Zoltan Varga f8fd60b5c0 [interp] Simplify the main interpreter loop code to speed up compilation. (#15889)
* [interp] Simplify the control flow in the main loop to speed up compilation of interp.c.

Get rid of the handle_finally and main_loop labels.

* [interp] Move some rarely used locals to InterpFrame to speed up compilation and to increase the chance that the other locals end up in registers.

* Add macros for throwing exceptions to shorten the code a bit.

* Fix a previous change.
2019-07-30 16:02:27 -04:00
Larry Ewing eb68675461 Bump msbuild to xplat-master 2019-07-30 14:20:22 -05:00
Larry Ewing 11b6828420 Update nuget binary 2019-07-30 14:20:22 -05:00
Alexander Köplinger ce1653b08a [sdks] Don't keep per-commit master builds in CI
We only want the daily builds.
2019-07-30 21:14:02 +02:00
Alexander Köplinger ee636ee8d9 [sdks] Make sure python3-pip is installed for Linux Android builds 2019-07-30 20:46:11 +02:00
Alexander Köplinger 9f0d493eea [netcore] Replace dl-test-assets.py with msbuild download (#15883)
The python file was unreliable on macOS, let's see whether a simple msbuild replacement is better.

Also fixed dependencies on some of the Makefile targets so that they correctly detect when they need to run.
2019-07-30 19:27:42 +02:00
Jay Krell a8d8fb6cea Fix warnings. (#15768)
* boehm-gc.c:1923:14: warning: variable old_obj set but not used [-Wunused-but-set-variable]

* class-init.c:1720:1: warning: compare_by_interface_id defined but not used [-Wunused-function]

* class.c:1724:1: warning: compare_interface_ids defined but not used [-Wunused-function]

* icall.c:8190:13: warning: variable klass set but not used [-Wunused-but-set-variable]

* image.c:1063:20: warning: variable header set but not used [-Wunused-but-set-variable]

* metadata.c:2573:25: warning: right shift count >= width of type [-Wshift-count-overflow]

* sgen-dynarray.h:194:1: warning: dyn_array_int_is_copy defined but not used [-Wunused-function]

* sgen-mono.c:255:1: warning: emit_managed_allocater_noilgen defined but not used [-Wunused-function]
sgen-mono.c:238:1: warning: emit_nursery_check_noilgen defined but not used [-Wunused-function]

* sgen-tarjan-bridge.c:449:25: warning: right shift count >= width of type [-Wshift-count-overflow]

* threads.c:1451:11: warning: variable res set but not used [-Wunused-but-set-variable]

* w32process-unix-default.c:239:19: warning: variable min_dev set but not used [-Wunused-but-set-variable]
w32process-unix-default.c:239:10: warning: variable maj_dev set but not used [-Wunused-but-set-variable]

* w32process-unix.c:2107:25: warning: variable waitret set but not used [-Wunused-but-set-variable]

* aot-compiler.c:4180:1: warning: add_lazy_init_wrappers defined but not used [-Wunused-function]

* aot-compiler.c:7200:86: warning: format %lu expects argument of type long unsigned int, but argument 3 has type gsize {aka unsigned int} [-Wformat=]

* aot-compiler.c:10013:7: warning: unused variable index [-Wunused-variable]

* aot-compiler.c:10012:15: warning: variable method set but not used [-Wunused-but-set-variable]

* method-to-ir.c:4031:22: warning: variable tmpreg set but not used [-Wunused-but-set-variable]

* mini-runtime.c:2977:14: warning: variable invoke set but not used [-Wunused-but-set-variable]

* mono-rand.c:94:1: warning: mono_getentropy defined but not used [-Wunused-function]
2019-07-30 12:10:30 +02:00
Jay Krell f1958bacaa Remove mono_thread_get_name. (#15875)
Unused since https://github.com/mono/mono/commit/b5c0c831da328b8ab7b7283a38fa56baaa7ae380.
And not likely to come back.
2019-07-30 03:08:55 +02:00
Jay Krell 929e3135bb HANDLE_FUNCTION_RETURN_VAL must not use handles in current frame (#15873) 2019-07-30 01:39:44 +02:00
Calvin Buckley 95f8a68c56 ArgumentNullException when pointer is null for Marshal.AddRef/Release/QueryInterface (#15867)
Fixes #15853
2019-07-29 20:27:18 +02:00
dotnet-maestro[bot] a0aae297d9 Update dependencies from https://github.com/dotnet/arcade build 20190729.1 (#15881)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19379.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19379.1
2019-07-29 20:24:40 +02:00
Jay Krell b5c0c831da Fix thread name leak in debugger. (#15858) 2019-07-29 11:31:14 +02:00
Jay Krell babcdbdcbd [Coop] Convert System.Buffer. (#15861)
And inline `mono_array_handle_length`.
And remove `inline` in .c files a little -- it only belongs in .h.
2019-07-29 11:30:16 +02:00
Zoltan Varga 967a79e5a1 [wasm] Fix the generation of emsdk_env.sh. (#15872) 2019-07-29 11:28:29 +02:00
Vlad Brezae 91b9ff3e53 [interp] Optimize ldelema (#15846)
Makes the opcode 2-3x time faster
2019-07-27 17:37:00 +03:00
Zoltan Varga 9f25324936 [WIP] [runtime] Convert WindowsIdentity.GetRoles () icall to coop. (#15849)
* [runtime] Convert WindowsIdentity.GetRoles () icall to coop.

* [runtime] Replace some Buffer icalls with Unsafe methods.

* Fix the windows build.
2019-07-27 02:27:24 -04:00
Alexander Köplinger 6a6a0f6213 [netcore] Disable new post-build.yml stage in AzDO pipeline 2019-07-27 02:54:50 +02:00
Alexander Köplinger 64be3113a3 [netcore] Add back _DotNetPublishToBlobFeed variable in AzDO pipeline 2019-07-27 02:41:41 +02:00
Alexander Köplinger e38468d0e4 [netcore] Fix condition in AzDO pipeline 2019-07-27 02:15:49 +02:00
Alexander Köplinger 4398a12286 [netcore] Fix name of empty.proj in AzDO pipeline 2019-07-27 02:07:31 +02:00
Alexander Köplinger a3fda4a3cb [netcore] Add back pushing to blob feed in AzDO pipeline 2019-07-27 02:01:20 +02:00
Alexander Köplinger 4ef62c8c46 [netcore] Set variables a bit differently 2019-07-27 00:56:25 +02:00
Alexander Köplinger 882208bbc6 [netcore] Explicitly set _PublishUsingPipelines variable to true
It shouldn't be needed when using the eng/common/templates/jobs/jobs.yml template but it is.
2019-07-27 00:34:38 +02:00
Alexander Köplinger e12a6bf5d8 [netcore] Only install Linux packages on hosted pool 2019-07-27 00:23:00 +02:00
Alexander Köplinger ae488c93e9 [netcore] Fix building of nupkg (#15855)
When https://github.com/mono/mono/commit/9010d2f290d28dc97ac276e0c0d32a2932b7550f was merged we stopped including mcs/build/config.make.
However, that file set the VERSION variable which wasn't migrated to the new netcore/config.make so the nuget package missed the version.

Additionally, System.Private.CoreLib sources were moved into the netcore folder and we now seemingly need to pass `-p:IsPackable=true` for dotnet pack to build the nuget package.
2019-07-27 00:17:31 +02:00
Alexander Köplinger dc16db91a1 [netcore] Enable nuget validation in post-build AzDO pipeline stage 2019-07-26 23:23:12 +02:00
Alexander Köplinger ccb53b88f4 [netcore] Switch back to old way of specifying poolname
Otherwise the AzDO test view contains `$(poolname)`
2019-07-26 23:18:59 +02:00
Alexander Köplinger 296d395535 [netcore] Use yaml stages in azure pipelines definition (#15838)
Arcade would like us to start using yaml stages.
2019-07-26 23:13:12 +02:00
Stephen Toub 216fad5177 Re-enable CA1802 (use consts instead of readonly statics) (#39782)
* Re-enable CA1802 (use consts instead of readonly statics)

I enabled it only for privates and internals, as we've previously violated this in public surface area, and as everything goes through API review moving forward, didn't seem worthwhile fighting it and adding suppressions in various places.

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-07-26 20:08:24 +02:00
Nicholas Schell 51aa4b019a [Mono.Posix] Parameters for chown should be signed integers not unsigned (#15828)
Fixes https://github.com/mono/mono/issues/10748

The calls for chown, lchown, fchown, and fchownat (from `Mono.Unix.Native.Syscall`) are all declared with unsigned integers for the `owner` and `group` parameters. This is incorrect.

Directly from the manpage
`man 2 chown`
<pre><code>
...
       int chown(const char *pathname, uid_t owner, gid_t group);
       int fchown(int fd, uid_t owner, gid_t group);
       int lchown(const char *pathname, uid_t owner, gid_t group);

...

       int fchownat(int dirfd, const char *pathname,
                    uid_t owner, gid_t group, int flags);

...
...
       <b>If the owner or group is specified as -1</b>, then that ID is not changed.
...
</pre></code>

Emphasis added on the documentation explaining how the parameters can take the value -1, clearly not an unsigned integer. The `uid_t` struct is not an unsigned integer. I am assuming this was just an oversite on whoever re-wrote `Mono.Unix.Native.Syscall`.

The original calls from `Mono.Posix.Syscall` (now marked as Obsolete) all correctly use signed integers.
```
                [DllImport ("libc", SetLastError=true)]
                public static extern int chown (string path, int owner, int group);
                [DllImport ("libc", SetLastError=true)]
                public static extern int lchown (string path, int owner, int group);
```

Even the documentation directly from `mcs/class/Mono.Posix/Documentation/en/Mono.Unix.Native/Syscall.xml`
```
          <para>
            One of the owner or group id's
            may be left unchanged by specifying it as -1.
          </para>
```
2019-07-26 20:07:38 +02:00
Ryan Lucia 29428550c2 [netcore] Implement AssemblyLoadContext.GetLoadedAssemblies() (#15832)
* [netcore] Implement AssemblyLoadContext.GetLoadedAssemblies()

* No refonly on netcore

* Ifdef out AppDomain.GetAssemblies() on netcore

* Don't init the error

* Unnecessary ifdef
2019-07-26 18:23:43 +02:00
monojenkins 86fbf751fe [csproj] Update project files 2019-07-26 16:52:58 +02:00
Marek Safar 044982b390 [wasm] Remove assemblies we don't want to distribute 2019-07-26 16:52:58 +02:00
Bernhard Urban b4c5d68c28 [android] switch to python offset tool (#15834)
[android] switch to python offset tool

And drop C# tool.

Fixes https://github.com/mono/mono/issues/9621
2019-07-26 08:15:50 -04:00
Kenneth Pouncey ddb1f31c9e Fix http framework module that errors using SDK 2.1.801 (#15844)
- 2.1.801 seems to have a problem with:

```
						using (var uint8Buffer = Uint8Array.From(await request.Content.ReadAsByteArrayAsync ()))
```
2019-07-26 12:13:27 +02:00
Zoltan Varga 390353d48b [netcore] Add a missing make dependency. 2019-07-26 10:03:14 +02:00
unknown a809e479f3 Update dependencies from https://github.com/dotnet/core-setup build 20190725.9
- Microsoft.NETCore.App - 5.0.0-alpha1.19375.9
2019-07-26 09:10:04 +02:00
unknown 0bb362511c Update dependencies from https://github.com/dotnet/corefx build 20190725.11
- Microsoft.Private.CoreFx.NETCoreApp - 5.0.0-alpha1.19375.11
2019-07-26 09:10:04 +02:00
dotnet-maestro[bot] 08bd3e5dc1 Update dependencies from https://github.com/dotnet/arcade build 20190725.3 (#15836)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19375.3
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19375.3
2019-07-26 02:11:51 +02:00
Alexander Köplinger ad2405761b [sdks] Report xcode11 builds as a separate GitHub status 2019-07-25 23:47:24 +02:00
Alexander Köplinger 77ac509c0b [sdks] Add special build job for building with Xcode 11 2019-07-25 23:47:24 +02:00
Aleksey Kliger (λgeek) 04517d3a39 [metadata] Fields whose types are gparams with a reference type constraint aren't blittlable. (#15761)
* [metadata] Fields whose types are gparams with a reference type constraint
aren't blittlable.
Don't try to layout the field to find out if it's blittable.
For gshared gparams, follow the blittability of the constraint.

Fixes certain recursive examples.

```
using System;

namespace TestRecursiveType
{
    class Program
    {
        static void Main(string[] args)
        {
            SubClass subC = new SubClass();
            Console.WriteLine(subC.GetTest());
        }
    }

    public struct ValueTest<U>
    {
        // When U is instantiated with T, from BaseClass, we know it'll be a
	// reference field, so we know the instantiation ValueTest<T> won't
	// be blittable.
        public readonly U value;
    }

    public abstract class BaseClass<T> where T : BaseClass<T>
    {
        public ValueTest<T> valueTest = default(ValueTest<T>);
    }

    public class SubClass : BaseClass<SubClass>
    {
        private String test = "test";

        public string GetTest()
        {
            return test;
        }
    }
}
```

Fixes https://github.com/mono/mono/issues/15760

---

The failure is happening when we are doing mono_class_setup_fields ("BaseClass<T>") which needs to decide for each field whether it is blittable or not. So therefore we are trying to decide if ValueTest<T> (that is: the ValueTest<U> field inside BaseClass<T>) is blittable or not.

So we instantiate U with T.
Now to decide whether VaueTest<T> is blittable or not, we look at every field.
So then we look at T value.
To decide if T is blittable we first check if it's a reference type.

That check is currently inadequate for generic parameters - what the PR adds is the ability to see if theres a T : class constraint or a T : C constraint - where C is some class. As soon as we know that T's constraint will force it to be a reference type we can definitely say that T won't be blittable without having to initialize C, at all.

Previously, Mono would see that T is some kind of type for which it couldn't definitively decide that it's a reference type and it would call: mono_class_setup_fields (field_class) which would then try to setup the fields of the parent class BaseClass<T>. And that would hit the recursion check.
2019-07-25 17:31:48 -04:00
Aleksey Kliger (λgeek) 090dffb9a0 [tests] Return non-zero exit code from MERP crash test on failure (#15804)
If any of the stress tests fail, return a non-zero exit code from the
supervising process.

Fixes #15781
2019-07-25 17:20:12 +02:00
Jay Krell ee34e2b122 [jit] [x86] Cleanup "_body" and finish conversion to x86_byte. (#15628) 2019-07-25 09:18:20 -04:00
Alexander Köplinger 6a196d6de8 [ci] Disable boehm on FreeBSD
It seems to cause issues and we don't want to spend time on boehm-related problems.
2019-07-25 01:38:00 +02:00
Cassio de Vargas Oliveira 8f0e9887b0 [System.ServiceModel] Add PUT, DELETE and OPTIONS handling to HttpReplyChannel (#15746)
Fixes #15740.
2019-07-25 01:09:41 +02:00
Calvin Buckley 68849282b3 Add community-supported FreeBSD CI to README (#15821) 2019-07-25 01:04:06 +02:00
Jay Krell 8cc7226834 ld configure: Add another dash to export-dynamic. (#15717)
GNU ld accept single or double dash, means the same thing.
AIX ld warns on single dash, errors on double dash, in autoconf, and then errors on single dash later.
We want the double dash so autoconf rejects it on AIX.
2019-07-25 01:02:46 +02:00
Filip Navara 30ce79f3f9 [netcore] Update CoreFX.issues.rsp (#15816)
Remove exclusions fixed by #14967
2019-07-24 22:04:56 +02:00
Aleksey Kliger (λgeek) 784b350c40 [cxx][llvm] Fix C++ build (#15807)
* [cxx] Fix LLVMModuleFlags var initialization

* [cxx] Fix C++ errors in mini-llvm.c
2019-07-24 12:37:57 -04:00
Jay Krell 9e78ce94d5 Remove unneeded auto cast with codeman. (#15792)
The uses are all void* or casted.
2019-07-24 17:31:26 +02:00
Stephen Toub 23cbdeba1b Re-enable CA1825 (zero-length array allocations) (dotnet/corefx#39708)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 17:27:08 +02:00
Vlad Brezae 4f84f21cbc [sre] Don't throw random exception when runtime shuts down (#15798)
Added here https://github.com/mono/mono/commit/89d1455a80ef`
2019-07-24 18:17:09 +03:00
Alexander Köplinger 6dff5fc813 Remove traces of w32process-win32-internals.h which was deleted by previous commit 2019-07-24 16:52:37 +02:00
Jay Krell f68c52c089 [Coop] Convert System.Diagnostics.{FileVersionInfo,Process}. (#15789) 2019-07-24 16:50:39 +02:00
Alexander Köplinger 57a6ebbf1a [netcore] Run tests only on public builds (#15812) 2019-07-24 15:26:48 +02:00
Vlad Brezae 71630cce75 [sre] Make creation of dynamic method synchronized
Before, reflection_create_dynamic_method could end up being called by two threads simultaneously. At the end of the method the ilgen field of the MonoReflectionDynamicMethod object is cleared, to enable its collection since it is no longer needed. The problem with this is that it can confuse the other thread compiling the dynamic method, making it see that there is no body.

We could either bother making this clearing work with multiple threads (and I'm not 100% convinced that the rest of the code is thread safe), disable the clearing of ilgen (which would make us use more memory) or go with the simple approach of locking on this DynamicMethod so only one thread is compiling it at one time.
2019-07-24 14:31:51 +02:00
Steve Pfister 2238c9dc5f Bump mono/corefx@eb5ba09 (#15799) 2019-07-24 07:50:52 -04:00
Alexander Köplinger 5f1da4d454 [ci] Add extra CI_TAGS for freebsd 2019-07-24 12:33:08 +02:00
Filip Navara 24bffd544a Update CoreFX.issues.rsp 2019-07-24 11:02:42 +02:00
Egor Bogatov 122494330d [netcore] Allow different enums as return type in CreateDelega… (#15787)
* Relaxed check for return type in CreateDelegate

* fix build errors
2019-07-24 09:50:29 +02:00
Marek Safar 2a01e1b125 [netcore] Update roslyn dependency 2019-07-24 09:45:03 +02:00
Jan Kotas 047a961ecd Fix build break in TimerQueue.Portable.cs
Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Sung Yoon Whang 3468ef668f Fix first value of counter payload being skewed (dotnet/coreclr#25739)
* Fix issue 25709

* rename

* Fix regression test

* cleanup

* Code review feedback

* set maxincrement to 3

Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Stephen Toub f8d61819b8 Make all event types nullable (dotnet/coreclr#25752)
Late-breaking design change: all events should be declared with nullable delegate types.

Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Stephen Toub 4ec5b8de98 Remove now unnecessary !s / TODO-NULLABLE comments (dotnet/coreclr#25749)
* Remove !s and TODO-NULLABLE comments for [DoesNotReturn]

* Remove !s and TODO-NULLABLE comments for [NotNullIfNotNull]

* Remove !s and TODO-NULLABLE comments for writes via Interlocked.CompareExchange

* Remove !s and TODO-NULLABLE comments for Debug.Assert on fields

* Update/add several TODO-NULLABLE comments

Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Santiago Fernandez Madero 0a683afa9a Fix nullability warnings from compiler update
Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Jan Kotas 176d523060 Delete unnecessary method (dotnet/coreclr#25661)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Stephen Toub ef3cbe9c56 Disable debugger evaluation of ValueTask<T>.Result (dotnet/coreclr#25727)
If the debugger evaluates a `ValueTask<T>`'s `Result`, that counts as the "you should only consume a `ValueTask<T>`" once, and ends up breaking / hanging / throwing exceptions and other bad stuff while stepping through code in the debugger.

This commit addresses that in two ways:
1. Adds `[DebuggerBrowsable(Never)]` to `Result` to prevent it from showing up in debugger views.
2. Adds a NotifyOfCrossThreadDependency call to its ToString.  This prevents the debugger from using ToString to show an implicit representation of the instance, and it forces the developer explicitly trying to access ToString (e.g. in the watch window) to click a button acknowleding the impact.

(Post 3.0, we should consider removing the `ValueTask<T>.ToString()` override altogether.)

Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Jan Kotas 927d8c322d Fix use of uninitialized variables in managed decimal implementation (#25674)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Stephen Toub c465ad1e80 Remove stale nullable !s and pragmas (dotnet/coreclr#25640)
Also update TODO-NULLABLE comments to be more specific where appropriate.

Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Stephen Toub 089743f733 Add AggressiveInlining to Single.GetHashCode (dotnet/coreclr#25633)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Stephen Toub 137c333cda Fix Timer argument exception parameter names (dotnet/coreclr#25617)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Stephen Toub 9d64e1ef74 Fix regression in Timers with long timeouts (dotnet/coreclr#25604)
* Fix regression in Timers with long timeouts

Early in .NET Core 3.0, we added an important optimization to significantly reduce lock contention and CPU overheads in situations where lots of timers were firing.  The optimization worked by splitting the set of timers into those expected to fire in the very near future and then everything else.  However, for really long timers (e.g. > 24 days), due to integer overflows we can accidentally put a long timer onto the short list and cause a timer that shouldn’t fire for days to instead fire in milliseconds.  This is not the first such bug we’ve had in Timer, and there is a fair amount of complicated casting (that we sometimes get wrong, obviously) in order to keep the tick count usage within the Int32 domain.  This PR addresses the problem (and hopefully others in the future) by switching over to using Int64.  We’re already paying to get 64-bit tick counts on both Windows and Unix, so this just removes truncation that was being performed, does a little more addition/comparison with 64-bit values instead of with 32-bit, and stores an Int64 instead of Int32 in each TimerQueueTimer.  On 64-bit, this has a 0 increase in memory consumption, as it simply ends up utilizing padding space that was previously in TimerQueueTimer.  On 32-bit, it increases memory allocation when creating a Timer by 4 bytes from 80 to 84 (still 3 allocations), but I believe it’s the right trade-off for reduced complexity and bug likelihood.

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-07-24 09:45:03 +02:00
Alexander Köplinger 70c72891f2 [netcore] Update Version.Details.xml
The earlier PR didn't update this file which is used by arcade for tracking.
2019-07-24 08:39:35 +02:00
Aleksey Kliger (λgeek) 7467ce4369 [netcore] Implement AssemblyLoadContext.InternalLoad (#15753)
Fixes https://github.com/mono/mono/issues/14830
2019-07-23 19:09:27 -04:00
Filip Navara 1551fa7951 [netcore] Bump CoreFX version to 5.0.0 (#15795)
* Bump CoreLib version

* Workaround to get dotnet to find dependencies

* Compile CoreLib with nullablePublicOnly
2019-07-24 00:53:30 +02:00
Zoltan Varga 69d179cba2 Avoid creating handles in a loop. 2019-07-23 12:55:55 -05:00
Zoltan Varga 4d1a6358d0 [runtime] Convert AssemblyBuilder.basic_init to handles using a gc handle to pin the object. 2019-07-23 12:55:55 -05:00
Zoltan Varga 063c3ed7f9 [runtime] Mark a few icalls as NOHANDLES. 2019-07-23 12:55:55 -05:00
Zoltan Varga 7b384f710c [runtime] Convert Environment icalls to handles. 2019-07-23 12:55:55 -05:00
Zoltan Varga fe015de078 Fix the netcore build. 2019-07-23 12:55:55 -05:00
Zoltan Varga 5ca052fca2 [runtime] Convert ValueType icalls to handles. 2019-07-23 12:55:55 -05:00
Larry Ewing 84af927e7d [wasm] clean up the clean targets 2019-07-23 12:16:22 -04:00
Zoltan Varga a9404577e6 [runtime] Convert locale code to use handles. (#15774)
* [runtime] Convert locale code to use handles.

* Sort a list of defines.

* Remove a do-while.

* Fix c++-ism.

* Use mono_string_handle_to_utf8 (). Update comments.
2019-07-23 11:33:20 -04:00
Jo Shields ce6c02e903 Forcibly clean working directory on every AzDO build (#15801) 2019-07-23 11:05:18 -04:00
Aleksey Kliger (λgeek) 148891b515 [cxx][netcore] Fix C++ build (#15786)
assembly.c `exact_sn_match` uses bitwise-or on MonoAssemblyNameEqFlags
2019-07-23 11:42:51 +02:00
Zebediah Figura 1854e439e5 [corlib] Foward System.Type.GetTypeFromProgID() to the correct function (#15693)
Fixes a stack overflow when running Staxel under wine-mono.
2019-07-23 11:17:28 +02:00
Alexander Köplinger 3e7f130739 [ci] Make sure global variables are really global
Using "def" in groovy makes it local to the run() method.
2019-07-23 10:27:53 +02:00
Kenneth Pouncey d46fa9b1e3 Add target for the browser threads tests run 2019-07-22 20:07:34 -04:00
Kenneth Pouncey 7cd7f5f9e1 Add running the browser tests for threads. 2019-07-22 20:07:34 -04:00
Ryan Lucia beb5553398 [netcore] Make assembly name parsing and comparison case-insensitive (#15522)
* Re-enable test

* Parse assembly info case-insensitively

* Lowercase the parsed public key token

* Case-insensitive comparison of public key tokens

* Fix string copy
2019-07-22 17:23:26 +02:00
Jo Shields 548fe0e0c1 Fix build on Autoconf 2.63 (#15636)
* Fix build on Autoconf 2.63

This was broken in e7f9dbe73c, because
AS_VAR_APPEND does not exist until v2.63b (?!)

* Work around autoconf for Mac not being fit for purpose

The correct way to do this is with AC_DEFUN in a special m4 file

But this dies on Mac, because reasons.

See also https://github.com/jedisct1/libsodium/issues/217
2019-07-22 17:20:47 +02:00
Maxim Lipnin ffe5446a40 Fix ambiguous time at the end of DST period on Windows 2019-07-22 17:12:46 +02:00
Ryan Lucia 54f608d08d Miscellaneous loader-related fixes (#15765)
* Clarify contents of list

* Fix mono_assembly_get_alc

* Remove pointless ifdef

* Prepend to domain_assemblies

* Revert "Prepend to domain_assemblies"

This reverts commit dbe6e47b80470fa13d22d97d32721d18c4764597.

* Ditch another ifdef
2019-07-22 10:58:12 -04:00
Vlad Brezae 009b0dd4c3 [interp] Enable inlining of object constructors (#15665)
* [interp] Split code for obj / vt newobj instruction

* [interp] Enable inlining of object constructors

If the ctor was inlined, the newobj instruction receives a max ushort as the data item for the index, so it doesn't execute the ctor in this case. Also, when inlining, we need to push on the stack the allocated object, once as argument for the ctor and the second needs to remain on the stack as the result of the IL newobj instruction.
2019-07-22 17:03:26 +03:00
Ryan Lucia 3c2813deb7 Special-case arrays of interfaces/generic parameters in IsAssignableFrom (#15749)
* Formatting fix

* Special-case arrays of interfaces/generic parameters

* Make more generic, fix typo

* Consider class constraint and add more elucidating comment

* Fix for potential crash

* Add test

* Fix test
2019-07-22 09:56:48 -04:00
Alexander Köplinger f497893a84 Add more tests to tarball with EXTRA_DIST 2019-07-22 15:23:09 +02:00
Aleksey Kliger (λgeek) 4138f096f8 [netcore] Re-enable AssemblyGetForwardedTypesLoadFailure (#15763)
Was fixed by https://github.com/mono/mono/pull/15752
2019-07-22 12:52:17 +02:00
Kenneth Pouncey e42d338e8f Add threads support to the SDK runtime generation.
- To enable the build with threads set `<EnableMonoWasmThreads>true</EnableMonoWasmThreads>`
   - default is false.
2019-07-19 17:33:08 -04:00
Kenneth Pouncey 98d8612b6b Fix packaging of the SDK when the runtime for threads does not exist
Closes https://github.com/mono/mono/issues/15734
2019-07-19 17:33:08 -04:00
Kenneth Pouncey eddd299c72 Add Signing.props file to common directory to be referenced from a common place
- Add the `Signing.props` to the `Directory.Build.props`
2019-07-19 17:33:08 -04:00
Maxim Lipnin e8d7f7c004 [netcore] Make System.Linq.Expressions.Tests.BindTests.GlobalField Pass (#15658)
`Expression.Bind` should throw `ArgumentException` if called with `FieldInfo` for a global field. The exception is thrown from validation of the (null) `DeclaringType` (see https://github.com/dotnet/corefx/pull/15318).
Mono returns `"<Module>"` in this case and doesn't throw so the test fails. 

Fixes #14917 .
2019-07-19 23:21:22 +02:00
Alexander Köplinger d159a38c47 [ci] Clean working directory after build in package and sdks build 2019-07-19 22:59:06 +02:00
Alexander Köplinger 1ab23207b5 [ci] Don't use method which is not allowed in Groovy sandbox 2019-07-19 22:52:01 +02:00
Alexander Köplinger 0c39f1f537 [ci] Fix OSX package builds to only be timer-triggered on master 2019-07-19 22:47:05 +02:00
Alexander Köplinger 6407d27000 [packaging] Don't use dl.xamarin.com for gtksharp package anymore 2019-07-19 22:16:34 +02:00
Alexander Köplinger 7bcba4e9bc [ci] Remove -f option from genhtml during code coverage
It needs some cpan modules to be installed which is a pain on OSX.
2019-07-19 22:10:38 +02:00
Alexander Köplinger 4909cf320f [ci] Run OSX package builds on master only once per day 2019-07-19 21:10:20 +02:00
Jay Krell 3e432663cd Remove mono_arch_free_jit_tls_data. (#15662) 2019-07-19 14:40:54 -04:00
Alexander Köplinger 49ed255707 [sdks] Calculate sha1 of sdks archive and upload it
This was requested by the XA team.
2019-07-19 20:05:48 +02:00
Ryan Lucia d685b72cb2 [netcore] Implement Thread.CurrentOSThreadId (#15748)
* [netcore] Implement Thread.CurrentOSThreadId

* Add comment explaining differences with mono_native_thread_id_get

* Add haiku implementation

* Attempt to fix linux builds

* Add MonoError parameter to icall
2019-07-19 13:22:50 -04:00
Sebastien Lebreton ec3cb3eb4e Fix TypeMirror.CSharpName computation 2019-07-19 10:42:00 -04:00
Kenneth Pouncey b85c584c0f WebAssembly.Core.Array.Pop should return null if the WebAssembly.Core.Array is empty instead of error. 2019-07-19 10:32:07 -04:00
Alexander Köplinger 3ff64f1efb [metadata] Fix name of header file
The file added as part of d5b374bb51 was actually called loaded-images-internals.h
2019-07-19 15:56:12 +02:00
Alexander Köplinger 7784f20a26 [ci] Don't require master node for reportGitHubStatus method
In some jobs we use throttle() logic which would mean only one job can execute on master, blocking other jobs in the meantime.

We don't really care which node executes this so let Jenkins pick one.
2019-07-19 14:50:10 +02:00
Egor Bogatov 8b2141a741 [netcore] Fix CI failures (#15745) 2019-07-19 14:06:04 +02:00
Alexander Köplinger a543958765 [ci] Add python3-pip package to wasm sdks build 2019-07-19 13:49:07 +02:00
Bernhard Urban 3f7d33ce85 [ios] Switch to python offset tool (#15744)
The C# version doesn't work on 64bit. It would require to update its dependencies, but Zoltan already added a Python version for WebAssembly which works fine.

Some notes:
* changed the semantics of `--xcode-path` in order to match the output of `xcode-select -p`
* switched to python3/pip3
* removed hack for arm64_32, it works properly now because the Python version uses stock `clang`
* removed some leftover usages of `XCODE32_DIR`.

Manually verified by comparing output with the C# version.

This will unblock the iOS team when building on Catalina/Xcode11, as they can't consume SDK archives there. See https://github.com/xamarin/xamarin-macios/pull/6603#issuecomment-512803082

Contributes to https://github.com/mono/mono/issues/9621
2019-07-19 13:48:02 +02:00
Aleksey Kliger (λgeek) 944cc96cac [netcore] Pass ALC in second loader request in load_reference_by_aname_default_asmctx (#15752)
Fixes crash in System.Reflection.Tests netcore testsuite in
System.Reflection.Tests.AssemblyNetCoreAppTests.AssemblyGetForwardedTypesLoadFailure
2019-07-19 07:44:07 -04:00
Alexander Köplinger 6ab8aff5dd [sdks] Add z option to tar
It's required on linux.
2019-07-19 12:49:38 +02:00
Alexander Köplinger a02f3aaf4b [sdks] Add linker sources to Android linux archive 2019-07-19 11:32:38 +02:00
Alexander Köplinger 349da3387c [sdks] Add third party notices and licenses to sdks archives (#15741)
It takes all THIRD-PARTY-NOTICES.TXT and LICENSE files from the repo.
2019-07-19 11:07:39 +02:00
Vlad Brezae c449308f8b [glib] Use clock_nanosleep if available (#15443)
According to the manual, it is recommended to use clock_nanosleep instead of nanosleep when the sleep can be repeatedly interrupted by signals and resumed. The remaining sleep interval was greater than the original timespec.

Fixes random timeouts of finalizer-abort.exe
2019-07-19 10:21:21 +03:00
Aleksey Kliger (λgeek) a37ad98b47 [loader] Pass ALC to mono_domain_loaded_internal, and then to domain search hook (#15743)
* Add a temporary mono_domain_ambient_alc function

Just use this to mark places where we need to pass through an ALC

* [runtime] Mark mono_assembly_loaded_full external only.

Runtime should use mono_assembly_loaded_internal.

* [loader] Add mono_install_assembly_search_hook_v2

Use it to install mono_domain_assembly_search and
mono_domain_assembly_postload_search.

The principal difference is that we can pass an assembly load context to the
hook.  But also we cleanup the "requesting assembly" hack for
mono_domain_assembly_postload_search.

* [domain] Comments and mono_assembly_get_alc ()

* [debugger] Comment on suspicious loader lock
2019-07-19 00:01:56 -04:00
Larry Ewing 34be988e33 Merge pull request #15704 from lewing/bump-msbuild-nuget-5.2
Bump msbuild to track xplat-master
2019-07-18 20:45:02 -04:00
Andy Hanson 25e79664b9 Return HardLimitBytes from GCMemoryInfo.TotalAvailableMemoryBytes (#25437)
* Add property HardLimitBytes to GCMemoryInfo

This adds a new property HardLimitBytes.

Unlike TotalAvailableMemoryBytes,
this will reflect an explicitly set COMPLUS_GCHeapHardLimit.

It will also reflect the fraction of a container's size that we use,
where TotalAvailableMemoryBytes is the total container size.

Normally, though, it is equal to TotalAvailableMemoryBytes.

Fix #38821

* Remove HardLimitBytes; have TotalAvailableMemoryBytes take on its behavior

* Fix typos

* Separate total_physical_mem and heap_hard_limit
so we can compute highMemoryLoadThresholdBytes and memoryLoadBytes

* Do more work in gc.cpp instead of Gc.cs

* Consistently end names in "Bytes"

Signed-off-by: dotnet-bot <[email protected]>
2019-07-18 19:10:21 -04:00
Aleksey Kliger (λgeek) 3f55bfb5cc [mini] Runtime check if boxing is needed for DIM constrained calls (#15729)
This is to handle the following example.  The issue is that in Check() we have
a constrained call where the called method is IAdder`1<!!U>::PlusPlus() which
is a default interface method, and we need to determine at runtime whether to
box the this argument.

```
using System;

public interface IAdder<T> {
	int Add (int x);

	int PlusPlus () {
		return Add (1);
	}
}

interface IGen3<T> { }

struct Adder<T> : IAdder<IGen3<T>> {
	int _field;
	public int Add (int x) {
		_field = x + _field;
		return _field;
	}
}

public class P {
	public static int Check<T, U>(T t) where T : IAdder<U> {
		return t.PlusPlus () + t.PlusPlus ();
	}

	public static void Main () {
		var x = new Adder<object> ();
		int y = Check<Adder<object>, IGen3<object>> (x);
		Console.WriteLine ("expect 2, got {0}", y);
	}
}
```
2019-07-18 16:46:55 -04:00
imhameed 561b400baa [interp] Use correctly-sized writes and reads in Unsafe.AddByteOffset and Unsafe.ByteOffset (#15677)
[interp] Use correctly-sized writes and reads in Unsafe.AddByteOffset and Unsafe.ByteOffset

The truncated store to the top of the stack in`MINT_INTRINS_UNSAFE_BYTE_OFFSET` could cause the upper bytes of the address used as the first argument to `ByteOffset` to linger, yielding inaccurate (and usually excessively large) offsets on systems where `sizeof(void *) > sizeof(guint32)`; this made
`System.Text.Unicode.Utf8Utility.GetPointerToFirstInvalidByte` return nonsense results.

The truncation in `MINT_INTRINS_UNSAFE_ADD_BYTE_OFFSET` hasn't, as far as I know, caused any test failures. But `AddByteOffset` takes an `IntPtr` as its second argument, not an `int`.

Fixes #14847.
2019-07-18 14:16:46 -04:00
Maxim Lipnin ab4eca1785 [netcore] Clean up rsp-file (#15700) 2019-07-18 18:34:10 +02:00
Egor Bogatov e6d2091a24 [netcore] Revise items in CoreFX.issues.rsp (#15664) 2019-07-18 18:33:38 +02:00
Aleksey Kliger (λgeek) d5b374bb51 [loader] Add MonoAssemblyLoadContext; stop sharing MonoImages on netcore (#15527)
Implement a couple of things:

1. Add a `MonoAssemblyLoadContext` opaque struct
2. On netcore Mono, use it to keep track of  which `MonoImage`s are loaded.  (Addresses part of #13891) 

In a bit more detail:

- Add a `MonoLoadedImages` struct to hold the hash tables that we use for checking if a `MonoImage` is already loaded
- Add an opaque `MonoAssemblyLoadContext` typedef
- (Framework Mono) Add a `get_global_loaded_images()` function to get the shared `MonoLoadedImages`
- (netcore Mono) Add a `MonoAssemblyLoadContext` struct that owns a `MonoLoadedImages` and add a `default_alc` member to `MonoDomain
- Pass a `MonoAssemblyLoadContext*` to most `MonoImage`-loading functions - on Framework Mono its usually NULL and we fall back to the global loaded images, on netcore Mono it's usually `domain->default_alc->loaded_images`
- (netcore Mono) Create a default Assembly Load Context when a `MonoDomain` is created
- Add a `MonoAssemblyLoadContext*` field to `MonoAssemblyLoadRequest` and pass an ALC in a few places.

---

Remaining work:

(netcore Mono) There are still places where a `MonoAssemblyLoadRequest` or a `MonoAssemblyOpenRequest` has a `NULL` ALC - those will need to be tracked down and fixed.

(netcore Mono) Eventually `MonoAssemblyLoadContext` should keep track of the loaded `MonoAssembly`s, not just images.  One goal on netcore Mono is to ifdef out `MonoDomain:domain_assemblies`.


---



* [loader] Add a MonoLoadedImages struct to own the MonoImage sharing

   Initially, there's just a single global set of loaded images.

   Once we have AssemblyLoadContext support, each ALC will have a separate set.

   NOTE:
     - Some of the existing Mono API is difficult to support with this design
       since it assumes each MonoImage is loaded at most once.

* [loader] Add a MonoAssemblyLoadContext member to MonoImage for netcore

* [loader] Unregister image from its owner when closing

* [loader] Pass MonoLoadedImages to register_image

* [domain] Add mono_domain_default_alc and mono_alc_get_loaded_images

* [loader] Add an AssemblyLoadContext argument to mono_image_loaded_internal

* [metadata] Add mono_image_get_alc ()

* [loader] Pass MonoAssemblyLoadContext to mono_image_open_from_data_internal

* [loader] Pass MonoAssemblyLoadContext to mono_image_open_from_module_handle

* [loaded] Pass MonoLoadedImages to mono_image_open_a_lot_parameterized

* [loader] Pass MonoAssemblyLoadContext to mono_image_open_a_lot

* [runtime] Mark mono_image_open_full external only

   Runtime should use mono_image_open_a_lot.

* [runtime] Mark mono_image_loaded_by_guid external only

   Also mark mono_image_loaded_by_guid_full external only

   Runtime will need some (as yet unwritten) mechanism that takes a MonoAssemblyLoadContext as an argument.

* [domain] Create a default ALC for each MonoDomain

* [netcore] Pass default ALC in mono_core_preload_hook

   If the assembly name matches a trusted platform assembly, open it in the default ALC of the root domain

* [mini] Open main assembly in default ALC in the root domain

* [netcore] Don't define get_global_loaded_images()

   Every assembly load request should come from an assembly load context.  Each ALC has a set of loaded images.  So we should never need a global list.

   With this PR, we no longer share MonoImages across distinct ALCs.  So in principle, each ALC can open the same assembly but resolve its references in different ways.

   Fixes part of https://github.com/mono/mono/issues/13891

* [runtime] Mark mono_pe_file_open external only

* [loader] Pass MonoAssemblyLoadContext to mono_image_open_raw  and mono_image_open_metadata_only

* [loader] Pass MonoAssemblyLoadContext to do_mono_image_open and set MonoImage:alc

* [loader] Add version 2 of assembly preload hook

   Pass MonoAssemblyLoadContext through the preload hook.  This is used in mono_assembly_request_byname_nosearch which, in turn, is called by load_reference_by_aname_default_asmctx which is used to resolve references from one assembly to another.

* [netcore] Pass native ALC ptr to AssemblyLoadContext.InternalLoadFile

* [netcore] Implement AssemblyLoadContext.InternalInitializeNativeALC

   also implement mono_domain_create_individual_alc ()

* [netcore] Pass ALC to System.Reflection.Assembly.InternalLoad

   Pass the domain default ALC to mono_assembly_load ()

   Also pass MonoAssemblyLoadContext to mono_assembly_load_full_gac_base_default ()

* [loader] Implement MONO_LOADED_IMAGES_ASSEMBLY properly

   Store the MonoLoadedImages for netmodules in the MonoImage for the main image of an assembly.  This is also used by SRE - the dummy module of the AssemblyBuilder has the loaded_images that contains the ModuleBuilders.

* [loader] Use global_loaded_images for netmodules with framework Mono

   The new stuff is only for ALC support in netcore

* [loader] Drop netmodule support in MonoAssemblyLoadContext

   netmodules are not supported in netcore

* [loader] Spin out image hashing out of image.c

   Move MonoLoadedImages support code to loaded-images.c loaded-images-global.c and loaded-images-netcore.c

Also spin out assembly-load-context.c for MonoAssemblyLoadContext functions

* Move ALC icall to assembly-load-context.c

* formatting fix

* [msvc] Add new files to .filters

* update comments

* [image] Change mono_loaded_images_remove_image to decrement the refcount

Decrement the refcount and remove the image from the loaded images hashes in
one place.  Change mono_loaded_images_remove_image to return TRUE if the rest
of image unloading should proceed or not.

* [loader] Drop unused argument to mono_alc_init
2019-07-17 17:35:15 -04:00
Jay Krell e2ce0a16a6 Fix leaks in mono_lookup_internal_call_full_with_flags, for lack of destructors. (#15659)
* Fix leaks in mono_lookup_internal_call_full_with_flags, for lack of C++ destructors.

* Initialize `sigstart` also.
2019-07-17 12:09:18 -07:00
Jay Krell b08aa71948 configure/makefile To support updating zlib to 1.2.11. (#15697) 2019-07-17 12:07:56 -07:00
Ryan Lucia 86e22c4a7f Print two bytes at a time in mono_pe_file_map conversion error (#15523)
* Print two bytes at a time

* Iterate over gunichar2
2019-07-17 11:49:30 -07:00
Alexander Köplinger c62473114a Add com.apple.security.cs.allow-unsigned-executable-memory exception to hardened runtime entitlements (#15721)
This avoids the issue from https://github.com/mono/mono/issues/13445 when hardened runtime is enabled.
2019-07-17 20:48:06 +02:00
Larry Ewing 36b9e006f3 Merge pull request #15713 from lewing/sdk-disable-gac
[ios][android] disable gac in ios and android sdk builds
2019-07-17 09:09:36 -04:00
Filip Navara 9af45e09db [netcore] Clear system last error before P/Invoke calls with SetLastError=true (#15703)
Fixes #15691
2019-07-17 14:44:50 +02:00
Alexander Köplinger 0509ceccb6 Revert "[ci] Remove separate utils.groovy file" and run step on master instead
This reverts commit d732cef5fc.

The github commit status setter step requires a node context so we now just use on on master instead.
2019-07-17 14:26:24 +02:00
Egor Bogatov 4febac951e [bcl] Sync recent NS2.1 changes (#15696)
1) Copied changes from corefx for System.Data (also https://github.com/mono/corefx/pull/310)
2) New Tracing api is left empty (because the current API is empty too)
3) New AES types throw PNSE

Bump netstandard.dll AssemblyVersion to 2.1 (fixes https://github.com/mono/mono/issues/13412)
2019-07-17 13:08:29 +02:00
monojenkins b61a4368c0 [bcl] Update BCL Linked Size 2019-07-17 06:42:24 -04:00
Alexander Köplinger ba1c7da0b9 [bcl] Add Mono.Cecil.Mdb assembly to monodroid_tools profile (#15710)
* [bcl] Add Mono.Cecil.Mdb assembly to monodroid_tools profile

Requested by the XA team.

* [csproj] Update project files
2019-07-17 11:19:04 +02:00
Alexander Köplinger d732cef5fc [ci] Remove separate utils.groovy file
For some reason when using a separate file and loading the function
from there Jenkins still requires us to have a node() context when
calling the function which is not what we want.

(cherry picked from commit d410e07d8b)
2019-07-17 10:57:38 +02:00
Larry Ewing 3a075b0b1e [wasm] disable gac in wasm runtime (#15686)
* [wasm] disable gac in wasm runtime

* [wasm] disable gac wasm.mk not configure.ac
2019-07-17 04:56:42 +02:00
Zoltan Varga 553fee6f03 [runtime] Fix the error message for exceptions created from MonoError. (#15705)
Fixes https://github.com/mono/mono/issues/15692.
2019-07-16 21:09:39 -04:00
Alexander Köplinger 39472e06a3 [ci] Wait for signing outside of a node() block
We don't need to block the machine just for waiting on signing to finish.
2019-07-17 01:01:42 +02:00
Larry Ewing 6727d1a39b [ios][android] disable gac in ios and android sdk builds 2019-07-16 18:22:26 -04:00
Zoltan Varga 978653633b [interp] Make the code GC safe on wasm. (#15695)
* [interp] Pass the vtable to get_virtual_method () to reduce the number of objrefs being passed around.

* No longer a prototype.

* [interp] Make the code GC safe on wasm.

* Use frame->o only on WASM.
2019-07-16 17:49:33 -04:00
Jay Krell 43f1a26804 Fix use of freed memory. (#15660)
Fix use of freed memory.
Move the free later, on the assumption that the free itself doesn't use memory now freed before it.
Found with Valgrind.
2019-07-16 13:16:52 -07:00
Alexander Köplinger 7480830b36 [ci] Bump timeout for .pkg signing job
In preparation for notarizing our .pkg with Apple we need to bump the timeout
since it can take up to an hour for Apple's server to return a result.
2019-07-16 21:32:13 +02:00
Aleksey Kliger (λgeek) d8a679375d [netcore] Use the strict loader (#15668)
Mono historically was quite lax in how it resolved assembly references - it
would pick the first assembly with a matching simple name.  The "strict"
mode (available in framework Mono with `--assembly-loader=strict`) follows the
spec behavior: the version and public key token of the candidate assembly must
match what is requested.
2019-07-16 20:30:16 +02:00
Filip Navara d2f7851c92 [netcore] Ignore public key when matching assemblies (#15678)
Related to #15669
2019-07-16 11:05:26 -07:00
Larry Ewing ee2b1089ff Bump msbuild to track xplat-master 2019-07-16 10:43:54 -04:00
Alexander Köplinger 709ba3faa5 Revert "Update dependencies from dotnet/corefx"
This reverts commit 4e513f802a.

It broke a few netcore tests.
2019-07-16 16:31:50 +02:00
Alexander Köplinger cef723ca9c [sdks] Use Azul Zulu OpenJDK for Android Linux build, since Debian 10 has no Java 8 2019-07-15 23:25:26 +02:00
Alexis Christoforides 532605f533 [System] Keep events from firing from a disposed 'DefaultWatcher' FileSystemWatcher
Fixes https://github.com/mono/mono/issues/8747

Also try to stop other implementations from dispatching events past Dispose(), without guaranteeing it
2019-07-15 23:25:32 +03:00
Alexander Köplinger 4b6f49bb06 [sdks] Update android linux builds to Debian 10
This was suggested by XA folks to fix the weird mingw llvm issues we've been seeing.
2019-07-15 21:36:04 +02:00
Larry Ewing 11ca09b3bb [wasm][size-diff] fix typo in wasm targets (#15676) 2019-07-15 20:25:33 +02:00
Alexander Köplinger 4e513f802a Update dependencies from dotnet/corefx 2019-07-15 17:52:29 +02:00
dotnet-maestro[bot] 157728ce0d [master] Update dependencies from dotnet/corefx (#15689)
* Update dependencies from https://github.com/dotnet/corefx build 20190714.1

- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19364.1

* Update dependencies from https://github.com/dotnet/arcade build 20190703.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19353.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19353.1

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/corefx build 20190703.3

- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19353.3

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08
2019-07-15 17:14:49 +02:00
Thays Grazia 73128453da [debugger] Don't list finalizer gc thread if it's not executing managed code (#15618)
* The example that reproduces the bug does this:
var thread = vm.GetThreads()[0];
greetingValue = program.InvokeMethod(thread, greeting, new Value[0]) as StringMirror;

But sometimes the Thread[0] was the MainThread of the program and it works, and other times was the GC Finalizer, but when it tries to run something on GC Finalizer thread, the thread is not suspended and throws an exception.
In the fix I removed the Finalizer thread if it's not executing a managed code of the list that is returned when CMD_VM_ALL_THREADS is called.

Fix #13311
2019-07-15 11:58:04 -03:00
Alexander Köplinger d85fe2c391 [System] Remove FileSystemWatcher tests from monotouch/xammac
They were already excluded from watch and tv but they don't work on any mobile Apple profile.
2019-07-15 15:17:27 +02:00
Jay Krell ceb09980f5 Fix leak in create_runtime_invoke_info when mono_class_vtable_… (#15661) 2019-07-15 11:34:54 +02:00
Jay Krell 6cd6f65f69 Trim mono_mini_arch_lock, mono_mini_arch_unlock, mini_arch_mutex. (#15663) 2019-07-15 11:34:34 +02:00
Bernhard Urban 9a19bdb6e6 [llvm] avoid FP elimination on iOS/armv7 (#15617)
[llvm] avoid FP elimination on iOS/armv7

Instead of
```
push    {r4, r5, r6, r7, r10, r11, lr}
```

LLVM will generate
```
push    {r4, r5, r6, r7, lr}
add     r7, sp, #12
push    {r9, r10}
```

Seems like this https://github.com/mono/llvm/commit/a04e9e4a0af16f15ace258e81448b7eeca5ff599 assumes that `-disable-fp-elim` is passed for iOS targets. I wondered why this wouldn't break things for them, but when you run `clang` from Xcode with `-v`, you will discover that its driver passes `-mdisable-fp-elim`.

Together with https://github.com/mono/llvm/pull/48 this fixes crashes with FullAOT+LLVM on iOS 32bit.

Fixes https://github.com/mono/mono/issues/15058

Contributes to https://github.com/mono/mono/issues/9621
2019-07-14 16:15:55 -04:00
Aleksey Kliger (λgeek) 70e9f8c501 Add configure flag to disable GAC support; disable GAC in netcore (#15681)
* [runtime] Add configure flag to disable GAC support

* [netcore] Disable GAC support
2019-07-13 11:36:37 -04:00
Larry Ewing 016a5253bb Merge pull request #10202 from Unity-Technologies/fix-dynamic-method-marshal-info
Don't try to access metadata for dynamic method added to non-dynamic …
2019-07-12 18:22:01 -05:00
Steve Pfister 611b94cb41 [ios] Nil Check to Ensure Local TimeZone Id is Set For TimeZon… (#15682)
In runtime.m added nil check in xamarin_timezone_get_local_name. Returns Local as the Id in the case of nil.
2019-07-12 20:56:45 +02:00
Alexander Köplinger e3d5b23ff9 [ci] Upload mac-entitlements.plist to azure when uploading .pkg
So it can be used by the codesigning job.
2019-07-12 19:46:50 +02:00
monojenkins 45c82cc647 [bcl] Update BCL Linked Size 2019-07-12 20:15:06 +03:00
Jo Shields 202dca075b Add hardened runtime testing to Catalina lane (#15589)
* Permit DYLD mangling, so p/invokes work from non-system paths

* Add com.apple.security.cs.disable-library-validation

This is required for the .dylibs used in p/invokes to work.

* Use adhoc signing
2019-07-12 15:29:00 +02:00
Alexander Köplinger 02829bb914 [ci] Add back accidentally removed check 2019-07-12 15:27:39 +02:00
Kenneth Pouncey f3aaade4c7 [wasm][sdk][tests] Use the SDK to build the browser tests (#15605)
# Fix the runtime paths evaluation.
- If running from a master build the runtime builds path is different from the nuget paths.
  - From a master build the runtime builds are found in `wasm\builds` now.

# Browser Tests modifications:
- Moved all sources to a sources directory `tests\browser\src\`.
- Create a solutions project that can be built by VSfMac or VS using the SDK
- Create separate projects for each TestSuite.
- Change makefile target for the browser tests to use `dotnet` to build instead of the `packager.exe`

# SDK modifications and fixes:

Fix sdk build to run `monolinker.exe` using `dotnet`
- Run `mono` as task tool if running from `dotnet` and not running under Windows instead of executing the `monolinker.exe` directly
- Clean up WasmLinkAssemblies code.
   - Add routine to determine if build was initiated from `dotnet` instead of msbuild.
   - Add common routine to find the correct monolinker.exe to execute depending on running local or nuget.

Without the previous fixes, `monolinker` step can fail with the following message when using `dotnet build`

```
.nuget/packages/mono.webassembly.build/0.1.0-preview1/build/netstandard2.0/Mono.WebAssembly.Build.targets(76,3): error MSB6006: "monolinker.exe" exited with code 8.
```

The faling msbuild target is:

```
      _MonoWasmLink:
         /Users/Jimmy/.nuget/packages/mono.webassembly.build/0.1.0-preview1/build/tools/monolinker.exe --verbose --exclude-feature
         ... the rest of the command is cut off from here to save space

```

With the fixes command above becomes the following which execute the `monolinker` with `mono`. :

```
      _MonoWasmLink:
         /Library/Frameworks/Mono.framework/Versions/Current/Commands/mono /Users/Jimmy/.nuget/packages/mono.webassembly.build/0.1.0-preview1/build/tools/monolinker.exe --verbose --exclude-feature remoting --exclude-feature com

         ... the rest of the command is cut off from here to save space
```
2019-07-12 14:44:40 +02:00
Jay Krell 81ed8dfaff extern "C" reduction. (#15634) 2019-07-12 12:01:35 +02:00
Marek Habersack 461ceae59b Fix offsets tool for Android NDK r20
Android NDK r20 contains a header file (`ioctl.h`) with this code:

    int ioctl(int __fd, int __request, ...);

    #if !defined(BIONIC_IOCTL_NO_SIGNEDNESS_OVERLOAD)
    /* enable_if(1) just exists to break overloading ties. */
    int ioctl(int __fd, unsigned __request, ...) __overloadable __enable_if(1, "") __RENAME(ioctl);
    #endif

The `_RENAME` macro is defined as `__asm__(x)` and serves the purpose of
replacing an existing symbol with the new one, decorated with the keyword.
Unfortunately, Mono's `offsets-tool` doesn't parse the header properly as
`CppSharp` doesn't understand `__asm__`:

    Processing triple: armv7-none-linux-androideabi
    Error parsing '/Users/rodo/git/xa2/external/mono/mono/metadata/metadata-cross-helpers.c'
    /Users/rodo/android-toolchain/ndk/sysroot/usr/include/bits/ioctl.h(60,5): error: conflicting types for 'ioctl'
    Error parsing '/Users/rodo/git/xa2/external/mono/mono/mini/mini-cross-helpers.c'
    /Users/rodo/android-toolchain/ndk/sysroot/usr/include/bits/ioctl.h(60,5): error: conflicting types for 'ioctl'
    make: *** [/Users/rodo/git/xa2/external/mono/sdks/builds/android-cross-arm-release/armv7-linux-android.h] Error 1

The workaround, implemented in this commit, is to define the
`BIONIC_IOCTL_NO_SIGNEDNESS_OVERLOAD` macro thus removing the "conflicting"
declaration from the picture, which changes nothing from the offset tool's point
of view and lets us process the headers in NDK r20 properly.
2019-07-12 12:41:54 +03:00
Zoltan Varga 04034032f4 [jit] Fix the devirt of EqualityComparer<byte>. (#15644)
* [jit] Fix the devirt of EqualityComparer<byte>.

* Add a test.

* Fix the tests.
2019-07-12 01:24:52 -04:00
Steve Pfister 537fc4b60d [ios] Ensure Local TimeZone Id is Set For TimeZoneInfo.Local (#15667)
* Fixes https://github.com/mono/mono/issues/14839

The local timezone name was not known and defaulted to "Local".
This change adds an sdk function that returns the local name.
2019-07-11 23:45:03 +02:00
Egor Bogatov 792bfbff91 [netcore] Do not inline ThrowHelpers, fix SkipFrames handling. (#15607)
1) Do not inline ThrowHelpers (e.g. `static void ThrowException() => throw new Exception();`)
2) `get_trace` incorrectly handles `skip` argument
3) fix broken ci (`dl-test-assets.py` is not python2 compatible any more)

Fixes https://github.com/mono/mono/issues/15182
Fixes https://github.com/mono/mono/issues/15188
2019-07-11 21:42:14 +02:00
Egor Bogatov 972cd65365 [netcore] Fix IsAssignableFrom (#15641)
Mono used to return `true` for these three cases (see System.Reflection.Tests.TypeTests.IsAssignableFrom tests):
```csharp
using System.Reflection;
using Xunit;

namespace ConsoleApp
{
    public static class Program
    {
        static void Main(string[] args)
        {
            Assert.False(typeof(TI_Interface1[]).GetTypeInfo().IsAssignableFrom(
                         typeof(TI_StructWithInterface[]).GetTypeInfo()));

            Assert.False(typeof(int?[]).GetTypeInfo().IsAssignableFrom(
                         typeof(int[]).GetTypeInfo()));

            Assert.False(typeof(int[]).GetTypeInfo().IsAssignableFrom(
                         typeof(int?[]).GetTypeInfo()));
            
        }
    }
    
    public interface TI_Interface1 { }
    public struct TI_StructWithInterface : TI_Interface1 { }
}
```
Fixes https://github.com/mono/mono/issues/10848
Fixes https://github.com/mono/mono/issues/15080

Unrelated  System.Reflection.MetadataLoadContext.Tests tests that don't fail anymore:
Close https://github.com/mono/mono/issues/15351
Close https://github.com/mono/mono/issues/15348
Close https://github.com/mono/mono/issues/15347
Close https://github.com/mono/mono/issues/15346
Close https://github.com/mono/mono/issues/15345
Close https://github.com/mono/mono/issues/15343
Close https://github.com/mono/mono/issues/15342
Close https://github.com/mono/mono/issues/15341
Close https://github.com/mono/mono/issues/15338
Close https://github.com/mono/mono/issues/15337
Close https://github.com/mono/mono/issues/15336
2019-07-11 21:41:11 +02:00
Zebediah Figura 2f1b50bfbf [metadata] Respect unmanaged calling conventions in function signatures. (#15363)
According to ECMA-335 § II.15.3, calling conventions other than "default" and
"vararg" describe unmanaged methods. Accordingly they should be treated as
pinvokes so that that their calling conventions are respected.
2019-07-11 14:38:03 -04:00
Micah N Gorrell 1002a4de2b [Mono.Security] Allow importing certificates from authenticode assemblies (#14210)
This change allows a number of games, such as DARK, to start successfully. The games use X509Certificate.CreateFromSignedFile() to load the certificate from their assemblies in order to verify them.

* Added support for creating an AuthenticodeDeformatter for an assembly
that has been loaded into memory

* Allow importing a certificate from an assembly signed with authenticode
when using BTLS

* Allow importing a certificate from an assembly signed with authenticode
when not using BTLS

* Added a test for loading certificates from assemblies signed with
authenticode
2019-07-11 19:09:33 +02:00
Calvin Buckley 41469ee55a Misc AIX/PASE tweaks (#15651)
* Partial enablement of alternate stack for AIX/i

It turns out much like macOS, AIX doesn't like to do mprotect/valloc
for the first thread's guard pages, so skip those. It seems mostly
fine except for one or two crashes causes it to grab the wrong IAR
and deadlock dumping memory. As such, leave the code and configure
script override to disable in place, just change the comment and
add support code.

* Use Qp2getifaddrs on PASE

Not sure if proper way to implement. Reuses getifaddrs code as much
as possible, since it's merely a name change based on the docs, due
to it being namespaced in case AIX gets it or something.

I'm not sure how many of these codepaths still work properly;
one had a questionable order of ifdef.

This will eventually prepare for CoreFX NetworkInterface, so test
it here.
2019-07-11 12:42:47 -04:00
Alexander Köplinger 37f5ef91bb Bump bockbuild to fix gtk build break 2019-07-11 17:29:33 +02:00
Alexander Köplinger 439ab4fb4c Bump bockbuild to get https://github.com/mono/bockbuild/pull/105 2019-07-11 16:08:01 +02:00
Jay Krell 2950bd39e1 Remove configure cruft -- Interlocked and GetProcessId. (#15633)
They are never checked and all relevant systems have all of them.
2019-07-11 13:39:11 +02:00
Jay Krell 7bdff9065b Cleanup mono_threads_platform_get_stack_bounds. (#15632)
Fix mingw warning unused function __readfsdword.
2019-07-11 13:35:57 +02:00
Steve Pfister 625be3d1fd Bump mono/corefx@17dd540 (#15654) 2019-07-11 13:30:01 +02:00
Steve Pfister 53a0a9eaf4 Add TypeForwards for FileSystemName & CryptographicOperations (#15652)
* Add TypeForwards for:

* System.IO.Enumeration.FileSystemName
* System.Security.Cryptography.CryptographicOperations

Since these were removed in NS 2.1

* Bump API snapshot submodule
2019-07-10 23:58:59 +02:00
Thays Grazia 4917c086b6 [debugger] Add intrinsic for creating a byte array (#15591)
Fixes #15268
2019-07-10 23:29:13 +02:00
Vlad Brezae 2f2a9bcc37 [interp] Add JitHelper intrins for enum comparison (#15635)
Fixes https://github.com/mono/mono/issues/15596
2019-07-10 20:42:50 +03:00
Ryan Lucia 370e76dfc8 [netcore] Don't default to mscorlib in Assembly.GetType (#15488)
* [netcore] Don't default to mscorlib in Assembly.GetType

* Add argument for whether or not to search mscorlib

* Reorder and rename search_mscorlib argument

* Use gboolean exclusively
2019-07-10 09:21:56 -07:00
Jay Krell 7a486d8f43 Remove quadratic behavior from g_strconcat. (#15630)
Prefer strlen + memcpy over strcat.
2019-07-10 12:06:51 -04:00
Jay Krell 58fc782d86 Fix warning: unused function get_address_from_sockaddr (#15631) 2019-07-10 10:36:46 +02:00
Jay Krell 77c269721e Provide g_strnlen to replace strnlen for portability to older systems. (#15626)
See https://github.com/mistydemeo/tigerbrew/issues/605.
See https://www.gnu.org/software/gnulib/manual/html_node/strnlen.html.
2019-07-09 23:43:12 -04:00
Kenneth Pouncey 8b8fd0a820 Create package of the templates
- Create a `Mono.WebAssembly.Templates.cproj`
- Moved the existing DotNet template to a new subfolder Templates\templates
- Add `dotnet pack` of the project to the Makefile.
2019-07-09 20:36:48 -05:00
Zoltan Varga 5fb57b4fbd [wasm] Bump emscripten to 1.38.38. (#15639) 2019-07-09 20:51:54 -04:00
Zoltan Varga cba874139d [interp] Avoid declaring MonoError's in interp_exec_method_full (), it increases the native stack frame size because the optimizer can't seem to figure out live ranges. (#15613)
* [interp] Avoid declaring MonoError's in interp_exec_method_full (), it increases the native stack frame size because the optimizer can't seem to figure out live ranges.

* Remove some unused fields from InterpFrame.
2019-07-09 15:16:46 -04:00
Thays Grazia d33747a6e3 [debugger] Update client thread frames after SetIP. (#15449)
* Fixes #13408

PR of draft https://github.com/mono/mono/pull/14667

* Disabling test on Interpreter.
2019-07-09 16:07:46 -03:00
Kenneth Pouncey a6983e4a37 Add threads option
```

  --threads (enable threads)
        type: bool  default: false

```
2019-07-09 13:26:24 -05:00
Kenneth Pouncey 742c98c5b4 Update 2019-07-09 13:26:24 -05:00
Kenneth Pouncey 46025dab20 Change formatting 2019-07-09 13:26:24 -05:00
Kenneth Pouncey 607027b544 Update docs
- Include threading
2019-07-09 13:26:24 -05:00
Martin Baulig cf609799f0 [System]: Allow reading fully buffered HttpWebResponse body… (#15220)
[System]: Allow reading fully buffered `HttpWebResponse` body after close.

If we have already read the entire response body, then we should allow the
user to read it even after the request has been aborted.

* `WebConnectionStream.Read ()`: Move `Operation.ThrowIfClosedOrDisposed ()`
   call down after argument checks and call a new protected abstract method
   called `TryReadFromBufferedContent ()` prior to it.

* `WebResponseStream.TryReadFromBufferedContent ()`: Implement it here.
  If the entire response body has been buffered, then `bufferedEntireContent`
  is true and `innerStream is BufferedReadStream` and we can call the new
  `BufferedReadStream.TryReadFromBuffer ()`.

* `WebResponseStream.ReadAllAsync ()`: Set `bufferedEntireContent = true`
   after reading the entire response body.

* `BufferedReadStream.TryReadFromBuffer ()`: New internal method.

Fixes #10645.
2019-07-09 19:26:42 +02:00
Zoltan Varga 2cefbc18df [jit] Add support for valuetype arguments to gsharedvt constrained calls. (#15610) 2019-07-09 11:40:06 -04:00
dotnet-maestro[bot] 6f24998e8b [master] Update dependencies from dotnet/corefx (#15608)
* Update dependencies from https://github.com/dotnet/corefx build 20190707.5

- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19357.5

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/corefx build 20190703.6

- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19353.6

* Update dependencies from https://github.com/dotnet/arcade build 20190703.19

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19353.19
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19353.19

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08
2019-07-09 14:12:26 +02:00
Egor Bogatov 9dc20c9b5f [netcore] Fix netcore CI lane (#15627) 2019-07-09 13:29:19 +02:00
Alexander Köplinger b2ba8e62ca Make RemoteExecutor a no-op on all mobile profiles (#15611)
Starting another Mono process for the remote executor doesn't work on any of them.

Helps with https://github.com/mono/mono/issues/15328
2019-07-09 11:45:00 +02:00
Zoltan Varga aeacedfd38 Remove support for llvm36, its not used anymore. (#15619)
* Remove support for llvm36, its not used anymore.

* [jit] Remove support for older llvm versions.
2019-07-09 11:44:17 +02:00
Jay Krell 5a0bc3cf81 [profiler] Fix printf bug -- char* vs. MonoString* (#15602)
Gcc warned.
2019-07-09 11:24:39 +02:00
Jay Krell 369f796d8d [jit] [x86] [amd64] Cleanup with x86_byte() (#15600) 2019-07-09 11:12:52 +02:00
Jay Krell 39b52e2da8 Access mini_debug_options directly within the runtime. (#15594)
We had some inconsistency around accessing mini_debug_options in the runtime (both directly as well as through the function, mini_get_debug_options). This PR makes the access consistent through the runtime.
2019-07-09 11:12:15 +02:00
Alexander Köplinger 9cec2b0da3 [ci] Remove check-seq-points step from CI runs
The test was disabled with https://github.com/mono/mono/pull/15623
2019-07-09 11:11:04 +02:00
Jay Krell 135eaa1758 Disable check-seq-points test. (#15623)
See https://github.com/mono/mono/pull/15599#issuecomment-509444313.
See https://github.com/mono/mono/pull/15567.

Alternative to https://github.com/mono/mono/pull/15599 and part https://github.com/mono/mono/pull/15567.
2019-07-09 11:09:29 +02:00
Jan Kotas 9335f2637e Cleanup IL linker heuristic usage (dotnet/coreclr#25547)
Prep-work for using mainstream IL linker

Signed-off-by: dotnet-bot <[email protected]>
2019-07-09 08:39:16 +03:00
Alexis Christoforides c6bf6370dd The regression is the accidental removal of RegisterReportingForNativeLib from the managed side, introduced by b919ac4#diff-939ea9baecd2e8b24260bcb33f531274 2019-07-09 01:34:44 +03:00
Jay Krell e4bc8790d3 runtime.h remove extern "C" and distribute normally instead of extra. (#15558) 2019-07-08 13:59:05 -04:00
Johan Lorensson 12c962835f Align native_handle open/close for MonoThreadInfo/MonoInternalThread on Windows. (#15482)
* Align native_handle open/close for MonoThreadInfo/MonoInternalThread on Windows.

* Drop assert on DuplicateHandle failure.

* Fix native thread handle gpointer conversion.
2019-07-08 13:50:17 -04:00
Alexander Köplinger 784449a077 [sdks] Fix android sdks job, take 2
It needs to work for both debug and release configs.
2019-07-08 19:34:32 +02:00
Jay Krell 63126b72f7 Remove some unused third party code. (#15475)
i.e. C++ helpers for Boehm GC.
2019-07-08 19:30:14 +02:00
Alexander Köplinger 305b2e76e6 [sdks] Fix android sdks job
It would try to execute the .stamp-android-loader-path target in unrelated configurations.
2019-07-08 18:04:23 +02:00
Thays Grazia ebebfe263b Crashes on running the boring.il test from coreclr, the problem was that using [System.Runtime]System.String the type was not understood as the primitive type string. (#15552)
Using ilasm from coreclr and running on mono it works, because of that I decided to fix on ilasm and not on runtime.

Fixes #13923
2019-07-08 10:22:19 -03:00
Zoltan Varga cb330378cf [runtime] Implement mono_verifier_class_is_valid_generic_instantiation () etc. even if the verifier is disabled. (#15564)
Fixes https://github.com/mono/mono/issues/15551.
2019-07-08 10:36:49 +02:00
Jay Krell f19bc96343 mono_native_tls_get_value that does not change LastError. (#15568) 2019-07-08 09:44:23 +02:00
Jay Krell 963ba77863 Inline GetLastError and SetLastError. (#15560) 2019-07-08 09:42:54 +02:00
Egor Bogatov 55cc1d6d8f [netcore] Throw ICE for Array.Copy(object[], enum[]) (#15585)
* test

* undo rsp changes

* Fix ICollection_NonGeneric_CopyTo_ArrayOfEnumType

* group all "requires precise gc" issues

* Add more gc precise tests (and a flaky one)
2019-07-07 09:11:03 -04:00
Ryan Lucia 851dfdb98a Convert dl-test-assets.py to Python 3 (#15524) 2019-07-06 17:34:30 -04:00
Jay Krell d540aee31f Cleanup zlib-helper.c allocations -- move integer overflow checks into calloc. (#15505) 2019-07-06 14:59:27 -04:00
Zoltan Varga de5dca2264 [jit] Add missing float conv.u8.ovf.un conversion. (#13907)
* [jit] Add missing float conv.u8.ovf.un conversion.

* Add support for the float64 bit version as well.

* Fix interpreter support.
2019-07-06 05:47:47 -04:00
Jay Krell 1cb8e04331 Distribute sgen-dynarray.h via source, not EXTRA_DIST. (#15559) 2019-07-05 18:05:13 +02:00
Jay Krell 2b7e2d2f34 Remove extra explicit dist. (#15557)
Automake sees through the conditionals.
2019-07-05 18:04:22 +02:00
Radek Doulik 0991905c8b [sdks] Use @loader_path for mono and libmonosgen (#15580)
* [sdks] Use @loader_path for mono and libmonosgen

This way we are able to dynamically load libmonosgen and also use host
mono binary.

The library dependencies look like this after the change:
```
otool -L /Users/rodo/git/mono/sdks/out/android-host-Darwin-release/bin/mono
/Users/rodo/git/mono/sdks/out/android-host-Darwin-release/bin/mono:
	@loader_path/libmonosgen-2.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	...

otool -L /Users/rodo/git/mono/sdks/out/android-host-Darwin-release/lib/libmonosgen-2.0.dylib
/Users/rodo/git/mono/sdks/out/android-host-Darwin-release/lib/libmonosgen-2.0.dylib:
	@loader_path/libmonosgen-2.0.dylib (compatibility version 2.0.0, current version 2.0.0)
	...
```
2019-07-05 17:38:19 +02:00
Bernhard Urban 5a5cbcc0a7 [sdks] sanity check for maximum number of open file descriptors (#15582)
Default for `ulimit -n ` seems to be 256, that isn't enough for the Android SDK build.
2019-07-05 17:19:08 +02:00
Alexander Köplinger 3ffe317138 [netcore] Only do CI builds on master
We don't care about the 2019-xx branches yet.
2019-07-05 17:15:12 +02:00
Alexander Köplinger bc269dc39e [netcore] Read NETCORETESTS_VERSION and NETCOREAPP_VERSION fro… (#15584)
* [netcore] Simplify CI build invocation

We now have build.sh as a one-stop entry to the build system.

* [netcore] Read NETCORETESTS_VERSION and NETCOREAPP_VERSION from eng/Versions.props

The Versions.props is auto-updated by Arcade so we automatically get new versions.
2019-07-05 17:03:49 +02:00
dotnet-maestro[bot] 3b3829e33c [master] Update dependencies from dotnet/arcade (#15550)
* Update dependencies from https://github.com/dotnet/arcade build 20190703.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19353.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19353.1

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/corefx build 20190703.3

- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview8.19353.3

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.05

- Microsoft.NETCore.App - 3.0.0-preview8-27903-05

* Update dependencies from https://github.com/dotnet/core-setup build 20190703.08

- Microsoft.NETCore.App - 3.0.0-preview8-27903-08
2019-07-05 17:03:09 +02:00
Egor Bogatov 3a7afab91c [netcore] CI work, add rsp for Windows (#15549) 2019-07-05 17:02:44 +02:00
Jay Krell e7f9dbe73c Link with -z now or -bind_at_load. (#14562)
Advantages:
 Dynamic linker gets out of the way of random function calls,
 in terms of timing, in terms of locking, and in term of success,
 and possibly in terms of security (readonly function pointers).
 If you successfully load, then you can make function calls with impunity,
 without regard as to if they are in the same .so as the caller, well,
 assuming they are to a leaf like libc, or to something itself built with -z now.

 The "success" is significant, as otherwise loaded LLVM has unresolved symbols lurking, depending on which code paths you send it down.

Disadvantage: Slower startup.

Mixed:
 Platform consistency, since this is how Windows behaves usually (unless you say link /delayload)

This will combine well with an upcoming revision of https://github.com/mono/mono/pull/14524.

Difficult alternative: Force the binding along sensitive paths by calling their callees earlier.
Typical alternative: Ignore the matter.

Android: It is believed this switch produces a warning, which is ignored, there is no affect, and it is unclear if the behavior is actually "now" or "lazy". Logs could be checked and a test run, but neither.
2019-07-05 15:54:16 +02:00
Jay Krell 4cf527f6d9 Readonly codemanager callbacks. (#15538) 2019-07-05 15:46:10 +02:00
Jay Krell 28ec3644ef Make thread locals just always extern. (#15563)
Making them static for C is not worth the ifdef.
2019-07-05 15:38:15 +02:00
Jay Krell b84b85688b Win32 zlib support. (#15509)
Fixes https://github.com/mono/mono/issues/15503

Always statically link on Windows (msvc and mingw).
This is a somewhat old zlib, and will be updated shortly (https://github.com/mono/mono/pull/15480)

Note that zlib is not valid C++, so always compile as C.
2019-07-05 14:38:56 +02:00
Steve Pfister 063985e04d Bump mono/corefx@9354dfd (#15545) 2019-07-05 14:35:14 +02:00
Bernhard Urban 808592925b [android] switch cross compilers host from 32bit to 64bit (#15553)
Untested, but we need to do it anyway soon. This will help us to understand the situation on Xamarin.Android while finishing the work for Xamarin.iOS.

Contributes to https://github.com/mono/mono/issues/9621
2019-07-05 13:58:38 +02:00
Johan Lorensson b1b61d7cb7 Interpreter reads last error to late after pinvoke. (#15571)
* Interpreter reads last error to late after pinvoke.

This could lead to clobbered last error since interpreter loop needs to
run two additional IL instructions in order to read out the value. This works
on JIT since the lowering saving the last error will happen right after
pinvoke.

This fix makes sure interpreter will get needed information to read out
last error right after pinvoke (if requested).

It adds a new IL prefix issued in managed->native wrapper that will tell
codegen (and interpreter) that upcoming calli instruction needs to save
last error, meaning that it could be done right after issuing the call,
no need to run any additional IL instructions to do that work, closing
the gap between the return of pinvoke call and save of last error.

Should fix, https://github.com/mono/mono/issues/15541.

* Optimize emit_get_last_error.
2019-07-05 10:30:17 +02:00
Kenneth Pouncey a90b735cf8 Update ,gitignore (#15561)
- emsdk_env.sh
- builds/threads
2019-07-05 07:29:52 +02:00
Kenneth Pouncey d8f2ebe384 Add a package.json to the tests/runtime directory. (#15573)
- Installs the required packages to run
- Modify make target `run-threads-sample` to use npm to install and run the test.
- There are two targets in the package.json file one for `test` and another 'start`
2019-07-05 05:43:50 +02:00
Larry Ewing 6530ba9861 [wasm] Add BlazingPizza.Client to size tesets 2019-07-04 19:48:34 -05:00
Jan Kotas a288cb1aae Delete some dead code (dotnet/coreclr#25546)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-04 19:18:35 +03:00
Jay Krell 5637cbd42d Do not compile metadata support/compress.c. (#15535) 2019-07-04 16:05:17 +02:00
Maxim Lipnin e0da61d691 [netcore] Make System.Reflection.Tests.TypeTests.GetEnumUnderlyingType Pass (#15510)
* [netcore] Make System.Reflection.Tests.TypeTests.GetEnumUnderlyingType Pass

* Remove recursive name parsing in case of "+" character; remove if condition for nested names
2019-07-04 09:10:18 -04:00
Alexander Köplinger 16750e4fd9 [netcore] Trigger Azure Pipelines builds only for master and release branches
Also batch changes so the system waits until a build is completed,
then queues another build of all changes that have not yet been built.
2019-07-04 09:16:56 +02:00
Larry Ewing 03d5525757 [wasm] allow overriding the build command invocation 2019-07-03 23:37:58 -05:00
Kenneth Pouncey 1a08a840c2 Fix the directory paths after threads commit
- Add threads build directories to the Runtime package.
2019-07-03 17:24:52 -05:00
Jay Krell 167709be8c Make sure TLS (thread local storage) is always TLS and not FLS (fiber local storage).
The Windows SDKs are inconsistent (and clearly documented as so), and the JIT assumes TLS.
2019-07-03 15:45:47 -05:00
Thays Grazia fb49d2d631 [debugger][wasm] Display content of "this" (#15528)
* Implementing watch of variable "this"
Fixes #15446

* Fixing indentation.
2019-07-03 12:15:18 -03:00
Vlad Brezae 6136d51ae9 [interp] Simplify MINT_NEWOBJ_ARRAY 2019-07-03 09:08:20 -05:00
Vlad Brezae aa7b713715 [interp] Make newarr lockfree
Before this commit, we were creating the array class from the element class during run time, also taking a lock in the meantime. This makes array allocation 2x faster. (on multithread much faster)
2019-07-03 09:08:20 -05:00
Johan Lorensson e30184752b Abort async suspend request on failure doing preemptive suspend. (#15486)
When a preemptive suspend fails, state machine will get into an invalid
state and the thread is in an unknown state (running/self-suspended). In case of
failure in mono_threads_suspend_begin_async_suspend, a new method should be
called, mono_threads_transition_abort_async_suspend making sure state machine
reflects correct thread state as well as reporting correct result to initial
caller of mono_threads_suspend_begin_async_suspend.
2019-07-03 13:08:05 +02:00
Jay Krell 08feb423c1 HAVE_DL_LOADER is never used so remove it. (#15500) 2019-07-03 11:01:59 +02:00
Jay Krell 33b4d2695e AC_DEFINE instead of AC_SUBST MONO_DL_NEED_USCORE. (#15499)
i.e. so it can be used in C instead of make.
i.e. so it can actually work.

The lone use is here:
```
C:\s\mono2\mono\utils\mono-dl.c(271):#if MONO_DL_NEED_USCORE
```
2019-07-03 11:01:19 +02:00
Jay Krell 177ae36c7a Do not compile unused support/uncompr.c. (#15516) 2019-07-03 10:59:38 +02:00
Egor Bogatov 57f362207c [netcore] Clean up CoreFX.issues.rsp (#15526) 2019-07-03 10:58:50 +02:00
Zoltan Varga c533ad99ce [wasm] Ongoing work. (#15504)
* [wasm] Avoid AOTing mscorlib if the input file haven't changed.

* [wasm] Store the wasm builds in a builds/ subdir.

* [wasm] Add a run-chrome- target to run test suites under chrome using a puppeteer script.

* [wasm] Link with -O0 in debug mode.

* [wasm] Add a runtime-threads make target.

* [wasm] Compile driver.o etc. with -Oz. Make the build-native -> packager.exe dependency order only.

* [wasm] Run the threads sample using chrome.

* Bump emscripten to 1.38.37.

* Fix the build.

* Fix the tests.

* Fix the tests.
2019-07-03 08:48:51 +02:00
Rich Lander 8fe4109ead Add entry for GCC (#15473) 2019-07-02 17:57:38 +02:00
Michal Strehovský 29e1d630b4 Use Array.MaxArrayLength in ArrayList (dotnet/coreclr#25530)
Now that `ArrayList` is in CoreLib, we don't need the copy.

Signed-off-by: dotnet-bot <[email protected]>
2019-07-02 17:26:31 +02:00
Jay Krell 4b074e842b Correct MONO_DL_NEED_USCORE for C++, and memcpy is faster than strcpy. (#15498) 2019-07-02 11:09:32 -04:00
Alexander Köplinger e843b52098 [netcore] Add DARC subscriptions for Microsoft.NETCore.App 2019-07-02 15:11:32 +02:00
Johan Lorensson 5fee1d3eea Add support for TLS callbacks on Windows. (#15423)
* Add support for TLS callbacks on Windows.

Mono runtime depends on DllMain to be called by OS in order to correctly
detach threads from the runtime. If this doesn't happen,
threads from native thread pools (not owned by runtime) and attached
using native->managed callback, won't detach resulting in attached
threads no longer running. Since threads are still attached
to runtime, next GC will try to suspend the thread and that will fail
and that in turn will put the state machine in an incorrect state,
bringing down the runtime at next GC (when the thread state is revisited).

This problem is currently handled by DllMain, but since DllMain only exist
in DLL's, statically link Mono runtime will get us into the above scenario.

This commit add support to hook up a TLS callback using the same mechanism
used by MSVC linker and c-runtime (also available under MINGW). The
callback will be included in a section/segment of an object file and included
in final image (DLL or EXE) by linker and called by OS loader, solving the
problem with static linked Mono runtime not being able to detach terminating
threads.

The commit keeps current DllMain method when building a DLL but
includes a mechanism making sure we only use one of the callback techniques
at runtime, if both have been included in final image. This will simplify the build
of libmini since we can always build the object including the callback, regardless
how the library will be consumed.
2019-07-02 14:06:57 +02:00
Alexander Köplinger b62878973d [netcore] Add DARC subscriptions for Microsoft.Private.CoreFx.NETCoreApp
It contains the corefx test assets.
2019-07-02 13:56:09 +02:00
Bernhard Urban 6f7da4ce49 [stats] distinguish between mini and LLVM AOT method (#15483)
[stats] distinguish between mini and LLVM AOT method

Also print the stats on shutdown when configured with `--with-core=only`
2019-07-02 04:55:50 -04:00
Zoltan Varga adbb7df7ce [netcore] Remove some unused SRE icalls. (#15484) 2019-07-02 04:27:48 -04:00
Jay Krell d956cf687c Fix const warning. (#15478) 2019-07-02 09:08:05 +02:00
Jay Krell caecad895a Make codeman not public (#15415)
Seems a bit obscure to be public, the header is not public.
2019-07-02 09:07:18 +02:00
Zoltan Varga 4473e761c5 Fix make package. 2019-07-01 22:15:21 -05:00
Zoltan Varga 5767de0213 Fix some targets. 2019-07-01 22:15:21 -05:00
Zoltan Varga 708d1948e4 Make a local copy of emsdk_env.sh for the interpreter builds. 2019-07-01 22:15:21 -05:00
Zoltan Varga 6304c094db Make a local copy of emsdk_env.sh during the ninja build. 2019-07-01 22:15:21 -05:00
Zoltan Varga e84e9e786d Avoid calling emsdk_env.sh, it calls emsdk update_env which is racy. 2019-07-01 22:15:21 -05:00
Zoltan VargaandLarry Ewing aacd83ad39 Fix formatting.
Co-Authored-By: Larry Ewing <[email protected]>
2019-07-01 22:15:21 -05:00
Zoltan VargaandLarry Ewing f01cb9c9d2 Fix formatting
Co-Authored-By: Larry Ewing <[email protected]>
2019-07-01 22:15:21 -05:00
Zoltan Varga beea086ec9 Enable threads builds on CI. 2019-07-01 22:15:21 -05:00
Zoltan Varga 3970c6112a Add back some stubs for the non-threads build. 2019-07-01 22:15:21 -05:00
Zoltan Varga 648bef053e Set Module.mainScriptUrlOrBlob so workers can load it. 2019-07-01 22:15:21 -05:00
Zoltan Varga 16ed192da3 Add missing file. 2019-07-01 22:15:21 -05:00
Zoltan Varga b40a624898 [wasm] Add threads support to the packager. 2019-07-01 22:15:21 -05:00
Zoltan Varga 7c3adaf873 [wasm] Implement pthreads support in the runtime. 2019-07-01 22:15:21 -05:00
Zoltan Varga e21bed53a0 [wasm] Allow overwriting EMSCRIPTEN_SDK_DIR. Add a runtime build with threads support if ENABLE_WASM_THREADS is defined in Make.config. 2019-07-01 22:15:21 -05:00
Zoltan Varga 7fa884b721 [wasm] Add a threads sample. 2019-07-01 22:15:21 -05:00
Zoltan Varga bc787a8a01 [runtime] Disable a a AC_TRY_RUN when cross-compiling. 2019-07-01 22:15:21 -05:00
Zoltan Varga 20a8edacb8 [wasm] Add a make define for wasm runtime builds. 2019-07-01 22:15:21 -05:00
Steve Pfister d39c84d45f [netcore] Remove IsByRef check on Reflection.Emit.DynamicMethod
Fixes https://github.com/mono/mono/issues/15324

Removed check on the return type being by ref.
2019-07-01 21:12:06 -04:00
Martin Baulig 3508cd8026 [System.Net.Http]: Delete broken Send_Transfer_Encoding_Custom() test. (#15470)
This test was checking a broken Mono-specific behavior, which has been
removed after we switched to the new corefx-based handler. It also does
not make much sense to use a `Transfer-Encoding` header with a GET request.
2019-07-02 01:27:42 +02:00
Johan Lorensson 51a11b68c5 Disable zlib on mingw Windows build to avoid dependency on zlib (#15493)
#4484 broke Windows mingw build due to new dependency, zlib1.dll not available in PATH on build bots. Disabling for now until we know how this should be handled (and also fixed for MSVC build runtime).
2019-07-02 01:15:37 +02:00
Alexander Köplinger 1a1e921efe Bump bockbuild to bring in fix for mono/mono#14957 2019-07-02 00:30:58 +02:00
Marek Safar 71d1b10c3e [netcore] Bump Roslyn 2019-07-01 23:01:13 +02:00
Michal Strehovský 68872c4a60 Use AssemblyLoadContext from shared partition (dotnet/corert#7570)
We were missing methods that got added for 3.0. The only LoadContext that works is the default one though.

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Stephen Toub d0d2096fc7 Fix ActivityTracker ES_BUILD_STANDALONE build
Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Koundinya Veluri 306e8c3cd6 Fix an assertion failure in the thread pool's QueueUserWorkItemCallbackBase (#25482)
Fixes https://github.com/dotnet/coreclr/issues/25242
- The issue could be that there is no memory barrier (or in the wrong place) on the thread reading the value, and an old value could be cached and read

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Santiago Fernandez Madero 4dfd7437a7 React to new compiler nullability warnings
Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Jan Kotas c88c0dd873 Fix typo & make the code leaner (dotnet/coreclr#25442)
Enum.HasFlag generates bigger IL and depends on complex JIT optimization for a good code.
The classic bit check is strongly preferred accross CoreCLR and CoreFX.

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Stephen Toub 45e5bb8ec0 Tweak nullable attribute per API review (dotnet/coreclr#25443)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Levi Broderick 83a9ee16fb Fix EncoderNLS / DecoderNLS regression in reporting error index (#25397)
Also fixes incorrect asserts in the Encoding type

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Ben Adams aeb8b0fa8f Don't show AggressiveInlining items in exception stacks (#25408)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Tanner Gooding c754857c0e Reverting the ShouldRoundUp logic to not change for custom numeric format strings. (#25400)
Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Jan Kotas 674f8876cc Delete DeserializationBlockedException (dotnet/coreclr#25393)
Contributes to dotnet/corefx#36723

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Stephen Toub 1543276813 React to compiler respecting nullable attributes on properties
Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Tarek Mahmoud Sayed 0890f588e9 Map C Locale to Invariant (dotnet/coreclr#25373)
ICU map the C locale to en-US_POSIX which has a non desired collation behavior as it doesn't support case insensitive comparison.
This change is to force mapping C locale to Invariant instead.

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Jan Kotas cc779bd7e3 Fix StackChange value for OpCodes.Stelem (dotnet/coreclr#25382)
Fixes dotnet/corefx#37955

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Santiago Fernandez Madero 4da8b52e28 Address last round of nullable feedback - S.Resources.ResourceManager, System.Reflection.Emit and ILGeneration (#25318)
* Address nullable feedback for System.Resources.ResourceManager

* Address nullable feedback for System.Reflection.Emit.ILGeneration

* Address nullable feedback for System.Reflection.Emit

* PR Feedback and clean-up redundant casts

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Tanner Gooding c471996c8b Updating Dragon4 to ensure the number buffer always provides a significant digit if one exists. (#25096)
* Updating Dragon4 to ensure the number buffer always provides a significant digit if one exists.

* Changing System.Number.RoundNumber to not round up floating-point numbers.

* Re-enabling the RealFormatterTestsBase CoreFX tests

* Updating Number.RoundNumber to take a isCorrectlyRounded parameter and to use IEEE compliant rounding for floating-point numbers.

* Change SinglePrecisionCustomFormat to 7, ensuring it matches the value used in netcoreapp2.1

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Ganbarukamo41 52814eb6bb Make Vector*.ToString() Culture invariant (dotnet/coreclr#25343)
* Remove IFormattable
* Hardcode characters
* Add tests

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 23:01:13 +02:00
Egor Bogatov d20fe8ec37 [netcore] Fix Array.Copy* tests. Bump NETCORETESTS_VERSION ver… (#15428)
* Fix Array.Copy* tests

* simplify code

* Add comments

* Address feedback

* Update CoreFX.issues.rsp

* Fix SRE tests

* Add comment

* bump versions again
2019-07-01 20:20:25 +02:00
Maxim Lipnin 15668a6292 Bump corefx (#15463)
This PR will bring mono/corefx#303
2019-07-01 19:01:23 +02:00
Miguel de Icaza de18c594f0 [metadata] Rename, null-initialize, and properly free *args variables (#13855) 2019-07-01 12:11:02 -04:00
Rich Lander 241d2d1809 Create THIRD-PARTY-NOTICES.TXT
Use: https://github.com/mono/mono/blob/6a9950c5d22a1d748a2163ce6bdbc7fa6ffd8e77/mcs/tools/sqlmetal/src/DbLinq/Test/Providers/ReadTest_Complex.cs#L571
2019-07-01 17:16:51 +02:00
dotnet-maestro[bot] 36b0c02463 [master] Update dependencies from dotnet/arcade (#15477)
* Update dependencies from https://github.com/dotnet/arcade build 20190630.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19330.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19330.1
2019-07-01 17:10:47 +02:00
Michal Strehovský 75dfa5c298 Remove AggressiveOptimization flag from System.Text (dotnet/coreclr#25356)
Based on conversation with Levi, I don't think this flag is needed.

The flag currently controls two things:
* Disqualifies the method from precompilation
* Disables Tier-0 JIT for the method

Removing the attribute allows us to precompile some of the methods (not all, because of `Vector<T>`). It measurably helps improve startup time because many of the attributed methods are complex and take a while to compile.

Once tier-1 JIT kicks in, the generated code should be identical to what we were getting before.

Signed-off-by: dotnet-bot <[email protected]>
2019-07-01 17:07:00 +02:00
Jay Krell 8c20d5c67a Remove unused AMD64 JIT CALLCONV_IS_STDCALL. (#15416) 2019-07-01 09:53:01 +02:00
Larry Ewing df74f5227f [wasm][debugger] remove args parsing hack 2019-06-30 12:25:40 -05:00
Larry Ewing 3b337e31c3 [wasm] use the router for all requests 2019-06-30 12:25:40 -05:00
Larry Ewing 18b031870e [wasm] remove TabMapper and just filter values key by key
proxy the version response through our logic so that we match
the actual protocol versions. Refactor the mapping logic so we
just rewrite specific keys that we understand and pass the rest
along.
2019-06-30 12:25:40 -05:00
Larry Ewing f293fd7174 [wasm] make the host url a uri 2019-06-30 12:25:40 -05:00
Larry Ewing 9455030364 [wasm] use options directly in other places 2019-06-30 12:25:40 -05:00
Larry Ewing 0065b50c93 [wasm] Start reworking the server logic for the Proxy and Debugger
Split some of the configuration logic out into options so that
we can start moving away from a fixed configuration.
2019-06-30 12:25:40 -05:00
Larry Ewing d7cfc6994a [wasm] make extract_conn_url return null on unexpected data
We want to avoid throwing inside ErrorDataReceived on unexpected
input because tends to hang the process in a bad state.  Instead
we return null from extract_conn_url and let the normal cleanup
process happen.
2019-06-30 12:25:10 -05:00
Rich Lander 40ebd4e815 Add entry for Silicon Graphics and HP
For https://github.com/mono/mono/blob/d58dfa185af1d48fb93efdef1d046762f214f0a7/libgc/include/gc_allocator.h
2019-06-29 20:54:42 +02:00
lateralusX be77d03c22 Fix 32-bit build error when using C++ compiler. 2019-06-29 13:48:34 -05:00
Katelyn Gadd c239906a01 Disable compiler server on darwin. Add force-enable option for compiler server. (#15450) 2019-06-28 18:24:09 -04:00
Filip Navara c788634b54 Add tests 2019-06-28 14:56:47 -05:00
Filip Navara cbe365b659 Fix marshalling bugs for StringBuilder parameters 2019-06-28 14:56:47 -05:00
Jo Shields 4421ebc1f2 Correct env vars used for Android directory override (#15469)
This fixes https://github.com/mono/mono/pull/15453

The issue is the env var names differ vs. Xamarin.Android
2019-06-28 15:29:37 -04:00
Jo Shields 714da9f5be Use /mnt/scratch for Android SDK, to match https://github.com/… (#15453) 2019-06-28 19:20:41 +02:00
Maxim Lipnin efa0a0bb3a Fix time zone transition out of DST (#15401)
When a datetime appears in range of [end_of_DST_period - Daylight_delta; end_of_DST_period] it's not DST and should return base offset.

Fixes #9664.
2019-06-28 19:04:21 +02:00
Kenneth Pouncey dfb9cdd072 Fix generation of wrong version. 2019-06-28 10:55:35 -05:00
Ryan Lucia c879bc4691 [netcore] Fix Assembly.GetForwardedTypes() (#15452)
* [netcore] Make GetForwardedTypes return nested types

* [netcore] Throw proper error in GetTopLevelForwardedTypes

* Remove unnecessary function

* Formatting

* Re-enable relevant tests

* Switch to REFERENCE_MISSING

* Use local error
2019-06-28 11:54:27 -04:00
dotnet-maestro 9bf0809439 Update dependencies from https://github.com/dotnet/arcade build 20190627.39
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19327.39
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19327.39
2019-06-28 17:27:39 +02:00
dotnet-maestro 5da074c43d Update dependencies from https://github.com/dotnet/arcade build 20190626.44
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19326.44
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19326.44
2019-06-28 17:27:39 +02:00
Zoltan Varga 112297ef5c [runtime] Implement support for embedded ppdb, when the ppdb blob is compressed and embedded into the pe image. 2019-06-28 15:19:43 +02:00
Jay Krell 19681ad2d4 Fix year+ old MIPS compile break. (#15459)
Fixes https://github.com/mono/mono/issues/15441
2019-06-28 11:28:05 +02:00
Alexander Köplinger 4e022f7f07 Replace two more MONO_DEBUG=clr-memory-model env vars with commandline switches
Follow up to https://github.com/mono/mono/pull/15447
2019-06-28 10:19:16 +02:00
Kenneth Pouncey 6b5113220c Simplify the file generation and remove the Encoding="Unicode" option 2019-06-28 01:01:58 -05:00
Kenneth Pouncey c692828f49 Add a target to set the version of the Templates's sdk version in the global.json.
- The `_WriteDotNetTemplateVersion` is called from the sdk build.

```
"Mono.WebAssembly.Sdk": "0.1.0-preview1"
```
2019-06-28 01:01:58 -05:00
Kenneth Pouncey 4c1cf2c148 Trying BeforeTargets="_GenerateRestoreProjectSpec" 2019-06-28 01:01:58 -05:00
Kenneth Pouncey 7e2433d9f4 Modify _CreatePackagesDir
- Another try
2019-06-28 01:01:58 -05:00
Kenneth Pouncey 1a2f43d4cb Address review comments separate versions for each sdk package
- Update to use only the SDK package version.
2019-06-28 01:01:58 -05:00
Kenneth Pouncey 6e6580beba Rename target to prefix it with an underscore to indicate that users should not call it directly. 2019-06-28 01:01:58 -05:00
Kenneth Pouncey 99e64a970f Add target to create packages directory if it does not exist. 2019-06-28 01:01:58 -05:00
Kenneth Pouncey 5ca42e24fb Remove the WebAssembly.Net.Http.xml file that was inadvertently commited 2019-06-28 01:01:58 -05:00
Kenneth Pouncey c9db6a08f1 Add versioning to the sdk and framework project files.
- Add a central versioning file `common\Versions`
- Modify projects to use the central version file
- Auto generate a versions file for the SDK versions so that they can be updated automatically.
2019-06-28 01:01:58 -05:00
Zoltan Varga a29cbc429d [netcore] Avoid calling mono_runtime_install_appctx_properties () in aot mode. (#15448) 2019-06-27 23:16:47 -04:00
Thays Grazia c011456f3f [dim] Emit error when calling abstract methods (#15433)
* Emitting bad image exception when a non virtual call is calling an abstract method.

* Fixing side-effect.
Implementing the same thing on interpreter.
Adding unit test.
2019-06-27 22:02:39 -03:00
Zoltan Varga 064d367ede Pass the --clr-memory-model flag on the command line instead of MONO_DEBUG so its not inherited by child processes. (#15447) 2019-06-27 20:44:39 -04:00
lateralusX c5ef80bf86 FIx id formatting to align with rest of code. 2019-06-27 14:59:59 -05:00
lateralusX 56d38ca430 Fix incorrect thread state on suspend thread failure.
According to documentation of mono_threads_suspend_begin_async_suspend:

"If begin suspend fails the thread must be left uninterrupted and resumed."

Current implementation on Windows didn't resume thread in case GetThreadContext
fails, leaving a thread in suspended state on failure.

Fix is to resume thread if GetThreadContext fails.
2019-06-27 14:59:59 -05:00
lateralusX 973f430d45 Fix use THREAD_SUSPEND_DEBUG macros on Windows.
Several errors in current implementation, both compile time errors as
well as warnings.
2019-06-27 14:59:59 -05:00
dotnet-maestro 6ae04f597d Update dependencies from https://github.com/dotnet/arcade build 20190626.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19326.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19326.2
2019-06-27 14:21:36 +02:00
Steve Pfister 814d20db91 [netcore] Review and document netcore test failures that are skipped (#15359)
* Went through the majority of corefx tests that were being skipped in CoreFX.issues.rsp.

For each failure, a github issue was logged and if possible, a more expanded
failure reason was specified.

Part of the https://github.com/mono/mono/issues/14787 epic work

* Cleaned up header that no longer had tests in it

* Pesky -method still around.  It'll ignore now
2019-06-27 14:14:02 +02:00
Ryan Lucia 8e4d1eb06f Disable flaky test HttpClientTest.CancelRequestViaProxy 2019-06-26 21:01:58 -05:00
Ryan Lucia 19bb89805a CreateNLSocket and CloseNLSocket should return gpointer (#15408)
In managed, these functions are used as `static external IntPtr`. This means that previously on arm64 the top bits of the return value were garbage. A comparison with 64-bit -1 like in LinuxNetworkChange.EnsureSocket would never be true, which was causing us to hit other assertions in the runtime.
Co-authored-by: Aleksey Kliger <[email protected]>
2019-06-26 15:41:11 -04:00
Steve Pfister 452fa3b50c Update CODEOWNERS (#15429) 2019-06-26 15:14:07 -04:00
Johan Lorensson b70694828d Fix unused-function warning in main.c. (#15424) 2019-06-26 19:16:11 +02:00
Aleksey Kliger (λgeek) 927c608184 [sdks] dynamically link libmonosgen to mono-sgen for monodroid host builds (#15410)
* [configure] Cosmetic AC_MSG_WARN fix

* [runtime] Mark mono_file_map_error as MONO_API, always

Fixed the `--with-static_mono=no` build on non-Win32

* [sdks] dynamically link libmonosgen to mono-sgen for monodroid host builds
2019-06-26 11:10:03 -04:00
Jay Krell cad60fce03 Remove mono_tls_get_tls_getter. 2019-06-26 07:14:30 -05:00
Jay Krell 8d6feabf0d Replace MONO_PATCH_INFO_GET_TLS_TRAMP with MONO_PATCH_INFO_JIT_ICALL_ADDR_NOCALL. 2019-06-26 07:14:30 -05:00
Vlad Brezae 6359520633 [sgen] Fix crashes in sgen due to xdomain refs
CADMessages are passed directly between appdomains. When using contained data, we need to make sure we don't create any cross domain references.

When domains are unloaded, all threads executing code in that appdomain are aborted and the entire heap is traversed and objects in that appdomain are cleared. If any objects in other domains are directly referencing objects in the unloaded domain, they will reference junk. If any, cross domain refs should only be allowed when the referenced object is in the root domain which is never unloaded.
2019-06-26 07:13:07 -05:00
Martin Baulig c56b37e00d [test-helpers]: Don't use named Mutexes on mobile. 2019-06-26 07:11:08 -05:00
Vlad Brezae aa05d4f43c [interp] Reduce computation under calc_section mutex
Calc_section mutex is meant to be a lower level mutex used only for synchronization on InterpMethod contents. Before this commit we were taking the loader mutex which was leading to deadlocks.
2019-06-26 07:10:37 -05:00
Larry Ewing f185358d96 [wasm] update the debugger instructions 2019-06-26 07:10:00 -05:00
dotnet-maestro d99c1e631b Update dependencies from https://github.com/dotnet/arcade build 20190624.24
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19324.24
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19324.24
2019-06-26 11:57:51 +02:00
Egor Bogatov 78b9c66501 Add xunit-summary.py (#15373) 2019-06-26 11:49:24 +02:00
Alexander Köplinger 6307f0156c [profiler] Add helper.h to tarball 2019-06-26 10:41:38 +02:00
Ryan Lucia a2a28b94c1 [netcore] Fix build.sh (#15380)
* [netcore] Revert changes to build.sh

It appears to have accidentally been changed in #15215, and the script no longer works correctly as a result, so revert

* Strip call to make
2019-06-25 23:58:41 -04:00
Larry Ewing 73dd9ac01e [wasm] make packager.exe depend on release/ and debug/ because it may use either 2019-06-25 21:44:06 -05:00
Alexis Christoforides 43f504a43e Bump bockbuild for fix to https://github.com/mono/mono/issues/14957 2019-06-25 20:59:50 -05:00
Larry Ewing 191854ded8 Merge branch 'master' into fix-dynamic-method-marshal-info 2019-06-25 20:18:14 -05:00
Zoltan Varga dc321b06a2 [aot] Save the number of locals into the aot debug info so the method header doesn't have to be decoded when its loaded. 2019-06-25 20:03:35 -05:00
Kenneth Pouncey 4699ff275d Add signing of the framework assemblies to the projects using the Open key. (#15303) 2019-06-25 17:45:13 -05:00
Thays Grazia 2bdf49cae1 [debugger][wasm] Local vars (#15385)
* Fixing side effect of #15357.

* Fixing side effect of #15357.
2019-06-25 17:36:26 -05:00
Alexander Köplinger 41767754d5 [System] Fix monotouch_watch xunit tests build
Forgot to exclude one more file.
2019-06-25 22:21:26 +02:00
Jay Krell 1c09e4de62 Fix tarball build and refresh monolite due to memory model change (#15370)
* Revise monolite due to memory model change.

* Fix tarball builds wrt netcore/config.make.

* Remove System.Private.CoreLib from mcs/class/Makefile, it was moved to netcore/

* Bump min_mono_version in basic-profile-check

The new MONO_DEBUG=clr-memory-model runtime option isn't available in earlier Mono versions.
2019-06-25 22:14:41 +02:00
Jay Krell 3e270ffe20 [threads] Define interlocked_mutex as non-recursive and on 32bit platforms only (#15393) 2019-06-25 14:56:37 -04:00
Radek Doulik 3efc0959fe [profiler] Add helper.c to static sources where needed (#15400)
This should fix broken `OS X x64 iOS SDK` build.
2019-06-25 20:04:16 +02:00
Alexander Köplinger bc1d080ba9 Exclude a few tests on monotouch_watch/xammac (#15397)
* [System.Core] Exclude AnonymousPipe tests on monotouch/xammac profiles

They should only be run on xammac_net_4_5.

Fixes https://github.com/mono/mono/issues/15329

* [System] Exclude WebClient and WebSocket tests on monotouch_watch

Fixes https://github.com/mono/mono/issues/15265.
2019-06-25 20:01:17 +02:00
Zoltan Varga ba242226f4 [wasm] Bump emscripten to 1.38.36. 2019-06-25 11:43:12 -05:00
Johan Lorensson 5ca92bdbe8 Add cooperative suspend aware threads for hybrid suspend. (#15204)
* Add cooperative suspend aware threads for hybrid suspend.

When running in hybrid suspend and having threads in blocking mode, GC Safe
mode, threads will still be preemptive suspended. This is done to make sure
compatibility is kept with embedders since current embedding API is not coop
aware. If, however the external attached threads promise to follow the coop
rules for a thread in Safe mode, it could still be possible to have them
running, making sure they won't be preempted when running STW. Unlocking this
possibility could have large performance wins if embedding threads runs a lot
of native code on threads attached to runtime.

This commit adds support for a new pair of API's where an external thread can
mark itself as cooperative suspend aware. Doing that guarantees the runtime
that it will follow all rules as dictated by cooperative suspend when a thread
is in safe mode. The change only goes one way since this is a lifetime commitment
for a thread. Once’s set, thread will be kept running when in safe mode.
2019-06-25 17:40:39 +02:00
Kevin Pilch d36d2dd02d Remove a stale comment (#15378)
Pushing https://github.com/aspnet/AspNetCore/pull/10561 upstream, to fix
AzDO Bug #890301 (https://dev.azure.com/devdiv/DevDiv/_workitems/edit/890301/)
2019-06-25 17:25:34 +02:00
Zoltan Varga 9ace0a3b9c [runtime] Refactor mono-debug.c. (#15381)
* [debug] Refactor the code in mono-debug.c.

Store the domain->debug info table mapping in MonoDomain to avoid a hashtable lookup.
Rename MonoDebugDataTable to DebugDomainInfo to better reflect its meaning.

* Remove some mono_ prefixes from static functions, along with the full/internal prefixes.
2019-06-25 09:35:21 -04:00
Alexander Köplinger b2ac112d37 [bcl] Move MONO_DEBUG env variable after Q_MCS
Otherwise we'd get "/bin/sh: @echo: command not found" errors.
2019-06-25 14:38:37 +02:00
Radek Doulik 858b2b8405 [aot profiler] Listen for commands on given port (#14936)
* [aot profiler] Listen for commands on given port

Extended the aot profiler so, that it can receive commands over the network.

Added new option `port=PORT`, which enables command server and specifies
the port the server should listen at.

We have 2 commands so far.

    save ... save the profile data to socket and close it
    quit ... quit the profiler. it also saves the profile to the file
             in case the output option was specified.

It makes the aot profiling much easier to use on Android as we don't need to
save the profile to a file on the device. That means we don't need to set
`<application android:debuggable="true"/>` flag, which changes the Android
app behavior and thus influence the profile itself. It is also convenient way
for IDEs to retrieve the aot profiles.

Example use for Xamarin.Android. Save and receive the profile data:

	adb shell setprop debug.mono.profile aot:verbose,port=9999
	adb forward tcp:9999 tcp:9999
	nc -v 127.0.0.1 9999 > profile.aotprof
	found 0 associations
	found 1 connections:
	     1:	flags=82<CONNECTED,PREFERRED>
		outif lo0
		src 127.0.0.1 port 50398
		dst 127.0.0.1 port 9999
		rank info not available
		TCP aux info available

	Connection to 127.0.0.1 port 9999 [tcp/distinct] succeeded!
	save

Check what we received:

	aotprofile-tool -sd profile.aotprof
	Modules:
		132475FF-85AA-430D-913C-7642CBD8587E mscorlib
		F7BDCAB5-83D3-4A0A-A33D-BBE94284667D Mono.Android
		22897151-27C9-4064-B001-8A04F5847812 System
		AA3FC224-D486-4304-A8C9-EBF316556B26 Java.Interop
		00D98403-051B-4168-A391-F3F601637CBD System.Core
		FD06519A-C321-426C-BDD8-C97777452057 xat_latests_and_greatest_vsmac_8._1
		9ECB003E-D449-438B-BE35-58810DCBC917 Xamarin.Android.Support.v7.AppCompat
		11659962-EFAC-400D-9F8D-AF925B26AE41 Xamarin.Android.Support.Fragment
		48C436F7-611D-470D-9949-AC13FFDCF613 Xamarin.Essentials
		2792D10D-7E13-46E6-BB4A-933C25635F48 Xamarin.Android.Support.Design
	Summary:
		Modules:         10
		Types:          221
		Methods:        932

* Try to fix WIN32 compilation

* Add helper.c to mono-profiler-log.vcxproj

* Add helper.c to mono-profiler-log.vcxproj.filters as well
2019-06-25 12:17:45 +02:00
Johan Lorensson f8fbbcf280 Increase max size of localloc and localloc_imm on amd64. (#15374)
We hit the following assert when doing full AOT of some assemblies:

wrong maximal instruction length of instruction localloc (expected 96, got 99)
Assertion: should not be reached at mono\mono\mini\mini-amd64.c:6801

Turns out that that size could be hit when a couple of things happens as part
of lowering OP_LOCALLOC and OP_LOCALLOC_IMM:

sreg1 is not RAX, RCX or RDI
dreg is not RAX, RCX or RDI
cfg->param_area is bigger than 127

Fix is to increase max size of the instruction, from 96 -> 120 (same as x86).
2019-06-25 10:46:33 +02:00
Johan Lorensson b181dbc50d Add support for Windows x64 Full AOT + LLVM + Interpreter on CI. (#15276) 2019-06-25 08:20:25 +02:00
Nikita Voronchev c30a10bc3e [System.Windows.Forms] Fix crash of DataGridView in case of assigning a custom Column Header (#15135) 2019-06-24 21:51:47 -04:00
Johan Lorensson b2124dab01 Add missing CI test script when running full AOT interpreter on Windows. (#15281) 2019-06-24 17:00:01 -04:00
Marek Safar 7066c05c39 [System.Private.CoreLib] Add new shared string resource 2019-06-24 21:12:12 +02:00
Andrii Siriak 0abee2baf5 Switch from IndexOf(string) to Contains(string) for better readability and performance (#38757)
* Fix performance IndexOf(string) -> Contains(string)

* Make comparison ordinal

Signed-off-by: dotnet-bot <[email protected]>
2019-06-24 21:12:12 +02:00
Stephen Toub eeb377842e Force secondary await continuations to run asynchronously (#25280)
* Force secondary await continuations to run asynchronously

For performance reasons, await continuations have been invoked synchronously, meaning they're invoked as part of the antecedent task's completion (as long as that task allows it, as long as there's sufficient stack space, etc.)  This generally works out well in the case where there's a single await continuation, which is far and away the common case.  However, it can cause problems in situations where there are multiple await continuations, as those continuations will end up being serialized, which can lead to slowdowns and deadlocks in niche situations.  To address that, this commit backs off a bit.  The first await continuation is still invoked synchronously, but subsequent await continuations are invoked asynchronously, such that they are not blocked by a previously registered await continuation.

* Fix nits

Signed-off-by: dotnet-bot <[email protected]>
2019-06-24 21:12:12 +02:00
Marco Rossignoli 3af0d87397 MemoryExtensions ToUpper / ToLower throws for overlapping buffer (#25327)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-24 21:12:12 +02:00
Roman Marusyk 96481aedf0 Change exception throwing in Path.GetRelativePath (dotnet/coreclr#25047)
* Fix Path.GetRelativePath throws ArgumentNullException when relativeTo is empty string

* Fix ArgumentException for relativeTo

Signed-off-by: dotnet-bot <[email protected]>
2019-06-24 21:12:12 +02:00
Herman Eldering a555a5b5b3 ArgumentException: use system-supplied message if message is null (#25115)
Enable using a system-supplied message while also providing an argument/parameter name by passing in a null message. Made to match the behavior of FileNotFoundException.

Signed-off-by: dotnet-bot <[email protected]>
2019-06-24 21:12:12 +02:00
Santiago Fernandez Madero 9ac62ea31a Address nullable feedback for System.Diagnostics.Tracing and StackTrace (#25303)
* Address nullable feedback for System.Diagnostics.Tracing and StackTrace

* Disable corefx tests that need to be updated

Signed-off-by: dotnet-bot <[email protected]>
2019-06-24 21:12:12 +02:00
Stephen Toub 7d4ce9cd8c Remove several unnecessary string allocations (dotnet/coreclr#25305)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-24 21:12:12 +02:00
Stephen Toub 366c80aed8 Reduce string allocation in DiagnosticCounter.GetMetadataString (#25219)
When the _metadata dictionary contains a single key/value pair, the method ends up allocating an unnecessary StringBuilder, char[] beneath it, and input string.

When the _metadata dictionary contains more key/value pairs, the method ends up allocating an unnecessary string per key/value pair.

Signed-off-by: dotnet-bot <[email protected]>
2019-06-24 21:12:12 +02:00
Zoltan Varga 1150d4a3e9 [netcore] Disable more runtime functionality. (#15369) 2019-06-24 14:47:00 -04:00
Alexander Köplinger 80db1ef59f [sdks] Do the WATCHOS5_VERSION -> WATCHOS64_32_VERSION rename in run-jenkins.sh too
It was missed in https://github.com/mono/mono/pull/15202
2019-06-24 19:14:54 +02:00
dotnet-maestro 683db00b2a Update dependencies from https://github.com/dotnet/arcade build 20190623.4
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19323.4
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19323.4
2019-06-24 17:25:34 +02:00
Thays Grazia 057f51d833 [wasm][debugger] Adding support to debug local vars in async methods (#15357)
- Improving performance calling only once mono_wasm_get_var_info.
- Adding support to debug local vars in async methods. They are special in the way that local variables can be lifted to generated class fields.
2019-06-24 10:34:42 -03:00
Johan Lorensson de90561fbd Fix race related to final event signaling in RegisteredWaitHandle. (#15280)
We have seen sporadic failures in thread pool tests on CI related to
test case:

System.Threading.ThreadPools.Tests.ThreadPoolTests.QueueRegisterPositiveAndFlowTest [FAIL]
      Assert.Equal() Failure
      Expected: 0
      Actual:   1
      Stack Trace:
          at System.Threading.ThreadPools.Tests.ThreadPoolTests.QueueRegisterPositiveAndFlowTest () [0x00143] in D:\j\workspace\z3\label\w64\external\corefx\src\System.Threading.ThreadPool\tests\ThreadPoolTests.cs:337
          at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
          at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in D:\j\workspace\z3\label\w64\mcs\class\corlib\System.Reflection\RuntimeMethodInfo.cs:395

Finally managed to track down the issue to a race when using the same final
event in sequential calls to RegisterWaitForSingleObject. The event could, depending on
timing, get signaled multiple times for the same RegisterWaitHandle instance
causing a thread waiting for completion on another RegisterWaitHandle using same event
to be signaled before that callback was completed. That will cause the race seen in the
failing test above.

Fix make sure we only signal the final event one time per RegisterWaitHandle
instance.
2019-06-24 10:56:21 +02:00
Bernhard Urban 7d5daa2f77 [arm] set exception handling model to dwarf for iOS
We recently switched the AOT compiler for iOS armv7 from 32bit host to 64bit host. At the same time we _also_ switched from LLVM 3.6 to the newer LLVM 6.0 fork we support.

In a Xamarin.iOS Release build for iOS armv7 exception handling would crash. Specifically the problem was that the exception object wasn't properly injected into the handler block. The way it works is, that the exception handler machinery passes the pointer to the exception object via `r0`.

With the newer LLVM the generated code of the exception handling block
looks like this:
```
LBB1_15:                                @ %EH_CLAUSE0_BB3
Ltmp8:
	ldr	r0, [sp, #24]
	str	r0, [sp, #4]
	ldr	r0, [sp, #28]
	ldr	r0, [sp, #12]
	ldr	r0, [r0]
	cmp	r0, #0
	beq	LBB1_17
```
thus overwriting `r0`, so that the pointer to the exception object is lost.  With the older LLVM 3.6 the generated code looks like this:
```
LBB1_8:                                 @ %EH_CLAUSE0_BB3
Ltmp8:
	str	r0, [sp, #4]
	ldr	r0, [r6]
	cmp	r0, #0
	beq	LBB1_10
```
correctly storing the exception object into a stack slot for later usage.

After some time I figured out that there are _different_ exception handling models. Depending on the model, the exception pointer is passed in `r0` or not:
https://github.com/mono/llvm/blob/2bd2f1db1803f7b36687e5abf912c69baa848305/lib/Target/ARM/ARMISelLowering.cpp#L14416-L14428

`SjLj` stands for "SetJump / LongJump" and  means that exception handling is implemented with this. On iOS this is the default model that is used. We want `dwarf` instead, so we tell this `llc` now and the generated code handles it correctly.

So why was it working before? In our older LLVM 3.6 fork we hardcoded it:
https://github.com/mono/llvm/blob/f80899cb3eb75f7f5640b4519e83bd96991bffb8/lib/Target/ARM/ARMISelLowering.cpp#L756-L762

The `-exception-model=` option is also not available in LLVM 3.6.

Contributes to https://github.com/mono/mono/issues/15058 and https://github.com/mono/mono/issues/9621
2019-06-24 09:48:45 +02:00
dotnet-maestro d027cbbc06 Update dependencies from https://github.com/dotnet/arcade build 20190622.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19322.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19322.2
2019-06-24 09:12:13 +02:00
dotnet-maestro 33a4a35826 Update dependencies from https://github.com/dotnet/arcade build 20190621.75
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19321.75
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19321.75
2019-06-24 09:12:13 +02:00
Zoltan Varga bbfce00878 [netcore] Remove unused icalls. 2019-06-23 10:05:22 +02:00
Zebediah Figura 9f49cc85af [mini] Support tracing pointer return values. (#15356) 2019-06-22 12:57:49 -04:00
Zoltan Varga c3161826e3 [aot] Fix a deadlock in init_plt () by calling create_trampoline () outside the lock. (#15332)
Fixes https://github.com/mono/mono/issues/15330.
2019-06-21 23:35:57 -04:00
Zoltan Varga f42fcc0459 [sdks] Avoid building everything on make all. (#15296)
* [sdks] Avoid building everything on make all.

* Add a dummy all target.
2019-06-21 23:35:42 -04:00
Vlad Brezae 0cf363c4db [arm64] Add location of this and rgctx arg
Used to fetch the value from async suspend stack frame, during exception handling.
2019-06-21 15:47:44 -05:00
Vlad Brezae a7a884e19e [arm] Add location of this and rgctx arg
Used to fetch the value from async suspend stack frame, during exception handling.
2019-06-21 15:47:44 -05:00
Vlad Brezae e1e26b87b5 [amd64] Fix location saving for *this*
With static methods we were saving location for irrelevant argument.
2019-06-21 15:47:44 -05:00
Jay Krell ab16b39a65 Remove three seemingly unused functions:
mono_aot_init_gshared_method_this
  mono_aot_init_gshared_method_mrgctx
  mono_aot_init_gshared_method_vtable

Update comments that refer to them, to refer to the renames.
 mini_llvm_init instead of mono_aot_init.

See 80bc0069e4 and 04d65f2986.

I'm here because I broke something nearby in a work-in-progress PR
and the existance of these functions made me look into them.
2019-06-21 15:46:24 -05:00
Ankit Jain 81f529689c Bump msbuild to track xplat-master (#15295)
* Bump msbuild to track xplat-master

* [msbuild] Bump to track xplat-master

.. which effectively enables use of the shared compiler.
2019-06-21 21:36:43 +02:00
Filip Navara 42eb919d52 Add basic implementation of Environment.FailFast (#15279)
* Add basic implementation of Environment.FailFast

* Add comment about __failfast on Windows 8+

* Re-add some test exclusions and clarify the comment around them

* Update icall.c
2019-06-21 18:52:12 +02:00
Aleksey Kliger (λgeek) 71ceefccf6 [api] Add a mono/metadata/profiler-legacy.h header (#15098)
* [api] Add mono/metadata/profiler-legacy.h header

Add a header with the legacy Mono profiler API.  New code should use the API
from mono/metadata/profiler.h.

* [profiler] Mark the legacy profiler API with MONO_DEPRECATED

* [runtime] Don't install the profiler-legacy.h header

Make the decision later whether these should be in the set of public API headers
2019-06-21 18:47:26 +02:00
monojenkins 3d48d85472 [ci] One more workaround for Git 2.22.0 (#15326)
Homebrew Git 2.22.0 misparses the submodule command and passes arguments like --hard and -xdff to git-submodule instead of to git-reset or git-clean.  Passing the entire command as a single argument seems to help.

Git mailing list bug report: https://public-inbox.org/git/[email protected]/
2019-06-21 10:57:38 -04:00
dotnet-maestro c6b8e90230 Update dependencies from https://github.com/dotnet/arcade build 20190620.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19320.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19320.1
2019-06-21 16:26:01 +02:00
monojenkins 304899de1b [bcl] Update BCL Linked Size 2019-06-21 13:56:27 +02:00
Egor Bogatov 9eb1f19909 Update Makefile 2019-06-21 13:55:33 +02:00
EgorBo 44cba4e442 fix build-test-corefx command 2019-06-21 13:55:33 +02:00
Kenneth Pouncey b32b5ceba2 Make sure that bindings are initialized in mono_wasm_new. (#15274)
- Fixes `this.mono_string_get_utf8 is not a function`.
2019-06-21 13:38:50 +02:00
Dmitry Kalyanov 480f636808 TransactionScope now actually uses IsolationLevel that was specified in TransactionOptions
Previously, using TransactionScope would always produce transactions
that use serializable isolation level even when user specified another
level (like ReadCommited).

fixes #13945
2019-06-21 11:27:59 +02:00
Stephen Toub a8b1b2ed20 Fix visibility on Exception.InnerExceptionPrefix (dotnet/coreclr#25278)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-21 08:34:24 +02:00
Santiago Fernandez Madero 93fdf6489c Address nullable feedback for S.T.Overlapped, S.Memory, S.R.InteropServices (#25214)
* Address nullable feedback for System.Threading.Overlapped

* Address nullable feedback for System.Memory

* Address nullable for System.Runtime.InteropServices

* Update xml comments and make CultureInfo nullable to match String.ToLower/Upper feedback

* PR feedback: revert accepting null comparer in BinarySearch

* Disable test that needs to be updated in corefx

Signed-off-by: dotnet-bot <[email protected]>
2019-06-21 08:34:24 +02:00
Dan Moseley 5dee50f30c Exception format cleanup subset (dotnet/coreclr#25185)
* Change ArgumentException message to one line

* Disable 2 tests

* Remove duplication in AggregateException.ToString()

* Inner exceptions on new lines

* Caps letter

* Typo

Signed-off-by: dotnet-bot <[email protected]>
2019-06-21 08:34:24 +02:00
lateralusX ad90ebd3ab Make copy_stack_data support configurable.
By default when called through macros like MONO_ENTER_GC_UNSAFE
code will always dump current registers into stack space on hybrid/coop.
The registers will be scanned but only when hitting a GC and when running
in GC unsafe, that will only happen when we block in the enter or hit a safe
point at a later point in time. There are currently a couple of frequent
scenarios where we go into GC safe when thread won't be suspended and in
that case the copy of the registers will only reflect the state when
entering GC unsafe.

Commits add option to enable/disable copy_stack_data support in configure step:
--enable-copy-stack-data, --disable-copy-stack-data.

copy_stack_data is enabled by default on all platforms except desktop platforms
macos, linux and windows (both 32/64-bit), since these platforms already support
full context as well as capabilities to scan the stack of a running thread.
2019-06-20 23:34:56 -05:00
Larry Ewing 7af0e36db3 Merge pull request #15293 from lewing/wasm-clean
[wasm] Add some missing directories to the clean target
2019-06-20 22:21:08 -05:00
Larry Ewing efa06b3ecd Merge pull request #15291 from lewing/doublecheck-290
[wasm] Add an explicit test for https://github.com/dotnet/try/issues/290
2019-06-20 20:46:39 -05:00
Aleksey Kliger (λgeek) 18ce655751 [loader] remap only System.Threading.Tasks.Dataflow older than 4.0.0.0 (#15266)
[loader] remap only System.Threading.Tasks.Dataflow older than 4.0.0.0

Allow through requests for newer versions unchanged.
2019-06-20 19:25:43 -04:00
Thays Grazia 405d521149 [debugger] Debugger doesn't break on unhandled exceptions (#15234)
* When the catch found is in a MONO_WRAPPER_RUNTIME_INVOKE the exception should be treated as an UNHANDLED by the debugger.

* Adding unit test.

* trying to fix side effect.

* I've tested the MonoTests.DebuggerTests.UnhandledException_2 test on VsWin using .net Framework and I think the test is wrong because the first break is in throw and the next break will be on breakpoint.
In our implementation we were ignoring the unhandled exception and stopping only on breakpoint.
2019-06-20 18:48:13 -04:00
Larry Ewing b20ef4cc36 [wasm] Add some missing directories to the clean target 2019-06-20 14:28:20 -05:00
Vlad Brezae b4e43abbcc [jit] Make alias analysis properly handle alias cloberring (#15255)
Alias analysis attempts to remove indirection when using OP_LDADDR (which fetches the address of a variable). For example :

	ldaddr r1 <- r0
	load_mem r2 <- r1

is equivalent to

	mov r2 <- r0

The remembered r1 alias needs to be forgotten in case r1 is changed. We were handling this for direct assignment with MOV, but not for the more subtle case where an alias to r1 would be passed to a call, which could lead to changing r1.

https://github.com/mono/mono/issues/14872
2019-06-20 21:35:18 +03:00
Larry Ewing 653a12ad3c Add an explicit test for https://github.com/dotnet/try/issues/290 2019-06-20 13:25:29 -05:00
dotnet-maestro 6023f36749 Update dependencies from https://github.com/dotnet/arcade build 20190619.25
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19319.25
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19319.25
2019-06-20 18:29:47 +02:00
Vlad Brezae 1120e82312 [jit] Add debug option for using clr memory model (#15019)
* [jit] Move value storing in a new write barrier emitting method

Brings together ref storing and the write barrier generation.

* [jit] Add debug option to attempt using the CLR memory model

Which prevents reordering of stores. Part of the way this is done on CoreCLR is by adding memory barriers to the write barrier, so we attempt a similar behavior.

This is not a complete implementation.

* [build] Add memory model flag to csc when building the bcl

This should prevent random crashes during the build

* [build] Add memory model flag to compiler server

* [build] Add memory model flag to test building
2019-06-20 19:18:26 +03:00
Jay Krell fb6ce0df91 [Coop] Establish handle frame in reflection_setup_internal_class. (#15248)
It is called in a loop by ves_icall_TypeBuilder_create_runtime_class.
See https://github.com/mono/mono/issues/15247.
2019-06-20 11:00:36 -04:00
Jay Krell 2104d1d957 Write to the same union member that is later read. (#15269)
It should not matter in this case, but it is the usual practise,
and not strictly valid otherwise.
2019-06-20 10:57:04 -04:00
Jay Krell e24f1ed945 [interp] Optimize CEE_MONO_TLS due their being only one live producer. (#15245)
There is a dead producer in Boehm. (see https://github.com/mono/mono/pull/15241)
This combined with https://github.com/mono/mono/pull/15226
will leave no remaining uses of mono_tls_get_tls_getter.

If there were really multiple values of the enum, consider
doing the switch in transform instead of interp.
2019-06-20 16:39:20 +03:00
Radek Doulik 688d7f0938 [Mono.Profiler.Aot] Add profile writer
It writes the profile data to given stream. It comes from
https://github.com/radekdoulik/aotprofile-tool
2019-06-20 14:13:34 +02:00
Egor Bogatov 5a21eb4288 Fix arcade stuff 2019-06-20 14:07:13 +02:00
Johan Lorensson fb35615c56 Interpreter PR builds run to many test suites. (#15251)
Fix makes sure we don't run full test suite on PR builds or when targeting
arm architectures or Windows.
2019-06-20 13:30:47 +02:00
monojenkins 3b53959f1e [csproj] Update project files 2019-06-20 12:04:07 +02:00
Marek Safar 7373266eb5 Bump linker & cecil 2019-06-20 12:04:07 +02:00
Johan Lorensson dfb46dad7d Add Windows x64 Full AOT Interpreter support on CI. (#15127)
Add support to run full interpreter test suite on CI for Windows x64 Full AOT.
Since Windows x64 Full AOT uses a different full AOT profile WinAOT a separate
testing profile was setup for the interpreter testing. NOTE, this profile is
pure for testing, inline with the other testing profiles. It is also reusing
most of its sources from other sources files (mainly WinAOT) to reduce maintenance
of the profile.

Commit also includes some smaller adjustments needed in order to get full
pass rate for Windows x64 Full AOT + Interpreter on CI.
2019-06-20 09:23:39 +02:00
Aleksey Kliger b2a860c949 [coop] Mark a few functions with MONO_PROFILER_API 2019-06-20 00:22:01 +02:00
Aleksey Kliger cf3bb20575 [runtime] Don't do GC Unsafe transition in mono_gchandle_free
Xamarin.Mac can call back here from a native thread that isn't attached to the
runtime.  SGen gchandle code is lockfree, and the profiler event can fire
without involving Mono.
2019-06-20 00:22:01 +02:00
Aleksey Kliger ee74ee90b3 [profiler] Don't switch to GC Safe when locking if thread isn't attached to the
runtime.

Some profiler events (for example gc_handle_deleted) could be raised on threads
that aren't attached to the runtime.  Since the thread won't participate in
Mono's stop the world (since the runtime can't see it), there's no need to do
the transition to GC Safe while the thread is trying to grab the profiler
buffer lock.
2019-06-20 00:22:01 +02:00
Jay Krell 09869a9c8b Fix compiler warnings. (#15196)
* Fix compiler warnings.
 unused variable: save_sigint
 unused variable: mono_environ
 uprototyed function: mono_marshal_xdomain_copy_value

* add static
2019-06-19 18:18:31 -04:00
Jay Krell 6e1cc91d8d Remove unused MONO_PATCH_INFO_SET_TLS_TRAMP, corresponding unused JIT icalls, etc. (#15201) 2019-06-19 16:25:34 -04:00
Marek Safar a4ef5c3590 Update CODEOWNERS 2019-06-19 20:39:03 +02:00
dotnet-maestro 7390b78b2d Update dependencies from https://github.com/dotnet/arcade build 20190619.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19319.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19319.1
2019-06-19 19:10:45 +02:00
Ryan Lucia 2a82614f98 Correctly set ReflectionType with inherited generic methods (#15233)
* Correctly set ReflectionType with inherited generic methods

* Allow ValueType

* Re-enable relevant test

* Switch to mono_class_from_mono_type_internal
2019-06-19 13:08:39 -04:00
Johan Lorensson 7ac0287a7b Increase timeout for interpreter fullaotmixed regression. (#15225)
On Windows (partly due to slow shell execution) this test take longer to
complete than current given timeout.
2019-06-19 17:45:10 +02:00
Zoltan Varga 7341c9f636 [jit] Avoid calling mini_jit_info_table_find () in mini_add_method_trampoline () unless needed. (#15239) 2019-06-19 10:52:27 -04:00
Filip Navara c1068f9db5 [netcore] Update the checks for ByRef return type in reflection invocation (#14967)
* Update the checks for ByRef return type in reflection invocation to also check for IsByRefLike types. This was missed as part of #13901 and noted in the description.

Fixes #14959, #14960, #14961, #14963

* Modify the reflection checks for IsByRef/IsByRefLike to check for same conditions as CoreCLR

* Handle reflection invocation with ref void return type

* Update test-ref-07 to have Main method that is valid to invoke through reflection (as the test runner does)

* Update expected IL
2019-06-19 08:51:43 +02:00
Zoltan Varga 611ba9a018 [interp] Implement tracing of return values. Improve printing of arrays. (#15217) 2019-06-18 23:03:13 -04:00
Alexis Christoforides 7c4300aa7f [filewatcher] Fall back to default if a new instance cannot be created 2019-06-19 05:26:57 +03:00
Alexis Christoforides cc6a2d4606 Improve robustness of post-install script (#15213)
We have several issues (e.g. https://github.com/mono/mono/issues/14181) where the installer occasionally fails in the postinstall script for unknown causes, on some hosts.

This seems to be sometimes the culpable section and this patch should help trace the issue or alleviate the common symptoms of it (see https://github.com/mono/mono/issues/14181)
2019-06-19 02:21:38 +03:00
Bernhard Urban e3f8596156 [arm] fix some more host/target pointer size issues (#15223)
[arm] fix some more host/target pointer size issues

As suggested by Jay in https://github.com/mono/mono/issues/15058#issuecomment-501995400

I haven't seen fixing it any specific issue, but we should still backport it to `2019-06` in order to avoid hard-to-debug regressions.

Contributes to https://github.com/mono/mono/issues/9621
2019-06-18 17:45:59 -04:00
Bernhard Urban fe7027935b [mini] fix OP_SEQ_POINT of other backends regarding target pointer size (#15222)
See https://github.com/mono/mono/pull/15205#issuecomment-502925368

Theoretically fixes cross compilation on a 32bit host to a 64bit target.
2019-06-19 00:06:54 +03:00
monojenkins 95259f9947 Bump API snapshot submodule 2019-06-18 20:53:25 +02:00
Steve Pfister 2d94e79f5b Bump mono/corefx to fix https://github.com/mono/mono/issues/14864 2019-06-18 20:53:25 +02:00
Ryan Lucia 7a1605cb07 [netcore] Don't default to an empty array for a null publicKey 2019-06-18 19:44:51 +02:00
dotnet-maestro d3d499f34e Update dependencies from https://github.com/dotnet/arcade build 20190618.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19318.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19318.2
2019-06-18 19:35:04 +02:00
Ryan Lucia 6c5bbbd757 [eglib] Don't escape chars in argv parsing enclosed in single quotes (#15047)
Fixes #14724

This may need to be reverted if customers are relying on the existing behavior, but we can cross that bridge when we come to it.

The larger issue of incompatibility with .NET Core should be addressed later.
2019-06-18 13:30:31 -04:00
Marek Safar 3428cec003 Mirror changes from mono/corefx,corert,coreclr (#15221)
Mirror changes from mono/corefx,corert,coreclr
2019-06-18 12:44:36 +02:00
Marek Safar 7052e60600 [netcore] Excluded tests update 2019-06-18 11:25:51 +02:00
Marek Safar d44da802a9 [System.Private.CoreLib] Merge fixes 2019-06-18 11:10:59 +02:00
Marek Safar e29f79e68e Merge remote-tracking branch 'upstream/master' into mirror-merge-10235436 2019-06-18 10:54:06 +02:00
Marek Safar 3d311876d2 [netcore] Reflect shared partition changes 2019-06-18 10:52:05 +02:00
Marek Safar 879c8501c9 [System.Private.CoreLib] Align on CA naming for easier sharing 2019-06-18 10:10:16 +02:00
naricc ac2894920a Implement GC.GetAllocatedBytes (#14779) 2019-06-18 09:08:21 +02:00
Bernhard Urban d5a35798c6 [arm] use target_mgreg_t instead of plain pointer type in sdb breakpoint (#15205)
[arm] use target_mgreg_t instead of plain pointer type in sdb breakpoint

Fixes Debug mode for iOS 32bit.

Contributes to https://github.com/mono/mono/issues/15058 & https://github.com/mono/mono/issues/9621

Diff before (left old cross32, right new cross32 running on amd64 host _before_ this fix):
<img width="1257" alt="Screenshot 2019-06-17 at 14 09 51" src="https://user-images.githubusercontent.com/75403/59603413-a9bd4f00-9109-11e9-8f18-aa7b4ca5817f.png">

/cc @mandel-macaque
2019-06-18 02:46:00 -04:00
Jay Krell fc74334e20 Allocate MonoJumpInfo instead of MonoAotCompile. 2019-06-17 23:41:26 -05:00
Kenneth Pouncey 67b4d55d91 Simplify header item fetch using the Headers entries iterator.
- Use the Headers `entries{}` iterator object.
- This replaces the `foreach` delegate call where the object returned in the delegate was being disposed of too early.
- The foreach delegate takes three objects name, value, other.  The `other` being disposed was causing a problem when calling back into the delegate later.
- Removes the lamda expression called by the delegate without the worry of a memory leak if the finally is removed.
2019-06-17 21:56:47 -05:00
Kenneth Pouncey f7bba7172e Add tests to the IssuesTestSuite to catch regressions
- See issue https://github.com/mono/mono/issues/14940
2019-06-17 21:56:47 -05:00
Kenneth Pouncey 8f864e4d92 Fix problem with fetch response header iteration prematurely disposing of the header object.
- Use the iterator of the headers object do iteration over the fetch response headers.
2019-06-17 21:56:47 -05:00
Jay Krell a97408ac1e Revert "threads.c:6403:6: warning: 'current_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]"
This reverts commit bf2f1abe01978102c22d76b4a10996e8d8b50b0f.

The logic is not clear as to if there is a bug, so leave the warning.
There are two uses of the possibly uninitialized variable.
One is guarded and not a bug.
The other is not clear, and don't want to blindly use 0.
2019-06-17 21:53:08 -05:00
Jay Krell af2c235f31 PR: Restore nearby unusual formatting. 2019-06-17 21:53:08 -05:00
Jay Krell 9c70b53cc3 intrinsics.c: In function 'mini_emit_inst_for_method':
intrinsics.c:1580:11: warning: 'result' may be used uninitialized in this function [-Wmaybe-uninitialized]
     *dest = result;
     ~~~~~~^~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 6e19637797 debugger-engine.c: In function 'set_bp_in_method':
debugger-engine.c:354:11: warning: variable 'code' set but not used [-Wunused-but-set-variable]
  gpointer code;
           ^~~~
2019-06-17 21:53:08 -05:00
Jay Krell 496cb4cfce tramp-arm64-gsharedvt.c: In function 'mono_arch_get_gsharedvt_trampoline':
tramp-arm64-gsharedvt.c:217:54: warning: variable 'callee_stack_area_offset' set but not used [-Wunused-but-set-variable]
  int caller_reg_area_offset, callee_reg_area_offset, callee_stack_area_offset;
                                                      ^~~~~~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 179b5e85cf mini-arm64-gsharedvt.c: In function 'mono_arch_get_gsharedvt_call_info':
mini-arm64-gsharedvt.c:142:29: warning: variable 'gsig' set but not used [-Wunused-but-set-variable]
  MonoMethodSignature *sig, *gsig;
                             ^~~~
2019-06-17 21:53:08 -05:00
Jay Krell b504d7e6d8 interp/mintops.c: In function 'mono_interp_dis_mintop':
interp/mintops.c:87:37: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'long int' [-Wformat=]
   g_string_append_printf (str, " %lld", (gint64)READ64 (ip + 1));
2019-06-17 21:53:08 -05:00
Jay Krell 452209414e In file included from object.c:40:0:
object.c: In function 'mono_class_proxy_vtable':
../../mono/metadata/profiler-private.h:191:4: warning: 'pvt' may be used uninitialized in this function [-Wmaybe-uninitialized]
    mono_profiler_raise_ ## name args; \
    ^~~~~~~~~~~~~~~~~~~~
object.c:2338:19: note: 'pvt' was declared here
  MonoVTable *vt, *pvt;
                   ^~~
2019-06-17 21:53:08 -05:00
Jay Krell bdb20ebd80 w32file-unix.c: In function 'mono_w32file_get_file_size':
w32file-unix.c:4994:19: warning: 'length_hi' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return length | ((gint64)length_hi << 32);
                   ^~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 457d0f02c5 interp/interp.c: In function 'interp_entry.constprop':
interp/interp.c:1847:3: warning: 'orig_domain' may be used uninitialized in this function [-Wmaybe-uninitialized]
   mono_threads_detach_coop (orig_domain, &attach_cookie);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 3357a1a611 image.c:1351:20: warning: variable 'header' set but not used [-Wunused-but-set-variable]
MonoDotNetHeader *header;
                    ^~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 00570db6a4 exception.c:747:1: warning: 'mono_new_exception_argument_out_of_range' defined but not used [-Wunused-function]
mono_new_exception_argument_out_of_range (const char *arg, MonoError *error)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell bc5d1a48d8 os-event-unix.c: In function 'mono_os_event_wait_multiple':
os-event-unix.c:195:12: warning: 'start' may be used uninitialized in this function [-Wmaybe-uninitialized]
    elapsed = mono_msec_ticks () - start;
    ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 96129ba873 In file included from ../../mono/eglib/glib.h:45:0,
from os-event.h:9,
                 from os-event-unix.c:11:
../../mono/eglib/eglib-remap.h:146:25: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define g_ptr_array_add monoeg_g_ptr_array_add
                         ^~~~~~~~~~~~~~~~~~~~~~
os-event-unix.c:121:19: note: 'data' was declared here
  OSEventWaitData *data;
                   ^~~~
2019-06-17 21:53:08 -05:00
Jay Krell faadb64774 marshal.c: In function 'mono_marshal_get_runtime_invoke_full':
marshal.c:2662:8: warning: 'sig_cache' may be used uninitialized in this function [-Wmaybe-uninitialized]
    res = (MonoMethod *)g_hash_table_lookup (sig_cache, sig_key);
    ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 64c321293b sgen-mono.c:260:1: warning: 'install_noilgen' defined but not used [-Wunused-function]
install_noilgen (void)
2019-06-17 21:53:08 -05:00
Jay Krell 0b5b42f6c7 In file included from sgen-new-bridge.c:31:0:
sgen-dynarray.h:331:1: warning: 'dyn_array_ptr_set_all' defined but not used [-Wunused-function]
 dyn_array_ptr_set_all (DynPtrArray *dst, DynPtrArray *src)
 ^~~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell e94887a18c threads.c:6403:6: warning: 'current_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (i == current_idx)
      ^
threads.c:6549:6: note: 'current_idx' was declared here
  int current_idx;
      ^~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 67680a2e81 sgen-dynarray.h:248:1: warning: 'dyn_array_ptr_set' defined but not used [-Wunused-function]
dyn_array_ptr_set (DynPtrArray *da, int x, void *ptr)
 ^~~~~~~~~~~~~~~~~

sgen-dynarray.h:202:1: warning: 'dyn_array_ptr_init' defined but not used [-Wunused-function]
 dyn_array_ptr_init (DynPtrArray *da)
 ^~~~~~~~~~~~~~~~~~

sgen-dynarray.h:194:1: warning: 'dyn_array_int_is_copy' defined but not used [-Wunused-function]
 dyn_array_int_is_copy (DynIntArray *da)
 ^~~~~~~~~~~~~~~~~~~~~

sgen-dynarray.h:188:1: warning: 'dyn_array_int_copy' defined but not used [-Wunused-function]
 dyn_array_int_copy (DynIntArray *dst, DynIntArray *src)
 ^~~~~~~~~~~~~~~~~~

sgen-dynarray.h:182:1: warning: 'dyn_array_int_ensure_independent' defined but not used [-Wunused-function]
 dyn_array_int_ensure_independent (DynIntArray *da)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sgen-dynarray.h:168:1: warning: 'dyn_array_int_get' defined but not used [-Wunused-function]
dyn_array_int_get (DynIntArray *da, int x)
 ^~~~~~~~~~~~~~~~~

sgen-dynarray.h:161:1: warning: 'dyn_array_int_add' defined but not used [-Wunused-function]
 dyn_array_int_add (DynIntArray *da, int x)
 ^~~~~~~~~~~~~~~~~

sgen-dynarray.h:147:1: warning: 'dyn_array_int_size' defined but not used [-Wunused-function]
 dyn_array_int_size (DynIntArray *da)
 ^~~~~~~~~~~~~~~~~~
sgen-dynarray.h:141:1: warning: 'dyn_array_int_uninit' defined but not used [-Wunused-function]
 dyn_array_int_uninit (DynIntArray *da)
 ^~~~~~~~~~~~~~~~~~~~
sgen-dynarray.h:135:1: warning: 'dyn_array_int_init' defined but not used [-Wunused-function]
 dyn_array_int_init (DynIntArray *da)
 ^~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell ae357bebbd In file included from sre.c:30:0:
../../mono/metadata/reflection-cache.h:43:1: warning: 'free_reflected_entry' defined but not used [-Wunused-function]
 free_reflected_entry (ReflectedEntry *entry)
 ^~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell cc60fe04d0 sre.c:2067:1: warning: 'is_sr_mono_field' defined but not used [-Wunused-function]
is_sr_mono_field (MonoClass *klass)
 ^~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 54366ee658 w32handle.c: In function 'mono_w32handle_wait_multiple':
w32handle.c:1146:13: warning: 'start' may be used uninitialized in this function [-Wmaybe-uninitialized]
     elapsed = mono_msec_ticks () - start;
     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell f2f5c45d9d custom-attrs.c:269:1: warning: 'load_cattr_type_object' defined but not used [-Wunused-function]
load_cattr_type_object (MonoImage *image, MonoType *t, gboolean header, const char *p, const char *boundp, const char **end, MonoError *error, guint32 *slen)
 ^~~~~~~~~~~~~~~~~~~~~~
2019-06-17 21:53:08 -05:00
Jay Krell 267a75f365 sre-save.c:114:1: warning: 'swap_with_size' defined but not used [-Wunused-function]
swap_with_size (char *dest, const char* val, int len, int nelem) {
2019-06-17 21:53:08 -05:00
Jay Krell 404a03b87e mono-mmap.c: In function 'mono_file_map_error':
mono-mmap.c:401:82: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 5 has type 'guint64 {aka long unsigned int}' [-Wformat=]
    *error_message = g_strdup_printf ("%s failed file:%s length:0x%zX offset:0x%lluX error:%s(0x%X)\n",
2019-06-17 21:53:08 -05:00
Jay Krell a37f71a4ea threadpool.c: In function 'mono_threadpool_remove_domain_jobs':
threadpool.c:571:91: warning: 'end' may be used uninitialized in this function [-Wmaybe-uninitialized]
    res = mono_coop_cond_timedwait (&tpdomain->cleanup_cond, &threadpool.domains_lock, end - now);
2019-06-17 21:53:08 -05:00
Sung Yoon Whang e734fca321 make DiagnosticCounter and its children lock 'this' instead of an arbitrary String (#25173)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:13 +00:00
Ben Adams 0ca0d1dfd9 IndexOfAny(values.Length == 0) == -1 (dotnet/coreclr#25075)
* IndexOfAny(values.Length == 0) == -1

* Skip tests

Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:12 +00:00
Adam Sitnik b58c351daf don't use var
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:10 +00:00
Adam SitnikandJan Kotas 62f597ea23 Apply suggestions from code review
Co-Authored-By: Jan Kotas <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:09 +00:00
Adam Sitnik 2597806f5f set the charset to Ansi
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:08 +00:00
Adam Sitnik a22d66c98c simplify the code
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:07 +00:00
Adam Sitnik 0dcea57a81 lock the dictionary
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:07 +00:00
Adam Sitnik fd52429be9 move the sort key logic to a dedicated helper type to avoid static field initialization order issues
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:06 +00:00
Adam Sitnik 3a45ebfa72 introduce cache for sort handles to prevent from memory leak in certain scenarios
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:05 +00:00
Adam Sitnik d7506847fe use IntPtr instead of CriticalHandle to avoid resurrection issues. It's ok to never free the handle
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:05 +00:00
Adam Sitnik ba42c41536 seal the CriticalSortHandle class
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:04 +00:00
Adam Sitnik 67e2d3ff62 change SafeSortHandle to be CriticalSortHandle to avoid expensive ref counting
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:03 +00:00
Marek Safar 3e3925ff93 Move parts of RuntimeType to shared partition (dotnet/coreclr#25176)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:02 +00:00
Sung Yoon Whang b723b841c0 Make DisplayUnits string.Empty by default instead of null (#25104)
* Make DisplayUnits string.Empty by default instead of null

* PR feedback on DisplayName and setter validation

Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:01 +00:00
Tarek Mahmoud Sayed 321b02ce2c Fix French Decimal number parsing (dotnet/coreclr#25154)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:01 +00:00
Jan Kotas 18a4099fbd Optimize Activator.CreateInstance (dotnet/coreclr#25145)
* Optimize Activator.CreateInstance
- Short-circuit Activator.CreateInstance<T>() for value types without default constructor
- Cache default constructor delegate on RuntimeType instead of fixed-size singleton cache

Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:37:00 +00:00
Stephen Toub 4a29e94abb Update Corelib to adapt to compiler nullability updates
Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:36:59 +00:00
Viktor Hofer ee64a8364f Delete dead uapaot code (dotnet/corefx#38330)
* Delete dead uapaot code

Signed-off-by: dotnet-bot <[email protected]>
2019-06-17 22:36:58 +00:00
Egor Bogatov c04dc84a9f fix RuntimeType.cs 2019-06-17 21:14:06 +02:00
Bernhard Urban 1e5ca1479c [watch] consistent naming for watchOS min version (#15202)
[watch] consistent naming for watchOS min version

See https://github.com/xamarin/xamarin-macios/pull/6307
2019-06-17 13:26:09 -04:00
Jay Krell 7d824dc2ae Fix race conditions in mono_lazy_initialize,
which is meant to be all about handling race conditions.

1. Less severe:
Add missing read barrier to mono_lazy_initialize().

This is unfortunate.

The general pattern of:

if initialized
  use the data
else:
  initialize the data, possibly with lots of locks and barriers
  mark initialized

is racy, because "use the data" can be scheduled ahead of "if initialized".

"Barriers come in pairs" generally, and this was missing one.

It depends somewhat. If the data is all pointers, initialized in the else path,
from null to non-null, and use includes dereferencing, which is a common
but not universal case, then it is ok on all non-Alpha processors, due
to "data dependency".

But if the data includes reading globals, then there is a race.

This is a bit of a slow down on fast paths on arm, and possibly
other architectures.

There are barrier-free ways to solve this, involving a thread local,
that should seriously be considered, and applied throughout the runtime.

The runtime has a lot of on-demand initialization and a lot of looks racy.

See www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2660.htm.
Which would have to be adopted to be coop-friendly which should not be difficult.

Notice that the existing "lazy" mechanism is also not coop-friendly.
That is not changed by this PR.

2. Change `status` to `*lazy_init` to fix severe race condition.
2019-06-17 15:31:35 +02:00
dotnet-maestro 6bd68bc2a4 Update dependencies from https://github.com/dotnet/arcade build 20190615.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19315.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19315.2
2019-06-17 15:30:58 +02:00
Jay Krell 8966528c21 Replace MONO_PATCH_INFO_TRAMPOLINE_FUNC_ADDR with MONO_PATCH_INFO_JIT_ICALL_ADDR. (#15053)
* Replace MONO_PATCH_INFO_TRAMPOLINE_FUNC_ADDR with MONO_PATCH_INFO_JIT_ICALL_ADDR.

* PR: Abstract the TrampolineType / jit_icall_id translation.
2019-06-17 01:25:53 -04:00
Vlad Brezae fd089b6e4d [interp] Prefer interp_in wrappers over trampolines (#14684)
[interp] Prefer interp_in wrappers over trampolines
2019-06-15 17:25:06 -04:00
Katelyn Gadd 59a0d1e70f Add the compiler server log to the gitignore 2019-06-15 16:16:12 -05:00
dotnet-maestro 7269db058e Update dependencies from https://github.com/dotnet/arcade build 20190614.27
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19314.27
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19314.27
2019-06-15 16:08:10 +02:00
Aleksey Kliger 8a0495ea3b [debugger-agent] Ignore thread_end event if thread is detached
The thread_stopped profiler event can be raised by the thread_info_key_dtor tls
key destructor when the thread is already doesn't have a domain set.  In that
case, don't call process_profiler_event since it cannot handle a thread with
null TLS values.

Addresses https://github.com/xamarin/xamarin-android/issues/2920
with the following stack trace

```
* thread #20, name = 'Filter', stop reason = signal SIGSEGV: invalid address (fault address: 0xbc)
  * frame #0: libmonosgen-2.0.so`mono_class_vtable_checked(domain=0x0000000000000000, klass=0x0000007200230648, error=0x00000071e92f9178) at object.c:1890
    frame #1: libmonosgen-2.0.so`get_current_thread_ptr_for_domain(domain=0x0000000000000000, thread=0x00000071ebfec508) at threads.c:595
    frame #2: libmonosgen-2.0.so`mono_thread_current at threads.c:1939
    frame #3: libmonosgen-2.0.so`process_event(event=<unavailable>, arg=<unavailable>, il_offset=<unavailable>, ctx=<unavailable>, events=<unavailable>, suspend_policy=<unavailable>) at debugger-agent.c:3715
    frame #4: libmonosgen-2.0.so`thread_end [inlined] process_profiler_event(event=EVENT_KIND_THREAD_DEATH, arg=0x00000071ebfec508) at debugger-agent.c:3875
    frame #5: libmonosgen-2.0.so`thread_end(prof=<unavailable>, tid=<unavailable>) at debugger-agent.c:3991
    frame #6: libmonosgen-2.0.so`mono_profiler_raise_thread_stopped(tid=<unavailable>) at profiler-events.h:105
    frame #7: libmonosgen-2.0.so`mono_thread_detach_internal(thread=<unavailable>) at threads.c:979
    frame #8: libmonosgen-2.0.so`thread_detach(info=0x00000071e949a000) at threads.c:3215
    frame #9: libmonosgen-2.0.so`unregister_thread(arg=<unavailable>) at mono-threads.c:544
    frame #10: libmonosgen-2.0.so`thread_info_key_dtor(arg=0x00000071e949a000) at mono-threads.c:774
    frame #11: 0x00000072899c58e8 libc.so`pthread_key_clean_all() + 124
    frame #12: 0x00000072899c5374 libc.so`pthread_exit + 76
    frame #13: 0x00000072899c5264 libc.so`__pthread_start(void*) + 44
    frame #14: 0x000000728996617c libc.so`__start_thread + 72
```
2019-06-15 09:31:05 +02:00
Marek Safar b5b58d67cf [System.Private.CoreLib] Extract RuntimeType for easier refactoring 2019-06-15 09:28:47 +02:00
Egor Bogatov 26f0222284 [netcore] Fix CI build script (#15130) 2019-06-15 09:27:15 +02:00
Jay Krell eafcbfd6ed Read only interp callbacks, option 4, without ordering sensitivity. 2019-06-14 18:51:56 -05:00
Jay Krell 1fe336691e Cleanup AIX code a little. 2019-06-14 18:43:36 -05:00
Aleksey Kliger (λgeek) 94725cb85e [llvm] bump to mono/llvm@2bd2f1db18 (#15049)
Emit .fnend directives on arm even for functions which don't have a corresponding mono method.

Fixes https://github.com/mono/mono/issues/15048
2019-06-14 16:17:07 -04:00
Marek Safar ef4c8bbbb0 [netcore] Arcade does not yet have CLSCompliant support, revert to manual settings 2019-06-14 22:00:40 +02:00
Thays Grazia a81cc67327 Implementing reabstraction of default interface methods. (#14790)
Implementing reabstraction of default interface methods.
Fix #14495
2019-06-14 16:15:38 -03:00
Marek Safar 49dc99be58 [netcore] Add more Arcade magic for signing 2019-06-14 21:10:20 +02:00
Alexander Kyte 877a2b6548 [metadata] Move problematic image out-param usage (#15131) 2019-06-14 14:38:09 -04:00
dotnet-maestro 377030eaab Update dependencies from https://github.com/dotnet/arcade build 20190613.18
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19313.18
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19313.18
2019-06-14 18:41:59 +02:00
Aleksey Kliger (λgeek) 0e0f1b9be0 [mini] Move some MONO_API functions to public header (#15105)
* [mini] Move some MONO_API functions to public header

And mark them all MONO_RT_EXTERNAL_ONLY.

mono_set_use_llvm is new - Xamarin.Android previously assigned to mono_use_llvm
directly.
2019-06-14 11:33:11 -04:00
Johan Lorensson b33c379057 Enable aotcheck and test-aot CI tests on Windows x64. (#15062) 2019-06-14 15:56:24 +02:00
Egor Bogatov 4212270b23 Fix csproj 2019-06-14 13:16:46 +02:00
Johan Lorensson a382edc9e1 Deadlock in loader when using bundling. (#15061)
We can hit the following deadlock when loading assemblies (using reflection)
together with bundling:

One thread calls mono_assembly_open_from_bundle, that will take assemblies lock
and then try to load assembly. If this race with a different load of the
same assemblies, one will lose, and that method will call mono_image_close that
in turn will call unload hook (mono_class_unregister_image_generic_subclasses)
that will take loader lock.

If we at the same time have a different thread that calls mono_class_create_from_typedef
, it will take loader lock and then it might end up calling mono_assembly_load_reference
that will take assemblies lock, but since that thread takes the locks
in different order compare to first thread, they could deadlock.

Looking into the use of assemblies lock in mono_assembly_open_from_bundle it
uses a static variable, bundles, that is not protected in other scenarios
and only set by mono_register_bundled_assemblies, normally called during
boot. The method called in the loop mono_image_open_from_data_internal is called
at several places without locks (and looks internal using image lock), so that
doesn't need to be protected. The rest is local data access and the only thing the
lock could do is serialize the whole loop between threads (but that shouldn't be needed).

Fix will remove the locking and also eliminating the incorrect lock order
causing the deadlock.
2019-06-14 11:20:28 +02:00
Marek Safar 9010d2f290 [netcore] Clean up netcore build 2019-06-14 11:03:35 +02:00
Ben Adams 12b737d980 Intrinsicify SpanHelpers.IndexOf(char) (dotnet/coreclr#22505)
* Helpers to support Intrinsics in SpanHelpers.Char

* Intrinsicify SpanHelpers.IndexOf(char)

* Feedback

* fix

* Fix assert

* Improve comment warning

* fix

* fix

* Fix

* Fix

Signed-off-by: dotnet-bot <[email protected]>
2019-06-14 09:37:52 +02:00
Jay Krell 467fd6516b Fix S390x compile since #14870 and a warning. (#15056) 2019-06-14 00:37:06 -05:00
Larry Ewing 56e27ca309 [wasm] fix most cases of numeric debugging for wasm
Fix the signededness of numeric types and use double
for the display of everthing since we are stuck with that
on the js side.
2019-06-13 22:25:23 -05:00
imhameed e6e9d5f6eb Don't create a cycle when translating IL break to IR. (#14980)
Don't create a cycle when translating IL `break` to IR.

`mono_emit_jit_icall` adds the instruction it generates to the current
basic block, and the redundant use of `MONO_ADD_INS` on an instruction
that has already been added to a BB will create a cycle in the `prev`
link chain.

Fixes #9706.
2019-06-13 13:56:07 -04:00
Jo Shields 1e0890f61f Ensure start-compiler-server.sh is in tarballs (#15071) 2019-06-13 13:10:38 -04:00
Jo Shields 7c99f6f249 [netcore] Add native ARM64 build to --with-core=only matrix (#14536)
* [netcore] Add native ARM64 build to `--with-core=only` matrix
2019-06-13 13:06:56 -04:00
dotnet-maestro 8affbbe98d Update dependencies from https://github.com/dotnet/arcade build 20190612.21
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19312.21
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19312.21
2019-06-13 17:32:22 +02:00
Ryan Lucia 20d83c24d6 Propagate error in mono_unicode_to_external (#14879)
* Add internal version of mono_unicode_to_external to propagate error

* Migrate things to _error version where sensible

* Remove redundant goto

* Print input string when conversion fails

* Remove todos

* Switch everything to MonoError

* Naming: err -> error

* Actually print out *filename correctly
2019-06-13 17:03:34 +02:00
Kenneth Pouncey e795253dc7 Fix generated warning of driver.c (#15036)
The following warning is generated when building master for interpreter as well as during AOT build of driver.c

```
driver.c:346:31: warning: initializing 'const MonoBundledAssembly **' with an expression of type 'MonoBundledAssembly **' discards qualifiers in nested pointer types [-Wincompatible-pointer-types-discards-qualifiers]
                const MonoBundledAssembly **bundle_array = g_new0 (MonoBundledAssembly*, assembly_count + 1);
                                            ^              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
2019-06-13 15:15:30 +02:00
Marek Safar ffe5166a9b [System.Private.CoreLib] Add licence headers 2019-06-13 09:45:50 +02:00
Marek Safar f2c74837d2 [netcore] Bump roslyn version 2019-06-13 09:44:12 +02:00
Stephen Toub 5eedd4f813 Fix nullable annotations on Binder.ReorderArgumentArray
Signed-off-by: dotnet-bot <[email protected]>
2019-06-13 09:44:12 +02:00
Stephen Toub 001844340a Remove defunct !s and update some TODO-NULLABLE comments
Signed-off-by: dotnet-bot <[email protected]>
2019-06-13 09:44:12 +02:00
dotnet-maestro[bot] 8eec14a2f1 Update dependencies from dotnet/arcade (dotnet/corefx#38474)
* Update dependencies from https://github.com/dotnet/arcade build 20190611.2

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19311.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19311.2
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19311.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19311.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19311.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19311.2
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19311.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19311.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19311.2
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19311.2
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19311.2

* Update `where T : object` constraint to be `where T : notnull`

* Update several TODO-NULLABLE comments

Signed-off-by: dotnet-bot <[email protected]>
2019-06-13 09:44:12 +02:00
Alexander Kyte 4ba594ad25 [crash] Print native module name when crash privacy disabled (#14986)
This makes it so that disabling crash privacy ensures we get the full native symbols printed regardless of allow and deny lists.

Before: https://gist.github.com/alexanderkyte/2b1f38a880c61ea15aa4c851e44af578

After: https://gist.github.com/alexanderkyte/ce80788a51761d91890d812874fa2da2
2019-06-13 10:07:10 +03:00
Marek Safar ad3150a5c5 Convert PermissionSet NIE to PlatformNotSupportedException (#25114)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-13 08:49:27 +02:00
Alexis Christoforides 167564efc6 Another speculative fix for 'pkg-config' sometimes getting built as a 32-bit package regardless of arch configuration (#14955)
Mono issue: https://github.com/mono/mono/issues/13804

The hypothesis is that at reconfigure using the configure cache file, the lack of explicit setting of the host somehow breaks the build process.
2019-06-13 06:34:03 +03:00
Zoltan Varga f87af4bfef [wasm] Simplify AOT profiling initialization. (#15038)
Current steps:
- Call MONO.mono_wasm_init_aot_profiler (null) before calling MONO.mono_load_runtime_and_bcl ().
- Call WebAssembly.Runtime.StopProfile () from the c# code to stop profiling.
- The profile data will be in Module.aot_profile_data.
2019-06-12 18:07:24 -04:00
Kenneth Pouncey 7eadeb3747 Add DataView test cases to BindingsTestSuite. 2019-06-12 16:40:46 -05:00
Kenneth Pouncey 98092c280b Add a private routine UnBoxValue to fix cast exceptions. 2019-06-12 16:40:46 -05:00
Kenneth Pouncey ce1d92568c [wasm][bindings] Add binding support for DataView 2019-06-12 16:40:46 -05:00
Jo Shields 607bd23f2e Install bc as a Linux prerequisite (#15046)
Our run-step logic uses `bc` to calculate step times, so `bc` is
needed to avoid ugly things on the console like:
```
../scripts/ci/./run-step.sh: line 59: echo: write error: Broken pipe
```
2019-06-12 15:45:22 -04:00
Jo Shields 698aed3946 Increase timeout on --core=only CI to 90 minutes, for ARM's benefit (#15044) 2019-06-12 15:27:00 -04:00
dotnet-maestro cf87874290 Update dependencies from https://github.com/dotnet/arcade build 20190611.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19311.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19311.2
2019-06-12 19:00:44 +02:00
Stephen Toub 6a2f0d94d1 Add missing TraceOperationCreation log event in GetStateMachineBox (#25097)
This was removed accidentally as part of overhauling the async infrastructure in 2.1. VS depends on it for some task tracking logic.

Signed-off-by: dotnet-bot <[email protected]>
2019-06-12 18:59:56 +02:00
monojenkins 4471332fd9 Bump API snapshot submodule 2019-06-12 18:57:17 +02:00
Zoltan Varga 918d7b0aaa [corlib] Add missing Unsafe.Unbox () method.
Fixes https://github.com/mono/mono/issues/14871.
2019-06-12 18:57:17 +02:00
Egor Bogatov 3a0191194b [netcore] Enable CoreFX tests on CI for Linux (#15015)
* Enable CoreFX tests on CI for Linux

* implement NativeLibrary.Unix.cs

* add missing libc

* add few -nonamespace

* more flaky tests
2019-06-12 18:55:44 +02:00
Larry Ewing bd7cb7e4d4 Enable the compiler server by default 2019-06-12 10:58:25 -05:00
Marek Safar 225890a180 [System.Private.CoreLib] Clean up few not implemented exceptions 2019-06-12 15:35:29 +02:00
Zoltan Varga a9949782d6 [runtime] Fix gshared support for BeginInvoke ()/EndInvoke () wrappers. (#14985)
Fixes https://github.com/mono/mono/issues/14972.
2019-06-12 09:18:14 -04:00
Vlad Brezae 9c265ace06 [jit] Fix interface cast (#14978)
* [jit] Throw exception if casting fails for special array interface

After the standard interface check (mini_emit_iface_cast), for special interfaces we need to do additional checks. We were skipping these checks if the object was not an array, without throwing a cast exception. This code path is reached for configurations where remoting is disabled.

Fixes https://github.com/mono/mono/issues/14729

* [tests] Add test for interface casting case

This test would have failed on fullaot lane for example.
2019-06-12 15:42:46 +03:00
Marius Ungureanu 669629330f Plug leak of ppdb_filename
mono_image_open_metadata_only and its callees all dupe the filename string, so free the string after mono_image_open_metadata_only is done with it:

```
      1 (128 bytes) ROOT LEAK: 0x7fb07f086c80 [128]  length: 105  "/Users/therzok/Work/md/md-addins/external-addins/MonoDevelop.MonoDroid/build/Xamarin.Installer.Common.pdb"
```
2019-06-12 14:22:24 +02:00
Maxim Lipnin 578b91eb07 Fix some warning related to nullability of reference types 2019-06-12 14:20:09 +02:00
Aleksey Kliger cd8b760220 [runtime] Switch to GC Unsafe for all GC external API functions
Fixes https://github.com/mono/mono/issues/14975
2019-06-12 14:11:01 +02:00
Martin Baulig a44db72a1c [System.Net.Http]: Add hack to the legacy HttpClient to pass down Timeout property. #12577. (#14970)
* [System.Net.Http]: Add hack to the legacy HttpClient to pass down Timeout property. #12577.

* `HttpClientHandler`, `IMonoHttpClientHandler`: add new internal `MonoSetTimeout (TimeSpan)` function.

* `HttpClient.SendAsyncWorker()`: if `handler` is `HttpClientHandler`, call the new internal
  `MonoSetTimeout()` function to pass down the timeout.

* `MonoWebRequestHandler.SendAsync()`: this is only used here to pass the timeout to the `HttpWebRequest`.

* Address feedback.

* Update HttpMessageInvoker.cs

* Make it build.

* Really make it build (forgot monotouch_watch).
2019-06-12 09:42:20 +02:00
Koundinya Veluri 2c7c7398bb Track timer count and add Timer.ActiveCount (dotnet/coreclr#25061)
* Track timer count and add Timer.Count

Part of https://github.com/dotnet/corefx/issues/38422

* Use lock to prevent tearing

* Add assert

* Rename Count to ActiveCount

* Fix build

Signed-off-by: dotnet-bot <[email protected]>
2019-06-12 09:41:15 +02:00
Egor Bogatov 56398813ae [netcore] Run CoreFX tests on CI (macOS) (#14849) 2019-06-12 09:40:15 +02:00
Zoltan Varga dd0f7eb2e1 [corlib] Preserve System.RuntimeType. 2019-06-12 08:50:06 +02:00
Aleksey Kliger bf61c7c973 [.github] Update CODEOWNERS 2019-06-12 08:46:16 +02:00
Zoltan Varga bcd14601c2 [aot] Open AOT profile files using "rb" so it works on windows.
Fixes https://github.com/xamarin/xamarin-android/issues/3168.
2019-06-12 08:31:05 +02:00
Stephen Toub d2e9be7d08 Update IEquatable/IComparable<T> for nullability (dotnet/coreclr#25053)
We need to revise our use of nullable for `IComparable<T>` and `IEquatable<T>`:
- For reference types that implement `IComparable<T>`, the implementation should use `IComparable<T?>`, e.g. `String : IComparable<String?>`, so that the type can be used in methods with a `where T : IComparable<T>` constraint: `IComparable<T>`'s contravariance then allows both `T` and `T?` to work as generic type arguments.
- For reference types that implement `IEquatable<T>`, we can't take advantage of such contravariance, as by design `IEquatable<T>` is invariant (it would be a breaking change to make it contravariant, and even if it wasn't doing so is of questionable design given that equality and inheritance don't mix well).  Given the current language design, we have little option but to explicitly make any reference type implementations of `IEquatable<T>` be oblivious, and also make all `where T : IEquatable<T>` constraints be oblivious.  Otherwise, regardless nullable annotations, a developer will get a warning for using either or both of `T`/`T?` with any given method employing such a constraint.

Signed-off-by: dotnet-bot <[email protected]>
2019-06-11 20:10:51 +02:00
Acid Chicken (硫酸鶏) c31180acc5 Fix Japan's new era fallback isn't reflected in Mono (#14896)
* Fix Japan's new era fallback isn't reflected in Mono

refs: <https://github.com/dotnet/coreclr/pull/23614>

* Fix array length

* Fix MonoTests.System.Globalization.CalendarTest

* Fix MonoTests.System.Globalization.EastAsianLunisolarCalendarTest

* Fix era index

refs: 1715e1d0e738ce95382ba372c24502967002a2f0

* Amend fixing

refs: 05af6e6f75fcea76e3d9e9f2f95f0caedb753aa7
2019-06-11 19:16:56 +02:00
Maryam Ariyan 9c542c174d Make Debug.Print(string) behavior consistent with .NET Framework (#25036)
*     Debug.Print should call Debug.WriteLine
    - to behave similar to .NET Framework

* temporarily disable tests
- Waiting for coreclr/fx changes to propagate

Signed-off-by: dotnet-bot <[email protected]>
2019-06-11 18:56:15 +02:00
Zoltan Varga 23ab664623 Revert some changes which don't have proper dependencies. 2019-06-11 11:51:10 -05:00
Zoltan Varga 1f289c9e44 Add a rule to create /aot-in. 2019-06-11 11:51:10 -05:00
Zoltan Varga 16c1682494 Make the creation of the dummy assemblies deterministic. 2019-06-11 11:51:10 -05:00
Zoltan Varga 23573b5348 [wasm] Avoid rebuilding the wasm files for the aot images if the aot image hasn't changed. 2019-06-11 11:51:10 -05:00
Zoltan Varga 0af5b236f9 [wasm] Make the cross compiler emit a depfile, not used yet. 2019-06-11 11:51:10 -05:00
Zoltan Varga 6b5779a956 [wasm] Fix dependencies for mscorlib. 2019-06-11 11:51:10 -05:00
Zoltan Varga d010cf5048 [aot] Avoid recompiling the dedup image if it hadn't changed. 2019-06-11 11:51:10 -05:00
Zoltan Varga d22e537c4e [wasm] Make the linker output deterministic. Avoid AOTing mscorlib if it havent' changed. 2019-06-11 11:51:10 -05:00
Zoltan Varga 8326c11779 [wasm] Compile the dedup image to wasm as well. Fix the dependencies of the dedup image. Fix a typo. 2019-06-11 11:51:10 -05:00
Alexander Kyte e4d3752684 [llvm] Fix disabling direct calls and inlining (#14880)
* [llvm] Enable disabling inlining on llvm

* [llvm] Fix disabling direct calls on llvm

* [llvm] Rename mono_inited even when doing self_init (generated init functions refer to it)
2019-06-11 12:30:04 -04:00
dotnet-maestro 22887567e1 Update dependencies from https://github.com/dotnet/arcade build 20190610.24
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19310.24
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19310.24
2019-06-11 17:17:07 +02:00
Aleksey Kliger (λgeek) 5440491ae8 [install] Include .exe extension when symlinking the mono binary (#14958)
Prevent the SDKs from making dangling symlinks when packaging the MXE
cross-compilers: should hav

    mono.exe -> mono-sgen.exe

rather than

    mono -> mono-sgen (dangling).
2019-06-11 09:42:24 -04:00
Johan Lorensson 3a193b7ae5 Merge pull request #14811 from lateralusX/lateralusX/fix-lmf-with-ctx-windows-msvc
Fix interpreter failure in install_eh_callback.exe under Windows x64 MSVC.
2019-06-11 13:22:18 +02:00
Jay Krell c398e19d35 Remove JIT icall hashing by address. (#14870)
* Work toward removing JIT icall hashing by address.

* Remove JIT icall hashing by address.

* Cleanup amd64 emit_call use.

* Move MonoJumpInfoTarget to among types, not functions.
If mini.h includes mini-runtime.h, then can move it nearer MonoJumpInfo.
Or if returned by out parameter (pointer) instead of struct by value.
Or pair of out parameters instead of struct.

* Closer to historical semantics, at least to avoid assertion failure, will try to refine in a later PR.

* Remove new comments about partial barriers, I think the comments are wrong and the code is correct (except that lock/unlock probably need to be full barriers, if they are not.)

* PR: Don't worry about size of MonoCallInst.jit_icall_id. Let it be 32 or 64 bits instead of 9.
2019-06-11 07:40:39 +03:00
dotnet-maestro 3dd5240c72 Update dependencies from https://github.com/dotnet/arcade build 20190609.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19309.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19309.1
2019-06-10 17:34:18 +02:00
dotnet-maestro 3ec86e017f Update dependencies from https://github.com/dotnet/arcade build 20190608.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19308.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19308.1
2019-06-10 13:36:50 +02:00
Marek Safar 7f2d519b0d [System.Private.CoreLib] Update public APIs 2019-06-09 13:01:50 +02:00
Zoltan Varga 23a928826c [wasm] Prototype for collecting aot profile data. (#14865)
* [runtime] Add some options to the aot profiler:
- write-at-method=<METHOD> Write the data when <METHOD> is compiled.
- send-to-method=<METHOD> Call <METHOD> with the collected data.

* [wasm] Fix profiler support in the packager.

* [wasm] Add prototype for generating aot profile data.

* Fix indentation.
2019-06-08 23:16:18 -04:00
dotnet-maestro bcf03bc442 Update dependencies from https://github.com/dotnet/arcade build 20190607.62
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19307.62
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19307.62
2019-06-08 22:51:37 +02:00
dotnet-maestro 4469cdaffc Update dependencies from https://github.com/dotnet/arcade build 20190606.12
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19306.12
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19306.12
2019-06-08 22:51:37 +02:00
Michal Strehovský b2768ac469 Move Marshal class to S.P.CoreLib (dotnet/corert#7502)
After this change, CoreRT only uses S.P.Interop to host the interop hashtable readers. Those can't move to CoreLib because they call into the type loader.

I didn't touch ProjectN's version of Marshal and I left the `PInvokeMarshal` class in place to help with that. I guess we'll need to make a call at some point on what to do with S.P.Interop since without MCG the code in it is kind of useless.

Signed-off-by: dotnet-bot <[email protected]>
2019-06-08 22:50:24 +02:00
Jay Krell 440764a82e g_new/g_new0 in wasm/driver.c (#14890) 2019-06-08 13:38:20 -04:00
Jay Krell 63f17d2f55 Cleanup amd64 emit_call / emit_call_body -- last parameter always FALSE. (#14897)
And it is reasonable to expect that to remain the case, as C compilers
do not generate code as would occur with the last parameter = TRUE.

They allocate the room for their maximum outgoing parameters at function entry,
and keep a constant stack, except for functions that call _alloca,
and this code risks but not necessarily breaks ABI compliance.

In particular, the rsp adjustment either needs unwind codes, or needs
to only occur in a function with a frame pointer other than RSP.

And the uwind codes for adding to RSP are very tricky to impossible.
Normally you only ever subtract from RSP. There is an unwind code for that.
But there isn't really for add.
You might be able to simulate it with chained unwind, making these
regions look kinda like end of function.
But this is all most unlikely.
2019-06-08 13:38:00 -04:00
monojenkins 609878dcb5 [bcl] Update BCL Linked Size 2019-06-08 09:35:38 +02:00
Steve MacLean 11761ebd7f Fix AppDomain issues (dotnet/coreclr#25019)
Populate AppDomain.CurrentDomain when invoking events
Make AppDomain method implemented in AssemblyLoadContext internal

Signed-off-by: dotnet-bot <[email protected]>
2019-06-08 09:34:45 +02:00
Carlos Sanchez Lopez 132969ee3e Fix issue in NamedPipeServerStream.GetImpersonationUserName() (#37676)
Fix for issue where NamedPipeServerStream.GetImpersonationUserName() throws unexpected InvalidationOperationException("The operation completed successfully") when impersonation is not allowed, when in fact it should simply return an empty string.

The fix will call GetNamedPipeHandleStateW once. If it fails, it will try to load sspicli.dll if it was not loaded, and will reattempt the call to GetNamedPipeHandleStateW.

This fix is only for Win32: UAP does not allow calling LoadLibraryEx, and Windows Nano says denies access to GetNamedPipeHandleStateW even after attempting to load sspicli.dll.

Signed-off-by: dotnet-bot <[email protected]>
2019-06-08 08:52:42 +02:00
Zoltan Varga 16532397c3 [wasm] Switch to the LLVM wasm backend. (#14734)
* [wasm] Switch to the llvm wasm backend.

* [wasm] Packager changes for the wasm backend.

* -s EMULATED_FUNCTION_POINTERS=1 no longer needed.
* Run wasm-strip on the final binary.
* Run opt during AOT.
* Disable the dynamic build for now, it doesn't seem to work with the wasm backend.

* [wasm] Use STACK_MAX instead of STACK_BASE for the bottom limit of the stack.

* [aot] Handle llvmopts= in llvmonly mode as well.

* [wasm] Disable an assertion which is no longer true with the wasm backend.

* [wasm] Disable computed gotos in the interpreter, the wasm backend doesn't support it.

Fix llvm target layout so its compatible with clang compiled code.

* [wasm] Pass llvm-path to the cross compiler.

* [wasm] Fix some problems with the dynamic build, still doesn't work. Fix packaging.

* [wasm] Pass -s DISABLE_EXCEPTION_CATCHING=0 to the runtime build, otherwise catch clauses are not generated in llvm-runtime.cpp.

* [aot] Allow llvmopts= argument multiple times.

* Bump emscripten version to 1.38.34.

* [wasm] Add https://github.com/emscripten-core/emscripten/pull/8457 as a patch.

* [wasm] Compile the aot .bc files to .o in a separate step using emcc, this will help with incremental compilation later.

* [wasm] Source emsdk_set_env.sh instead of emsdk_env.sh the latter calls emsdk construct_env to construct emsdk_set_env.sh which is racy.
2019-06-08 00:46:56 -04:00
Jerome Laban f5cfc67c8e [Wasm] Fix memory override in mono_wasm_add_assembly 2019-06-07 22:00:31 -05:00
Jeremy Kuhne 4102c7fd90 Fix redist
Signed-off-by: dotnet-bot <[email protected]>
2019-06-07 23:17:51 +02:00
Santiago Fernandez Madero 355d611e94 Address nullable feedback for System.Runtime and System.Runtime.Extensions (#25017)
* Address last nullable feedback from System.Runtime

* Address nullable feedback for System.Runtime.Extensions

* PR Feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-06-07 23:17:51 +02:00
Stephen Toub 3f1bca5a34 Add [NotNull] to syncLock parameter of EnsureInitialized (#25012)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-07 23:17:51 +02:00
Sung Yoon Whang cf93ce4fce Add DisplayUnits property to DiagnosticCounter (dotnet/coreclr#24981)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-07 23:17:51 +02:00
Ankit Jain 46108fd7de Bump msbuild to track xplat-master (#14814)
Picks up changes in msbuild after:
	[mono] Update SDKs to track cli branch `release/2.1.8xx`

(https://github.com/mono/msbuild/pull/110)
2019-06-07 21:54:03 +02:00
Alexander Kyte d54a6544b3 [crash] Move /proc/self/maps crash collection to created JSON blob (#14704)
* [runtime] Don't print /proc/self/maps on Android

* [runtime] Add proc mapping to crash JSON output

* [runtime] Zero initialize locals in threading macros

* [crash] Filter out illegal characters from process_maps

* [crash] Prevent concurrent reads from /proc/self/maps

* [crash] Clean up memset in g_async_safe_fgets

* [crash] Remove stack staging array in async_safe_fgets

* Revert "[crash] Prevent concurrent reads from /proc/self/maps"

This reverts commit f65166559ad24ad65c530f7abbc096e4d4634878.
2019-06-07 15:18:57 -04:00
Calvin Buckley 18e0ebfe89 AIX/PASE integration improvements (#14652)
* Allow using SysV-style sonames on AIX/PASE

This uses a far saner naming convention with libtool, and is
consistent with the official PASE RPM repository. However, some
loader changes are required to make it "just work" and workaround
some real dumb behaviour on AIX's part.

Note that while Mono works when built without the different soname
tweak, it won't when installed, because the convention is strange
and the libtool .la archives won't be installed. It's recommended
as such that installation of Mono keeps the libtool files or just
uses SVR4 sonames like the rest of the world, even if they're made
strange like AIX.

* Specify a specific version of unixODBC, make an include

A workaround against PASE RPMs of unixODBC not including the just
"libodbc.so" except in the development version. If a platform needs
a specific version (the macOS reference not changed in the DllMap)
then it can be specified in the configure script.

AIX doesn't need a special name because both AIX Toolbox and Perzl
include non-archive libraries in /opt/freeware/lib - unexpected.

* Don't try to use shm_open on PASE due to it not being implemented

All this will do is cause a coredump if running the script on PASE,
and write an entry to the SLIC diagnostic logs. This test could be
re-enabled if i 7.4 supports it properly.

* fix ODBC include

* Check for what library to use for libintl when dlopenning on AIX

These checks are for the benefit of the DllMap. The construct used
is kinda hacky, IMHO, but it resolves the concerns of hardcoding.
In the event that this doesn't work (it does for me), it falls back
to what the IBM RPMs seem to use for linking gettext et al.

Not sure of the utility for other platforms, since they usually
use sane soname conventions and the one-liner here depends heavily
on an AIX developer tool and its output format.

The use of cut/awk should work with the stock AIX utils, no GNU
necessarily needed.
2019-06-07 20:02:43 +02:00
Martin Baulig 96125c693c Bump CoreFX to pickup https://github.com/mono/corefx/pull/298. (#14851) 2019-06-07 13:14:21 -04:00
Martin Baulig ac908dd334 Implement RSACertificateExtensions.CopyWithPrivateKey(). #14152. (#14860)
* Implement RSACertificateExtensions.CopyWithPrivateKey().  #14152.

* RSACertificateExtensions.CopyWithPrivateKey(): implement.

Since `RSACertificateExtensions` lives in `System.Core` and only `mscorlib`
internals (but not `System` internals) are visible to it, we need to use a
little trick here:

* System.Security.Cryptography.X509Certificates.X509CertificateImpl:
  add new abstract methods CopyWithPrivateKey() and CreateCertificate().

* System.Security.Cryptography.X509Certificates.X509Certificate2Impl:
  sealed implement them here.

The `httpcfg` tool, only checks whether the key is valid, so we don't really
need to call `CopyWithPrivateKey()` (which requires us to take a dependency
on `System.Core`).

* Do the same thing in HttpListener.
2019-06-07 13:13:48 -04:00
Aleksey Kliger (λgeek) 277bbdaada [runtime] Make cross-appdomain wrappers throw NIE for methods with ref struct args (#14863)
* [AppDomain] Cross-appdomain wrapper throws NIE for methods with ref struct arguments

If we have a ref struct and a method that takes it as an argument:

```
[Serializable]
public ref struct R {
  public int i;
}

public interface I {
  public void M1 (R r, SomeClass o);
}

public class M : MarshalByRefObject, I {
  public void M1 (R r, SomeClass o) { ... }
}
```

If we create an instance of M in another domain and try to call it:
```
  I obj = (I)otherDomain.CreateInstanceAndUnwrap (typeof(M).Assembly.FullName,
  nameof(M));
  R r;
  r.i = 42;
  SomeClass o = ...;
  obj.M1 (r, o);
```

Mono will need to create a wrapper that can invoke M.M1 in the other domain.
The way the wrapper works in `mono_marshal_get_xappdomain_invoke` is by
creating an array of all the arguments that need to be serialized (see
`mono_get_xdomain_marshal_type`) and then serializing the whole array (by
calling out to `System.Runtime.Remoting.RemotingServices.SerializeCallData`).
In the example it would make a two element array and try to serialize `r` and
`o` into it. For valuetypes it normally does this by boxing the argument.
However since `R` is a ref-struct, boxing it is not allowed.

This works on .NET Framework.

However for Mono we would need to serilize `R` without boxing it, which seems
challenging with our current setup.

So for now we generate a wrapper that just throws a NotImplementedException if
it is ever called.

This fixes https://github.com/mono/mono/issues/14809 (in that marshalling a
TextWriter across domains works again) but in an unsatisfactory way (because
you can't call any of the ReadOnlySpan<char> overloads on the transparent proxy
object).

* [corlib] Add back Serializable attribute on some reflection classes

Tests that use https://www.nuget.org/packages/NUnit.ApplicationDomain/
need to serialize MethodInfo (and hence MethodBase).

* [corlib] Add test for transparent proxies for classes with methods that take
ref struct args

Regression test for https://github.com/mono/mono/issues/14809

* Bump API snapshot submodule
2019-06-07 13:06:32 +02:00
Ryan Lucia 65608fe3f4 Remove exclusions for resolved issue 2019-06-07 09:31:43 +02:00
Tanner Gooding e0471729b0 Marking Vector128<T>.Count and Vector256<T>.Count as [Intrinsic] (#24991)
* Marking Vector128<T>.Count and Vector256<T>.Count as [Intrinsic]

* Fixing NI_Vector128_Count and NI_Vector256_Count to use clsHnd when getting the simdSize and baseType

* Applying the formatting patch.

* Changing some comments to just be "vector element count".

* Fixing impBaseIntrinsic to set the baseType so Vector128_Count and Vector256_Count don't return nullptr

Signed-off-by: dotnet-bot <[email protected]>
2019-06-07 07:10:14 +02:00
Zoltan Varga bd1ad0089f Switch Hashtables to Dictionary in the encoding classes so Hashtable can be linked out. (#14774) 2019-06-06 23:03:22 -04:00
Bernhard Urban 03c6855d05 [ios] switch cross32/crosswatch to be executed on x86_64 and use newer LLVM (#14852)
Contributes to https://github.com/mono/mono/issues/9621
Fixes https://github.com/mono/mono/issues/14841

Note that it breaks iOS 32bit on devices. The Apple Watch _might_ still works (only tested on `2019-02`).  It unblocks some build related issues on the Xamarin.iOS `2019-06` integration, and we have to do it anyway. I'll come back to it to fix device related issues.
2019-06-07 00:01:00 +02:00
Ryan Lucia a5a26a2f92 Add logic to object array typecheck to handle arrays of unmanaged pointers (#14733)
Fixes #14555 

The NULL check alone is not enough, because interfaces are also parented to NULL for some reason, and so I've moved `class_kind` out from the bitfield section to make it accessible from IR. The beginning of the struct is going to be padded to 32 bits anyway at the least, so this move should save space if anything.

Our type checking overall is not very robust, and in particular the supertype comparison doesn't work well for anything that isn't an object, so it's possible there are some other weird corner cases. As far as I can tell looking through the array of objects stuff though, we should have reasonable coverage with the existing tests + the stuff I added.
2019-06-06 15:38:57 -04:00
Ryan Lucia 6d2c77fb33 Switch supported runtimes storage from an array to a list (#14777)
Fixes #12141 

Switched to a list because in theory any number of tags can be present. Old behavior was to put them into an array of size 3 and zero the byte following them, which was causing the crash with more than two tags. There's no null check for the default runtime because that should never happen, and the list is reversed to preserve the order from the XML. Changing the signature of `get_runtimes_from_exe` should be fine because it's static and only called in the one place.
2019-06-06 15:02:57 -04:00
Jan Kotas 4d5807110f Delete unnecessary security transparency attributes (dotnet/coreclr#25007)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-06 20:57:11 +02:00
Bernhard Urban 812357ec51 [mach] cast objc_msgSend{,Super} usages (#14836)
Fixes #14792
2019-06-06 20:14:59 +02:00
Martin Baulig 88c05a8910 Bump CoreFX to pickup https://github.com/mono/corefx/pull/298. 2019-06-06 13:45:29 -04:00
Bernhard Urban e8367ce3d7 [llvm] emit call to mini_llvmonly_throw_nullref_exception without exceptions in mind (#14840)
Fixes https://github.com/mono/mono/issues/14243
2019-06-06 19:24:20 +02:00
Alexander Kyte 364a8423e3 [runtime] Gracefully skip AOTing problematic assemblies (#14232) 2019-06-06 12:07:31 -04:00
Egor Bogatov b861cacd48 [netcore] Improve netcore/build.sh script (#14835)
* Improve netcore/build.sh

* bump corefx tests version

* ignore StringTests failures

* Ignore more tests for xtestall

* Implement Environment.TickCount64

* cleanup

* Add two debug-* rules
2019-06-06 17:43:57 +02:00
dotnet-maestro 636e06334f Update dependencies from https://github.com/dotnet/arcade build 20190605.13
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19305.13
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19305.13
2019-06-06 17:28:03 +02:00
Thays Grazia 2da7707373 [Mono.Debugger.Soft] Properly close connections
This PR fixes #7377
2019-06-06 11:12:47 -03:00
dotnet-maestro 2e4b6b34ac Update dependencies from https://github.com/dotnet/arcade build 20190604.23
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19304.23
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19304.23
2019-06-06 13:47:26 +02:00
dotnet-maestro f02d09f7f6 Update dependencies from https://github.com/dotnet/arcade build 20190604.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19304.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19304.1
2019-06-06 13:47:26 +02:00
Martin Baulig 3998dc01c9 Make CalendarData more linker friendly.
See https://github.com/mono/corefx/pull/298 for a description of the
technique that we're using here to make it more linker friendly.
2019-06-06 13:40:53 +02:00
Alexander Köplinger 51202617a1 [sdks] Use 7z format for the android/ios/mac archives (#14837)
It has way better compression performance.
Kept WebAssembly on .zip for now since external users took dependencies on it [1].

Fixes https://github.com/mono/mono/issues/14215

[1] https://github.com/nventive/Uno.Wasm.Bootstrap/blob/e2bf8946e162642ca1bdf4f003f8de4a94954f73/Readme.md#updating-the-mono-sdk-build
2019-06-06 12:24:56 +02:00
Santiago Fernandez Madero 504a1a30fa More PR Feedback
Signed-off-by: dotnet-bot <[email protected]>
2019-06-06 10:32:52 +02:00
Santiago Fernandez Madero 420a9da24a PR Feedback
Signed-off-by: dotnet-bot <[email protected]>
2019-06-06 10:32:52 +02:00
Santiago Fernandez Madero eab7775571 PR Feedback
Signed-off-by: dotnet-bot <[email protected]>
2019-06-06 10:32:52 +02:00
Santiago Fernandez Madero c2796feb97 Fix some nullable annotations from API Review
Signed-off-by: dotnet-bot <[email protected]>
2019-06-06 10:32:52 +02:00
Santiago Fernandez Madero a8fd49434f Remove stale Task async extension methods from TaskExtensions (#24958)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-06 10:07:27 +02:00
Santiago Fernandez Madero 992eacfac9 Remove Collection<T> range APIs (dotnet/coreclr#24938)
Signed-off-by: dotnet-bot <[email protected]>
2019-06-06 10:07:27 +02:00
Jay Krell 515234a128 [thread] Print function name when asserting MonoThreadInfo is non-NULL (#13814)
https://github.com/mono/mono/issues/13813.
2019-06-06 10:40:39 +03:00
monojenkins bf78c04740 [bcl] Update BCL Linked Size 2019-06-06 09:31:40 +02:00
Kenneth Pouncey 0562fde077 [wasm][bcl] Use zlib for DeflateStream on WASM profile (#14308)
* [wasm][bcl] Use zlib for DeflateStream on WASM profile

- Add `-s USE-ZLIB=1` flag for the emscripten build of `mono.js`
- Add new `zlib-helper` module build that is included in the `mono` wasm build.
- This adds roughly 300 kb to the size.

* Add zlib calls to `icall` for `WASM` profile

* Address comments use `TARGET_WASM` instead of `HOST_WASM`

* Hack around JS exception: RuntimeError: indirect call signature mismatch

- Instead of using the function pointer from DeflateStream (Marshal.GetFunctionPointerForDelegate) obtain the callback functions from the object itself.

* Update error messages and add exception parameter to `mono_runtime_invoke`.

* Add `mono/support` zlib include sources files to make `package` target.

* Add `zlib-helper` build to packager.

- Note: Right now only supports zlib build from mono tree build.
- Add `zlibtest.cs` scenario to compress and uncompress using DeflateStream and GZip.
- Add test to make file to build and run aot version of ziplibtest.

* Add copy of zlib header support files to `package-wasm-runtime`

- The support library is not built for wasm but the zlib include files are needed to build support during wasm build.
- See mono.js build and the use of the `-s USE_ZLIB=1` flag.
- The include files will be used in packager.exe to build zlib support for wasm.

* Use the zlib includes from support to build the zlib support.

* Setup base tests for testing System.IO.Compression integration

* Formatting

* Add more ziparchive tests

* Formatting and indentation

* Add more Zip tests

* Add more tests.

- Add more tests for ZipArchive.
- Add tests for Deflate - small, large and very large strings.
- Add tests for GZipStream - small, large and very large strings.

* Fix merge of EMCC_FLAGS

* Add new option to packager to enable the use of zlib

-   --enable-zlib (enable the use of zlib for System.IO.Compression support)
        type: bool  default: false

- update packager doc

* Address review comments

- Change `enable-zlib` to `zlib`
2019-06-06 05:07:56 +02:00
Martin Baulig 2b3a23c511 Bump CoreFX to pickup the fix for #14214. (#14821)
HttpClient.SendAsync() should not attempt to read response body on a HEAD request.

* CoreFX PR https://github.com/dotnet/corefx/pull/38129.

* Backported in https://github.com/mono/corefx/pull/297.

* Fixes https://github.com/mono/mono/issues/14214.
2019-06-05 22:14:14 -04:00
Egor Bogatov 181a602ace Fix build on macOS 10.15 Catalina + xcode 11 (#14820)
1) CC_MD5_Init, CC_MD5_Update and CC_MD5_Final are deprecated.

```c
mono-md5.c:45:2: error: 'CC_MD5_Init' is deprecated: first deprecated in macOS 10.15 - This function is
      cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256
      (or stronger). [-Werror,-Wdeprecated-declarations]
        CC_MD5_Init (ctx);
        ^
```

2) objc_msgSend is deprecated
```
mono-threads-mach-helper.c:95:17: error: too many arguments to function call, expected 0, have 2
                objc_msgSend (value, release);
                ~~~~~~~~~~~~  ^~~~~~~~~~~~~~
```
XCode has a special switch `Enable Strict Checking of objc_msgSend Calls` which is now `true` by default. It's fixed by `-DOBJC_OLD_DISPATCH_PROTOTYPES=1` flag to clang or the corresponding define in the source file.

3) Fixes https://github.com/mono/mono/issues/14793

It worked on pre 10.15 without `-framework GSS`, because it got pulled in through the dependencies. You can see it by running DYLD_PRINT_LIBRARIES=1 csharp and then trace it back. On Mojave /System/Library/Frameworks/GSS.framework/Versions/A/GSS got loaded as dependency of /usr/lib/libcups.2.dylib and so on. Unlike Windows, macOS will resolve the symbols to whatever is already available so it was just happy that someone loaded GSS before libmono-native[-compat/-unified].
2019-06-06 00:39:04 +02:00
Vlad Brezae e548a7d231 [interp] Inline more methods (#14755)
* [interp] Add support for inlining methods with locals

For each local in the inlined method we allocate a new local in the parent method.

* [interp] Enable inlining of methods using ldarga opcode

* [interp] Don't inline methods that do localloc

Inlining localloc in a loop leads to stack overflows. JIT has same behavior.
2019-06-05 22:05:30 +02:00
Alexander Köplinger a83f700546 [tests] Exclude more nunit categories on ios/mac (#14807)
A few more that we missed adding to the exclude file in the sdks archive.

(cherry picked from commit 3d9513efd4)
2019-06-05 21:14:53 +02:00
Egor Bogatov c5ed9bfc0d Reflect recent NS2.1 changes (#14679)
Due to few recent updates to dotnet/standard (NETStandard 2.1) we had 40 apicompat issues.
Mostly copy-pasted from dotnet/corefx.
Didn't implement Cryptography stuff yet.
Checked all profiles.

Implements #14609
2019-06-05 20:44:46 +02:00
Jerome Laban f7042d48a5 Enforce C++ exception support for the release-dynamic configuration 2019-06-05 11:19:21 -05:00
imhameed 993d484285 [jit] Treat ternary operations as non-constant during constant evaluation and propagation (#14782)
* Treat ternary operations as non-constant... (#13873)

...during constant evaluation and propagation.

* Move ternary SSA cfold test from basic.cs to objects.cs.
2019-06-05 17:42:18 +02:00
Brendan Zagaeski 888a8d44f6 [arm64] Correct exception filter stack frame size (#14757)
* [arm64] Correct exception filter stack frame size

Fixes: https://github.com/mono/mono/issues/14170
Fixes: https://github.com/xamarin/xamarin-android/issues/3112

The `call_filter()` function generated by `mono_arch_get_call_filter()`
was overwriting a part of the previous stack frame because it was not
creating a large enough new stack frame for itself.  This had been
working by luck before the switch to building the runtime with Android
NDK r19.

I used a local build of [xamarin/xamarin-android/d16-1@87a80b][0] to
verify that this change resolved both of the issues linked above.  I
also confirmed that I was able to reintroduce the issues in my local
environment by removing the change and rebuilding.

After this change, the generated `call_filter()` function now starts by
reserving sufficient space on the stack to hold a 64-bit value at the
`ctx_offset` location.  The 64-bit `ctx` value is saved to the
`ctx_offset` location (offset 344 in the new stack frame) shortly
afterwards:

    stp	x29, x30, [sp,#-352]!
    mov	x29, sp
    str	x0, [x29,#344]

As expected, the invocation of `call_filter()` now no longer modifies
the top of the previous stack frame.

Top of the stack before `call_filter()`:

    (gdb) x/8x $sp
    0x7fcd2774a0:	0x7144d250	0x00000000	0x2724b700	0x00000000
    0x7fcd2774b0:	0x1ee19ff0	0x00000071	0x0cc00300	0x00000071

Top of the stack after `call_filter()` (unchanged):

    (gdb) x/8x $sp
    0x7fcd2774a0:	0x7144d250	0x00000000	0x2724b700	0x00000000
    0x7fcd2774b0:	0x1ee19ff0	0x00000071	0x0cc00300	0x00000071

Additional background information
=================================

The original lucky, "good" behavior worked as follows for
[mono/mono/2018-08@725ba2a built with Android NDK r14][1]:

 1. The `resume` parameter for `mono_handle_exception_internal()` is
    held in register `w23`.

 2. That register is saved into the current stack frame at offset 20 by
    a `str` instruction:

           0x00000000000bc1bc <+3012>:	str	w23, [sp,#20]

 3. `handle_exception_first_pass()` invokes `call_filter()` via a `blr`
    instruction:

        2279							filtered = call_filter (ctx, ei->data.filter);
           0x00000000000bc60c <+4116>:	add	x9, x22, x24, lsl #6
           0x00000000000bc610 <+4120>:	ldr	x8, [x8,#3120]
           0x00000000000bc614 <+4124>:	ldr	x1, [x9,#112]
           0x00000000000bc618 <+4128>:	add	x0, sp, #0x110
           0x00000000000bc61c <+4132>:	blr	x8

    Before the `blr` instruction, the top of the stack looks like this:

        (gdb) x/8x $sp
        0x7fcd2774a0:	0x7144d250	0x00000000	0x0a8b31d8	0x00000071
        0x7fcd2774b0:	0x00000000	0x00000000	0x1ef51980	0x00000071

 4. `call_filter()` runs.  This function is generated by
    `mono_arch_get_call_filter()` and starts with:

           stp	x29, x30, [sp,#-336]!
           mov	x29, sp
           str	x0, [x29,#344]

    Note in particular how the first line subtracts 336 from `sp` to
    start a new stack frame, but the third line writes to a position
    that is 344 bytes beyond that, back within the *previous* stack
    frame.

 5. After the invocations of `call_filter()` and
    `handle_exception_first_pass()`, `w23` is restored from the stack:

           0x00000000000bc820 <+4648>:	ldr	w23, [sp,#20]

    At this step, the top of the stack looks like this:

        (gdb) x/8x $sp
        0x7fcd2774a0:	0x7144d250	0x00000000	0xcd2775b0	0x0000007f
        0x7fcd2774b0:	0x00000000	0x00000000	0x1ef51980	0x00000071

    Notice how `call_filter()` has overwritten bytes 8 through 15 of the
    stack frame.  In this original lucky scenario, this does not affect
    the value restored into register `w23` because that value starts at
    byte 20.

 6. `mono_handle_exception_internal()` tests the value of `w23` to
    decide how to set the `ji` local variable:

        2574			if (resume) {
           0x00000000000bb960 <+872>:	cbz	w23, 0xbb9c4 <mono_handle_exception_internal+972>

    Since `w23` is `0`, `mono_handle_exception_internal()` correctly
    continues into the `else` branch.

The bad behavior for
[mono/mono/2018-08@725ba2a built with Android NDK r19][2]
works just slightly differently:

 1. As before, the local `resume` parameter starts in register `w23`.
 2. This time, the register is saved into the stack frame at offset 12
    (instead of 20):

           0x00000000000bed7c <+3200>:	str	w23, [sp,#12]

 3. As before, `handle_exception_first_pass()` invokes `call_filter()`
    via a `blr` instruction.

    At this step, the top of the stack looks like this:

        (gdb) x/8x $sp
        0x7fcd2774a0:	0x7144d250	0x00000000	0x2724b700	0x00000000
        0x7fcd2774b0:	0x1ee19ff0	0x00000071	0x0cc00300	0x00000071

 4. `call_filter()` runs as before.  And the first few instructions of
    that function are the same as before:

        stp	x29, x30, [sp,#-336]!
        mov	x29, sp
        str	x0, [x29,#344]

 5. `w23` is again restored from the stack, but this time from offset 12:

           0x00000000000bf2c0 <+4548>:	ldr	w23, [sp,#12]

    The problem is that `call_filter()` has again overwritten bytes 8
    through 15 of the stack frame:

        (gdb) x/8x $sp
        0x7fcd2774a0:	0x7144d250	0x00000000	0xcd2775b0	0x0000007f
        0x7fcd2774b0:	0x1ee19ff0	0x00000071	0x0cc00300	0x00000071

    So after the `ldr` instruction, `w23` has an incorrect value of
    `0x7f` rather than the correct value `0`.

 6. As before, `mono_handle_exception_internal()` tests the value of `w23` to
    decide how to set the `ji` local variable:

        2574			if (resume) {
           0x00000000000be430 <+820>:	cbz	w23, 0xbe834 <mono_handle_exception_internal+1848>

    But this time because `w23` is *not* zero, execution continues
    *incorrectly* into the `if` branch rather than the `else` branch.
    The result is that `ji` is set to `0` rather than a valid
    `(MonoJitInfo *)` value.  This incorrect value for `ji` leads to a
    null pointer dereference, as seen in the bug reports.

[0]: https://github.com/xamarin/xamarin-android/tree/xamarin-android-9.3.0.22
[1]: https://jenkins.xamarin.com/view/Xamarin.Android/job/xamarin-android-freestyle/1432/Azure/
[2]: https://jenkins.xamarin.com/view/Xamarin.Android/job/xamarin-android-freestyle/1436/Azure/

* reduce frame size
2019-06-05 17:38:06 +02:00
lateralusX ae84befc0f Fix interpreter failure in install_eh_callback.exe under Windows MSVC.
INTERP_PUSH_LMF_WITH_CTX_BODY is not fully supported under Windows MSVC
since that compiler doesn't support taking address from a label, needed
by current implementation to correctly resume after unwinding exceptions
happening in native frames as tested by install_eh_callback.exe.

This fix add support to restore to a known location and use a flag
indicating if we have been resumed to the location or just passing by
for the first time. If we resume it will transfer control to specified label.
This will mimic the behavior of taking the address of a label and use that
address as the restore point and works like how setjmp/longjmp work.

I also considered switching to setjmp/longjmp but that would have had a bigger
impact on all platforms and needed changes into the resume context
machinery as well.

While doing the implementation I also found an interesting issue with
MONO_CONTEXT_GET_CURRENT under Windows x64. On most other platforms it is
implemented as inline assembler, but on MSVC x64 inline assembler is not
supported so it is implemented as a function. Problem with that is how IP
was resolved, since it won't be resolved to the last instruction in the
expanded macro, but to the IP within the mono_context_get_current. This has
not had any visible effects in the past since it will just do the ret and get
back to the call site, but when this was used in INTERP_PUSH_LMF_WITH_CTX_BODY
it caused some issues. This was fixed to make sure rsp and rip reflect location
in caller frame and not within mono_context_get_current, similar to how
it works on all platforms with inline assembler support.
2019-06-05 17:32:02 +02:00
Kenneth Pouncey 7a74dd65ff [wasm][sdk] Clean the managed directory files on /t:Clean build target (#14756)
* Clean the `managed` directory files on `/t:Clean` build target

* Modify the `CleanManaged` target to `_CleanManagedOutputDir`.

- Address comments by Mikayla.
2019-06-05 15:53:35 +02:00
Bijan Tabatabai a3de0304a1 Align mcs's tuple deconstruction behavior with csc
Before the code
(a, b) = (b, a);
was the equivalent of
a = b;
b = a;

now, it evaluates it to so something like
tmp1 = a;
tmp2 = b;
a = tmp2;
b = tmp1;

Signed-off-by: Bijan Tabatabai <[email protected]>
2019-06-05 13:08:59 +02:00
Johan Lorensson 644bfc93d4 Merge pull request #14760 from lateralusX/lateralusX/increase-windows-main-thread-stack-size
Increase main thread stack size on Windows.
2019-06-05 12:26:50 +02:00
Egor Bogatov d3101fbaeb [netcore] Download and use local .NET Core SDK (#14696)
* Download and use local .NET Core SDK

* depend on 'all' rule in nupkg

* fix build error

* Windows support

* use InitializeToolset function

* ouput full path of dotnet in init-tools.sh

* remove init-tools

* Add init-tools.ps1 (Windows)

* fix / issue on cygwin

* address Jo's feedback

* add powershell to PATH for make nupkg

* add netcore/build.sh

* handle pack and test commands

* Update tools.ps1

* Update tools.ps1
2019-06-05 11:52:00 +02:00
Youssef1313 9e5c2c1e52 Being consistent (dotnet/coreclr#24927)
Being consistent using all if statement with curly braces.

Signed-off-by: dotnet-bot <[email protected]>
2019-06-05 10:31:21 +02:00
Adam Sitnik 9fb74fb894 follow the ICU User Guide recommendation to optimize the perf of InvariantCultureIgnoreCase on Linux (#24889)
* follow the ICU User Guide recommendation to optimize the perf of InvariantCultureIgnoreCase on Linux:

1. try to guess the max size and call ucol_getSortKey just once
2. if the buffer is not big enough, call the method again providing the actual sort key length

* handle 0 case

* handle integer overflow

* shorten the time the buffers are pinned

* use the cheapest pinning

* code review fixes: don't use variable length stackalloc, don't copy text from docs (licensing) + don't try to go with the fast path when it would require allocating more managed memory for big strings

* simplify the condition

Signed-off-by: dotnet-bot <[email protected]>
2019-06-05 10:31:21 +02:00
Stephen Toub 5e1dd8d78d Remove unnecessary Shared<T> class from Task (dotnet/coreclr#24931)
It's just StrongBox<T>.

Signed-off-by: dotnet-bot <[email protected]>
2019-06-05 10:31:21 +02:00
Stephen Toub b4aa38f0c2 Adjust several where T : class? constraints (dotnet/coreclr#24894)
* Adjust several `where T : class?` constraints

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-06-05 10:31:21 +02:00
Michal Strehovsky 76526cf1c9 Work around ProjectN compiler bug
[tfs-changeset: 1738641]

Signed-off-by: dotnet-bot <[email protected]>
2019-06-05 10:31:21 +02:00
Aleksey Kliger be92baf12d [runtime] Autoconf check for pthread_mutexattr_setprotocol
Android doesn't always declare that function.
2019-06-05 09:55:34 +02:00
Johan Lorensson a76fc055cf Merge pull request #14694 from lateralusX/lateralusX/fix-llvm-build-path-msvc
Fix LLVM build break on Windows MSVC.
2019-06-04 11:16:49 +02:00
lateralusX 29a2383333 Increase main thread stack size on Windows.
On Windows default thread stack size has been 1MB for a long time
(both 32/64-bit). When starting to use interpreter some of the tests
include deep recursions that will hit stackoverflow on Windows
(ackermann.exe as one example). This commit adjust the default reserved
stack size to 8MB for debug builds and 1.5MB (same as coreclr), for main
thread only. All other threads will still default to 1MB stack size
(both debug/release).
2019-06-04 09:37:39 +02:00
Tanner Gooding 4b81fcbcd7 Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class (#24886)
* Removing the TestAllOnes, TestAllZeros, and TestMixOnesZeros methods from the Sse41 class

* Removing JIT support for the SSE41_TestAllOnes, SSE41_TestAllZeros, and SSE41_TestMixOnesZeros intrinsics

* Removing tests for the Sse41.TestAllOnes, Sse41.TestAllZeros, and Sse41.TestMixOnesZeros methods

Signed-off-by: dotnet-bot <[email protected]>
2019-06-04 09:20:29 +02:00
Rich Lander 697c1402ea Update license to match directory 2019-06-04 09:06:40 +02:00
Rich Lander f0ef7aa4df Update license to match directory 2019-06-04 09:06:40 +02:00
Johan Lorensson 0fa59f11ea Merge pull request #14766 from lateralusX/lateralusX/fix-win-32-createprocess-error
Change in process_complete_path exposed uninitialized variable error.
2019-06-04 08:49:02 +02:00
monojenkins deb0227a78 Bump roslyn to release 3.1.0 (#14778) 2019-06-03 22:41:42 +02:00
Alexander Köplinger 098de8b1ee [ci] Remove spaces in pipeline-netcore-runtime.yml
According to docs "names must contain only basic Latin alphabet letters (A-Z, a-z), numbers, and underscores (_)"
2019-06-03 19:56:37 +02:00
lateralusX 85bdaee7a5 Change in process_complete_path exposed uninitialized variable error.
https://github.com/mono/mono/commit/5d088cf0de7f3e50e3547dba361af4401e938dd4
exposed a problem with an uninitialized variable, only exposed on some
build configurations, 32-bit Windows release builds.
2019-06-03 16:04:32 +02:00
dotnet-maestro 369777b246 Update dependencies from https://github.com/dotnet/arcade build 20190602.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19302.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19302.2
2019-06-03 15:26:33 +02:00
monojenkins 283261cd1c [csproj] Update project files 2019-06-03 14:36:00 +02:00
Marek Safar eb99fdeb1a Update API 2019-06-03 14:36:00 +02:00
Marek Safar c84dc2ec55 [Mono.Profiler.Log] Add profiled data reader APIs 2019-06-03 14:36:00 +02:00
Katelyn Gadd 888c8b4621 Basic CI test coverage verifying that we can compile msbuild (#14242)
This adds a basic CI pass that attempts to compile the latest revision of msbuild and verifies that it produced an MSBuild.dll.
2019-06-03 12:03:36 +02:00
Rich Lander cab30bcecc Update TPN with Mono entry (#14744)
* Update TPN with Mono entry

* Update THIRD-PARTY-NOTICES.TXT

Add additional notice for Mono

* Update THIRD-PARTY-NOTICES.TXT

Update the Novell MIT-specific license

* Update THIRD-PARTY-NOTICES.TXT

Group various patterns of Mono license together
2019-06-03 09:05:18 +02:00
Jay Krell 018940f1bc Remove W32_UPDATE_LAST_ERROR_RESTORE_POINT that is not used and does not make sense to me, as to when it would be useful, having preserved LastError around many code paths through the years. 2019-06-03 09:04:16 +02:00
Jay Krell c5a628e86f Do not change Win32 lasterror in the first MONO_EXIT_GC_SAFE. 2019-06-03 09:04:16 +02:00
Aleksey Kliger a7578081e1 [sdks] Bump Android NDK, build tools and platform tools versions
Try to match Xamarin.Android master

Build tools and Platform tools: https://github.com/xamarin/xamarin-android/blob/f9f5b6cd120484b13df74e94638e07411d8693fa/Configuration.props#L100-L102

NDK: https://github.com/xamarin/xamarin-android/blob/f9f5b6cd120484b13df74e94638e07411d8693fa/build-tools/scripts/Ndk.targets#L4
2019-06-03 09:02:07 +02:00
Rich Lander 7c6efec792 Create THIRD-PARTY-NOTICES.TXT
TPN for https://github.com/mono/mono/new/master/mcs/class/System.Data/Test
2019-06-03 08:57:09 +02:00
Rich Lander 474f20c5ea Create THIRD-PARTY-NOTICES.TXT
TPN for https://github.com/mono/mono/tree/61559965a188d03456d6f7840a0cdabdf35c2400/mcs/tools/sqlsharp
2019-06-03 08:56:48 +02:00
Marek Safar 33136e3601 Merge pull request #14754 from Dotnet-GitSync-Bot/mirror-merge-10213317
Mirror changes from mono/coreclr
2019-06-03 08:47:04 +02:00
dotnet-maestro 0cab992234 Update dependencies from https://github.com/dotnet/arcade build 20190601.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19301.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19301.2
2019-06-03 08:45:59 +02:00
Dan Moseley 0e1b88b8ed Improve fatal err msg (dotnet/coreclr#24390)
* Improve fatal err msg

* Match SO format

* a

* Remove dead define

* More adjustments to ex msg

* And PAL

* Remove special case for SOE

* Remove excess Debug.Assert newline

* Remove excess newline

* typo

* New format

* Remove DebugProvider redundancy

* Adjustments

* Remove preceding newline

* Make other SOE and OOM consistent

* Tidy up assertion msg

* Fix missing newline after inner exception divider

* CR when no inner exception

* ToString never CR terminated

* disable corefx tests temporarily

Signed-off-by: dotnet-bot <[email protected]>
2019-06-02 13:57:10 +00:00
Rich Lander e27cda23e0 Update THIRD-PARTY-NOTICES.TXT
Add usage link
2019-06-01 20:41:40 +02:00
Rich Lander 015560df3d Create THIRD-PARTY-NOTICES.TXT
TPN for https://github.com/mono/mono/blob/0f9bb15622b649db81974057f66669674ea47923/mcs/class/I18N/tools/cvt.sh
2019-06-01 20:41:40 +02:00
Rich Lander 72dfea91df Update THIRD-PARTY-NOTICES.TXT
Add entry for https://github.com/mono/mono/blob/a34c9c79c07156797499b6ed2ce43c5897263b57/mono/benchmark/logic.cs
2019-06-01 20:40:57 +02:00
dotnet-maestro 860cb934ec Update dependencies from https://github.com/dotnet/arcade build 20190531.5
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19281.5
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19281.5
2019-06-01 20:40:09 +02:00
Zoltan Varga 7e0585fa35 [wasm] Add document with wasm feature requests. 2019-06-01 10:42:46 -05:00
Zoltan Varga b0d2edff27 [arm64] Set a llvm target layout. Assert in llvm if the target layout is not set, the defaults used by 'opt' are not correct. (#14714)
* [arm64] Set a llvm target layout. Assert in llvm if the target layout is not set, the defaults used by 'opt' are not correct.

* Add a llvm target layout for amd64.
2019-06-01 01:33:57 -04:00
Stephen Toub 7294bbc140 Fix FileStream.FlushAsync() to behave like Flush() (dotnet/coreclr#24902)
Flush() behaves like Flush(false) and writes out any buffered data but doesn't P/Invoke to FlushFileBuffers/FSync to flush the OS buffers.

But whereas FlushAsync() is supposed to just be an async equivalent of Flush(), it's actually behaving like Flush(true).  This makes FlushAsync() inconsistent and much more expensive.  (This is separate from FlushAsync not actually being async, which is an impactful problem to be solved separately.)

This changes FlushAsync to behave like Flush()/Flush(false) rather than Flush(true).  If someone wants the FlushFileBuffers/FSync behavior, they can call Flush(true).

Signed-off-by: dotnet-bot <[email protected]>
2019-06-01 07:11:46 +02:00
Alexis Christoforides 7300066faa [MacSDK] Properly handle PATHs with spaces during package post-install (#14735) 2019-05-31 20:49:10 -07:00
Kenneth Pouncey df402845f2 [wasm][bindings] Add support for marshaling DateTime and DateTimeOffset (#14722)
* Add support for marshalling DateTime and DateTimeOffset

* Add type checking to Runtime.GetDateValue

- Update to use clr ToUnixTimeMillisecons and FromUnixTimeMilliseonds to replace manual calculations.
- Moved magic numbers to managed side to address comments left by Katelyn and Jay.
2019-06-01 05:11:59 +02:00
Ryan Lucia 43aeac9e1e Propagate error in mono_file_map_error on posix (#14710) 2019-05-31 17:19:32 -04:00
Ryan Lucia 5d088cf0de [coop] Add GC safe transitions around blocking OS API calls (#14612)
If this was not possible due to them being called during runtime initialization, a short comment was left noting the specific reason why.

Fixes #14377

This includes a couple other random fixes I noticed on the way, most notably replacing SEE_MASK_FLAG_DDEWAIT with SEE_MASK_FLAG_NOASYNC as the former is deprecated.
2019-05-31 14:39:22 -04:00
Jo Shields 0f4ac3f13e Bump version to 6.5.0 (#14728) 2019-05-31 12:59:57 -04:00
Aleksey Kliger 8004791be8 [metadata] Mark mono_type_is_generic_parameter as a MONO_API
Used by the MONO_CLASS_IS_INTERFACE macro.

Fixes https://github.com/mono/mono/issues/14005
2019-05-31 12:07:58 +02:00
Vlad Brezae caa4a753ca [marshal] Fix race between delegate marshaling and finalization
When passing a delegate to native code, we pass the delegate_trampoline which can be used to invoke the delegate from native code and we store this mapping (delegate_trampoline->delegate) in a hashtable so we can get a delegate for the delegate_trampoline, when marshalling the opposite way. If we are trying to marshal a ftnptr (for managed code) to a delegate and we don't find this mapping we can crash. This could happen if the finalization for some other delegate that uses the same ftnptr removes this entry from the table. We solve this by never freeing these entries. The first delegate-ftnptr pair will always be alive. This is easier, faster and potentially uses less memory than tracking in the hashtable every pair. There should be a small and limited set of methods marshalled to native.

Fixes https://github.com/mono/mono/issues/13231
2019-05-31 12:05:37 +02:00
Katelyn Gadd 8d858b20c5 Add CI test coverage for compiler server (#14145)
* Add a warning to the gensources Makefile so it's not confusing when it fails to compile in non-build profiles

* Add CI test script that verifies the compiler server functions

* Fix bugs

* Add compiler server tag to jenkins script

* Add +x

* Rename compiler server test tag
2019-05-31 12:03:31 +02:00
Steve Pfister d607506055 Merge pull request #14325 from HebaruSan/fix/listviewgroup-forecolor
Fix light on light ListViewGroup headers on dark theme
2019-05-30 22:05:37 -04:00
Ryan Lucia c6eaeeed85 Batch of runtime warning fixes on Darwin (#14713) 2019-05-30 16:35:47 -04:00
Aleksey Kliger 615698f44e [monodroid] Exclude System.IO.Tests.File_Copy_str_str CoreFX testsuite
The test case CopyFileWithData_MemberData with input of size 1024 * 1024 * 10
causes the Xamarin.Android.Bcl_Tests to crash for some reason.  Temporarily
exclude this entire set of tests from running.

Also disable System.IO.Tests.FileInfo_CopyTo_str because it derives from the
above test class.
2019-05-30 19:33:32 +02:00
Stephen Toub eda4361b05 Handle nullable attributes on platforms that lack them
Signed-off-by: dotnet-bot <[email protected]>
2019-05-30 19:25:27 +02:00
Martin Baulig 19358243ed [corlib]: Move sre dependency into their own method in System.RuntimeType. (#14698)
* [corlib]: Move sre dependency into their own method in `System.RuntimeType`.

Move call to `TypeBuilderInstantiation.MakeGenericType` into a new
`System.RuntimeType.MakeTypeBuilderInstantiation` method to allow the
linker to remove it.

Requires linker PR https://github.com/mono/linker/pull/590.

* Bump linker.

* Bump cecil as well.

* Fix the build.

* Really fix the build.

* Bump API snapshot submodule

* [csproj] Update project files
2019-05-30 18:19:55 +02:00
dotnet-maestro b04d31702e Update dependencies from https://github.com/dotnet/arcade build 20190529.5
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19279.5
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19279.5
2019-05-30 18:02:38 +02:00
Jo Shields 4eda5f50eb [netcore] Fix duplicate publishing of metapackage (#14708) 2019-05-30 09:59:33 -04:00
Jay Krell e2d6361771 Remove JIT icall hashing by name and AOT JIT icall hashing. (#14644) 2019-05-30 12:39:55 +02:00
Jo Shields 2a5e8f0c37 [netcore] Add a metapackage for all supported runtimes 2019-05-30 09:21:05 +02:00
Jay Krell 815cb9da1a mono_mempool_alloc0: Don't give up the rest of the chunk (#14671)
when the allocation does not fit, i.e. when it is >= MONO_MEMPOOL_PREFER_INDIVIDUAL_ALLOCATION_SIZE.

Or at least make the code clearer and smaller.

"fixes" https://github.com/mono/mono/issues/14669.
2019-05-29 19:11:46 -04:00
Blightbuster 778fd0e2d3 Fix spelling in wasm sample docs (#14570) 2019-05-30 00:26:12 +02:00
dotnet-maestro a6bb97472c Update dependencies from https://github.com/dotnet/arcade build 20190528.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19278.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19278.1
2019-05-29 23:11:29 +02:00
Marek Safar 30a2eeb982 [System.Private.CoreLib] Reflect shared partition changes 2019-05-29 22:14:22 +02:00
Jan Kotas e920807341 Fix superfluous delegate allocations in Unix WaitSubsystem (#7454)
Fixes #7452

Signed-off-by: dotnet-bot <[email protected]>
2019-05-29 22:14:22 +02:00
Stephen Toub ae89c386b4 Change StreamReader.ReadBufferAsync to return ValueTask<int> (#24810)
It's a private helper that's always directly awaited.  No need to allocate a task each time it's called and data is synchronously available.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-29 22:14:22 +02:00
Vladimir Sadov 76dee58018 Using AllocateUninitializedArray in array pool (dotnet/coreclr#24504)
* Just use `new T[]` when elements are not pointer-free

* reduce zeroing out when not necessary.

* use AllocateUninitializedArray in ArrayPool

Signed-off-by: dotnet-bot <[email protected]>
2019-05-29 22:14:22 +02:00
Marek Safar 3285e0519e Move parts of WeakReference to shared partition (dotnet/coreclr#24800)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-29 22:14:22 +02:00
Jan Kotas 41522e6fdb Cleanup unnecessary code in exception formatting (dotnet/coreclr#24797)
* Cleanup unnecessary code in exception formatting

* Delete fNeedFileInfo argument for GetStackTrace

Fixes #8694

Signed-off-by: dotnet-bot <[email protected]>
2019-05-29 22:14:22 +02:00
Rich Lander 83a9d92110 Update THIRD-PARTY-NOTICES.TXT 2019-05-29 18:47:07 +02:00
Rich Lander d97a62a14e Create THIRD-PARTY-NOTICES.TXT
TPN for https://github.com/mono/mono/blob/7a1a832f6577ffb12d4d302d2868a5b1aaa5ec65/packaging/MacSDK/packaging/resources/postinstall#L96
2019-05-29 18:47:07 +02:00
Aleksey Kliger (λgeek) addc474eb0 [ci] Add Android Windows (Release) archive job to the pipeline (#14699) 2019-05-29 17:52:42 +02:00
Alexander Köplinger f46191114b [bcl] Add nunit exclude categories for monotouch/monodroid profiles (#14695)
We didn't set all the categories that the products used in our profiles.

Now that the products can consume the exclude categories from mono we
need to unify the values.

Removed ValueAdd since it's not used anymore and combined MacNotWorking
into NotOnMac.
2019-05-29 16:58:55 +02:00
Alexander Köplinger 4fcbbd8fb7 [System] Fix MultiCastOptionTest on WatchOS
With https://github.com/mono/mono/commit/cf69b4725976e51416bfdff22f3e1834006af00a it started doing DNS lookups for localhost and we don't have sockets on the watch.
2019-05-29 16:44:58 +02:00
lateralusX 0a6b13f83a Fix LLVM build break on Windows MSVC.
https://github.com/mono/mono/pull/14607 broke LLVM build on Windows MSVC.
This is just a quick fix falling back to old behavior on Windows MSVC. Since
all LLVM tools will be available in the same folder as mono runtime binary
there is no specific need to point out other build folders hosting LLVM tooling.
2019-05-29 12:09:59 +02:00
Egor Bogatov 472465d6ba bump roslyn 2019-05-29 10:25:18 +02:00
Rich Lander ea3e3dd114 Update THIRD-PARTY-NOTICES.TXT 2019-05-29 10:20:21 +02:00
Rich Lander 51d58cf80c Create THIRD-PARTY-NOTICES.TXT
TPN for https://github.com/mono/mono/blob/23e6f6f4b58d72800f4e27fa29a6b58806ff475f/mono/mini/bench.cs#L65
2019-05-29 10:20:21 +02:00
Rich Lander 1cea554b69 Update THIRD-PARTY-NOTICES.TXT 2019-05-29 10:20:01 +02:00
Rich Lander 1b038ee743 Create THIRD-PARTY-NOTICES.TXT
TPN for https://github.com/mono/mono/tree/master/mcs/class/I18N/CJK/Test
2019-05-29 10:20:01 +02:00
Rich Lander 9cfe096cac Create THIRD-PARTY-NOTICES.TXT
TPN for https://github.com/mono/mono/blob/29ee4e15806848ff5131c4bdd23ded786f5bc186/mono/benchmark/zipmark.cs
2019-05-29 10:19:41 +02:00
Marek Safar 088cbe3b04 [System.Private.CoreLib] Remove unused members and further cleanups 2019-05-29 09:44:58 +02:00
Marek Safar c03cc8361f [System.Private.CoreLib] Reflect shared partition changes 2019-05-29 09:43:57 +02:00
Marco Rossignoli 3d7a409154 Expose Path.TrimEndingDirectorySeparator (dotnet/coreclr#20805)
* expose TrimEndingDirectorySeparator

* address PR feedback

* updates

* address PR feedback

* fix comment

Signed-off-by: dotnet-bot <[email protected]>
2019-05-29 09:43:57 +02:00
Egor Bogatov 9a11bd94a3 Move some CustomAttribute related types to shared (dotnet/coreclr#23651)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-29 09:43:57 +02:00
Vlad Brezae 04f4db7b87 [interp] Make --interp= not override last set execution mode (#14683)
It makes sense to pass --interp (--interp=-inline) while having another execution mode previously set up (like --full-aot-interp).

Cleanup code a little bit by killing mono_enable_interp which doesn't do much.
2019-05-29 10:02:23 +03:00
Katelyn Gadd add2a211b3 Infrastructure support / fixes for making compiler server the default (#14279)
* Fix enabling the compiler server using autogen, and force it off if mcs is being used

* autogen updates

* Formatting fixes

* Fix vbcs getting turned on if unspecified even if mcs was selected

* Dynamically evaluate ENABLE_COMPILER_SERVER each time we compile instead of evaluating it once at some arbitrary point during makefile evaluation

* More detailed comment based on testing

* Handle the /shared option in genproj so it doesn't fail

* Raise basic profile check requirement to 6.2 and hopefully assert that named pipes work

* Default compiler server to off for now.
2019-05-28 23:54:44 -07:00
Alexander Köplinger edd6c013b0 [sdks] Only package android-sources on macOS
rsync might not be installed on other platforms and we only need android-sources in one sdks archive.
2019-05-29 00:30:22 +02:00
Alexander Köplinger a2f66ddca1 [sdks] Don't package android-sources on Windows
We don't need it there.
2019-05-28 19:50:00 +02:00
Alexander Köplinger 4b1e9da414 [sdks] Add linker sources to android sdks archive (#14686)
(cherry picked from commit c96878fb16)
2019-05-28 18:57:46 +02:00
Alexander Köplinger 07c58ee2ed [bcl] Write newline-separated nunit/xunit excludes file for sdks archive (#14681)
During XI integration we noticed that just using the verbatim commandline
-exclude or -notrait is not ideal since XI uses the nunit/xunit APIs to
pass that information and not the command line parser.

Instead we now write the exclude categories/traits as a newline-separated file.
2019-05-28 18:49:26 +02:00
Stephen Toub a67c6a2b52 Add and apply nullable attributes (dotnet/coreclr#24679)
* Add and apply nullable attributes

* Adapt to API review decisions

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-05-28 18:14:19 +02:00
Vlad Brezae 5cbe938847 [interp] Share more wrappers for different interp in signatures (#14596)
[interp] Share more wrappers for different interp in signatures

The passed arguments are already considered to be gpointer in interp_entry and the real value is obtained using stackval_from_data. For types that are passed by value in a register the wrappers will be identical and we can share them.

This commit reduces the size used by interp_in wrappers (in fullaot-interp) by half. These wrappers still take a fair amount of size, which comes mainly from signatures including value types, which aren't shared.
2019-05-28 11:46:49 -04:00
Alexander Köplinger 20fcb62cbc Bump corefx to fix monodroid profile build on Windows 2019-05-28 15:35:17 +02:00
Aleksey Kliger (λgeek) 83f17b4cf9 [sdks] Build static binaries for Android SDK and LLVM with MXE (#14283)
We used to use the static MXE toolchain, but after switching to Homebrew, we
have to explicitly pass flags to build binaries that don't depend on the
MinGW32 GCC support libraries (libstdc++-6.dll, libwinpthread-1.dll and others)
when building the LLVM and Mono binaries.

The simplest approach is just to pass CMAKE_EXE_LINKER_FLAGS=-static to cmake
and LDFLAGS=-all-static to libtool.  The rest of the changes are just to make
it easier to do that by adding a configure flag and updating the SDKs
infrastructure.

We will also need an LLVM bump to actually build a new llvm archive with the
new build flags; until then, building Mono will provision an old build of LLVM
with the old build flags that still depends on libstdc++-6.dll.

---

An alternative approach instead of passing -all-static and -static would be to
probe for the assorted -static-libXYZ flags to GCC at configure time.  (For the
LLVM build we would need to hardcode them as that build doesn't go through
autoconf).  Right now Mono doesn't have any other DLL dependencies (other than
the core windows DLLs), so -all-static works just as well and is simpler.
2019-05-28 08:56:51 -04:00
Sebastien Pouliot 9fb44af2fe [mscorlib] Ensure monotouch[_runtime] API are identical (#14665)
* [mscorlib] Ensure monotouch[_runtime] API are identical

Ensure the API surface for `mscorlib.Core.dll` is identical between the
`monotouch` and `monotouch_runtime` (used for REPL and the interpreter).

This ensure code compiled against one will be fine when building against
the other (e.g. avoiding linker errors).

In practice this means:

1. Expose the API needed for `System.Reflection.Emit` in XI

	- throwing `PlatformNotSupportedException` **by default**; or
	- calling the mono runtime when the interpreter is enabled;

2. Do not expose additional, not supported, API (e.g. COM related)

	- `monotouch_runtime` configuration was built without `FULL_AOT_RUNTIME`
	  and that brings some other stuff that is not AOT related

Follow up to #14606

Existing diff

Removed methods:

```csharp
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access);
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, System.Collections.Generic.IEnumerable<Reflection.Emit.CustomAttributeBuilder> assemblyAttributes);

[Obsolete ("Declarative security for assembly level is no longer enforced")]
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, Security.Policy.Evidence evidence);
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir);
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, System.Collections.Generic.IEnumerable<Reflection.Emit.CustomAttributeBuilder> assemblyAttributes, Security.SecurityContextSource securityContextSource);

[Obsolete ("Declarative security for assembly level is no longer enforced")]
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.Policy.Evidence evidence);

[Obsolete ("Declarative security for assembly level is no longer enforced")]
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions);
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, bool isSynchronized, System.Collections.Generic.IEnumerable<Reflection.Emit.CustomAttributeBuilder> assemblyAttributes);

[Obsolete ("Declarative security for assembly level is no longer enforced")]
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, Security.Policy.Evidence evidence, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions);

[Obsolete ("Declarative security for assembly level is no longer enforced")]
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions);

[Obsolete ("Declarative security for assembly level is no longer enforced")]
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.Policy.Evidence evidence, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions);

[Obsolete ("Declarative security for assembly level is no longer enforced")]
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.Policy.Evidence evidence, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions, bool isSynchronized);

[Obsolete ("Declarative security for assembly level is no longer enforced")]
public Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.Policy.Evidence evidence, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions, bool isSynchronized, System.Collections.Generic.IEnumerable<Reflection.Emit.CustomAttributeBuilder> assemblyAttributes);
```

Removed methods:

```csharp
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access);
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, Security.Policy.Evidence evidence);
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir);
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.Policy.Evidence evidence);
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions);
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, Security.Policy.Evidence evidence, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions);
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions);
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.Policy.Evidence evidence, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions);
public virtual Reflection.Emit.AssemblyBuilder DefineDynamicAssembly (Reflection.AssemblyName name, Reflection.Emit.AssemblyBuilderAccess access, string dir, Security.Policy.Evidence evidence, Security.PermissionSet requiredPermissions, Security.PermissionSet optionalPermissions, Security.PermissionSet refusedPermissions, bool isSynchronized);
```

Added constructor:

```csharp
public AssemblyBuilder ();
```

Removed properties:

```csharp
public override string CodeBase { get; }
public override System.Reflection.MethodInfo EntryPoint { get; }
public override string EscapedCodeBase { get; }
public override System.Security.Policy.Evidence Evidence { get; }
public override string FullName { get; }
public override bool GlobalAssemblyCache { get; }
public override string ImageRuntimeVersion { get; }
public override bool IsDynamic { get; }
public override string Location { get; }
public override System.Reflection.Module ManifestModule { get; }
public override bool ReflectionOnly { get; }
```

Removed methods:

```csharp
public void AddResourceFile (string name, string fileName);
public void AddResourceFile (string name, string fileName, System.Reflection.ResourceAttributes attribute);
public ModuleBuilder DefineDynamicModule (string name, bool emitSymbolInfo);
public ModuleBuilder DefineDynamicModule (string name, string fileName);
public ModuleBuilder DefineDynamicModule (string name, string fileName, bool emitSymbolInfo);
public System.Resources.IResourceWriter DefineResource (string name, string description, string fileName);
public System.Resources.IResourceWriter DefineResource (string name, string description, string fileName, System.Reflection.ResourceAttributes attribute);
public void DefineUnmanagedResource (byte[] resource);
public void DefineUnmanagedResource (string resourceFileName);
public void DefineVersionInfoResource ();
public void DefineVersionInfoResource (string product, string productVersion, string company, string copyright, string trademark);
public override bool Equals (object obj);
public override object[] GetCustomAttributes (bool inherit);
public override object[] GetCustomAttributes (System.Type attributeType, bool inherit);
public override System.Type[] GetExportedTypes ();
public override System.IO.FileStream GetFile (string name);
public override System.IO.FileStream[] GetFiles (bool getResourceModules);
public override int GetHashCode ();
public override System.Reflection.Module[] GetLoadedModules (bool getResourceModules);
public override System.Reflection.ManifestResourceInfo GetManifestResourceInfo (string resourceName);
public override string[] GetManifestResourceNames ();
public override System.IO.Stream GetManifestResourceStream (string name);
public override System.IO.Stream GetManifestResourceStream (System.Type type, string name);
public override System.Reflection.Module GetModule (string name);
public override System.Reflection.Module[] GetModules (bool getResourceModules);
public override System.Reflection.AssemblyName GetName (bool copiedName);
public override System.Reflection.AssemblyName[] GetReferencedAssemblies ();
public override System.Reflection.Assembly GetSatelliteAssembly (System.Globalization.CultureInfo culture);
public override System.Reflection.Assembly GetSatelliteAssembly (System.Globalization.CultureInfo culture, System.Version version);
public override System.Type GetType (string name, bool throwOnError, bool ignoreCase);
public override bool IsDefined (System.Type attributeType, bool inherit);
public void Save (string assemblyFileName);
public void Save (string assemblyFileName, System.Reflection.PortableExecutableKinds portableExecutableKind, System.Reflection.ImageFileMachine imageFileMachine);
public void SetEntryPoint (System.Reflection.MethodInfo entryMethod, PEFileKinds fileKind);
public override string ToString ();
```

Added constructor:

```csharp
public ConstructorBuilder ();
```

Removed properties:

```csharp
public override System.Reflection.CallingConventions CallingConvention { get; }
public override System.Reflection.Module Module { get; }

[Obsolete]
public System.Type ReturnType { get; }
```

Removed methods:

```csharp
public void AddDeclarativeSecurity (System.Security.Permissions.SecurityAction action, System.Security.PermissionSet pset);
public void SetSymCustomAttribute (string name, byte[] data);
public override string ToString ();
```

Removed property:

```csharp
public override System.Reflection.Module Module { get; }
```

Added property:

```csharp
public override System.Reflection.MethodImplAttributes MethodImplementationFlags { get; }
```

Removed methods:

```csharp
public override System.Delegate CreateDelegate (System.Type delegateType);
public override System.Delegate CreateDelegate (System.Type delegateType, object target);
public override string ToString ();
```

Added properties:

```csharp
public override bool IsByRefLike { get; }
public override bool IsSZArray { get; }
public override bool IsVariableBoundArray { get; }
```

Removed method:

```csharp
public override bool IsAssignableFrom (System.Reflection.TypeInfo typeInfo);
```

Added constructor:

```csharp
public EventBuilder ();
```

Removed properties:

```csharp
public override int MetadataToken { get; }
public override System.Reflection.Module Module { get; }
```

Removed method:

```csharp
[Obsolete ("An alternate API is available: Emit the MarshalAs custom attribute instead.")]
public void SetMarshal (UnmanagedMarshal unmanagedMarshal);
```

Added properties:

```csharp
public override bool IsByRefLike { get; }
public override bool IsConstructedGenericType { get; }
public override bool IsSZArray { get; }
public override bool IsTypeDefinition { get; }
public override bool IsVariableBoundArray { get; }
```

Removed methods:

```csharp
public override System.Type[] GetGenericParameterConstraints ();
public override bool IsAssignableFrom (System.Reflection.TypeInfo typeInfo);
public override bool IsInstanceOfType (object o);
```

Modified properties:

```diff
-public virtual int ILOffset { get; }
+public int ILOffset { get; }
```

Removed method:

```csharp
public virtual void MarkSequencePoint (System.Diagnostics.SymbolStore.ISymbolDocumentWriter document, int startLine, int startColumn, int endLine, int endColumn);
```

Added property:

```csharp
public override bool IsConstructedGenericMethod { get; }
```

Removed methods:

```csharp
public void AddDeclarativeSecurity (System.Security.Permissions.SecurityAction action, System.Security.PermissionSet pset);

[Obsolete ("An alternate API is available: Emit the MarshalAs custom attribute instead.")]
public void SetMarshal (UnmanagedMarshal unmanagedMarshal);
public void SetSymCustomAttribute (string name, byte[] data);
```

Removed properties:

```csharp
public override int MetadataToken { get; }
public override System.Guid ModuleVersionId { get; }
public override string ScopeName { get; }
```

Removed methods:

```csharp
public System.Diagnostics.SymbolStore.ISymbolDocumentWriter DefineDocument (string url, System.Guid language, System.Guid languageVendor, System.Guid documentType);
public void DefineManifestResource (string name, System.IO.Stream stream, System.Reflection.ResourceAttributes attribute);
public System.Resources.IResourceWriter DefineResource (string name, string description);
public System.Resources.IResourceWriter DefineResource (string name, string description, System.Reflection.ResourceAttributes attribute);
public void DefineUnmanagedResource (byte[] resource);
public void DefineUnmanagedResource (string resourceFileName);
public override object[] GetCustomAttributes (bool inherit);
public override object[] GetCustomAttributes (System.Type attributeType, bool inherit);
public override System.Reflection.FieldInfo GetField (string name, System.Reflection.BindingFlags bindingAttr);
public override System.Reflection.FieldInfo[] GetFields (System.Reflection.BindingFlags bindingFlags);
protected override System.Reflection.MethodInfo GetMethodImpl (string name, System.Reflection.BindingFlags bindingAttr, System.Reflection.Binder binder, System.Reflection.CallingConventions callConvention, System.Type[] types, System.Reflection.ParameterModifier[] modifiers);
public override System.Reflection.MethodInfo[] GetMethods (System.Reflection.BindingFlags bindingFlags);
public System.Diagnostics.SymbolStore.ISymbolWriter GetSymWriter ();
public override System.Type GetType (string className);
public override System.Type GetType (string className, bool ignoreCase);
public override System.Type GetType (string className, bool throwOnError, bool ignoreCase);
public override System.Type[] GetTypes ();
public override bool IsDefined (System.Type attributeType, bool inherit);
public override bool IsResource ();
public override System.Reflection.FieldInfo ResolveField (int metadataToken, System.Type[] genericTypeArguments, System.Type[] genericMethodArguments);
public override System.Reflection.MemberInfo ResolveMember (int metadataToken, System.Type[] genericTypeArguments, System.Type[] genericMethodArguments);
public override System.Reflection.MethodBase ResolveMethod (int metadataToken, System.Type[] genericTypeArguments, System.Type[] genericMethodArguments);
public override byte[] ResolveSignature (int metadataToken);
public override string ResolveString (int metadataToken);
public override System.Type ResolveType (int metadataToken, System.Type[] genericTypeArguments, System.Type[] genericMethodArguments);
public void SetSymCustomAttribute (string name, byte[] data);
```

Modified properties:

```diff
-public virtual int Attributes { get; }
+public int Attributes { get; }
-public virtual string Name { get; }
+public string Name { get; }
-public virtual int Position { get; }
+public int Position { get; }
```

Removed method:

```csharp
[Obsolete ("An alternate API is available: Emit the MarshalAs custom attribute instead.")]
public virtual void SetMarshal (UnmanagedMarshal unmanagedMarshal);
```

Removed interface:

```csharp
System.Runtime.InteropServices._SignatureHelper
```

Removed methods:

```csharp
public override bool Equals (object obj);
public override int GetHashCode ();
public override string ToString ();
```

Removed property:

```csharp
public override bool ContainsGenericParameters { get; }
```

Added properties:

```csharp
public override bool IsByRefLike { get; }
public override bool IsSZArray { get; }
public override bool IsSecurityCritical { get; }
public override bool IsSecuritySafeCritical { get; }
public override bool IsSecurityTransparent { get; }
public override bool IsVariableBoundArray { get; }
```

Removed methods:

```csharp
public void AddDeclarativeSecurity (System.Security.Permissions.SecurityAction action, System.Security.PermissionSet pset);
public override bool IsAssignableFrom (System.Reflection.TypeInfo typeInfo);
protected override bool IsValueTypeImpl ();
```

Removed methods:

```csharp
public static object GetActiveObject (string progID);
public static IntPtr GetComInterfaceForObjectInContext (object o, System.Type t);
public static int GetComSlotForMethodInfo (System.Reflection.MemberInfo m);
public static int GetEndComSlot (System.Type t);
public static IntPtr GetExceptionPointers ();
public static IntPtr GetIDispatchForObjectInContext (object o);
public static IntPtr GetITypeInfoForType (System.Type t);
public static IntPtr GetIUnknownForObjectInContext (object o);

[Obsolete ("This method has been deprecated")]
public static IntPtr GetManagedThunkForUnmanagedMethodPtr (IntPtr pfnMethodToWrap, IntPtr pbSignature, int cbSignature);
public static System.Reflection.MemberInfo GetMethodInfoForComSlot (System.Type t, int slot, ref ComMemberType memberType);

[Obsolete ("This method has been deprecated")]
public static System.Threading.Thread GetThreadFromFiberCookie (int cookie);
public static System.Type GetTypeForITypeInfo (IntPtr piTypeInfo);

[Obsolete]
public static string GetTypeInfoName (UCOMITypeInfo pTI);
public static System.Guid GetTypeLibGuid (ComTypes.ITypeLib typelib);

[Obsolete]
public static System.Guid GetTypeLibGuid (UCOMITypeLib pTLB);
public static System.Guid GetTypeLibGuidForAssembly (System.Reflection.Assembly asm);
public static int GetTypeLibLcid (ComTypes.ITypeLib typelib);

[Obsolete]
public static int GetTypeLibLcid (UCOMITypeLib pTLB);
public static string GetTypeLibName (ComTypes.ITypeLib typelib);

[Obsolete]
public static string GetTypeLibName (UCOMITypeLib pTLB);
public static void GetTypeLibVersionForAssembly (System.Reflection.Assembly inputAssembly, out int majorVersion, out int minorVersion);

[Obsolete ("This method has been deprecated")]
public static IntPtr GetUnmanagedThunkForManagedMethodPtr (IntPtr pfnMethodToWrap, IntPtr pbSignature, int cbSignature);
public static bool IsTypeVisibleFromCom (System.Type t);
public static int NumParamBytes (System.Reflection.MethodInfo m);

[Obsolete]
public static void ReleaseThreadCache ();
```

* [csproj] Update project files

* Bump API snapshot submodule
2019-05-28 14:39:38 +02:00
Kenneth Pouncey ad03563fb4 [wasm][ci] Enable ChakraCore tests (#14653)
- Chakra 1.11.9 release is now out which fixes https://github.com/microsoft/ChakraCore/issues/6037

Closes https://github.com/mono/mono/issues/13195
2019-05-28 10:29:29 +02:00
Dan Moseley da3e52793a Call derived ToString on inner exceptions (dotnet/coreclr#24793)
* Remove special Appx path and METHOD__EXCEPTION__TO_STRING

* Remove Exception.ToString(bool, bool)

* Remove Exception.InternalToString and callers

* Cache message

Signed-off-by: dotnet-bot <[email protected]>
2019-05-28 09:18:17 +02:00
Alexander Köplinger 7ca8e89ce7 [sdks] Explicitly set version of the mac/ios/watchos/tvos platform SDKs (#14663)
Otherwise the Xcode linker tries to guess the version from the path,
and since we use Xcode101.app it'd use sdk=101 as the version which is wrong.

By explicitly specifying e.g. `$(XCODE_DIR)/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS12.1.sdk`
as the sysroot it correctly guesses sdk=12.1 instead.

See also https://github.com/xamarin/xamarin-macios/commit/834c0a9fd7062c0c25011721fd7d524b8a60b41e
2019-05-28 01:38:38 +02:00
Johan Lorensson 8d0ad4c816 Reduce stack size used by interpreter frame on Windows MSVC. (#14659)
Reduce stack size used by interpreter frame on Windows MSVC.

Interpreter frame was 1248 bytes in size under Windows MSVC. This was almost double the size of other platforms ~670 bytes. After investigating different constructs in interpreter switch statement in interp_exec_method_full, it turns out that local declared errors couldn't be reused over different case statements and added ~100 bytes each. Switching local declared errors to shared one, reduce the stack size down to ~670 bytes under Windows MSVC.
2019-05-27 17:55:52 -04:00
Jay Krell 07c5ecdf7b Introduce g_static_assert. (#14651)
ifdef __cplusplus
define g_static_assert(x) static_assert (x, "")
else
define g_static_assert(x) g_assert (x)
endif

It is, granted, C++11, not C++98, and some C variations.
2019-05-27 15:33:46 -04:00
Jay Krell 15eb9f7ba1 warning: 'emit_load' defined but not used [-Wunused-function] (#14646)
Rename emit_load_general to emit_load
2019-05-27 20:18:57 +02:00
Calvin Buckley 19e0a80ad1 Bump CoreFX and make necessary changes (#14660)
I myself am bumping for ODBC fixes. This includes a change to SslProtocols to include the Tls13 entry required by the CoreFX changes. (It doesn't wire it up to anything, including BTLS.)

* Fix CollectionTest.UnusableSyncLockTest test

The test checked whether the SyncRoot is of type object, but the corefx implementation switched to returning `this`.

* Bump API snapshot submodule
2019-05-27 19:30:19 +02:00
Marek Safar 00c43ce6e8 [System.Private.CoreLib] Resolve APIs mismatches 2019-05-27 17:32:26 +02:00
Johan Lorensson 164c257bb9 Merge pull request #14628 from lateralusX/lateralusX/interpreter-windows-x64-mini-regression-support
Fix interpreter mini regression test on Windows x64.
2019-05-27 17:00:06 +02:00
Stephen Toub 0eb9e611d2 Stop nulling out lock object in SemaphoreSlim (dotnet/coreclr#24776)
SemaphoreSlim.Dispose nulls out its lock object, and that's then used as an indication in other methods whether they should throw ObjectDisposedException.  But nulling out an object used for synchronization in other methods is a bad practice, and while SemaphoreSlim.Dispose is not thread-safe to be used concurrently with other usage of the instance, it's still confusing when such usage leads to NullReferenceExceptions due to trying to lock on a null lock object.  This change just changes the lock to be readonly, always set, and then whether the instance has been disposed is just a value set on that object (such that it's no larger than it used to be).

Signed-off-by: dotnet-bot <[email protected]>
2019-05-27 16:44:48 +02:00
Jan Kotas 278e11d840 Fix nulable annotations build break (dotnet/coreclr#24768)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-27 16:44:48 +02:00
Santiago Fernandez Madero 6ce793487c Fix nullable annotation in String.Join
Signed-off-by: dotnet-bot <[email protected]>
2019-05-27 16:44:48 +02:00
Santiago Fernandez Madero 3837ea0c64 Fix Guid.TryParse nullabel annotation
Signed-off-by: dotnet-bot <[email protected]>
2019-05-27 16:44:48 +02:00
Santiago Fernandez Madero d4eb0c4a9f Fix nullable annotation in Array.SetValue
Signed-off-by: dotnet-bot <[email protected]>
2019-05-27 16:44:48 +02:00
Marek Safar 0f4dd6bc49 Bump roslyn dependency 2019-05-27 15:55:54 +02:00
dotnet-maestro-bot 538ecf31ef Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, respectively (master) (#24369)
* Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, respectively

* Use `Nullable=enable` rather than `NullableContextOptions=enable`

* Resolving new nullability warnings

* PR Feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-05-27 15:55:54 +02:00
Alexander Köplinger 1d4dab41a9 Add missing new files to Makefile.am, fix tarball build (#14656)
They were added in https://github.com/mono/mono/pull/14427
2019-05-27 15:21:26 +02:00
Rich Lander 5f87cb724f Create THIRD-PARTY-NOTICES.TXT
TPN for language files @ https://github.com/mono/mono/new/4fd4f46ca31141774d8dcd3b72d2171d32a49f67/mcs/class/I18N/West/Test
2019-05-27 09:31:14 +02:00
Alexander Köplinger 989ea49239 [System] Fix monotouch_runtime repl assemblies
They were missing some exclude files that caused unnecessary p/invokes to be retained.

Fixes https://github.com/mono/mono/issues/13526
2019-05-27 09:28:00 +02:00
lateralusX 1fc0ed9664 Review feedback. 2019-05-27 09:26:25 +02:00
Conrad Meyer e2a21cbac3 [System.Net.NetworkInformation] Fork FreeBSD from MacOs (#14619)
* [System.Net.NetworkInformation] Fork FreeBSD from MacOs

They are related, but not identical.  In particular, MacOS AF_INET6 is wrong
on FreeBSD and breaks IPv6 networking on FreeBSD.  Establish an inheritence
relationship with overrides for now; it's possible more differences will be
needed in the future.

This change is released under the MIT license.

* [csproj] Update project files
2019-05-27 09:21:07 +02:00
dotnet-maestro a12749adb6 Update dependencies from https://github.com/dotnet/arcade build 20190524.6
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19274.6
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19274.6
2019-05-27 09:18:18 +02:00
dotnet-maestro 3f7f652c76 Update dependencies from https://github.com/dotnet/arcade build 20190523.11
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19273.11
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19273.11
2019-05-27 09:18:18 +02:00
Jay Krell 393d7ef616 Widen MonoJumpInfo union to pointer-sized so mono_add_patch_info can just use target field blindly. (#14642)
just use target field blindly.
2019-05-26 18:30:18 +02:00
Jay Krell 489c40a548 Remove MONO_PATCH_INFO_METHOD_REL. (#14643)
It is not used, and it had a larger than pointer field
where a pointer was required, at least for 32bit hosted cross builds.
2019-05-25 10:30:53 -04:00
Zoltan Varga 7c837f58bc [jit] Also allow System.Runtime.CompilerServices.Unsafe intrinsics from the System.Runtime.CompilerServices assembly, not just corlib. (#14618)
* [jit] Also allow System.Runtime.CompilerServices.Unsafe intrinsics from the System.Runtime.CompilerServices assembly, not just corlib.

* [jit] Fix Unsafe.RefIsAddressLessThan()/RefIsAddressGreaterThan().
2019-05-25 10:30:04 -04:00
Alexander Kyte 9cb89c9ea9 [build] Provide in-tree llvm to mono correctly (#14607) 2019-05-25 01:10:21 -07:00
Ryan Lucia 96b1fd837d [coop] Transition various public APIs into an external/internal form to avoid unnecessary GC-unsafe calls (#14427)
Relevant issue: #14376

There are potentially more functions this can apply to, but this covers the ones listed in the issue and an extra one I found in the process.

Functions were either broken off into an external-only and internal version, or such a pair already existed and the internal version was moved from the source file to a separate `-internals` header, similarly to in 3c74df5667.

This gets slightly complicated with `mono_domain_set` and `mono_domain_set_internal`, both of which are currently public (thanks to 4beada2892) and have different signatures. Additionally, the latter does not actually include the gc-unsafe transition despite being public. 
I've opted to introduce `mono_domain_set_fast` as the 'internal' version of `mono_domain_set`, to add the proper gc-unsafe transition to `mono_domain_set_internal`, and then to migrate internal usage to `mono_domain_set_internal_with_options`. As part of that I've marked `mono_domain_set_internal` as external only, which is unfortunate naming-wise but I believe the best option here without introducing API breakage.
2019-05-24 19:09:00 -04:00
Alexander Kyte ea4ff9ba80 [llvm] Use CoreCLR GC interop configuration (#14598)
[llvm] Use CoreCLR GC interop configuration

Since they're identical right now, we can use the coreclr configuration
to make our IR more easily analyzed by tools built around LLVM.

```
class CoreCLRGC : public GCStrategy {
public:
  CoreCLRGC() {
    UseStatepoints = true;
    // These options are all gc.root specific, we specify them so that the
    // gc.root lowering code doesn't run.
    InitRoots = false;
    NeededSafePoints = 0;
    UsesMetadata = false;
    CustomRoots = false;
  }

  Optional<bool> isGCManagedPointer(const Type *Ty) const override {
    // Method is only valid on pointer typed values.
    const PointerType *PT = cast<PointerType>(Ty);
    // We pick addrspace(1) as our GC managed heap.
    return (1 == PT->getAddressSpace());
  }
};

/// A GCStrategy for the Mono Runtime.
class MonoGC : public GCStrategy {
public:
  MonoGC() {
    UseStatepoints = true;
    // These options are all gc.root specific, we specify them so that the
    // gc.root lowering code doesn't run.
    InitRoots = false;
    NeededSafePoints = 0;
    UsesMetadata = false;
    CustomRoots = false;
  }
};
```

Source: https://github.com/mono/llvm/blob/64c0343537016c153894dc60316bd7b316b812c8/lib/CodeGen/BuiltinGCs.cpp#L105-L137
2019-05-24 16:55:50 -04:00
Jay Krell f93d42dbf5 Cleanup: load_function_full -- avoid a string alloc/copy and cast. (#14625)
Cleanup: load_function_full -- avoid a string alloc/copy and cast.
2019-05-24 16:36:00 -04:00
Ryan Lucia 76c45bc2cb Fix build warning for orig_method (#14603)
Variable is only used here: https://github.com/mono/mono/blob/82a993124888d470d1057eae9546e5be76524dad/mono/mini/mini-trampolines.c#L743
2019-05-24 21:34:23 +02:00
Zoltan Varga 3ff4282abe [llvm] Remove JIT support for older llvm versions. (#14605) 2019-05-24 14:56:01 -04:00
musikhin b1c3216f89 Fix SqliteMembershipProvider initialization bug, issue #14234 (#14479)
On the stage of the initialization of the SqliteMembershipProvider the existed code always produced an error "Failed to map path '/'" in case if the ASP.NET application is placed not at the root path. Detailed step by step description of the problem is provided in the issue description.

The bug was that was implemented the call of the function with wrong parameters list. So the fix was in changing the function call. The same function call is also used in SqlMembershipProvider.cs.

Fixes #14234
2019-05-24 20:44:08 +02:00
Aleksey Kliger (λgeek) 94adfce735 [merp] Don't leak g_getenv return value (#14602)
[merp] Don't leak g_getenv return value

Coverity said:
```
     CID 1445100:  Resource leaks  (RESOURCE_LEAK)
     Failing to save or free storage allocated by "monoeg_g_getenv("MONO_CRASH_NOFILE")" leaks it.
```
2019-05-24 13:55:53 -04:00
Vlad Brezae 3d331568e1 [interp] Fix warning with coverity (#14613)
[interp] Fix warning with coverity
2019-05-24 13:36:10 -04:00
Alexander Kyte fb2233b337 [merp] Add assertions against initing dumper from signal handler (#13851) 2019-05-24 12:17:38 -04:00
lateralusX a895be83f6 Fix interpreter mini regression test on Windows x64.
First set of fixes to get the following tests working under interpreter
on Windows x64:

* mono/mini richeck
* mono/mini mixedcheck
* mono/mini fullaotmixedcheck
* mono/tests winx64structs.exe

Fixes are primarily related to Windows x64 ABI support in interpreter. Fixes
also makes sure our interpreter trampolines get unwind info making it possible
to debug through the trampolines on Windows x64.

Several fixes related to value types was needed, also fixed support for return
value types not fitting into registers, current implementation didn't return
passed in value type address in return register as mandated by both
System V and Win x64 ABI's.

Identified and fixed memory leak on every pinvoke from interpreter that needs stack.
Since Windows x64 ABI always use 32 bytes of stack allocated by caller, the
memory leak was hit on every pinvoke call.
2019-05-24 15:53:02 +02:00
Alexander Köplinger 82a9931248 [sdks] Fix min OSX version of runtime files in Mac SDK (#14615)
It was using an unescaped makefile variable in the template, i.e. ended up empty which meant the build just took the host version as the min version.

Fixed the variable and also moved it to CFLAGS/CXXFLAGS instead of CPPFLAGS to be consistent with ios.mk
2019-05-24 14:10:47 +02:00
Lee Culver ef9d54d151 Throw ObjectDisposedException instead of crashing when Cairo.Context handle == IntPtr.Zero (#14323)
* Throw ObjectDisposedException instead of crashing when Cairo.Context.handle == IntPtr.Zero

We are seeing instances where VS for Mac is crashing with a SIGSEGV when
calling into certain Cairo.Context functions.  Looking at the code, it's clear
that it's possible to have Context.handle == IntPtr.Zero after disposing the
object.

From research, it looks like passing a nullptr to raw cairo functions can
result in a SIGSEGV:
    https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/93807

This change adds check to see if Conext.handle == IntPtr.Zero in Context
painting, font, and path methods.  This will turn uncatchable SIGSEGVs
into ObjectDisposedException.

* Update Context.cs

* Ensure SetTarget results in a valid handle
2019-05-24 12:22:51 +02:00
Rich Lander 8f6a7b34ee Create THIRD-PARTY-NOTICES.TXT
TPN for https://github.com/mono/mono/blob/435f968102d0820ca65d63e1e741e4130b4d1303/support/ios/net/route.h
2019-05-24 12:08:47 +02:00
Jay Krell 0c7ed830ac [loaded LLVM] Add several missing MONO_LLVM_INTERNAL (#14589)
* [llvm] Remove unused default_mono_llvm_unhandled_exception.
It references mono_gchandle_get_target_internal which is not marked MONO_LLVM_INTERNAL
so attempts to run it will fail.

This is caught by linking wit -z now (https://github.com/mono/mono/pull/14562).

* [loaded LLVM] mono_debug_get_seq_points and mono_class_enum_basetype_internak MONO_LLVM_INTERNAL

* Mark mono_debug_method_lookup_location MONO_LLVM_INTERNAL.
Found by linking with -z now (https://github.com/mono/mono/pull/14562)
which we should probably do for this and other reasons.

* #include mono-compiler.h for MONO_LLVM_INTERNAL.

* [loaded LLVM] Mark mini_is_gsharedvt_variable_signature as MONO_LLVM_INTERNAL.
Found by https://github.com/mono/mono/pull/14562.

* Mark mono_print_ins MONO_LLVM_INTERNAL.

* mono_rgctx_info_type_to_str MONO_LLVM_INTERNAL

* [loaded LLVM] mono_compile_create_var MONO_LLVM_INTERNAL

* ifdef around use of MONO_LLVM_INTERNAL and hope

* remove include mono-compiler.h from public header to internal header

* MONO_API_NO_EXTERN_C mono_debug_method_lookup_location() instead of mono_debug_method_lookup_location() MONO_LLVM_INTERNAL to workaround possible lack of MONO_LLVM_INTERNAL.
2019-05-24 02:58:26 -07:00
Jay Krell 0d22880940 Make function pointers readonly. (#14470) 2019-05-24 02:58:03 -07:00
Santiago Fernandez Madero e1d628c18d Make AppDomain.GetThreadPrincipal() internal (dotnet/coreclr#24747)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-24 10:00:05 +02:00
Jan Kotas f670f46497 Delete FEATURE_TESTHOOK (dotnet/coreclr#24746)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-24 10:00:05 +02:00
David Wrighton 30fb72969e Fewer ilstubs in corelib from reflection apis (dotnet/coreclr#24708)
Rework use of marshalling for RuntimeTypeHandle, RuntimeModule, RuntimeAssembly, and IRuntimeMethodInfo as used by QCalls
- Remove special QCall only used marshallers for RuntimeAssembly, RuntimeModule and IRuntimeMethodInfo
- Following the pattern of ObjectHandleOnStack, implement QCall handle types for RuntimeAssembly/Module/TypeHandle. Use these in all QCalls that once passed the types directly.
- For uses of IRuntimeMethodInfo, follow the existing RuntimeMethodHandleInternal pattern

Also perform some replacement of bool marshalling with use of Interop.BOOL, and a few cases of using pointers instead of byref arguments.

Fix delivers a relatively small win on startup, and small throughput gains around reflection as IL stubs are no longer necessary for many functions in reflection that once needed them.

Reduces methods jitted on powershell startup from 422 to 399, (About 5%) but performance win is only about 5ms on ~400ms as the methods removed are simple.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-24 10:00:05 +02:00
Jan Kotas 50fac54741 Fix CoreRT build breaks
Signed-off-by: dotnet-bot <[email protected]>
2019-05-24 08:33:58 +02:00
Sebastien Pouliot 9ca1619d63 [System.Core] Ensure monotouch[_runtime] API are identical (#14606)
* [System.Core] Ensure monotouch[_runtime] API are identical

Ensure the API surface for `System.Core.dll` is identical between the
`monotouch` and `monotouch_runtime` (used for REPL and the interpreter).

This ensure code compiled against one will be fine when building against
the other (e.g. avoiding linker errors).

Removed methods:

```csharp
public void CompileToMethod (System.Reflection.Emit.MethodBuilder method);
public void CompileToMethod (System.Reflection.Emit.MethodBuilder method, System.Runtime.CompilerServices.DebugInfoGenerator debugInfoGenerator);
```

Removed methods:

```csharp
[Obsolete ("do not use this method")]
public static IRuntimeVariables MergeRuntimeVariables (IRuntimeVariables first, IRuntimeVariables second, int[] indexes);

[Obsolete ("do not use this method")]
public static System.Linq.Expressions.Expression Quote (System.Linq.Expressions.Expression expression, object hoistedLocals, object[] locals);
```

* [csproj] Update project files

* Bump API snapshot submodule
2019-05-24 01:44:24 +02:00
Alexander Köplinger f5f3c6aabe [tests] Add xunit.execution.dotnet.dll to tests directory (#14595)
So it gets included in the sdks archive
2019-05-23 20:17:41 +02:00
Bernhard Urban b564c26cb5 [interp] set correct stack type on op_Implicit/op_Explicit intrinsics for native types (#14575)
[interp] set correct stack type on op_Implicit/op_Explicit intrinsics for native types

Needs some additional conversions which happen to be included by accident previously.

This fixes those warnings on amd64:
```
Test run:
image=/Users/lewurm/work/mono-dim-call/mono/mini/builtin-types.exe
BuiltinTests.test_0_nuint_fieldload: Store local stack type mismatch 0 1
BuiltinTests.test_0_much_casting: Store local stack type mismatch 0 1
Results: total tests: 84, all pass
Elapsed time: 0.026546 secs (0.026546, 0.000000)
```

and those warnings on armv7:
```
Test run: image=/mono/mono/mini/builtin-types.exe
BuiltinTests.test_0_nint_inc: 0011 arith type mismatch add.i4 0 1
BuiltinTests.test_0_nint_dec: 0011 arith type mismatch sub.i4 0 1
BuiltinTests.test_0_nint_implicit_decimal: 0034 arith type mismatch
add.i4 0 1
BuiltinTests.test_0_nuint_inc: 0011 arith type mismatch add.i4 0 1
BuiltinTests.test_0_nuint_dec: 0011 arith type mismatch sub.i4 0 1
BuiltinTests.test_0_nuint_implicit_decimal: 0034 arith type mismatch
add.i4 0 1
Results: total tests: 84, all pass
Elapsed time: 0.039214 secs (0.039214, 0.000000)
```
2019-05-23 12:56:16 -04:00
monojenkins 72eb2ee84a [Android] Fix runtime loading of DSOs for 64-bit processes (#14577)
[Android] Fix runtime loading of DSOs for 64-bit processes

Context: https://github.com/xamarin/xamarin-android/issues/2780

On Android the executable for the application is going to be
`/system/bin/app_process{32,64}` depending on the application's architecture.
However, libraries for the different architectures live in different
subdirectories of `/system`: `lib` for 32-bit apps and `lib64` for 64-bit ones.
Thus appending `/lib` below will fail to load the DSO for a 64-bit app, even if
it exists there, because it will have a different architecture. The quickest fix
is to use `lib64` explicitly for 64-bit Android apps.



<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->


Backport of #13281.

/cc @lambdageek @grendello
2019-05-23 10:56:37 -04:00
Bernhard Urban fa3b4812d7 [netcore] add some intrinsics for interpreter (#14547)
[netcore] add some intrinsics for interpreter

```console
$ MONO_ENV_OPTIONS='--interp' make -C netcore xtest-System.Runtime.Tests
Microsoft.DotNet.XUnitConsoleRunner v2.5.0 (64-bit .NET Core 3.0.0-preview5-27620-01)
  Discovering: System.Runtime.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Runtime.Tests (found 5266 of 5402 test cases)
  Starting:    System.Runtime.Tests (parallel test collections = on, max threads = 16)
[...]
  Finished:    System.Runtime.Tests
=== TEST EXECUTION SUMMARY ===
   System.Runtime.Tests  Total: 32485, Errors: 0, Failed: 23, Skipped: 2, Time: 126.432s
```
See failures here: https://gist.github.com/lewurm/c8372b0c7ba6a78cf8b7b7b8c7090820
2019-05-23 10:00:49 -04:00
dotnet-maestro 75de80a482 Update dependencies from https://github.com/dotnet/arcade build 20190522.13
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19272.13
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19272.13
2019-05-23 15:56:23 +02:00
Alexander Köplinger 9606a8f180 [bcl] Remove usages of mono-project.com/go-mono.com/google.com in tests (#14586)
Use example.com and example.org instead.

Fixes https://github.com/mono/mono/issues/14585

Note that not all of the things I replaced make an actual network request but I thought it'd be nice to be consistent.
2019-05-23 14:12:14 +02:00
Johan Lorensson d96fa3ab31 Merge pull request #14549 from lateralusX/lateralusX/add-coop-config-windows
Add ability to use cooperative suspend in configure step.
2019-05-23 09:21:43 +02:00
Jay Krell 8804dbac27 Fix decoding of WRAPPER_SUBTYPE_ICALL_WRAPPER and WRAPPER_SUBTYPE_INTERP_LMF. (#14546) 2019-05-23 01:43:19 -04:00
Jay Krell 37d6df9d67 Fix warning: (#14529)
aot-compiler.c: In function 'arch_init':
aot-compiler.c:1092:11: warning: unused variable 'has_custom_args' [-Wunused-variable]
  gboolean has_custom_args = !!acfg->aot_opts.llvm_llc;
2019-05-23 01:43:05 -04:00
Stephen Toub e1021fc68b Fix Path.Join argument nullable annotation (dotnet/coreclr#24719)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-23 07:18:33 +02:00
Marek Safar eb936495b3 Commit 29810a78e5b93d8da9fb921d096226d249fc75a5 added unconditional dependency on GetCpuUtilization (#24715)
Update projitems file inclusion

Signed-off-by: dotnet-bot <[email protected]>
2019-05-23 07:18:33 +02:00
Marius UngureanuandMartin Baulig fe74f62140 Plug leak of CustomAttribute initializer name (#14544)
* Plug leak of CustomAttribute initializer name

All the CustomAttribute initializer names (fields, property) except the last were leaked. Ensure all names are freed.

Fixes #14543

* Apply suggestions from code review

Co-Authored-By: Martin Baulig <[email protected]>
2019-05-22 22:59:20 -04:00
Larry Ewing 84bc4bfb8b Merge pull request #14552 from lewurm/interp-dimcall-fix
[interp] add missing enum check on constrained callvirt
2019-05-22 20:30:01 -05:00
Jay Krell ee1868e82f Close two race conditions. (#14510) 2019-05-23 01:47:29 +02:00
Alexander Köplinger 2c76de1ee1 [tests] Add Xunit.NetCore.Extensions.dll to tests directory (#14571)
So it gets included in the sdks archive
2019-05-22 19:48:07 +02:00
Bernhard Urban 574d87ca9f [driver] add --version=number (#14538)
* [driver] add --version-number

Useful for third parties consuming the version number of mono.

* s/--version-number/--version=number/g

* add man page entry
2019-05-22 18:49:38 +02:00
Marek Safar e2cc6fc40d [System.Private.CoreLib] Workaround for broken shared project file exclusion 2019-05-22 16:17:50 +02:00
dotnet-maestro 3ba95bba6a Update dependencies from https://github.com/dotnet/arcade build 20190521.7
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19271.7
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19271.7
2019-05-22 16:02:29 +02:00
Jay Krell 5334e32de9 More information to PowerPC assertion failure. (#14569) 2019-05-22 14:27:40 +02:00
Jay Krell d583190ce7 Add more information to a stackless faulting community line. (#14566) 2019-05-22 13:17:53 +02:00
Jay Krell 74faf39971 [PowerPC] Fix compile error. (#14564) 2019-05-22 13:15:27 +02:00
Marek Safar 6751700b20 [System.Private.Corelib] More nullable types tweaks 2019-05-22 12:47:11 +02:00
Egor Bogatov 64fe6a054c [netcore] Add Microsoft.Private.CoreFx.OOB package to corefx-restore.csproj (#14559)
* Add Microsoft.Private.CoreFx.OOB package

* Add GC.GetTotalAllocatedBytes stub

* Add missing icalls

* Add more tests to ignore

* Update GC.cs

* Add more tests to ignore

* Update Monitor.cs
2019-05-22 12:32:05 +02:00
Egor Bogatov 36193f5378 [netcore] Set System.Private.Corlib AssemblyVersion to 4.0.0.0 (#14556)
* clean up

* cleanup

* bump assembly version
2019-05-22 09:37:17 +02:00
Stephen Toub f5c8b3f7e9 Implement AppDomain.Monitoring*MemorySize (dotnet/coreclr#24610)
* Implement AppDomain.MonitoringTotalAllocatedMemorySize

* Change precise:true back to precise:false in GetTotalAllocatedBytes

Signed-off-by: dotnet-bot <[email protected]>
2019-05-22 09:33:36 +02:00
Mike Marynowski fdc9a1e7cc Modified format logic so that braces are not allowed in custom format specifiers (#23062)
* Modified format logic so that braces are not allowed in custom format specifiers.

* Disabled failing test temporarily and fixed code style issue.

PR needed to pass test: https://github.com/dotnet/corefx/pull/35820

* Slight changes to logic to better align the diff.

* Fixed counting error.

* Fix nullable

* Move exclusion near related test

* Add skip to new issue file

* Delete CoreFX.issues.json

Signed-off-by: dotnet-bot <[email protected]>
2019-05-22 09:33:36 +02:00
Egor Bogatov 7f03824327 [netcore] Fix PointerTests (#14557)
* Fix PointerTests

* Update CoreFX.issues.rsp
2019-05-22 08:24:40 +02:00
Stephen Toub 8ef0c136eb Reduce overhead of SemaphoreSlim.WaitAsync (dotnet/coreclr#24687)
This affects the case where SemaphoreSlim.WaitAsync is invoked, the operation completes asynchronously because there's no count available in the semaphore, and where a timeout and/or a cancellation token is passed to WaitAsync.  In that case, we need to wait for the underlying wait task to complete, for cancellation to be requested, or for the timeout to elapse.

There's currently one code path that handles this.  This change improves that slightly by avoiding a defensive array copy.  However, we can do much better when we get a cancelable token but no timeout, in which case we can avoid operations like Task.Delay, can register with the original cancellation token rather than a new one (which means we avoid forcing a new CancellationTokenSource's lazily-allocated partitions into existence), etc.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-22 08:23:06 +02:00
monojenkins 80963d3a8b [bcl] Update BCL Linked Size 2019-05-22 08:17:59 +02:00
Zoltan Varga e9fbb4210c [jit] Fix signed/unsigned comparisons in JitHelpers.EnumCompareTo () intrinsic. (#14553)
Fixes https://github.com/mono/mono/issues/14551.
2019-05-21 20:17:50 -04:00
Jay Krell f0cf94a5d1 MONO_PATCH_INFO_JIT_ICALL cleanup (#14545)
The most important point of the "temporary" aspect, esp. given
the complete conversion, is renaming MONO_PATCH_INFO_JIT_ICALL to MONO_PATCH_INFO_JIT_ICALL_ID.
Any accidental or merged MONO_PATCH_INFO_JIT_ICALL will fail to compile.
2019-05-21 17:04:02 -04:00
Alexander Kyte eaaf77189d [crash] Don't waitpid() if fork() fails (#14539) 2019-05-21 16:20:30 -04:00
Alexander Kyte 8c4c9a06cd [crash] Handle OOM/blocked allocation during crash dumper (#14540)
* [crash] Remove typo from crash sub-header

* [crash] Use error path that returns nonzero status
2019-05-21 16:20:15 -04:00
Tarek Mahmoud Sayed 107ff9732d Enhance the Missing Resources Exception Message (dotnet/coreclr#24645)
* Enhance the Missing Resources Exception Message

* Address the feedback

* Fix Nullable declaration

Signed-off-by: dotnet-bot <[email protected]>
2019-05-21 18:22:05 +02:00
dotnet-maestro c02c4a8b53 Update dependencies from https://github.com/dotnet/arcade build 20190520.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19270.2
2019-05-21 17:08:48 +02:00
Bernhard Urban 539e3f8546 [interp] add missing enum check on constrained callvirt
This detail got lost when the code was duplicated here: https://github.com/mono/mono/pull/13154/files#diff-f115ce23fba6528256a47e2b7e8b0a19R1611

Fixes `mono/tests/dim-constrainedcall.il` on the interpreter. This PR will enable it: https://github.com/mono/mono/pull/14166
2019-05-21 16:31:11 +02:00
Jay Krell c1d01670d3 Initial icall-def.h / icall-def-netcore.h split. (#14489)
* Copy icall-def.h to icall-def-core.h.

* Manually preprocess icall-def.h vs. icall-def-core.h.
The only common part in this construction is the JIT icalls at the end.
There much overlap, now duplicated.

* Remove JIT icalls fro icall-def-core.h.

* Merge icall-def-core.h with master.

* Merge icall-def.h with master.

* Rename icall-def-core.h to icall-def-netcore.h.

* Remove more unused icalls
2019-05-21 14:50:09 +02:00
Andrew Arnott 13992b7f50 Avoid boxing in TextWriter.Write(StringBuilder) (dotnet/coreclr#24664)
Fixes #24663 by calling `Write(ReadOnlySpan<char>)` instead of `Write(object)` with a boxed `Memory<char>`.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-21 14:47:36 +02:00
Santiago Fernandez Madero 0d1ed39f45 Add IsVariableBoundArray to TypeDelegator (dotnet/coreclr#24637)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-21 14:47:36 +02:00
Tanner Gooding ad9de49bdb Fixing the Dragon4 algorithm to correctly handle when the first significant digit is after the cutoff (#24484)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-21 14:47:36 +02:00
Tarek Mahmoud Sayed 6986880de5 Ensure using single Utc object in TimeZoneInfo (dotnet/coreclr#24614)
Currently if calling GetSystemTimeZones, will return a list which in include Utc object created from the enumeration.  But when calling FindSystemTimeZoneById("UTC") will return the cached Utc object which is different than the one returned from the enumeration. This in general could be not a problem but it is better to ensure returned the same object from both APIs. The reason is in our internal code, we use some reference equality for the perf reason. Ensure the usage of Utc object will make it more reliable.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-21 14:47:36 +02:00
Anirudh Agnihotry 07de377517 Correcting documentation for span and memory slice (dotnet/coreclr#24612)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-21 14:47:36 +02:00
Levi Broderick 335c1206e9 Fix parameter names in ToUtf16 (dotnet/coreclr#24617)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-21 14:47:36 +02:00
lateralusX 70b26c9bc3 Add ability to use cooperative suspend in configure step.
Needed in order to setup CI lanes using --enable-cooperative-suspend.
2019-05-21 13:48:29 +02:00
Tarek Mahmoud Sayed 14de5cabbe Fix Handling time patterns with quotes (dotnet/coreclr#24589)
We encountered some cultures have a time patterns with single quotes which we should handle keeping the parts between quotes as fixed text inside the pattern and not treat it as any of the time specifiers

Signed-off-by: dotnet-bot <[email protected]>
2019-05-21 13:47:07 +02:00
monojenkins 98880bd6a5 [csproj] Update project files 2019-05-21 12:33:55 +02:00
Martin Baulig 1eb9161ca6 Removing some remoting and multi-appdomain APIs on wasm and the AOT test profiles.
Build / profile changes:
------------------------

* `build/profiles/testing_aot_common.make`: define `DISABLE_REMOTING = yes` and
  `NO_MULTIPLE_APPDOMAINS = yes`.

* `mcs/class/corlib/Makefile`: check `DISABLE_REMOTING` when setting
  `REFERENCE_SOURCES_FLAGS` (and don't define `FEATURE_REMOTING`, `MONO_COM`
   and `FEATURE_COMINTEROP`).

* added new `testing_aot_common_corlib.dll.exclude.sources`.  Several types in
  the `System.Runtime.Remoting.Messaging` namespace are used by the runtime in
  non-remoting scenarios, so those need to be preserved.
  For all other remoting namespaces, we only need a few stripped down stub versions
  of the some of the types; those have been added to a new `legacy` directory, so
  we can wildcard-exclude all the files here.

* added new `testing_aot_common_corlib.dll.sources`; this currently only contains
  `legacy/*.cs` to list above mentioned stub versions.

* added new `testing_aot_common_corlib_test.dll.exclude.sources` as a common test
  excludes file.

API Changes (conditional to `DISABLE_REMOTING`):
------------------------------------------------

* `mcs/class/corlib/legacy/`: add stub-versions for some of the remoting-related
  classes that are used by the runtime (so we can't completely remove those types):

  - `System.MarshalByRefObject`.
  - `System.Runtime.Remoting.IRemotingTypeInfo`.
  - `System.Runtime.Remoting.ObjectHandle`.
  - `System.Runtime.Remoting.RemotingServices`.
  - `System.Runtime.Remoting.Activation.ActivationServices`.
  - `System.Runtime.Remoting.Contexts.Context`.
  - `System.Runtime.Remoting.Messaging.ILogicalThreadAffinative`.
  - `System.Runtime.Remoting.Messaging.LogicalCallContext`.
  - `System.Runtime.Remoting.Proxies.TransparentProxy`.
  - `System.Runtime.Remoting.Proxies.RealProxy`.

  some of these have fields that need to be preserved; these are marked with
  appropriate `#region` pragmas.

All changes below are conditional to `DISABLE_REMOTING`.

* `System.Runtime.Remoting.Messaging.AsyncResult`: this class is used by some of
  the async code, so we can't completely remove it.  However, we can remove the
  `MonoMethodMessage call_message` field when `DISABLE_REMOTING`.

* `System.Runtime.Remoting.Messaging.MonoMethodMessage`: this class is also used
  by some runtime code and thus needs to be preserved. However, when `DISABLE_REMOTING`
  is defined, then we make some changes to it:
  - remove all iterfaces (`IMethodCallMessage`, `IMethodReturnMessage`, and `IInternalMessage`).
  - `Properties` throws `PlatformNotSupportedException`.

* `System.Runtime.InteropServices.Marshal`: disable some COM-related code.

* `System.Threading.Thread`: remove `CurrentContext` property.

* `System.Threading.ExecutionContext`: adjust conditional logic; don't define
  `FEATURE_REMOTING` if `DISABLE_REMOTING`.

* `System.Activator`: add `DISABLE_REMOTING` to the existing
   `#if FEATURE_REMOTING || MOBILE_LEGACY` conditional in this class.

* `System.AppDomain`: since we only have one domain, `DefaultDomain` will always
   return the root domain; comment out the call to `RemotingServices.GetDomainProxy`
   as well as some internal methods.

* `System.__ComObject`: stub out on `DISABLE_REMOTING` as well as `!FULL_AOT_RUNTIME`.

* `System.Runtime.Serialization.Formatters.Binary.BinaryFormatter`: adjust `IFormatter`
  versus `IRemotingFormatter` interface logic to use the former when `DISABLE_REMOTING`.

* `System.Runtime.Serialization.Formatters.Binary.BinaryObjectReader`: adjust existing
  `#if FEATURE_REMOTING || MOBILE_LEGACY` conditional to add `DISABLE_REMOTING` to it.

* `System.Diagnostics.CorrelationManager`: comment out some `CallContext.LogicalGetData()`
  and `CallContext.LogicalSetData`.

* `System.Diagnostics.TraceEventCache`: likewise.

Test changes:
-------------

* `mono/tests/Makefile.am`: conditionally disable some remoting tests.

* `corlib/Test/System.Runtime.Serialization/SerializationTest.cs`: conditionally
   disable all tests requiring remoting.

* `corlib/Test/System/ActivatorTest.cs`: same; trying to preserve as much as possible
  in this test.

* added some `DISABLE_REMOTING` and `DISABLE_SECURITY` conditionals to some of the tests.
2019-05-21 12:33:55 +02:00
Alexander Köplinger aee4cdd248 Bump gtk-sharp in bockbuild (#14537)
Brings in https://github.com/mono/gtk-sharp/pull/273.
2019-05-21 11:35:40 +02:00
Jay Krell c03814f8dc Replace string/hash-based MONO_PATCH_INFO_JIT_ICALL with enum-based MONO_PATCH_INFO_JIT_ICALL_ID. (#14512)
* Replace string/hash-based MONO_PATCH_INFO_JIT_ICALL with enum-based MONO_PATCH_INFO_JIT_ICALL_ID.

* Reconvert mono-llvm.c after merge with master.
2019-05-21 00:16:36 -04:00
Marius Ungureanu 57a3b24f75 Fix leak in mono_parse_options (#14533)
Fix leak in mono_parse_options

When MONO_ENV_OPTIONS is null, we would leak the array and buffer



<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-05-20 18:25:55 -04:00
dotnet-maestro 52171b21a4 Update dependencies from https://github.com/dotnet/arcade build 20190520.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19270.1
2019-05-20 16:37:31 +02:00
dotnet-maestro 9e8717d885 Update dependencies from https://github.com/dotnet/arcade build 20190518.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19268.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19268.2
2019-05-20 16:37:31 +02:00
Zoltan Varga ccb505b6ec [llvm] Fix patching of calls from LLVM JITted code. (#14520)
* [runtime] Fix mono_icall_get_wrapper_full () to always compile the wrapper even if a trampoline was created previously.

* [jit] Add a mini_patch_llvm_jit_callees () function to patch callsite variables for LLVM JIT.

* [llvm] Patch LLVM JIT callees in trampolines as well. Patching after a method is compiled is not enough, since new callsites can be created after a method has been compiled.

* [llvm] Cleanup calls from JITted code. Compile referenced jit icall wrappers immediately, since the calls will not be patched.

* Add a missing MONO_LLVM_INTERNAL.
2019-05-20 10:22:26 -04:00
Bernhard Urban c2118341c6 [arm] one more attempt to fix slotsize issue on llvmonly (#14444)
* [arm] one more attempt to fix slotsize issue on llvmonly

Regression of https://github.com/mono/mono/pull/12992 & https://github.com/mono/mono/pull/14362

In the end, the actual fix boils down to:
```patch
--- a/mono/mini/mini-arm.c
+++ b/mono/mini/mini-arm.c
@@ -2374,7 +2374,7 @@ mono_arch_get_llvm_call_info (MonoCompile *cfg, MonoMethodSignature *sig)
                                lainfo->nslots = ALIGN_TO (ainfo->struct_size, 8) / 8;
                                lainfo->esize = 8;
                        } else {
-                               lainfo->nslots = ainfo->struct_size / sizeof (target_mgreg_t);
+                               lainfo->nslots = ALIGN_TO (ainfo->struct_size, sizeof (target_mgreg_t)) / sizeof (target_mgreg_t);
                                lainfo->esize = 4;
                        }
                        break;
```

Tested on `xamarin-macios/arm64_32-v3` branch:
* mscorlib
* mini
* dont link
* monotouch tests
* and a modified version of https://github.com/mono/mono/issues/8486#issuecomment-414365860 (added larger structs too)

with each device, Watch Series 3 (`armv7k`) and Watch Series 4 (`arm64_32`).

I hope that is the last iteration on this.

* remove arm64_32_abi
2019-05-20 03:09:35 -07:00
Jay Krell 1ecffe9554 Work toward JIT icall hash removal. (#14508)
i.e. when CEE_MONO_JIT_ICALL_ADDR takes enum instead of func.
2019-05-19 14:15:07 -07:00
dotnet-maestro d667baf94b Update dependencies from https://github.com/dotnet/arcade build 20190517.7
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19267.7
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19267.7
2019-05-18 22:18:21 -07:00
Egor Bogatov 616e06225a [netcore] Merge all *.rsp files into CoreFX.issues.rsp (#14513)
* merge rsp files into CoreFX.issues.rsp

* Update CoreFX.issues.rsp

* Update CoreFX.issues.rsp

* clean up

* Update CoreFX.issues.rsp

* download OS specific tests

* Update Makefile

* Add comments for build-local-corefx-test-% rule
2019-05-18 22:15:31 -07:00
Egor Bogatov bd7ec72362 [netcore] Fix Math.ILogB corner cases (#14500)
* Fix ILogb corner cases

* remove redundant tabs

* Add RSP for S.R.Extensions

* remove autotools magic

* add more comments
2019-05-18 20:59:38 -07:00
Egor Bogatov 29938ada1f [netcore] Respect attributes defined on parameters in Delegates (#14468)
* Respect attributes defined on Delegates

* remove 'var's

* Unwrap System.Reflection.Tests.PointerTests.*
2019-05-18 20:58:20 -07:00
Jay Krell 7601045796 Make mono_jit_icall_info MONO_LLVM_INTERNAL. (#14525) 2019-05-18 20:38:46 -07:00
Jay Krell 24c0f17b1c Add missing dependency on $(srcdir)/genmdesc.py. (#14515) 2019-05-18 14:18:46 -07:00
Larry Ewing 73baf1b291 Merge pull request #14490 from vargaz/bump-emsdk
[wasm] Bump emscripten to 1.38.31.
2019-05-18 13:31:55 -07:00
Bernhard Urban 45a1c98df8 [interp] disable inlining for built-in types (#14501)
[interp] disable inlining for built-in types

Fixes https://github.com/mono/mono/issues/14246
2019-05-18 14:45:57 -04:00
Jay Krell 3142f7d54d Reduce JIT icall hash use. (#14507)
* Reduce JIT icall hash use.

* PR: Rename mono_jit_icall_info_at to mono_find_jit_icall_info.

* Use enum instead of int, and update comment to reality (the assert is arguably leniently off by one.)

* Cast integer to enum for C++.

* More int vs. enum, and use two variables, and const.

* Undo a little fishing for CI failure.
2019-05-18 07:05:57 -07:00
Larry Ewing 63b16ae32f Merge pull request #14488 from jeromelaban/dev/jela/wasm-dlopen
[Wasm] Expand support for dynamic linking
2019-05-17 13:11:31 -07:00
Zoltan Varga 1972a3a95d [wasm] Emit more precise signatures for icalls. (#14494)
[wasm] Emit more precise signatures for icalls.
2019-05-17 13:46:01 -04:00
Johan Lorensson 42bc7daeb8 Merge pull request #14498 from lateralusX/lateralusX/fix-llvm-build-error
Fix Windows Mono LLVM build error on nightly master build.
2019-05-17 09:26:37 -07:00
Jo Shields 6a81662247 [netcore] Fixes for Arcade on private mirror (#14509)
* [netcore] Use bash explicitly for Arcade things

* [netcore] Work around https://github.com/dotnet/cli/issues/10014

* [netcore] Try forcing powershell Arcade on Windows
2019-05-16 22:31:23 -07:00
Zoltan Varga ab90b1f15b [wasm] Avoid sharing C icall functions between icalls, in wasm to avoid calling them with incorrect signatures. (#14493) 2019-05-17 00:53:55 -04:00
Alexander Köplinger 24275c9717 Add missing DARC files 2019-05-16 17:50:36 -07:00
Jo Shields 2b35b6bab4 [netcore] Build/upload Windows runtime nupkg (#14506)
* [netcore] Switch build properties from /p: to -p: due to MSYS2/dotnet bug

* [netcore] Switch from nuget pack to dotnet pack

* [netcore] Add Windows x64 build
2019-05-16 17:36:31 -07:00
Alexander Köplinger 871e6f5846 Manual DARC update from build '20190516.4' 2019-05-16 17:03:15 -07:00
Alexander Köplinger 6d404e4ede [netcore] Update dotnet feed url 2019-05-16 16:05:47 -07:00
Jérôme Laban 527abcd115 Update the driver to support MONO_TYPE_I
Add tests to validate boxing/unboxing
2019-05-16 13:54:12 -04:00
Alexis Christoforides 7082845114 [monodroid] Introduce 'win32 host' BCL build (#14424)
* [monodroid] Introduce 'win32 host' BCL build

* [sdks] Add _bcl_$(1)_BUILD_FLAGS variable to BclTemplate build step

Allows Android SDK on Windows to pass PROFILE_PLATFORM=win32

* [sdks] Pass _bcl_$(1)_BUILD_FLAGS when building the tests, too

* Copy test source exclusion files from the general monodroid profile

Apparently we don't fall back to the general exclusion sources for tests if the platorm-specific exclusion file does not exist.

* Also add win32 copies of the nunit exclude files:

files=$(find . -name "monodroid*_test*exclude.sources")
for file in $files
do
    name=$(basename $file)
    pushd $(dirname $file)
    cp $name win32_$name
    git add win32_$name
    popd
done

* [csproj] Update project files
2019-05-16 09:23:13 -07:00
Jérôme Laban 230f593eb6 Add missing extra exported method to allow Module.addFunction 2019-05-16 10:49:43 -04:00
Jay Krell da6cb6c685 Work towards removing JIT icall hashing. (#14474)
* Work towards removing JIT icall hashing.

* PR: Use enums instead of pointers.

* Fix int/enum mismatch.
2019-05-16 10:12:34 -04:00
Levi Broderick 88944be25c Make Label and OpCode readonly and IEquatable (dotnet/coreclr#24360)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-16 00:20:25 -07:00
lateralusX 142d1a9ca0 Fix Windows Mono LLVM build error on nightly master build. 2019-05-16 02:47:57 +02:00
Zoltan Varga 6a38d99535 [wasm] Bump emscripten to 1.38.31. 2019-05-15 16:46:05 -07:00
Filip Navara ad698c9878 [netcore] Exclude some unused icalls (#14475)
* [netcore] Exclude unused native locale icalls

* Fix builds with mono_feature_disable_sockets, currently not enabled by configure script

* [netcore] Don't compile in System.IO icall in netcore profile
2019-05-15 18:29:01 -04:00
Jérôme Laban 7a1e382925 Adjust spaces 2019-05-15 15:49:09 -04:00
Jérôme Laban 52557848ba Force import all libraries in dynamic mode, addFunction support 2019-05-15 15:03:37 -04:00
Jérôme Laban a1db6e83ed [Wasm] Add binding support for IntPtr 2019-05-15 15:03:37 -04:00
Jay Krell ebd0cdad5e Make genmdesc output better typed and more readable. (#14477)
* Make genmdesc output better typed and more readable -- almost hand-maintainable
but no clear route to actually hand-maintainable.

* Replace != with < and undo debug code.
2019-05-15 13:16:25 -04:00
Jérôme Laban 4d023b6bf8 [Wasm] Force libstdcxx to be included in the main module in release-dynamic 2019-05-14 22:28:34 -04:00
Jay Krell 495a93305b Add two asserts to mono_emit_jit_icall. (#14459) 2019-05-13 23:22:26 -07:00
Tanner Gooding f34d562641 Fixing S.P.Corelib to not double include files and ensure that S.N.V is marked #nullable enable (#24526)
* Changing EnableDefaultCompileItems=false to EnableDefaultItems=false

* Taking the VS auto-fixes for the solution and corelib csproj

* Removing the duplicated T4 file includes in the main csproj

* Regenerating the included T4 templates

* Fixing S.P.Corelib to properly list available platforms/configurations

* Add a comment on the T4 template service

Signed-off-by: dotnet-bot <[email protected]>
2019-05-13 22:49:30 -07:00
Sung Yoon Whang be552ca506 Fix EventCounter disable logic (dotnet/coreclr#24519)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-13 22:49:30 -07:00
Andrew Au 5c401e1572 Remove obsolete comments
Signed-off-by: dotnet-bot <[email protected]>
2019-05-13 22:49:30 -07:00
Stephen Toub 061d44d72e Tweak a few nullable annotations (dotnet/coreclr#24494)
- Assembly.ToString() won't return null
- Several attributes have the intent that their arguments are non-nullable, even though they don't check and throw; the annotations should match the intent in such cases.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-13 22:49:30 -07:00
Stephen Toub 0130eaecb8 Fix netstandard build for nullable annotations
Signed-off-by: dotnet-bot <[email protected]>
2019-05-13 22:49:30 -07:00
Stephen Toub 1f36289bab Fix netfx build with nullable annotations
Signed-off-by: dotnet-bot <[email protected]>
2019-05-13 22:49:30 -07:00
Alexander Kyte 4b111f373e [merp] Add an env var to disable all mono_crash files (#14407) 2019-05-13 09:36:43 -04:00
Zoltan Varga 008a0fb04a [corlib] Avoid preserving all fields of AppDomain. Don't preserve fields of Marshal, the runtime doesn't need them. 2019-05-12 22:49:14 -07:00
Alexander Köplinger ca5e8f207b [sdks] Lipo arm64_32 binaries for watchOS 2019-05-12 17:46:49 -07:00
Zoltan Varga c09128d8ff [corlib] Preserve AppDomain::DoTypeBuilderResolve () using a PreserveDependency attribute. (#14462) 2019-05-12 20:08:12 -04:00
Angelo Compagnucci f29eae3e35 configure: check for c++ availability (#14461)
Since commit d8af775, c++ compiler is required to compile.
This patch checks if the c++ compiler is available as soon as possible
and returns an error in case it is not found.

Fixes: https://github.com/mono/mono/issues/14195

Signed-off-by: Angelo Compagnucci <[email protected]>
2019-05-12 15:43:00 -07:00
Alexander Köplinger db2f0ab3a5 [sdks] Use -pathmap CSC option for iOS/Mac
This allows the products to install the sources at a known location.
2019-05-12 10:23:46 -07:00
Jay Krell a1c476c04d Convert rest of JIT icall registration to static info. (#14455)
* Convert rest of JIT icall registration to static storage.

* PR: Expand macros manually (they can actually emcompass more, not less, another time).
2019-05-11 18:42:04 -07:00
Egor Bogatov 1049f06668 hide props 2019-05-11 09:53:48 +02:00
Marek Safar 73b82f02af Merge pull request #14458 from monojenkins/bclsizediff
[bcl] Update BCL Linked Size
2019-05-11 09:41:33 +02:00
Marek Safar 547ba43104 [System.Private.CoreLib] nullable warnings fixes 2019-05-11 09:40:04 +02:00
Johan Lorensson 072883b7fa Bump boringssl to include fix for Windows path's in lookup dirs. (#14435) 2019-05-11 02:20:00 -04:00
monojenkins f0d6e855ef [bcl] Update BCL Linked Size 2019-05-11 03:26:26 +00:00
Aleksey Kliger (λgeek) f4b86bbb41 [sdks] Build Android SDK on Windows (#14402)
Modify the sdks/builds/ infrastructure to support compiling the Android SDK on Windows.

The initial goal of this commit is to build only the monodroid BCL on Windows.  Compilation of the host and cross-compiler mono binaries is future work.

There's one kind of hacky bit in here.  Had to make sure that scripts/ci/run-jenkins.sh does _not_ set MONO_EXECUTABLE.  Normally windows builds use the msvc in-tree compiled mono binary to build the BCL.  In the case of the SDKs, we don't build that msvc binary, and we just use the usual (cygwin) mono to build the BCL.

* [sdks] allow building on cygwin

* [sdks] Start adding stub templates to llvm.mk

* [sdks] provision-android stubs for win32

* [sdks] Pass cygwin host triple to calls to configure on win32

* [sdks] Add runtime stub templates

* [sdks] Add android stub templates for win32

This is enough to get configure-android to work on cygwin x86_64

* [sdks] On win32, the HostMxe build is the host buildwe want the x86_64-w64-mingw32 toolchain, not the cygwin toolchain

* [sdks] For android on cygwin depend on the mingw64-{x86_64,i686}-zlib

* [sdks] Add android SDK build artifacts to .gitignore

* [sdks] Add AndroidCrossMXETemplate stub to android.mk for Windows builds

* [sdks] Fixup comments in android.mk

* [sdks] use UNAME=Windows for Cygwin and WSL

Don't assume Cygwin is the build platform for Windows Android SDK builds.

Keep using UNAME for coarse platform descriptions.
Switch to HOST_ARCH_MINGW32 instead of CYGWIN_BUILD_MACHINE for variable holding
the machine part of the host triplet for Windows.

* [sdks] Dummy provision-mxe target for windows

* [ci] Don't provision-android on Windows

It doesn't work yet.

* [sdks] temporarily turn off android-host-mxe-Win64-release

Needs mingw64-x86_64-zlib on all the CI builds bots.

* FIXME: hack - don't set MONO_EXECUTABLE to the msvc mono for Android SDK build

* [sdks] drop LLVMProvisionTemplateStub
2019-05-10 19:14:50 -04:00
Bernhard Urban 1d90dcfd35 [arm64] set MONO_ARCH_HAVE_UNWIND_BACKTRACE for watch4 (#14440)
[arm64] set MONO_ARCH_HAVE_UNWIND_BACKTRACE for watch4

Fixes a couple of mscorlib test failures, failing with
> Stack walks are not supported on this platform
2019-05-10 14:05:54 -04:00
Alexis Christoforides aedaf15f27 Revert "[System] Add FSEvent FileSystemWatcher to 'monotouch' BCL pro… (#14316)
* Revert "[System] Add FSEvent FileSystemWatcher to 'monotouch' BCL profile"

This reverts commit 46fc5352f3dfe0027e684a0f61e71130fccd559f.

While iOS FileSystemWatcher works, we now find that it is using unofficially-available  symbols and cannot publish apps using those.

Fixes https://github.com/mono/mono/issues/14290

* [csproj] Update project files
2019-05-10 12:50:03 -04:00
Jay Krell 04252ff724 Remove some malloc from JIT icall registration. (#14431)
Disallow duplicate JIT icall registration (by name, address, or new static info storage).
2019-05-10 08:36:29 -04:00
Johan Lorensson 991c7b6a61 Merge pull request #14425 from lateralusX/lateralusX/fix-profiler-on-windows
Add log profiler support to Mono MSVC build.
2019-05-10 12:50:28 +02:00
Egor Bogatov d06a42d56c TextInfo.ChangeCase should not use CultureInfo.CurrentCulture (#14105)
* Fix TextView

* Update CultureInfoTest.cs
2019-05-10 11:04:52 +02:00
Marek Safar affb833a6d Clean up local nullable enable 2019-05-10 10:51:17 +02:00
dotnet-bot ef5530ca28 fixing server error and syncing the repos 2019-05-10 10:51:17 +02:00
Stephen Toub b31b703b89 Turn on nullability for all of Corelib (dotnet/coreclr#24497)
* Enable nullable at the project level

* Remove `#nullable enable` from individual files

Removes `#nullable enable` from almost all .cs files in System.Private.CoreLib. I left it only in the ~30 files (out of ~1480 that had it) that are mirrored to corefx, that are built into projects by corefx that don't yet set NullableContextOptions at the project level, and that use nullable annotations; otherwise, they'd break the corefx build.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-10 10:51:17 +02:00
Johan Lorensson 5f41fb86be Merge pull request #14332 from lateralusX/lateralusX/add-llvm-windows-msvc-build-packaging-support
Add LLVM Windows MSVC build/packaging/archive/download support.
2019-05-10 10:33:43 +02:00
Filip Navara 643b2ebfc6 [netcore] Enable MSVC builds of Mono w/ ENABLE_NETCORE (#14418)
* Enable MSVC builds of Mono w/ ENABLE_NETCORE

* Fix non-netcore build

* Move the ENABLE_NETCORE definition to config.h where it belongs

* Replace .def with linker #pragmas

* TARGET_WIN32 -> HOST_WIN32 && HOST_X86

* Pick up MONO_ENABLE_NETCORE from cygconfig.h

* Make `./configure --with-core=only` MSVC builds working

* Include netcore sources unconditionally, move the condition into the .c file

* Fix MSVC C++ netcore build on Win32
2019-05-10 10:26:44 +02:00
Martin Baulig 0e5e464cff Add a few DISABLE_SECURITY conditionals. (#14300)
* Add a few `DISABLE_SECURITY` conditionals.

* [csproj] Update project files

* Fix tests.
2019-05-10 10:17:00 +02:00
Ryan Lucia 0c70519707 Fix minor build warning (#14426)
Fix minor build warning
2019-05-10 04:06:00 -04:00
Zoltan Varga 29fb43eb09 [corlib] Change the RuntimeModule.GetGuid and RuntimeAssembly.GetAotId icalls to return a byte array. (#14393)
* [corlib] Change the RuntimeModule.GetGuid and RuntimeAssembly.GetAotId icalls to return a byte array instead of a string, so it doesn't have to be parsed by the Guid ctor. Also allocate the arrays in the c# code and pass them to the icalls.
2019-05-09 20:34:55 -04:00
Jay Krell 77ab9ee0b8 Do not allocate handles in ReleaseMutex. (#14403)
* Do not allocate handles in ReleaseMutex.
Take advantage of thread/internal_thread maturity/pinning.

There are arguments for and against this.

It is arguably better to use handles everywhere.
But it is dubious to require an allocation to release a lock.
Releasing a lock should be infallible.
And surviving low memory shouldn't be a lost cause, imho..

This diff could also be viewed as an opportunistic cycle/size optimization
and be placed under ifdef -- ifdef THREAD_ALWAYS_PINNED orsuch.

This is an alternative to https://github.com/mono/mono/pull/14397.

* PR: Move comments.
2019-05-09 20:54:56 +02:00
lateralusX 2a703e72ff Add log profiler support to Mono MSVC build.
Several fixes to the log profiler in order to work on Windows.

* Add new dynamic library project to build log profiler on Windows MSVC.
* Fix dependecy between log profiler and Mono.
* Rewrite command pipe logic on Windows since it's not supported to select
  on both sockets and pipes.
* Several additional socket fixes needed for log profiler to work on Windows.
2019-05-09 18:33:00 +02:00
Egor Bogatov 735489b10b [netcore] Fix HideDetectionHappensBeforeBindingFlagChecks (#14336)
* Hide public property in Base if there is a private in Derived

* Update excludes-System.Runtime.Tests.rsp

* Update RuntimePropertyInfo.cs
2019-05-09 18:27:24 +02:00
Bernhard Urban a093cbddba [metadata] use handle stack in mono_runtime_object_init_handle (#14399)
Fixes this crash on watchOS with llvmonly:
```
(lldb) bt 35
* thread %1, name = 'tid_303', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x4d55545c)
  * frame %0: 0x01ab81de mscorlibtests`sgen_vtable_get_descriptor(vtable=0x4d555458) at sgen-client-mono.h:29:33
    frame %1: 0x01a9e278 mscorlibtests`major_copy_or_mark_object_canonical at sgen-marksweep-drain-gray-stack.h:158:10
    frame %2: 0x01a9debc mscorlibtests`major_copy_or_mark_object_canonical(ptr=0x182f260c, queue=0x01dd4894) at sgen-marksweep.c:1363
    frame %3: 0x019d31f2 mscorlibtests`mono_handle_stack_scan(stack=0x17e200b0, func=(mscorlibtests`major_copy_or_mark_object_canonical + 1 at sgen-marksweep.c:1362), gc_data=0x01dd4894, precise=1, check=1) at handle.c:340:5
    frame %4: 0x01a45680 mscorlibtests`sgen_client_scan_thread_data(start_nursery=0x00000000, end_nursery=0xffffffff, precise=1, ctx=ScanCopyContext @ 0x01dd4580) at sgen-mono.c:2254:5
    frame %5: 0x01a93e80 mscorlibtests`job_scan_thread_data(worker_data_untyped=0x00000000, job=0x0511c004) at sgen-gc.c:1416:2
    frame %6: 0x01adef0a mscorlibtests`sgen_workers_enqueue_job(generation=1, job=0x0511c004, enqueue=0) at sgen-workers.c:184:3
    frame %7: 0x01a9334a mscorlibtests`enqueue_scan_from_roots_jobs(gc_thread_gray_queue=0x01dd4894, heap_start=0x00000000, heap_end="", ops=0x01c6aaac, enqueue=0) at sgen-gc.c:1661:2
    frame %8: 0x01a94d16 mscorlibtests`major_copy_or_mark_from_roots(gc_thread_gray_queue=0x01dd4894, old_next_pin_slot=0x01dd4864, mode=COPY_OR_MARK_FROM_ROOTS_SERIAL, object_ops_nopar=0x01c6aaac, object_ops_par=0x00000000) at sgen-gc.c:2070:2
    frame %9: 0x01a95658 mscorlibtests`major_start_collection(gc_thread_gray_queue=0x01dd4894, reason="LOS overflow", concurrent=0, old_next_pin_slot=0x01dd4864) at sgen-gc.c:2189:2
    frame %10: 0x01a92ccc mscorlibtests`major_do_collection(reason="LOS overflow", is_overflow=0, forced=1) at sgen-gc.c:2362:2
    frame %11: 0x01a8e9ce mscorlibtests`sgen_perform_collection_inner(requested_size=21616, generation_to_collect=1, reason="LOS overflow", forced_serial=1, stw=1) at sgen-gc.c:2563:14
    frame %12: 0x01a8e76c mscorlibtests`sgen_perform_collection(requested_size=21616, generation_to_collect=1, reason="LOS overflow", forced_serial=1, stw=1) at sgen-gc.c:2640:2
    frame %13: 0x01a8e73e mscorlibtests`sgen_ensure_free_space(size=21616, generation=1) at sgen-gc.c:2514:2
    frame %14: 0x01a99184 mscorlibtests`sgen_los_alloc_large_inner(vtable=0x185749d0, size=21616) at sgen-los.c:380:2
    frame %15: 0x01a81c0a mscorlibtests`sgen_alloc_obj_nolock(vtable=0x185749d0, size=21616) at sgen-alloc.c:172:16
    frame %16: 0x01a44940 mscorlibtests`mono_gc_alloc_vector(vtable=0x185749d0, size=21616, max_length=900) at sgen-mono.c:1317:20
    frame %17: 0x00a5b408 mscorlibtests`aot_wrapper_icall_mono_gc_alloc_vector + 102
    frame %18: 0x00a56818 mscorlibtests`mscorlib_wrapper_alloc_object_AllocVector_intptr_intptr + 324
    frame %19: 0x01092b26 mscorlibtests`mscorlibtests1_MonoTests_System_DecimalTest2__ctor + 7286
    frame %20: 0x00a78912 mscorlibtests`aot_wrapper_gsharedvt_out_sig_pinvoke_void_this_ + 28
    frame %21: 0x00a4a4d2 mscorlibtests`mscorlib_wrapper_runtime_invoke_object_runtime_invoke_sig_void_intptr_intptr_object_intptr_intptr_intptr + 312
```

The hint here was that the crash happened in `mono_handle_stack_scan ()` and inspecting the handle stack there. After enabling `MONO_HANDLE_TRACK_OWNER` and `MONO_HANDLE_TRACK_SP` in `handle.h`, I got this:
```
warning: Handle 0x17886a0c (object = 0x16e73fd0) (allocated from "../../../../../mono/metadata/object.c:3182") is leaking.

    frame %1: 0x019833ba mscorlibtests`mono_handle_new(obj=0x01f194a0, info=0x17882600, owner="../../../../../mono/metadata/gc.c:1337") at handle.c:183:2
    frame %2: 0x019823c0 mscorlibtests`mono_gc_alloc_handle_string(vtable=0x17888760, size=24, len=5) at gc.c:1337:9
    frame %3: 0x019de896 mscorlibtests`mono_string_new_size_handle(domain=0x16e73fd0, len=5, error=0x01dc804c) at object.c:6643:6
    frame %4: 0x019d6fc4 mscorlibtests`mono_string_new_size_checked(domain=0x16e73fd0, length=5, error=0x01dc804c) at object.c:6655:2
    frame %5: 0x019de64e mscorlibtests`mono_string_new_utf16_checked(domain=0x16e73fd0, text=0x1842ab10, len=5, error=0x01dc804c) at object.c:6536:6
    frame %6: 0x019debc2 mscorlibtests`mono_string_new_checked(domain=0x16e73fd0, text="ar-SA", error=0x01dc804c) at object.c:6778:7
    frame %7: 0x019b06a8 mscorlibtests`construct_culture(this_obj=0x01f19428, ci=0x01b2d878, error=0x01dc804c) at locales.c:357:2
    frame %8: 0x019b0e3a mscorlibtests`ves_icall_System_Globalization_CultureInfo_internal_get_cultures(neutral='\0', specific='\x01', installed='\0') at locales.c:714:9
    frame %9: 0x007061f0 mscorlibtests`aot_wrapper___System_dot_Globalization_System_dot_Globalization_dot_CultureInfo__internal_get_cultures_pinvoke_cl2a_System_2eGlobalization_2eCultureInfo_5b_5d__cl4_bool_cl4_bool_cl4_bool_cl2a_System_2eGlobalization_2eCultureInfo_5b_5d__cl4_bool_cl4_bool_cl4_bool_ + 100
    frame %10: 0x00704fb2 mscorlibtests`mscorlib_System_Globalization_CultureInfo_GetCultures_System_Globalization_CultureTypes + 192
    frame %11: 0x0100f422 mscorlibtests`mscorlibtests1_MonoTests_System_DateTimeTest_Parse_Bug53023b + 192
    frame %12: 0x00a28702 mscorlibtests`aot_wrapper_gsharedvt_out_sig_pinvoke_void_this_ + 28
    frame %13: 0x009fa2c2 mscorlibtests`mscorlib_wrapper_runtime_invoke_object_runtime_invoke_sig_void_intptr_intptr_object_intptr_intptr_intptr + 312
    frame %14: 0x019278f2 mscorlibtests`mono_llvmonly_runtime_invoke(method=0x17953820, info=0x1842a9a0, obj=0x053b7c40, params=0x00000000, exc=0x01dc8550, error=0x01dc88a4) at mini-runtime.c:3000:2
```

@lambdageek suggested this fix after showing this trace to him. As far as I understand we do _not_ know the root cause yet. The handle leak happens in this trace:
```
(lldb) mbt
* thread %1
  * frame %0: 0x0176192c mscorlibtests`do_debug_me_please_kkthx at object.c:128:2
    frame %1: 0x01761a62 mscorlibtests`mono_runtime_object_init_handle(this_obj=MonoObjectHandle @ 0x01b53fbc, error=0x01b5404c) at object.c:146:3
    frame %2: 0x0176191e mscorlibtests`mono_runtime_object_init_checked(this_obj_raw=0x01fde880, error=0x01b5404c) at object.c:176:2
    frame %3: 0x0173ce32 mscorlibtests`ves_icall_System_Globalization_CultureInfo_internal_get_cultures(neutral='\0', specific='\x01', installed='\0') at locales.c:712:4
    frame %4: 0x004931d8 mscorlibtests`aot_wrapper___System_dot_Globalization_System_dot_Globalization_dot_CultureInfo__internal_get_cultures_pinvoke_cl2a_System_2eGlobalization_2eCultureInfo_5b_5d__cl4_bool_cl4_bool_cl4_bool_cl2a_System_2eGlobalization_2eCultureInfo_5b_5d__cl4_bool_cl4_bool_cl4_bool_ + 100
    frame %5: 0x00491f9a mscorlibtests`mscorlib_System_Globalization_CultureInfo_GetCultures_System_Globalization_CultureTypes + 192
    frame %6: 0x00d9b8f4 mscorlibtests`mscorlibtests1_MonoTests_System_DateTimeTest_Parse_Bug53023b + 192
    frame %7: 0x007b56ea mscorlibtests`aot_wrapper_gsharedvt_out_sig_pinvoke_void_this_ + 28
```
`mono_runtime_object_init_checked ()` already should take care of the handle stack 😕
2019-05-09 11:31:24 -04:00
Alexander Köplinger a597cee5b0 [sdks] Add .cs source files to ios archive
XI/XM install the Mono sources as part of their package.
2019-05-09 17:24:35 +02:00
Alexander Köplinger 969c04b141 [packaging] Add some missing .pdb's to Windows MSI (#14420) 2019-05-09 16:14:21 +02:00
Jay Krell 2524d5613b Usually do not create a handle in mono_runtime_invoke_handle. (#14404)
Use mono_runtime_invoke_handle_void instead.
2019-05-09 16:13:21 +02:00
Egor Bogatov b4e565f21b [netcore] Set of workarounds for ArrayTests (#14369)
* Fix ushort to char conversion

* fix one more test

* Enable more Array tests

* fix comment

* Fix CreateInstance_NotSupportedType_ThrowsNotSupportedException

* Address feedback

* Update ArraySortHelper.cs

* fix compilation error?

* bump corefx-tests, fix one more array.copy issue
2019-05-09 14:36:44 +02:00
Alexander Köplinger 8370fe318b [sdks] Make sure the mono-version.txt directory exists 2019-05-09 11:48:56 +02:00
Jay Krell c7697e0643 Mechanize strings in marshal.c register_icall and cleanup a little. (#14357)
The less mechical parts:
 - spell out monoeg_g_free
 - register_dyn_icall not used, remove
 - register_icall_no_wrapper only used once, spell it out instead

This is nice cosmetically on its own and will help remove JIT icall hashing.
2019-05-09 10:03:55 +02:00
Alexander Köplinger be571243e4 Bump helix-binaries
Helix recently started using Python 3 so we need to have a compatible xunit-reporter.py script.
2019-05-09 09:44:53 +02:00
Jay Krell 997190c12c Introduce enum and static data for JIT icalls, that are currently hashed (#14359)
* Introduce enum and static data for JIT icalls, that are currently hashed
by string and address and use dynamic allocation.

These will be used shortly.

* PR: Move MONO_JIT_ICALLS content from class-internals.h to jit-icall-reg.h.
Not clear what is the best name but moving along.
2019-05-09 02:06:52 -04:00
Ryan Lucia 6a20b25cc6 [corlib] Implement AssemblyBuilder.get_ReflectionOnly() (#14406)
* [corlib] Implement AssemblyBuilder.get_ReflectionOnly()

Fixes #13028

* Bump API snapshot submodule
2019-05-08 23:53:35 +02:00
Ryan Lucia 2894e57ed7 [gitignore] Add crash dump files, .dylib.dSYM directories, and test-path (#14408)
[gitignore] Add crash dump files, .dylib.dSYM directories, and test-path

Wasn't sure where in the file to best put the .dylib.dSYM stuff, so suggestions are welcome
2019-05-08 17:36:11 -04:00
Larry Ewing 0dd432096b Merge pull request #14203 from kjpou1/wasm-sdk-lower-version
[wasm][sdk] Fix warning NU1604, does not contain an inclusive lower b…
2019-05-08 11:44:03 -05:00
Alexander Köplinger 622ae6b8d4 [sdks] Add Mono version to ios/mac archive 2019-05-08 17:07:20 +02:00
Bernhard Urban 19f57ad0b8 [llvmonly] make local copy of trace_ips pointer from exception object (#14400)
Fixes a race in llvmonly (watchOS):
```
Process 397 stopped
* thread %10, name = 'tid_8e2f', stop reason = EXC_BAD_ACCESS (code=1, address=0x28)
    frame %0: 0x0177f690 mscorlibtests`mono_llvm_load_exception at mini-exceptions.c:3886:23
   3883                 size_t upper = mono_array_length_internal (mono_ex->trace_ips);
   3884
   3885                 for (int i = 0; i < upper; i += TRACE_IP_ENTRY_SIZE) {
-> 3886                         gpointer curr_ip = mono_array_get_internal (mono_ex->trace_ips, gpointer, i);
   3887                         for (int j = 0; j < TRACE_IP_ENTRY_SIZE; ++j) {
   3888                                 gpointer p = mono_array_get_internal (mono_ex->trace_ips, gpointer, i + j);
   3889                                 trace_ips = g_list_append (trace_ips, p);
Target 0: (mscorlibtests) stopped.

(lldb) mbt
* thread %10
  * frame %0: 0x0177f690 mscorlibtests`mono_llvm_load_exception at mini-exceptions.c:3886:23
    frame %1: 0x00e23b7a mscorlibtests`mscorlibtests1_MonoTests_System_LazyTest__c__DisplayClass16_0__ConcurrentInitializationb__1 + 254
    frame %2: 0x0087af98 mscorlibtests`mscorlib_wrapper_delegate_invoke__Module_invoke_void + 610
    frame %3: 0x00368856 mscorlibtests`mscorlib_System_Threading_ThreadHelper_ThreadStart_Context_object + 448
  [...]
(lldb) p/x mono_ex
(MonoException *) $2 = 0x01d9e968
(lldb) p/x mono_ex->trace_ips
(MonoArray *) $3 = 0x00000000
(lldb) thread list
Process 397 stopped
  thread %1: tid = 0x38772, 0x018156aa mscorlibtests`jit_info_table_copy_and_split_chunk(table=0x17635a00, chunk=0x17b767f0) at jit-info.c:483:28, name = 'tid_303', queue = 'com.apple.main-thread'
  thread %3: tid = 0x387ad, 0x1c4f9764 libsystem_kernel.dylib`__psynch_cvwait + 24, name = 'SGen worker'
  thread %4: tid = 0x387b0, 0x1c4f1224 libsystem_kernel.dylib`semaphore_wait_trap + 8, name = 'Finalizer'
  thread %5: tid = 0x387b5, 0x1c4fa6cc libsystem_kernel.dylib`__workq_kernreturn + 8
  thread %6: tid = 0x387b6, 0x1c4f11d4 libsystem_kernel.dylib`mach_msg_trap + 20, name = 'com.apple.uikit.eventfetch-thread'
* thread %10: tid = 0x389a6, 0x0177f690 mscorlibtests`mono_llvm_load_exception at mini-exceptions.c:3886:23, name = 'tid_8e2f', stop reason = EXC_BAD_ACCESS (code=1, address=0x28)
  thread %11: tid = 0x38985, 0x1c4f9764 libsystem_kernel.dylib`__psynch_cvwait + 24, name = 'tid_8113'
  thread %12: tid = 0x38986, 0x1c4f123c libsystem_kernel.dylib`semaphore_timedwait_trap + 8, name = 'Thread Pool Worker'
  thread %13: tid = 0x38987, 0x1c4f123c libsystem_kernel.dylib`semaphore_timedwait_trap + 8, name = 'Thread Pool Worker'
  thread %14: tid = 0x389a3, 0x1c4f123c libsystem_kernel.dylib`semaphore_timedwait_trap + 8, name = 'Thread Pool Worker'
  thread %15: tid = 0x389a4, 0x1c4f123c libsystem_kernel.dylib`semaphore_timedwait_trap + 8, name = 'Thread Pool Worker'
  thread %16: tid = 0x389a5, 0x1c4f123c libsystem_kernel.dylib`semaphore_timedwait_trap + 8, name = 'Thread Pool Worker'
(lldb) thread select 1
* thread %1, name = 'tid_303', queue = 'com.apple.main-thread'
    frame %0: 0x018156aa mscorlibtests`jit_info_table_copy_and_split_chunk(table=0x17635a00, chunk=0x17b767f0) at jit-info.c:483:28
   480                          jit_info_table_split_chunk (chunk, &new_table->chunks [j], &new_table->chunks [j + 1]);
   481                          j += 2;
   482                  } else {
-> 483                          new_table->chunks [j] = table->chunks [i];
   484                          ++new_table->chunks [j]->refcount;
   485                          ++j;
   486                  }
(lldb) mbt
* thread %1
  * frame %0: 0x018156aa mscorlibtests`jit_info_table_copy_and_split_chunk(table=0x17635a00, chunk=0x17b767f0) at jit-info.c:483:28
    frame %1: 0x01815304 mscorlibtests`jit_info_table_chunk_overflow(table=0x17635a00, chunk=0x17b767f0) at jit-info.c:579:10
    frame %2: 0x018146ee mscorlibtests`jit_info_table_add(domain=0x16624cc0, table_ptr=0x16624d9c, ji=0x176f4428) at jit-info.c:614:33
    frame %3: 0x01814662 mscorlibtests`mono_jit_info_table_add(domain=0x16624cc0, ji=0x176f4428) at jit-info.c:674:2
    frame %4: 0x0175f5da mscorlibtests`mono_aot_find_jit_info(domain=0x16624cc0, image=0x16c07200, addr=0x00271ff1) at aot-runtime.c:3710:3
    frame %5: 0x0181443e mscorlibtests`mono_jit_info_table_find_internal(domain=0x16624cc0, addr=0x00271ff1, try_aot=1, allow_trampolines=0) at jit-info.c:306:9
    frame %6: 0x018145e0 mscorlibtests`mono_jit_info_table_find(domain=0x16624cc0, addr=0x00271ff1) at jit-info.c:335:9
    frame %7: 0x01780212 mscorlibtests`build_stack_trace(frame_ctx=0x01c2fb18, state=0x01c2ffb8) at mini-exceptions.c:392:31
    frame %8: 0x1c598aa2 libunwind.dylib`_Unwind_Backtrace + 232
    frame %9: 0x0177f4fc mscorlibtests`throw_exception(ex=0x01d9e968, rethrow=0) at mini-exceptions.c:3800:3
    frame %10: 0x0177f3c8 mscorlibtests`mono_llvm_throw_exception(ex=0x01d9e968) at mini-exceptions.c:3823:2
    frame %11: 0x00439ed0 mscorlibtests`mscorlib_System_Runtime_ExceptionServices_ExceptionDispatchInfo_Throw + 116
    frame %12: 0x00271ff0 mscorlibtests`mscorlib_System_LazyHelper_ThrowException + 98
    frame %13: 0x002730c2 mscorlibtests`mscorlib_System_Lazy_1_T_REF_CreateValue + 194
    frame %14: 0x00273390 mscorlibtests`mscorlib_System_Lazy_1_T_REF_get_Value + 128
    frame %15: 0x0027307a mscorlibtests`mscorlib_System_Lazy_1_T_REF_CreateValue + 122
    frame %16: 0x00273390 mscorlibtests`mscorlib_System_Lazy_1_T_REF_get_Value + 128
    frame %17: 0x00e22eb0 mscorlibtests`mscorlibtests1_MonoTests_System_LazyTest_ConcurrentInitialization + 1422
    frame %18: 0x008948e2 mscorlibtests`aot_wrapper_gsharedvt_out_sig_pinvoke_void_this_ + 28
    frame %19: 0x008664a2 mscorlibtests`mscorlib_wrapper_runtime_invoke_object_runtime_invoke_sig_void_intptr_intptr_object_intptr_intptr_intptr + 312
```
2019-05-08 09:39:59 -04:00
Zoltan Varga f879e35e3e [runtime] Use MAP_JIT automatically when running under a hardened runtime on osx. (#14395)
* [runtime] Use MAP_JIT automatically when running under a hardened runtime on osx.

* Fix memory ordering.
2019-05-08 07:20:55 -04:00
Alexander Köplinger 76f3d2da55 [sdks] Add Mono binaries to mac archive 2019-05-08 12:42:54 +02:00
Jay Krell 8928ed6fd8 Mechanize strings in mini-runtime.c register_jit_icall. (#14374)
* Mechanism strings to register_dyn_icall in mini-runtime.c.
That is both, generate them kinda, and make them available for some later manipulation.

* Mechanize strings for JIT icall registration in mini-runtime.c.
Generate them slightly and make them amenable to crude preprocessor transforms later.

* Try to improve github diff presentation.
2019-05-08 03:46:31 -04:00
lateralusX 6fc4fe419d Bump LLVM to include build/package/upload/download of Windows LLVM builds. 2019-05-08 09:24:38 +02:00
Zoltan Varga 5ccb9854b8 [interp] Add tracing support. Return values are not yet supported. (#14389) 2019-05-07 23:16:20 -04:00
Jo Shields 1ecbff9e93 Don't apply MONO_ATTR_FORMAT_PRINTF to mono_error_set_argument (#14385)
The constructor for mono_error_set_argument lacks a `const char *msg_format`
so clearly we shouldn't be applying formatting from an entirely
unrelated parameter.

This was flagged by `-Werror=format-security`
2019-05-07 15:52:35 -04:00
Jo Shields 80f99fc37d Remapping should affect GAC search paths considered by the loader (#14384)
Closes: #14366

Fixes Mac package failures during IronRuby compilation
2019-05-07 15:32:30 -04:00
Alexis Christoforides 2454ccb800 [corlib] Fix exception 'replacement' in IsolatedStorageFile.MoveFile()
This was caused by changes in File.Move coming from https://github.com/mono/mono/pull/12000
2019-05-07 14:33:27 -04:00
Larry Ewing b0ec83c4d0 Merge pull request #14370 from lewing/mixed-sample
[wasm] Add a mixed target for sample
2019-05-07 11:05:50 -05:00
Alexander Köplinger bf7faa00ad [sdks] Add Mono libraries to mac archive 2019-05-07 17:43:03 +02:00
Alexander Köplinger b39d38ece1 [sdks] Add mono-2.pc to mac archive
Xamarin.Mac needs it.
2019-05-07 17:43:03 +02:00
Alexander Köplinger ece23539f1 [sdks] Add Mono libraries and frameworks to iOS archive 2019-05-07 17:43:03 +02:00
Alexander Köplinger 5c4f523065 [sdks] Remove --with-monotouch from configure arguments
They are only needed for BCL builds and those are disabled by --disable-mcs-build
2019-05-07 17:43:03 +02:00
Alexander Köplinger 37f3fa17a1 [sdks] Fix README.md 2019-05-07 17:43:03 +02:00
Johan Lorensson 5bcf166375 Merge pull request #14375 from lateralusX/lateralusX/fix-mutex-leak-on-gc
Mutex memory leak on sgen GC (nursery, major).
2019-05-07 13:57:05 +02:00
Juan Antonio Cano b5b9ac7456 Fix for #14353 (#14354) 2019-05-07 11:40:55 +02:00
Bernhard Urban 8913a1a73e [arm] fix armv7k regression on struct passing (#14362)
We can't use `slotsize=8` on `armv7k` as it leads to stack corruption.

Note that `mtouch` already calls the AOT compiler with `--aot=mtriple=arm64_32-ios`, so no changes are required there.

Regression introduced by https://github.com/mono/mono/pull/12992

Fixes https://github.com/mono/mono/issues/13454
2019-05-07 05:24:55 -04:00
lateralusX c5d014397a Mutex memory leak on sgen GC (nursery, major).
During GC we allocate a gray queue protected by a mutex, sgen_gray_object_queue_init.
This mutex is never destroyed when clearing up the object containing it,
sgen_gray_object_queue_dispose, so it will leak. Overtime this could cause
OOM on some systems depending on how memory related to system primitives are
handled and partitioned.
2019-05-07 10:20:31 +02:00
Anirudh Agnihotry f46b93c5f4 making DiagnosticCounter internal (dotnet/coreclr#24427)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-07 07:02:02 +02:00
Jay Krell b3ecd17109 Mechanize strings in cominterop register_jit_icall. (#14356)
This reduces the current source code and will be useful in eliminating JIT icall hashing.
2019-05-06 19:31:03 -04:00
Jay Krell 072ff8fcfb Mechanize strings in remoting.c register_icall. (#14360)
This will help remove/reduce JIT icall hashing, as the
name will also be a field name or token paste to an enum value.
2019-05-06 19:29:42 -04:00
Thays Grazia 1294e4d0e5 A deadlock happens when during a process_suspend there is a pending invoke and then when it's calling the invoke there is another call to process_suspend in the same thread. (#14368) 2019-05-06 19:24:02 -03:00
Jay Krell a41be28871 Make mono_fmod extern "C and not static, to simplify later (#14355)
* Make mono_fmod extern "C and not static, to simplify later
removal of JIT icall hashing. Making it more consistent with other icalls.
Costing maybe one instruction in some slow paths.

* Move mono_fmod from mini-runtime.c to jit-icalls.c.

* Fix declaratoin of mono_fmod.
2019-05-06 23:49:29 +02:00
Aaron Robinson b8cf9823a8 Port all managed product binaries to use SDK style projects (#24285)
Convert managed product binary to use SDK project system.
 - Uses Arcade for versions strings
 - Overrides Arcade defined output paths - should change in the future

Signed-off-by: dotnet-bot <[email protected]>
2019-05-06 20:20:25 +02:00
Krzysztof Wicher 8ab1154d23 Nullable: System.Collections.Generic remainder (dotnet/coreclr#24340)
* Nullable: System.Collections.Generic remainder

* apply review feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-05-06 16:57:18 +02:00
sancheolz 3e51e7d222 [WinForms] fix EditingCellFormattedValue getter and setter for bool value (#13845)
* [WinForms] If DataGridViewCheckBoxCell not in threeState mode
EditingCellFormattedValue must return true or false, instead of
value of CheckState type

* [WinForms] DataGrid: fix type check in EditingCellFormattedValue setter.
When set bool value to EditingCellFormattedValue there will be exception.
Type equality must be done through IsAssignableFrom not direct

* [WinForms] DataGrid: Add test for EditingCellFormattedValue getter and setter.
2019-05-06 15:11:49 +02:00
monojenkins b6a652c072 Bump API snapshot submodule 2019-05-06 15:00:15 +02:00
Marek Safar ad3a5196dc [Facades] Include missing enums in System.Memory 2019-05-06 15:00:15 +02:00
Alexander Köplinger 4eea0870e1 [tests] Write nunit/xunit exclude categories to a file (#14281)
So we can include it in the SDKs archive.
2019-05-06 13:59:03 +02:00
Ben Adams 3bb7f82d00 Move AsyncMethodBuilder.SetStateMachine to non-generic (#24403)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-06 10:55:35 +02:00
pedestrianlove f60a397ab5 Remove special casing (#14155)
* match the parameter

* Removed special handling.

Removed special handling of TypedReference and RuntimeArgumentHandle

* Remove the whole special casing block

* Revert part of last commit

Restored the check for IsByRefLikeAttribute

* Corrected the function name
2019-05-06 02:00:16 -04:00
Larry Ewing 8d80ccc897 Merge pull request #14259 from jeromelaban/dev/jela/wasm-dlopen
[Wasm] Add support for P/Invoke through dynamic linking
2019-05-05 16:39:52 -05:00
Patrik Švikruha b30604fe9f fix typos - expext to expect in wasm test 2019-05-05 12:39:29 +02:00
Larry Ewing 59caa3e992 Add replace ContainsKey with a consistency check in object registration (#14343) 2019-05-05 08:04:37 +02:00
lateralusX edc7c34502 Add execute permissions on build scripts. 2019-05-04 13:29:36 +02:00
Larry Ewing b2a9049de4 Merge pull request #14331 from BrzVlad/feature-interp-ldsflda-opt
[interp] Optimize ldsflda opcode
2019-05-04 00:55:38 -05:00
Egor Bogatov 534c6883b1 [netcore] Fix CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_T… (#14321)
* Fix CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_ThrowsMissingMethodException

* Update excludes-System.Runtime.Tests.rsp

* Update RuntimeType.cs
2019-05-04 06:36:03 +02:00
Jan Kotas 744d3b7713 Fix CoreRT build breaks
Signed-off-by: dotnet-bot <[email protected]>
2019-05-04 06:25:52 +02:00
Filip Navara b7876417d3 Implement String.IsAscii in shared CoreLib and use it for [Is]Normalize[d] for all runtimes (#24373)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-04 06:25:52 +02:00
Levi Broderick f96706874d Vector.CopyTo / TryCopyTo should be readonly methods (dotnet/coreclr#24359)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-04 06:25:52 +02:00
Larry Ewing 887887a7fe Merge pull request #14340 from lewing/wasm-link-descriptor
[wasm] Add --link-descriptor arg to packager
2019-05-03 22:56:13 -05:00
Jérôme Laban ff4839d99e Regenerate m2n trampolines 2019-05-03 20:42:10 -04:00
Jérôme Laban 40981f0cfd Adjust indentation 2019-05-03 20:40:31 -04:00
Jérôme Laban 21743bd58d Add vifffff and viffffff trampolines 2019-05-03 20:40:30 -04:00
Jérôme Laban 04b8dd0f9b Fix invalid emscripten path file name 2019-05-03 20:39:18 -04:00
Jérôme Laban ca9892c340 Lookup pinvoke_names in wasm_dl_load first 2019-05-03 20:39:18 -04:00
Jérôme Laban 4c034a4678 Adjust indentation 2019-05-03 20:39:18 -04:00
Jérôme Laban ee6603916d Make wasm dlopen use only for release-dynamic configuration 2019-05-03 20:39:18 -04:00
Jérôme Laban 8a0e78d5a9 Move -s MAIN_MODULE=1 to all configurations
This will avoid emscripten to call abort() because  MAIN_MODULE is not defined.
2019-05-03 20:39:18 -04:00
Jérôme Laban b5b860f8d7 Make libmono_icall_table_la_LIBADD and libmono_ilgen_la_LIBADD conditional to wasm. 2019-05-03 20:39:18 -04:00
Jérôme Laban 8bddfdb2d2 Fix indentation, spacing. 2019-05-03 20:39:17 -04:00
Jérôme Laban f8371d8114 Generate m2n after update 2019-05-03 20:39:17 -04:00
Jérôme Laban c48414e9ef Apply fix for emscripten issue
https://github.com/emscripten-core/emscripten/issues/8511
2019-05-03 20:30:00 -04:00
Jérôme Laban 935bc21276 Fix indentation 2019-05-03 20:30:00 -04:00
Jérôme Laban 3f303a5033 Adjust release-dynamic output 2019-05-03 20:30:00 -04:00
Jérôme Laban ecd8c210e0 Add more driver cookies 2019-05-03 20:30:00 -04:00
Jérôme Laban aaccedfbfb Adjust touch of the release-dynamic folder 2019-05-03 20:30:00 -04:00
Jérôme Laban 6207844e39 try build release-dynamic 2019-05-03 20:29:59 -04:00
Jérôme Laban 51abc92b6e mono emscripten double loading issue 2019-05-03 20:29:59 -04:00
Jérôme Laban a1cda38793 Workaround for second dlopen failure returns non-null 2019-05-03 20:29:59 -04:00
Jérôme Laban 195e7f0b05 Add missing include 2019-05-03 20:29:59 -04:00
Jérôme Laban b50d35f620 Add minimal dl support 2019-05-03 20:29:59 -04:00
Jérôme Laban f334609ad5 Add EXPORT_ALL
https://github.com/emscripten-core/emscripten/blob/399cd460a4c7f12fbc7104cc7d1e7e20e7b574bf/tests/test_browser.py#L3420
2019-05-03 20:29:58 -04:00
Jérôme Laban 96e4e2f532 Enable dynamic linking support for mono 2019-05-03 20:29:58 -04:00
Larry Ewing 4cc2c190c0 Merge pull request #14309 from lewing/icall-branch
[wasm] generate icall_trampoline_dispatch as nested branches
2019-05-03 17:56:32 -05:00
Larry Ewing ea912ff155 Merge pull request #14306 from radical/bump_msbuild_master
[msbuild] Bump to pick up test fixes
2019-05-03 16:12:56 -05:00
Larry Ewing 0262d10220 Add --link-descriptor arg to packager to allow custom linker configuration 2019-05-03 13:45:21 -05:00
Jo Shields cae7795990 [netcore] Unique Asset Manifest filenames per branch 2019-05-03 14:41:44 -04:00
Larry Ewing 1d86f1a792 Order the groupings preferentially by length to reduce the worst case 2019-05-03 13:31:55 -05:00
Jo Shields 2331437db0 [netcore] Install and use GNU sed on Mac 2019-05-03 14:02:12 -04:00
Jo Shields 4b6f7f090a [netcore] Looks like dependsOn only references base job name, not each leg 2019-05-03 13:41:45 -04:00
Jo Shields 7fcf315af7 [netcore] Add OSX build (#14337) 2019-05-03 13:32:47 -04:00
Jo Shields 99853eeeb3 [netcore] Publish to BAR too (#14334) 2019-05-03 10:49:41 -04:00
Martin Baulig 40372422e7 Add a few RuntimeFeature.IsDynamicCodeSupported conditionals. (#14284)
* Add a few `RuntimeFeature.IsDynamicCodeSupported` conditionals.

* Update RuntimeMethodInfo.cs
2019-05-03 16:09:48 +02:00
lateralusX f42c1e0a67 Add option to restore VS build env from file. 2019-05-03 15:14:22 +02:00
lateralusX 568813b93b Add support for cygwin and WSL in helper build scripts. 2019-05-03 15:14:21 +02:00
lateralusX 488e15e8ab Add support to include external build LLVM binaries in Mono build output. 2019-05-03 15:14:21 +02:00
lateralusX f83d9f3575 Add LLVM SDK build/package support for Windows msvc build LLVM. 2019-05-03 15:14:21 +02:00
Zoltan Varga 231da41c78 [corlib] Avoid a runtime crash on new ArgIterator(new RuntimeArgumentHandle()). 2019-05-03 12:55:41 +02:00
Vlad Brezae ccdc79fd9e [interp] Optimize ldsflda opcode
2-4x speedup
2019-05-03 13:54:06 +03:00
Sung Yoon Whang 2867365120 Add Series/CounterType to CounterPayload and IncrementingCounterPayload (#24349)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-03 09:08:20 +02:00
Jay Krell d37cd2c2fc ld -Bsymboli so dynamic linker does not get betweem mono and itself. (#14298) 2019-05-03 02:29:56 -04:00
Paul Hebble 955faeac52 Fix light on light ListViewGroup headers on dark theme 2019-05-02 22:16:06 -05:00
Zoltan Varga 15f9b329c0 [runtime] Fix the signature of the AppDomain:DoUnhandledException () icall. (#14322) 2019-05-02 22:44:08 -04:00
Larry Ewing 795fed8852 Merge pull request #14319 from lewing/set-options-strdup
[wasm] Define wasm_strdup when setting options
2019-05-02 20:25:18 -05:00
Larry Ewing e6422bc3b4 Define wasm_strdup when setting options 2019-05-02 14:24:36 -05:00
Zoltan Varga 8312f0abe3 [wasm] Add a --runtime-arg= argument to runtime-tests.js to allow setting runtime arguments like --trace. (#14305) 2019-05-02 14:46:18 -04:00
Krzysztof Wicher 6ea6d1a481 Add using System.Diagnostics on some files
Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Stephen Toub b607d622ff Delete stale compilation constants from AsyncIteratorMethodBuilder (#37331)
I accidentally left these MICROSOFT_BCL_ASYNCINTERFACES_PACKAGE references in as part of some recent churn.  This compilation constant isn't set anywhere.

And the CORERT ifdef is no longer needed now that we've consolidated the code to shared.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Stephen Toub b1c8ebcdd4 Add ManualResetValueTaskSourceCore / AsyncIterateMethodBuilder to Microsoft.Bcl.AsyncInterfaces (#37320)
* Add ManualResetValueTaskSourceCore / AsyncIterateMethodBuilder to Microsoft.Bcl.AsyncInterfaces

These two types needed modifications to target .NET Standard 2.0 and are the necessary pieces to enable the compiler to compile async iterators.

- Copied ManualResetValueTaskSourceCore.cs from coreclr and tweaked it.  I opted to do this rather than ifdef because the changes are not localized and I didn't want to significantly perturb the primary implementation.
- Added a few ifdefs to the shared AsyncIteratorMethodBuilder.  It already had ifdefs, so I just added to it.
- Added a test project, and included the existing ManualResetValueTaskSourceCore tests.  I had to disable two of the tests because of some of the optimization differences.
- Augmented those tests to validate that the compiler is able to successfully generate iterators and await foreach them.

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Ludovic Henry 7336f1d621 Implement GC.RegisterMemoryLoadChangeNotification (dotnet/coreclr#24202)
* Implement GC.RegisterMemoryLoadChangeNotification

This allows users to register a callback to be called whenever the
memory load is between a low and high thresholds. The idea is to allow
them to tweak their memory usage based on the available memory.

It is only internal for now because we are not confident on the shape of
the API and if it's the best we can provide users. This needs to go
through a few iterations with first party users like ASP.NET or corefx.

WIP for https://github.com/dotnet/coreclr/issues/18619

* fixup! Implement GC.RegisterMemoryLoadChangeNotification

* fixup! Implement GC.RegisterMemoryLoadChangeNotification

* fixup! Implement GC.RegisterMemoryLoadChangeNotification

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Dan Moseley 4b40a182b1 Adjust some terms (dotnet/coreclr#24351)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Krzysztof Wicher e09ca81503 Nullable: Interop and src/System remainder (dotnet/coreclr#24328)
* Nullable: Interop and src/System remainder

* apply feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Krzysztof Wicher c8b4fc18c3 Nullable: System.Collections remainder (non-generic) (dotnet/coreclr#24326)
* Nullable: System.Collections remainder (non-generic)

* apply feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Blake Hensley 6f1121badb Added overloads to Path.Join (dotnet/coreclr#24307)
* Added overloads to Path.Join

* Refactor Path.Join and Path.Combine to use ValueStringBuilder

* Use proper defined const for empty string

* Fix Windows-specific const

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Stephen Toub 8c5f625792 Move the new ConfigureAwait/WithCancellation extension methods to a new type (#24331)
We decided after all to put these on a different type, TaskAsyncEnumerableExtensions.  This commit adds the new type.  We can delete the methods in the old location once corefx consumes an updated build and switches over to using the new ones.

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Santiago Fernandez Madero 3c0290dfcd Merge pull request dotnet/coreclr#24258 from dotnet/NullableFeature
Merge nullable feature into master

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Buyaa Namnan a25a0c2fc6 Fix test failures
Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Krzysztof Wicher 50a010a39f fix build errors after merge
Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Santiago Fernandez Madero 8f883a789f Nullable: Comparers, Dictionary and Friends (dotnet/coreclr#23971)
* Nullable: Comparers, Dictionary and Friends

* Add object constraint to Dictionary

* Fix warning from new compiler and annotating dictionary

* PR Feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
buyaa-n 3183fd2028 Nullable for Type class (dotnet/coreclr#23489)
System.Type, System.Reflection nullability

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Krzysztof Wicher ab23b7e07d Nullable: System.Diagnostics.Tracing (dotnet/coreclr#24070)
* Nullable: System.Diagnostics.Tracing

* apply feedback

* fix one more comment

Signed-off-by: dotnet-bot <[email protected]>
2019-05-02 20:34:11 +02:00
Bernhard Urban 1cbd5cbacf [arm] amend stack pointer properly in exception trampoline (#14310)
The previous attempt ( https://github.com/mono/mono/pull/14078 ) only fixed it for ABIs where the stack pointer alignment is 8 bytes. ABIs, such as watchOS, require 16 byte alignment.
2019-05-02 13:48:41 -04:00
Alexander Kyte b15631d641 [llvm] Widen vector equality (OP_PCMPEQx) (#14292)
* [llvm] Widen vector equality (OP_PCMPEQx)

Fixes https://github.com/mono/mono/issues/14261
Fixes https://github.com/mono/mono/issues/14143

This was causing an issue when trying to inline
System.Numerics.Vectors.Vector`1<byte>:Equals into System.Span.IndexOf
from System.Memory.dll as provided by nuget. I believe that it is
comparing the result of a SIMD operation on two SIMD registers there with a
SIMD register full of zero bytes.

When we produce the Equals call (no inline), we spill the SIMD <4 x i32>
vector to the stack in the caller, and we then later load it
with the widened type used here <16 x i8>.

When we inline, we end up making the args into XMOV opcodes,
and then doing the "pcmpeqb" mini opcode with the return values
from those operations. This becomes a register to register no-op
copy, and the original <4 x i32> gets compared against the <16 x i8>
type:

```
  %116 = icmp eq <16 x i8> zeroinitializer, <4 x i32> %115
```

This does not go the way we want it to. It reliably leads to IndexOf
breaking and only finding the desired byte in the portion not processed
by the SIMD code (in the last few elements of the array).

This fix checks if the input dimensions differ, and does a conversion.
This produces the following IR:

```
  %114 = bitcast <4 x i32> %99 to <16 x i8>
  %115 = icmp eq <16 x i8> %114, %113
  %116 = sext <16 x i1> %115 to <16 x i8>
  %117 = icmp eq <16 x i8> zeroinitializer, %116
```

* [llvm] Widen vector greater-than

Here we do the same trick used in the above fix, but for the parallel greater-than operation.
2019-05-02 12:24:35 -04:00
Jay Krell d371432a10 Move three trivial threadpool icalls to callers. (#14296)
ves_icall_System_Threading_ThreadPool_PostQueuedCompletionStatus
 ves_icall_System_Threading_ThreadPool_BindIOCompletionCallbackNative
 ves_icall_System_Threading_ThreadPool_IsThreadPoolHosted
2019-05-02 10:25:58 -04:00
Jo Shields 748da2e4a9 [netcore] Onboard Arcade (#14301) 2019-05-02 10:24:10 -04:00
Friedrich von Never c9c50f85f4 Fix #14255: correct type and bitness for TARGETS request of X11 clipboard 2019-05-02 14:23:02 +02:00
Egor Bogatov ea917ba76a [netcore] clean up excludes-System.Runtime.Tests.rsp (#14294)
* update System.Runtime.Tests.rsp

* Update System.Private.CoreLib.csproj

* Update excludes-System.Runtime.Tests.rsp

* Invoke AppContext.OnProcessExit from runtime

* remove Utf16/Utf8 tests

* Implement LoadFromPath

* make NativeLibrary os specific

* Add missing LoadWithPartialName

* Update Assembly.cs

* Update Assembly.cs

* Update NativeLibrary.Unix.cs
2019-05-02 14:00:39 +02:00
Larry Ewing 2e97d6edd7 Merge pull request #14295 from vargaz/mixed-eh-5
[runtime] Fix some mixed EH problems.
2019-05-02 01:46:36 -05:00
Larry Ewing f557414b61 Try out a branching trampoline dispatch 2019-05-01 23:29:48 -05:00
Ankit Jain 3fe8360358 [msbuild] Bump to pick up test fixes 2019-05-01 15:43:27 -04:00
Alexis Christoforides 2fc4d80c99 corlib] Add API that was dropped during the coreFX System.IO integration (#14265) 2019-05-01 11:24:21 -04:00
Marek Safar cece97035d Make block optimized ClearWithoutReferences fully shared (#24312)
Signed-off-by: dotnet-bot <[email protected]>
2019-05-01 09:28:17 +02:00
Zoltan Varga 781d20bab4 [runtime] Fix some mixed EH problems. 2019-05-01 02:00:56 -04:00
Zoltan Varga e431093f73 [aot] Avoid passing -march=arm to llc when using thumb, it forces arm32 code generation. (#14288)
Fixes https://github.com/mono/mono/issues/14247.
2019-04-30 20:47:27 -04:00
Ankit Jain a27a7737c4 Update nuget.exe too 2019-04-30 20:12:08 +02:00
Ankit Jain 450e296221 Bump msbuild to track xplat-master 2019-04-30 20:12:08 +02:00
Tanner Gooding 285992a721 Updating System.Numerics.Vector<T> to use the readonly members feature. (#23827)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-30 18:29:44 +02:00
monojenkins 0da2ba771b [csproj] Update project files 2019-04-30 12:14:57 +02:00
lateralusX 81ce33f6b6 Add minimal COM support into WinAOT BCL profile and Windows Mono runtime.
Technologies like SharpDX uses a minimal set of COM support from runtime
and System.Runtime.InteropServices.Marshal:

AddRef
Release
QueryInterface

All these are low level wrappers around methods in IUknown interface and
doesn't need any of the additional runtime COM support enabled to work.

Technologies like CoreRT includes these methods in their full AOT
profile, meaning that SharpDX can run on CoreRT on Windows platforms. Mono's
WinAOT profile and runtime currently don't, making it impossible  to use
SharpDX.

This PR adds the needed methods into WinAOT profile and also make
sure corresponding icalls always gets included on Windows build Mono runtime.
2019-04-30 12:14:57 +02:00
Marek Safar 92cb0369bb Fix the build 2019-04-30 09:39:12 +02:00
Levi Broderick 98846ea2ff Add more span-based Vector<T> ctors and CopyTo methods (#23333)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-30 09:39:12 +02:00
Egor Bogatov 5702e95cea Move DefaultBinder.CanConvert.cs to shared (dotnet/coreclr#23931)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-30 09:39:12 +02:00
Michal Strehovský 7bca6da11f Move NativeLibrary to the shared partition (dotnet/coreclr#24143)
I'm taking the LibraryNameVariation helper from System.Runtime.Loader for the ride as well because it's a general purpose probing logic that is useful in a managed implementation of NativeLibrary.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-30 09:39:12 +02:00
dschinde 6291956230 Improve pref of Array.IndexOf() for certain T. (dotnet/coreclr#24293)
Applies changes to `Array.IndexOf()` and `Array.LastIndexOf()` similar
to the changes made in #20855, so that types other than `byte` and
`char` can use use the fast vectorized path.

Also allows 32-bit and 64-bit types for which
`RuntimeHelpers.IsBitwiseEquatable<T>()` returns `true` to use the
faster implementation of `IndexOf` and `LastIndexOf` from
`MemoryExtensions`.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-30 09:39:12 +02:00
Jan Kotas cee1268335 Workaround memset alignment sensitivity (dotnet/coreclr#24302)
* Workaround memset alignment sensitivity

memset is up to 2x slower on misaligned block on some types of hardware. The problem is uneven performance of "rep stosb"
used to implement the memset in some cases. The exact matrix on when it is slower and by how much is very complex.

This change workarounds the issue by aligning the memory block before it is passed to memset and filling in the potential misaligned
part manually. This workaround will regress performance by a few percent (<10%) in some cases, but we will gain up to 2x improvement
in other cases.

Fixes #24300

Signed-off-by: dotnet-bot <[email protected]>
2019-04-30 09:39:12 +02:00
Anirudh Agnihotry b3eeab7410 Improve Precision to 10 microseconds in timespan (dotnet/coreclr#24279)
* Increasing precision properly and leaving the rounding of to casting operator

* disabling corefx tests in coreclr and addressing feedback

* correcting test project name

* Fix json

Signed-off-by: dotnet-bot <[email protected]>
2019-04-30 07:48:31 +02:00
Zoltan Varga cf10cb7238 [wasm] Add support for pinvokes in user assemblies. (#14253)
The --pinvoke-libs=x argument to packager.exe can be used to generate pinvoke linking tables.
'x' is a list of library names used in DllImport declarations, i.e. --pinvoke-libs=libtest is used
to link with [DllImport ("libtest")].
2019-04-29 19:20:28 -04:00
Larry Ewing 498974d09a Merge pull request #14199 from kjpou1/wasm-sdk-cl-args
[wasm][sdk] Add command line quoting and escaping to WasmLinkAssembli…
2019-04-29 17:33:44 -05:00
Marek Safar dc683e5cd3 Fix the build 2019-04-29 22:47:13 +02:00
Steve MacLean c86a8f843e Fix Satellite Assembly loading (dotnet/coreclr#24191)
* Fix Satellite Assembly loading

When loading satellite assemblies, we should probe next to the parent
assembly and load into the same AssemblyLoadContext as the parent
assembly.

Disable fallback probing for satellite assemblies.

Add AssemblyLoadContext.Resolving handler to probe for satellite
assemblies next to parent

Fixes #20979

* Call ResolveSatelliteAssembly from native

Only call ResolveSatelliteAssembly from native when
resolving a satellite assembly

* PR Feedback

Minimize string creation
Remove unnecessary if null checks
Eliminate corner cases by only allowing one case insensitive matching directory.

* ResolveSatelliteAssembly should ...

ResolveSatelliteAssembly should always be called on the ALC which loaded parentAssembly

Simplify code.
Add Debug.Assert

* Remove case insensitive culture search

* PR Feedback

* Fix parentAssembly logic

* Fixes from initial testing

* Add probe for lower case culture name

* PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-29 22:47:13 +02:00
Anirudh Agnihotry f503eb7dbc Revert "Dummy commit" (dotnet/coreclr#24197)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-29 22:47:13 +02:00
Anipik 45f19a5577 Dummy commit
Signed-off-by: dotnet-bot <[email protected]>
2019-04-29 22:47:13 +02:00
Anipik c94f194278 synving with coreclr 2019-04-29 22:10:14 +02:00
Marek Safar c6c25db0c2 Mirror changes from mono/coreclr,corefx,corert (#14163)
Mirror changes from mono/coreclr,corefx,corert
2019-04-29 19:30:57 +02:00
monojenkins 344df07dd2 [csproj] Update project files 2019-04-29 15:47:04 +02:00
Martin Baulig 23343ab506 Remove ClientRealProxy on wasm and testing_aot. 2019-04-29 15:47:04 +02:00
Martin Baulig 06487590ff Define DISABLE_SECURITY and DISABLE_REMOTING on wasm and testing_aot. 2019-04-29 15:47:04 +02:00
Martin Baulig b22ed1a09f Make testing_aot_full tests build again in System.Security. (#14244)
* Make `testing_aot_full` tests build again in System.Security.

* Add System.Security tests.
2019-04-29 15:43:33 +02:00
Kenneth Pouncey 1faa0ec279 Set an explicit version.
Address review comments by Katelyn Gadd
2019-04-29 05:51:06 +02:00
Jay Krell 90a91429ae Remove libgcc_s_seh-1.dll dependency when targeting Win32 with gcc. (#14251)
Don't use popcount intrinsic.
Alternative but not exactly contradictory to https://github.com/mono/mono/pull/14248.

Note that this is a single inlinable instruction on x86,
if you assume at least SSE4 from circa 2007, which I am avoiding here.
2019-04-27 21:57:17 -04:00
Vlad Brezae 6d9c4c24d2 [interp] Optimize enum Hasflag (#14173)
* [interp] Optimize enum.HasFlag for csc pattern

Avoid boxing and slow call. Makes it 100x faster.

* [interp] Optimize enum.HasFlag for mcs pattern

* [interp] Transform ldc.i4 + conv.i8 into ldc.i8

Simplifies code, making enum.HasFlag optimization work for long enums.
2019-04-27 12:14:16 +03:00
Kenneth Pouncey 5d9ecd7112 [wasm][bindings] Refactor WebAssembly.Core object instantiation. (#14191)
* Refactor WebAssembly.Core object instantiation.

- Move the supported Core object identification into javascript.
- Runtime the core object type is now passed into the Runtime from javascript binding support instead of being housed in managed code.

* Address review comments.

* Fix indentation

* Implement suggestion by Katelyn Gadd to use Symbol instead of a Map or WeakMap.

- This removes the previous mono_wasm_core_map used for type mapping.
- Attach a special named symbol for `wasm type` to the prototype property for the Core objects that we have bound.
- The Managed Type is stored in the symbol property that will be passed to the managed side.
2019-04-27 09:27:22 +02:00
monojenkins 87000b43bb [bcl] Update BCL Linked Size 2019-04-27 08:38:28 +02:00
Vlad Brezae a68022ae7e [interp] Optimize special static field access (#14202)
* [interp] Optimize special static field access

3x faster. For value types 10x.

* [interp] Remove duplicated code

* [interp] Further optimize thread static field access

Provides an additional 50% perf gain.
2019-04-27 00:28:12 +03:00
Vlad Brezae 6fb7b496bd [interp] Don't change next_jit_code_hash during imethod transform (#14240)
This field is used by the internal hash table to link nodes and it can be changed during hash table insertion of other imethods. Copying this field back was leading to random hangs in hash table lookup.
2019-04-26 17:20:33 +02:00
Zoltan Varga c2e540331d [runtime] Add a python version of the offsets tool. (#14229)
* [runtime] Add a python version of the offsets tool.

This version only depends on python and libclang. It currently only
works on osx.

* [runtime] Add a dummy structure needed by the python version of the offsets tool.

* [offsets-tool-py] Change some argument names for compatibility.

* [wasm] Use the python offsets tool on osx, the c# version is 32 bit, and the 64 bit version doesn't work.

* [wasm] Fix the ordering of mono libraries on the link line.
2019-04-26 11:12:24 -04:00
Martin Baulig 5e2069746c Avoid HashAlgorithm.Create() on FULL_AOT_RUNTIME. (#14228) 2019-04-26 14:08:36 +02:00
Kenneth Pouncey c97840f414 Replace the command line generation using string formatting with the ProcessArguments routines that will add escaping and quoting to the parameters and as necessary.
- The routine specifically will escape path separators when needed for instance on windows instead of using the simplified `.Replace ("\\", "\\\\")` as previously implemented.
- The routine will also add quoting when necessary.
2019-04-26 12:00:30 +02:00
Kenneth Pouncey cefbe81ee9 Rebase WasmLinkAssemblies 2019-04-26 11:12:08 +02:00
Jo Shields d44e45c32e [netcore] Avoid touching or using submodules in coreonly mode 2019-04-26 08:53:25 +02:00
Jo Shields 82a60e239f [netcore] Copy in 3 files, to avoid need for corert submodule in coreonly 2019-04-26 08:53:25 +02:00
Jérôme Laban 95cc5b2f45 Add missing pinvoke-tables-default.h from build artifacts. (#14237)
[Wasm] Add missing pinvoke-tables-default.h from build artifacts

This change restores the ability to build wasm AOT apps outside the mono source tree.
2019-04-26 00:45:45 -04:00
Martin Baulig 19387b1f41 Disable "unreachable code" warnings on wasm. (#14230) 2019-04-25 22:02:53 +02:00
Jo Shields 3521df4cf4 [netcore] Smarter version numbering of nupkg (#14011)
The version number in version.h only shows e.g. "6.3.0", and we
want full version numbers ideally, to match what our Mac pkg files
show. This logic calculates that version number.
2019-04-25 15:42:56 -04:00
Jo Shields b1d54d2e42 [netcore] Fix make dist following https://github.com/mono/mono/pull/14167 (#14233) 2019-04-25 14:27:46 -04:00
Jay Krell 8eec35bcdd Fix arm32 tailcall_reg/tailcall_membase. (#14187)
* Revert "[Tailcall] [arm] [jit] Fix moving tailcall parameters. (#12701)"

This reverts commit 257efc6374.

* When moving parameters for tailcall, and having pushed ip,
and adjusting the offset to account for that, split the adjustment
between sp and frame pointer, as frame pointer may or may not be sp.
This fixes https://github.com/mono/mono/issues/11489.
2019-04-25 13:10:06 -04:00
Egor Bogatov 591d6d0a21 [netcore] ASP.NET Core sample (#14224)
* ASP.NET Core sample

* update makefile

* update Home page

* Update Makefile

* remove ASPNET_SHAREDRUNTIME

* replace mvc with web sample
2019-04-25 18:28:56 +02:00
Alexis Christoforides e541be2da2 [monodroid] Enable System.IO.Pipes (#14160)
* [monodroid] Enable System.IO.Pipes

* Bump API snapshot submodule

* [csproj] Update project files
2019-04-25 11:05:11 -04:00
monojenkins 3d7a63ba17 [csproj] Update project files 2019-04-25 09:17:13 +02:00
Martin Baulig 0a5a9ec821 Remove DISABLE_REMOTING conditional. 2019-04-25 09:17:13 +02:00
Martin Baulig b07f68a61c Getting rid of the DISABLE_REMOTING conditional. 2019-04-25 09:17:13 +02:00
Vlad Brezae 913951b350 [interp] Don't check for exception in native wrappers (#14184)
We already do it when we get back to the interpreter.
2019-04-25 10:09:11 +03:00
Johan Lorensson 45a3eef924 Merge pull request #14101 from lateralusX/lateralusX/add-coop-support-windows-msvc
Add hybrid/cooperate suspend runtime support on Windows.
2019-04-25 02:53:13 -04:00
Bernhard Urban b658792614 [interp] fix op_explicit for cast from nfloat to nint and vice versa (#14201)
Fixes https://github.com/xamarin/xamarin-macios/issues/5809
2019-04-25 08:37:01 +02:00
monojenkins 1e9ea1c616 [bcl] Update BCL Linked Size 2019-04-25 08:15:15 +02:00
Kenneth Pouncey e412e520f5 [wasm][sdk] Add dotnet new custom template. (#14183)
* [wasm][sdk] Add dotnet new custom template.

```
Templates                                         Short Name         Language          Tags
----------------------------------------------------------------------------------------------------------------------------
Mono WebAssembly Starter                          wasm               [C#]              Mono/WebAssembly
```

Example use:

```
dotnet new wasm -n Test.WebAssembly -o Test.WebAssembly
```

* Package the template files
2019-04-25 05:50:54 +02:00
Kenneth Pouncey 7f6deb2b6f [wasm] [bindings] Package doc .xml files (#14174) 2019-04-25 05:49:54 +02:00
Filip Navara 019b4563d3 [netcore] Restore Roslyn compilers from NuGet to allow up-to-date version to be used (#14157)
* Restore Roslyn compilers from NuGet to allow up-to-date version to be used

* Move the Roslyn version to makefile, ensure that it is updated before building System.Private.CoreLib

* Pass the whole path to Roslyn props file instead of just Roslyn version to dotnet build

* Make the Roslyn restore compatible with .NET Core 2.2 SDK
2019-04-24 17:24:46 +02:00
Egor Bogatov 95b873997a [netcore] Don't wrap CustomAttributeNamedArgument into CustomAttributeNamedArgument (#14180)
* don't wrap CustomaAttributeNamedArg

* fix BlockCopy failing test

* update NETCORETESTS_VERSION and NETCOREAPP_VERSION

* avoid typedard creation in netcore

* fix merge issue
2019-04-24 17:23:51 +02:00
Alexander Kyte 0d9e13f983 [llvm] Propagate nonnull attribute through LLVM IR (#13697)
## Summary

This change allows LLVM to identify unnecessary null checks. We mark GOT accesses (including those made by LDSTR) and new object calls as nonnull.

Since LLVM won't propagate this, we propagate from definition to usage, across casts, and from usage to definition (conditionally).

This enables it to remove a significant portion of some benchmarks. 

In real-world code, we can expect to see this remove the unnecessary null checks made by private methods. 

## Example

### C#:

Note that the constant strings are trivially non-null. This PR spots and propagates that. 

```

   static void ThrowIfNull(string s)
    {
        if (s == null)
            ThrowArgumentNullException();
    }

    static void ThrowArgumentNullException()
    {
        throw new ArgumentNullException();
    }

    [MethodImpl(MethodImplOptions.NoInlining)]
    static int Bench(string a, string b, string c, string d)
    {
        ThrowIfNull(a);
        ThrowIfNull(b);
        ThrowIfNull(c);
        ThrowIfNull(d);

        return a.Length + b.Length + c.Length + d.Length;
    }

    [Benchmark(Description = nameof(NoThrowInline))]
    public int Test() => Bench("a", "bc", "def", "ghij");

```

### Before:

```

define hidden monocc i32 @NoThrowInline_MainClass_Bench_string_string_string_string(i64*  %arg_a, i64* %arg_b, i64* %arg_c, i64*  %arg_d) #6 gc "mono" {
BB0:
  br label %INIT_BB1

INIT_BB1:                                         ; preds = %BB0
  br label %INITED_BB2

INITED_BB2:                                       ; preds = %INIT_BB1
  br label %BB3

BB3:                                              ; preds = %INITED_BB2
  br label %BB2

BB2:                                              ; preds = %BB3
  notail call monocc void @NoThrowInline_MainClass_ThrowIfNull_string(i64* %arg_a)
  notail call monocc void @NoThrowInline_MainClass_ThrowIfNull_string(i64* %arg_b)
  notail call monocc void @NoThrowInline_MainClass_ThrowIfNull_string(i64* %arg_c)
  notail call monocc void @NoThrowInline_MainClass_ThrowIfNull_string(i64* %arg_d)
  %0 = bitcast i64* %arg_a to i32*
  %1 = getelementptr i32, i32* %0, i32 4
  %t50 = load volatile i32, i32* %1
  %2 = bitcast i64* %arg_b to i32*
  %3 = getelementptr i32, i32* %2, i32 4
  %t52 = load volatile i32, i32* %3
  %t53 = add i32 %t50, %t52
  %4 = bitcast i64* %arg_c to i32*
  %5 = getelementptr i32, i32* %4, i32 4
  %t55 = load volatile i32, i32* %5
  %t56 = add i32 %t53, %t55
  %6 = bitcast i64* %arg_d to i32*
  %7 = getelementptr i32, i32* %6, i32 4
  %t58 = load volatile i32, i32* %7
  %t60 = add i32 %t56, %t58
  br label %BB1

BB1:                                              ; preds = %BB2
  ret i32 %t60
}

```

### After:

Note: safepoint in below code is added by backend, not part of this change

```

define hidden monocc i32 @NoThrowInline_MainClass_Bench_string_string_string_string(i64* nonnull %arg_a, i64* nonnull %arg_b, i64* nonnull %arg_c, i64* nonnull %arg_d) #6 gc "mono" {
BB0:
  %0 = getelementptr i64, i64* %arg_a, i64 2
  %1 = bitcast i64* %0 to i32*
  %t50 = load volatile i32, i32* %1, align 4
  %2 = getelementptr i64, i64* %arg_b, i64 2
  %3 = bitcast i64* %2 to i32*
  %t52 = load volatile i32, i32* %3, align 4
  %t53 = add i32 %t52, %t50
  %4 = getelementptr i64, i64* %arg_c, i64 2
  %5 = bitcast i64* %4 to i32*
  %t55 = load volatile i32, i32* %5, align 4
  %t56 = add i32 %t53, %t55
  %6 = getelementptr i64, i64* %arg_d, i64 2
  %7 = bitcast i64* %6 to i32*
  %t58 = load volatile i32, i32* %7, align 4
  %t60 = add i32 %t56, %t58
  %8 = load i64*, i64** getelementptr inbounds ([37 x i64*], [37 x i64*]* @mono_aot_NoThrowInline_llvm_got, i64 0, i64 7), align 8
  %9 = load i64, i64* %8, align 4
  %10 = icmp eq i64 %9, 0
  br i1 %10, label %gc.safepoint_poll.exit, label %gc.safepoint_poll.poll.i

gc.safepoint_poll.poll.i:                         ; preds = %BB0
  %11 = load void ()*, void ()** bitcast (i64** getelementptr inbounds ([37 x i64*], [37 x i64*]* @mono_aot_NoThrowInline_llvm_got, i64 0, i64 25) to void ()**), align 8
  call void %11() #8
  br label %gc.safepoint_poll.exit

gc.safepoint_poll.exit:                           ; preds = %BB0, %gc.safepoint_poll.poll.i
  ret i32 %t60
}

```

## Dependencies 

This depends on https://github.com/mono/linker/pull/528.
2019-04-24 16:53:47 +02:00
Jo Shields 5c02267668 [netcore] Fix escaping (#14209) 2019-04-24 10:50:16 -04:00
Jo Shields 1fe9041e4b [netcore] This is a bash script, not a batch file. Correct env var use. (#14207) 2019-04-24 10:09:27 -04:00
Larry Ewing 194070823c Merge pull request #14192 from kjpou1/wasm-fix-cl
[wasm][tests] Fix browser test command line arguments.
2019-04-24 08:59:39 -05:00
Jo Shields 9d4c9a89f1 [netcore] Try passing dnceng PAT for internal builds (#14204) 2019-04-24 09:21:21 -04:00
lateralusX 0d390066ca Fix race condition under wow64 for cooperative suspended threads.
Under hybrid suspend a thread can be cooperative suspended but still
checked for a platform critical region under wow64. Since thread is
not preemptive suspended we can't reliably call GetThreadContext and
doing so could also (even correctly) return a context flagged as critical
triggering an assert in stw for cooperative suspended threads.
2019-04-24 14:16:03 +02:00
lateralusX f26e30c38a Add hybrid/cooperate runtime support on Windows. 2019-04-24 14:15:45 +02:00
Kenneth Pouncey c5aa3ecdec [wasm][sdk] Fix warning NU1604, does not contain an inclusive lower bound 2019-04-24 13:57:16 +02:00
Santiago Fernandez Madero 7bd9e122aa Fix build errors in Interop.Errors
Signed-off-by: dotnet-bot <[email protected]>
2019-04-24 11:02:06 +02:00
Santiago Fernandez Madero be620ee542 Disable warning in ValueStringBuilder.ToString
Signed-off-by: dotnet-bot <[email protected]>
2019-04-24 11:02:06 +02:00
Kenneth Pouncey 9a0ce7242c [wasm][sdk] Add command line quoting and escaping to WasmLinkAssemblies ToolTask.
- This resolves a few issues when executing `monolinker.exe` from windows build.
2019-04-24 10:52:45 +02:00
Alexander Köplinger 4873b27706 [acceptance-tests] Run roslyn tests using in-tree mono instead of system mono (#14186)
We were inadvertently running the roslyn tests against the system mono in CI.
Instead we now install mono to a custom prefix, prepend that to PATH and run
the roslyn tests against the correct mono we just built.
2019-04-24 08:50:58 +02:00
Kenneth Pouncey fd0b6a769a [wasm][tests] Fix command line arguments.
- Add `.pdb` file support to the karma config.
2019-04-24 06:50:02 +02:00
Katelyn Gadd 14e83aab44 Add roslyn bump instructions next to roslyn-binaries 2019-04-23 18:38:55 -04:00
Zoltan Varga fdc2dce384 [netcore] Convert netcore/Makefile.am to a normal makefile, get the configure variables from config.make. (#14167)
* [netcore] Convert netcore/Makefile.am to a normal makefile, get the configure variables from config.make.

* [netcore] Convert mcs/class/System.Private.CoreLib/Makefile.am to a normal makefile.
2019-04-23 17:01:23 -04:00
Jo Shields 73c2145c28 [netcore] Fix error in sed, screwing up submodules (#14189) 2019-04-23 16:45:53 -04:00
Jo Shields 4a144ac103 Merge pull request #14188 from directhex/mangle-submodules-internally
[netcore] Mangle .gitmodules on internal project to internal mirrors
2019-04-23 16:23:42 -04:00
Jo Shields 6e10a33a07 [netcore] Mangle .gitmodules on internal project to internal mirrors 2019-04-23 16:01:58 -04:00
Zoltan Varga c1c7a739cc [netcore] Throw the correct exception for byref returns returning null, .net core throws a nullref. (#14128) 2019-04-23 12:05:50 -04:00
Bernhard Urban 223e0bd78d [aot] partial revert of #14043 (#14135)
We need to emit a real call here. On arm/android we would emit this now:
```asm
ldr pc, =label
.ltorg         # place address of `label` here.
```
which is a jump to `label`, not a call.

We need a different solution to make larger assemblies work, but for now
I revert it so the `2019-02` intergration is unblocked.

Partial revert of #14043
2019-04-23 15:53:05 +02:00
Thays Grazia aed21f3e4b [DIM] Throwing AmbiguousImplementationException on call of multiple candidate implementations. (#14127)
* Adding AmbiguousImplementationException exception and throwing this when there are multiple candidate implementations.
2019-04-23 09:48:39 -03:00
Filip Navara 921f00352f [netcore] Establish a baseline for make xtestpass (#14072)
* Bump CoreFX version, include few more packages

* Add exclusions for System.Collections.NonGeneric.Tests

* Exclude tests that crash runtime

* Add more exclusions for known failures

* Exclude System.Utf8String.Experimental.Tests, it is CoreCLR specific
Exclude System.ComponentModel.Composition.Registration.Tests, the published version throws PNSE for all methods

Please enter the commit message for your changes. Lines starting

* Make a list of known non-passing tests and establish baseline for 'make xtestpass'

* Add exclusions

* Reenable System.Net.NameResolution.Functional.Tests

* Reenable System.Net.Sockets.Tests

* Reenable System.Diagnostics.Tracing.Tests

* Reenable System.Net.Http.Functional.Tests

* Reenable System.Net.HttpListener.Tests

* Reenable System.CodeDom.Tests

* Reenable System.Linq.Expressions.Tests

* Reenable System.Threading.ThreadPool.Tests

* Reenable System.Runtime.Tests

* Reenable System.Collections.Tests

* Reenable System.Threading.ThreadPool.Tests

* Reenable System.Memory.Tests

* Reenable System.Linq.Parallel.Tests

* Update exclusions for System.Diagnostics.Process.Tests

* Reenable System.Dynamic.Runtime.Tests

* Reenable System.Runtime.Numerics.Tests

* Sort excluded tests

* Reenable System.Reflection.Tests

* Reenable System.Reflection.Emit.Tests

* Reenable System.Linq.Parallel.Tests

* Reenable System.Diagnostics.TraceSource.Tests

* Reenable System.Threading.Tests

* Disable tests that trigger UI on macOS

* Update System.Runtime.Tests exclusion list

* Update line numbers
2019-04-23 14:44:39 +02:00
Jay Krell 1ffb5fb83f Cleanup patch_info code a little. (#14037)
e.g. whenever underlying representation is nul terminated string.
 MONO_PATCH_INFO_LDSTR_LIT
 MONO_PATCH_INFO_OBJC_SELECTOR_REF
almost the same as
 MONO_PATCH_INFO_JIT_ICALL
 MONO_PATCH_INFO_JIT_ICALL_ADDR
 MONO_PATCH_INFO_JIT_ICALL_ADDR_NOCALL

MONO_PATCH_INFO_LDSTR_LIT no longer allocate
 and copy the string from the AOT image into image_pool.

g_str_equal check pointer equality first.
While obviously correct, not obviously faster,
as it adds cost when strings are unequal.

Uninline g_str_equal, seems cleaner, but perhaps less efficient.

Combine the switch-exit and default: paths,
as only one case other than default exited the switch.

Lift out other common subexpressions.
2019-04-23 10:57:31 +02:00
Kenneth Pouncey 778f3a4925 [wasm][sdk] Fixes to the sdk packages (#14120)
* Package the wasm and wasm Facades correctly.

* Move the build props and targets file to netstandard2.0 build directory.

* Place framework .props file properly for build

* Place runtime .props file properly for build

* A little cleanup and add escaping windows path separator.

- There are problems executing mononlinker.exe on windows if the windows path separators are not escaped.
2019-04-23 07:17:26 +02:00
Zoltan Varga 2477d73d58 [runtime] Fix a warning. (#14168) 2019-04-22 20:56:48 -04:00
Zoltan Varga 0a95f46f30 [llvm] Remove unused dlsym_cb. (#14164) 2019-04-22 20:56:33 -04:00
Zoltan Varga f1d1bd6084 [llvmonly] Enable invariant loads from preinited got slots. (#14027) 2019-04-22 18:03:36 -04:00
Aleksey Kliger (λgeek) 43540e6649 [image] Create MonoImageStorage to own the image raw data (#13942)
* [image] Create MonoImageStorage to own the image raw data

Create a new data structure: MonoImageStorage.

It is an object that will have the responsibility for the raw data of a
MonoImage.  It has a string key and a refcount that is used to share a
MonoImageStorage between multiple MonoImage objects.

The reason we need this is because the current MonoAssembly/MonoImage design is
broken for multiple domains and (more evidently) it will be broken when we add
AssemblyLoadContext support.  The issue is that a MonoImage may be shared
between multiple domains (or ALCs), but it has a 'references' field which
points to a single other MonoAssembly.

This is a problem because the references of an image may be resolved
differently in different domains (or ALCs).

The eventual solution will be to stop sharing MonoImages based on path name (or
in the case of in-memory images based on a name made up from the address of the
byte blob).

However we still don't want to open the same data more than once (if we're on a
config where we don't have mmap, we malloc some memory and dump the data in
there - we don't want to do that multiple times for the same file).

So the solution is to create this MonoImageStorage object and make it possible
to share it based on path name, but don't give it any responsibilities except
for owning the memory.  It doesn't know anything about metadata or assemblies
or any of that stuff - it just owns a chunk of memory and knows when and how to
free it.

This commit just adds the MonoImageStorage object and wires it up in MonoImage
loading.  There should be no observable behavioral changes from this commit.

* [win32] call FreeLibrary from MonoImageStorage dtor, not mono_image_close_except_pools

If we're sharing a MonoImageStorage, only call FreeLibrary when the storage is
finally destroyed, not every time one of the images is closed.
2019-04-22 14:43:11 -04:00
Steve MacLean f318317bbd Remove create assembly name (dotnet/coreclr#24154)
* Remove RuntimeAssembly.CreateAssemblyName

Fixes #24135

CreateAssemblyName was not compatible with AssemblyLoadContext isolation.

Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)

* Remove unused AssemblyNameNative::Init arguments

* Temp disable corefx CreateInstanceAssemblyResolve

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:49:48 +00:00
dotnet-maestro-bot ba4e9450aa Update BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively (master) (#24060)
* Update BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively

* Fix build errors

* Disable warning with pragma and linked issue

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:49:47 +00:00
Steve MacLean 9cf417d5b7 Fix Timezone whitespace (dotnet/coreclr#24137)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:49:41 +00:00
Tanner Gooding 2119795cae Pulling in CoreFX changes and fixing up Sse2.StoreLow to be Sse2.StoreScalar (#24123)
* Update dependencies from https://github.com/dotnet/corefx build 20190419.5

    - Microsoft.NETCore.Platforms - 3.0.0-preview5.19219.5
    - Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19219.5

* Removing the Sse2.StoreLow(long/ulong*, ...) methods that have been replaced

* Moving the Sse2.StoreLow(long/ulong*, ...) tests to be Sse2.StoreScalar tests

* Fixing some existing usages of Sse2.StoreLow(long/ulong*, ...)

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:45:47 +00:00
Koundinya Veluri b1255e5f83 Implement APIs for some threading metrics (CoreCLR) (dotnet/coreclr#24113)
Implement APIs for some threading metrics (CoreCLR)

API review: https://github.com/dotnet/corefx/issues/35500

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:45:47 +00:00
Krzysztof Wicher a97a684f25 Nullable: couple of missing #nullable enable (dotnet/coreclr#24094)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:45:46 +00:00
Stephen Toub 029b95b2c5 Nullable: System.Collections.Concurrent (dotnet/coreclr#24054)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:45:45 +00:00
Benjamin Bartels 8430f02a5a Fixed ChunkEnumerator.Current NRE (dotnet/coreclr#24076)
* Fixed ChunkEnumerator.Current NRE

* Added Nullable Flow analysis annotation comment

* Changed TODO-NULLABLE comment to link to appropriate issue

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:45:44 +00:00
Santiago Fernandez Madero 7d24b8eeef Fix StringBuilder annotations and debug.asserts (dotnet/coreclr#24069)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:45:44 +00:00
Stephen Toub a19c49cf77 Nullable: Addition COM types (dotnet/coreclr#24032)
Somehow these slipped through previous rounds of annotating.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:45:42 +00:00
Stephen Toub c9d58058fc Fix a few internal nullable annotations and comments (dotnet/coreclr#23987)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:43:21 +00:00
Stephen Toub 656238b95b Nullable: System.Runtime.InteropServices.CustomMarshalers/WindowsRuntime (#23930)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:43:20 +00:00
Stephen Toub dd29d74ca4 Nullable: src\System\Runtime\InteropServices (dotnet/coreclr#23936)
* Nullable: src\System\Runtime\InteropServices

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:43:20 +00:00
buyaa-n f7c25c025c Nullable: Enums, Structures from Reflection folder (dotnet/coreclr#23933)
* Nullable: Enums, Structures from Reflection

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:43:19 +00:00
Anirudh Agnihotry 8104af8221 Nullable System.ComponentModel, System.Diagnostics.CodeAnalysis, System.Diagnostics.Contracts (#23910)
* Nullable System.ComponentModel, System.Diagnostics.CodeAnalysis, System.Diagnostics.Contracts

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:42:09 +00:00
Stephen Toub f1901501e8 Nullable: Runtime serialization, COM, Vector, remaining IO, and other (#23895)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:42:05 +00:00
Stephen Toub bde9213406 Nullable: System.Runtime.CompilerServices (dotnet/coreclr#23886)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:38:01 +00:00
Krzysztof Wicher 2126d5a92c Nullable: Globalization native interop + some missing files (#23914)
* Nullable: globalization native + some missing files

* address feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:38:00 +00:00
Stephen Toub 01917a7a4a Update Version annotations to match changes in master (#23917)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:38:00 +00:00
Anirudh Agnihotry 06441b788f Nullable: System.Diagnostics (dotnet/coreclr#23753)
* added nullable annotation for system.Diagnostics

* fixing build errors with nullableFeature branch

* stephen feedback

* annotating files in the shared folder

* removing newline, correxting message and adding comments

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:37:59 +00:00
Anirudh Agnihotry 74dc838b36 Nullable System.Diagnostics.Store (dotnet/coreclr#23874)
* removing using systems and adding nullability for System.Diagnostics.SymbolStore

* annotating the class that implements the internal interface

* adding bang to fix failure

* correcting the byte array declarations

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:37:58 +00:00
Anirudh Agnihotry 452db22237 Nullable: Interop.Adavapi32 (dotnet/coreclr#23875)
* interop definations nullified

* reverting null check and adding arguments nullable to match win32 function definations

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:37:57 +00:00
Santiago Fernandez Madero 88f40c0547 Fix build errors due to merge conflicts
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:37:53 +00:00
Krzysztof Wicher b4ed8f6782 Nullable: Interop: Kernel32 and few others (dotnet/coreclr#23880)
* Nullable: Interop: Kernel32 and few others

* fix compile errors (new compiler)

* address feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:35:22 +00:00
Stephen Toub 933536a87a Address follow-up PR feedback on System nullability annotations (#23878)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:35:00 +00:00
Stephen Toub 3418f9c1f8 Nullable: System (most of it) (dotnet/coreclr#23774)
* Nullable: shared\System (most of it)

And some other things it touches.

* Nullable: src\System (most of it)

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:32:38 +00:00
Anirudh Agnihotry 1e64bf5c1c Nullable Internal.Win32.RegistryKey (dotnet/coreclr#23856)
* anootated registrykey

* Fixing the build for windows

* Adding bang after the resize argument

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:28:33 +00:00
Krzysztof Wicher 6f07ebbfc6 Nullable: System.Resources (dotnet/coreclr#23830)
* nullable: system.resources

* apply feedback

* apply another feedback

* fix SR.cs after rebase

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:28:33 +00:00
Stephen Toub 074f8a9e6c Nullable: Attributes, SafeHandles, and misc (dotnet/coreclr#23810)
* Nullable: Attributes, SafeHandles, and misc

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:28:28 +00:00
Stephen Toub 7d9c1bc28d Nullable: System.IO (dotnet/coreclr#23732)
* Nullable: System.IO

Everything exception StreamReader, StreamWriter, BinaryReader, BinaryWriter, which are waiting for some changes in master to propagate over to the feature branch.

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:27:20 +00:00
Santiago Fernandez Madero c7abb47a8a Fix build errors with new compiler
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:27:19 +00:00
Krzysztof Wicher 62ab4ced87 Nullable: System.Text (dotnet/coreclr#23708)
* Nullable: System.Text

* apply feedback

* simplify second enc.Clone() call

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:27:15 +00:00
Tanner Gooding a7e61a0a10 Nullable: System.Runtime.InteropServices.Marshal (dotnet/coreclr#23699)
* Nullable: System.Runtime.InteropServices.Marshal

* Fixing the nullable annotations for BindToMoniker and GetObjectForIUnknown

* Fixing the nullability of PtrToStringAuto(IntPtr, int)

Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:26:04 +00:00
Anirudh Agnihotry a9193f4dc3 adding null annotations (dotnet/coreclr#23744)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:24:08 +00:00
Stephen Toub 2996c13498 Nullable: Array (dotnet/coreclr#23746)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:24:07 +00:00
Stephen Toub e329b82c14 Nullable: Span and friends (dotnet/coreclr#23734)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-22 16:24:06 +00:00
Jay Krell 800701fe3f Small step toward reduction/elimination of JIT icall hashing. (#14149)
Ultimate goal is to significantly reduce or maybe completely
eliminate the hashing of JIT icalls.

It is not a small change.

This is a small digestable albeit tedious step toward that.

The "names" of opcode emulation icalls are needed for
token pasting and/or struct fields. They are needed without quotes.

This PR removes the quotes.
And then for now, just always restores them.

This is extracted from https://github.com/mono/mono/pull/14047
as a step toward making it easier to review.
2019-04-22 11:04:32 +02:00
Vlad Brezae afc16a8733 [interp] Fix buffer overflow when incrementing sp
Fixes https://github.com/mono/mono/issues/14079
2019-04-21 10:06:34 +03:00
Alexander Köplinger 6b73e8db82 Bump monolite (#14144)
Looks like monolite was broken somehow. Rebuild it.
2019-04-20 00:35:18 +02:00
Larry Ewing 061fb88295 Merge pull request #14136 from kjpou1/wasm-function-tests
[wasm] Fix NRE WebAssembly.Core.Array during initialization
2019-04-19 16:08:12 -05:00
Aleksey Kliger (λgeek) 7ba1f77f6d [loader] Don't store through a null ptr (#14110)
* [loader] Dont't store through a null ptr

If 'status' is null, don't try to write to it.

Fixes https://github.com/mono/mono/issues/13941

* [metadata] Protect writes to MonoImageOpenStatus* in a few places.

When possible assert that `MonoImageOpenStatus *status` arguments to various
functions in the runtime aren't null.  There are a few places (MONO_API) where
it's possible that callers are passing null.  In that case, use a local
MonoImageOpenStatus, or check for null before doing assignments.
2019-04-19 15:57:31 -04:00
pedestrianlove 1bdffd21cb Make dedicated MonoError for mono_error_set_argument_out_of_range (#14119)
* Make dedicated MonoError for mono_error_set_argument_out_of_range
2019-04-19 12:13:21 -04:00
Jay Krell 435feaaa02 [Coop] Convert performance counters and performance counter categories. (#13623)
* Cut down on strlen calls.
But keep the shared memory format unchanged to match .NET. (i.e. don't
put string lengths in it).

* PR: MONO_ENTER_NO_SAFEPOINTS instead of gchandle.

Push/pop frames in loops and mind the return/goto/break/continue carefully, instead of using assignment.

*PR: Reduce gsize to adequate int, move multiple int declarations to same line.

* PR: Fix prototypes in disabled code.

* PR: Spell out `int` as `gint32`.

Use an uppercase guid to workaround Windows problem.

* A bit more true to the previous version.
* Reduce diff a little.
* if (is_ok()) around one line instead of goto around it.
* Restore some old code.
* Restore more verbosity, that used to have a point but no longer does.
2019-04-19 11:27:16 -04:00
Kenneth Pouncey 12aa4de4a7 Add tests for WebAssemlby.Core.Array initialization
- Add tests for WebAssembly.Core.Function
2019-04-19 13:21:35 +02:00
Kenneth Pouncey 02d72c7e85 Fix NRE WebAssembly.Core.Array 2019-04-19 13:20:31 +02:00
Zoltan Varga 84f6e1dfac [llvm] Avoid looking up intrinsics by name in most cases. (#14029)
[llvm] Avoid looking up intrinsics by name in most cases.
2019-04-19 04:15:54 -04:00
Tanner Gooding 54776b2541 Adding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128) (#24102)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-19 08:34:08 +02:00
Larry Ewing e0e3592c20 Merge pull request #14129 from lewing/sample-tfm
[wasm] Fix the samples target framework
2019-04-18 21:24:47 -05:00
Larry Ewing 45bf2cf557 Add a mixed target for sample 2019-04-18 21:05:13 -05:00
Katelyn Gadd d9c1f37780 Fix start-compiler-server (#14117) 2019-04-18 14:54:25 -07:00
Zoltan Varga f7dff29c6c [aot] Add a depfile= argument which causes the AOT compiler to write out a gcc style dep file listing the dependencies between the output file and all referenced assemblies. (#14124)
* [aot] Add a depfile= argument which causes the AOT compiler to write out a gcc style dep file listing the dependencies between the output file and all referenced assemblies.

* Add a manpage entry.

* Update after comments.
2019-04-18 16:41:47 -04:00
Larry Ewing 783f8e9c07 Fix the samples target framework 2019-04-18 14:49:35 -05:00
Larry Ewing eaba6c608c Merge pull request #14113 from vargaz/netcore-pinvoke
[wasm] Fix the types of the generated function declarations in the pinvoke table.
2019-04-18 11:43:09 -05:00
Thays Grazia bc2d8e7c92 Protecting boxing a null value (#14018)
When a static method is called the obj is not used, so it can be null and it doesn't need to be boxed.
Adding an assert in the method to prevent other crash in this method if a NULL is received.
2019-04-18 13:29:21 -03:00
Bernhard Urban dacee19252 [interp] disable tail call opt if managed debugger is enabled (#14098)
[interp] disable tail call opt if managed debugger is enabled 

Fixes https://github.com/mono/mono/issues/12981
2019-04-18 11:56:10 -04:00
Alexander Köplinger 9dcb8311ef [ci] Workaround races in the tests build (#14121)
We're still seeing some failing tests build sometimes.
2019-04-18 15:51:40 +02:00
Vincent Povirk 8c2d1829c1 Respect call convention modopts in native wrappers. (#14017)
MS's C++ compiler emits code that uses this.
2019-04-18 09:44:31 -04:00
Justin Needham a738d0e284 Update documentation for --with-large-heap
This Flags only applies to the Boehm GC
2019-04-18 13:59:27 +02:00
Johan Lorensson 90869d7708 Merge pull request #13931 from lateralusX/lateralusX/external-direct-icalls-symbol-name
Add support for direct icalls using external functions not in icall-def.h.
2019-04-18 06:20:54 -04:00
Jay Krell c7e5f4150b mono_remoting_marshal_init in mono_marshal_get_proxy_cancast to register icalls. (#14097)
Alternatively move the registration to mono_remoting_init.
2019-04-18 10:10:47 +02:00
Filip Navara 7e35b5128b [netcore] Fix failures in System.Tests.MulticastDelegateTests (#14096) 2019-04-18 08:39:31 +02:00
Egor Bogatov 61dbc22bfd [netcore] improve Windows support (#14100)
* better Windows support

* remove unzip.py

* move FeaturePortableTimer to csproj
2019-04-18 08:30:11 +02:00
Zoltan Varga 569be02071 [netcore] Fix the tests. (#14108)
* [netcore] Fix the tests.

* Fix Monitor class too.
2019-04-18 08:23:01 +02:00
Katelyn Gadd b043647c48 Adjust roslyn mcs dll deploy list based on #13755. Keep Tasks.Extensions and Memory because their facades are only deployed on mobile. 2019-04-18 08:21:31 +02:00
Larry Ewing 93c45bae27 Merge pull request #14088 from vargaz/wasm-direct-calls
[llvmonly] Allow direct calls to inflated methods since they can initialize themselves correctly now.
2019-04-17 17:55:00 -05:00
Larry Ewing 1cd911a844 Merge pull request #14041 from kjpou1/wasm-sdk-packages
[wasm] [sdk] Build and package the sdk nugets.
2019-04-17 17:32:27 -05:00
Zoltan Varga 9551e22ba9 [wasm] Fix the types of the generated function declarations in the pinvoke table. 2019-04-17 14:53:52 -04:00
Vlad Brezae 3f11315916 [interp] Small vt opcode optimisations (#14040)
[interp] Simplify cpobj.vt

[interp] Optimize stelem.vt/ldelem.vt

[interp] Avoid unnecessary write barrier for ldobj.vt
Write barriers are only required for stores in the major heap/los.

[interp] Simplify ldfld.vt/stfld.vt
2019-04-17 20:47:48 +02:00
Vlad Brezae 183de1c302 [interp] Improve boxing/unboxing (#14048)
* [interp] Remove redundant check

It can't be an enum if it is stored on the vtstack

* [interp] Optimize boxing

Makes boxing of primitives 4x faster and boxing of vt 3x faster.

* [interp] Remove unneccessary check in unbox

We do the same check as jit. Makes unboxing 10x faster.

* [interp] Extract some duplicate code for boxing

* [interp] Fix boxing of nullable with constrained calls

Before the box opcode optimization, it was handling nullable. When normally boxing a nullable we call the Box method, but this is awkward when doing a constrained call, so we just add a separate opcode. This is slightly slower than calling Box, but much faster than the old code using the generic mono_value_box_checked.
2019-04-17 21:38:19 +03:00
lateralusX c31b4dd5b4 Review feedback. 2019-04-17 17:04:08 +02:00
Egor Bogatov afcd30d8c2 [netcore] Fix two System.Tests.PseudoCustomAttributeTests tests (#14073)
Now all custom attribute related tests pass in System.Runtime.Tests.
Also this PR fixes broken acceptance tests for regular mono introduced in https://github.com/mono/mono/pull/13809
2019-04-17 16:39:38 +02:00
Vlad Brezae 1b4a2a68f5 [interp] Fix interp strmfld vt (#14086)
* [interp] Fix store remote value type field

Looks like the culprit for some random mcs tests failures

* [interp] Delete dummy code
2019-04-17 16:40:07 +03:00
Jay Krell d882ea388a Replace two element hash table with two element array and cheap linear search. (#14049)
Replace two element hash table with two element array and cheap linear search.

Maybe I misunderstand the code?
Or significant expansion is expected?
2019-04-17 05:06:28 -04:00
Jay Krell cd5e14a3cc Factor the function mono_call_add_patch_info out of a few lines of repeated code in many backends. (#13970)
This notably does not apply to amd64, x86.
They have more logic intertwined around the patch when they emit the call.
2019-04-17 09:41:54 +02:00
Zoltan Varga 9e10afd3d6 [netcore] Create netcore specific versions of refsource classes. (#14074) 2019-04-17 08:56:16 +02:00
Zoltan Varga 605ea1555c [llvmonly] Add stubs for methods which cannot be compiled since they can be called directly. 2019-04-16 19:44:28 -04:00
Jay Krell 6a39d91078 Remove a few string allocs/copies, i.e. for generic trampoline names. (#14038) 2019-04-17 00:37:10 +02:00
Bernhard Urban 98a1d40584 [arm] align stack pointer in throw trampoline (#14078)
This is a regression introduced by e46fa20466

Fixes https://github.com/mono/mono/issues/13672
2019-04-17 00:36:05 +02:00
Zoltan Varga 08f4d74daf [wasm] Only aot with interp support when in mixed mode. 2019-04-16 16:40:17 -04:00
Zoltan Varga 61d6860f21 [llvmonly] Make direct calls to more methods, not enabled yet. 2019-04-16 16:39:21 -04:00
Zoltan Varga d257f7a663 [aot] Prepend the assembly name to the mangled method names. 2019-04-16 16:38:52 -04:00
Zoltan Varga 3ef6463a03 [netcore] Allow cross-module direct calls to alloc wrappers. 2019-04-16 14:55:05 -04:00
Filip Navara e10034c1ff Update CustomAttributeExtensions to call Attribute class to get proper parameter validation. Fixes System.Reflection.Extensions.Tests. 2019-04-16 19:35:35 +02:00
Marek Safar 3c2025bb58 Reflect shared partition changes 2019-04-16 19:24:43 +02:00
Filip Navara d5a4f9b8a9 Move EventSource to shared CoreLib partition (dotnet/coreclr#23925)
* Move most of EventSource to shared CoreLib partition

* Reenable some code that can be shared with Microsoft.Diagnostics.Tracing.EventSource.Redist in CoreFX

* Remove unused functions

* Fix placement of #endregion

* Clean up P/Invoke prototypes

* Move remaining code from EventSource_CoreCLR to shared partition (guarded by !CORERT)

* Remove more unnecessary marshalling attributes

* Move remaining CoreRT/ProjectN code to shared partition

* Avoid using Windows errors on non-Windows platforms

Signed-off-by: dotnet-bot <[email protected]>
2019-04-16 19:24:43 +02:00
Zoltan Varga b71e29a62d [llvmonly] Allow direct calls to inflated methods since they can initialize themselves correctly now. 2019-04-16 13:19:19 -04:00
Zoltan Varga 1c568bf16f [aot] Change how the context is computed in init_aot_method (). Instead of (#14026)
getting it from the caller, save it in the aot image and read it back.
This will make it possible to emit direct calls to gshared methods later.
2019-04-16 11:30:16 -04:00
Jay Krell 18f0bf055e Register mono_gc_wbarrier_generic_nostore_internal regular with its own name, not dynamic with a special name. (#14042) 2019-04-16 13:34:46 +02:00
Jay Krell 6225a9b031 Register g_free icall regular, as monoeg_g_free. (#14044)
The point here is that register_dyn is a bit obscure and could use clarification.
2019-04-16 13:34:29 +02:00
Egor Bogatov 8cd9b562ea [netcore] Fix WaitHandle.SignalAndWait (#13809)
* fix failing tests

* Add build-corefx-test-for- rule

* Update WaitHandle.cs

* fix S.T.T.rsp file

* fix build

* bump corlib version

* handle new errors in old mono

* Update w32handle.c
2019-04-16 12:04:02 +02:00
Egor Bogatov d2054f6cc0 [netcore] Fix System.Tests.PseudoCustomAttributeTests.* tests (#14065)
* fix Custom Attribute tests

* fix CA

* fix CA

* Update MonoCustomAttrs.cs

* fix MarshalAsAttribute

* Update MarshalAsAttribute.cs

* Update MarshalAsAttribute.cs
2019-04-16 11:51:26 +02:00
Zoltan Varga edae380da5 [netcore] Add linker descriptor for corelib. (#14064)
* [netcore] Add linker descriptor. This is just a copy of the mscorlib descriptor.

* [netcore] Update linker descriptor for netcore.

* Remove com/remoting related classes.
* Other smaller changes.

* [netcore] Allow loading corlib from MONO_PATH.

* Update System.Private.CoreLib.xml
2019-04-16 11:48:12 +02:00
Levi Broderick 7ae2e1e769 Fix incorrect bit match pattern in UTF-16 validation (dotnet/coreclr#24015)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-16 11:27:33 +02:00
Jan Kotas d99f005b4b Fold ResourceSet::CommonInit into constructor (dotnet/coreclr#23993)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-16 11:27:33 +02:00
Egor Bogatov 128aec0590 Add "partial" to MarshalAsAttribute (dotnet/coreclr#24014)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-16 11:27:33 +02:00
Jan Kotas 31b890bd2e Remove redundant UnderlyingSystemType calls (dotnet/coreclr#24000)
UnderlyingSystemType is virtual

Signed-off-by: dotnet-bot <[email protected]>
2019-04-16 11:04:44 +02:00
Kenneth Pouncey aa01f6fb75 Add sdk package solution to be built by dotnet command. 2019-04-16 09:19:35 +02:00
Filip Navara fbac2cb6f0 [netcore] Fix couple of custom attribute tests (#14063)
* Revert "[netcore] fix some CustomAttribute related tests (#14056)"

This reverts commit b1af4c2726.

* Add parameter validation to Attribute.GetCustomAttribute

* Fix indentation
2019-04-16 08:10:54 +02:00
Kenneth Pouncey 81b0163bca Merge branch 'master' of https://github.com/mono/mono into wasm-sdk-packages 2019-04-16 05:20:44 +02:00
Kenneth Pouncey eb98d562b0 [wasm] [packager] Run mono-cil-strip from wasm-tools (#14035)
* [wasm] Add mono-cil-strip to the wasm tools build

* Run mono-cil-strip.exe from tools.
2019-04-16 04:55:29 +02:00
Zoltan Varga 9d91df98df [llvmonly] Fix a buffer overflow. (#14057) 2019-04-15 19:23:05 -04:00
Bernhard Urban 9ff3b0d65e [aot] change method table generation so that it works for larger assemblies on ARM (#14043)
[aot] change method table generation so that it works for larger assemblies on ARM

At the end of the AOT compilation, we dump a table containing all method
entrypoints using the toolchain linker to resolve the addresses. Previously
we used `bl` for that, however on larger assemblies the offset might
overflow the 24bit immediate (thus, the linker bailing out with
"Error: branch out of range"). Instead, using `ldr pc,=<label>` followed
by `.ltorg` emits the full 32bit address to a method. That takes 8 bytes
for each method instead of 4 bytes.


( I couldn't reopen https://github.com/mono/mono/pull/3486 anymore)
2019-04-15 18:25:51 -04:00
Egor Bogatov b1af4c2726 [netcore] fix some CustomAttribute related tests (#14056)
* fix CA

* fix CA

* remove redundant checks

* remove redundant checks
2019-04-15 19:06:52 +02:00
Filip Navara 30e947a667 Fix stack overflow introduced in 012ac05aa9 2019-04-15 16:59:08 +02:00
Filip Navara 012ac05aa9 [netcore] Misc. fixes (#14050)
* Check for lower bounds on non-zero-based arrays

* Grab correct version of System.Reflection.Context

* Move Attribute type validation to fix checking for custom attributes using interface types

* Fix parameter checks
2019-04-15 15:02:47 +02:00
Vlad Brezae 79f15ccd35 [interp] Static field access fixes (#14009)
* [interp] Further optimize static vt field access

We don't require any write barrier checking since we always copy between interpreter vt_stack and static data. We can also include the vt size in the code stream. Makes it over 1.5x times faster.

* [interp] Fix static field access using ldfld/stfld

Static field access using the ldfld/stfld instructions was not updated when stsfld/ldsfld were optimized.

* [interp] Fix special static vtype field access
2019-04-15 15:35:34 +03:00
Kenneth Pouncey a487fb83b6 use dotnet instead of msbuild 2019-04-15 14:25:52 +02:00
Filip Navara 8c85c29841 [netcore] Switch to msbuild nuget which is available for all platforms (#13989)
* Switch to msbuild nuget which is available for all platforms

* Remove check-env rule dependency

* Add missing reference to System.Composition.TypedParts

* Sort references by name
2019-04-15 11:30:46 +02:00
Kenneth Pouncey 58196e1aab [wasm] [sdk] Build and package the sdk nugets. 2019-04-15 10:26:58 +02:00
Marco Rossignoli 64799bb439 improve entropy (dotnet/coreclr#23591)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-15 08:53:55 +02:00
Egor Bogatov 2a8028f7ce [netcore] Do not inline if [DynamicSecurityMethod] exists (#14032)
* fix crash

* fix build
2019-04-15 08:34:23 +02:00
Raz Friman 791139bead Remove unused offset calculation (dotnet/coreclr#23793)
Utf8Parser has a redundant calculation of date time offset.

Fix #21834

Signed-off-by: dotnet-bot <[email protected]>
2019-04-15 08:32:36 +02:00
Levi Broderick daa940339c Remove old method names from Rune (dotnet/coreclr#23938)
* Remove old method names from Rune, reenable suppressed tests

* Revert re-enablement of failing ArraySegment tests

Signed-off-by: dotnet-bot <[email protected]>
2019-04-15 08:32:36 +02:00
Jay Krell cfdcf29478 Remove redundant check of llvm_acfg->aot_opts.direct_icalls. (#14028) 2019-04-14 15:58:17 -04:00
Filip Navara 7ac572217d [netcore] Make System.Private.CoreLib and host APIs compilable on Windows (#13943)
* Fix Windows builds of CLR hosting API

* Make System.Private.CoreLib compilable on Windows

* Remove accidental change

* Fix Unix build

* Update GlobalizationMode.cs

* Update GlobalizationMode.Unix.cs
2019-04-14 18:58:40 +02:00
Jay Krell 568c822ae9 Remove constant parameter to mono_tls_get_tls_setter and mono_tls_get_tls_getter. (#13894)
It doesn't matter, but for code clarity.
Also strengthen the types of both of these, though rarely enough to avoid casts.
2019-04-14 16:24:18 +02:00
Marek Safar 233f5ad096 Reflect shared partition changes 2019-04-14 15:54:18 +02:00
Jan Kotas 30d94ae529 Fix AssemblyName regression
Signed-off-by: dotnet-bot <[email protected]>
2019-04-14 15:54:18 +02:00
Jan Kotas 1baa703c92 Move GCMemoryInfo to shared partition
Signed-off-by: dotnet-bot <[email protected]>
2019-04-14 15:54:18 +02:00
dotnet-maestro-bot 592dac20f9 Update BuildTools, CoreClr to preview4-03913-01, preview5-27612-73, respectively (master) (#23916)
* Update BuildTools, CoreClr to preview4-03913-01, preview5-27612-73, respectively

* Fix nullable build errors

Signed-off-by: dotnet-bot <[email protected]>
2019-04-14 15:54:18 +02:00
Jan Kotas 88c35b4974 Delete unused AssemblyName._hashForControl and related code (#23972)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-14 15:54:18 +02:00
Steve MacLean 64c0733212 EnterContextualReflection handle null (dotnet/coreclr#23953)
* EnterContextualReflection handle null

* Add ContextualReflection MockAssembly test

* Fix ContextualReflection typo

Signed-off-by: dotnet-bot <[email protected]>
2019-04-14 15:54:18 +02:00
Jan Kotas a49d96b057 Delete outdated comment
Signed-off-by: dotnet-bot <[email protected]>
2019-04-14 15:54:18 +02:00
Filip Navara b672c05ad0 Move DateTime Windows implementation to shared CoreLib (#23888)
* Move DateTime Windows implementation to shared CoreLib

* Make all the BOOL/struct marshalling explicit

* internal -> private

* Use unsafe code on all layers, remove unnecessary fixed blocks

Signed-off-by: dotnet-bot <[email protected]>
2019-04-14 15:54:18 +02:00
Jan Kotas 13183af5c3 Delete COMPlus_FinalizeOnShutdown (dotnet/coreclr#23595)
This compat quirk is increasingly more broken since the framework is generally not compatible with, and we have not heard anybody actually using it.

Changed Environment.HasShutdownStarted to unconditionally return false. It does not make sense for it to ever return true with shutdown finalization disabled.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-14 15:44:21 +02:00
Kenneth Pouncey a26c8bca81 Updating to recent sdk 1.38.30. (#14023)
osx binaries are now available.

```

touch .stamp-wasm-checkout-and-update-emsdk
cd /Users/Jimmy/websharp/projects/mono/sdks/builds/toolchains/emsdk && ./emsdk install sdk-1.38.30-64bit
Fetching all tags from Emscripten Github repository...
Done. 158 tagged releases available, latest is 1.38.30.
Fetching all tags from Binaryen Github repository...
Done. 85 tagged Binaryen releases available, latest is 1.38.30.
Fetching all precompiled tagged releases..
Downloading: /Users/Jimmy/websharp/projects/mono/sdks/builds/toolchains/emsdk/llvm-tags-32bit.txt from https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/tag/osx_32bit/index.txt
Downloading: /Users/Jimmy/websharp/projects/mono/sdks/builds/toolchains/emsdk/llvm-tags-64bit.txt from https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/tag/osx_64bit/index.txt, 2629 Bytes
Downloading: /Users/Jimmy/websharp/projects/mono/sdks/builds/toolchains/emsdk/upstream/lkgr.json from https://storage.googleapis.com/wasm-llvm/builds/linux/lkgr.json, 4641 Bytes
Installing SDK 'sdk-1.38.30-64bit'..
Installing tool 'clang-e1.38.30-64bit'..
Downloading: /Users/Jimmy/websharp/projects/mono/sdks/builds/toolchains/emsdk/zips/emscripten-llvm-e1.38.30.tar.gz from https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/tag/osx_64bit/emscripten-llvm-e1.38.30.tar.gz, 318164889 Bytes

```
2019-04-13 06:08:18 -04:00
dotnet-maestro[bot] 3e19f1b052 Update dependencies from dotnet/corefx (dotnet/coreclr#23893)
* Update dependencies from https://github.com/dotnet/corefx build 20190411.2

- Microsoft.NETCore.Platforms - 3.0.0-preview5.19211.2
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19211.2

* Update dependencies from https://github.com/dotnet/corefx build 20190411.22

- Microsoft.NETCore.Platforms - 3.0.0-preview5.19211.22
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19211.22

* Removing renamed HWIntrinsic APIs from S.P.Corelib

* Updating the hwintrinsiclistxarch to match the new intrinsic API names

* Updating the HWIntrinsic generated tests to use the new API names

Signed-off-by: dotnet-bot <[email protected]>
2019-04-13 08:13:39 +02:00
monojenkins 21d82e7d0b [bcl] Update BCL Linked Size 2019-04-13 08:09:56 +02:00
Marek Safar cc5886e3d5 Reflect shared partition changes 2019-04-12 23:45:22 +02:00
Steve MacLean 28e5883c8d Contextual reflection (dotnet/coreclr#23740)
* Add ContextualReflection APIs

Add ContextualReflection APIs approved in dotnet/corefx#36236
Fix issue #22213

* SetParentAssembly even when IsCollectible()
* ContextualReflection tests

* PR Feedback
* Add more usage tests

Add using statement tests
Add bad usage tests including Assert.Throws<>

* Only initialize on set
* Add XML API comments
* Unify VerifyIsolation
* Fix unused expectedAssembly
* Remove ContextualReflectionScope throw
* Clean up TestResolveMissingAssembly et. al
* Remove unused QCall::AppDomainHandle
* Remove AppDomainBaseObject
* Pass AssemblyLoadContext as managed object to native
* Fix AssemblyLoadContextBaseObject packing

* AssemblyLoadContext backing stores

Use explicit backing stores for events and properties

* Remove StaticAsyncLocalCurrentContextualReflectionContext
* Remove PermissionSetObject

Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 23:45:22 +02:00
Egor Bogatov 1fc8151c7c Move AssemblyName to shared (dotnet/coreclr#23737)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 23:45:22 +02:00
Ludovic Henry 1271a16b46 Make GC.GetGCMemoryInfo public (dotnet/coreclr#23779)
* Make GC.GetGCMemoryInfo public

This is to be used to allow users to optimize memory consumption based
on what's available to the GC and on the system.

This is based on https://github.com/dotnet/corefx/issues/34631

* Address reviews

- Pass GCMemoryInfo struct to native in place of many arguments
- Make GCMemoryInfo.HeapSize and GCMemoryInfo.Fragmentation long in place of IntPtr

* Address reviews

- Mark GCMemoryInfo readonly

* Rearrange fields and match managed/native names

* Fix compilation

* Use getter shorthand

* Address API Design Review

https://github.com/dotnet/corefx/issues/34631#issuecomment-481358549

* Fix comments

* Fix comments

* Do everything in managed

* Address review

 - Remove unecessary [StructLayout.Sequential]
 - Remove "_" prefix for parameters variables

Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 23:45:22 +02:00
Tarek Mahmoud Sayed 79ee7156df Update Range.GetOffsetAndLength (dotnet/coreclr#23855)
* Update Range.GetOffsetAndLength

Make it return offset and length tuple instead of the old Type Range.OffsetAndLength

* Fix the return Tuple fields names

Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 23:45:22 +02:00
Tanner Gooding 608be919cb Tweaking some APIs according to user feedback. (dotnet/coreclr#23857)
* Updating the Avx2.ConvertToVector256UInt APIs to return a signed type (matching the native signature and Sse41 APIs).

* Adding explicit overloads for `Sse41.ConvertToVector128Int*` and `Avx2.ConvertToVector256Int*` that take a pointer

* Updating the word ordering for the Compare/CompareScalar methods.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 23:45:22 +02:00
Sung Yoon Whang 28c375e962 Expose new EventCounter APIs (dotnet/coreclr#23808)
* rename BaseCounter to DiagnosticCounter

* Change MetaData->Metadata

* Make EventSource and Name a property for counter classes

* Make the counter APIs public

* fix build errors

* Change float to double

* Few cleanups, fix test

* fix GetMetadataString

* PR feedback

* More PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 23:45:22 +02:00
Jan Kotas 261191886e Disable nullability-related warnings
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 23:45:22 +02:00
Vlad Brezae e30e45f94b [interp] Optimize ldobj/stobj (#13761)
* [interp] Remove dead code

It doesn't make sense to dereference a value type

* [interp] Emit faster instructions for ldobj

* [interp] Emit faster instructions for stobj

* [interp] Simply ldobj vt

This makes it 10x faster

* [interp] Make ldind.r8 unaligned friendly
2019-04-12 21:50:05 +03:00
Levi Broderick e3dd143a5d Clarify comment in 3-byte processing
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 585f55636a Add missing check to 3-byte processing logic
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 51bac6357b PR feedback: Clarify 3-byte sequence processing
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 5246c85995 Fix compilation failure in Utf16Utility
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick d0ec53204d PR feedback: document tempUtf8CodeUnitCountAdjustment usage
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 5034af7331 PR feedback: Clarify charIsNonAscii vector usage
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 02505b8dbd PR feedback: Validate nint definitions
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 94bd111713 PR feedback: Remove redundant endianess checks
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick a92e26d2b4 PR feedback: CountNumberOfLeadingAsciiBytesFrom24BitInteger
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick e1d5e9f79e PR feedback: Fix typos
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 5f292a145d Re-flow Utf8Utility.Helpers
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 445efebc58 Rename DWORD -> UInt32 throughout API surface
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 7bb04786ec Add comments tracking JIT workarounds.
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick d015b30937 Fix incorrect Debug.Assert statements
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick f241bc0016 Expand masks in Utf8Utility, fix const in fallback path
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 9f2d23cf50 PR feedback: Enable SSE2 in Utf16Utility code
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick d7feacf303 PR feedback - Simplify CountNumberOfLeadingAsciiBytesFrom24BitInteger - Extract some consts out to top of file w/ comments
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 4d112e6ef1 PR feedback: GetElement(0) -> Sse2.StoreLow
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 2ecf1e7a20 Simplify vectorized logic; remove unnecessary adjustment
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick f2e4d316e7 Clarify that vector read is unaligned
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 639df30083 Remove SSE41.X64 optimization from AsciiUtility RyuJIT now handles this optimally
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 5a17d4224b Improve perf of "is ASCII?" inner loop in UTF-8 validation.
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick 77863a7ab0 Hook up new UTF-8 logic through UTF8Encoding - Add vectorized UTF-16 validation and transcoded byte counts - Move Utf16Utility into Unicode namespace alongside Utf8Utility - Fix some bugs in DecoderNLS's draining logic
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Levi Broderick a86f468670 Add optimized UTF-8 validation and transcoding logic - Hook it up through the existing Utf8 public static APIs - Move some shared methods out of ASCIIUtility - Hook it up through the Utf8String ctor
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Steve MacLean 9501ef8cfb Fix Assembly.LoadFromPartialName(string) (dotnet/coreclr#23912)
Assembly.LoadFromPartialName(string) should not throw FileNotFoundException, but
should rather return null.

ArgumentException should use nameof(partialName)

Fixes #19817

Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Stephen Toub 23b6c94d58 Fix Version's comparer operators to allow null (dotnet/coreclr#23898)
Previously for `<`/`<=` it would throw if `v1` argument was null, but for `>`/`>=` would throw if the `v1` argument was null, albeit using `v1` in the exception parameter name.  It's also not expected for comparisons like this to throw, in general.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Filip Navara 2e480766b3 Move TimerQueue.TickCount Windows implementation to shared CoreLib (#23838)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 19:22:35 +02:00
Alexander Köplinger b1c39e4e3d [corlib] Disable FileTest.SymLinkStats() on TVOS
Symlinks on TVOS run into sandboxing restrictions. We've already disabled a similar test.

This test was added recently as part of 26e0b1deec.

(cherry picked from commit b85fdbdb10)
2019-04-12 14:27:41 +02:00
Jay Krell 22bbf4416a Increase gsharedvt trampolines by 10% from 4000 to 4400.
There are many minor arguments here.

Where this matters most -- iOS -- the pool is already dynamic.

Other platforms could use a dynamic pool or JIT (despite FullAOT).
Using JIT would defeat the test coverage.

Mitigates https://github.com/mono/mono/issues/13888.
If this feels too tenative, go bigger.
2019-04-12 08:30:15 +02:00
Maxim Lipnin ded4fa6558 [w32error] Add ENONET error case 2019-04-12 08:29:02 +02:00
Santiago Fernandez Madero 990a90fea0 Add back using to EventSourceException
Signed-off-by: dotnet-bot <[email protected]>
2019-04-12 08:15:02 +02:00
Maxim Lipnin 3657c0239a Remove #if-def for TypedReference.MakeTypedReference readonly restriction 2019-04-12 08:07:07 +02:00
Kenneth Pouncey 0d6f7a9e6f Add tests for past issues to catch regressions. (#13981)
- Add IssuesTestSuite to test suite make build.
- Add new issues spec and test calls.
2019-04-12 04:55:14 +02:00
Jo Shields a7c7f903f3 Merge pull request #13998 from directhex/extradist_20190411
[netcore] hand-craft a dist-recursive rule for System.Private.CoreLib
2019-04-11 15:15:29 -04:00
Jo Shields 40e7b26702 [netcore] hand-craft a dist-recursive rule for System.Private.CoreLib
`make dist` stopped erroring in #13961 but didn't actually work, because
the relevant Makefile.am was not distributed, causing configure to fail
(because the Makefile.am was cited as an input, unconditionally).

We can't rely on the dist-recusrive from library.make or build.make because
this lib is in a weirdo format which doesn't comply with the requirements
of those helpers, so craft a simple handwritten replacement for our special
case
2019-04-11 11:04:01 -04:00
Zoltan Varga 5036336df8 [jit] Make dlmalloc use mono_valloc so it picks up the MAP_JIT flag on osx. (#13979)
Fixes https://github.com/mono/mono/issues/13878.
2019-04-11 09:19:42 -04:00
Miguel de Icaza 56db577988 [debugger-agent]: Print error if the socket can not be created, remove assert that probed the wrong value, Coverity 1307166 (#13860) 2019-04-11 09:38:17 -03:00
Zoltan Varga 1a76a455a7 Add missing DynamicSecurityMethod attributes. 2019-04-11 11:21:02 +02:00
Zoltan Varga 8b1a18784d [jit] Disable inlining for methods with [System.Security.DynamicSecurityMethod], its used to make methods which contain a StackCrawlMark.
Also check that the attribute is present for StackMaekMark locals.
2019-04-11 11:21:02 +02:00
Marek Safar 995bbb998c Merge pull request #13815 from radical/nuget-5
[nuget] Bump to nuget 5.0.0
2019-04-11 11:08:41 +02:00
Alexander Köplinger ec045a52b0 [cil-strip] Fix reading of undefined NativeType values in old Cecil (#13954)
cil-strip crashed when processing this method: https://github.com/mono/corefx/blob/f54e64b341a7b114c3502e197b46670cacb28639/src/Microsoft.CSharp/tests/DefaultParameterTests.cs#L88

It uses `MarshalAs((UnmanagedType)2000)`, i.e. an undefined value for the native type. The old Cecil embedded in cil-strip tried to read more than one byte which blows up in this case.

Upstream Cecil just reads a single byte:
https://github.com/jbevain/cecil/blob/1b79b96d29f1e8e9ba832191b1b42ea9cb750d20/Mono.Cecil/AssemblyReader.cs#L3700-L3703

Fixes https://github.com/mono/mono/issues/13639
2019-04-11 11:08:25 +02:00
sancheolz 4eb4173b57 [WinForms] Fix displayed image in TreeNode when ImageIndex set to -2
When ImageIndex in TreeNode set to -2 must not displayed any image
2019-04-11 10:51:59 +02:00
Filip Navara 8ba5a5201f [netcore] Implement Assembly.GetExecutingAssembly with stack mark parameter (#13903)
* Implement Assembly.GetExecutingAssembly with stack mark parameter

* Address PR feedback
2019-04-11 04:31:22 -04:00
Filip Navara 847296f1f0 [netcore] Fix marshalling of ref ptr return types (#13914)
* Fix marshalling of ref ptr return types

* Revert assert -> exception change
2019-04-11 04:31:11 -04:00
Filip Navara a26f73dcd9 Do not crash the runtime in System.Reflection.Emit.ILGeneration tests (#13917) 2019-04-11 04:30:59 -04:00
Johan Lorensson 562ac284e4 Merge pull request #13959 from filipnavara/link-windows
[windows] Link libgcc statically on Windows
2019-04-11 04:18:47 -04:00
Patrik Švikruha 49cc696bd7 fix link in README.MD
fix link to WebAssembly packager.exe in README.MD
2019-04-11 09:50:26 +02:00
Maxim Lipnin 068e8fe042 Use DNS.GetHostAddressesAsync instead of sync version (#13949)
Fixes #13163
2019-04-11 09:07:14 +02:00
Johan Lorensson 0c1489b836 Merge pull request #13946 from lateralusX/lateralusX/merge-icall-hash-maps
Merge icall_hash and icall_hash_foreign into one.
2019-04-11 02:58:59 -04:00
Kenneth Pouncey e0eff41f9e Add generated xml doc to sdk build. (#13965)
- Add the WebAssembly.Bindings.xml to the package.
- Add the WebAssembly.Net.Http.xml to the package.
2019-04-11 07:36:56 +02:00
Kenneth Pouncey 75d74f2eb6 [wasm] Revert Update to emscripten 1.38.30 https://github.com/mono/mono/pull/13759 (#13964)
- 1.38.30 is still not available for mac:
2019-04-11 05:01:36 +02:00
Thays Grazia bf8d7ef448 Cleaning exceptions during static constructor loading (#13962)
Cleaning exceptions during static constructor loading

Reset the stack_trace and trace_ips because the type initialization exception is reused.
Fixes #13714
2019-04-10 18:25:49 -04:00
Jo Shields 9d4d20b389 Merge pull request #13976 from directhex/another-llvm-symbol
Add another symbol for loadedllvm
2019-04-10 15:46:09 -04:00
Jo Shields 8fa16b329c Add another symbol for loadedllvm
Closes https://github.com/mono/mono/issues/13974
2019-04-10 15:45:30 -04:00
Alexander Köplinger 39e5c5f057 [corlib] Disable a ParameterInfoTest test on MONOTOUCH
It needs SRE and even with interpreter config this doesn't work yet.

(cherry picked from commit 766b3204c3)
2019-04-10 21:00:20 +02:00
Marek Safar c10e8da1b5 Merge pull request #13972 from filipnavara/netcore-nullability
[netcore] Disable nullability-related warnings
2019-04-10 19:08:07 +02:00
Marek Safar e1164a8dbd Merge pull request #13963 from Dotnet-GitSync-Bot/mirror-merge-10135517
Mirror changes from mono/corefx,coreclr,corert
2019-04-10 19:07:08 +02:00
Jo Shields fd8598a994 Merge pull request #13973 from directhex/netcore-pipeline
[netcore] Add a Pipeline yaml for Core build
2019-04-10 12:44:50 -04:00
Jason Imison c16b4cff44 [MacSDK] Bump F# to 4.5 (#10919)
* Use a custom prefix instead of trying to infer it, which doesn't work under bockbuild.

The following line is problematic in the scope of building the Mac SDK package (using bockbuild):

https://github.com/fsharp/fsharp/blob/ccfccbacfdb16b2ab143cf83f5ece20f738fd864/mono/config.make#L5

It's problematic because where `mono` lives in this case would be something like `/macsdk-staging-dir/bin/mono` which is not the actual prefix (prefix here being the final destination, `/Library/Frameworks/Mono.framework/...`) but a staging area that bockbuild uses (this is how we build on system prefixes without installing on CI)

For the F# build, bockbuild expects things to end up  in `/fsharp-staging-dir/$(prefix)` (because that's what most `make install`s do when given `DESTDIR=/fsharp-staging-dir/`). If things end up in _any other_ directory in `/fsharp-staging-dir/`  (like `/fsharp-staging-dir/macsdk-staging-dir` in our case) that would cause us to miss packaging those files (this has happened before, with packages that have broken or different use of `DESTDIR`). So there is an added write-protection for anywhere in `/fsharp-staging-dir` that *isn't*  `/fsharp-staging-dir/$(prefix)` , because a write-protection error, while obtuse, is much preferable to missing the fact that some files are not packaged (as would have happened here)

So the fix is to stop trying to infer the prefix, and return to providing it explicitly to the build system (this used to be the case via the `configure` step)

* Also, if we are doing an override of the 'make' command, we need to take care of passing DESTDIR ourselves too

* Since now we perform 'make install' on the make step, make the 'install' step into a no-operation.

* Look for sn where mono is, not in the final destination (which again, may not be the same)
2019-04-10 12:35:44 -04:00
Jo Shields 08a8880ddd Merge pull request #13961 from directhex/makedist_again
[netcore] Fix `make dist`
2019-04-10 12:08:11 -04:00
Jo Shields 992b0249f0 [netcore] Add a Pipeline yaml for Core build 2019-04-10 11:33:20 -04:00
Filip Navara 226d5a0885 Disable nullability-related warnings 2019-04-10 17:31:39 +02:00
Johan Lorensson b016a0a945 Make nullable embedding API's public. (#13950)
Currently we have two nullable API's that will have value in the public
embedding API (already requestsed by users), eliminating the needs to go
from native->managed and back to get nullable information about a type.

mono_class_is_nullable
mono_class_get_nullable_param

This PR moves them from class-internals.h into class.h and mark them
with MONO_API and when needed include GC UNSAFE/SAFE transition.
2019-04-10 11:29:00 -04:00
Alexander Köplinger e8caaa1dbd [configure] Add failsafe for missing submodules (#13957)
GitHub provides a way to download a .zip/.tar.gz of the repository content in their UI, however the archive doesn't contain git submodules.

The mono build then fails with confusing "missing file" errors.

Since GitHub doesn't let us disable the archive download we should at least add some logic to detect this broken case and bail out.
2019-04-10 15:26:28 +02:00
Alexander Köplinger 183b22b4db [System.Net.Http] Make some tests specific to HttpClientHandler
Otherwise they throw PNSE on e.g. WatchOS.

(cherry picked from commit 0b6dbfa349)
2019-04-10 15:03:50 +02:00
Martin Baulig 22c6ed3f1c Add conditionals allowing some calenders to be disabled. (#13730)
Add `GlobalizationMode.Invariant` conditionals to some calendar code.

This allows the Japanese, Taiwan and Hebrew calendars to be disabled.
2019-04-10 13:44:11 +02:00
lateralusX dd2d363e76 WASM driver uses incompatible signatures for icall lookup.
uses_handles parameter is a gboolean -> int32_t in Mono but was uint8_t
in WASM implementation. This triggered a problem when a uninitialized
gboolean was used and only parts of it got set and method still returns
an address, indicating success. This is a different behavior compared to
Mono's default implementation. Fix to this particular problem was to init
the gboolean variable before calling, but good to make sure the signatures are in
sync anyways.
2019-04-10 10:16:32 +02:00
lateralusX 18bba37796 Merge icall_hash and icall_hash_foreign into one.
icalls registered with mono_add_internal_call, mono_add_internal_call_with_flags
or mono_add_internal_call_internal ended up in two different hash tables
depending if they were "foreign" or not. This caused double lookups in
mono_lookup_internal_call_full. There are also use cases where it could be
interesting to keep additional flags related to the icall, that could be
used by codegen for various optimization.

This PR merge the two hash tables into one and add a flag describing icall
details. The flag could later be extended with additional behaviors going
forward if needed.
2019-04-10 10:10:27 +02:00
Aleksey Kliger 72c8776d8f [utils] stub mono_setmmapjit on Win32 and Wasm 2019-04-09 17:35:35 -04:00
Miguel de Icaza bc4a1ac85a Do not use MAP_JIT by default, instead make this something that is toggled by Xamarin.Mac which needs it 2019-04-09 17:35:35 -04:00
Jan Kotas c828db526f Update CoreRT for changes in shared partition
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:31:08 -07:00
Stephen Toub 84b81ac290 Improve RuntimeHelpers.GetSubArray (dotnet/coreclr#23829)
* Improve RuntimeHelpers.GetSubArray

This change does three things.

First, it fixes `GetSubArray` to work when the supplied array is actually a `U[]` where `U : T`.  Currently this case ends up throwing an exception inside of span, which doesn't like working with arrays covariantly.

Second, it fixes argument validation so that we throw an ArgumentNullException if the input array is null rather than NullReferenceException.

Third, it improves the performance of `GetSubArray` for the 95% common case where either `T` is a value type or the type of the array matches the `T` type specified.

* Only use `Array.Empty<T>` when `typeof(T[]) == array.GetType()`

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:26 -07:00
Stephen Toub 2570c11ec4 Fix two new nullable warnings with latest compiler
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:26 -07:00
Hugh Bellamy 727ff4b34d Remove remaining devdocs and cleanup ComponentModel code (#23175)
* Remove remaining devdocs and cleanup ComponentModel code

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:25 -07:00
Jeremy Koritzinsky 6a5487c8e1 Match PtrToStringUTF8 to the other PtrToString* families. (#23731)
* Match PtrToStringUTF8 to the other PtrToString* families.

* Make PtrToString*(IntPtr,int) exceptions consistent.

* Exclude out-of-date tests in CoreFX.

* Update exclusions to cover tests that are now throwing ArgumentOutOfRangeExceptions instead of ArgumentExceptions.

* Fix parameter order for exception.

* Pass value to exception.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:24 -07:00
Steve MacLean 7cf81c817b Whitespace (dotnet/coreclr#23772)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:23 -07:00
Tanner Gooding b7d729d2ef Update the JIT to recognize the IsSupported property for all HWIntrinsics (#23751)
* Moving some JITDUMP calls into Compiler::lookupNamedIntrinsic

* Marking the IsSupported methods as Intrinsic for all HWIntrinsic ISAs

* Updating the hwintrinsic importation to more generally handle IsSupported and ThrowPNSE

* Applying formatting patch.

* Adding using System.Runtime.CompilerServices to the various x86 PlatformNotSupported HWIntrinsic files

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:22 -07:00
Stephen Toub 51d6b9bf02 Don't null out references in Stream/BinaryReader/Writer (#23725)
These types null out some fields on Dispose, and some of those fields are accessible directly via exposed properties, which means that nulling them out would either force us to annotate those properties as being nullable or would require us to lie about them being nullable.  Nulling them out also makes it easier to accidentally null ref in the implementation, and prevents us from making the fields readonly.

It should be exceedingly rare that you dispose of one of these objects and then keep it alive while also being concerned about keeping alive the other helper objects the type uses.  So this change just uses a separate flag to track disposal, and avoids nulling out the fields, which is not a common practice elsewhere in the framework.

This will be a visible change in that after Dispose, properties like StreamWriter.BaseStream/Encoding will now return the stream/encoding rather than null.  In theory that could break someone if they were using those properties to determine whether the writer had been disposed, but that seems unlikely / similar fallout from most any bug fix, and objects generally aren't supposed to be touched after Dispose, anyway.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:21 -07:00
Grant fccd3ad15b Revert optimization (dotnet/coreclr#23759)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:19 -07:00
Levi Broderick a55709fa7a Improve performance of Memory<T>.Span property getter (#23750)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:19 -07:00
Santiago Fernandez Madero ebe0d573b8 Fix Debug.Assert in GenericDelegateCache (dotnet/coreclr#23755)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:18 -07:00
Santiago Fernandez Madero b3d4e338cf Fix merge conflicts on Delegate and String.resx
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:17 -07:00
Stephen Toub 28c0991cfc Fix build break due to conflicting PRs (dotnet/coreclr#23726)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:16 -07:00
Krzysztof Wicher 0ff89565f5 Nullable: shared/System/Security (dotnet/coreclr#23623)
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:15 -07:00
Stephen Toub e90270aefb Nullable: Streams (dotnet/coreclr#23703)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:28:09 -07:00
Bernhard Urban de1fc96374 [aot] use g_malloc () instead of malloc () (#13953)
[aot] use g_malloc () instead of malloc ()

Unbreaks jemalloc support as it hooks into `g_malloc ()` instead of replacing `malloc ()`.

```
%4  0x000055ee6af0d27b in sigabrt_signal_handler (_dummy=6, _info=0x7ffc7b0c4ff0, context=0x7ffc7b0c4ec0) at mini-posix.c:232
%5  <signal handler called>
%6  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
%7  0x00007f4ae0d73801 in __GI_abort () at abort.c:79
%8  0x000055ee6b2ab6ed in rtree_child_leaf_tryread (elm=0x55ee6b75b028 <je_extents_rtree+704104>, dependent=true) at src/rtree.c:205
%9  0x000055ee6b2ab95f in je_rtree_leaf_elm_lookup_hard (tsdn=0x7f4ae1f05738, rtree=0x55ee6b6af1c0 <je_extents_rtree>, rtree_ctx=0x7f4ae1f05758, key=94482510772944, dependent=true, init_missing=false) at src/rtree.c:292
%10 0x000055ee6b242f70 in rtree_leaf_elm_lookup (tsdn=0x7f4ae1f05738, rtree=0x55ee6b6af1c0 <je_extents_rtree>, rtree_ctx=0x7f4ae1f05758, key=94482510772944, dependent=true, init_missing=false) at include/jemalloc/internal/rtree.h:369
%11 0x000055ee6b242fb5 in rtree_read (tsdn=0x7f4ae1f05738, rtree=0x55ee6b6af1c0 <je_extents_rtree>, rtree_ctx=0x7f4ae1f05758, key=94482510772944, dependent=true) at include/jemalloc/internal/rtree.h:394
%12 0x000055ee6b2431ee in rtree_szind_slab_read (tsdn=0x7f4ae1f05738, rtree=0x55ee6b6af1c0 <je_extents_rtree>, rtree_ctx=0x7f4ae1f05758, key=94482510772944, dependent=true, r_szind=0x7ffc7b0c6000, r_slab=0x7ffc7b0c6004) at include/jemalloc/internal/rtree.h:446
%13 0x000055ee6b24d468 in ifree (tsd=0x7f4ae1f05738, ptr=0x55ee6c7dfad0, tcache=0x7f4ae1f058f0, slow_path=true) at src/jemalloc.c:2126
%14 0x000055ee6b24de06 in mono_jefree (ptr=0x55ee6c7dfad0) at src/jemalloc.c:2290
%15 0x000055ee6b2c6c68 in monoeg_g_free (ptr=0x55ee6c7dfad0) at gmem.c:83
%16 0x000055ee6adefafa in emit_method_code (acfg=0x7f4ae0986000, cfg=0x7f4ae0ad4e00) at aot-compiler.c:6243
%17 0x000055ee6adf9534 in emit_code (acfg=0x7f4ae0986000) at aot-compiler.c:9704
%18 0x000055ee6ae04a9d in emit_aot_image (acfg=0x7f4ae0986000) at aot-compiler.c:13535
%19 0x000055ee6ae03b7c in mono_compile_assembly (ass=0x7f4ae09a9300, opts=374434303, aot_options=0x7f4ae093c000 "bind-to-runtime-version,outfile=./../../class/lib/build-linux//Microsoft.CodeAnalysis.CSharp.dll.so", global_aot_state=0x7ffc7b0c6438) at aot-compiler.c:13357

```
2019-04-09 16:25:53 -04:00
Stephen Toub a8ba76c4c1 Nullable: System.Threading.Tasks (dotnet/coreclr#23691)
* Nullable: System.Threading.Tasks

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:25 -07:00
Santiago Fernandez Madero 1675c9e7d4 Nullable: All remaining exceptions (dotnet/coreclr#23676)
* Nullable: All remaining exceptions

* Fix build break and PR Feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:21 -07:00
Stephen Toub e4865826f1 Nullable: ReaderWriterLockSlim (dotnet/coreclr#23657)
* Nullable: ReaderWriterLockSlim

* Address PR feedback

* Audit System.Threading for unannotated statics

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:19 -07:00
Stephen Toub 1e799563fc Nullable: System.Threading (dotnet/coreclr#23663)
Finishes off annotation of the System.Threading namespace, not including subnamespaces.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:18 -07:00
Stephen Toub 2a9ae82761 Nullable: Interlocked, Volatile (dotnet/coreclr#23655)
Also fixing the class? annotation on public LazyInitializer methods.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:17 -07:00
buyaa-n 75f54646fb Nullable: System.Enum
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:16 -07:00
Krzysztof Wicher 192062ee5b Nullable: globalization remainder (dotnet/coreclr#23526)
* Nullable: remainder of globalization

* annotate windows specific files

* add TODO-NULLABLE next to TODO suggesting comments

* fixes after merging other globalization annotations, apply feedback

* fix windows

* address feedback

* fix windows

* fixes

* apply feedback

* remove workaround

* s_Invariant?, couple of Debug.Asserts

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:15 -07:00
Stephen Toub e5828e1a8d Nullable: System.Buffers (dotnet/coreclr#23619)
* Nullable: System.Buffers

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:12 -07:00
Stephen Toub aad1b221c5 Nullable: AsyncLocal (dotnet/coreclr#23618)
* Nullable: AsyncLocal

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:10 -07:00
Stephen Toub 95d18423a4 Nullable: WaitHandles (dotnet/coreclr#23604)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:09 -07:00
Stephen Toub 02f2718c86 Nullable: SemaphoreSlim (dotnet/coreclr#23628)
* Nullable: SemaphoreSlim

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:08 -07:00
Stephen Toub 4a47ccbfaf Nullable: ExecutionContext (dotnet/coreclr#23611)
* Nullable: ExecutionContext

* Add TODO comments

* Fix conflict with ThreadPool PR

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:07 -07:00
Stephen Toub 1b6614ea4a Fix build break due to nullable PR conflicts (dotnet/coreclr#23641)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:06 -07:00
Stephen Toub 406cfbc6d3 Nullable: ThreadLocal (dotnet/coreclr#23626)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:05 -07:00
Stephen Toub c9b17e9bed Nullable: Lazy (dotnet/coreclr#23639)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:04 -07:00
Stephen Toub 6f1aaede58 Nullable: SpinWait/Lock (dotnet/coreclr#23613)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:03 -07:00
Stephen Toub 557efaa549 Nullable: CancellationToken (dotnet/coreclr#23609)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:02 -07:00
Stephen Toub 015cc4c0f3 Nullable: ManualResetEventSlim (dotnet/coreclr#23630)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:00 -07:00
Stephen Toub 2bcad8bd47 Nullable: SynchronizationContext (dotnet/coreclr#23634)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:23:00 -07:00
Santiago Fernandez Madero 6daecf7f18 Nullable: Annotate remaining System.*Exception (dotnet/coreclr#23585)
* Nullable: Annotate remaining System.*Exception

* PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:59 -07:00
Stephen Toub 1e0dc722cc Nullable: ThreadPool (dotnet/coreclr#23600)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:57 -07:00
Dan Moseley 7e2fad45c5 Annotate Unix interop (dotnet/coreclr#23589)
* Unix interop

* More interop

* Fix

* fix

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:56 -07:00
Tanner Gooding b04c1e800a Nullable: System.Runtime.Intrinsics
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:55 -07:00
Tanner Gooding e5f984a353 Fixing the StringInfo constructor to work with the nullability analysis
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:53 -07:00
Krzysztof Wicher 70759684c3 Nullable: DateTimeFormat, DateTimeFormatInfoScanner, SortKey, StringInfo, TextElementEnumerator, TimeSpanFormat, TimeSpanParse (#23486)
* nullable: DateTimeFormat, DateTimeFormatInfoScanner, SortKey, StringInfo, TextElementEnumerator, TimeSpanFormat, TimeSpanParse

* prefix workaround comment with TODO-NULLABLE

* add TODO-NULLABLE

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:52 -07:00
Krzysztof Wicher 3b1c91d8cf Nullable: NumberFormatInfo, CultureInfo (dotnet/coreclr#23459)
* Nullable: NumberFormatInfo, CultureInfo

* fix build

* fix windows

* fix APPX issue

* another appx failure

* get rid of line split

* mark retVal as nullable

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:51 -07:00
Santiago Fernandez Madero 69a0897eb7 Nullable: Exception, SystemException, Argument*Exception (#23515)
* Nullable: Exception, SystemException, Argument*Exception

* Add Debug.Assert rather than comment

Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:50 -07:00
Santiago Fernandez Madero e2f1a0913e Nullable: make Object.ToString() return nullable (dotnet/coreclr#23510)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:49 -07:00
Santiago Fernandez Madero 9ff4795adb Nullable: System.Double, System.Single (dotnet/coreclr#23503)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-09 13:22:48 -07:00
Jo Shields 96246ab598 [netcore] Fix make dist
```
make[5]: Entering directory `/mnt/jenkins/workspace/build-source-tarball-mono/mcs/class/System.Private.CoreLib'
make[5]: Leaving directory `/mnt/jenkins/workspace/build-source-tarball-mono/mcs/class/System.Private.CoreLib'

make[5]: *** No rule to make target `dist-recursive'.  Stop.
make[4]: *** [dist-recursive] Error 1
```
2019-04-09 16:06:26 -04:00
Alexander Köplinger c3541fc543 [nunit-lite] Use .NOTPARALLEL to possibly fix some races
We're seeing occasional build errors on CI that seem to be some kind
of race when compiling nunit-lite and nunit-lite-console.
2019-04-09 20:44:43 +02:00
Filip Navara f90133579f Link libgcc statically on Windows 2019-04-09 18:52:12 +02:00
Jo Shields 430307e24b [netcore] Runtime nupkg fixes (#13934)
We can now build `--with-core=only` on Linux or Mac with the same makefile, and have a functional `make nupkg` rule which attempts to produce a .nupkg of the runtime in the format consumed by core-setup.
2019-04-09 17:41:46 +02:00
Jo Shields 6544999e86 Merge pull request #13955 from directhex/more-loadedllvm-magic
Make sure mini_method_is_default_method is in loaded LLVM
2019-04-09 11:28:34 -04:00
Jo Shields 2c42f8d317 Make sure mini_method_is_default_method is in loaded LLVM
mono: symbol lookup error: /usr/lib/libmono-llvm.so: undefined symbol: mini_method_is_default_method
2019-04-09 10:53:53 -04:00
Rolf Bjarne Kvinge 6492dd3a6f [corlib] Fix a few NSLogWriter issues. (#13799)
* [corlib] Make NSLogWriter thread-safe.

* [corlib] Simplify newline checking in NSLogWriter.

Checking the StringBuilder buffer after writing to it instead of the input
string/char[] makes the code somewhat simpler.

* [corlib] Fix NSLogWriter.Write to take into account the index and count parameters.
2019-04-09 14:58:15 +02:00
Johan Lorensson 00b8b21e72 Merge pull request #13928 from lateralusX/lateralusX/use-tls-key-lmf-add-windows
Use TLS_KEY_LMF_ADDR on Windows when pusing lmf frame.
2019-04-09 05:26:35 -04:00
Filip Navara 4449463256 [netcore] Allow reflection invocation of methods with ByRef return types (#13901)
CoreCLR allows reflection on methods with ByRef return types under certain conditions. The PR implementing it is https://github.com/dotnet/coreclr/pull/17639.

Mono already implemented most of it in the marshalling code but artificially blocked it in `ves_icall_InternalInvoke`. I changed the condition for the exception to match the condition in `emit_invoke_call` (marshal-ilgen.c). It's similar to the condition in CoreCLR, but it may not handle byref-like types correctly. It would have to fixed on both places if it turns out to be the case.

The remaining issue is that null references returned in ByRef are not checked and converted to correct exception. It should result in `NullReferenceException` with special message that doesn't get wrapped in `TargetInvocationException`. I put a TODO marker at a place where I think it should be handled, but it's a bit over my head to implement it.

/cc @vargaz
2019-04-09 10:42:18 +02:00
Johan Lorensson fd4539b0ed Merge pull request #13930 from lateralusX/lateralusX/add-supported-additional-defines-windows
Make sure additional supported enable defines ends up in config.h on Windows.
2019-04-09 04:16:44 -04:00
lateralusX 491a4d5da8 Add support for direct icalls not defined in icall-def.h.
An icall declaration can now use the following attribute:

MonoDirectICallSymbolNameAttribute("MyNativeCFunction")

and if not already defined in icall-def.h and direct-icalls are used when
AOT compile the assembly, a direct call will use symbol defined in attribute
as the symbol for direct call. Using this attribute will also enable inlining
for the specific icall wrapper generating inlined direct icalls to external
defined native methods.

This feature is valuable when embedding the runtime and extend with icalls
added using mono_add_internal_call. By applying the above attribute, it is
possible to do AOT with direct-icalls and get static linked icalls without
the need to extend and rebuild cross compiler in the process.
2019-04-09 08:55:29 +02:00
Kenneth Pouncey 68278f0326 [wasm] Core Bindings for SharedArrayBuffer (#13913)
* Add support for core SharedArrayBuffer.

- Add SharedArrayBuffer implementation
- Add SharedArrayBuffer constructors to TypedArray implemenations

* Add tests for SharedArrayBuffer.

- Refactored the test code to add specific test files for Core Bindings.  This separates the tests into specific test regions.
- Moved bindings tests from the http tests to the core bindings tests.

* Cleanup debugging code.
2019-04-09 08:46:36 +02:00
Alexander Kyte b0ae9dbdaa [merp] Restore non-assertion behavior in debugger-engine.c (#13865) 2019-04-08 22:23:35 -04:00
Zoltan Varga 69b6667e2f [llvm] If a true/false branch of a conditional branch is marked as out-of-line, emit an llvm.expect call. (#13915) 2019-04-08 21:57:44 -04:00
Katelyn Gadd ef99519ae5 Bump macsdk msbuild hash to msbuild that uses new roslyn, matching mono master (#13852) 2019-04-09 01:21:39 +02:00
Alexander Köplinger 3903a50e43 [System.Data] Remove unnecessary file from xunit tests (#13935)
It contained DllImports to some Windows APIs which causes issues on xamarin-macios which expects all pinvokes to exist.

Turns out we don't even need that file.
2019-04-08 23:51:34 +02:00
Larry Ewing e51645a560 Merge pull request #13759 from kjpou1/wasm-update-sdk
[wasm] Update to emscripten 1.38.30
2019-04-08 13:23:55 -05:00
lateralusX 03071d5aca Make sure additional supported enable defines ends up in config.h on Windows. 2019-04-08 16:59:10 +02:00
lateralusX f204ccf058 Use TLS_KEY_LMF_ADDR on Windows when pusing lmf frame. 2019-04-08 16:33:03 +02:00
Bernhard Urban 6c774081b5 [AOT] fix winaot LLVM profile (#13909)
[AOT] fix winaot LLVM profile

Regression due to https://github.com/mono/mono/pull/13877
2019-04-08 10:16:37 -04:00
Jo Shields 7b3bb4bfe0 Merge pull request #13918 from directhex/reenable_llvm_test
Reenable LLVM JIT CI
2019-04-08 09:47:14 -04:00
Alexander Köplinger ea13df0e75 Bump bockbuild to get GTK fix (#13912)
https://github.com/mono/bockbuild/pull/93
2019-04-08 15:46:55 +02:00
Jo Shields d52bfac874 Reenable LLVM JIT CI 2019-04-08 09:35:22 -04:00
Zoltan Varga e6385a35c9 [jit] Avoid adding a needless zext which confuses abcrem. (#13890)
[jit] Avoid adding a needless zext which confuses abcrem.

Fixes https://github.com/mono/mono/issues/13889.
2019-04-08 09:06:11 -04:00
Alexander Köplinger da34285bc1 Revert "[image] Create MonoImageStorage to own the image raw data (#13892)" (#13916)
This reverts commit a56573fb7c.
2019-04-08 13:09:46 +02:00
Egor Bogatov b49e72950e [llvm] do not emit safe points for simple methods (#13887)
* do not emit sp on method entry for simple methods

* do not emit sp on method entry for simple methods

* address feedback
2019-04-08 10:53:52 +02:00
Filip Navara f13239aae8 Fix cut & paste error in TypeLoadException constructor 2019-04-08 08:53:57 +02:00
Filip Navara 194c275878 Reenable working Enum tests 2019-04-08 08:53:20 +02:00
Zoltan Varga 8170457d4f [netcore] Remove an assertion which is no longer needed. 2019-04-08 08:48:54 +02:00
Kenneth Pouncey b6237c392f [wasm] Javascript Core Function (#13528)
* Add JavaScript Core support for Function

* Fix compile

* Fix bindings tests

* Add Core Function tests

- TestFunctionSum
   - Create a new Function with a body that returns the sum of two numbers
   - call method `Call` on the sum Function

- TestFunctionApply
   - Return the Math.min function from the Global Math space
   - Call method `Apply` on the min Function to return the minimum value from an array.

* Use Core Function to determine streaming instead of calling InvokeJS which uses javascript Eval.

* Move nested array checking to managed code as per review comments.

- This removes the icall as per review suggestion.
2019-04-08 07:09:27 +02:00
Zoltan Varga e8b77c3af7 [wasm] Generate the pinvoke tables. (#13897)
* [wasm] Generate the pinvoke tables.

Put the default non-linked version of the table into version control, usable by the interpreter only build.

* Add a comment to the generated file.
2019-04-07 06:20:19 -04:00
Aleksey Kliger (λgeek) a56573fb7c [image] Create MonoImageStorage to own the image raw data (#13892)
Create a new data structure: MonoImageStorage.

It is an object that will have the responsibility for the raw data of a
MonoImage.  It has a string key and a refcount that is used to share a
MonoImageStorage between multiple MonoImage objects.

The reason we need this is because the current MonoAssembly/MonoImage design is
broken for multiple domains and (more evidently) it will be broken when we add
AssemblyLoadContext support.  The issue is that a MonoImage may be shared
between multiple domains (or ALCs), but it has a 'references' field which
points to a single other MonoAssembly.

This is a problem because the references of an image may be resolved
differently in different domains (or ALCs).

The eventual solution will be to stop sharing MonoImages based on path name (or
in the case of in-memory images based on a name made up from the address of the
byte blob).

However we still don't want to open the same data more than once (if we're on a
config where we don't have mmap, we malloc some memory and dump the data in
there - we don't want to do that multiple times for the same file).

So the solution is to create this MonoImageStorage object and make it possible
to share it based on path name, but don't give it any responsibilities except
for owning the memory.  It doesn't know anything about metadata or assemblies
or any of that stuff - it just owns a chunk of memory and knows when and how to
free it.

This commit just adds the MonoImageStorage object and wires it up in MonoImage
loading.  There should be no observable behavioral changes from this commit.
2019-04-07 05:23:29 -04:00
Filip Navara 9a63a2d41f Propagate System.Globalization.Invariant from runtimeconfig.json to GlobalizationMode 2019-04-07 08:56:52 +02:00
Filip Navara eddd208dfb Update CoreFX / Runtime versions, download the CoreFX binaries and use them for running the tests 2019-04-07 08:43:06 +02:00
Jay Krell b3917b60ec Remove obsolete AOT relocations for code clarity, assuming no need to support old AOT images. (#13893)
Remove mono_get_throw_exception_by_name declaration.
2019-04-07 02:21:36 -04:00
Miguel de Icaza 7116ecaf4e [metadata] Fix memory leak for the last iteration of the loop, Coverity #1444258 (#13856) 2019-04-06 11:46:27 +02:00
Miguel de Icaza 8567415aea [Coverity] Ensure that we never return -1 from pagesize operation, helps eliminate many false positives (#13863) 2019-04-06 11:41:28 +02:00
Miguel de Icaza af4b09ba27 [metadata] Handle condition in ftell, Coverity 1307192 (#13862)
ftell can be a negative value, handle that scenario.
2019-04-06 11:35:07 +02:00
Filip Navara f29dd7622c [netcore] Implement RuntimeImports.RhBulkMoveWithWriteBarrier (#13840)
* [netcore] Implement RuntimeImports.RhBulkMoveWithWriteBarrier

* Add the actual write barrier to RhBulkMoveWithWriteBarrier

* Rename ves_icall_System_Runtime_RuntimeImports_Memmove_wbarrier to ves_icall_System_Runtime_RuntimeImports_RhBulkMoveWithWriteBarrier

Fixes 15 failures in System.Memory.Tests.
2019-04-06 11:26:55 +02:00
Filip Navara d074481a29 [netcore] Fix Marshal.IsPinnable regression (#13876)
Fix regression from https://github.com/mono/mono/pull/13807/files#diff-e881a4d9491559282e7ae2021f8ad3a4R54.

CoreCLR code for reference: https://github.com/dotnet/coreclr/blob/2f4a7564beb6f8c1f4929504ee2221953d25fc39/src/vm/marshalnative.cpp#L276-L278

Fixes `System.Tests.StringTests.Ctor_CharPtr_DoesNotAccessInvalidPage` in `System.Runtime.Tests`.

My understanding is that IsPinnable should return `true` for:
- Any blittable type
- Any array of blittable types
- Any array of primitive types (covers bool[])
- String, Utf8String (handled separately in managed code in Mono)

It should not return `true` for:
- Primitive non-blittable type
- Value types that are not blittable (eg. contain pointers to other GC objects)
2019-04-06 11:21:07 +02:00
Filip Navara 6346235702 [netcore] More Array.Copy fixes (#13842)
Remaining errors:
```
/Users/filipnavara/Documents/mono/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs(391,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Tests.ArrayTests.Copy_SZArray(sourceArray: [0, 1, 2, 3, null, ...], sourceIndex: 2, destinationArray: [204, 204, 204, 204, 204, ...], destinationIndex: 5, length: 3, expected: [204, 204, 204, 204, 204, ...]) [FAIL]
      System.InvalidCastException : Specified cast is not valid.
      Stack Trace:
        /Users/filipnavara/Documents/mono/mcs/class/System.Private.CoreLib/System/Array.cs(170,0): at System.Array.Copy(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length, Boolean reliable)
        /Users/filipnavara/Documents/mono/mcs/class/System.Private.CoreLib/System/Array.cs(87,0): at System.Array.Copy(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length)
        /Users/vsts/agent/2.149.2/work/1/s/src/System.Runtime/tests/System/ArrayTests.cs(1293,0): at System.Tests.ArrayTests.Copy(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length, Array expected)
        /Users/vsts/agent/2.149.2/work/1/s/src/System.Runtime/tests/System/ArrayTests.cs(1243,0): at System.Tests.ArrayTests.Copy_SZArray(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length, Array expected)
        /Users/filipnavara/Documents/mono/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs(391,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Tests.ArrayTests.SetValue_Casting_Invalid [FAIL]
      Assert.Throws() Failure
      Expected: typeof(System.InvalidCastException)
      Actual:   (No exception was thrown)
      Stack Trace:
        /Users/vsts/agent/2.149.2/work/1/s/src/System.Runtime/tests/System/ArrayTests.cs(3939,0): at System.Tests.ArrayTests.SetValue_Casting_Invalid()
        /Users/filipnavara/Documents/mono/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs(391,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
```

The last Copy_SZArray test case is `yield return new object[] { new object[] { 0, 1, 2, 3, null, 5, 6, 7, 8, 9 }, 2, new int?[] { 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0xcc }, 5, 3, new int?[] { 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 2, 3, null, 0xcc, 0xcc } };`
2019-04-06 11:17:32 +02:00
Kenneth Pouncey d12d4c9f45 [wasm] Fix Uint8ClampedArray.From(byte[]) invalid cast (#13790)
* Handle Uint8ClampedArray from byte[] array correctly.

Fixes https://github.com/mono/mono/issues/13787

* Add tests for TypedArray.From

* Fix assert descriptions.

* Add TypedArrayTypeCode which is an enum of typed array types.

- Add tests
2019-04-06 10:36:33 +02:00
Marek Safar 1ae3a94254 Reflect shared code changes 2019-04-06 08:07:10 +02:00
Marek Safar fe75f010c2 Move parts of delegate to shared partition (dotnet/coreclr#23552)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-06 08:07:10 +02:00
Bernhard Urban 61100b24e0 [AOT] remove confusing llcopts flag (#13877)
[AOT] remove confusing llcopts flag

Introduced by
https://github.com/mono/mono/commit/2eeaf888c1d0a681c8705bd609f76196d8fb82ed
2019-04-05 16:05:56 -04:00
Jo Shields 0fc2363a4a Merge pull request #13866 from lambdageek/fix-no-gc-unsafe-dl-fallback-register
[mono-dl] Don't do thread state transitions in mono_dl_fallback_register
2019-04-05 15:50:57 -04:00
Alexander Kyte 5f5c51f3ef [merp] Fix image size reported (#13847)
* [merp] Point managed image_size at correct size field

* [merp] Bump merp version number

Fixes #13834
2019-04-05 21:26:13 +02:00
Alexander Kyte 715d33c46e [llvm] Make GOT a typed struct (#13803) 2019-04-05 15:25:09 -04:00
Vlad Brezae 47a0ad469b [interp] Add intrinsics for common object methods (#13762)
GetHashCode is 2x faster while GetType is 10x faster.
2019-04-05 22:10:16 +03:00
Zoltan Varga 25157c4ccd [netcore] Avoid loading the globalization native lib in invariant mode. (#13853)
* [netcore] Avoid loading the globalization native lib in invariant mode.

* Fix a c++-ism.
2019-04-05 14:48:00 -04:00
Filip Navara 7bf675a760 Remove -noappdomain and -noshadow too 2019-04-05 18:00:49 +02:00
Filip Navara b60ca5fb6b Keep the xunit parallelization setting at default value to allow 'Xunit.CollectionBehavior(DisableTestParallelization = true)' override 2019-04-05 18:00:49 +02:00
Alexander Kyte 0cbdcd8e5a [llvm] Give LLVM noalias info about alloc functions (#13801)
From: https://llvm.org/docs/LangRef.html

```
Furthermore, the semantics of the noalias attribute on return values are stronger than the semantics of the attribute when used on function arguments. On function return values, the noalias attribute indicates that the function acts like a system memory allocation function, returning a pointer to allocated storage disjoint from the storage for any other object accessible to the caller.
```

Think this probably helps LLVM reorder the method calls, telling it that allocating won't return a pointer to something else on the stack.
2019-04-05 17:12:34 +02:00
Aleksey Kliger (λgeek) c434294b24 [metadata] Don't free_aggregate_modifiers in mono_metadata_free_type (#13785)
The aggregate modifiers container is owned by a MonoImageSet.  The aggregate
modifiers may be shared by more than one MonoType that happen to need the same
modifiers. (Similar to how generic instantiations are shared)

When the image set is cleaned up the aggregate modifier cleanup will free the
types in the aggregate modifiers container (the call to
free_aggregate_modifiers in mono_metadata_clean_for_image).

With this extra call to free_aggregate_modifiers in mono_metadata_free_type may
cause the same memory to be freed twice.

Fixes https://github.com/mono/mono/issues/13775
2019-04-05 11:01:24 -04:00
Jay Krell 36c5f3f370 Add MONO_PATCH_INFO_TRAMPOLINE_FUNC_ADDR and MONO_PATCH_INFO_SPECIFIC_TRAMPOLINE_LAZY_FETCH_ADDR. (#13794)
* Add MONO_PATCH_INFO_LAZY_FETCH_ADDR and MONO_PATCH_INFO_TRAMP_ADDR.
These are int-based alternatives to MONO_PATCH_INFO_JIT_ICALL_ADDR + sprintf.

This clarifies work to remove the JIT icall hash tables that are used with:
 MONO_PATCH_INFO_JIT_ICALL
 MONO_PATCH_INFO_JIT_ICALL_ADDR
 MONO_PATCH_INFO_JIT_ICALL_ADDR_NOCALL

making it easier to make those enum-based, indexing a fixed size dense array.

As a related side effect, that could be achieved otherwise,
this fixes apparent leaks.

And clarify MONO_PATCH_INFO_JIT_ICALL_ADDR_NOCALL slightly, by making
searches for it find one more hit.

That is, those three enums are mostly used with a fixed set of strings.
Except for as in this PR where they are used with indefinite strings.
The removal of the indefinite strings eases replacement of the fixed
set of strings with an enum.

* Bump MONO_AOT_FILE_VERSION.

* PR feedback: Remove unused code and historical commentary.
Also updated PR title with more verbose actual names of the new symbols:
  `MONO_PATCH_INFO_TRAMPOLINE_FUNC_ADDR`
  `MONO_PATCH_INFO_SPECIFIC_TRAMPOLINE_LAZY_FETCH_ADDR`

* Add missing break.
2019-04-05 03:43:28 -04:00
Zoltan Varga 3344bd64c8 [netcore] System.Runtime.InteropServices test fixes. (#13807)
* [netcore] Fix Marshal test failures.

* [netcore] Add exclusions for System.Runtime.InteropServices.Tests.

* [netcore] Make an icall internal.

* Add more test exclusions.

* Address review comments.
2019-04-05 02:13:52 -04:00
Zoltan Varga 22e2cd87a7 [interp] Add more netcore intrinsics. (#13849)
* [interp] Add more netcore intrinsics.

* Address review comments.

* Fix a warning.
2019-04-05 02:13:34 -04:00
Alexander Köplinger 7030a95c84 Fix .vscode/c_cpp_properties.json 2019-04-05 01:04:12 +02:00
Aleksey Kliger 275d1f5d16 [mono-dl] Don't do thread state transitions in mono_dl_fallback_register
1. it doesn't touch the managed runtime

2. it may be called (arguably it ought to be called only) before the runtime is
initialized (and in particular before the current thread is attached).
2019-04-04 18:09:41 -04:00
Vlad Brezae 474305cbce [interp] Fix GetFunctionPointer (#13708)
This method returns a function pointer that can be called with a calli instruction. On interpreter we use a pointer to InterpMethod while on jit we use the native code address. Normally, GetFunctionPointer should return the InterpMethod pointer if called from interp or the native code address if called from jit. Since we don't have any information about the execution engine of the caller, we solve this by intrinsifying all these calls, that happen in the interpreter.

Passing such function pointers between jitted and interp code is probably still unreliable.

Fixes https://github.com/mono/mono/issues/13654
2019-04-04 22:19:50 +02:00
Jo Shields 4b46c5fca4 Merge pull request #13858 from kg/disable-llvmjit-on-ci
Disable llvmjit in the packaging test ci lane so we can turn the lane back on
2019-04-04 16:14:54 -04:00
Katelyn Gadd 5e58ed80c8 Disable llvmjit in this ci lane so we can turn the lane back on 2019-04-04 12:46:45 -07:00
Thays Grazia beb81d3deb [DIM] Do not order implemented interfaces (#13721)
This test https://github.com/dotnet/coreclr/blob/1649da12db73c8c07513c9168cb30ec70c310063/tests/src/Regressions/coreclr/20452/twopassvariance.il

On mono we were ordering the list of implemented interfaces and shouldn't do this as it's described on ECMA-335 Section II.12.2.1 and II.12.2.2.
The ordering was removed on ilasm and some changes were needed on metadata either because it's not ordered anymore.

There were two bugs, one on ilasm and other on class initialization on mono.

### ILAsm ###

If we get the .exe generated by .net Framework it doesn't execute on mono without modifications because we ordered the implemented interfaces list by id. And doing that the order defined on source code is ignored.

If we get the .exe generated by Mono it doesn't execute on .net Framework because on IlAsm we order the list and loose the order defined on source code.

The interfaces on metadata before these changes on IlAsm were like this:
```
1: Fooer1 implements class IFoo<class Derived>
2: Fooer1 implements class IFoo<class Base>
3: Fooer2 implements class IFoo<class Base>
4: Fooer2 implements class IFoo<class Derived>
5: Fooer3 implements class IFoo<object>
6: Fooer3 implements class IBar<class Derived>
7: Fooer3 implements class IBaz<class Base>
8: IBar implements class IFoo<!0>
9: IBaz implements class IFoo<!0>
10: Fooer4 implements IQux
11: Fooer4 implements class IBar<class Derived>
12: IQux implements class IFoo<class Base>
13: IQux implements class IFoo<class Derived>
14: Fooer5 implements IQux
15: Fooer5 implements class IBar<class Derived>
16: Fooer6 implements class IBar<class Base>
17: Fooer6 implements class IFoo<class Base>
18: Fooer7 implements class IFoo<class Base>
19: Fooer7 implements class IBar<class Base>
```

And After the changes they follow the definition order which is the same order of IlAsm for .net framework and .net core.
```
1: IBar implements class IFoo<!0>
2: IBaz implements class IFoo<!0>
3: IQux implements class IFoo<class Base>
4: IQux implements class IFoo<class Derived>
5: Fooer1 implements class IFoo<class Base>
6: Fooer1 implements class IFoo<class Derived>
7: Fooer2 implements class IFoo<class Derived>
8: Fooer2 implements class IFoo<class Base>
9: Fooer3 implements class IBaz<class Base>
10: Fooer3 implements class IBar<class Derived>
11: Fooer3 implements class IFoo<object>
12: Fooer4 implements IQux
13: Fooer4 implements class IBar<class Derived>
14: Fooer5 implements class IBar<class Derived>
15: Fooer5 implements IQux
16: Fooer6 implements class IFoo<class Base>
17: Fooer6 implements class IBar<class Base>
18: Fooer7 implements class IBar<class Base>
19: Fooer7 implements class IFoo<class Base>
```

### Mono vtable layout ###

Internally when Mono computes the interface table for each class, it would previously sort the interfaces by `MonoClass:interface_id` which is a unique id assigned (roughly) in load order.  This was incorrect because the order of the interfaces determines the final vtable for the class.  This PR changes the interface table computation so that the interfaces of a single class are ordered in declaration order, following ECMA. 

One consequence is that we can no longer use binary search with the interface id as the key to find out if a class implements an interface.  We have to do a linear scan. On the other hand, we expect that the number of interfaces implemented by a single class is small in practice.

This is how the Vtable for Fooer1 and Fooer2 looks like after the changes:
```
*** Vtable for class 'Fooer1' at "FINALLY" (size 6)
[O][000][INDEX 000] object:ToString () [0x7fd78681db20]
[O][001][INDEX 001] object:GetHashCode () [0x7fd78681daf8]
[O][002][INDEX 002] object:Finalize () [0x7fd78681dad0]
[O][003][INDEX 003] object:Equals (object) [0x7fd78681daa8]
[I][004][INDEX 000] IFoo:Gimme () [0x7fd786503800]
[I][005][INDEX 000] IFoo:Gimme () [0x7fd7865038c0]
Packed interface table for class Fooer1 has size 2
[000][UUID 078][SLOT 004][SIZE 001] interface IFoo[Base]
[001][UUID 079][SLOT 005][SIZE 001] interface IFoo[Derived]
```
and
```
*** Vtable for class 'Fooer2' at "FINALLY" (size 6)
[O][000][INDEX 000] object:ToString () [0x7fd78681db20]
[O][001][INDEX 001] object:GetHashCode () [0x7fd78681daf8]
[O][002][INDEX 002] object:Finalize () [0x7fd78681dad0]
[O][003][INDEX 003] object:Equals (object) [0x7fd78681daa8]
[I][004][INDEX 000] IFoo:Gimme () [0x7fd7865038c0]
[I][005][INDEX 000] IFoo:Gimme () [0x7fd786503800]
Packed interface table for class Fooer2 has size 2
[000][UUID 079][SLOT 004][SIZE 001] interface IFoo[Derived]
[001][UUID 078][SLOT 005][SIZE 001] interface IFoo[Base]
```

This is how the VTable for Fooer1 and Fooer2 looks like before the changes, as you can see Packed interface table are the same in Fooer1 and Fooer2, so the behavior of both classes was the same:

```
Vtable for class 'Fooer1' at "FINALLY" (size 6)
[O][000][INDEX 000] object:ToString () [0x7fcf3801d920]
[O][001][INDEX 001] object:GetHashCode () [0x7fcf3801d8f8]
[O][002][INDEX 002] object:Finalize () [0x7fcf3801d8d0]
[O][003][INDEX 003] object:Equals (object) [0x7fcf3801d8a8]
[I][004][INDEX 000] IFoo:Gimme () [0x7fcf37c29880]
[I][005][INDEX 000] IFoo:Gimme () [0x7fcf37c29940]
Packed interface table for class Fooer1 has size 2
[000][UUID 076][SLOT 004][SIZE 001] interface IFoo[Base]
[001][UUID 077][SLOT 005][SIZE 001] interface IFoo[Derived]
```

```
Vtable for class 'Fooer2' at "FINALLY" (size 6)
[O][000][INDEX 000] object:ToString () [0x7fcf3801d920]
[O][001][INDEX 001] object:GetHashCode () [0x7fcf3801d8f8]
[O][002][INDEX 002] object:Finalize () [0x7fcf3801d8d0]
[O][003][INDEX 003] object:Equals (object) [0x7fcf3801d8a8]
[I][004][INDEX 000] IFoo:Gimme () [0x7fcf37c29940]
[I][005][INDEX 000] IFoo:Gimme () [0x7fcf37c29880]
Packed interface table for class Fooer2 has size 2
[000][UUID 076][SLOT 005][SIZE 001] interface IFoo[Base]
[001][UUID 077][SLOT 004][SIZE 001] interface IFoo[Derived]
```
2019-04-04 15:38:21 -03:00
Zoltan Varga aba1bac992 [llvm] Fix llvm JIT. (#13835)
[llvm] Fix llvm JIT.

<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-04-04 09:46:06 -04:00
Stephen Toub 463e323a9c Don't null out buffer in MemoryStream on Capacity reset (#23700)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-04 15:32:31 +02:00
Bernhard Urban 83243d9a3a [fullaot+interp] add Facades to this profile (#13824)
* [fullaot+interp] add Facades to this profile

* [csproj] Update project files
2019-04-04 11:58:53 +02:00
Kenneth Pouncey 55a6457f58 [wasm] Disable debugger tests (#13827) 2019-04-04 11:44:30 +02:00
Sung Yoon Whang 80d5c49c52 Add CPU runtime counter (dotnet/coreclr#23680)
* Add cpu counter

* Fix windows build

* Make the counter just return current CPU usage as %

* Add Unix

* Fix unix build

* Some cleanup

* rename

* fixing some build errors

* some cleanup

* remove unused using

* more cleanup

* newline

* Address PR feedback

* more pr feedback

* More feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-04-04 11:35:46 +02:00
Filip Navara 281721bea0 Move null check into separate method to prevent unnecessary conversion of null into ReadOnlySpan (#23616)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-04 11:35:46 +02:00
Jeremy Koritzinsky d8f557209d Change Auto charset to mean UTF-8 off-Windows (dotnet/coreclr#23664)
Match Mono's behavior by changing the Auto character set to mean UTF-8 on non-Windows platforms (new behavior) and UCS-2/UTF-16 on Windows (current behavior).

Fixes #23464
Fixes dotnet/corefx#32442

Impact of breaking change: It is highly unlikely that anyone is actively using current behavior since it is inconsistent with Mono and doesn't match any native system APIs on non-Windows platforms (they're all UTF-8 based).

We will need to update our documentation to reflect this updated behavior.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-04 11:35:46 +02:00
Alexander Köplinger e75ba60277 Update csproj file 2019-04-04 11:09:55 +02:00
Jan Vorlicek 2f0ae8e621 Remove s_isProcessExiting and Clear of ALC list at exit
Signed-off-by: dotnet-bot <[email protected]>
2019-04-04 11:09:04 +02:00
Jan Vorlicek 41316a7438 Deliver Unload event at exit for all ALCs
Sending it just for collectible ALCs is not correct at process exit.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-04 11:09:04 +02:00
Jan Vorlicek a449662610 Fix accidental non-collectible context unloading
The OnProcessExit was iterating over the s_contextsToUnload and calling
Unload on each of the contexts. However the s_contextsToUnload is a
misnomer, it contains all the contexts, both collectible and
non-collectible ones. So we were calling Unload on non-collectible
contexts too there. That resulted in InvalidOperationException being
thrown from the OnProcessExit.

This change fixes that by calling unload only on ALCs whose
IsCollectible returns true. It also renames the s_contextsToUnload to
s_allContexts.

Close #22902

Signed-off-by: dotnet-bot <[email protected]>
2019-04-04 11:09:04 +02:00
Filip Navara 9270f159bf [netcore] Improve support for rare enum types (#13825)
* [netcore] Improve support for rare enum types (IntPtr, UIntPtr, Single, Double, Char, Boolean backing types)

* Add back Intrinsic attribute

* Update Enum.cs
2019-04-04 11:08:07 +02:00
Egor Bogatov 271c4448b4 [netcore] Implement missing Math and MathF methods (#13833)
* Add missing Math(f) methods

* remove extra empty line
2019-04-04 10:37:05 +02:00
Vlad Brezae e6c43065f7 [interp] Optimize static vtype field access (#13769)
We want to avoid calling stackval_to/from methods. Also include the field address in the instruction stream. This makes static vtype field access 10x faster.

Refactor the code a bit.
2019-04-04 11:06:19 +03:00
Alexander Köplinger af92a7fc54 [corlib] Disable EncodingTest.AllEncodingsAreSerializable() on XM4.5 too
(cherry picked from commit 9eb2dbf4cc)
2019-04-04 01:57:21 +02:00
Alexander Köplinger 2f6753a179 Bump bockbuild 2019-04-04 00:12:44 +02:00
Alexander Köplinger 011b333848 Bump linker to latest master (#13818)
(cherry picked from commit 6717c3422a)
2019-04-03 23:42:07 +02:00
Filip Navara c27e3c58c0 [netcore] Implement RuntimeAssembly.InternalLoadAssemblyName 2019-04-03 22:58:41 +02:00
Vlad Brezae cfa75e8ca5 [gsharedvt] Fix sizeof opcode (#13817)
[gsharedvt] Fix sizeof opcode

We were setting the stack type by using another global local named ins.

This lead to missing methods in the aot image due to invalid IL. Fixes https://github.com/mono/mono/issues/13479.
2019-04-03 14:26:00 -04:00
Jo Shields 4c07ca4e46 Merge pull request #13828 from directhex/loadedllvmaot
Add MONO_LLVM_INTERNAL to re-fix LLVM AOT with loadedllvm
2019-04-03 14:09:29 -04:00
Jo Shields 124025fc4d Merge pull request #13750 from directhex/test-installed-prefix-mono
Add tests to ensure `make install` prefix is functional
2019-04-03 13:38:20 -04:00
Jo Shields 656208c004 Add MONO_LLVM_INTERNAL to re-fix LLVM AOT with loadedllvm 2019-04-03 13:19:57 -04:00
Vlad Brezae f98a81b488 [interp] Add intrinsics for Math operations (#13635) 2019-04-03 19:56:35 +03:00
Marek Safar 9bdf6c2c6c [netcore] Simplify runtime and tests synchronization 2019-04-03 17:35:14 +02:00
Alexander Köplingeranddirecthex 4df8ca38d6 Update scripts/ci/run-test-make-install.sh
Co-Authored-By: directhex <[email protected]>
2019-04-03 10:47:10 -04:00
Alexis Christoforides bd25e86727 [MacSDK] Bump bockbuild for fix to https://github.com/mono/mono/issues/13804 2019-04-03 10:41:10 -04:00
Jo Shields 8bd6a288b5 Add tests to ensure make install prefix is functional
Adds 5 quick checks, on prefix-tests tag:
* Build a basic file with mcs
* Build a basic file with Roslyn
* AOT an assembly
* LLVM AOT an assembly (loadedllvm)
* LLVM JIT an assembly (loadedllvm)

This should let us spot regressions affecting installed prefixes sooner
2019-04-03 09:11:54 -04:00
Filip Navara 180915ffa6 [netcore] Improve element type checks in Array.Copy and Array.ConstrainedCopy (#13811)
* [netcore] Improve element type checks in Array.Copy and Array.ConstrainedCopy

* Reshuffle ifs
2019-04-03 12:09:51 +02:00
Ankit Jain 285443b5d4 [nuget] Bump to nuget 5.0.0 2019-04-03 04:26:15 -04:00
Filip Navara ced517784b [netcore] Reenable some methods on RuntimeType 2019-04-03 10:23:56 +02:00
Jan Kotas 757a07c284 Avoid unnecessary SetLastError on PInvokes (dotnet/corefx#36544)
These console PInvokes are used in nearly every app. Omitting unnecessary SetLastError
will save us from generating marshalling stub for them.

Signed-off-by: dotnet-bot <[email protected]>
2019-04-03 10:20:58 +02:00
Filip Navara bd8ec57901 [netcore] Bump SDK version 2019-04-03 10:16:28 +02:00
Jay Krell 5ed727ed8e Rename cabs/cimag/creal to mono_cabs/mono_cimag/mono_creal without macro to rename. (#13663)
Also make cimag/creal macros for guaranteed inlining -- instead of passing structs by value.
And add spaces before parens to follow coding convention (which is designed
to ease low tech searches for entire words).

This was agreed to when the code was first ported to C++ but got dropped.
The compromise though was to put the defines relatively late to limit their impact.
2019-04-03 03:26:28 -04:00
Alexander Köplinger 02946b7ced [bcl] Fix compiling nunitlite when PARENT_PROFILE is defined (#13791)
In this case we relied on nunitlite to be compiled when the parent profile is compiled. That doesn't work however if we compile the child profile first (e.g. during a parallel make) since it'll
complain about missing nunitlite.dll.

We now compile nunitlite in the child profiles too even though we don't use it.
This is an alternative solution to what I tried in https://github.com/mono/mono/pull/5357 since I couldn't get it to work and this should be the easier fix.

It allows us to finally remove the `-i` (ignore errors) from the CI scripts and catch test assembly breakages in mobile profiles which we ignored before.
2019-04-02 21:41:43 +02:00
Jo Shields 688ac23fb6 Merge pull request #13797 from directhex/remove-csc-dim-some-more
Remove csc-dim script, since csc-dim is gone
2019-04-02 14:04:55 -04:00
Filip Navara 02be9aeba3 [netcore] Cleanup + test fixes (#13795)
Avoid using `wget` since it's not installed on macOS by default.
2019-04-02 17:49:20 +02:00
Jo Shields d828e92449 Remove csc-dim script, since csc-dim is gone 2019-04-02 11:20:38 -04:00
Egor Bogatov 3bb6fe8797 [netcore] Fix few Array tests (#13756)
* fix test

* fix tests

* Fix ArgumentNullException empty ParamName

* System.Text.Tests.StringBuilderTests are fine

* fix BlockCopy test

* enable more tests

* Enable more tests

* address feedback
2019-04-02 14:48:53 +02:00
Alexander Köplinger 448cf31a8d [System] Clear MONO_CFG_DIR before starting mcs in CodeDOM CSharpCodeGenerator for XM4.5 (#13742)
* [System] Clear MONO_CFG_DIR before starting mcs in CodeDOM CSharpCodeGenerator

This showed up in the xamarin-macios 2019-02 integration.
When you used Xslt with a custom C# script in a Xamarin.Mac Full application
we'd try to launch mcs via CodeDOM to compile the script.

This started failing in 2019-02 because System.Native (mono-native) wasn't found,
the reason is that XM sets MONO_CFG_DIR to point to the Contents/MonoBundle
in the app bundle where it packages the global config file with dllmaps.

However the started Mono wasn't able to find mono-native since the config
there uses a different name for the file.

To prevent that we now clear MONO_CFG_DIR so it uses the default value for the
mono process we're starting (note that setting it to String.Empty doesn't work)

* Make it specific to XM 4.5
2019-04-02 10:46:07 +02:00
Zoltan Varga df846bcbc9 [netcore] Fixes for System.Reflection tests. (#13776)
* [netcore] Add error checking for assembly version parsing, pass the full 32 bit value to managed code.

* [netcore] Implement RuntimeType.StructLayoutAttribute.

* [runtime] Implement RuntimeFieldHandle.GetValueDirect (), convert SetValueDirect () to handles.

* [netcore] Implement Assembly.GetFiles ()/GetForwardedTypes ().

* [runtime] Handle 'ARM' as a valid architecture in assembly name parsing.

* [netcore] Implement ParameterInfo.MarshalAsAttribute, AssemblyName.EscapedCodeBase.

* [netcore] Add exclusions for System.Reflection.Tests.

* [netcore] Update test exclusions.

* [netcore] Fix CustomAttributeExtensions.

* [netcore] Add a list of passing test suites.

* [netcore] Add a missing argument check.

* Update Object.cs
2019-04-02 09:02:25 +02:00
Krzysztof Wicher b7140b3a9e PermissionSet: follow netfx more in order to avoid workarounds with nullable (#23637)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-02 08:54:54 +02:00
Krzysztof Wicher 9bbfc63c4c Change PermissionSet.SyncRoot to return this instead of null (#23631)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-02 08:36:39 +02:00
Filip Navara a63a85b21d [netcore] Add exception for System.Threading.ThreadPool tests 2019-04-02 00:08:49 +02:00
Filip Navara ed01dc0e92 [netcore] Add exception for System.IO tests 2019-04-02 00:08:49 +02:00
Filip Navara 8b2463b57c [netcore] Add exception for System.Text.Json tests 2019-04-02 00:08:49 +02:00
Levi Broderick b4b41e15d5 Fix bad Debug.Assert statements in UTF-8 processing (dotnet/coreclr#23627)
Signed-off-by: dotnet-bot <[email protected]>
2019-04-01 23:36:28 +02:00
Zoltan Varga cee8934bce [netcore] Fix a number of SRE argument checking failures. 2019-04-01 23:20:38 +02:00
Zoltan Varga 7b2d7dfd6f [netcore] Implement RuntimeMethodInfo.GetPseudoCustomAttributes (). 2019-04-01 23:20:38 +02:00
Zoltan Varga 476514ec98 [sre] Emit custom modifiers for return values. 2019-04-01 23:20:38 +02:00
Acid Chicken (硫酸鶏) 004f1ba107 Add new era in Japan called "Reiwa" (dotnet/coreclr#23614)
* Add new era in Japan called "Reiwa"

* Update Japanese eras English names

refs: <https://github.com/dotnet/coreclr/pull/23614#issuecomment-478680005>

Signed-off-by: dotnet-bot <[email protected]>
2019-04-01 23:05:21 +02:00
Filip Navara a1e65c0559 [netcore] Fix TrySetApartmentStateUnchecked return value 2019-04-01 23:04:41 +02:00
Jo Shields 262a543a17 Fix tarball builds 2019-04-01 15:50:51 -04:00
Alexander Köplinger 7a9cb8f420 Apply API snapshot and csproj changes from https://github.com/mono/mono/pull/13767 2019-04-01 21:45:41 +02:00
Martin Baulig f42f1026cd Add netcore/Makefile to .gitignore (#13771) 2019-04-01 20:14:22 +02:00
Zoltan Varga 37a09e9eb0 [interp] Add Internal.Runtime.CompilerServices.Unsafe intrinsics. (#13732)
[interp] Add Internal.Runtime.CompilerServices.Unsafe intrinsics.
2019-04-01 13:15:52 -04:00
Jay Krell ff1d485b56 Fix a few deficiencies in mono_path_filename_in_basedir. Mainly strstr. (#13719)
* Fix a few deficiencies in mono_path_filename_in_basedir.
The main one is that strstr is too loose.
Add tests.
Make it case insensitive on Win32 and allow some denormal input.
 Note that case sensitivity is a function of file system, not
 operating system, but a lot of code gets it wrong, so here does too.

Add more data to asserts.

Account for test reality -- filename is not absolute.

The Win32 code paths can be tested on Unix and vice versa
w/o compromise. See https://github.com/mono/mono/pull/13707

* Reduce testing per PR feedback.

* Edit/add comments.
This is an attempt to clarify and hopefully doesn't backfire.

* Try to make tests clearer, and stop skipping some oops.

* PR: Restore case insensitivity testing on Windows. Tweak a little bit.

* Include the .c file instead of .h to fix some builds.
2019-04-01 12:43:10 -04:00
Jo Shields c4eb7d679b Merge pull request #13767 from directhex/master
Bump version to 6.3
2019-04-01 11:40:54 -04:00
Jo Shields b198ef5ad6 Bump version to 6.3 2019-04-01 10:43:21 -04:00
Filip Navara acb8dd1183 Fix WASM build (#13763)
Broken by https://github.com/mono/mono/pull/13712.
2019-04-01 12:15:50 +02:00
Alexander Köplinger 7c62c3b838 Update API snapshot 2019-04-01 11:33:15 +02:00
monojenkins df0b3ae630 [bcl] Update BCL Linked Size 2019-04-01 08:12:39 +02:00
Kenneth Pouncey a26ef0b6a1 [wasm] Update to emscripten 1.38.30 2019-04-01 06:02:43 +02:00
Marek Habersack acbeffd073 [sdks,mac] Remove dependency on MXE in favor of MinGW
It turns out that homebrew now has a package for the MinGW gcc-based windows
cross compiler which is awesome as it allows us to skip building MXE and use the
latest version of the GCC suite pre-packaged for Mac. This commit removes almost
all traces of MXE (except for `mxe.mk` itself, because I don't know if any bot
or external tool, whatever, use targets in it) and adds the following brew
packages to SDK bot provisioning as well as to the `provision-mxe` target of
Mono SDKs:

  * mingw-w64
  * xamarin/xamarin-android-windeps/mingw-zlib

The latter package builds a Windows version of zlib using MinGW and it comes
from Xamarin's own homebrew tap at https://github.com/xamarin/homebrew-xamarin-android-windeps/blob/f4cc90845ff1953800d8d71035566a12d9b7aa24/mingw-zlib.rb

Additionally, this commit adds a new `configure` flag: `--with-static-zlib=PATH`
which allows one to specify the static zlib archive to use when linking Mono.
The static archive supersedes the otherwise indicated or detected zlib. This is
the recommended mode of operation for MinGW builds as it avoids problems with
`zlib.dll` versions on the target machine.
2019-03-31 11:51:13 -04:00
Filip Navara 9ccfd778e3 [System.Private.CoreLib/mscorlib] Implement Interlocked.MemoryBarrierProcessWide (#13712)
* Implement Interlocked.MemoryBarrierProcessWide

* Bump MONO_CORLIB_VERSION

* Bump API snapshot submodule
2019-03-31 12:08:51 +02:00
Ganbarukamo41 e894d683f9 Implement IEquatable to Memory and ReadOnlyMemory (dotnet/coreclr#23586)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-31 09:51:23 +02:00
Egor Bogatov 282a9635b3 fix IsPinnable 2019-03-31 09:50:09 +02:00
Marcos Cobeña Morián 4747e3c057 Fixed casing (#13736) 2019-03-30 16:53:24 +01:00
Steve MacLean 7ffd5ed8aa Assembly.Load ALC name (dotnet/coreclr#23574)
Use normalized path for ALC name

Signed-off-by: dotnet-bot <[email protected]>
2019-03-30 00:39:00 +01:00
Alexander Köplinger 5cce664b6f Update System.Net.Http for Watch
(cherry picked from commit 4e3ef48ff0)
2019-03-30 00:13:07 +01:00
Alexander Köplinger bb4a72ae3b Bump binary-reference-assemblies
(cherry picked from commit 0366d7da15)
2019-03-29 23:51:52 +01:00
Alexander Köplinger a2462e19e9 [System.Net.Http] Add IVT to Xamarin.* assemblies and update Mac
NSUrlSessionHandler is in Foundation namespace on XM

(cherry picked from commit 5460d8af74)
2019-03-29 23:48:52 +01:00
Marek Safar 4d7931cd0f enable more tests 2019-03-29 23:30:00 +01:00
Marek Safar c302bfdc66 [netcore] Reorder test targets 2019-03-29 23:30:00 +01:00
Marek Safar b3fc4b1263 [System.Private.CoreLib] Adopt delegate to netcore 2019-03-29 23:30:00 +01:00
Marek Safar ec0618dd9e [System.Private.CoreLib] Fix the type conflicts with corefx types 2019-03-29 23:30:00 +01:00
Jo Shields 37a4bd4c08 Fix for OpenBSD scope error in https://github.com/mono/mono/pull/13633 2019-03-29 16:54:26 -04:00
Martin Baulig ccb95fc05f [wasm]: Disable managed collation on wasm. (#13684)
* The `SimpleCollator` class now implements a new internal interface `ISimpleCollator`.
  In `CompareInfo`, we reference it by that interface everywhere except `GetCollator ()`,
  so we can `#if`-def it out.

  Later on, we will use the linker to do this dynamically with some sort of conditional,
  but even then the interface is required to limit references to the `SimpleCollator` type
  to one single method.

* Add `Mono.Globalization.Unicode/SimpleCollator.cs` to `wasm_corlib.dll.exclude.sources`.

* `corlib/Makefile`: remove collation resources on WASM.

* Added new `[Category ("ManagedCollator")]` to the relevant tests.
2019-03-29 21:31:17 +01:00
Aleksey Kliger (λgeek) 20b523ee9c [arm] Don't use C++ keyword as a variable name (#13744)
Fixes the nightly C++ Jenkins jobs
https://jenkins.mono-project.com/job/test-mono-mainline-linux-cxx/
2019-03-29 16:27:49 -04:00
Alexander Köplinger 41672cbc74 Bump binary-reference-assemblies 2019-03-29 19:43:24 +01:00
Alexander Köplinger 15a0b97b10 [System.Net.Http] Move Mac/iOS specific HttpMessageHandler's to Xamarin.*.dll (#13746)
* Revert "[System.Net.Http] Move NSUrlSessionHandler from xamarin-macios to mono (#13229)"

This reverts commit 5bf74a9954.

* [System.Net.Http] Move Mac/iOS specific HttpMessageHandler's to Xamarin.*.dll

We decided to move these types into Xamarin products since they can't be
used without the underlying infrastructure anyway.

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-29 19:27:07 +01:00
Jo Shields 9ebf3a834c Merge pull request #13747 from directhex/dependency_tracking_is_hard
Add missing assemblies needed by Roslyn snapshot
2019-03-29 14:03:40 -04:00
Jo Shields ece0f7cc26 Add missing assemblies needed by Roslyn snapshot 2019-03-29 14:03:06 -04:00
Jo Shields fbc7da2a3f Merge pull request #13633 from rfht/master
Fix DNS Name Resolution Failure on OpenBSD (GitHub issue #8168)
2019-03-29 13:27:48 -04:00
Filip Navara a7a225ceaf [netcore] Guard for skipFrames overflow, update test exclusions (#13745)
* [netcore] Guard for skipFrames overflow

* [netcore] Remove Timer tests exclusion

* [netcore] Remove unnecessary null check
2019-03-29 17:53:52 +01:00
Katelyn Gadd 0de947787c Add missing roslyn assemblies to mcs package makefile (#13738)
* Add missing roslyn assemblies to mcs package makefile

* Remove deploy step for dynamic interface methods prototype since current roslyn has DIM

Roslyn picked up some new dependencies that I failed to add to a Makefile containing a list of its dependencies. This may fix some scenarios (not covered by CI) that result in csc and/or msbuild not working.
2019-03-29 16:39:11 +01:00
Koundinya Veluri 3eef668848 Change Timer implementation on Unixes to use only one scheduling thread (#7071)
* Change Timer implementation on Unixes to use only one scheduling thread

- Separated from https://github.com/dotnet/corert/pull/7066

* Address feedback from https://github.com/dotnet/corert/pull/7066

* Remove reference to s_lock

* Reduce work inside lock

* Move _id

* Fix duplicate timers in scheduled timer list, move info to TimerQueue

Signed-off-by: dotnet-bot <[email protected]>
2019-03-29 15:21:46 +01:00
Egor Bogatov 8cce577994 Update tests 2019-03-29 14:56:22 +01:00
Filip Navara 7ea8460025 Make the DnsTest more resilient to multi-IP DNS results (#13737)
Sometimes Google DNS is/was returning "dns.google" for reverse query of 8.8.8.8 and 8.8.4.4 instead of the expected "google-public-dns-a.google.com" and "google-public-dns-b.google.com". Since "dns.google" resolves to both 8.8.8.8 and 8.8.4.4 in random order the round-trip tests for IP -> hostname -> IP were failing when they got the other IP.

This changes the logic in the hostname -> IP check to check whether the expected IP is any one of the returned ones (ie. non necessarily the first one).
2019-03-29 14:54:49 +01:00
Tanner Gooding 40532637b9 Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively (#23536)
* Removing FeedTasksPackageVersion from dependencies.props
* The corresponding metadata was removed in https://github.com/dotnet/coreclr/pull/22884

* Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively

* Adding a ! in String.Searching.cs

Signed-off-by: dotnet-bot <[email protected]>
2019-03-29 14:46:41 +01:00
Zoltan Varga 77e99d080d [netcore] Ongoing work. (#13731) 2019-03-29 12:47:16 +01:00
Ben Adams 20c9bdc20a Avoid boxing allocations for async in Tier0 (dotnet/coreclr#22984)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-29 08:04:23 +01:00
Marek Safar afb35526cf Simplify StackFrame class (dotnet/coreclr#23483)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-29 08:04:23 +01:00
Jan Kotas 9d354a7332 Delete RuntimeThread.cs (dotnet/coreclr#23532)
No longer needed

Signed-off-by: dotnet-bot <[email protected]>
2019-03-29 08:04:23 +01:00
Levi Broderick e2c52c86d3 Improve performance of Marvin32 (dotnet/coreclr#22816)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-29 08:04:23 +01:00
Sung Yoon Whang 419b334239 Fix increment calculation in IncrementingPollingCounter (#23502)
* Add test for IncrementingPollingCounter

* Fix a bug in Increment calculation in IncrementingPollingCounter

* Remove setting DisplayName property since that's a private property for now

* fix comment

* Remove unused variables

Signed-off-by: dotnet-bot <[email protected]>
2019-03-29 07:56:07 +01:00
Santiago Fernandez Madero cbf08f3dd6 Nullable: System.Object (dotnet/coreclr#23466)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 20:17:41 +01:00
Krzysztof Wicher b2e00ef754 Nullable: all calendars (dotnet/coreclr#23469)
* calendar

* nullable: all calendars

* fix likely corert error

Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 20:17:41 +01:00
Santiago Fernandez Madero bc096b344f Nullable: System.Char (dotnet/coreclr#23480)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 20:17:41 +01:00
Egor Bogatov 2522547cd5 [netcore] Improve xtest command (#13703)
The python script now also extracts downloaded zips and `make xtest-%` is now able to consume these artifacts.
E.g.
```
make xtest-System.Collections.Tests COREFX_ROOT=/prj/corefx-repo
```
We still need COREFX_ROOT because of two missing files:
`CoreFx.Private.TestUtilities.dll` and `xunit.console.deps.json`
maybe I should just add them to our repo?

Also this PR fixes `RemoteExecutorConsoleApp` problems for `make xtest-%`
2019-03-28 18:00:34 +01:00
Larry Ewing 49ba9f32ec Merge pull request #13705 from kjpou1/wasm-issue-12871
[wasm] Fix System.DllNotFoundException: libc
2019-03-28 11:44:43 -05:00
Alexander Köplinger f48b0a70c3 [Mono.Runtime.Tests] Remove duplicate file in .sources 2019-03-28 16:40:07 +01:00
simplejackcoder e3471b915d GetPinnableReference on String.cs (dotnet/coreclr#23428)
* GetPinnableReference on String.cs

* Add attributes for debugger and performance

Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 16:31:00 +01:00
Jo Shields 7e99ce2960 Merge pull request #13700 from directhex/compress-with-xz
Switch `make dist` format from BZip2 to XZ.
2019-03-28 11:22:09 -04:00
Radek Doulik 4cf13bcd16 [profiler] Add duration=NUM parameter to AOT profiler (#13688)
* [profiler] Add duration=NUM parameter to AOT profiler

It instructs the AOT profiler to write the data after NUM seconds
measured from runtime initialization.

* [profilers] Added aot:duration=NUM parameter description
2019-03-28 10:54:36 -04:00
Alexander Köplinger c6b066a7ab Bump corefx to get unit test reliability fix (#13709) 2019-03-28 15:46:21 +01:00
Jo Shields ac0f7ece35 Merge pull request #13699 from directhex/no-more-monograph
Delete monograph. Closes https://github.com/mono/mono/issues/7845
2019-03-28 10:18:53 -04:00
Maxim Lipnin 03e3608b87 Move checks for empty command text to SqlCommand 2019-03-28 15:02:24 +01:00
Maxim Lipnin b1a0ee371a Throw ArgumentException if there is no active statement during reading a row 2019-03-28 15:02:24 +01:00
Filip Navara 8f99674718 Update Makefile 2019-03-28 14:36:07 +01:00
Filip Navara 141493c473 Separate out common code from pinvoke_probe_for_module_relative_directories into pinvoke_probe_for_module_in_directory 2019-03-28 14:36:07 +01:00
Filip Navara 4648210f3b [netcore] Move P/Invoke directory lookup from mono_dl_fallback to pinvoke_probe_for_module_relative_directories 2019-03-28 14:36:07 +01:00
Filip NavaraandAleksey Kliger 3e05b4ea77 [netcore] Handle NATIVE_DLL_SEARCH_DIRECTORIES for p/invoke
Co-authored-by: Aleksey Kliger <[email protected]>
2019-03-28 14:36:07 +01:00
Jan Kotas 8bad65acb8 Move QueryPerformanceCounter PInvokes to shared (dotnet/corefx#36409)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:13:48 +01:00
buyaa-n e76b69f37b Nullable updates for byte type (dotnet/coreclr#23460)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:13:48 +01:00
buyaa-n 1feba9a019 Nullable changes for boolean type (dotnet/coreclr#23451)
* Nullable changes for boolean type

Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:13:48 +01:00
Santiago Fernandez Madero 6b79fcecc8 Nullable: String (dotnet/coreclr#23450)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:13:48 +01:00
Krzysztof Wicher 6ac3ca34e7 nullable: number (dotnet/coreclr#23454)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:13:48 +01:00
Krzysztof Wicher c0f4d63fa0 Nullable: Uint32, (U)Int16, (U)Int64 (dotnet/coreclr#23449)
* Nullable: UInt32

* (U)Int16, (U)Int64

* Make NumberFormatInfo non-nullable

Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:13:48 +01:00
Krzysztof Wicher 23b6018c77 Nullable: Int32 (dotnet/coreclr#23443)
* Nullable: Int32

* remove restore and move nullable up front

* remove trailing \n after #nullable to make it easier to remove later

Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:13:48 +01:00
Steve MacLean dae859e9e2 ALC Enhancement nits (dotnet/coreclr#23506)
isCollectible default should be false
String should be string

Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:13:48 +01:00
Steve MacLean ea3b4ae05f ALC enhancements (dotnet/coreclr#22273)
* Initial implementatation of ALC enhancements

Add public constructor with name
Add Name property
Add Assemblies property
Add All property
Override ToString
Name Default and Assembly.Load(...) ALCs
Add AssemblyLoadContext30Extensions test

Signed-off-by: dotnet-bot <[email protected]>
2019-03-28 14:02:28 +01:00
Vlad Brezae 23aa609af7 [interp] Small changes (#13691)
* [interp] Extract the code pushing lmf in separate function

There is no reason to not optimize the code inside do_icall

* [interp] Remove dead code

Trace ips are filled in mono_handle_exception_internal
2019-03-28 13:12:17 +01:00
Zoltan Varga 34f3b8947c [llvm] Fix the computation of size of gshared instances in another place.
Fixes https://github.com/mono/mono/issues/13610.
2019-03-28 13:07:45 +01:00
Filip Navara d261a9ace1 [netcore] Implement missing functions in RegisteredWaitHandle and EventWaitHandle 2019-03-28 08:30:20 +01:00
Jay Krell 83acc1a343 Restore domain in error path. (#13662)
* In mono_threadpool_enqueue_work_item, if mono_runtime_invoke_checked fails,
still restore domain.

In mono_threadpool_enqueue_work_item, acknowledge with a comment but do not change
that mono_domain_set failing leads to returning success.

In mono_threadpool_enqueue_work_item, refactor for sharing code without loss
of efficiency or hopefully clarity.

* Keep this line duplicated:
`mono_runtime_invoke_checked (unsafe_queue_custom_work_item_method, NULL, args, error);`
2019-03-28 02:20:53 -04:00
Jay Krell 3fae397cce Cleanup mono_marshal_get_icall_wrapper (#13661)
Every caller was consistently forming the same name based on callinfo->name
and passing callinfo->func and callinfo->sig.
Pass callinfo instead and do the common work in mono_marshal_get_icall_wrapper.

This has the following side effects:
 Do not form and free name when there is a cache hit. This seems like a nice optimization.
 Allow name when there is a cache hit. This is unintended. We could assert if it is a problem.
2019-03-28 02:20:35 -04:00
Kenneth Pouncey 4904dac430 [wasm] Fix System.DllNotFoundException: libc
Fixes issue: https://github.com/mono/mono/issues/12871
2019-03-28 06:42:10 +01:00
Zoltan Varga 5433bd030e [runtime] Revert daf92b9e62. (#13696)
Fixes https://github.com/mono/mono/issues/13607.
2019-03-27 23:46:43 +01:00
Jo Shields a9c340a063 Switch make dist format from BZip2 to XZ.
Closes https://github.com/mono/mono/issues/9267
2019-03-27 15:50:25 -04:00
Jo Shields 38fdb39cac Delete monograph. Closes https://github.com/mono/mono/issues/7845 2019-03-27 15:45:06 -04:00
Alexander Köplinger 77cf4cc4f8 [tests] Remove MONOMAC ifdef from BCL tests (#13694)
It was set by xamarin-macios when they were still taking the raw .cs source files
but since we switched to prebuilt binaries we need to replace it with
some define we're actually setting in Mono.

Most cases can be replaced by just XAMMAC_4_5 since MOBILE is defined on the xammac profile.
2019-03-27 20:21:48 +01:00
Jo Shields e40d76cb4a Merge pull request #13673 from directhex/runtime-nupkg
Runtime nupkg generation
2019-03-27 14:39:17 -04:00
Alexander Köplinger e8c660ce90 [mono] Don't try "open" handlers on iOS/Android in ves_icall_System_Diagnostics_Process_ShellExecuteEx_internal (#13693)
When you use `Process.Start()` with `UseShellExecute=true` (which is the default on Mono/.NET Framework, but false on .NET Core) then we'd still try to first start the file directly, before falling back to trying the "open" handlers like xdg-open to launch the file.

Presumably we do this so that on mobile you can still start a process without needing to explicitly set `UseShellExecute=false`.

However we don't need to try the fallback on iOS/Android since the "open" handlers won't work there anyway.

This recently showed up on the Xamarin.iOS Mono 2019-02 integration where we started running the `System.Diagnostics.ProcessTest` suite and the `Start1_FileName_NotFound()` would fail at `#C6` because the native error code wasn't 2 (file not found) but 13 (invalid data). This is because it tried
to use `/usr/bin/open` which doesn't work of course so it got to the `mono_w32error_set_last (ERROR_INVALID_DATA)` on L2088.
2019-03-27 19:11:48 +01:00
Jo Shields a48e2c8e10 Add some RID detection, and use it to allow runtime nupkg generation
We cannot presume more than just "linux" or "osx" in our RIDs, because
if we want to enable --host vs --build, we can't detect the OS from
the runtime environment.

This is an okay compromise for now.
2019-03-27 10:28:50 -04:00
Jo Shields 7f04ffa847 Add possibility of generating a runtime .nupkg for Mono (Mac-only right now) 2019-03-27 10:28:50 -04:00
Filip Navara 7a74f15949 [netcore] Fix stack size for new threads 2019-03-27 15:23:59 +01:00
Marek Safar fdc4920d5f [System.Private.CoreLib] Implement exceptions capturing 2019-03-27 15:22:50 +01:00
Maxim Lipnin a9f3b8ca54 Port 13553 "Fix transition offset logic" to master 2019-03-27 14:57:03 +01:00
Filip Navara c45f622d97 [netcore] Fix thread debugging messages 2019-03-27 14:33:54 +01:00
Tanner Gooding e658a7d478 Cleaning up the P/Invoke signatures for QPF and QPC to avoid marshalling and pinning (#36071)
* Cleaning up the P/Invoke signatures for QPF and QPC to avoid marshalling and pinning

* Responding to PR feedback.

* Dropping support for low resolution stopwatch

* Removing BestFitMapping=false

* Removing unneeded unsafe declarations

* Addressing more PR feedback

* Fixing the pal_time header file

* Fixing the Unix P/Invoke signatures for GetTimestamp and GetTimestampResolution to return ulong.

* Fixing GetTimestampResolution to scale the result for HAVE_CLOCK_MONOTONIC

Signed-off-by: dotnet-bot <[email protected]>
2019-03-27 14:32:40 +01:00
lateralusX b98013086e Fix incorrect use of FreeHGlobal on Marshal UTF8 allocated string. 2019-03-27 14:23:44 +01:00
Zoltan Varga c7d6919ceb [netcore] Download test assets from the dotnet-core blob feed. 2019-03-27 14:22:41 +01:00
sancheolz a68389fe9a Fix NRE when combobox was disposed and Text set (#13665)
If combobox already was disposed and we setting Text field there will be NullReferenceException. On .net winforms there no excetions.
2019-03-27 13:02:56 +01:00
Alexander Köplinger 1bc213fac1 [System.Xml] Don't hardcode nunit-lite-console in GeneratedCodeAttribute
Instead determine it at runtime.
2019-03-27 11:39:22 +01:00
Alexander Köplinger 5602acf399 [corlib] Skip FileTest.LastWriteTimeSubMsCopy on older iOS Simulators (#13681)
When we switched to using the corefx System.IO.File implementation we also switched to an implementation that uses the `copyfile()` standard library call on macOS/iOS to copy files. This should preserve file metadata such as timestamps.

However there's a small edge case: when using an older version of the iOS Simulator < 11.0 the `copyfile()` call doesn't copy sub-second timestamps, presumably because older iOS ran on HFS which doesn't support that.
When we run this simulator on modern macOS which uses APFS and thus supports sub-second timestamps the origin file used for the test _does_ have sub-second timestamps and the test would fail.

We now skip the test in such environments.

PS: why did this not fail with the old Mono implementation? We used to always call utimes() on the destination file after copying to copy metadata, which in turn would update the file in the simulator host.
It doesn't seem worth it to replicate that behavior for this small edge case.
2019-03-27 11:26:16 +01:00
Katelyn Gadd e9d847d0f6 Bump roslyn binaries to 3.1.0 and add VBCSCompiler.exe to the set of paths auto-detected by configure.ac (#13518)
* Reconfigure bump for PR test

* Actually bump submodule this time probably

* Bump submodule

* Revert "Bump submodule"

This reverts commit b47679be10d3c38d40673cf73e0dc48a300318bc.

* Bump submodule

* Modify csi-test.csx to manually reference netstandard 2.0, because this is required for some reason

* Checkpoint: Test modifying csi.rsp instead of csi-test

* Git

* Update submodule

* Update submodule compiler path

* Remove binaries-new submodule

* Update to latest roslyn-binaries revision and update path in configure.ac
2019-03-27 09:17:24 +01:00
Zoltan Varga 4bb8637454 [netcore] Fix some thread failures. 2019-03-27 09:15:45 +01:00
Zoltan Varga de89d6dc77 [netcore] Fix ArgumentException argument order. 2019-03-27 09:15:45 +01:00
Zoltan Varga 593853ef06 [netcore] Disable boehm. 2019-03-27 09:15:45 +01:00
Martin Baulig 1af992a5ff Split AppDomain.DoTypeResolve(object) into DoTypeResolve() and DoTypeBuilderResolve(). (#13142)
* Instead of having one `AppDomain.DoTypeResolve(object)` that checks at runtime whether
  the argument is a `string` or a `TypeBuilder`, use two strongly-typed methods
  `DoTypeResolve(string)` and `DoTypeBuilderResolve(TypeBuilder)`.

* Add both to the `corlib/LinkerDescriptor/mscorlib.xml`.

* Adjust the code in `appdomain.c` accordingly.

* Bump corlib version.

This is part of a larger on-going project to improve the linker logic.

The rationale behind this is that the new `AppDomain.DoTypeResolve(string)`
that is being called from `mono_domain_try_type_resolve_name()` should not
reference `TypeBuilder`, to allow the linker to remove some of the
`System.Reflection.Emit` types.
2019-03-27 01:51:38 -04:00
Jay Krell 636160148f Cleanup double semi-colons. (#13660)
Cleanup double semi-colons.
2019-03-26 23:45:42 -04:00
Filip Navara fea837d6d3 Fix sample path 2019-03-26 20:47:21 +01:00
Filip Navara b9b6923a58 Exception stack trace should be null when not thrown yet 2019-03-26 20:47:21 +01:00
Marek Safar 06cdc67e2f [System.Private.CoreLib] Implement StackTrace construction from current thread 2019-03-26 19:52:00 +01:00
Egor Bogatov 2f1c1d3b2c [netcore] Implement Array.Sort (#13674)
* Update Array.cs

* implement Array.Sort
2019-03-26 18:10:23 +01:00
Martin Baulig 22073ed676 Cosmetic: remove accidentally added gensources debugging flag. (#13678) 2019-03-26 18:02:55 +01:00
Bernhard Urban 5e70d5ee51 [intrinsics] sync implementation with IL code (#13647)
* [intrinsics] sync implementation with IL code

Before the intrinsic implemented
```
ldarg.0
ldarg.1
sizeof !!T
mul
conv.i
add
ret
```

now it implements
```
ldarg.0
ldarg.1
sizeof !!T
conv.i
mul
add
ret
```

`conv.i` and `mul` have been swapped. Also see https://github.com/mono/mono/pull/13609

* fix op_sext_i4 usage
2019-03-26 12:30:18 -04:00
Zoltan Varga 9d652a972a [llvm] Fix the computation of size of gshared instances in emit_args_to_vtype (). (#13659)
Fixes https://github.com/mono/mono/issues/13610.
2019-03-26 16:28:59 +01:00
Filip Navara e7011c780f Convert from ucontext_t (or platform equivalent) to MonoContext early and propagate it through 2019-03-26 10:56:49 +01:00
Filip Navara 69abf8f5e4 Preserve the native crash context instead of MonoContext to allow printing managed stack trace later 2019-03-26 10:56:49 +01:00
Filip Navara d8e53c515d [netcore] Change loader behaviour to disable assembly remapping and allow loading newer assembly versions 2019-03-26 09:03:04 +01:00
Marek Safar 86506fbdbd [System.Private.CoreLib] Implement StackFrame initialization 2019-03-26 08:39:15 +01:00
Larry Ewing ed2d3504d6 Merge pull request #13620 from kjpou1/wasm-misc-cleanup
[wasm] Remove specific link to framework file when building test-suite
2019-03-25 13:55:51 -05:00
Bernhard Urban 64e17113b2 [amd64] use 32bit variant of lea_membase for 32bit operations (#13642)
[amd64] use 32bit variant of lea_membase for 32bit operations

Consider
```
 xor %r15, %r15       // %r15 = 0x0
 dec %r15d            // %r15 = 0xffff_ffff
 lea 0x1(%r15), %rdx  // %rdx = 0x1_0000_0000 but should be 0x0
```

instead `lea 0x1(%r15), %edx` should be generated.


Fixes #13452
Fixes #13597
2019-03-25 14:25:43 -04:00
Larry Ewing 05a40c67ea Merge pull request #13636 from kjpou1/wasm-add-bindings
[wasm] [packager] Remove the unnecessary call to add_bindings()
2019-03-25 12:13:01 -05:00
Egor Bogatov e653d48b3a [netcore] Improve xunit console runner (#13648)
* improve xunit runner

* improve xunit runner
2019-03-25 16:40:42 +01:00
Larry Ewing 478656ff1d Merge pull request #13416 from kjpou1/wasm-websocket-tests
[wasm][tests] Add WebSocket tests
2019-03-25 09:12:29 -05:00
Zoltan Varga 1fb3b3b87d [netcore] Add System.Reflection.Emit support. (#13613) 2019-03-25 15:04:36 +01:00
Marek Safar 48b8f5ce47 Revert "Do not use MAP_JIT by default, instead make this something that is toggled by Xamarin.Mac which needs it"
This reverts commit a4c8606767.
2019-03-25 14:56:41 +01:00
Johan Lorensson cae256c3b0 Merge pull request #13571 from lateralusX/lateralusX/add-utc-timezone-on-fallback
Add UTC timezone in WinRT GetSystemTimeZones fallback implementation.
2019-03-25 09:30:47 -04:00
Jay Krell 8feaad70f0 Remove const on struct fields. (#13624)
It is unusual and not useful.
2019-03-25 08:36:38 -04:00
Miguel de Icaza a4c8606767 Do not use MAP_JIT by default, instead make this something that is toggled by Xamarin.Mac which needs it 2019-03-25 12:00:41 +01:00
Johan Lorensson 1ff137d950 Merge pull request #13572 from lateralusX/lateralusX/change-test-spincount
Increase spin-count on test to not end up in frequent sleeps on multicore machines.
2019-03-25 06:48:41 -04:00
Kenneth Pouncey 85d86d2215 [wasm] Remove the unnecessary call to add_bindings() when runtime.js is generated. 2019-03-25 11:38:28 +01:00
Jay Krell 004314e9dd [windows]Fix and cleanup configure.ac parsing for MONO_CORLIB_VERSION and ACINIT. (#13630)
Not just a guid or an uppercase guid.
2019-03-25 10:55:15 +01:00
Bernhard Urban eb1cb188a6 [interp] fix "This greater-than-or-equal-to-zero comparison of an unsigned value is always true" reported by Coverity (#13625)
[interp] fix "This greater-than-or-equal-to-zero comparison of an unsigned value is always true" reported by Coverity
2019-03-25 05:45:59 -04:00
Egor Bogatov ac2fb76ed0 [netcore] Marshal.IsPinnable (#13628)
Needed for MSBuild.
Stream changes were copied from [CoreRT](https://github.com/dotnet/corert/blob/master/src/System.Private.CoreLib/src/System/IO/Stream.CoreRT.cs).
IsPinnable - perhaps it should be an icall/intrinsics for better perf?
[CoreCLR impl for IsPinnable (InternalCall)](https://github.com/dotnet/coreclr/blob/1f3f474a13bdde1c5fecdf8cd9ce525dbe5df000/src/vm/marshalnative.cpp#L257)
[CoreRT impl for IsPinnable](https://github.com/dotnet/corert/blob/master/src/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.cs#L114) (and [MightBeBlittable](https://github.com/dotnet/corert/blob/master/src/System.Private.CoreLib/src/System/Runtime/InteropServices/InteropExtensions.cs#L60))
2019-03-25 10:22:54 +01:00
Nick Schonning 47cc95bbb6 typo: Double word "both" (dotnet/corefx#36272)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 65b123d5e9 typo: Double word "never" (dotnet/corefx#36300)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning f1bde8bbaa typo: Double word "to" (dotnet/corefx#36264)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 659cf556ef typo: Double word "that" (dotnet/corefx#36269)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 83133240dc typo: Double word "a" (dotnet/corefx#36271)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 2a659f1cda typo: Double word "in" (dotnet/corefx#36270)
* typo: Double word "in"

* Update src/System.Console/src/System/Console.cs

Co-Authored-By: nschonni <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 0f3c093b09 typo: Double word "the" (dotnet/corefx#36274)
* typo: Double word "the"

* Apply suggestions from code review

Co-Authored-By: nschonni <[email protected]>

Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 0719b0209c typo: Double word "this" (dotnet/corefx#36273)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 4b2c08e01b typo: Double word "are" (dotnet/corefx#36275)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 42199a6297 typo: Double word "types" (dotnet/corefx#36276)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 84bc77cabf typo: Double word "is" (dotnet/corefx#36283)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Nick Schonning 32c4104e44 typo: Double word "we" (dotnet/corefx#36288)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 09:44:44 +01:00
Egor Bogatov b3287d7157 [netcore] Semaphore (#13627)
* Update Semaphore.cs

* netcore Semaphore

* Update Semaphore.cs
2019-03-25 08:51:52 +01:00
Nick Schonning 21b1ee3b62 typo: Double word "as" (dotnet/corefx#36277)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-25 08:34:52 +01:00
Jay Krell fd1baed2af Remove the parsing, hashing, locking, allocations associated with JIT icall signatures. (#13579)
* Remove the parsing, hashing, locking, allocations associated with JIT icall signatures.
Make them statically allocated, single-instanced at compile time, and almost
statically initialized.

Fix C++ and x86.

More x86 fix.

Fix ARMv5.

Undo tedious work to be redone instead of merged from old.

Put all signatures back, prepare for automated conversion.

Replace all the register_icall strings with:

my @a = ("double double",
"long long long",
"long long int32",
"double double double",
"ulong float",
"ulong double",
"long float",
"double int32",
"float float float",
"long double",
"object ptr int int32",
"double ptr",
"int int int ptr ptr ptr",
"int obj ptr",
"int obj",
"int ptr int int ptr object",
"int32 double",
"int32 int32 int32",
"int32 int32 ptr",
"int32 obj",
"int32 object ptr ptr ptr",
"int32 object",
"int32 ptr ptr ptr ptr ptr int32",
"int32 ptr ptr",
"obj ptr int",
"obj ptr",
"object int object object",
"object int object",
"object int",
"object int32",
"object object ptr ptr",
"object object ptr",
"object object",
"object ptr int int int int",
"object ptr int int int",
"object ptr int int",
"object ptr int ptr",
"object ptr int",
"object ptr int32",
"object ptr ptr int32",
"object ptr ptr ptr ptr ptr",
"object ptr ptr",
"object ptr",
"object",
"ptr int",
"ptr obj",
"ptr object int ptr ptr",
"ptr object int32 int32",
"ptr object ptr ptr",
"ptr object ptr",
"ptr object",
"ptr ptr int ptr",
"ptr ptr int",
"ptr ptr int32",
"ptr ptr ptr ptr",
"ptr ptr ptr",
"ptr ptr",
"ptr",
"uint32 double",
"uint32 ptr int32",
"void double ptr",
"void int",
"void int32",
"void obj ptr",
"void object object ptr",
"void object object",
"void object ptr int32 int32",
"void object ptr int32",
"void object ptr",
"void object",
"void ptr int int object",
"void ptr int object",
"void ptr int ptr",
"void ptr int",
"void ptr int32",
"void ptr object int32",
"void ptr ptr int",
"void ptr ptr int32",
"void ptr ptr ptr",
"void ptr ptr",
"void ptr",
"void ptr object",
"void",
);

while (my $line = <>)
{
	if ($line =~ /register|mono_create_icall_signature/ && $line =~ /"/)
	{
		for my $from (@a)
		{
			my $to = "mono_icall_sig_$from";
			$to =~ s/ /_/g;
			$to =~ s/"//g;
			$to =~ s/"//g;
			$to =~ s/"//g;
			$line =~ s/\Q"$from"\E/$to/;
		}
	}
	print($line);
}

Remove whitespace from end of line.

Convert the strings to smaller arrays, of chars now,
that are scaled offsets into MonoDefaults, or -1 for ptrref.

Use smaller encoding.

fix merge

cleanup

* Larger representation that handles alignment.

* Try to undo external changel.

* Fix AOT.

* Fix code search and comments

* Restore warning in this PR.

* More ARM signatures.

* Change representation from pointer to offset.
  Use sizeof for the special case ptrref.
Comments. Perhaps too much.
asserts. Perhaps too much.
A little bit more verbose/readable but essentially the same thing otherwise.
 Perhaps too verbose.

* The initializer all-but-must be pointer-sized.
Even if the values fit in much smaller.
Add comments.
On obscure systems size_t is smaller than a pointer so
gsize or uintptr_t is required. Use gsize.

* Spaces before parens.

* PR: Use enum instead of offsetof.
Use may_alias some.
mono builds with -fno-strict-aliasing, but we had recent
aliasing problem (the enum operators with older g++)
and this looks a little hazardous

We could also have a separate integer or array of byte or array of integer or perhaps string
to resolve the aliasing.

integer: 16 values, 8 max -- could just use an int instead of this array business,
but the representation would be full with no room for expansion.
We are not wasting any/much memory here -- maybe one word per the 200 signatures,
because of sloppyness around any_size_array.

Work a little on dealiasing.
Comment some aliases and make obj/object, int/ptr, bool/boolean share values.

* tweak: Compute all the values once and then directly index small local array.

* Adjust comments to new reality.
Add comments explaining aliasing.

* Add casts to attempt to abide by strict aliasing rules.
2019-03-24 23:16:32 -04:00
thfrwn 6d3aa51dd3 Fix DNS Name Resolution Failure on OpenBSD (GitHub issue #8168) 2019-03-24 17:10:22 -07:00
Kenneth Pouncey 5e61de3a2c Modify packager to load the .pdb files for framework packages. (#13608) 2019-03-24 08:33:27 +01:00
リーフストーム 0b58483fa8 Fix handle leak in cominterop (#13536) 2019-03-23 15:15:57 -04:00
Alexander Köplinger d4953f63ca [sdks] Easier labels for pipeline parts 2019-03-23 10:42:42 +01:00
Alexander Köplinger afdf77b053 [sdks] Build Android Linux Mono SDKs package on CI 2019-03-23 10:30:45 +01:00
Levi Broderick 6ddc22cefe Replace slow implementations in ASCIIUtility with fast implementations (#22516)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-23 09:56:52 +01:00
Jérôme Laban 5134c0fec6 Include the corebindings.c in the package output (#13606)
This update restores the ability to use the packager outside of the mono source tree.
2019-03-23 07:11:01 +01:00
Alexander Kyte 0eac33443d [runtime] Add MONO_LLVM_INTERNAL to *get_aot_init_wrapper* marshal funcs (#13611) 2019-03-23 01:36:58 -04:00
Kenneth Pouncey 1b7c7561ab Remove specific link to framework file when building test-suite 2019-03-23 05:32:51 +01:00
Tarek Mahmoud Sayed 612c1b9f42 Apply Optimization in Index.GetOffset suggested by Levi (#23349)
* Apply Optimization in Index.GetOffset suggested by Levi

* Add Comment

* address the feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-03-22 23:30:09 +01:00
Marek Safar 871975de4e Adopt to shared Exception 2019-03-22 23:27:38 +01:00
Marek Safar 7541d7e5fb Move Exception to shared partition (dotnet/coreclr#23361)
* Move Exception to shared partition

* Remove class name caching

* Not useful comments removal

Signed-off-by: dotnet-bot <[email protected]>
2019-03-22 23:27:38 +01:00
Andrew Hoefling 8fe79b4c8e Updated Exception Handling for Collection<T> (dotnet/coreclr#23290)
* Updated Argument Helper param from list->collection since the parameter name is collection

* Updated exception message to use an out of range exception that doesn't explicitly reference a list

* Simplified if statements that verify if the index is out of range

* Updated if logic to be simplified using (uint)

* Updated exception handling to throw ThrowHelper.ThrowArgumentOutOfRange_IndexException() when the ExceptionArgument was 'Index'

Signed-off-by: dotnet-bot <[email protected]>
2019-03-22 23:27:38 +01:00
Thays Grazia 4abc661805 [DIM] Method call of a class that implements a protected nested interface (#13558)
* Unexpected System.MethodAccessException is thrown for a method call of a class that implements a protected interface inside another interface.

```
public interface I1
{
    protected interface T1
    {
        void M1();
    }

    protected class T2
    {}

    protected struct T3
    {}

    protected enum T4
    {
        B
    }
}

class Test1 : I1
{
    static void Main()
    {
        I1.T1 a = new Test2();
        a.M1();
        System.Console.WriteLine(new I1.T2());
        System.Console.WriteLine(new I1.T3());
        System.Console.WriteLine(I1.T4.B);
    }

    class Test2 : I1.T1
    {
        public void M1()
        {
            System.Console.WriteLine("M1");
        }
    }
}
``


Fixing this case Test1 implements I1<int> but can access methods from I1<object>
public interface I1<X>
{
    protected interface T1
    {
        void M1();
    }

    protected class T2
    {}

    protected struct T3
    {}

    protected enum T4
    {
        B
    }
}

class Test1 : I1<int>
{
    static void Main()
    {
        I1<object>.T1 a = new Test2();
        a.M1();
        System.Console.WriteLine(new I1<object>.T2());
        System.Console.WriteLine(new I1<object>.T3());
        System.Console.WriteLine(I1<object>.T4.B);
    }

    class Test2 : I1<object>.T1
    {
        public void M1()
        {
            System.Console.WriteLine("M1");
        }
    }
}
2019-03-22 18:37:16 -03:00
Marek Safar 1a4014dbc0 Move Buffer constants to platform specific files (dotnet/coreclr#23352)
* Move Buffer constants to platform specific files

* Add explicit access modifier

Signed-off-by: dotnet-bot <[email protected]>
2019-03-22 21:57:24 +01:00
Aleksey Kliger (λgeek) d465a7ad65 [aot] cleanup MonoError in add_extra_method_with_depth (#13605)
I missed something in the code review for #13581.  Need to cleanup MonoError if it's not ok.
2019-03-22 21:24:56 +01:00
Egor Bogatov e72d6d9e1c [netcore] Implement missing bits in Mutex (#13591)
Needed for xunit console runner tool.
2019-03-22 18:54:20 +01:00
Zoltan Varga b4f4acc133 [aot] Avoid an assert which can happen in normal usage. (#13581)
Fixes https://github.com/mono/mono/issues/13455.
2019-03-22 16:02:15 +01:00
Alexander Köplinger c8508e56b6 [ci] Build macOS .pkg PR builds on a separate bot (#13600)
This allows us to get faster results.
2019-03-22 15:19:24 +01:00
Alexander Köplinger a766d2e802 Bump linker to latest master (#13594)
* Bump linker to latest master

The linker source were reorganized a little bit, e.g. sources in src/

* [csproj] Update project files
2019-03-22 10:10:08 +01:00
Vlad Brezae 216e4aa405 [interp] Make transform phase more flexible (#13516)
* [interp] Fix instruction length

* [interp] Don't generate directly into linear code stream

Allocate each instruction into the mempool and link them together. At the end of code generation and after all potential optimisation passes, we will compact this code into its final form.

* [interp] Add support for branch relocations

For each branch instruction, we store in its data field the il offset that we are branching to. During the final code generation, we resolve all backward branches and add relocs for forward branches. These relocs are then resolved after all instructions have been emitted in the final code stream.

* [interp] Extract vararg call code in separate instruction

It requires a different instruction size and is extremely rare code.

* [interp] Fix backwards branch with large offset

We were adding an unsigned instead of subtracting.

* [interp] Fix line numbers

For each il offset that generated interpreter instructions we store the native offset, during the compaction phase.

* [interp] Fix seq points

We have to defer SeqPoint data creation during the compact generation phase, because that's when we have native offset information. We add a flags field to the interpreter instruction to store any relevant information coming from the compilation phase.

* [interp] Make verbose logging a bit nicer

We no longer have the native offset during the first IL instruction interation. Maybe we should bring back logging for the IL -> IR mapping during the compaction phase.

* [interp] Remove some dead code
2019-03-22 10:06:10 +02:00
Kenneth Pouncey 31cb0e28a5 Fix indentation to address review comments 2019-03-22 05:13:12 +01:00
Jo Shields 21cfdbe81c Make test runner able to deal with whitespace patterns other than newline (#13587)
Helix wasn't running our runtime tests as expected, because the test runner expected newline-separated tests to run, and we were generating space-separated.

Following "be liberal in what you accept" philosophy, and to prevent this issue in the future, just deal with "whitespace separated" rather than "this specific whitespace and no other"
2019-03-22 00:23:28 +01:00
Alexis Christoforides c803e6f75b Xamarin.Android integration fixes (#13589)
Backport of #12940.

- Disable other failing tests (they are tests that are newly added, not regressions)
- Look for mono_pal_init() directly in the System.Native library
- [configure] Have libmono-native depend on libmono(-sgen) for the Android build
If this is not done, Android is not able to resolve mono symbols that are used in mono-native (e.g. mono_add_internal_call_with_flags), and will refuse to load the library with 'cannot locate symbol' errors
2019-03-22 00:15:08 +01:00
Egor Bogatov 0fc15b168f [netcore] Xunit console runner (#13592)
* xunit console runner

* add more xunit args

* use rsp file
2019-03-21 23:43:48 +01:00
Zoltan Varga 53bef4aec4 [llvmonly] Add gsharedvt in wrappers to calls which could go to the interpreter. (#13548)
[llvmonly] Add gsharedvt in wrappers to calls which could go to the interpreter.

Fixes https://github.com/mono/mono/issues/13463.




<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-03-21 15:56:06 -04:00
Vlad Brezae 8423f0e9a0 [interp] Enable compile all debug option also on interp (#13570)
[interp] Enable compile all debug option also on interp
2019-03-21 12:05:48 -04:00
Kenneth Pouncey 2b37e1c0b5 Add tests for send and receive of text and binary messages. 2019-03-21 16:37:36 +01:00
Johan Lorensson 7e8d4303fa Couple of fixes to LLVM AOT compiler on Windows x64. (#13474)
* Enable MSVC objects on LLVM >= 6.00
* Always used PIC relocation-model on Windows x64 due to LLVM problem with
static triggering incorrect ADDR32 relocation entries in 64-bit objects.
* Add CodeView symbol format instead of DWARF for Windows x64.
* Fix LLVM outfile when doing static link to not end up in temp directory.
* Only add /DEFAULTLIB when using MSVC and not doing static compile. For
static compile the needed libraries must be added when objects get's linked
and since the needed libraries are c-runtime libraries, should be transparent
for most applications consuming the object files.
2019-03-21 10:05:01 -04:00
Kenneth Pouncey 6513fffcd7 Add tests for
- Client Close
- Host Close with CloseStatus and CloseStatusDescription filled in from Host.
2019-03-21 14:22:31 +01:00
Bernhard Urban 5852d1cf74 [arm] respect potential spilling for overflow flag check (#13564)
[arm] respect potential spilling for overflow flag check

```
  18 int_sbb R77 <- R54 R57
  19 store_membase_reg [arm_fp + 0x24] <- R77
  20 cond_exc_c OverflowException
```
this wasn't properly handled by the arch lowering pass.

Fixes https://github.com/mono/mono/issues/13284
2019-03-21 08:15:31 -04:00
Nikita Voronchev 037faa47cc [WinForms] Related Forms closing issue (#13150) (#13151)
Fixes #13150
2019-03-21 12:57:55 +01:00
lateralusX b554e0ea2c Increase spin-count on test to not end up in frequent sleeps on multicore machines. 2019-03-21 11:43:55 +01:00
lateralusX 33ea64cf7e Add UTC timezone in WinRT GetSystemTimeZones fallback implementation.
Needed by tests when hitting fallback solution in TimeZoneInfo.WinRT.cs.

Fix also sort the TimeZones similar to how its done in .NET Framework/Core.
2019-03-21 11:38:29 +01:00
Zoltan Varga 6a0a5bf3ca [netcore] Implement/fix enum/nullable comparers. 2019-03-21 11:33:34 +01:00
Zoltan Varga a6dc1cec3b [netcore] Implement RuntimeAssembly.GetSatelliteAssembly (). 2019-03-21 11:33:34 +01:00
Zoltan Varga 622bb8d5d5 [jit] Add JitHelpers.EnumEquals ()/EnumCompareTo () intrinsics. 2019-03-21 11:33:34 +01:00
Egor Bogatov 36a62bbf8a [netcore] Implement missing bits in ThreadPool (#13566)
* implement missing bits in ThreadPool

* remove [SecurityCritical]
2019-03-21 11:29:43 +01:00
Kenneth Pouncey 7dbcf1ed4b Add more tests for websockets. 2019-03-21 11:02:43 +01:00
Kenneth Pouncey a15526af3a [wasm][websockets]Fix Error Code not reported correctly with ClientWebSocket 2019-03-21 11:01:24 +01:00
Jan Kotas f2065c849a Hoist calls to IsBitwiseEquatable (dotnet/coreclr#23381)
Smaller IL is easier for JIT

Signed-off-by: dotnet-bot <[email protected]>
2019-03-21 08:10:47 +01:00
Marek Safar 701ca04b36 Update with shared partition changes 2019-03-21 08:05:14 +01:00
Jan Kotas 48114c0375 Unify EnumInfo and NamesAndValues
Signed-off-by: dotnet-bot <[email protected]>
2019-03-21 08:05:14 +01:00
Alexander Kyte 42c3b73ac1 [merp] Fix anon allocation, use MAP_PRIVATE 2019-03-21 07:48:25 +01:00
Egor Bogatov 8cf878ff50 advanced MemberData support 2019-03-21 07:46:56 +01:00
Bernhard Urban 4111910dd8 [llvm] dump bitcode file even if verifier fails (#13556)
[llvm] dump bitcode file even if verifier fails

This can be useful for debugging issues in the products.
2019-03-20 19:45:39 -04:00
Johan Lorensson d3a2841e93 Adjust genconst to changes in winsetup.bat. (#13554)
When logic moved from winsetup.bat into an msbuild task that changed the
console output of winsetup.bat causing problems for genconst to find
MONO_VERSION and MONO_CORLIB_VERSION. There was also a potential problem
where winsetup.bat couldn't find msbuild.exe if not included in PATH.

This fix makes sure winsetup.bat detect and setup a full msbuild environment
before running msbuild.exe. It also change genconsts to look at the generated
config.h for the correct values of MONO_VERSION and MONO_CORLIB_VERSION that
will be used by the runtime builds.
2019-03-20 18:48:20 -04:00
Bernhard Urban 00d871d103 [ssa] avoid code motion to try-blocks (#13555)
[ssa] avoid code motion to try-blocks

Consider
```
BB4:  // successor BB5, BB9
[...]
br [B9]

BB5: // catch handler block for BB4
[...]
br BB9

BB9:
aotconst R90
gc_safe_point R90
[...]
```

Previously, our invariant code motion pass would move `aotconst R90` to the end of BB4. Unfortunately, BB4 contains instructions that can cause an exception and thus control flow is broken and continues to BB5. `aotconst R90` wouldn't be loaded correctly in this scenario.

When lowered to LLVM IR this is more obvious, and the verification pass of LLVM catches this.

Fixes https://github.com/mono/mono/issues/13460
2019-03-20 18:45:47 -04:00
Thays Grazia 4e13c53451 [dim] System.MethodAccessException is thrown for a protected method declared in an interface (#13513)
* ```
interface I1<T>
{
    sealed protected void M1()
    {
        System.Console.WriteLine("M1");
    }
}

interface I3<T> : I1<T>
{}

interface I2<T> : I3<T>
{
    static void Test(I2<int> x)
    {
        x.M1();
    }
}

class A : I2<int>
{
    static void Main()
    {
        I2<byte>.Test(new A());
    }
}
```
When a interface implements another interface and they are generics, we don't need to check the datatypes of generics, we only need to check the inheritance.
Fixes 13467

* Adding test.

* Using the getter functions

* Initializing klass->interfaces/interfaces_count.

* Update mono/metadata/class.c

Co-Authored-By: thaystg <[email protected]>

* Fixing side effect on dim-simple.il
2019-03-20 18:08:51 -04:00
Aleksey Kliger (λgeek) 60221d88d5 [aot] Fix a few memory leaks (#13514)
1. aot-compiler: don't leak `MonoCustomAttrInfo`

2. aot-runtime: don't leak sigs when decoding wrapper references.  All of these cases we decode a sig (which uses malloc), and then call some method that immediately calls `mini_get_underlying_signature` which dups the sig, so the one from the decode isn't needed anymore.
2019-03-20 16:50:25 +01:00
Alexander Köplinger 242596b243 Bump corefx 2019-03-20 12:10:31 +01:00
Johan Lorensson a0e999549e Merge pull request #13529 from lateralusX/lateralusX/fix-mixup-global-cotask-alloc
Fix mixup of Global Free and CoTaskMem Alloc in Marshal's Secure String implementation.
2019-03-20 05:44:35 -04:00
Egor Bogatov b87bd4f6e4 [netcore] Allow all primitive types to be passed to Buffer.BlockCopy (#13544)
* Update Buffer.cs

* allow all primitive types to be passed to BlockCopy

* convert Len to bytes
2019-03-20 08:41:58 +01:00
Egor Bogatov 8b4eef9387 [netcore] Initial MemberDataAttribute support (#13543)
This PR adds ~2200 tests to System.Runtime.Tests and ~1000 to System.Collections.Tests
2019-03-20 08:40:46 +01:00
Thays Grazia b811e645a3 When it is a sealed method in Interface it's not Static nor Virtual and shouldn't add virtual.
Fixes #13508
2019-03-20 08:36:21 +01:00
Alexander Köplinger 8aaf420efe Fix Windows MSI build 2019-03-20 01:49:26 +01:00
Thays Grazia 86e7400525 [metadata][dim] Unexpected System.NotSupportedException in presence of default interface implementations (#13468)
* namespace Application
{
	public interface I1 { void M1() { System.Console.WriteLine("Unexpected!!!"); }}

	public interface I2 : I1 { void I1.M1() { System.Console.WriteLine("I2.I1.M1"); }}

	public interface I3 : I1 { void I1.M1() { System.Console.WriteLine("I3.I1.M1"); }}

	public interface I4 : I1 { void I1.M1() { System.Console.WriteLine("I4.I1.M1"); }}

	class Test10 : I1, I2, I3, I4 { public void M1() { System.Console.WriteLine("Test10.M1"); } }

	class MainClass {
		public static void Main(string[] args)
		{
			I1 var = new Test10();
			var.M1();
		}
	}
}

The interface method M1 is overridden at I1, at I2, at I3, at I4. The class Test10 overrides method M1 so regardless of having methods overriden in interface, the method of the class should be priority in this case. And then I remove the conflicts because there is not a conflict anymore.
2019-03-19 19:26:09 -03:00
Egor Bogatov 3a2d027e5e fix literals 2019-03-19 23:13:58 +01:00
Sung Yoon Whang dd6a9063c9 Remove timer in RuntimeEventSource (dotnet/coreclr#23311)
* Change RuntimeEventSource's counter types

* cleanup

* cleanup

Signed-off-by: dotnet-bot <[email protected]>
2019-03-19 23:02:11 +01:00
Grant 0584d63bf1 Trim/TrimStart/TrimEnd methods for Memory and Span (dotnet/coreclr#22798)
* Span.Trim

* Add another helper

* Remove redundant comments

* Optimize Trim(ReadOnlySpan<char>)

* Suggested overload for byte

* CR fixes

* CR fix

* Add Span overloads

* Add Memory overloads

* CR

* Rename method

* Optimization

* Tweaks

* Refactor

* Opt

* Use 2 helpers

* CR fixes

* CR fixes

* Nits

* CR fixes

* remove in params

* Bug

* Bug

* Move Trim methods to their own dedicated file

* Add char overloads

* Use Contains

* CR fixes

* Optmize ClampNull

* Nit

* Revert optimization

* Make existing implementations consistent with new

* Revert existing methods

* Move helpers

* Span, Memory and RoM should use consistent pattern

* POC for changing RoS

* Revert POC

* Use consistent idiom

* More inlining of explaining vars

* Use expression body for existing code

* CR fixes

* Nit

* Grammar

* CR fixes

* Fix perf bug in existing code

* Perf fix

* Force CI build

* Force CI

Signed-off-by: dotnet-bot <[email protected]>
2019-03-19 22:29:01 +01:00
Egor Bogatov 2785cdbd30 fix typo 2019-03-19 22:27:50 +01:00
Alexander Köplinger a0f593958b [ci] Fix wrong redirect which would overwrite Make.config 2019-03-19 21:53:40 +01:00
Alexander Köplinger dbc3c1a1cd [sdks] Build mac in Mono SDKs (#13535)
Enables building of the xammac runtime and BCL/tests into the SDKs archive.

Contributes to #11397
2019-03-19 20:44:42 +01:00
Bernhard Urban 4cd5068230 [aot] force v7 on arm when using LLVM on iOS (#13521)
[aot] force v7 on arm when using LLVM on iOS

In https://github.com/mono/mono/pull/11172 we added passing `-march=arm` to `llc`, so that newer LLVM would generate code correctly for the target arch. Unfortunately this seems to break older LLVM, that is still used for 32bit code on Xamarin.iOS. For iOS we need to force it to armv7, otherwise it will try to substitute certain locking primitives with builtins that aren't available as hardware instructions on armv5.


Before this change:

```console
$ nm ./obj/iPhone/Release/mtouch-cache/armv7/mscorlib.dll-llvm.o | grep sync_
         U ___sync_fetch_and_add_4
         U ___sync_lock_test_and_set_4
         U ___sync_synchronize
         U ___sync_val_compare_and_swap_4
00079e1c T _mscorlib_System_Runtime_CompilerServices_AsyncMethodBuilderCore_ThrowAsync_System_Exception_System_Threading_SynchronizationContext
00057f80 T _mscorlib_System_Threading_SemaphoreSlim_WaitAsync_int_System_Threading_CancellationToken
00058430 T _mscorlib_System_Threading_SemaphoreSlim_WaitUntilCountOrTimeoutAsync_System_Threading_SemaphoreSlim_TaskNode_int_System_Threading_CancellationToken
         U _p_1214_plt_mscorlib_System_Threading_SemaphoreSlim_WaitAsync_int_System_Threading_CancellationToken_llvm
         U _p_1217_plt_mscorlib_System_Threading_SemaphoreSlim_WaitUntilCountOrTimeoutAsync_System_Threading_SemaphoreSlim_TaskNode_int_System_Threading_CancellationToken_llvm
         U _p_1735_plt_mscorlib_System_Runtime_CompilerServices_AsyncMethodBuilderCore_ThrowAsync_System_Exception_System_Threading_SynchronizationContext_llvm
         U _p_1976_plt_mscorlib_System_Threading_SemaphoreSlim_WaitAsync_llvm
         U _p_37_plt_mscorlib__jit_icall_ves_icall_thread_finish_async_abort_llvm

```

After this change:

```console
$ nm ./obj/iPhone/Release/mtouch-cache/armv7/mscorlib.dll-llvm.o | grep sync_
0007008c T _mscorlib_System_Runtime_CompilerServices_AsyncMethodBuilderCore_ThrowAsync_System_Exception_System_Threading_SynchronizationContext
00050654 T _mscorlib_System_Threading_SemaphoreSlim_WaitAsync_int_System_Threading_CancellationToken
00050ab4 T _mscorlib_System_Threading_SemaphoreSlim_WaitUntilCountOrTimeoutAsync_System_Threading_SemaphoreSlim_TaskNode_int_System_Threading_CancellationToken
         U _p_1214_plt_mscorlib_System_Threading_SemaphoreSlim_WaitAsync_int_System_Threading_CancellationToken_llvm
         U _p_1217_plt_mscorlib_System_Threading_SemaphoreSlim_WaitUntilCountOrTimeoutAsync_System_Threading_SemaphoreSlim_TaskNode_int_System_Threading_CancellationToken_llvm
         U _p_1735_plt_mscorlib_System_Runtime_CompilerServices_AsyncMethodBuilderCore_ThrowAsync_System_Exception_System_Threading_SynchronizationContext_llvm
         U _p_1976_plt_mscorlib_System_Threading_SemaphoreSlim_WaitAsync_llvm
         U _p_37_plt_mscorlib__jit_icall_ves_icall_thread_finish_async_abort_llvm
```

Fixes https://github.com/mono/mono/issues/13478
2019-03-19 12:46:00 -04:00
Alexander Kyte 04d65f2986 [runtime] Default llvm to self-init+direct native calls (#13312)
* [runtime] Default llvm to self-init

Now the init code is behind llvm_plt_init. Setting
--aot=llvm-plt will bring back the legacy llvm+plt behavior

* [llvm] Mark managed methods no-inline by llvm

* [runtime] Clean up self-disabling machinery

* [llvm] Skip self-init on cctors

* [runtime] Always make ctors call their cctors

* [runtime] Improve mono_print_unwind_info, add cases

* [runtime] Fix too-early eager calling of cctors

We emitted all of the lazy checks and init around a specific static
method, but still were initializing it when we initialized methods
that access it. This made static cctors run before they were supposed
to.

The problem was that the call site here has method == NULL, because
we don't compute it. That's expected, as we don't compute the method
along this path.

This initial "&&" looks like it was supposed to avoid calling the method
on a null MonoMethod reference. This preserves that, while fixing the
control flow issues.

* [runtime] Associate init_method native code with MonoMethod

* [runtime] Future-proof against aot init wrapper subtype mixups

* [runtime] Fix goto in AOT-init change for c++

* [runtime] Move docs for llvm-disable-self-init into runtime

* [runtime] Fix bitcode, remove unneeded wrapper around init icall

* [llvm] Include global prefix in init name

* [comment] Describe debugging usage of llvm self-init disable flag

* [aot] Consolidate mangler string append lines

* [llvm] Make self-init documentation changes

* [llvm] Rename self-init funcs, mini_llvmonly_ to mini_llvm_

* [runtime] Enable inlining for methods without init
2019-03-19 11:13:11 -04:00
lateralusX d4e5d14569 Fix mixup of global and cotask mem alloc heaps in Marshal's Secure String. 2019-03-19 15:53:23 +01:00
Bernhard Urban 6cb5c7f9cf [llvm] fix field init for platforms where unbox_trampolines tables are not used (#13527)
Fixes https://github.com/mono/mono/issues/13522
2019-03-19 15:31:44 +01:00
Kenneth Pouncey d4dec33b84 Merge branch 'master' of https://github.com/mono/mono into wasm-websocket-tests 2019-03-19 14:38:15 +01:00
Zoltan Varga 7a5487b966 [netcore] Ongoing work. (#13509)
* [netcore] Avoid casting to generic parameters in gen-xunit-runner.

* [netcore] Make the build-/run- targets more generic, add support for more test suites.

* remove NIE from Exception

* [netcore] Convert gen-xunit-runner to use roslyn for code generation instead of codedom.

* [netcore] Add check target to run all test suites.
2019-03-19 12:19:33 +01:00
Vsevolod Kukol 8a292ff635 Bump bockbuild to fix Gtk NSView embedding on Mac (#13511)
This fixes mouse event handling for NSViews embedded in Gtk.

Fixes VSTS #802376
Fixes VSTS #821841
2019-03-19 10:23:59 +01:00
Alexander Köplinger 31516f0b3e Reduce number of classes in winaot mscorlib. (#13341)
* Reduce number of classes in winaot mscorlib.

Winaot profile should be a Windows AOT friendly profile close to mobile
and consoles. At some point it was set to include the full net_4_x that
cause problems on none desktop platforms. This fix reduce the set to only
include classes similar to mobile and console profiles.

* Reverting changes to TimeZoneInfo test when reducing classes in corlib winaot.

* Move SafePasswordHandle to win32_build_corlib profile.

* Excluded some additional none Windows sources from win32_build/winaot profile.
2019-03-19 10:07:13 +01:00
monojenkins cecd6b316f [csproj] Update project files 2019-03-19 09:06:36 +00:00
Levi Broderick 909cae3de9 Add Utf8String skeleton (dotnet/coreclr#23209)
Utf8String is an experimental type that is string-like (heap-allocated, immutable, variable-length, null-terminated) but whose inner representation is UTF-8, not UTF-16.

This is a skeleton implementation of the basic API shape. The ecosystem of APIs has not yet been built around it. All Utf8String-related code is currently surrounded by ifdefs to allow easy identification and removal from release branches.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-19 09:44:07 +01:00
Vincent Povirk d21d4764e8 [mono/tests] Fix out of tree build. 2019-03-19 09:40:06 +01:00
Levi Broderick e9e902b929 Add Rune.TryEncodeToUtf8 and related APIs (dotnet/coreclr#23250)
Also renames the existing Encode / Decode APIs per design review feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-03-19 09:33:25 +01:00
Thays Grazia 4fbdcf504d [dim] Interface with sealed method (#13501)
* '''
interface I1
{
   sealed void M1()
   {
       System.Console.WriteLine(“M1”);
   }
}

interface I2 : I1
{
   static void Test<T>(T x) where T : I2
   {
       x.M1();
   }
}

class A : I2
{
   static void Main()
   {
       I2.Test(new A());
   }
}
'''

When an interface implements a Sealed method, this method is not virtual, so it will not be available at vtable. But in the IL the call is a virtual call, but in this case we don't need to search at vtable.

Fixes #13466

* Change IL test.
2019-03-18 18:46:07 -03:00
Johan Lorensson a66f944ff7 Fix a couple of build warnings under MSVC. (#13475) 2019-03-18 14:38:27 -04:00
Alexander Köplinger 9bcad32ca5 Update csproj 2019-03-18 19:30:42 +01:00
Marek Safar b1a155979b Update codeowners (#13505) 2019-03-18 17:32:43 +01:00
Ludovic Henry 1965786397 Update CODEOWNERS 2019-03-18 08:50:19 -07:00
Alexander Kyte f7796b0da0 Merge pull request #13447 from alexanderkyte/fallback_merp_allocator
[crash] Fallback to MAP_ANONYMOUS for allocator
2019-03-18 11:49:52 -04:00
Zoltan Varga d5dfc5e76c [jit] Add RuntimeHelpers:IsBitwiseEquatable () intrinsic. (#13499)
* [jit] Add RuntimeHelpers:IsBitwiseEquatable () intrinsic.

* Update access modifier
2019-03-18 16:33:29 +01:00
Zoltan Varga 5232408f7a [runtime] Avoid putting non-virtual and non-static DIM methods into vtables, roslyn generates these for private property accessors. (#13449)
Fixes part of https://github.com/mono/mono/issues/13374.
2019-03-18 11:54:33 -03:00
Alexander Köplinger 12043bb6f5 [System.Drawing.Common] Enable debug symbols
The facade contains code now so we should build a .pdb.
2019-03-18 15:43:30 +01:00
Zoltan Varga 32b84339cb [netcore] Disable runtime cleanup on netcore, coreclr does not cleanup either. Also disable aborting background threads, its no longer needed. (#13469) 2019-03-18 10:40:22 -04:00
Jay Krell 23999ca43d Cleanup mono_array_new_1, mono_array_new_2, mono_array_new_3, mono_array_new_4.
Mainly to remove the dynamic alloca but also combine common code.
If there is a perf concern then we can forceinline mono_array_new_n.
2019-03-18 15:02:30 +01:00
Alexander Köplinger 5521ad349f [System.Net.Http] Port https://github.com/xamarin/xamarin-macios/pull/5769 to mono 2019-03-18 14:39:54 +01:00
Alexander Köplinger e0326df7c6 More Windows MSI fixes 2019-03-18 13:19:17 +01:00
Alexander Köplinger d431fd5619 Fix nunit-lite signing key 2019-03-18 12:40:38 +01:00
Alexander Köplinger 0ae04b8e80 Fix Windows MSI build, msbuild is now in Current instead of 15.0 2019-03-18 11:40:03 +01:00
Alexander Köplinger 362eface2c Remove more unnecessary nunit24 cruft 2019-03-18 11:31:06 +01:00
Johan Lorensson 273776c737 Merge pull request #13482 from lateralusX/lateralusX/windows-build-script-updates
Windows full AOT build scripts update.
2019-03-18 06:15:42 -04:00
Egor Bogatov 9f25f0f540 cache downloaded net core sdk 2019-03-18 11:15:09 +01:00
Marek Safar 4014060cca Reflect shared code changes 2019-03-18 11:12:40 +01:00
Levi Broderick 9ef79a5156 Make more types eligible for vectorized code paths in MemoryExtensions (#20855)
Types like sbyte, ushort, and other 8-bit / 16-bit elemental types are now directed down the fast vectorized code paths that previously only byte and char were eligible for.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-18 11:12:40 +01:00
monojenkins e52716f9a0 [bcl] Update BCL Linked Size 2019-03-18 11:08:16 +01:00
EgorBo 88acef1575 fix formatting 2019-03-18 10:49:06 +01:00
Egor Bogatov 253753bdb7 Add failing tests 2019-03-18 10:49:06 +01:00
Egor Bogatov 0801bfe4aa fix bug 2019-03-18 10:49:06 +01:00
Egor Bogatov 0d48237457 fix case when InlineData's type != ParameterType 2019-03-18 10:49:06 +01:00
Zoltan Varga 8b9d89b150 [netcore] Fix running tests. (#13493)
* [netcore] Fix running the tests.

* [netcore] Implement missing enum icalls.
2019-03-17 20:55:49 -04:00
Marek Safar fc7ab5076e Adapt shared Enum 2019-03-17 13:42:00 +01:00
Egor Bogatov 5df1bae25d Move Enum and CorElementType to shared (dotnet/coreclr#23177)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-17 13:42:00 +01:00
Sung Yoon Whang bc420a440e Fixing some payload serialization issue on new EventCounters (#23295)
* Fixing some payload serialization issue on new EventCounters

* Fix build error

Signed-off-by: dotnet-bot <[email protected]>
2019-03-17 08:09:21 +01:00
Nikita Potapenko cfa37ea29b Fix typo (dotnet/coreclr#23300)
.Net -> .NET

Signed-off-by: dotnet-bot <[email protected]>
2019-03-16 18:44:58 +01:00
sancheolz 1ca9fcc201 Fix local variable assign
Local variable must be assigned before use
2019-03-16 10:30:49 +01:00
[email protected] f278deee46 Fix Stackoverflow when SplitContainer`s SplitterDistance setted in SplitterMoved event subscription 2019-03-16 10:30:49 +01:00
monojenkins 9522ae42bb [bcl] Update BCL Linked Size 2019-03-16 10:22:50 +01:00
Zoltan Varga a0d0209fb1 [netcore] Add support for running tests.
* Move the sdk download from netcore/sample/Makefile to netcore/Makefile
* Add targets for running the System.Runtime.Tests test suite.
2019-03-16 10:20:51 +01:00
Jay Krell d34b6da0d8 [Coop] Convert ves_icall_System_Globalization_CultureData_fill_number_data. (#13477)
* [Coop] Convert ves_icall_System_Globalization_CultureData_fill_number_data.

Tested by running this program:
```
class A
{
	public static void Main()
	{
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.CompareInfo);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.DateTimeFormat.AMDesignator);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.DateTimeFormat.DateSeparator);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.DisplayName);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.EnglishName);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.IsNeutralCulture);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.IsReadOnly);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.LCID);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.Name);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.NativeName);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.NumberFormat.CurrencySymbol);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.NumberFormat.NumberDecimalDigits);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.NumberFormat.NumberDecimalSeparator);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.Parent);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.TextInfo);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.ThreeLetterISOLanguageName);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.ThreeLetterWindowsLanguageName);
		System.Console.WriteLine(System.Globalization.CultureInfo.CurrentUICulture.TwoLetterISOLanguageName);
	}
}
```

which covers some but not all of the data.

*  - Use gint32 instead of int when interfacing directly with managed code.
   Indirectly would be passing the parameter off to additional native code; compiler
   can often silently convert.
   int will always be 32 bits.

 - Expand tedious error-prone code instead of using preprocessor to automate.

 - Add comments that the native and managed types must match.

 - Rename the managed type to match the native type (not necessary,
   but might as well have them grep perfectly coincidentally.).

 - Sort the fields and some of their uses for easier reading.
 It might be infinitesimally faster to line up the order
 with the native structure, to synchronize access order (i.e. sequential access to all).

 - Restore parameter name to number_index.

 - Validate, with assert, number_index maximum not just minimum.

* Restore the group_sizes logic.
group_sizes is an array of up to two integers, -1 terminated.

* restore const

* Add comment explaining the ordered -- sorted alphabetically.
2019-03-15 16:56:41 -04:00
Larry Ewing e61f00cd2d Merge pull request #12984 from kjpou1/wasm-typed-arrays
[wasm] Typed Array support for better memory usage
2019-03-15 15:36:17 -05:00
Jo Shields 0f457095e5 Don't produce nunit-console scripts in bin/ (#13480)
NUnit bundle is gone, these scripts are empty and useless

```
10:27:45  DEBUG: Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/mono-core-6.1.0.462-0.nightly.1.epel6.x86_64
10:27:45  DEBUG: BUILDSTDERR: error: Installed (but unpackaged) file(s) found:
10:27:45  DEBUG: BUILDSTDERR:    /usr/bin/nunit-console
10:27:45  DEBUG: BUILDSTDERR:    /usr/bin/nunit-console2
10:27:45  DEBUG: BUILDSTDERR:    /usr/bin/nunit-console4
10:27:45  DEBUG: RPM build errors:
10:27:45  DEBUG: BUILDSTDERR:     Installed (but unpackaged) file(s) found:
10:27:45  DEBUG: BUILDSTDERR:    /usr/bin/nunit-console
10:27:45  DEBUG: BUILDSTDERR:    /usr/bin/nunit-console2
10:27:45  DEBUG: BUILDSTDERR:    /usr/bin/nunit-console4
```
2019-03-15 19:16:15 +01:00
Johan Lorensson 36a2cabc7b Default to sgen on Windows x64. (#13473)
Since Boehm is not supported on Windows x64 we should set sgen as default
GC instead of forcing the use of --disable-bohem.
2019-03-15 12:12:10 -04:00
lateralusX 47ee8c8f46 Excluded some additional none Windows sources from win32_build/winaot profile. 2019-03-15 17:02:48 +01:00
Zoltan Varga db12fc8666 [wasm] Update to emscripten 1.38.29. 2019-03-15 10:33:37 -05:00
Justin Van Patten 202a217e15 Collection<T>: Validate parameters in the public methods (#23166)
I was looking over the new Range methods on `Collection<T>` and it occurred to me that for all existing methods, parameter validation is done in the *public* methods before calling the *protected virtual* methods. This changes the new Range methods to do the same.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-15 16:01:50 +01:00
lateralusX dab3cc35c0 Windows full AOT build scripts update.
* Only do clean/rebuild when an assembly changed.
* Add wrappers for different full AOT build configurations.
* Make scripts callable from different working directory.
2019-03-15 15:58:50 +01:00
Alexander Köplinger cfb3704940 [eglib] Remap g_utf16_len and g_utf16_len to monoeg_ prefix (#13476)
They fail a xamarin-macios public symbols check otherwise (monoeg_ is whitelisted).
2019-03-15 15:56:05 +01:00
Johan Lorensson f375ffd08c Merge pull request #13472 from lateralusX/lateralusX/enable-all-ci-tests-llvm-windows
Enable all CI test suites for Windows x64 full AOT + LLVM.
2019-03-15 10:27:13 -04:00
Zoltan Varga 9cdb5b4a12 [llvm] Fix receiving rgctx argument in DIM methods, they receive the mrgctx even if they are not generic. 2019-03-15 14:34:24 +01:00
Jo Shields 85ccf3ec02 Merge pull request #13437 from DavidKarlas/patch-1
Fix generating `.dSYM` for GTK assemblies
2019-03-15 09:15:15 -04:00
Bernhard Urban 4a2e7ce6f9 [mini] Remove public symbol helper_sig_llvmonly_imt_trampoline (#13462)
Fixes Xamarin.Tests.Misc.PublicSymbols test.
2019-03-15 12:34:43 +01:00
Marek Safar 2fa8290b7a Update for shared partition change 2019-03-15 11:20:43 +01:00
Egor Bogatov 6b2958e199 Move TypeLoadException to shared (dotnet/coreclr#23238)
* fix coding-style

* shorter form for TypeName property

* move coreclr-specific ctor to TypeLoadException

Signed-off-by: dotnet-bot <[email protected]>
2019-03-15 11:20:43 +01:00
Kenneth Pouncey b9bc111f01 Address review comments - Rename HostObjectInterface to IHostObject 2019-03-15 10:52:21 +01:00
Larry Ewingandkjpou1 e00dc00649 Update sdks/wasm/binding_support.js
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:34:16 +01:00
Larry Ewingandkjpou1 953acc3afd Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:32:57 +01:00
Larry Ewingandkjpou1 dd92015bbd Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:32:32 +01:00
Larry Ewingandkjpou1 caedcc8270 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:32:15 +01:00
Larry Ewingandkjpou1 e346211299 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:31:58 +01:00
Larry Ewingandkjpou1 e3a1b8714e Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:31:36 +01:00
Larry Ewingandkjpou1 b325eaacd1 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:31:10 +01:00
Larry Ewingandkjpou1 892b7ac039 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/ArrayBuffer.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:30:52 +01:00
Larry Ewingandkjpou1 4d17766a23 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:29:54 +01:00
Larry Ewingandkjpou1 e3ed42a492 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:29:37 +01:00
Larry Ewingandkjpou1 670b032653 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:29:22 +01:00
Larry Ewingandkjpou1 a4bb7611b8 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:29:11 +01:00
Larry Ewingandkjpou1 57aa52db5a Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:28:23 +01:00
Larry Ewingandkjpou1 6ff0679677 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/Array.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:28:06 +01:00
Larry Ewingandkjpou1 3e4706cf24 Update sdks/wasm/framework/src/WebAssembly.Bindings/Core/ArrayBuffer.cs
Co-Authored-By: kjpou1 <[email protected]>
2019-03-15 10:27:51 +01:00
Kenneth Pouncey 7708f047d6 Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays 2019-03-15 09:35:47 +01:00
Marek Safar 0bd836b2f2 [System.Private.CoreLib] Remove unused variables from TypeNameParser 2019-03-15 09:28:07 +01:00
Marek Safar 25abfa4a3f [System.Private.CoreLib] Small StackTrace cleanup 2019-03-15 09:27:41 +01:00
lateralusX d06927eecf Move SafePasswordHandle to win32_build_corlib profile. 2019-03-15 09:20:03 +01:00
lateralusX 8a77ff6c05 Reverting changes to TimeZoneInfo test when reducing classes in corlib winaot. 2019-03-15 09:20:03 +01:00
lateralusX e36be73ffb Reduce number of classes in winaot mscorlib.
Winaot profile should be a Windows AOT friendly profile close to mobile
and consoles. At some point it was set to include the full net_4_x that
cause problems on none desktop platforms. This fix reduce the set to only
include classes similar to mobile and console profiles.
2019-03-15 09:20:03 +01:00
lateralusX 3fabfccb73 Enable all CI test suites for Windows x64 full AOT + LLVM. 2019-03-15 08:50:43 +01:00
Egor Bogatov e8a66f38da bump netcore sdk version 2019-03-14 23:39:05 +01:00
lateralusX 8a6a8b7f88 Fix missing llc options for Windows x64 full AOT + LLVM mini regression tests. 2019-03-14 16:39:36 -04:00
Vlad Brezae 73ff4a7434 [interp] Make sure we call init before registering counters (#13457)
[interp] Make sure we call init before registering counters
2019-03-14 15:55:56 -04:00
Jo Shields cd8dc77a8e [win] Don't try to install NUnit 2.4, it's dead now 2019-03-14 15:01:34 -04:00
Alexander Kyte b20b86ff11 Merge pull request #13247 from lateralusX/lateralusX/fix-llvm-dwarf-cfi-windows-x64
Fix LLVM Dwarf CFI on Windows x64. Bump to corresponding LLVM commit.
2019-03-14 13:30:48 -04:00
Kenneth Pouncey 9f2dd3f554 [wasm][doc] Add Packager doc (#13411)
* Add Packager doc

* Fix numbering

* Address review comments

Packager.exe to packager.exe

* Move packager readme doc from getting started as per review comment.

* - Addresses review comment -- Fix emdash in `packager.exe -help` command line.

* Fix command line argument -- instead of single -
2019-03-14 17:45:56 +01:00
Vlad Brezae 620a46d8f2 [profiler] Fix vtune build (#13390)
[profiler] Fix vtune build
2019-03-14 11:19:47 -04:00
Marek Safar c194209317 [netcore] Generate full project setup in gen-xunit-runner 2019-03-14 14:35:29 +01:00
Jb Evain 959fbda60a [sdb] Add property AssemblyMirror.HasDebugInfo (#13353)
* [sdb] Add property AssemblyMirror.HasDebugInfo

* Fix mono_debug_image_has_debug_info to work with ppdb

* Bump API snapshot submodule
2019-03-14 09:44:17 +01:00
Aleksey Kliger (λgeek) c0b48793db Custom modifier equivalence, duplication, appending and inflation (#13320)
This all stems from ECMA 335, 7.1.1:

> The CLI itself shall treat required and optional modifiers in the same
> manner. Two signatures that differ only by the addition of a custom
> modifier (required or optional) shall not be considered to match. Custom
> modifiers have no other effect on the operation of the VES.

This rule means that when comparing signatures, we have to treat two types that
differ only in their custom modifiers as distinct. In particular, we have to do
this when comparing signatures in order to fill in the vtable for a class.  And
moreover, we have to concatenate custom modifiers when doing generic
instantiation.  If a method in a generic type has signature `T modopt(IsConst)
Method()` and we instantiate T with `int32 modopt(IsLong)`, we are expected to
produce the signature `int32 modopt(IsConst) modopt(IsLong) Method()` (with the
custom modifiers on `int32` in that order).

So this PR implements the following operations:
1. custom modifier appending during `mono_metadata_type_dup_with_cmods`
2. custom modifier-respecting comparison in `do_mono_metadata_type_equal`

To do this, we actually have to introduce a second representation of custom
modifiers: in the normal representation, all the cmod type specs come from a
single image.  Whereas now, due to inflation of signatures, we can have a mix
of modifiers from different images.  So in the MonoAggregateModContainer
representation, we pair each typespec token with the image in which it is to be
resolved.

We keep the old representation (a single image to resolve the entire set of
typespec tokens) because it's natural when you're just reading from a single
image.  Also this representation is part of the embedding API.

---

### But that's not all ###


It is possible for generic parameters of a generic class to appear in the
_custom modifiers_ of a type in a method signature.  For example:
```
    T modopt(Nullable`1<T>) Method ()
```

In this case, when we inflate this signature, we need to inflate not only the
return type, but also the modifiers on a return type.

That means our old aggregate representation (where each modifier is a pair of a
MonoImage and a typespec token) is inadequate: we can inflate a signature and
get a custom modifier that doesn't appear as a typespec in any table of any
existing image.

This is the same situation as generic instances: as a program runs, it creates
generic instances that are not part of the source code.  So we solve it the
same way as with generic instances.

Our new `MonoAggregateModContainer` representation is a pointer into memory owned
by a MonoImageSet that contains an entire MonoType for each custom modifier.

The invariant is that the aggregate modifier container is allocated from a
mempool of a `MonoImageSet` that includes the images of all the modifiers.

In general, when inflating, we first create a provisional candidate
MonoAggregateModContainer on the stack and then look it up the image set that
should own it and then look for a "canonical" mod container in the
`MonoImageSet:aggergate_modifiers_cache`

---

Also had to bump the AOT image format, which now always reads back in using the aggregate representation.

---

This should address #10564, #10565, #12422, #10945 (again), #6936, and the parts of #11350 that **don't** deal with arrays.

---

TODO:

- [x] Add some representative test cases to this PR.
- [ ] Modify our acceptance tests to run the various disabled Roslyn tests.
2019-03-14 09:16:42 +01:00
Johan Lorensson 557d8406f6 Merge pull request #13444 from lateralusX/lateralusX/fix-simd-llvm-issue
Fix error in SIMD test on Windows x64 LLVM due to changed llc defaults.
2019-03-14 03:43:12 -04:00
Maxim Lipnin 55fbd14763 Remove nunit24 from mono build and tree (#13415)
* Remove nunit24 from mono build and tree

* More cleanup

* Fix build

* [csproj] Update project files
2019-03-13 23:47:39 +01:00
Levi Broderick f62dfab807 Add OperationStatus-based UTF8 transcoding APIs (dotnet/coreclr#23219)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-13 23:46:08 +01:00
Alexander Kyte 1a574284ac [crash] Fallback to MAP_ANONYMOUS for allocator
This is helpful by allowing the crash reporter to work even while
unable to write to the working directory.
2019-03-13 14:30:57 -04:00
Zoltan Varga 8fed6666b0 Address review comments. 2019-03-13 17:52:11 +01:00
Zoltan Varga dfb3ebd706 [netcore] Improvements to gen-xunit-runner.
* Add support for response files.
* Fix encoding of small primitive types.
* Print number of run/failed/skipped tests.
2019-03-13 17:52:11 +01:00
Zoltan Varga 23fea25e80 [netcore] Define COMPlus_DebugWriteToStdErr=1 in make run to enable debug logging. 2019-03-13 17:52:11 +01:00
Zoltan Varga c3d77000a7 [netcore] Test fixes.
* EqualityComparer.cs: Add LastIndexOf ().
* RuntimeAssembly.cs: Implement	       CreateAssemblyName ().
* AssemblyLoadContext.cs: Handle windows paths.		  Add DoAssemblyResolve () method.
* Array.cs: Add/fix error handling. Implement LastIndexOf ()/GetRawArrayData ().
* Attribute.cs:	    Implement.
* Buffer.cs: Add/fix error handling.
* DefaultBinder.cs: Implement.
* RuntimeType.cs: Implement HasSameMetadataDefinitionAs ().
* RuntimeEventInfo.cs: Ditto.
* RuntimeFieldInfo.cs: Ditto.
* RuntimeMethodInfo.cs: Ditto.
* RuntimePropertyInfo.cs: Ditto.
* MonoCustomAttrs.cs: Add eror handling. Implement inheritance support for parameters.
* gc.cs: Fix error handling.
* rttype.cs: Fix handling of null namespaces.
2019-03-13 17:52:11 +01:00
Zoltan Varga aa949e2114 [runtime] Add more error checking and special cases to the Array get/set icalls. 2019-03-13 17:52:11 +01:00
Zoltan Varga 46ae93a23c [runtime] Add a few more m_class accessors. 2019-03-13 17:52:11 +01:00
Zoltan Varga d5feee9c71 [runtime] Fix the ordering of the Buffer icalls. 2019-03-13 17:52:11 +01:00
Zoltan Varga 3dcee3319e [runtime] Avoid asserting if AppDomainUnloadedException is not found. 2019-03-13 17:52:11 +01:00
Zoltan Varga 7f9cb785f2 [runtime] Fix the creation of argument exceptions in netcore, the layout of ArgumentException is no longer visible to the runtime. 2019-03-13 17:52:11 +01:00
Zoltan Varga d7ba254448 [jit] Fix a IL verification error which the netcore tests run into. 2019-03-13 17:52:11 +01:00
Ankit Jain 4cb9a914f0 [msbuild] Update to track upstream vs16.0 branch (#13053) 2019-03-13 16:40:05 +01:00
Michal Strehovsky 90bdd5da71 Fix missed RelocatedType annotation
[tfs-changeset: 1735855]

Signed-off-by: dotnet-bot <[email protected]>
2019-03-13 15:58:58 +01:00
Aleksey Kliger d28aab8d56 [class-init] Take loader lock around mono_class_setup_interface_id_internal
Writing to MonoClass:interface_id must be done with the loader lock held.

Fixes assertion:
```
* Assertion at class-init.c:1830, condition `i == 0 || interfaces_full [i]->interface_id >= interfaces_full [i - 1]->interface_id' not met
```
2019-03-13 10:54:07 -04:00
lateralusX 9b440da1f2 Fix error in SIMD test on Windows x64 LLVM due to changed llc defaults. 2019-03-13 15:52:48 +01:00
Johan Lorensson eaa5805af7 Merge pull request #13393 from lateralusX/lateralusX/fix-build-warning-local-global
Fix build warning, local variable hides global.
2019-03-13 08:39:02 -04:00
Rolf Bjarne Kvinge a72e7ffc0d Revert "[mini] Inline Selector.GetHandle for tvOS and watchOS assemblies as well. (#13246)" (#13418)
Revert "[mini] Inline Selector.GetHandle for tvOS and watchOS assemblies as well. (#13246)"

This reverts commit c99fe4b462.

It doesn't work when LLVM is enabled for tvOS: https://github.com/xamarin/xamarin-macios/pull/5742#issuecomment-471007078, it causes multiple compilation errors like this:

    Process exited with code 1, command:
    /Applications/Xcode101.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang  -isysroot /Applications/Xcode101.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/SDKs/AppleTVOS12.1.sdk -Qunused-arguments -mtvos-version-min=12.1 -fembed-bitcode-marker -arch arm64 -c -o /private/var/folders/nh/n1y9qj2n40d7wpmx1mg9blg80000gn/T/mtouch.cache/arpl1vgs.js6/arm64/Xamarin.TVOS.dll-llvm.o -x assembler /private/var/folders/nh/n1y9qj2n40d7wpmx1mg9blg80000gn/T/mtouch.cache/arpl1vgs.js6/arm64/Xamarin.TVOS.dll-llvm.s
    /private/var/folders/nh/n1y9qj2n40d7wpmx1mg9blg80000gn/T/mtouch.cache/arpl1vgs.js6/arm64/Xamarin.TVOS.dll-llvm.s:4665:14: error: invalid variant 'OBJC_SELECTOR_REFERENCES_.2@PAGE'
            adrp    x8, l_@OBJC_SELECTOR_REFERENCES_.2@PAGE
                           ^
    /private/var/folders/nh/n1y9qj2n40d7wpmx1mg9blg80000gn/T/mtouch.cache/arpl1vgs.js6/arm64/Xamarin.TVOS.dll-llvm.s:4673:18: error: invalid variant 'OBJC_SELECTOR_REFERENCES_.2@PAGEOFF'
            ldr     x1, [x8, l_@OBJC_SELECTOR_REFERENCES_.2@PAGEOFF]




<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-03-13 08:05:48 -04:00
Alexis Christoforides f934b60854 [MacSDK] Bump Nuget to 4.8.2 2019-03-13 11:28:58 +01:00
Marek Safar fa7b007914 [System.Private.CoreLib] Remove duplicate checks 2019-03-13 10:35:25 +01:00
Sung Yoon Whang 6e85a0fb99 Add new counter APIs (dotnet/coreclr#23077)
* Refactor EventCounter and add PollingCounter

* Add PollingCounter

* Add IncrementingEventCounter and IncrementingPollingCounter

* Add MetaData API to Counters

* Some more refactoring

* removing commented out code

* some more cleanup

* build fix and addressing some PR comments

* Addressing PR feedback

* use StringBuilder to generate metadata string

Signed-off-by: dotnet-bot <[email protected]>
2019-03-13 10:03:41 +01:00
David Karlaš a716c9ad7b Fix generating .dSYM for GTK assemblies
Problem is that https://github.com/mono/bockbuild/blob/14535c270ea9f8d536efe6852700d8d1cb657c1f/packages/gtk%2B.py#L4 passes `gtk` for repository name to `GitHubPackage` which then uses this as package name. So when it's decided if `-g` should be added at https://github.com/mono/bockbuild/blob/5c2378112dc681cea0aa5c2447661fb13adbc46b/bockbuild/darwinprofile.py#L158-L159 it's false hence GTK assemblies don't get debug symbols.
2019-03-13 09:39:22 +01:00
Calvin Buckley 55d913c2d3 Bump corefx for System.Native posix_fadvise change (#13409) 2019-03-13 02:18:47 +01:00
Tanner Gooding cde76c1521 Fixing a couple of issues in the Utf8Parsing/Formatting code (#23134)
* Fixing NumberToSingle and NumberToDouble to handle DigitsCount == 0

* Fixing Utf8Formatter.Float to transcode non ASCII bytes

* Responding to PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-03-12 22:42:53 +01:00
Alexander Köplinger d884bd3e12 [corlib] Fix RuntimeFeatureTest.NoNewFeaturesAdded()
DefaultImplementationsOfInterfaces was enabled with https://github.com/mono/mono/pull/13417
2019-03-12 21:03:06 +01:00
Alexander Köplinger 92b435d6fe Move drawing types for XI/XM/wasm/orbis/unreal to System.Drawing.Common (#13414)
* Move drawing types for XI/XM/wasm/orbis/unreal to System.Drawing.Common

For XI/XM they were in Xamarin.iOS.dll/OpenTK-1.0.dll before.

For wasm/orbis/unreal we remove System.Drawing.dll from the profiles and
add the types to System.Drawing.Common.dll instead to align with the other
mobile profiles (only "net_4_x" and "build" still have System.Drawing.dll).

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-12 18:07:19 +01:00
Joshua Peterson 244c1aab8e Fix a possible crash while printing a warning (#13399)
The format string was incorrect in this case, which leads to a crash
in Unity. Simply remove the unused `%s` format specifier here.
2019-03-12 18:03:58 +01:00
monojenkins fb8554d76f [csproj] Update project files 2019-03-12 17:26:20 +01:00
monojenkins 0a85578bd0 Bump API snapshot submodule 2019-03-12 17:26:20 +01:00
Zoltan Varga 522a46dcac [corlib] Define FEATURE_DEFAULT_INTERFACES so RuntimeFeatures indicates DIMs are supported. 2019-03-12 17:26:20 +01:00
Kenneth Pouncey 205bb1666a [wasm][tests] Add WebSocket tests 2019-03-12 14:57:50 +01:00
Zoltan Varga 00c837d66a [netcore] Implement Type.GetType () overloads with assembly/type resolve delegates. (#13410)
Instead of extending the runtime gettype implementation, port the type parsing code
to C#.
2019-03-12 13:01:34 +01:00
Zoltan Varga ec7b9ec409 [jit] Implement Unsafe:ByteOffset<T> intrinsic. 2019-03-12 12:19:51 +01:00
Kenneth Pouncey 38ec3156f5 Address review by @Suchiman after conflict resolution. Thanks for the catch. 2019-03-12 11:02:28 +01:00
Kenneth Pouncey 9a73ea12b7 Confilct with Runtime.cs
Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays

# Conflicts:
#	sdks/wasm/framework/src/WebAssembly.Bindings/Runtime.cs
2019-03-12 10:11:04 +01:00
Larry Ewing 4ff1307e21 Remove all use of ContainsKey from js bindings (#13376) 2019-03-12 09:18:09 +01:00
Maxim Lipnin ad5fe197a3 Add reflected type to event methods (#13397)
Fixes https://github.com/mono/mono/issues/13350
Fixes https://github.com/mono/mono/issues/10277
2019-03-12 08:32:40 +01:00
Hugh Bellamy 030111234e Fix NRE in EqualStringArrays (dotnet/coreclr#23174)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-11 22:35:21 +01:00
Michal Strehovský 07c383b829 Replace Delegate.CreateDelegate (dotnet/corert#7147)
Replacing this with a pattern that is easier to statically analyze. We use the GetType/GetMethod/CreateDelegate pattern in several places already.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-11 22:20:53 +01:00
Alexander Köplinger b92a105992 [configure.ac] Fix configure checks for Mono.Native (#13395)
When the configure checks were ported from configure.cmake in corefx
a couple of mistakes happened:

- Using AC_TRY_COMPILE instead of AC_TRY_LINK:
  CMake's check_c_source_compiles() function compiles *and* links while
  AC_TRY_COMPILE only does the former. This hides potential linking issues
  which should fail the configure check.
- Using CFLAGS="-Werror -W....":
  This works in CMake but autoconf always appends the previously defined
  CFLAGS and since we set e.g. `-Wno-undefined` some configure checks
  would fail due to an unrelated warning being treated as an error.
  We need to only promot specific warnings to errors instead.

While looking at this I also found that we were setting CFLAGS after
we already AC_SUBST() it, we need to do this very close to the end of configure.ac.
Moved some code into that last block.

Finally, Android has special cases for sendfile and arc4random_buf where
they're defined in the header but aren't actually there for certain API profiles.
For now we disable arc4random_buf on Android and add a special check for sendfile.

* Fix sendfile with 6 parameters being misdetected

We need to make sure to actually prevent the implicit prototype since
in this case sendfile with different set of parameters actually exists
so the linker wouldn't fail.

Also fixed a few other cases of wrong configure checks due to missing headers.

* Move GSS checks into the Mono.Native checks section

This allows us to have a 1:1 mapping of the checks from configure.cmake
2019-03-11 20:36:40 +01:00
Thays Grazia 3537672955 [debugger] Fixing two crashes while debugging an Android app. (#13373)
* [debugger] Fixing two crashes while debugging an Android app.

-> Doing stepping into in VSM in some situation the frame saved in TLS is not synchronised with what is really been executed in the main thread. This makes the debugger-agent crashes because it tries to get variable info in some memory that is not available anymore.
	-> To fix it I forced the update of stack when CMD_THREAD_GET_FRAME_INFO is called.

-> Doing step over in Visual Studio for Windows, if you have the threads debugger window enabled, VSW calls frame_commands for each thread that is showed, and if the thread is not really_suspended it tries to get variable info from a memory that is not available anymore because the thread is not suspended yet.
	-> To fix it I don't send variable info of a frame if the thread is not really_suspended and doesn't have an async_state valid.

#Fixes 12843
2019-03-11 15:55:47 -03:00
Alexander Köplinger 0d7ce1f767 Fix build on Alpine Linux (#13394)
- sys/sysctl.h isn't available on Alpine and not needed by the code,
  guard it using HAVE_SYS_SYSCTL_H like elsewhere. Added by https://github.com/mono/mono/pull/11855

- pthread_mutexattr_setprotocol doesn't support PTHREAD_PRIO_INHERIT,
  check return value. Added by https://github.com/mono/mono/pull/13333
2019-03-11 16:59:44 +01:00
Kenneth Pouncey cbe835d0c1 Use new HostObject instead of NewJSObject. 2019-03-11 15:36:33 +01:00
Kenneth Pouncey 911b21dff4 Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays
# Conflicts:
#	sdks/wasm/framework/src/WebAssembly.Net.Http/WasmHttpMessageHandler.cs
2019-03-11 15:24:26 +01:00
Egor Bogatov d0013e438c Add System.Drawing converters to netstandard facade (#13326)
This PR adds missing System.Drawing converters thus it completes NS2.1 support (as of today) for all profiles except macOS\IOS specific ones: monotouch, tv, watch, xammac, xammac_net_4_5.
2019-03-11 13:23:31 +01:00
Zoltan Varga db67d18d0d [netcore] Ongoing work. (#13391)
* [runtime] Add a few new m_class inline functions.

* [netcore] Implement Array.IndexOf ().

* [netcore] Implement RuntimeHelpers.PrepareMethod ().

* Add error checks to RuntimeHelpers.GetUninitializedObject ().
* Fix some type attributes.
* Fix some TypedReference special cases.
2019-03-11 08:16:21 -04:00
Zoltan Varga 38a2639fc1 [netcore] Fix build. (#13392)
* [netcore] Fix build.

* Update Buffer.cs
2019-03-11 12:57:44 +01:00
lateralusX ce3bbb011b Fix build warning, local variable hides global.
On Windows MSVC build this cause:

warning C4459: declaration of 'mono_cfg_dir' hides global declaration
2019-03-11 12:36:25 +01:00
Johan Lorensson ed3039b377 Merge pull request #13367 from lateralusX/lateralusX/fix-windows-build-warning
Fix build warning in mono-error.h.
2019-03-11 07:12:29 -04:00
Kenneth Pouncey b124b51066 Address review comments.
- Cleanup docs.
- Cleanup implicit conversions.
- Remove ToSpan()
2019-03-11 12:02:11 +01:00
Zoltan Varga ea761357f8 [jit] Reenable the EqualityComparer:Default devirt optimization. (#13321) 2019-03-11 06:09:59 -04:00
Calvin Buckley e9e52de223 Fix System.Decimal regression from .NET Core on big endian (#13348)
Upstream must have rewritten, because the runtime checks were
replaced with the (not good for Mono) ifdefs.

Not throughly tested, but unbreaks build locally; waiting for CI
to come back with more results.

If it works, could someone get this upstream?
2019-03-11 10:20:49 +01:00
Johan Lorensson a91e3f162a Merge pull request #13366 from lateralusX/lateralusX/add-missing-public-header-to-dist
Include mono-forward.h public header on Windows.
2019-03-11 04:29:42 -04:00
monojenkins 0e804950b5 [csproj] Update project files 2019-03-11 09:11:16 +01:00
monojenkins 0086403d54 Bump API snapshot submodule 2019-03-11 09:11:16 +01:00
Steve Pfister a49d5df03f These changes help prep for refsrc System.Web
* DynamicRoleClaimProvider to help with legacy role management in web forms
* Added AppDomainManagerAssembly, AppDomainManagerType, and PartialTrustVisibleAssemblies
  properties to AppDomainSetup. They don't do anything, but having  them there
  helps lessen the amount of change in refsrc System.Web.
2019-03-11 09:11:16 +01:00
Larry Ewing b5082160c3 Remove linq usage from WasmHttpMessageHandler 2019-03-11 09:10:59 +01:00
Levi Broderick 31b5a4554a Refactor Encoding to split fast-path and fallback logic (#23098)
This refactoring is limited to ASCIIEncoding at the moment, but it can easily be applied to UTF-8 / UTF-16 / UTF-32.

High-level changes:
- Fallback logic has been split from the fast-path, improving performance of GetBytes and similar routines.
- All of the plumbing of when to invoke the fallback logic and how to manage leftover data has been moved into the base class.
- Almost all of the logic except for the fast-path is now written in terms of verifiable code (Span and ReadOnlySpan).
- Minor bug fixes in EncoderNLS.Convert (see https://github.com/dotnet/coreclr/issues/23020).

Signed-off-by: dotnet-bot <[email protected]>
2019-03-11 09:05:29 +01:00
monojenkins db6ee0108b [bcl] Update BCL Linked Size 2019-03-11 09:01:51 +01:00
Bernhard Urban 2eeaf888c1 [AOT] add option to control arguments to llc and add fallback for x86 (#13323)
* [AOT] add option to control arguments to llc and add fallback for x86

Fixes https://github.com/mono/mono/issues/12182

* rename
2019-03-11 08:40:22 +01:00
Kenneth Pouncey 24a0e0d7f2 Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays 2019-03-11 06:23:29 +01:00
monojenkins 3489679dc5 Bump API snapshot submodule 2019-03-10 13:11:12 +01:00
Steve Pfister 063f2a2b9a Added missing ToolLocationHelper methods that will be
used by refsrc System.Web.Compliation.AssemblyResolver.
2019-03-10 13:11:12 +01:00
Larry Ewing 5dbf642965 Add Blazor E2E test to wasm bcl-size-diff 2019-03-10 13:11:01 +01:00
Kurt Van Dijck 3e8108ea65 threads: set mutex PRIO_INHERIT in attribute (#13333)
threads: set mutex PRIO_INHERIT in attribute

When running multiple threads on a linux-rt kernel, with different priorities, the lack of priority-inheritance
makes the kernel make wrong scheduling choices.
This commit changes the system-wide mutex initializers.
This change protects our system against unexpected latencies in higher priority threads.

<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-03-09 23:35:34 -05:00
Marek Safar 4259cfad8f Remove local Buffer copy 2019-03-10 00:56:08 +01:00
Egor Bogatov 8a3a41b81a Move Buffer to shared (dotnet/coreclr#23157)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-10 00:56:08 +01:00
Dan Moseley 73caa49efb Remove 2 suffix step 1 (dotnet/corefx#35904)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-10 00:56:08 +01:00
Stephen Toub d5b0333f37 Add stack depth check to all Task continuations (dotnet/coreclr#23152)
Currently Task has a stack depth check that avoids stack overflows on very deep stack continuation chains, but it only applies to Task.ContinueWith, not to other kinds of continuations.  This changes that to have it apply to all.

As part of this, this also deletes the current StackGuard type used to achieve the check.  The type was meant to avoid expensive calls to check where we are on the stack, but now that we're using TryEnsureSufficientExecutionStack, it's actually faster to just call that rather than access the current StackGuard from a ThreadLocal.  This then also cleans up the call sites nicely, as they no longer need finally blocks to undo the increment performed on the StackGuard.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-09 17:48:20 +01:00
Zoltan Varga 92dfcb120b [netcore] Use codedom for code emission in the xunit generator. Add support for Theories and inline data. 2019-03-09 11:52:49 +01:00
Zoltan Varga 0f798ae6cf [netcore] Ongoing work. (#13357)
* [netcore] Implement MethodBody using internal Runtime* classes. Use the mono version for ModuleHandle.

* [netcore] Reflection fixes.

* Address review comments.

* [netcore] Implement RuntimeHelpers:GetUninitializedObject ().

* [netcore] Implement the Type::GetMethod () overload which has a genericParameterCount parameter.

* [netcore] Implement Thread.OptimalMaxSpinWaitsPerSpinIteration.

* Revert a change to fix a test failure.

* [netcore] Implement Marshal:GetExceptionForHRInternal ().

* [netcore] Implement GC:GetSegmentSize ().

* [runtime] Allow pointer type members in typed references.
2019-03-09 05:26:40 -05:00
Marek Safar dd0e9a8aa3 Fix the build 2019-03-09 09:27:46 +01:00
Marek Safar 289eb40af4 Move part of RuntimeHelpers to shared partition (dotnet/coreclr#23130)
* Move part of RuntimeHelpers to shared partition

* Remove FormatterServices.cs

Signed-off-by: dotnet-bot <[email protected]>
2019-03-09 09:27:46 +01:00
Steve Pfister 0306c38fed Add refsrc DataProtector to System.Security (#13365)
* Added DataProtector abstract class to be used when refsrc
System.Web gets ported over.

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-09 01:07:53 +01:00
Zoltan Varga 4401acd172 [jit] Avoid an assert with default interface methods and gsharing.
Fixes https://github.com/mono/mono/issues/13319.
2019-03-09 00:55:39 +01:00
Dotnet-GitSync-Bot 8efb2906d2 Mirror changes from mono/coreclr,corert (#13375)
* Added new Range Manipulation APIs for Collection<T> which propogate up to ObservableCollection<T>. AddRange, InsertRange, RemoveRange and Replace Range

Signed-off-by: dotnet-bot <[email protected]>

* Updated index out of range exception check to be a single comparison

Signed-off-by: dotnet-bot <[email protected]>

* Updated foreach to use T instead of var

Signed-off-by: dotnet-bot <[email protected]>

* Adding braces on for loop

Signed-off-by: dotnet-bot <[email protected]>

* Added ReplaceItemsRange API and updated ReplaceRange to invoke the protected method

Signed-off-by: dotnet-bot <[email protected]>

* Remove ternary operator from invocation as it is the same as inputing items.Count

Signed-off-by: dotnet-bot <[email protected]>

* Updated RemoveItemsRange to prevent int.MaxValue overflow errors

Signed-off-by: dotnet-bot <[email protected]>

* Updated RemoveItemsRange to properly remove each item and not just the index items

Signed-off-by: dotnet-bot <[email protected]>

* Added ArgumentOutOfRangeException exception in RemoveRange if the count is less than 0

Signed-off-by: dotnet-bot <[email protected]>

* Updated RemoveRange invocation of RemoveAt to use index instead of i, because the array changes with each iteration of the for loop and will cause side-effects which may include index out of range exceptions. This needs to be index because as the array shrinks the index is always at the correct position.

Signed-off-by: dotnet-bot <[email protected]>

* Updated RemoveAt->RemoveItem. This change removes redundent validation checks that happen using the RemoveAt API. RemoveItem gives us direct access to invoke the command

Signed-off-by: dotnet-bot <[email protected]>

* Updated InsertItemsRange to simplify the expression and added performance improvements. If the underlying `items` is using List<T> we should use it's InsertRange method since it is optimized, othersie we use InsertItem

Signed-off-by: dotnet-bot <[email protected]>

* Added new RemoveRange validation check to see if the resulting range (index + count) > items.Count and if it is true throw ArgumentException

Signed-off-by: dotnet-bot <[email protected]>

* Removed (Int64) cast statements from RemoveItemsRange when checking for overflow errors

Signed-off-by: dotnet-bot <[email protected]>

* InsertItemsRange API now checks if the underlying items.IsReadOnly first then collection == null

Signed-off-by: dotnet-bot <[email protected]>

* Simplified the RemoveItem logic since we have more robust validation

Signed-off-by: dotnet-bot <[email protected]>

* Optimized RemoveItemsRange to call the list.RemoveRange if the items is of type List<T>

Signed-off-by: dotnet-bot <[email protected]>
2019-03-09 00:51:26 +01:00
Filip Navara 19258e1680 Allow deserialization for ResourceManager created with non-default resource set type (#23051)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-09 00:44:14 +01:00
Johan Lorensson 2e30dbab63 Correctly defined thread API support for different Windows platforms. (#13344) 2019-03-08 14:34:49 -05:00
Zoltan Varga 6c81f5dbd2 [sdb] Avoid stack overflows caused by recursive calls between suspend_current () and invoke_method (). (#13362)
Fixes https://github.com/mono/mono/issues/13261.
2019-03-08 14:20:36 -05:00
Johan Lorensson 4c57215ca9 Fix GetTokenName to fail with exception on none Windows desktop platforms. (#13343) 2019-03-08 12:38:56 -05:00
Johan Lorensson 526939e146 Better probing logic on Windows when Unicode Win32 symbols are used. (#13345)
Several of the corefx interop sources uses the Unicode names of Win32 symbols.
Our current probing implementation on Windows will test the given name last
when nomangle is not provided (default). On Windows that will be a large number
of probes due to old stdcall name mangling rules. Fix makes sure we first test
the symbol against its charset and the given symbol, before trying the stdcall
name mangling rules. Will reduce the probing a lot on Windows for corefx Win32
interop classes.
2019-03-08 12:35:56 -05:00
Larry Ewing 27197d3f15 Add System.Runtime.Serialization targets 2019-03-08 10:36:31 -06:00
Larry Ewing f2b8ec3b3d Move the disabled tests under INCLUDE_DISABLED 2019-03-08 10:36:31 -06:00
Larry Ewing ad4e0414cd Add DataContractSerializer test 2019-03-08 10:36:31 -06:00
Larry Ewing a7f4dea649 Add linker test for Queryable 2019-03-08 10:36:31 -06:00
Alexander Köplinger 566e4565f4 [corlib] Remove Interop.MountPoints.cs from .sources (#13363)
* [corlib] Remove Interop.MountPoints.cs from .sources

We no longer need it since https://github.com/mono/mono/pull/13125 and having
it included makes xamarin-macios still complain about the missing symbol.

* [csproj] Update project files
2019-03-08 17:19:09 +01:00
lateralusX 7014dc1f8c Fix LLVM Dwarf CFI on Windows x64. Bump to corresponding LLVM commit. 2019-03-08 16:33:17 +01:00
lateralusX 5d5cb61243 Fix build warning in mono-error.h.
Warning (at least on Windows) due to unamed struct:

C4201, nonstandard extension used : nameless struct/union

Since the header can be consumed by embedders this warning should be
disabled.
2019-03-08 16:11:14 +01:00
lateralusX e9183496fb Include mono-forward.h public header on Windows. 2019-03-08 15:35:10 +01:00
Kenneth Pouncey e0651ded29 Add exclude features option when linking to the sdk. (#13340) 2019-03-08 15:22:36 +01:00
Johan Lorensson f89fdf28a3 Fix build warning in full AOT build. (#13342) 2019-03-08 06:37:46 -05:00
Marek Safar 63a58325b5 Remove unused type 2019-03-08 09:50:42 +01:00
Marek Safar 841a1d49b7 Use platform specific implementation of GetCurrentProcessId (#23084)
* Use platform specific implementation of GetCurrentProcessId

directly in shared location instead of relying on runtime export

* Move GetCurrentProcessId to Interop class

* Update ES_BUILD_STANDALONE build

Signed-off-by: dotnet-bot <[email protected]>
2019-03-08 09:50:42 +01:00
Marek Safar 14b0f985de Merge pull request #13356 from monojenkins/bclsizediff
[bcl] Update BCL Linked Size
2019-03-08 09:38:42 +01:00
Jb Evain 297b6ba328 [sdb] Avoid double lookup of replay packets 2019-03-08 09:34:54 +01:00
Dávid Kaya 8fc751180c Added UserFlags field, unblocks #34560 (dotnet/corefx#35851)
* Added UserFlags field

* Added UserFlags

Signed-off-by: dotnet-bot <[email protected]>
2019-03-08 07:39:21 +01:00
monojenkins b5daa32188 [bcl] Update BCL Linked Size 2019-03-08 03:38:14 +00:00
Alexander Köplinger 8cd69e14e3 Update System.Net.Http.csproj
Change missed in https://github.com/mono/mono/commit/97adf2e53e20c127bc38cb4f64a43f55c77e5c7e
2019-03-07 23:41:22 +01:00
Stephen Toub ad819c8921 Add missing CopyToAsync override in FileStream.Unix.cs (#23101)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 23:38:17 +01:00
Zoltan Varga 11349df4e6 [netcore] Add a tool to convert corefx test assemblies into simple test runners. (#13346)
* [netcore] Add a tool to convert corefx test assemblies into simple test runners.

* Fix computation of traits.
2019-03-07 22:50:42 +01:00
Hugh Bellamy f6179a0e68 Cleanup Globalization info code (dotnet/coreclr#22591)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 22:24:52 +01:00
Martin Baulig 97adf2e53e HttpClient for Web Assembly. 2019-03-07 21:49:27 +01:00
Alexander Köplinger 2e4d4a040c [sqlmetal] Distribute DbLinq.snk in tarball 2019-03-07 19:05:05 +01:00
monojenkins dbcd755c86 Bump API snapshot submodule 2019-03-07 18:47:03 +01:00
monojenkins ebb8b6fff2 [csproj] Update project files 2019-03-07 18:47:03 +01:00
Martin Baulig 2d6f02a83c HttpClient for Android. 2019-03-07 18:47:03 +01:00
Vlad Brezae deebdd1489 [interp] Add a few starting stats (#13347)
* [runtime] Use same single convention for stats tracking time

Also avoid useless mallocs/frees

* [interp] Add counters for transform phase
2019-03-07 11:53:11 -05:00
Kenneth Pouncey cad455b393 Fix HttpMessageHandler request content as binary. 2019-03-07 11:50:09 +01:00
Alexander Köplinger f77193d306 [mono/tests] Add fullaot-mixed to SUBDIRS
Fixes tarball build break.
2019-03-07 11:43:56 +01:00
Kenneth Pouncey 8d12c53c0a Fix ClientWebSocket passing of ArraySegment. 2019-03-07 11:35:16 +01:00
Kenneth Pouncey bb5eb13967 Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays
# Conflicts:
#	sdks/wasm/framework/src/WebAssembly.Bindings/WebAssembly.Bindings.csproj
2019-03-07 10:10:59 +01:00
monojenkins 7fe2472b34 [csproj] Update project files 2019-03-07 10:03:14 +01:00
monojenkins 530596db02 Bump API snapshot submodule 2019-03-07 10:03:14 +01:00
Steve Pfister 6a9950c5d2 * System.Data.Linq now points to reference source
* Created SR and Strings helpers as refsrc resources are
  missing / incomplete

* Moved existing tests into the Test folder

* Moved old DBLinq code into tools/sqlmetal as there are no other
  alternatives.
2019-03-07 10:03:14 +01:00
Marek Safar c96df417d1 Remove code moved to shared 2019-03-07 00:42:25 +01:00
Tanner Gooding 57c75cbb94 Fixing the float/double parsing logic to handle exponents that are too large/small (#23043)
* Fixing the float/double parsing logic to handle exponents that are too large/small

* Fixing the debug assert to use >= and <=

* Fixing the max exponents to be +1 to match what scale uses.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Stephen Toub 6d8df4e7f3 Clean up some string.Format usage (dotnet/coreclr#23025)
* Clean up some string.Format usage

Mainly changes some string.Format usage to be SR.Format when working with resource strings.  Also cleans up a few asserts that were using string.Format.

* Address PR feedback and clean up src

* Address more feedback

* Update src/System.Private.CoreLib/shared/System/Type.Enum.cs

Thanks.

Co-Authored-By: stephentoub <[email protected]>
Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Maryam Ariyan d56e47721a Add Type Forward (dotnet/coreclr#23036)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Marek Safar 72406ff802 Move more Assembly methods to shared partition (dotnet/coreclr#22817)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Andrew Au a7963f4e51 Fix issue 23009
Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Honza Rameš d1b1ce9dfa Fix ValueStringBuilder.EnsureCapacity to call Grow correctly (#35810)
* Fix ValueStringBuilder.EnsureCapacity to call Grow correctly (#35746)

Call to EnsureCapacity may result in invalid buffer size being
allocated.

* Update ValueStringBuilder.Grow to prevent misuse (#35746)

Updated name of the argument to make it clearer on the call-site also
added summary co clearly state the behavior of Grow.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
dotnet-maestro[bot] 60de375154 Update dependencies from dotnet/core-setup (dotnet/corefx#35713)
* Update dependencies from https://github.com/dotnet/core-setup build 20190301.13

This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27501-13

* Remove workaround for System.Runtime.CompilerServices.Unsafe

* Update dependencies from https://github.com/dotnet/core-setup build 20190302.8

This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27502-8

* Update dependencies from https://github.com/dotnet/core-setup build 20190303.9

This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27503-9

* Update dependencies from https://github.com/dotnet/core-setup build 20190304.10

This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27504-10

* Don't include EventRegistrationToken on Unix

This type was accidentally duplicated between CoreLib and contracts.

Suppress that for now since we're detecting the duplication in the shared framework.

Make a fix in the shared items to restore the condition on this type.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Viktor Hofer af3965d9d2 Project msbuild syntax cleanup (dotnet/corefx#35686)
* Remove license header from non-shipping files

* Remove obsolete Project attributes

* Remove xml header and remove DefaultTargets

Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Michal Strehovský edf4941ec3 Fix ProjectN build breaks (dotnet/corert#7115)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Marek Safar 186ae08b0a Move fully managed TimerQueue implementation to shared partition (#7111)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-07 00:42:25 +01:00
Alexander Köplinger 97f2393f3e [mono/tests] Add common_mixed.mk to EXTRA_DIST 2019-03-06 23:58:48 +01:00
Alexander Köplinger 2f2881fc4b Add .gitignore for mono/tests/fullaot-mixed 2019-03-06 23:56:11 +01:00
Alexander Köplinger aabd3ab102 Bump bockbuild to get GTK fix
See https://github.com/mono/bockbuild/pull/90
2019-03-06 23:45:10 +01:00
Marek Safar fbffa8719a [System.Private.CoreLib] Fix the build 2019-03-06 23:05:20 +01:00
Martin Baulig 6034bc00c4 Introducing HttpClient.CreateDefaultHandler(). (#13305)
* The default `HttpClient` constructor now calls a static method `CreateDefaultHandler()`;
   we provide a platform-specific implementation of it.

* Replaced `HeaderUtils` with `PlatformHelper` and removed the `LEGACY_HTTPCLIENT` conditional.

* Added a new `socketshandler.sources` file to keep the sources in one place.

* Use a reflection check in the tests instead of the `LEGACY_HTTPCLIENT` conditional.

* This allows us to also get rid of the `SOCKETSHTTPHANDLER` define.
2019-03-06 20:56:42 +01:00
Zoltan Varga 835c8590ca [netcore] Implement DependentHandle using the existing ephemeron code. 2019-03-06 18:24:46 +01:00
Katelyn Gadd d02c43e23e Propagate type load errors out of IsAssignableFrom instead of erroneously returning false. Makes the underlying cause of #13113 discoverable. (#13324) 2019-03-06 11:41:55 -05:00
Ludovic Henry 6527e21bb4 [safepoint] Use LLVM pass to insert safepoint (#11789)
* [safepoint] Use LLVM pass to insert safepoint

This is to avoid safepoints to stop optimizations from happening.

* [safepoint] Use LLVM pass to insert safepoint

This is to avoid safepoints to stop optimizations from happening.

* fix error: emit_gc_safepoint_poll does not return anything

* Revert partial 4150f06f8621f2f2918e3bd747bf80a0f0f8c9c6

* Fix build

* [runtime] Add mono_threads_state_poll to preinited icalls

* [runtime] Adding back in safepoint icall skip code

* Revert mini.c to 100f422

* [runtime] Add missing deref to safepoint poll

* [runtime] Make safepoint functions have WeakODR linkage
2019-03-06 11:38:48 -05:00
Alexander Köplinger cacc9b7c4c [Facades] Add typeforwarders for DispatchProxy and TypeExtensions (#13325)
* [Facades] Add typeforwarders for DispatchProxy and TypeExtensions

DispatchProxy lives in System.Core for all profiles since https://github.com/mono/mono/pull/13198.

TypeExtensions live in corlib since https://github.com/mono/mono/pull/9746.

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-06 16:20:51 +01:00
Zoltan Varga 2b761f9ea5 [linker] Only preserve the m_value fields of the primitive types. 2019-03-06 11:34:34 +01:00
Egor Bogatov e42bf95d14 NS2.1 Sync new changes, mobile profiles (#13198)
* Add RuntimeHelpers.GetSubArray. Add missing types to NS's TypeForwarders.cs

* more NS2.1 changes

* ios changes

* Update Decimal (it's now readonly struct)

* fix mcs

* add ROMC.cs

* Fix tests, finish monodroid profile

* Make SRE-not-supported NS2.1 compatible

* Make monotouch_tv and watch NS2.1 compatible

* make some SRE types more NS21 compatible (non-abstract now)

* bump corefx

* More NS21 fixes

* bump coreclr acceptance tests

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-06 08:55:16 +01:00
Alexander Köplinger b31a445e85 [gitattributes] Do CRLF normalization on sln/proj files
They can be used with native line endings.

We now have a shared folder with the dotnet repos and they have CRLF normalization enabled.
This difference leads to conflicts while applying changes from the dotnet repos to mono.
2019-03-06 08:34:01 +01:00
justremotephone eb3f7312bd [System.ServiceModel] Fix a race condition in HttpRequestChannel. (#13304)
Concurrent request completions could cause following exception:

```
    FATAL UNHANDLED EXCEPTION: System.ArgumentOutOfRangeException:
        Index was out of range. Must be non-negative and less than
        the size of the collection.
        Parameter name: index
       at System.Collections.Generic.List`1[T].RemoveAt (System.Int32 index) [0x00009] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Collections.Generic.List`1[T].Remove (T item) [0x0000c] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.ServiceModel.Channels.HttpRequestChannel+HttpChannelRequestAsyncResult.Cleanup () [0x00011] in <28c4695205ef47378f5370502b066592>:0
       at System.ServiceModel.Channels.HttpRequestChannel+HttpChannelRequestAsyncResult.set_IsCompleted (System.Boolean value) [0x00034] in <28c4695205ef47378f5370502b066592>:0
       at System.ServiceModel.Channels.HttpRequestChannel+HttpChannelRequestAsyncResult.Complete (System.Exception ex) [0x0001a] in <28c4695205ef47378f5370502b066592>:0
       at System.ServiceModel.Channels.HttpRequestChannel+<>c__DisplayClass7_1.<BeginProcessRequest>b__0 (System.IAsyncResult r) [0x000bd] in <28c4695205ef47378f5370502b066592>:0

    This stack was captured after some changes in AwaitTaskContinuation.RunOrScheduleAction.
    Unfortunately the current implementation of AwaitTaskContinuation.RunOrScheduleAction re-throws the above
    exception with a wrong stack:

       at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction (System.Action action, System.Boolean allowInlining, System.Threading.Tasks.Task& currentTask) [0x00023] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishContinuations () [0x00052] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishStageThree () [0x0003c] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishStageTwo () [0x000a1] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.Finish (System.Boolean bUserDelegateExecuted) [0x00003] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.TrySetException (System.Object exceptionObject) [0x00023] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[TResult].SetException (System.Exception exception) [0x00029] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Net.HttpWebRequest+<RunWithTimeoutWorker>d__241`1[T].MoveNext () [0x000e0] in <3e9b3e26c4694baab3f689687ad40612>:0
       at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext (System.Object stateMachine) [0x00000] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00071] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) [0x00000] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.Run () [0x00024] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction (System.Action action, System.Boolean allowInlining, System.Threading.Tasks.Task& currentTask) [0x00023] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishContinuations () [0x00052] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task.FinishStageThree () [0x0003c] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Threading.Tasks.Task`1[TResult].TrySetResult (TResult result) [0x0004f] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1[TResult].SetResult (TResult result) [0x0003d] in <4a8a0eaa024f41829d3435c07e5c7edb>:0
       at System.Net.ServicePointScheduler+<WaitAsync>d__45.MoveNext () [0x000f7] in <3e9b3e26c4694baab3f689687ad40612>:0
       at System.Runtime.CompilerServices.AsyncMethodBuilderCore+MoveNextRunner.InvokeMoveNext (System.Object stateMachine) [0x00000] in <4a8a0
```

On an Android Xamarin installation this causes an app crash. Since no user code is active the exception cannot be caught.
2019-03-06 01:07:29 +01:00
Alexander Kyte 24c637dd26 Merge pull request #13262 from alexanderkyte/fixup_no_threads
[crash] Detect when 0 attached threads, fix hang/double-fault.
2019-03-05 17:38:16 -05:00
Maxim Lipnin 0e9495a034 Get fully qualified name of ModuleBuilder (#13308)
* Get fully qualified name of ModuleBuilder

* Use MethodBuilder.FileName to find main module
2019-03-05 16:20:47 -05:00
Kenneth Pouncey 9330096912 [wasm][ci]Update to latest JavaScript (engine) Version Updater (#13307)
- The purpose of this is to be able to respond to CI incidents faster for instance specific engine versions when JavaScript engines do not update/install correctly.
- This will install from a forked version of the jsvu repo: https://github.com/GoogleChromeLabs/jsvu
- Forked version rests here:  https://github.com/kjpou1/jsvu/tree/mono-wasm
   - The forked version removes the Node >= 10.0 dependency but brings in the newest 1.4.0 version modifications.
- This should be temporary until we get another solution i.e. a managed version of the engine updater.
2019-03-05 17:08:45 +01:00
Alexander Köplinger d99af881c3 [corlib] Disable ThreadPoolTest.GetAvailableThreads () on machines with many cores
It doesn't work well on the new 64 core ARM machines we have in CI.
2019-03-05 14:33:26 +01:00
Zoltan Varga af87454146 [jit] Avoid an assert when gsharedvt enums are boxed. (#13301)
Fixes https://github.com/mono/mono/issues/13297.
2019-03-05 01:21:02 -05:00
Alexander Köplinger c2a1eb5de6 [corlib] Improve ThreadPoolTest.GetAvailableThreads ()
Don't print console output in the loop and bump timeout.
2019-03-05 01:44:07 +01:00
Zoltan Varga 819660ef97 [netcore] Ongoing work.
* Implement all CustomAttributeExtensions methods.
* Add stubs for __ComObject which is needed by the runtime.
2019-03-04 19:33:46 +01:00
monojenkins 24d55fb184 [master] Fix mono conc hashtable lookup endless loop (#13292)
Fix mono conc hashtable lookup endless loop
2019-03-04 13:11:55 -05:00
monojenkins ef30f5589b [bcl] Update BCL Linked Size 2019-03-04 18:40:41 +01:00
Aaron Hill 290b537a73 Ensure that the module cctor is run before the entry point is executed (#13242)
* Ensure that the module cctor is run before the entry point is executed

We need to ensure that any module cctor for the 'main' image
is run *before* we invoke the entry point

This is required in order for tools like Costura
(https://github.com/Fody/Costura) to work properly. These tools inject
a module initializer which sets up event handlers (e.g. AssemblyResolve),
which allows the main method to run properly

For more information about module constructors,
see https://blogs.msdn.microsoft.com/junfeng/2005/11/19/module-initializer-a-k-a-module-constructor/

* Fix module-cctor-entrypoint.il
2019-03-04 12:31:17 -05:00
Alexander Köplinger e8fbaa5531 [linker] Fix monotouch tests which need Xamarin.iOS.dll (#13287)
The linker couldn't resolve Xamarin.iOS.dll which System.Net.Http references now.
2019-03-04 17:46:56 +01:00
Egor Bogatov af6d863e52 [corlib] Fix Directory.GetLogicalDrives () (#13125)
Fixes #13030
2019-03-04 16:43:46 +01:00
sancheolz 89f264ad86 [SWF] Method OnClosed should pass FormClosedEventArgs type, instead of EventArgs.Empty (#13283)
Fixes #13282
2019-03-04 15:31:59 +01:00
Bernhard Urban 1da9c0f9e7 [interp] mixed mode fixes for delegates (#13215)
* [interp] avoid multiple transformations

* [interp] remove delegate hack for method_ptr=imethod case

it isn't needed anymore

* [interp] ensure initialized fields of a class retrieved from wrapper data

* [fullaot mixed] add test for specific mixed mode scenario

* [interp] remove assertion, it does not take into account multiple threads transforming the same method

* [interp] avoid non-lazy compilation of delegate if interpreter is involved

* [fullaot-mixed] disable on i386

* [interp] propagate errors on delegate init

* fix c++ build

* [tests] improve return codes

* error only for dynamic methods

* [fullaot-mixed] disable test on coop
2019-03-04 15:06:35 +01:00
sancheolz bac5347996 [System.Runtime.Remoting] Implement CustomErrorsMode for RemotingConfiguration (#13251)
Implemented property RemotingConfiguration.CustomErrorsMode.

Fixes #13250
2019-03-04 15:01:40 +01:00
Marek Safar a08eff03f7 [System.Private.CoreLib] Implement more APIs 2019-03-04 12:58:03 +01:00
Zoltan Varga 85c8e85476 [netcore] Ongoing work. (#13278)
* Implement CustomAttributeExtensions methods.
* Add a AssemblyFileVersion attribute.
* Don't try AppDomain.TypeResolve.
2019-03-04 11:59:37 +01:00
Zoltan Varga f82ae71c90 [netcore] Fix threading. 2019-03-03 13:42:10 +01:00
Zoltan Varga 6b6b1ce35e [jit] Fix the RuntimeHelpers.ObjectHasComponentSize () intrinsics. (#13271) 2019-03-03 06:58:11 -05:00
Jan Kotas 9bdb423e5d Fix CoreCLR build break
Signed-off-by: dotnet-bot <[email protected]>
2019-03-03 12:12:26 +01:00
Jan Kotas 6578e93670 Update CoreRT for changes in shared partition
Signed-off-by: dotnet-bot <[email protected]>
2019-03-03 12:10:25 +01:00
Marek Safar 519139773f Fix the build 2019-03-03 12:01:00 +01:00
Marek Safar 243d669a2e Move Activator to shared partition (dotnet/coreclr#22894)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-03 12:01:00 +01:00
Grant d8e9e8fa6d Use BitOperations in more callsites (CoreCLR) (dotnet/coreclr#22630)
* Missed perf improvement in EventProvider

* Add missing methods to StubEnvironment

Signed-off-by: dotnet-bot <[email protected]>
2019-03-02 23:07:39 +01:00
Jan Kotas 84d6476152 Fix CoreFX build break
Signed-off-by: dotnet-bot <[email protected]>
2019-03-02 21:10:37 +01:00
Jan Kotas a31af4add7 Fix netfx build break
Signed-off-by: dotnet-bot <[email protected]>
2019-03-02 21:10:37 +01:00
Alexander Köplinger 64556b9bb9 [ci] Shorten timeout in SDKs tests
The tests normally complete in a few mins.
2019-03-02 12:46:27 +01:00
Calvin Buckley 2ecf08d265 More PPC/AIX regression fixes (#13264)
* Fix System.Math regressions brought on by PowerPC JIT optimizations

	* While frin[.] does do rounding, the semantics are slightly
	  different enough from the BCL that it subtly breaks, as
	  seen by some tests. Ceil/Floor/Trunc are fine, however.
	  Perhaps the sysmath.c version can be translated to asma.

	* Fix typo where signed long comparison for isel was using
	  an unsigned comparison.
	  Add a test for this in the JIT regression check.

* Link against (not fd.o) libbsd for System.Native on AIX

The way we link the library by default will allow some unresolved
symbols. These will get resolved to the runtime when loaded by it.
However, flock isn't in AIX libc, and the native library needs it.
This doesn't seem to be a problem on AIX, but on i libbsd doesn't
seem to be in the dependency chain, so it errors out when you use
it. The workaround is to link libbsd (not the freedesktop.org one)
into the library. According to dump, it seems it has its own copy
of ioctl and fnctl, but they seem benign according to objdump and
don't seem to affect System and corlib tests I've ran to check it.
2019-03-02 12:43:12 +01:00
Marek Safar 30d70e98e6 Fix the build 2019-03-02 11:05:00 +01:00
Morgan Brown 580f5ef53a Implement Serialization Guard
Add Serialization Guard API and consume it in CoreLib targets

Signed-off-by: dotnet-bot <[email protected]>
2019-03-02 11:05:00 +01:00
Maxim Lipnin ed0d055424 Throw InvalidOperationException if inner handler is not assigned 2019-03-02 02:31:54 +01:00
Alexander Kyte db5d8729b4 [crash] Detect when 0 attached threads, fix hang/double-fault. 2019-03-01 16:11:11 -05:00
Zoltan Varga 4970e055b3 [netcore] Implements threads. (#13245)
* [netcore] Implements threads.

There is only one thread object, since there are no domains.

* Make the start callback internal.
2019-03-01 15:15:31 -05:00
Ludovic Henry 234daf1cf3 [android] Fix Mono.Debugger.Soft tests with Android SDKs (#13218)
* [android] Fix Mono.Debugger.Soft tests with Android SDKs

* [android] Fix connecting with LLDB

* [android] Add scaffolding to run profiler tests

* [android] Fix some corlib tests

* [android] Fix Mono.DebuggerTests.ExceptionFilter2

* [csproj] Update project files
2019-03-01 21:03:26 +01:00
Rolf Bjarne Kvinge c99fe4b462 [mini] Inline Selector.GetHandle for tvOS and watchOS assemblies as well. (#13246) 2019-03-01 11:10:04 -05:00
monojenkins 83d5cf0c5c [android] Fix inaccurate detection of sendfile() (#13243)
[android] Fix inaccurate detection of sendfile()
2019-03-01 10:28:34 -05:00
Alexander Kyte 23c83a48cd [runtime] Optimize array_set_value_impl slow path (#13186)
* [runtime] Add unmanaged fast-path for mono_class_is_assignable_from

Our managed code has a fast path for this that checks if the two types
are the same. The unmanaged calls here always falls back on the slow path.

This leads to a latency that is pretty observable during
array_set_value_impl calls.

* [runtime] Make faster already-pinned nullable init path

* [runtime] Expose non-handle-allocating object_handle_isinst_mbyref

* [runtime] Use MONO_ENTER_NO_SAFEPOINTS for array_set_value_impl
2019-03-01 10:21:02 -05:00
Vlad Brezae e4b281825a [interp] Add fast paths for common cast checks (#13225)
* [interp] Remove some duplicated code

* [interp] Optimize type checking for interfaces

Mainly to avoiding handles for common scenarios. Makes type checking for common interfaces 10x faster.

* [interp] Optimize type checking for common classes

Mainly to avoiding handles for common scenarios. Makes type checking for common classes 10x faster.
2019-03-01 10:19:12 -05:00
Alexander Köplinger 98e0f2697d [sdks] Use throttle() instead of lock()
The former works in freestyle builds.
2019-03-01 14:45:16 +01:00
Alexander Köplinger f5b9af2505 Revert "[sdks] Make sure to run only one build per type per node"
This reverts commit b740313aa5.

We actually want to only run one build per product on a node,
e.g. so that android-debug and android-release can't run on
the same node and stomp on each other's toolchain.
2019-03-01 13:57:06 +01:00
Alexander Köplinger 793c3aa3aa [ci] Add node name to log of Jenkins pipeline builds
Makes it easier to figure out where a build ran.
2019-03-01 13:31:01 +01:00
Alexander Köplinger 5bf74a9954 [System.Net.Http] Move NSUrlSessionHandler from xamarin-macios to mono (#13229)
* [System.Net.Http] Move NSUrlSessionHandler from xamarin-macios to mono

This allows us to remove the need for a special custom System.Net.Http.dll
build in the xamarin-macios repository.

Part of #11397

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-01 12:20:27 +01:00
Katelyn Gadd 6c58376102 If a ClientIdentity has no ClientProxy then return null from the accessor instead of throwing. Experimental partial fix for issue #13113 2019-03-01 11:59:50 +01:00
Levi Broderick fcbc8c3792 Add Rune.DecodeUtf16 / DecodeUtf8 and friends (dotnet/coreclr#22725)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-01 09:57:09 +01:00
Aaron Robinson 3508069707 Move COM related attributes to the shared source location of Object class. (#22942)
Signed-off-by: dotnet-bot <[email protected]>
2019-03-01 09:57:09 +01:00
Tanner Gooding 5b02347ae8 Removing the ExtractVector128 and InsertVector128 APIs that take an address. (#22886)
* Removing the InsertVector128 and ExtractVector128 overloads that take an address from S.P.Corelib

* Removing the ExtractStore and InsertLoad tests.

* Fixing the PacketTracer test to use the appropriate Extract/InsertVector128 overloads

* Removing the JIT support for the Extract/InsertVector128 overloads that take an address.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-01 09:54:21 +01:00
monojenkins 041e874182 [bcl] Update BCL Linked Size 2019-03-01 09:32:07 +01:00
Alexis Christoforides adc62b328e [monodroid] Use CoreFX to implement System.Drawing types that used to be in Mono.Android.dll (#13135)
* [monodroid] Use CoreFX to fill in reference stubs for System.Drawing types that are currently 'forked' from Mono into Mono.Android.dll

The list of localy implemented System.Drawing types: https://github.com/xamarin/xamarin-android/blob/e0da1f152de84c4cc39983f2fda775ec98c08250/src/Mono.Android/Mono.Android.csproj#L311-L325

* [netstandard] Update for Mono.Android change

* Bump reference assemblies to include Mono.Android update

* Use System.Drawing.Common to find moved types in monodroid case for netstandard facade

* Bump API snapshot submodule

* [csproj] Update project files
2019-03-01 01:50:44 +01:00
Alexander Köplinger 4ea57007fa [Mono.Debugger.Soft] Disable Attach() test that fails or hangs (#13239)
It was recently reenabled in #9091 but it fails/hangs frequently.
2019-03-01 01:43:19 +01:00
Aaron Robinson b5d6e5344f Set the MarshalByRefObject to be ComVisible and (dotnet/coreclr#22930)
a IDispatch class interface. this is being done
  to ensure WinForms consumers can interact with
  COM based controls.

Signed-off-by: dotnet-bot <[email protected]>
2019-03-01 00:28:08 +01:00
Stephen Toub b0935ae258 Fix DumpAsync to understand ContinuationWrapper (dotnet/coreclr#22913)
Continuations created while the debugger is attached or certain EventSource events are enabled end up getting wrapped in an extra ContinuationWrapper object that carries some additional information.  DumpAsync currently isn't unwrapping these but should.  This just teaches it to look for a known field name so that it can "see through" these wrappers while following async "stacks".

Signed-off-by: dotnet-bot <[email protected]>
2019-02-28 23:30:53 +01:00
Marek Safar a88ad66551 Build fixes 2019-02-28 23:05:24 +01:00
Jan Kotas 51a4aae4ff Fix CoreRT build break
Signed-off-by: dotnet-bot <[email protected]>
2019-02-28 23:05:24 +01:00
Stephen Toub ee67c17eb3 Address PR feedback (clean up style in Thread.CoreCLR.cs)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-28 23:05:24 +01:00
Stephen Toub 54d2a05d66 Fix Thread-related breaking changes
- Thread.ExecutionContext needs to return ExecutionContext.Capture() to public callers.
- Fix restoring of culture to be inside of the ExecutionContext callback where applicable

Signed-off-by: dotnet-bot <[email protected]>
2019-02-28 23:05:24 +01:00
Marek Safar 4c4421f30d Fix the build 2019-02-28 22:41:40 +01:00
Filip Navara d14b15f502 Move Thread to shared CoreLib (dotnet/coreclr#22744)
* Move Thread to shared CoreLib

* Remove all local variables from Thread in shared code

* Remove duplicate checks

* Port back CoreRT changes needed for shared code

* Fix missing culture initialization in ThreadStart()

* Adjust for shared WaitHandle

Signed-off-by: dotnet-bot <[email protected]>
2019-02-28 22:41:40 +01:00
Johan Lorensson 80e5e7ff62 Cancel sync IO on Windows when aborting thread. (#13173)
* Cancel sync IO on Windows when aborting thread.

Using CancelIO/CancelIOEx or CancelSynchronousIo on a thread that is moving
into a suspended state can cause these calls to hang (they shouldn’t but
have been observed to be the case). Fix does the cancel of sync IO after
the aborted thread has been resumed, but before releasing suspend locks
making sure thread won't be suspend again until after cancel IO call has
completed.

* Add tests aborting blocking socket and file IO on Windows.
2019-02-28 16:02:21 -05:00
Alexander Köplinger e3caf01677 [sdks] Use abspath instead of PWD on iOS app build (#13230)
PWD is the wrong directory when e.g. you're doing "make -C sdks/ios" from the repo root.

Fixes https://github.com/mono/mono/issues/13224
2019-02-28 21:47:21 +01:00
Mikhail Filippov f512a68edc [Mono.Debugger.Soft] Add new debugger tests and fix the Attach() test (#9091)
* Fixed the Attach() test which required a free port to attach.

* Added test for incorrect events behavior when VM is started with suspend

* Bump API snapshot submodule
2019-02-28 19:29:30 +01:00
Calvin Buckley a4eee02195 PPC JIT optimizations (System.Math instruction inlining) (#11964)
* [ppc] Optimize floating point performance in the JIT sqrt/sqrtf/abs

* [ppc] Integer Min/Max inlining wiht POWER5 isel instruction

Compresses a function call down to two instruction, for both signed
and unsigned, long and int. Needs to check for POWE5 though, and I
don't know the effects of this on ppc32. FP version using fsel is
also desirable, but not in the scope of this commit.

* [ppc] Check for POWER5 compatible CPU before using isel

* [ppc] Don't use long min/max inlining for ppc32

Other 64-bit operations are marked for ppc64 only.

* [ppc] also ifdef that out for ppc32 too

* [ppc] Rounding function optimizations
2019-02-28 09:31:12 -05:00
Johan Lorensson 3487962a82 Merge pull request #13210 from lateralusX/lateralusX/adjust-test-console-output
Update output from console-output test.
2019-02-28 06:40:33 -05:00
Johan Lorensson dd9ee189c6 Merge pull request #13212 from lateralusX/lateralusX/add-waitforkeypress-test-project
Add atexit-waitforkeypress handler in Visual Studio mono.sln test projects run args.
2019-02-28 05:06:38 -05:00
monojenkins ace38db535 [bcl] Update BCL Linked Size 2019-02-28 08:24:51 +01:00
Martin Baulig 3f43547cd6 [corlib]: Use Guid.NewGuid() implementation from CoreFx. (#13189)
* [corlib]: Use `Guid.NewGuid()` implementation from CoreFx.

The corefx implementation of `Guid.NewGuid()` uses the internal
`Interop.GetRandomBytes(byte*, int)`, which uses `RNGCryptoServiceProvider`
directly without using `CryptoConfig`.

* [csproj] Update project files

* Rename Guid.MonoTouch.cs -> CommonCrypto/Guid.cs.
2019-02-28 00:37:25 -05:00
Ludovic Henry 53b7b79f53 Initial support for Fuchsia (#13200)
* Initial support for Fuchsia

Compile like this:

if you have Zircon installed, with the prebuilts on "../zircon", use this to compile:

CC="`pwd`/../zircon/prebuilt/downloads/clang/bin/clang-9 -nostdlib -O2 -g -fdebug-prefix-map=/cvs/fuchsia/zircon=. -finline -fno-common -ffunction-sections -fdata-sections -no-canonical-prefixes -march=x86-64 -mcx16 --target=x86_64-fuchsia -fPIC -D_ALL_SOURCE=1 -DENABLE_DRIVER_TRACING=1 -fasynchronous-unwind-tables -fno-omit-frame-pointer  -std=c11 -I`pwd`/../zircon/build-x64-clang/sysroot/include/ -I`pwd`/../zircon/system/public" LDFLAGS="-L`pwd`/../zircon/build-x64-clang/sysroot/lib/ -L`pwd`/../zircon/build-x64-clang/sysroot/debug" ./configure --host=x86_64-google-fuchsia

* Use HOST_FUCHSIA rather than TARGET_FUCHSIA
2019-02-27 21:33:15 -05:00
Bernhard Urban 69cb9ad922 [interp] fix conflict of #13154 and #13177 (#13208)
See https://github.com/mono/mono/pull/13177#discussion_r259872514
2019-02-27 21:32:37 -05:00
Bernhard Urban 2030ebdc5e [interp] compute size of generic valuetype correctly (#13216)
[interp] compute size of generic valuetype correctly

Otherwise we smash the stack.


Contributes to https://github.com/xamarin/xamarin-macios/issues/5622
2019-02-27 18:25:40 -05:00
Calvin Buckley a3be248d3f [corlib] Simplify RuntimeInformation by getting OS name from the runtime (#13164)
We can get the the OS name similar to the architecture from the value that is used by the runtime for DllMaps.

Cached the values into static fields so we only need to do the runtime icall once.

Added all the existing OS names recognized by DllMap to RuntimeInformation.
This also allows us to mark some corlib/System tests that hang the runtime on AIX as non-working.
2019-02-27 23:21:34 +01:00
Miguel de Icaza fe92cea485 Use HOST_FUCHSIA rather than TARGET_FUCHSIA 2019-02-27 16:54:50 -05:00
Bernhard Urban a3dd8b3246 [lldb] fix helper for interpreter stacktraces (#13211)
Broke due to b6775765ed
2019-02-27 21:55:14 +01:00
Marek Safar 6f8ec5fdce Fixes build 2019-02-27 21:24:21 +01:00
Grant 448fd6ac62 Make BitOperations public (CoreCLR) (dotnet/coreclr#22864)
* Make BitOps public

* Update name to BitOperations

* Change namespace to System.Numerics

* Fix file name

* Alphabetical

Signed-off-by: dotnet-bot <[email protected]>
2019-02-27 21:24:21 +01:00
Maxim Lipnin 1ab0ffc964 [corlib] Update DriveInfo tests to use the newer RuntimeInformation APIs (#13205) 2019-02-27 19:23:19 +01:00
lateralusX 695743e3ab Add atexit-waitforkeypress handler in Visual Studio mono.sln test projects run args. 2019-02-27 17:45:57 +01:00
lateralusX ac906dd937 Update output from console-output test.
Current output from console-output test is just Error and Out (indicating)
the different console output streams. When seen in log files the error output
string can be misleading. Fix makes it clearer that the output is originating
from a test and not an “error”.
2019-02-27 17:19:30 +01:00
Zoltan Varga 8ca41f08a0 [jit] Fix the class of the stack entry for ldelema, it should be the class not its element class. (#13134)
Fixes https://github.com/mono/mono/issues/10101.
2019-02-27 16:31:54 +01:00
Martin Baulig 55a34261c9 [Mono.Security]: minor CryptoConvert changes to make it more linker-friendly. (#13204)
* Add new internal `CryptoConvert.TryImportCapiPrivateKeyBlob()` method that's using `RSAManaged` directly to make it more linker-friendly.

* Also add new internal `CryptoConvert.TryImportCapiPublicKeyBlob()`.

* Use it in `AssemblyName.IsPublicKeyValid`.
2019-02-27 12:56:06 +01:00
Zoltan Varga ce2259d009 [runtime] Default Interface method fixes. (#13154)
* [runtime] Inflate overridden methods properly during vtable construction when using default interface methods.

* [jit] Handle default interface methods in constrained calls, they need to box if the constrained type is a valuetype which doesn't override the default method.

* [runtime] Update Default Interface Methods tests from coreclr.

* [jit] Fix interp support.
2019-02-26 22:00:46 -05:00
Ankit Jain f7d053a0d6 nuget-hash-extractor: Improvements to reduce unnecessary diffs on update (#13197)
* [nuget-hash-extractor] Make the order for denied lists deterministic and

.. stable. We were not sorting the list of assemblies with the same
version, causing irrelevant changes in updates.

* Update denied assembly list to fix order

.. to be deterministic. Generated with the updated
nuget-hash-extractor.cs .

* [nuget-hash-extractor] Make the order of assemblies deterministic

The .nupkgs were being processed in arbitrary order, causing unncessary
diffs when updating them which required manual work to check and fix
them.
2019-02-27 00:41:11 +01:00
Martin Baulig 6a3b12b622 Revert "[Mono.Security]: minor CryptoConvert changes to make it more linker-friendly." (#13202)
This reverts commit ef7e64a5be.
2019-02-27 00:17:37 +01:00
Stephen Toub 48f65d5108 Special-case 1 module per assembly in Assembly.GetTypes/DefinedTypes (#22825)
It's very common for an assembly to have only one module, in which case we can avoid unnecessary allocations and copies in Assembly.GetTypes() and Assembly.DefinedTypes.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-27 00:03:26 +01:00
Dotnet-GitSync-Bot 2b4bff1956 Mirror changes from mono/coreclr (#13192)
This PR contains mirrored changes from mono/coreclr


**Please REBASE this PR when merging**

 cc @grant-d
2019-02-26 23:59:38 +01:00
Ludovic Henry a685cf26a4 [ci] Add new mode of execution for nunit tests on Android (#13098)
* [ci] Add new mode of execution for nunit tests on Android

This makes it possible to run the `nunit-lite-console.exe` on the host, while the tests still run on the device. This makes it transparent wherever the tests are running, giving us a seamless integration with the existing infrastructure based around nunit.

* [android] Fix System.Net.Http test suite

* [android] Fix System.ServiceModel.Web test suite

* [android] Fix Mono.Security test suite

* fixup! [ci] Add new mode of execution for nunit tests on Android

* [ci] Disable failing tests

* [csproj] Update project files
2019-02-26 22:08:01 +01:00
Miguel de Icaza a55e8496be Initial support for Fuchsia
Compile like this:

if you have Zircon installed, with the prebuilts on "../zircon", use this to compile:

CC="`pwd`/../zircon/prebuilt/downloads/clang/bin/clang-9 -nostdlib -O2 -g -fdebug-prefix-map=/cvs/fuchsia/zircon=. -finline -fno-common -ffunction-sections -fdata-sections -no-canonical-prefixes -march=x86-64 -mcx16 --target=x86_64-fuchsia -fPIC -D_ALL_SOURCE=1 -DENABLE_DRIVER_TRACING=1 -fasynchronous-unwind-tables -fno-omit-frame-pointer  -std=c11 -I`pwd`/../zircon/build-x64-clang/sysroot/include/ -I`pwd`/../zircon/system/public" LDFLAGS="-L`pwd`/../zircon/build-x64-clang/sysroot/lib/ -L`pwd`/../zircon/build-x64-clang/sysroot/debug" ./configure --host=x86_64-google-fuchsia
2019-02-26 15:55:41 -05:00
Zoltan Varga 5f5ef1efe5 [wasm] Disable chakra tests until its fixed. (#13199) 2019-02-26 21:41:46 +01:00
Vlad Brezae 88c560ad72 [interp] Avoid clearing the stack with each call (#13177)
* [interp] Move special case initialisation of frame->ip

* [interp] Properly init locals

When we have locals that need to be initialized.

* [interp] Load the entire enum value

When calling calling method on constrained type for enums with long storage.

* [interp] Avoid clearing the stack with each call

Reducing overhead for each call, this can give an overall performance improvement of 5%.
2019-02-26 12:01:29 -05:00
Alexander Kyte a0c6a15465 [runtime] Use FastCopy on multidimensional arrays (#13181) 2019-02-26 10:09:46 -05:00
Maxim Lipnin fc240aaa1c Consider unknown GB18030 characters as invalid to enforce use of replacement character instead of throwing SystemException. (#13188)
* Consider unknown GB18030 characters as invalid to enforce use of replacement character instead of throwing SystemException.

* Return negative result for unknown character instead of throwing SystemException in GB18030Source.FromUCS
2019-02-26 12:51:51 +01:00
Zoltan Varga 5225828263 [corlib] Add a RuntimeTypeHandle::GetCorElementType () icall, use it to remove a few other small icalls. 2019-02-26 12:51:14 +01:00
Alexander Köplinger 97f0a0f94c [ci] Use dl.internalx.com when building on private Jenkins
(cherry picked from commit 9d4aa950aa)
2019-02-26 11:25:45 +01:00
Martin Baulig ef7e64a5be [Mono.Security]: minor CryptoConvert changes to make it more linker-friendly.
* Add new internal `CryptoConvert.TryImportCapiPrivateKeyBlob()`
  method that's using `RSAManaged` directly to make it more
  linker-friendly.

* Use it in `AssemblyName.IsPublicKeyValid`.
2019-02-26 10:18:54 +01:00
Kenneth Pouncey 07287648b2 [wasm] Add browser test suite. (#13145)
* [wasm] Add browser test suite.

- Runs a series of tests against the HttpClientHandler and blob tests.

* Setup custom browser launcher to pass `--no-sandbox` to work on CI

* Remove auto client config that caused async errors on tests.
2019-02-26 10:07:21 +01:00
Marek Safar 7c975c18d8 AssemblyLoadContext from shared 2019-02-25 23:39:31 +01:00
Marek Safar 5ae98353a6 Move AssemblyLoadContext to shared partition (dotnet/coreclr#22685)
* Move AssemblyLoadContext to shared partition

* Move static initializer to DefaultAssemblyLoadContext

and remove stream copying from lock scope

Signed-off-by: dotnet-bot <[email protected]>
2019-02-25 23:39:31 +01:00
Martin Baulig 7f3a127b6d Remove unused (and broken) mono_btls_ssl_ctx_get_servername(). (#13184) 2019-02-25 20:15:17 +01:00
Bernhard Urban fc171a192a [aot] abort lookup early when a method isn't available in AOT image (#13138)
[aot] abort lookup early when a method isn't available in AOT image

Mixed mode depends on that.  Usually, compile_method of mini takes care
to request only existing methods from the AOT image, but in some cases,
e.g. from a trampoline, AOT runtime is quiered directly.

Contributes to https://github.com/xamarin/xamarin-macios/issues/5618
2019-02-25 10:56:15 -05:00
Jay Krell 2f3f58c7f1 [mkbundle] Fix mapping length (#13061)
* https://github.com/mono/mono/issues/11643 mkbundle problem - Illegal byte sequence

The size of the mapping is the maximum file offset to map.
See https://docs.microsoft.com/en-us/windows/desktop/Memory/creating-a-file-mapping-object.

When I tried it, I got a different error.

If in the debugger you simulate this fix, it gets further.

Here is a small program to exercise and see the behavior:

```
// include <windows.h>
// include <stdio.h>
// include <stdlib.h>
//
// int main()
// {
//  // Create a 128K file.
//
//  HANDLE file = CreateFile("1", GENERIC_READ | GENERIC_WRITE, 0, 0, CREATE_ALWAYS, 0, 0);
//  printf("createfile %p %d\n", file, GetLastError());
//
//  HANDLE map = CreateFileMapping(file, 0, PAGE_READWRITE, 0, 1 << 17, 0);
//  printf("createmap %p %d\n", map, GetLastError());
//
//  CloseHandle(map);
//  CloseHandle(file);
//  system("dir");
//
//  // Attempt to map the second 64K of the 128K file, with a 64K mapping.
//
//  file = CreateFile("1", GENERIC_READ | GENERIC_WRITE, 0, 0, OPEN_EXISTING, 0, 0);
//  printf("createfile %p %d\n", file, GetLastError());
//
//  map = CreateFileMapping(file, 0, PAGE_READWRITE, 0, 1 << 16, 0);
//  printf("createmap %p %d\n", map, GetLastError());
//
//   // This fails.
//
//  PVOID view = MapViewOfFile(map, FILE_MAP_WRITE, 0, 1 << 16, 1 << 16);
//  printf("view %p %d\n", view, GetLastError());
//
//  CloseHandle(map);
//
//  // Use a 128K mapping instead. It works.
//
//  map = CreateFileMapping(file, 0, PAGE_READWRITE, 0, 1 << 17, 0);
//  printf("createmap %p %d\n", map, GetLastError());
//
//  view = MapViewOfFile(map, FILE_MAP_WRITE, 0, 1 << 16, 1 << 16);
//  printf("view %p %d\n", view, GetLastError());
// }
```

Here is debugging mono and simulating the fix in the debugger (I did not build or test
the fix):

```

\bin\amd64\cdb C:\Users\jaykrell\Downloads\output\output.exe

0:000> bm kernel*!*createfilemap*
0:000> g

Breakpoint 2 hit
KERNELBASE!CreateFileMappingW:
00007ffd`0a449de0 4883ec48        sub     rsp,48h
0:000> dv
                  hFile = 0x00000000`00000200
lpFileMappingAttributes = 0x00000000`00000000
              flProtect = 2
      dwMaximumSizeHigh = 0
       dwMaximumSizeLow = 0x477000
                 lpName = 0x00000000`00000000 ""

0:000> bm kern*!*mapviewoffile*
0:000> g
Breakpoint 38 hit
KERNEL32!MapViewOfFileStub:
00007ffd`0b09bfa0 48ff2591c10500  jmp     qword ptr [KERNEL32!_imp_MapViewOfFile (00007ffd`0b0f8138)] ds:00007ffd`0b0f8138={KERNELBASE!MapViewOfFile (00007ffd`0a465ad0)}
0:000> dv
  hFileMappingObject = 0x00000000`00000204
     dwDesiredAccess = 4
    dwFileOffsetHigh = 0
     dwFileOffsetLow = 0x30000
dwNumberOfBytesToMap = 0x477000
0:000> gu
0:000> r rax
rax=0000000000000000
0:000> !gle
LastErrorValue: (Win32) 0x5 (5) - Access is denied.
LastStatusValue: (NTSTATUS) 0xc000001f - {Invalid Mapping}  An attempt was made to create a view for a section which is bigger than the section.

0:000> .restart
0:000> bm kernel*!*createfilemap*
0:000> g
0:000> dv
                  hFile = 0x00000000`00000220
lpFileMappingAttributes = 0x00000000`00000000
              flProtect = 2
      dwMaximumSizeHigh = 0
       dwMaximumSizeLow = 0x477000
                 lpName = 0x00000000`00000000 ""
0:000> ?? dwMaximumSizeLow += 0x30000
unsigned long 0x4a7000
0:000> bc *
0:000> g
Corlib not in sync with this runtime: The runtime did not find the mscorlib.dll it expected. Expected interface version CA4932AE-2294-4ECD-B863-BF98FDD84F33 but found 0CC970F6-6F25-4218-9427-3E4C3DC8DE33. Check that your runtime and class libraries are matching.
Loaded from: mscorlib.dll
Download a newer corlib or a newer runtime at http://www.mono-project.com/download.

```

* Restore useful part of comment.

* Restore dead code.

* Add to comment the other possibility that is being countered.

* Additional explanation.
2019-02-25 09:48:04 -05:00
Johan Lorensson e6d259b82c Fix multiple issues with response file option on Windows. (#13132)
* Fix multiple issues with --response file option on Windows.

* If file is UTF8 encoded and include BOM mark, implementation failed to
detect and remove BOM mark causing errors. Fix check for BOM mark and if
found, remove it before passed to parsing. NOTE, current implementation
only supports UTF8 (and ASCII) content in response file and won't detect
or handle any other codepages.

* Since the content in --response file should mimic what should have been
passed on command line, we should apply same parsing rules on Windows as done
by the shell when running the arguments on the command line. Current
implementation uses its own parsing that is not the same as used by the Windows
shell, meaning that arguments can't be identical in response file compared to
what's passed on command line. This commit fix parsing of the command
line in the response file so its first parsed by the shell before added
to internal argc, argv parameters (similar as done when passed to main function).

* Add support to handle new lines in response file on Windows.
2019-02-25 09:42:44 -05:00
Radek Doulik 4a96c5e715 [aot] Resolve profile against compiled assembly (#13148)
[aot] Resolve profile against compiled assembly

When trying to use AOT profile in XA for assembly AOT compilation, the
methods from the profile were not compiled.

Context: https://github.com/xamarin/xamarin-android/issues/2504

The problem was, the profile data were not resolved, as there was no
assembly loaded in the domain.

With this fix, the compiled assembly is used to resolve the profile as
well.
2019-02-25 08:35:48 -05:00
Marek Safar ecef8d334a [System.Private.CoreLib] Implement more APIs 2019-02-25 13:51:30 +01:00
monojenkins 8a417e9cb6 Bump API snapshot submodule 2019-02-25 13:30:32 +01:00
Martin Baulig aee90aca7c Make System.dll internals visible to Mono.Android. 2019-02-25 13:30:32 +01:00
Zoltan Varga c94af71bf0 [corlib] Hardcode IsRunningOnWindows as false on WASM too. (#13161) 2019-02-25 03:18:28 -05:00
Kenneth Pouncey fdbebe278e Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays 2019-02-25 04:54:45 +01:00
Zoltan Varga 6644136745 [wasm] Update to emscripten 1.38.28. (#13160)
* [wasm] Update to emscripten 1.38.28.

The emscripten patch is no longer needed.

* [wasm] Disable optimizations in SHA1Transform (), the normal version seems to cause stack overflows in binaryen's asm2wasm tool.
2019-02-24 22:50:31 -05:00
Zoltan Varga f52f874aae [wasm] Small fixes. (#13166)
* [wasm] Disable an unused icall which has an invalid signature under wasm.

* [aot] Make the dedup pass less verbose.
2019-02-24 22:42:55 -05:00
Eric StJohn b936c53101 Make System.Runtime.CompilerServices.Unsafe inbox (dotnet/corefx#35526)
* Make System.Runtime.CompilerServices.Unsafe inbox

Fix a couple places where we wanted to use it from other inbox assemblies but couldn't.

Unsafe remains as a package and newer versions of Unsafe will replace the inbox Version,
permitting us to add API over time.

* Update Rune tests to use TryEncodeToUtf8Bytes directly

* Add temporary suppression to package tests

Signed-off-by: dotnet-bot <[email protected]>
2019-02-23 08:52:41 +01:00
Ankit Jain 6df26e8287 [nuget] Add new versions of System.Net.Http
.. to the list of denied assemblies. Added `4.3.4`.

Prompted by issue #12603 .
2019-02-23 08:51:03 +01:00
Ankit Jain ae240f1f8e [nuget] Add new versions of System.Text.Encoding.CodePages ..
.. to the list of denied assemblies. Added:

- `4.5.0`
- `4.5.1`

Fixes issue #12603 .
2019-02-23 08:51:03 +01:00
Jan Kotas 6df88479c8 Change Environment.Version to return product version (dotnet/coreclr#22664)
* Change Environment.Version to return product version

- Contributes to https://github.com/dotnet/corefx/issues/31099
- Use AssemblyInformationalVersion attribute as fallback

* Add sanity test for Environment.Version

* Disable CodeDom tests

* Fix test assembly name

Signed-off-by: dotnet-bot <[email protected]>
2019-02-23 08:49:36 +01:00
Stephen Toub b0d3ead369 Ignore EINVAL/EBADF errors from FTruncate in FileStream.Init (#22788)
They indicate we're working with a special file, where failure to truncate is not a fatal condition.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-22 22:24:37 +01:00
Vincent Dondain 0525583d1e [System] Bump SocketTest.TestSelect1 socket timeout to 1ms (#13152)
- Previous test with 100 micro second timeout would fail on iOS device when running **all the socket tests** about 3 times out of 5.
- With a 1 millisecond timeout, it didn't fail the 10 times I tried locally, hopefully this is enough to fix the flakiness.
- Fixes #8360: [System.Net.Sockets] flakey failures of SocketTest.TestSelect1 on Darwin systems
  (https://github.com/mono/mono/issues/8360)
- Also partial fix for maccore issue https://github.com/xamarin/maccore/issues/1069
2019-02-22 21:28:06 +01:00
Kenneth Pouncey 80f8aa27b1 Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays
# Conflicts:
#	sdks/wasm/Makefile
2019-02-22 14:24:14 +01:00
Ankit Jain a4fada3900 [fsharp] Fix a type inference error introduced by recent changes (#13109)
```
@/external/bockbuild/builds/fsharp-fsharp-6624925/src/scripts/fssrgen.fsx(334,28): error FS0041: A unique overload for method 'GetFileNameWithoutExtension' could not be determined based on type information prior to this program point.
A type annotation may be needed. Candidates: System.IO.Path.GetFileNameWithoutExtension(path: System.ReadOnlySpan<char>) : System.ReadOnlySpan<char>, System.IO.Path.GetFileNameWithoutExtension(path: string) : string
[@/external/bockbuild/builds/fsharp-fsharp-6624925/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]
```
2019-02-22 08:00:41 -05:00
Bernhard Urban 3be2390665 [aot] add wrappers to "slim" mscorlib (i.e. --aot=interp) (#13137)
* [aot] add gc wrappers in interp scenario

* [aot] add icall wrappers in interp scenario
2019-02-22 07:59:53 -05:00
Zoltan Varga 55c998d282 [aot] Only emit the static interp trampolines/wrappers into the mscorlib AOT image. (#13117) 2019-02-22 07:58:57 -05:00
Ludovic Henry 49b6628370 [aot] use unbox arbitrary trampolines for "slim" mscorlib (#13139)
We need the recently introduced "unbox arbitrary" trampolines in one more
scenario: non-mscorlib AOT code calls a method from mscorlib with
interpreter. Before we just relied on the amodule not being available,
but mscorlib amodule is always present due to wrappers, trampolines,
etc.
2019-02-22 07:57:16 -05:00
Vlad Brezae b6775765ed [interp] Cleanup code a little (#13092)
* [interp] Cleanup code a little

* [interp] Rename rtm to imethod
2019-02-22 07:55:37 -05:00
Thays Grazia 1e1e0b6b01 [wasm] [debugger] Add test suite. (#13093)
* [wasm] [debugger] Add test suite.

* [wasm] [debugger] Add test suite.

* [wasm] [debugger] Add test suite.

* Changing what Larry suggested and removing some -debug that is not used.

* Adding the DebuggingTestSuite.

* indentation

* Update run-jenkins.sh
2019-02-22 07:52:59 -05:00
Zoltan Varga 50ce9ed8e5 [netcore] Implement AppContext. 2019-02-22 10:19:37 +01:00
monojenkins 66e88b1e6b [bcl] Update BCL Linked Size 2019-02-22 10:03:28 +01:00
Bernhard Urban af46af33a1 [jit/cprop] insert dummy insn if first insn of basic block got replaced (#13127)
[jit/cprop] insert dummy insn if first insn of basic block got replaced

Fixes https://github.com/mono/mono/issues/13056 & https://github.com/mono/mono/issues/13057
2019-02-21 21:05:34 -05:00
Bernhard Urban 8891a4b778 [aot] use unbox arbitrary trampolines for "slim" mscorlib
We need the recently introduced "unbox arbitrary" trampolines in one more
scenario: non-mscorlib AOT code calls a method from mscorlib with
interpreter. Before we just relied on the amodule not being available,
but mscorlib amodule is always present due to wrappers, trampolines,
etc.
2019-02-21 23:28:41 +01:00
Zoltan Varga 2124448a37 [runtime] Move mono_get_context_capture_method () from security-manager.c to object.c. (#13071) 2019-02-21 16:26:05 -05:00
Maxim Lipnin 506406df06 Try to extract valid drive name from DriveInfo ctor string argument (#13105)
It's possible to pass any string as an argument to DriveInfo ctor (e.g.  `new DriveInfo(Path.GetTempPath())`). Mono throws ArgumentException if there is no exactly the same drive name in the list of available drives.

I tried to handle this case by extracting any valid drive name from the array of available drives sorted by path in descending order.

Fixes https://github.com/mono/mono/issues/12157
2019-02-21 21:57:55 +01:00
Marek Safar 020ce70e30 [System.Private.CoreLib] Implement more APIs 2019-02-21 21:34:18 +01:00
Martin Baulig 7277e3bb5e SslStream improvements and tests
* Add server-side Server-Name-Indication (SNI) support (both AppleTls and BTLS).

* Support the new `SslServerAuthenticationOptions.ServerCertificateSelectionCallback`.

* Server certificate selection is now compatible with CoreFx behavior; first
  checking the new `ServerCertSelectionDelegate` then `LocalCertSelectionCallback`
  and finally using an explicitly provided certificate.

* Misc exception checks and fixes to make behavior consistent with CoreFx;
  any exception thrown by reading / writing the underlying stream will now be
  propagated verbatim (and not wrapped in an `AuthenticationException`);
  exceptions thrown by the handshake / TLS stack itself will still be wrapped.

* Added `System.Net.Security` xUnit tests from CoreFx.

* Misc test cleanups; moved certificate test files from `System.Net.Http` into
  `System` and embed them in the test assembly as resources, adjusting
  `test-helpers/Configuration.Certificates.cs` accordingly.
2019-02-21 20:43:25 +01:00
Zoltan Varga aa04713723 [llvmonly] Do null checks on interp transitions for virtual->non virtual calls. (#13118)
Fixes https://github.com/mono/mono/issues/12998.
2019-02-21 12:24:14 -05:00
Alexander Köplinger b740313aa5 [sdks] Make sure to run only one build per type per node
They could conflict while provisioning android toolchains etc. otherwise.
2019-02-21 17:33:41 +01:00
Ankit Jain bda914c9b5 [bockbuild] Bump to master HEAD to get new fixes (#13108) 2019-02-21 17:19:27 +01:00
Zoltan Varga 576b1a0827 [llvm] Mark the branch in OP_GC_SAFE_POINT as taken. (#13114) 2019-02-21 10:08:04 -05:00
Kenneth Pouncey 7038d1915a Small cleanup 2019-02-21 14:05:08 +01:00
Kenneth Pouncey 49b92c95d0 Modify public interface CopyTo and CopyFrom to use lightweight Span<U>.
- Modifications in response to review comments.
2019-02-21 14:03:24 +01:00
Johan Lorensson 6f786bc465 Disable Mono.CSharp on Windows x64 full AOT test. (#13124)
Not part (and should not be) part of the winaot profile and therefore not testable (even though they pass when manually AOT:ing the assembly).
2019-02-21 13:29:34 +01:00
Vlad Brezae ff84ee290e [runtime] Remove dead code (#13089)
[runtime] Remove dead code

Interface method calls on constrained types are resolved in get_method_constrained now (apparently since https://github.com/mono/mono/commit/3259e04ace67552fc8d63a8f1ddbb830e526f05f)
2019-02-21 06:55:48 -05:00
Tanner Gooding af1034a99c Enable the HWIntrinsic extension methods and remove the instance implementations (#22705)
* Removing various S.R.I.Vector instance method APIs, since they should now be exposed as extension methods

* Updating the JIT to recognize the S.R.I.Vector extension methods.

* Updating various S.R.I.Vector test templates

* Regenerating the S.R.I tests that are created from a template.

* Fixing the numArgs for Base_Vector256_GetLower

* Fixing the handling for `Base_VectorXXX_As` to normalize the struct type.

* Adding the Base_Vector128_As intrinsics back for arm64

Signed-off-by: dotnet-bot <[email protected]>
2019-02-21 12:26:09 +01:00
Nikolay Sivov ffd601eed4 Fix some compiler warnings (#13044)
Fix some compiler warnings

Compiled with gcc 8.2.0/x86_64-linux-gnu.
2019-02-21 06:05:47 -05:00
Vlad Brezae 809e40435f [tests] Fix function signature (#13090)
[tests] Fix function signature

To match pinvoke signature from pinvoke-2 test.
2019-02-21 04:15:53 -05:00
Johan Lorensson 3622703cbe Enable all CI test suites for Windows x64 full AOT. (#13102) 2019-02-21 10:04:20 +01:00
Ben Adams bcdc345b44 Reduce struct copy by 1 in ValueTask.GetAwaiter (dotnet/coreclr#22738)
* Reduce struct copy by 1 in ValueTask.GetAwaiter

* Bit more explicit

Signed-off-by: dotnet-bot <[email protected]>
2019-02-21 10:02:14 +01:00
Filip Navara 5d36e4b2a7 Move Thread to shared CoreLib (dotnet/corefx#35462)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-21 10:00:54 +01:00
Zoltan Varga b4943dec39 [jit] Fix the loaded llvm build. (#13110) 2019-02-21 03:45:36 -05:00
Zoltan Varga d48b84d67f [llvm] Fix a 'incoming phi sreg1' llvm failure which happens with valuetypes+phi nodes. (#13077)
[llvm] Fix a 'incoming phi sreg1' llvm failure which happens with valuetypes+phi nodes.

Fixes https://github.com/mono/mono/issues/12988.
2019-02-21 03:35:54 -05:00
Aleksey Kliger (λgeek) 72512cfbcb [loader] Fix off by 1 (netstandard is a framework facade) (#13111)
[loader] Fix off by 1 (netstandard is a framework facade)

Before 5e0d39a8a1, there used to be a handwritten binary search that traveersed `framework_assemblies` to determine if a given assembly was a framework assembly or not.  The binary search used `last = G_N_ELEMENTS (framework_assemblies) - 1` as the initial condition, but it used an inclusive `first <= last` as the loop count.

After we switched to a hashtable, we used the same final value initialize `assembly_remapping_table`.

We didn't notice because `mscorlib` used to be the last assembly in the table and `mscorlib` already has a ton of special handling in the loader.  But `netstandard` is not special.  So we added it to the table, but it still doesn't get special handling.

This should fix instances where code references netstandard 2.0.0.0, but we give it netstandard 2.1.0.0

https://github.com/mono/mono/blob/f8094319132d2d40f37e8cac6058e783b5648260/mono/metadata/assembly.c#L345
2019-02-21 01:45:50 -05:00
Stephen Toub f809431913 Use ThrowHelper in ManualResetValueTaskSourceCore (dotnet/coreclr#22714)
Just move the helper being used to ThrowHelper.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-20 22:47:35 +01:00
Stephen Toub a5e27b6316 Fix bug introduced during cleanup in JapaneseLunisolarCalendar (#22717)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-20 20:24:29 +01:00
Ben Adams bce27a80de Allow Task.WaitAny completion to run synchronously (dotnet/coreclr#21245)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-20 20:24:29 +01:00
Johan Lorensson 795dc5ebd2 Remaining fixes needed to pass rest of CI test suites for windows x64 full AOT. (#13084)
* Fix for runtime mcs-compileall test on Windows x64 full AOT.

Test picked up full AOT:ed libraries as well as managed libraries failing
the test. Full AOT:ed shared libraries on Windows has .dll.dll prefix and
full AOT:ed executables on Windows has .exe.dll prefix.

Fix makes sure to filter out any files ending with dll.dll or exe.dll.

* Fix build errors in System.Web.Services test under winaot profile.

* Fix errors in System.Core test under winaot profile.

* Fix build error in linker tests on Windows under winaot profile.

Build fails since profile build mscorlib is used as well as default
triggering build error. Fix is to build linker tests using -nostdlib flag.
2019-02-20 14:17:10 -05:00
Johan Lorensson 3bcebfb0a0 Don't install jay as part of make install. (#13086)
Should not be part of the package and cause issues on Windows 32-bit
cygwin build since it's not using makefile generated by autotools. When
make install is run it will build jay one more time, but picking up
cygwin default gcc compiler instead of the one used in configure step, mingw.
That cause link errors since the object files are not rebuild, only relinked
with different linker, causing errors.
2019-02-20 14:01:03 -05:00
Alexander Köplinger 78ef5a9722 [ci] Prefer gmake over make for SDKs build (#13091)
Apple's make doesn't support the --output-sync option and Homebrew's make is installed as gmake.

Also fixed a few places in the repo where we directly invoked make instead of $(MAKE).
2019-02-20 19:46:54 +01:00
Marek Safar 951803d082 [System.Private.CoreLib] Implement more APIs 2019-02-20 17:55:17 +01:00
Stephen Toub 5ec1def012 Fix race condition in ManualResetValueTaskSourceCore (dotnet/coreclr#22711)
* Fix race condition in ManualResetValueTaskSourceCore

ManualResetValueTaskSourceCore.GetStatus is used from ValueTaskAwaiter.IsCompleted.  If GetStatus returns Success too early, then IsCompleted will also return true too early, which will result in GetResult being called too early.  This doesn't happen today when an MRVTSC is used sequentially.  But if an instance is pooled by the object its stored on getting put back into a pool as part of a call to the wrapper's GetResult, then we can end up in the following situation:
- Thread 1 starts an await on an instance containing an MRVTSC.  It calls IsCompleted.
- Thread 2 starts to complete that instance, getting as far as calling SignalCompletion and setting _completed to true but not yet setting _continuation.
- Thread 1 sees _completed == true and returns true from IsCompleted.  It calls GetResult, and the wrapper extracts the result from the instance, resets it, and puts it back into the pool.
- Thread 3 takes the object out of the pool and starts using it.
- Thread 2 continues SignalCompletion on that instance, and sets _continuation to the sentinel.
- Now Thread 3's instance's _continuation is the sentinel when it should be null.  If it calls SignalCompletion, it'll erroneously find that _continuation is not null and will queue _continuation/_continuationState for execution, resulting in the sentinel getting executed.  If it calls OnCompleted, it'll find that the _continuation is not null, and will queue the supplied continuation/state to execute immediately even though the operation may not yet actually be done.

The fix is simply to check not just _completed but also _continuation.  The operation is considered pending if either _completed is false, meaning SignalCompletion has not yet been called, or if _continuation is still null, meaning it's neither been set to the supplied delegate nor to the sentinel.  We can't just rely on _completed for the above outlined reasons, and we can't just rely on _continuation because it can be non-null if OnCompleted was called to hook up a callback (if we only cared about the await pattern, then we could just check _continuation and wouldn't need _completed, but we also need to support non-await access).

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-02-20 13:02:45 +01:00
Alexander Köplinger 3ac43f72bb Update sdks-archive.groovy android packages 2019-02-20 11:46:36 +01:00
Egor Bogatov 3c41d74f1e NS2.1: System.Security.Cryptography changes (#13022)
* NS21: X509Store, rsa.cs

* More NS2.1 changes

* remove X509Stubs.cs

* Add corert/CancellationTokenRegistration.cs

* Implement Socket.ReceiveAsync

* Add X509Certificates stubs

* bump corefx and corert

* bump corefx

* remove corefx/tmp

* Bump API snapshot submodule

* [csproj] Update project files
2019-02-20 11:43:26 +01:00
monojenkins fceb9471e2 [bcl] Update BCL Linked Size 2019-02-20 09:16:55 +01:00
Jan Kotas ad4c22c4f4 Use out arguments in UmAlQuraCalendar (dotnet/coreclr#22704)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-20 09:13:30 +01:00
Kenneth Pouncey 16f1845a19 Fix spacing 2019-02-20 07:30:24 +01:00
Kenneth Pouncey 2e4713cb39 Fix spelling 2019-02-20 07:29:49 +01:00
Kenneth Pouncey d60440869c Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays 2019-02-20 06:40:15 +01:00
Ludovic Henry 7f017427ea Update CODEOWNERS 2019-02-19 19:41:45 -05:00
Radek Doulik 30799ff97f [profiler] Do not print that many new lines (#13060)
The `mono_profiler_printf` already adds `\n` char, so we don't need to
add them in most cases.

Before the fix the output of aot profiler with verbose enabled looked
like:

    02-19 10:50:02.877 22795 22815 I mono-prof: System.OutOfMemoryException:.ctor (string) 2
    02-19 10:50:02.877 22795 22815 I mono-prof:
    02-19 10:50:02.877 22795 22815 I mono-prof: System.SystemException:.ctor (string) 4
    02-19 10:50:02.877 22795 22815 I mono-prof:
    02-19 10:50:02.877 22795 22815 I mono-prof: System.Exception:.ctor (string) 6
    02-19 10:50:02.877 22795 22815 I mono-prof:
    02-19 10:50:02.877 22795 22815 I mono-prof: System.Exception:.cctor () 7
    02-19 10:50:02.877 22795 22815 I mono-prof:
    ...

The `usage ()`'s output should now look similar to other profilers
usage output.
2019-02-19 18:27:04 -05:00
Stephen Toub aff251e11c Move EventRegistrationToken to shared (dotnet/coreclr#22565)
* Move EventRegistrationToken to shared

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-02-20 00:18:55 +01:00
Stephen Toub e5f7fa3e67 Use RunContinuationsAsynchronously in SemaphoreSlim.WaitAsync (#22686)
SemaphoreSlim.Release shouldn't invoke arbitrary continuations as part of its invocation, so when it dequeues a task waiter and goes to complete it, rather than just calling TrySetResult, it queues the task to the thread pool to have TrySetResult invoked there.  Now that we have RunContinuationsAsynchronously, though, we can just use that functionality instead.  This has two main benefits:
1. We avoid queueing a work item entirely if there are no continuations from the task.  This might happen, for example, if the semaphore is released so quickly after waiting on it that the WaitAsync caller hasn't yet hooked up a continuation, in which case the await on the WaitAsync task will just see IsCompleted as true and continue running.
2. We avoid queueing a work item when the task represents a synchronous Wait, which happens if there's already a pending WaitAsync when Wait goes to block.  The main benefit here is avoiding potential thread pool starvation, if threads in the pool are blocked in such Waits, and previously another thread pool thread would have been needed to run the queued work item to complete the synchronous Wait.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-19 23:45:33 +01:00
Hugh Bellamy dc32ce591e Cleanup Calendars code (dotnet/coreclr#22582)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-19 23:45:33 +01:00
Martin Baulig 23762efca5 Add temporary workaround for internal StreamContent constructor. 2019-02-19 23:19:07 +01:00
Maxim Lipnin c890be00c9 use for loop to access item values and avoid InvalidCastException which occurs because VirtualDirectoryMappingCollection enumerator returns key and it's not expected 2019-02-19 21:08:02 +01:00
Fei Peng 1f33f3923a Optimize Vector128/256<T>.Get/WithElement (dotnet/coreclr#22353)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-19 17:08:46 +01:00
Johan Lorensson 187711df20 Enable runtime + corlib tests on CI for Windows x64 full AOT. (#13059) 2019-02-19 09:37:43 -05:00
Vlad Brezae c21c2df0af [interp] Kill stinarg opcodes (#13038)
* [interp] Extract some duplicated code

* [interp] Kill stinarg opcodes

Before we were reallocating the arguments in the current frame and had a stinarg opcode for copying each argument there. Access the arguments directly from the parent frame, to reduce call overhead. This can give up to 5-10% general speedup.
2019-02-19 08:40:00 -05:00
roozbehid af0bdab76d add missing typeforwardes in facades (#12694)
* add missing typeforwardes

* Bump API snapshot submodule
2019-02-19 13:38:17 +01:00
Zoltan Varga 9f9067094f [netcore] Fix GCHandles, the lowest bit is used by the GCHandle class to store information. 2019-02-19 10:51:51 +01:00
Marek Safar 2e88b48fde [mcs] Remove doc about CAS security 2019-02-19 10:14:48 +01:00
Zoltan Varga b8b2469380 [jit] Add a few more unsafe intrinsics. (#12971) 2019-02-19 02:27:40 -05:00
Katelyn Gadd 66092e0571 Update roslyn-binaries submodule to point to latest master revision (#12833)
This updates our roslyn submodule so that the new csc-dim is available.
2019-02-18 22:54:54 +01:00
Alexander Köplinger 1c26f21c0d Bump linker submodule to latest master (#13031)
* Bump linker submodule to latest master

* [csproj] Update project files
2019-02-18 14:02:34 +01:00
Phil Jaenke 8c185ed423 Remove leading . from script invocation (#13046)
The leading `.` in the script invocation causes the tests to fail on multiple platforms by causing the required argument to not be passed correctly resulting in bad output. Removal of the leading `.` ensures correct operation on all platforms.
2019-02-18 12:45:25 +01:00
Alexander Köplinger 602bdea385 Set executable bit for all .sh files in repo 2019-02-18 12:39:57 +01:00
bwadswor fe7c3d43e5 Correct access permissions to include "user execute" for run-msbuild.sh. (#13042)
Correct access permissions for run-msbuild.sh.  Adding "user execute" seems to fix the following build error.  With this change I'm able to build on windows in Cygwin.  without, I see the below error:

```
$ make -j4
(CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /cygdrive/c/mono/mono/missing autoheader)
rm -f stamp-h1
touch config.h.in
cd . && /bin/sh ./config.status config.h
config.status: creating config.h
config.status: config.h is unchanged
Git submodules updated successfully
make  all-recursive
make[1]: Entering directory '/cygdrive/c/mono/mono'
Making all in msvc
make[2]: Entering directory '/cygdrive/c/mono/mono/msvc'
Building Mono runtime using Visual Studio.
../msvc/run-msbuild.sh "build" "i686"
**/bin/sh: ../msvc/run-msbuild.sh: Permission denied**
make[2]: *** [Makefile:614: all-local] Error 126
make[2]: Leaving directory '/cygdrive/c/mono/mono/msvc'
make[1]: *** [Makefile:583: all-recursive] Error 1
make[1]: Leaving directory '/cygdrive/c/mono/mono'
make: *** [Makefile:513: all] Error 2
```
2019-02-18 12:34:29 +01:00
Zoltan Varga 77644b833e [netcore] EH work (#13041)
* [netcore] Switch to Debugger class from corlib.

* [netcore] Implement exception stack trace support.

* Address review comments.

* [netcore] Create a netcore specific version of Exception based on the refsource version.
2019-02-18 10:20:45 +01:00
Martin Baulig 099e003240 Add types supporting C# 8.0 Ranges. (#12841)
* Add types for C# 8.0 Ranges.

* Add workaround from @lewurm to fix the native crash.

* Fix compiler error test.

* [interp] guard span get_item intrinsic regarding its signature

* Cleanup sources and remove duplicates; thanks Egor!

* Bump API snapshot submodule

* [csproj] Update project files
2019-02-18 09:55:45 +01:00
Marek Safar ad62ab26b7 Merge pull request #13040 from marek-safar/build-fixes
[System.Private.CoreLib] Implement more APIs
2019-02-17 11:03:18 +01:00
Jan Kotas 003a626bba Avoid pulling in Lazy<T> during startup (dotnet/coreclr#22659)
Environment constructor runs on every startup path. Remove dependency on Lazy<T> from it.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-17 11:02:36 +01:00
Thays Grazia 194b82b8b0 If getter is not implemented in a property we don't want to show this property, in Vs the behaviour is the same. (#13033)
Fixes #12964
2019-02-16 11:48:00 -02:00
Marek Safar f0ca41c781 [System.Private.CoreLib] Implement more APIs 2019-02-16 00:47:18 +01:00
Tanner Gooding a12209bf52 Updating some local functions to be 'static' (captureless). (#22635)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-16 00:20:34 +01:00
Alexander Kyte 12b3dbcc38 [crash] Move dump_memory_around_ip after the native crash (#13021)
If someone jumps to a bogus address for some reason, this will
double-fault. On OSX, a double fault is often a hang.
2019-02-15 18:14:03 -05:00
Vlad Brezae b3839e4434 [interp] Fix unaligned crashes on arm (#12985)
* [interp] Fix unaligned access crashes on arm

strd instruction fails if the memory address is not word aligned.

Fixes corlib-xunit suite on arm.

* [interp] Fix warning
2019-02-16 00:06:00 +02:00
Alexander Köplinger d224a047e0 Revert "[Facades] Remove System.Drawing.Primitives from xammac_net_4_5_SUBDIRS"
This reverts commit 9c1fd50666.

This is wrong, net_4_x_SUBDIRS only includes common_deps_SUBDIRS, not common_SUBDIRS.
2019-02-15 20:39:33 +01:00
Ludovic Henry 42f7bff05b [ci] Fix Bitcode{+Interpter} on AArch64 (#13016) 2019-02-15 13:38:20 -05:00
Kenneth Pouncey ccfa653b48 [wasm][CI] Reactivate Chakra tests in CI (#13026)
- Chakra install fails: https://github.com/Microsoft/ChakraCore/issues/5945
2019-02-15 12:12:37 +01:00
Alexander Köplinger 9c1fd50666 [Facades] Remove System.Drawing.Primitives from xammac_net_4_5_SUBDIRS
It's already included in the common_SUBDIRS and confuses a build safeguard in xamarin-macios.
2019-02-15 12:03:40 +01:00
Marek Safar 34c3055a7c Move Interlocked 2019-02-15 09:25:26 +01:00
Tanner Gooding 884b4c2473 Fixing the number formatting code to only recognize 'R' for double/float. (#22613)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-15 09:25:26 +01:00
Marek Safar f2c8664ac1 Move Reflection.Emit Tokens to shared partition (dotnet/coreclr#22602)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-15 09:25:26 +01:00
monojenkins 4ee073da2a [bcl] Update BCL Linked Size 2019-02-15 08:34:51 +01:00
Grant 7e52c1973e Missed optimization from #22497
Signed-off-by: dotnet-bot <[email protected]>
2019-02-15 08:33:24 +01:00
Larry Ewing 7f0eaf39ca Add some blazor binaries to bcl-size-diff 2019-02-14 23:57:30 +01:00
Grant d91a227cba Consolidate implementation of Rotate and PopCount (dotnet/coreclr#22584)
* Perf: BitOps.LeadingZeroCount

* Remove redundant MSIL cast, conv.u8

* Use local functions for SoftwareFallback

* Target BIT32/64

Signed-off-by: dotnet-bot <[email protected]>
2019-02-14 23:00:36 +01:00
Marek Safar 8294fc0588 Remove local FrameworkEventSource 2019-02-14 22:47:06 +01:00
Marek Safar dbac2e4ffc Move FrameworkEventSource to shared partition (dotnet/coreclr#22507)
* Move FrameworkEventSource to shared partition

and remove unused code

* Remove more unused code

* Remove CA8001 suppress message

Signed-off-by: dotnet-bot <[email protected]>
2019-02-14 22:47:06 +01:00
Levi Broderick 776e2a84c3 Add Rune creation API from UTF-16 surrogate pair (dotnet/coreclr#22590)
Also brings in some perf improvements to existing char and UnicodeUtility APIs

Signed-off-by: dotnet-bot <[email protected]>
2019-02-14 22:47:06 +01:00
Egor Bogatov cf69b47259 NS2.1: System.IO, System.Reflection.Emit, etc (#12854)
* System.IO, System.Data

* lots of small ns21 improvements

* More changes (System.Reflection.Emit)

* Add IEquatable to S.R.Emit types

* bump corefx

* fix unix build

* more NS21 changes

* more changes

* bump corefx

* Fix failing tests (Sockets)

* bump corefx

* tmp workaround

* move DispatchProxyGenerator to net_4_x

* Bump API snapshot submodule

* [csproj] Update project files
2019-02-14 22:40:58 +01:00
Grant 572d9928c0 Perf: Consolidate implementation of LeadingZeroCount (dotnet/coreclr#22497)
* Perf: BitOps.LeadingZeroCount

* CR fix

* CR fixes

* Optimization

* Revert

* Confirmed fix

* Simplify

* Return int

* Fixes

* Simplify

* CR fixes

* CR fixes

* Fix unit failure on Linux-musl x64 Debug

* CR fixes

* CR fixes

* Cleanup

Signed-off-by: dotnet-bot <[email protected]>
2019-02-14 22:38:32 +01:00
Fei Peng 938477a7de Remove unnecessary ThrowIfUnsupportedType calls and definitions
Signed-off-by: dotnet-bot <[email protected]>
2019-02-14 22:38:32 +01:00
Ludovic Henry 1be2bbce16 [ci] Enable working Bitcode{+Interpreter} test suites (#12997) 2019-02-14 14:47:05 -05:00
Martin Baulig 5c754423f2 Pass X509Certificate2 to the certificate validator.
This makes us consistent with corefx; see also
https://github.com/dotnet/corefx/pull/35306.

Using `X509Certificate` has become a problem because the
`HttpClientHandler.ServerCertificateCustomValidationCallback`
callback takes an `X509Certificate2` parameter.
2019-02-14 18:27:13 +01:00
Maxim Lipnin 347af5d61f Bump ikdasm 2019-02-14 18:09:49 +01:00
Rolf Bjarne Kvinge 4fec79cc6a [tests] Add the BitcodeNotSupported category to tests exercising non-bitcode-compatible API. (#13007)
* [tests] Add the BitcodeNotSupported category to tests exercising non-bitcode-compatible API.

We have APIs that use exception filter clauses, and we don't support that when
compiling to bitcode.

So mark any tests exercising such API accordingly, so that we can skip those
tests when running tests on targets that use bitcode (watchOS).

* [tests] Use BitcodeNotSupported on applying profiles
2019-02-14 11:49:29 -05:00
Bernhard Urban 920a621367 [bitcode] round up value type size for slot calculation (#12992)
consider

```csharp
struct S3
{
    public ushort X;
    public ushort Y;
    public ushort Z;
}
```
this would be 3 * 2 = 6 bytes. Structs, however, are passed around as i32
arrays in LLVM IR between functions. Those, if such a struct is passed, are
split to int32 depending on the struct's size. The previous calulation was
wrongly reserving one such i32 slot instead of two for `S3` above.

Additionally increase slot size to i64 so that it aligns with a
slightly different ABI on arm64_32.
2019-02-14 14:56:45 +01:00
Alexander Köplinger 9e8317f877 [System.Net.Http] Improve HttpClientTest to use the retry http listener (#12994)
It was missed in https://github.com/mono/mono/pull/11829 so we were still manually
creating HttpListeners which are not hardened against "Address already in use".

Should fix/improve https://github.com/xamarin/maccore/issues/1407.
2019-02-14 11:32:12 +01:00
Zoltan Varga f1ccdc49a9 [runtime] Avoid depending on the layout of the ParameterInfo class in the runtime, netcore has a version with a different layout. (#12980) 2019-02-14 09:32:42 +01:00
Kenneth Pouncey f5084b594f Move the index accessors to TypedArray instead duplicating the logic. 2019-02-14 06:32:37 +01:00
Alexander Kyte 4b83678a4a [crash] Add more detailed reporting for exceptions (#12946)
* [crash] Add more detailed reporting for exceptions

This bumps the crash reporting file format to version 0.0.3.

* [crash] Fix exception stack walker to consider captured_traces

Previously we were missing these frames from the captured_traces fields
of MonoException and MonoStackTrace.
2019-02-13 23:27:17 -05:00
Ludovic Henry e0643e5ac7 [ci] Fix Linux x64 Bitcode job (#12970)
* [ci] Fix Linux x64 Bitcode job

* [ci] Add Bitcode+Interpreter job

* [ci] Improve output information when AOTting the BCL
2019-02-13 18:31:31 -05:00
Alexander Köplinger 1c2ef6a472 Mono.Native: Simplify checking for min-version
We don't need to do the replacement sed magic for the compat library,
it should just use whatever is passed in.
2019-02-13 23:36:07 +01:00
Alexander Köplinger ae507fc4c4 [corlib] Fix CustomAttributeDataTest.MethodIncludesDllImportAttributeData() on watch/tv
Bitcode requires that the native symbol exists.
Changed the pinvoke to something that exists in libc.
2019-02-13 23:35:52 +01:00
Marek Safar 689e9b2e03 Remove local SafeHandle version 2019-02-13 23:24:44 +01:00
Stephen Toub 85caf55c16 Move SafeHandle to managed code and shared (dotnet/coreclr#22564)
* Move SafeHandle to managed code and shared

This moves the implementation of SafeHandle from native code in the runtime to managed.  I used corert's implementation as a base, and reviewed it again against the existing native implementation, making a few tweaks to better match the existing semantics.

This should be a valid move because of the reduced goals around CERs, thread aborts, etc.

However, there are places in the runtime that access SafeHandle functionality via its native counterpart, so I kept the relevant pieces of the native code intact.  Most code will continue to use the managed APIs, but the runtime can continue calling into the native versions when needed.

* Address PR feedback

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-02-13 23:24:44 +01:00
Alexander Köplinger c81e675866 [wasm][ci] Disable ChakraCore tests"
Downloading ChakraCore is broken right now due to https://github.com/Microsoft/ChakraCore/issues/5945.
2019-02-13 23:06:12 +01:00
Michal Strehovský 268f9e41cc Annotate EventCounter as a relocated type (dotnet/corert#6990)
This moved to CoreLib and needs to be annotated as such for Project N.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-13 21:06:20 +01:00
Fei Peng 745499f724 Remove unnecessary ThrowIfUnsupportedType calls and definitions
Signed-off-by: dotnet-bot <[email protected]>
2019-02-13 20:57:02 +01:00
Ludovic Henry bbb71e04a0 [ci] Use testing_aot_full_interp for FullAOT+Interpreter+LLVM (#12976) 2019-02-13 09:56:32 -05:00
Kenneth Pouncey 49d1d1795b Add U : struct constraint on TypeArray. Addresses comment review. 2019-02-13 15:38:07 +01:00
Kenneth Pouncey 1f9533a777 Fix delegate call back. Causes memory access crash with AOT. 2019-02-13 14:45:04 +01:00
Aleksey Kliger (λgeek) 5f1a8e7764 [debug-helpers] Include custom modifiers in mono_type_get_desc (#12979)
* [debug-helpers] Include custom modifiers in mono_type_get_desc

* [mini] Print return type in MONO_METHOD_VERBOSE output
2019-02-13 08:38:16 -05:00
Zoltan Varga 2466c2fc79 [netcore] Implement Assembly/AssemblyName/Module.
For RuntimeAssembly, make a fork since the amount of changes is very big. For AssemblyName/RuntimeModule, use the corlib version with some
ifdefs.
2019-02-13 11:11:37 +01:00
Kenneth Pouncey d81f8c7370 Modification of sdk framework build to not include the initialisation of the Bindings as it is now automatic. 2019-02-13 10:46:46 +01:00
Kenneth Pouncey 6dc1f10af1 Add corebindings build module and inclusion AOT
- Conditional include of bindings depending on if  --nobindings is specified.
- Packager: AOT ninja build modifications.
   - Add corebindings build dependency
   - Add bindings_support.j build dependency
   - Remove dependency to add Bindings initialisation to build and mono_config.js
 - Modify runtime.js and runtime-tests.js to remove the bindings initialisation code.
2019-02-13 10:45:12 +01:00
Ludovic Henry a43f1d2909 [sdks] Add mac-{mac32,mac64} targets (#12959)
* [sdks] Add mac-{mac32,mac64} targets

* [sdks] Add configure-* and build-* for CI
2019-02-12 18:57:56 -05:00
Tarek Mahmoud Sayed 469b0a7a0f Index and Range updates (dotnet/coreclr#22331)
* Index and Range updates

* Address @mikedn  feedback

* Address Feedback

* more feedback

* Use Deconstruct in Range.GetOffsetAndLength

* Rename GetArrayRange to GetSubArray

* Temporary disable the old Corefx Range tests

* Return back the TimeSpan test disabling

* Fix Range jit test

* Exclude the jit test

* revert the changes in the jit Range test

* Address Suggested Feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-02-13 00:01:05 +01:00
Jan Kotas 781bebfdcb Fix CoreRT build breaks - Adjust resource name - Workaround C# compiler/analyzer bug
Signed-off-by: dotnet-bot <[email protected]>
2019-02-12 23:36:22 +01:00
Marek Safar 3f5471a602 Remove local version of GCHandle 2019-02-12 21:19:29 +01:00
Stephen Toub 64a626fa87 Move GCHandle to shared (dotnet/coreclr#22499)
* Move GCHandle to shared

* Cache the handle in a local to make it easier for JIT to generate good code

* Rename m_handle to _handle to match the coding conventions

* Delete isPinned argument for GCHandleInternalCompareExchange

* Add fast path to GCHandle.Alloc/Free FCalls

* Disable outdated test

Signed-off-by: dotnet-bot <[email protected]>
2019-02-12 21:19:29 +01:00
Sung Yoon Whang c005351c61 Renaming RuntimeEventSource to NativeRuntimeEventSource (#22533)
* Renaming RuntimeEventSource to NativeRuntimeEventSource

* missed a couple of comments and XPlatEventLogger

* rename DotNETRuntimeEventSource.cs to NativeRuntimeEventSource.cs

* use condition= instead of ifdef

* removing ifdef from NativeRuntimeEventSource.cs

* Fix case for 'eventing' directory in csproj

* Fix unix builds

* This should fix unix build...

Signed-off-by: dotnet-bot <[email protected]>
2019-02-12 20:57:00 +01:00
Tanner Gooding 39f83e1925 Add extensions methods for several of the VectorXXX<T> helper methods (#22336)
* Moving several of the Vector128<T> instance methods to be extension methods.

* Moving several of the Vector256<T> instance methods to be extension methods.

* Moving several of the Vector64<T> instance methods to be extension methods.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-12 19:18:32 +01:00
Marek Safar d0c5bcff23 Fix the build 2019-02-12 18:37:19 +01:00
Marek Safar 27ea466b0b [System.Private.CoreLib] Clean up EqualityComparer 2019-02-12 18:37:19 +01:00
Thays Grazia 5f65ce9f7d [debugger] Reverting part of https://github.com/mono/mono/pull/12114 (#12950)
* [debugger] Reverting part of this commit https://github.com/mono/mono/pull/12114, removing this part the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881.
Inserted a new test that reproduces the regression.
Fixes #12881
2019-02-12 14:20:38 -02:00
Larry Ewing 2b9e5db153 Remove the logic that prepends a line in source references
Remove the hack that injected an extra line with the source
location now that we reference local sources when we can and
fix the Match logic so that it corrects for the difference
between pdbs and chrome breakpoints
2019-02-12 10:06:31 -06:00
Larry Ewing 2dcbeb5548 Use file: urls when when the files exist locally
Unknown schemes (dotnet:) are not well supported by all the
tools that support the chrome DevTools protocol so if the
file exists locally use a file: url rather than a dotnet:
url to reference it.
2019-02-12 10:06:31 -06:00
Larry Ewing 36d26498d4 Handle urlRegex breakpoint requests.
VisualStudio debug agents use urlRegex rather than url
when looking for breakpoint locations so add support for those
requests.
2019-02-12 10:06:31 -06:00
Larry Ewing 419646c960 VSCode expects the decription field to be populated for the variables display 2019-02-12 09:37:01 -06:00
Larry Ewing ce751cbe55 Make sure we add callFrameId so that the debugger populates locals 2019-02-12 09:37:01 -06:00
Michal Strehovský 52d6e18ea6 Ifdef out code that triggers UTC bug (dotnet/corert#7003)
This results in bad codegen on AMD64. I filed a bug internally; hopefully we can get a fix soon.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-12 16:17:04 +01:00
hamish-rose 412f75a1c5 Add new rounding modes to System.Math, System.MathF (dotnet/coreclr#20815)
* add new rounding modes to MidpointRounding.cs

new modes added to enum
implemented ToZero for double in Math.cs

* ToZero implementation

* implement double and float rounding modes

* updating rounding implementation

now round inline with DecCalc internal round implementation

* small bug fix

also replace var to make things obvious

* update implementation - floor/ceil

code review feedback

* review feedback

add comments, update MathF with floor/ceil

* code review feedback

 - fix comments
 - replace ifelse with switch
 - remove RoundingMode enum from DecCalc

* exclude outdated corefx test

Signed-off-by: dotnet-bot <[email protected]>
2019-02-12 16:12:49 +01:00
Larry Ewing 80c10f6307 Merge pull request #12952 from lewing/debugger-proxy-discovery
[Wasm] Proxy More of the DevTools protocol
2019-02-12 08:32:59 -06:00
Kenneth Pouncey 56d77dcce9 Remove unused code 2019-02-12 14:14:12 +01:00
Maxim Lipnin b4370f6e76 Update System.Data.Entity to handle new String overloads (#12680)
* Add new String overloads

* Remove some overloads with non-primitive types

* Remove IndexOf overloads with more than 1 argument

* Remove Trim() from TrimTranslator because CanonicalFunctionDefaultTranslator already supports it.

* Trim/TrimStart/TrimEnd: remove Char parameter overloads; add condition to support parameterless overloads.

* Remove unsupported Char overloads of Contains, IndexOf, StartWith and EndWith methods
2019-02-12 13:59:39 +01:00
Kenneth Pouncey fbaa3db2e0 Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays 2019-02-12 13:30:53 +01:00
Kenneth Pouncey 58fe50e028 Add support for CopyTo
- ArraySegment
- primitive array
- memory address CopyTo (IntPtr, offset, count)
2019-02-12 13:16:16 +01:00
Kenneth Pouncey b1f7a22a8b Add CopyFrom implementation and support for
- ArraySegment
- support CopyFrom IntPtr, offset, count to marshal memory pointer from Heap to TypedArray
2019-02-12 10:32:20 +01:00
monojenkins 5374e7ef46 [csproj] Update project files 2019-02-12 08:52:42 +01:00
monojenkins e4303ac76f Bump API snapshot submodule 2019-02-12 08:52:42 +01:00
Alexander Köplinger 6474cf7b61 Bump cecil submodule 2019-02-12 08:52:42 +01:00
Zoltan Varga 19d705c69d [bcl] Restructure the Module classes to simplify netcore integration.
* Move all icalls to RuntimeModule.
* Make all icalls static and receive the module as an IntPtr.
* Remove some duplicate code between the RuntimeModule and ModuleBuilder classes.
2019-02-12 08:46:09 +01:00
Dotnet-GitSync-Bot 374f44ebe8 Mirror changes from mono/corert,coreclr (#12951)
* Make Module partial to allow additional changed for Mono

Signed-off-by: dotnet-bot <[email protected]>

* Move ConditionalWeakTable to shared (dotnet/coreclr#22531)

Leaves DependentHandle as being the runtime PAL

Signed-off-by: dotnet-bot <[email protected]>
2019-02-12 01:45:39 -05:00
Larry Ewing 85bf22730b Proxy More of the DevTools protocol
Much of the tooling around DevTools expects
actions under /json to return useful data
this adds adds some simple logic to proxy those
so that you can point tooling directly at the
proxied port and get responses you expect
2019-02-11 21:18:15 -06:00
Larry Ewing a51b475173 Merge pull request #12809 from lewing/wasm-debug-documentation
[WASM] debug documentation and sample updates
2019-02-11 20:08:54 -06:00
Marek Safar ac5ab1a7ef Use shared Volatile 2019-02-12 00:32:45 +01:00
Stephen Toub 9d136f9446 Move Volatile to shared (dotnet/coreclr#22523)
* Move Volatile to shared

This largely takes corert's implementation, which uses Unsafe.As and volatile fields.

We could investigate also removing the JIT's replacements subsequently.

* Add [Intrinsic] attributes

Signed-off-by: dotnet-bot <[email protected]>
2019-02-12 00:32:45 +01:00
Alexander Köplinger 6ca20e92b6 [ci] Bump timeout for corlib-xunit tests
See https://github.com/mono/mono/issues/12945
2019-02-11 20:34:04 +01:00
Kenneth Pouncey 17134ec2b6 Add support for CopyFrom
- Array, offset, count
- ArraySegment
2019-02-11 17:13:45 +01:00
Bernhard Urban aac567ff66 [ios] add crosswatch64_32 target (#12893)
* [ios] add crosswatch64_32 target

* fix gnu triple for wasm
2019-02-11 11:08:02 -05:00
Alexander Köplinger ff7fc7e93a [ci] Bump bockbuild to get fontconfig download url fix 2019-02-11 16:56:46 +01:00
Aleksey Kliger (λgeek) 95f31d0259 [runtime] Refactor pinvoke probing, part 2 (#12850)
* [marshal] Add emit_exception_for_error callback

* [runtime] MonoError-ize mono_lookup_pinvoke_call_internal

Two complications:

1. Marshalling needs to turn a MonoError into MethodBuilder instructions to
   emit an exception.
2. The public API uses two string to signal an error.  So we have to use
   a custom status struct to return the error code.

* [loader] Factor out library path transformations

* [marshal] Copy error msg in mono_mb_emit_exception_for_error

Add new mono_mb_stdrup to make a copy of a given string into the memory that
will live with the MethodBuilder's method.

* [interp] Callvirt of an icall should call the wrapper.

See pinvoke2.cs test_0_missing_virtual_pinvoke_method ()

You can have an icall override a virtual method:

    	public class T2 : T {
    		[MethodImplAttribute(MethodImplOptions.InternalCall)]
    		public override extern object MyClone ();
    	}

When the interpret saw this, it was setting up a child frame with the frame
method being the MonoMethod of the icall itself, not the wrapper.  But it was
executing the wrapper.  As a result if the wrapper body had a LDSTR in it, we
would hit the assertion in the MINT_LDSTR_TOKEN case where
frame->imethod->method->wrapper_type == MONO_WRAPPER_NONE is not allowed.

With this change the frame method is now the wrapper which has a correct
wrapper type.

* [loader] remove pinvoke_probe_transform_path do{}while(0) construct

take the line damage; make the code easier to understand.
2019-02-11 10:49:56 -05:00
Jonathan Chambers 7176289621 Grow StackSlotInfo array rather than asserting (#12829) 2019-02-11 09:28:48 -05:00
Johan Lorensson dad67f4760 Incorrect call to MONO_HANDLE_SETRAW causes random crash in sgen. (#12851)
mono_string_utf16_to_builder_copy incorrectly uses MONO_HANDLE_SETRAW to
update the chunkLength field with a string length. Since MONO_HANDLE_SETRAW
assumes the argument is a MonoObject reference this could lead to a dereference
and since the value is a string length, that dereference will lead to a crash.

The problem happens in mono_gc_wbarrier_set_arrayref_internal where vtable
is retrieved from value. The crash happens randomly since it is depending
on the object being moved out of the nursery + sgen_binary_protocol_wbarrier
not being eliminated.

Fix is to use MONO_HANDLE_SETVAL since the value is not a reference so no need
to trigger a write barrier.
2019-02-11 09:12:20 -05:00
Johan Lorensson 4ba6733438 Fix OP_GET_LAST_ERROR codegen on Windows x64 full AOT. (#12853)
Current codegen incorrectly read back last error when doing p/invoke for
full AOT. This caused many failed corlib tests ~600. It also
turns out that the test for set/get last error related to p/invoke that we
have in pinvoke2.exe, is not run for the full AOT profile, due to other tests
depending on none full AOT features. In order to make sure we run the test
and not regress, test has been moved into its own runtime tests, running as
part of full AOT testing.
2019-02-11 09:11:50 -05:00
Alexander Kyte 9531662837 [crash] Use safer invalid-free test (#12864)
When using the previous test, some memory unsafety was
observed. It's rather unrecoverable memory unsafety, as
it corrupts heap memory used by the sequence points, registered MERP
paths, jit info internals, and output string.

Crashes seen here: https://github.com/mono/mono/pull/12387 reproduce
with less than 100 iterations of this malloc test run as the stress
test.

```
(MonoJitInfoTable) $2 = {
  domain = 0x5050505050505050
  num_chunks = 1347440720
  num_valid = 1347440720
  chunks = {}
}
```

with

```
(lldb) p/x 1347440720
(int) $0 = 0x50505050
```

And sometimes the mono crash

```
(lldb) p *it
(SeqPointIterator) $3 = {
  seq_point = (il_offset = 0, native_offset = 0, flags = 0, next_offset = 0, next_len = 0)
  ptr = 0x5050505050505050 <no value available>
  begin = 0x5050505050505050 <no value available>
  end = 0x5050505050505064 <no value available>
  has_debug_data = 0
}
```

===

These do not reproduce when doing a double free of legally allocated
memory.

I think that the crash reporting tests aren't the place to check if the
OS allows for wild heap corruption when doing these things. I don't
think it's currently in scope for the runtime to do crash reporting
after it's internal metadata tables have been corrupted. They're the
source of truth for symbolication. We don't have many options to
validate and reparse them, unless we want to make this all very
heavyweight.
2019-02-11 09:11:11 -05:00
Johan Lorensson 1a3813e899 Fix errors in TimeZoneInfoTest on Windows full AOT using winaot profile. (#12852)
Fix errors in TimeZoneInfoTest on Windows full AOT using winaot profile.
2019-02-11 08:35:54 -05:00
Kenneth Pouncey 949f3f7125 Add implicit conversion to and from primitive array. 2019-02-11 13:49:30 +01:00
Kenneth Pouncey 0e1a202bbb Add Type Array CopyFrom support.
- This will copy a managed array from heap to the typed array memory.
2019-02-11 10:29:02 +01:00
Marek Safar d5147e88bb [System.Private.CoreLib] Add more APIs 2019-02-11 09:50:36 +01:00
Kenneth Pouncey 56021009aa Misspellings 2019-02-11 07:37:03 +01:00
Kenneth Pouncey 07bb573833 Merge branch 'master' of https://github.com/mono/mono into wasm-typed-arrays 2019-02-11 06:09:05 +01:00
Vlad Brezae 846eca0dbd [interp] Fix ldelema (#12903)
The ldelema IL instruction provided the element class while the Address intrinsic provided the array class.

Fixes https://github.com/xamarin/xamarin-macios/issues/5363
2019-02-11 01:09:06 +02:00
Calvin Buckley b2f590b599 Fix build and use System.Native on FreeBSD (#12921)
* Required includes for system headers to behave on FreeBSD

* System.Native on FreeBSD
2019-02-10 10:27:54 +01:00
Jan Kotas b98780c71b Fix casing of interop directories (dotnet/corert#6982)
Match convention introduced by https://github.com/dotnet/corefx/pull/35085

Signed-off-by: dotnet-bot <[email protected]>
2019-02-10 09:37:18 +01:00
Sung Yoon Whang 544c43d0d6 set up CoreLib to include EventCounter in build project (#22501)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-10 09:32:05 +01:00
Marek Safar ca418e412b [netcore] Update to the latest version 2019-02-09 17:31:41 +01:00
Alexander Köplinger 67f1926803 [ci] Fix windows job name in osx-package.groovy 2019-02-09 14:32:27 +01:00
Marek Safar 903b264c4f Move Array's SZGenericArrayEnumerator to shared partition (#22480)
* Move Array's SZGenericArrayEnumerator to shared partition

* Remove legacy comment

* Move all array enumerators to a new file

Signed-off-by: dotnet-bot <[email protected]>
2019-02-09 08:30:10 +01:00
monojenkins 1f330171a8 [bcl] Update BCL Linked Size 2019-02-09 08:27:25 +01:00
Sung Yoon Whang 3fa2c0511f move EventCounter to shared CoreLib (dotnet/corefx#35183)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-09 08:25:51 +01:00
Marek Safar 5f9b66db43 [System.Private.CoreLib] Add missing Array APIs 2019-02-09 08:23:04 +01:00
Grant 29942cfd80 BitOps.TrailingZeroCount has inconsistent software fallback (#22333)
Fix #22326

Signed-off-by: dotnet-bot <[email protected]>
2019-02-09 00:58:07 +01:00
Marek Safar 38550e117e [System.Private.CoreLib] Implement part of GCSettings 2019-02-09 00:08:20 +01:00
Marek Safar 54f35f6198 Clean up GCSettings temp version 2019-02-08 23:15:15 +01:00
Stephen Toub 4bb7d23683 Move GCSettings to shared (dotnet/coreclr#22483)
Mainly just type definitions and error handling that gets shared.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-08 23:15:15 +01:00
Ludovic Henry f804ffdd2c Merge pull request #12810 from lateralusX/lateralusX/fix-win-fullaot-runtime-tests
Fix Windows x64 full AOT runtime test failures.
2019-02-08 15:50:03 -05:00
Ludovic Henry 719668fda1 Merge pull request #12856 from migueldeicaza/registry-finalizer-fixed
[Registry] Prevent crash due to background thread facing problems in the file system
2019-02-08 15:44:23 -05:00
Ludovic Henry 2355e592dc [arm/bitcode] mark valuetype returns as such when dealing with pinvokes (#12894)
On armv7 our calling convention happens to be the same as the platform
one. However, when using a armv7 cross compiler to generate bitcode that
targets a different platform (e.g. arm64_32) the calling convention can
be different (e.g. on arm64_32, a return buffer must be passed via r8).
Thus, mark it properly for LLVM so it can generate correct code.
2019-02-08 15:38:00 -05:00
Bernhard Urban 8ad82bbfc1 [ios] link mono-native correctly (#12895)
Fixes this app startup issue

```
dyld: Library not loaded: /Users/lewurm/work/mono-watch4-ios-sdk/sdks/out/ios-target64-release/lib/libmono-native-unified.0.dylib
  Referenced from: /var/containers/Bundle/Application/9697C8F3-811C-4BF3-B1BC-1E6385673984/PublicStaging.app/test-Mono.Runtime.Tests
  Reason: image not found
Process 2269 exited with status = 0 (0x00000000) Terminated due to signal 6
```
2019-02-08 15:36:53 -05:00
Vlad Brezae b62cca8974 [interp] Remove some cknull uses (#12849)
* [interp] Avoid using MINT_CKNULL

Unnecessary overhead for this tiny instruction.

* [interp] Do null check for this before inlining

Otherwise we miss it.
2019-02-08 15:32:07 -05:00
Vlad Brezae edccda13d3 [interp] Add method to seq_points table after we finish registering it (#12902)
* [interp] Add method to seq_points table after we finish registering it

When adding a breakpoint (mono_de_set_breakpoint) we search in this table for seq_point information for the method. If we find the information we expect that the method is already compiled and has the metadata initialized when actually adding the breakpoint (set_bp_in_method). We were crashing if the jinfo field of the interp method was not yet initialized.

Fixes https://github.com/xamarin/xamarin-macios/issues/5381

* [interp] Move profiler callback when we are actually done

Just in case.
2019-02-08 15:29:07 -05:00
Jan Kotas b8ee1ca51f Update CoreRT with shared array implementation
Signed-off-by: dotnet-bot <[email protected]>
2019-02-08 19:58:21 +01:00
Zoltan Varga f1dfd9c413 [llvmonly] Add a mini_llvmonly_throw_nullref_exception () jit icall to throw nullref exceptions, it occurs very frequently when explicit null checks are enabled. (#12883) 2019-02-08 13:06:11 -05:00
Zoltan Varga e14ef8a658 [corlib] Move the implementations of virtual methods from Assembly to RuntimeAssembly to ease netcore integration. (#12805)
* [corlib] Move the implementations of virtual methods from Assembly to RuntimeAssembly to ease netcore integration.

* [corlib] Move more code to RuntimeAssembly.

* [corlib] Move fields from Assembly to RuntimeAssembly/AssemblyBuilder.cs. Reduce the amount of fields visible to runtime code.

* Update serialization tests.

* Fix the MOBILE build.

* Bump API snapshot submodule
2019-02-08 13:05:54 -05:00
Zoltan Varga 83fc1456db [wasm] Add mixed tests to CI. (#12882)
* [wasm] Only dedup the assemblies which are actually AOTed in mixed mode.

* [wasm] Add mixed mode test targets.

* [wasm] Add mixed tests to CI.
2019-02-08 13:05:35 -05:00
Alexander Köplinger b01cfed2a4 [ci] Support building the OSX .pkg on private Jenkins 2019-02-08 17:18:41 +01:00
Alex Thibodeau d5dfaf6006 FIxing crash where a generic enum is passed into get_shared_type. Also added automated test to catch this scenario. (#12622) 2019-02-08 09:27:54 -05:00
Bernhard Urban b9c611e93c [arm64] encode offset within stack slot for r4 in gsharedvt descriptor (#12867)
Follow up fix for https://github.com/mono/mono/pull/11741

Fixes https://github.com/mono/mono/issues/12831
2019-02-08 12:28:29 +01:00
Bernhard Urban 63f4ee5540 [arm/bitcode] mark valuetype returns as such when dealing with pinvokes
On armv7 our calling convention happens to be the same as the platform
one. However, when using a armv7 cross compiler to generate bitcode that
targets a different platform (e.g. arm64_32) the calling convention can
be different (e.g. on arm64_32, a return buffer must be passed via r8).
Thus, mark it properly for LLVM so it can generate correct code.
2019-02-08 11:17:06 +01:00
Aleksey Kliger 972f29179d [sre] Handle null values in MarshalAsAttribute CustomAttributeBuilder
Normally strings are encoded as length-then-utf8 in ECMA-335.  But a null
String is encoded as just the byte 0xFF.

When we make a CustomAttributeBuilder for a MarshalAsAttribute and attach it to
some parameter we first encode the CAB as a byte blob and then decode it in
CAB.get_umarshal into a UnmanagedMarshal attribute.  But the decoding didn't
account for the possibility of null strings.

Fixes https://github.com/mono/mono/issues/12747
2019-02-08 10:56:08 +01:00
Marek Safar 49c0a9c2de Remove local DateTime 2019-02-08 10:37:29 +01:00
Marek Safar 9636096e3b Move DateTime for Unix to shared partition (dotnet/coreclr#22383)
* Move DateTime for Unix to shared partition

* Keep CoreCLR specific implementation

Signed-off-by: dotnet-bot <[email protected]>
2019-02-08 10:37:29 +01:00
Marek Safar f4c9b79905 Use local Array version 2019-02-08 10:27:04 +01:00
Stephen Toub a4681c14d9 Fix CoreLib to include PasteArguments.Unix.cs correctly (#22453)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-08 10:27:04 +01:00
Marek Safar 2e267dfa80 Move Array to shared partition (dotnet/coreclr#22321)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-08 10:27:04 +01:00
Marek Safar 8608d281c6 Implement ManifestBasedResourceGroveler::GetNeutralResourcesLanguageAttribute (#22372)
* Implement ManifestBasedResourceGroveler::GetNeutralResourcesLanguageAttribute in shared managed code

* Remove native ::GetNeutralResourcesLanguage

Signed-off-by: dotnet-bot <[email protected]>
2019-02-08 10:27:04 +01:00
Tarek Mahmoud Sayed ab717125aa Index and Range updates (dotnet/coreclr#22331)
* Index and Range updates

* Address @mikedn  feedback

* Address Feedback

* more feedback

* Use Deconstruct in Range.GetOffsetAndLength

* Rename GetArrayRange to GetSubArray

* Temporary disable the old Corefx Range tests

* Return back the TimeSpan test disabling

* Fix Range jit test

* Exclude the jit test

* revert the changes in the jit Range test

* Address Suggested Feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-02-08 10:27:04 +01:00
Bernhard Urban 33d6380103 [aot] interp flag on AOT images only on mscorlib required (#12838)
[aot] interp flag on AOT images only on mscorlib required

/cc @spouliot. This fixes `--interpreter=-all` on Xamarin.iOS.
2019-02-07 17:15:50 -05:00
Bernhard Urban 21c65aafc8 [ios] pass --enable-monotouch to cross compilers so icall defintions are visible to it (#12834)
This fixes a regression introduced by https://github.com/mono/mono/commit/5187b0bdaaff56936d697b0753dad51e7498991d

The AOT compiler wasn't aware of the icalls since they are guarded by `ENABLE_MONOTOUCH`. Passing `--enable-monotouch` to configure of the AOT compiler enables that define, so it can properly resolve those icalls. However, to avoid `zlib` dependency for the cross compilers, we stub
them out.
2019-02-07 20:26:42 +01:00
Alexander Kyte 0e65799c8e [runtime] Use temp folders for merp tests (#12830)
The 2018-10 lane seemed to be failing some tests because the merp-json-valid.exe test left behind the crash log file. I fixed that in this PR, but also move the tests into their separate folders so they can run at the same time safely.
2019-02-07 19:32:06 +01:00
Tanner Gooding 321e0b511f Fixing Utf8Formatter.Float to support all the same format specifiers as the utf16 formatter. (#22434)
* Fixing Utf8Formatter.Float to support all the same format specifiers as the utf16 formatter.

* Disabling some outdated CoreFX tests.

* Fixing TryFormatFloatingPoint to special-case format.IsDefault

Signed-off-by: dotnet-bot <[email protected]>
2019-02-07 18:47:19 +01:00
Stephen Toub 75a7b9601f Finish removing Environment from corefx
Signed-off-by: dotnet-bot <[email protected]>
2019-02-07 18:30:59 +01:00
Miguel de Icaza 39397b5e92 [Registry] Prevent crash due to background thread facing problems in the file system 2019-02-07 11:52:59 -05:00
Zoltan Varga b019ca4d5a [wasm] Fix icall table linking, generate one table per assembly. (#12840) 2019-02-07 11:44:11 -05:00
Vlad Brezae 33189ef31f [tests] Enable test suites on interpreter (#12806)
Seem to pass locally
2019-02-07 16:13:24 +02:00
Johan Lorensson bbe84c03fa Merge pull request #12811 from lateralusX/lateralusX/fix-win-fullaot-runtime-tests-toggleref
Fix issue where togglerefs might be incorrectly pinned by GC.
2019-02-07 02:59:45 -05:00
Kenneth Pouncey dedbbbf401 Fix error with bindings. 2019-02-07 07:09:08 +01:00
Aleksey Kliger (λgeek) d36f437f60 [runtime] Refactor pinvoke probing (#12795)
* [runtime] Mark mono_lookup_pinvoke_call external only

Runtime should use mono_lookup_pinvoke_call_internal

* [loader] Factor out helper functions from mono_lookup_pinvoke_call

Separate the logic for probing for a dynamic library module from the logic for
looking for a symbol inside the module.

* [loader] Factor out relative directory probing in pinvoke lookup
2019-02-06 20:50:32 -05:00
Zoltan Varga 9453281f0c [ci] Enable llvmonly+mixed tests on CI. (#12777) 2019-02-06 20:46:06 -05:00
Alexander Köplinger 004deafa3a [tests] Disable flaky block_guard_restore_aligment_on_exit.exe on Windows PRs
See https://github.com/mono/mono/issues/12839
2019-02-07 01:25:13 +01:00
Thays Grazia ada7c1b821 [wasm][debugger] Bug on attributes with value type string and content NULL (#12827)
* An attribute with a content that was a string null was creating two items in result json and it was throwing an exception in client side because it is expected a name and a value and not a name and two values.
2019-02-06 21:19:01 -02:00
Alexander Köplinger ea3d9b80b5 [corlib] Remove reflection-based Mono.Native test (#12828)
The managed linker removes the type embedded inside mscorlib and we don't want to whitelist it in linker xml since then it'd be kept for everyone.

Instead move the type to the test assembly and remove the reflection-based tests.
2019-02-06 22:47:19 +01:00
Miguel de Icaza b3eeb1667a [man] mono.1 - describe how to get the list of options 2019-02-06 15:52:19 -05:00
Alexander Köplinger b4c66a1d59 [mono-native] Remove accidentally added brotli.c file
It broke the iOS SDK build because of duplicated main().

See https://github.com/mono/mono/pull/12189
2019-02-06 20:50:50 +01:00
Alexander Köplinger 04c71af56a Extend mono-native minimum version magic to CPPFLAGS/CXXFLAGS (#12801)
We were only doing the -mmacosx-min-version replacement magic on
CFLAGS and LDFLAGS for mono-native-compat and -unified,
but we need to do the same for CPPFLAGS/CXXFLAGS too.

Fixes an issue where the libraries were targeting the wrong minimum OSX
version when built from xamarin-macios since they pass the minimum version
in CPPFLAGS instead of CFLAGS for OSX.
2019-02-06 19:07:58 +01:00
Martin Baulig 5c17c4cf31 Add support for async-streams (C# 8.0). (#12674)
Bring some new APIs from corefx master for async-streams (C# 8.0):

- `IAsyncDisposable`
- `IAsyncEnumerable`
- `IAsyncEnumerator`
- `AsyncIteratorMethodBuilder`
- `AsyncIteratorStateMachineAttribute`
- `ConfiguredAsyncDisposable`
- `ConfiguredCancelableAsyncEnumerable`
- `ManualResetValueTaskSourceCore`
- `TaskExtensions` (replacing our reference source version).

Minor changes to existing code:

- Add `ExecutionContext.ContextCallback<TState>(ref TState state)` delegate.
- Add `ExecutionContext.RunInternal<TState>` method.
- Uncomment `AsyncMethodBuilderCore.Start<TStateMachine>`.
- Add new `ThreadPool.QueueUserWorkItem<T>(Action<T>,T,bool)` and `UnsafeQueueUserWorkItem<T>(Action<T>,T,bool)` overloads.

New xUnit tests from CoreFX:

- `System.Threading.Tasks/tests/System.Runtime.CompilerServices/ConfiguredCancelableAsyncEnumerableTests.netcoreapp.cs`
- `System.Threading.Tasks.Extensions/tests/ManualResetValueTaskSourceTests.cs`
- `System.Threading.Tasks.Extensions/tests/ValueTaskTests.cs`
- `Common/tests/System/Threading/Tasks/Sources/ManualResetValueTaskSource.cs`
- `Common/tests/System/Threading/Tasks/Sources/ManualResetValueTaskSourceFactory.cs`
- `System.Threading.Tasks.Extensions/tests/AsyncValueTaskMethodBuilderTests.cs`
- `System.Threading.ThreadPool/tests/ThreadPoolTests.cs`
- `System.Threading.ThreadPool/tests/ThreadPoolTests.netcoreapp.cs` (partial due to missing `IThreadPoolWorkItem`)
2019-02-06 15:01:45 +01:00
Kenneth Pouncey fdc3d56c9b Typed Array Support - Initial commit
- Contains breaking changes
  - Remove NewArrayJS which is replaced with Array bidning.
- Add support for working with Typed Arrays, ArrayBuffer and Array.
-  Typed arrays supported

   - Int8Array 		| int8_t	| byte or SByte (signed byte)
   - Uint8Array		| uint8_t	| byte or Byte (unsigned byte)
   - Uint8ClampedArray| uint8_t	| byte or Byte (unsigned byte)
   - Int16Array		| int16_t	| short (signed short)
   - Uint16Array		| uint16_t	| ushort (unsigned short)
   - Int32Array		| int32_t	| int (signed integer)
   - Uint32Array		| uint32_t	| uint (unsigned integer)
   - Float32Array		| float		| float
   - Float64Array		| double	| double

- Split the bindings into separate file for easier support and to keep the driver program size down.
2019-02-06 14:52:30 +01:00
Thays Grazia e1602576d3 [wasm][debugger] Evaluate properties and generics. (#12782)
* [wasm][debugger] Evaluate properties and generics.
2019-02-06 09:39:00 -02:00
Alexander Köplinger aedc1ca38f [ci] Support Mono version 6.x in Windows .msi build 2019-02-06 11:47:02 +01:00
Vlad Brezae 7869333c52 [metadata] Fix dynamic delegate (#12762)
* [metadata] Decouple dynamic method signature from its delegate invoke wrapper

The invoke wrapper should not be referencing the signature because it will be freed once with the dynamic method. The wrapper can outlive the dynamic method, it is cached based on the signature.

Fixes crash on old IronJS benchmark with interpreter (which uses a lot of delegate wrappers, compared to jit)

* [interp] Add debug method for printing transformed code
2019-02-06 11:19:26 +01:00
Larry Ewing 5b44b5cbb8 Update README.md debugger instructions to match the current layout 2019-02-05 19:42:17 -06:00
Larry Ewing 1ea56466e4 Include mono-config.js produced by packager in debug.html 2019-02-05 19:41:37 -06:00
Larry Ewing d4251f42f4 Remove shell prompt from README.md to be consistent and improve cut and paste 2019-02-05 19:39:04 -06:00
Larry Ewing 879afec442 Merge pull request #12540 from jeromelaban/dev/jela/wasm-debugger-update
[WASM] Improve debugging support
2019-02-05 19:01:30 -06:00
Egor Bogatov 2f6104f163 [System.IO.Compression] Brotli from CoreFX (#12189)
Resolves https://github.com/mono/mono/issues/11431

I put the native impl to Mono.Native, but probably it should be in a separate lib (`libmono-native.0.dylib` before: **81kb**, after: **898kb**) if Linker is not able to trim it if it's not used.
Compiles and works on Windows (however, we don't build Mono.Native for Windows, but we can borrow `clrcompression.dll` from .net core) and macOS but requires changes in mono/corefx,

I disabled xunit tests as those need 50mb of test data.

PS: Brotli could be fully managed 😢 https://github.com/dotnet/corefxlab/issues/1673

C# ports:

- https://github.com/master131/BrotliSharpLib 
A quick benchmark (Compressing a 5mb file with max compression level=11)
Mono JIT: 25sec
Mono LLVM-AOT: 7.8sec
.NET Core 2.2: 6.8sec
.NET Core 3.0: 5.8sec
.NET Core's BrotliStream (with native lib): 3.5sec


- https://github.com/google/brotli/tree/master/csharp - official C# port. Based on Java sources, slow, outdated (2 years ago).
2019-02-06 00:25:19 +01:00
Martin Baulig 94f00fe796 Fix HttpClient on AIX (#12744). (#12771)
Define `PLATFORM_UNIX` in `mcs/build/platforms/unix.make` and make
`mcs/build/profiles/net_4_x.make` define `SOCKETSHTTPHANDLER=1` when set.
2019-02-05 22:41:43 +01:00
Alexander Köplinger fd71ea2fd3 [corlib] Disable GetFrames_AsyncCalls on mobile
See https://github.com/mono/mono/pull/12790
2019-02-05 21:33:56 +01:00
Michal Strehovský 399d14104a Fix ProjectN build breaks (dotnet/corert#6954)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-05 19:13:59 +01:00
lateralusX c432251142 Fix issue where togglerefs might be incorrectly pinned.
Due to current order, process togglerefs and then take current threads
stack could cause a problem where toogleref references might be left
in registers after native code process the list and those reference
would then be put into current thread context, incorrectly pinning the
toggleref, preventing it from being GC:ed. The problem was observed on
Windows (in debug build) running sgen-toggleref.exe runtime test since
the native compile of sgen_process_togglerefs used a register when
walking the list of togglerefs that was then not re-used until the
current threads stack was taken, causing incorrect pinning. This problem
could in theory happen on any platform depending on how sgen_process_togglerefs
would been compiled and what register will be used.

Fix is to take current threads context before walking the togglerefs to make
sure we are not getting managed references into registers as part of managing
the toggleref list in native code.
2019-02-05 18:37:05 +01:00
lateralusX ecc42a8410 Fix failure in catchfault_tail.exe due to stack overwrite in final handler.
Combination of Windows x64 ABI and the lack of not checking for fault handlers
in OP_START_HANDLER cause a hard to track stack corruption when combined with
tail calls. Fix is to make sure we also handle fault regions in handlers to
handle cases like the one exposed by catchfault_tail.exe test.
2019-02-05 18:34:20 +01:00
lateralusX dfa2fe6d2b Add better support to dynamically setup content of config.h in Windows MSVC builds.
When running tests on CI the runtime is configured from autogen.sh script.
When running fullaot there are a couple of features not supported so they are
disabled. The problem is that the MSVC Windows builds have its own winconfig.h
template, losing all the disabled features from configures config.h.

This commit adds support to detect the disable defines from configures config.h
if one exists. Since the complexity of this step increases the work previously
done in winsetup.bat has been moved into a msbuild target that is used from
both within VS build as well as winsetup.bat (there are a couple of other builds
using that bat file, so won't remove it).

The winconfig.h template we had is quite outdated compared to what’s generated
by configure. This commit also updates the winconfig.h to closer match what generated
for corresponding mingw build but keep all the Windows specific configurations
included in current version.
2019-02-05 18:34:20 +01:00
lateralusX c39e3e1200 Fix failing test under debug mode due to incorrect marshal alloc. 2019-02-05 18:34:20 +01:00
lateralusX 46e65d2a09 Fix process stress tests to not popup thousands of Windows.
Fix runtime test run to pickup working wrapper when running
with --enable-msvc but not setting MONO_EXECUTABLE.
2019-02-05 18:34:20 +01:00
Jo Shields 667925b987 Merge pull request #12794 from directhex/master
Bump version to 6.1.0
2019-02-05 11:26:56 -05:00
Jo Shields 1f77041f92 Bump version to 6.1.0 2019-02-05 09:42:19 -05:00
Marek Safar 29594b984c [corlib] Fix GetFrames_AsyncCalls test not to block 2019-02-05 13:09:36 +01:00
monojenkins ae99e720cd [csproj] Update project files 2019-02-05 13:08:33 +01:00
monojenkins b7fe8104e6 Bump API snapshot submodule 2019-02-05 13:08:33 +01:00
Egor Bogatov 4285787ece improve test 2019-02-05 13:08:33 +01:00
Egor Bogatov 5946cd6cb5 use CoreRT's CancellationToken and CancellationTokenSource 2019-02-05 13:08:33 +01:00
Egor Bogatov 56aab1437d add #if MONO to ref-source file 2019-02-05 13:08:33 +01:00
Egor Bogatov 3c9035442b Do not clone SyncronizationContext in EE 2019-02-05 13:08:33 +01:00
Martin Baulig afd4971208 "Ice Blue": Adding some "Connection Info" properties to SslStream. 2019-02-05 10:49:47 +01:00
Zoltan Varga 51287431af [netcore] Ongoing work. (#12750) 2019-02-05 10:34:31 +01:00
Ben Adams 45b6b640a4 Fix string.strlen (dotnet/coreclr#22397)
* Add explanation comment

Fixes #22393

Signed-off-by: dotnet-bot <[email protected]>
2019-02-05 10:29:49 +01:00
Marek Safar dc323ae290 Remove local SynchronizationContext 2019-02-05 10:20:12 +01:00
Marek Safar d2ee660406 Move SynchronizationContext to shared partition (dotnet/coreclr#22389)
* Move SynchronizationContext to shared partition

* Move WaitHelperNative to WaitHandle

Signed-off-by: dotnet-bot <[email protected]>
2019-02-05 10:20:12 +01:00
Vlad Brezae 63fc0ebdfa [interp] Add missing write barrier (#12772) 2019-02-05 09:30:33 +02:00
Jan Kotas 88a621524e More compact implementation of Marshal.GenerateProgIdForType (#22395)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-04 22:53:05 +01:00
Martin Baulig 721a437310 Remove internal WebRequest.RequestCallback to fix a compiler warning. 2019-02-04 22:52:38 +01:00
Thays Grazia 427cdf422e Disable test GetFrames_AsynsCalls for wasm only. (#12768) 2019-02-04 18:09:20 +01:00
Thays Grazia aa08555cfb [wasm][debugger] Add array inspection to the debugger. (#12733)
* [wasm][debugger] Evaluate array variables.

* Prefixing free_objref with mono_debugger_ to "document" that it's a debugger only function.
2019-02-04 10:32:40 -05:00
Aleksey Kliger (λgeek) f7fca0a8a2 [runtime] Switch to GC Unsafe in a few more external API functions (#12738)
* [runtime] Switch to GC Unsafe in mono_property_get_value

It's external only, so it should switch from GC Safe to GC Unsafe when called.

Addresses crash in https://github.com/mono/mono/issues/12724

* [runtime] Make mono_image_loaded external only

Also mono_image_loaded_full

Runtime should use mono_image_loaded_internal

* [runtime] Make mono_get_exception_argument_null external only
2019-02-04 16:10:49 +01:00
Jo Shields 4d9e8f58f8 Bump libgdiplus to mono-2018-12 branch tip 2019-02-04 15:14:14 +01:00
Damien Diederen 1cd74fa1cd [profiler] Avoid native crash with GUID-less assemblies
Without this patch, Mono crashes while writing AOT profiling data at
shutdown (when instructed to do so via --profile=aot:output=out.aotprof)
if any of the sampled methods belong to a dynamic image, which doesn't
have a GUID.

This happens with e.g. the DynamicProxyGenAssembly2 image:

> DynamicProxyGenAssembly2 is a temporary assembly built by mocking
> systems that use CastleProxy like Moq or NSubsitute. It is generated
> when the mock is needed and disposed of after the tests are finished.

(cf. https://stackoverflow.com/a/17179923)
2019-02-04 14:21:57 +01:00
Filip Navara 7d53edefa2 Remove code that was moved to System.Native (dotnet/corert#6932)
* Remove code that was already moved from System.Private.CoreLib.Native to System.Native.

* Move Interop files for System.Native to shared Interop directory.

* Add FeaturePortableThreadPool conditions to csproj files.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-04 14:18:40 +01:00
Mikhail Filippov 8a6d0028bd Use LoadFrom instead LoadFile for load logger type.
LoadFile lost assembly load-context. If the logger assembly has any dependencies placed in same folder logger can't load it. Main.cs using LoadFrom to load assembly but assembly already loaded in the cache after GetLoggerTypeName.
2019-02-04 14:14:53 +01:00
monojenkins 0ea6711572 [csproj] Update project files 2019-02-04 13:53:27 +01:00
monojenkins 3ad59586bf Bump API snapshot submodule 2019-02-04 13:53:27 +01:00
Egor Bogatov 7b0cd424db Copy refs from CoreFX 2019-02-04 13:53:27 +01:00
Marek Safar 81f5873758 [System.Private.CoreLib] Use local string version 2019-02-04 13:52:51 +01:00
Marek Safar bb5feb2579 [System.Private.CoreLib] Add Nullable runtime support 2019-02-04 09:44:40 +01:00
Michal Strehovský cc4c2b03d6 Throw the right exception when interface dispatch is ambiguous (#22295)
Throw the approved exception per dotnet/corefx#34124.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-03 22:04:43 +01:00
Filip Navara 4b88f5c167 Move Interop.GetTimestamp.cs to shared CoreLib partition. (#35031)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-03 21:34:31 +01:00
Marek Safar 03f07724b3 [System.Private.CoreLib] Fix the build 2019-02-02 23:05:22 +01:00
Zoltan Varga 6bc1e59d69 [runtime] Rename more MonoX->RuntimeX classes. (#12732) 2019-02-02 21:36:49 +01:00
Stephen Toub d0c54c546a Avoid delegate/work item allocations when setting async continuation (#22373)
When awaiting a task, there's a race between seeing whether the task has completed (in which case we just continue running synchronously), finding the task hasn't completed (in which case we hook up a continuation), and then by the time we try to hook up the continuation finding the task has already completed.  In that final case, we don't want to just execute the callback synchronously, as we risk a stack dive, so we queue it.  That queueing currently entails two allocations in the common case: one for the work item object, and one for the Action delegate we force into existence for the state machine box's MoveNext method (in the common case it's now never allocated because you only await Tasks and ValueTasks known to the runtime, which bypasses its creation).  We can instead just queue the box itself, and avoid both allocations.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-02 21:24:16 +01:00
Jan Kotas 3496691706 Rename ResourceManager fields to follow conventions (dotnet/coreclr#22371)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-02 20:02:34 +01:00
Lee Culver cab519ca07 Add back missing stack frames to mono MERP reports
Changeset https://github.com/mono/mono/commit/e1461ebc855977667f71d1804fd96eed2a155aff
introduced a regression where only the topmost frame of managed crashes are reported.

This change adds back the missing stack frames.
2019-02-02 15:18:28 +01:00
Marek Safar a7277849e7 Remove Mono implementation 2019-02-02 09:54:49 +01:00
Marek Safar 89c8d135eb Move Marshal::UnsafeAddrOfPinnedArrayElement to shared partition (#22359)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-02 09:54:49 +01:00
monojenkins 15e7ec70de [bcl] Update BCL Linked Size 2019-02-02 09:44:42 +01:00
Alexander Köplinger 2c8fe4fdc2 [bcl] Use delaysign for nunit/nunitlite
Otherwise mcs won't build it.
2019-02-02 01:17:59 +01:00
Marek Safar 598426a7ae Remove local ResourceManager 2019-02-02 00:20:35 +01:00
Stephen Toub b2226867ae Remove stale warning 420 pragmas (dotnet/coreclr#22352)
It used to be that the CS0420 warning ("a reference to a volatile field will not be treated as volatile") would fire when a volatile was used with an Interlocked.* operation.  That warning was unnecessary, as Interlocked.* would itself provide the relevant barriers, and these functions were special cased in Roslyn a long time ago.  But there are still lots of places where pragmas disabling the warning have stuck around.  I'm deleting them all.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-02 00:20:35 +01:00
Filip Navara 21fca52b3d Move ResourceManager to shared CoreLib. (dotnet/coreclr#22249)
* Move ResourceManager to shared CoreLib.

* Split UAP code out of ResourceManager.cs into separate files.

* Remove ResourceManager.NonUap.cs.

* Do not access internal field (CoreRT build fix).

* Fix non-Windows builds (CoreRT).

* Remove obsolete Debug code.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-02 00:20:35 +01:00
Alexander Köplinger 31e170fd3e [bcl] Actually fix the nunit/nunitlite assembly identity (#12743)
The solution from https://github.com/mono/mono/pull/12725 doesn't fully work
since e.g. gacutil seems to verify the strong name.

Instead follow what we do for other keys where we don't have the private key:
add them to the machine.config pubTokenMapping list.
2019-02-01 23:33:36 +01:00
Alexander Köplinger 260cc5411d Fix tarball build 2019-02-01 23:15:00 +01:00
Maxim Lipnin cd2d903518 Avoid recursive extracting redundant frames from captured traces. 2019-02-01 23:05:25 +01:00
Tanner Gooding 40eb410e73 Update the double/float formatters to return the shortest roundtrippable string. (#22040)
* Updating Number.Formatting to always compute a round-trippable number by default.

* Adding a third-party notice entry for the Grisu3 reference implementation

* Fixing up the Grisu3 algorithm to better match the reference implementation (including comments, etc)

* Porting the Grisu3 implementation that generates the shortest roundtrippable sequence.

* Updating the Dragon4 algorithm to support printing the shortest roundtrippable string.

* Fixing the double/float formatters to ignore precision specifiers for 'R'

* Fixing the double/float formatters to handle +0.0 and -0.0

* Fix the casing of `point` in THIRD-PARTY-NOTICES

Co-Authored-By: tannergooding <[email protected]>

* Fixing the double/float formatting code to consider a precision specifier of 0 to be the same as default.

* Fixing the double/float formatter so that nMaxDigits is set appropriately.

* Changing the double/float formatting logic to account for the format when determining the correct precision to request.

* Updating the double/float formatter to take the format specifier into account when determining the number of digits to request.

* Fixing the double/float formatting code to continue handling zero correctly.

* Disabling some outdated CoreFX tests.

* Responding to various feedback from the PR

Signed-off-by: dotnet-bot <[email protected]>
2019-02-01 22:28:08 +01:00
Alexander Köplinger 2d715b1af2 Fix tarball build 2019-02-01 20:59:54 +01:00
Alexander Köplinger acc902614e [bcl] Fix assembly identity of nunit/nunitlite (#12725)
* [bcl] Fix assembly identity of nunit/nunitlite

The new strong name key added in https://github.com/mono/mono/commit/acaa73b7026897f7e83a101a9bc331476b5ed169
changed the assembly identity which we can't do for shipping libraries.

Given that the old .snk is invalid (see https://github.com/dotnet/roslyn/issues/32502),
we just sign with the extracted public key and /publicsign.

For MCS_MODE builds we instead use the mono.snk since mcs doesn't support /publicsign
and we don't really care about having the correct identity there.

* [csproj] Update project files
2019-02-01 20:58:54 +01:00
Johan Lorensson 7710b4c099 Add support for Windows x64 winaot, winaot_llvm builds/tests on CI. (#12601)
Add support for building Windows x64 fullaot version of winaot profile
that can be run on CI. Initial changes also add execution of mini regression
tests on CI. More tests will be added going forward and when having full
pass rate.

Add support for building Windows x64 fullaot+llvm version of winaot profile
that can be run on CI. Initial changes also add execution of mini regression
tests on CI. More tests will be added going forward and when having full
pass rate.

In order to get deterministic build results and working build on CI, we need
to setup a correct build environment for the MSVC builds. Since MSVC build is
currently run from cygwin, there are environment problems, both general
but also in our CI environment, since we add cygwin bin folder to system path
(needed by Jenkins plugin). When running more complex cmake builds like
BTLS and LLVM, this will cause problems picking up incorrect tools,
failing builds on CI.

Another problem is the AOT compilation using MSVC toolchain. In the
past CI used some "hard coded paths" to make sure clang.exe and link.exe was found.
This is not optimal and won't work when including LLVM as part of full AOT since
link.exe will need access to more of the full build environment setup by VS
development environments (like platform libraries).

In order to get a better build environment on CI this commit includes and enhance
a couple of build scripts used to run msbuild.exe and mono-sgen.exe (as AOT compiler)
in a VS development environment, isolate that build process from cygwin environment.

The build scripts will locate installed VS tooling, VS2015 build tools or VS dev env,
VS2017 build tools or VS dev env and use corresponding development environment
scripts as part of running msbuild.exe and mono-sgen.exe in AOT mode.

In order to make sure mono-sgen.exe as AOT compiler is run through these scripts
an additional environment variable MONO_EXECUTABLE_WRAPPER is introduced and used
in mono-wrapper when set. Without this indirection there will be problems on CI
tests since the environment is using MONO_EXECUTABLE and pass that into for example
test driver that run child processes of mono-sgen.exe, meaning that we can't
use scripts for MONO_EXECUTABLE, but splitting the MONO_EXECUTABLE to represent
mono runtime and have a MONO_EXECUTABLE_WRAPPER that could be a launch script
solves this issue.

This commit also includes several smaller fixes made to the generic
fullaot build infrastructure.

Fix additional msbuild arguments.

Add Mono.SIMD assembly to winaot profile.

Run msbuild.exe as part of .bat file.
2019-02-01 11:54:45 -05:00
Marek Habersack dc1cdb9983 [bcl] Fix possible deadlock race in CSharpCodeGenerator (#12685)
`CSharpCodeGenerator` runs a compiler while redirecting its standard error and
standard output streams for further reporting. However, in doing that it fails
to read the standard output data completely and also fails to properly wait for
the standard error output to complete. Depending on environment it may lead to
the process using `CSharpCodeGenerator` hanging while the process has already
exited but there still is data to be read from standard output and standard
error.

This commit changes the code to an implementation of reading standard error and output
that makes sure all the data is read before the process is closed.

The hope is that it may fix some of the timeouts/hangs we see on the
Xamarin.Android build bots as a portion of them hangs in test that use the
code generator.
2019-02-01 15:14:28 +01:00
Alexander Köplinger a1973e5cae Bump api-snapshot 2019-02-01 14:13:38 +01:00
Martin Baulig 2f411750ac "Imperial Red": Bring HttpClient from CoreFx (#11906)
This brings `System.Net.Http` from CoreFx.

It is currently only enabled on Desktop Mac and Linux; Mobile is coming shortly.
2019-02-01 14:09:30 +01:00
Marek Safar af70768885 Merge pull request #12704 from lewurm/arm-ios-epsilon-workaround
[arm/ios] workaround for faulty vcmp.f64 insn
2019-02-01 14:05:06 +01:00
Bernhard Urban cd937eaaa0 Bump corert
Commit list for mono/corert:

* mono/corert@1b7d4a1e4 [Number] make double 0.0 cmp more portable (#30)

Diff: https://github.com/mono/corert/compare/c4ae51646152de0af32b2c85538b6e7317faa7f8...1b7d4a1e4bd79305905338827cc41eb8303364f0
2019-02-01 14:04:45 +01:00
monojenkins ec2b56cc78 [csproj] Update project files 2019-02-01 10:56:46 +01:00
Zoltan Varga 1c1e0b1bad [runtime] Rename most System.Reflection.MonoX classes to RuntimeX for consistency with coreclr. 2019-02-01 10:56:46 +01:00
Thays Grazia 257efc6374 [Tailcall] [arm] [jit] Fix moving tailcall parameters. (#12701)
* When moving parameters for tailcall, first copy the parameters using ARMREG_IP and after that get destination in ARMREG_IP, then it's not necessary the PUSH and POP to SP nor the saved_ip_offset.
Fixes #11489

* Removing unused variable.
2019-02-01 10:01:32 +01:00
Alexis Christoforides 8f5cef9364 [corlib] Import System.IO.File from CoreFX (#12000)
Contributes to #7246
2019-02-01 09:48:09 +01:00
Tanner Gooding 472269a1cf Fixing a GC hole in Number.BigInteger (dotnet/coreclr#22334)
Signed-off-by: dotnet-bot <[email protected]>
2019-02-01 09:25:03 +01:00
Michal Strehovský d5a924a9dd Annotate types moved from S.R.Extensions
Testing how much hate this is going to bring me.

These annotations let ProjectN deal with the fact that we now have two
definitions of System.Environment in the system. This is needed as long
as Project N is stuck on 2.1-level version of the framework.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-01 09:25:03 +01:00
Stephen Toub 86406319d2 Replace several Nullable<T>.Value with .GetValueOrDefault() (#22297)
The former does extra work that the latter doesn't do, and they're equivalent when we know it contains a value, such as immediately after a HasValue check.

Signed-off-by: dotnet-bot <[email protected]>
2019-02-01 09:09:37 +01:00
monojenkins 65e51b26c3 [bcl] Update BCL Linked Size 2019-02-01 09:09:00 +01:00
Vlad Brezae 6bab31e4c1 [marshal] Optimize clearing of entries for method (#12681)
Fixes dynamic-method-churn.exe timeouts, which was hanging on arm because the finalizer thread was hanging from taking too long to clear these hashtable entries.
2019-01-31 21:48:10 -05:00
Zoltan Varga 7517529b62 [netcore] Add back corlib version check. (#12702) 2019-02-01 01:43:35 +01:00
Zoltan Varga b8b527c7ca [netcore] Ongoing work. (#12697)
* [runtime] Fix icall ordering.

* [netcore] Disable dllmap for netcore for now.

* [netcore] Disable loading some threadpool types which don't exist in netcore.

* [netcore] Disable Mono.Native.
2019-01-31 18:50:39 -05:00
Andrew Au f086f55c17 AsyncSteppingFix - Eagerly initialize the AsyncStateMachineBox to avoid expression evaluation in ProjectN async stepping.
[tfs-changeset: 1732745]

Signed-off-by: dotnet-bot <[email protected]>
2019-01-31 21:05:39 +01:00
Michal Strehovský 1139b8e47a Fix ProjectN build breaks (dotnet/corert#6924)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-31 19:25:56 +01:00
Alexander Köplinger 78d2492ef6 [bcl] Add Mono.CSharp back to xammac profile
It was removed in https://github.com/mono/mono/commit/96af472795496ad32768d113b1cb42a9d3cdcbcf but xammac does need it still.
2019-01-31 18:19:58 +01:00
Zoltan Varga 57fda1a647 [llvmonly] Make direct calls to icalls/icall wrappers. (#12693)
* [runtime] Improve mono_print_ji ().

* [llvmonly] Add a few more preinited got slots. Avoid emitting TLS_TRAMP preinited got slots in llvmonly mode.

* [aot] Simplify the mangled name of icall wrappers.

* [llvmonly] Make direct calls to icalls/icall wrappers in llvmonly+static mode.

* [aot] Disable some dedup logging which is always 0.

* Fix an strstr call.
2019-01-31 11:51:16 -05:00
Bernhard Urban 719117f9d7 [arm/ios] workaround for faulty vcmp.f64 insn
Fixes https://github.com/mono/mono/issues/11965
2019-01-31 17:02:17 +01:00
Alexander Köplinger a2abcc9a2f [System] Skip DefaultValueAttributeTest.Bug_12362() on xammac 4.5 too 2019-01-31 16:57:25 +01:00
Stephen Toub 554ff45da9 Replace Environment.s_macOS with use of PLATFORM_OSX
Signed-off-by: dotnet-bot <[email protected]>
2019-01-31 16:38:51 +01:00
Stephen Toub 05956b9db7 Adapt corert to Environment moving from corefx
Signed-off-by: dotnet-bot <[email protected]>
2019-01-31 16:38:51 +01:00
Alexis Christoforides ea55c54fe9 [xammac_net_4_5] Use CoreFX System.IO 2019-01-31 13:48:16 +01:00
Zoltan Varga 6ec5e3a4cf [corlib] Fix the linker descriptors for the SRE classes.
Preserve the ModuleBuilder.RuntimeResolve () method using a PreserveDependency attribute.
Remove nonexistent methods.
2019-01-31 13:47:25 +01:00
Marek Safar c7cb61a9a6 Remove GetSystemMaxDBCSCharSize implementation 2019-01-31 08:41:41 +01:00
Marek Safar f3ef35c779 Add managed implementation of GetSystemMaxDBCSCharSize (#22290)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-31 08:41:41 +01:00
Tanner Gooding 68606a1c30 Reverting "Fixing up the UTF8Formatter and some tests to properly handle -0.0" (#22300)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-31 08:33:33 +01:00
Marek Safar 1b09a26710 Implement Environment 2019-01-30 23:28:37 +01:00
Stephen Toub 8eeffb8628 Switch CoreLib over to using shared Environment from corefx (#22106)
This requires merging/adapting the implementation with EnvironmentAugments (which goes away completely), the shared files, what corert has, etc.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-30 23:28:37 +01:00
Jonathan Chambers 115c196575 Implement marshaling for generic struct fields (#12660) 2019-01-30 13:57:03 -05:00
Johan Lorensson 1350f7a77a Windows support to abort blocking system calls. (#12654)
* Fix race condtion in socket altertable wait implementation on Windows.

* Add support to abort blocking Windows mono_w32file_read/write methods.
2019-01-30 13:53:44 -05:00
Vlad Brezae 2f92606f1f [tests] Disable oldgen stress on interp (#12682)
[tests] Disable oldgen stress on interp
2019-01-30 12:36:06 -05:00
Vlad Brezae e461679612 [interp] Add support for break on method entry (#12651)
[interp] Add support for break on method entry

When using --break. We need to have a breakpoint set from debugger in mono_break.
2019-01-30 11:36:24 -05:00
Rolf Bjarne Kvinge 29b163f41c Fix leak if mono_assembly_setrootdir is called multiple times. (#12648)
Fix leak if mono_assembly_setrootdir is called multiple times.

Fix leak if mono_assembly_setrootdir is called multiple times by freeing the
previously stored value.




<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-01-30 10:16:01 -05:00
Vlad Brezae efac4c16ed [sgen] Logging for objects kept alive from ephemerons (#12650) 2019-01-30 16:17:08 +02:00
Rolf Bjarne Kvinge c9583047e8 Fix leak if mono_set_config_dir is called multiple times. (#12647)
Fix leak if mono_set_config_dir is called multiple times.

Fix leak if mono_set_config_dir is called multiple times by freeing the
previously stored value.




<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-01-30 09:15:57 -05:00
Michal Strehovský 434ec4110d Fix namespace of the AmbiguousImplementationException (#22291)
Moving to the namespace that was approved in dotnet/corefx#34124.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-30 13:48:02 +01:00
Jonathan Chambers ea95b18bde Throw ArgumentNullException if null method is passed to delegate constructor via invoke. (#12668)
Throw ArgumentNullException if null method is passed to delegate cons…

…tructor via invoke.

Fixes Unity issue: https://issuetracker.unity3d.com/issues/editor-crashes-with-g-logv-when-entering-play-mode-with-active-flowcanvas-script
2019-01-30 05:06:20 -05:00
monojenkins 3730afd464 [bcl] Update BCL Linked Size 2019-01-30 09:46:03 +01:00
Markus Kitsinger 63e512d133 Add AmbiguousImplementationException (dotnet/coreclr#22280)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-30 09:33:07 +01:00
Markus Kitsinger 3850bce0f0 Do not cache error string in SerializationException (dotnet/coreclr#22281)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-30 09:33:07 +01:00
Marek Safar 3322b33f0d Remove Mono implementation 2019-01-30 09:30:24 +01:00
Marek Safar 167e79290f Move Marshal::StringTo* methods to shared partition (dotnet/coreclr#22266)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-30 09:30:24 +01:00
Tanner Gooding fb1a589aea Fixing several of the HWIntrinsic SoftwareFallback functions to be captureless (#22263)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-30 09:30:24 +01:00
Michal Strehovský 3d17e982c1 Recover some of the size lost with AsyncMethodBuilder/Task unification (#6913)
When we unified the implementations of these across all of our runtimes, we lost all size optimizations people have been doing on the Project N side over the past six years.

This restores a bit of the loss. For one sample app with lots of async usage, this removes 2.1 MB of generic instantiations.

There is more we can do, but I can't spend time on that right now. These two things jumped out on me when I was looking at it back in December and were an easy fix I wanted to do for a while.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-30 09:30:24 +01:00
Zoltan Varga 4799e263a9 [aot] Size optimizations. (#12631)
* [gshared] Make mono_method_lookup_or_register_info () static, its only used in mini-generic-shared.c. Simplify callers.

* [aot] Optimize the encoding/decoding of MonoJumpInfoRgctxEntry.

Previously, all entries were associated with a method, but thats only needed for entries which have
is_mrgctx set, the rest can be associated with a class. Also, emit the encoding of methods/classes
only once, then refer to the them using a blob offset.

* [aot] Optimize the encoding of generic contexts by emitting every ginst only once.

* [aot] Add a MONO_AOT_METHOD_FLAG_HAS_PATCHES flag to avoid having to write the number of patches if its 0.

* [aot] Add a preinited got slot for MONO_PATCH_INFO_GC_SAFE_POINT_FLAG, fix the equality test.
2019-01-29 16:10:51 -05:00
Alexander Köplinger af2b7fec45 [utils] Add mono-errno.h to EXTRA_DIST
It was missed in https://github.com/mono/mono/pull/12082
2019-01-29 21:30:15 +01:00
Thays Grazia 4c09d46388 [Wasm][Debugger] Object inspection. (#12655)
* [Wasm][Debugger] Object inspection.

* Changind  indention formatting.
2019-01-29 10:37:08 -05:00
Kenneth Pouncey 51e3be76db [wasm] Wasm Websocket support (#12615)
* [wasm] Fix crash with delegates.

Internally the javascript bridge support uses `System.Delegate` and `System.Delegate.DynamicInvoke` to support delegate callbacks.  The linker, when executed over the assemblies, does not know about this code coverage and will strip out `System.Delegate.DynamicInvoke`.

To fix this:

- Add reference to `System.Delegate.DynamicInvoke` to the `WebAssembly.Bindings` linker xml file so the linker knows not to strip the code.
- Add detailed error messages in case something else goes wrong so the crash is not so cryptic.

* [wasm] WebSocket support initial commit.

- Connect to socket
- Basic Send and Receive support for Text and Binary - Needs work.
- Close socket.

* Add nuget packaging for build tools sdk

* Add Not Implemented Exceptions to the ClientWebSocketOptions implementation.

- The browser websocket specification does not provide for referencing the underlying http parameters.
- KeepAliveInterval - The browser websocket implementation implements the PING/PONG implementation and does not provide a mechanism via the websocket API.

* Remove validattion for keepalive as it is not implemented.

* a couple more Not Implemented Exceptions for WebSocketOptions

* Change to PlatformNotSupportedException.

* ProjectReference instead of assembly.

* Add websockets assembly to sdk build

* Add WebAssembly.Net.Websockets to packager.

- Treat as core for AOT linker.  This should be linked out but the linker but will appear in the loaded assembly list.
- Make sure it is imported as part of the non AOT build.

* Cleanup code.

* Add WebAssembly.Net.WebSockets assemblies to package
2019-01-29 10:35:33 -05:00
Katelyn Gadd 3704221361 Fix pipes not being enabled in all relevant versions of the build profile 2019-01-29 11:41:04 +01:00
Egor Bogatov cd69f587dc [corlib] TimeZoneInfo from corefx (#11500)
Not yet enabled for mobile, build and basic profiles.
Doesn't require ICU dependency, also I created a small PR for dotnet/coreclr to improve TimeZoneInfo.DisplayName on unix: https://github.com/dotnet/coreclr/pull/20728

Part of #7737
2019-01-29 11:34:00 +01:00
Marek Safar 1f4a0965cc Add Marshal ansi conversion to shared partition (dotnet/coreclr#22243)
* Add Marshal ansi conversion to shared partition

* Ignore bestFit/throwOnUnmappableChar on Unix

* Use same assert in StringToAnsiString

* wideCharLen parameter rename

Signed-off-by: dotnet-bot <[email protected]>
2019-01-29 09:15:21 +01:00
Filip Navara 30b930a0fe Add sample from issue #12402. 2019-01-28 23:43:13 +01:00
DasSkelett cd814981ea Take text alignment for LinkLabels into account (#12643)
<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
## Problem
`LinkLabels` ignore the text alignment for rendering the "hitbox" and the text color (= the `LinkArea`), and the focus rectangle. Also every text behind the end of this LinkArea/focus rectangle region is not painted at all.
This becomes visible if `AutoSize = false` and the `Size` is bigger than the text would need,
and if the text alignment is anything different than `TopLeft`.

## Cause
I think this is because the `piece.regions` are only translated regarding the padding, but neglecting the text alignment.

## Solution
Calculate the offset due to alignment and add it to the translation in `LinkLabel.CreateLinkPieces ()`

Fixes #12402 

## One more problem:
~Right now, a very tiny bit at the end of the label is still cut off (see my zipped and attached comparison pictures). Maybe `GetBounds ()` returns a value little bit smaller than it should be.
Can someone help?~

Also, maybe I took the wrong approach to this issue, but I don't know the inner mechanisms of mono.
So feel free to either advise me to change something, or change it yourself(s) :)
2019-01-28 23:30:10 +01:00
Mike Krüger 085ddcccb5 Fixes VS4Mac Issue #6898 (#12432)
https://github.com/mono/monodevelop/issues/6898

Not sure if it's the root of the problem but it surely fixes the dead lock on my machine.
2019-01-28 16:30:40 -05:00
Aleksey Kliger (λgeek) 1ec822976b [cxx] Set CXXLD and CCLD in configure (#12625)
* [cxx] Set CCLD and CXXLD for final linking

Essentialy bypass automake's automatic linker selection based on _SOURCES file
extensions.

The issue:
  1. Right now we need to use the C linker unless we're linking with LLVM which
     needs C++.
  2. Later when we start using C++ in Mono we will still want the C linker,
     because we will use a subset of C++ that doesn't depend on the C++ runtime
     library (because we don't want to break embedders that don't expect us to
     use C++).

So in either case which linker we use is a decision that we want to make
independent of what the file extensions look like.

So we set MONO_CXXLD in configure.  If LLVM is enabled, we use $CXX, otherwise
$CC.

Then in mono/mini/Makefile.am.in we set CCLD and CXXLD to MONO_CXXLD.  So
whatever automake decides we're going to use the linker that we want.

This partly reverts 988f4a2147 which tried
another approach (which turned out not to work).

This should also address https://github.com/mono/mono/issues/12060

Closes https://github.com/mono/mono/issues/12435

* [cxx] Fix link errors if both --enable-llvm and --enable-cxx are on
2019-01-28 16:22:00 -05:00
Ben Adams b4534a0cd2 string.EndsWith use SequenceEqual not SequenceCompareTo (#22207)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-28 09:38:26 +01:00
[email protected] 6c4199d25d Improve BinaryReader.ReadUInt32() perf by 30% when using MemoryStream (#22102)
BinaryReader.ReadInt32() has nice optimization which was missing from the ReadUInt32() version. Now both implementations are aligned.

ReadUInt32 and all the 64 bits types are now 30% to 50% faster than original implementation.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-28 09:38:26 +01:00
Ben Adams d35e06ff3c Shrink Task.Delay when used without cancellation (dotnet/coreclr#22233)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-28 09:38:26 +01:00
Dotnet-GitSync-Bot 3b2c1ca08a Mirror changes from mono/corefx,corert (#12645)
This PR contains mirrored changes from mono/corefx,corert


**Please REBASE this PR when merging**

 cc @jkotas
2019-01-28 09:33:53 +01:00
Marek Safar c40885324e Remove local Timer copy 2019-01-27 22:45:35 +01:00
Stephen Toub 6d13120e7c Remove several uses of VoidTaskResult (dotnet/coreclr#22238)
* Remove defunct netstandard code from ValueTask

* Remove several uses of VoidTaskResult

Currently TrySetResult/Canceled/Exception live on `Task<T>`.  There's no reason `TrySetCanceled` and `TrySetException` need to live there, as they only access state from the base `Task`, and so can be moved down.  `TrySetResult` needs the `TResult`, however in a variety of cases `Task<T>` is used with a `VoidTaskResult`, and for such cases we can just have a parameterless `TrySetResult()` on the base class as well, which can be used any time there is no `TResult` or when `default(TResult)` is the desired result.  This lets us switch several cases where we were using `Task<VoidTaskResult>` to just be `Task`, which saves 8 bytes on the task instance on 64-bit.  It also avoids an Interlocked.Exchange as part of the TrySetResult call.

This primarily affects Task.Delay and the non-generic variants of Task.WhenAll, ValueTask.AsTask(), Task.FromCanceled, and Task.FromException.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-27 22:45:35 +01:00
Filip Navara 0ed3a181c1 Move Timer to shared CoreLib partition. (dotnet/coreclr#22231)
* Move Timer to shared CoreLib partition.

* Move SignalNoCallbacksRunning back to shared code, add static EventWaitHandle.Set.

* Remove AppDomain references from shared Timer code, reshuffle some code out of SetTimer in non-shared code.

* Change m_ prefix to match code style.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-27 22:45:35 +01:00
Dotnet-GitSync-Bot f932a50d51 Mirror changes from mono/coreclr (#12635)
* Move Marshal::ZeroFree* to shared partition (dotnet/coreclr#22230)

* Move Marshal::ZeroFree* to shared partition

* Add managed version of SysStringByteLen

Signed-off-by: dotnet-bot <[email protected]>

* Remove duplicated code
2019-01-27 08:47:05 +01:00
Stephen Toub 6707bed13b Factor WinRT GetFolderPath into static accessible via reflection (#34873)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-26 14:40:18 +01:00
Dotnet-GitSync-Bot 87220f95fc Mirror changes from mono/coreclr (#12629)
* Move more Marshal methods to shared partition (dotnet/coreclr#22205)

* Move more Marshal methods to shared partition

* Implement ThrowExceptionForHR in managed

Signed-off-by: dotnet-bot <[email protected]>

* Remove local copy
2019-01-26 09:24:24 +01:00
monojenkins 39f669c465 [bcl] Update BCL Linked Size 2019-01-26 08:37:15 +01:00
Zoltan Varga ada3f474cc [aot] Print detailed stats only when --aot=stats is used. Avoid emitting 2 copies of preinited got slots in llvmonly mode. (#12614) 2019-01-25 18:52:36 -05:00
Ben Adams ed3649661e Skip rangecheck in string.EndsWith(char) (dotnet/coreclr#22206)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-25 20:32:21 +01:00
Ben Adams 32ae150897 Use AggressiveOptimization for intrinsics-based SpanHelpers (#22191)
* Use AggressiveOptimization for intrinsics-based SpanHelpers

* Remove from LastIndexOfAny

Signed-off-by: dotnet-bot <[email protected]>
2019-01-25 17:37:03 +01:00
Marek Safar 52dce5ed74 Reduce Task's static ctor dependencies (dotnet/coreclr#22172)
* Reduce Task's static ctor dependencies

* Remove defensive check

* Revert "Remove defensive check"

This reverts commit df15ab0350e8f44fc5cbb1a18c5211cd1de11989.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-25 17:31:31 +01:00
Larry Ewing e9a084b470 Merge pull request #12611 from marek-safar/linker-fixes
Add monolinker binary assets tests
2019-01-25 09:39:51 -06:00
Elliot Prior f5c045a546 Cancel CTS immediately if delay is zero. (dotnet/coreclr#18098)
The intended behaviour on specifying a delay of zero is that the CancellationTokenSource is cancelled immediately - before this change, it would depend on the scheduling of the timer callback which could lead to seeing a non-cancelled token. Now, it marks itself as cancelled immediately, without invoking any callbacks (as this method is called only from within the constructor of the object, before any callbacks could have been registered.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-25 15:19:59 +01:00
Ben Adams 7fb70b59cc Speedup .SequenceCompareTo(byte, ...) (dotnet/coreclr#22127)
* Speedup .SequenceCompareTo(byte, ...)

* Rename jump location

* Better annotations for clarity

Signed-off-by: dotnet-bot <[email protected]>
2019-01-25 14:06:39 +01:00
Katelyn Gadd acaa73b702 Integration and bug fixes to enable use of roslyn compiler server (#12476)
This PR still needs additional cleanup work to be ready to merge but it's getting close enough to be worth running tests and getting code review. The purpose of this PR is to make various bug fixes and infrastructure changes so that it is trivial to use the roslyn compiler server on a clean checkout.

Summary of the changes:
* configure.ac generates some additional variables in config.make that are used to configure the compiler server mode in make. You can then use the compiler server by passing ```ENABLE_COMPILER_SERVER=1``` to make or flipping the switch in config.make.
* config.make has two variables pointing to the compiler server version of roslyn. This lets you use a local build/checkout of roslyn but only when the compiler server is enabled. Once we update in-tree roslyn these vars can default to that. (The in-tree version of csc is not compatible with the compiler server.) The vars are named ```SERVER_CSC_LOCATION``` and ```VBCS_LOCATION```.
* config.make also has a variable that sets the name of the roslyn compiler server pipe. If you're trying to build multiple checkouts in parallel, or build in multiple user accounts, you'll need to use separate pipenames. You'll be able to set this from the command line once I tweak the config file with ```COMPILER_SERVER_PIPENAME=xxx```.
* basic_profile_check attempts to start the compiler server before any builds happen. I put it there because that was the only way I found to get it to always run before mcs builds. I spent a few hours trying to add a separate build target for this, and then gave up because makefiles. (I'd love to get suggestions on a better way to do this) Because it's nontrivial to track compiler server instances across builds, I just spawn a new one every time - this works fine because the compiler server has logic to detect an existing instance.
* I completely rewrote our implementation of Timer and its scheduler, because the existing one was burning an entire core at all times in the compiler server, mostly calling SortedList methods. The new implementation is probably not release-ready, but I focused on keeping it easy to audit and understand because attempts to preserve the existing logic kept breaking. Ideally we can just pull in corefx's timers here, but it looked non-trivial to do that.
* ReaderWriterLockSlim was checking Environment.ProcessorCount every time it was used, which in most configurations will result in a syscall to getpid() and another syscall to check our affinity. This was bottlenecking the compiler server really bad. I changed this to match most other threading code and use PlatformHelper.ProcessorCount instead.
* Our nunit.snk was corrupt (not sure how this happened) so I replaced it with the current nunit.snk from mainline nunit. Thanks to @jaredpar and other roslyn folks for troubleshooting this - it was causing problems for our msbuild infrastructure as well and I never figured that out.

Some work remains before the compiler server is good enough to use by default, which I will probably document here (or in tree? on a wiki?)
2019-01-25 14:05:29 +01:00
Zoltan Varga 124636c036 [jit] Add support for Unsafe intrinsics. (#12605) 2019-01-25 08:04:19 -05:00
Dotnet-GitSync-Bot f76994e0a1 Mirror changes from mono/coreclr,corert (#12612) 2019-01-25 14:01:09 +01:00
Tomasz Jaworski 901ca2bf6d Fix handling invalid Windows proxy config (#12595)
This fixes NullReferenceException that was thrown if:
-
 HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Internet Settings\\ProxyEnable was set to true (1)
-
 HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Internet Settings\\ProxyServer was set to null

Fixes #10030
2019-01-25 11:48:23 +01:00
Zoltan Varga f96d070114 [ci] Add CI_TAGS handling for ccache (#11305) 2019-01-25 11:37:18 +01:00
Zoltan Varga 9b8ff3260b [netcore] Port classes to netcore (#12548) 2019-01-25 09:47:31 +01:00
Marek Safar dcbe42a59c Add monolinker binary assets tests 2019-01-25 00:16:42 +01:00
Filip Navara 5f7db9082e Fix argument checks in ThreadPool.RegisterWaitForSingleObject. (#6887)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-25 00:07:11 +01:00
Marek Safar 06e109380e Fix the build 2019-01-25 00:00:06 +01:00
Tanner Gooding a184818adf Fixing some issues with the decimal parser/formatter (dotnet/coreclr#22070)
* Fixing the decimal formatting so that -0 prints as 0

* Fixing the decimal parser to consider digits still in the buffer as part of the zero/non-zero tail check

Signed-off-by: dotnet-bot <[email protected]>
2019-01-25 00:00:06 +01:00
Marek Safar ea13736f5c Move TaskContinuation to shared partition (dotnet/coreclr#22167)
* Move TaskContinuation to shared partition

* Remove TASK_STATE_THREAD_WAS_ABORTED from Task

* Use already existing ThrowAsync

Signed-off-by: dotnet-bot <[email protected]>
2019-01-25 00:00:06 +01:00
Michal Strehovský c313fc50ff Fix UWP VirtualAlloc import (dotnet/corert#6882)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-24 23:08:38 +01:00
Zoltan Varga af8d01c458 [runtime] Fix #ifdef NETCORE. 2019-01-24 23:07:56 +01:00
Alexander Kyte 56d8b8ec5f Merge pull request #12081 from alexanderkyte/posix_funcs_fix
[runtime] Guard usage of unix functions that aren't posix
2019-01-24 12:53:25 -05:00
Aleksey Kliger (λgeek) c90d1fe6d8 [image] Don't leak old image->name when closing (#12589) 2019-01-24 12:27:33 -05:00
Zoltan Varga afde007137 [wasm] Make the compilation of the empty.cs files quiet. (#12593)
[wasm] Make the compilation of the empty.cs files quiet.
2019-01-24 09:45:59 -05:00
Kenneth Pouncey f50cbd18ac [wasm] Fix AOT test build error message 'Unable to compile method'. (#12594)
* [wasm] Fix AOT test build error message 'Unable to compile method'.

* Remove `--aot-interp` command line option

* Remove a few more options

* add --linker option
2019-01-24 06:17:01 -05:00
Bernhard Urban c8552ac097 [runtime] cleanup around native crash info (#12581)
[runtime] cleanup around native crash info

Contributes to https://github.com/mono/mono/issues/12404
2019-01-24 06:05:44 -05:00
Bernhard Urban f394d7cd8e [spinlock] reduce interations in BCL test and extract it into a stress test
Reduces execution time from about two minutes down to five seconds for SpinLockTests.
2019-01-24 11:17:20 +01:00
Marek Safar 9f16ba6567 Fix the build 2019-01-24 11:15:35 +01:00
Ben Adams c68385b8a6 Speedup SpanHelpers.IndexOf{Any}(byte, ...) (dotnet/coreclr#22118)
* Speedup SpanHelpers.IndexOf(byte)

* 128 * 2 alignment

* Move TrailingZeroCountFallback to common SpanHelpers

So it can be used by other types than byte

* Speedup SpanHelpers.IndexOfAny(byte, ...)

* Indent for support flags

* More helpers, constency in local names/formatting, feedback

* Skip bounds check in software fallback

Signed-off-by: dotnet-bot <[email protected]>
2019-01-24 11:15:35 +01:00
Marek Safar 973b5c1b0f Move IOCompletionCallback to shared partition (dotnet/corert#6875)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-24 11:15:35 +01:00
Stephen Toub 677d83b4ab Implement IAsyncDisposable.ConfigureAwait (dotnet/coreclr#22160)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-24 10:56:26 +01:00
monojenkins 638c927fc1 [bcl] Update BCL Linked Size 2019-01-24 10:50:17 +01:00
Zoltan Varga 74fba1e6d3 [runtime] Avoid calling mono_pe_file_time_date_stamp () for images loaded from memory. (#12587) 2019-01-24 04:27:58 -05:00
Alexander Kyte 1a480b72d3 [runtime] Fix mono_pe_file_map logging (#12588) 2019-01-24 04:27:37 -05:00
Jérôme Laban a95bbcb8e7 Fix lookup for all SourceLink mappings, prefer local file over SourceLink 2019-01-23 21:09:44 -05:00
Zoltan Varga c821964b29 [runtime] Reorganize mono_dl_build_path () a bit, add a new case for netcore.
The netcore native libs are named System.Native.dylib etc. so they don't have the
lib prefix. Add a case for it.
2019-01-23 18:32:35 -05:00
Alexander Kyte 56d6010e59 [runtime] Fix wasm definition of HAVE_UTIME(S) 2019-01-23 18:30:23 -05:00
Marek Safar 76fcb3343d Fix the build 2019-01-24 00:09:19 +01:00
Filip Navara 9fe6dcb374 Move common ThreadPool code to shared CoreLib partition. (#22115)
* Move common ThreadPool code to shared CoreLib partition.

* Move numWorkingThreads counting out of shared code.

* Rename ThreadPoolGlobals.vmTpInitialized to threadPoolInitialized.
Remove exception handling from ThreadPoolWorkQueue.Dispatch.
Remove obsolete code from ThreadPoolWorkQueue.Dispatch.
Rename ThreadPool.EnsureVMInitialized to ThreadPool.EnsureInitialized.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-24 00:09:19 +01:00
Alexander Kyte 6843fff6a5 [runtime] Remove dependency on getpeername 2019-01-23 17:22:26 -05:00
Alexander Kyte a53c038871 [runtime] Add missing checks for HAVE_STRINGS_H 2019-01-23 17:22:26 -05:00
Alexander Kyte e49e6b55d0 [runtime] Remove missing check for HAVE_SYS_PARAM_H 2019-01-23 17:22:26 -05:00
Alexander Kyte 6d9af6db31 [runtime] Add missing checks for HAVE_SYS_RESOURCE_H 2019-01-23 17:22:26 -05:00
Alexander Kyte 79d3407c70 [runtime] Add missing checks for HAVE_NETINET_TCP_H 2019-01-23 17:22:26 -05:00
Alexander Kyte af3112213c [runtime] Remove dependency on atexit 2019-01-23 17:22:25 -05:00
Alexander Kyte 5c1585cfa9 [runtime] Remove dependency on openlog and closelog 2019-01-23 17:22:25 -05:00
Alexander Kyte 510aa8c702 [runtime] Make it easier to define DISABLE_SOCKETS 2019-01-23 17:22:25 -05:00
Alexander Kyte 9905044f66 [runtime] Remove dependency on utimes 2019-01-23 17:22:25 -05:00
Alexander Kyte a3f286c821 [runtime] Add missing HAVE_SYSCONF 2019-01-23 17:22:25 -05:00
Alexander Kyte 8ceec78af2 [runtime] Remove dependency on GetHostName 2019-01-23 17:22:25 -05:00
Alexander Kyte d185d31120 [runtime] Remove dependency on msync 2019-01-23 17:22:25 -05:00
Alexander Kyte 498a57aa9c [runtime] Remove dependency on getdtablesize 2019-01-23 17:22:25 -05:00
Alexander Kyte cd375339e6 [runtime] Remove dependency on lstat 2019-01-23 17:22:25 -05:00
Alexander Kyte 3a5199388d [runtime] Remove build dependency on chmod 2019-01-23 17:22:25 -05:00
Alexander Kyte af0f33f81a [runtime] Remove dependency on makedev 2019-01-23 17:22:24 -05:00
Alexander Kyte 68ad522689 [runtime] Remove dependency on readlink 2019-01-23 17:22:24 -05:00
Martin Baulig e060c5b0f0 [eglib]: Fix memory leak in g_find_program_in_path(). #11615. (#12580) 2019-01-23 16:41:46 -05:00
Alexander Kyte a80d44980c Merge pull request #12082 from alexanderkyte/no_direct_errno
[runtime] Create some indirection for errno setting
2019-01-23 16:28:09 -05:00
Larry Ewing 63cbf6126e Merge pull request #12551 from kjpou1/wasm-aot-link
[wasm] AOT linkage and samples
2019-01-23 15:25:42 -06:00
Jan Kotas 63d2f0e6ec Fix CoreRT build after moving Task.cs to shared partition
Signed-off-by: dotnet-bot <[email protected]>
2019-01-23 22:16:07 +01:00
Filip Navara 25ce6d849d Fix possibly unintentional use of bit-wise or operator. (#22152)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-23 22:16:07 +01:00
alexk000 3fd3eb5081 Remove variable name duplication (dotnet/coreclr#22155)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-23 22:16:07 +01:00
Marek Safar 89940bd801 Remove redundant files 2019-01-23 22:06:53 +01:00
Marek Safar 39b9e2099f Move Task to shared partition (dotnet/coreclr#22105)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-23 22:06:53 +01:00
Ben Adams 5bb7ab2f7d Remove duplicate requiresSynchronization params attribute (#22143)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-23 22:06:53 +01:00
Filip Navara d22d97718a Update parameter names in PInvoke signatures to match MSDN documentation.
Signed-off-by: dotnet-bot <[email protected]>
2019-01-23 22:06:53 +01:00
Filip Navara ee6597030e Build fixes.
Signed-off-by: dotnet-bot <[email protected]>
2019-01-23 22:06:53 +01:00
Jérôme Laban 133088a437 Update GetScriptSource more async, show exception message. 2019-01-23 15:50:55 -05:00
Zoltan Varga 80bc0069e4 [llvmonly] Move the mono_aot_init_llvm_method family of functions to llvmonly-runtime.c, rename them to mini_llvmonly_init_... for consistency. (#12575)
[llvmonly] Move the mono_aot_init_llvm_method family of functions to llvmonly-runtime.c, rename them to mini_llvmonly_init_... for consistency.
2019-01-23 12:25:53 -05:00
Larry Ewing 8ac757202a Merge pull request #12254 from marek-safar/bcl-fixes
Enables SRE for wasm
2019-01-23 10:24:39 -06:00
Kenneth Pouncey 45ccb2b185 Address review comments 2019-01-23 17:03:50 +01:00
Kenneth Pouncey b6d5809aa2 Update packager to address review comments
- Add `verbose` CL flag to control `--verbose` mode sent to `monolinker` during link phase.

```
  --verbose (set verbose option on link)
        type: bool  default: false
```
2019-01-23 16:21:04 +01:00
Kenneth Pouncey ab95e60634 Remove netstandard from list of core assemblies as it is now implemented in monolinker. 2019-01-23 15:21:53 +01:00
Sebastien Pouliot d9508b8086 [System.Net.Http] Fix CFNetworkHandler when no data is sent
The handler receive an `Open` and the a `Close` event but never a
`DataAvailable` event.

So it _hangs_ if only a `200` status is received (since the headers
are not considered _data_) received from the web server.

This is because some initialization only occurs inside
`HandleHasBytesAvailableEvent` which is now called, on `Close`,
to ensure the initialization is done before completing the request.

This, along with a cancellation check, makes the test case from
https://github.com/xamarin/xamarin-macios/issues/5190 work properly
with this handler.

Fixes https://github.com/xamarin/xamarin-macios/issues/5289
2019-01-23 14:36:20 +01:00
Bijan Tabatabai 7c87bd7c19 [Fix] GetActiveTcpConnections now returns correct state in unix
The values of the enum for the TcpState are different in Unix systems
than in .NET, so a function was added to convert between the two.

Signed-off-by: Bijan Tabatabai <[email protected]>
2019-01-23 14:34:14 +01:00
Maxim Lipnin b56f4d9184 Japanese calendar era change (#12556)
* Support new Japanese calendar eras

* Port Formatting Japanese First Year of Era

* Fix formatting

* Update switches for mobile mode

* Bump corefx
2019-01-23 14:33:00 +01:00
Martin Baulig 22d01c707c [Mono.Security]: Remove some obsolete test tools.
These tools were using the obsolete `Mono.Security.Protocol.Tls` code
(Legacy TLS), which is scheduled for removal.
2019-01-23 14:32:16 +01:00
Kenneth Pouncey 96f2de301a Merge branch 'master' of https://github.com/mono/mono into wasm-aot-link 2019-01-23 14:29:41 +01:00
Kenneth Pouncey 2aeb4afa26 Bump linker (#12560)
* Bump linker

* Bump linker
2019-01-23 08:27:43 -05:00
monojenkins 98c4e0efd7 [csproj] Update project files 2019-01-23 12:55:42 +00:00
Martin Baulig 5c71a7872d [SslStream]: Flatten exceptions in sync SslStream APIs.
The sync APIs `SslStream.AuthenticateAsClient()` and `AuthenticateAsServer()`
should not throw `AggregateException`.

Fixes #9418.
2019-01-23 13:13:25 +01:00
Steve Pfister 26e0b1deec Fixes #12479 - Fixed issue where time lookups on a symlink (GetLastWrite, Creation, … (#12533)
When given a path to a symlink `GetLastWriteTime` returned the time for the actual file.  This PR resolves that.

Fixes https://github.com/mono/mono/issues/12479
2019-01-23 13:05:59 +01:00
Kenneth Pouncey 4a29e830b3 Merge branch 'master' of https://github.com/mono/mono into wasm-aot-link 2019-01-23 11:44:33 +01:00
Marek Safar dc9bc9e0e6 Enables SRE for wasm 2019-01-23 11:17:47 +01:00
Zoltan Varga 8c7ef3c7a3 [jit] Enable generic sharing for empty structures. (#12570)
[jit] Enable generic sharing for empty structures.
2019-01-23 04:35:52 -05:00
Larry Ewing bd063d89ad Merge pull request #12566 from vargaz/dir-dependency
[bcl] Fix the dependencies for the corlib tests.
2019-01-22 19:44:06 -06:00
Larry Ewing d7be84abc4 Merge pull request #12554 from BrzVlad/feature-interp-virtperf
[interp] Improve performance of virtual calls
2019-01-22 18:43:55 -06:00
Vlad Brezae 5b2d3972a0 [utils] Fix potential overflow (#12559)
[utils] Fix potential overflow

When doing array copy of 16+ GB.
2019-01-22 18:45:27 -05:00
Zoltan Varga d41e8dd5eb [bcl] Fix the dependencies for the corlib tests. 2019-01-22 12:44:36 -05:00
Alexander Kyte 7f1619b570 [runtime] Create some indirection for errno setting 2019-01-22 11:51:12 -05:00
Vlad Brezae ad7cb105ec [sgen] Don't trigger concurrent collections if we exceed soft heap limit (#12536)
Concurrent gc (mark / sweep) allows the heap to grow further, which is not what we want if we already exceeded the limit.
2019-01-22 11:13:38 -05:00
Alexander Kyte 6bcd623e7c Merge pull request #12518 from alexanderkyte/merp_thread_hash
[crash] Place hashes into the json file for all threads
2019-01-22 11:07:59 -05:00
Vlad Brezae 7cdde25858 [interp] Fall back to old implementation when calling on proxy
Virtual call optimizations don't handle remoting yet
2019-01-22 16:56:21 +02:00
Vlad Brezae 81330cd5ac [interp] Allocate interface table as part of MonoVTable 2019-01-22 16:56:21 +02:00
Vlad Brezae 42cc325b44 [interp] Use fast virtual invoke code also for interfaces
As with virtual generic calls, when doing an interface call, we need to iterate over all the methods in the hashing slot.
2019-01-22 16:55:46 +02:00
Vlad Brezae 11aca2f939 [interp] Improve performance of generic virtual calls
Different instantiations of generic virtual methods occupy the same slot in the vtable. We probe them using a single linked list, by the same logic of jit's imt trampolines.
2019-01-22 16:55:46 +02:00
Vlad Brezae 2c73aa015b [interp] Improve performance of virtual calls
We allocate a new interp vtable array that we store inside the type's vtable. This array has the same logic as the jit vtable array and it stores InterpMethod pointers. We embed the virtual method slot in the interp instruction stream.
2019-01-22 16:55:46 +02:00
Aleksey Kliger 55d29aa7d4 [netcore] Make Assembly.Load (new AssemblyName (corlib_name + ".dll")) work again
Partly revert a change in https://github.com/mono/mono/pull/12478

CoreCLR treats `Assembly.Load (new AssemblyName ("System.Private.CoreLib.dll"))`
the same as `Assembly.Load (new AssemblyName ("System.Private.CoreLib"))`  (and
.NET Framework behaves likewise with "mscorlib.dll").
2019-01-22 15:43:11 +01:00
Alexander Kyte 470354fa81 [crash] Test and fix stability of native crash pipeline(s) (#12125)
* [runtime] Make infrastructure for merp tests

* [runtime] Fix dumping when crash happens without sigctx

* [runtime] Disable crashy (886/1000 runs) stacktrace walker

* [crash] Remove usage of allocating build/os info functions

* [crash] Remove often-crashing g_free on native crash path

* [crash] Add crash_reporter checked build

We add a checked build mode that asserts when mono mallocs inside of
the crash reporter. It makes risky allocations into assertions. It's
useful for automated testing because the double-abort often represents
itself as an indefinite hang. If it happens before the thread dumping
supervisor process is started, or after it ends, the crash reporter
hangs.

* [crash] Remove reliance on nested SIGABRT/double-fault (broken on OSX)

* [crash] Fix top-level handling of double faults/assertions

* [runtime] Make fatal unwinding errors return into handled error paths

* [crash] Change dumper logging for better info

* [runtime] Fix handling of segfault on sgen thread

Threads without domains that get segfaults will end up in
this handler. It's not safe to call this function with a NULL domain.

See crash below:

```
* thread #1, name = 'tid_307', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=2, address=0x10eff40f8)
  * frame #0: 0x000000010e1510d9 mono-sgen`mono_threads_summarize_execute(ctx=0x0000000000000000, out=0x0000001000000000, hashes=0x0000100000100000, silent=4096, mem="", provided_size=2199023296512) at threads.c:6414
    frame #1: 0x000000010e152092 mono-sgen`mono_threads_summarize(ctx=0x000000010effda00, out=0x000000010effdba0, hashes=0x000000010effdb90, silent=0, signal_handler_controller=1, mem=0x0000000000000000, provided_size=0) at threads.c:6508
    frame #2: 0x000000010df7c69f mono-sgen`dump_native_stacktrace(signal="SIGSEGV", ctx=0x000000010effef48) at mini-posix.c:1026
    frame #3: 0x000000010df7c37f mono-sgen`mono_dump_native_crash_info(signal="SIGSEGV", ctx=0x000000010effef48, info=0x000000010effeee0) at mini-posix.c:1147
    frame #4: 0x000000010de720a9 mono-sgen`mono_handle_native_crash(signal="SIGSEGV", ctx=0x000000010effef48, info=0x000000010effeee0) at mini-exceptions.c:3227
    frame #5: 0x000000010dd6ac0d mono-sgen`mono_sigsegv_signal_handler_debug(_dummy=11, _info=0x000000010effeee0, context=0x000000010effef48, debug_fault_addr=0xffffffffffffffff) at mini-runtime.c:3574
    frame #6: 0x000000010dd6a8d3 mono-sgen`mono_sigsegv_signal_handler(_dummy=11, _info=0x000000010effeee0, context=0x000000010effef48) at mini-runtime.c:3612
    frame #7: 0x00007fff73dbdf5a libsystem_platform.dylib`_sigtramp + 26
    frame #8: 0x0000000110bb81c1
    frame #9: 0x000000011085ffe1
    frame #10: 0x000000010dd6d4f3 mono-sgen`mono_jit_runtime_invoke(method=0x00007faae4f01fe8, obj=0x0000000000000000, params=0x00007ffee1eaa180, exc=0x00007ffee1ea9f08, error=0x00007ffee1eaa250) at mini-runtime.c:3215
    frame #11: 0x000000010e11509d mono-sgen`do_runtime_invoke(method=0x00007faae4f01fe8, obj=0x0000000000000000, params=0x00007ffee1eaa180, exc=0x0000000000000000, error=0x00007ffee1eaa250) at object.c:2977
    frame #12: 0x000000010e10d961 mono-sgen`mono_runtime_invoke_checked(method=0x00007faae4f01fe8, obj=0x0000000000000000, params=0x00007ffee1eaa180, error=0x00007ffee1eaa250) at object.c:3145
    frame #13: 0x000000010e11aa58 mono-sgen`do_exec_main_checked(method=0x00007faae4f01fe8, args=0x000000010f0003e8, error=0x00007ffee1eaa250) at object.c:5042
    frame #14: 0x000000010e118803 mono-sgen`mono_runtime_exec_main_checked(method=0x00007faae4f01fe8, args=0x000000010f0003e8, error=0x00007ffee1eaa250) at object.c:5138
    frame #15: 0x000000010e118856 mono-sgen`mono_runtime_run_main_checked(method=0x00007faae4f01fe8, argc=2, argv=0x00007ffee1eaa760, error=0x00007ffee1eaa250) at object.c:4599
    frame #16: 0x000000010de1db2f mono-sgen`mono_jit_exec_internal(domain=0x00007faae4f00860, assembly=0x00007faae4c02ab0, argc=2, argv=0x00007ffee1eaa760) at driver.c:1298
    frame #17: 0x000000010de1d95d mono-sgen`mono_jit_exec(domain=0x00007faae4f00860, assembly=0x00007faae4c02ab0, argc=2, argv=0x00007ffee1eaa760) at driver.c:1257
    frame #18: 0x000000010de2257f mono-sgen`main_thread_handler(user_data=0x00007ffee1eaa6a0) at driver.c:1375
    frame #19: 0x000000010de20852 mono-sgen`mono_main(argc=3, argv=0x00007ffee1eaa758) at driver.c:2551
    frame #20: 0x000000010dd56d7e mono-sgen`mono_main_with_options(argc=3, argv=0x00007ffee1eaa758) at main.c:50
    frame #21: 0x000000010dd5638d mono-sgen`main(argc=3, argv=0x00007ffee1eaa758) at main.c:406
    frame #22: 0x00007fff73aaf015 libdyld.dylib`start + 1
    frame #23: 0x00007fff73aaf015 libdyld.dylib`start + 1
  thread #2, name = 'SGen worker'
    frame #0: 0x000000010e2afd77 mono-sgen`mono_get_hazardous_pointer(pp=0x0000000000000178, hp=0x000000010ef87618, hazard_index=0) at hazard-pointer.c:208
    frame #1: 0x000000010e0b28e1 mono-sgen`mono_jit_info_table_find_internal(domain=0x0000000000000000, addr=0x00007fff73bffa16, try_aot=1, allow_trampolines=1) at jit-info.c:304
    frame #2: 0x000000010dd6aa5f mono-sgen`mono_sigsegv_signal_handler_debug(_dummy=11, _info=0x000070000fb81c58, context=0x000070000fb81cc0, debug_fault_addr=0x000000010e28fb20) at mini-runtime.c:3540
    frame #3: 0x000000010dd6a8d3 mono-sgen`mono_sigsegv_signal_handler(_dummy=11, _info=0x000070000fb81c58, context=0x000070000fb81cc0) at mini-runtime.c:3612
    frame #4: 0x00007fff73dbdf5a libsystem_platform.dylib`_sigtramp + 26
    frame #5: 0x00007fff73bffa17 libsystem_kernel.dylib`__psynch_cvwait + 11
    frame #6: 0x00007fff73dc8589 libsystem_pthread.dylib`_pthread_cond_wait + 732
    frame #7: 0x000000010e28d76d mono-sgen`mono_os_cond_wait(cond=0x000000010e44c9d8, mutex=0x000000010e44c998) at mono-os-mutex.h:168
    frame #8: 0x000000010e28df4f mono-sgen`get_work(worker_index=0, work_context=0x000070000fb81ee0, do_idle=0x000070000fb81ed4, job=0x000070000fb81ec8) at sgen-thread-pool.c:165
    frame #9: 0x000000010e28d2cb mono-sgen`thread_func(data=0x0000000000000000) at sgen-thread-pool.c:196
    frame #10: 0x00007fff73dc7661 libsystem_pthread.dylib`_pthread_body + 340
    frame #11: 0x00007fff73dc750d libsystem_pthread.dylib`_pthread_start + 377
    frame #12: 0x00007fff73dc6bf9 libsystem_pthread.dylib`thread_start + 13
  thread #3, name = 'Finalizer'
    frame #0: 0x00007fff73bf6246 libsystem_kernel.dylib`semaphore_wait_trap + 10
    frame #1: 0x000000010e1d9c0a mono-sgen`mono_os_sem_wait(sem=0x000000010e43e400, flags=MONO_SEM_FLAGS_ALERTABLE) at mono-os-semaphore.h:84
    frame #2: 0x000000010e1d832d mono-sgen`mono_coop_sem_wait(sem=0x000000010e43e400, flags=MONO_SEM_FLAGS_ALERTABLE) at mono-coop-semaphore.h:41
    frame #3: 0x000000010e1da787 mono-sgen`finalizer_thread(unused=0x0000000000000000) at gc.c:920
    frame #4: 0x000000010e152919 mono-sgen`start_wrapper_internal(start_info=0x0000000000000000, stack_ptr=0x000070000fd85000) at threads.c:1178
    frame #5: 0x000000010e1525b6 mono-sgen`start_wrapper(data=0x00007faae4f31bd0) at threads.c:1238
    frame #6: 0x00007fff73dc7661 libsystem_pthread.dylib`_pthread_body + 340
    frame #7: 0x00007fff73dc750d libsystem_pthread.dylib`_pthread_start + 377
    frame #8: 0x00007fff73dc6bf9 libsystem_pthread.dylib`thread_start + 13
  thread #4
    frame #0: 0x00007fff73c0028a libsystem_kernel.dylib`__workq_kernreturn + 10
    frame #1: 0x00007fff73dc7009 libsystem_pthread.dylib`_pthread_wqthread + 1035
    frame #2: 0x00007fff73dc6be9 libsystem_pthread.dylib`start_wqthread + 13
(lldb)
```

* [crash] Add signal-safe mmap/file "allocator"

* [crash] Remove use of static memory from dumper

* [runtime] Reduce print buffer size for lockless printer.

Each frame that prints ends up increased by the size of buff.
In practice, clang often fails to deduplicate some of these buffers,
leading to 30k-big stackframes.

It was noticed by a series of hard-to-diagnose segfaults on stacks that
looked otherwise fine during the crash reporting stress test.

This change fixes this, making stacks a 1/10th of the size. It doesn't
seem to break the crash reporter messages anywhere (may need to shrink
other "max name length" fields), and it's not mission-critical anywhere
else.

* [crash] Use async-safe file memory for dumper internals

* [crash] Add memory barriers around merp configuration

* [crash] Use signal-safe printers on all native crash paths

* [crash] Move gdb/lldb lookup to startup

* [runtime] Move MOSTLY_ASYNC_SAFE_FPRINTF to eglib

* [runtime] Fix all callsites of MOSTLY_ASYNC_SAFE_PRINTF

* [runtime] Fix all callsites of MOSTLY_ASYNC_SAFE_FPRINTF

* [crash] Switch to signal-safe exit function

* [crash] Make dumper enum in managed

* [runtime] Add more information to managed frame

* [crash] Make async_safe printers inlined

* [runtime] Move basic pe_file functionality into proclib

* [crash] Fix handling of thread attributes
2019-01-22 09:09:22 -05:00
Alexander Kyte f4d059f903 [runtime] Remove two missing tests from monodroid+aot excludes 2019-01-22 14:08:03 +01:00
Marek Safar e1d3838af6 Fix the build 2019-01-22 13:40:28 +01:00
Filip Navara dd90410129 Move MemoryFailPoint to shared CoreLib partition (dotnet/coreclr#22104)
* Move MemoryFailPoint to shared CoreLib partition.

* Split MemoryFailPoint into Unix and Windows versions.

* Replace MemoryFailPoint.GetMemorySettings FCall with GC.GetSegmentSize to make sharing with CoreRT easier.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-22 13:40:28 +01:00
Zoltan Varga 4e3264f975 [runtime] Move some internal methods and icalls from MethodBase to RuntimeMethodInfo to ease netcore integration. 2019-01-22 13:30:09 +01:00
Jan Kotas b4012bae49 Fix CoreRT build breaks
Signed-off-by: dotnet-bot <[email protected]>
2019-01-22 12:22:10 +01:00
Marek Safar a61fe27946 Fix the build 2019-01-22 10:14:37 +01:00
Marek Safar 5f59e8f9a3 Move TplEtwProvider to shared partition (dotnet/coreclr#22120)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-22 10:14:37 +01:00
Kenneth Pouncey ef5e58587e Remove link-mode=None
- Address reviewer comments
2019-01-22 10:08:21 +01:00
Martin Baulig a7cfa881fb [System]: Fix race condition in SystemDependencyProvider.Initialize(). #12538. (#12541) 2019-01-22 09:14:56 +01:00
Kenneth Pouncey 402859587e Update README.md 2019-01-22 07:45:58 +01:00
Kenneth Pouncey bc39d7fcd9 Update README.md 2019-01-22 07:42:14 +01:00
Kenneth Pouncey 434d70053d Update README.md
Fix link
2019-01-22 07:39:46 +01:00
Kenneth Pouncey 9d82a07db3 [wasm] Update documentation 2019-01-22 07:21:19 +01:00
Kenneth Pouncey 4173fb24f2 [wasm] Modify packager linkage for AOT'd code.
- Add new experimental command line option

   - --link-mode=None|SdkOnly|Full        Set the link type used for AOT. (EXPERIMENTAL)
   - `None` no linking.
   - `SdkOnly` only link the Core libraries.
   - `Full` link Core and User assemblies. **(default)**

- Add the Facades directory to the resolve paths.
- Treat netstandard, WebAssembly.Bindings and WebAssembly.Net.Http as core libraries.  `monolinker.exe` does not see `netstandard` as a core library.
2019-01-22 07:20:45 +01:00
Kenneth Pouncey d2635afea2 [wasm] Fix a few issues that crop up from time to time. Mostly affects running in an AOT'd application. 2019-01-22 06:36:27 +01:00
Kenneth Pouncey 045eed6107 [wasm] Fix a problem with void methods that are invoked.
- The problem stems from void methods returning a corrupted MonoObject when the method that is invoked is marked as `void`.
- Internally the cwrap'd invoke method is defined as returning a `number` which internally will return the result from `mono_wasm_invoke_method` of the driver.  In the case of `void` methods this may contain invalid address reference causing a memory access crash if referenced.
2019-01-22 06:35:11 +01:00
Kenneth Pouncey 5cfcd27534 [wasm] Add two new AOT'd samples targets 2019-01-22 06:25:55 +01:00
Jérôme Laban 920074b55f Fix invalid csharp_space_between_method_declaration_name_and_open_parenthesis 2019-01-21 17:52:12 -05:00
Jérôme Laban 90234bd386 Reformat additions based on editor config file 2019-01-21 17:47:55 -05:00
Jérôme Laban bba2b18202 Adjust editor config based on https://www.mono-project.com/community/contributing/coding-guidelines/#style-guidelines 2019-01-21 17:47:09 -05:00
Martin Baulig 13540da80b [System]: Correctly dispose inner stream in WebResponseStream. #11928. (#12459) 2019-01-21 23:24:57 +01:00
Stephen Toub bce478353a Avoid intermediate strings in some StringBuilder formatting (#22111)
* Avoid intermediate strings in some StringBuilder formatting

Several appends to string builders are first creating strings and then appending those strings, and they're not using the existing Append(primitive) overloads because they want to customize the format string or provider as part of appending the value.  This fixes a few of those cases, using another internal AppendSpanFormattable overload on StringBuilder.

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-01-21 22:36:43 +01:00
Bernhard Urban aa0f15fdca [tvOS] cleanup defines for tvOS (#12539)
Fixes https://github.com/mono/mono/issues/11697
2019-01-21 21:36:06 +01:00
Alexis Christoforides cbfd736864 [configure] Small fix in sigaltstack() checking on cross-compiler case (#12365) 2019-01-21 21:35:49 +01:00
Thays Grazia 5078e23d75 [Debugger] Checking server version before call elapsed_time (#12511)
* The version of the server and client should be bumped to call the elapsed_time.

* Removing extra {

* Calling correctly.

* This should be checked in ThreadMirror.ElapsedTime instead using vm.CheckProtocolVersion (), so calling the public method will fail.
2019-01-21 15:28:12 -05:00
Jérôme Laban 4461e1e6a1 Adjust formatting, add .editorconfig 2019-01-21 12:50:50 -05:00
Jérôme Laban 78ef51b90a Add support for full document path
- Show the full file name in chrome source browser
- Fix support for duplicate file names in different paths
2019-01-21 11:26:12 -05:00
Jérôme Laban 4d4dc12932 Fix "Collection was modified" for pending operations 2019-01-21 11:26:12 -05:00
Jérôme Laban 91909b2b24 Fix NRE for unknown method token for some generated methods 2019-01-21 11:26:12 -05:00
Jérôme Laban 6160337c0f Fixed support for local urls 2019-01-21 11:26:12 -05:00
Jérôme Laban 49fddf283f Add support for mono pdbs, sourcelink 2019-01-21 11:26:12 -05:00
Marek Safar 6fee0c0ad8 [build] Fix netcore build (#12526)
* [build] Fix netcore build

* Fix Mono env parsing for netcore and reduce Task dependencies

* Fix the build
2019-01-21 16:26:51 +01:00
Zoltan Varga 86bae56326 [runtime] Make -Wreturn-type into an error. (#9915) 2019-01-21 08:57:57 -05:00
Zoltan Varga 32e5af52d9 [wasm] Add a --il-strip option to strip IL code from assemblies in AOT mode. (#12529) 2019-01-21 08:41:12 -05:00
Romain Marcadier-Muller 7cd9e0314d [signcode.exe] Allow use of new hash algorithm (#11999)
Enable SHA256, SHA384 and SHA512 hash algorithms to be used for
Authenticode signatures. This enables producing digital signatures that
are trustworthy using the `mono` tooling.

Fixes #7517
2019-01-21 08:29:45 -05:00
Jay Krell 32aa0ad724 [configure] Silently automatically disable Boehm on x86_64-mingw. (#12274) 2019-01-21 08:28:38 -05:00
Zoltan Varga 78be74cc6b [llvmonly] Mixed mode fixes (#12521)
* [llvmonly] Fix dynamic delegate creation in mixed mode.

* [llvmonly] Fix support for virtual calls in mixed mode. Handle calls which end up being not virtual, and add wrappers
for virtual call signatures too.

* [llvmonly] Disable calling aot-ed synchronized methods from the interpreter, it hits an assert in mono_jit_compile_method_jit_only ().
2019-01-21 07:44:47 -05:00
Kenneth Pouncey 18bd1f434d Add hello.exe build target to make file so aot-sample runs. (#12534) 2019-01-21 13:33:54 +01:00
Zoltan Varga 7318005f0c [wasm] Distribute wasm_tools. (#12532) 2019-01-21 07:28:08 -05:00
Marek Safar 65b441964e Move Task factory type to shared partition (dotnet/coreclr#22089)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-21 12:08:53 +01:00
Bernhard Urban 8730101b3c [ios] enable llvm for watch64_32 runtime (#12497)
I lost that change during upstreaming 🙁
2019-01-21 11:12:02 +01:00
Zoltan Varga 99944c65c5 [wasm] Add support for linking out unused icalls in interpreter and aot+interp mode using a new --link-icalls option. (#12512)
* [wasm] Add a 'wasm-tuner' helper tool which is ran during the app build process.
Currently it only supports one option: --gen-icall-table which generates a linked
icall table based on a linked mscorlib.dll.

* [wasm] Add support for linking out unused icalls in interpreter and aot+interp mode using a new --link-icalls option.

This involves the following steps:
- mono --print-icall-table > icall-table.json
- tuner.exe --gen-icall-table icall-table.json linker-out/mscorlib.dll > icall-table.h
- link icall-table.h into the final executable.

The downside is that this requires compiling a new mono.wasm even in interpreter mode.

* Update README.

* Fix thisdir.

* [csproj] Update project files
2019-01-20 22:34:14 -05:00
Ben Adams 82b940f0e0 Use List<T>.ToArray() in places (dotnet/coreclr#22101)
* Use ReadOnlySpan.ToArray in places

* Use List.ToArray

* Don't take .Length in to local and use as loop condition

Signed-off-by: dotnet-bot <[email protected]>
2019-01-21 01:13:34 +01:00
Jan Kotas 4833a124da Cleanup array related FCalls (dotnet/coreclr#22097)
* Cleanup Array FCalls

* Disable outdated CoreFX tests

https://github.com/dotnet/corefx/pull/34700

Signed-off-by: dotnet-bot <[email protected]>
2019-01-20 17:37:51 +01:00
Jan Kotas 698e3cb786 Fix CoreCLR build for changes in shared partition
Signed-off-by: dotnet-bot <[email protected]>
2019-01-20 09:24:44 +01:00
Jan Kotas 3505ee705e Fix build for ProjectN/WinRTInterop Delete superfluous AsyncCausalityTracer arguments
Signed-off-by: dotnet-bot <[email protected]>
2019-01-19 20:39:48 +01:00
Marek Safar 091f7c3fc8 Fix build
Signed-off-by: dotnet-bot <[email protected]>
2019-01-19 20:39:48 +01:00
Miguel de Icaza 917d219d54 [jit] Constant folding for some Math operations on doubles (#9281)
[jit] Constant folding for some Math operations on doubles

This adds support for constant folding of additions and
multiplications of doubles as well as constant folding of Math.Sin,
Math.Cos, Math.Abs and Math.Sqrt.

Inspired by some changes that went into RyuJit:

https://github.com/AndreyAkinshin/aakinshin.net/blob/master/web/_posts/en/2015/ryujit-rc-and-constant-folding.md
2019-01-19 04:45:39 -05:00
Aleksey Kliger 1a965367e5 [netcore] Add an assembly preload hook by parsing TRUSTED_PLATFORM_ASSEMBLIES property 2019-01-19 09:14:44 +01:00
Aleksey Kliger 2037ad6d09 [assembly] for ENABLE_NETCORE load System.Private.CoreLib from preload hook
in mono_assembly_load_corlib, load "System.Private.CoreLib" using the preload
hook, don't bother with the mono assemblies paths
2019-01-19 09:14:44 +01:00
Aleksey Kliger 8c02942689 [netcore] Don't set up mono_defaults.mono_method_message_class
We don't have a MonoMethodMessage in System.Private.CoreLib yet.  Not sure if we need it.
2019-01-19 09:14:44 +01:00
Aleksey Kliger (λgeek) 7f75e05522 [netcore] Small runtime changes (#12503)
* [configure] --with-core should disable remoting, sre.save and appdomains

* [class-init] with ENABLE_NETCORE System.Array has some constant fields

* [object] for NETCORE don't handle appdomain unload exception specially

Since it doesn't exist in System.Private.CoreLib.dll (it's no netstandard.dll)
2019-01-18 23:34:02 +01:00
Aleksey Kliger (λgeek) 58cb6aa49c [netcore] System.Private.CoreLib changes to match runtime expectations. (#12504)
1. Add classes that the runtime depends on:
   * System.Reflection.RuntimeAssembly and System.Reflection.MonoAssembly
   * System.Mono.MonoDomain and System.Mono.MonoDomainSetup
2. Add fields to some classes so they match what `object-internals.h` expect on the native side.
3. Make a non-`abstract` `System.RuntimeType` stub.
   `System.Type` and `System.RuntimeType` need to have fields that match `object-internals.h` and also the runtime wants to create instances of this type and things go wrong if it's abstract.
2019-01-18 23:33:24 +01:00
Alexander Kyte 34cc1abd19 [crash] Place hashes into the json file for all threads 2019-01-18 17:30:28 -05:00
Alexander Kyte 6e80adbe43 [runtime] Don't try (slow) dlopen on android if it doesn't exist (#12074)
On android, the dlopen call will take around 1ms per AOT module we try to load. By not using dlopen with the existence check, we rely on a much slower dlopen check that happens later. I think they support dlopen of non-resolved names.

This might break a few things if we don't use the full path to dlopen. If it does, we should probably add existence checks at the caller, but this will be an optimization that works everywhere.
2019-01-18 22:45:56 +01:00
Alexander Köplinger ee8e8288a6 [System] Fix test compilation on Android 2019-01-18 22:35:25 +01:00
Marek Safar 076b36d662 Merge pull request #12505 from Dotnet-GitSync-Bot/mirror-merge-10019180
Mirror changes from mono/coreclr
2019-01-18 20:19:04 +01:00
Marek Safar 56848baf6a Fix the build 2019-01-18 20:16:04 +01:00
Alexander Kyte c375ef7370 Merge pull request #12053 from alexanderkyte/fixup_aot_probe
[runtime] Add opt-out for AOT file probing with MONO_AOT_MODE_NONE
2019-01-18 13:28:45 -05:00
Marek Safar 2963d731c3 Move AsyncCausality to shared partition (dotnet/coreclr#22062)
* Move AsyncCausality to shared partition

* Set FeatureAsyncCausalityTracer property

Signed-off-by: dotnet-bot <[email protected]>
2019-01-18 18:20:29 +00:00
Aleksey Kliger 278858fe62 [class-init] Allow ghc_slot or finalize_slot == 0
Uninitialized slot values are -1, not 0.

For example GetHashCode could be in slot 0.
2019-01-18 12:26:58 -05:00
Marek Safar 0a86bd4bf7 Fixes build 2019-01-18 16:10:00 +01:00
Stephen Toub 2cd281fae5 Move Environment to shared CoreLib (dotnet/corefx#34654)
Rather than having Environment partially live in corefx and call into an EnvironmentAugments type in CoreLib that in turn calls into an Environment type in CoreLib, we're just moving Environment to live in CoreLib.

To start that, this PR moves Environment and its dependencies from their current locations into the shared CoreLib.  Those changes will mirror over to coreclr.  After that, I'll fix it up to work in CoreLib. And once those changes are built and available back to corefx, I'll update System.Runtime.Extensions to just use the functionality from CoreLib and delete remaining unnecessary code from corefx.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-18 16:10:00 +01:00
Michal Strehovský 3c0c8adbf8 Enable detection of HW intrinsics (dotnet/corert#6836)
I took the liberty of marking the types containing the hardware intrinsics as [Intrinsic] to avoid doing a name check on everything in the system module. It feels like we should take advantage of this attribute in CoreCLR too.

This doesn't actually enable the support because RyuJIT unconditionally disables HW intrinsics for prejit (both CoreRT and CPAOT are considered prejit). We might want to do something about this on the RyuJIT side to address that (for CPAOT, to be able to pregenerate best code possible ahead of time, assuming a fixed ISA; and for CoreRT without JIT, where the concerns about AVX-SSE penalty don't apply). See conversation in dotnet/coreclr#21603

Signed-off-by: dotnet-bot <[email protected]>
2019-01-18 16:10:00 +01:00
Marek Safar 18ca997ac9 Fix defines in TaskAwaiter (dotnet/corert#6846)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-18 16:10:00 +01:00
Filip Navara 292c674043 Split ContractsBCL into separate classes and move them to shared CoreLib (#22006)
* Split up ContractsBCL into separate classes.

* Move remaining Contract, ContractHelper code to shared partition.

* Split ContractHelper to allow custom debugging experience in CoreRT.

* Simplify ContractHelper.InternalContractFailed.

* Use resource loading code from CoreRT.

* Remove unused parameter.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-18 15:36:44 +01:00
Maxim Lipnin 1c4a35efc3 Add TypeConverter fallback to DefaultValueAttribute (#12412)
Requires https://github.com/mono/corefx/pull/235.

Fixes https://github.com/mono/mono/issues/12362.
2019-01-18 15:22:58 +01:00
Alexander Köplinger 4741e44109 Fix tarball build 2019-01-18 14:37:52 +01:00
Atsushi Eno 72d7b3365b [wasm] fix insufficient csc arguments in sample README (#12493)
There would be newer build instruction with msbuild sdks but so far fix current readme.
2019-01-18 13:20:03 +01:00
Aleksey Kliger 9d697e9c5f Don't hardcode "mscorlib" use MONO_ASSEMLBY_CORLIB_NAME or mono_is_corlib_image
Use the MONO_ASSEMBLY_CORLIB_NAME define instead of hardcoding "mscorlib"
everywhere.  If building for netcore, the define is set to
"System.Private.CoreLib" instead.

In some circumstances, a string comparison against assembly->aname.name is used to
check if something is in corelib.  In cases like that, instead use
`mono_is_corlib_image (assembly->image)` instead.  (This introduces a
dependency on mono_defaults.corlib being correctly initialized, so it's
inappropriate for code that runs very early during startup.  Which I checked as
best I could.)

This should fix every use of literal "mscorlib" in the runtime.

This does _not_ fix every use of literal "mscorlib.dll" in the runtime, partly
because some of those uses are in the Framework-specific codepaths in the
loader and it doesn't necessarily make sense to perturb them.
2019-01-17 21:32:14 -05:00
Marek Safar 2c6ec113ff [System.Private.CoreLib] Initial build pass (#12450)
* [System.Private.CoreLib] Initial build pass

* Add temporary files not officialy converted to allow to build the library

* Formatting changes

* master rebase

* Fixes build

* Doc tests update

* Bump API snapshot submodule
2019-01-17 23:25:23 +01:00
Stephen Toub 09e9ffa65e Clean up a few minor Span-related uses (dotnet/coreclr#22038)
Some unnecessary Span to ReadOnlySpan casts.
Some places where new Span(...).Slice(...) can be replaced with AsSpan(...).
Etc.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-17 22:45:03 +01:00
Stephen Toub d4d6122008 Avoid allocations in Utf8Formatter.TryFormat(float/double, ...) (#22011)
* Avoid allocations in Utf8Formatter.TryFormat(float/double, ...)

Currently every call to Utf8Formatter.TryFormat for a float or a double allocates two strings, one for the format string and one for the resulting number.   This avoids those in the common case where we can use float/double.TryFormat and format directly into a stack buffer.  Also removes some unsafe code; the performance of StandardFormat.ToString isn't currently worth the extra nanoseconds gained by using unsafe code.

* Delete assert

There's a test that uses unsafe code to cause this to fail and validate that no exception is thrown.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-17 22:38:25 +01:00
Alexander Kyte b69ae3049e Merge pull request #12058 from alexanderkyte/fixup_aot_paths_host
[runtime] Don't probe aot cache on android
2019-01-17 16:12:42 -05:00
Zoltan Varga 09f3c2b8e1 [llvmonly] Refactor llvmonly runtime support code by moving it to a separate file. (#12436)
* [llvmonly] Move all runtime support code to a new llvmonly-runtime.c file.

* [llvmonly] Make mini_init_delegate () work in mixed mode, it needs to initialize both the interp and the llvmonly related data.

* [llvmonly] Implement EH support in mixed mode.

On interp->native transitions, add a try-catch. On native->interp transitions, rethrow the exception using a c++ throw.

* [llvmonly] Unify function naming, name all llvmonly runtime functions mini_llvmonly_.

* Fix a build failure.

* Fix windows build.

* Fix an aot failure.

* Fix the EH changes.
2019-01-17 13:16:36 -05:00
Marek Safar d864752ea0 Fix AsyncMethodBuilder build on Mono (dotnet/coreclr#22034)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-17 17:51:24 +01:00
Kenneth Pouncey dd5f9b8659 [wasm] Fix crash with delegates. (#12464)
Internally the javascript bridge support uses `System.Delegate` and `System.Delegate.DynamicInvoke` to support delegate callbacks.  The linker, when executed over the assemblies, does not know about this code coverage and will strip out `System.Delegate.DynamicInvoke`.

To fix this:

- Add reference to `System.Delegate.DynamicInvoke` to the `WebAssembly.Bindings` linker xml file so the linker knows not to strip the code.
- Add detailed error messages in case something else goes wrong so the crash is not so cryptic.
2019-01-17 15:43:24 +01:00
Marius Ungureanuandbaulig 6e28675564 Update mcs/class/System/System.IO.Compression/DeflateStream.cs
Co-Authored-By: baulig <[email protected]>
2019-01-17 15:00:25 +01:00
Martin Baulig 5068c7cc13 [System.IO.Compression]: Correctly handle exceptions in inner stream. #12205.
DeflateStream now correctly handles exceptions thrown by it's inner stream and
rethrows them after returning from native code.
2019-01-17 15:00:25 +01:00
Bernhard Urban 5625d51903 [.gitignore] recently added targetwatch64_32 2019-01-17 14:15:39 +01:00
Filip Navara 90ca7ea980 Fix CoreCLR build of AsyncMethodBuilder.
Signed-off-by: dotnet-bot <[email protected]>
2019-01-17 14:15:13 +01:00
Kirill Osenkov 98bfa5d904 Fix https://github.com/mono/mono/issues/12461.
After .NET 4.5 .NET Framework has changed the System.ComponentModel.Composition ReflectionModelServices.IsExportFactoryImportDefinition to not throw.

Updating this to match the .NET Framework behavior.
2019-01-17 12:05:10 +01:00
Ben Adams 19d3a157f4 Reduce steps for string.Contains(string value) (dotnet/coreclr#22008)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-17 09:28:07 +01:00
Marek Habersack eebe4b5285 [Android,AOT] Support dumping AOT offsets with Android NDK r17+ (#12454)
The latest Android NDK releases no longer ship with per-platform C headers.
Instead they ship with a set of unified headers and require the presence of the
`__ANDROID_API__` macro in order to select the target platform.
The AOT offset dumper doesn't support this new layout and this commit changes
that by adding support for the unified headers (without removing support for the
older NDKs) thus fixing the following error when trying to dump the offsets with
newer NDK:

    Processing triple: aarch64-v8a-linux-android
    Error parsing '[...]/mono/mono/metadata/metadata-cross-helpers.c'
    [...]/mono/mono/metadata/metadata-cross-helpers.c(5,10): fatal: 'stdio.h' file not found
    Error parsing '[...]/mono/mono/mini/mini-cross-helpers.c'
    [...]/mono/mono/mini/mini-cross-helpers.c(7,10): fatal: 'stdio.h' file not found
2019-01-16 23:57:01 +01:00
Bernhard Urban c8b6e6a8ff [arm64_32] use emulate OPs so it works with bitcode compiled code for armv7k (#12443)
[arm64_32] use emulate OPs so it works with bitcode compiled code for armv7k
2019-01-16 14:15:48 -05:00
Filip Navara f83d82c76f Move AsyncMethodBuilder to shared. (dotnet/corert#6832)
* Move AsyncMethodBuilder to shared.

* Bring back PROJECTN.

* #if-out TrackAsyncMethodCompletion for CoreRT.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-16 19:53:03 +01:00
Alexander Kyte 78af5ccc19 [runtime] Don't define build config dir on android (#12056)
* [runtime] Don't define build config dir on android

* [runtime] Don't look for files in unset mono_get_config_dir
2019-01-16 12:32:57 -02:00
Alexander Köplinger 230c2a7103 Add .gitignore for mono/tests/llvmonly-mixed 2019-01-16 15:02:53 +01:00
Marek Safar c797248624 [build] Add dotnet launcher bridge to the runtime (#12416)
Initial pass on settings this up (it works but using system Mono assemblies only)

Naming nitpicks are welcomed ;-)
2019-01-16 14:39:23 +01:00
monojenkins 6fabd0fbb7 [bcl] Update BCL Linked Size 2019-01-16 14:35:05 +01:00
Alexander Köplinger a7cf1beb8a Revert "Improve github issue template"
It's actually on purpose so we don't get annoying task progress indicators in the issues list.
2019-01-16 14:21:06 +01:00
Alexander Köplinger 6c2ab0edff Improve github issue template 2019-01-16 14:07:46 +01:00
Kenneth Pouncey 0c4d525eb8 [wasm] Build target fixes (#12418)
- Add linker xml descriptor to WebAssembly.Bindings and WebAssembly.Net.Http
   - The XML linker descriptor will keep the full assembly for these assemblies during link.

- Fix Link Assemblies command line.
   - Miscellaneous fixes for how the assemblies are linked whether they are framework or facades.
   - Add the Facades directory to the resolve paths.
2019-01-16 11:40:37 +01:00
Jan Kotas ed6041b7cf String -> string
Signed-off-by: dotnet-bot <[email protected]>
2019-01-16 09:52:55 +01:00
Marek Safar c404a499ad Move more COM exceptions to shared partition (dotnet/corert#6829)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-16 09:46:53 +01:00
Zoltan Varga 4d57a5786a [wasm] Linker changes. (#12433)
* [wasm] Add support for v8 style options to the packager, i.e. --option/--no-option.

Add a --linker option to turn on linking in interpreter mode.

* [wasm] Add a print-table.py helper script to print out the function table of a wasm module.

* [runtime] Add a --print-icall-table option to dump the icall table as json. Usable for linking the icall table.

* [runtime] Pass the method to the icall table lookup function.
2019-01-16 03:36:13 -05:00
Alexis Christoforides b79a9e7383 [fullaotinterp/fullaotinterp_llvm] Use CoreFX System.IO (#12386) 2019-01-16 10:02:00 +02:00
Miguel de Icaza b748dd14a2 [mini] re-enable LLVM for Linux JIT (#12420)
[mini] re-enable LLVM for Linux JIT

This re-enables the Linux JIT as suggested in https://github.com/mono/mono/issues/12030
2019-01-15 20:15:35 -05:00
Zoltan Varga 12e3cf9f5a [arm] Set the LLVM data layout, without it, opt seems to make incorrect optimizations. (#12429)
* [arm] Set the LLVM data layout, without it, opt seems to make incorrect optimizations.

Fixes https://github.com/mono/mono/issues/12307.

* [x86] Set the LLVM data layout.
2019-01-15 18:57:36 -05:00
Calvin Buckley 324d372168 Bump CoreFX for AIX/FileSystemEnumerator fix (#12375) 2019-01-15 19:40:01 +01:00
Jo Shields 33860df038 Merge pull request #12272 from nealef/context
Cater for later glibc use of ucontext
2019-01-15 11:46:47 -05:00
Jonathan Chambers d0e984aca3 Fix reentrant exception handling. (#12342)
Store handled status in local that is passed into
handler rather than a single thread local value
which can be overwritten in case of reentrance.
2019-01-15 16:56:14 +01:00
Johan Lorensson f4c4372901 Merge pull request #12317 from lateralusX/lateralusX/fix-warning-errors-win64-platform
Fix warning and build errors triggered in win64 platform that doesn't define HAVE_CLASSIC_WINAPI_SUPPORT.
2019-01-15 07:38:20 -05:00
Vlad Brezae 39c8e693f8 [interp] Remove unreachable code (#12411)
We throw exception directly from child frame if the transform phase fails.
2019-01-15 12:59:38 +02:00
Thays Grazia 41eb902535 [Debugger] Debugger failure when field content is assigned by an unsafe value (#12394)
* [Debugger] Debugger failure when a method is called in watches and any field of the Class has the type of the field different of the value of the field because the assign was done in an unsafe way like this:
Now the datatypes check in the fields are only executed when it's not inside an invoke method.
_pinnable = Unsafe.As<Pinnable<T>>(array);
A unit test that reproduces the issue was created either.
Fixes #12374
2019-01-15 07:51:16 -02:00
Zoltan Varga 3e3a2f51dd [wasm] Delete an unused CFLAGS assignment. (#12413) 2019-01-15 04:26:36 -05:00
Tarek Mahmoud Sayed dd9265c8f7 Fix TimeSpan parsing (dotnet/coreclr#21968)
* Fix TimeSpan parsing

* Temporary disabling the failed CI tests

Signed-off-by: dotnet-bot <[email protected]>
2019-01-15 08:57:02 +01:00
Aleksey Kliger 67c5a87ace [threads] Use refcounts for coordinating finalization and detaching
Reverts a29ad08d00 (#9914)

The basic problem we want to solve is the following:
  1. All access to InternalThread:state must be protected by the
     InternalThread:synch_cs mutex
  2. We must destroy the mutex when we are done with the thread.
  3. We don't know which happens later - detaching the machine thread or
     finalizing its InternalThread managed object.

The solution is to replace InternalThread:synch_cs by InternalThread:longlived
which is a refcounted struct that holds the synch_cs.  The refcount starts out
at 2 when the thread is attached to the runtime and when we create the managed
InternalThread object that represents it.
Both detaching and finalizing the managed object will decrement the refounct,
and whichever one happens last will be responsible for destroying the mutex.

This addresses https://github.com/mono/mono/issues/11956 which was a race
condition due to the previous attempt to fix this lifetime problem.  The
previous attempt incorrectly used CAS in mono_thread_detach_internal while
continuing to use locking of synch_cs elsewhere. In particular
mono_thread_suspend_all_other_threads could race with
mono_thread_detach_internal: it expects to take the thread lock and test
thread->state and use the thread->suspended event, while detaching deletes
thread->suspended without taking a lock.

As a result we had a concurrency bug: in suspend_all_other_threads it's
possible to see both the old (non-Stopped) value of thread->state and the
new (NULL) value of thread->suspended.  Which leads to crashes.

---

Background - why we don't know if detaching or finalization happens first.

1. InternalThread normally outlives the machine thread. This can happen because
when one thread starts another it can hold a reference to the fresh thread's
Thread object which holds a reference to the InternalThread. So after the
machine thread is done, the older thread can query the state of the younger
Thread object. This is the normal situation.

2. During shutdown we can have the opposite situation: the InternalThread
objects are finalized first (this happens during root domain finalization), but
the machine threads are still running, and they may still return to
start_wrapper_internal and call detach_internal. So in this case we have an
InternalThread whose finalizer ran first and detach will run second.
2019-01-14 19:29:09 -05:00
Marek Safar 00437dc590 [corlib] Add tracking exception for not object based type hierarchies 2019-01-14 20:38:19 +01:00
lateralusX 4e3ec6540d Review feedback and smaller adjustments to HAVE_API_SUPPORT_WIN32_* defines. 2019-01-14 19:09:18 +01:00
Alexander Kyte 21a0053638 [runtime] Fix jemalloc support (#12388) 2019-01-14 14:59:30 -02:00
Alexander Köplinger 1db473d810 Fix tarball build 2019-01-14 17:48:22 +01:00
Alexander Köplinger 311d1952af [bcl] Embed Source Link information (#12403)
Source Link allows IDEs/debuggers to retrieve a source file from a remote location like GitHub when the local file isn't available.

Specification: https://github.com/dotnet/designs/blob/e55c517a1e7f8dc35b092397058029531209d610/accepted/diagnostics/source-link.md

For now we only embed info about mono, cecil, corefx and corert since that covers 99% of what you usually want to debug and doesn't need fancy logic that reads git submodules and figures out their URLs.

Should enable use cases like https://twitter.com/jlaban/status/1084248087802060801
2019-01-14 15:16:31 +01:00
ShonkyCH b2ec37efde Fix cross compile issue introduced in 5.16 (#12267)
Fix cross compile issue introduced in 5.16

Fixes #9951
2019-01-14 05:35:36 -05:00
Thays Grazia 141bec26a5 [Debugger] Fix crash when there is a generic struct with a field that is an enumerator. (#12368)
* [Debugger]  Debugger crashes when inside a class, there is an internal struct, with a field that is an enumerator.
files.myBucket.GetEnumerator().get_Current().Key
Fixes #10735

* [Debugger] Debugger crashes when there is a generic struct with a field that is an enumerator.
Example: files.get_Current().Key
A unit test that reproduces this crash was added too.
Fixes #10735

* Removing the extra space.
2019-01-14 11:16:20 +01:00
Zoltan Varga 749e93c33c [llvmonly] Mixed mode changes. (#12383)
* [wasm] Add support for llvmonly+interp mixed mode.

* Add new --aot-interp and --aot-assemblies= options to packager.exe.
  The former enables mixed mode, the latter specifies the list of assemblies which will be AOTed.
* Set the proper AOT_MODE and link in interp libraries in the driver when mixed mode is enabled.

* [llvmonly] Add beginnings of support for llvmonly+interp mixed mode. Treat cross assembly calls as possible places where execution can transition to the interpreter.

* [llvmonly] Add mixed mode tests.

* [llvmonly] Return NULL from mono_jit_compile_method_with_opt () if a method is not found in mixed mode, the caller needs to handle it.

* Implement interp entry support for delegate invokes.

* Implement interp entry for virtual calls.

* Implement interp entry in virtual delegate calls.

* Implement interp entry for virtual generic calls.

* Add runtime invoke test.

* [llvmonly] Add a mini_llvmonly_load_method () helper function to reduce the amount of duplicated code.

* [llvmonly] Add a mini_llvmonly_load_method_delegate () helper function.

* Fix the checked build.
2019-01-14 05:15:16 -05:00
Zoltan Varga 1291c08c1d [runtime] Revert part of fc5800b30d, it breaks ios, which seems to have AppDomain.Unload (). (#12398) 2019-01-12 10:06:54 -05:00
Zoltan Varga fc5800b30d [runtime] Disable more code on wasm. (#12379)
* [runtime] Add a 'cleanup' --enable-minimal option to disable the shutdown cleanup code on platforms which don't need it. Enable it on wasm.

* [wasm] Disable mdb support in the device runtime.

* [runtime] Disable appdomain creation/unload icalls if DISABLE_APPDOMAINS is set.
2019-01-11 17:53:02 -05:00
Zoltan Varga 9047295678 [runtime] Register the GC alloc icalls during startup instead of on-demand, since create_allocator () might not be called at runtime in llvmonly mode if the generated code directly calls its wrapper. (#12381) 2019-01-11 17:25:30 -05:00
Stephen Toub 73b2c87dee Add missing overrides to SyncTextWriter (dotnet/coreclr#21956)
Several recently added virtuals to TextWriter were missing overrides on SyncTextWriter.

We were missing overrides of the synchronous `Write(ReadOnlySpan<char>)` and `WriteLine(ReadOnlySpan<char>)` overloads.  The impact here is primarily performance, though it'll still be an observable change in corner-case scenarios: rather than using the base implementation which would copy the span to an array and then invoke the properly overridden array-based Write{Line} methods, it'll now just delegate to the wrapped span methods.  So it calls the correct overload now on the wrapped instance, and saves some cost in the process.

We were also missing overrides for the async `WriteLineAsync()`, `WriteAsync(ReadOnlyMemory<char>, CancellationToken)`, WriteLineAsync(ReadOnlyMemory<char>, CancellationToken)` overloads.  Fixing these doesn't change the overload that's invoked on the wrapped writer, but it does cause the calls to become synchronous rather than queue a task that in turn calls the synchronized overload.  Whether the new behavior is better is arguable, but it keeps it consistent with every other XxAsync method on SyncTextWriter, which in my opinion is more important... if we wanted to alter the behavior for all of the XxAsync methods, we should do it for all of them.

Also, in the StringBuilder-based overrides, we were ignoring cancellation.  And in the recently added DisposeAsync, we should follow-suit with the rest of the async APIs and make it synchronous.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-11 23:17:52 +01:00
Zoltan Varga f14c5ca370 [wasm] Don't make aot-dummy.dll an output of the linker. (#12380) 2019-01-11 14:57:59 -05:00
Eberhard Beilharz 7952489bd2 [swf] Fix dispose of panels in StatusBar (#12355)
This change implements disposing of the panels of a status bar.
2019-01-11 13:21:28 +01:00
monojenkins 1e0bb426c7 [csproj] Update project files 2019-01-11 11:55:09 +01:00
Katelyn Gadd cc73cba992 Rearrange sources files to work around limitations of gensources/xtest integration 2019-01-11 11:55:09 +01:00
Katelyn Gadd b6d5b0e093 Disable the named pipe tests on win32 due to OnNativeIOCompleted issue (7500?) 2019-01-11 11:55:09 +01:00
Katelyn Gadd 6d7167f2f6 Ignore enotconn error results from the socket shutdown API 2019-01-11 11:55:09 +01:00
Katelyn Gadd 5834d7acc6 Move UnixDomainSockets pipe test to only run on linux net_4_x since it seems like it basically will only work there 2019-01-11 11:55:09 +01:00
Katelyn Gadd 1199c999ab Disable two test files for issue #12324 2019-01-11 11:55:09 +01:00
Katelyn Gadd c36000e83b Exclude unix domain socket tests from wasm profile 2019-01-11 11:55:09 +01:00
Katelyn Gadd 31a7a3ff29 Split unix build profile sources file out 2019-01-11 11:55:09 +01:00
Katelyn Gadd dd9160a464 Don't throw in pipestream's finalizer. Include named pipe support in the build profile. 2019-01-11 11:55:09 +01:00
Katelyn Gadd c5decd8c09 Throw an argument out of range exception when a pipe name is too long and specify which argument is out of range. Fixes a corefx test. 2019-01-11 11:55:09 +01:00
Katelyn Gadd 71e7273634 Enable named pipe tests 2019-01-11 11:55:09 +01:00
Katelyn Gadd 26b12f68ff Enable geteuid and seteuid so csc compiler server works 2019-01-11 11:55:09 +01:00
Zoltan Varga 141e1e48a5 [wasm] Compile the wasm runtime using optimization. (#12367) 2019-01-11 04:39:11 -05:00
Stephen Toub 4ff1c28c3f Add WithCancellation for async enumerables (dotnet/coreclr#21939)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-11 10:13:43 +01:00
Vlad Brezae 60d34d95c7 [interp] Fix resuming into interp when finally throws exception (#12328)
We might need to adjust the ip in the same fashion when normally resuming to catch handler.

In the example from the testcase, we have these transitions : ... -> interp_frame -> jit -> eh1 -> interp_frame -> eh2. When eh1 unwinds to call the finally clause from interp_frame it also pops all other lmf entries until there. This means that eh2 thinks it was called directly from the interp_frame (as it would happen with the jit), but in this case there are still the jit frames in the middle. Eh2 doesn't know how to resume over the jit frames, it will just set the resume state to the interp_frame and eh1 will do the resuming over the jitted frames, after run_finally returns gracefully. If the exception were to be handled by frames parent to interp_frame and there are also pushed contexts on the lmf stack, then eh2 could both unwind and resume directly there, skipping eh1 and the jitted frames altogether.
2019-01-11 09:44:04 +02:00
Marek Safar d8690f8f83 Move public interface ISymDocumentWriter to shared location (#21931)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-11 08:15:57 +01:00
Alexis Christoforides bae33bb447 Bump corefx 2019-01-10 16:08:48 -05:00
Marek Safar 5ba3db2155 Move COMException to shared partition (dotnet/corert#6803)
* Move COMException to shared partition

* Review feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-01-10 22:02:45 +01:00
Marek Safar 56e0b9448b Moves EnvironmentVariableTarget enum to shared partition (#21930)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-10 19:07:21 +01:00
monojenkins ab184eb52a [csproj] Update project files 2019-01-10 18:09:26 +01:00
monojenkins 753eaf9641 Bump API snapshot submodule 2019-01-10 18:09:26 +01:00
Maxim Lipnin 7e737e7cc4 Fix unrelated build issues 2019-01-10 18:09:26 +01:00
Maxim Lipnin 45fdf3d7f7 Bump corefx 2019-01-10 18:09:26 +01:00
Ben Adams d9389fa2e1 Move restoring ExecutionContext out of generic methods (#21909)
* Move restoring ExecutionContext out of generic methods

* Move one back

Signed-off-by: dotnet-bot <[email protected]>
2019-01-10 17:13:24 +01:00
Alexander Köplinger a707496149 Bump bockbuild 2019-01-10 16:30:35 +01:00
Kenneth Pouncey 1690b225ec [wasm] Cleanup Framework Bindings and HttpMessageHandler code. (#12326)
* Cleanup Framework Bindings and HttpMessageHandler code.

- move to framework folder to match package structure.  Simplifies packager code finding the framework libraries.
- create solution and project files
- split up the `bindings.cs`, now removed, into multiple files and reformat code
- Clean up xml documentation
- generate xml file documentation on build.
- modify make file to build the solution and modify tests to use framework output.
- modify `packager` to use the correct directory structure.
- modify `sdk` build targets.
- modify `package` target to package the correct assemblies along with source projects and solution.

Tested:

- JavaScript shell tests which run in jenkens
- Browser Tests
- AOT build and tests

* Modify projects to be netstandard instead of framework.

- use dotnet instead of msbuild which is not available.
- Modify test builds

* Fix Sdk.props to point to correct Bindings library path

* Fix build dependencies

* Fix AOT build - duplicate assembly key

* Fix package target
2019-01-10 15:53:05 +01:00
Martin Baulig edaa62f3a1 Misc AppleTls / BTLS exception and error check changes. (#12319) 2019-01-10 14:50:15 +01:00
monojenkins 59aa49b441 [bcl] Update BCL Linked Size 2019-01-10 13:37:11 +01:00
Alexander Köplinger a037a97cdf [Mono.Debugger.Soft] Keep existing crash files in Crash() test
Instead of deleting all, only delete the ones created by the test.
2019-01-10 12:28:39 +01:00
Levi Broderick baa8cf7312 Move OperationStatus into shared source (dotnet/coreclr#21912)
This is the first step to moving OperationStatus from corefx into coreclr. It'll be used by the transcoding APIs which live in System.Private.CoreLib.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-10 10:41:03 +01:00
Alexis Christoforides bb84dad457 [corlib] Fix monodroid build to reinclude CoreFX System.IO (#12057)
* [corlib] Fix monodroid build to reinclude CoreFX System.IO

* [corlib] Fix orbis and unreal builds to reinclude CoreFX System.IO

* [Mono.Native] Build on Android

* [csproj] Update project files

* Bump API snapshot submodule
2019-01-09 20:21:56 -05:00
Bernhard Urban ccc88a9971 [interp] use interp_lmf wrapper for interp2native on platforms with wonky sigcontext (#12293)
[interp] use interp_lmf wrapper for interp2native on platforms with wonky sigcontext

On some platforms (e.g. AppleTV) SigContext is available, but isn't as
precise as we would like to have it. For example, it doesn't save
callee-saved registers and thus aren't restored properly.

Unfortunately, this also means we can't use the fastpath for
interp2native, so we disable it on those platforms.


Needs backport to: 2018-08, 2018-10, 2018-12
2019-01-09 17:55:39 -05:00
Thays Grazia cb77514a94 [Debugger] Crash test (#12304)
* Changing the test behavior as discussed with Ludovic, because we already have knowledge about the unreliability of the crash reporter and the test is not about it.
So if in 10 times at least one of them works for now it's good.
Fixes #11385

* Removing extra message.

* Removing the crash log file after the test is finished.
2019-01-09 17:31:32 -02:00
Kenneth Pouncey cb16759b8a [wasm][ci] Re-enable chakra tests (#12332)
Re-enables the chakra tests now that the upstream jsvu issue was fixed.

Fixes https://github.com/mono/mono/issues/12331
2019-01-09 20:20:25 +01:00
Jan Kotas 0a8c290c5b More DispatchWrapper tweaks
Signed-off-by: dotnet-bot <[email protected]>
2019-01-09 18:42:49 +01:00
Marek Safar 0f107837c0 Removes PNSE version of DispatchWrapper and keep only single version with ifdef
Signed-off-by: dotnet-bot <[email protected]>
2019-01-09 18:42:49 +01:00
Jan Kotas 4114852a8b Delete files moved to shared partition
Signed-off-by: dotnet-bot <[email protected]>
2019-01-09 18:42:49 +01:00
Aleksey Kliger 59f6251897 [coop] Move mono_threads_is_blocking_transitions_enabled to header
and make inline
2019-01-09 10:43:19 -05:00
Aleksey Kliger 99eeaab909 [coop] Drop support for MONO_ENABLE_BLOCKING_TRANSITION env var
It was never documented and it is not as useful now with a matured hybrid
suspend.

If MONO_ENABLE_BLOCKING_TRANSITION set, and mono is otherwise configured to use
preemptive suspend, the thread state machinery would perform RUNNING->BLOCKING
transitions (ie: MONO_ENTER_GC_SAFE and friends would be more than no-ops), but
still preemptively suspend every thread.  This was useful for testing the
thread transitions separately from the coop suspend details.
2019-01-09 10:43:19 -05:00
Zoltan Varga a19f9d869d Bitcode mixed mode work. (#12312)
* [llvmonly] Avoid generating/loading trampolines in llvmonly+interp mode.

Add a new execution mode MONO_AOT_MODE_LLVMONLY_INTERP and make --llvmonly-interp use that. INTERP_LLVMONLY defaults to the interpreter, while LLVMONLY_INTERP defaults to aot.

* [llvmonly] Save whenever a method has a gsharedvt variable signature into the aot image and use that instead of looking up its MonoJitInfo, which is a perf problem since its done for all methods.

* Add a case to append_mangled_wrapper_subtype ().

* [llvmonly] Move initialization of delegate->method_ptr to mini_init_delegate (), pass a handle to the callback.

* [llvmonly] Allow --regression to work in mixed mode.

* [llvmonly] Set param names for gsharedvt in/out wrappers.

* [llvmonly] Use the dedup mangler for setting method names for gsharedvt in/out wrappers, shorten the names a bit.

* Revert "[llvmonly] Allow --regression to work in mixed mode."

This reverts commit d7838c1ce7dc0e3d7bfc3c7f01214224f561db90.

* Fix c++-isms.
2019-01-09 15:23:58 +01:00
Kenneth Pouncey 1be89d440c [wasm] Fix build target errors (#12314)
- Fix different errors when building via the nuget instead of locally.
- The nuget generated had a different structure so fixed the output generation to work for both local build as well as nuget build.
- Fix problem with the monolinker.exe not being located correctly.
- Move the monolinker.exe to tools directory within nuget.
2019-01-09 15:20:35 +01:00
Alexander Köplinger a947358007 Disable Chakra tests on wasm
https://github.com/mono/mono/issues/12331
2019-01-09 13:55:05 +01:00
Tomas Weinfurt c6b7d04096 fix DateTime overflow on ARM32 (dotnet/coreclr#21902)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-09 12:47:28 +01:00
Marek Safar 7897436a7e Moves common COM type to shared corelib partition (dotnet/corert#6782)
* Moves common COM type to shared corelib partition

* Moves GetHRForException to PInvokeMarshal

* Add temporary CORECLR ifdef to ArrayWithOffset

* Apply cleanup from CoreCLR

Signed-off-by: dotnet-bot <[email protected]>
2019-01-09 10:01:33 +01:00
Stephen Toub c7785160c0 Expose string.Concat(ReadOnlySpan, ...) (dotnet/coreclr#21882)
* Expose string.Concat(ReadOnlySpan, ...)

* Add String.Empty fast path to string.Concat(ReadOnlySpan, ...)

Signed-off-by: dotnet-bot <[email protected]>
2019-01-09 09:45:59 +01:00
Alexander Köplinger d8c75df45b Fixup wasm build
We need to also purge any changes done by emsdk
2019-01-09 01:57:20 +01:00
Alexander Köplinger 2bb95a4990 [wasm] Fix build when emsdk repo is dirty
We hit the following issue when the upstream repo receives a new commit:

```
16:11:49 error: Your local changes to the following files would be overwritten by merge:
16:11:49     binaryen-tags.txt
16:11:49     emscripten-tags.txt
16:11:49     upstream/lkgr.json
```

To workaround we now clean the emsdk repo before pulling.
2019-01-08 18:40:15 +01:00
lateralusX 4486952c2f Fix build error when doing MSVC build wihtout cygwin not having a config.h. 2019-01-08 15:01:48 +01:00
Martin Baulig 78cca25b44 Move ENABLE_GSS conditional into System; fixes #12263. (#12303)
Should fix #12263.
2019-01-08 14:33:38 +01:00
lateralusX 46a1c80a41 Fix warnings and build errors when bumping Mono on alternative Windows platforms.
Several of the name changes fixes MSVC warnings where local variables
hides global variables using the same name.

Number of adjustments not building on platforms not defining HAVE_CLASSIC_WINAPI_SUPPORT.

Fix a couple of build projects not setting dependencies on build-init.vcxproj.
This could cause races in build order if projects depend on build initialization.

Added support to force external builds to use msbuild even if ninja is present.
2019-01-08 14:06:14 +01:00
Thays Grazia 0b6eff6ed4 [debugger] Fix test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter (#12114)
The problem was in this line:
ss_nested_with_two_args(ss_nested_arg (), ss_nested_arg ());
The first step_into works correctly entering in the ss_nested_arg method, but the second one doesn't work.
The problem was because this flag MONO_SEQ_POINT_FLAG_NONEMPTY_STACK was set, so the debugger don't consider that it was a possible break.
The solution of the issue was create another flag to identify nested calls and ignore the  MONO_SEQ_POINT_FLAG_NONEMPTY_STACK.
2 new tests were added to test other nested calls.
#Fixes 7326
2019-01-08 09:47:04 -02:00
Dan Moseley b9e209fc93 Fix path length 255 (dotnet/coreclr#21838)
* Fix path length 255

* Fix assert

* Dead code

Signed-off-by: dotnet-bot <[email protected]>
2019-01-08 08:40:23 +01:00
Jan Kotas de75ac8c6f CoreRT updates for files moved to shared partition
Signed-off-by: dotnet-bot <[email protected]>
2019-01-08 08:40:23 +01:00
Marek Safar 84d992cfd7 Moves ComTypes to shared partition (dotnet/coreclr#21861)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-08 08:35:32 +01:00
monojenkins 07dc55c8c4 [bcl] Update BCL Linked Size 2019-01-08 08:29:43 +01:00
Zoltan Varga fea1723e40 [wasm] Enable Mono.Native. (#12143)
* [wasm] Add stubs for a few functions needs by System.Native.

* [wasm] Enable Mono.Native.

* Enable Mono.Native in the mono build.
* Link libmono-native.a into the interpreter/aot builds.
* Add a dlopen fallback to driver.c to allow the runtime to look up the pinvoke declarations.

* [wasm] Enable direct pinvokes for AOT, disable the dl fallback in AOT mode, its not needed since the generate code links directly to the Mono.Native symbols.

* [wasm] Disable more corlib tests for wasm.

* [wasm] Enable running corlib tests on CI.

* [wasm] Pass -D_WASM_ to the Mono.Native build.

* Fix line numbers in stack frame tests.

* Revert "[wasm] Enable direct pinvokes for AOT, disable the dl fallback in AOT mode, its not needed since the generate code links directly to the Mono.Native symbols."

This reverts commit 2d2ba5261c6fa0b6c1c110d53f18c4248c11cdff.

Direct pinvokes need more support since it needs to link against objc-libs, btls, etc.

* [csproj] Update project files
2019-01-07 19:00:17 -05:00
Aleksey Kliger (λgeek) 988f4a2147 [mini] Use C++ linker iff building C++ that needs the C++ runtime (#12266)
* [mini] Use C++ linker iff building C++ that needs the C++ runtime

(This has nothing to do with --enable-cxx.  This is about our LLVM .cpp files).

Explicitly set the linker for libmini.  The issue is that the automatic
linker selection (See
https://www.gnu.org/software/automake/manual/html_node/How-the-Linker-is-Chosen.html)
looks at all the _SOURCES for a target, even those that are only
conditionally added, even if the condition is false.  So because we sometimes
build mini-llvm-cpp.cpp we always get the c++ linker.  But that's not what we
want.

The goal is:
 - if there's any C++ code included into mono (either the shared lib or a
   program) that needs the C++ runtime library, ensure that we link using the C++
   linker.  This was already true, we just need to make sure it stays true.
 - if mono is built in such a way that it has no C++ code in it (that needs the
   C++ runtime library), ensure that we link with the C linker and without
   including the C++ runtime library.
   This will address issues like https://github.com/mono/mono/issues/12060

We do this in two steps:

1. We split out all the c++ source code to libmini-cxx.la and include that into
   libmini.la.

   That's enough to force C++ linking if libmini-cxx.la has any code in it.  If
   there's no C++ code (right now that means there's no --enable-llvm or
   --enable-llvm-runtime), we don't add libmini-cxx.la and all the C source in
   libmini links in the normal manner.

2. We have a hack where we sometimes include libmono.a (the static library)
   into the mono executable.  In that case, we could forget about the C++
   linker (which leads to build failures because llvm uses all the C++ runtime
   library stuff that we forgot to link in).

   So we use the "nodist_EXTRA_..._SOURCES=dummy.cpp` hack to make it look like
   the mono executable has C++ source, which in turn forces the use of the C++
   linker.

   The conditional logic here has to match exactly what we do for deciding
   whether to add libmini-cxx.la into libmini.la.  If we do, then force the use
   the C++ linker here.

   It may seem like another option is to use something like
   `mono_boehm_LINK=$(CXXLINK)` to set a target-specific linker.  But this is
   bad, actually, because in that case we will drop the `..._LDFLAGS` and other
   linker flags unless we're very diligent to include all of them.  The
   `nodist_EXTRA_..._SOURCES` hack is more resilient because automake will
   ensure that all the flags are kept.

* [llvm,wasm] Don't add -lstdc++ in llvm_config.mk

Leave it to the linker.

This is needed when building wasm cross compilers for windows which pass
-static-libstdc++ to configure.  As a result we would get duplicate symbols by
linking against a static libstdc++.a and also the export stubs of libstdc++.dll

In mini, link monow using the C++ linker same as with mono by using the nodist_EXTRA_..._SOURCES
trick.

In wasm, pass -static-libstdc++ to CXXFLAGS, not LDFLAGS.  c++ linking picks up
CXXFLAGS anyway, and -static-libstdc++ has no effect on the C linker and it
doesn't affect explicit -lstdc++ flags anyway.
2019-01-07 17:51:31 -02:00
Marek Safar 65a2c8a396 Moves StackTrace to shared partition (dotnet/coreclr#21757)
* Moves StackTrace to shared partition

* Remove obsolete comment

* StackFrame::GetFileName behaves like property, remove SecurityException

* Adjust CoreRT ifdefs, fix names for consistency

Signed-off-by: dotnet-bot <[email protected]>
2019-01-07 18:45:48 +01:00
Bernhard Urban 333ad864c4 [ios] initial watch64_32 support (#11691)
* [ios] initial watch64_32 support

* align iOSSimulatorTemplate with iOSDeviceTemplate
2019-01-07 14:56:42 -02:00
Zoltan Varga 7d746ac405 [aot] Delete the automatically created temporary directory when using --aot=llvm. (#12294) 2019-01-07 11:37:43 -05:00
Jay Krell ad3a9fbba8 [Coop] Convert and cleanup open/create of named mutex/event/semaphore. (#12002)
* [Coop] Convert System.Threading.Semaphore.
Potential handles are avoided through fixed, but error path converting utf16 to utf8 is introduced.

* [Coop] Cleanup System.Threading.Mutex. Replace gchandle pinning with C# fixed.

* Remove two commented out lines that are not likely to materialize.

* [Coop] Cleanup System.Threading.NativeEventCalls. Replace gchandle with C# fixed.

* Don't assume ves_icall_System_Threading_Semaphore_ReleaseSemaphore_internal output is to stack.
2019-01-07 10:51:10 -05:00
Alexis Christoforides 96259e2b30 [tests] Remove an invalid assertion on System.IO.DriveInfo
All fixed drives are not guaranteed to be ready
2019-01-07 08:21:29 -05:00
Kenneth Pouncey 749a0825c3 [wasm] Fix build targets errors
- The "WasmLinkAssemblies" task could not be loaded from the assembly
2019-01-07 10:55:27 +01:00
Zoltan Varga 4d9bba73a2 Bump corefx to pick up wasm build changes. 2019-01-07 10:11:58 +01:00
Jan Kotas 1bd557004e Delete redundant S.R.InteropServices.PInvokeMap and S.R.InteropServices.PInvokeMarshal (#21831)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-07 09:42:38 +01:00
Ben Adams 18c632ed43 Maintain left.Equals(right) order for equality for compat (#21829)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-06 10:11:18 +01:00
Ben Adams 453de54075 (C#7) Use pattern matching is rather than as with null check (#21828)
* Use pattern matching `is` rather than `as` with null check

Signed-off-by: dotnet-bot <[email protected]>
2019-01-06 10:11:18 +01:00
Ben Adams d2fbbb9633 Remove redundant unsafe contexts (dotnet/coreclr#21826)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-06 09:52:56 +01:00
Mikayla Hutchinson 5abcf78484 [Wasm] Fix build targets packaging 2019-01-05 10:33:49 +01:00
Vlad Brezae ec1510e35f [exceptions] Always process self aborts even if we have one pending (#11927)
[exceptions] Always process self aborts even if we have one pending

For example, in the following code, the abort that ends the thread should be the one thrown from the finally block instead of the try block :

```csharp
try {
	Thread.CurrentThread.Abort ();
} finally {
	Thread.CurrentThread.Abort ();
	Console.WriteLine ("Why are you still here ?");
}
```
2019-01-04 19:25:33 -05:00
Jo Shields 0623e93aee Merge pull request #12271 from directhex/fix-configure-on-old-autoconf
Add explicit no-op to RISC-V FPU detection, to fix old Autoconf (RHEL 6)
2019-01-04 16:16:24 -05:00
Ben Adams 4c8bfc6555 Support faster null checks (dotnet/coreclr#21765)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-04 21:05:29 +01:00
Stephen Toub bef2df9ed6 Add StringExtensions.Concat to fix Microsoft.IO.Redist assembly
Signed-off-by: dotnet-bot <[email protected]>
2019-01-04 20:59:20 +01:00
Neale Ferguson ed617f19ca Missing include 2019-01-04 13:36:42 -05:00
Neale Ferguson 5595d6c611 Cater for later glibc use of ucontext 2019-01-04 13:33:14 -05:00
Jo Shields e978b049a7 Add explicit no-op to RISC-V FPU detection, to fix old Autoconf (RHEL 6)
Apparently, on old versions of Autoconf, a AC_TRY_COMPILE block with an
empty action-if-true block, like:
```
        if test x$fpabi = xauto; then
                AC_TRY_COMPILE([], [
                        #ifdef __riscv_float_abi_double
                        #error "double"
                        #endif
                ], [
                ], [
                        fpabi=double
                ])
        fi
```
emits invalid shell code, like:
```
  (exit $ac_status); } && {
         test -z "$ac_c_werror_flag" ||
         test ! -s conftest.err
       } && test -s conftest.$ac_objext; then

else
```

`else` immediately after `then` is not valid.

This construct is fine on newer versions, where `then :` is used, which
does not count as invalid.

Even though we're not building for CentOS 6 RISC-V, the invalid shell
causes the configure script to fail entirely, e.g. https://jenkins.mono-project.com/view/Releases/job/ng-release-generate-rpm-packages/963/execution/node/142/log/

Add a useless action-if-true which won't affect the program flow, but
means we aren't emitting `then else` on old Autoconf.
2019-01-04 12:39:54 -05:00
Marek Habersack 60e1a3a63f [Android] Fix build with NDK r18 (#11016)
Xamarin.Android is looking to switch to using the latest Android NDK, r18.
However, there are a few build issues in Mono and BTLS which need to be
addressed before that happens.

  * BTLS fails to build some ARM assembly sources with NDK r18's clang.
    https://github.com/mono/boringssl/pull/12 fixes this issue

  * BTLS uses obsolete Android cmake toolchain file.
    Add a configure option to set alternative toolchain file.

  * NDK r18 minimu supported API level is 16.
    This commit makes the API level configurable and sets the minimum platform
    to API 16

  * NDK r18 makes changes to declaration of `mmap` which break Mono build.
    Detect NDK version in `mono-compiler.h` and act accordingly (do not
    redeclare `mmap`)

  * NDK r18 doesn't have `cpp` and SDKs build assumes it's present.
    Detect whether `cpp` is present and, if not, use `compiler -E` instead.

  * NDK r18 uses unified headers exclusively and requires __ANDROID_API__ to be
    set in order to present the correct set of native APIs.
    SDKs now define the macro when the `ANDROID_NEW_NDK` Make variable is set to
    anything else than `no`.
2019-01-04 11:58:14 -05:00
Aleksey Kliger (λgeek) 32074d1698 [coop] Add high level suspend policy accessors (#12116)
- mono_threads_suspend_policy_name
- mono_threads_suspend_policy_are_safepoints_enabled
- mono_threads_suspend_policy_is_multiphase_stw_enabled
- mono_threads_suspend_policy_is_blocking_transition_enabled

The normal accessors (mono_threads_are_safepoints_enabled, etc) just apply the
policy acessors to the current policy
2019-01-04 11:36:05 -05:00
Vlad Brezae f562e59d98 [sgen] Fix debug build (#12067) 2019-01-04 12:24:46 -02:00
Kenneth Pouncey 646515fd35 [wasm] Allow creation of JavaScript Objects. (#11970)
- Allow creation of JavaScript objects without resorting to json parsing and creating hooks.
- Small cleanup of the bindings routines.
- Modify WasmHttpMessageHandler to use new routines and take out the hackish calls.
2019-01-04 13:42:07 +01:00
Egor Bogatov 98b7d35110 Undo changes in ConditionalWeakTable.cs (#12261)
* undo cwt ns21

* implement AddOrUpdate
2019-01-04 12:25:00 +01:00
Mikayla Hutchinson 5f890cede3 Add WebAssembly MSBuild targets (#12221) 2019-01-04 11:51:37 +01:00
Bernhard Urban 21d77b319a [amd64] fix --enable-minimal=jit build (#12265) 2019-01-04 09:42:52 +01:00
Stephen Toub e2ecfe2410 Use ValueStringBuilder instead of StringBuilderCache in PathInternal.Windows.cs
Signed-off-by: dotnet-bot <[email protected]>
2019-01-04 09:29:04 +01:00
Egor Bogatov 6db483c371 Eliminate some bounds checks in Path (dotnet/coreclr#21721)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-04 09:29:04 +01:00
Marek Safar 6e11c95a84 Adds portable version of EncodingTable (dotnet/coreclr#21735)
* Adds portable version of EncodingTable

Most of the implementation is extracted from CoreRT

* Use string comparer directly

* Remove no longer used COMNlsInfo

* Adds localization support

* Removes FeatureCoreFxGlobalization configuration

* Remove redudant encodings look up from GetEncoding

* Keep Hashtable for nameToCodePage as it does not lock on read

* Replace locked dictionary lookup with short switch

* Include comment with msbuild task link used to generate the data file

Signed-off-by: dotnet-bot <[email protected]>
2019-01-04 09:29:04 +01:00
Stephen Toub 011610e440 Improve performance of Path.ChangeExtension (dotnet/coreclr#21766)
In the common case where it need to replace a non-empty extension with a non-empty extension, it currently incurs a substring without the original extension prior to then concatenating with the new extension.  This PR avoids that.

(As the Path implementation is in corelib, this uses string.FastAllocateString and then formats into it with a span; if we wanted to avoid that, string.Create could also be used.)

* Add internal String.Concat overloads for spans

* Use span-based string.Concat overloads in several places

Signed-off-by: dotnet-bot <[email protected]>
2019-01-04 09:29:04 +01:00
Stephen Toub d3747f620b Reduce allocation in Index/Range.ToString (dotnet/coreclr#21755)
* Reduce allocation in Index/Range.ToString

* Address PR feedback

Signed-off-by: dotnet-bot <[email protected]>
2019-01-04 09:16:57 +01:00
Martin Baulig e8f15493be Merge CoreFX with dotnet/release/2.2 (#11913)
* Trying to merge CoreFX with dotnet/release/2.2

* Disable some System.IO tests

* fix wasm build

* fix fse.notsupported

* Bump API snapshot submodule
2019-01-04 09:10:58 +01:00
Alexander Kyte 84276a51f7 [runtime] Enable interpreter to be used with --enable-minimal=jit (#12080)
[runtime] Enable interpreter to be used with --enable-minimal=jit
2019-01-03 15:45:43 -05:00
Aleksey Kliger (λgeek) 3a4b2b4a32 [coop] Make sure suspend_count is positive in suspend request states (#12241)
* Fix bug in pulse transition - the suspend count was lost and incorrectly
  swapped to 0.
* finish_async_suspend transition - add assertions that the suspend count is
  positive. Try to catch incorrect states sooner.

Fixes https://github.com/mono/mono/issues/12235
2019-01-03 11:23:13 -05:00
Vlad Brezae 1b242b8960 [interp] Fix resuming into interp frame during EH (#12092)
[interp] Fix resuming into interp frame during EH

During EH, we can have the same frame twice on the stack, the original one and when invoking clauses in the same frame from EH. When having a resume state, we need to check if we should catch it in the current frame, or the original.

<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-01-03 10:05:57 -05:00
Marek Safar 5b220bf1dc Updates codeowners 2019-01-03 15:17:27 +01:00
Jan Kotas ec9d78627d Cleanup current culture handling in the unmanaged runtime (#21706)
Large portion of the current culture handling in the unmanaged runtime inherited from desktop has been no-op. The nativeInitCultureAccessors QCall that it used to depend on desktop got (almost) never called in CoreCLR.

- Delete resetting of current culture on threadpool threads. It was needed in desktop because of a very tricky flow of current culture between appdomains. It is superseded by the flowing the current culture via AsyncLocal in CoreCLR.
- Comment out fetch of managed current culture for unmanaged resource lookup. It has number of problems that are not easy to fix. We are not localizing the unmanaged runtime currently anyway, so it is ok to just comment it out.
- Fix the rest to call CultureInfo directly without going through Thread.CurrentThread

Signed-off-by: dotnet-bot <[email protected]>
2019-01-03 15:06:47 +01:00
Stephen Toub 40ec59d65b Replace string.Format(SR. with SR.Format(SR. (dotnet/coreclr#21763)
We use SR.Format in almost all places where we format resource strings (without a format provider), but there were a few stragglers.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-03 09:58:07 +01:00
Stephen Toub 61530694c8 Change a couple string.Replace("a", "b") to string.Replace('a', 'b') (#21768)
The latter is functionally the same but less overhead.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-03 09:58:07 +01:00
Stephen Toub 4e16ade794 Use StringBuilderCache in PathInternal.NormalizeDirectorySeparators (#21760)
When we do need to normalize, we're currently allocating the StringBuilder/char[] for the full path length.  As long as the path length is less than the max cacheable size (360), we'll now use a cached builder.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-03 09:44:24 +01:00
Marek Safar 91ca78d698 Additional ifdef changes which are ES_BUILD_STANDALONE specific for System.Diagnostics.Tracing (#21748)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-02 23:08:47 +01:00
Stephen Toub c2a5e933bd Replace Array.Copy(src, dst, int) calls with Array.Copy(src, 0, dst, 0, int) (#21756)
The former calls GetLowerBound(0) on both src and dst, which is unnecessary when the arrays are T[] and thus always have a lower bound of 0.

Signed-off-by: dotnet-bot <[email protected]>
2019-01-02 23:08:47 +01:00
Alexander Kyte 227e7119b7 Merge pull request #12126 from alexanderkyte/telemetry_blob
[crash] Support extra merp params
2019-01-02 12:14:35 -05:00
Jay Krell 6a9d38a2cb Change array construction with rank>4 to use not use varargs -- localalloc. (#12213)
* Change array construction with rank>4 to use not use varargs -- localalloc.
This fixes https://github.com/mono/mono/issues/12193.

This is alternative to https://github.com/mono/mono/pull/12200.
They are both pretty good approaches.
12200 uncovered a hash order dependency which should be fixed either way.

* Fix C++.

* Remove unused MONO_ARCH_VARARG_ICALLS and ARCH_VARARG_ICALLS.
2019-01-02 12:12:46 -05:00
Kenneth Pouncey 9f73df9441 [wasm] Add support to find the wasm framework libraries. (#12211) 2019-01-02 12:11:59 -05:00
Zoltan Varga 0e96ba6889 [llvm] Remove the linkonce code, its not used anymore. (#12173) 2019-01-02 12:11:16 -05:00
Jay Krell fc33a23c68 Remove MonoCompile.inlined_method. It is confusing to have so many MonoMethods in MonoCompile: (#12201)
```
typedef struct {
.
.
.
    MonoMethod      *method;
    MonoMethod      *inlined_method; /* the method which is currently inlined */
    MonoMethod      *current_method; /* The method currently processed by method_to_ir () */
    MonoMethod      *method_to_register; /* The method to register in JIT info tables */
} MonoCompile;
```
so at least remove one of them that is not really used.
2019-01-02 12:09:34 -05:00
Jay Krell 9b285bf28a Do not build up indefinite coop handles in loops. (#12206)
* Do not build up indefinite coop handles in loops.

https://jenkins.mono-project.com/job/test-mono-pull-request-acceptance-tests/11767/parsed_console/log.html
ves_icall_System_Threading_WaitHandle_Wait_internal_raw USED 107 handles

* Add const.
2019-01-02 11:45:23 -05:00
Jay Krell d966231f0a [Coop] Convert and consolidate {remoting,cominterop}type_from_handle. (#12178)
* Consolidate identical functions type_from_handle and cominterop_type_from_handle
mostly into mono_type_from_handle.
However keep them separate for registration/patching sake, since
will error if register twice, else need to arrange to register once.

* [Coop] Convert {remoting,cominterop}type_from_handle.

* Fix warning about missing icall declaratons.
2019-01-02 11:38:29 -05:00
Marek Safar 3de77f3c60 Moves Attribute instance bits to shared location (dotnet/corert#6747)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-02 16:46:39 +01:00
Filip Navara 5eb676ddea Remove dummy globalization implementation. (dotnet/corert#6756)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-02 16:37:27 +01:00
monojenkins caf22d5f0b [csproj] Update project files 2019-01-02 13:54:08 +01:00
Leonardo Galli 1746f09efe [build] Fixed csproj.tmpl for macos: Conflict in naming of HostPlatform.
macOS was used for checking HostPlatform for OSX, but darwin is what the value was set to. This fixes the solution and csproj files for OSX.
2019-01-02 13:54:08 +01:00
Jan Kotas 8383b2194b AppContext moved to shared partition - CoreRT specific changes
Signed-off-by: dotnet-bot <[email protected]>
2019-01-02 10:13:31 +01:00
Ben Adams 2586365035 strlen to managed code and vectorize (dotnet/coreclr#21729)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-02 10:13:31 +01:00
Marek Safar cd079b1cab Tweaks permissions ifdefs in System.Diagnostics.Tracing (#21733)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-02 10:13:31 +01:00
Marek Safar 02c1851501 Moves AppContext to shared location (dotnet/coreclr#21734)
Signed-off-by: dotnet-bot <[email protected]>
2019-01-02 10:05:59 +01:00
Jay Krell 496eceef19 Register two separate functions for mono_fconv_u4 and mono_fconv_u8
instead of each function twice.

Elsewhere there is single instancing based on function address
and registering the same function twice breaks things.
2019-01-01 23:38:17 -05:00
Comical DERSKEAL e78eeecb33 Typo fix (#12230)
Typo fix


<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2019-01-01 16:15:39 -05:00
Jan Kotas 5a784c3cca Delete useless ArgumentNullException message (dotnet/coreclr#21728)
"Object cannot be null" does not add anything over the default "Value cannot be null"

Signed-off-by: dotnet-bot <[email protected]>
2019-01-01 10:01:05 +01:00
Dmitry Kalyanov d933418d23 Fix data race in System.Web.Caching by using appropriate lock level
System.Web.Caching.CacheItemLRU.this[string].get modifies LRU list so it
must be called under write lock. Cache.GetKeyLastChange violates this
constraint by acquiring only a read lock.

Fixes #12218
2018-12-31 15:36:36 -05:00
Marek Safar 326afd6eaf Moves ExceptionDispatchInfo to shared location (dotnet/coreclr#21725)
* Moves ExceptionDispatchInfo to shared location

* Use struct for Exception.DispatchState, avoid TLAs in names, misc cleanup

Signed-off-by: dotnet-bot <[email protected]>
2018-12-31 21:07:53 +01:00
Jan Kotas c624667e2f Add license, keep more of the CriticalHandle logic in the shared file
Signed-off-by: dotnet-bot <[email protected]>
2018-12-31 10:44:45 +01:00
Marek Safar c508d6d3c9 Moves CriticalHandle to shared location
Signed-off-by: dotnet-bot <[email protected]>
2018-12-31 10:44:45 +01:00
Marek Safar c44a67cf03 Readability improvement in MemoryStream (dotnet/coreclr#21710)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-31 10:36:04 +01:00
Koundinya Veluri 66fc2bf37f Don't Sleep(1) in some spin-wait loops (dotnet/coreclr#21722)
- In spin-wait loops that are not expected to last too long, Sleep(1) significantly delays threads from completing the operation
- From eliminating Sleep(1) in such spin-wait loops, there can be a tradeoff, better fairness vs worse throughput, because Sleep(1) removes threads from contention and in some cases fewer threads can make faster progress at the cost of delaying the Sleep(1) threads relatively significantly. Eliminating the Sleep(1) in such spin-wait loops seems to be a good tradeoff.

Signed-off-by: dotnet-bot <[email protected]>
2018-12-31 10:36:04 +01:00
Jan Kotas 3ea344432f Fix CoreRT build breaks
Signed-off-by: dotnet-bot <[email protected]>
2018-12-31 10:36:04 +01:00
Thays Grazia 2a16c76733 [Debugger] Record time it took between steps. (#12217)
* When going to https://jenkins.mono-project.com/job/test-mono-pull-request-arm64/8921/testReport/junit/(root)/DebuggerTests/StackTraceInNative/ for example, we have no idea why the underlying process has exited. To figure it out, we need to go to https://jenkins.mono-project.com/job/test-mono-pull-request-arm64/8921/parsed_console/log_content.html#WARNING1 and scroll back up to where the test was executed to find out the debuggee process crashed with an assertion.
This was fixed by redirecting the StandardOutput and StandardError of the debuggee process in the Mono.Debugger.Soft test suite.

* [Debugger] Record time it took between steps.
I implemented a new message to avoid breaking the protocol. I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent.
Fixes #8460

* Bump API snapshot submodule
2018-12-30 20:46:09 -05:00
Ben Adams 7315fc3d99 Shorter ExecutionContext.Capture (dotnet/coreclr#21707)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-30 19:26:51 +01:00
Marek Safar 081c438508 Moves generic comparers to shared CoreLib (dotnet/coreclr#21649)
* Moves generic comparer to shared CoreLib

* Keep Index/LastIndexOf optimizations in CoreCLR only

* Moved runtime-specific enum helper to runtime-specific partial type

Signed-off-by: dotnet-bot <[email protected]>
2018-12-30 10:55:01 +01:00
Marek Safar a2e68c76cd Moves ThrowHelper to shared location (dotnet/corert#6741)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-30 00:21:46 +01:00
Filip Navara 6900eb750e Move CultureInfo to shared CoreLib (dotnet/coreclr#21672)
* Move thread CurrentCulture and CurrentUICulture variables to CultureInfo.

* Move CultureInfo to shared CoreLib

* Code style fixes for consistency.

* Fold down APPX code into CultureInfo.CurrentCulture/CurrentUICulture.

* Remove unnecessary parentheses around return statements.

* Remove GetCurrentUICultureNoAppX.

Signed-off-by: dotnet-bot <[email protected]>
2018-12-29 22:49:33 +01:00
Egor Bogatov 34619669a5 Replace Interop.ReadDir.cs with Interop.ReadDir.cs from System.IO.FileSystem (#21622)
* Use Interop.ReadDir.cs from FileSystem (corefx)

* Use ArrayPool

* Remove ReadBufferSize (and static cctor)

* use NameBufferSize for 256 const

* Delete ReadDir and SafeDirectoryHandle.Unix.cs

* Introduce GetDirectoryEntryFullPath, remove uint casts

* Refactor EnumerateFilesRecursively

Signed-off-by: dotnet-bot <[email protected]>
2018-12-29 22:49:33 +01:00
Hugh Bellamy bd60819235 Remove dead Guid parsing code (dotnet/coreclr#21123)
* Remove dead checks in Guid parsing

* Minor cleanups in Guid

* Delete unused failureMessageFormatArgument

Signed-off-by: dotnet-bot <[email protected]>
2018-12-29 22:17:48 +01:00
Kenneth Pouncey a113c668a1 Add pupeteer to the browser tests node packages. (#12179)
- This will download the most recent version of headless to use.
- Add junit-reporter to output a tests output file to be used for jenkins CI in the future.
2018-12-28 10:05:51 -05:00
Kenneth Pouncey 07723a4772 [wasm] Update build docs (#12088)
* Update build docs

* Upate aot info
2018-12-28 08:45:32 -05:00
Jan Kotas 2d73d36997 Use common copy of System.Numerics.Hashing.HashHelpers
Signed-off-by: dotnet-bot <[email protected]>
2018-12-28 11:15:34 +01:00
Aleksey Kliger d1a5fa3783 [mini] Always emit safepoints, except WASM
This addresses https://github.com/mono/mono/issues/11765
2018-12-27 12:19:09 -05:00
Aleksey Kliger 0bf473d29c [marshal] Always emit blocking transitions, except WASM 2018-12-27 12:19:09 -05:00
Aleksey Kliger (λgeek) c1587b9f37 Reduce extern "C", in non-public headers. (#12148) 2018-12-27 09:32:57 -05:00
Jay Krell c09dda16ff ICALL_EXPORT reduction. (#12145)
ICALL_EXPORT should not be placed on HANDLES() functions.
Only the auto-generated wrappers need it, and they get it from the macro expansion.
And the explicit function declarations are generally redundant - the macro creates declarations, too.
2018-12-27 09:32:29 -05:00
Filip Navara 8f8289d444 Move Contracts.cs (CoreCLR version) to shared CoreLib and update code to compile. (#6734)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-27 15:18:55 +01:00
Filip Navara d9c30acd8e Move System/Numerics/Hashing to shared CoreLib. (dotnet/corert#6732)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-26 23:04:30 +01:00
Filip Navara d559dc6b66 Move DebugProvider.Windows to shared CoreLib. (dotnet/coreclr#21657)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-24 14:29:23 +01:00
Ben Adams db8add85e6 Use TZCNT and LZCNT for Locate{First|Last}Found{Byte|Char} (#21073)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-24 11:06:37 +01:00
Michal Strehovský 4f456991bc Fix ProjectN regression in ByReference<T> (dotnet/corert#6713)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-24 00:32:27 +01:00
ichensky 92c2fab68e Add optimization in GetHashCode for Int16 and SByte (dotnet/coreclr#21652)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-23 19:07:03 +01:00
Jan Kotas da25533507 Delete CoreLib.FixupCoreLibName (dotnet/coreclr#21655)
This method doing blind find&replace of "mscorlib" with "System.Private.CoreLib". It is both incorrect (e.g. if the typename happened to contain "mscorlib" string) and inefficient (unnecessary allocations and use of reflection).

Signed-off-by: dotnet-bot <[email protected]>
2018-12-23 19:07:03 +01:00
Marek Safar 08ad82a826 Extracts public IThreadPoolWorkItem interface to shared CoreLib (#21653)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-23 11:08:56 +01:00
Marek Safar 676f268a9f Moves CoreLib to shared location (dotnet/coreclr#21654)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-23 11:06:13 +01:00
Ben Adams 55ca4eb088 SpanHelpers deal with nullable reference types (dotnet/coreclr#21232)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 21:37:34 +01:00
Jan Kotas 958529643c Move some Task related files to shared CoreLib partition (#21650)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 19:19:00 +01:00
Jan Kotas 6069e0909a Synchronize Task, Awaiter and ThreadPool implementation with CoreCLR (#6706)
Synchronized the code as much as possible with CoreCLR. The one major piece that I have excluded is tracing. I will look into doing that separately.

Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:29:22 +01:00
Jan Kotas edc045728c CoreRT-specific Object.cs changes - Fix build breaks - Apply same cleanup to all related files
Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:29:22 +01:00
Jan Kotas d555d5ac7a Cleanup to match conventions
Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:29:22 +01:00
Marek Safar ddb79c3924 Moves common part of Object to CoreLib shared
Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:29:22 +01:00
Dan Moseley e1c1b7ad52 Remove _syncRoot field from collections (dotnet/coreclr#21628)
* SyncRoot

* Temp disable tests

* Disable outdated CoreFX test

* Tidier

Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:16:14 +01:00
Tanner Gooding fbfe1a8fc2 Ensure that the S.N.Vector methods are marked as [Intrinsic] and that the attribute is respected by the runtime (#21601)
* Updating the SIMD intrinsics to check for the `[Intrinsic]` attribute

* Ensure that the existing Vector/Vector<T> intrinsic methods are marked as such.

* Fixing Vector<T>.DotProduct and Vector.AndNot to be treated as intrinsic

* Fixing `SIMDIntrinsicBitwiseAndNot` to swap the operands for XARCH

Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:16:14 +01:00
Marek Safar 48fe8a78c3 Moves ByReference to shared CoreLib (dotnet/coreclr#21633)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:16:14 +01:00
Fei Peng 44af99b0ab Implement the remaining BMI1/2 intrinsic (dotnet/coreclr#21480)
* Add tests for BMI1/2 intrinsic

* Implement the remaining BMI1/2 intrinsic

* Fix emitDispIns for BMI instruction

Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:16:14 +01:00
Fei Peng e13e7eb7a5 Add AggressiveInlining for Vector<T>.op_Multiply (dotnet/coreclr#21587)
Signed-off-by: dotnet-bot <[email protected]>
2018-12-22 11:16:14 +01:00
Thays Grazia e8c0ce7605 When going to https://jenkins.mono-project.com/job/test-mono-pull-request-arm64/8921/testReport/junit/(root)/DebuggerTests/StackTraceInNative/ for example, we have no idea why the underlying process has exited. To figure it out, we need to go to https://jenkins.mono-project.com/job/test-mono-pull-request-arm64/8921/parsed_console/log_content.html#WARNING1 and scroll back up to where the test was executed to find out the debuggee process crashed with an assertion. (#12172)
This was fixed by redirecting the StandardOutput and StandardError of the debuggee process in the Mono.Debugger.Soft test suite.
2018-12-21 22:36:05 -02:00
Jay Krell a0b5245c77 [Coop] Mostly convert 30+ JIT icalls (and embedding API). (#11941)
* [Coop] Mostly convert 30+ icalls used via register_icall.
And infrastructure to support that.
The infrastructure is not as ideal as it could be.
In future the C preprocessor wrappers should be marshal-ilgen wrappers,
so the handles are more efficiently created.

Some of the conversion is incomplete and just goes back to raw pointers,
but mostly it is good.

Some of the conversion is by replacing previously manual conversion
with more automatic conversion, but most of it is new.

* Replace `foo_raw` with `foo` and `foo` with `foo_impl` per https://github.com/mono/mono/pull/11941#discussion_r243436712.

* Replace gchandle with no_safepoints in mono_string_builder_to_utf16_impl.
https://github.com/mono/mono/pull/11941#discussion_r243438706
at least the one loop.

* Fix windows build: mono_string_to_utf8str vs. mono_string_to_utf8str_impl.

* Fix boehm ves_icall_string_alloc vs. ves_icall_string_alloc_raw.

* Reduce apparent or actual diff.

* Add link to GitHub issue.

* Fix merge.

* Reduce another apparent but probably not actual diff.

* FIXME missing error

* Reduce diff in comment.

* Reduce diff in comment.
2018-12-21 18:12:37 -05:00
Alexander Kyte c2438b7dc2 [crash] Support extra merp params 2018-12-21 13:30:33 -05:00
Alexander Köplinger c11a3cdd53 Bump bockbuild 2018-12-21 16:47:02 +01:00
Cody Russell 5d4f630037 Bump bockbuild for VSTS #737323 fix to GtkNSView. (#11972) 2018-12-21 16:26:13 +01:00
Manuel de la Pena 5ce08b8433 Minor style changes. 2018-12-21 13:12:53 +01:00
Manuel de la Pena 5c2267c5a7 Fix error while chaging the request :/ 2018-12-21 13:12:53 +01:00
Manuel de la Pena 2bb9a2b39a Small typo. 2018-12-21 13:12:53 +01:00
Manuel de la Pena 4194c31994 No need to close the obc, it can be reused. 2018-12-21 13:12:53 +01:00
Manuel de la Pena a35d921f81 [Network] Fix CVE 2018-8292 on Mac OS X.
This commit ensures that CVE 2018-8292 is fixed by not setting
auto-redirect in the first request done by CFNetwork. CFNetwork has the
same bug, but we can work around it by performing the first request,
checking the response and, if it is a rediret, follow it without the
Authorization headers.
2018-12-21 13:12:53 +01:00
Filip Navara c628f13279 System.Windows.Forms: Fix incorrect layout for table layout nested in flow layout
Fixes issue #8922. The flow layout code specifies `int.MaxValue` as width in `GetPreferredSize` call, which the table layout didn't handle properly and tried to use all the available space.

Relevant WinForms open source code that implements the same behavior:
https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Windows/Forms/Layout/FlowLayout.cs#L183-L188

https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Windows/Forms/Layout/TableLayout.cs#L700-L702
2018-12-21 11:58:52 +01:00
PaulBol 7331c5e1d7 [WinForms] Dispose tooltips (#12059)
I noticed that some controls do not dispose tooltips and timers. Depending on the underlying implementation these may use native resources. Therefore I'd suggest to dispose these with the parent control to not rely on the garbage collector to eventually release the resources.

Additionally, in the case of `ToolStrip.cs` `CloseToolTip` would first create the objects before turning them off.
2018-12-21 10:50:12 +01:00
Egor Bogatov 534c98c070 [NS2.1] More types and members (#11944)
* Add NS21 Events to EventListener

* NS21: System.Data.DbProviderFactories

* Add ISOWeek

* some Socket API, etc

* more ns21 members

* Add GC.GetAllocatedBytesForCurrentThread stub

* clean up in icall-def.h

* bump corert

* Bump API snapshot submodule

* [csproj] Update project files
2018-12-21 10:37:22 +01:00
Zoltan Varga 7846f99f35 [jit] Emit a OP_NOT_NULL in MONO_EMIT_NULL_CHECK. (#12078) 2018-12-20 23:57:51 -05:00
Jay Krell 0d6d334bcb [Coop] Convert ves_icall_System_Array_FastCopy. (#11983)
* [Coop] Port ves_icall_System_Array_FastCopy.
  Using MONO_ENTER_NO_SAFEPOINTS / MONO_EXIT_NO_SAFEPOINTS.
2018-12-20 14:15:39 -05:00
Jay Krell fead81a538 [Coop] Convert System.String icalls. (#11991)
* [Coop] Mostly convert System.String icalls. But do not pin due to perf/profiler.

* Use MONO_ENTER_NO_SAFEPOINTS / MONO_EXIT_NO_SAFEPOINTS

* Add FIXME to MONO_HANDLE_RAW (mono_ldstr_metadata_sig ()), looks like a reasonable place to temporarily suspend the coop conversion graph walk.

* Restore MonoObjectHandleOut to mono_handle_assign_raw (was mono_handle_assign).
2018-12-20 14:13:10 -05:00
Alexander Köplinger ddf6249c1d Update Helix SDK to latest version (#12156)
They added retry logic inside of the SDK to deal with some expected Helix API responses.
2018-12-20 19:46:22 +01:00
dotnet bot ccd7b52ca8 Add System.Private.CoreLib shared sources (#12162)
Taken from corefx commit 5956ad35864352b38c53aa8c2d1ce012c96b168d. Subsequent updates will happen via a mirroring bot.
2018-12-20 18:51:17 +01:00
Zoltan Varga 53f091ea4f [runtime] Avoid typedref returns from icalls, wasm doesn't support them. (#12142)
* [runtime] Convert TypedReference icalls to handles, return the result using an out argument since wasm doesn't support TypedReference returns from icalls.

* Bump corlib version.

* [runtime] Change ArgIterator icalls to return typedref results using an out argument since wasm doesn't support typedref returns from icalls.

* Use MONO_HANDLE_RAW () only at the end.
2018-12-20 10:25:47 -05:00
Alexander Köplinger 5855fcd47b Bump ms-test-suite (#12150)
Brings in disabling of the ThreadLocalTests.RunThreadLocalTest8_Values_NegativeCases test (https://github.com/xamarin/ms-test-suite/pull/3)
2018-12-20 15:21:25 +01:00
Marek Safar 729bd4e45d Bootstraps netcore build (#12120)
This does not build but puts placeholders for syncing in place
2018-12-20 14:19:15 +01:00
monojenkins d6a9dc0a50 [bcl] Update BCL Linked Size (#11996) 2018-12-20 13:56:52 +01:00
Bernhard Urban d5b777ea13 [sdks] Add a XCODE32_DIR make variable and use it to compile the 32 bit cross compilers. (#12055)
Forward port of #10139

Needed for arm64_32 (#11691): We still need to build AOT compilers that are 32bit, which is only possible with Xcode9. However, arm64_32 needs Xcode10.
2018-12-20 13:40:54 +01:00
Larry Ewing 671708c403 Skip TypedReferenceTest fixture for WASM as it causes a runtime abort (#12124)
The sdks/wasm run-all-corlib target currently aborts in the TypedReferenceTest fixture. Skip it in that case by adding it to the NotWasm category.
2018-12-20 13:22:31 +01:00
Larry Ewing 3d64ae0618 Allow urls with a blob scheme to pass validation in WASM (#12121)
Relax HttpMessageRequest url scheme validation for wasm so that urls with a blob scheme make it to the host backend. Fixes #11681

note: the browser tests fail when running chrome 71 in headless mode, they work in chrome 70 and 72
2018-12-20 13:14:39 +01:00
Jo Shields 6de9c370ec Bump to latest SQLite for Mac bundle (#12118)
* Bump to latest SQLite for Mac bundle

* Explicitly disable editline support.

SQLite assumes that if editline is enabled (the default), then NCurses was compiled with TermInfo support, which is not true on Mac
2018-12-20 12:24:47 +01:00
Jay Krell 89736b3659 Reduce extern "C", in non-public headers. 2018-12-20 02:24:51 -08:00
Zoltan Varga a46e3305c4 [wasm] Run patch with -N so it doesn't fail if called more than once. 2018-12-19 11:36:12 -05:00
guthubuser e77d5bafef Update Graphics to find err
ystem.Exception: Generic Error [GDI+ status: GenericError]
  at System.Drawing.GDIPlus.CheckStatus (System.Drawing.Status status) [0x00079] in <bb99ab19679c4cf79f4136bd0faf8b5e>:0 
  at System.Drawing.Graphics.FillRectangle (System.Drawing.Brush brush, System.Int32 x, System.Int32 y, System.Int32 width, System.Int32 height) [0x00025] in <bb99ab19679c4cf79f4136bd0faf8b5e>:0 
  at System.Drawing.Graphics.FillRectangle (System.Drawing.Brush brush, System.Drawing.Rectangle rect) [0x0002c] in <bb99ab19679c4cf79f4136bd0faf8b5e>:0 
  at (wrapper remoting-invoke-with-check) System.Drawing.Graphics.FillRectangle(System.Drawing.Brush,System.Drawing.Rectangle)
  at System.Windows.Forms.Control.PaintControlBackground (System.Windows.Forms.PaintEventArgs pevent) [0x002ff] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control.OnPaintBackground (System.Windows.Forms.PaintEventArgs pevent) [0x00000] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control.WmPaint (System.Windows.Forms.Message& m) [0x0005f] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control.WndProc (System.Windows.Forms.Message& m) [0x001a4] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.ScrollBar.WndProc (System.Windows.Forms.Message& m) [0x00000] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control+ControlWindowTarget.OnMessage (System.Windows.Forms.Message& m) [0x00000] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.Control+ControlNativeWindow.WndProc (System.Windows.Forms.Message& m) [0x0000b] in <69ecb40f27a1431a99620933ba9a8b39>:0 
  at System.Windows.Forms.NativeWindow.WndProc (System.IntPtr hWnd, System.Windows.Forms.Msg msg, System.IntPtr wParam, System.IntPtr lParam) [0x00085] in <69ecb40f27a1431a99620933ba9a8b39>:0
2018-12-19 10:33:31 -05:00
Ankit Jain 56581e9cc4 [MacSDK] Bump NuGet to 4.8.1 2018-12-19 14:03:23 +01:00
Alexander Kyte 713162263d [crash] Fix reported utf encoding (#12123) 2018-12-19 07:48:16 -05:00
Zoltan Varga 0af7408340 [wasm] Enable EMULATED_FUNCTION_POINTERS. (#12077)
* [wasm] Add the fix for https://github.com/kripken/emscripten/issues/7399 as a patch for emscripten.

* [wasm] Factor out some flags from the makefile targets.

* [wasm] Enable EMULATED_FUNCTION_POINTERS.
2018-12-18 17:00:44 -05:00
Zoltan Varga a92701bd18 [aot] Add MONO_PATCH_INFO_INTERRUPTION_REQUEST_FLAG to the preinited got slots. (#12075) 2018-12-18 16:50:51 -05:00
Jay Krell 399264331b Reduce but don't eliminate excess extern "C".
G_BEGIN_DECLS is almost never needed. Esp. around entire files.
It is for "the OS" and interoperation with some code that is still C, like profilers.

MONO_BEGIN_DECLS is often used in internal headers, in which case the same, but
not addressed here.

MONO_BEGIN_DECLS is often used in public headers, along with comprehensive
MONO_API, in which case it is redundant. This would be useful if/when mono
goes back to using .def files, which are a good idea for multiple reasons.
2018-12-18 16:03:04 -05:00
Jay Krell 2f0b4b8593 Remove ves_icall_System_Threading_Thread_current_lcid.
Probably unused since a0c6e79318 in 2004.
Certainly unused since cc9c53a109 in 2008.
Except for use by MERP, replace with its implementation -- MONO_LOCALE_INVARIANT.
2018-12-18 15:58:05 -05:00
Ankit Jain e70f02a4c2 Bump msbuild to track xplat-master 2018-12-18 16:28:45 +01:00
Zoltan Varga 475431927c [jit] Call mono_register_jit_icall_full () in more places so most jit icalls can be called directly during AOT. (#12076)
* [jit] Call mono_register_jit_icall_full () in more places so most jit icalls can be called directly during AOT.

* Fix a c++-ism.

* Fix a c++-ism.

* Fix a c++-ism.
2018-12-18 08:18:28 -05:00
Martin Baulig e72f0a8a03 [gensources]: Add platform/project logic to tests.
The gensources tool now supports platform/specific .sources for nunit and xunit tests.
2018-12-18 13:14:07 +01:00
Maxim Lipnin 787c851fa5 Fix IndexOutOfRangeException in MethodInfo.ReturnParameter.IsDefined(type) 2018-12-18 12:23:59 +01:00
Jay Krell ea12da137a Null terminate in mono_string_to_byvalstr like the comment says (#11985)
and like mono_string_to_byvalwstr does and like the code
makes room for.
2018-12-17 16:41:46 -05:00
Jay Krell 05049138ec Remove MONO_HANDLE_ARRAY_SETRAW. 2018-12-17 16:40:54 -05:00
Jay Krell 2b6373afeb [Coop] Convert System.Globalization.CompareInfo. (#12063)
This is a subset of https://github.com/mono/mono/pull/12023, maybe easier to review
in smaller pieces.

Alternatives:
 1. Move more to managed.
 2. Remove the feature.
2018-12-17 16:35:19 -05:00
Jay Krell f8dbcf5ac7 [Coop] Mark RegisterReportingForNativeLib_internal NOHANDLES(). 2018-12-17 16:29:47 -05:00
Jb Evain 2993fa3281 [Mono.Debugger.Soft] Fix reading custom attribute named arguments on old protocol versions 2018-12-17 12:47:14 +01:00
Zoltan Varga f2d43e98d7 [wasm] Pass the bindings assembly to the linker. (#12061) 2018-12-17 06:20:36 -05:00
Johan Lorensson d42d675b81 Windows x64 LLVM assert support + MSVC only for none cross compiler build. (#11946)
* Add support for LLVM asserts in internal LLVM build on Windows.

* Only build LLVM using MSVC if not cross compiling.

If not cross compiling, building runtime where host/target is Windows, only
build and use LLVM as part of msvc build (only supported configuration),
disabled on gcc build.

Enforce 64-bit LLVM support when building using Visual Studio solution file.

* Disable Windows LLVM Visual Studio build on unsupported configurations.

Automatically disable Windows LLVM build in Visual Studio. This enables
the option to configure using --enable-llvm but still build all runtime
configurations from within Visual Studio. A warning will be issued into
build logs when LLVM support is disabled for a specific build configuration.

* Fix so build-init always have cygconf.h available when needed.
2018-12-14 15:45:33 -05:00
Jay Krell 1503ca4952 Cache MonoMethod in ves_icall_System_Security_SecureString_EncryptInternal / ves_icall_System_Security_SecureString_DecryptInternal. 2018-12-14 15:22:22 -05:00
Zoltan Varga d8faa8e881 [llvmonly] Emit unbox trampolines as 2 tables instead of a lookup function, this takes less space that the switch statement (#12054)
in the lookup function.
2018-12-13 23:16:48 -05:00
Zoltan Varga 0212106d36 [wasm] Add more helper make targets. (#12052) 2018-12-13 22:52:58 -05:00
Egor Bogatov 622609d54b Get rid of Registry in XmlReader (#12008) 2018-12-13 16:20:46 -05:00
Alexander Kyte 9b81922a62 [runtime] Don't probe aot cache on android 2018-12-13 16:08:12 -05:00
Alexander Kyte a8d10611ac [runtime] Fix aot mode double init check 2018-12-13 15:09:58 -05:00
Alexander Kyte 799991bc34 [runtime] Don't assert when MONO_AOT_MODE_NONE passed to setter 2018-12-13 14:31:22 -05:00
Alexander Kyte cc7aefb008 [runtime] Don't probe for assemblies when MONO_AOT_MODE_NONE is set 2018-12-13 14:30:44 -05:00
Jay Krell 3fbafe6550 Fix MonoSortKey native/managed layout mismatch. (#12043)
Fix MonoSortKey native/managed layout mismatch.

MonoSortKey native:
https://github.com/mono/mono/blob/f019810b12ba130b7fed1cd41bb2eaed04ececef/mono/metadata/object-internals.h#L700

SortKey managed:
https://github.com/mono/mono/blob/f019810b12ba130b7fed1cd41bb2eaed04ececef/mcs/class/corlib/Mono.Globalization.Unicode/SortKey.cs#L69

do not agree.

Memory is corrupted and crash if you set $MONO_DISABLE_MANAGED_COLLATION=yes documented here:
https://github.com/mono/mono/blob/f019810b12ba130b7fed1cd41bb2eaed04ececef/man/mono.1#L1161

Fix is to remove the native code and replace by trivial managed.

Found testing coop-conversion of System.Globalization. https://github.com/mono/mono/pull/12023
2018-12-13 12:55:43 -05:00
Zoltan Varga 087b198c99 [wasm] Remove the old 32 cross compiler, its not used anymore. (#12046) 2018-12-13 12:09:30 -05:00
Thays Grazia 05188e03f9 [debugger] Fix test StepOutAsync (#12032)
* The problem with this flaky issue was the timing of processing of the async tasks, as it was executed in background threads it was not possible to reach the end of execution because all the foreground threads exit earlier.
The solution creates a TaskScheduler that ensure that the thread that will execute the task will be a foreground thread and then the test always works.

Fixes #6997
2018-12-13 11:50:06 -05:00
Calvin Buckley a3ef7c874e Update corefx submodule for AIX readdir_r fix (#12031)
Exposes a race condition in CoreFX when gensources tries to enumerate Cecil sources. Run it without `--trace=all`, 86 sources found. Run it with, even if redirected to `/dev/null`, 132 sources found. Eeeeeek.
2018-12-13 11:44:26 -05:00
Zoltan Varga 01f6a0203b [wasm] Avoid dedup-ing StructureToPtr/PtrToStructure wrappers, its not neccessary, and it doesn't seem to work. (#12033) 2018-12-13 10:06:34 -05:00
Jay Krell dfc517c346 [Coop] Mark 15 icalls as NOHANDLES. (#12028) 2018-12-13 09:47:49 -05:00
Kenneth Pouncey f019810b12 Merge pull request #11943 from kjpou1/wasm-test-suite
[wasm] Add browser test suite.
2018-12-13 09:13:45 -05:00
Alexander Kyte 118684e89b [runtime] Remove duplicate merp invoke line (#12036)
[runtime] Remove duplicate merp invoke line

Looks like this broke when it got squashed down, or we overlooked it. We've got two calls where we expected one.
2018-12-13 09:05:24 -05:00
Zoltan Varga 2e05d26cfa [jit] Add beginnings of llvmonly+interp mixed mode support. (#11987)
[jit] Add beginnings of llvmonly+interp mixed mode support.
2018-12-13 08:55:57 -05:00
Jay Krell 28b1e79d19 Fix two leaks in error paths. (#12042) 2018-12-13 05:17:54 -08:00
Jay Krell 5870948f56 Remove ves_icall_System_Globalization_CompareInfo_internal_index_char. (#12026)
Unused since Feb 2018 d63e8b6f5a.
2018-12-12 15:03:26 -08:00
Jay Krell 40d462b6ee Remove unused ves_icall_System_Globalization_RegionInfo_construct_internal_region_from_lcid. (#12024)
Remove unused ves_icall_System_Globalization_RegionInfo_construct_internal_region_from_lcid.

See 0204abe803 from 2009.
2018-12-12 17:25:40 -05:00
Jay Krell bdf4e262a0 Cleanup mono_ldstr_metadata_sig esp. remove extra mono_string_intern_checked. 2018-12-12 16:32:36 -05:00
Jay Krell 5e45fb2760 Set error in mono_string_new_utf8_len_handle, mono_string_new_len_checked. 2018-12-12 16:22:58 -05:00
Martin Baulig 41e57c671f [resx2sr]: Giving this tool some love. (#11969) 2018-12-12 09:34:54 -05:00
Jay Krell 22a4056ecf [Coop] Add typechecking to MONO_HANDLE_SETVAL and fix mistakes it finds. (#12021)
[Coop] Add typechecking to MONO_HANDLE_SETVAL and fix mistakes it finds.
2018-12-11 20:25:39 -05:00
Jay Krell 6265eb0223 Remove ERROR_DECL_VALUE. (#12012)
Remove ERROR_DECL_VALUE.
2018-12-11 14:35:43 -05:00
Calvin Buckley 0c30564bc9 for "build" config, import corlib common sources at unix instead (#11989)
...of importing it at linux/macOS

this unbreaks the build on "unix" platforms like FreeBSD and AIX

(is this all needed files, and am I doing this right?)
2018-12-10 15:01:04 -05:00
Jay Krell a91771787c [Coop] Mark System.ArgIterator all NOHANDLES. (#12003) 2018-12-10 11:39:18 -08:00
Jay Krell a29aa4ac80 Reduce lock hold times. (#11997) 2018-12-10 06:20:51 -08:00
Jay Krell de37ae3168 Inline mono_string_handle_length by making it a macro, usually. (#11994) 2018-12-10 04:04:33 -08:00
Jay Krell 3be2618c63 Quash warning icall.c:4408:12: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] (#11993)
if (klass = m_class_get_parent (klass))
            ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
icall.c:4408:12: note: place parentheses around the assignment to silence this warning
        if (klass = m_class_get_parent (klass))
                  ^
            (                                 )
icall.c:4408:12: note: use '==' to turn this assignment into an equality comparison
        if (klass = m_class_get_parent (klass))
2018-12-10 01:04:54 -08:00
Jay Krell 52a07dd48e [Coop] Convert System.Security.SecureString. (#11995) 2018-12-09 23:46:20 -08:00
Alexander Köplinger 2f678add77 Bump corefx 2018-12-09 08:09:04 -05:00
Alexis Christoforides fd424c5dd0 [corlib] Import System.IO.TextWriter/StreamWriter from CoreFX (#11783)
* [corlib] Import System.IO.TextWriter/StreamWriter from CoreFX

* Adjust a Mono test. According to CoreFX TextWriter sources, CoreNewLine should only be used for read-only purposes.

* Bump CoreCLR for bug fix on test which becomes much flakier apparently with this patch

* Bump corefx

* Bump API snapshot submodule

* [csproj] Update project files
2018-12-09 08:05:45 -05:00
monojenkins 2cdcf190af [bcl] Update BCL Linked Size 2018-12-08 18:43:32 +01:00
Jay Krell ce1b1cd473 sizeof (gpointer) => sizeof (target_mgreg_t). (#11981) 2018-12-08 08:48:47 -08:00
Jay Krell cdf8c2923e [sgen] Make CHECK_CANARY_FOR_OBJECT a function. (#11971) 2018-12-08 02:47:37 -08:00
Jay Krell fd1458579f marshal.c cleanup (#11968)
- Reduce length computations of string builders.
 - Handle zero sized StringBuilder correctly (initialize the first
   not just the second character).
 - Check for overflow correctly in StringBuilder -- include offset.
 - Fix prototype of mono_string_to_byvalstr (gpointer vs. char*)
 - Fix prototype of mono_string_to_byvalwstr (gpionter vs. gunichar2*).
 - Single point of exit in mono_string_builder_to_utf8.
2018-12-08 02:05:19 -08:00
Kenneth Pouncey beb8397421 Address review comments 2018-12-07 15:55:23 +01:00
Larry Ewingandkjpou1 904e8d48ff Update sdks/wasm/tests/browser/http-spec.js
Update with review suggestion

Co-Authored-By: kjpou1 <[email protected]>
2018-12-07 15:38:42 +01:00
Larry Ewingandkjpou1 039044d320 Update sdks/wasm/tests/browser/http-spec.js
Update with review comment suggestion

Co-Authored-By: kjpou1 <[email protected]>
2018-12-07 15:38:16 +01:00
Alexis Christoforides 449e36638f [corlib] Import FileSystemInfo and family from CoreFX (#11342)
Includes the following from System.IO:

* FileSystemInfo
* FileInfo
* DirectoryInfo
* Directory
* FileSystem
* Path `Join()` Span API

and all of System.IO.Enumeration namespace.

Adds about 1600 System.IO tests

Behavior changes:
* `File.Replace` now replaces files even if they are read-only (using the `rename` syscall on Unix)
* Directory enumeration is no longer stable in the way that many Mono tests expect
* Some changes in when/whether some representations of directories contain a trailing separator character
* Changes in which exceptions are thrown (sometimes these are platform-dependent on CoreFX)

Issues:
* https://github.com/dotnet/corefx/issues/33486
* https://github.com/dotnet/corefx/issues/33490

Part of #7246
2018-12-07 15:02:23 +01:00
Jay Krell 3643f411a0 Fix cross compile of libtest. (#11865)
CC       libtest_la-libtest.lo
    <inline asm>:37:2: error: instruction requires: Not 64-bit mode
            popl %eax
            ^
    ... same error many times

Fix ThisCall tests.

Libtest.c needs to be C++ for Visual C+++ to accept __thiscall.
gcc accepts __thiscall in C.

Visual C++ only accepts __thiscall on member functions and function pointers,
not globals. Gcc accepts on globals also.
So test what we can.

add extern C

Limit thiscall testing to Win32, even if gcc has more support.
2018-12-06 10:49:33 -08:00
Jay Krell c80110cb05 [w32file-unix] Use mono_dl_open in place of dlopen
* Cleanup boehm/dlopen per https://github.com/mono/mono/pull/11853#discussion_r238861650.
https://github.com/mono/mono/issues/11936

* s/mono_dlopen/mono_dl_open s/dlsym/mono_dl_symbol

* s/dlclose/mono_dl_close

* Fix mono_dl_symbol use.

* Fix mono_dl_open call.

* Fix type of libc_handle for mono_dl vs. regular dl.
2018-12-06 13:48:20 -05:00
Jay Krell 943fa94bce Fix CHECK_CANARY_FOR_OBJECT. (#11957)
Fix CHECK_CANARY_FOR_OBJECT.

..\mono\metadata\sgen-mono.c(1443): warning C4390: ';': empty controlled statement found; is this the intent?

(Why is this not a function?)
2018-12-06 12:55:37 -05:00
Jay Krell eeb7e6bdb5 Remove mono_array_to_byvalarray and mono_byvalarray_to_array. (#11954)
Remove mono_array_to_byvalarray      and mono_byvalarray_to_array.

Only   mono_array_to_byte_byvalarray and mono_byvalarray_to_byte_array are used.
2018-12-06 11:55:51 -05:00
Alexander Köplinger ee3afd3103 [acceptance-tests] Add a generated file to .gitignore 2018-12-06 17:19:48 +01:00
Alexander Kyte e1461ebc85 [crash] Switch crash reporting writers to no-allocate + validate json (#11884)
* [crash] Switch merp dumper to no-allocate file writer

- Pass merp directory to backend (optional)
- Adds tests that needed the named change

* [crash] Make mono-state use non-allocating format strings

* [crash] Add json formatting validators to mono/tests

* [crash] Make crash-sending icalls use const strings

* [crash] Use fork+exec for merp

* [crash] Throw exception when unable to contact merp

* [crash] Disable merp-json-valid test on non-OSX
2018-12-06 10:57:05 -05:00
Jay Krell ff04de942b [cxx] Fix arm+arm64 since 9a9439329b. (#11958) 2018-12-06 15:56:32 +01:00
Jay Krell 13e9729ed6 Eliminate mgreg_t in favor of target_mgreg_t and host_mgreg_t. And one minor fix. (#11952)
* Elimination of mgreg_t in favor of target_mgreg_t and host_mgreg_t.

* [mips] Fix one host vs. target size.

* easier to read in narrow screen

* For posterity.
2018-12-06 08:23:39 -05:00
Alexander Köplinger e031ff4425 [ci] Replace plus with uri-encoded version in build url reported to Helix 2018-12-06 14:00:21 +01:00
Jo Shields 21dcc74a7a [Win32] Enable BTLS in Windows builds (#11947) 2018-12-06 12:59:09 +01:00
Jay Krell 8525f4c679 Fix race condition in mono_string_builder_new. (#11955)
Fix race condition in mono_string_builder_new.
2018-12-06 06:25:45 -05:00
Calvin Buckley bbb475d058 Fix regression with building PPC JIT (#11948)
* Fix regression with building PPC JIT

d5547b1929 made an incorrect change
to `mini-ppc.c` that wouldn't build; revert that file.

* Switch to fixing mini-ops.h instead
2018-12-06 10:41:39 +01:00
Egor Bogatov cd21cdb1b6 Display AM/PM for ko-KR culture (#11327)
Fixes https://github.com/mono/mono/issues/11317
(I guess I need to update culture-info-tables.h via make but it doesn't work on Windows, I have to switch to macOS).
2018-12-06 10:13:31 +01:00
Jay Krell 858434201d Fix cross compile of libtest.
CC       libtest_la-libtest.lo
    <inline asm>:37:2: error: instruction requires: Not 64-bit mode
            popl %eax
            ^
    ... same error many times

Fix ThisCall tests.

Libtest.c needs to be C++ for Visual C+++ to accept __thiscall.
gcc accepts __thiscall in C.

Visual C++ only accepts __thiscall on member functions and function pointers,
not globals. Gcc accepts on globals also.
So test what we can.

add extern C

Limit thiscall testing to Win32, even if gcc has more support.
2018-12-06 00:46:21 -08:00
Jay Krell 7f729566b4 Adjust test (not runtime) to workaround Windows i386 GCC ABI bug. 2018-12-06 00:11:13 -08:00
Jay Krell 71d46c815d Remove excess extern "C" per https://github.com/mono/mono/pull/11121#issuecomment-444562586. (#11950)
Remove one excess extern "C" per https://github.com/mono/mono/pull/11121#issuecomment-444562586.

There are many more.
2018-12-06 01:25:39 -05:00
Kenneth Pouncey bb6aae9a6e Small clean up to use path variable instead of relative path. 2018-12-06 05:15:12 +01:00
Jay Krell 9a9439329b Host/target corrections and clarifications and cleanup. (#11887) 2018-12-05 18:01:55 -08:00
Alexander Kyte c84ae2e7e9 [crash] Add crash reporter logger (#11855)
* [crash] Add crash reporter logger

* [crash] Disable mono-merp when disabling crash reporting
2018-12-05 17:19:34 -05:00
Jay Krell 4a5d19498b Move MONO_STRFTIME_T and MONO_STRFTIME_F to mono-time.h. 2018-12-05 16:50:29 -05:00
Jay Krell 66d1da652e strftime(%F) and strftime(%T) are non-portable shorthands that produce
a lot of warnings in the build. Expand them to their portable equivalents.
2018-12-05 16:50:29 -05:00
Zoltan Varga d5547b1929 [jit] Rename the textual names of several instructions so they match the opcode names. (#11938) 2018-12-05 16:05:39 -05:00
Jay Krell 460c8b4c16 Split mono_class_init into mono_class_init and mono_class_init_internal, add GC mode transition to first. (#11121)
mono_class_init_internal is what mono_class_init was.
mono_class_init *adds* missing GC mode transitions and calls mono_class_init_internal.

Replace mono_class_init with mono_class_init_internal.
2018-12-05 12:27:44 -08:00
Jay Krell 45407470db Quash some "may be used uninitialized" warnings.
/s/mono/mono/mini/interp/interp.c: In function 'interp_entry_from_trampoline':
/s/mono/mono/mini/interp/interp.c:2422:3: warning: 'orig_domain' may be used uninitialized in this function [-Wmaybe-uninitialized]
   mono_threads_detach_coop (orig_domain, &attach_cookie);
   ^
/s/mono/mono/mini/interp/interp.c: In function 'interp_exec_method_full':
/s/mono/mono/mini/interp/interp.c:2695:4: warning: 'locals' may be used uninitialized in this function [-Wmaybe-uninitialized]
    memset (locals, 0, rtm->locals_size);
    ^
/s/mono/mono/mini/method-to-ir.c: In function 'mini_handle_enum_has_flag':
/s/mono/mono/mini/method-to-ir.c:3416:9: warning: 'load' may be used uninitialized in this function [-Wmaybe-uninitialized]
    load = mono_decompose_opcode (cfg, load);
         ^
At least the first two seem to be compiler weakness.
2018-12-05 13:14:00 -05:00
Jay Krell 40f86511d4 Fix a bunch of warnings. (#11859)
* Fix a bunch of warnings.

/s/mono/mono/metadata/marshal.c:4862:72: warning: format specifies type 'unsigned long' but the argument has type 'gsize' (aka 'unsigned int') [-Wformat]
                mono_error_set_out_of_memory (error, "Could not allocate %lu bytes", size);
                                                                         ~~~         ^~~~
                                                                         %zu
/s/mono/mono/metadata/marshal.c:6229:1: warning: unused function 'install_noilgen' [-Wunused-function]
install_noilgen (void)
^
                                                        %llx

/s/mono/mono/metadata/w32file-unix.c:4877:147: warning: format specifies type 'void *' but the argument has type 'gint' (aka 'int') [-Wformat]
        mono_trace (G_LOG_LEVEL_DEBUG, MONO_TRACE_IO_LAYER_FILE, "%s: Unlocking fd %p, offset %" G_GINT64_FORMAT ", length %" G_GINT64_FORMAT, __func__, ((MonoFDHandle*) filehandle)->fd, (gint64) offset, (gint64) length);
                                                                                   ~~                                                                    ^~

/s/mono/mono/metadata/w32process-unix-internals.h:44:1: warning: unused function 'mono_w32process_module_free' [-Wunused-function]
mono_w32process_module_free (MonoW32ProcessModule *module)
^

/s/mono/mono/utils/mono-threads-android.c:44:1: warning: no previous prototype for function 'mono_threads_platform_get_stack_bounds' [-Wmissing-prototypes]
mono_threads_platform_get_stack_bounds (guint8 **staddr, size_t *stsize)
^

/s/mono/mono/mini/interp/transform.c:1666:15: warning: unused variable 'vt' [-Wunused-variable]
                MonoVTable *vt = mono_class_vtable_checked (domain, target_method->klass, error);
                            ^
/s/mono/mono/utils/mono-counters.c:547:55: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'gssize' (aka 'int') [-Wformat]
                fprintf (outfile, ENTRY_FMT "%zd\n", counter->name, *(gssize*)buffer);
                                             ~~~                    ^~~~~~~~~~~~~~~~
                                             %td

/s/mono/mono/sgen/sgen-debug.c:1066:72: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'int' [-Wformat]
        fprintf (heap_dump_file, "<occupied offset=\"%zd\" size=\"%zd\"/>\n", start - section_start, end - start);
                                                     ~~~                      ^~~~~~~~~~~~~~~~~~~~~
                                                     %d
/s/mono/mono/sgen/sgen-debug.c:1066:95: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'int' [-Wformat]
        fprintf (heap_dump_file, "<occupied offset=\"%zd\" size=\"%zd\"/>\n", start - section_start, end - start);
                                                                  ~~~                                ^~~~~~~~~~~
                                                                  %d
/s/mono/mono/sgen/sgen-debug.c:1139:4: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'mword' (aka 'unsigned int') [-Wformat]
                        safe_object_get_size (obj));
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-debug.c:37:30: note: expanded from macro 'safe_object_get_size'
                                ^
/s/mono/mono/sgen/sgen-memory-governor.c:309:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->promoted_size / 1024,
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~

/s/mono/mono/sgen/sgen-debug.c:1139:4: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'mword' (aka 'unsigned long long') [-Wformat]
                        safe_object_get_size (obj));
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-debug.c:37:30: note: expanded from macro 'safe_object_get_size'
                                ^
/s/mono/mono/metadata/w32file-unix.c:70:9: warning: 'INVALID_HANDLE_VALUE' macro redefined [-Wmacro-redefined]
        ^
/s/mono/mono/metadata/w32handle.h:19:9: note: previous definition is here
        ^
/s/mono/mono/metadata/handle.c:159:31: warning: 'extern' variable has an initializer [-Wextern-initializer]
extern MonoThreadInfo * const mono_thread_info_current_var = NULL;
                              ^
/s/mono/mono/mini/branch-opts.c:117:18: warning: unused variable 'int_cmov_opcodes' [-Wunused-const-variable]
static const int int_cmov_opcodes [] = {
                 ^
/s/mono/mono/mini/branch-opts.c:130:18: warning: unused variable 'long_cmov_opcodes' [-Wunused-const-variable]
static const int long_cmov_opcodes [] = {
                 ^
/s/mono/mono/mini/interp/interp.c:1233:1: warning: unused label 'exit_pinvoke' [-Wunused-label]
exit_pinvoke:
^~~~~~~~~~~~~
/s/mono/mono/mini/interp/interp.c:1900:1: warning: unused label 'exit_icall' [-Wunused-label]
exit_icall:
^~~~~~~~~~~

/s/mono/mono/mini/interp/transform.c:1668:7: warning: unused variable 'called_inited' [-Wunused-variable]
                int called_inited = vt->initialized;
                    ^
                                 ^/s/mono/mono/sgen/sgen-debug.c:1139:4: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'mword' (aka 'unsigned long long')
      [-Wformat]
                        safe_object_get_size (obj));
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-debug.c:37:30: note: expanded from macro 'safe_object_get_size'
                                ^
/s/mono/mono/sgen/sgen-descriptor.c:132:52: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
                SGEN_LOG (6, "Ptrfree descriptor %p, size: %zd", (void*)desc, stored_size);
                                                                 ^
/s/mono/mono/sgen/sgen-descriptor.c:145:70: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
                SGEN_LOG (6, "Largebitmap descriptor %p, size: %zd, last set: %d", (void*)desc, stored_size, last_set);
                                                                                   ^
/s/mono/mono/sgen/sgen-descriptor.c:156:80: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
                        SGEN_LOG (6, "Runlen descriptor %p, size: %zd, first set: %d, num set: %d", (void*)desc, stored_size, first_set, num_set);
                                                                                                    ^
/s/mono/mono/sgen/sgen-gc.c:1252:82: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int') [-Wint-to-void-pointer-cast]
                SGEN_LOG (6, "Precise root scan %p-%p (desc: %p)", start_root, root->end_root, (void*)root->root_desc);
                                                                                               ^
/s/mono/mono/sgen/sgen-nursery-allocator.c:800:114: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'mword'
      (aka 'unsigned long long') [-Wformat]
  ...SGEN_LOG (3, "Bastard pinning obj %p (%s), size: %zd", p, sgen_client_vtable_get_name (SGEN_LOAD_VTABLE (p)), sgen_safe_object_get_size (p));
                                                      ~~~                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                      %llu
/s/mono/mono/sgen/sgen-gc.h:143:69: note: expanded from macro 'SGEN_LOG'
                mono_gc_printf (sgen_gc_debug_file, "%s " format "\n", logTime, ##__VA_ARGS__); \
                                                                                  ^~~~~~~~~~~
/s/mono/mono/utils/mono-logger-internals.h:109:34: note: expanded from macro 'mono_gc_printf'
        fprintf (gc_log_file, format, ##__VA_ARGS__);   \
                                        ^~~~~~~~~~~
/s/mono/mono/sgen/sgen-pinning.c:213:117: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'mword'
      (aka 'unsigned long long') [-Wformat]
  ...SGEN_LOG (3, "Bastard pinning obj %p (%s), size: %zd", ptr, sgen_client_vtable_get_name (SGEN_LOAD_VTABLE (ptr)), sgen_safe_object_get_size (ptr));
                                                      ~~~                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                      %llu
/s/mono/mono/sgen/sgen-gc.h:143:69: note: expanded from macro 'SGEN_LOG'
                mono_gc_printf (sgen_gc_debug_file, "%s " format "\n", logTime, ##__VA_ARGS__); \
                                                                                  ^~~~~~~~~~~
/s/mono/mono/utils/mono-logger-internals.h:109:34: note: expanded from macro 'mono_gc_printf'
        fprintf (gc_log_file, format, ##__VA_ARGS__);   \
                                        ^~~~~~~~~~~
/s/mono/mono/metadata/w32file-unix.c:70:9: warning: 'INVALID_HANDLE_VALUE' macro redefined [-Wmacro-redefined]
        ^
/s/mono/mono/metadata/w32handle.h:19:9: note: previous definition is here
        ^
/s/mono/mono/metadata/handle.c:159:31: warning: 'extern' variable has an initializer [-Wextern-initializer]
extern MonoThreadInfo * const mono_thread_info_current_var = NULL;
                              ^
/s/mono/mono/metadata/sgen-mono.c:107:95: warning: cast to 'gpointer' (aka 'void *') from smaller integer type 'MonoGCDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
        SGEN_LOG (8, "Adding value remset at %p, count %d, descr %p for class %s (%p)", dest, count, (gpointer)m_class_get_gc_descr (klass), m_clas...
                                                                                                     ^
/s/mono/mono/metadata/sgen-mono.c:1741:83: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
                SGEN_LOG (6, "Profiler root scan %p-%p (desc: %p)", start_root, root->end_root, (void*)root->root_desc);
                                                                                                ^
/s/mono/mono/mini/helpers.c:72:9: warning: 'ARCH_PREFIX' macro redefined [-Wmacro-redefined]
        ^
/s/mono/mono/mini/helpers.c:68:9: note: previous definition is here
        ^
/s/mono/mono/mini/branch-opts.c:117:18: warning: unused variable 'int_cmov_opcodes' [-Wunused-const-variable]
static const int int_cmov_opcodes [] = {
                 ^
/s/mono/mono/mini/branch-opts.c:130:18: warning: unused variable 'long_cmov_opcodes' [-Wunused-const-variable]
static const int long_cmov_opcodes [] = {
                 ^
/s/mono/mono/mini/mini-arm.c:7363:1: warning: no previous prototype for function 'mono_arch_get_seq_point_info' [-Wmissing-prototypes]
mono_arch_get_seq_point_info (MonoDomain *domain, guint8 *code)
^
/s/mono/mono/mini/exceptions-arm.c:241:65: warning: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551612 to -4
      [-Wconstant-conversion]
        mono_add_unwind_op_offset (unwind_ops, code, start, ARMREG_LR, - sizeof (mgreg_t));
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/s/mono/mono/mini/mini-unwind.h:132:170: note: expanded from macro 'mono_add_unwind_op_offset'
  ...do { (op_list) = g_slist_append ((op_list), mono_create_unwind_op ((code) - (buf), DW_CFA_offset, (reg), (offset))); } while (0)
                                                 ~~~~~~~~~~~~~~~~~~~~~                                         ^~~~~~
/s/mono/mono/mini/interp/interp.c:1233:1: warning: unused label 'exit_pinvoke' [-Wunused-label]
exit_pinvoke:
^~~~~~~~~~~~~
/s/mono/mono/mini/interp/interp.c:1900:1: warning: unused label 'exit_icall' [-Wunused-label]
exit_icall:
^~~~~~~~~~~
/s/mono/mono/mini/interp/transform.c:1668:7: warning: unused variable 'called_inited' [-Wunused-variable]
                int called_inited = vt->initialized;
                    ^

/s/mono/mono/utils/mono-time.c:23:34: warning: unused variable 's_TimebaseInfo' [-Wunused-variable]
static mach_timebase_info_data_t s_TimebaseInfo;
                                 ^
/s/mono/mono/sgen/sgen-debug.c:1139:4: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'mword' (aka 'unsigned long long')
      [-Wformat]
                        safe_object_get_size (obj));
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-debug.c:37:30: note: expanded from macro 'safe_object_get_size'
                                ^
/s/mono/mono/sgen/sgen-descriptor.c:132:52: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
                SGEN_LOG (6, "Ptrfree descriptor %p, size: %zd", (void*)desc, stored_size);
                                                                 ^
/s/mono/mono/sgen/sgen-descriptor.c:145:70: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
                SGEN_LOG (6, "Largebitmap descriptor %p, size: %zd, last set: %d", (void*)desc, stored_size, last_set);
                                                                                   ^
/s/mono/mono/sgen/sgen-descriptor.c:156:80: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
                        SGEN_LOG (6, "Runlen descriptor %p, size: %zd, first set: %d, num set: %d", (void*)desc, stored_size, first_set, num_set);
                                                                                                    ^
/s/mono/mono/sgen/sgen-gc.c:1252:82: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int') [-Wint-to-void-pointer-cast]
                SGEN_LOG (6, "Precise root scan %p-%p (desc: %p)", start_root, root->end_root, (void*)root->root_desc);
                                                                                               ^
/s/mono/mono/sgen/sgen-nursery-allocator.c:800:114: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'mword'
      (aka 'unsigned long long') [-Wformat]
  ...SGEN_LOG (3, "Bastard pinning obj %p (%s), size: %zd", p, sgen_client_vtable_get_name (SGEN_LOAD_VTABLE (p)), sgen_safe_object_get_size (p));
                                                      ~~~                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                      %llu
/s/mono/mono/sgen/sgen-gc.h:143:69: note: expanded from macro 'SGEN_LOG'
                mono_gc_printf (sgen_gc_debug_file, "%s " format "\n", logTime, ##__VA_ARGS__); \
                                                                                  ^~~~~~~~~~~
/s/mono/mono/utils/mono-logger-internals.h:109:34: note: expanded from macro 'mono_gc_printf'
        fprintf (gc_log_file, format, ##__VA_ARGS__);   \
                                        ^~~~~~~~~~~

/s/mono/mono/sgen/sgen-pinning.c:213:117: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'mword'
      (aka 'unsigned long long') [-Wformat]
  ...SGEN_LOG (3, "Bastard pinning obj %p (%s), size: %zd", ptr, sgen_client_vtable_get_name (SGEN_LOAD_VTABLE (ptr)), sgen_safe_object_get_size (ptr));
                                                      ~~~                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                      %llu
/s/mono/mono/sgen/sgen-gc.h:143:69: note: expanded from macro 'SGEN_LOG'
                mono_gc_printf (sgen_gc_debug_file, "%s " format "\n", logTime, ##__VA_ARGS__); \
                                                                                  ^~~~~~~~~~~
/s/mono/mono/utils/mono-logger-internals.h:109:34: note: expanded from macro 'mono_gc_printf'
        fprintf (gc_log_file, format, ##__VA_ARGS__);   \
                                        ^~~~~~~~~~~

/s/mono/mono/metadata/w32file-unix.c:70:9: warning: 'INVALID_HANDLE_VALUE' macro redefined [-Wmacro-redefined]
        ^
/s/mono/mono/metadata/w32handle.h:19:9: note: previous definition is here
        ^

/s/mono/mono/metadata/handle.c:159:31: warning: 'extern' variable has an initializer [-Wextern-initializer]
extern MonoThreadInfo * const mono_thread_info_current_var = NULL;
                              ^
/s/mono/mono/metadata/sgen-mono.c:107:95: warning: cast to 'gpointer' (aka 'void *') from smaller integer type 'MonoGCDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
        SGEN_LOG (8, "Adding value remset at %p, count %d, descr %p for class %s (%p)", dest, count, (gpointer)m_class_get_gc_descr (klass), m_clas...
                                                                                                     ^
/s/mono/mono/metadata/sgen-mono.c:1741:83: warning: cast to 'void *' from smaller integer type 'SgenDescriptor' (aka 'unsigned int')
      [-Wint-to-void-pointer-cast]
                SGEN_LOG (6, "Profiler root scan %p-%p (desc: %p)", start_root, root->end_root, (void*)root->root_desc);

* PR: Remove comments.

* Preserve unsignedness of GC descriptor in logging.
2018-12-05 08:22:59 -08:00
Calvin Buckley 4af055c794 Fix PowerPC regression caused by tracing changes (#11907)
2b029b3df4 broke ppc JIT tracing by
moving it into mini and changing the arguments. Since the mini IR
emitter handles tracing now, rip out the tracing code from the JIT.

(Looks like SPARC will need a similar change, but someone needs to
love SPARC first.)
2018-12-05 15:48:35 +01:00
Kenneth Pouncey 6f5204f5f1 Remove errant binary. 2018-12-05 14:12:47 +01:00
Kenneth Pouncey 23e5688caf [wasm] Add browser test suite.
The existing tests work with JavaScript Engines and do not have any way to test code that works only in the browser.   The JavaScript Engines do not have access to any browser API’s so functionality like the WasmHttpMessageHandler can not be tested.

- Add test suite that uses Headless Chrome and Node.js with Karma.
- Allows testing the browser API.
2018-12-05 13:52:00 +01:00
Jay Krell d62f73a79d Fix warnings and race condition in time keeping. (#11862)
* Fix warnings and race condition in time keeping.

/s/mono/mono/utils/mono-time.c:23:34: warning: unused variable 's_TimebaseInfo' [-Wunused-variable]
static mach_timebase_info_data_t s_TimebaseInfo;

/s/mono/mono/utils/mono-time.c:112:1: warning: unused function 'get_boot_time' [-Wunused-function]

* Remove boot_time, unused since https://github.com/mono/mono/commit/06a4273d73cfa732d911bdaf50f752c025a0665c.
2018-12-04 22:43:41 -08:00
Jay Krell bd96170808 Fix always-true assertion. (#11863)
Alternatively, safer, since it never worked, remove it.

   /s/mono/mono/utils/mono-error.c:124:28: warning: comparison of constant 'MONO_ERROR_CLEANUP_CALLED_SENTINEL' (65535) with expression of type 'short' is always true [-Wtautological-constant-out-of-range-compare]
            g_assert (orig_error_code != MONO_ERROR_CLEANUP_CALLED_SENTINEL);
                      ~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixing this reveals problems in ves_icall_System_Threading_Thread_GetAbortExceptionState,
i.e. the repaired assert fails, so this depends on https://github.com/mono/mono/pull/11889.

Also cleanup and optimize nearby.
2018-12-04 18:24:22 -08:00
Jay Krell ad6de27b90 Fix more warnings. (#11853)
This isn't correct for Win64 but that should be ok.
It is correct for all other platforms.

/s/mono/mono/sgen/sgen-memory-governor.c:309:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->promoted_size / 1024,
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:310:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->major_size / 1024,
                                ^~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:311:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->major_size_in_use / 1024,
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:312:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->los_size / 1024,
                                ^~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:313:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->los_size_in_use / 1024);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:321:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->los_size / 1024,
                                ^~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:322:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->los_size_in_use / 1024);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:332:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->los_size / 1024,
                                ^~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:333:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->los_size_in_use / 1024);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:337:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->major_size / 1024,
                                ^~~~~~~~~~~~~~~~~~~~~~~~
/s/mono/mono/sgen/sgen-memory-governor.c:338:5: warning: format specifies type 'ssize_t' (aka 'long') but the argument has type 'unsigned int' [-Wformat]
                                entry->major_size_in_use / 1024);
                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/s/mono/mono/metadata/w32file-unix.c:4688:1: warning: no previous prototype for function 'ves_icall_System_IO_DriveInfo_GetDriveType' [-Wmissing-prototypes]
ves_icall_System_IO_DriveInfo_GetDriveType (const gunichar2 *root_path_name, gint32 root_path_name_length, MonoError *error)
^

/s/mono/mono/metadata/remoting.c:2143:1: warning: no previous prototype for function 'mono_context_set_icall' [-Wmissing-prototypes]
mono_context_set_icall (MonoAppContext *new_context_raw)
^

/s/mono/mono/mini/mini-posix.c:229:2: warning: unused variable 'ctx' [-Wunused-variable]
        MONO_SIG_HANDLER_GET_CONTEXT;

And beware icall-decl.h + Boehm producing:
w32file-unix.c:4905:16: error: implicit declaration of function 'GC_dlopen' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        libc_handle = dlopen ("/usr/lib/libc.dylib", 0);
                      ^
or, if you fix that, unreferenced symbol _GC_dlopen.
2018-12-04 16:18:02 -08:00
Jay Krell dd58c519e4 Fix warnings and a C++ error.
mono/master 32beba680e with no local edits

The C++ compilation was likely an accident and I'll try again after git clean.

jaymac1:mono jay$ cat sdks/Mak*g
ENABLE_CXX=1

will run again with git clean.

 make -C sdks/builds build-ios-cross32 build-android-cross-arm build-android-cross-x86

/s/mono/mono/mini/mini-llvm.c:7729:18: warning: unused variable 'iter' [-Wunused-variable]
                GHashTableIter iter;
                               ^
/s/mono/mono/mini/mini-llvm.c:7730:15: warning: unused variable 'method' [-Wunused-variable]
                MonoMethod *method;
                            ^
/s/mono/mono/mini/mini-llvm.c:7731:11: warning: unused variable 'callers' [-Wunused-variable]
                GSList *callers, *l, *l2;
                        ^
/s/mono/mono/mini/mini-llvm.c:7731:21: warning: unused variable 'l' [-Wunused-variable]
                GSList *callers, *l, *l2;
                                  ^
/s/mono/mono/mini/mini-llvm.c:7731:25: warning: unused variable 'l2' [-Wunused-variable]
                GSList *callers, *l, *l2;
                                      ^
/s/mono/mono/mini/mini-llvm.c:9022:13: error: cannot initialize a variable of type 'CallSite *' with an lvalue of type 'gpointer' (aka 'void *')
                CallSite *site = g_ptr_array_index (module->callsite_list, sindex);
                          ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/s/mono/mono/mini/mini-llvm.c:9002:17: warning: unused variable 'iter' [-Wunused-variable]
        GHashTableIter iter;
                       ^
/s/mono/mono/mini/mini-llvm.c:9004:10: warning: unused variable 'callers' [-Wunused-variable]
        GSList *callers, *l;
                ^
/s/mono/mono/mini/mini-llvm.c:9004:20: warning: unused variable 'l' [-Wunused-variable]
        GSList *callers, *l;
2018-12-04 17:09:10 -05:00
Alexander Köplinger feb342ae4f Add PathHelpers.cs to EXTRA_DIST to fix tarball build 2018-12-04 22:28:18 +01:00
Alexander Kyte 436a44a764 Merge pull request #11636 from alexanderkyte/crash_reporter_no_timeout
[crash] Force lldb/gdb traces to appear during hangs
2018-12-04 14:12:24 -05:00
Alexander Kyte 9994a181fd [crash] Early exit if callbacks not set (#11909) 2018-12-04 13:40:00 -05:00
Jay Krell eca15996c7 Remove extra percent from GSIZE_FORMAT.
Every user puts one on and the result does not work.
2018-12-04 11:03:20 -05:00
Marek Safar fa06ac818c [corlib] Make by-ref struct actually ref now C# supports them. (#11871)
* [corlib] Make by-ref struct actually ref now C# supports them.

This is technically breaking change but the types are already specialized
in C# compiler to be ref structs therefore the breaking change is more
theoretical than practical

* [mcs] Improves error reporting for special runtime types

* Bump API snapshot submodule
2018-12-04 16:53:08 +01:00
Rolf Bjarne Kvinge 632bb59b21 [System] Implement a helper function to create unique temporary directories and use it in tests. (#11831)
While working on PR #11829 I stress-tested the tests by running multiple test
runs in parallel, and it turned out that many tests were not parallel-safe,
because they used the same temporary file names and ended up stomping on
eachother.

So I implemented a helper method that creates a guaranteed unique temporary
directory, and I've changed all tests to use this new helper method.
2018-12-04 16:43:23 +01:00
Neale Ferguson 18fdc10cc1 Fix order of parameter processing. Note the offsets appear different to the size of the variables being passed but s390x will align parameters on 64-bit boundaries which is why the gbooleans appear to be treated as gulongs. (#11912)
Fix order of parameter processing. 

New parameter addition was put in wrong spot in the parameter list. Also the offsets on the stack were incorrect as 32-bit values are placed in 64-bit aligned slots on s390x. Therefore, even though these are gbooleans the appear to be treated as gulongs.



<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2018-12-04 10:15:57 -05:00
Bernhard Urban 2f17f4f2a2 [bcl] add fullaotinterp_llvm preset (#11847)
* [bcl] add fullaotinterp_llvm preset

That is, the AOT compiler uses the LLVM backend for BCL. AOT+LLVM is
used in the 'Release' configuration on Xamarin.iOS.

* [aot_full_interp_llvm] enable corlib tests
2018-12-04 09:56:36 -05:00
Kenneth Pouncey 8c32d109a0 [ci] Re-Enable V8 tests on wasm (#11929)
-  Found latest V8 version: v7.3.16.  Works

Resolves: https://github.com/mono/mono/issues/11908
2018-12-04 15:54:56 +01:00
Jay Krell ac688eaa5d Fix and cleanup ves_icall_System_Threading_Thread_GetAbortExceptionState.
In particular, to not fail asserts related to MONO_ERROR_CLEANUP_CALLED_SENTINEL,
which are currently missing or incorrect.
2018-12-04 09:54:42 -05:00
monojenkins cf7b6cfd5f [csproj] Update project files 2018-12-04 11:13:19 +01:00
Jb Evain 83d63bf181 [Mono.Debugger.Soft] Make exposing Cecil metadata an option 2018-12-04 11:13:19 +01:00
Jay Krell 88a1ffcf0d More mgreg_t to host_mgreg_t or target_mgreg_t conversion. (#11914)
* More mgreg_t to host_mgreg_t or target_mgreg_t conversion.
 Mostly target_mgreg_t.
Note that this is all optional, in the sense that cross compilers
never run their runtime. So mgreg_t is always target_mgreg_t, or
they are the same.
But agreement is to ban mgreg_t.
2018-12-03 23:40:05 -08:00
Zoltan Varga f24d652d56 [wasm] AOT work. (#11826)
* [bcl] Disable some tests under WASM.

* [bcl] Pass a stack mark through TypeSpec.Resolve ().

* [runtime] Avoid freeing an error which gets passed back from an icall.

* [wasm] Make Environment.GetCommandLineArgs () work. Allow excluding tests on the command line.

* Fix some stackframe tests.

* [wasm] Add a missing dependency to the ninja files.
2018-12-03 20:41:28 -05:00
Mikhail Pilin 2be08fc551 Fix race condition in XmlCharType.Instance (#11814) 2018-12-03 19:18:46 -05:00
Jay Krell 03f5674a36 Fix compilation errors targeting 32bit from 64bit host. (#11861) 2018-12-03 15:47:50 -08:00
Alexander Kyte 8ea3be0255 [runtime] Add waitpid to probed-for libc functions 2018-12-03 17:13:16 -05:00
Alexander Kyte 82e6bda20a [crash] Create supervisor thread for crash dumper 2018-12-03 17:13:16 -05:00
Alexander Kyte f2d5baf6cb [runtime] Make sure lldb/gdb dump happens when MERP fails 2018-12-03 17:13:16 -05:00
Jo Shields f885880f31 Bump version to 5.23 (#11911) 2018-12-03 22:26:36 +01:00
Shaan Nobee 9b4736d4c2 [mkbundle] Delete target directory if it exists before downloading runtime (#11876)
Fixes #11858
2018-12-03 18:30:12 +01:00
Alexander Köplinger fb2fea63fd [ci] Disable V8 tests on wasm
See https://github.com/mono/mono/issues/11908
2018-12-03 18:21:02 +01:00
Vlad Brezae e1720d0a01 [exceptions] Verbose logging for cfa_reg assertion (#11888)
[exceptions] Verbose logging for cfa_reg assertion

Historically very common and hard to reproduce assertion, which, in some cases, could be fixed just from this logging. Log example :

```
Unset cfa_reg in method <0x40011220 - (null) trampoline>. Memory around ip (0x40011220):
0x40011210  41 89 07 4c 8b 3c 24 48 83 c4 08 c3 00 00 00 00  A..L.<$H........
0x40011220  48 83 c7 10 b8 00 12 01 40 ff e0 00 00 00 00 00  H.......@.......
0x40011230  00 00 00 00 e8 c7 ef fe ff 08 f8 34 e0 55 55 55  ...........4.UUU
0x40011240  00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
* Assertion: should not be reached at unwind.c:664
```
2018-12-03 11:55:53 -05:00
Alexander Köplinger 191421603b [ci] Support more OS combinations on Helix 2018-12-03 16:26:26 +01:00
Calvin Buckley f840e00f12 Fix lack of symbols in System.Native support lib on AIX (#11905)
I forgot to fix Makefile.am to check for AIX and include the unix
sources if so. Actually fixes #11895.
2018-12-03 14:40:09 +01:00
Jay Krell 3ecdd17b01 Use target offset in mono_get_delegate_virtual_invoke_impl. (#11886) 2018-12-03 14:39:19 +01:00
Jay Krell 1fa43b7cd2 Layout should not be host-sensitive, only target-sensitive. (#11885)
* Layout should not be host-sensitive, only target-sensitive.

* Always set target_sizeof_void_p.
2018-12-03 14:36:36 +01:00
Jay Krell 16baa4d205 Fix = vs. ==. (#11897) 2018-12-03 14:34:36 +01:00
Alexander Köplinger 30fbfa8c37 Add System.Buffers facade to framework assemblies list
Looks like it was forgotten.
2018-12-03 14:30:56 +01:00
Calvin Buckley 3f3c217519 Build System.Native for AIX/i (#11896)
This will probably be needed in the future; and attempts to solve
the issue with System.Random not working when running under Jenkins.
2018-12-03 12:28:45 +01:00
Jay Krell bfb314165a Fix https://github.com/mono/mono/issues/11898 (#11899)
Fix https://github.com/mono/mono/issues/11898
This regressed six months ago at https://github.com/mono/mono/pull/9503/files#r238093574.

There are two identical sounding functions:

mono_string_handle_to_utf8:
  What we usually use. Sounds reasonable. Usually is reasonable.
  Allocates with malloc.

mono_string_to_utf8str_handle:
  What should be used here. Allocates with CoTaskMemAlloc.
  So it can be freed with marshal_free => CoTaskMemFree.

i.e. The allocator and the freeer need to agree.
2018-12-03 12:20:22 +01:00
Johan Lorensson 876f22d159 Merge pull request #11873 from lateralusX/lateralusX/windows-increase-llvm-compile-rate
Increase number of compiled LLVM methods on Windows x64.
2018-12-03 09:04:13 +01:00
monojenkins c99d2de68e [csproj] Update project files 2018-12-02 09:19:53 +01:00
Martin Baulig b8f8423139 Bring the internal 'NTAuthentication' class. 2018-12-02 09:19:53 +01:00
Alexander Köplinger 793f24a07a [configure.ac] Only use AM_EXTRA_RECURSIVE_TARGETS when available (#11877)
It's only available in automake 1.13+. Since we only use it for tests
we can just make it optional on systems with earlier automake.

Fixes https://github.com/mono/mono/issues/11809
2018-12-02 03:18:58 +01:00
monojenkins 0679e4b052 [bcl] Update BCL Linked Size 2018-12-01 10:50:03 +01:00
Jay Krell 1c4d949128 Cross AOT: sizeof(gpointer) vs. sizeof(target_mgreg_t), sizeof(MonoTypedRef) vs. MONO_ABI_SIZEOF. (#11868) 2018-11-30 16:56:35 -08:00
Alexander Kyte cde8093a65 Merge pull request #11864 from jaykrell/do-not-truncate-merp-data
Do not truncate 64bit MERP hashes to 32bits.
2018-11-30 17:40:07 -05:00
Jay Krell b04d891826 Remove gratuitious ifdef and fix warning. (#11839) 2018-11-30 14:38:18 -08:00
Jay Krell d23a54bc87 [arm] [jit] s/mgreg_t/target_mgreg_t/ for clarity. (#11869) 2018-11-30 13:57:30 -08:00
Martin Baulig e14a67696f [corlib]: Bring Random from CoreFX and add RandomNumberGenerator.Fill(Span<byte>). (#11797)
This adds some `Span<byte>` overloads to `Random` and `RandomNumberGenerator`.

Part of #7737
2018-11-30 21:46:44 +01:00
Maxim Lipnin 0a86e39c9b [reflection] Import MethodBase from CoreFX (#11837)
Part of #9660.
2018-11-30 17:58:42 +01:00
lateralusX 3e77f33e0a Increase number of compiled LLVM methods on Windows x64.
* Add support for additional calling conventions supported on Windows x64.
* Add support for more call info storage types used on Windows x64.
2018-11-30 16:06:18 +01:00
Henric Müller ba89f8df45 Hide detection fixes for events
Removing BindingFlags checks from native code to instead
trust the checks made in managed code. This fixes the case
when events were incorrectly returned from types that
have overridden private or static events.
2018-11-30 15:08:32 +01:00
Jay Krell 4e34b6a8fd Do not truncate 64bit MERP hashes to 32bits.
This might invalidate all existing data however and perhaps 32bits is enough.

/s/mono/mono/utils/mono-merp.c:227:63: warning: format specifies type 'unsigned int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
    g_string_append_printf (output, "BlameModuleOffset: 0x%x\n", merp->moduleOffset);
							  ~~     ^~~~~~~~~~~~~~~~~~
							  %zx
/s/mono/mono/utils/mono-merp.c:231:59: warning: format specifies type 'unsigned int' but the argument has type 'guint64' (aka 'unsigned long long')
  [-Wformat]
    g_string_append_printf (output, "StackChecksum: 0x%x\n", merp->hashes.offset_free_hash);
						      ~~     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
						      %llx
/s/mono/mono/utils/mono-merp.c:232:55: warning: format specifies type 'unsigned int' but the argument has type 'guint64' (aka 'unsigned long long')
  [-Wformat]
    g_string_append_printf (output, "StackHash: 0x%x\n", merp->hashes.offset_rich_hash);
						  ~~     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
						  %llx

The first one isn't really a truncation but fix the warning.
Or use guint32 for module offsets instead of size_t.
2018-11-30 01:48:58 -08:00
Vlad Brezae 9c6d733449 [interp] Fix rethrow (#11844)
* [interp] Remove some useless code

* [interp] Remove useless variable

When unwinding, we get the last interp frame that was executing from the LMF marker.

* [interp] Rethrow from the actual ip

Before we would rethrow from ip - 1 which could be part of another clause, screwing up EH.

* [interp] Enable all bcl disabled tests
2018-11-30 11:22:11 +02:00
monojenkins 7c01f6f583 [bcl] Update BCL Linked Size 2018-11-30 10:02:01 +01:00
Marek Safar da38380007 Bump linker 2018-11-30 09:55:14 +01:00
Marek Safar 7a8ae2dd27 Adds more tests 2018-11-30 09:55:14 +01:00
Marek Safar e07794921c [tools] Update linker arguments 2018-11-30 09:55:14 +01:00
Jay Krell c8b8a16e43 Get lasterror before messing with gc mode. (#11520) 2018-11-29 22:38:45 -08:00
Vlad Brezae 8e0cf9bcfb [tests] More test updates for interp/fullaotinterp (#11838)
* [tests] Include corlib suite on fullaotinterp

Disable more appdomain tests on fullaotinterp

* [interp] Bump again trampoline number for fullaotinterp

It wasn't enough for corlib and System.Core suites
2018-11-30 01:24:51 +02:00
Zoltan Varga 9c4f2281e2 [runtime] Use a separate implementation of mono-mmap.c for wasm, the default mmap based implementation doesn't work because munmap () cannot free memory inside mappings. (#11840) 2018-11-29 18:02:54 -05:00
Marek Safar 32beba680e [Facades] Updated netstandard facade 2018-11-29 22:04:37 +01:00
Jay Krell b1058550ed [Coop] Convert System_IO_DriveInfo. (#11519) 2018-11-29 12:54:27 -08:00
Martin Baulig 72ab774236 "Code Ultramarine": sync X509Certificate2 with CoreFX and introduce X509Certificate2ImplUnix (#9705)
Sync `X509Certificate2` implementation with CoreFX, similar to how we did for `X509Certificate` in "Blue" (#9650).

* Introducing `X509Certificate2ImplUnix` as new common base class for `X509CertificateImplApple`, `X509CertificateImplBtls` and `X509Certificate2ImplMono`.  This uses the internal `CertificateData` class from CoreFX instead of the old "fallback" implementation from "Mono.Security".

* `MonoBtlsProvider`, `X509CertificateImplBtls`: the "fallback" option has been removed since we now always provide this functionality via the managed `CertificateData`.

* `X509CertificateImplMono`: This has been largely stripped down to use the new `X509CertificateImplUnix`.
2018-11-29 21:20:29 +01:00
Jay Krell 2129059951 Fix some warnings. Mostly benign but driver.c looks maybe crashy. (#11843)
```
abcremoval.c: In function 'process_block':
abcremoval.c:1061:6: warning: variable 'inst_index' set but not used [-Wunused-but-set-variable]
  int inst_index;
      ^

driver.c: In function 'mini_regression_step':
driver.c:514:12: warning: 'func' may be used uninitialized in this function [-Wmaybe-uninitialized]
     result = func ();
            ^

aot-compiler.c: In function 'emit_method_info':
aot-compiler.c:6388:10: warning: variable 'method_index' set but not used [-Wunused-but-set-variable]
  guint32 method_index;
          ^

mini-codegen.c: In function 'mono_print_ins_index_strbuf':
mini-codegen.c:727:3: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'gpointer' [-Wformat=]
   g_string_append_printf (sbuf, " %s", ins->inst_p1);
   ^
  CC       libmini_la-mini-exceptions.lo
mini-exceptions.c: In function 'summarize_frame':
mini-exceptions.c:1556:25: warning: unused variable 'ud' [-Wunused-variable]
  MonoSummarizeUserData *ud = (MonoSummarizeUserData *) data;
```

Probably from:
https://jenkins.mono-project.com/job/build-package-dpkg-mono-pullrequest/label=ubuntu-1404-amd64/326/console
2018-11-29 20:38:32 +01:00
Alexis Christoforides c8e3ba4e4e [driver] Parse config file under --regression mode also (#11845)
As of https://github.com/mono/mono/pull/11342 the regression tests (builtin-types.cs) call into System.Native incidentally as part of Interop.Sys type initialization. The --regression command line option was causing the --config part of the mono invocation to be ignored, resulting in a buried 'System.DllNotFoundException: System.Native' during the test run,
2018-11-29 13:55:16 -05:00
Alexander Köplinger eb53bbe805 [ci] Don't pass Helix API token for telemetry in PR builds 2018-11-29 18:45:11 +01:00
Ludovic Henry e8c423ec2b [sdks] Reduce android provisioning to minimum + Rework targets generation (#11835)
* [sdks] Reduce android provisioning to minimum

It's not in use by XA anymore, so we only care about what we require

* [sdks] Rework targets generation
2018-11-29 09:30:59 -08:00
Johan Lorensson 27d1568d21 Merge pull request #11786 from lateralusX/lateralusX/windows-llvm-60-windows-x64
Windows x64 LLVM 6.0 support.
2018-11-29 15:46:34 +01:00
Alexander Köplinger 8cb2c03352 [ci] Move Linux x64 C++ to Helix 2018-11-29 15:35:57 +01:00
Zoltan Varga 1337d2e044 [jit] Refactor call code. (#11775)
* [jit] Refactor the constrained call handling code into a separate function. NFC.

* [jit] Move the low level call related code to calls.c. NFC.

* [jit] Use mini_emit_get_rgctx_klass () in a few more places.

* [jit] Add calls.c to common_sources.

* Fix some c++-isms.

* Fix the windows build.
2018-11-29 09:18:37 -05:00
Rolf Bjarne Kvinge c93db5b047 [System] Refactor tests to use system-assigned ports whenever possible. (#11829)
Refactor tests to use system-assigned ports whenever possible, so that we
avoid the potential race condition in NetworkHelpers.FindFreePort.

This should make it much less probable to run into spurious "Address already
in use" exceptions.

In some cases I kept the call to NetworkHelpers.FindFreePort:

* When the test is not binding/listening on a port, but instead trying to
  connect to an inexistent port (for tests that verifies error handling /
  exceptions). In this case there is still a race condition (if a test tries
  to verify that a connection fails, it may unexpectedly succeed instead).

* Sometimes the test doesn't actually use the port (the test is verifying
  something very different, for instance a ArgumentNullExceptions, which are
  thrown before the port is used).

* Some API doesn't allow for requesting a system assigned port:

    * HttpListener: in this case I elected to re-try a few times in case of
      "Address already in use" exceptions.

    * The 'UdpClient (string, port)' constructor (other constructors work
      fine): these turned out a bit complicated to work around (or would
      modify the test more than would be reasonable), so for these we still
      have to hope for the best.

Hopefully fixes https://github.com/xamarin/maccore/issues/604.
2018-11-29 14:02:07 +01:00
Martin Baulig 374925522b [corlib]: Bring "HashAlgorithm" from CoreFX. (#11794) 2018-11-29 13:32:02 +01:00
Alexander Köplinger 9ebde410b5 [corlib] Disable AllEncodingsAreSerializable on mobile
We won't have all encodings on mobile by default.
2018-11-29 12:44:41 +01:00
lateralusX e4e30da77f Fix review feedback. 2018-11-29 10:42:05 +01:00
Egor Bogatov 787f1bc69c [NS2.1] Import some primitive System.Drawing types from CoreFX (#11658)
* Import Color and friends from CoreFX

* Fix some tests

* SystemColors.cs from CoreFX

* bump corefx

* ignore reflection tests

* fix System.Web tests

* bump corefx

* remove files

* fix mobile platforms

* fix mobile build

* fix mobile build

* fix mobile build

* fix mobile build

* Bump API snapshot submodule

* [csproj] Update project files
2018-11-29 09:12:32 +01:00
monojenkins 3b47ac2e9a [csproj] Update project files 2018-11-29 08:58:20 +01:00
Martin Baulig 89e599bc6f Misc corefx sources (ReadOnlyMemoryStream and CertificateHelper). 2018-11-29 08:58:20 +01:00
Egor Bogatov 1d0189d778 [corlib] Make all Encoding types serializable (#11661)
Fixes https://github.com/mono/mono/issues/11529 
Fixes https://github.com/mono/mono/issues/11663
2018-11-29 08:48:59 +01:00
Alexander Köplinger fab1f8e19b Update csproj 2018-11-29 02:30:49 +01:00
Calvin Buckley 5e08e6a1d4 Revert usage of gcc builtin for icache flush on ppc (#11815)
This is a no-op on gcc ppc for AIX, Linux, and FreeBSD, and should
not be used until gcc implements this. (It *does* on ARM, RISC-V,
Alpha, and MIPS, however - but not PowerPC or x86, based on a skim
of gcc source.)

Should fix #11527.
2018-11-28 20:04:55 +01:00
Rolf Bjarne Kvinge 212bfe90f1 [System] Use pid-specific X509Store names in tests to make it possible to run multiple System test runs in parallel. (#11830)
While working on PR #11829 I stress-tested the tests by running multiple test
runs in parallel, and it turned out that the X509StoreTest is not parallel-safe.

This fixes the X509StoreTest test to parallel-safe.
2018-11-28 19:20:34 +01:00
Marek Safar cd69b727d0 [build] Fixes documentation build profile dependency (#11801) 2018-11-28 17:47:59 +01:00
Alexander Kyte fb42448b70 [runtime] Integrate BenchmarkDotNet for in-tree microbenchmarks (reapply of #9833) (#11813) 2018-11-28 17:13:07 +01:00
Alexander Kyte aae4a8d8fc [runtime] Fix return of uninit value (#11823)
We have a return on line 3608 that doesn't have an
obvioius assignment to the variable "o" before that.
2018-11-28 10:41:10 -05:00
Vlad Brezae 53672c5f4c [interp] Enable System.Xml tests (#11791)
* [tests] Change timezone so it doesn't fail on UTC+2 systems

Change to remote UTC-1

* [interp] Enable System.XML tests
2018-11-28 07:19:08 -08:00
Jérôme Laban bcf63dcb9a Add the packager --search-path parameter (#11396)
- Adds the ability for the packager to search in additional folders when resolving assemblies.
- Ignore missing symbols when resolving assemblies, which can happen for facade assemblies.
2018-11-28 07:08:58 -08:00
Vlad Brezae aa8ea8026d [interp] Fix interp inline (#11824)
[interp] Fix interp inline


<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2018-11-28 09:55:41 -05:00
Vlad Brezae 9cf13ee9e5 [interp] Enable System.Data tests on fullaotinterp (#11798)
* [interp] Enable System.Data tests on fullaotinterp

* [csproj] Update project files
2018-11-28 15:50:01 +02:00
Vlad Brezae e17958b140 [arm] Add enough trampolines for fullaotinterp mode (#11811)
Fixes a few bcl tests suites.
2018-11-28 15:19:09 +02:00
monojenkins 5514c173c3 [bcl] Update BCL Linked Size (#11819)
Size Diff: https://jenkins.mono-project.com/job/test-mono-mainline-bclsize/149/BCL_20Size_20Diff/

Commits since last run: 31b8fa1...8b605414d1f9eeff781ed0b4d628acd5287296b7
2018-11-28 12:33:51 +01:00
Martin Baulig f3706b57ee Move "NegotiateStreamPal" from "System.Data" into "System". (#11778)
Make System internals visible to System.Data and move some of the internal
GSS sources into System.
2018-11-28 12:29:04 +01:00
Maxim Lipnin 5cdc152df8 [corlib] Type from CoreFX (#11665)
Part of #7737
2018-11-28 12:00:50 +01:00
Alexander Kyte 892cad1dab Merge pull request #11790 from alexanderkyte/fixup_merp_exc_type
[crash] Add managed exception class name
2018-11-27 19:55:58 -05:00
Alexander Köplinger 8b605414d1 [ci] Add workaround for Helix SDK not setting external visibility on PRs when using authentication 2018-11-28 00:41:19 +01:00
Vlad Brezae 34781da14e [interp] Enable System.Web.Services tests on fullaotinterp (#11800) 2018-11-28 00:42:20 +02:00
Vlad Brezae 51b977699f [runtime] Check for error to prevent overwrites (#11812)
Fixes crash in corlib suite on fullaotinterp
2018-11-28 00:42:03 +02:00
Alexander Kyte 67f2491e77 [crash] Add managed exception class name 2018-11-27 14:50:03 -05:00
Alexander Köplinger 1f6c9272fe Revert "[runtime] Integrate BenchmarkDotNet for in-tree microbenchmarks (#9833)"
This reverts commit e15b8c53ff.

It broke other builds.

Revert "[bench] Revert hardcoding of microbenchmarks to run-jenkins (#11787)"

This reverts commit 7a81ac67a2.
2018-11-27 13:46:23 +01:00
lateralusX 6f987dd44d Bump to latest Mono LLVM commit to include needed Windows x64 changes. 2018-11-27 10:33:32 +01:00
monojenkins 0de674c2dc [csproj] Update project files 2018-11-27 09:21:34 +01:00
Marek Safar b7e8278eb5 Bump linker 2018-11-27 09:21:34 +01:00
Vlad Brezae 21f9aeeef4 [interp] Fix fullaotinterp exceptions (#11760)
* [interp] Check for exception if we always catch it in coop case

* [interp] Enable more fullaotinterp tests

billions and billions

* [interp] Reorganize tests for fullaotinterp

* [interp] Don't include internal frames in stack trace

For handled exceptions. On unhandled exceptions we leave them for debugging purposes.

Fixes exception18.cs
2018-11-27 10:20:41 +02:00
Alex Earl 2c4859839e Fix #11779
This adds any base interfaces to the remoting TypeInfo to match the
behavior of MS.NET
2018-11-27 09:05:51 +01:00
Alexander Köplinger 94d4055773 [ci] Disable log compression in pipeline builds for now - second attempt 2018-11-26 21:53:55 +01:00
Alexander Kyte 7a81ac67a2 [bench] Revert hardcoding of microbenchmarks to run-jenkins (#11787) 2018-11-26 12:38:15 -08:00
Alexander Kyte e15b8c53ff [runtime] Integrate BenchmarkDotNet for in-tree microbenchmarks (#9833)
Don't merge, using my fork of the BenchmarkDotNet repo so I can use a not-yet-merged hack to fix the build.
2018-11-26 12:34:26 -08:00
Alexander Köplinger fb4b611636 [ci] Disable log compression in pipeline builds for now
It is incompatible with JEP-210 at the moment.
2018-11-26 17:42:57 +01:00
Alexander Köplinger d4f2bc598c [ci] Bump nunit-lite submodule to fix csc warning 2018-11-26 17:24:55 +01:00
lateralusX 8548b21a92 Make used environment variables local to test scripts. 2018-11-26 17:24:35 +01:00
lateralusX 99eb69b14b Build additional LLVM backends and tools on Windows. 2018-11-26 17:23:39 +01:00
lateralusX c702820e14 Fix msvc build warnings. 2018-11-26 17:23:27 +01:00
lateralusX a2bf8b2a07 Fix assert under LLVM debug builds due to mismatched types.
When doing AOT build of builtin-types.exe using a debug compiled LLVM build the
following assert occurs:

Assertion failed: C1->getType() == C2->getType() &&
"Operand types in binary constant expression should match",
file C:\github\mono\external\llvm\lib\IR\Constants.cpp, line 1717.

This happens due to an optimization in cfold.c that removes the widening
done to a const variable in C:\github\mono\mono\mini\mini-native-types.c@224
and when that variable is later used in 64-bit LLVM lowering of OP_LNEG, OP_LNOT
they mismatch the static const 64-bit int used as operands triggering the assert.

Fix is to make sure the operand used when lowering these opcodes are converted
to matching operands.
2018-11-26 17:23:05 +01:00
lateralusX 6d0af3c44d Fix stack corruption when using nullable types in dyncall.
Incorrect calculation of start of nullable buffer caused stack corruption.
Currently this was only identified on Windows x64 due to use of alternative
ABI register storage types. Fix resolves crash in test_0_dyncall_nullable.
2018-11-26 17:22:50 +01:00
lateralusX 536cd702ed Fix LLVM linker flags for 6.0. 2018-11-26 17:22:31 +01:00
Zoltan Varga 99f9565d62 [runtime] Add stack marks to a few icalls. (#11774)
* [runtime] Add a mono_runtime_get_caller_from_stack_mark () function, use it in a few places. NFC.

* [bcl] Add a stackMark argument to AppDomain.Load () calls.
2018-11-26 16:52:49 +01:00
Bernhard Urban f396735a83 [mini] use AOT trampolines in interp mixed mode (#11767)
[mini] use AOT trampolines in interp mixed mode

Fixes this on mscorlib/mixed mode on Xamarin.iOS:
```
[FAIL] NonExceptional.Serialization_Deserialization : System.Runtime.Serialization.SerializationException : An error occurred while deserializing the object. The serialized data is corrupt. 
[FAIL] NonExceptional.Serialize_Deserialize_FixedDateRule : System.Runtime.Serialization.SerializationException : An error occurred while deserializing the object. The serialized data is corrupt. 
[FAIL] NonExceptional.Serialize_Deserialize_FloatingDateRule : System.Runtime.Serialization.SerializationException : An error occurred while deserializing the object. The serialized data is corrupt. 
[FAIL] SerializationTests.Serialization_Deserialization : System.Runtime.Serialization.SerializationException : An error occurred while deserializing the object. The serialized data is corrupt. 
[FAIL] TimeZoneTest.CurrentTimeZone_SerializationRoundtrip : System.Runtime.Serialization.SerializationException : An error occurred while deserializing the object. The serialized data is corrupt. 
```
2018-11-26 08:55:42 -05:00
monojenkins 31b8fa1bc8 [bcl] Update BCL Linked Size 2018-11-23 09:10:27 +01:00
Zoltan Varga 53cc61669a [jit] ABCREM improvements. (#11761)
[jit] ABCREM improvements.
2018-11-23 02:45:33 -05:00
Zoltan Varga 53cf7bb3c6 [jit] Rename MONO_PATCH_INFO_INTERNAL_METHOD to MONO_PATCH_INFO_JIT_ICALL. (#11758) 2018-11-22 21:52:42 -05:00
Alexander Köplinger 59eba95b90 Add MKINSTALLDIRS for 4.7.1-api and 4.7.2-api
Not strictly necessary but for consistency.
2018-11-22 15:13:29 +01:00
Yvan Janssens e709b687b1 [aix/ibmi] Fix for PR#11704 (#11757)
@kadler addressed a mistake related to the difference between POWER5 and POWER5_ANDUP wrt. capabilities detection.

This PR should fix this. 

Context: https://github.com/mono/mono/pull/11704#discussion_r235525330
2018-11-22 13:11:07 +01:00
Aleksey Kliger 9ac5844ad4 [loader] ignore 'internalcall' impl attribute on 'abstract' methods
Otherwise we emit a noisy warning when doing a lookup of the method.

Fixes https://github.com/mono/mono/issues/11479
2018-11-22 09:52:08 +01:00
monojenkins 5419b07457 [bcl] Update BCL Linked Size 2018-11-22 09:51:25 +01:00
Zoltan Varga 7067ed1910 [corlib] Refactor Type:GetName () to reduce differences with refsources and make it easier to add support for stack marks later. (#11154)
* [corlib] Refactor Type:GetName () to reduce differences with refsources and make it easier to add support for
stack marks later.

Move the icall to RuntimeTypeHandle. Pass a unused stack mark and a unused reflectionOnly parameter.

* Bump API snapshot submodule
2018-11-22 02:56:01 -05:00
Vlad Brezae 765f462bb4 [interp] Add inlining of small methods (#11735)
[interp] Add inlining of small methods

Avoid call overhead by inlining small methods. We replace stinarg opcodes with storing of the arguments in locals allocated in the parent frame (for each argument).

TODO
- support for methods with locals
- maybe add inline costs to prevent over inlining

On microbenchmark inlining can improve up to 3.5x (less than the 5x that I observed with jit).

Contributes to #11531
2018-11-21 11:15:35 -05:00
Alexander Köplinger b6a2f252fc [tools] Fix build of mono-shlib-cop test.dll 2018-11-21 15:48:49 +01:00
monojenkins 1236b908a4 [bcl] Update BCL Linked Size 2018-11-21 09:50:24 +01:00
Zoltan Varga 8fee89e530 [WIP] [WASM] AOT work (#11746)
[bcl] Use the UTF8 encoding on WASM by default, similarly to ios.
2018-11-21 02:02:35 -05:00
Calvin Buckley d94c842496 System.Net.NetworkInformation.NetworkInterface backend for AIX (#9454)
Yes, I do know of a possible refactor, but why not get this working? This will enable `System.Net.Sockets.Socket` to depend IPv4/IPv6 are working, and thus, fix a LOT of issues on CI; a bunch of test suites have one or two things that depend on loopback, which is currently busted unless you nop out Socket's protocol check.

Also made a note that the Mac version of the backend is actually likelier to work under other OSes. Structures are kinda ugly, but they work; it took a whole morning and night beating them into submission.

Untested under PASE, though I've marked notes for self to what's different. (My guess: it works, but not as well as it should - but good enough so that Socket starts working again.)

And hey, the Mac backend can't do this!

```
csharp> NetworkInterface.GetAllNetworkInterfaces().Select(x => $"The MTU of {x.Name} is {x.GetIPProperties().GetIPv4Properties().Mtu}");
{ "The MTU of en0 is 1500", "The MTU of lo0 is 16896" }   
```
2018-11-21 03:11:17 +01:00
Alexander Köplinger 9cf3782449 [tests] Propagate runtime exit code in test_op_il_seq_point.sh (#11749)
We weren't checking whether the runtime returned a zero exit code which
means if the compilation failed we still reported success.

Now the exit code is propagated all the way up and we report an error
both to make and to the xml result file.

Since iltests.exe contains a test with expected invalid IL this would
now cause a failure. The easiest fix is to just move that test from
mono/mini to mono/tests since all other tests are fine.

Fixes https://github.com/mono/mono/issues/11091
2018-11-21 02:17:23 +01:00
Aleksey Kliger f63d97d384 [loader] Use Request structs to pass arguments to the loader
Try to make all entry points into the loader look more uniform by taking a request
struct instead of a big pile of arguments.  Where it makes sense, make the
structs subtypes of each other so that more general arguments are shared.

- Pass assembly load arguments in a struct
- Pass assembly open arguments in a struct
- Push MonoAssemblyOpenRequest creation to some callers
- Drop is_private argument to try_load_from
   It's been dead code for ten years since c9e8bac0c3
- Get rid of mono_assembly_open_a_lot
- Drop dead static function
- Replace mono_assembly_load_full_nosearch by mono_assembly_request_byname_nosearch
- replace mono_assembly_load_full_internal by mono_assembly_request_byname
- Make mono_assembly_request_byname the internal API
   pass a no_postload_search flag in MonoAssemblyByNameRequest, usually FALSE.
   Pass TRUE in the one caller of the old mono_assembly_request_byname_nosearch.
- Pass the requesting assembly via MonoAssemblyByNameRequest
- Prepare loader Requests with an initialization function
2018-11-20 18:45:20 -05:00
markusbeth 60d0977c65 prevent endless recursion in ListView.ToString() (#11049) (#11561)
prevent endless recursion in ListView.ToString()

do not access the Items[] in ListView.ToString() in VirtualMode
as this might cause an endless recursion if ToString() is called
from within the RetrieveVirtualItem event handler

Fixes #11049
2018-11-20 15:45:33 -05:00
Aleksey Kliger e9987df5bd [tests] Add some Type.IsByRefLike tests 2018-11-20 08:20:05 -05:00
Aleksey Kliger f20445ba0b [reflection] make t.MakeByRefType().IsByRefLike == False
Fixes https://github.com/mono/mono/issues/11693
2018-11-20 08:20:05 -05:00
Zoltan Varga d2028ba041 [arm64] Fix passing r4/r8 arguments on the stack in the gsharedvt trampoline. (#11741)
Fixes https://github.com/mono/mono/issues/11613.
2018-11-20 04:30:07 -05:00
Zoltan Varga 3241199830 [runtime] Initialize MethodBody objects by calling a ctor instead of accessing the object directly. This allows the MethodBody type to be removed by the linker. (#11730)
* [runtime] Initialize MethodBody objects by calling a ctor instead of accessing the object directly. This allows the MethodBody type to be removed by the linker.

* [bcl] Preserve CustomAttributeData and related types using PreserveDependency attributes on the GetCustomAttributesDataInternal () icall.

* Fix a test.

* Fix C++ build failures.

* Bump API snapshot submodule
2018-11-20 03:09:51 -05:00
Zoltan Varga c7a71ca4bd [WIP] [WASM] Ongoing AOT work. (#11728)
* [wasm] Add the declaring types assembly name to the mangled name for instances during dedup. Fixes failures when two assemblies have a generic type with the same name.

* [runtime] Rename MONO_WRAPPER_UNKNOWN to MONO_WRAPPER_OTHER.

* [aot] Make the aot name mangling a little denser.

* [wasm] Don't emulate lojg shifts/multiplications.

* [runtime] Fix warnings.

* [aot] Small cleanups to the dedup code:

* Fix the dedup logging in llvmonly mode.
* Split mono_compile_assembly () into 2 functions, the second one doing the emission.
* Split the setting of cfg->skip from emit_code ().
* Skip more code and some logging for the other assemblies in the dedup-include case.

* [jit] Do the conversion to JIT intrinsics somewhat earlier.

This is needed to avoid emitting the code for passing the mrgctx etc. for
generic intrinsics like RuntimeHelpers.IsReferenceOrContainsReferences ().

* [aot] Implement sharing of gsharedvt wrappers passing/receiving
valuetype arguments based on their layout.

This is done by replacing valuetypes with instances of the
newly added Mono.ValueTuple generic structures inside the
wrappers. For example, for the type:
struct FooStruct {
  int i; object o;
}
and the gsharedvt out wrapper:
gsharedvt_out (ref FooStruct v);

This will be replaced by:
gsharedvt_out (ref ValueTuple<int, object> v);

The two structures have the same layout so as far as the JIT is
concerned, they are identical.

* [aot] Share native int/native uint with int32/uint32 in gsharedvt wrappers on 32 bit platforms.

* [bcl] Make the Mono.ValueType structs internal.
2018-11-20 02:21:21 -05:00
Aleksey Kliger 90a3ca90a2 Bump corefx 2018-11-19 15:26:04 -05:00
Aleksey Kliger d3778a8b7c [reflection] Parse error if rank > 1 array contains *
Can either have a multi-dimensional array type or an array with a lower
bound, not both.  (eg `System.Int32[,,]` vs `System.Int32[*]`, but not `System.Int32[*,]`)

Fixes https://github.com/mono/mono/issues/11684
2018-11-19 15:26:04 -05:00
Ludovic Henry f1b7f3969b Revert " [sdks] Add mac-{mac32,mac64} and ios-tools64 targets" (#11734)
* Revert "[wasm][binding] Allow the cleanup of transparent/bridged marshalled objects causing leaks. (#11660)"

This reverts commit 75741eb68d.

* Revert "[wasm] Add the declaring types assembly name to the mangled name for instances during dedup (#11724)"

This reverts commit 63fb96c61a.

* Revert "[runtime] Skip sentry upload when tool fails to build (#11726)"

This reverts commit cb690285fb.

* Revert "[sdks] Add mac-{mac32,mac64} and ios-tools64 targets (#10964)"

This reverts commit 6f1537ef58.
2018-11-19 08:52:19 -05:00
Kenneth Pouncey 75741eb68d [wasm][binding] Allow the cleanup of transparent/bridged marshalled objects causing leaks. (#11660)
- Example: When a delegate is marshalled to JS it is allocated so that it is not GC'd.  Since we do not know when JS is finished with the delegate we need a way, for right now, to tell the Runtime to de-allocate the object and remove the transparent/bridged instance from JS as well.  The side-effect of not doing this is that any local that is captured (used) by a lambda became heap memory and were allocated as fields on the object.  Since the delegate is never a candidate for GC the local that was captured was never released either.

- Fix an error with Windows Edge and Windows IE that threw an exception `Object doesn't support this action` on certain host objects.  This only affected Windows Edge and IE when using the JavaScript delete operator to clean up an object after being disposed.

- Cleanup marshalled Tasks after completion.  The marshalled tasks and their continuation objects were never un-allocated thus not allowing them to be GC'd.
2018-11-19 13:08:07 +00:00
Zoltan Varga 63fb96c61a [wasm] Add the declaring types assembly name to the mangled name for instances during dedup (#11724)
Fixes failures when two assemblies have a generic type with the same name.
2018-11-19 13:55:18 +01:00
Alexander Kyte cb690285fb [runtime] Skip sentry upload when tool fails to build (#11726) 2018-11-19 13:54:24 +01:00
Ludovic Henry 6f1537ef58 [sdks] Add mac-{mac32,mac64} and ios-tools64 targets (#10964) 2018-11-19 13:52:34 +01:00
Alexander Köplinger 5e45e77fbf [ci] Use correct casing in Helix queue names 2018-11-19 13:20:28 +01:00
myfreeweb b60b724963 Add support for FreeBSD/aarch64 (#11638)
Add support for FreeBSD/aarch64

(I also needed the #7017 workaround and a boringssl patch for auxval stuff, but this is the important part.)
2018-11-19 06:25:31 -05:00
Ludovic Henry aa0d921232 [sdks] Add monotouch_tools profile + Add mono-api-info and pdb2mdb to monodroid_tools profile (#11707)
* [sdks] Add monotouch_tools profile

* [sdks] Add mono-api-info and pdb2mdb to monodroid_tools profile

* [csproj] Update project files
2018-11-18 22:58:54 -05:00
Alexander Köplinger f30ce1cbce [bcl] Add missed Helix tests for vts tests and System.Web.Extensions-standalone (#11720)
Missed those while converting the tests to Helix.
2018-11-17 01:35:59 +01:00
Egor Bogatov ab0736fa79 [NS2.1] IntPtr, UIntPtr, Encoding, Enum, Random, Thread, System.Net primitives (#11674)
* NS21: Encoding, Thread, UIntPtr, IntPtr, Enum, Random

* some http primitives

* undo Random

* add more Runtime tests

* bump corefx

* update tests

* Update corlib_xtest.dll.sources

* Bump API snapshot submodule

* [csproj] Update project files
2018-11-16 18:11:50 -05:00
Alexander Köplinger 6283c6337d Revert "[ci] Don't try sentry upload after a failed build"
This reverts commit 0853179237.
It's actually still useful in cases where the "build" profile worked but
a later profile crashed.
2018-11-16 21:29:58 +01:00
Alexander Köplinger 0853179237 [ci] Don't try sentry upload after a failed build
It won't work cause the uploader wasn't built yet.
2018-11-16 21:26:24 +01:00
Nikita Voronchev 1076d746b9 [WinForms] Matching Mono PropertyGrid behaviour with .Net one (#11618) 2018-11-16 14:29:43 -05:00
HebaruSan e743a7fd74 [WinForms] Really fix ToolStrip background (#11287)
## Problem

Even after #10942, menus and toolstrips still look awful with a dark theme:

![toolstrip](https://user-images.githubusercontent.com/1559108/46361551-8e6dea80-c633-11e8-97d1-242612b4b5cf.png)

## Previous attempt

#10942 was a first stab in the dark at what was going on here, before I managed to get mono to compile for testing. I was hopeful that it would address this, but the problem was different.

## Another red herring

Later I thought the problem might be that `SystemColors.ButtonFace.IsSystemColor` was `false`. It looked like this might have caused the runtime to interpret `ButtonFace`'s special 168 value as an RGB code instead of a system color marker.

This fix had no effect (see below for true cause), but I'll include it anyway; the lower bound of the upper system colors block needs to decrease from 170 to 168 to allow `ButtonFace` and `ButtonHighlight` to be considered system colors:

https://github.com/mono/mono/blob/44db64c620c2c957a49b3f5a69cb09c19c1c8c1a/mcs/class/System.Drawing/System.Drawing/KnownColor.cs#L200-L203

## Actual cause

The toolstrip color comes from `ProfessionalColorTable.ToolStripGradientBegin` and `ProfessionalColorTable.ToolStripGradientEnd`. The latter color is hard coded to a light shade, but the former defaults to `SystemColors.ButtonFace`.

These are the colors that are loaded from the GTK system theme:

https://github.com/mono/mono/blob/b104565ccfde477fc7b6308f2d3e4efff0af5848/mcs/class/System.Windows.Forms/System.Windows.Forms/X11DesktopColors.cs#L111-L116

Note that `ButtonFace` is not among them. This means that it uses a compile time default, and is not a good choice for the background of a control. `ToolStrip` is using it anyway, but other controls use `SystemColors.Control` instead.

## Changes

There are two obvious ways to fix this:

1. Use `SystemColors.Control` instead of `SystemColors.ButtonFace` in `ProfessionalColorTable`
2. Load `SystemColors.ButtonFace` from the system theme

This pull request does both. In addition, it also sets the other end of the toolstrip gradients to `SystemColors.ControlLight` instead of a hard coded value. The choice of `ControlLight` was made because in those cases where alternate hard coded values were available for both sides of the gradient, the "other" side was consistently lighter. Now it looks better:

![image](https://user-images.githubusercontent.com/1559108/47258840-efd0ee80-d466-11e8-842f-2fed8b3b9d82.png)
2018-11-16 20:09:20 +01:00
HebaruSan 89b1b8d049 Draw menu background with SystemColors.Menu to fix dark themes (#11301)
## Problem

Dropdown menus have light text on a light background in a dark theme:

![image](https://user-images.githubusercontent.com/1559108/47260376-2e26d780-d480-11e8-8330-86ecc82994df.png)

## Cause

The background is rendered here:

https://github.com/mono/mono/blob/4a6b11577fe06a58e6326b1c3a3bb58cfee6185c/mcs/class/System.Windows.Forms/System.Windows.Forms/ToolStripProfessionalRenderer.cs#L372-L375

`this.ColorTable.ToolStripDropDownBackground` is set to either `SystemColors.Window` or various hard coded shades of near-white in `ProfessionalColorTable`.

## Changes

Now that color comes from `SystemColors.Menu`, defined as "[Gets a Color structure that is the color of a menu's background](https://docs.microsoft.com/en-us/dotnet/api/system.drawing.systemcolors)", which looks better in a dark theme:

![image](https://user-images.githubusercontent.com/1559108/47260394-77772700-d480-11e8-85ad-03be8a59e56e.png)

It still looks fine in a normal theme as well:

![image](https://user-images.githubusercontent.com/1559108/47260396-7cd47180-d480-11e8-8989-4ee9448e9d05.png)

KeePass is not affected by this change, presumably thanks to its custom toolstrip renderer.
2018-11-16 20:07:55 +01:00
Aleksey Kliger (λgeek) be9a2f6303 [threading] Implement 'pulse' transition for two-phase STW (#11708)
* [threading] Add `pulse` transition and begin_pulse_resume_and_request_suspension operation.

A `pulse` atomically resumes a preemptively suspended GC Safe thread and
requests that it suspend again.

If the thread reaches a GC Safe -> GC Unsafe transition, it will self-suspend.
If it doesn't, another iteration of the 'mop up' STW phase will async suspend
it again.

* [threading] Use pulse_resume_and_request_suspension in STW

With non-hybrid suspend, a pulse is just a resume.

With hybrid suspend, a `pulse` is a combination of a resume of a preemptively
suspended GC Unsafe thread and a request that it suspend again - as if we
atomically resumed the thread and then applied the initial phase of two-phase
suspend again.  If the now-running thread comes to a GC Safe -> GC Unsafe
transition it will suspend.  If not, we will preemptively suspend it again
during the mop-up phase.

The important thing is that we don't want the thread to transition to GC Unsafe
again: if it does so, it may try to take a lock that some other
async-suspended thread is holding, and it will never reach a safepoint ---
exactly the situation that two-phase suspend is supposed to solve.

* [threads] Add mono_threads_is_multiphase_stw_enabled

Flip the logic in mono_thread_info_begin_pulse_resume_and_request_suspension
2018-11-16 12:47:45 -05:00
Alexander Köplinger 30ad7cde21 [upload-to-sentry] Skip reading assemblies without mono_crash.json and silence no symbols error (#11696)
The previous code read all the .dll and .exe files even when there actually wasn't any mono_crash.*.json file to process.

In the happy case of no crash file this cuts the time from 60s to 5s.

We can also use more efficient patterns in Directory.GetFiles() instead of getting _all_ files and filtering in-memory.

Lastly we also ignore printing a message when a debug symbols file wasn't found for an assembly, this is an expected case for a lot of our assemblies.
Using InMemory Cecil reading shaves another 20s off.
2018-11-16 16:46:37 +01:00
Bernhard Urban 5ed1bf1a52 [interp] attempt to intrinsify again after a method is resolved regarding generics (#11712)
[interp] attempt to intrinsify again after a method is resolved regarding generics

discovered when running https://github.com/Clancey/gMusic
2018-11-16 10:05:43 -05:00
Yvan Janssens 2cad522dcd [aix/ibmi] Build broken due to subtle difference between i and AIX
PASE is the Unix subsystem of IBM i, and is binary compatible with AIX. Since IBM i is not a Unix, there are some subtle differences between both environments.

There is an issue with the way PASE on IBM i 7.2 behaves differently than AIX with regards to the POWER_n_ANDUP defines for CPU compatibility. When trying to build on i as opposed to AIX, the following errors appear which break the build:

```
make[5]: Entering directory '/home/YVANJ/mono-on-i/mono/mono/utils'
  CC       libmonoutils_la-mono-hwcap-ppc.lo
mono-hwcap-ppc.c: In function 'mono_hwcap_arch_init':
mono-hwcap-ppc.c:67:6: error: implicit declaration of function '__power_4_andup' [-Werror=implicit-function-declaration]  if (__power_4_andup())
      ^~~~~~~~~~~~~~~
mono-hwcap-ppc.c:67:2: warning: nested extern declaration of '__power_4_andup' [-Wnested-externs]
  if (__power_4_andup())
  ^~
mono-hwcap-ppc.c:69:6: error: implicit declaration of function '__power_5_andup' [-Werror=implicit-function-declaration]  if (__power_5_andup())
      ^~~~~~~~~~~~~~~
mono-hwcap-ppc.c:69:2: warning: nested extern declaration of '__power_5_andup' [-Wnested-externs]
  if (__power_5_andup())
```

This commit adds `#ifdef`s to handle this condition so the build works on IBM i 7.2 now. The resulting application code should not differ from the AIX output, however, this patch fixes the build failure.
2018-11-16 14:56:36 +01:00
Alexander Köplinger a8b06539d5 [corlib] Fix xunit tests build for System.Reflection.TestModule.dll
test_lib_dir is only defined after the library.make include so we need
to move the logic further down.

Additionally we don't even need to build this assembly ourselves since
corefx already contains a prebuilt binary.
2018-11-16 14:31:02 +01:00
Mads Kruse Johnsen 7f5e358971 [wcf] do not assume that message body is always Wrapped (#11694)
Currently, setting IsWrapped=false on a MessageContract leads to an error in serialization due to an empty element being present where the wrapper element would have been, instead of it being gone entirely.
The serialization then fails because the empty string is not valid localName (which of course is fine).
2018-11-16 12:31:00 +01:00
Bernhard Urban 30bb12fa2a [aot] image is usable without debug flag when interpreter is used (#11705) 2018-11-16 12:14:52 +01:00
Johan Lorensson 71418eb6b0 Merge pull request #11666 from lateralusX/lateralusX/windows-llvm-support
Integrated LLVM build as part of Visual Studio Mono runtime build.
2018-11-16 07:59:59 +01:00
Alexander Kyte 7b3a6a4579 [crash] Remove duplicated il_offset (#11700) 2018-11-15 23:22:58 +01:00
Alexander Köplinger 178696df1c Fix tarball build
The helix binaries weren't getting included so the uploader tool failed to build.
While we don't need them for a tarball build it's easier to just include them.
2018-11-15 20:08:39 +01:00
Maxim Lipnin 462bd6781e [Reflection] CoreFX import for Module type (#11577)
* [Reflection] CoreFX import for Module type

* Bump corefx

* Fix incorrect merge

* Bump corefx

* Update corlib_xtest.dll.sources

* Revert corert bump

* Bump corert

* Bump xunit-binaries

* Use NotImplemented.ByDesign

* Remove redundant class modificators

* Make the output for TestModule.dll assembly profile specific

* Update path to include TestModule.dll assembly

* Bump API snapshot submodule

* [csproj] Update project files
2018-11-15 13:19:01 -05:00
Alexander Köplinger 041c2d0d66 [bcl] Remove unused DISABLE_CAS_USE and AGCLR define (#11695)
* [bcl] Disable unused DISABLE_CAS_USE and AGCLR define

* [csproj] Update project files
2018-11-15 17:26:33 +01:00
Aleksey Kliger (λgeek) 9fb668bfc8 [configure] Pass -stdlib=libc++ to clang on darwin to build C++ code (#11673)
[configure] Pass -stdlib=libc++ to clang on darwin to build C++ code

On iOS 6.0 (`-miphoneos-version-min=6.0`), this is needed to get modern C++11
headers like `<type_traits>`.  It does not seem to harm anything to
over-approximate and pass it to clang always when building on Darwin.
2018-11-15 10:56:37 -05:00
Zoltan Varga 83fd9e41f0 [runtime] Fix the size calculation in mono_debug_add_method (). (#11672) 2018-11-15 16:10:19 +01:00
Jonathon Rossi 0cdb35fa47 Fix starting process with empty environment incorrectly inherits all variables (#11630)
This pull request fixes starting a process with an empty environment variable collection in `ProcessStartInfo`. As per the issue it fixes a regression that it used to work but currently an empty environment variable collection works like it was never touched.

I also made a minor fix to remove the `StringBuilder` because a simple `string.Concat` does the job without the `StringBuilder` allocation and overhead.

I've included unit tests. Please let me know if you'd like any changes.

Fixes #8766
2018-11-15 16:06:26 +01:00
Rodrigo Kumpera aa50145d12 [metadata] Compute interface offsets of ginst by inflating the GTD instead of doing it from the grounds up. (#10931)
* [metadata] Compute interface offsets of ginst by inflating the GTD instead of doing it from the grounds up. Fixes #10837

Say you have;
```
interface Bar<T> { T Bla(); }
class Foo<A,B>: IBar<A>, IBar<B> {
	int IBar<int>.Bla)() { ... }
}
```

The GTD of Foo will have the following interface offsets table:
```
4: IBar<A>
5: IBar<B>
```

With the existing code, if you have Foo<int,int> the interface offsets table will look like this:
```
4: IBar<int>
```

The problem with that is it will produce a hole in the vtable and subclasses of Foo<int,int> will have not on slot 5.

That would be just wasteful, unless you have this:

```
class Sub: Foo<int,int>, IBar<int> {
	int IBar<int>.Bla)() { ...  }
}
```

IOW, a subclass that overrides the interface implementation in Foo. The problem is that it's not always reliable to which iface offset
calls to `IBar<int>` will go through and thus it's possible to have calls made against instances of `Sub` to execute the code from its base
class.

The solution is to inflate the interface offsets table from the gtd as that will preserve the number of entries and will cause the
rest of the vtable layout code to fill the duplicated slots correctly.

* Add regression test for #10837.

* [sre] Replace assert with proper error handling.

* [metadata] Don't mono_class_init ifaces, just have offsets setup.

* [metadata] Make setup_interface_offsets not depend on mono_class_init and fix lazy iid computation.

All that interface offset setup needs are iid as the output in interfaces_packed is sorted by it. Remove
the need to use mono_class_init by properly extracting and making iid setup lazy.

Beyond that, make mono_get_unique_iid not return 0 as a valid iid.
Otherwise we don't have a proper sentinel value when lazily computing iid.

* [metadata] Keep interfaces in the same relative order when computing offsets

qsort() is not guaranteed to be a stable sort (one that keeps elements with the
same key in the same order).  For example, the msvc qsort isn't stable.

Add an insertion_order field to ClassAndOffset to keep interfaces with the same
interface_id in the same relative order.

This is all relevant because in setup_interface_offsets we could see the same
interface multiple times (for example, with generics) at different offsets.
2018-11-15 07:39:06 -05:00
Alexander Köplinger 90c80dd026 [ci] Use "Build" as the queue name for Helix telemetry events 2018-11-15 01:50:21 +01:00
roozbehid 8b4f331e1d [wasm] add IIIIIIIIIIIII signature to managed2native transitions (#11659)
* add more calling up to 12 arguments

* use m2n-gen to generate it. also more cases which I encountered were added

* remove duplicate cookie
2018-11-14 17:46:47 -05:00
Alexis Christoforides 10c7e9f722 [System] Add FSEvent FileSystemWatcher to 'monotouch' BCL profile (#10809)
* [System] Add FSEvent FileSystemWatcher to 'monotouch' BCL profile

* [csproj] Update project files
2018-11-14 08:55:31 -05:00
Zoltan Varga eddc1d3990 [wasm] Rename the cross targets so 'wasm-cross' builds the 64 bit compiler, and 'wasm-cross-32' builds the old 32 bit version. (#11678) 2018-11-14 08:42:28 -05:00
Mads Kruse Johnsen 0ade173b9b [wcf] pass on the ContentType of MTOM message response (#11664) 2018-11-14 11:50:48 +01:00
Martin Baulig 1b02237c8f [System.Data]: GSS is not available on tvOS and watchOS. (#11671)
* [System.Data]: GSS is not available on tvOS and watchOS.

* [csproj] Update project files
2018-11-14 11:09:05 +01:00
lateralusX e6123028ae Fix scenario before cygconf.h has been created in build-init. 2018-11-14 09:42:44 +01:00
Zoltan Varga 930fa40957 [wasm] Ongoing AOT work. (#11637)
[wasm] Ongoing AOT work.
2018-11-14 00:25:39 -05:00
Ludovic Henry 5187b0bdaa [sdks] Compile support/{zlib-helper,nl}.c so XI/XM/XA does not have to cherry-pick them (#11599)
* [sdks] Compile support/{zlib-helper,nl}.c so XA doesn't have to cherry-pick it.

* [sdks] Fix ios and android compilation and use of tests

The tests are already built as part of the archive, so there is no need to recompile them. We just need to pick them from the right folder.
2018-11-13 22:06:04 -05:00
Vlad Brezae 6b858ef9d7 [interp] Small fixes (#11667)
[interp] Small fixes


<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2018-11-13 19:05:36 -05:00
Mikayla Hutchinson c2b6caf04d Add meaningful resource strings for System.Web.Services (#11624)
* Add meaningful resource strings for System.Web.Services

Generated from mcs/class/referencesource/System.Web.Services/System.Web.Services.txt
using resx2sr

Also adds support for txt files and custom class names to resx2sr

Fixes #11623

* [csproj] Update project files

* [resx2sr] fix formatting

* [resx2sr] fix formatting

* [resx2sr] fix formatting

* [resx2sr] fix formatting

* [resx2sr] fix formatting
2018-11-13 17:04:54 -05:00
Alexander Köplinger 67ed831661 [ci] Add sentry upload to run-test-helix.sh too 2018-11-13 22:19:34 +01:00
Alexander Köplinger b429e290e8 [ci] Use different way of cleaning acceptance-tests/external
Some jobs pre-clone repositories into acceptance-tests/external, those
would be removed. We don't need to do that, all we want is to have
clean submodule repos so just cd into the repos and clean them.
2018-11-13 21:40:06 +01:00
Alexander Köplinger d4952011ea [ci] Remove MONO_HELIX_CREATOR and v4 suffix and fix sentry upload on build error
Setting the creator isn't needed, Helix defaults to using the API key user.
2018-11-13 21:02:31 +01:00
Alexander Köplinger 14e1e717ae [System.Web] Add optional shared FileSystemWatcher's to CacheDependency
Right now we create a separate FileSystemWatcher for each file in
CacheDependency. On systems where inotify handles are limited this
leads to problems. As a workaround we can share the FSW which watches
the same directory. Since this wasn't extensively tested, hide it behind
and environment variable.

We enable this in the Helix environment only for now.
2018-11-13 21:02:31 +01:00
Alexander Köplinger c408741000 [ci] Add targets to bundle tests and add a script to run them in Helix
The test-bundle target copies all assets needed for test execution
to a specified directory. We upload this directory to Helix and use it
to run our mainline tests.
2018-11-13 21:02:31 +01:00
Alexander Köplinger dcc2d172e9 [tools] Add client for sending jobs to Helix
This uses the Helix SDK to create jobs in the Helix environment.
2018-11-13 21:02:31 +01:00
Bernhard Urban 43b5f8c3ae [mini] rename s/__mono_ilp32__/MONO_ARCH_ILP32 (#11652) 2018-11-13 09:50:24 -05:00
Bernhard Urban 81924df99a [arm] fix --enable-minimal=aot build (#11653)
[arm] fix --enable-minimal=aot build

mentioned here: https://github.com/mono/mono/issues/8430#issuecomment-437041383
2018-11-13 09:45:44 -05:00
lateralusX ab33926c89 Fix LLVM install target in Visual Studio build. 2018-11-13 15:39:28 +01:00
Alexander Kyte 672249512b [sentry] Gracefully handle protocol version mismatches (#11655) 2018-11-13 15:18:50 +01:00
lateralusX de5b6bb8d1 Re-enable Ninja build for Visual Studio LLVM. 2018-11-13 14:59:30 +01:00
lateralusX 2ba737914e Use one msbuild worker as default for LLVM/BTLS Visual Studio build. 2018-11-13 14:44:52 +01:00
lateralusX 0227590612 Enable Win32 path variable when using with-llvm on cygwin. 2018-11-13 14:40:13 +01:00
lateralusX cca5d0d0f4 Reduce default LLVM/BTLS Visual Studio build output. 2018-11-13 14:38:49 +01:00
Neale Ferguson b7adce8049 Simplify retrieving TLS offset 2018-11-13 11:08:19 +01:00
Bernhard Urban 8e10108d9f [wasm] add ILI signature to managed2native transitions (#11646)
[wasm] add ILI signature to managed2native transitions

Mentioned here https://github.com/mono/mono/issues/8711#issuecomment-437764245
2018-11-12 20:15:33 -05:00
Alexander Köplinger 49a5af74f7 [ci] Clean acceptance-tests/external before build
Otherwise it might have left-over files from previous builds since it
uses our custom submodule system which isn't catched by Jenkins cleaning.
2018-11-13 00:19:07 +01:00
Alexander Köplinger 3a4c3e8cee [ci] Don't show apidiff/csproj diff step if it's not executed 2018-11-12 18:33:57 +01:00
Alexander Köplinger 2edec383b5 [ci] Move sentry reporting to the run-test-* scripts
So a "no-tests" build doesn't try to do sentry uploading.
2018-11-12 17:59:50 +01:00
lateralusX 9728edf5cc Align LLVM/BTLS Visual Studio external builds. 2018-11-12 16:28:23 +01:00
Alexander Köplinger d901e8ab9c [ci] Move apidiff and csproj diff out from run-test-default.sh
Due to new Jenkins job layering.
2018-11-12 15:27:35 +01:00
lateralusX 269d02cf5b Add support for LLVM integrated build as part of Visual Studio solution
build. LLVM build follows similar pattern as BTLS build and will be build
as part of regular Visual Studio build Mono runtime if LLVM has been enabled
through the autogen.sh, --enable-llvm or –with-llvm argument. It is also
supports msbuild properties MONO_ENABLE_LLVM, MONO_EXTERNAL_LLVM_CONFIG,
if Visual Studio Mono runtime has been built without using autogen.sh.
When just using –enable-llvm, LLVM build will try to build internal LLVM
branch under external/llvm or if override has been set in props file
(using MONO_INTERNAL_LLVM_SOURCE_DIR), an alternative LLVM source
directory path. If –with-llvm has been used pointing to an llvm-config.exe,
no internal LLVM will be build, but the external LLVM build will be used.
Needed LLVM executables (opt.exe, llc.exe) will be installed into regular
Visual Studio Mono runtime build output directory.

The internal Mono LLVM 6.0 release will build as part of changes to this
commit, but it has not yet been fixed to work as expected during runtime.
That work will be done in different commit. The Mono LLVM 3.6 branch will
however work as expected for Windows x64 and can be setup and used using
–with-llvm argument or build as part of Visual Studio build Mono runtime
by enabling msbuild properties, MONO_ENABLE_LLVM and
MONO_INTERNAL_LLVM_SOURCE_DIR.
2018-11-12 15:16:14 +01:00
Bernhard Urban 207a67ae22 [ios] cosmetic fix for WatchOS Makefile (#11639)
It's not really used, and the directory `[...]/SDKs/WatchOS.sdk` always
exists.
2018-11-11 22:02:22 -05:00
Bernhard Urban 06e00cd38d [wasm] add DDI signature to managed2native transitions (#11642)
Mentioned by a user here: https://github.com/mono/mono/issues/8711#issuecomment-437638741
2018-11-11 22:00:48 -05:00
Kenneth Pouncey 521b8a0b3c [wasm] Make WasmHttpMessageHandler the default handler for WebAssembly (#11631)
* Clean up leaks in the WasmHttpMessageHandler.

- Most of the leaks present themselves during a Cancel of a streaming request.

* Make WasmHttpMessageHandler the default handler for WebAssembly

-  Required libraries WebAssembly.Net.Http.dll and WebAssembly.Bindings.dll.

* Clean up spacing
2018-11-11 22:00:18 -05:00
Alexander Köplinger 5d2525527e Add common "test" target for precompiling test assemblies (#11622)
So we can precompile all tests across the repo using a simple "make test" in the root.
2018-11-12 00:37:11 +01:00
Bernhard Urban 95a26ebff9 [mini] rename INTERP_FILTER_METHOD to REGRESSION_FILTER_METHOD and accept it for all execution engines (#11594)
So this is possible now:

```console
$ REGRESSION_FILTER_METHOD=test_0_return ./mono/mini/mono-sgen --single-method=inline ./mono/mini/basic.exe
$ # or
$ REGRESSION_FILTER_METHOD=test_0_return ./mono/mini/mono-sgen --regression --interp ./mono/mini/basic.exe
```
2018-11-09 21:59:36 -05:00
Marek Safar 02e71d52de More codeowners updates 2018-11-09 21:14:03 +01:00
Henric Müller 037c8be1b6 Bumping reference assemblies generated with latest GenAPI (#11628)
This PR bumps the reference assemblies submodule to bring in private dummy fields in structs and should fix #7859.
2018-11-09 14:34:08 +01:00
Henric Müller 79820d638d Updating GenAPI binaries (#11629)
Bumping api-snapshot submodule which brings in a newly
built GenAPI binaries along with a rename of the exe
to Microsoft.DotNet.GenAPI.exe
2018-11-09 14:32:40 +01:00
Kenneth Pouncey 2bdadca909 Clean up leaks in the WasmHttpMessageHandler. (#11616)
- Most of the leaks present themselves during a Cancel of a streaming request.
2018-11-09 07:14:22 -05:00
monojenkins da2646c366 [bcl] Update BCL Linked Size 2018-11-09 09:50:52 +01:00
Bernhard Urban 43c37db845 [llvm] bump for armv5 fix (#11621)
[llvm] bump for armv5 fix

Commit list for mono/llvm:

* mono/llvm@76f65d611f Merge pull request #17 from lewurm/armv5-fix
* mono/llvm@a864c603a2 [mono] respect FloatABIType, so it will work on armv5

Diff: https://github.com/mono/llvm/compare/c97510286a58f9aaa116fcfdb8b693d5f61910d2...76f65d611fbf31890d79fd278e89cd889bf1c497
2018-11-09 02:25:36 -05:00
Zoltan Varga d768d8a571 [runtime] Add __attribute__(format) to glib string formatting functions, fix -Wformat warnings/errors exposed by the change. (#11611)
[runtime] Add __attribute__(format) to glib string formatting functions, fix -Wformat warnings/errors exposed by the change.
2018-11-08 15:15:39 -05:00
Zoltan Varga af0191cde0 [interp] Add a null check to MINT_LDELEMA. (#11606)
Fixes https://github.com/mono/mono/issues/11603.
2018-11-08 13:41:47 -05:00
Bernhard Urban a8a7a3401a [llvm] bump for armhf callingconv fix (#11607)
Commit list for mono/llvm:

* mono/llvm@c97510286a [mono] respect hardfloat/softloat setting in ARM ABI (#16)

Diff: https://github.com/mono/llvm/compare/8415fd85ce1570d4ba0a735bc4e968735a67ca37...c97510286a58f9aaa116fcfdb8b693d5f61910d2


Fixes https://github.com/mono/mono/issues/11095
2018-11-08 13:36:00 -05:00
Calvin Buckley 6d1b2316b8 Fix wasm mono showing print dialog twice on error (#11602)
Fixes #11596.
2018-11-08 13:36:01 +01:00
Marek Safar 3d47946343 [corlib] Removes dead code from EventInfo (#11502) 2018-11-08 12:58:05 +01:00
Marek Safar 46b36bf842 [sdks] Document one more build setting 2018-11-08 12:32:20 +01:00
Marek Safar df6056cd63 [corlib] Move Stack and Queue to mscorlib as we want to used them by (#11511)
* [corlib] Move Stack and Queue to mscorlib as we want to used them by

implementation code in mscorlib

* Bump API snapshot submodule

* [csproj] Update project files
2018-11-08 12:17:07 +01:00
Rodrigo Kumpera f5cb39880a unbreak the interp build. 2018-11-08 10:52:47 +01:00
Marek Safar 30e2d0974d [wasm] Move bundled linker to different location
Right now it's in same location as wasm implementation assemblies
which means they are used for execution but they are not .NET desktop
compatible.
2018-11-08 09:43:59 +01:00
Zoltan Varga ec545dcfd5 [wasm] Avoid referencing aot-dummy.dll in non-aot mode. (#11600) 2018-11-08 01:44:24 -05:00
Bernhard Urban e8aa7a2b73 initial RISC-V support (#11593)
initial RISC-V support

I rebased @alexrp's work (https://github.com/alexrp/mono/commits/riscv) and added stubs so this minimal example works in the interpreter:

```console
$ qemu-riscv64 ./mono/mini/mono-sgen --version
Mono JIT compiler version 5.21.0 (riscv/f4802305009 Wed Nov  7 02:58:20 PST 2018)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
        TLS:           __thread
        SIGSEGV:       normal
        Notifications: epoll
        Architecture:  riscv64,double-fp
        Disabled:      none
        Misc:          
        Interpreter:   yes
        Suspend:       preemptive
        GC:            sgen (concurrent by default)
$ export MONO_PATH=../mono-riscv-bclbuild/b/lib/mono/4.5 
$ grep -A 2 test_0_return mono/mini/basic.cs
        public static int test_0_return () {
                return 0;
        }
$ INTERP_FILTER_METHOD=test_0_return qemu-riscv64 ./mono/mini/mono-sgen --interp --regression basic.exe
Test run: image=/home/lewurm/work/mono-riscv/basic.exe
Results: total tests: 1, all pass 
Elapsed time: 0.002441 secs (0.002441, 0.000000)

Overall results: tests: 1, 100% pass
```
2018-11-07 15:04:00 -05:00
Zoltan Varga f0fe3fc426 [corlib] Move the runtime internal state to MonoModule from Module. Bump corlib version. (#11586) 2018-11-07 19:44:50 +01:00
Alexander Köplinger ab9c940dff [android sdk] Package resource assemblies into app bundle (#11583)
.NET resource assemblies live in subdirectories named after the culture
of the resource. We need to package these assemblies too.

Follow up to https://github.com/mono/mono/pull/11575
2018-11-07 13:42:06 -05:00
Zoltan Varga e14d92437e [jit] Move a few DISABLE_JIT stubs to arch-stubs.c. (#10991) 2018-11-07 13:41:07 -05:00
Alexander Köplinger 993f9bb39d Upgrade xunit to version 2.4 (#11595)
It contains the fix for a bug which makes NUnit xml parsing fail on Jenkins
2018-11-07 17:06:00 +01:00
Alexander Köplinger 5eb4698bb2 Bump corert 2018-11-07 13:28:27 +01:00
Marek Safar bc27aa23b7 Updates codeowners (#11592) 2018-11-07 13:06:46 +01:00
Alexander Kyte 5e318afd2e [runtime] Fix llvm arm autodetection / fix build (#11172)
[runtime] Fix llvm arm autodetection / fix build
2018-11-07 04:35:46 -05:00
monojenkins 5753014eed [bcl] Update BCL Linked Size 2018-11-07 09:34:15 +01:00
Alexis Christoforides 46a28303e2 [corlib] Import System.IO.Stream/BufferedStream from CoreFX (#10880)
* [corlib] Import System.IO.Stream/BufferedStream from CoreFX

* Bump API snapshot submodule

* [csproj] Update project files
2018-11-06 23:54:19 -05:00
Bernhard Urban 22143c7916 [icalls] remove DISABLE_POLICY_EVIDENCE (#11565)
[icalls] remove DISABLE_POLICY_EVIDENCE

Originally it was introduced with https://github.com/mono/mono/commit/db3591bb93dfe913c39ff73b95194effb88c880a . It seems like only the icall definitions were disabled for device runtimes (which aren't shipped there anyway), however the icalls themselves are _included_ in the device runtime. Note that the definitions are available to the AOT compiler.

Not sure what the rationale was behind this. Since the original change is very old, I think it just happened to be like that today. When running with the interpreter we need the icalls definitions at run-time available too (via the optional icall table that is linked in, so no additional cost for the fullAOT runtime due to this change).

Also remove `HANDLES_MAYBE` since it isn't needed anymore.

I think eventually we want to have `--enable-minimal=policy_evidence` that _also_ excludes the actual icalls, but this will need changes on the BCL side as well.
2018-11-06 15:55:48 -05:00
Alex Earl 5d5d8fc7ea Bump roslyn-binaries submodule to pull in System.Xml.dll file name fix in vbc.rsp (#11573) 2018-11-06 21:40:40 +01:00
Zoltan Varga 7356b0914a [sdks] Exit with non-zero exit code if the simulator test fails on ios. (#11547) 2018-11-06 20:48:06 +01:00
Alexander Köplinger 30e870b19e [ios sdk] Package resource assemblies into app bundle (#11575)
.NET resource assemblies live in subdirectories named after the culture
of the resource. We need to package these assemblies too.

Addresses https://github.com/mono/mono/pull/11547#issuecomment-435688914
2018-11-06 19:43:09 +01:00
Bernhard Urban 2f749688f7 [interp] enable delegate-with-null-target.exe (#11570)
It was fixed by https://github.com/mono/mono/pull/11433

Related: https://github.com/mono/mono/issues/6861
2018-11-06 11:18:15 -05:00
Egor Bogatov 14cb53030d Don't override default LLVM's opt & llc args via llvmopts-add and llvmllc-add commands (#11556)
Don't override default LLVM's opt & llc args via llvmopts-add and llvmllc-add commands

Currently we can pass custom arguments to LLVM's `opt` and `llc` via:
```
mono --aot=llvm,llvmopts="...",llvmllc="..."
```
but those completely override the default arguments mono uses (some of them are required).
E.g. lets say I need to add `-foo` to both opt and llc, I should do:

```
mono --aot=llvm,llvmllc="**-foo** -march=x86-64 -mattr=sse4.1 -asm-verbose=false 
-disable-gnu-eh-frame -enable-mono-eh-frame -mono-eh-frame-symbol=_mono_aot_p_eh_frame 
-disable-tail-calls -no-x86-call-frame-opt -relocation-model=pic 
-filetype=obj,llvmopts="**-foo** -O2 -disable-tail-calls"
```

So this PR introduces new commands `llvmopts-add` and `llvmllc-add` to be able to simply do:
`mono --aot=llvm,llvmopts-add="-foo",llvmllc-add="-foo"`

PS: let me know if you don't like the `-add` suffix

/cc: @migueldeicaza
2018-11-06 08:05:40 -05:00
Rodrigo Kumpera ce08c32632 Merge pull request #11444 from vargaz/wasm-work10
[wasm] AOT work.
2018-11-06 07:46:18 -05:00
Bernhard Urban c200ccbb62 [mini] do not emit safepoints for methods without calls and loops (#11554)
[mini] do not emit safepoints for methods without calls and loops

with this optimization, running Roslyn with mono on
`mono/tests/pinvoke11.cs` compiles:

* 2019 methods without safepoints, and
* 9443 methods with safepoints.
2018-11-06 07:25:38 -05:00
Alexander Köplinger c8d59d1d1d [ci] Fix Windows .msi build 2018-11-06 10:40:06 +01:00
monojenkins 1b7e823963 [csproj] Update project files 2018-11-06 10:27:55 +01:00
Marek Safar 2101be92eb [corlib] Update aot testing profile to run more tests 2018-11-06 10:27:55 +01:00
monojenkins ff4496f0af [csproj] Update project files 2018-11-06 02:08:49 +00:00
Alexander Kyte 03c8728e10 [runtime] Enable usage of Runtime team sentry server (#11532) 2018-11-05 21:01:47 -05:00
Vlad Brezae efe81504bd [ci] Add jenkins script for testing fullaot + interp (#11553)
For now, run the runtime suite and a few bcl tests.
2018-11-05 16:11:08 -05:00
Vlad Brezae ef78b582a1 [corlib] Icall for Buffer.Memcpy
Jitted code is too slow. For larger sizes, doing an icall to memcpy is 4-5 times faster than using the managed implementation.
2018-11-05 21:09:55 +01:00
Vlad Brezae 0947b7b289 [corlib] Remove unused function 2018-11-05 21:09:55 +01:00
Bernhard Urban 9772a0868a [interp] transform delegate invoke in method body too (#11528)
[interp] transform delegate invoke in method body too
2018-11-05 13:15:29 -05:00
Zoltan Varga 909c8300d5 [corlib] Add stubs for timezone info for wasm, use it instead of the file system based code. 2018-11-05 01:36:29 -05:00
Zoltan Varga 994aaa7c2b [wasm] Avoid emitting gsharedvt versions of the Vector<T> simd fallback code, its large and unlikely to be used. 2018-11-04 23:48:34 -05:00
Zoltan Varga 8e1a4e2702 [jit] Implement Vector.IsHardwareAccelerated () as an intrinsics even if SIMD is not enabled to help deadce. 2018-11-04 23:47:48 -05:00
Zoltan Varga a5f51afafa [corlib] Add stubs for timezone info for wasm, use it instead of the file system based code. 2018-11-04 23:45:26 -05:00
Zoltan Varga daf92b9e62 [aot] Avoid AOTing ref instances of methods with valuetype constraints, they will never be used. 2018-11-04 18:09:34 -05:00
Alexander Köplinger 2fd171c4f9 Fix tarball build
1) We try to include every source in .sources but that doesn't work
for generic _test.sources since we'd need to prepend the Test/ path.

2) MonoNativeConfig.cs.in was removed in 273f120c52
2018-11-04 13:15:46 +01:00
Zoltan Varga ed19b6eb6f [runtime] Add a --enable-minimal=assert_messages option to remove assertion messages, only file/line numbers are retained. Enable it for wasm. 2018-11-03 23:19:46 -04:00
Zoltan Varga 0ea592b812 [wasm] Restrict the set of methods dedup-ed to a set which works. 2018-11-03 04:39:37 +01:00
Zoltan Varga 52471e886b [jit] Use mono_method_get_full_name () in a few places since it includes return types. 2018-11-03 04:39:14 +01:00
Zoltan Varga 67b3909420 [wasm] Enable dedup support. 2018-11-03 04:35:05 +01:00
Zoltan Varga ee47f34257 [wasm] Avoid linking the icall table into the app in aot mode. 2018-11-02 23:34:24 +01:00
Jonathan Chambers 02f46d3f49 Fix ref return for structs in runtime invoke wrapper. (#11514)
Use mono_mb_emit_op for CEE_LDOBJ to ensure wrapper data is added for
indirect load of a ref return value as method-to-ir expects this for wrappers.
2018-11-02 16:58:03 -04:00
Alexander Köplinger de2cb5fdde [ci] Switch to new syntax of Azure Storage plugin 2018-11-02 18:53:40 +01:00
Marek Safar a0d6531ef7 [man] Fixes --compile-all sytax (#11518) 2018-11-02 11:59:23 -04:00
Bernhard Urban 0cd8c758a8 [bcl] avoid false pinning in GCTest (#11521) 2018-11-02 10:34:28 -04:00
Bernhard Urban 9e8ff85c08 [interp] accept typed-by-ref as return type from a JIT call (#11522) 2018-11-02 10:33:06 -04:00
Jo Shields ffa8c9992f Merge pull request #11509 from directhex/cleanup-system-native-make-dist
Clean up .o files from System.Native during `make dist`
2018-11-02 10:02:53 -04:00
Marek Safar b3a2a47caf [corlib] Remove incorrectly converted silverlight check
Fixes #11478
2018-11-02 12:22:49 +01:00
monojenkins e9830a7a41 [csproj] Update project files 2018-11-02 12:19:12 +01:00
Martin Baulig 273f120c52 "Mono.Native - Halloween Edition"
In preparation of the upcoming FSW support, `Mono.Native` now supports icall registration
and has a test added for this.  This doesn't actually hook up FSW yet on iOS, but all the
preparations have been made as well as some tests for it.

* When using Bitcode (iOS only), we now link against the Mono runtime because we cannot have
  any undefined symbols.  Without Bitcode, the `mtouch` tool will do the linking for us.

* Add `-framework GSS` if needed.

* Removed `common/MonoNativeConfig.cs` - the test harness in `xamarin-macios/tests/xharness`
  now takes care of that.

* Include a few more `System.Native` files on IOS.

* `mono_native_initialize()`: New native method to initialize the module and register any
  necessary icalls.  We register a new `Mono.MonoNativePlatform::IncrementInternalCounter`
  icall for testing purposes.

* `mono_native_is_initialized()`: New native method for testing.

* `MonoNativePlatform.Initialize()`, `IsInitialized()`: Managed side of these.

* `MonoNativePlatform.IncrementInternalCounter()`: New icall, which is registered by
  `mono_native_initialize()` - this is used by the test suite to make sure the icall
  registration works.

* `NativePlatformTest`: Removed compat / unified check, see above.  Add tests to call
  the other managed APIs via reflection.
2018-11-02 12:19:12 +01:00
Jay Krell 29e3d25799 [coop] Refactor/reuse mono_value_box_handle/mono_value_box_checked and reduce raw pointers. (#11466) 2018-11-02 03:09:36 -07:00
monojenkins 3a747e10d7 Bump API snapshot submodule 2018-11-02 08:30:11 +01:00
Jb Evain c41cd66598 Make all invokable mirrors share an interface 2018-11-02 08:30:11 +01:00
Jb Evain 0e392596cf [Mono.Debugger.Soft] Refactor the InvokeMethodAsync methods to reduce duplication 2018-11-02 08:30:11 +01:00
Bernhard Urban 226a836210 [marshal] fix pointer type (#11499)
[marshal] fix pointer type
2018-11-01 18:55:35 -04:00
Dominik Przywara 81795e454e Added missing cts.Cancel() in HttpClient Dispose() method 2018-11-01 23:06:39 +01:00
Jo Shields 791ec7faea Delete more useless binary cruft from make dist 2018-11-01 14:10:24 -04:00
Jo Shields 7184737bee Clean up .o files from System.Native during make dist
Closes: https://github.com/mono/mono/issues/11501
2018-11-01 13:53:13 -04:00
Zoltan Varga 4ba22e2c78 [llvm] Fix the build. 2018-11-01 13:18:56 +01:00
monojenkins 0bd0bd3fff [bcl] Update BCL Linked Size 2018-11-01 08:47:43 +01:00
Jay Krell f57ceafa10 Reduce TLS accesses. (#11487)
* Reduce TLS accesses.
Functions with HANDLE_FUNCTION_ENTER, only call mono_thread_info_current once,
instead of 1 + per-MONO_HANDL_NEW.

This can be extended in future in multiple potential ways.
 1 Macro split from HANDLE_FUNCTION_ENTER.
   This is easiest/no downside, i.e. for functions that do not HANDLE_FUNCTION_ENTER
   but that do multiple MONO_HANDLE_NEW, call other macro
   just to mono_thread_info_current () into local.
 2 Pass TLS as seperate parameter. Probably not actually, see 4.
 3 Store TLS in handles -- too large? Probably not actually, see next.
 4 Store TLS in MonoError. i.e. MonoError is "call context", chained
   up to "thread context".
2018-10-31 20:49:29 -07:00
Aleksey Kliger (λgeek) d28db369f1 Implement MONO_ENTER_NO_SAFEPOINTS/MONO_EXIT_NO_SAFEPOINTS (#11476)
* [threads] Add a no_safepoints bit to the thread state machine.

Only valid on RUNNING or ASYNC_SUSPEND_REQUESTED.
Currently no transitions set the bit, but the expectation is that it can only
be set/unset by the current thread on itself and only in RUNNING or
ASYNC_SUSPEND_REQUESTED.
Transitions to suspended states or to GC Safe states are forbidden if
wont_safept is set.

The intention is that this is used by a thread to mark a scope where it will
not safepoint (perhaps because it wants to manipulate a raw ptr to a managed
object).

The wont_safept bit only makes sense for cooperative suspension.  For async, we
have the critical regions (which should be much more rarely needed).

* [threads] Add state machine funcs to query/set/uniset wont_safept

* [threads] add MONO_ENTER_NO_SAFEPOINTS/MONO_EXIT_NO_SAFEPOINTS macros

A region between MONO_ENTER_NO_SAFEPOINTS/MONO_EXIT_NO_SAFEPOINTS must not call
any function that could: reach a safepoint (and suspend the current thread),
allocate memory from the managed heap, or transition to GC Safe.  In such a
region it is safe to dereference a pointer to managed memory and use read/write
from it (an alternative to avoid the no safepoints region is to pin the memory
with a global GC handle before manipulating it).  GC Write barriers still need
to be used.

The current design doesn't allow nesting - the underlying thread state
transitions check that the flag isn't already set - keep the regions short and simple.

* [sgen] Don't initiate STW from a thread in a NO_SAFEPOINTS region

In other words, if you were in
MONO_ENTER_NO_SAFEPOINTS/MONO_EXIT_NO_SAFEPOINTS, you shouldn't be calling
anything that would start the GC
2018-10-31 23:39:20 -04:00
Zoltan Varga 761398d080 [aot] Add some comments. 2018-11-01 03:02:13 +01:00
Alexander Köplinger 75f3c0cc0c [System.Drawing] Fix test build for wasm profile
It was recently switched to only contain the netstandard20 subset of types.
2018-11-01 02:04:40 +01:00
Bernhard Urban e1c6c78158 [ci babysitter] Add more output around timeout killing machinery (#11463) 2018-11-01 00:42:37 +01:00
Bernhard Urban e67699917c [runtime] allocate volatile_{locals,args} bitset in image mempool (#11490)
Fixes https://github.com/mono/mono/issues/11488, an regression introduced by https://github.com/mono/mono/pull/11294
2018-11-01 00:40:49 +01:00
Marek Safar af2c781c2e [corlib] Tweaks few linker descriptors to be more precise 2018-10-31 20:49:02 +01:00
Zoltan Varga 9960c5b419 [llvmonly] Rework the handling of direct calls.
Move the allocation of got offsets for calls to a separate pass after all methods have been compiled. This means
that got offsets do not need to be allocated for calls which can be turned into direct calls.
2018-10-31 19:55:59 +01:00
Alexander Köplinger c36045510c Bump nunitlite to get WASM-related fix 2018-10-31 17:34:33 +01:00
Michael Voorhees 8ca2e209aa Additional constructor preservations
Upcoming changes to monolinker will make additional optimizations when no instance ctors are marked.

To be safe, add preservations for the ctor's of types that are created in the runtime.

The change to preserve the .ctor() of`System.Runtime.Remoting.Messaging.AsyncResult`  was made for more than out of caution.  We have a simple delegate test that hung without this.
2018-10-31 15:31:21 +01:00
Alexander Köplinger 4b1e93d2ee Bump corefx to get disabled test 2018-10-31 14:31:51 +01:00
Marek Safar 22995f84af Bump corefx (#11482)
* Bump corefx

* Bump API snapshot submodule
2018-10-31 14:08:19 +01:00
monojenkins 6ef9162b78 [csproj] Update project files 2018-10-31 14:08:04 +01:00
Marek Safar 103999d3cd [corlib] Tweak more wasm defines 2018-10-31 14:08:04 +01:00
Alan Grgic 7a23177292 Add missing constructor in System.Security.Policy.Evidence (#11480)
Fixes #7750.
2018-10-31 13:54:21 +01:00
Marek Safar 5493154046 [corlib] Remove tests which were moved to System.Core 2018-10-31 13:47:08 +01:00
majellin24 92711632bf Modification to allow deserialization of derrived types (#11194)
* Modification to allow deserialization of derrived types

* white space correction

* second attempt

* third attempt

* fourth

* whitespace

* maybe fix null ref exception

* missed same condition in other method

* fixing condition

* hopefully correcting the test failure in AOT

* Modification to allow deserialization of derrived types

white space correction

second attempt

third attempt

fourth

whitespace

maybe fix null ref exception

missed same condition in other method

fixing condition

hopefully correcting the test failure in AOT

formatting

missed some formatting

* adding a test for PR #11194

* fixing a few exceptions

* adding ref
2018-10-31 10:43:46 +01:00
Bernhard Urban aa37f45a3d [tests] reduce recursion depth
so it doesn't trigger a stack overflow on Xamarin.iOS with interpreter on a debug build (`CFLAGS=-O0`).
2018-10-31 10:36:15 +01:00
monojenkins 7ac56e5794 [csproj] Update project files 2018-10-31 10:10:16 +01:00
monojenkins 1ab2271e74 Bump API snapshot submodule 2018-10-31 10:10:16 +01:00
Maxim Lipnin c671d31c41 Move TODO comment regarding GetBaseMethod from reference source to MonoMethod class 2018-10-31 10:10:16 +01:00
Maxim Lipnin 11ea7fdd7f [Reflection] CoreFX import for MethodInfo type 2018-10-31 10:10:16 +01:00
Alexander Kyte dd9e11fba8 [crash] Fix async setting for crash reporter
We were previously only setting it from the icall. The icall was
therefore fine, while invocations associated with actual dumps
caused crashes like this:

```

thread #10, name = 'Thread Pool Worker'
    frame #0: 0x00007fff978dac22 libsystem_kernel.dylib`__psynch_mutexwait + 10
    frame #1: 0x00007fff979c5dfa libsystem_pthread.dylib`_pthread_mutex_lock_wait + 100
    frame #2: 0x00007fff979c3519 libsystem_pthread.dylib`_pthread_mutex_lock_slow + 285
    frame #3: 0x0000000108e0d4a9 mono`mono_loader_lock + 73
    frame #4: 0x0000000108dc9106 mono`mono_class_create_from_typedef + 182
    frame #5: 0x0000000108dc1f2c mono`mono_class_get_checked + 92
    frame #6: 0x0000000108e21da2 mono`mono_metadata_parse_type_internal + 1378
    frame #7: 0x0000000108e25e11 mono`mono_metadata_parse_mh_full + 1233
    frame #8: 0x0000000108ca4f79 mono`mono_debug_add_aot_method + 121
    frame #9: 0x0000000108cc6b1e mono`decode_exception_debug_info + 5918
    frame #10: 0x0000000108cc5047 mono`mono_aot_find_jit_info + 1367
    frame #11: 0x0000000108e082cc mono`mono_jit_info_table_find_internal + 204
    frame #12: 0x0000000108cdb035 mono`mini_jit_info_table_find_ext + 69
    frame #13: 0x0000000108cdad5c mono`mono_find_jit_info_ext + 124
    frame #14: 0x0000000108cdc3a5 mono`unwinder_unwind_frame + 229
    frame #15: 0x0000000108cdbade mono`mono_walk_stack_full + 798
    frame #16: 0x0000000108cda1a4 mono`mono_summarize_managed_stack + 100
    frame #17: 0x0000000108e6dc03 mono`mono_threads_summarize_execute + 1347
    frame #18: 0x0000000108e6df88 mono`mono_threads_summarize + 360

```
2018-10-31 08:21:21 +01:00
Alexander Köplinger 7645c8b8f0 Revert "[interp] Optimise method execution start (#11328)"
This reverts commit ecf399da07.

It breaks a webassembly test.
2018-10-31 01:35:06 +01:00
Zoltan Varga db5666c72c [jit] Fix the s390x build. (#11474) 2018-10-31 01:28:56 +01:00
Vlad Brezae 5204ef1f5c [tests] Add new build profile for testing mixed mode (#11307)
We aot only the bcl (--aot=full,interp) while the tests code is interpreted.

<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2018-10-30 15:48:46 -04:00
Alexander Köplinger 555e5c5214 [mini] Fix missing semicolon in mini-s390x.c
Typo from 38caaf67b1
2018-10-30 20:38:30 +01:00
Alexander Kyte 58d5e154b7 [crash] Fix merp invocation (#11435)
The change which made the handler return (rather than crashing the
runtime) did not consider this control flow path that causes the sigterm
signal handler to trigger the merp dumper if we return.

We now always return.

This was previously so that a random sigterm could be used to trigger a
dump. This isn't really used, and won't work right now anyways
(we don't register it until right before we dump). My fix is to remove
it, and to make the signal handler only work as part of the dumper
machinery.
2018-10-30 19:24:38 +01:00
Marek Safar 263e59de65 [System.Core] Adds ~28k corefx tests (#11445) 2018-10-30 18:27:33 +01:00
Marek Safar a84d2bcdef [corlib] Deletes unused code 2018-10-30 17:43:22 +01:00
Vlad Brezae ecf399da07 [interp] Optimise method execution start (#11328)
[interp] Optimise method execution start

This can lead to 4% general speedup

<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2018-10-30 11:35:44 -04:00
Nikolay Sivov d3af6d44ff [metadata] Compiler warnings fixes. (#10893)
* [metadata] Fix strict prototype warning.

* [metadata] Remove unused variable.

* [metadata] Fix unused function warning.

* [metadata] Fix unused function warning for swap_with_size().

* [metadata] Fix "may be uninitialized" warnings.

* [metadata] Simplify missing ICustomMarshaler exception throwing case.

With current code there is no reason to have explicit jump label.
2018-10-30 10:14:54 -05:00
Bernhard Urban 36c27a2328 [interp] fix definition of MINT_CKNULL_N (#11447)
So that the debug output renders the operand of `MINT_CKNULL_N`
correctly.
2018-10-30 11:11:50 -04:00
Bernhard Urban 8e0cbf1044 [gitgnore] put .dylib on ignore list (#11453) 2018-10-30 09:41:45 -04:00
Ankit Jain f038e7cd8a Bump msbuild to track xplat-master (#11440)
- pickup fix for https://github.com/mono/mono/issues/11214 .
2018-10-30 13:28:53 +01:00
Bernhard Urban adc72216b3 [delegates] do not use CEE_CALLVIRT for non-virtual methods (#11433)
[delegates] do not use CEE_CALLVIRT for non-virtual methods
2018-10-30 06:05:33 -04:00
Martin Baulig 40ac474150 [System]: lock protect SystemCertificateProvider.EnsureInitialized(). 2018-10-30 10:33:47 +01:00
Jay Krell 2be23d7835 One version of ves_icall_...StringToHGlobalUni is better than two. (#11404) 2018-10-29 23:16:50 -07:00
Zoltan Varga 7ef033cf8d [aot] Remove unused got_offset arguments from a few functions. Fix a warning. NFC. 2018-10-30 04:29:25 +01:00
Jay Krell 8f26798fee Disable failing assert in failing test DebuggerTests.Threads Assert.AreEqual (ThreadState.Stopped, e.Thread.ThreadState) (#11419)
Disable failing assert in failing test DebuggerTests.Threads Assert.AreEqual (ThreadState.Stopped, e.Thread.ThreadState)

https://github.com/mono/mono/issues/11416
2018-10-29 18:35:31 -04:00
Vlad Brezae 4ab5d5398f [interp] Init also vtstack value types when allocated (#11425) 2018-10-29 22:37:52 +02:00
Zoltan Varga c0da2a5126 [wasm] Bitcode code generation improvements (#11413)
* [llvm] Rewrite the bitcode get_method () generated method to load the result from a table on wasm instead of a huge
switch statement.

This might be usable on other platforms in the future but having a table full of function pointers might lead to linking
problems.

* [llvm] Make direct calls to jit icalls without wrappers as well.

* [llvm] Export mono_llvm_clear_exception () with G_EXTERN_C, its called from llvm generated code.

* [wasm] Emit target layout/target triple into bitcode files.

* [aot] Allow the decoding of references to icall wrappers, so compiled code can reference them directly using a MONO_PATCH_INFO_METHOD.

* [llvm] Call icall wrappers directly from corlib code in llvmonly mode instead of going through the GOT.

* [llvm] Instance methods without got accesses don't need initialization in llvmonly mode.
2018-10-29 20:06:01 +01:00
Jay Krell 985be3e594 [Coop] Convert ves_icall_System_Environment_InternalSetEnvironmentVariable. (#11408) 2018-10-29 08:46:47 -07:00
monojenkins 251409f040 [csproj] Update project files 2018-10-29 16:03:44 +01:00
monojenkins cda073e850 Bump API snapshot submodule 2018-10-29 16:03:44 +01:00
Marek Safar 11baeccd48 [Facades] Adds NS21 APIs 2018-10-29 16:03:44 +01:00
Robin Sue f72e959c8c [wasm] Extend WasmHttpMessageHandler (#11255)
- Adds support for HttpCompletionOption.ResponseHeadersRead by delaying reading of the response body into HttpContent
- Adds optional support for streaming responses in supported browsers
- Adds support for canceling in flight fetch requests
2018-10-29 11:31:34 +01:00
Kenneth Pouncey ca9f1b0cb7 [wasm] Wasm sample docs (#11347)
Create docs directory and update sample documentation.

- Add getting started docs directory
- Add section of obtaining the mono distribution.

resolves: https://github.com/mono/mono/issues/11346

Fix distribution package from wasm build to have the same structure as `packager.exe` is expecting.

resolves: https://github.com/mono/mono/issues/11344
2018-10-29 11:29:44 +01:00
Johan Lorensson 1ec7ac5438 Add option to integrate msvc build into regular make build. (#11343)
* Integrate msvc build into make build system.

Add support to perform msvc build as part of regular make build. By default
msvc build will not automatically be done and needs to be enabled using
--with-msvc argument passed to ./autogen.sh. Doing msvc build as part of
regular make will automatically set MONO_EXECUTABLE to build msvc build
Mono runtime used in BCL and Test build as well as runtime used when running
tests.

* Add support to install msvc build mono runtime.

* Disable --with-msvc argument for none Windows builds.

* Fix VS2015 Build Tools build environment.

* Updated with review feedback switching to --enable-msvc.
2018-10-28 18:18:28 -04:00
Jay Krell 668933de7f Remove dead mono_signature_get_managed_fmt_string prototype. (#11409) 2018-10-28 18:07:46 -04:00
Jay Krell 7b5cac0539 [w32file] Restrict mono_w32file_get_volume_information interface to its actual implementation and usage.
On all platforms, mono_w32file_get_volume_information is only asked for its last parameter.
So replace mono_w32file_get_volume_information with mono_w32file_get_file_system_type that
only takes that parameter.
2018-10-28 18:07:13 -04:00
Alexander Köplinger a682a3b2b6 Fix tarball build
Forgot to add a file to EXTRA_DIST
2018-10-28 01:22:07 +02:00
Marek Safar ea967a0718 [runtime] Fixes threadpool tests not to rely on arbitrary sleep timeout (#11348) 2018-10-27 23:42:10 +02:00
Jay Krell 31473ac156 Update some comments. (#11382) 2018-10-27 16:58:12 -04:00
Jay Krell c299a99431 Disable flaky tests finalizer-abort.exe, process-stress-2.exe, process-stress-3.exe. (#11418) 2018-10-27 16:49:52 -04:00
Aleksey Kliger (λgeek) ab51a8172e [reflection] Implement RuntimeType.IsByRefLike (#11111)
* [reflection] Implement RuntimeType.IsByRefLike

* [runtime] Add MonoClass:is_byreflike bit

Not set anywhere yet.

* [custom_attrs] Add mono_class_metadata_foreach_custom_attr

Unlike mono_custom_attrs_from_class_checked, this iterator function iterates
over the metadata without taking the loader lock or constructing class
instances, so it is safe to use during assembly loading or class initialization.

* [class-init] Set is_byreflike from attributes in mono_class_create_from_typedef

* [class-init] Set is_byreflike for generic instances

* [class-init] fail arrays of IsByRefLike elements

* [class-init] Check for ByRefLike struct fields

ByRefLike types only allowed as instance fields of structs that are
themselves ByRefLike.

* [runtime] Disallow instantiating generics with ByRefLike types

Instantiating a generic with a `ref struct` is not allowed.

* [runtime] Disallow instantiating generics with TypedReference

Reverts f457a01416. That was a hack to support
gsharedvt (gsharedvt worked by hijacking TypedReference to instantiate generic
vars since it's a lightly used class) that we no longer rely on (we now
instantiate generic vars by types that are synthesized for purpose).

* [mini] Don't box IsByRefLike types

* [runtime] Disallow boxing IsByRefLike types

* Bump corlib version

* [tests] Test that JIT won't box or instantiate IsByRefLike types

* [metadata] Don't inflate methods with invalid generic arguments

* [metadata] Make mono_is_valid_generic_argument non-static

Make it callable from other translation units.

* [class-init] Check for invalid generic instantiations

Disallow instantiations that contain void, TypedReference or IsByRefLike structs.

* [interp] Don't box IsByRefLike structs
2018-10-27 11:03:42 -05:00
Jay Krell 12b2b48504 [icalls] Dial back a few functions from HANDLES to NOHANDLES, (#11386)
* [icalls] Dial back a few functions from HANDLES to NOHANDLES,
that take/return no objects, nor have error paths.
2018-10-27 07:48:57 -07:00
Jay Krell e75c972ef8 [Coop] Convert mono_custom_attrs_from_builders. (#11394) 2018-10-27 07:03:35 -07:00
Zoltan Varga ec1c08afa5 [llvm] Fix passing vtypes received by value as arguments, they need to be copied. Fixes https://github.com/mono/mono/issues/11378. (#11389) 2018-10-27 12:42:46 +02:00
Marek Safar 9214bdc7be [corlib] Replace few more simple types with corefx (#11401) 2018-10-27 01:46:20 +02:00
Alexander Köplinger 73afc0361a [profiler] Add xunit xml profiler tests output and allow tests to run from outside the build tree (#11383)
We need xunit xml output for Helix.

The new mode which doesn't rely on build tree paths can be enabled by passing the special value "out-of-tree" as the build dir.

Respects the MONO_EXECUTABLE env variable and bases everything off of that.

Also unified run_test and run_test_sgen since we only have sgen nowadays and we only need one.
2018-10-27 00:32:58 +02:00
Bernhard Urban f8f574ded5 [interp] throw overflow exception when {float,double}.NaN is converted to an int type (#11380)
[interp] throw overflow exception when {float,double}.NaN is converted to an int type

A comparison with NaN is always `false`.
2018-10-26 17:45:32 -04:00
Aleksey Kliger (λgeek) e522b00d40 [marshal] Delete unused locals in emit_managed_wrapper_ilgen (#11379)
[marshal] Delete unused locals in emit_managed_wrapper_ilgen

`ex_local` and `e_local` were used prior to
https://github.com/mono/mono/commit/b20d5ce1e5d69512242dd42ae6ff1afc2483c16d
in order to store an exception raised by the managed method before passing it
to `ftnptr_eh_callback`.  After that commit, we invoke the callback from the
stack unwinder, rather than from the method wrapper.  As a result both of the
locals are now dead code.
2018-10-26 16:35:26 -04:00
Alexander Köplinger d34dfd46d0 [profiler] Reenable tests when using hybrid suspend (#11402)
They got disabled with https://github.com/mono/mono/commit/282ee4bfd7ea91dc0015891010c71d8bd1421bc8 but now that hybrid suspend is the default on multiple platforms we should reenable them.
2018-10-26 22:23:45 +02:00
Marek Safar 16db2720aa [runtime] Disables crashing appdomain-threadpool-unload.exe test (#11393) 2018-10-26 11:45:55 -04:00
Henric Müller ee661a08db Add .NET 4.7.2 reference assemblies (#11391)
Adding .NET 4.7.2 reference assemblies by updating submodule reference and adding new framework to mcs/tools/xbuild/frameworks and update Makefile to ship as described in #8657.
2018-10-26 15:41:40 +02:00
Bernhard Urban 9292e8a605 [interp] enable more BCL tests (#11381)
[interp] enable more BCL tests

probably won't pass on all configurations, I wanna find out on which.
2018-10-26 09:05:39 -04:00
Katelyn Gadd 786f58bf83 Partially exclude custom modifiers from metadata type equality (#11134)
Fixes #10945
Reverts fix for #6936

https://github.com/mono/mono/issues/10945 appears to have been introduced by https://github.com/mono/mono/commit/9dc6c344ac34a470fa0f4fc411e357f7eaf577fd. Unfortunately it is not possible to revert the commit at this point using git revert, but manually disabling the equality change fixes BinaryFormatter. This should be sufficient to get a lot of the broken roslyn tests working again.
2018-10-26 12:35:12 +02:00
Jay Krell 5b8b0f20ac [Coop/icalls] Convert a few, nohandles() a few, cleanup a few. (#11355)
* [Coop] Convert ves_icall_System_Object_MemberwiseClone.
[Coop] Convert ves_icall_System_Runtime_CompilerServices_RuntimeHelpers_GetObjectValue.
[Coop] Convert ves_icall_MonoField_get_core_clr_security_level.
[Coop] Convert ves_icall_System_Runtime_CompilerServices_RuntimeHelpers_RunClassConstructor.
[Coop] Convert ves_icall_System_Runtime_CompilerServices_RuntimeHelpers_RunModuleConstructor.
[coop] Remove redundant declarations.
[Coop] Nohandles ves_icall_System_Environment_Exit.
[Coop] Nohandles ves_icall_System_Environment_GetIs64BitOperatingSystem.
[Coop] Nohandles mono_pagesize.
[Coop] Nohandles mono_environment_exitcode_get.
[Coop] Nohandles ves_icall_System_Environment_get_HasShutdownStarted.
[Coop] Nohandles ves_icall_System_Environment_get_Platform.
[Coop] Nohandles ves_icall_System_Environment_get_ProcessorCount.
[Coop] Nohandles ves_icall_System_Environment_get_TickCount.
[Coop] Nohandles mono_environment_exitcode_set.
[Coop] Nohandles ves_icall_System_Reflection_AssemblyName_GetNativeName.
[Coop] Nohandles ves_icall_System_Reflection_AssemblyName_ParseAssemblyName.
[Coop] Nohandles mono_digest_get_public_token.
[Coop] Nohandles ves_icall_System_Runtime_CompilerServices_RuntimeHelpers_GetOffsetToStringData.
[icalls] Cleanup ves_icall_System_Environment_get_HasShutdownStarted.
[icalls] Cleanup ves_icall_System_Environment_BroadcastSettingChange.
[icalls] Cleanup ves_icall_IsTransparentProxy.
[icalls] Cleanup ves_icall_Remoting_RemotingServices_GetVirtualMethod.
[icalls] Cleanup ves_icall_System_Runtime_Activation_ActivationServices_EnableProxyActivation.
[icalls] Cleanup ves_icall_System_Runtime_Activation_ActivationServices_AllocateUninitializedClassInstance.
[icalls] Cleanup ves_icall_RuntimeMethodHandle_GetFunctionPointer.
[icalls] Cleanup ves_icall_System_Configuration_DefaultConfig_get_machine_config_path.
[icalls] Cleanup ves_icall_System_Configuration_InternalConfigurationHost_get_bundled_app_config.
[icalls] Cleanup ves_icall_System_Web_Util_ICalls_get_machine_install_dir.
[icalls] Cleanup ves_icall_get_resources_ptr
[icalls] Cleanup ves_icall_System_Diagnostics_Debugger_IsLogging.
[icalls] Cleanup ves_icall_System_Activator_CreateInstanceInternal.
[icalls] Cleanup ves_icall_MonoMethod_get_base_method.
[icalls] Cleanup ves_icall_MonoMethod_get_name.

* Replace mono_error_ok with is_ok.
* Remove outdated comment.
* Use return_if_nok where applicable.
* Use return_val_if_nok where applicable.
* Use NULL_HANDLE_ARRAY where applicable.
2018-10-26 01:41:32 -07:00
Alexander Köplinger cc6157a1c1 [Mono.Profiler.Log] Use full path for temporary .mlpd's (#11384)
So they don't depend on the working dir.
2018-10-26 04:29:51 +02:00
Alexander Köplinger a509e43cc1 [Mono.Debugger.Soft] Disable flaky Crash() test 2018-10-26 00:32:22 +02:00
Zoltan Varga c1e21d488a [wasm] WASM work. (#11314)
* [wasm] Handle the /dev/random problems by defining 'crypto' in runtime-tests.js instead of in the runtime/library_mono.js.
Print a	stack trace if runtime_invoke () throws	a JS exception.

* [wasm] Add a mono_wasm_setenv () function to the MONO module.

* [wasm] Mark some corlib tests as MultiThreaded/NotWasm.
2018-10-25 17:40:38 -04:00
Jay Krell 8fba63a2a3 [cxx] Fix WebAssembly/C++ (ICALL_EXPORT) (#11359)
Remove ICALL_EXPORT on all implementations.
Add ICALL_EXPORT on two declarations.

ICALL_EXPORT is on declarations, correctly,
  and either isn't needed on implementations, or is incorrect.
On non-handles() implementations, it isn't needed but is ok.
On handles() implementations, it is incorrect.

Add ICALL_EXPORT on mono_object_hash_internal and mono_monitor_exit_internal.

Previously many declarations were missing, which was a reason we put it on implementations.
2018-10-25 13:07:05 -07:00
Alexander Köplinger bf12b8762d [build] Enable netstandard facade in the "build" profile (#11377)
* [build] Enable netstandard facade in the "build" profile

It is necessary for a helix tool which I'm building in this profile
and it relies on NS2.0.

Adding full NS2.0 would require building System.Transactions.dll,
System.Runtime.Serialization.dll and System.Data.dll too but those
in turn rely on a whole bunch of other junk that I don't want to bring
into the build profile. Therefore I just added stubs for the types
directly into netstandard.dll.

* [csproj] Update project files
2018-10-25 21:38:10 +02:00
Neale Ferguson 8e44a7fa0c A couple of missing mono_class_from_mono_type_internal changes (#11372)
A couple of missing mono_class_from_mono_type_internal changes

Two instances were missed when mono_class_from_mono_type was changed to mono_class_from_mono_type_internal
2018-10-25 14:35:33 -04:00
monojenkins 5cf1cb8a4e [csproj] Update project files 2018-10-25 20:11:08 +02:00
monojenkins c40bbf93b0 Bump API snapshot submodule 2018-10-25 20:11:08 +02:00
Marek Safar 7ebb2f989d [corlib] Adds back accidentally removed legacy COM API to Binder 2018-10-25 20:11:08 +02:00
Alexander Köplinger 87493e96fb [System.Runtime.Serialization] Fix possible race when creating the test response file
test_lib might not be set yet at this point since we're including library.make
later on, use LIBRARY instead which is set further above.
2018-10-25 18:56:00 +02:00
Alexander Köplinger c91486cc2d Fix tarball build by including upload-to-sentry 2018-10-25 15:20:15 +02:00
Marek Safar 7ec5a9af87 [build] Fixes wasm tools to run on desktop .net as well (#11351)
* [build] Fixes wasm tools to run on desktop .net as well

Fixes #11326

* [csproj] Update project files
2018-10-25 15:13:46 +02:00
Bernhard Urban cb467ff359 [interp] fix unused variable warnings (#11365)
```
interp/interp.c:2337:17: warning: unused variable 'entry_funcs_static' [-Wunused-variable]
static gpointer entry_funcs_static [MAX_INTERP_ENTRY_ARGS + 1] = { INTERP_ENTRY_FUNCLIST (static) };
                ^

interp/interp.c:2338:17: warning: unused variable 'entry_funcs_static_ret' [-Wunused-variable]
static gpointer entry_funcs_static_ret [MAX_INTERP_ENTRY_ARGS + 1] = { INTERP_ENTRY_FUNCLIST (static_ret) };
                ^

interp/interp.c:2339:17: warning: unused variable 'entry_funcs_instance' [-Wunused-variable]
static gpointer entry_funcs_instance [MAX_INTERP_ENTRY_ARGS + 1] = { INTERP_ENTRY_FUNCLIST (instance) };
                ^

interp/interp.c:2340:17: warning: unused variable 'entry_funcs_instance_ret' [-Wunused-variable]
static gpointer entry_funcs_instance_ret [MAX_INTERP_ENTRY_ARGS + 1] = { INTERP_ENTRY_FUNCLIST (instance_ret) };
                ^

4 warnings generated.
```
2018-10-25 15:07:45 +02:00
Martin Baulig a52744eeeb [System.Core]: Stub out Interop.Sys.GetEUid and SetEUid. (#11366)
* [System.Core]: Stub out `Interop.Sys.GetEUid` and `SetEUid`.

This is a temporary fix; the native side still needs to be ported from c++
and tested.

* [csproj] Update project files
2018-10-25 15:06:22 +02:00
Alexander Köplinger 6532ffee6b Bump boringssl submodule to get PPC32 fix 2018-10-25 13:48:13 +02:00
monojenkins d0069a948d [bcl] Update BCL Linked Size (#11361) 2018-10-25 03:34:04 +02:00
Alexander Köplinger 741a5d954a Revert "Fix const warning. And integer overflow for degenerate input. And C++. (#11088)"
This reverts commit dc43c6b469.

It causes regressions on WASM: https://jenkins.mono-project.com/job/test-mono-mainline-wasm/label=ubuntu-1804-amd64/1297/
2018-10-25 03:27:20 +02:00
Jay Krell 0c229900fe Remove errant character from 3bf5c2bd10 that breaks compile. (#11360) 2018-10-25 02:38:00 +02:00
Jay Krell dc43c6b469 Fix const warning. And integer overflow for degenerate input. And C++. (#11088)
https://jenkins.mono-project.com/job/test-mono-pull-request-wasm-cxx/536/parsed_console/log.html

driver.c:254:11: warning: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
                strcpy (&name [len - 3], "dll");
                        ^~~~~~~~~~~~~~~
/mnt/jenkins/workspace/test-mono-pull-request-wasm-cxx/sdks/builds/toolchains/emsdk/emscripten/1.38.11/system/include/libc/string.h:31:31: note: passing argument to parameter here
char *strcpy (char *__restrict, const char *__restrict);
2018-10-25 01:36:58 +02:00
Bernhard Urban 3bf5c2bd10 [aot] add unbox_arbitrary_trampoline for fullaot/interp mixed mode (#11321)
* [aot] add unbox_arbitrary_trampoline for fullaot/interp mixed mode

On a virtual call where the receiver is a value type, the value type is
boxed at the caller's site, but must be unboxed before passed to the
callee. In FullAOT this happens with the help of the `unbox_trampoline`,
which is attached to the AOT'd assembly for every virtual method with a
value type as receiver, so we have a specific `unbox_trampoline` for
each such `MonoMethod`.

In mixed mode it can happen that an FullAOT'd method is calling such a
method which is _not_ FullAOT compiled, therefore it has to be executed
by the interpreter. We have to insert a trampoline between AOT caller
and interp callee (being a native-to-interp entry), that does the
unboxing and has a configurable target address at run-time. So that:

  AOT caller -> unbox_arbitrary_trampoline -> native-to-interp entry

Note on testing: Tested on three different configurations
* amd64/macos with --full-aot-interp and `make -C mcs/class/corlib TESTNAME=MonoTests.System.ArrayTest.BinarySearch_ArgPassingOrder`. This will be covered soon by https://github.com/mono/mono/pull/11307.
* arm64/linux, same as above.
* arm64/iOS which has a different code path due to trampoline pages being used. Tested with `monotouch-tests` mixed mode (i.e. mscorlib.dll FullAOT, rest is interpreter).

armv7 isn't implemented yet.

* fix llvm aot compiler

* unbox_arbitrary_trampoline support for ARM
2018-10-25 01:20:12 +02:00
Jay Krell 1ac2c5218e Remove GetOffsetToStringData (but leave ves_icall_System_Runtime_CompilerServices_RuntimeHelpers_GetOffsetToStringData, it is used). (#11353) 2018-10-25 01:15:50 +02:00
Marek Safar 8023c9822c [build] Add more tools for monodroid to reduce sources dependency (#11352)
* [build] Add more tools for monodroid to reduce sources dependency

* [csproj] Update project files
2018-10-25 01:09:52 +02:00
Egor Bogatov 207b9b03df Fix bcl-size-diff calculation (#11357)
The BCL size regression (see https://github.com/mono/mono/pull/11041) was actually caused by changes in linker/Makefile: https://github.com/mono/mono/commit/539b14892000f3c4b13657161819680dd9aa098c#diff-f2d312cb75589935c2b11af219414f48L73
With this fix it's green again:

![image](https://user-images.githubusercontent.com/523221/47464597-5f8e0300-d7f2-11e8-88ac-b3e6e6129c81.png)
2018-10-25 01:03:50 +02:00
Rolf Bjarne Kvinge d86fdaf3ab [System.Net.Http] Comment out dead code. (#11331)
Comment out code to convert NSUrlError to WebExceptionStatus, because the
result isn't used. Looking through git history it seems the resulting
WebExceptionStatus was never used.

Fixes this warning:

    HttpClientEx.cs(83,8): warning CS0219: The variable 'webExceptionStatus' is assigned but its value is never used
2018-10-25 00:26:34 +02:00
Marek Habersack 0d68ffd1ce [SDKS, LLVM] Disable detection and use of libxml2 (#11340)
Mono doesn't use libxml2 and neither do the LLVM bits used by Mono when building
the AOT cross-compilers. Presence of `-lxml2` on the command line breaks 32-bit
builds on 64-bit Linux hosts:

    libtool: link: cc -shared  -fPIC -DPIC  -Wl,--whole-archive ./.libs/libmini.a ./.libs/libmono-ee-interp.a ./.libs/libmono-dbg.a ../../mono/metadata/.libs/libmonoruntimesgen.a ../../mono/sgen/.libs/libmonosgen.a ../../mono/utils/.libs/libmonoutils.a ../../mono/eglib/.libs/libeglib.a -Wl,--no-whole-archive  -lLLVMBitWriter -lLLVMAnalysis -lLLVMProfileData -lLLVMObject -lLLVMMCParser -lLLVMMC -lLLVMBitReader -lLLVMCore -lLLVMBinaryFormat -lLLVMSupport -lLLVMDemangle -L$HOME/xamarin-android/external/mono/sdks/out/llvm-llvm32/lib -lz -ltinfo -lxml2 -lstdc++ -lm -lrt -ldl -lpthread  -O0 -ggdb3 -m32 -g -mno-tls-direct-seg-refs -Wl,-export-dynamic   -Wl,-soname -Wl,libmonosgen-2.0.so.1 -o .libs/libmonosgen-2.0.so.1.0.0
    mv -f .deps/libmini_la-aot-runtime-wasm.Tpo .deps/libmini_la-aot-runtime-wasm.Plo
    /usr/bin/ld: skipping incompatible //usr/lib/x86_64-linux-gnu/libxml2.so when searching for -lxml2
    /usr/bin/ld: skipping incompatible //usr/lib/x86_64-linux-gnu/libxml2.a when searching for -lxml2
    /usr/bin/ld: cannot find -lxml2
    collect2: error: ld returned 1 exit status
    make[7]: *** [Makefile:1495: libmonosgen-2.0.la] Error 1

Installation of `libxml2-dev` (on Ubuntu/Debian + friends) for the x86
architecture (or x86_64 architecture on 32-bit host) would be possible but then
it would break the 64-bit build because the 64-bit version of the library would
be absent. It would be a problem if Mono+LLVM actually used xml2, but since it
doesn't we can just disable the feature completely.
2018-10-25 00:22:37 +02:00
Aleksey Kliger (λgeek) 0c8fbcd970 [tests] Regression test for #11123 (#11312)
Loading a type that has a field from an assembly that cannot be loaded should
still leave the type usable for some operations such as IsSubclassOf.
2018-10-25 00:21:24 +02:00
Rodrigo Kumpera 3039d6f3f0 [wasm] Improve build reliability. (#11349)
* [wasm] Fix wasm toolchain bootstraping

* [wasm] Move the provision step to happen before the build.
2018-10-25 00:20:35 +02:00
Alexander Köplinger cd47933265 Bump corefx 2018-10-25 00:14:49 +02:00
Jay Krell e8b0376421 Stack-based icall parameter handles and only one managed/native transition per icall. (#11294)
Handles for icall parameters allocated in managed (but not native), can just be pointers to locals or parameters.

Currently the managed stack is scanned conservatively.
When this changes, there will be metadata provided to find these, so this approach will just keep working and should still be ideal (aside from nohandles or staying in managed).

For ObjIn, use pointer to parameter.
For ObjOut/ObjInOut, the parameter might, though it is far fetched, point to a native frame, which isn't convincing. Therefore for those, use a pointer to a managed volatile local, closer to how handles looked like.
For ValueTypeRef, make the parameter volatile so it is sure to survive.

We use volatile instead of merely address-taken because 1. a hypothetical aggressive whole program compiler/optimizer could see through address-taken (runtime and wrappers and corlib compiled together).  2. ValuetypeRef is even easier to optimize/break because the address-taken is  dead.

FIXME: Tests that exercise every icall, coop and otherwise.
FIXME: Gcstress.

Collateral damage: The one rarely run assert that handles are not out of scope
cannot be so easily implemented so is removed. It might come back though, if we type tag the handles.

Furthermore, the handle stack setup/cleanup can be done in native instead of managed.
Furthermore, the error check can either be done in native instead of managed, or the fast path inlined in the JIT. Here we just move it to native (and inline the fast path in native).

Therefore coop icalls go from 3 + handle-count managed/native transitions, to just always one,  *and* at least some of their handle allocation is exceedingly fast and free of TLS.

The typed handle wrappers change from returning a handle to returning a raw pointer.
Because previously the handle would be allocated in the handle frame setup by the JIT.
Now the JIT doesn't setup a handle frame.

There is a weakreference test that is seemingly very sensitive to stack layout.
For this reason at least, the MonoError is still allocated on the managed side.
 Moving it to native broke the test.
This might also be preferable for the public interface.

Coop icalls retain some costs:
  - The volatile might cost a little -- lack of enregistration.
  - Native code allocating handles.
  - Still TLS access.
  - JIT icalls (vs. metadata-driven) still native-only handle allocation, and still fully manual conversion.
  - Coop icalls that return an object always allocate a handle -- could be more efficient out or inout handle instead, though inout is currently very rare.

Some of this can be further mitigated.
Mainly, the metadata icall signatures could move the "local" handles  to be out parameters, in order for managed to allocate them.

The JIT icalls could have richer signatures than just "ptr" and gain these wrappers, or previous (ref parameters, retyped as handles).
2018-10-24 09:38:19 -07:00
Zoltan Varga 38caaf67b1 [jit] Remove unused mono_arch_instrument_prolog ()/epilog () functions. (#11304) 2018-10-24 12:18:47 -04:00
Maxim Lipnin f933418246 Fix the issue when ParameterInfo.RawDefaultValue returns Missing.Value for non-null default values of DateTime?` and decimal? parameters (#11330) 2018-10-24 14:33:38 +02:00
Marek Safar 45a2ea63ce [corlib] Remove unused files (#11322)
* [corlib] Remove unused files

* [csproj] Update project files
2018-10-24 14:17:23 +02:00
Alexis Christoforides 05bc22015c [corlib] Import System.IO.TextReader/StreamReader from CoreFX (#11044)
* [corlib] Import System.IO.TextReader/StreamReader from CoreFX

* Bump API snapshot submodule

* [csproj] Update project files
2018-10-24 04:16:01 -04:00
Aleksey Kliger (λgeek) 1680235bda [wasm] Add missing include (#11335)
Fixup for
https://github.com/mono/mono/commit/5e961c6deb27c6bfc46cdba99274bbe02f8f0562
2018-10-23 22:28:55 +02:00
Maxim Lipnin 5392af120b [Reflection] Fix ParameterInfo's custom modifiers order (#11308)
* [Reflection] Reverse custom modifiers order in ParameterInfo's  GetRequiredCustomModifiers and GetOptionalCustomModifiers methods to follow NetFX/CoreFX behavior.

* Move reversing custom modifiers from managed code to native one.

* Small refactoring

* Disable System.Reflection.Emit related test on Full AOT mode.
2018-10-23 19:08:48 +02:00
Aleksey Kliger (λgeek) 5e961c6deb [marshal] Emit GC Safe transitions around foreign internal calls. (#11183)
* [threads] Make mono_add_internal_call external only

The runtime should use mono_add_internal_call_internal or
mono_add_internal_call_with_flags.

The thread suspend mechanism needs to know if an icall is added via the legacy
mono_add_internal_call API (which is not coop-aware, and so the registered
icalls must run in GC Safe mode), or if it is added by the runtime or by a
cooperative client (currently either the profiler or the System.Native PAL)
which knows to add GC transitions and safepoints and not to block indefinitely.

* [marshal] Factor out GCSafeTransitionBuilder

Make a local builder for creating the GC Safe transition calls for a method wraper.

* [sgen] Add coop GC transitions in mono_gc_toggleref_add

Also mark it external only. It's not used inside the runtime.

* [marshal] Emit GC Safe transitions around foreign icalls.

A foreign icall is added using mono_add_internal_call and that is not coop GC
aware.  (The runtime uses mono_add_internal_call_with_flags or
mono_add_internal_call_internal)

Under hybrid suspend, foreign icalls will run in GC Safe mode and transition to
GC Unsafe only when the call back into the runtime or invoke managed code.

Fixes https://github.com/mono/mono/issues/11138

* [cxx] function type overloads for mono_add_internal_call_internal

and mono_add_internal_call_with_flags

* [runtime] Add new API call mono_dangerous_add_raw_internal_call

Under hybrid suspend, this adds an icall that is assumed to run in GC Unsafe
mode.  As such it has additional requirements for correct operation: it must
not run loops without periodically polling the runtime, and it must not perform
blocking operations such as blocking I/O or taking locks without manually
switching to GC Safe mode.
2018-10-23 11:42:45 -05:00
Miguel de Icaza 8a1377130f [wasm] Add bindings API documentation 2018-10-23 11:28:55 -04:00
Egor Bogatov 4693c9775c [corlib] DateTime, TimeSpan and TimeZone from CoreFX (#11232)
* DateTime from corefx

* TimeZone and TimeSpan from corefx

* bump corefx

* remove some reflection tests temporarily (due to corefx bump)

* ignore "Obsolete" warrning-error in System.XML (because of TimeZone)

* undo submodules

* remove TimeZone.cs

* Add tests

* clean up

* fix failing TZ tests

* Add HebrewCalendar as optional to "he" culture

* ignore failing tests

* Bump API snapshot submodule

* [csproj] Update project files
2018-10-23 17:25:30 +02:00
Alexander Kyte 109563930d [crash] Add mono_crash uploader for Sentry (#10840)
* [crash] Report which thread was crashing

* [crash] Added upload-to-sentry tool

* [crash] Add sentry uploader step to telemetry
2018-10-23 17:24:26 +02:00
Maxim Lipnin 5de2976c11 Enable more corefx reflection tests (#11221)
Part of #9660 

Instead of https://github.com/mono/mono/pull/11025

https://github.com/mono/corefx/pull/152 needs to be merged.
2018-10-23 14:06:58 +02:00
Jay Krell c1e5e1d395 Remove two accidentally added functions from old version of a commited PR. (#11289) 2018-10-22 15:29:48 -07:00
Jay Krell 3c74df5667 [coop] Transition all functions in object.h to MONO_RT_EXTERNAL_ONLY (#11188)
In general this is achieved by renaming mono_foo to mono_foo_internal,
and mono_foo_bar calls mono_foo_bar_internal, possibly adding a GC mode change
to mono_foo_bar and removing from mono_foo_bar_internal.

We can also consider other names like m_foo_bar, mi_foo_bar, m.foo_bar, m->foo_bar, m::foo_bar, using mi = mono_internal; mi::foo, foo.bar(), etc.

* [test] Report dlsym failure with an assertion failure and give the symbol.

* Compilation of external-only.c/.o needs special care.
Because it is dead code, except for exports, the linker does not necessarily eagerly look into it (.o within .a), and export anything. This is the usual behavior of Windows linker. Unix linker I guess it varies between programs and shared libraries, but it was observed and broke a test, and a small case was constructed to demonstrate the behavior (i.e. where the dlsym assert is added), even though I assumed the opposite -- so must be program vs. sharedlibrary.

Therefore, we `#include external-only.c` in object.c.

Longer term we should probably use Windows .def files and their Unix equivalent, and/or be sure to list external-only.o directly on the link command line, instead of burying it in a static library.

.def files were used in the past and have other advantages/differences.

Other than guaranteeably reaching into .a/.lib files to find exports, they also export on NT/x86 as plain "mono_foo" instead of "_mono_foo", easing portability of LoadLibrary / GetProcAddress.
The loss of the x86 C name mangling *could* be viewed as a loss, of a tiny amount of safety.

They also make declspec(dllimport) and declspec(dllexport) both pointless, at least for C functions -- dllimport remains significant for data and C++ (no need to list mangled names in .def file), and to microoptimize one instruction out of some calls on non-LTCG builds.
2018-10-22 14:03:05 -07:00
Johan Lorensson f2d67cd299 Windows BTLS assembler build support (cygwin/msvc). (#11234)
* Add support for BTLS assembler build on Windows (cygwin/msvc).

Building BTLS with assembler support on Windows requires several
additional build tools (except cmake) for both cygwin/msvc builds.
On cygwin, perl and yasm will be needed and on msvc, ninja, perl
and yasm. On msvc builds BTLS doesn’t support Visual Studio generator
when building with assembler support, so this commit adds support for
ninja build system covering that scenario. This commit adds support for
auto detection of needed build tools and enable assembler builds if all
needed tools have been identified as available. Commit also fixes the
execution of msbuild on CI to just use the original PATH variable instead
of the cygwin PATH to make sure correct version of identified build tools
gets used (Windows version of git, ninja, perl and yasm). Both cygwin and
msvc build will use nasm compiler (through use of yasm) since generated
assembler won’t compile with mingw’s gcc version.

* Bump BTLS commit.

* Fix a couple of warnings on BTLS build.

* Fix failing certificate import test using BTLS on Windows.

Mono BTLS library assumes all passwords are ANSI encoded strings since
SafePasswordHandle gets passed directly through pinvokes. This is only true for
SafePasswordHandle implemented on Unix:es. On Windows, SafePasswordHandle stores
passwords as Unicode, most likely due to Windows Crypto API accepting Unicode
passwords. When using BTLS on Windows this difference submerged since passwords
passed to BTLS will be Unicode encoded failing the decryption of PCKS12 structure.

Keeping the pattern already in place, passing SafePasswordHandler all the way
through pinvokes, the needed conversion will be done just before calling into OpenSSL
library as part of mono's BTLS library adapter.
2018-10-22 15:58:52 -04:00
Jay Krell ab17f4555d Fix warnings about unprototyped icalls and duplicate typedefs. (#11298) 2018-10-22 11:03:06 -07:00
Alexis Christoforides 412d35bd79 [class] Ensure 'cast_class' is initialized for array type classes. (#11268)
* [class] Ensure 'cast_class' is initialized for array type classes.

Fixes https://github.com/mono/mono/issues/9507

Background: Monoclass:cast_class is used internally to allow for some interfaces to be assignable to each other if they share a "storage class" instead of the class's element class. This is used to i.e. implement IList<ulong> being assignable from IList<long> (IList<ulong> has cast_class=long)

Consider a GenericClass<T> with a T[] field. On instantiation with e.g. GenericClass<ulong> , the ulong[] array class will be generated. As above, ulong[] has cast_class=long
When mono_class_init() is called on an array class, its element_class is also initialized.
If GenericClass<T>:Method() uses any type/subtype checking (e.g. if (field is double[]) ), those may attempt to use cast_class, which is not ensured as initialized.

* Fix typo

Co-Authored-By: alexischr <[email protected]>
2018-10-22 13:16:11 -04:00
Bernhard Urban c2c178c111 [ci] run regression tests with AOT (#11092) 2018-10-22 17:53:23 +02:00
Zoltan Varga 14b061ba65 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 08:45:43 -04:00
Zoltan Varga bf6a1edf75 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 07:08:54 -04:00
Zoltan Varga 299ae7a84e [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 07:08:38 -04:00
Zoltan Varga 54503ed970 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 07:08:14 -04:00
Zoltan Varga a7f448ad32 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 07:08:00 -04:00
Zoltan Varga 479a90be29 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 07:07:45 -04:00
Bernhard Urban b969364b7d [ci] run regression tests with AOT (#11092) 2018-10-22 12:46:20 +02:00
Zoltan Varga 5c5aef6164 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 04:06:26 -04:00
Zoltan Varga d58bf0bf41 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 04:06:03 -04:00
Zoltan Varga d7705f3fa5 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 04:05:40 -04:00
Zoltan Varga af0f521891 [jit] Profiler argument handling changes (#10885)
[jit] Profiler argument handling changes
2018-10-22 04:05:17 -04:00
Zoltan Varga 2b029b3df4 [jit] Profiler argument handling changes (#10885)
* [jit] Add support for accessing method arguments in the profiler in llvmonly mode, by generating code to store them into the MonoProfilerCallContext.args array.

* [jit] Use ctx->args instead of ctx->context for accessing arguments in the profiler.

* Update after review comments.

* [jit] Switch --trace to use the profiler infrastructure.

* Fix a rebase problem.

* Fix c++ failures.
2018-10-22 02:20:39 +02:00
Zoltan Varga aa670c98cb [wasm] Fix AOT support. (#11291)
* [wasm] Fix the creation of runtime.js in ninja mode.

* [wasm] Exit with an error code if the emscripten runtime hits an abort.

* [wasm] Error out when mono_wasm_load_runtime () fails too.

* [wasm] Wrap some code in ENVIRONMENT_IS_SHELL.

* [aot] Emit runtime invoke wrappers for up to 40 parameters for bitcode, newly added tests depend on it.

* [aot] Fix a buffer overflow in mini_get_gsharedvt_out_sig_wrapper_signature ().

* [wasm] Remove some filesystem code which is no longer needed.

* [wasm] Disable coop gc on the cross compiler, it effects the generated code.

* [wasm] Use a different random device under wasm so we can override its behavior. This is needed because /dev/random no longer works in emscripten 1.38.13 in JS shells.

* [wasm] Bump emscripten to 1.38.13.

* [wasm] Print a stack in one more abort case.

* [wasm] Add putchar to EXPORTED_FUNCTIONS, llvm-lto seems to create references to it after linking.
2018-10-21 22:44:43 +02:00
Alexander Köplinger 6a8a2059bb [Microsoft.Build.Engine] Fix race condition in TestTasks.dll compilation and embedding (#11275)
Since we've started embedding test resources inside of the test assembly
we've sometimes seen a strange error on Jenkins during the test run:

```
Msg: Error initializing task StringTestTask: Could not load file or assembly 'Microsoft.Build.Utilities.Core, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
Msg: Error initializing task StringTestTask: System.TypeLoadException: Could not load file or assembly 'Microsoft.Build.Utilities.Core, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
  at (wrapper managed-to-native) System.RuntimeType.GetConstructors_native(System.RuntimeType,System.Reflection.BindingFlags)
...
```

However this was from an xbuild_12 run so how come it tried to load xbuild 14 stuff?

The reason is there's a race condition between when TestTasks.dll gets
built and when it's embedded inside of the test assembly.

If we're building the xbuild_12 and xbuild_14 profile at the same time
we could end up embedding the xbuild_14 version of TestTasks.dll instead
of the correct one since we're copying it to the same file name.

The fix is to remove the unnecessary copying logic since we can just tell
the compiler to embed the file under the correct name.
2018-10-21 02:09:37 +02:00
Vlad Brezae 4a6b11577f [aot] Reenable recursion checking when initing shared got entries (#11258) 2018-10-20 12:37:59 +02:00
Jay Krell 0a2b2b7b21 Disable direct x86 aot tailcalls. Except to self. (#11282)
FullAOT is hypothetically ok, but FullAOT has other problems (https://github.com/mono/mono/issues/11276).

This addresses https://github.com/mono/mono/issues/11265.
This regressed presumably https://github.com/mono/mono/commit/f5373adc8a89d4b0d1d549fdd6d9adc3ded4b400.
2018-10-19 23:44:00 -07:00
Jay Krell f87470806d Fix recently introduced warning. (#11257) 2018-10-19 23:47:51 +02:00
Bernhard Urban b104565ccf [interp] use unsigned conversion for nuint (#11259)
[interp] use unsigned conversion for nuint

Fixes `MutableDataTest.Constructor` on Xamarin.iOS with interpreter.

monotouch tests are looking good now with interp-only:
<img width="906" alt="screenshot 2018-10-19 at 11 22 07" src="https://user-images.githubusercontent.com/75403/47209686-3d7b2780-d391-11e8-887f-9e1f39de2026.png">
😬
2018-10-19 17:25:33 -04:00
Jay Krell 44db64c620 Typesafe coop handles for all platforms. (#11012)
This is an alternative or precursor to https://github.com/mono/mono/pull/10212.

 - Removes the dependency of some ABIs passing a pointer and a pointer in a struct the same.
 - Therefore gives all platforms the same type safety.
 - *If* we move to C++, allows us to have member functions in coop handles.
 -  Having the coop signatures available in C can provide  benefits, though we should 
    probably generate them from reading metadata -- though they won't match w/o more changes,
    since we mixup types in several places, like IntPtr vs. pointers.

JIT now traffics in old type-unsafe handles, and wrappers are generated with C preprocessor to trivially convert.
 This way the JIT doesn't have to pass structs by value here, which was tried/failed.

The C preprocessor machinery can/should be extended for additional gains.
In particular driving managed/native coop icall transitions from 3+ per call to 1 (like https://github.com/mono/mono/pull/10212).

That will require better verification of the signatures in icall-def.h, either automated and en masses or gradually manually. Embedders will likely do something else, or at least have to independently invent similar.

Whereever a native function was exposed via multiple managed names, wrappers are reused.
2018-10-19 14:13:28 -07:00
Aleksey Kliger (λgeek) eaaf83ef92 [runtime] Don't init classes in ves_icall_RuntimeTypeHandle_is_subclass_of (#11227)
We must not get a TLE if referenced types are in an assembly that can't be
loaded.

Fixes https://github.com/mono/mono/issues/11123
2018-10-19 14:11:31 -04:00
Kenneth Pouncey 85493320e7 [wasm] Fix Sample.html so sample will run (#11242)
* [wasm] Sample program in wasm sdks does not run.

- Add `mono-config.js` reference to html file.

resolves: https://github.com/mono/mono/issues/11239

* Fix `runtime.js` to reference `mono-config.js` variables.

* Fix packager.exe where it deletes the `runtime.js`.

- Replaced the File Delete and Copy with a Copy if new call.
- re-add the generation of a skeleton  `runtime.js` file if one can not be found.
2018-10-19 20:08:56 +02:00
Alexander Köplinger e48ca0d4cc [Mono.Debugger.Soft] Fixed spaces vs. tabs in Makefile 2018-10-19 20:04:50 +02:00
monojenkins 86941b00c1 [WinForms] Propagate the flags from DrawTextInternal to MeasureTextInternal (#11262)
Flags to DrawText never reached MeasureText therefore strings with '&' were measured incorrect when drawn with flag TextFormatFlags.NoPrefix.
Fixes #6352
2018-10-19 18:09:53 +02:00
Alexander Köplinger 2d8839e704 [System] Don't throw NIE for ServicePoint.ConnectionLeaseTimeout and .ReceiveBufferSize (#11246)
* [System] Don't throw NIE for ServicePoint.ConnectionLeaseTimeout and .ReceiveBufferSize

Instead return a no-op value. This is the same behavior as .NET Core.

Fixes https://github.com/dotnet/standard/issues/642

* Bump API snapshot submodule
2018-10-19 17:48:23 +02:00
Alexander Köplinger 2c1e5292f5 Bump corefx submodule
MemberInfoTests.cs moved from System.Runtime -> System.Reflection
2018-10-19 13:37:43 +02:00
Eberhard Beilharz 5fa2df8b4d [metadata] Fix crash related to custom attributes (#10739)
* [tests] Renumber duplicate return codes

* [metadata] Fix crash related to custom attributes (#10737)

When a class doesn't contain the desired custom attribute we used
to return the last available attribute. This prevented
`cominterop_ccw_queryinterface()` to detect that the interface
isn't implemented and lead to a crash.

This change fixes #10737.

* [cominterop] Switch to GC Unsafe in IUnknown and IDispatch impls

These methods can be called directly from embedding APIs.
2018-10-19 07:03:25 -04:00
Ludovic Henry aa5438dd5d [sdks] Package what's missing for XA (#11253)
They require the additional files:
 - mono/eglib/eglib-config.h: that's to build `libmonodroid`
 - mcs/build/Consts.cs: that's to build `Mono.Posix` and `Mono.Data.Sqlite`
2018-10-19 06:57:31 -04:00
Rodrigo Kumpera 2ae12c6a0a [wasm] Fix provision-wasm to do emsdk selection. Remove the need for the emcc patch. (#11250)
[wasm] Fix provision-wasm to do emsdk selection. Remove the need for the emcc patch.
2018-10-19 04:45:41 -04:00
Vlad Brezae 7a40ab148d [interp] Remove mint_type uses at execution time (#11167)
It is too slow. Check during transform whether the class is stored on vtstack or not.
2018-10-19 10:27:00 +03:00
Kenneth Pouncey dd7ac9ddd6 Fix Duplicate assemblies in config.js file_list: [ ... ] (#11236)
resolves: https://github.com/mono/mono/issues/11187
2018-10-19 02:28:23 -04:00
Alexander Kyte 9aab5273dd Add crash reporting debugger event (#10628)
This should help get information on native crashes that happen in hard-to-debug environments. 

To quote https://github.com/mono/mono/issues/10157 : 


When a mono runtime is attached to a managed debugger and the debugged runtime is induced to cause a crash, the state of that crash is not communicated to the managed debugger. This, combined with the difficulty in having the debugged runtime both attached to the managed debugger and lldb, makes this type of crash difficult to interactively debug.

When the managed debugger is the only connection someone has with the runtime because it is embedded in a way that is resistant to unmanaged debugging (watchOS application on-device, for instance), this is an even more difficult problem.

By adding an SDB protocol event that sends a type of "runtime death" and a blob of opaque json (version dependent, no protocol guarantees), people can report these crashes without having to assist a mono runtime engineer in observing a crash on device.

In the case that spurious bugs in this manner are submitted, it will require less effort as well to spot stack frames that indicate misuse of mixed managed-unmanaged APIs (which offer the ability to drive a segfault or g_assert
2018-10-19 02:39:03 +02:00
Alexis Christoforides 4844ab019d [corlib] Import System.IO.UnmanagedMemoryStream from CoreFX (#11210)
* [corlib] Import System.IO.UnmanagedMemoryStream from CoreFX

* Bump API snapshot submodule

* [csproj] Update project files
2018-10-18 18:34:38 -04:00
Ludovic Henry bdebfe93fb [tests] Embed Mono.Data.Sqlite test resource (#11244) 2018-10-18 18:30:49 -04:00
Zoltan Varga ab18dea99b [arm64] Remove the limitation on the number of nullable arguments for dyncalls. (#11186)
* [arm64] Remove the limitation on the number of nullable arguments for dyncalls.

Fixes https://github.com/xamarin/xamarin-macios/issues/4984.

* [amd64] Remove the limitation on the number of nullable arguments for dyncalls.

* [jit] Add tests for dyncalls with lots of nullable arguments.
2018-10-18 23:11:31 +02:00
Jay Krell d16869c510 Remove a few raw pointers, correct some signatures, remove some unnecessary handles(). (#11211)
* Mark AddRefInternal as NOHANDLES(). Its signature was incorrect.

* Change ves_icall_System_Runtime_InteropServices_Marshal_ReleaseInternal to NOHANDLES.

* Mark ves_icall_System_Runtime_InteropServices_Marshal_QueryInterfaceInternal NOHANDLES.

* ves_icall_System_Runtime_InteropServices_Marshal_BufferToBSTR to nohandles().

* ves_icall_System_Runtime_InteropServices_Marshal_FreeBSTR to nohandles().

* ves_icall_System_Runtime_InteropServices_Marshal_FreeHGlobal nohandles().

* ves_icall_System_Runtime_InteropServices_Marshal_FreeCoTaskMem nohandles().

* Fix the signature of ves_icall_System_Runtime_InteropServices_Marshal_AllocCoTaskMemSize.

* [coop] Remove most uses of out_of_memory_ex.
2018-10-18 22:27:03 +02:00
Ludovic Henry cb616340d0 [pipeline] Ensure only 1 build per-product is executed per-node (#11247) 2018-10-18 22:09:16 +02:00
Alexander Köplinger 229a4673d4 [ci] Move OSX .pkg build to a separate bot pool
Allows us to better utilize the bockbuild cache.
2018-10-18 16:36:01 +02:00
Alexander Köplinger d07ddffffe [Mono.Debugger.Soft] Simplify building dtest-app.exe for monodroid profile (#11229)
We only build it if we're explicitly building the monodroid profile and for the
monodroid_tools profile we only build the test assembly but not dtest-app.exe
2018-10-18 13:06:27 +02:00
Alexis Christoforides 660ca3bc70 [corlib] Ensure that Console Streams are thread-safe (#11205)
The Console class wraps the standard system stream reader/writers on construction so as to expose them as thread-safe. However, the Set-Out/In/Err methods in referencesource do not do the same when they replace default targets.

CoreFX code does: https://github.com/mono/corefx/blob/1748f6492e8b96842f76e1a9e7b5d7e8ccfca480/src/System.Console/src/System/Console.cs\#L412-L444

Possible fix for https://github.com/mono/mono/issues/11146
2018-10-17 17:10:40 -04:00
Martin Baulig 95017ad9e4 Add myself as code owner of mono/native and some managed code. (#11228)
- `mono/native`
- `/mcs/class/corlib/Mono` (dependency injector, mono native, pal, certificates)
- `mcs/class/corlib/System.Security.Cryptography.X509Certificates`
- `/mcs/class/System/Mono` (PAL, certificates and dependency injector)
- `/mcs/class/System/System.Security.Cryptography.X509Certificates`
2018-10-17 21:26:47 +02:00
Ludovic Henry a282040c96 [bcl] Build all XUnit and NUnit tests for monodroid, monotouch, monotouch_tv, monotouch_watch and wasm BCL profiles (#11201) 2018-10-17 14:44:45 -04:00
Vlad Brezae 2b64076769 [aot] Ensure shared got entries are initialized before loading methods (#11190)
Executing aot code that uses them would crash. Fixes random csc crashes.
2018-10-17 14:21:45 -04:00
Egor Bogatov 2a250915c4 [corlib] Add xunit tests for BitConverter, Convert, etc (#10758)
* Add System.Runtime.Extensions tests

* ignore Environment.UserDomainName.cs

* bump corefx
2018-10-17 07:45:55 -07:00
HebaruSan b286fe3d74 Fix MessageBox text color for dark themes (#11196)
## Problem

`MessageBox` displays as black-on-dark in a dark theme:

![image](https://user-images.githubusercontent.com/1559108/47039608-f64f2580-d149-11e8-9c1d-1dd8d99d4cb8.png)

This can be difficult to read.

## Cause

The text is drawn with a hard coded color of `Color.Black`. This assumes that the background under the text will be light to contrast with black.

## Changes

Now the color is `SystemColors.ControlText` instead, to match the background of the popup.

In a normal theme this will still be black.
2018-10-17 14:10:17 +02:00
Alexander Köplinger a2f0c286af [pkg] Add preinstall which removes existing Mono of the same version (#11203)
Fixes https://github.com/mono/mono/issues/11202
2018-10-17 12:50:11 +02:00
Alexander Köplinger 237482628a Bump api-snapshot 2018-10-17 12:35:34 +02:00
Johan Lorensson b2d0e7e8a6 Merge pull request #11100 from lateralusX/lateralusX/build-btls-msvc
Build BTLS on Windows, Visual Studio.
2018-10-17 08:39:55 +02:00
Alexander Köplinger efd6c05aef Upstream a few test related commits from my Helix work (#11197)
* [bcl] Run System.Windows.Forms.DataVisualization tests

* [bcl] Run Mono.Messaging.* tests

* [bcl] Use correct label for mdoc tests

* [runtime] Skip verifying an xunit-binaries assembly
2018-10-17 03:48:49 +02:00
Jay Krell 99c3c9ba32 Fix cygwin configure error message to match scripts/ci. (#11151) 2018-10-17 01:54:12 +02:00
Bernhard Urban 965aebf500 [ppc] fix UCONTEXT_REG macros for FreeBSD (#11128)
Contributed by @lenoil98. Fixes https://github.com/mono/mono/issues/11020
2018-10-17 01:49:47 +02:00
Alexis Christoforides d3769a73ff [corlib] Import System.IO.IOException from CoreFX (#11102)
* [corlib] Import System.IO.IOException/FileLoadException from CoreFX

* [corlib] Remove unused string

* [corlib] Remove another test assert for BadImageFormatException

Exception message no longer includes the file name
2018-10-17 01:38:30 +02:00
Alexander Köplinger 0fad97f2f3 [wasm] Use latest Microsoft.AspNetCore.App in ProxyDriver.csproj 2018-10-16 23:10:53 +02:00
Alexander Köplinger 74687a0a63 Remove azure-pipelines.yml
It was an experiment
2018-10-16 22:50:08 +02:00
Alexander Köplinger 6c7790d0a8 Move CODEOWNERS to .github folder
So all GitHub related special files are in one place
2018-10-16 21:28:05 +02:00
Martin Baulig b61a3ffb02 [System]: Reenable native Apple Certificate support on WatchOS. (#11173)
During the code refactoring this summer, support for native apple certificates
has been dropped on watchOS.

* add `apple-certificates.sources` and move all certificate-related code from
  `appletls.sources`.

* move non-network related code from `MacProxy` into a new `AppleTypes`.

* add the `MONO_FEATURE_APPLE_X509` magic to `System/Makefile` where it was missing from.
2018-10-16 20:57:09 +02:00
Ludovic Henry 2a4cfddd9a [sdks] Build tests for BCL targets (#11141)
* [sdks] Build BCL profiles without configure flags

* [sdks] Add BclTemplate to build BCL profiles

This is to avoid building all the profiles in a single `sdks/out/bcl` directory which will be shared between android, ios and wasm.

* [sdks] Simplify call to BclTemplate

* [mcs] Make directory dependency as order-only

We would otherwise always rebuild the target since the directory is updated whenever something is added to the directory. This is a common Makefile technique.

* [sdks] Build tests for BCL targets
2018-10-16 14:00:12 -04:00
Jonathan Chambers 36edb2f275 Take fast path only for delegate types not Delegate/MulticastDelegate. (#11182) 2018-10-16 13:14:32 -04:00
Alexander Köplinger 7a505f2e40 [mcs] Fix platform-specific build of "build" profile and remove more remnants of the "basic" profile (#11185)
The platform specific build got lost in 8d8fd97dbf but we need it for monolite. The remnants of the "basic" profile are no longer needed.
2018-10-16 19:12:13 +02:00
Ludovic Henry 0fd450ac6b [sdks] Add Groovy script to build the SDKs archives for the products (#11137) 2018-10-16 11:03:51 -04:00
Zoltan Varga 0beb087567 [WIP] [wasm] AOT work. (#11071)
* [runtime] Fix the signature of some native type tests.

* [runtime] Add stubs for the ves_icall_System_Net_NetworkInformation_MacOsIPInterfaceProperties_ParseRouteInfo_internal () icall, needed for AOT.

* [wasm] Print a native stack trace on asserts.

* [wasm] Avoid mmaps with zero length, it leads to an exception under emscripten.

* [bcl] Preserve CustomAttributeData:.ctor (), its called from the runtime.

* [wasm] Print out full test names in the test runner.

* [wasm] Preserve System.Threading.WasmRuntim.

* [wasm] Rename config.js to mono-config.js

* [wasm] Add targets to build aot versions of the test suites.

* [wasm] Exit with a nonzero exit code in case of a failure.

* [wasm] Disable crash reporting.

* [wasm] Use mono headers for public functions.

* [wasm] Enable building AOT tests on CI.

* [wasm] Run some AOT test suites on CI.

* [runtime] Make MonoBundledAssembly.size non-const.

* [wasm] Add a --setenv=VARIABLE=VALUE argument to runtime-tests.js which allows the setting of environment variables.

* [wasm] Update cross compiler executable name.

* [wasm] Remove unused aot-driver.js file, runtime-tests.js has the same functionality.

* [wasm] Run mini tests with AOT on CI.

* [wasm] Error out if the linker fails.

* [wasm] Fix building the AOT tests from another directory.

* [wasm] Use a matching Mono.Cecil.dll for the linker.

* [wasm] Fix running aot tests on CI.

* Revert "[sdks] Switch the invocation of the offsets too to 64 bit on osx. (#10903)"

This reverts commit 2989a83f23.

This seems to cause failures on linux+webassembly.
2018-10-16 10:29:29 +02:00
monojenkins b71a4b76bb [sdks] futimens and futimes symbols are missing on anything earlier than 10.13 (#11179)
This breaks when LLVM is built on 10.13+ and the runtimes are built on 10.12.
2018-10-15 23:02:41 -04:00
Martin Baulig f973c6d90f [System] Make a test compile on mobile. (#11175) 2018-10-16 01:12:14 +02:00
Jay Krell d30c8649f1 mono_field_get_type to mono_field_get_type_internal to skip GC mode machinery (#11082)
But also optimize mono_field_get_type in the common case, to "short circuit"
and skip ditto.
2018-10-16 00:40:43 +02:00
Alexander Kyte 2d415fa1b3 [crash] Split unmanaged method pointers into method ip + offset (#11142)
The VS4M team is making a tool that makes a symbolication lookup table. This enables symbolication without access to the relevant binary. 

For unmanaged, it's much harder to precompute things because we were presenting the instruction address. From the address, any lookup needs to find the function enclosing this interior pointer.

To make it easier, this reports the address of the native method as well as the offset. A lookup table can simply key on the function start address with this now. 

ie:

  ``` 
      {
        "native_address" : "0x1003a6340",
        "native_offset" : "0x00046",
        "native_module" : "mono"
      }
```

 ```
$ nm mini/mono-sgen | grep '1003a6340' 

00000001003a6340 t _mono_runtime_run_main_checked

```

```
$ nm mini/mono-sgen | grep ' t ' | sort -n

00000001000a4e90 t _alloc_ireg
00000001000a4eb0 t _decompose_long_opcode
00000001000aae90 t _mono_decompose_long_opts
00000001000aaea0 t _mono_decompose_vtype_opts
00000001000ae130 t _m_class_get_byval_arg
00000001000ae150 t _alloc_dreg
............
```
2018-10-16 00:39:37 +02:00
Jay Krell c105cd2339 Remove GC mode transitions from mono_array_length, and replace with mono_array_length_internal. (#11122) 2018-10-15 14:07:58 -07:00
Alexander Kyte 1bc31b3ab1 [crash] Bump static memory for crash string to 500k
Note:
- This memory isn't accessed until we're crashing
- On any modern machine, unused static memory is lazily allocated. When
we access it, the fault will trigger the MMU to map memory for us.
- This is guaranteed to be reentrant and safe. mmap (the alternative) is
surely fairly stable on many systems, but this is not guaranteed. The
documentation pages for mmap specifically claim it as not safe in these async
contexts.
2018-10-15 13:12:50 -04:00
Alexander Kyte aef45d547e [crash] Print half-completed dump when space runs out 2018-10-15 13:12:50 -04:00
Martin Baulig 51548b4d37 Initial Mono.Native Support. (#10596)
`Mono.Native` is the new name for both `System.Native` and `System.Security.Cryptography.Apple`.
It is built as a stand-alone shared library and not bundled with the runtime because we
may need to build two different versions of it.

Starting with macOS 10.12+ and iOS 10+, Apple introduced a new Unified API for some of the
crypto primitives that we're using as part of System.Security.Cryptography.Apple.

On Desktop, we can check at runtime whether the OS version is recent enough and switch
implementation accordingly.  We build a single `libmono_native` shared library.

However, on Mobile we cannot have any undefined symbols as this would break Bitcode.

During the mobile build, we are called with `CC` containing an explicit minium version flag,
which is either `-mmacosx-version-min=`, `-mios-simulator-version-min=` or `-miphoneos-version-min=`
depending on platform.

We build two versions of the shared library:
- `libmono_native_compat` is built with whichever minimum version is passed to us via `CC`.
- `libmono_native_unifed` is built with the minimum version set to macOS 10.12+ / iOS 10+.

For testing purposes, there is a function called `mono_native_get_platform_type ()`
(see mono/native/mono-native-platform.c), which returns a `MonoNativePlatformType` enum value.
There is also `Mono.MonoNativePlatform.GetPlatformType ()` (see mcs/class/corlib/Mono/MonoNativePlatform.cs).

This can be called by automated tests both to ensure that the library has been correctly installed and also
to verify that it's the correct version of it.

* `configure.ac`: add new configure checks for Mono.Native.

* `mono/native/`: new directory - this replaces the `System.Native` code that was previously in `mono/metadata`.

* `mcs/class/corlib/Mono`: New internal `MonoNativePlatformType` and `MonoNativePlatform` classes.
2018-10-15 17:38:45 +02:00
Alexander Köplinger 2ebb5efed5 Fix comment in RemoteExecutorTestBase.Mono.cs 2018-10-15 17:21:36 +02:00
lateralusX 360620a68a Additional checks for correct environment when doing msvc BTLS builds. 2018-10-15 16:51:44 +02:00
lateralusX c77084dcb8 Add lib prefix of msvc build BTLS library. 2018-10-15 14:51:22 +02:00
lateralusX d5e38af6c7 Fix BTLS build warnings on Windows. 2018-10-15 14:45:24 +02:00
lateralusX dd3e2cd0c7 Fix case insensitive compares. 2018-10-15 14:45:24 +02:00
lateralusX f8249e65be Add vcxproj to build btls as part of regular mono msvc build. 2018-10-15 14:45:24 +02:00
lateralusX 1678b9cbae Bump external/boringssl commit. 2018-10-15 14:45:23 +02:00
lateralusX c1d38347cb Build script for btls using msvc. 2018-10-15 14:45:23 +02:00
lateralusX 9761c65ae8 Fix mono btls build using msvc 2015/2017. 2018-10-15 14:45:23 +02:00
Alexander Köplinger 8d1dd6aa65 Fix Mono.Debugger.Soft to use test exe's from different directory (#11033)
And make it work for the monodroid_tools profile.
2018-10-15 14:12:19 +02:00
monojenkins fa79aa7e8b Merge pull request #11127 from lewurm/mono-ppc-sigill
[ppc] use G_BYTE_ORDER in order to define patch_load_sequence

Fixes https://github.com/mono/mono/issues/11021
2018-10-15 03:35:35 -04:00
Zoltan Varga 2989a83f23 [sdks] Switch the invocation of the offsets too to 64 bit on osx. (#10903) 2018-10-15 04:50:54 +02:00
Marek Safar 2e5d1bbe82 [metadata] Remove unused type caches 2018-10-14 08:27:44 -07:00
Maxim Lipnin 5c4e4c5084 Add check for empty string to correctly get constructors in case of name="*" 2018-10-12 18:22:08 -07:00
Maxim Lipnin 081ca12f82 [Reflection] Fixing bugs in MonoParameterInfo caught by xunit tests (#11052)
This PR fixes the bugs caught by [RawDefaultValue](https://github.com/mono/corefx/blob/411def5f278956f3c514c02ab76d9bb89428fef7/src/System.Runtime/tests/System/Reflection/ParameterInfoTests.cs#L22) and [VerifyParameterInfoGetRealObjectWorks](https://github.com/mono/corefx/blob/411def5f278956f3c514c02ab76d9bb89428fef7/src/System.Runtime/tests/System/Reflection/ParameterInfoTests.cs#L91) tests
2018-10-12 18:12:49 -07:00
monojenkins 232ed99c1c Bump API snapshot submodule 2018-10-12 18:00:46 -07:00
Zoltan Varga e5b4c144ac Fix checking the contents of the sourcelink file on windows. 2018-10-12 18:00:46 -07:00
Zoltan Varga 7f81c2776f [sdb] Add support for reading the sourcelink data from portable pdb files using a new SourceLink property on ModuleMirror objects.
Fixes https://github.com/mono/mono/issues/10038.
2018-10-12 18:00:46 -07:00
Bernhard Urban e5504fb8ea [mini helpers] strip more directives on arm (#11124)
* `-s` removes all symbols.
* `-x` removes non-global symbols.

This is needed in order to get human readable output with `MONO_VERBOSE_METHOD=method`, so instead of:

```
Disassembly of section .text:

00000000 <.text>:
   0:   e92d4900        .word   0xe92d4900
   4:   e24dd05c        .word   0xe24dd05c
   8:   e1a0b00d        .word   0xe1a0b00d
   c:   e58b0030        .word   0xe58b0030
  10:   e58b1034        .word   0xe58b1034
[...]
```

It is this now:
```
Disassembly of section .text:

00000000 <.text>:
   0:   e92d4900        push    {r8, fp, lr}
   4:   e24dd05c        sub     sp, sp, #92     ; 0x5c
   8:   e1a0b00d        mov     fp, sp
   c:   e58b0030        str     r0, [fp, #48]   ; 0x30
  10:   e58b1034        str     r1, [fp, #52]   ; 0x34
[...]
```

This is needed due to a newer toolchain on our ARM bots. Tested on armv7 and aarch64.
2018-10-12 17:23:33 -04:00
Jay Krell 697e959c6f mono_class_from_mono_type to mono_class_from_mono_type_internal to skip GC mode machinery (#11078) 2018-10-12 12:24:17 -07:00
Bernhard Urban ddf734ee52 [ppc] use G_BYTE_ORDER in order to define patch_load_sequence
Fixes https://github.com/mono/mono/issues/11021
2018-10-12 17:22:52 +02:00
Kenneth Pouncey c3999baa3d [wasm] Add support for Module.locateFile to runtime loading (#11101)
* [wasm] Fix the build.

* [wasm] Add --copy parameter to packager

- copy parameter

```

        --copy=always|ifnewer        Set the type of copy to perform
                              'always' overwrites the file if it exists.
                              'ifnew' copies or overwrites the file if modified or size is different.

```

- Fix wasm build target in do-runtime target.

* [wasm] Add support for Module.locateFile to runtime loading

See issue https://github.com/mono/mono/issues/11099 for more information.

resolves issue: https://github.com/mono/mono/issues/11099

* Fix spelling of option `ifnew` to `ifnewer`
2018-10-12 10:59:57 -04:00
Jay Krell ec623e581e Replace MONO_CLASS_IS_INTERFACE with MONO_CLASS_IS_INTERFACE_INTERNAL to avoid gc mode transitions. (#11112) 2018-10-12 07:58:04 -07:00
Jay Krell 51ebea7a48 mono_method_signature to mono_method_signature_internal to skip GC mode machinery (#11080) 2018-10-12 01:18:06 -07:00
monojenkins 656c820cf9 [2018-08] Bump msbuild (#11098) 2018-10-11 17:35:22 -04:00
Martin Baulig 3baefe7ef1 Build BTLS on Windows, cygwin/mingw. (#9306)
* Build BTLS on Windows.

* Quote more cmake paths

Should fix issue on Windows build where cmake is installed in C:\Program Files

* Fix btls cygwin x86, x64 Windows build.

NOTE, cygwin btls build depends on cygwin installed cmake, update cygwin
install to include cmake before building.

* Disable BTLS as default for Windows builds.
2018-10-11 17:25:13 -04:00
Vlad Brezae 431628cad7 [interp] Implement interpreter entry trampolines on amd64 (#10978)
* [interp] Avoid unnecessary allocations when pinvoke void functions

* [amd64] Refactor interp pinvoke context computation

* [amd64] Interp trampoline for interpreter entry

* [aot] Don't include interp_in_wrapper when we use entry trampoline

These wrappers take a lot of space in the image.
2018-10-11 17:18:30 -04:00
Bernhard Urban 15ae6a97ad [exceptions] continue program execution when mapping of stack overflow guard page fails (#11064)
* [exceptions] continue program execution when mapping of stack overflow guard page fails

Related: https://github.com/mono/mono/issues/10415

* turn comment into warning

* fix mono_gc_register_altstack call when no guard page is mapped
2018-10-11 17:16:17 -04:00
Bernhard Urban 288b9b0f95 [tests] lower recursion depth of PerformNoPinAction (#11065)
so it doesn't overflow the stack when running on macOS with `clang -O0`.
2018-10-11 17:15:54 -04:00
Jay Krell 0d308e5e9a x86 mono_arch_get_patch_offset: add support for 0xe9/jmp eip+32b. (#11089)
I don't know what the specific code is or what changed, etc.

This addresses Mac/x86:

https://jenkins.mono-project.com/job/test-mono-pull-request-i386-osx/15364/parsed_console/log.html

```Unable to compile method 'int Tests:calli_sig_check_2 ()' due to: 'Invalid IL code in Tests:calli_sig_check_2 (): IL_000b: calli     0x11000044```

which then fails an assert and fails overall.

CI goes deep into bash w/o echoing commands but a repro is:

 cd mono/mini
 MONO_PATH=./../../mcs/class/lib/net_4_x lldb -- ./mono --aot iltests.exe

The code is meant to be invalid, and meant to raise an exception,
which is catchable/resumable (at least in the JIT case where
executing IL the first time, can raise an exception while caller is
running, vs. AOT where the codegen all happens offline -- leaving what?
A note made at AOT time that calling the code should raise an exception?).

It isn't meant to fail an assert in either case.
2018-10-11 16:46:09 -04:00
Alexander Kyte c3fe80a0c4 [crash] Crash Reporter V2 (#10532)
This change set represents a major set of changes to the crash reporting mechanism. 

1) Coordination involving mandatory timeouts and signals have been changed greatly, to instead use semaphores and to end waiting as soon as possible. 

2) Dumping of unmanaged symbols outside of mono has been made possible. Embedders that want to get information on frames outside of mono-sgen can register the library with an icall. This carefully preserves both privacy (opt-in) and resiliency (can't crash/lose more info when misused).

3) The dumper has moved from a workflow that kills the runtime after a long delay into one that can dump individual threads or the entire runtime in a prompt manner. The runtime doesn't die at the end of the dump, but allows threads to resume what they were doing and returns to the caller. 

4) This has allowed for the addition of a number of tests that stress both parallel and concurrent dumping of threads. These run fairly quickly, and leave the runtime in a state to continue testing. 

5) With this lightweight testing setup created, a long burn-in testing period was done. Places we were using locks or trying to malloc resulted in crashes or hangs. After making the needed changes, it managed to run the dumping tests in a loop for a whole weekend on a Linux x64 configuration without any problems.

This has resulted in a dumper with dramatically improved stability and performance.
2018-10-11 16:38:21 -04:00
Zoltan Varga 92ebd1793b [wasm] Fix the build. (#11063) 2018-10-11 16:33:37 -04:00
Jay Krell 2c3ad9d458 mono_class_enum_basetype to mono_class_enum_basetype_internal to skip GC mode machinery. (#11079) 2018-10-11 12:13:23 -04:00
Jay Krell b77c6a6885 mono_class_is_assignable_from to mono_class_is_assignable_from_internal to skip GC mode machinery (#11081)
FIXME mono_class_is_assignable_from_checked
2018-10-11 09:48:16 -04:00
Jay Krell 70208087df Replace mono_object_get_class with mono_object_class to avoid gc transitions. (#11077) 2018-10-11 09:47:53 -04:00
Alexander Kyte 6b9b24c583 [runtime] Fixup stacktrace creation on s390x (#11073)
* [runtime] Fix mismatched parenthesis on exc-s390x

* [runtime] Fix mismatched static function type declaration on s390x

* [runtime] Fixup b7c18caf0c for s390x
2018-10-10 17:25:44 -04:00
Alexander Kyte b4067405d3 [runtime] Fix internal llvm (#11074)
The makefile uses $(dir $<) which has `../` and so refers to `llvm/external/llvm` rather than `external/llvm` now that we're using llvm from a submodule in external/
2018-10-10 15:46:31 -04:00
monojenkins fb7ad92db9 Merge pull request #11053 from BrzVlad/fix-interp-static-field
[interp] Optimize static field access

Do most of the work on transform side and include the field address in the instruction stream. We need to run cctor at runtime to preserve expected order. This makes static field access 4 times faster.



<!--
Thank you for your Pull Request!

If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.

Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
2018-10-10 13:25:41 -04:00
Aleksey Kliger 6161324629 Example experiment "null" 2018-10-10 11:54:14 -04:00
Aleksey Kliger 8a0fbd4e89 Add --enable-experiment= and MONO_EXPERIMENT= support
Experiments are unsupported and provide no stability or backward compatability
guarantees.
2018-10-10 11:54:14 -04:00
Marek Safar 8d8fd97dbf [build] Unify bootstrap profiles (#11024)
* [build] Unify bootstrap profiles

We can now rely on build only as we have reliable monolite and package
compilers

* Fixes genproj dependencies

* [csproj] Update project files
2018-10-10 08:49:38 -07:00
Maxim Lipnin 831e73abcd [Reflection] Unify exception param name 2018-10-09 18:02:24 -07:00
Maxim Lipnin 98db98fe06 [Reflection] Handle overflow exception on constructor invocation (#11028)
It allows to re-enable  [Invoke_OneDimensionalArray_NegativeLengths_ThrowsOverflowException](https://github.com/mono/corefx/blob/master/src/System.Reflection/tests/ConstructorInfoTests.cs#L96) test and enable [TestInvoke_1DArrayWithNegativeLength](https://github.com/mono/corefx/blob/master/src/System.Runtime/tests/System/Reflection/ConstructorInfoTests.cs#L79) test.

Fixes https://github.com/mono/mono/issues/10024
2018-10-09 16:59:12 -07:00
monojenkins 53f4861c2d [csproj] Update project files 2018-10-09 16:33:53 -07:00
monojenkins d44969b5c4 Bump API snapshot submodule 2018-10-09 16:33:53 -07:00
Maxim Lipnin 58dd6ac196 Disable GetTypeTests.cs 2018-10-09 16:33:53 -07:00
Maxim Lipnin 88c68600e6 [Reflection] CoreFX import for TypeDelegator type 2018-10-09 16:33:53 -07:00
Aleksey Kliger fdfd781b4a Always use InvariantCulture calendars in X509Certificate on Mobile
Allow the linker to remove UmAlQuraCalendar and HijriCalendar on mobile devices

Match the CoreFX X509Certificate changes: https://github.com/mono/corefx/commit/4eb1fc2abd2ffa70e402d22415d0209b21725a10

Fixes https://github.com/mono/mono/issues/10448
2018-10-09 15:47:26 -07:00
Jay Krell d4c0479362 [icalls] Declare all icalls correctly. (#11019)
It is hacky to have to avoid includes in order to have conflicting/incorrect declarations.

And hacky to use extern "C" when the reason is to have incorrect prototypes.

It is arguably hacky to suppress the gcc warning -- granted, the functions are never called, and merely their addresses taken and put into void* -- arguably gcc's warning is too strict and should only trigger for calls or taking address into a non-void*.

Arguably the declarations should be moved around the tree.

Perhaps we should omit the prototypes from C++.
2018-10-09 13:27:49 -04:00
Jay Krell b477d7dad8 [icall] Add InOut handles. Use InOut handles and Out handles more correctly. (#11042)
This is only an unenforced naming convention.
2018-10-09 13:27:28 -04:00
Zoltan Varga 1d71454132 [arm64] Pass small stack args correctly on linux. Fixes pinvoke.exe with llvm+full aot. (#10674)
* [arm64] Pass small stack args correctly on linux. Fixes pinvoke.exe with llvm+full aot.

* Bump llvm.
2018-10-09 11:37:54 -04:00
Bernhard Urban e357ef7ae8 Bump corefx
Commit list for mono/corefx:

* mono/corefx@17e9259f14 [tests] add finalizer helper to avoid false pinning (#156)
* mono/corefx@4eb1fc2abd Remove calendary dependency from X509Certificate

Diff: https://github.com/mono/corefx/compare/411def5f278956f3c514c02ab76d9bb89428fef7...17e9259f147d9b4b32394d249bf2b7aa1673e406
2018-10-09 11:33:12 -04:00
Zoltan Varga 65e207ba7c [wasm] AOT work. (#10989)
* [llvm] Fix the icall signature of a few llvm EH icalls.

* [wasm] Disable com/remoting in the linker.

* [wasm] Enable direct icalls.

* [wasm] Generate the configuration into a config.js file instead of rewriting the runtime.js file.

* [wasm] Enable icall symbol map in the cross compiler, compile the device runtime with -fexceptions.

* [wasm] Rename runtime-tests.g.js -> runtime-tests.js.

* [wasm] Add mono_wasm_assembly_get_entry_point () function to obtain the entry point of an assembly.

* [wasm] Add profiler support to the packager.

* [wasm] Add support for running a normal .net executable to the test runner.
2018-10-09 11:32:20 -04:00
Vlad Brezae 78455914e8 [interp] Optimize static field access
Do most of the work on transform side and include the field address in the instruction stream. We need to run cctor at runtime to preserve expected order. This makes static field access 4 times faster.
2018-10-09 17:38:39 +03:00
Ludovic Henry a618a1a9ea [sdks] Add cmake toolchain file for LLVM MXE builds (#11008)
We couldn't compile llvmwin{32,64} on Linux because we would try to use {i686,x86_64}-w64-mingw-cmake but it wouldn't exist.
2018-10-09 08:14:20 -04:00
Egor Bogatov ed50d2560a Depend on all *_test.dll.sources for make run-test (#11030)
* depend on all test.sources for `make run-test`

* fix typo (to exclude xunit tests)
2018-10-08 21:31:03 -04:00
Ludovic Henry 8b7d80396e [llvm] Add as a submodule (#11010) 2018-10-08 18:27:20 -04:00
Alexander Köplinger a8d007e51d AOT: use 32 bit flags for as/ld when targetting x86 on linux (#11032)
So it works when running the 64bit as/ld on the host with a 32bit mono binary.
2018-10-08 18:24:04 -04:00
Jay Krell 6b3cb0d93b [Coop] Convert mono_object_clone_checked, mono_object_new_from_token, mono_class_create_runtime_vtable, mono_runtime_object_init_checked. (#11018)
* [coop] Optimize mono_runtime_object_init_handle -- don't pin non-valuetypes.

* [coop] Convert mono_runtime_object_init_checked to call mono_runtime_object_init_handle.

* [coop] Convert mono_class_create_runtime_vtable.

* [Coop] Convert mono_object_new_from_token.

* [coop] Convert mono_object_clone_checked.
2018-10-08 11:36:30 -07:00
Ludovic Henry c6ddea6c06 [mcs] Fix dependencies on mcs/class/lib/<Profile>/tests/<Profile>_corlib_test.dll.nunitlite.config (#11029)
The directory mcs/class/lib/wasm/tests wouldn't necessarily be created before we would try to copy the file to it.
2018-10-08 12:42:17 -04:00
Rodrigo Kumpera df46658fd1 [wasm] Unbreak the debugger and harden it against bad assemblies. (#11011)
* [wasm] Harden the debugger against invalid breakpoints.

This happens when you reload a page and the old BPs land in now invalid code regions.

* Add node support to library_mono.js

* [wasm] Correctly register pdb files.
2018-10-08 12:08:23 -04:00
Ludovic Henry 58228c24fa [sdks] Build Android SDKs archive in Debug configuration on master builds (#11007)
* [sdks] Build Android SDKs archive in Debug configuration on master builds

* [sdks] Drop `product-` prefix from Android and iOS SDKs CI_TAGS parameters
2018-10-08 11:46:52 -04:00
Zoltan Varga c7c89f2155 [llvm] Fix the loaded llvm build. (#11014) 2018-10-08 11:06:05 -04:00
Jay Krell b7c18caf0c Significant disambiguation between host and target. (#10969) 2018-10-08 10:38:35 -04:00
Jay Krell 58925baab1 [icalls] Change gboolean to MonoBoolean. (#11017) 2018-10-08 10:37:37 -04:00
Calvin Buckley 0d29dfb9dd Mitigation for spawn FD closing taking forever with a big FD limit (#10761)
* Mitigation for spawn FD closing taking forever with a big FD limit

On systems with a large file descriptor limit, Mono takes a very
long time to spawn a new process; with informal testing on the AIX
CI builder, (with a POWER7) it took ~30 minutes. This is obviously
very undesirable, but hand our is forced - libraries the user might
be calling could be creating non-CLOEXEC files we're unaware of. As
such, we started from the FD limit and worked our way down until we
hit stdio. Using APIs such as posix_spawn aren't desirable as we do
some fiddling with the child before we exec; and even then, closing
FDs with posix_spawn relies on non-standard file actions like
Solaris' addclosefrom not present on many systems. (All of this is
unnecessary on Windows, of course.)

This presents an alternative way (currently only implemented on AIX
but with notes how for other platforms) to try to close the child's
loose FDs before exec; by trying to get the highest number FD in
use, then work our way down. In the event we can't, we simply fall
back to the old logic.

See #6555 for a discussion and the initial problem being mitigated.

* Use an another strategy of closing only known to be open handles

...on FreeBSD and AIX.

Use the kinfo_getfiles library call on FreeBSD and only close what's
safe to close. On AIX, use the third and fourth arguments to getprocs
to check what's open. However, the array to get all the handles takes
1 MB, so allocate it on the heap; like what kinfo_getfiles does. We
don't need to free these as the child will exec or exit, which blows
it all away.

The previous strategy from previous commit is still used and on AIX,
enhanced.

* Add Linux strategy to fork FD close

Tested on WSL, shows benefits with big FD ulimit.
2018-10-08 08:31:29 -04:00
monojenkins a756fa0f4a [csproj] Update project files 2018-10-08 10:03:28 +02:00
Marek Safar cd5135022b Bump linker 2018-10-08 10:03:28 +02:00
Marek Safar 539b148920 [linker] Adds more tests 2018-10-08 10:03:28 +02:00
monojenkins e64d8aaa72 Bump API snapshot submodule 2018-10-08 10:02:16 +02:00
Marek Safar 6ca0889b3c [build] Fixes Mono.Cecil boostrap dependency 2018-10-08 10:02:16 +02:00
Marek Safar 0b003f9fa4 Bump cecil 2018-10-08 10:02:16 +02:00
Marek Safar 6070870c2d [build] Update XI facades to build against reference assemblies (#10980)
Clean up facades to build remaining ones in parallel
2018-10-07 16:37:41 -04:00
Ludovic Henry d319f72d0d [sdks] Fix wasm order-only dependency on .PHONY target (#11009) 2018-10-05 20:26:37 -04:00
Jay Krell 31c90d2817 [icalls] Replace gboolean and mono_bool by MonoBoolean. (#10948)
Though one of these is an enum, use gint32.

The enums MonoResolveTokenError and MonoProtocolType are also used in icalls, but that is left alone.
2018-10-05 21:33:06 +02:00
Jay Krell bf11fbd8d3 ifdef HAVE_ARRAY_ELEM_INIT is not actually guarding code that uses C99 array (#10996)
initialization, but rather code that is portable to C89 and C++98.

The alternative is also ok, just costs typically a pointer and a relocation per array element,
things most people wouldn't notice but was presumably the point here.
2018-10-05 21:20:16 +02:00
Alexander Köplinger 67390ef6f4 Bump corefx 2018-10-05 18:24:10 +02:00
Alexis Christoforides b8ccd4071f [corlib] Fixup for System.IO.MemoryStream CoreFX import 2018-10-05 10:49:14 -04:00
Ludovic Henry 0c776d5a9e Bump to llvm/release_60/117a508c (#10983) 2018-10-05 09:49:35 -04:00
Rodrigo Kumpera b42a6a83ad Merge pull request #10962 from kumpera/another_vtable_bug
[runtime] Properly inflate cmods of (m)var.
2018-10-05 09:26:50 -04:00
monojenkins 7d18d3d660 [bcl] Update BCL Linked Size 2018-10-05 09:39:25 +02:00
Ankit Jain 2fbfadbd9c Bump msbuild to track xplat-master (#10339) 2018-10-05 09:13:22 +02:00
Alexander Kyte 7d56ecc42c [crash] Make stub for rethrow_preserve_exception on aarch64 2018-10-05 02:04:59 -04:00
Alexander Kyte 7ca584cdc3 [crash] Fixup field name typo on untested arches (#10990) 2018-10-05 00:04:19 +02:00
Rodrigo Kumpera 84b6e89300 [aot] Add clangxx option to --aot (#10779)
* [aot] Add clangxx option to --aot that removes the hardcoded clang++ in our aot compiler.

* [mini] Make --aot addictive.

* Update CI script for bitcode.
2018-10-04 17:18:28 -04:00
Alexander Kyte dcdbf3aafc [runtime] Fix malformed string selection in exceptions-ppc.c (#10987) 2018-10-04 22:14:02 +02:00
Maxim Lipnin ab0099d393 Bump corert 2018-10-04 21:54:05 +02:00
Maxim Lipnin 90cc835df8 Bump corert 2018-10-04 21:54:05 +02:00
Maxim Lipnin 3d24f0ba99 Extract case for verifying several object array parameters to separate test method. 2018-10-04 21:54:05 +02:00
Maxim Lipnin bc4d1a18ed Add unit tests to verify custom attribute ctor with object array as parameter 2018-10-04 21:54:05 +02:00
Alexander Köplinger 8b90cefc79 Fix corefx submodule ref 2018-10-04 19:42:35 +02:00
monojenkins 3568d3648e [csproj] Update project files 2018-10-04 19:01:44 +02:00
monojenkins 0627919d75 Bump API snapshot submodule 2018-10-04 19:01:44 +02:00
Alexis Christoforides 83ad1cb3d8 [corlib] Import System.IO.MemoryStream from CoreFX 2018-10-04 19:01:44 +02:00
Rodrigo Kumpera 577ab741b2 Make a bunch of classes optional to the runtime. (#10804)
The makes the following classes optional to the runtime:

System.Reflection.CustomAttributeData
System.Text.StringBuilder
System.Math
System.Console
System.Diagnostics.StackTrace

Those are all types that can be clearly made optional. There are a lot of other types
we could, but there are deeper dependencies in places as threadpool or marshal.

* [runtime] Kill mono_defaults.console_class.

* [runtime] Kill mono_defaults.asyncresult_class. Doesn't help much as it's still needed by the TP.

* [runtime] Remove mono_defaults.stack_trace_class.

* [runtime] Remove dead field.

* [runtime] Remove mono_defaults.math_class

* [runtime] Cleanup handleref resolution to use the access macros.

* [runtime] Remove mono_defaults.stribuilder_class.

* [runtime] Remove System.Reflection.CustomAttributeData

* [corlib] Update linker description.

* [runtime] Fix compilation of the iOS SDK.
2018-10-04 18:21:40 +02:00
Alexander Köplinger d9fabd0501 [tests] Remove magic which prepends MonoTests to NUnit test selection (#10977)
When passing FIXTURE or TESTNAME to "make run-test" we automatically
prepended `MonoTests.` to the value since all of our NUnit tests
start with that to save you from typing a few chars.

Now that we have xUnit tests as well this is confusing since it doesn't
happen there. Better to remove it for consistency.
2018-10-04 17:05:25 +02:00
Alexander Köplinger 42e347ee47 [corlib] Simplify confusing "SSPI" error message and align with corefx (#10976)
Right now if anything goes wrong in the security stack you get a message like this:

```
System.Security.Authentication.AuthenticationException: A call to SSPI failed, see inner exception. ---> Mono.Btls.MonoBtlsException: Ssl error:1000007d:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED
```

This is confusing since SSPI is a Windows-only thing and is not used on Mono.
We inherited this error message string from referencesource.

Change the string to something more generic which also aligns us with CoreFX:
https://github.com/dotnet/corefx/blob/a10890f4ffe0fadf090c922578ba0e606ebdd16c/src/System.Net.Security/src/Resources/Strings.resx#L210-L212
2018-10-04 17:04:58 +02:00
Alexander Köplinger b13145bb12 [ci] Always pass sha1 from Mac to Windows packaging build
Before we only did this for PR builds but it turns out it's needed for
normal master/branch builds too.

In situations where there are two Mac builds at roughly the same time
the downstream Windows builds would otherwise both refer to the same/latest
commit since they just checkout the latest ref on the branch.

Now we reset the Windows build to the sha1 which is passed to it.
2018-10-04 14:21:59 +02:00
Kenneth Pouncey a7f5952c69 [wasm][bindings] Add support for strongly typed marshalling of C# enums. (#10958)
* Add support for strongly typed marshalling of C# enums.

JavaScript does not have the concept of Enums like TypeScript.  Strings are used to represent enums.  This PR allows a strongly type contract between C# values and the string representations used by a lot of the JavaScript API's.

Example:

DOM InputElement type ->  https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#attr-type#Form_<input>_types

    The InputElement types are represented by strings.  button, checkbox, color, date, datetime-local etc....

     These string can be represented and marshalled back and forth by defining an enum as shown below with an `Export` data contract attribute.

```
    public enum InputElementType
    {
        [Export(EnumValue = ConvertEnum.ToLower)]
        Button,
        [Export(EnumValue = ConvertEnum.ToLower)]
        CheckBox,
        [Export(EnumValue = ConvertEnum.ToLower)]
        Color,
        [Export(EnumValue = ConvertEnum.ToLower)]
        Date,
        [Export("datetime-local")]
        DateTimeLocal,
   }

```

The enum conversion allows controlling the marshalling:

- Default - Marshals the enum name as is
- ToLower - Marshals the enum name to lower case string
- ToUpper - Marshals the enum name to upper case string
- Numeric - Marshals the enum numeric values.

Marshalling from C# to JavaScript using the SDK Bindings should be made as easy and pain free as possible.

Marshalling the string values from JavaScript to C# will need a little help.  The SDK Bindings Runtime provides a method to transport the string value to a strongly typed enum.

```
   WebAssembly.Runtime.EnumFromExportContract(typeof(InputElementType), inputElementType);
```

* Add marshalling of C# Enums to method calls.

* Add tests to bindings-test harness for testing marshalling of C# enum values.

* Modify test for marshalling enum value without Export contract.
2018-10-04 11:44:05 +02:00
monojenkins 385b8a2783 Merge pull request #10749 from lewurm/interp-fixes-for-native-type
[interp] fixes for native types

please look at single commits.

------------------------

[interp] fix op_implicit/op_explicit conversions for native types
    
Conversion operators have been mostly broken in the interpreter, for example conversion from nint to float didn't work. While some conversions are easy to intrinsify (like nint -> I8), there are harder cases like nint -> decimal. The JIT actually falls back to the managed implementation, so let's do this in the interpreter as well.
    
However the managed implementation expects a pointer to the value type, i.e. the container type System.nfloat instead of float/double primitives. In such cases the value is going to be stored in a local and then the address of its storage is pushed on the stack before invoking the managed implementation of the conversion.
    
Added test cases for scenarios observed in Xamarin.iOS.

-----------------------

[interp] support ntype.CompareTo ()

-----------------------

[interp] support ntype.Equals ()

-----------------------

 [interp] support nfloat.*Infinity

-----------------------

[interp] support ntype.ToString ()

-----------------------

The conversion issue creeped everywhere in Xamarin.iOS since it heavily relies on nint/nuint/nfloat. With this PR we are getting close to a green monotouch tests 😁 
<img width="874" alt="screen shot 2018-09-21 at 23 24 36" src="https://user-images.githubusercontent.com/75403/45907566-b457eb80-bdf8-11e8-9cc7-b8cf311dd269.png">

needs backporting to 2018-06 and 2018-08
2018-10-04 11:25:35 +02:00
HebaruSan 0c2543cecf Fix default colors for DataGridView (#10944)
* Fix default colors for DataGridView

* Update tests
2018-10-04 10:54:56 +02:00
Egor Bogatov 895bf51b0c Use Mono.Android as a reference for netstandard facade (#10849)
* bump external/binary-reference-assemblies

* use Mono.Android for netstandard

* use API_BIN_REFS

* move ifeq monodroid upper

* use Mono.Android in System.Drawing.Primitives instead of ns

* fix typo

* Add Mono.Android back to ns as API_BIN_REFS

* Bump API snapshot submodule

* [csproj] Update project files
2018-10-04 10:39:21 +02:00
monojenkins 8d8587f4bc [bcl] Update BCL Linked Size 2018-10-04 09:32:05 +02:00
Alexander Kyte 19fbbda478 Merge pull request #10468 from alexanderkyte/fix_stacktrace
[runtime] Fix stored exception throws
2018-10-04 03:31:30 -04:00
Alexander Kyte e46fa20466 [crash] Fix trampoline rethrows to set caught_in_unmanaged 2018-10-03 17:11:04 -04:00
Rodrigo Kumpera e32462ed7d [mini] Add regression test for #10834. 2018-10-03 13:35:59 -04:00
Rodrigo Kumpera ccaf6a86dc [metadata] Make type dup used by inflate_generic_type be cmod aware. Fixes #10834
We didn't include cmods when inflating var/mvar cuz we'd mono_metadata_type_dup' the inflated type
and not the (m)var MonoType.

The solution is to add a variant of mono_metadata_type_dup that takes the source of cmods to use.
2018-10-03 13:25:29 -04:00
Rodrigo Kumpera 517be3d557 [metadata] Improve --print-vtable when dealing with broken types or abstract methods. 2018-10-03 13:23:28 -04:00
Bernhard Urban 7c61df97a8 [interp] introduce float R4 stack type 2018-10-03 16:57:32 +02:00
Bernhard Urban bdae608a88 [interp] support ntype.ToString () 2018-10-03 16:56:59 +02:00
Bernhard Urban 5f41720a4d [interp] support nfloat.*Infinity 2018-10-03 16:56:58 +02:00
Bernhard Urban 4cccb0dda9 [interp] support ntype.Equals () 2018-10-03 16:56:58 +02:00
Bernhard Urban 6a759dbcd4 [interp] support ntype.CompareTo () 2018-10-03 16:56:58 +02:00
Bernhard Urban bffb1163df [interp] fix op_implicit/op_explicit conversions for native types
Conversion operators have been mostly broken in the interpreter, for
example conversion from nint to float didn't work. While some
conversions are easy to intrinsify (like nint -> I8), there are harder
cases like nint -> decimal. The JIT actually falls back to the managed
implementation, so let's do this in the interpreter as well.

However the managed implementation expects a pointer to the value type,
i.e. the container type System.nfloat instead of float/double primitives.
In such cases the value is going to be stored in a local and then the
address of its storage is pushed on the stack before invoking the
managed implementation of the conversion.

Added test cases for scenarios observed in Xamarin.iOS.
2018-10-03 16:56:58 +02:00
Vlad Brezae ffb4f021bf [interp] Avoid emitting some unnecessary opcodes (#10894) 2018-10-03 10:50:27 -04:00
Rolf Bjarne Kvinge 5501111e8a [sdks/ios] Build libMonoPosixHelper for device architectures, so that zlib-helper.o is created. (#10921)
xamarin-macios currently builds zlib-helper.o using mono's source code.

It would be preferrable to use a version built by mono, and since
zlib-helper.o is a byproduct of building libMonoPosixHelper, we need to build
libMonoPosixHelper (we already build it for simulator architectures), even
though we don't need/use libMonoPosixHelper itself.
2018-10-03 10:46:47 -04:00
monojenkins 0eea315727 Merge pull request #10672 from jaykrell/fault-addr-wasm.3
Get fault_addr in debugger stacks.

This time w/o breaking WebAssembly and w/ working on Mac.
2018-10-03 15:35:52 +02:00
Alexander Köplinger 6ad08fff9e [bcl] Put xunit tests in mcs/class/lib/PROFILE/tests too (#10928)
So they are next to their NUnit counterparts.

Move xunit remote executor app to tests dir too and compile it when
compiling the test assembly instead of doing it before running the test.

We need to use an absolute path for the xunit remote executor and it
needs to be in Windows format on Windows since we pass it as an env var
to the xunit tests.
2018-10-03 12:16:19 +02:00
Aleksey Kliger fbf43a4266 [linker] Bump to mono/linker@e6760e6f
Includes mono/linker@4dde7af5c8
to fix permissions of files created by OutputStep.

Fixes https://github.com/mono/mono/issues/10743
2018-10-03 10:27:51 +02:00
Maxim Lipnin 4905422666 [Reflection] Fix issue with finding types in module using an asterisk as filter criteria 2018-10-03 08:45:49 +02:00
Paul Hebble 7d52f0fb7e Paint ToolStrip background with ToolStrip.BackColor 2018-10-03 08:42:40 +02:00
monojenkins 82e573122a [csproj] Update project files 2018-10-03 08:38:19 +02:00
monojenkins dc42f1562f Bump API snapshot submodule 2018-10-03 08:38:19 +02:00
Marek Safar 6bcccccb82 [corlib] Control SRE using its own define 2018-10-03 08:38:19 +02:00
Marek Safar 4c20744e2a [corlib] Updates PNSE version of DynamicMethod to have matching APIs 2018-10-03 08:38:19 +02:00
Johan Lorensson c82567b6c9 Merge pull request #10646 from lateralusX/lateralusX/issue10508-diag
Fix scheduling problem related to thread-suspend-suspended and thread-suspend-selfsuspended.
2018-10-03 08:31:53 +02:00
monojenkins 8f9d781f8c [bcl] Update BCL Linked Size 2018-10-03 08:25:25 +02:00
Ludovic Henry def2d9e550 [sdks] Use make --output-sync=recurse on CI (#10939)
When building the SDKs on CI, the output is very scrambled. There are simultaneously outputs from making multiple runtimes, uncompressing some tar archives, cloning some repos, building various BCL profiles, etc. This makes it quite hard to easily understand what's going wrong when the build fails.

By using `--output-sync=recurse`, we make sure that even if many targets are executed in parallel, the output is still as if it was executed sequentially.
2018-10-02 23:42:05 -04:00
Ludovic Henry bc6d91e992 Update azure-pipelines.yml 2018-10-02 23:07:03 -04:00
Ludovic Henry cd3974f221 Update azure-pipelines.yml 2018-10-02 22:56:10 -04:00
Ludovic Henry d216896999 Update azure-pipelines.yml 2018-10-02 22:55:40 -04:00
Ludovic Henry 17ac875028 Update azure-pipelines.yml 2018-10-02 22:52:32 -04:00
Ludovic Henry 9072200e08 Update azure-pipelines.yml 2018-10-02 22:45:13 -04:00
Ludovic Henry f7c77c35f0 Update azure-pipelines.yml 2018-10-02 22:38:18 -04:00
miguel f824e73d2f [AzureDevOps] Move to Ubuntu 2018-10-02 22:36:53 -04:00
miguel 4f27bfe066 Update 2018-10-02 22:36:03 -04:00
Ludovic Henry 9e570bc053 Update azure-pipelines.yml 2018-10-02 22:34:16 -04:00
Ludovic Henry ee90fb094e Update azure-pipelines.yml 2018-10-02 22:25:26 -04:00
Miguel de Icaza 708af8c15e Set up CI with Azure Pipelines
Barebones script for the dev.azure.com/mono-project pipeline setup.
2018-10-02 22:20:59 -04:00
Aleksey Kliger (λgeek) c0d72ca8cb [w32handle] Add coop state transitions in mono_w32handle_lock_handles (#10910)
If another thread locked at least one of the other handles, and there is a
cooperative GC STW happening, this function will loop forever.

Add GC Safe transitions around the call to sleep to give this thread a chance
to suspend.

Fixes https://github.com/mono/mono/issues/10863
2018-10-03 00:03:49 +02:00
Vlad Brezae 84ec74a9f0 [runtime] Fix undefined pthread_main_np (#10930)
It is exported only when _DARWIN_C_SOURCE is defined.
2018-10-03 00:00:59 +02:00
Ludovic Henry 6dcc779e17 [sdks] Build llvm-llvm{,win}{32.64} on Linux on CI as well (#10937) 2018-10-02 16:53:02 -04:00
Martin Baulig f0921fd850 Use passwordless import in the X509Certificate(byte[]) constructor.
The `X509Certificate(byte[])` constructor should call `CertificateProvider.Import(byte[])`
to use the native apple implementation if possible.

Add temporary hack to `X509Certificate2(byte[])` to ensure that we always get an
`X509Certificate2Impl`.
2018-10-02 17:21:58 +02:00
Marek Safar 2b6eae3912 [linker] Reenable accidentally disabled test 2018-10-02 16:30:49 +02:00
Rodrigo Kumpera f399693f63 [metadata] Improve --print-vtable. 2018-10-02 10:24:08 -04:00
Rodrigo Kumpera 28dbdb4217 [metadata] Extract print_vtable_layout_result. 2018-10-02 10:24:03 -04:00
Rodrigo Kumpera 0919c6fd90 [metadata] print just the assembly name when dumping the vtable. 2018-10-02 10:23:59 -04:00
Ludovic Henry a67333b58f [sdks] Ensure LLVM is cloned before trying to download (#10913) 2018-10-02 08:53:24 -04:00
Maxim Lipnin f04b43a44d [Reflection] Fix the issue with ToString method in MonoCMethod type (#10901)
Fixes https://github.com/mono/mono/issues/10838.

The new behavior is similar to coreclr's one: https://github.com/dotnet/coreclr/blob/af4ec7c89d0192ad14392da04e8c097da8ec9e48/src/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs#L145
2018-10-02 14:29:49 +02:00
Alexander Köplinger e9de4af4d4 [ci] Remove workaround for libtiff issue
We recently updated libtiff, let's see if this is still required
2018-10-02 13:31:09 +02:00
Jay Krell b07aab167f Restore typecheck to corlib version check, so that mixing
old integer with new string errors w/o crash.
2018-10-02 11:19:27 +02:00
Alexander Köplinger 634e726bdf [packaging] Remove installation of openssl via brew on macOS (#10874)
We're now using an msbuild version which uses .NET Core 2.x which no longer needs openssl.
2018-10-02 11:10:23 +02:00
Alexander Köplinger 6145ad25fc Merge pull request #10912 from akoeplinger/test-precompile
[mcs] Fix test compilation to use common target and refactor mono-symbolicate test building
2018-10-02 11:09:35 +02:00
monojenkins d31c926a74 [bcl] Update BCL Linked Size 2018-10-02 10:45:43 +02:00
Maxim Lipnin c22ac963e9 [System.Reflection] CoreFX import for TypeInfo type (#10871)
* [System.Reflection] CoreFX import for TypeInfo type

* Bump corefx

* Bump corefx

* Bump API snapshot submodule

* [csproj] Update project files
2018-10-02 10:35:43 +02:00
Kenneth Pouncey d02ecf72b6 [wasm] Update sample.cs usage and docs (#10847)
* Fix problem with HttpClientHandler not returning the response status text if available when there is an http error.

resolves: https://github.com/mono/mono/issues/10842

* Extend C# sample to include:

- Calling JavaScript functions from C#
- Calling C# functions from JavaScript.
- Referencing JavaScript objects
- Getting and Setting JavaScrip object properties.
- Invoking JavaScript object functions.
- Setting up the default HttpClientHandler
- Instantiating a default WasmHttpMessageHandler.
- Setting up HttpClient calls
- Parsing and testing the correct results returned from the HtppClient.
- Obtaining a byte array and string array from response.
- Obtaining a reference to a global script function defined in the .html file and calling it.
- Working with DOM objects using the SDK's WebAssembly.Bindings.dll

resolves: https://github.com/mono/mono/issues/7548

* Update sample usage docs
2018-10-02 10:33:04 +02:00
Jay Krell f246511f38 [cxx] Do not define C++ keywords: bool, inline, final, it can break things. (#10883)
* [cxx] Do not define C++ keywords: bool, inline, final, it can break things.

https://jenkins.mono-project.com/job/d/421/parsed_console/log.html

  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\xkeycheck.h(250): fatal error C1189: #error:  The C++ Standard Library forbids macroizing keywords. Enable warning C4005 to find the forbidden macro. [d:\j\workspace\d\msvc\libmonoruntime.vcxproj]

* PR: Leave profiler defining C++ keywords (define bool char).
* PR: Restore libgc. (mainline removed the code in 2011).
2018-10-01 22:40:15 -07:00
Alexander Köplinger f782e36a80 [mcs] Fix test compilation to use common target
Add proper dependencies to the test support files where they were missing.
Compile test files using the standard "make test" target.
2018-10-02 02:08:07 +02:00
Alexander Köplinger a7d4c2a8b9 [mono-symbolicate] Refactor so test assets can be precompiled 2018-10-02 01:58:59 +02:00
Ludovic Henry 0aebe90cac [sdks] Create archive targets for pre-building on CI (#10882)
* [sdks] Remove redundant --enable-cxx

* [sdks] Shorten `-m32`/`-m64` parameters detection for runtimes

* [sdks] Build BCL profiles without configure flags

* [sdks] Add BclTemplate to build BCL profiles

This is to avoid building all the profiles in a single `sdks/out/bcl` directory which will be shared between android, ios and wasm.

* [sdks] Create archive targets for pre-building on CI

* [sdks] Use archive-{android,ios,wasm} on CI

* [sdks] Run archive-llvm-llvm{,win}{32,64} on CI
2018-10-01 17:43:46 -04:00
Vlad Brezae 9182bcccc3 [runtime] Disable stack guard for main thread on osx (#10899)
On macOS Mojave, it seems that changing the mapping of stack pages for main thread can lead to corruption bugs.

https://github.com/mono/mono/issues/10802
2018-10-01 16:37:16 -04:00
Alexander Kyte 52a9b776ea [runtime] Fix off by one with stacktrace rethrow 2018-10-01 14:23:48 -04:00
Jo Shields 6f8ca69401 Merge pull request #10898 from directhex/master
Bump version to 5.21.0
2018-10-01 12:05:05 -04:00
Jo Shields bb8a0ce8e7 Bump version to 5.21.0 2018-10-01 10:21:34 -04:00
lateralusX 51affb26bc Fix scheduling problem related to thread-suspend-suspended and thread-suspend-selfsuspended.
thread-suspend-suspended and thread-suspend-selfsuspended tests has showed long
execution times on low core Windows machines running wow64. It looks like an OS
related issue where ResumeThread Win32 API takes a lot longer time to complete
when running a test scenario like thread-suspend-suspended and this additional
time adds up over many iterations pushing it over to timeout. NOTE, the same behavior
has been identified running on .NET framework, so it's not a mono specific issue and
only reproduce under wow64 on low core machines (probably when one core is busy
just leaving us with one core for most of the test).

Since the purpose of the test is to run GC when t1 is suspended, doing this more
deterministic will fix the ResumeThread issue under wow64 on low core count as
well as making the tests more deterministic, always having t1 in a suspended state
when running GC (that will test the suspend suspended scenario).

Full investigation can be found in, https://github.com/mono/mono/issues/10508.
2018-10-01 16:15:10 +02:00
Alexander Kyte 2e15fa255f [runtime] Add test for icall wrapper rethrowing and exception length 2018-09-30 23:26:10 -04:00
Alexander Kyte cd1a48ef26 [runtime] Fix stored exception throws
On cooperative suspend, the wrapper frames capture the exception
in a MonoError, which then must be thrown. The problem with treating
it as a CIL THROW opcode is that every time you THROW, you completely
reset the stacktrace's collectin of saved frames.

The RETHROW opcode will force the JIT to rely on an in-flight exception,
that in our case has been taken our of the in-flight context.

By relying on the new MONO_RETHROW, we will take an explicit exception
and put it back in-flight without clearing the stored stacktrace.
2018-09-30 23:26:09 -04:00
Alexander Kyte 2cee721190 [runtime] Add mono_rethrow opcode 2018-09-30 23:26:09 -04:00
Jay Krell c76bacba17 Combine MONO_ATTRIBUTE_NO_OPTIMIZE and MONO_NO_OPTIMIZATION. 2018-09-18 10:27:33 -07:00
Jay Krell cb4d25dec2 Move MONO_SIG_HANDLER_DEBUG from mono/utils/mono-signal-handler.h to
mono/mini/mini-runtime.c so it can use the correct ifdefs
which should fix WebAssembly compilation and let it work on
Mac and Win32 also. This means we no longer need HOST_LINUX in configure.ac either.

Note that for Win32 we don't have the same sort of execution
of a debugger for this to help, but you can see it works
if you run in a debugger and break on mono_sigsegv_signal_handler_debug.
2018-09-18 10:24:18 -07:00
Jay Krell 7c191c1370 Get fault_addr in debugger stacks. 2018-09-18 09:35:35 -07:00
Jay Krell b690f2d3d1 Move signal handler stuff out of ifdef except MONO_SIG_HANDLER_INFO_TYPE since it was all the same. 2018-09-18 09:35:35 -07:00
Jay Krell 86ee99f6b3 Use MONO_SIG_HANDLER_INFO_TYPE in two places so that Win32 and Posix are otherwise identical. 2018-09-18 09:35:35 -07:00
Jay Krell 2aaeae2354 Provide MONO_ATTRIBUTE_NO_OPTIMIZE in mono-compiler.h. 2018-09-18 09:35:35 -07:00
Jonathan Chambers 9de58a07c0 Don't try to access metadata for dynamic method added to non-dynamic image. Fixes issue #10201. 2018-08-20 16:51:18 -04:00
6411 changed files with 628488 additions and 287960 deletions

No files matched your search

+7 -4
View File
@@ -1,3 +1,6 @@
# diff settings
*.cs diff=csharp
# ensure LF endings on all checkouts
configure.ac crlf=input
config.rpath crlf=input
@@ -13,11 +16,11 @@ mkinstalldirs crlf=input
*.h crlf
*.cs crlf
*.il crlf
*.sln crlf
*.*proj* crlf
# don't do anything to line-endings. Let CRLFs go into the repo, and CRLF on checkout
*.bat -crlf
*.sln -crlf
*.*proj* -crlf
# don't do anything to line-endings. Let CRLFs/LFs go into the repo, and CRLF/LFs on checkout
*.bat -crlf
*.xml -crlf
# CRLF Handling
+161
View File
@@ -0,0 +1,161 @@
# Mono Code Owners File
#
# GitHub uses this file to determine who to assign for reviews
# on pull requests. Please keep this file alphabetically sorted.
#
# References:
#
# https://github.com/blog/2392-introducing-code-owners
# https://help.github.com/articles/about-codeowners
# These owners will be the default owners for everything in the repo.
* @marek-safar
# Order is important. The last matching pattern has the most precedence.
/acceptance-tests @akoeplinger @kg
/acceptance-tests/profiler-stress* @BrzVlad @akoeplinger
/data @directhex @akoeplinger
/data/gdb @lewurm @vargaz
/data/lldb @lewurm @vargaz
/docs @marek-safar @akoeplinger
/docs/riscv.md @alexrp @lewurm
/docs/sources/mono-api-profiler.html @BrzVlad
/external @akoeplinger @marek-safar
/external/api-snapshot @marek-safar @akoeplinger
/external/binary-reference-assemblies @marek-safar @akoeplinger
/external/bockbuild @akoeplinger @alexischr
/external/boringssl @baulig
/external/cecil @marek-safar @akoeplinger
/external/corefx @akoeplinger @marek-safar @egorbo @steveisok
/external/corert @akoeplinger @marek-safar @egorbo @steveisok
/external/linker @marek-safar
/external/llvm-project @SamMonoRT @vargaz @imhameed
/external/nuget-buildtasks @radical @akoeplinger
/external/roslyn-binaries @kg @marek-safar @akoeplinger @lewing
/libgc @BrzVlad @vargaz @naricc
/llvm @vargaz @SamMonoRT @imhameed
/man @marek-safar @miguel
/man/*prof* @BrzVlad
/mcs @marek-safar @akoeplinger @egorbo
/mcs/build @marek-safar @akoeplinger
/mcs/class @steveisok @akoeplinger
/mcs/class/corlib/System.Reflection*/ @vargaz @lambdageek
/mcs/class/corlib/System.Security.Cryptography.X509Certificates @baulig @steveisok
/mcs/class/Mono.Btls.Interface @baulig @steveisok
/mcs/class/Mono.Data.Tds @egorbo
/mcs/class/Mono.Debugger.Soft @vargaz @thaystg
/mcs/class/Mono.Options @jonpryor @marek-safar
/mcs/class/Mono.Profiler.Log @lambdageek
/mcs/class/Mono.Security/Mono.Security/Interface @baulig @steveisok
/mcs/class/System/Mono.AppleTls @baulig @rolf
/mcs/class/System/Mono.Btls @baulig @marek-safar
/mcs/class/System/Mono.Net.Security @baulig @steveisok
/mcs/class/System/Mono.Security.Interface @baulig @steveisok
/mcs/class/System/System.Security.Cryptography.X509Certificates @baulig @steveisok
/mcs/class/System.Data* @egorbo @steveisok
/mcs/errors @marek-safar @lewurm
/mcs/ilasm @marek-safar @lewurm
/mcs/jay @marek-safar @lewurm
/mcs/mcs @marek-safar @lewurm
/mcs/tests @marek-safar @lewurm
/mcs/tools @marek-safar @akoeplinger @steveisok
/mcs/tools/gensources @kg @akoeplinger
/mcs/tools/resx2sr @baulig
/mcs/tools/upload-to-sentry @directhex @akoeplinger
/mono/arch @vargaz @lewurm
/mono/btls @baulig @marek-safar
/mono/dis @lambdageek @vargaz
/mono/eglib @vargaz @lambdageek
/mono/benchmark @SamMonoRT @lewurm
/mono/metadata @vargaz @lambdageek @thaystg
/mono/metadata/*profiler* @lambdageek
/mono/metadata/handle* @lambdageek @vargaz
/mono/metadata/monitor* @brzvlad @vargaz
/mono/metadata/sgen* @brzvlad @vargaz @naricc
/mono/metadata/thread* @lateralusX @lambdageek
/mono/metadata/w32* @lateralusX @lambdageek
/mono/metadata/*-win* @lateralusX @lambdageek
/mono/metadata/appdomain* @vargaz @lambdageek @CoffeeFlux
/mono/metadata/assembly* @vargaz @lambdageek @CoffeeFlux
/mono/metadata/domain* @vargaz @lambdageek @CoffeeFlux
/mono/metadata/loader* @vargaz @lambdageek @CoffeeFlux
/mono/metadata/native-library* @vargaz @lambdageek @CoffeeFlux
/mono/metadata/*-unix* @lambdageek @CoffeeFlux
/mono/mini @vargaz @lewurm @lambdageek @SamMonoRT
/mono/mini/*cfgdump* @lewurm @vargaz
/mono/mini/*exceptions* @lewurm @vargaz @BrzVlad
/mono/mini/*ppc* @lewurm @vargaz
/mono/mini/*riscv* @alexrp @lewurm
/mono/mini/*type-check* @lewurm @lambdageek
/mono/mini/*llvm* @vargaz @imhameed
/mono/mini/interp/* @lewurm @BrzVlad
/mono/mini/*profiler* @BrzVlad @lambdageek
/mono/mini/debugger-agent.c @vargaz @thaystg @DavidKarlas @lambdageek
/mono/native @baulig @egorbo @alexischr @marek-safar
/mono/profiler @BrzVlad @lambdageek
/mono/sgen @BrzVlad @lambdageek
/mono/utils @vargaz @lewurm @lambdageek
/mono/utils/atomic* @lewurm @vargaz
/mono/utils/mono-hwcap* @lewurm @vargaz
/mono/utils/mono-mem* @lewurm @vargaz
/mono/utils/mono-merp* @alexischr @lambdageek
/mono/utils/mono-state* @alexischr @lambdageek
/mono/utils/mono-threads* @lambdageek @vargaz
/mono/utils/*-win* @lateralusX @lambdageek
/msvc @lateralusX @kg @akoeplinger
/msvc/scripts @akoeplinger @kg
/netcore @marek-safar @akoeplinger @egorbo @vargaz @steveisok
/packaging @alexischr @akoeplinger @directhex
/packaging/MacSDK/msbuild.py @radical @akoeplinger
/runtime @akoeplinger @marek-safar
/samples @lambdageek @lewurm
/samples/profiler @BrzVlad @lambdageek
/samples/size @alexrp @lambdageek
/scripts @akoeplinger @directhex
/scripts/ci @akoeplinger @directhex
/sdks @marek-safar @lewurm @vargaz @lambdageek
/sdks/builds/android* @alexischr @jonpryor
/sdks/builds/mxe* @alexischr @jonpryor
/sdks/builds/ios* @vargaz @rolfbjarne
/sdks/builds/wasm* @vargaz @kjpou1 @lewing
/sdks/wasm @vargaz @kjpou1 @kg @lewing
/sdks/ios @vargaz @rolfbjarne
/sdks/android @alexischr @jonpryor
/support @lambdageek @vargaz
/tools @lambdageek @vargaz
/tools/locale-builder @marek-safar @egorbo
/tools/nuget-hash-extractor @marek-safar @radical @akoeplinger
/tools/offsets-tool @lewurm @rolfbjarne
/tools/pedump @lambdageek @lewurm
/tools/sgen @brzvlad @vargaz @naricc
+18 -1
View File
@@ -24,7 +24,6 @@
*.tlh
*.bak
*.ilk
*.log
*.lib
*.sbr
*.sdf
@@ -89,6 +88,7 @@ stamp-h.in
*~
*.swp
*.o
*.dylib
.deps
.libs
@@ -128,7 +128,24 @@ docs/perlmod*
compile
mono.h
mono-*.tar.*
mono_crash*
tmpinst-dir.stamp
msvc/scripts/inputs/
extensions-config.h
*.dylib.dSYM
*.mlpd
llvm/build/
llvm/usr/
sdks/builds/llvm-*/
sdks/builds/android-*/
mcs/build/compiler-server.log
tools/offsets-tool-py/offtool/
tools/offsets-tool-py/clang/__pycache__
##############################################################################
# Arcade output directories
##############################################################################
.packages
artifacts
.dotnet
+13
View File
@@ -58,3 +58,16 @@
[submodule "external/api-snapshot"]
path = external/api-snapshot
url = git://github.com/mono/api-snapshot.git
[submodule "external/helix-binaries"]
path = external/helix-binaries
url = git://github.com/mono/helix-binaries.git
[submodule "external/illinker-test-assets"]
path = external/illinker-test-assets
url = git://github.com/mono/illinker-test-assets.git
[submodule "external/llvm-project"]
path = external/llvm-project
url = git://github.com/dotnet/llvm-project.git
branch = release/6.x
[submodule "external/bdwgc"]
path = external/bdwgc
url = git://github.com/Unity-Technologies/bdwgc.git
+7 -8
View File
@@ -3,11 +3,8 @@
{
"name": "Mac",
"includePath": [
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1",
"${default}",
"/usr/local/include",
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0/include",
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include",
"/usr/include",
"${workspaceRoot}",
"${workspaceRoot}/mono",
"${workspaceRoot}/mono/eglib",
@@ -17,11 +14,8 @@
"intelliSenseMode": "clang-x64",
"browse": {
"path": [
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1",
"${default}",
"/usr/local/include",
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0/include",
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include",
"/usr/include",
"${workspaceRoot}",
"${workspaceRoot}/mono",
"${workspaceRoot}/mono/eglib",
@@ -31,6 +25,7 @@
"databaseFilename": ""
},
"macFrameworkPath": [
"${default}",
"/System/Library/Frameworks",
"/Library/Frameworks"
]
@@ -38,6 +33,7 @@
{
"name": "Linux",
"includePath": [
"${default}",
"/usr/include",
"/usr/local/include",
"${workspaceRoot}",
@@ -49,6 +45,7 @@
"intelliSenseMode": "clang-x64",
"browse": {
"path": [
"${default}",
"/usr/include",
"/usr/local/include",
"${workspaceRoot}",
@@ -63,6 +60,7 @@
{
"name": "Win32",
"includePath": [
"${default}",
"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/include",
"${workspaceRoot}",
"${workspaceRoot}/mono",
@@ -76,6 +74,7 @@
"intelliSenseMode": "msvc-x64",
"browse": {
"path": [
"${default}",
"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/include/*",
"${workspaceRoot}",
"${workspaceRoot}/mono",
-136
View File
@@ -1,136 +0,0 @@
# Mono Code Owners File
#
# GitHub uses this file to determine who to assign for reviews
# on pull requests. Please keep this file alphabetically sorted.
#
# References:
#
# https://github.com/blog/2392-introducing-code-owners
# https://help.github.com/articles/about-codeowners
# These owners will be the default owners for everything in the repo.
* @luhenry @marek-safar
# Order is important. The last matching pattern has the most precedence.
/acceptance-tests @akoeplinger
/acceptance-tests/profiler-stress* @alexrp
/data @marek-safar @akoeplinger @luhenry
/data/gdb @vargaz
/data/lldb @lewurm @vargaz
/docs @luhenry @marek-safar
/docs/sources/mono-api-profiler.html @alexrp
/external @marek-safar @luhenry
/external/binary-reference-assemblies @marek-safar @akoeplinger
/external/bockbuild @akoeplinger @alexischr
/external/boringssl @baulig
/external/nuget-buildtasks @radical @akoeplinger
/libgc @BrzVlad @vargaz @luhenry
/llvm @vargaz @luhenry
/man @marek-safar @miguel @luhenry
/man/*prof* @alexrp
/mcs @marek-safar @luhenry
/mcs/build @marek-safar @akoeplinger
/mcs/class @marek-safar @akoeplinger
/mcs/class/corlib/System.Reflection*/ @vargaz @lambdageek
/mcs/class/Mono.Btls.Interface @baulig
/mcs/class/Mono.Data.Tds @egorbo
/mcs/class/Mono.Debugger.Soft @vargaz
/mcs/class/Mono.Options @jonpryor
/mcs/class/Mono.Profiler.Log @alexrp
/mcs/class/Mono.Security/Mono.Security/Interface @baulig
/mcs/class/System/Mono.AppleTls @baulig
/mcs/class/System/Mono.Btls @baulig
/mcs/class/System/Mono.Net.Security @baulig
/mcs/class/System/Mono.Security.Interface @baulig
/mcs/class/System.Data* @egorbo
/mcs/errors @marek-safar
/mcs/ilasm @marek-safar
/mcs/jay @marek-safar
/mcs/mcs @marek-safar @lewurm
/mcs/tests @marek-safar
/mcs/tools @marek-safar @akoeplinger
/mono @luhenry
/mono/btls @baulig
/mono/dis @lambdageek @vargaz
/mono/eglib @kumpera @vargaz @luhenry
/mono/metadata @vargaz @kumpera
/mono/metadata/*verify* @kumpera
/mono/metadata/*profiler* @alexrp
/mono/metadata/monitor* @brzvlad
/mono/metadata/sgen* @brzvlad
/mono/metadata/threads* @luhenry @kumpera
/mono/metadata/threadpool* @luhenry
/mono/metadata/w32* @luhenry
/mono/metadata/*-win* @lateralusX @luhenry
/mono/mini @vargaz @kumpera
/mono/mini/*cfgdump* @lewurm
/mono/mini/*exceptions* @lewurm
/mono/mini/*ppc* @lewurm
/mono/mini/*type-check* @lewurm
/mono/mini/interp/* @lewurm @BrzVlad
/mono/mini/*profiler* @alexrp
/mono/mini/debugger-agent.c @DavidKarlas
/mono/profiler @alexrp @kumpera
/mono/sgen @BrzVlad @kumpera
/mono/utils @kumpera @vargaz
/mono/utils/atomic* @alexrp
/mono/utils/mono-hwcap* @alexrp
/mono/utils/mono-mem* @alexrp
/mono/utils/mono-threads* @luhenry @kumpera
/mono/utils/*-win* @lateralusX @kumpera
/msvc @lateralusX @luhenry
/msvc/*profiler* @alexrp
/msvc/scripts @akoeplinger @kg
/packaging/ @alexischr @akoeplinger @luhenry @directhex
/packaging/MacSDK/msbuild.py @radical @akoeplinger
/runtime @akoeplinger @marek-safar @luhenry
/samples @luhenry
/samples/profiler @alexrp
/samples/size @alexrp
/scripts @akoeplinger @luhenry
/scripts/ci @akoeplinger @alexischr
/scripts/ci/run-test-profiler-stress-tests.sh @alexrp
/sdks @marek-safar @luhenry
/sdks/builds/android* @luhenry @jonpryor
/sdks/builds/mxe* @luhenry @jonpryor
/sdks/builds/ios* @vargaz @rolfbjarne
/sdks/wasm @kumpera @lrz
/sdks/ios @vargaz @rolfbjarne
/sdks/android @luhenry @jonpryor
/support @luhenry @vargaz
/tools @kumpera @luhenry
/tools/checker @tritao
/tools/crash-bisector @kumpera
/tools/locale-builder @marek-safar
/tools/monograph @vargaz
/tools/nuget-hash-extractor @marek-safar
/tools/offsets-tool @lewurm @rolfbjarne
/tools/pedump @kumpera @lambdageek
/tools/sgen @brzvlad
-2
View File
@@ -28,8 +28,6 @@ Mono itself, and does not end up in the redistributable part of Mono:
* mcs/jay: 4-clause BSD licensed
* mcs/nunit24: MS-PL
* mcs/class/I18N/mklist.sh, tools/cvt.sh: GNU GPLv2
Runtime Code
+40 -9
View File
@@ -11,15 +11,29 @@ else
tools_dir = tools
endif
SUBDIRS = mk po $(libgc_dir) llvm mono $(ikvm_native_dir) support data runtime scripts man samples $(tools_dir) msvc $(docs_dir) acceptance-tests
if ENABLE_MSVC
build_with_msvc = msvc
build_without_msvc =
else
build_with_msvc =
build_without_msvc = msvc
endif
if ENABLE_NETCORE
update_submodules =
SUBDIRS = mk llvm mono runtime netcore
else
update_submodules = update_submodules
SUBDIRS = $(build_with_msvc) mk po $(libgc_dir) llvm mono $(ikvm_native_dir) support data runtime scripts man samples $(tools_dir) $(build_without_msvc) $(docs_dir) acceptance-tests
endif
# Keep in sync with SUBDIRS
DIST_SUBDIRS = m4 mk po $(libgc_dir) llvm mono ikvm-native support data runtime scripts man samples tools msvc docs acceptance-tests
DIST_SUBDIRS = $(build_with_msvc) m4 mk po $(libgc_dir) llvm mono ikvm-native support data runtime scripts man samples tools $(build_without_msvc) docs acceptance-tests netcore netcore/corerun
all: update_submodules
all: $(update_submodules)
SUBMODULE_ERROR='Could not recursively update all git submodules. You may experience compilation problems if some submodules are out of date'
update_submodules:
@$(srcdir)/scripts/update_submodules.sh
@cd $(srcdir) && scripts/update_submodules.sh
.PHONY: update_submodules
@@ -32,9 +46,10 @@ EXTRA_DIST= \
winconfig.h \
code_of_conduct.md \
external \
netcore/Makefile \
mcs/class/referencesource
DISTCHECK_CONFIGURE_FLAGS = EXTERNAL_MCS=false EXTERNAL_RUNTIME=false
DISTCHECK_CONFIGURE_FLAGS = EXTERNAL_RUNTIME=false
# Distribute the 'mcs' tree too
GIT_DIR ?= $(srcdir)/.git
@@ -42,9 +57,19 @@ dist-hook:
test -d $(distdir)/mcs || mkdir $(distdir)/mcs
d=`cd $(distdir)/mcs && pwd`; cd $(mcs_topdir) && $(MAKE) distdir=$$d dist-recursive
rm -rf `find $(top_distdir)/external -path '*\.git'`
rm -rf `find $(top_distdir)/external -path '*\.libs'`
rm -rf `find $(top_distdir)/external -path '*\.deps'`
rm -f `find $(top_distdir)/external -path '*\.o'`
rm -f `find $(top_distdir)/external -path '*\.so'`
rm -f `find $(top_distdir)/external -path '*\.lo'`
rm -f `find $(top_distdir)/external -path '*\.Plo'`
rm -f `find $(top_distdir)/external -name '\.dirstamp'`
rm -f `find $(top_distdir)/external -path '*\.exe' -not -path '*/roslyn-binaries/*'`
rm -f `find $(top_distdir)/external -path '*\.dll' -not -path '*/binary-reference-assemblies/*' -not -path '*/roslyn-binaries/*'`
rm -rf "$(top_distdir)/external/linker/linker/Tests"
rm -f `find $(top_distdir)/external -path '*\.dll' -not -path '*/binary-reference-assemblies/*' -not -path '*/roslyn-binaries/*' -not -path '*/helix-binaries/*'`
rm -rf "$(top_distdir)/external/linker/test"
rm -rf "$(top_distdir)/external/llvm-project/lldb/test"
rm -rf "$(top_distdir)/external/llvm-project/libcxx/test"
rm -rf "$(top_distdir)/external/llvm-project/clang/test"
pkgconfigdir = $(libdir)/pkgconfig
noinst_DATA = mono-uninstalled.pc
@@ -59,9 +84,15 @@ if BITCODE
BITCODE_CHECK=yes
endif
if DEFAULT_TESTS
CI_TEST_SCRIPT=$(srcdir)/scripts/ci/run-test-default.sh
else
CI_TEST_SCRIPT=$(srcdir)/scripts/ci/run-test-$(TEST_PROFILE).sh
endif
.PHONY: check-ci
check-ci:
MONO_LLVMONLY=$(BITCODE_CHECK) $(srcdir)/scripts/ci/run-test-$(TEST_PROFILE).sh
MONO_LLVMONLY=$(BITCODE_CHECK) $(CI_TEST_SCRIPT)
.PHONY: validate do-build-mono-mcs mcs-do-clean mcs-do-tests
validate: do-build-mono-mcs
+8
View File
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<clear />
<add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
</packageSources>
</configuration>
+7 -1
View File
@@ -30,7 +30,8 @@ The Mono project is part of the [.NET Foundation](https://www.dotnetfoundation.o
| Windows | i386 | [![windows-i386][17]][18] |
| CentOS | s390x (cs) | [![centos-s390x][19]][20] |
| Debian 9 | ppc64el (cs) | [![debian-9-ppc64el][21]][22]|
| AIX | ppc64 (cs) | [![aix-ppc64][23]][24] |
| AIX 6.1 | ppc64 (cs) | [![aix-ppc64][23]][24] |
| FreeBSD 12 | amd64 (cs) | [![freebsd-amd64][25]][26] |
_(cs) = community supported architecture_
@@ -58,6 +59,8 @@ _(cs) = community supported architecture_
[22]: https://jenkins.mono-project.com/job/test-mono-mainline-community-chroot/label=debian-9-ppc64el
[23]: https://jenkins.mono-project.com/job/test-mono-mainline-community/label=aix-ppc64/badge/icon
[24]: https://jenkins.mono-project.com/job/test-mono-mainline-community/label=aix-ppc64
[25]: https://jenkins.mono-project.com/job/test-mono-mainline-community/label=freebsd-12-amd64/badge/icon
[26]: https://jenkins.mono-project.com/job/test-mono-mainline-community/label=freebsd-12-amd64
Compilation and Installation
============================
@@ -306,6 +309,9 @@ faster under the Xen virtualization system.
* `--with-large-heap=yes,no` - Enable support for GC heaps larger than 3GB.
* This only applies only to the Boehm garbage collector, the SGen garbage
collector does not use this configuration option.
* This defaults to `no`.
* `--enable-small-config=yes,no` - Enable some tweaks to reduce memory usage
+185
View File
@@ -0,0 +1,185 @@
Mono uses third-party libraries or other resources that may be
distributed under licenses different than the Mono software.
Attributions and license notices for test cases originally authored by
third parties can be found in the respective test directories.
In the event that we accidentally failed to list a required notice, please
bring it to our attention. Post an issue or email us:
[email protected]
The attached notices are provided for information only.
License notice for Mono
-----------------------
Note: multiple license notices are provided that occure in source code.
They are equivalent forms of the the MIT license from various copyright holders.
// Dual licensed under the terms of the MIT X11 or GNU GPL
// Copyright 2003-2011 Novell, Inc.
// Copyright 2011 Xamarin Inc
/**
*
* Copyright 2001-2003 Ximian, Inc
* Copyright 2003-2010 Novell, Inc.
* Copyright (C) 2012 Xamarin Inc
*
* Licensed under the MIT license. See LICENSE file in the project root for full license information.
*/
/******************************************************************************
* The MIT License
* Copyright (c) 2003 Novell Inc. www.novell.com
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the Software), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*******************************************************************************/
License notice for Apple
-------------------------
Content: https://github.com/mono/mono/blob/435f968102d0820ca65d63e1e741e4130b4d1303/support/ios/net/route.h
License: https://opensource.apple.com/apsl/
License for GCC
---------------
License: http://gcc.gnu.org/onlinedocs/gcc-4.6.4/libstdc++/manual/manual/license.html
Content: https://github.com/mono/mono/blob/c398e19d3515c6bbb6046ed014b2095594a15229/mono/mini
Example: https://github.com/mono/mono/blob/c398e19d3515c6bbb6046ed014b2095594a15229/mono/mini/decompose.c#L967
GCC RUNTIME LIBRARY EXCEPTION
Version 3.1, 31 March 2009
Copyright (C) 2009 Free Software Foundation, Inc.
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
This GCC Runtime Library Exception ("Exception") is an additional
permission under section 7 of the GNU General Public License, version
3 ("GPLv3"). It applies to a given file (the "Runtime Library") that
bears a notice placed by the copyright holder of the file stating that
the file is governed by GPLv3 along with this Exception.
When you use GCC to compile a program, GCC may combine portions of
certain GCC header files and runtime libraries with the compiled
program. The purpose of this Exception is to allow compilation of
non-GPL (including proprietary) programs to use, in this way, the
header files and runtime libraries covered by this Exception.
0. Definitions.
A file is an "Independent Module" if it either requires the Runtime
Library for execution after a Compilation Process, or makes use of an
interface provided by the Runtime Library, but is not otherwise based
on the Runtime Library.
"GCC" means a version of the GNU Compiler Collection, with or without
modifications, governed by version 3 (or a specified later version) of
the GNU General Public License (GPL) with the option of using any
subsequent versions published by the FSF.
"GPL-compatible Software" is software whose conditions of propagation,
modification and use would permit combination with GCC in accord with
the license of GCC.
"Target Code" refers to output from any compiler for a real or virtual
target processor architecture, in executable form or suitable for
input to an assembler, loader, linker and/or execution
phase. Notwithstanding that, Target Code does not include data in any
format that is used as a compiler intermediate representation, or used
for producing a compiler intermediate representation.
The "Compilation Process" transforms code entirely represented in
non-intermediate languages designed for human-written code, and/or in
Java Virtual Machine byte code, into Target Code. Thus, for example,
use of source code generators and preprocessors need not be considered
part of the Compilation Process, since the Compilation Process can be
understood as starting with the output of the generators or
preprocessors.
A Compilation Process is "Eligible" if it is done using GCC, alone or
with other GPL-compatible software, or if it is done without using any
work based on GCC. For example, using non-GPL-compatible Software to
optimize any GCC intermediate representations would not qualify as an
Eligible Compilation Process.
1. Grant of Additional Permission.
You have permission to propagate a work of Target Code formed by
combining the Runtime Library with Independent Modules, even if such
propagation would otherwise violate the terms of GPLv3, provided that
all Target Code was generated by Eligible Compilation Processes. You
may then convey such a combination under terms of your choice,
consistent with the licensing of the Independent Modules.
2. No Weakening of GCC Copyleft.
The availability of this Exception does not imply any general
presumption that third-party software is unaffected by the copyleft
requirements of the license of GCC.
Hopefully that text is self-explanatory. If it isn't, you need to speak to your lawyer, or the Free Software Foundation.
License notice for Silicon Graphics and HP
------------------------------------------
/*
* Copyright (c) 1996-1997
* Silicon Graphics Computer Systems, Inc.
*
* Permission to use, copy, modify, distribute and sell this software
* and its documentation for any purpose is hereby granted without fee,
* provided that the above copyright notice appear in all copies and
* that both that copyright notice and this permission notice appear
* in supporting documentation. Silicon Graphics makes no
* representations about the suitability of this software for any
* purpose. It is provided "as is" without express or implied warranty.
*
* Copyright (c) 2002
* Hewlett-Packard Company
*
* Permission to use, copy, modify, distribute and sell this software
* and its documentation for any purpose is hereby granted without fee,
* provided that the above copyright notice appear in all copies and
* that both that copyright notice and this permission notice appear
* in supporting documentation. Hewlett-Packard Company makes no
* representations about the suitability of this software for any
* purpose. It is provided "as is" without express or implied warranty.
*/
/*
* This implements standard-conforming allocators that interact with
* the garbage collector. Gc_alloctor<T> allocates garbage-collectable
* objects of type T. Traceable_allocator<T> allocates objects that
* are not temselves garbage collected, but are scanned by the
* collector for pointers to collectable objects. Traceable_alloc
* should be used for explicitly managed STL containers that may
* point to collectable objects.
*
* This code was derived from an earlier version of the GNU C++ standard
* library, which itself was derived from the SGI STL implementation.
*/
Content: https://github.com/mono/mono/blob/d58dfa185af1d48fb93efdef1d046762f214f0a7/libgc/include/gc_allocator.h
+1
View File
@@ -4,3 +4,4 @@ Makefile
*.dll
*.mdb
coreclr-testlist.txt
microbench-perf.sh
+3 -1
View File
@@ -3,9 +3,10 @@ BENCHMARKER_PATH=$(ACCEPTANCE_TESTS_PATH)/benchmarker
ROSLYN_PATH=$(ACCEPTANCE_TESTS_PATH)/roslyn
CORECLR_PATH=$(ACCEPTANCE_TESTS_PATH)/coreclr
MSTESTSUITE_PATH=$(ACCEPTANCE_TESTS_PATH)/ms-test-suite
DEBIANSHOOTOUTMONO_PATH=$(ACCEPTANCE_TESTS_PATH)/DebianShootoutMono
CLEANFILES = *.dll *.exe *.mdb
EXTRA_DIST=README.md SUBMODULES.json versions.mk profiler-stress.mk roslyn.mk coreclr.mk ms-test-suite.mk
EXTRA_DIST=README.md SUBMODULES.json microbench.mk versions.mk profiler-stress.mk roslyn.mk coreclr.mk ms-test-suite.mk
CLASS=$(mcs_topdir)/class/lib/$(DEFAULT_PROFILE)
TOOLS_CLASS=$(mcs_topdir)/class/lib/build
@@ -17,6 +18,7 @@ ILASM = $(TOOLS_RUNTIME) $(TOOLS_CLASS)/ilasm.exe
XUNIT = $(RUNTIME) $(abs_top_builddir)/external/xunit-binaries/xunit.console.exe
include versions.mk
include microbench.mk
include profiler-stress.mk
include roslyn.mk
include coreclr.mk
+11 -3
View File
@@ -2,7 +2,7 @@
{
"name": "roslyn",
"url": "git://github.com/mono/roslyn.git",
"rev": "7a840bd5697ef6ea41f554a09d837636fba9d88d",
"rev": "6bfcd4e770609a38b8523e83ce1ec943162f30bb",
"remote-branch": "origin/mono-testing",
"branch": "mono-testing",
"directory": "roslyn"
@@ -10,7 +10,7 @@
{
"name": "coreclr",
"url": "git://github.com/mono/coreclr.git",
"rev": "f3d9c9f742f9dcb5faf40080db5e7f464dab7e7c",
"rev": "90f7060935732bb624e1f325d23f63072433725f",
"remote-branch": "origin/mono",
"branch": "mono",
"directory": "coreclr"
@@ -18,7 +18,7 @@
{
"name": "ms-test-suite",
"url": "[email protected]:xamarin/ms-test-suite.git",
"rev": "67f29dfc0741b5311dd746c75760963a2915e648",
"rev": "39b1b222e8a3690a1b8ea018ce54d2a826f5246e",
"remote-branch": "origin/master",
"branch": "master",
"directory": "ms-test-suite"
@@ -30,5 +30,13 @@
"remote-branch": "origin/master",
"branch": "master",
"directory": "benchmarker"
},
{
"name": "DebianShootoutMono",
"url": "https://github.com/alexanderkyte/DebianShootoutMono.git",
"rev": "3fde2ced806c1fe7eed81120a40d99474fa009f0",
"remote-branch": "origin/release_11_15_2018",
"branch": "release_11_15_2018",
"directory": "DebianShootoutMono"
}
]
-1
View File
@@ -3175,7 +3175,6 @@ CORECLR_COREMANGLIB_TEST_CS_SRC= \
$(CORECLR_PATH)/tests/src/CoreMangLib/cti/system/runtime/interopservices/inattribute/inattributector.cs \
$(CORECLR_PATH)/tests/src/CoreMangLib/cti/system/runtime/interopservices/layoutkind/layoutkindauto.cs \
$(CORECLR_PATH)/tests/src/CoreMangLib/cti/system/runtime/interopservices/layoutkind/layoutkindsequential.cs \
$(CORECLR_PATH)/tests/src/CoreMangLib/cti/system/runtime/interopservices/marshal/marshalgetlastwin32error.cs \
$(CORECLR_PATH)/tests/src/CoreMangLib/cti/system/runtime/interopservices/marshal/marshalreadint641.cs \
$(CORECLR_PATH)/tests/src/CoreMangLib/cti/system/runtime/interopservices/marshal/marshalsizeof1.cs \
$(CORECLR_PATH)/tests/src/CoreMangLib/cti/system/runtime/interopservices/marshalasattribute/marshalasattributearraysubtype.cs \
+17
View File
@@ -0,0 +1,17 @@
#! /bin/sh
r='@mono_build_root@'
aotpattern="--aot="
# if this is an aot invoke
if [[ $@ =~ $aotpattern ]];
then
# just aot the code
echo "$r/runtime/mono-wrapper $@"
exec $r/runtime/mono-wrapper $@
else
# else run it under perf
echo "$MONO_PERF_BINARY record -o $r/acceptance-tests/perf.data -v -s -g -- $r/mono/mini/mono-sgen $@"
exec $MONO_PERF_BINARY record -o $r/acceptance-tests/perf.data -v -s -g $r/mono/mini/mono-sgen $@
fi
+119
View File
@@ -0,0 +1,119 @@
check-microbench: DebianShootoutMono.stamp
@$(MAKE) test-run-microbench
DebianShootoutMono.stamp:
@$(MAKE) validate-DebianShootoutMono RESET_VERSIONS=1
@$(MAKE) prepare-dlls
@touch $@
abs_top_srcdir = $(abspath $(top_srcdir))
TEST_EXE_PATH=$(abs_top_srcdir)/acceptance-tests/external/DebianShootoutMono/release/
NET_4_X_RUNTIME=MONO_PATH=$(TEST_EXE_PATH):$(abs_top_srcdir)/mcs/class/lib/net_4_x $(abs_top_srcdir)/runtime/mono-wrapper
FULL_AOT_RUNTIME=MONO_PATH=$(abs_top_srcdir)/mcs/class/lib/testing_aot_full $(abs_top_srcdir)/runtime/mono-wrapper
PERF_BINARY=$(if $(MONO_PERF_BINARY),$(MONO_PERF_BINARY),perf)
PERF_RUNTIME=$(abs_top_srcdir)/acceptance-tests/microbench-perf.sh
define BenchmarkDotNetTemplate
run-microbench-$(1):: DebianShootoutMono.stamp
MONO_BENCH_AOT_RUN="$(AOT_RUN_FLAGS)" \
MONO_BENCH_AOT_BUILD="$(AOT_BUILD_FLAGS)" \
MONO_BENCH_EXECUTABLE="$(abs_top_srcdir)/runtime/mono-wrapper" \
MONO_BENCH_PATH="$(abs_top_srcdir)/mcs/class/lib/$(TEST_PROFILE)" \
MONO_BENCH_INPUT="$(2)" \
$(NET_4_X_RUNTIME) \
$(TEST_EXE_PATH)/DebianShootoutMono.exe $(1)
test-run-microbench:: run-microbench-$(1)
run-microbench-debug-$(1):: DebianShootoutMono.stamp
echo MONO_PATH="$(abs_top_srcdir)/mcs/class/lib/$(TEST_PROFILE)" $(abs_top_srcdir)/runtime/mono-wrapper $(AOT_BUILD_FLAGS) $(TEST_EXE_PATH)/DebianShootoutMono.exe
MONO_BENCH_INPUT="$(2)" \
MONO_PATH="$(abs_top_srcdir)/mcs/class/lib/$(TEST_PROFILE)" \
$(abs_top_srcdir)/runtime/mono-wrapper $(AOT_RUN_FLAGS) $(TEST_EXE_PATH)/DebianShootoutMono.exe Run $(1)
test-run-microbench-debug:: run-microbench-debug-$(1)
if HOST_LINUX
run-microbench-profiled-$(1):: microbench-results/$(1).perf.data
microbench-results/$(1).perf.data: DebianShootoutMono.stamp
mkdir -p microbench-results
MONO_PERF_BINARY="$(PERF_BINARY)" \
MONO_BENCH_EXECUTABLE="$(PERF_RUNTIME)" \
MONO_BENCH_AOT_RUN="$(AOT_RUN_FLAGS)"\
MONO_BENCH_AOT_BUILD="$(AOT_BUILD_FLAGS)"\
MONO_BENCH_PATH="$(abs_top_srcdir)/mcs/class/lib/$(TEST_PROFILE)" \
MONO_BENCH_INPUT="$(2)" \
$(NET_4_X_RUNTIME) \
$(TEST_EXE_PATH)/DebianShootoutMono.exe $(1) $(2)
mv perf.data microbench-results/$(1).perf.data
microbench-results/$(1).tmp.perf: microbench-results/$(1).perf.data
$(PERF_BINARY) script -i microbench-results/$(1).perf.data > microbench-results/$(1).tmp.perf
microbench-results/$(1).perf-flame.svg: microbench-results/$(1).tmp.perf
cat microbench-results/$(1).tmp.perf | ./external/DebianShootoutMono/FlameGraph/stackcollapse-perf.pl > microbench-results/$(1).perf-folded
./external/DebianShootoutMono/FlameGraph/flamegraph.pl microbench-results/$(1).perf-folded > microbench-results/$(1).perf-flame.svg
rm microbench-results/$(1).tmp.perf
rm microbench-results/$(1).perf-folded
MONO_PERF_FLAGS=--show-cpu-utilization -n --hierarchy -T $(MONO_PERF_ADDITIONAL_FLAGS)
microbench-results/$(1).perf.report: microbench-results/$(1).perf.data
$(PERF_BINARY) report -i microbench-results/$(1).perf.data $(MONO_PERF_FLAGS) > microbench-results/$(1).perf.report
test-run-microbench-profiled:: run-microbench-profiled-$(1)
test-run-microbench-publish-collect:: microbench-results/$(1).perf.data microbench-results/$(1).perf.report microbench-results/$(1).perf-flame.svg
endif
endef
if HOST_LINUX
test-run-microbench-perf-check:
$(PERF_BINARY) record -a -o perf.data -- echo "testing"
rm perf.data
microbench-results/perf-data.zip:
zip microbench-results/perf-data.zip microbench-results/*.perf.data
rm microbench-results/*.perf.data
perf-report: microbench-results/perf-data.zip
perf-report-total: test-run-microbench-publish-collect
@$(MAKE) perf-report
endif
.PHONY: prepare-dlls
if FULL_AOT_TESTS
prepare-dlls:
$(FULL_AOT_RUNTIME) $(AOT_BUILD_FLAGS) $(TEST_EXE_PATH)/*.{dll,exe}
else
prepare-dlls:
endif
FIXTURE_DIR=$(abs_top_srcdir)/acceptance-tests/external/DebianShootoutMono/fixtures
$(eval $(call BenchmarkDotNetTemplate,Mandelbrot,))
$(eval $(call BenchmarkDotNetTemplate,RegexRedux,$(FIXTURE_DIR)/regexredux-input.txt))
$(eval $(call BenchmarkDotNetTemplate,KNucleotide,$(FIXTURE_DIR)/knucleotide-input.txt))
$(eval $(call BenchmarkDotNetTemplate,BinaryTrees,))
$(eval $(call BenchmarkDotNetTemplate,NBodyTest,))
$(eval $(call BenchmarkDotNetTemplate,SpectralNorm,))
$(eval $(call BenchmarkDotNetTemplate,Fannkuchredux,))
$(eval $(call BenchmarkDotNetTemplate,Fasta,))
$(eval $(call BenchmarkDotNetTemplate,RevComp,$(FIXTURE_DIR)/revcomp-input.txt))
#$(eval $(call BenchmarkDotNetTemplate,GistBenchmark,$(MONO_BENCH_GIST_URL))) broken in BDN, bug filed
+2
View File
@@ -1,4 +1,6 @@
check-roslyn:
@echo "Runnning roslyn tests using mono from PATH:"
mono --version
@$(MAKE) validate-roslyn RESET_VERSIONS=1
cd $(ROSLYN_PATH); \
./build.sh --restore --build --test --mono || exit; \
+10
View File
@@ -7,6 +7,7 @@ $(eval $(call ValidateVersionTemplate,benchmarker,BENCHMARKER))
$(eval $(call ValidateVersionTemplate,roslyn,ROSLYN))
$(eval $(call ValidateVersionTemplate,coreclr,CORECLR))
$(eval $(call ValidateVersionTemplate,ms-test-suite,MSTESTSUITE))
$(eval $(call ValidateVersionTemplate,DebianShootoutMono,DEBIANSHOOTOUTMONO))
# Bump the given submodule to the revision given by the REV make variable
# If COMMIT is 1, commit the change
@@ -14,6 +15,7 @@ bump-benchmarker: __bump-benchmarker
bump-roslyn: __bump-version-roslyn
bump-coreclr: __bump-version-coreclr
bump-ms-test-suite: __bump-version-ms-test-suite
bump-DebianShootoutMono: __bump-version-DebianShootoutMono
# Bump the given submodule to the branch given by the BRANCH/REMOTE_BRANCH make variables
# If COMMIT is 1, commit the change
@@ -21,6 +23,7 @@ bump-branch-benchmarker: __bump-branch-benchmarker
bump-branch-roslyn: __bump-branch-roslyn
bump-branch-coreclr: __bump-branch-coreclr
bump-branch-ms-test-suite: __bump-branch-ms-test-suite
bump-branch-DebianShootoutMono: __bump-branch-DebianShootoutMono
# Bump the given submodule to its current GIT version
# If COMMIT is 1, commit the change
@@ -28,6 +31,7 @@ bump-current-benchmarker: __bump-current-benchmarker
bump-current-roslyn: __bump-current-version-roslyn
bump-current-coreclr: __bump-current-version-coreclr
bump-current-ms-test-suite: __bump-current-version-ms-test-suite
bump-current-DebianShootoutMono: __bump-current-version-DebianShootoutMono
commit-bump-benchmarker:
$(MAKE) bump-benchmarker COMMIT=1
@@ -41,6 +45,9 @@ commit-bump-coreclr:
commit-bump-ms-test-suite:
$(MAKE) bump-ms-test-suite COMMIT=1
commit-bump-DebianShootoutMono:
$(MAKE) bump-DebianShootoutMono COMMIT=1
commit-bump-current-benchmarker:
$(MAKE) bump-current-benchmarker COMMIT=1
@@ -52,3 +59,6 @@ commit-bump-current-coreclr:
commit-bump-current-ms-test-suite:
$(MAKE) bump-current-ms-test-suite COMMIT=1
commit-bump-current-DebianShootoutMono:
$(MAKE) bump-current-DebianShootoutMono COMMIT=1
+18 -6
View File
@@ -120,7 +120,7 @@ for PARAM; do
done
if test x$has_ext_mod = xtrue; then
pushd ../mono-extensions/scripts
pushd $top_srcdir../mono-extensions/scripts
sh ./prepare-repo.sh $ext_mod_args || exit 1
popd
else
@@ -150,17 +150,29 @@ automake $am_opt ||
echo "Running autoconf ..."
autoconf || { echo "**Error**: autoconf failed."; exit 1; }
if test -d $srcdir/libgc; then
echo Running libgc/autogen.sh ...
(cd $srcdir/libgc ; NOCONFIGURE=1 ./autogen.sh "$@")
echo Done running libgc/autogen.sh ...
if test -d $srcdir/external/bdwgc; then
echo Running external/bdwgc/autogen.sh ...
(cd $srcdir/external/bdwgc ; NOCONFIGURE=1 ./autogen.sh "$@")
echo Done running external/bdwgc/autogen.sh ...
fi
if test x$MONO_EXTRA_CONFIGURE_FLAGS != x; then
echo "MONO_EXTRA_CONFIGURE_FLAGS is $MONO_EXTRA_CONFIGURE_FLAGS"
fi
conf_flags="$MONO_EXTRA_CONFIGURE_FLAGS --enable-maintainer-mode --enable-compile-warnings" #--enable-iso-c
host_conf_flag=
build_uname_all=`(uname -a) 2>/dev/null`
case "$build_uname_all" in
CYGWIN*)
if [[ "$@" != *"--host="* ]]; then
echo "Missing --host parameter, configure using ./configure --host=i686-w64-mingw32 or --host=x86_64-w64-mingw32"
echo "Falling back using --host=x86_64-w64-mingw32 as default."
host_conf_flag="--host=x86_64-w64-mingw32"
fi
;;
esac
conf_flags="$MONO_EXTRA_CONFIGURE_FLAGS --enable-maintainer-mode --enable-compile-warnings $host_conf_flag" #--enable-iso-c
if test x$NOCONFIGURE = x; then
echo Running $srcdir/configure $conf_flags "$@" ...
+219 -431
View File
@@ -1,6 +1,6 @@
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 15
MinimumVisualStudioVersion = 15.0.0.0
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "jay", "mcs/jay/jay.vcxproj", "{5d485d32-3b9f-4287-ab24-c8da5b89f537}"
EndProject
@@ -188,7 +188,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mono.Cecil.Mdb", "mcs/class
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mono.CSharp", "mcs/class/Mono.CSharp/Mono.CSharp.csproj", "{817CE046-07E8-409D-84BF-A6EA4F2879DE}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mono.Debugger.Soft", "mcs/class/Mono.Debugger.Soft/Mono.Debugger.Soft.csproj", "{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mono.Debugger.Soft", "mcs/class/Mono.Debugger.Soft/Mono.Debugger.Soft.csproj", "{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mono.C5", "mcs/class/Mono.C5/Mono.C5.csproj", "{A9F5A575-3725-4691-A7A6-0ABDEA3994CE}"
EndProject
@@ -302,10 +302,6 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Build.Tasks", "mc
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Build", "mcs/class/Microsoft.Build/Microsoft.Build.csproj", "{86E2C258-C0D8-48D0-BA76-0280A981CEE0}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_System.Drawing.Primitives", "mcs/class/Facades/System.Drawing.Primitives/Facades_System.Drawing.Primitives.csproj", "{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_netstandard", "mcs/class/Facades/netstandard/Facades_netstandard.csproj", "{E4596A34-AFBC-4744-8352-E6996AC34C16}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_System.Collections.Concurrent", "mcs/class/Facades/System.Collections.Concurrent/Facades_System.Collections.Concurrent.csproj", "{DE0D7286-1F09-4ACC-BC43-75342349FFC1}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_System.Collections", "mcs/class/Facades/System.Collections/Facades_System.Collections.csproj", "{758C73D3-F04B-40BD-B55B-057F529053CA}"
@@ -568,30 +564,18 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_System.Runtime.Seri
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_System.Security.Cryptography.Algorithms", "mcs/class/Facades/System.Security.Cryptography.Algorithms/Facades_System.Security.Cryptography.Algorithms.csproj", "{942F9B7C-3245-4F5A-A4ED-140013DCCE2C}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_netstandard", "mcs/class/Facades/netstandard/Facades_netstandard.csproj", "{E4596A34-AFBC-4744-8352-E6996AC34C16}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_System.Drawing.Primitives", "mcs/class/Facades/System.Drawing.Primitives/Facades_System.Drawing.Primitives.csproj", "{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Facades_System.Net.Http.Rtc", "mcs/class/Facades/System.Net.Http.Rtc/Facades_System.Net.Http.Rtc.csproj", "{786AAD60-DBEA-4F9B-BF1B-C3486CE000D0}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "NUnit.Framework", "mcs/nunit24/NUnitFramework/framework/NUnit.Framework.csproj", "{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "nunit.core.interfaces", "mcs/nunit24/NUnitCore/interfaces/nunit.core.interfaces.csproj", "{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "nunit.core", "mcs/nunit24/NUnitCore/core/nunit.core.csproj", "{559F5BCC-3235-494A-9D86-4F26F67F9E40}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "nunit.util", "mcs/nunit24/ClientUtilities/util/nunit.util.csproj", "{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "nunit.mocks", "mcs/nunit24/NUnitMocks/mocks/nunit.mocks.csproj", "{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "nunit.framework.extensions", "mcs/nunit24/NUnitExtensions/framework/nunit.framework.extensions.csproj", "{DFE253AA-843E-4374-B862-9F0B7414CB8C}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "nunit.core.extensions", "mcs/nunit24/NUnitExtensions/core/nunit.core.extensions.csproj", "{6464D30A-2B8E-458D-B96A-2ECDE947B58B}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "nunit-console-runner", "mcs/nunit24/ConsoleRunner/nunit-console/nunit-console-runner.csproj", "{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "nunit-console", "mcs/nunit24/ConsoleRunner/nunit-console-exe/nunit-console.csproj", "{2D845BF5-42C7-41D3-AC01-F63980F76B22}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ilasm", "mcs/ilasm/ilasm.csproj", "{C02B3C37-DB98-40A5-84F0-F98633DA7EE4}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "al", "mcs/tools/al/al.csproj", "{0A20671F-CCA9-457D-886C-0828C7D64128}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "aprofutil", "mcs/tools/aprofutil/aprofutil.csproj", "{658B566B-CED1-4C42-9926-C1AA930BA368}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "monolinker", "mcs/tools/linker/monolinker.csproj", "{D60432F1-3C12-4235-A1CC-4CA5575403BD}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "culevel", "mcs/tools/culevel/culevel.csproj", "{E8E246BD-CD0C-4734-A3C2-7F44796EC47B}"
@@ -1126,22 +1110,14 @@ Global
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|orbis.ActiveCfg = Debug|orbis
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|orbis.Build.0 = Debug|orbis
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|orbis.ActiveCfg = Release|orbis
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|orbis.Build.0 = Release|orbis
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|unreal.ActiveCfg = Debug|unreal
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|unreal.Build.0 = Debug|unreal
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|unreal.ActiveCfg = Release|unreal
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|unreal.Build.0 = Release|unreal
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|wasm.ActiveCfg = Debug|wasm
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|wasm.Build.0 = Debug|wasm
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|wasm.ActiveCfg = Release|wasm
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|wasm.Build.0 = Release|wasm
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|winaot.ActiveCfg = Debug|winaot
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|winaot.Build.0 = Debug|winaot
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|winaot.ActiveCfg = Release|winaot
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|winaot.Build.0 = Release|winaot
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|orbis.ActiveCfg = Debug|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|orbis.ActiveCfg = Release|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|unreal.ActiveCfg = Debug|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|unreal.ActiveCfg = Release|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|wasm.ActiveCfg = Debug|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|wasm.ActiveCfg = Release|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|winaot.ActiveCfg = Debug|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|winaot.ActiveCfg = Release|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Debug|xammac.ActiveCfg = Debug|net_4_x
{DCB27742-5382-4CB3-B7D8-A6DF92B8B68C}.Release|xammac.ActiveCfg = Release|net_4_x
{4900DA48-CB1B-4520-98EE-F6B0F3054341}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
@@ -1560,10 +1536,8 @@ Global
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Debug|unreal.Build.0 = Debug|unreal
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Release|unreal.ActiveCfg = Release|unreal
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Release|unreal.Build.0 = Release|unreal
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Debug|wasm.ActiveCfg = Debug|wasm
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Debug|wasm.Build.0 = Debug|wasm
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Release|wasm.ActiveCfg = Release|wasm
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Release|wasm.Build.0 = Release|wasm
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Debug|wasm.ActiveCfg = Debug|net_4_x
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Release|wasm.ActiveCfg = Release|net_4_x
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Debug|winaot.ActiveCfg = Debug|winaot
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Debug|winaot.Build.0 = Debug|winaot
{2281525D-7F2E-41C1-982F-E612AF3ECF61}.Release|winaot.ActiveCfg = Release|winaot
@@ -1688,10 +1662,8 @@ Global
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Debug|unreal.Build.0 = Debug|unreal
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Release|unreal.ActiveCfg = Release|unreal
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Release|unreal.Build.0 = Release|unreal
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Debug|wasm.ActiveCfg = Debug|wasm
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Debug|wasm.Build.0 = Debug|wasm
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Release|wasm.ActiveCfg = Release|wasm
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Release|wasm.Build.0 = Release|wasm
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Debug|wasm.ActiveCfg = Debug|net_4_x
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Release|wasm.ActiveCfg = Release|net_4_x
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Debug|winaot.ActiveCfg = Debug|winaot
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Debug|winaot.Build.0 = Debug|winaot
{7395C26D-7C2A-4F7F-AB7D-CE0B50BDFF38}.Release|winaot.ActiveCfg = Release|winaot
@@ -2238,10 +2210,8 @@ Global
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Debug|unreal.Build.0 = Debug|unreal
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Release|unreal.ActiveCfg = Release|unreal
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Release|unreal.Build.0 = Release|unreal
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Debug|wasm.ActiveCfg = Debug|wasm
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Debug|wasm.Build.0 = Debug|wasm
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Release|wasm.ActiveCfg = Release|wasm
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Release|wasm.Build.0 = Release|wasm
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Debug|wasm.ActiveCfg = Debug|net_4_x
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Release|wasm.ActiveCfg = Release|net_4_x
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Debug|winaot.ActiveCfg = Debug|winaot
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Debug|winaot.Build.0 = Debug|winaot
{2401CC34-7A55-4EC4-B8BF-6E846245F5FE}.Release|winaot.ActiveCfg = Release|winaot
@@ -2300,10 +2270,8 @@ Global
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Debug|unreal.Build.0 = Debug|unreal
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Release|unreal.ActiveCfg = Release|unreal
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Release|unreal.Build.0 = Release|unreal
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Debug|wasm.ActiveCfg = Debug|wasm
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Debug|wasm.Build.0 = Debug|wasm
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Release|wasm.ActiveCfg = Release|wasm
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Release|wasm.Build.0 = Release|wasm
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Debug|wasm.ActiveCfg = Debug|net_4_x
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Release|wasm.ActiveCfg = Release|net_4_x
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Debug|winaot.ActiveCfg = Debug|winaot
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Debug|winaot.Build.0 = Debug|winaot
{89CDEBFC-EF90-4437-9D6B-439277F2C7E5}.Release|winaot.ActiveCfg = Release|winaot
@@ -2406,10 +2374,8 @@ Global
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Debug|unreal.Build.0 = Debug|unreal
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Release|unreal.ActiveCfg = Release|unreal
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Release|unreal.Build.0 = Release|unreal
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Debug|wasm.ActiveCfg = Debug|wasm
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Debug|wasm.Build.0 = Debug|wasm
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Release|wasm.ActiveCfg = Release|wasm
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Release|wasm.Build.0 = Release|wasm
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Debug|wasm.ActiveCfg = Debug|net_4_x
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Release|wasm.ActiveCfg = Release|net_4_x
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Debug|winaot.ActiveCfg = Debug|winaot
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Debug|winaot.Build.0 = Debug|winaot
{182E5AD7-2F59-48E5-B338-C515733AE79B}.Release|winaot.ActiveCfg = Release|winaot
@@ -2600,10 +2566,8 @@ Global
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Debug|unreal.Build.0 = Debug|unreal
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Release|unreal.ActiveCfg = Release|unreal
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Release|unreal.Build.0 = Release|unreal
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Debug|wasm.ActiveCfg = Debug|wasm
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Debug|wasm.Build.0 = Debug|wasm
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Release|wasm.ActiveCfg = Release|wasm
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Release|wasm.Build.0 = Release|wasm
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Debug|wasm.ActiveCfg = Debug|net_4_x
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Release|wasm.ActiveCfg = Release|net_4_x
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Debug|winaot.ActiveCfg = Debug|winaot
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Debug|winaot.Build.0 = Debug|winaot
{B6102416-28B0-44C3-88A6-84B8C6B5E7EF}.Release|winaot.ActiveCfg = Release|winaot
@@ -3366,30 +3330,32 @@ Global
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Release|wasm.ActiveCfg = Release|net_4_x
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Debug|winaot.ActiveCfg = Debug|net_4_x
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Release|winaot.ActiveCfg = Release|net_4_x
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Debug|xammac.ActiveCfg = Debug|net_4_x
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Release|xammac.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|net_4_x.Build.0 = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|net_4_x.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|net_4_x.Build.0 = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|monodroid.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|monotouch.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|orbis.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|orbis.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|unreal.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|unreal.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|wasm.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|wasm.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|winaot.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|winaot.ActiveCfg = Release|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Debug|xammac.ActiveCfg = Debug|net_4_x
{8787A3B7-8A19-4586-8DCF-6F5914FD48D5}.Release|xammac.ActiveCfg = Release|net_4_x
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Debug|xammac.ActiveCfg = Debug|xammac
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Debug|xammac.Build.0 = Debug|xammac
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Release|xammac.ActiveCfg = Release|xammac
{817CE046-07E8-409D-84BF-A6EA4F2879DE}.Release|xammac.Build.0 = Release|xammac
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|net_4_x.Build.0 = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|net_4_x.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|net_4_x.Build.0 = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|monodroid.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|monotouch.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|orbis.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|orbis.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|unreal.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|unreal.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|wasm.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|wasm.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|winaot.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|winaot.ActiveCfg = Release|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Debug|xammac.ActiveCfg = Debug|net_4_x
{767CAD15-F8B5-4EAC-8B3D-4EF75F768015}.Release|xammac.ActiveCfg = Release|net_4_x
{A9F5A575-3725-4691-A7A6-0ABDEA3994CE}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{A9F5A575-3725-4691-A7A6-0ABDEA3994CE}.Debug|net_4_x.Build.0 = Debug|net_4_x
{A9F5A575-3725-4691-A7A6-0ABDEA3994CE}.Release|net_4_x.ActiveCfg = Release|net_4_x
@@ -3480,8 +3446,10 @@ Global
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Release|unreal.ActiveCfg = Release|net_4_x
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Debug|wasm.ActiveCfg = Debug|net_4_x
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Release|wasm.ActiveCfg = Release|net_4_x
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Debug|winaot.ActiveCfg = Debug|net_4_x
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Release|winaot.ActiveCfg = Release|net_4_x
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Debug|winaot.ActiveCfg = Debug|winaot
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Debug|winaot.Build.0 = Debug|winaot
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Release|winaot.ActiveCfg = Release|winaot
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Release|winaot.Build.0 = Release|winaot
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Debug|xammac.ActiveCfg = Debug|net_4_x
{045A3571-9B4B-4318-BD72-22C6CCD094F1}.Release|xammac.ActiveCfg = Release|net_4_x
{1B87A378-65E8-4899-9C9A-C940429D643C}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
@@ -3664,10 +3632,8 @@ Global
{49AC287E-29E1-4683-98B8-6E65DA581854}.Debug|unreal.Build.0 = Debug|unreal
{49AC287E-29E1-4683-98B8-6E65DA581854}.Release|unreal.ActiveCfg = Release|unreal
{49AC287E-29E1-4683-98B8-6E65DA581854}.Release|unreal.Build.0 = Release|unreal
{49AC287E-29E1-4683-98B8-6E65DA581854}.Debug|wasm.ActiveCfg = Debug|wasm
{49AC287E-29E1-4683-98B8-6E65DA581854}.Debug|wasm.Build.0 = Debug|wasm
{49AC287E-29E1-4683-98B8-6E65DA581854}.Release|wasm.ActiveCfg = Release|wasm
{49AC287E-29E1-4683-98B8-6E65DA581854}.Release|wasm.Build.0 = Release|wasm
{49AC287E-29E1-4683-98B8-6E65DA581854}.Debug|wasm.ActiveCfg = Debug|net_4_x
{49AC287E-29E1-4683-98B8-6E65DA581854}.Release|wasm.ActiveCfg = Release|net_4_x
{49AC287E-29E1-4683-98B8-6E65DA581854}.Debug|winaot.ActiveCfg = Debug|winaot
{49AC287E-29E1-4683-98B8-6E65DA581854}.Debug|winaot.Build.0 = Debug|winaot
{49AC287E-29E1-4683-98B8-6E65DA581854}.Release|winaot.ActiveCfg = Release|winaot
@@ -3990,10 +3956,8 @@ Global
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Debug|unreal.Build.0 = Debug|unreal
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Release|unreal.ActiveCfg = Release|unreal
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Release|unreal.Build.0 = Release|unreal
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Debug|wasm.ActiveCfg = Debug|wasm
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Debug|wasm.Build.0 = Debug|wasm
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Release|wasm.ActiveCfg = Release|wasm
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Release|wasm.Build.0 = Release|wasm
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Debug|wasm.ActiveCfg = Debug|net_4_x
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Release|wasm.ActiveCfg = Release|net_4_x
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Debug|winaot.ActiveCfg = Debug|winaot
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Debug|winaot.Build.0 = Debug|winaot
{B949A52E-3240-4BD3-B57B-89C78D9EB9D4}.Release|winaot.ActiveCfg = Release|winaot
@@ -4050,24 +4014,42 @@ Global
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|net_4_x.Build.0 = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|net_4_x.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|net_4_x.Build.0 = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monodroid.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|orbis.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|orbis.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|unreal.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|unreal.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|wasm.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|wasm.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|winaot.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|winaot.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|xammac.ActiveCfg = Debug|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|xammac.ActiveCfg = Release|net_4_x
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monodroid.ActiveCfg = Debug|monodroid
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monodroid.Build.0 = Debug|monodroid
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monodroid.ActiveCfg = Release|monodroid
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monodroid.Build.0 = Release|monodroid
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch.ActiveCfg = Debug|monotouch
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch.Build.0 = Debug|monotouch
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch.ActiveCfg = Release|monotouch
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch.Build.0 = Release|monotouch
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch_tv.ActiveCfg = Debug|monotouch_tv
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch_tv.Build.0 = Debug|monotouch_tv
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch_tv.ActiveCfg = Release|monotouch_tv
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch_tv.Build.0 = Release|monotouch_tv
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch_watch.ActiveCfg = Debug|monotouch_watch
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|monotouch_watch.Build.0 = Debug|monotouch_watch
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch_watch.ActiveCfg = Release|monotouch_watch
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|monotouch_watch.Build.0 = Release|monotouch_watch
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|orbis.ActiveCfg = Debug|orbis
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|orbis.Build.0 = Debug|orbis
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|orbis.ActiveCfg = Release|orbis
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|orbis.Build.0 = Release|orbis
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|unreal.ActiveCfg = Debug|unreal
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|unreal.Build.0 = Debug|unreal
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|unreal.ActiveCfg = Release|unreal
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|unreal.Build.0 = Release|unreal
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|wasm.ActiveCfg = Debug|wasm
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|wasm.Build.0 = Debug|wasm
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|wasm.ActiveCfg = Release|wasm
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|wasm.Build.0 = Release|wasm
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|winaot.ActiveCfg = Debug|winaot
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|winaot.Build.0 = Debug|winaot
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|winaot.ActiveCfg = Release|winaot
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|winaot.Build.0 = Release|winaot
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|xammac.ActiveCfg = Debug|xammac
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Debug|xammac.Build.0 = Debug|xammac
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|xammac.ActiveCfg = Release|xammac
{AC3AC4DA-7C10-4AE9-A131-6DBBE61432E3}.Release|xammac.Build.0 = Release|xammac
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Debug|net_4_x.Build.0 = Debug|net_4_x
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Release|net_4_x.ActiveCfg = Release|net_4_x
@@ -4096,10 +4078,8 @@ Global
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Debug|unreal.Build.0 = Debug|unreal
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Release|unreal.ActiveCfg = Release|unreal
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Release|unreal.Build.0 = Release|unreal
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Debug|wasm.ActiveCfg = Debug|wasm
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Debug|wasm.Build.0 = Debug|wasm
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Release|wasm.ActiveCfg = Release|wasm
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Release|wasm.Build.0 = Release|wasm
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Debug|wasm.ActiveCfg = Debug|net_4_x
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Release|wasm.ActiveCfg = Release|net_4_x
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Debug|winaot.ActiveCfg = Debug|winaot
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Debug|winaot.Build.0 = Debug|winaot
{7C660E7A-C89B-4ACA-9458-492B6D14B168}.Release|winaot.ActiveCfg = Release|winaot
@@ -4220,10 +4200,8 @@ Global
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Debug|unreal.Build.0 = Debug|unreal
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Release|unreal.ActiveCfg = Release|unreal
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Release|unreal.Build.0 = Release|unreal
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Debug|wasm.ActiveCfg = Debug|wasm
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Debug|wasm.Build.0 = Debug|wasm
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Release|wasm.ActiveCfg = Release|wasm
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Release|wasm.Build.0 = Release|wasm
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Debug|wasm.ActiveCfg = Debug|net_4_x
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Release|wasm.ActiveCfg = Release|net_4_x
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Debug|winaot.ActiveCfg = Debug|winaot
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Debug|winaot.Build.0 = Debug|winaot
{7B3EB110-1E57-4CA0-B65B-DB51B7F95D4D}.Release|winaot.ActiveCfg = Release|winaot
@@ -4260,10 +4238,8 @@ Global
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Debug|unreal.Build.0 = Debug|unreal
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Release|unreal.ActiveCfg = Release|unreal
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Release|unreal.Build.0 = Release|unreal
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Debug|wasm.ActiveCfg = Debug|wasm
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Debug|wasm.Build.0 = Debug|wasm
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Release|wasm.ActiveCfg = Release|wasm
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Release|wasm.Build.0 = Release|wasm
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Debug|wasm.ActiveCfg = Debug|net_4_x
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Release|wasm.ActiveCfg = Release|net_4_x
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Debug|winaot.ActiveCfg = Debug|winaot
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Debug|winaot.Build.0 = Debug|winaot
{E161C076-8631-4D5D-96BD-2B2FB2CEE76D}.Release|winaot.ActiveCfg = Release|winaot
@@ -4520,10 +4496,8 @@ Global
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Debug|unreal.Build.0 = Debug|unreal
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Release|unreal.ActiveCfg = Release|unreal
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Release|unreal.Build.0 = Release|unreal
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Debug|wasm.ActiveCfg = Debug|wasm
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Debug|wasm.Build.0 = Debug|wasm
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Release|wasm.ActiveCfg = Release|wasm
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Release|wasm.Build.0 = Release|wasm
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Debug|wasm.ActiveCfg = Debug|net_4_x
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Release|wasm.ActiveCfg = Release|net_4_x
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Debug|winaot.ActiveCfg = Debug|winaot
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Debug|winaot.Build.0 = Debug|winaot
{0F4B1E4B-86CA-43CE-B773-BD942E71B990}.Release|winaot.ActiveCfg = Release|winaot
@@ -4770,86 +4744,6 @@ Global
{86E2C258-C0D8-48D0-BA76-0280A981CEE0}.Release|winaot.ActiveCfg = Release|net_4_x
{86E2C258-C0D8-48D0-BA76-0280A981CEE0}.Debug|xammac.ActiveCfg = Debug|net_4_x
{86E2C258-C0D8-48D0-BA76-0280A981CEE0}.Release|xammac.ActiveCfg = Release|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|net_4_x.Build.0 = Debug|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|net_4_x.ActiveCfg = Release|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|net_4_x.Build.0 = Release|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monodroid.ActiveCfg = Debug|monodroid
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monodroid.Build.0 = Debug|monodroid
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monodroid.ActiveCfg = Release|monodroid
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monodroid.Build.0 = Release|monodroid
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch.ActiveCfg = Debug|monotouch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch.Build.0 = Debug|monotouch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch.ActiveCfg = Release|monotouch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch.Build.0 = Release|monotouch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch_tv.ActiveCfg = Debug|monotouch_tv
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch_tv.Build.0 = Debug|monotouch_tv
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch_tv.ActiveCfg = Release|monotouch_tv
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch_tv.Build.0 = Release|monotouch_tv
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch_watch.ActiveCfg = Debug|monotouch_watch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch_watch.Build.0 = Debug|monotouch_watch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch_watch.ActiveCfg = Release|monotouch_watch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch_watch.Build.0 = Release|monotouch_watch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|orbis.ActiveCfg = Debug|orbis
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|orbis.Build.0 = Debug|orbis
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|orbis.ActiveCfg = Release|orbis
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|orbis.Build.0 = Release|orbis
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|unreal.ActiveCfg = Debug|unreal
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|unreal.Build.0 = Debug|unreal
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|unreal.ActiveCfg = Release|unreal
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|unreal.Build.0 = Release|unreal
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|wasm.ActiveCfg = Debug|wasm
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|wasm.Build.0 = Debug|wasm
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|wasm.ActiveCfg = Release|wasm
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|wasm.Build.0 = Release|wasm
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|winaot.ActiveCfg = Debug|winaot
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|winaot.Build.0 = Debug|winaot
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|winaot.ActiveCfg = Release|winaot
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|winaot.Build.0 = Release|winaot
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|xammac.ActiveCfg = Debug|xammac
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|xammac.Build.0 = Debug|xammac
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|xammac.ActiveCfg = Release|xammac
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|xammac.Build.0 = Release|xammac
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|net_4_x.Build.0 = Debug|net_4_x
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|net_4_x.ActiveCfg = Release|net_4_x
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|net_4_x.Build.0 = Release|net_4_x
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monodroid.ActiveCfg = Debug|monodroid
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monodroid.Build.0 = Debug|monodroid
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monodroid.ActiveCfg = Release|monodroid
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monodroid.Build.0 = Release|monodroid
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch.ActiveCfg = Debug|monotouch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch.Build.0 = Debug|monotouch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch.ActiveCfg = Release|monotouch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch.Build.0 = Release|monotouch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch_tv.ActiveCfg = Debug|monotouch_tv
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch_tv.Build.0 = Debug|monotouch_tv
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch_tv.ActiveCfg = Release|monotouch_tv
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch_tv.Build.0 = Release|monotouch_tv
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch_watch.ActiveCfg = Debug|monotouch_watch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch_watch.Build.0 = Debug|monotouch_watch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch_watch.ActiveCfg = Release|monotouch_watch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch_watch.Build.0 = Release|monotouch_watch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|orbis.ActiveCfg = Debug|orbis
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|orbis.Build.0 = Debug|orbis
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|orbis.ActiveCfg = Release|orbis
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|orbis.Build.0 = Release|orbis
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|unreal.ActiveCfg = Debug|unreal
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|unreal.Build.0 = Debug|unreal
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|unreal.ActiveCfg = Release|unreal
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|unreal.Build.0 = Release|unreal
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|wasm.ActiveCfg = Debug|wasm
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|wasm.Build.0 = Debug|wasm
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|wasm.ActiveCfg = Release|wasm
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|wasm.Build.0 = Release|wasm
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|winaot.ActiveCfg = Debug|winaot
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|winaot.Build.0 = Debug|winaot
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|winaot.ActiveCfg = Release|winaot
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|winaot.Build.0 = Release|winaot
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|xammac.ActiveCfg = Debug|xammac
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|xammac.Build.0 = Debug|xammac
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|xammac.ActiveCfg = Release|xammac
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|xammac.Build.0 = Release|xammac
{DE0D7286-1F09-4ACC-BC43-75342349FFC1}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{DE0D7286-1F09-4ACC-BC43-75342349FFC1}.Debug|net_4_x.Build.0 = Debug|net_4_x
{DE0D7286-1F09-4ACC-BC43-75342349FFC1}.Release|net_4_x.ActiveCfg = Release|net_4_x
@@ -6118,10 +6012,8 @@ Global
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Debug|unreal.Build.0 = Debug|unreal
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Release|unreal.ActiveCfg = Release|unreal
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Release|unreal.Build.0 = Release|unreal
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Debug|wasm.ActiveCfg = Debug|wasm
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Debug|wasm.Build.0 = Debug|wasm
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Release|wasm.ActiveCfg = Release|wasm
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Release|wasm.Build.0 = Release|wasm
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Debug|wasm.ActiveCfg = Debug|net_4_x
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Release|wasm.ActiveCfg = Release|net_4_x
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Debug|winaot.ActiveCfg = Debug|winaot
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Debug|winaot.Build.0 = Debug|winaot
{7D51E040-A2D0-4F86-9B1F-C010AB99396B}.Release|winaot.ActiveCfg = Release|winaot
@@ -6158,10 +6050,8 @@ Global
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Debug|unreal.Build.0 = Debug|unreal
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Release|unreal.ActiveCfg = Release|unreal
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Release|unreal.Build.0 = Release|unreal
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Debug|wasm.ActiveCfg = Debug|wasm
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Debug|wasm.Build.0 = Debug|wasm
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Release|wasm.ActiveCfg = Release|wasm
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Release|wasm.Build.0 = Release|wasm
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Debug|wasm.ActiveCfg = Debug|net_4_x
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Release|wasm.ActiveCfg = Release|net_4_x
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Debug|winaot.ActiveCfg = Debug|winaot
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Debug|winaot.Build.0 = Debug|winaot
{6E922C6D-E914-45AD-A5E0-4DCC6CB8C469}.Release|winaot.ActiveCfg = Release|winaot
@@ -6638,10 +6528,8 @@ Global
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Debug|unreal.Build.0 = Debug|unreal
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Release|unreal.ActiveCfg = Release|unreal
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Release|unreal.Build.0 = Release|unreal
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Debug|wasm.ActiveCfg = Debug|wasm
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Debug|wasm.Build.0 = Debug|wasm
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Release|wasm.ActiveCfg = Release|wasm
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Release|wasm.Build.0 = Release|wasm
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Debug|wasm.ActiveCfg = Debug|net_4_x
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Release|wasm.ActiveCfg = Release|net_4_x
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Debug|winaot.ActiveCfg = Debug|winaot
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Debug|winaot.Build.0 = Debug|winaot
{7EC5DC98-75BE-44FB-9D99-056044EC18BD}.Release|winaot.ActiveCfg = Release|winaot
@@ -6678,10 +6566,8 @@ Global
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Debug|unreal.Build.0 = Debug|unreal
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Release|unreal.ActiveCfg = Release|unreal
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Release|unreal.Build.0 = Release|unreal
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Debug|wasm.ActiveCfg = Debug|wasm
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Debug|wasm.Build.0 = Debug|wasm
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Release|wasm.ActiveCfg = Release|wasm
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Release|wasm.Build.0 = Release|wasm
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Debug|wasm.ActiveCfg = Debug|net_4_x
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Release|wasm.ActiveCfg = Release|net_4_x
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Debug|winaot.ActiveCfg = Debug|winaot
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Debug|winaot.Build.0 = Debug|winaot
{7B87655B-F9BB-48FB-88FF-CB92582C4F89}.Release|winaot.ActiveCfg = Release|winaot
@@ -9958,10 +9844,8 @@ Global
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Debug|unreal.Build.0 = Debug|unreal
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Release|unreal.ActiveCfg = Release|unreal
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Release|unreal.Build.0 = Release|unreal
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Debug|wasm.ActiveCfg = Debug|wasm
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Debug|wasm.Build.0 = Debug|wasm
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Release|wasm.ActiveCfg = Release|wasm
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Release|wasm.Build.0 = Release|wasm
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Debug|wasm.ActiveCfg = Debug|net_4_x
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Release|wasm.ActiveCfg = Release|net_4_x
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Debug|winaot.ActiveCfg = Debug|winaot
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Debug|winaot.Build.0 = Debug|winaot
{4F62F70F-FD2B-45E5-8A62-9ABFB6A29FC5}.Release|winaot.ActiveCfg = Release|winaot
@@ -10090,6 +9974,86 @@ Global
{942F9B7C-3245-4F5A-A4ED-140013DCCE2C}.Debug|xammac.Build.0 = Debug|xammac
{942F9B7C-3245-4F5A-A4ED-140013DCCE2C}.Release|xammac.ActiveCfg = Release|xammac
{942F9B7C-3245-4F5A-A4ED-140013DCCE2C}.Release|xammac.Build.0 = Release|xammac
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|net_4_x.Build.0 = Debug|net_4_x
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|net_4_x.ActiveCfg = Release|net_4_x
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|net_4_x.Build.0 = Release|net_4_x
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monodroid.ActiveCfg = Debug|monodroid
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monodroid.Build.0 = Debug|monodroid
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monodroid.ActiveCfg = Release|monodroid
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monodroid.Build.0 = Release|monodroid
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch.ActiveCfg = Debug|monotouch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch.Build.0 = Debug|monotouch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch.ActiveCfg = Release|monotouch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch.Build.0 = Release|monotouch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch_tv.ActiveCfg = Debug|monotouch_tv
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch_tv.Build.0 = Debug|monotouch_tv
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch_tv.ActiveCfg = Release|monotouch_tv
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch_tv.Build.0 = Release|monotouch_tv
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch_watch.ActiveCfg = Debug|monotouch_watch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|monotouch_watch.Build.0 = Debug|monotouch_watch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch_watch.ActiveCfg = Release|monotouch_watch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|monotouch_watch.Build.0 = Release|monotouch_watch
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|orbis.ActiveCfg = Debug|orbis
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|orbis.Build.0 = Debug|orbis
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|orbis.ActiveCfg = Release|orbis
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|orbis.Build.0 = Release|orbis
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|unreal.ActiveCfg = Debug|unreal
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|unreal.Build.0 = Debug|unreal
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|unreal.ActiveCfg = Release|unreal
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|unreal.Build.0 = Release|unreal
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|wasm.ActiveCfg = Debug|wasm
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|wasm.Build.0 = Debug|wasm
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|wasm.ActiveCfg = Release|wasm
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|wasm.Build.0 = Release|wasm
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|winaot.ActiveCfg = Debug|winaot
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|winaot.Build.0 = Debug|winaot
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|winaot.ActiveCfg = Release|winaot
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|winaot.Build.0 = Release|winaot
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|xammac.ActiveCfg = Debug|xammac
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Debug|xammac.Build.0 = Debug|xammac
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|xammac.ActiveCfg = Release|xammac
{E4596A34-AFBC-4744-8352-E6996AC34C16}.Release|xammac.Build.0 = Release|xammac
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|net_4_x.Build.0 = Debug|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|net_4_x.ActiveCfg = Release|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|net_4_x.Build.0 = Release|net_4_x
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monodroid.ActiveCfg = Debug|monodroid
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monodroid.Build.0 = Debug|monodroid
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monodroid.ActiveCfg = Release|monodroid
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monodroid.Build.0 = Release|monodroid
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch.ActiveCfg = Debug|monotouch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch.Build.0 = Debug|monotouch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch.ActiveCfg = Release|monotouch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch.Build.0 = Release|monotouch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch_tv.ActiveCfg = Debug|monotouch_tv
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch_tv.Build.0 = Debug|monotouch_tv
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch_tv.ActiveCfg = Release|monotouch_tv
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch_tv.Build.0 = Release|monotouch_tv
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch_watch.ActiveCfg = Debug|monotouch_watch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|monotouch_watch.Build.0 = Debug|monotouch_watch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch_watch.ActiveCfg = Release|monotouch_watch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|monotouch_watch.Build.0 = Release|monotouch_watch
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|orbis.ActiveCfg = Debug|orbis
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|orbis.Build.0 = Debug|orbis
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|orbis.ActiveCfg = Release|orbis
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|orbis.Build.0 = Release|orbis
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|unreal.ActiveCfg = Debug|unreal
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|unreal.Build.0 = Debug|unreal
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|unreal.ActiveCfg = Release|unreal
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|unreal.Build.0 = Release|unreal
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|wasm.ActiveCfg = Debug|wasm
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|wasm.Build.0 = Debug|wasm
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|wasm.ActiveCfg = Release|wasm
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|wasm.Build.0 = Release|wasm
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|winaot.ActiveCfg = Debug|winaot
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|winaot.Build.0 = Debug|winaot
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|winaot.ActiveCfg = Release|winaot
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|winaot.Build.0 = Release|winaot
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|xammac.ActiveCfg = Debug|xammac
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Debug|xammac.Build.0 = Debug|xammac
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|xammac.ActiveCfg = Release|xammac
{1961C6D4-5B4D-4D82-A9AF-C6134D346B63}.Release|xammac.Build.0 = Release|xammac
{786AAD60-DBEA-4F9B-BF1B-C3486CE000D0}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{786AAD60-DBEA-4F9B-BF1B-C3486CE000D0}.Debug|net_4_x.Build.0 = Debug|net_4_x
{786AAD60-DBEA-4F9B-BF1B-C3486CE000D0}.Release|net_4_x.ActiveCfg = Release|net_4_x
@@ -10112,204 +10076,6 @@ Global
{786AAD60-DBEA-4F9B-BF1B-C3486CE000D0}.Release|winaot.ActiveCfg = Release|net_4_x
{786AAD60-DBEA-4F9B-BF1B-C3486CE000D0}.Debug|xammac.ActiveCfg = Debug|net_4_x
{786AAD60-DBEA-4F9B-BF1B-C3486CE000D0}.Release|xammac.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|net_4_x.Build.0 = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|net_4_x.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|net_4_x.Build.0 = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|monodroid.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|monotouch.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|orbis.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|orbis.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|unreal.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|unreal.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|wasm.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|wasm.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|winaot.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|winaot.ActiveCfg = Release|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Debug|xammac.ActiveCfg = Debug|net_4_x
{5A1007E5-0FDA-42F5-98AC-D61E11C4B3AB}.Release|xammac.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|net_4_x.Build.0 = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|net_4_x.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|net_4_x.Build.0 = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|monodroid.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|monotouch.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|orbis.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|orbis.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|unreal.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|unreal.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|wasm.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|wasm.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|winaot.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|winaot.ActiveCfg = Release|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Debug|xammac.ActiveCfg = Debug|net_4_x
{9B6CBD42-1AA3-40FA-A8B3-80C63EA47A02}.Release|xammac.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|net_4_x.Build.0 = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|net_4_x.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|net_4_x.Build.0 = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|monodroid.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|monotouch.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|orbis.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|orbis.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|unreal.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|unreal.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|wasm.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|wasm.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|winaot.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|winaot.ActiveCfg = Release|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Debug|xammac.ActiveCfg = Debug|net_4_x
{559F5BCC-3235-494A-9D86-4F26F67F9E40}.Release|xammac.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|net_4_x.Build.0 = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|net_4_x.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|net_4_x.Build.0 = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|monodroid.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|monotouch.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|orbis.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|orbis.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|unreal.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|unreal.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|wasm.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|wasm.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|winaot.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|winaot.ActiveCfg = Release|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Debug|xammac.ActiveCfg = Debug|net_4_x
{8F75DF82-CC9B-44A0-97CC-8ED180AFF6EF}.Release|xammac.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|net_4_x.Build.0 = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|net_4_x.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|net_4_x.Build.0 = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|monodroid.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|monotouch.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|orbis.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|orbis.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|unreal.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|unreal.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|wasm.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|wasm.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|winaot.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|winaot.ActiveCfg = Release|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Debug|xammac.ActiveCfg = Debug|net_4_x
{94A88112-9E7E-45FA-A3FF-ACF8E1DF0FCB}.Release|xammac.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|net_4_x.Build.0 = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|net_4_x.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|net_4_x.Build.0 = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|monodroid.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|monotouch.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|orbis.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|orbis.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|unreal.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|unreal.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|wasm.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|wasm.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|winaot.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|winaot.ActiveCfg = Release|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Debug|xammac.ActiveCfg = Debug|net_4_x
{DFE253AA-843E-4374-B862-9F0B7414CB8C}.Release|xammac.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|net_4_x.Build.0 = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|net_4_x.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|net_4_x.Build.0 = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|monodroid.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|monotouch.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|orbis.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|orbis.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|unreal.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|unreal.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|wasm.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|wasm.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|winaot.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|winaot.ActiveCfg = Release|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Debug|xammac.ActiveCfg = Debug|net_4_x
{6464D30A-2B8E-458D-B96A-2ECDE947B58B}.Release|xammac.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|net_4_x.Build.0 = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|net_4_x.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|net_4_x.Build.0 = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|monodroid.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|monotouch.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|orbis.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|orbis.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|unreal.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|unreal.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|wasm.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|wasm.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|winaot.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|winaot.ActiveCfg = Release|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Debug|xammac.ActiveCfg = Debug|net_4_x
{F0B8A9C7-8D0D-4629-B730-CFCB17C4BB2D}.Release|xammac.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|net_4_x.Build.0 = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|net_4_x.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|net_4_x.Build.0 = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|monodroid.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|monotouch.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|orbis.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|orbis.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|unreal.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|unreal.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|wasm.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|wasm.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|winaot.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|winaot.ActiveCfg = Release|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Debug|xammac.ActiveCfg = Debug|net_4_x
{2D845BF5-42C7-41D3-AC01-F63980F76B22}.Release|xammac.ActiveCfg = Release|net_4_x
{C02B3C37-DB98-40A5-84F0-F98633DA7EE4}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{C02B3C37-DB98-40A5-84F0-F98633DA7EE4}.Debug|net_4_x.Build.0 = Debug|net_4_x
{C02B3C37-DB98-40A5-84F0-F98633DA7EE4}.Release|net_4_x.ActiveCfg = Release|net_4_x
@@ -10354,6 +10120,28 @@ Global
{0A20671F-CCA9-457D-886C-0828C7D64128}.Release|winaot.ActiveCfg = Release|net_4_x
{0A20671F-CCA9-457D-886C-0828C7D64128}.Debug|xammac.ActiveCfg = Debug|net_4_x
{0A20671F-CCA9-457D-886C-0828C7D64128}.Release|xammac.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|net_4_x.Build.0 = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|net_4_x.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|net_4_x.Build.0 = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|monodroid.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|monodroid.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|monotouch.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|monotouch.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|monotouch_tv.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|monotouch_tv.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|monotouch_watch.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|monotouch_watch.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|orbis.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|orbis.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|unreal.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|unreal.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|wasm.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|wasm.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|winaot.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|winaot.ActiveCfg = Release|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Debug|xammac.ActiveCfg = Debug|net_4_x
{658B566B-CED1-4C42-9926-C1AA930BA368}.Release|xammac.ActiveCfg = Release|net_4_x
{D60432F1-3C12-4235-A1CC-4CA5575403BD}.Debug|net_4_x.ActiveCfg = Debug|net_4_x
{D60432F1-3C12-4235-A1CC-4CA5575403BD}.Debug|net_4_x.Build.0 = Debug|net_4_x
{D60432F1-3C12-4235-A1CC-4CA5575403BD}.Release|net_4_x.ActiveCfg = Release|net_4_x
+1653 -337
View File
File diff suppressed because it is too large. Load diff
+3 -3
View File
@@ -7,7 +7,7 @@ EXTRA_DIST = \
config.in \
browscap.ini mono.supp mono.d README \
mono.pc.in mono-2.pc.in monosgen-2.pc.in mint.pc.in dotnet.pc.in dotnet35.pc.in wcf.pc.in monodoc.pc.in \
mono-nunit.pc.in mono-cairo.pc.in mono-options.pc.in cecil.pc.in \
mono-cairo.pc.in mono-options.pc.in cecil.pc.in \
mono-lineeditor.pc.in system.web.extensions_1.0.pc.in system.web.extensions.design_1.0.pc.in\
dtrace-prelink.sh system.web.mvc.pc.in system.web.mvc2.pc.in system.web.mvc3.pc.in aspnetwebstack.pc.in \
reactive.pc.in xbuild12.pc \
@@ -25,10 +25,10 @@ else
SGENPCFILE=
endif
pkgconfig_DATA= mono.pc mono-2.pc dotnet.pc dotnet35.pc wcf.pc mono-nunit.pc mono-cairo.pc mono-options.pc cecil.pc monodoc.pc mono-lineeditor.pc system.web.extensions_1.0.pc \
pkgconfig_DATA= mono.pc mono-2.pc dotnet.pc dotnet35.pc wcf.pc mono-cairo.pc mono-options.pc cecil.pc monodoc.pc mono-lineeditor.pc system.web.extensions_1.0.pc \
system.web.extensions.design_1.0.pc system.web.mvc.pc system.web.mvc2.pc system.web.mvc3.pc aspnetwebstack.pc reactive.pc xbuild12.pc $(SGENPCFILE)
DISTCLEANFILES= mono-2.pc mono.pc mint.pc dotnet.pc dotnet35.pc wcf.pc mono-nunit.pc mono-cairo.pc mono-options.pc cecil.pc monodoc.pc mono-lineeditor.pc system.web.extensions_1.0.pc \
DISTCLEANFILES= mono-2.pc mono.pc mint.pc dotnet.pc dotnet35.pc wcf.pc mono-cairo.pc mono-options.pc cecil.pc monodoc.pc mono-lineeditor.pc system.web.extensions_1.0.pc \
system.web.extensions.design_1.0.pc system.web.mvc.pc system.web.mvc2.pc system.web.mvc3.pc aspnetwebstack.pc reactive.pc $(SGENPCFILE) mono-sgen-gdb.py
mono_DATA = config \
+4 -3
View File
@@ -6,13 +6,14 @@
<dllmap dll="libintl" name="bind_textdomain_codeset" target="@LIBC@" os="solaris"/>
<dllmap dll="libintl" target="@INTL@" os="!windows"/>
<dllmap dll="i:libxslt.dll" target="libxslt@libsuffix@" os="!windows"/>
<dllmap dll="i:odbc32.dll" target="libodbc@libsuffix@" os="!windows"/>
<dllmap dll="i:odbc32.dll" target="@ODBC@" os="!windows"/>
<dllmap dll="i:odbc32.dll" target="libiodbc.dylib" os="osx"/>
<dllmap dll="oci" target="libclntsh@libsuffix@" os="!windows"/>
<dllmap dll="db2cli" target="libdb2_36@libsuffix@" os="!windows"/>
<dllmap dll="MonoPosixHelper" target="$mono_libdir/libMonoPosixHelper@libsuffix@" os="!windows" />
<dllmap dll="System.Native" target="$mono_libdir/libmono-system-native@libsuffix@" os="!windows" />
<dllmap dll="System.Net.Security.Native" target="$mono_libdir/libmono-system-net-security-native@libsuffix@" os="!windows" />
<dllmap dll="System.Native" target="$mono_libdir/@MONO_NATIVE_LIBRARY_NAME@@libsuffix@" os="!windows" />
<dllmap dll="System.Net.Security.Native" target="$mono_libdir/@MONO_NATIVE_LIBRARY_NAME@@libsuffix@" os="!windows" />
<dllmap dll="System.Security.Cryptography.Native.Apple" target="$mono_libdir/@MONO_NATIVE_LIBRARY_NAME@@libsuffix@" os="osx" />
<dllmap dll="libmono-btls-shared" target="$mono_libdir/libmono-btls-shared@libsuffix@" os="!windows" />
<dllmap dll="i:msvcrt" target="@LIBC@" os="!windows"/>
<dllmap dll="i:msvcrt.dll" target="@LIBC@" os="!windows"/>
Regular → Executable
View File
File mode changed.
+13 -13
View File
@@ -1,8 +1,9 @@
import lldb
import traceback
def print_frames(thread, num_frames, current_thread):
# TODO: Make output header similar to bt.
print '%c thread #%i' % ('*' if current_thread else ' ', thread.idx)
print('%c thread #%i' % ('*' if current_thread else ' ', thread.idx))
if current_thread:
selected_frame = thread.GetSelectedFrame()
@@ -14,17 +15,16 @@ def print_frames(thread, num_frames, current_thread):
if function_name == "interp_exec_method_full":
try:
s = 'frame->imethod->method'
klassname = frame.EvaluateExpression('(char*) ' + s + '->klass->name').summary[1:-1]
methodname = frame.EvaluateExpression('(char*) ' + s + '->name').summary[1:-1]
methoddesc = frame.EvaluateExpression('(char*) mono_method_full_name (' + s + ', 1)').summary[1:-1]
ipoffset = frame.EvaluateExpression('ip').GetValueAsUnsigned()
insn = ''
if ipoffset != 0:
ipoffset -= frame.EvaluateExpression('rtm->code').GetValueAsUnsigned()
insn = "\"" + frame.EvaluateExpression('mono_interp_opname [*ip]').summary[1:-1] + "\""
var = '%s::%s @ %d %s || %s' % (klassname, methodname, ipoffset, insn, frame)
ipoffset -= frame.EvaluateExpression('frame->imethod->code').GetValueAsUnsigned()
insn = "\"" + frame.EvaluateExpression('mono_interp_opname (*ip)').summary[1:-1] + "\""
var = '%s @ %d %s || %s' % (methoddesc, ipoffset, insn, frame)
except Exception as e:
print "DBG: execfail:" + str(e)
traceback.print_exc()
elif function_name == "mono_interp_transform_method":
try:
s = 'runtime_method->method'
@@ -32,7 +32,7 @@ def print_frames(thread, num_frames, current_thread):
methodname = frame.EvaluateExpression('(char*) ' + s + '->name').summary[1:-1]
var = 'transforming %s::%s || %s' % (klassname, methodname, frame)
except Exception as e:
print "DBG: transformfail:" + str(e)
print("DBG: transformfail:" + str(e))
elif pc[0] == '0':
try:
framestr = frame.EvaluateExpression('(char*)mono_pmip((void*)%s)' % pc).summary[1:-1]
@@ -40,7 +40,7 @@ def print_frames(thread, num_frames, current_thread):
except:
pass
print ' %c %s' % ('*' if current_thread and frame.idx == selected_frame.idx else ' ', var)
print(' %c %s' % ('*' if current_thread and frame.idx == selected_frame.idx else ' ', var))
def monobt(debugger, command, result, dict):
opts = {'all_bt': False, 'num_frames': None}
@@ -50,20 +50,20 @@ def monobt(debugger, command, result, dict):
elif command.isdigit():
opts['num_frames'] = int(command)
elif command != '':
print 'error: monobt [<number>|all]'
print('error: monobt [<number>|all]')
return
target = debugger.GetSelectedTarget()
process = target.process
if not process.IsValid():
print 'error: invalid process'
print('error: invalid process')
return
if opts['all_bt']:
for thread in process.threads:
print_frames(thread, len(thread), process.selected_thread == thread)
print ''
print('')
else:
thread = process.selected_thread
num_frames = len(thread) if opts['num_frames'] is None else opts['num_frames']
@@ -76,4 +76,4 @@ def __lldb_init_module (debugger, dict):
# Add any commands contained in this module to LLDB
debugger.HandleCommand('command script add -f monobt.monobt monobt')
debugger.HandleCommand('command alias mbt monobt')
print '"monobt" command installed'
print('"monobt" command installed')
-9
View File
@@ -1,9 +0,0 @@
prefix=${pcfiledir}/../..
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
Name: Mono NUnit
Description: Mono's version of NUnit
Version: @VERSION@
Libs: -r:${libdir}/mono/4.5/nunit.core.dll -r:${libdir}/mono/4.5/nunit.core.interfaces.dll -r:${libdir}/mono/4.5/nunit.core.extensions.dll -r:${libdir}/mono/4.5/nunit.framework.dll -r:${libdir}/mono/4.5/nunit.framework.extensions.dll -r:${libdir}/mono/4.5/nunit.mocks.dll -r:${libdir}/mono/4.5/nunit.util.dll -r:${libdir}/mono/4.5/nunit-console-runner.dll
+3 -2
View File
@@ -52,7 +52,8 @@ EXTRA_DIST = \
-include $(mcs_topdir)/build/config.make
CLASS=$(mcs_topdir)/class/lib/$(DEFAULT_PROFILE)
DOC_PROFILE:=net_4_x
CLASS=$(mcs_topdir)/class/lib/$(DOC_PROFILE)
dist-hook:
$(mkdir_p) $(distdir)/sources
@@ -68,7 +69,7 @@ clean-local:
-rm -f deploy/* convert.exe* AgilityPack.dll*
-rm -f $(ASSEMBLED_DOCS)
TOOL_MAKE=$(MAKE) -f $(srcdir)/docs.make topdir=$(srcdir)/../mcs srcdir=$(srcdir)
TOOL_MAKE=$(MAKE) -f $(srcdir)/docs.make topdir=$(srcdir)/../mcs srcdir=$(srcdir) PROFILE=$(DOC_PROFILE)
monoapi.zip: monoapi.tree
+23
View File
@@ -18,6 +18,27 @@ convert.exe: $(srcdir)/convert.cs AgilityPack.dll
AgilityPack.dll:
$(CSCOMPILE) -r:$(topdir)/class/lib/$(PROFILE)/mscorlib.dll -r:$(topdir)/class/lib/$(PROFILE)/System.dll -r:$(topdir)/class/lib/$(PROFILE)/System.Xml.dll -target:library -out:$@ $(srcdir)/HtmlAgilityPack/*.cs
ifdef MCS_MODE
monoapi.zip:
touch $@
monoapi.tree: monoapi.zip
touch $@
mono-tools.zip:
touch $@
mono-tools.tree: mono-tools.zip
touch $@
mono-file-formats.zip:
touch $@
mono-file-formats.tree: mono-file-formats.zip
touch $@
else
monoapi.zip: monoapi.tree
@test -f $@ || { rm -f $< && $(MAKE) $<; }
@@ -36,5 +57,7 @@ mono-file-formats.zip: mono-file-formats.tree
mono-file-formats.tree: $(srcdir)/mono-file-formats.config $(srcdir)/docs.make
$(MDOC) assemble -o mono-file-formats -f man $<
endif
.doc-stamp:
+138
View File
@@ -0,0 +1,138 @@
# Mono RISC-V Port
These are some useful links and notes pertaining to the RISC-V port of Mono.
## Useful RISC-V documentation
* [RISC-V User-Level ISA Specification](https://riscv.org/specifications)
* [RISC-V Privileged ISA Specification](https://riscv.org/specifications/privileged-isa)
* [RISC-V Debug Specification](https://riscv.org/specifications/debug-specification)
* [RISC-V ELF psABI Specification](https://github.com/riscv/riscv-elf-psabi-doc)
* [RISC-V C API Specification](https://github.com/riscv/riscv-c-api-doc)
* [RISC-V Toolchain Conventions](https://github.com/riscv/riscv-toolchain-conventions)
* [RISC-V Assembly Programmer's Manual](https://github.com/riscv/riscv-asm-manual)
## Useful RISC-V repositories
* [RISC-V Organization](https://github.com/riscv)
* [RISC-V GNU Toolchain](https://github.com/riscv/riscv-gnu-toolchain)
* [RISC-V Binutils](https://github.com/riscv/riscv-binutils-gdb)
* [RISC-V GCC](https://github.com/riscv/riscv-gcc)
* [RISC-V Glibc](https://github.com/riscv/riscv-glibc)
* [RISC-V Newlib](https://github.com/riscv/riscv-newlib)
* [RISC-V Tools](https://github.com/riscv/riscv-tools)
* [RISC-V Opcodes](https://github.com/riscv/riscv-opcodes)
* [RISC-V Tests](https://github.com/riscv/riscv-tests)
## Setting up a cross environment
### Debian/Ubuntu packages
This is the most painless way of getting a functional toolchain installed. Note
that these packages may not be available on older distributions; this is tested
on Ubuntu 19.04.
First, add this to your `$HOME/.bashrc` (or some other script that you run):
```bash
export RISCV=$HOME/riscv
export PATH=$RISCV/bin:$PATH
export QEMU_LD_PREFIX=/usr/riscv64-linux-gnu
```
Next, install the toolchain packages like so:
```bash
# apt install autoconf automake binutils-riscv64-linux-gnu build-essential gcc-riscv64-linux-gnu gdb-multiarch g++-riscv64-linux-gnu libtool qemu qemu-system-misc qemu-user qemu-user-static
```
You will now have all the toolchain binaries in `/usr/bin`.
### Building manually
This approach may be somewhat unstable since you will be using the latest
versions of the various parts of the toolchain.
First, add this to your `$HOME/.bashrc` (or some other script that you run):
```bash
export RISCV=$HOME/riscv
export PATH=$RISCV/bin:$PATH
export QEMU_LD_PREFIX=$RISCV/sysroot
```
Next, install some dependencies needed to build the toolchain:
```console
# apt install autoconf automake autotools-dev curl libmpc-dev libmpfr-dev libgmp-dev gawk build-essential bison flex texinfo gperf libtool patchutils bc zlib1g-dev libexpat-dev
```
Finally, build the toolchain:
```console
$ git clone --recursive [email protected]:riscv/riscv-gnu-toolchain.git
$ cd riscv-gnu-toolchain
$ ./configure --prefix=$RISCV --enable-linux --enable-multilib --with-arch=rv64imafdc --with-abi=lp64d
$ make linux
```
This will install the built toolchain binaries in `$RISCV/bin`.
## Building Mono with a cross toolchain
Building Mono is quite straightforward:
```console
$ ./autogen.sh --prefix=$RISCV/sysroot --host=riscv64-linux-gnu
$ make
$ make install
```
(Note: You may need to use `--host=riscv64-unknown-linux-gnu` instead if you
built the toolchain manually.)
You can set `CFLAGS` as appropriate to change the RISC-V options, such as which
standard extensions and ABI to use. For example, to use the 64-bit soft float
ABI:
```console
$ CFLAGS="-mabi=lp64" ./autogen.sh --prefix=$RISCV/sysroot --host=riscv64-linux-gnu
```
Note that, since this is a cross build, the `mcs` directory won't be built. You
will have to build the managed libraries and tools through a native build of
Mono and copy them into `$RISCV/sysroot`.
You can run Mono with QEMU like this:
```console
$ qemu-riscv64 ./mono/mini/mono hello.exe
```
## Debugging
Debugging with GDB currently requires a manually built toolchain.
It can be done like so:
```console
$ qemu-riscv64 -g 12345 ./mono/mini/mono --interp basic.exe &
$ riscv64-unknown-elf-gdb -ex 'target remote localhost:12345' -ex 'b main' -ex 'c' ./mono/mini/mono
```
## Things to be done
Things that need to be done beyond the basic 64-bit port, in no particular
order:
* Complete the soft float port.
* Complete the 32-bit port.
* Add unwind info to trampolines.
* Implement AOT support.
* Implement interpreter support.
* Implement LLVM support.
* Implement SDB support.
* Implement `dyn_call` support.
* Ensure all runtime tests pass.
* Ensure all corlib tests pass.
* Set up CI on Jenkins.
+6
View File
@@ -109,6 +109,12 @@ typedef struct {
<h3>Write Barriers</h3>
<p>SGen is a concurrent and generational GC, features which require
tracking changes to the state of the heap. This is achieved through
write barriers. Whenever native code is changing the state of the
heap by storing references into another managed object, it needs to
do it using this write barrier API.
<h4><a name="api:mono_gc_wbarrier_arrayref_copy">mono_gc_wbarrier_arrayref_copy</a></h4>
<h4><a name="api:mono_gc_wbarrier_generic_nostore">mono_gc_wbarrier_generic_nostore</a></h4>
<h4><a name="api:mono_gc_wbarrier_generic_store">mono_gc_wbarrier_generic_store</a></h4>
+27
View File
@@ -0,0 +1,27 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ProductDependencies>
<Dependency Name="Microsoft.Private.CoreFx.NETCoreApp" Version="5.0.0-alpha.1.19563.3">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>5cee7c97d602f294e27c582d4dab81ec388f1d7b</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App" Version="5.0.0-alpha.1.19564.1">
<Uri>https://github.com/dotnet/core-setup</Uri>
<Sha>c77948d92a2f950140f09384f057cb893ec3955a</Sha>
</Dependency>
<Dependency Name="Microsoft.Net.Compilers" Version="3.3.1-beta4-19476-06">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>39d545dc14bc4d5a546e5e2f58d1ebaca72fcd61</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.19567.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>928efaa081ffd17b37f6c662fee44775f2d0b90f</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="5.0.0-beta.19567.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>928efaa081ffd17b37f6c662fee44775f2d0b90f</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
+14
View File
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<VersionPrefix>5.0.0</VersionPrefix>
<PreReleaseVersionLabel>prerelease</PreReleaseVersionLabel>
<!-- Package versions -->
<!-- corefx -->
<MicrosoftPrivateCoreFxNETCoreAppVersion>5.0.0-alpha.1.19563.3</MicrosoftPrivateCoreFxNETCoreAppVersion>
<!-- core-setup -->
<MicrosoftNETCoreAppVersion>5.0.0-alpha.1.19564.1</MicrosoftNETCoreAppVersion>
<!-- roslyn -->
<MicrosoftNetCompilersVersion>3.3.1-beta4-19476-06</MicrosoftNetCompilersVersion>
</PropertyGroup>
</Project>
+2
View File
@@ -0,0 +1,2 @@
@echo off
powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0Build.ps1""" -restore -build -test -sign -pack -publish -ci %*"
+158
View File
@@ -0,0 +1,158 @@
param(
[Parameter(Mandatory=$true)][string] $InputPath, # Full path to directory where NuGet packages to be checked are stored
[Parameter(Mandatory=$true)][string] $ExtractPath, # Full path to directory where the packages will be extracted during validation
[Parameter(Mandatory=$true)][string] $SymbolToolPath # Full path to directory where dotnet symbol-tool was installed
)
Add-Type -AssemblyName System.IO.Compression.FileSystem
function FirstMatchingSymbolDescriptionOrDefault {
param(
[string] $FullPath, # Full path to the module that has to be checked
[string] $TargetServerParam, # Parameter to pass to `Symbol Tool` indicating the server to lookup for symbols
[string] $SymbolsPath
)
$FileName = [System.IO.Path]::GetFileName($FullPath)
$Extension = [System.IO.Path]::GetExtension($FullPath)
# Those below are potential symbol files that the `dotnet symbol` might
# return. Which one will be returned depend on the type of file we are
# checking and which type of file was uploaded.
# The file itself is returned
$SymbolPath = $SymbolsPath + "\" + $FileName
# PDB file for the module
$PdbPath = $SymbolPath.Replace($Extension, ".pdb")
# PDB file for R2R module (created by crossgen)
$NGenPdb = $SymbolPath.Replace($Extension, ".ni.pdb")
# DBG file for a .so library
$SODbg = $SymbolPath.Replace($Extension, ".so.dbg")
# DWARF file for a .dylib
$DylibDwarf = $SymbolPath.Replace($Extension, ".dylib.dwarf")
.\dotnet-symbol.exe --symbols --modules --windows-pdbs $TargetServerParam $FullPath -o $SymbolsPath | Out-Null
if (Test-Path $PdbPath) {
return "PDB"
}
elseif (Test-Path $NGenPdb) {
return "NGen PDB"
}
elseif (Test-Path $SODbg) {
return "DBG for SO"
}
elseif (Test-Path $DylibDwarf) {
return "Dwarf for Dylib"
}
elseif (Test-Path $SymbolPath) {
return "Module"
}
else {
return $null
}
}
function CountMissingSymbols {
param(
[string] $PackagePath # Path to a NuGet package
)
# Ensure input file exist
if (!(Test-Path $PackagePath)) {
throw "Input file does not exist: $PackagePath"
}
# Extensions for which we'll look for symbols
$RelevantExtensions = @(".dll", ".exe", ".so", ".dylib")
# How many files are missing symbol information
$MissingSymbols = 0
$PackageId = [System.IO.Path]::GetFileNameWithoutExtension($PackagePath)
$PackageGuid = New-Guid
$ExtractPath = Join-Path -Path $ExtractPath -ChildPath $PackageGuid
$SymbolsPath = Join-Path -Path $ExtractPath -ChildPath "Symbols"
[System.IO.Compression.ZipFile]::ExtractToDirectory($PackagePath, $ExtractPath)
# Makes easier to reference `symbol tool`
Push-Location $SymbolToolPath
Get-ChildItem -Recurse $ExtractPath |
Where-Object {$RelevantExtensions -contains $_.Extension} |
ForEach-Object {
if ($_.FullName -Match "\\ref\\") {
Write-Host "`t Ignoring reference assembly file" $_.FullName
return
}
$SymbolsOnMSDL = FirstMatchingSymbolDescriptionOrDefault $_.FullName "--microsoft-symbol-server" $SymbolsPath
$SymbolsOnSymWeb = FirstMatchingSymbolDescriptionOrDefault $_.FullName "--internal-server" $SymbolsPath
Write-Host -NoNewLine "`t Checking file" $_.FullName "... "
if ($SymbolsOnMSDL -ne $null -and $SymbolsOnSymWeb -ne $null) {
Write-Host "Symbols found on MSDL (" $SymbolsOnMSDL ") and SymWeb (" $SymbolsOnSymWeb ")"
}
else {
$MissingSymbols++
if ($SymbolsOnMSDL -eq $null -and $SymbolsOnSymWeb -eq $null) {
Write-Host "No symbols found on MSDL or SymWeb!"
}
else {
if ($SymbolsOnMSDL -eq $null) {
Write-Host "No symbols found on MSDL!"
}
else {
Write-Host "No symbols found on SymWeb!"
}
}
}
}
Pop-Location
return $MissingSymbols
}
function CheckSymbolsAvailable {
if (Test-Path $ExtractPath) {
Remove-Item $ExtractPath -Force -Recurse -ErrorAction SilentlyContinue
}
Get-ChildItem "$InputPath\*.nupkg" |
ForEach-Object {
$FileName = $_.Name
# These packages from Arcade-Services include some native libraries that
# our current symbol uploader can't handle. Below is a workaround until
# we get issue: https://github.com/dotnet/arcade/issues/2457 sorted.
if ($FileName -Match "Microsoft\.DotNet\.Darc\.") {
Write-Host "Ignoring Arcade-services file: $FileName"
Write-Host
return
}
elseif ($FileName -Match "Microsoft\.DotNet\.Maestro\.Tasks\.") {
Write-Host "Ignoring Arcade-services file: $FileName"
Write-Host
return
}
Write-Host "Validating $FileName "
$Status = CountMissingSymbols "$InputPath\$FileName"
if ($Status -ne 0) {
Write-Error "Missing symbols for $Status modules in the package $FileName"
}
Write-Host
}
}
CheckSymbolsAvailable
+11
View File
@@ -0,0 +1,11 @@
@{
IncludeRules=@('PSAvoidUsingCmdletAliases',
'PSAvoidUsingWMICmdlet',
'PSAvoidUsingPositionalParameters',
'PSAvoidUsingInvokeExpression',
'PSUseDeclaredVarsMoreThanAssignments',
'PSUseCmdletCorrectly',
'PSStandardDSCFunctionsInResource',
'PSUseIdenticalMandatoryParametersForDSC',
'PSUseIdenticalParametersForDSC')
}
+83
View File
@@ -0,0 +1,83 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<Project Sdk="Microsoft.NET.Sdk">
<!--
This MSBuild file is intended to be used as the body of the default
publishing release pipeline. The release pipeline will use this file
to invoke the PushToStaticFeed task that will read the build asset
manifest and publish the assets described in the manifest to
informed target feeds.
-->
<PropertyGroup>
<TargetFramework>netcoreapp2.1</TargetFramework>
</PropertyGroup>
<Import Project="$(MSBuildThisFileDirectory)DefaultVersions.props" Condition="Exists('$(MSBuildThisFileDirectory)DefaultVersions.props')" />
<!--
This won't be necessary once we solve this issue:
https://github.com/dotnet/arcade/issues/2266
-->
<Import Project="$(MSBuildThisFileDirectory)ArtifactsCategory.props" Condition="Exists('$(MSBuildThisFileDirectory)ArtifactsCategory.props')" />
<Import Project="$(NuGetPackageRoot)microsoft.dotnet.build.tasks.feed\$(MicrosoftDotNetBuildTasksFeedVersion)\build\Microsoft.DotNet.Build.Tasks.Feed.targets" />
<Target Name="PublishToFeed">
<Error Condition="'$(ArtifactsCategory)' == ''" Text="ArtifactsCategory: The artifacts' category produced by the build wasn't provided." />
<Error Condition="'$(AccountKeyToStaticFeed)' == ''" Text="AccountKeyToStaticFeed: Account key for target feed wasn't provided." />
<Error Condition="'$(ManifestsBasePath)' == ''" Text="Full path to asset manifests directory wasn't provided." />
<Error Condition="'$(BlobBasePath)' == '' AND '$(PackageBasePath)' == ''" Text="A valid full path to BlobBasePath of PackageBasePath is required." />
<ItemGroup>
<!-- Include all manifests found in the manifest folder. -->
<ManifestFiles Include="$(ManifestsBasePath)*.xml" />
</ItemGroup>
<Error Condition="'@(ManifestFiles)' == ''" Text="No manifest file was found in the provided path: $(ManifestsBasePath)" />
<!--
For now the type of packages being published will be informed for the whole build.
Eventually this will be specified on a per package basis:
TODO: https://github.com/dotnet/arcade/issues/2266
-->
<PropertyGroup>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == '.NETCORE'">https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == '.NETCOREVALIDATION'">https://dotnetfeed.blob.core.windows.net/arcade-validation/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'ASPNETCORE'">https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'ASPNETCORETOOLING'">https://dotnetfeed.blob.core.windows.net/aspnet-aspnetcore-tooling/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'ENTITYFRAMEWORKCORE'">https://dotnetfeed.blob.core.windows.net/aspnet-entityframeworkcore/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'ASPNETEXTENSIONS'">https://dotnetfeed.blob.core.windows.net/aspnet-extensions/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'CORECLR'">https://dotnetfeed.blob.core.windows.net/dotnet-coreclr/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'CORESDK'">https://dotnetfeed.blob.core.windows.net/dotnet-sdk/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'TOOLSINTERNAL'">https://dotnetfeed.blob.core.windows.net/dotnet-tools-internal/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'TOOLSET'">https://dotnetfeed.blob.core.windows.net/dotnet-toolset/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'WINDOWSDESKTOP'">https://dotnetfeed.blob.core.windows.net/dotnet-windowsdesktop/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'NUGETCLIENT'">https://dotnetfeed.blob.core.windows.net/nuget-nugetclient/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'ASPNETENTITYFRAMEWORK6'">https://dotnetfeed.blob.core.windows.net/aspnet-entityframework6/index.json</TargetStaticFeed>
<TargetStaticFeed Condition="'$(ArtifactsCategory.ToUpper())' == 'ASPNETBLAZOR'">https://dotnetfeed.blob.core.windows.net/aspnet-blazor/index.json</TargetStaticFeed>
</PropertyGroup>
<Error
Condition="'$(TargetStaticFeed)' == ''"
Text="'$(ArtifactsCategory)' wasn't recognized as a valid artifact category. Valid categories are: '.NetCore' and '.NetCoreValidation'" />
<!-- Iterate publishing assets from each manifest file. -->
<PushArtifactsInManifestToFeed
ExpectedFeedUrl="$(TargetStaticFeed)"
AccountKey="$(AccountKeyToStaticFeed)"
BARBuildId="$(BARBuildId)"
MaestroApiEndpoint="$(MaestroApiEndpoint)"
BuildAssetRegistryToken="$(BuildAssetRegistryToken)"
Overwrite="$(OverrideAssetsWithSameName)"
PassIfExistingItemIdentical="$(PassIfExistingItemIdentical)"
MaxClients="$(MaxParallelUploads)"
UploadTimeoutInMinutes="$(MaxUploadTimeoutInMinutes)"
AssetManifestPath="%(ManifestFiles.Identity)"
BlobAssetsBasePath="$(BlobBasePath)"
PackageAssetsBasePath="$(PackageBasePath)"/>
</Target>
<ItemGroup>
<PackageReference Include="Microsoft.DotNet.Build.Tasks.Feed" Version="$(MicrosoftDotNetBuildTasksFeedVersion)" />
</ItemGroup>
</Project>
+84
View File
@@ -0,0 +1,84 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<Project Sdk="Microsoft.NET.Sdk">
<!--
This MSBuild file is intended to be used as the body of the default
publishing release pipeline. The release pipeline will use this file
to invoke the PublishSymbols tasks to publish symbols to MSDL and SymWeb.
Parameters:
- PDBArtifactsDirectory : Full path to directory containing PDB files to be published.
- BlobBasePath : Full path containing *.symbols.nupkg packages to be published.
- DotNetSymbolServerTokenMsdl : PAT to access MSDL.
- DotNetSymbolServerTokenSymWeb : PAT to access SymWeb.
- DotNetSymbolExpirationInDays : Expiration days for published packages. Default is 3650.
-->
<PropertyGroup>
<TargetFramework>netcoreapp2.1</TargetFramework>
</PropertyGroup>
<Import Project="$(NuGetPackageRoot)microsoft.symboluploader.build.task\$(SymbolUploaderVersion)\build\PublishSymbols.targets" />
<Target Name="PublishSymbols">
<ItemGroup>
<FilesToPublishToSymbolServer Include="$(PDBArtifactsDirectory)\*.pdb"/>
<PackagesToPublishToSymbolServer Include="$(BlobBasePath)\*.symbols.nupkg"/>
<!--
These packages from Arcade-Services include some native libraries that
our current symbol uploader can't handle. Below is a workaround until
we get issue: https://github.com/dotnet/arcade/issues/2457 sorted.
-->
<PackagesToPublishToSymbolServer Remove="$(BlobBasePath)\Microsoft.DotNet.Darc.*" />
<PackagesToPublishToSymbolServer Remove="$(BlobBasePath)\Microsoft.DotNet.Maestro.Tasks.*" />
</ItemGroup>
<PropertyGroup>
<DotNetSymbolExpirationInDays Condition="'$(DotNetSymbolExpirationInDays)' == ''">3650</DotNetSymbolExpirationInDays>
<PublishToSymbolServer>true</PublishToSymbolServer>
<PublishToSymWeb Condition="'$(PublishToSymWeb)' == ''">true</PublishToSymWeb>
<PublishToMSDL Condition="'$(PublishToMSDL)' == ''">true</PublishToMSDL>
<PublishToSymbolServer Condition="'@(FilesToPublishToSymbolServer)' == '' and '@(PackagesToPublishToSymbolServer)' == ''">false</PublishToSymbolServer>
</PropertyGroup>
<Message
Importance="High"
Text="No symbol package(s) were found to publish."
Condition="$(PublishToSymbolServer) == false" />
<!-- Symbol Uploader: MSDL -->
<Message Importance="High" Text="Publishing symbol packages to MSDL ..." Condition="$(PublishToSymbolServer)" />
<PublishSymbols PackagesToPublish="@(PackagesToPublishToSymbolServer)"
FilesToPublish="@(FilesToPublishToSymbolServer)"
PersonalAccessToken="$(DotNetSymbolServerTokenMsdl)"
SymbolServerPath="https://microsoftpublicsymbols.artifacts.visualstudio.com/DefaultCollection"
ExpirationInDays="$(DotNetSymbolExpirationInDays)"
VerboseLogging="true"
DryRun="false"
ConvertPortablePdbsToWindowsPdbs="false"
PdbConversionTreatAsWarning=""
Condition="$(PublishToSymbolServer) and $(PublishToMSDL)"/>
<!--
Symbol Uploader: SymWeb
Watson, VS insertion testings and the typical internal dev usage require SymWeb.
Currently we need to call the task twice (https://github.com/dotnet/core-eng/issues/3489).
-->
<Message Importance="High" Text="Publishing symbol packages to SymWeb ..." Condition="$(PublishToSymbolServer)" />
<PublishSymbols PackagesToPublish="@(PackagesToPublishToSymbolServer)"
FilesToPublish="@(FilesToPublishToSymbolServer)"
PersonalAccessToken="$(DotNetSymbolServerTokenSymWeb)"
SymbolServerPath="https://microsoft.artifacts.visualstudio.com/DefaultCollection"
ExpirationInDays="$(DotNetSymbolExpirationInDays)"
VerboseLogging="true"
DryRun="false"
ConvertPortablePdbsToWindowsPdbs="false"
PdbConversionTreatAsWarning=""
Condition="$(PublishToSymbolServer) and $(PublishToSymWeb)"/>
</Target>
<ItemGroup>
<PackageReference Include="Microsoft.SymbolUploader.Build.Task" Version="$(SymbolUploaderVersion)" />
</ItemGroup>
</Project>
+28
View File
@@ -0,0 +1,28 @@
# Don't touch this folder
uuuuuuuuuuuuuuuuuuuu
u" uuuuuuuuuuuuuuuuuu "u
u" u$$$$$$$$$$$$$$$$$$$$u "u
u" u$$$$$$$$$$$$$$$$$$$$$$$$u "u
u" u$$$$$$$$$$$$$$$$$$$$$$$$$$$$u "u
u" u$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$u "u
u" u$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$u "u
$ $$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$ $
$ $$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$ $
$ $$$" ... "$... ...$" ... "$$$ ... "$$$ $
$ $$$u `"$$$$$$$ $$$ $$$$$ $$ $$$ $$$ $
$ $$$$$$uu "$$$$ $$$ $$$$$ $$ """ u$$$ $
$ $$$""$$$ $$$$ $$$u "$$$" u$$ $$$$$$$$ $
$ $$$$....,$$$$$..$$$$$....,$$$$..$$$$$$$$ $
$ $$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$ $
"u "$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$" u"
"u "$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$" u"
"u "$$$$$$$$$$$$$$$$$$$$$$$$$$$$" u"
"u "$$$$$$$$$$$$$$$$$$$$$$$$" u"
"u "$$$$$$$$$$$$$$$$$$$$" u"
"u """""""""""""""""" u"
""""""""""""""""""""
!!! Changes made in this directory are subject to being overwritten by automation !!!
The files in this directory are shared by all Arcade repos and managed by automation. If you need to make changes to these files, open an issue or submit a pull request to https://github.com/dotnet/arcade first.
+127
View File
@@ -0,0 +1,127 @@
# This file is a temporary workaround for internal builds to be able to restore from private AzDO feeds.
# This file should be removed as part of this issue: https://github.com/dotnet/arcade/issues/4080
#
# What the script does is iterate over all package sources in the pointed NuGet.config and add a credential entry
# under <packageSourceCredentials> for each Maestro managed private feed. Two additional credential
# entries are also added for the two private static internal feeds: dotnet3-internal and dotnet3-internal-transport.
#
# This script needs to be called in every job that will restore packages and which the base repo has
# private AzDO feeds in the NuGet.config.
#
# See example YAML call for this script below. Note the use of the variable `$(dn-bot-dnceng-artifact-feeds-rw)`
# from the AzureDevOps-Artifact-Feeds-Pats variable group.
#
# - task: PowerShell@2
# displayName: Setup Private Feeds Credentials
# condition: eq(variables['Agent.OS'], 'Windows_NT')
# inputs:
# filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1
# arguments: -ConfigFile ${Env:BUILD_SOURCESDIRECTORY}/NuGet.config -Password $Env:Token
# env:
# Token: $(dn-bot-dnceng-artifact-feeds-rw)
[CmdletBinding()]
param (
[Parameter(Mandatory = $true)][string]$ConfigFile,
[Parameter(Mandatory = $true)][string]$Password
)
$ErrorActionPreference = "Stop"
Set-StrictMode -Version 2.0
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
. $PSScriptRoot\tools.ps1
# Add source entry to PackageSources
function AddPackageSource($sources, $SourceName, $SourceEndPoint, $creds, $Username, $Password) {
$packageSource = $sources.SelectSingleNode("add[@key='$SourceName']")
if ($packageSource -eq $null)
{
$packageSource = $doc.CreateElement("add")
$packageSource.SetAttribute("key", $SourceName)
$packageSource.SetAttribute("value", $SourceEndPoint)
$sources.AppendChild($packageSource) | Out-Null
}
else {
Write-Host "Package source $SourceName already present."
}
AddCredential -Creds $creds -Source $SourceName -Username $Username -Password $Password
}
# Add a credential node for the specified source
function AddCredential($creds, $source, $username, $password) {
# Looks for credential configuration for the given SourceName. Create it if none is found.
$sourceElement = $creds.SelectSingleNode($Source)
if ($sourceElement -eq $null)
{
$sourceElement = $doc.CreateElement($Source)
$creds.AppendChild($sourceElement) | Out-Null
}
# Add the <Username> node to the credential if none is found.
$usernameElement = $sourceElement.SelectSingleNode("add[@key='Username']")
if ($usernameElement -eq $null)
{
$usernameElement = $doc.CreateElement("add")
$usernameElement.SetAttribute("key", "Username")
$sourceElement.AppendChild($usernameElement) | Out-Null
}
$usernameElement.SetAttribute("value", $Username)
# Add the <ClearTextPassword> to the credential if none is found.
# Add it as a clear text because there is no support for encrypted ones in non-windows .Net SDKs.
# -> https://github.com/NuGet/Home/issues/5526
$passwordElement = $sourceElement.SelectSingleNode("add[@key='ClearTextPassword']")
if ($passwordElement -eq $null)
{
$passwordElement = $doc.CreateElement("add")
$passwordElement.SetAttribute("key", "ClearTextPassword")
$sourceElement.AppendChild($passwordElement) | Out-Null
}
$passwordElement.SetAttribute("value", $Password)
}
function InsertMaestroPrivateFeedCredentials($Sources, $Creds, $Password) {
$maestroPrivateSources = $Sources.SelectNodes("add[contains(@key,'darc-int')]")
Write-Host "Inserting credentials for $($maestroPrivateSources.Count) Maestro's private feeds."
ForEach ($PackageSource in $maestroPrivateSources) {
Write-Host "`tInserting credential for Maestro's feed:" $PackageSource.Key
AddCredential -Creds $creds -Source $PackageSource.Key -Username $Username -Password $Password
}
}
if (!(Test-Path $ConfigFile -PathType Leaf)) {
Write-Host "Couldn't find the file NuGet config file: $ConfigFile"
ExitWithExitCode 1
}
# Load NuGet.config
$doc = New-Object System.Xml.XmlDocument
$filename = (Get-Item $ConfigFile).FullName
$doc.Load($filename)
# Get reference to <PackageSources> or create one if none exist already
$sources = $doc.DocumentElement.SelectSingleNode("packageSources")
if ($sources -eq $null) {
$sources = $doc.CreateElement("packageSources")
$doc.DocumentElement.AppendChild($sources) | Out-Null
}
# Looks for a <PackageSourceCredentials> node. Create it if none is found.
$creds = $doc.DocumentElement.SelectSingleNode("packageSourceCredentials")
if ($creds -eq $null) {
$creds = $doc.CreateElement("packageSourceCredentials")
$doc.DocumentElement.AppendChild($creds) | Out-Null
}
# Insert credential nodes for Maestro's private feeds
InsertMaestroPrivateFeedCredentials -Sources $sources -Creds $creds -Password $Password
AddPackageSource -Sources $sources -SourceName "dotnet3-internal" -SourceEndPoint "https://pkgs.dev.azure.com/dnceng/_packaging/dotnet3-internal/nuget/v2" -Creds $creds -Username "dn-bot" -Password $Password
AddPackageSource -Sources $sources -SourceName "dotnet3-internal-transport" -SourceEndPoint "https://pkgs.dev.azure.com/dnceng/_packaging/dotnet3-internal-transport/nuget/v2" -Creds $creds -Username "dn-bot" -Password $Password
$doc.Save($filename)
+117
View File
@@ -0,0 +1,117 @@
#!/usr/bin/env bash
# This file is a temporary workaround for internal builds to be able to restore from private AzDO feeds.
# This file should be removed as part of this issue: https://github.com/dotnet/arcade/issues/4080
#
# What the script does is iterate over all package sources in the pointed NuGet.config and add a credential entry
# under <packageSourceCredentials> for each Maestro's managed private feed. Two additional credential
# entries are also added for the two private static internal feeds: dotnet3-internal and dotnet3-internal-transport.
#
# This script needs to be called in every job that will restore packages and which the base repo has
# private AzDO feeds in the NuGet.config.
#
# See example YAML call for this script below. Note the use of the variable `$(dn-bot-dnceng-artifact-feeds-rw)`
# from the AzureDevOps-Artifact-Feeds-Pats variable group.
#
# - task: Bash@3
# displayName: Setup Private Feeds Credentials
# inputs:
# filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.sh
# arguments: $BUILD_SOURCESDIRECTORY/NuGet.config $Token
# condition: ne(variables['Agent.OS'], 'Windows_NT')
# env:
# Token: $(dn-bot-dnceng-artifact-feeds-rw)
ConfigFile=$1
CredToken=$2
NL='\n'
TB=' '
source="${BASH_SOURCE[0]}"
# resolve $source until the file is no longer a symlink
while [[ -h "$source" ]]; do
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
source="$(readlink "$source")"
# if $source was a relative symlink, we need to resolve it relative to the path where the
# symlink file was located
[[ $source != /* ]] && source="$scriptroot/$source"
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
. "$scriptroot/tools.sh"
if [ ! -f "$ConfigFile" ]; then
echo "Couldn't find the file NuGet config file: $ConfigFile"
ExitWithExitCode 1
fi
if [[ `uname -s` == "Darwin" ]]; then
NL=$'\\\n'
TB=''
fi
# Ensure there is a <packageSources>...</packageSources> section.
grep -i "<packageSources>" $ConfigFile
if [ "$?" != "0" ]; then
echo "Adding <packageSources>...</packageSources> section."
ConfigNodeHeader="<configuration>"
PackageSourcesTemplate="${TB}<packageSources>${NL}${TB}</packageSources>"
sed -i.bak "s|$ConfigNodeHeader|$ConfigNodeHeader${NL}$PackageSourcesTemplate|" NuGet.config
fi
# Ensure there is a <packageSourceCredentials>...</packageSourceCredentials> section.
grep -i "<packageSourceCredentials>" $ConfigFile
if [ "$?" != "0" ]; then
echo "Adding <packageSourceCredentials>...</packageSourceCredentials> section."
PackageSourcesNodeFooter="</packageSources>"
PackageSourceCredentialsTemplate="${TB}<packageSourceCredentials>${NL}${TB}</packageSourceCredentials>"
sed -i.bak "s|$PackageSourcesNodeFooter|$PackageSourcesNodeFooter${NL}$PackageSourceCredentialsTemplate|" NuGet.config
fi
# Ensure dotnet3-internal and dotnet3-internal-transport is in the packageSources
grep -i "<add key=\"dotnet3-internal\">" $ConfigFile
if [ "$?" != "0" ]; then
echo "Adding dotnet3-internal to the packageSources."
PackageSourcesNodeFooter="</packageSources>"
PackageSourceTemplate="${TB}<add key=\"dotnet3-internal\" value=\"https://pkgs.dev.azure.com/dnceng/_packaging/dotnet3-internal/nuget/v2\" />"
sed -i.bak "s|$PackageSourcesNodeFooter|$PackageSourceTemplate${NL}$PackageSourcesNodeFooter|" NuGet.config
fi
# Ensure dotnet3-internal and dotnet3-internal-transport is in the packageSources
grep -i "<add key=\"dotnet3-internal-transport\">" $ConfigFile
if [ "$?" != "0" ]; then
echo "Adding dotnet3-internal-transport to the packageSources."
PackageSourcesNodeFooter="</packageSources>"
PackageSourceTemplate="${TB}<add key=\"dotnet3-internal-transport\" value=\"https://pkgs.dev.azure.com/dnceng/_packaging/dotnet3-internal-transport/nuget/v2\" />"
sed -i.bak "s|$PackageSourcesNodeFooter|$PackageSourceTemplate${NL}$PackageSourcesNodeFooter|" NuGet.config
fi
# I want things split line by line
PrevIFS=$IFS
IFS=$'\n'
PackageSources=$(grep -oh '"darc-int-[^"]*"' $ConfigFile | tr -d '"')
IFS=$PrevIFS
PackageSources+=('dotnet3-internal')
PackageSources+=('dotnet3-internal-transport')
for FeedName in ${PackageSources[@]} ; do
# Check if there is no existing credential for this FeedName
grep -i "<$FeedName>" $ConfigFile
if [ "$?" != "0" ]; then
echo "Adding credentials for $FeedName."
PackageSourceCredentialsNodeFooter="</packageSourceCredentials>"
NewCredential="${TB}${TB}<$FeedName>${NL}<add key=\"Username\" value=\"dn-bot\" />${NL}<add key=\"ClearTextPassword\" value=\"$CredToken\" />${NL}</$FeedName>"
sed -i.bak "s|$PackageSourceCredentialsNodeFooter|$NewCredential${NL}$PackageSourceCredentialsNodeFooter|" NuGet.config
fi
done
+83
View File
@@ -0,0 +1,83 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<Project Sdk="Microsoft.NET.Sdk">
<!--
This MSBuild file is intended to be used as the body of the default
publishing release pipeline. The release pipeline will use this file
to invoke the SignCheck tool to validate that packages about to
be published are correctly signed.
Parameters:
- PackageBasePath : Directory containing all files that need to be validated.
- SignCheckVersion : Version of SignCheck package to be used.
- SignValidationExclusionList : ItemGroup containing exclusion list to be forwarded to SignCheck.
- EnableJarSigningCheck : Whether .jar files should be validated.
- EnableStrongNameCheck : Whether strong name check should be performed.
-->
<PropertyGroup>
<TargetFramework>netcoreapp2.1</TargetFramework>
</PropertyGroup>
<!--
From 'Signing.props' we import $(SignValidationExclusionList)
-->
<Import Project="$(MSBuildThisFileDirectory)Signing.props" Condition="Exists('$(MSBuildThisFileDirectory)Signing.props')" />
<Target Name="ValidateSigning">
<PropertyGroup>
<SignCheckToolPath>$(NuGetPackageRoot)Microsoft.DotNet.SignCheck\$(SignCheckVersion)\tools\Microsoft.DotNet.SignCheck.exe</SignCheckToolPath>
<SignCheckInputDir>$(PackageBasePath)</SignCheckInputDir>
<SignCheckLog>signcheck.log</SignCheckLog>
<SignCheckErrorLog>signcheck.errors.log</SignCheckErrorLog>
<SignCheckExclusionsFile>signcheck.exclusions.txt</SignCheckExclusionsFile>
</PropertyGroup>
<ItemGroup>
<!--
Documentation for these arguments is available here:
https://github.com/dotnet/arcade/tree/master/src/SignCheck
-->
<SignCheckArgs Include="--recursive" />
<SignCheckArgs Include="--traverse-subfolders" />
<SignCheckArgs Include="--file-status AllFiles" />
<SignCheckArgs Include="--log-file $(SignCheckLog)" />
<SignCheckArgs Include="--error-log-file $(SignCheckErrorLog)" />
<SignCheckArgs Include="--input-files $(SignCheckInputDir)" />
<SignCheckArgs Include="--exclusions-file $(SignCheckExclusionsFile)" Condition="'@(SignValidationExclusionList)' != ''" />
<SignCheckArgs Include="--verify-jar" Condition="'$(EnableJarSigningCheck)' == 'true'" />
<SignCheckArgs Include="--verify-strongname" Condition="'$(EnableStrongNameCheck)' == 'true'" />
</ItemGroup>
<WriteLinesToFile
File="$(SignCheckExclusionsFile)"
Lines="@(SignValidationExclusionList)"
Condition="'@(SignValidationExclusionList)' != ''"
Overwrite="true"
Encoding="Unicode"/>
<!--
IgnoreExitCode='true' because the tool doesn't return '0' on success.
-->
<Exec
Command="&quot;$(SignCheckToolPath)&quot; @(SignCheckArgs, ' ')"
IgnoreExitCode='true'
ConsoleToMsBuild="false"
StandardErrorImportance="high" />
<Error
Text="Signing validation failed. Check $(SignCheckErrorLog) for more information."
Condition="Exists($(SignCheckErrorLog)) and '$([System.IO.File]::ReadAllText($(SignCheckErrorLog)))' != ''" />
<Message
Text="##vso[artifact.upload containerfolder=LogFiles;artifactname=LogFiles]{SignCheckErrorLog}"
Condition="Exists($(SignCheckErrorLog)) and '$([System.IO.File]::ReadAllText($(SignCheckErrorLog)))' != ''" />
</Target>
<ItemGroup>
<PackageReference Include="Microsoft.DotNet.SignCheck" Version="$(SignCheckVersion)" />
</ItemGroup>
</Project>
+184
View File
@@ -0,0 +1,184 @@
param(
[Parameter(Mandatory=$true)][string] $InputPath, # Full path to directory where Symbols.NuGet packages to be checked are stored
[Parameter(Mandatory=$true)][string] $ExtractPath, # Full path to directory where the packages will be extracted during validation
[Parameter(Mandatory=$true)][string] $SourceLinkToolPath, # Full path to directory where dotnet SourceLink CLI was installed
[Parameter(Mandatory=$true)][string] $GHRepoName, # GitHub name of the repo including the Org. E.g., dotnet/arcade
[Parameter(Mandatory=$true)][string] $GHCommit # GitHub commit SHA used to build the packages
)
# Cache/HashMap (File -> Exist flag) used to consult whether a file exist
# in the repository at a specific commit point. This is populated by inserting
# all files present in the repo at a specific commit point.
$global:RepoFiles = @{}
$ValidatePackage = {
param(
[string] $PackagePath # Full path to a Symbols.NuGet package
)
# Ensure input file exist
if (!(Test-Path $PackagePath)) {
throw "Input file does not exist: $PackagePath"
}
# Extensions for which we'll look for SourceLink information
# For now we'll only care about Portable & Embedded PDBs
$RelevantExtensions = @(".dll", ".exe", ".pdb")
Write-Host -NoNewLine "Validating" ([System.IO.Path]::GetFileName($PackagePath)) "... "
$PackageId = [System.IO.Path]::GetFileNameWithoutExtension($PackagePath)
$ExtractPath = Join-Path -Path $using:ExtractPath -ChildPath $PackageId
$FailedFiles = 0
Add-Type -AssemblyName System.IO.Compression.FileSystem
[System.IO.Directory]::CreateDirectory($ExtractPath);
$zip = [System.IO.Compression.ZipFile]::OpenRead($PackagePath)
$zip.Entries |
Where-Object {$RelevantExtensions -contains [System.IO.Path]::GetExtension($_.Name)} |
ForEach-Object {
$FileName = $_.FullName
$Extension = [System.IO.Path]::GetExtension($_.Name)
$FakeName = -Join((New-Guid), $Extension)
$TargetFile = Join-Path -Path $ExtractPath -ChildPath $FakeName
# We ignore resource DLLs
if ($FileName.EndsWith(".resources.dll")) {
return
}
[System.IO.Compression.ZipFileExtensions]::ExtractToFile($_, $TargetFile, $true)
$ValidateFile = {
param(
[string] $FullPath, # Full path to the module that has to be checked
[string] $RealPath,
[ref] $FailedFiles
)
# Makes easier to reference `sourcelink cli`
Push-Location $using:SourceLinkToolPath
$SourceLinkInfos = .\sourcelink.exe print-urls $FullPath | Out-String
if ($LASTEXITCODE -eq 0 -and -not ([string]::IsNullOrEmpty($SourceLinkInfos))) {
$NumFailedLinks = 0
# We only care about Http addresses
$Matches = (Select-String '(http[s]?)(:\/\/)([^\s,]+)' -Input $SourceLinkInfos -AllMatches).Matches
if ($Matches.Count -ne 0) {
$Matches.Value |
ForEach-Object {
$Link = $_
$CommitUrl = -Join("https://raw.githubusercontent.com/", $using:GHRepoName, "/", $using:GHCommit, "/")
$FilePath = $Link.Replace($CommitUrl, "")
$Status = 200
$Cache = $using:RepoFiles
if ( !($Cache.ContainsKey($FilePath)) ) {
try {
$Uri = $Link -as [System.URI]
# Only GitHub links are valid
if ($Uri.AbsoluteURI -ne $null -and $Uri.Host -match "github") {
$Status = (Invoke-WebRequest -Uri $Link -UseBasicParsing -Method HEAD -TimeoutSec 5).StatusCode
}
else {
$Status = 0
}
}
catch {
$Status = 0
}
}
if ($Status -ne 200) {
if ($NumFailedLinks -eq 0) {
if ($FailedFiles.Value -eq 0) {
Write-Host
}
Write-Host "`tFile $RealPath has broken links:"
}
Write-Host "`t`tFailed to retrieve $Link"
$NumFailedLinks++
}
}
}
if ($NumFailedLinks -ne 0) {
$FailedFiles.value++
$global:LASTEXITCODE = 1
}
}
Pop-Location
}
&$ValidateFile $TargetFile $FileName ([ref]$FailedFiles)
}
$zip.Dispose()
if ($FailedFiles -eq 0) {
Write-Host "Passed."
}
}
function ValidateSourceLinkLinks {
if (!($GHRepoName -Match "^[^\s\/]+/[^\s\/]+$")) {
Write-Host "GHRepoName should be in the format <org>/<repo>"
$global:LASTEXITCODE = 1
return
}
if (!($GHCommit -Match "^[0-9a-fA-F]{40}$")) {
Write-Host "GHCommit should be a 40 chars hexadecimal string"
$global:LASTEXITCODE = 1
return
}
$RepoTreeURL = -Join("https://api.github.com/repos/", $GHRepoName, "/git/trees/", $GHCommit, "?recursive=1")
$CodeExtensions = @(".cs", ".vb", ".fs", ".fsi", ".fsx", ".fsscript")
try {
# Retrieve the list of files in the repo at that particular commit point and store them in the RepoFiles hash
$Data = Invoke-WebRequest $RepoTreeURL | ConvertFrom-Json | Select-Object -ExpandProperty tree
foreach ($file in $Data) {
$Extension = [System.IO.Path]::GetExtension($file.path)
if ($CodeExtensions.Contains($Extension)) {
$RepoFiles[$file.path] = 1
}
}
}
catch {
Write-Host "Problems downloading the list of files from the repo. Url used: $RepoTreeURL"
$global:LASTEXITCODE = 1
return
}
if (Test-Path $ExtractPath) {
Remove-Item $ExtractPath -Force -Recurse -ErrorAction SilentlyContinue
}
# Process each NuGet package in parallel
$Jobs = @()
Get-ChildItem "$InputPath\*.symbols.nupkg" |
ForEach-Object {
$Jobs += Start-Job -ScriptBlock $ValidatePackage -ArgumentList $_.FullName
}
foreach ($Job in $Jobs) {
Wait-Job -Id $Job.Id | Receive-Job
}
}
Measure-Command { ValidateSourceLinkLinks }
+148
View File
@@ -0,0 +1,148 @@
[CmdletBinding(PositionalBinding=$false)]
Param(
[string][Alias('c')]$configuration = "Debug",
[string]$platform = $null,
[string] $projects,
[string][Alias('v')]$verbosity = "minimal",
[string] $msbuildEngine = $null,
[bool] $warnAsError = $true,
[bool] $nodeReuse = $true,
[switch][Alias('r')]$restore,
[switch] $deployDeps,
[switch][Alias('b')]$build,
[switch] $rebuild,
[switch] $deploy,
[switch][Alias('t')]$test,
[switch] $integrationTest,
[switch] $performanceTest,
[switch] $sign,
[switch] $pack,
[switch] $publish,
[switch] $clean,
[switch][Alias('bl')]$binaryLog,
[switch] $ci,
[switch] $prepareMachine,
[switch] $help,
[Parameter(ValueFromRemainingArguments=$true)][String[]]$properties
)
. $PSScriptRoot\tools.ps1
function Print-Usage() {
Write-Host "Common settings:"
Write-Host " -configuration <value> Build configuration: 'Debug' or 'Release' (short: -c)"
Write-Host " -platform <value> Platform configuration: 'x86', 'x64' or any valid Platform value to pass to msbuild"
Write-Host " -verbosity <value> Msbuild verbosity: q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic] (short: -v)"
Write-Host " -binaryLog Output binary log (short: -bl)"
Write-Host " -help Print help and exit"
Write-Host ""
Write-Host "Actions:"
Write-Host " -restore Restore dependencies (short: -r)"
Write-Host " -build Build solution (short: -b)"
Write-Host " -rebuild Rebuild solution"
Write-Host " -deploy Deploy built VSIXes"
Write-Host " -deployDeps Deploy dependencies (e.g. VSIXes for integration tests)"
Write-Host " -test Run all unit tests in the solution (short: -t)"
Write-Host " -integrationTest Run all integration tests in the solution"
Write-Host " -performanceTest Run all performance tests in the solution"
Write-Host " -pack Package build outputs into NuGet packages and Willow components"
Write-Host " -sign Sign build outputs"
Write-Host " -publish Publish artifacts (e.g. symbols)"
Write-Host " -clean Clean the solution"
Write-Host ""
Write-Host "Advanced settings:"
Write-Host " -projects <value> Semi-colon delimited list of sln/proj's to build. Globbing is supported (*.sln)"
Write-Host " -ci Set when running on CI server"
Write-Host " -prepareMachine Prepare machine for CI run, clean up processes after build"
Write-Host " -warnAsError <value> Sets warnaserror msbuild parameter ('true' or 'false')"
Write-Host " -msbuildEngine <value> Msbuild engine to use to run build ('dotnet', 'vs', or unspecified)."
Write-Host ""
Write-Host "Command line arguments not listed above are passed thru to msbuild."
Write-Host "The above arguments can be shortened as much as to be unambiguous (e.g. -co for configuration, -t for test, etc.)."
}
function InitializeCustomToolset {
if (-not $restore) {
return
}
$script = Join-Path $EngRoot "restore-toolset.ps1"
if (Test-Path $script) {
. $script
}
}
function Build {
$toolsetBuildProj = InitializeToolset
InitializeCustomToolset
$bl = if ($binaryLog) { "/bl:" + (Join-Path $LogDir "Build.binlog") } else { "" }
$platformArg = if ($platform) { "/p:Platform=$platform" } else { "" }
if ($projects) {
# Re-assign properties to a new variable because PowerShell doesn't let us append properties directly for unclear reasons.
# Explicitly set the type as string[] because otherwise PowerShell would make this char[] if $properties is empty.
[string[]] $msbuildArgs = $properties
# Resolve relative project paths into full paths
$projects = ($projects.Split(';').ForEach({Resolve-Path $_}) -join ';')
$msbuildArgs += "/p:Projects=$projects"
$properties = $msbuildArgs
}
MSBuild $toolsetBuildProj `
$bl `
$platformArg `
/p:Configuration=$configuration `
/p:RepoRoot=$RepoRoot `
/p:Restore=$restore `
/p:DeployDeps=$deployDeps `
/p:Build=$build `
/p:Rebuild=$rebuild `
/p:Deploy=$deploy `
/p:Test=$test `
/p:Pack=$pack `
/p:IntegrationTest=$integrationTest `
/p:PerformanceTest=$performanceTest `
/p:Sign=$sign `
/p:Publish=$publish `
@properties
}
if ($clean) {
if(Test-Path $ArtifactsDir) {
Remove-Item -Recurse -Force $ArtifactsDir
Write-Host "Artifacts directory deleted."
}
exit 0
}
try {
if ($help -or (($null -ne $properties) -and ($properties.Contains("/help") -or $properties.Contains("/?")))) {
Print-Usage
exit 0
}
if ($ci) {
$binaryLog = $true
$nodeReuse = $false
}
if ($restore) {
InitializeNativeTools
}
Build
}
catch {
Write-Host $_.ScriptStackTrace
Write-PipelineTelemetryError -Category "InitializeToolset" -Message $_
ExitWithExitCode 1
}
ExitWithExitCode 0
+216
View File
@@ -0,0 +1,216 @@
#!/usr/bin/env bash
# Stop script if unbound variable found (use ${var:-} if intentional)
set -u
# Stop script if command returns non-zero exit code.
# Prevents hidden errors caused by missing error code propagation.
set -e
usage()
{
echo "Common settings:"
echo " --configuration <value> Build configuration: 'Debug' or 'Release' (short: -c)"
echo " --verbosity <value> Msbuild verbosity: q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic] (short: -v)"
echo " --binaryLog Create MSBuild binary log (short: -bl)"
echo " --help Print help and exit (short: -h)"
echo ""
echo "Actions:"
echo " --restore Restore dependencies (short: -r)"
echo " --build Build solution (short: -b)"
echo " --rebuild Rebuild solution"
echo " --test Run all unit tests in the solution (short: -t)"
echo " --integrationTest Run all integration tests in the solution"
echo " --performanceTest Run all performance tests in the solution"
echo " --pack Package build outputs into NuGet packages and Willow components"
echo " --sign Sign build outputs"
echo " --publish Publish artifacts (e.g. symbols)"
echo " --clean Clean the solution"
echo ""
echo "Advanced settings:"
echo " --projects <value> Project or solution file(s) to build"
echo " --ci Set when running on CI server"
echo " --prepareMachine Prepare machine for CI run, clean up processes after build"
echo " --nodeReuse <value> Sets nodereuse msbuild parameter ('true' or 'false')"
echo " --warnAsError <value> Sets warnaserror msbuild parameter ('true' or 'false')"
echo ""
echo "Command line arguments not listed above are passed thru to msbuild."
echo "Arguments can also be passed in with a single hyphen."
}
source="${BASH_SOURCE[0]}"
# resolve $source until the file is no longer a symlink
while [[ -h "$source" ]]; do
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
source="$(readlink "$source")"
# if $source was a relative symlink, we need to resolve it relative to the path where the
# symlink file was located
[[ $source != /* ]] && source="$scriptroot/$source"
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
restore=false
build=false
rebuild=false
test=false
integration_test=false
performance_test=false
pack=false
publish=false
sign=false
public=false
ci=false
clean=false
warn_as_error=true
node_reuse=true
binary_log=false
pipelines_log=false
projects=''
configuration='Debug'
prepare_machine=false
verbosity='minimal'
properties=''
while [[ $# > 0 ]]; do
opt="$(echo "${1/#--/-}" | awk '{print tolower($0)}')"
case "$opt" in
-help|-h)
usage
exit 0
;;
-clean)
clean=true
;;
-configuration|-c)
configuration=$2
shift
;;
-verbosity|-v)
verbosity=$2
shift
;;
-binarylog|-bl)
binary_log=true
;;
-pipelineslog|-pl)
pipelines_log=true
;;
-restore|-r)
restore=true
;;
-build|-b)
build=true
;;
-rebuild)
rebuild=true
;;
-pack)
pack=true
;;
-test|-t)
test=true
;;
-integrationtest)
integration_test=true
;;
-performancetest)
performance_test=true
;;
-sign)
sign=true
;;
-publish)
publish=true
;;
-preparemachine)
prepare_machine=true
;;
-projects)
projects=$2
shift
;;
-ci)
ci=true
;;
-warnaserror)
warn_as_error=$2
shift
;;
-nodereuse)
node_reuse=$2
shift
;;
*)
properties="$properties $1"
;;
esac
shift
done
if [[ "$ci" == true ]]; then
pipelines_log=true
binary_log=true
node_reuse=false
fi
. "$scriptroot/tools.sh"
function InitializeCustomToolset {
local script="$eng_root/restore-toolset.sh"
if [[ -a "$script" ]]; then
. "$script"
fi
}
function Build {
InitializeToolset
InitializeCustomToolset
if [[ ! -z "$projects" ]]; then
properties="$properties /p:Projects=$projects"
fi
local bl=""
if [[ "$binary_log" == true ]]; then
bl="/bl:\"$log_dir/Build.binlog\""
fi
MSBuild $_InitializeToolset \
$bl \
/p:Configuration=$configuration \
/p:RepoRoot="$repo_root" \
/p:Restore=$restore \
/p:Build=$build \
/p:Rebuild=$rebuild \
/p:Test=$test \
/p:Pack=$pack \
/p:IntegrationTest=$integration_test \
/p:PerformanceTest=$performance_test \
/p:Sign=$sign \
/p:Publish=$publish \
$properties
ExitWithExitCode 0
}
if [[ "$clean" == true ]]; then
if [ -d "$artifacts_dir" ]; then
rm -rf $artifacts_dir
echo "Artifacts directory deleted."
fi
exit 0
fi
if [[ "$restore" == true ]]; then
InitializeNativeTools
fi
Build
+16
View File
@@ -0,0 +1,16 @@
#!/usr/bin/env bash
source="${BASH_SOURCE[0]}"
# resolve $SOURCE until the file is no longer a symlink
while [[ -h $source ]]; do
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
source="$(readlink "$source")"
# if $source was a relative symlink, we need to resolve it relative to the path where
# the symlink file was located
[[ $source != /* ]] && source="$scriptroot/$source"
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
. "$scriptroot/build.sh" --restore --build --test --pack --publish --ci $@
@@ -0,0 +1,41 @@
set(CROSS_NDK_TOOLCHAIN $ENV{ROOTFS_DIR}/../)
set(CROSS_ROOTFS ${CROSS_NDK_TOOLCHAIN}/sysroot)
set(CLR_CMAKE_PLATFORM_ANDROID "Android")
set(CMAKE_SYSTEM_NAME Linux)
set(CMAKE_SYSTEM_VERSION 1)
set(CMAKE_SYSTEM_PROCESSOR arm)
## Specify the toolchain
set(TOOLCHAIN "arm-linux-androideabi")
set(CMAKE_PREFIX_PATH ${CROSS_NDK_TOOLCHAIN})
set(TOOLCHAIN_PREFIX ${TOOLCHAIN}-)
find_program(CMAKE_C_COMPILER ${TOOLCHAIN_PREFIX}clang)
find_program(CMAKE_CXX_COMPILER ${TOOLCHAIN_PREFIX}clang++)
find_program(CMAKE_ASM_COMPILER ${TOOLCHAIN_PREFIX}clang)
find_program(CMAKE_AR ${TOOLCHAIN_PREFIX}ar)
find_program(CMAKE_LD ${TOOLCHAIN_PREFIX}ar)
find_program(CMAKE_OBJCOPY ${TOOLCHAIN_PREFIX}objcopy)
find_program(CMAKE_OBJDUMP ${TOOLCHAIN_PREFIX}objdump)
add_compile_options(--sysroot=${CROSS_ROOTFS})
add_compile_options(-fPIE)
add_compile_options(-mfloat-abi=soft)
include_directories(SYSTEM ${CROSS_NDK_TOOLCHAIN}/include/c++/4.9.x/)
include_directories(SYSTEM ${CROSS_NDK_TOOLCHAIN}/include/c++/4.9.x/arm-linux-androideabi/)
set(CROSS_LINK_FLAGS "${CROSS_LINK_FLAGS} -B ${CROSS_ROOTFS}/usr/lib/gcc/${TOOLCHAIN}")
set(CROSS_LINK_FLAGS "${CROSS_LINK_FLAGS} -L${CROSS_ROOTFS}/lib/${TOOLCHAIN}")
set(CROSS_LINK_FLAGS "${CROSS_LINK_FLAGS} --sysroot=${CROSS_ROOTFS}")
set(CROSS_LINK_FLAGS "${CROSS_LINK_FLAGS} -fPIE -pie")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${CROSS_LINK_FLAGS}" CACHE STRING "" FORCE)
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${CROSS_LINK_FLAGS}" CACHE STRING "" FORCE)
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${CROSS_LINK_FLAGS}" CACHE STRING "" FORCE)
set(CMAKE_FIND_ROOT_PATH "${CROSS_ROOTFS}")
set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER)
set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY)
@@ -0,0 +1,42 @@
set(CROSS_NDK_TOOLCHAIN $ENV{ROOTFS_DIR}/../)
set(CROSS_ROOTFS ${CROSS_NDK_TOOLCHAIN}/sysroot)
set(CLR_CMAKE_PLATFORM_ANDROID "Android")
set(CMAKE_SYSTEM_NAME Linux)
set(CMAKE_SYSTEM_VERSION 1)
set(CMAKE_SYSTEM_PROCESSOR aarch64)
## Specify the toolchain
set(TOOLCHAIN "aarch64-linux-android")
set(CMAKE_PREFIX_PATH ${CROSS_NDK_TOOLCHAIN})
set(TOOLCHAIN_PREFIX ${TOOLCHAIN}-)
find_program(CMAKE_C_COMPILER ${TOOLCHAIN_PREFIX}clang)
find_program(CMAKE_CXX_COMPILER ${TOOLCHAIN_PREFIX}clang++)
find_program(CMAKE_ASM_COMPILER ${TOOLCHAIN_PREFIX}clang)
find_program(CMAKE_AR ${TOOLCHAIN_PREFIX}ar)
find_program(CMAKE_LD ${TOOLCHAIN_PREFIX}ar)
find_program(CMAKE_OBJCOPY ${TOOLCHAIN_PREFIX}objcopy)
find_program(CMAKE_OBJDUMP ${TOOLCHAIN_PREFIX}objdump)
add_compile_options(--sysroot=${CROSS_ROOTFS})
add_compile_options(-fPIE)
## Needed for Android or bionic specific conditionals
add_compile_options(-D__ANDROID__)
add_compile_options(-D__BIONIC__)
set(CROSS_LINK_FLAGS "${CROSS_LINK_FLAGS} -B ${CROSS_ROOTFS}/usr/lib/gcc/${TOOLCHAIN}")
set(CROSS_LINK_FLAGS "${CROSS_LINK_FLAGS} -L${CROSS_ROOTFS}/lib/${TOOLCHAIN}")
set(CROSS_LINK_FLAGS "${CROSS_LINK_FLAGS} --sysroot=${CROSS_ROOTFS}")
set(CROSS_LINK_FLAGS "${CROSS_LINK_FLAGS} -fPIE -pie")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${CROSS_LINK_FLAGS}" CACHE STRING "" FORCE)
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${CROSS_LINK_FLAGS}" CACHE STRING "" FORCE)
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${CROSS_LINK_FLAGS}" CACHE STRING "" FORCE)
set(CMAKE_FIND_ROOT_PATH "${CROSS_ROOTFS}")
set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER)
set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY)
+11
View File
@@ -0,0 +1,11 @@
deb http://ports.ubuntu.com/ubuntu-ports/ bionic main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ bionic main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ bionic-updates main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ bionic-updates main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ bionic-backports main restricted
deb-src http://ports.ubuntu.com/ubuntu-ports/ bionic-backports main restricted
deb http://ports.ubuntu.com/ubuntu-ports/ bionic-security main restricted universe multiverse
deb-src http://ports.ubuntu.com/ubuntu-ports/ bionic-security main restricted universe multiverse
+3
View File
@@ -0,0 +1,3 @@
# Debian (sid) # UNSTABLE
deb http://ftp.debian.org/debian/ sid main contrib non-free
deb-src http://ftp.debian.org/debian/ sid main contrib non-free
+11
View File
@@ -0,0 +1,11 @@
deb http://ports.ubuntu.com/ubuntu-ports/ trusty main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ trusty main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ trusty-updates main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ trusty-updates main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ trusty-backports main restricted
deb-src http://ports.ubuntu.com/ubuntu-ports/ trusty-backports main restricted
deb http://ports.ubuntu.com/ubuntu-ports/ trusty-security main restricted universe multiverse
deb-src http://ports.ubuntu.com/ubuntu-ports/ trusty-security main restricted universe multiverse
+11
View File
@@ -0,0 +1,11 @@
deb http://ports.ubuntu.com/ubuntu-ports/ xenial main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ xenial main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ xenial-updates main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ xenial-updates main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ xenial-backports main restricted
deb-src http://ports.ubuntu.com/ubuntu-ports/ xenial-backports main restricted
deb http://ports.ubuntu.com/ubuntu-ports/ xenial-security main restricted universe multiverse
deb-src http://ports.ubuntu.com/ubuntu-ports/ xenial-security main restricted universe multiverse
+11
View File
@@ -0,0 +1,11 @@
deb http://ports.ubuntu.com/ubuntu-ports/ zesty main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ zesty main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ zesty-updates main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ zesty-updates main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ zesty-backports main restricted
deb-src http://ports.ubuntu.com/ubuntu-ports/ zesty-backports main restricted
deb http://ports.ubuntu.com/ubuntu-ports/ zesty-security main restricted universe multiverse
deb-src http://ports.ubuntu.com/ubuntu-ports/ zesty-security main restricted universe multiverse
@@ -0,0 +1,71 @@
From e72c9d7ead60e3317bd6d1fade995c07021c947b Mon Sep 17 00:00:00 2001
From: Mathieu Desnoyers <[email protected]>
Date: Thu, 7 May 2015 13:25:04 -0400
Subject: [PATCH] Fix: building probe providers with C++ compiler
Robert Daniels wrote:
> > I'm attempting to use lttng userspace tracing with a C++ application
> > on an ARM platform. I'm using GCC 4.8.4 on Linux 3.14 with the 2.6
> > release of lttng. I've compiled lttng-modules, lttng-ust, and
> > lttng-tools and have been able to get a simple test working with C
> > code. When I attempt to run the hello.cxx test on my target it will
> > segfault.
>
>
> I spent a little time digging into this issue and finally discovered the
> cause of my segfault with ARM C++ tracepoints.
>
> There is a struct called 'lttng_event' in ust-events.h which contains an
> empty union 'u'. This was the cause of my issue. Under C, this empty union
> compiles to a zero byte member while under C++ it compiles to a one byte
> member, and in my case was four-byte aligned which caused my C++ code to
> have the 'cds_list_head node' offset incorrectly by four bytes. This lead
> to an incorrect linked list structure which caused my issue.
>
> Since this union is empty, I simply removed it from the struct and everything
> worked correctly.
>
> I don't know the history or purpose behind this empty union so I'd like to
> know if this is a safe fix. If it is I can submit a patch with the union
> removed.
That's a very nice catch!
We do not support building tracepoint probe provider with
g++ yet, as stated in lttng-ust(3):
"- Note for C++ support: although an application instrumented with
tracepoints can be compiled with g++, tracepoint probes should be
compiled with gcc (only tested with gcc so far)."
However, if it works fine with this fix, then I'm tempted to take it,
especially because removing the empty union does not appear to affect
the layout of struct lttng_event as seen from liblttng-ust, which must
be compiled with a C compiler, and from probe providers compiled with
a C compiler. So all we are changing is the layout of a probe provider
compiled with a C++ compiler, which is anyway buggy at the moment,
because it is not compatible with the layout expected by liblttng-ust
compiled with a C compiler.
Reported-by: Robert Daniels <[email protected]>
Signed-off-by: Mathieu Desnoyers <[email protected]>
---
include/lttng/ust-events.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/usr/include/lttng/ust-events.h b/usr/include/lttng/ust-events.h
index 328a875..3d7a274 100644
--- a/usr/include/lttng/ust-events.h
+++ b/usr/include/lttng/ust-events.h
@@ -407,8 +407,6 @@ struct lttng_event {
void *_deprecated1;
struct lttng_ctx *ctx;
enum lttng_ust_instrumentation instrumentation;
- union {
- } u;
struct cds_list_head node; /* Event list in session */
struct cds_list_head _deprecated2;
void *_deprecated3;
--
2.7.4
+97
View File
@@ -0,0 +1,97 @@
diff -u -r a/usr/include/urcu/uatomic/generic.h b/usr/include/urcu/uatomic/generic.h
--- a/usr/include/urcu/uatomic/generic.h 2014-03-28 06:04:42.000000000 +0900
+++ b/usr/include/urcu/uatomic/generic.h 2017-02-13 10:35:21.189927116 +0900
@@ -65,17 +65,17 @@
switch (len) {
#ifdef UATOMIC_HAS_ATOMIC_BYTE
case 1:
- return __sync_val_compare_and_swap_1(addr, old, _new);
+ return __sync_val_compare_and_swap_1((uint8_t *) addr, old, _new);
#endif
#ifdef UATOMIC_HAS_ATOMIC_SHORT
case 2:
- return __sync_val_compare_and_swap_2(addr, old, _new);
+ return __sync_val_compare_and_swap_2((uint16_t *) addr, old, _new);
#endif
case 4:
- return __sync_val_compare_and_swap_4(addr, old, _new);
+ return __sync_val_compare_and_swap_4((uint32_t *) addr, old, _new);
#if (CAA_BITS_PER_LONG == 64)
case 8:
- return __sync_val_compare_and_swap_8(addr, old, _new);
+ return __sync_val_compare_and_swap_8((uint64_t *) addr, old, _new);
#endif
}
_uatomic_link_error();
@@ -100,20 +100,20 @@
switch (len) {
#ifdef UATOMIC_HAS_ATOMIC_BYTE
case 1:
- __sync_and_and_fetch_1(addr, val);
+ __sync_and_and_fetch_1((uint8_t *) addr, val);
return;
#endif
#ifdef UATOMIC_HAS_ATOMIC_SHORT
case 2:
- __sync_and_and_fetch_2(addr, val);
+ __sync_and_and_fetch_2((uint16_t *) addr, val);
return;
#endif
case 4:
- __sync_and_and_fetch_4(addr, val);
+ __sync_and_and_fetch_4((uint32_t *) addr, val);
return;
#if (CAA_BITS_PER_LONG == 64)
case 8:
- __sync_and_and_fetch_8(addr, val);
+ __sync_and_and_fetch_8((uint64_t *) addr, val);
return;
#endif
}
@@ -139,20 +139,20 @@
switch (len) {
#ifdef UATOMIC_HAS_ATOMIC_BYTE
case 1:
- __sync_or_and_fetch_1(addr, val);
+ __sync_or_and_fetch_1((uint8_t *) addr, val);
return;
#endif
#ifdef UATOMIC_HAS_ATOMIC_SHORT
case 2:
- __sync_or_and_fetch_2(addr, val);
+ __sync_or_and_fetch_2((uint16_t *) addr, val);
return;
#endif
case 4:
- __sync_or_and_fetch_4(addr, val);
+ __sync_or_and_fetch_4((uint32_t *) addr, val);
return;
#if (CAA_BITS_PER_LONG == 64)
case 8:
- __sync_or_and_fetch_8(addr, val);
+ __sync_or_and_fetch_8((uint64_t *) addr, val);
return;
#endif
}
@@ -180,17 +180,17 @@
switch (len) {
#ifdef UATOMIC_HAS_ATOMIC_BYTE
case 1:
- return __sync_add_and_fetch_1(addr, val);
+ return __sync_add_and_fetch_1((uint8_t *) addr, val);
#endif
#ifdef UATOMIC_HAS_ATOMIC_SHORT
case 2:
- return __sync_add_and_fetch_2(addr, val);
+ return __sync_add_and_fetch_2((uint16_t *) addr, val);
#endif
case 4:
- return __sync_add_and_fetch_4(addr, val);
+ return __sync_add_and_fetch_4((uint32_t *) addr, val);
#if (CAA_BITS_PER_LONG == 64)
case 8:
- return __sync_add_and_fetch_8(addr, val);
+ return __sync_add_and_fetch_8((uint64_t *) addr, val);
#endif
}
_uatomic_link_error();
@@ -0,0 +1,11 @@
deb http://ports.ubuntu.com/ubuntu-ports/ bionic main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ bionic main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ bionic-updates main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ bionic-updates main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ bionic-backports main restricted
deb-src http://ports.ubuntu.com/ubuntu-ports/ bionic-backports main restricted
deb http://ports.ubuntu.com/ubuntu-ports/ bionic-security main restricted universe multiverse
deb-src http://ports.ubuntu.com/ubuntu-ports/ bionic-security main restricted universe multiverse
@@ -0,0 +1,11 @@
deb http://deb.debian.org/debian buster main
deb-src http://deb.debian.org/debian buster main
deb http://deb.debian.org/debian-security/ buster/updates main
deb-src http://deb.debian.org/debian-security/ buster/updates main
deb http://deb.debian.org/debian buster-updates main
deb-src http://deb.debian.org/debian buster-updates main
deb http://deb.debian.org/debian buster-backports main contrib non-free
deb-src http://deb.debian.org/debian buster-backports main contrib non-free
@@ -0,0 +1,12 @@
deb http://deb.debian.org/debian stretch main
deb-src http://deb.debian.org/debian stretch main
deb http://deb.debian.org/debian-security/ stretch/updates main
deb-src http://deb.debian.org/debian-security/ stretch/updates main
deb http://deb.debian.org/debian stretch-updates main
deb-src http://deb.debian.org/debian stretch-updates main
deb http://deb.debian.org/debian stretch-backports main contrib non-free
deb-src http://deb.debian.org/debian stretch-backports main contrib non-free
@@ -0,0 +1,11 @@
deb http://ports.ubuntu.com/ubuntu-ports/ trusty main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ trusty main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ trusty-updates main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ trusty-updates main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ trusty-backports main restricted
deb-src http://ports.ubuntu.com/ubuntu-ports/ trusty-backports main restricted
deb http://ports.ubuntu.com/ubuntu-ports/ trusty-security main restricted universe multiverse
deb-src http://ports.ubuntu.com/ubuntu-ports/ trusty-security main restricted universe multiverse
@@ -0,0 +1,11 @@
deb http://ports.ubuntu.com/ubuntu-ports/ xenial main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ xenial main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ xenial-updates main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ xenial-updates main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ xenial-backports main restricted
deb-src http://ports.ubuntu.com/ubuntu-ports/ xenial-backports main restricted
deb http://ports.ubuntu.com/ubuntu-ports/ xenial-security main restricted universe multiverse
deb-src http://ports.ubuntu.com/ubuntu-ports/ xenial-security main restricted universe multiverse
+11
View File
@@ -0,0 +1,11 @@
deb http://ports.ubuntu.com/ubuntu-ports/ zesty main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ zesty main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ zesty-updates main restricted universe
deb-src http://ports.ubuntu.com/ubuntu-ports/ zesty-updates main restricted universe
deb http://ports.ubuntu.com/ubuntu-ports/ zesty-backports main restricted
deb-src http://ports.ubuntu.com/ubuntu-ports/ zesty-backports main restricted
deb http://ports.ubuntu.com/ubuntu-ports/ zesty-security main restricted universe multiverse
deb-src http://ports.ubuntu.com/ubuntu-ports/ zesty-security main restricted universe multiverse
@@ -0,0 +1,3 @@
# Debian (jessie) # Stable
deb http://ftp.debian.org/debian/ jessie main contrib non-free
deb-src http://ftp.debian.org/debian/ jessie main contrib non-free
@@ -0,0 +1,44 @@
#!/usr/bin/env bash
set -e
__ARM_SOFTFP_CrossDir=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
__TIZEN_CROSSDIR="$__ARM_SOFTFP_CrossDir/tizen"
if [[ -z "$ROOTFS_DIR" ]]; then
echo "ROOTFS_DIR is not defined."
exit 1;
fi
# Clean-up (TODO-Cleanup: We may already delete $ROOTFS_DIR at ./cross/build-rootfs.sh.)
# hk0110
if [ -d "$ROOTFS_DIR" ]; then
umount $ROOTFS_DIR/*
rm -rf $ROOTFS_DIR
fi
TIZEN_TMP_DIR=$ROOTFS_DIR/tizen_tmp
mkdir -p $TIZEN_TMP_DIR
# Download files
echo ">>Start downloading files"
VERBOSE=1 $__ARM_SOFTFP_CrossDir/tizen-fetch.sh $TIZEN_TMP_DIR
echo "<<Finish downloading files"
echo ">>Start constructing Tizen rootfs"
TIZEN_RPM_FILES=`ls $TIZEN_TMP_DIR/*.rpm`
cd $ROOTFS_DIR
for f in $TIZEN_RPM_FILES; do
rpm2cpio $f | cpio -idm --quiet
done
echo "<<Finish constructing Tizen rootfs"
# Cleanup tmp
rm -rf $TIZEN_TMP_DIR
# Configure Tizen rootfs
echo ">>Start configuring Tizen rootfs"
rm ./usr/lib/libunwind.so
ln -s libunwind.so.8 ./usr/lib/libunwind.so
ln -sfn asm-arm ./usr/include/asm
patch -p1 < $__TIZEN_CROSSDIR/tizen.patch
echo "<<Finish configuring Tizen rootfs"
+171
View File
@@ -0,0 +1,171 @@
#!/usr/bin/env bash
set -e
if [[ -z "${VERBOSE// }" ]] || [ "$VERBOSE" -ne "$VERBOSE" ] 2>/dev/null; then
VERBOSE=0
fi
Log()
{
if [ $VERBOSE -ge $1 ]; then
echo ${@:2}
fi
}
Inform()
{
Log 1 -e "\x1B[0;34m$@\x1B[m"
}
Debug()
{
Log 2 -e "\x1B[0;32m$@\x1B[m"
}
Error()
{
>&2 Log 0 -e "\x1B[0;31m$@\x1B[m"
}
Fetch()
{
URL=$1
FILE=$2
PROGRESS=$3
if [ $VERBOSE -ge 1 ] && [ $PROGRESS ]; then
CURL_OPT="--progress-bar"
else
CURL_OPT="--silent"
fi
curl $CURL_OPT $URL > $FILE
}
hash curl 2> /dev/null || { Error "Require 'curl' Aborting."; exit 1; }
hash xmllint 2> /dev/null || { Error "Require 'xmllint' Aborting."; exit 1; }
hash sha256sum 2> /dev/null || { Error "Require 'sha256sum' Aborting."; exit 1; }
TMPDIR=$1
if [ ! -d $TMPDIR ]; then
TMPDIR=./tizen_tmp
Debug "Create temporary directory : $TMPDIR"
mkdir -p $TMPDIR
fi
TIZEN_URL=http://download.tizen.org/releases/milestone/tizen
BUILD_XML=build.xml
REPOMD_XML=repomd.xml
PRIMARY_XML=primary.xml
TARGET_URL="http://__not_initialized"
Xpath_get()
{
XPATH_RESULT=''
XPATH=$1
XML_FILE=$2
RESULT=$(xmllint --xpath $XPATH $XML_FILE)
if [[ -z ${RESULT// } ]]; then
Error "Can not find target from $XML_FILE"
Debug "Xpath = $XPATH"
exit 1
fi
XPATH_RESULT=$RESULT
}
fetch_tizen_pkgs_init()
{
TARGET=$1
PROFILE=$2
Debug "Initialize TARGET=$TARGET, PROFILE=$PROFILE"
TMP_PKG_DIR=$TMPDIR/tizen_${PROFILE}_pkgs
if [ -d $TMP_PKG_DIR ]; then rm -rf $TMP_PKG_DIR; fi
mkdir -p $TMP_PKG_DIR
PKG_URL=$TIZEN_URL/$PROFILE/latest
BUILD_XML_URL=$PKG_URL/$BUILD_XML
TMP_BUILD=$TMP_PKG_DIR/$BUILD_XML
TMP_REPOMD=$TMP_PKG_DIR/$REPOMD_XML
TMP_PRIMARY=$TMP_PKG_DIR/$PRIMARY_XML
TMP_PRIMARYGZ=${TMP_PRIMARY}.gz
Fetch $BUILD_XML_URL $TMP_BUILD
Debug "fetch $BUILD_XML_URL to $TMP_BUILD"
TARGET_XPATH="//build/buildtargets/buildtarget[@name=\"$TARGET\"]/repo[@type=\"binary\"]/text()"
Xpath_get $TARGET_XPATH $TMP_BUILD
TARGET_PATH=$XPATH_RESULT
TARGET_URL=$PKG_URL/$TARGET_PATH
REPOMD_URL=$TARGET_URL/repodata/repomd.xml
PRIMARY_XPATH='string(//*[local-name()="data"][@type="primary"]/*[local-name()="location"]/@href)'
Fetch $REPOMD_URL $TMP_REPOMD
Debug "fetch $REPOMD_URL to $TMP_REPOMD"
Xpath_get $PRIMARY_XPATH $TMP_REPOMD
PRIMARY_XML_PATH=$XPATH_RESULT
PRIMARY_URL=$TARGET_URL/$PRIMARY_XML_PATH
Fetch $PRIMARY_URL $TMP_PRIMARYGZ
Debug "fetch $PRIMARY_URL to $TMP_PRIMARYGZ"
gunzip $TMP_PRIMARYGZ
Debug "unzip $TMP_PRIMARYGZ to $TMP_PRIMARY"
}
fetch_tizen_pkgs()
{
ARCH=$1
PACKAGE_XPATH_TPL='string(//*[local-name()="metadata"]/*[local-name()="package"][*[local-name()="name"][text()="_PKG_"]][*[local-name()="arch"][text()="_ARCH_"]]/*[local-name()="location"]/@href)'
PACKAGE_CHECKSUM_XPATH_TPL='string(//*[local-name()="metadata"]/*[local-name()="package"][*[local-name()="name"][text()="_PKG_"]][*[local-name()="arch"][text()="_ARCH_"]]/*[local-name()="checksum"]/text())'
for pkg in ${@:2}
do
Inform "Fetching... $pkg"
XPATH=${PACKAGE_XPATH_TPL/_PKG_/$pkg}
XPATH=${XPATH/_ARCH_/$ARCH}
Xpath_get $XPATH $TMP_PRIMARY
PKG_PATH=$XPATH_RESULT
XPATH=${PACKAGE_CHECKSUM_XPATH_TPL/_PKG_/$pkg}
XPATH=${XPATH/_ARCH_/$ARCH}
Xpath_get $XPATH $TMP_PRIMARY
CHECKSUM=$XPATH_RESULT
PKG_URL=$TARGET_URL/$PKG_PATH
PKG_FILE=$(basename $PKG_PATH)
PKG_PATH=$TMPDIR/$PKG_FILE
Debug "Download $PKG_URL to $PKG_PATH"
Fetch $PKG_URL $PKG_PATH true
echo "$CHECKSUM $PKG_PATH" | sha256sum -c - > /dev/null
if [ $? -ne 0 ]; then
Error "Fail to fetch $PKG_URL to $PKG_PATH"
Debug "Checksum = $CHECKSUM"
exit 1
fi
done
}
Inform "Initialize arm base"
fetch_tizen_pkgs_init standard base
Inform "fetch common packages"
fetch_tizen_pkgs armv7l gcc glibc glibc-devel libicu libicu-devel libatomic
fetch_tizen_pkgs noarch linux-glibc-devel
Inform "fetch coreclr packages"
fetch_tizen_pkgs armv7l lldb lldb-devel libgcc libstdc++ libstdc++-devel libunwind libunwind-devel lttng-ust-devel lttng-ust userspace-rcu-devel userspace-rcu
Inform "fetch corefx packages"
fetch_tizen_pkgs armv7l libcom_err libcom_err-devel zlib zlib-devel libopenssl libopenssl-devel krb5 krb5-devel libcurl libcurl-devel
Inform "Initialize standard unified"
fetch_tizen_pkgs_init standard unified
Inform "fetch corefx packages"
fetch_tizen_pkgs armv7l gssdp gssdp-devel tizen-release
@@ -0,0 +1,50 @@
lang en_US.UTF-8
keyboard us
timezone --utc Asia/Seoul
part / --fstype="ext4" --size=3500 --ondisk=mmcblk0 --label rootfs --fsoptions=defaults,noatime
rootpw tizen
desktop --autologinuser=root
user --name root --groups audio,video --password 'tizen'
repo --name=standard --baseurl=http://download.tizen.org/releases/milestone/tizen/unified/latest/repos/standard/packages/ --ssl_verify=no
repo --name=base --baseurl=http://download.tizen.org/releases/milestone/tizen/base/latest/repos/standard/packages/ --ssl_verify=no
%packages
tar
gzip
sed
grep
gawk
perl
binutils
findutils
util-linux
lttng-ust
userspace-rcu
procps-ng
tzdata
ca-certificates
### Core FX
libicu
libunwind
iputils
zlib
krb5
libcurl
libopenssl
%end
%post
### Update /tmp privilege
chmod 777 /tmp
####################################
%end
+18
View File
@@ -0,0 +1,18 @@
diff -u -r a/usr/lib/libc.so b/usr/lib/libc.so
--- a/usr/lib/libc.so 2016-12-30 23:00:08.284951863 +0900
+++ b/usr/lib/libc.so 2016-12-30 23:00:32.140951815 +0900
@@ -2,4 +2,4 @@
Use the shared library, but some functions are only in
the static library, so try that secondarily. */
OUTPUT_FORMAT(elf32-littlearm)
-GROUP ( /lib/libc.so.6 /usr/lib/libc_nonshared.a AS_NEEDED ( /lib/ld-linux.so.3 ) )
+GROUP ( libc.so.6 libc_nonshared.a AS_NEEDED ( ld-linux.so.3 ) )
diff -u -r a/usr/lib/libpthread.so b/usr/lib/libpthread.so
--- a/usr/lib/libpthread.so 2016-12-30 23:00:19.408951841 +0900
+++ b/usr/lib/libpthread.so 2016-12-30 23:00:39.068951801 +0900
@@ -2,4 +2,4 @@
Use the shared library, but some functions are only in
the static library, so try that secondarily. */
OUTPUT_FORMAT(elf32-littlearm)
-GROUP ( /lib/libpthread.so.0 /usr/lib/libpthread_nonshared.a )
+GROUP ( libpthread.so.0 libpthread_nonshared.a )
+137
View File
@@ -0,0 +1,137 @@
#!/usr/bin/env bash
set -e
__NDK_Version=r14
usage()
{
echo "Creates a toolchain and sysroot used for cross-compiling for Android."
echo.
echo "Usage: $0 [BuildArch] [ApiLevel]"
echo.
echo "BuildArch is the target architecture of Android. Currently only arm64 is supported."
echo "ApiLevel is the target Android API level. API levels usually match to Android releases. See https://source.android.com/source/build-numbers.html"
echo.
echo "By default, the toolchain and sysroot will be generated in cross/android-rootfs/toolchain/[BuildArch]. You can change this behavior"
echo "by setting the TOOLCHAIN_DIR environment variable"
echo.
echo "By default, the NDK will be downloaded into the cross/android-rootfs/android-ndk-$__NDK_Version directory. If you already have an NDK installation,"
echo "you can set the NDK_DIR environment variable to have this script use that installation of the NDK."
echo "By default, this script will generate a file, android_platform, in the root of the ROOTFS_DIR directory that contains the RID for the supported and tested Android build: android.21-arm64. This file is to replace '/etc/os-release', which is not available for Android."
exit 1
}
__ApiLevel=21 # The minimum platform for arm64 is API level 21
__BuildArch=arm64
__AndroidArch=aarch64
__AndroidToolchain=aarch64-linux-android
for i in "$@"
do
lowerI="$(echo $i | awk '{print tolower($0)}')"
case $lowerI in
-?|-h|--help)
usage
exit 1
;;
arm64)
__BuildArch=arm64
__AndroidArch=aarch64
__AndroidToolchain=aarch64-linux-android
;;
arm)
__BuildArch=arm
__AndroidArch=arm
__AndroidToolchain=arm-linux-androideabi
;;
*[0-9])
__ApiLevel=$i
;;
*)
__UnprocessedBuildArgs="$__UnprocessedBuildArgs $i"
;;
esac
done
# Obtain the location of the bash script to figure out where the root of the repo is.
__CrossDir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
__Android_Cross_Dir="$__CrossDir/android-rootfs"
__NDK_Dir="$__Android_Cross_Dir/android-ndk-$__NDK_Version"
__libunwind_Dir="$__Android_Cross_Dir/libunwind"
__lldb_Dir="$__Android_Cross_Dir/lldb"
__ToolchainDir="$__Android_Cross_Dir/toolchain/$__BuildArch"
if [[ -n "$TOOLCHAIN_DIR" ]]; then
__ToolchainDir=$TOOLCHAIN_DIR
fi
if [[ -n "$NDK_DIR" ]]; then
__NDK_Dir=$NDK_DIR
fi
echo "Target API level: $__ApiLevel"
echo "Target architecture: $__BuildArch"
echo "NDK location: $__NDK_Dir"
echo "Target Toolchain location: $__ToolchainDir"
# Download the NDK if required
if [ ! -d $__NDK_Dir ]; then
echo Downloading the NDK into $__NDK_Dir
mkdir -p $__NDK_Dir
wget -nv -nc --show-progress https://dl.google.com/android/repository/android-ndk-$__NDK_Version-linux-x86_64.zip -O $__Android_Cross_Dir/android-ndk-$__NDK_Version-linux-x86_64.zip
unzip -q $__Android_Cross_Dir/android-ndk-$__NDK_Version-linux-x86_64.zip -d $__Android_Cross_Dir
fi
if [ ! -d $__lldb_Dir ]; then
mkdir -p $__lldb_Dir
echo Downloading LLDB into $__lldb_Dir
wget -nv -nc --show-progress https://dl.google.com/android/repository/lldb-2.3.3614996-linux-x86_64.zip -O $__Android_Cross_Dir/lldb-2.3.3614996-linux-x86_64.zip
unzip -q $__Android_Cross_Dir/lldb-2.3.3614996-linux-x86_64.zip -d $__lldb_Dir
fi
# Create the RootFS for both arm64 as well as aarch
rm -rf $__Android_Cross_Dir/toolchain
echo Generating the $__BuildArch toolchain
$__NDK_Dir/build/tools/make_standalone_toolchain.py --arch $__BuildArch --api $__ApiLevel --install-dir $__ToolchainDir
# Install the required packages into the toolchain
# TODO: Add logic to get latest pkg version instead of specific version number
rm -rf $__Android_Cross_Dir/deb/
rm -rf $__Android_Cross_Dir/tmp
mkdir -p $__Android_Cross_Dir/deb/
mkdir -p $__Android_Cross_Dir/tmp/$arch/
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/libicu_60.2_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/libicu_60.2_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/libicu-dev_60.2_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/libicu-dev_60.2_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/libandroid-glob-dev_0.4_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/libandroid-glob-dev_0.4_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/libandroid-glob_0.4_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/libandroid-glob_0.4_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/libandroid-support-dev_22_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/libandroid-support-dev_22_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/libandroid-support_22_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/libandroid-support_22_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/liblzma-dev_5.2.3_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/liblzma-dev_5.2.3_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/liblzma_5.2.3_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/liblzma_5.2.3_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/libunwind-dev_1.2.20170304_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/libunwind-dev_1.2.20170304_$__AndroidArch.deb
wget -nv -nc http://termux.net/dists/stable/main/binary-$__AndroidArch/libunwind_1.2.20170304_$__AndroidArch.deb -O $__Android_Cross_Dir/deb/libunwind_1.2.20170304_$__AndroidArch.deb
echo Unpacking Termux packages
dpkg -x $__Android_Cross_Dir/deb/libicu_60.2_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/libicu-dev_60.2_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/libandroid-glob-dev_0.4_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/libandroid-glob_0.4_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/libandroid-support-dev_22_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/libandroid-support_22_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/liblzma-dev_5.2.3_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/liblzma_5.2.3_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/libunwind-dev_1.2.20170304_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
dpkg -x $__Android_Cross_Dir/deb/libunwind_1.2.20170304_$__AndroidArch.deb $__Android_Cross_Dir/tmp/$__AndroidArch/
cp -R $__Android_Cross_Dir/tmp/$__AndroidArch/data/data/com.termux/files/usr/* $__ToolchainDir/sysroot/usr/
# Generate platform file for build.sh script to assign to __DistroRid
echo "Generating platform file..."
echo "RID=android.21-arm64" > $__ToolchainDir/sysroot/android_platform
echo Now run:
echo CONFIG_DIR=\`realpath cross/android/$__BuildArch\` ROOTFS_DIR=\`realpath $__ToolchainDir/sysroot\` ./build.sh cross $__BuildArch skipgenerateversion skipnuget cmakeargs -DENABLE_LLDBPLUGIN=0
+234
View File
@@ -0,0 +1,234 @@
#!/usr/bin/env bash
usage()
{
echo "Usage: $0 [BuildArch] [LinuxCodeName] [lldbx.y] [--skipunmount] --rootfsdir <directory>]"
echo "BuildArch can be: arm(default), armel, arm64, x86"
echo "LinuxCodeName - optional, Code name for Linux, can be: trusty, xenial(default), zesty, bionic, alpine. If BuildArch is armel, LinuxCodeName is jessie(default) or tizen."
echo "lldbx.y - optional, LLDB version, can be: lldb3.9(default), lldb4.0, lldb5.0, lldb6.0 no-lldb. Ignored for alpine"
echo "--skipunmount - optional, will skip the unmount of rootfs folder."
exit 1
}
__LinuxCodeName=xenial
__CrossDir=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
__InitialDir=$PWD
__BuildArch=arm
__UbuntuArch=armhf
__UbuntuRepo="http://ports.ubuntu.com/"
__LLDB_Package="liblldb-3.9-dev"
__SkipUnmount=0
# base development support
__UbuntuPackages="build-essential"
__AlpinePackages="alpine-base"
__AlpinePackages+=" build-base"
__AlpinePackages+=" linux-headers"
__AlpinePackages+=" lldb-dev"
__AlpinePackages+=" llvm-dev"
# symlinks fixer
__UbuntuPackages+=" symlinks"
# CoreCLR and CoreFX dependencies
__UbuntuPackages+=" libicu-dev"
__UbuntuPackages+=" liblttng-ust-dev"
__UbuntuPackages+=" libunwind8-dev"
__AlpinePackages+=" gettext-dev"
__AlpinePackages+=" icu-dev"
__AlpinePackages+=" libunwind-dev"
__AlpinePackages+=" lttng-ust-dev"
# CoreFX dependencies
__UbuntuPackages+=" libcurl4-openssl-dev"
__UbuntuPackages+=" libkrb5-dev"
__UbuntuPackages+=" libssl-dev"
__UbuntuPackages+=" zlib1g-dev"
__AlpinePackages+=" curl-dev"
__AlpinePackages+=" krb5-dev"
__AlpinePackages+=" openssl-dev"
__AlpinePackages+=" zlib-dev"
__UnprocessedBuildArgs=
while :; do
if [ $# -le 0 ]; then
break
fi
lowerI="$(echo $1 | awk '{print tolower($0)}')"
case $lowerI in
-?|-h|--help)
usage
exit 1
;;
arm)
__BuildArch=arm
__UbuntuArch=armhf
__AlpineArch=armhf
__QEMUArch=arm
;;
arm64)
__BuildArch=arm64
__UbuntuArch=arm64
__AlpineArch=aarch64
__QEMUArch=aarch64
;;
armel)
__BuildArch=armel
__UbuntuArch=armel
__UbuntuRepo="http://ftp.debian.org/debian/"
__LinuxCodeName=jessie
;;
x86)
__BuildArch=x86
__UbuntuArch=i386
__UbuntuRepo="http://archive.ubuntu.com/ubuntu/"
;;
lldb3.6)
__LLDB_Package="lldb-3.6-dev"
;;
lldb3.8)
__LLDB_Package="lldb-3.8-dev"
;;
lldb3.9)
__LLDB_Package="liblldb-3.9-dev"
;;
lldb4.0)
__LLDB_Package="liblldb-4.0-dev"
;;
lldb5.0)
__LLDB_Package="liblldb-5.0-dev"
;;
lldb6.0)
__LLDB_Package="liblldb-6.0-dev"
;;
no-lldb)
unset __LLDB_Package
;;
trusty) # Ubuntu 14.04
if [ "$__LinuxCodeName" != "jessie" ]; then
__LinuxCodeName=trusty
fi
;;
xenial) # Ubuntu 16.04
if [ "$__LinuxCodeName" != "jessie" ]; then
__LinuxCodeName=xenial
fi
;;
zesty) # Ubuntu 17.04
if [ "$__LinuxCodeName" != "jessie" ]; then
__LinuxCodeName=zesty
fi
;;
bionic) # Ubuntu 18.04
if [ "$__LinuxCodeName" != "jessie" ]; then
__LinuxCodeName=bionic
fi
;;
jessie) # Debian 8
__LinuxCodeName=jessie
__UbuntuRepo="http://ftp.debian.org/debian/"
;;
stretch) # Debian 9
__LinuxCodeName=stretch
__UbuntuRepo="http://ftp.debian.org/debian/"
__LLDB_Package="liblldb-6.0-dev"
;;
buster) # Debian 10
__LinuxCodeName=buster
__UbuntuRepo="http://ftp.debian.org/debian/"
__LLDB_Package="liblldb-6.0-dev"
;;
tizen)
if [ "$__BuildArch" != "armel" ]; then
echo "Tizen is available only for armel."
usage;
exit 1;
fi
__LinuxCodeName=
__UbuntuRepo=
__Tizen=tizen
;;
alpine)
__LinuxCodeName=alpine
__UbuntuRepo=
;;
--skipunmount)
__SkipUnmount=1
;;
--rootfsdir|-rootfsdir)
shift
__RootfsDir=$1
;;
*)
__UnprocessedBuildArgs="$__UnprocessedBuildArgs $1"
;;
esac
shift
done
if [ "$__BuildArch" == "armel" ]; then
__LLDB_Package="lldb-3.5-dev"
fi
__UbuntuPackages+=" ${__LLDB_Package:-}"
if [ -z "$__RootfsDir" ] && [ ! -z "$ROOTFS_DIR" ]; then
__RootfsDir=$ROOTFS_DIR
fi
if [ -z "$__RootfsDir" ]; then
__RootfsDir="$__CrossDir/../../../.tools/rootfs/$__BuildArch"
fi
if [ -d "$__RootfsDir" ]; then
if [ $__SkipUnmount == 0 ]; then
umount $__RootfsDir/*
fi
rm -rf $__RootfsDir
fi
if [[ "$__LinuxCodeName" == "alpine" ]]; then
__ApkToolsVersion=2.9.1
__AlpineVersion=3.7
__ApkToolsDir=$(mktemp -d)
wget https://github.com/alpinelinux/apk-tools/releases/download/v$__ApkToolsVersion/apk-tools-$__ApkToolsVersion-x86_64-linux.tar.gz -P $__ApkToolsDir
tar -xf $__ApkToolsDir/apk-tools-$__ApkToolsVersion-x86_64-linux.tar.gz -C $__ApkToolsDir
mkdir -p $__RootfsDir/usr/bin
cp -v /usr/bin/qemu-$__QEMUArch-static $__RootfsDir/usr/bin
$__ApkToolsDir/apk-tools-$__ApkToolsVersion/apk \
-X http://dl-cdn.alpinelinux.org/alpine/v$__AlpineVersion/main \
-X http://dl-cdn.alpinelinux.org/alpine/v$__AlpineVersion/community \
-X http://dl-cdn.alpinelinux.org/alpine/edge/testing \
-X http://dl-cdn.alpinelinux.org/alpine/edge/main \
-U --allow-untrusted --root $__RootfsDir --arch $__AlpineArch --initdb \
add $__AlpinePackages
rm -r $__ApkToolsDir
elif [[ -n $__LinuxCodeName ]]; then
qemu-debootstrap --arch $__UbuntuArch $__LinuxCodeName $__RootfsDir $__UbuntuRepo
cp $__CrossDir/$__BuildArch/sources.list.$__LinuxCodeName $__RootfsDir/etc/apt/sources.list
chroot $__RootfsDir apt-get update
chroot $__RootfsDir apt-get -f -y install
chroot $__RootfsDir apt-get -y install $__UbuntuPackages
chroot $__RootfsDir symlinks -cr /usr
if [ $__SkipUnmount == 0 ]; then
umount $__RootfsDir/*
fi
if [[ "$__BuildArch" == "arm" && "$__LinuxCodeName" == "trusty" ]]; then
pushd $__RootfsDir
patch -p1 < $__CrossDir/$__BuildArch/trusty.patch
patch -p1 < $__CrossDir/$__BuildArch/trusty-lttng-2.4.patch
popd
fi
elif [ "$__Tizen" == "tizen" ]; then
ROOTFS_DIR=$__RootfsDir $__CrossDir/$__BuildArch/tizen-build-rootfs.sh
else
echo "Unsupported target platform."
usage;
exit 1
fi
+119
View File
@@ -0,0 +1,119 @@
set(CROSS_ROOTFS $ENV{ROOTFS_DIR})
set(TARGET_ARCH_NAME $ENV{TARGET_BUILD_ARCH})
set(CMAKE_SYSTEM_NAME Linux)
set(CMAKE_SYSTEM_VERSION 1)
if(TARGET_ARCH_NAME STREQUAL "armel")
set(CMAKE_SYSTEM_PROCESSOR armv7l)
set(TOOLCHAIN "arm-linux-gnueabi")
if("$ENV{__DistroRid}" MATCHES "tizen.*")
set(TIZEN_TOOLCHAIN "armv7l-tizen-linux-gnueabi/6.2.1")
endif()
elseif(TARGET_ARCH_NAME STREQUAL "arm")
set(CMAKE_SYSTEM_PROCESSOR armv7l)
if(EXISTS ${CROSS_ROOTFS}/usr/lib/gcc/armv6-alpine-linux-musleabihf)
set(TOOLCHAIN "armv6-alpine-linux-musleabihf")
else()
set(TOOLCHAIN "arm-linux-gnueabihf")
endif()
elseif(TARGET_ARCH_NAME STREQUAL "arm64")
set(CMAKE_SYSTEM_PROCESSOR aarch64)
if(EXISTS ${CROSS_ROOTFS}/usr/lib/gcc/aarch64-alpine-linux-musl)
set(TOOLCHAIN "aarch64-alpine-linux-musl")
else()
set(TOOLCHAIN "aarch64-linux-gnu")
endif()
elseif(TARGET_ARCH_NAME STREQUAL "x86")
set(CMAKE_SYSTEM_PROCESSOR i686)
set(TOOLCHAIN "i686-linux-gnu")
else()
message(FATAL_ERROR "Arch is ${TARGET_ARCH_NAME}. Only armel, arm, arm64 and x86 are supported!")
endif()
if(DEFINED ENV{TOOLCHAIN})
set(TOOLCHAIN $ENV{TOOLCHAIN})
endif()
# Specify include paths
if(TARGET_ARCH_NAME STREQUAL "armel")
if(DEFINED TIZEN_TOOLCHAIN)
include_directories(SYSTEM ${CROSS_ROOTFS}/usr/lib/gcc/${TIZEN_TOOLCHAIN}/include/c++/)
include_directories(SYSTEM ${CROSS_ROOTFS}/usr/lib/gcc/${TIZEN_TOOLCHAIN}/include/c++/armv7l-tizen-linux-gnueabi)
endif()
endif()
set(CMAKE_SYSROOT "${CROSS_ROOTFS}")
set(CMAKE_C_COMPILER_EXTERNAL_TOOLCHAIN "${CROSS_ROOTFS}/usr")
set(CMAKE_CXX_COMPILER_EXTERNAL_TOOLCHAIN "${CROSS_ROOTFS}/usr")
set(CMAKE_ASM_COMPILER_EXTERNAL_TOOLCHAIN "${CROSS_ROOTFS}/usr")
# Specify link flags
if(TARGET_ARCH_NAME STREQUAL "armel")
if(DEFINED TIZEN_TOOLCHAIN) # For Tizen only
add_link_options("-B${CROSS_ROOTFS}/usr/lib/gcc/${TIZEN_TOOLCHAIN}")
add_link_options("-L${CROSS_ROOTFS}/lib")
add_link_options("-L${CROSS_ROOTFS}/usr/lib")
add_link_options("-L${CROSS_ROOTFS}/usr/lib/gcc/${TIZEN_TOOLCHAIN}")
endif()
elseif(TARGET_ARCH_NAME STREQUAL "x86")
add_link_options(-m32)
endif()
# Specify compile options
if(TARGET_ARCH_NAME MATCHES "^(arm|armel|arm64)$")
set(CMAKE_C_COMPILER_TARGET ${TOOLCHAIN})
set(CMAKE_CXX_COMPILER_TARGET ${TOOLCHAIN})
set(CMAKE_ASM_COMPILER_TARGET ${TOOLCHAIN})
endif()
if(TARGET_ARCH_NAME MATCHES "^(arm|armel)$")
add_compile_options(-mthumb)
add_compile_options(-mfpu=vfpv3)
if(TARGET_ARCH_NAME STREQUAL "armel")
add_compile_options(-mfloat-abi=softfp)
if(DEFINED TIZEN_TOOLCHAIN)
add_compile_options(-Wno-deprecated-declarations) # compile-time option
add_compile_options(-D__extern_always_inline=inline) # compile-time option
endif()
endif()
elseif(TARGET_ARCH_NAME STREQUAL "x86")
add_compile_options(-m32)
add_compile_options(-Wno-error=unused-command-line-argument)
endif()
# Set LLDB include and library paths for builds that need lldb.
if(TARGET_ARCH_NAME MATCHES "^(arm|armel|x86)$")
if(TARGET_ARCH_NAME STREQUAL "x86")
set(LLVM_CROSS_DIR "$ENV{LLVM_CROSS_HOME}")
else() # arm/armel case
set(LLVM_CROSS_DIR "$ENV{LLVM_ARM_HOME}")
endif()
if(LLVM_CROSS_DIR)
set(WITH_LLDB_LIBS "${LLVM_CROSS_DIR}/lib/" CACHE STRING "")
set(WITH_LLDB_INCLUDES "${LLVM_CROSS_DIR}/include" CACHE STRING "")
set(LLDB_H "${WITH_LLDB_INCLUDES}" CACHE STRING "")
set(LLDB "${LLVM_CROSS_DIR}/lib/liblldb.so" CACHE STRING "")
else()
if(TARGET_ARCH_NAME STREQUAL "x86")
set(WITH_LLDB_LIBS "${CROSS_ROOTFS}/usr/lib/i386-linux-gnu" CACHE STRING "")
set(CHECK_LLVM_DIR "${CROSS_ROOTFS}/usr/lib/llvm-3.8/include")
if(EXISTS "${CHECK_LLVM_DIR}" AND IS_DIRECTORY "${CHECK_LLVM_DIR}")
set(WITH_LLDB_INCLUDES "${CHECK_LLVM_DIR}")
else()
set(WITH_LLDB_INCLUDES "${CROSS_ROOTFS}/usr/lib/llvm-3.6/include")
endif()
else() # arm/armel case
set(WITH_LLDB_LIBS "${CROSS_ROOTFS}/usr/lib/${TOOLCHAIN}" CACHE STRING "")
set(WITH_LLDB_INCLUDES "${CROSS_ROOTFS}/usr/lib/llvm-3.6/include" CACHE STRING "")
endif()
endif()
endif()
set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM NEVER)
set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
set(CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY)
+11
View File
@@ -0,0 +1,11 @@
deb http://archive.ubuntu.com/ubuntu/ bionic main restricted universe
deb-src http://archive.ubuntu.com/ubuntu/ bionic main restricted universe
deb http://archive.ubuntu.com/ubuntu/ bionic-updates main restricted universe
deb-src http://archive.ubuntu.com/ubuntu/ bionic-updates main restricted universe
deb http://archive.ubuntu.com/ubuntu/ bionic-backports main restricted
deb-src http://archive.ubuntu.com/ubuntu/ bionic-backports main restricted
deb http://archive.ubuntu.com/ubuntu/ bionic-security main restricted universe multiverse
deb-src http://archive.ubuntu.com/ubuntu/ bionic-security main restricted universe multiverse
+11
View File
@@ -0,0 +1,11 @@
deb http://archive.ubuntu.com/ubuntu/ trusty main restricted universe
deb-src http://archive.ubuntu.com/ubuntu/ trusty main restricted universe
deb http://archive.ubuntu.com/ubuntu/ trusty-updates main restricted universe
deb-src http://archive.ubuntu.com/ubuntu/ trusty-updates main restricted universe
deb http://archive.ubuntu.com/ubuntu/ trusty-backports main restricted
deb-src http://archive.ubuntu.com/ubuntu/ trusty-backports main restricted
deb http://archive.ubuntu.com/ubuntu/ trusty-security main restricted universe multiverse
deb-src http://archive.ubuntu.com/ubuntu/ trusty-security main restricted universe multiverse
+11
View File
@@ -0,0 +1,11 @@
deb http://archive.ubuntu.com/ubuntu/ xenial main restricted universe
deb-src http://archive.ubuntu.com/ubuntu/ xenial main restricted universe
deb http://archive.ubuntu.com/ubuntu/ xenial-updates main restricted universe
deb-src http://archive.ubuntu.com/ubuntu/ xenial-updates main restricted universe
deb http://archive.ubuntu.com/ubuntu/ xenial-backports main restricted
deb-src http://archive.ubuntu.com/ubuntu/ xenial-backports main restricted
deb http://archive.ubuntu.com/ubuntu/ xenial-security main restricted universe multiverse
deb-src http://archive.ubuntu.com/ubuntu/ xenial-security main restricted universe multiverse
+38
View File
@@ -0,0 +1,38 @@
param (
$darcVersion = $null,
$versionEndpoint = "https://maestro-prod.westus2.cloudapp.azure.com/api/assets/darc-version?api-version=2019-01-16",
$verbosity = "m",
$toolpath = $null
)
. $PSScriptRoot\tools.ps1
function InstallDarcCli ($darcVersion) {
$darcCliPackageName = "microsoft.dotnet.darc"
$dotnetRoot = InitializeDotNetCli -install:$true
$dotnet = "$dotnetRoot\dotnet.exe"
$toolList = & "$dotnet" tool list -g
if ($toolList -like "*$darcCliPackageName*") {
& "$dotnet" tool uninstall $darcCliPackageName -g
}
# If the user didn't explicitly specify the darc version,
# query the Maestro API for the correct version of darc to install.
if (-not $darcVersion) {
$darcVersion = $(Invoke-WebRequest -Uri $versionEndpoint -UseBasicParsing).Content
}
$arcadeServicesSource = 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json'
Write-Host "Installing Darc CLI version $darcVersion..."
Write-Host "You may need to restart your command window if this is the first dotnet tool you have installed."
if (-not $toolpath) {
& "$dotnet" tool install $darcCliPackageName --version $darcVersion --add-source "$arcadeServicesSource" -v $verbosity -g
}else {
& "$dotnet" tool install $darcCliPackageName --version $darcVersion --add-source "$arcadeServicesSource" -v $verbosity --tool-path "$toolpath"
}
}
InstallDarcCli $darcVersion
+82
View File
@@ -0,0 +1,82 @@
#!/usr/bin/env bash
source="${BASH_SOURCE[0]}"
darcVersion=''
versionEndpoint="https://maestro-prod.westus2.cloudapp.azure.com/api/assets/darc-version?api-version=2019-01-16"
verbosity=m
while [[ $# > 0 ]]; do
opt="$(echo "$1" | awk '{print tolower($0)}')"
case "$opt" in
--darcversion)
darcVersion=$2
shift
;;
--versionendpoint)
versionEndpoint=$2
shift
;;
--verbosity)
verbosity=$2
shift
;;
--toolpath)
toolpath=$2
shift
;;
*)
echo "Invalid argument: $1"
usage
exit 1
;;
esac
shift
done
# resolve $source until the file is no longer a symlink
while [[ -h "$source" ]]; do
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
source="$(readlink "$source")"
# if $source was a relative symlink, we need to resolve it relative to the path where the
# symlink file was located
[[ $source != /* ]] && source="$scriptroot/$source"
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
. "$scriptroot/tools.sh"
if [ -z "$darcVersion" ]; then
darcVersion=$(curl -X GET "$versionEndpoint" -H "accept: text/plain")
fi
function InstallDarcCli {
local darc_cli_package_name="microsoft.dotnet.darc"
InitializeDotNetCli
local dotnet_root=$_InitializeDotNetCli
if [ -z "$toolpath" ]; then
local tool_list=$($dotnet_root/dotnet tool list -g)
if [[ $tool_list = *$darc_cli_package_name* ]]; then
echo $($dotnet_root/dotnet tool uninstall $darc_cli_package_name -g)
fi
else
local tool_list=$($dotnet_root/dotnet tool list --tool-path "$toolpath")
if [[ $tool_list = *$darc_cli_package_name* ]]; then
echo $($dotnet_root/dotnet tool uninstall $darc_cli_package_name --tool-path "$toolpath")
fi
fi
local arcadeServicesSource="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json"
echo "Installing Darc CLI version $darcVersion..."
echo "You may need to restart your command shell if this is the first dotnet tool you have installed."
if [ -z "$toolpath" ]; then
echo $($dotnet_root/dotnet tool install $darc_cli_package_name --version $darcVersion --add-source "$arcadeServicesSource" -v $verbosity -g)
else
echo $($dotnet_root/dotnet tool install $darc_cli_package_name --version $darcVersion --add-source "$arcadeServicesSource" -v $verbosity --tool-path "$toolpath")
fi
}
InstallDarcCli
+2
View File
@@ -0,0 +1,2 @@
@echo off
powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0dotnet-install.ps1""" %*"
+29
View File
@@ -0,0 +1,29 @@
[CmdletBinding(PositionalBinding=$false)]
Param(
[string] $verbosity = "minimal",
[string] $architecture = "",
[string] $version = "Latest",
[string] $runtime = "dotnet",
[string] $RuntimeSourceFeed = "",
[string] $RuntimeSourceFeedKey = ""
)
. $PSScriptRoot\tools.ps1
$dotnetRoot = Join-Path $RepoRoot ".dotnet"
$installdir = $dotnetRoot
try {
if ($architecture -and $architecture.Trim() -eq "x86") {
$installdir = Join-Path $installdir "x86"
}
InstallDotNet $installdir $version $architecture $runtime $true -RuntimeSourceFeed $RuntimeSourceFeed -RuntimeSourceFeedKey $RuntimeSourceFeedKey
}
catch {
Write-Host $_
Write-Host $_.Exception
Write-Host $_.ScriptStackTrace
ExitWithExitCode 1
}
ExitWithExitCode 0
+88
View File
@@ -0,0 +1,88 @@
#!/usr/bin/env bash
source="${BASH_SOURCE[0]}"
# resolve $source until the file is no longer a symlink
while [[ -h "$source" ]]; do
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
source="$(readlink "$source")"
# if $source was a relative symlink, we need to resolve it relative to the path where the
# symlink file was located
[[ $source != /* ]] && source="$scriptroot/$source"
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
version='Latest'
architecture=''
runtime='dotnet'
runtimeSourceFeed=''
runtimeSourceFeedKey=''
while [[ $# > 0 ]]; do
opt="$(echo "$1" | awk '{print tolower($0)}')"
case "$opt" in
-version|-v)
shift
version="$1"
;;
-architecture|-a)
shift
architecture="$1"
;;
-runtime|-r)
shift
runtime="$1"
;;
-runtimesourcefeed)
shift
runtimeSourceFeed="$1"
;;
-runtimesourcefeedkey)
shift
runtimeSourceFeedKey="$1"
;;
*)
echo "Invalid argument: $1"
exit 1
;;
esac
shift
done
# Use uname to determine what the CPU is.
cpuname=$(uname -p)
# Some Linux platforms report unknown for platform, but the arch for machine.
if [[ "$cpuname" == "unknown" ]]; then
cpuname=$(uname -m)
fi
case $cpuname in
aarch64)
buildarch=arm64
;;
amd64|x86_64)
buildarch=x64
;;
armv7l)
buildarch=arm
;;
i686)
buildarch=x86
;;
*)
echo "Unknown CPU $cpuname detected, treating it as x64"
buildarch=x64
;;
esac
. "$scriptroot/tools.sh"
dotnetRoot="$repo_root/.dotnet"
if [[ $architecture != "" ]] && [[ $architecture != $buildarch ]]; then
dotnetRoot="$dotnetRoot/$architecture"
fi
InstallDotNet $dotnetRoot $version "$architecture" $runtime true $runtimeSourceFeed $runtimeSourceFeedKey || {
local exit_code=$?
echo "dotnet-install.sh failed (exit code '$exit_code')." >&2
ExitWithExitCode $exit_code
}
ExitWithExitCode 0
@@ -0,0 +1,6 @@
param(
[string] $token
)
Write-Host "##vso[task.setvariable variable=VSS_NUGET_ACCESSTOKEN]$token"
Write-Host "##vso[task.setvariable variable=VSS_NUGET_URI_PREFIXES]https://dnceng.pkgs.visualstudio.com/;https://pkgs.dev.azure.com/dnceng/;https://devdiv.pkgs.visualstudio.com/;https://pkgs.dev.azure.com/devdiv/"
+87
View File
@@ -0,0 +1,87 @@
Param(
[Parameter(Mandatory=$true)][string] $barToken, # Token generated at https://maestro-prod.westus2.cloudapp.azure.com/Account/Tokens
[Parameter(Mandatory=$true)][string] $gitHubPat, # GitHub personal access token from https://github.com/settings/tokens (no auth scopes needed)
[Parameter(Mandatory=$true)][string] $azdoPat, # Azure Dev Ops tokens from https://dev.azure.com/dnceng/_details/security/tokens (code read scope needed)
[Parameter(Mandatory=$true)][string] $outputFolder, # Where the graphviz.txt file will be created
[string] $darcVersion = '1.1.0-beta.19175.6', # darc's version
[string] $graphvizVersion = '2.38', # GraphViz version
[switch] $includeToolset # Whether the graph should include toolset dependencies or not. i.e. arcade, optimization. For more about
# toolset dependencies see https://github.com/dotnet/arcade/blob/master/Documentation/Darc.md#toolset-vs-product-dependencies
)
$ErrorActionPreference = "Stop"
. $PSScriptRoot\tools.ps1
Import-Module -Name (Join-Path $PSScriptRoot "native\CommonLibrary.psm1")
function CheckExitCode ([string]$stage)
{
$exitCode = $LASTEXITCODE
if ($exitCode -ne 0) {
Write-Host "Something failed in stage: '$stage'. Check for errors above. Exiting now..."
ExitWithExitCode $exitCode
}
}
try {
Push-Location $PSScriptRoot
Write-Host "Installing darc..."
. .\darc-init.ps1 -darcVersion $darcVersion
CheckExitCode "Running darc-init"
$engCommonBaseDir = Join-Path $PSScriptRoot "native\"
$graphvizInstallDir = CommonLibrary\Get-NativeInstallDirectory
$nativeToolBaseUri = "https://netcorenativeassets.blob.core.windows.net/resource-packages/external"
$installBin = Join-Path $graphvizInstallDir "bin"
Write-Host "Installing dot..."
.\native\install-tool.ps1 -ToolName graphviz -InstallPath $installBin -BaseUri $nativeToolBaseUri -CommonLibraryDirectory $engCommonBaseDir -Version $graphvizVersion -Verbose
$darcExe = "$env:USERPROFILE\.dotnet\tools"
$darcExe = Resolve-Path "$darcExe\darc.exe"
Create-Directory $outputFolder
# Generate 3 graph descriptions:
# 1. Flat with coherency information
# 2. Graphviz (dot) file
# 3. Standard dependency graph
$graphVizFilePath = "$outputFolder\graphviz.txt"
$graphVizImageFilePath = "$outputFolder\graph.png"
$normalGraphFilePath = "$outputFolder\graph-full.txt"
$flatGraphFilePath = "$outputFolder\graph-flat.txt"
$baseOptions = @( "--github-pat", "$gitHubPat", "--azdev-pat", "$azdoPat", "--password", "$barToken" )
if ($includeToolset) {
Write-Host "Toolsets will be included in the graph..."
$baseOptions += @( "--include-toolset" )
}
Write-Host "Generating standard dependency graph..."
& "$darcExe" get-dependency-graph @baseOptions --output-file $normalGraphFilePath
CheckExitCode "Generating normal dependency graph"
Write-Host "Generating flat dependency graph and graphviz file..."
& "$darcExe" get-dependency-graph @baseOptions --flat --coherency --graphviz $graphVizFilePath --output-file $flatGraphFilePath
CheckExitCode "Generating flat and graphviz dependency graph"
Write-Host "Generating graph image $graphVizFilePath"
$dotFilePath = Join-Path $installBin "graphviz\$graphvizVersion\release\bin\dot.exe"
& "$dotFilePath" -Tpng -o"$graphVizImageFilePath" "$graphVizFilePath"
CheckExitCode "Generating graphviz image"
Write-Host "'$graphVizFilePath', '$flatGraphFilePath', '$normalGraphFilePath' and '$graphVizImageFilePath' created!"
}
catch {
if (!$includeToolset) {
Write-Host "This might be a toolset repo which includes only toolset dependencies. " -NoNewline -ForegroundColor Yellow
Write-Host "Since -includeToolset is not set there is no graph to create. Include -includeToolset and try again..." -ForegroundColor Yellow
}
Write-Host $_
Write-Host $_.Exception
Write-Host $_.ScriptStackTrace
ExitWithExitCode 1
} finally {
Pop-Location
}
+26
View File
@@ -0,0 +1,26 @@
<Project Sdk="Microsoft.DotNet.Helix.Sdk" DefaultTargets="Test">
<PropertyGroup>
<Language>msbuild</Language>
</PropertyGroup>
<ItemGroup>
<HelixCorrelationPayload Include="$(CorrelationPayloadDirectory)">
<PayloadDirectory>%(Identity)</PayloadDirectory>
</HelixCorrelationPayload>
</ItemGroup>
<ItemGroup>
<HelixWorkItem Include="WorkItem" Condition="'$(WorkItemDirectory)' != ''">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<Command>$(WorkItemCommand)</Command>
<Timeout Condition="'$(WorkItemTimeout)' != ''">$(WorkItemTimeout)</Timeout>
</HelixWorkItem>
</ItemGroup>
<ItemGroup>
<XUnitProject Include="$(XUnitProjects.Split(';'))">
<Arguments />
</XUnitProject>
</ItemGroup>
</Project>
+3
View File
@@ -0,0 +1,3 @@
@echo off
powershell -NoProfile -NoLogo -ExecutionPolicy ByPass -command "& """%~dp0init-tools-native.ps1""" %*"
exit /b %ErrorLevel%
+148
View File
@@ -0,0 +1,148 @@
<#
.SYNOPSIS
Entry point script for installing native tools
.DESCRIPTION
Reads $RepoRoot\global.json file to determine native assets to install
and executes installers for those tools
.PARAMETER BaseUri
Base file directory or Url from which to acquire tool archives
.PARAMETER InstallDirectory
Directory to install native toolset. This is a command-line override for the default
Install directory precedence order:
- InstallDirectory command-line override
- NETCOREENG_INSTALL_DIRECTORY environment variable
- (default) %USERPROFILE%/.netcoreeng/native
.PARAMETER Clean
Switch specifying to not install anything, but cleanup native asset folders
.PARAMETER Force
Clean and then install tools
.PARAMETER DownloadRetries
Total number of retry attempts
.PARAMETER RetryWaitTimeInSeconds
Wait time between retry attempts in seconds
.PARAMETER GlobalJsonFile
File path to global.json file
.NOTES
#>
[CmdletBinding(PositionalBinding=$false)]
Param (
[string] $BaseUri = "https://netcorenativeassets.blob.core.windows.net/resource-packages/external",
[string] $InstallDirectory,
[switch] $Clean = $False,
[switch] $Force = $False,
[int] $DownloadRetries = 5,
[int] $RetryWaitTimeInSeconds = 30,
[string] $GlobalJsonFile
)
if (!$GlobalJsonFile) {
$GlobalJsonFile = Join-Path (Get-Item $PSScriptRoot).Parent.Parent.FullName "global.json"
}
Set-StrictMode -version 2.0
$ErrorActionPreference="Stop"
Import-Module -Name (Join-Path $PSScriptRoot "native\CommonLibrary.psm1")
try {
# Define verbose switch if undefined
$Verbose = $VerbosePreference -Eq "Continue"
$EngCommonBaseDir = Join-Path $PSScriptRoot "native\"
$NativeBaseDir = $InstallDirectory
if (!$NativeBaseDir) {
$NativeBaseDir = CommonLibrary\Get-NativeInstallDirectory
}
$Env:CommonLibrary_NativeInstallDir = $NativeBaseDir
$InstallBin = Join-Path $NativeBaseDir "bin"
$InstallerPath = Join-Path $EngCommonBaseDir "install-tool.ps1"
# Process tools list
Write-Host "Processing $GlobalJsonFile"
If (-Not (Test-Path $GlobalJsonFile)) {
Write-Host "Unable to find '$GlobalJsonFile'"
exit 0
}
$NativeTools = Get-Content($GlobalJsonFile) -Raw |
ConvertFrom-Json |
Select-Object -Expand "native-tools" -ErrorAction SilentlyContinue
if ($NativeTools) {
$NativeTools.PSObject.Properties | ForEach-Object {
$ToolName = $_.Name
$ToolVersion = $_.Value
$LocalInstallerArguments = @{ ToolName = "$ToolName" }
$LocalInstallerArguments += @{ InstallPath = "$InstallBin" }
$LocalInstallerArguments += @{ BaseUri = "$BaseUri" }
$LocalInstallerArguments += @{ CommonLibraryDirectory = "$EngCommonBaseDir" }
$LocalInstallerArguments += @{ Version = "$ToolVersion" }
if ($Verbose) {
$LocalInstallerArguments += @{ Verbose = $True }
}
if (Get-Variable 'Force' -ErrorAction 'SilentlyContinue') {
if($Force) {
$LocalInstallerArguments += @{ Force = $True }
}
}
if ($Clean) {
$LocalInstallerArguments += @{ Clean = $True }
}
Write-Verbose "Installing $ToolName version $ToolVersion"
Write-Verbose "Executing '$InstallerPath $($LocalInstallerArguments.Keys.ForEach({"-$_ '$($LocalInstallerArguments.$_)'"}) -join ' ')'"
& $InstallerPath @LocalInstallerArguments
if ($LASTEXITCODE -Ne "0") {
$errMsg = "$ToolName installation failed"
if ((Get-Variable 'DoNotAbortNativeToolsInstallationOnFailure' -ErrorAction 'SilentlyContinue') -and $DoNotAbortNativeToolsInstallationOnFailure) {
$showNativeToolsWarning = $true
if ((Get-Variable 'DoNotDisplayNativeToolsInstallationWarnings' -ErrorAction 'SilentlyContinue') -and $DoNotDisplayNativeToolsInstallationWarnings) {
$showNativeToolsWarning = $false
}
if ($showNativeToolsWarning) {
Write-Warning $errMsg
}
$toolInstallationFailure = $true
} else {
Write-Error $errMsg
exit 1
}
}
}
if ((Get-Variable 'toolInstallationFailure' -ErrorAction 'SilentlyContinue') -and $toolInstallationFailure) {
exit 1
}
}
else {
Write-Host "No native tools defined in global.json"
exit 0
}
if ($Clean) {
exit 0
}
if (Test-Path $InstallBin) {
Write-Host "Native tools are available from" (Convert-Path -Path $InstallBin)
Write-Host "##vso[task.prependpath]$(Convert-Path -Path $InstallBin)"
return $InstallBin
}
else {
Write-Error "Native tools install directory does not exist, installation failed"
exit 1
}
exit 0
}
catch {
Write-Host $_
Write-Host $_.Exception
exit 1
}
+141
View File
@@ -0,0 +1,141 @@
#!/usr/bin/env bash
source="${BASH_SOURCE[0]}"
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
base_uri='https://netcorenativeassets.blob.core.windows.net/resource-packages/external'
install_directory=''
clean=false
force=false
download_retries=5
retry_wait_time_seconds=30
global_json_file="$(dirname "$(dirname "${scriptroot}")")/global.json"
declare -A native_assets
. $scriptroot/native/common-library.sh
while (($# > 0)); do
lowerI="$(echo $1 | awk '{print tolower($0)}')"
case $lowerI in
--baseuri)
base_uri=$2
shift 2
;;
--installdirectory)
install_directory=$2
shift 2
;;
--clean)
clean=true
shift 1
;;
--force)
force=true
shift 1
;;
--downloadretries)
download_retries=$2
shift 2
;;
--retrywaittimeseconds)
retry_wait_time_seconds=$2
shift 2
;;
--help)
echo "Common settings:"
echo " --installdirectory Directory to install native toolset."
echo " This is a command-line override for the default"
echo " Install directory precedence order:"
echo " - InstallDirectory command-line override"
echo " - NETCOREENG_INSTALL_DIRECTORY environment variable"
echo " - (default) %USERPROFILE%/.netcoreeng/native"
echo ""
echo " --clean Switch specifying not to install anything, but cleanup native asset folders"
echo " --force Clean and then install tools"
echo " --help Print help and exit"
echo ""
echo "Advanced settings:"
echo " --baseuri <value> Base URI for where to download native tools from"
echo " --downloadretries <value> Number of times a download should be attempted"
echo " --retrywaittimeseconds <value> Wait time between download attempts"
echo ""
exit 0
;;
esac
done
function ReadGlobalJsonNativeTools {
# Get the native-tools section from the global.json.
local native_tools_section=$(cat $global_json_file | awk '/"native-tools"/,/}/')
# Only extract the contents of the object.
local native_tools_list=$(echo $native_tools_section | awk -F"[{}]" '{print $2}')
native_tools_list=${native_tools_list//[\" ]/}
native_tools_list=$( echo "$native_tools_list" | sed 's/\s//g' | sed 's/,/\n/g' )
local old_IFS=$IFS
while read -r line; do
# Lines are of the form: 'tool:version'
IFS=:
while read -r key value; do
native_assets[$key]=$value
done <<< "$line"
done <<< "$native_tools_list"
IFS=$old_IFS
return 0;
}
native_base_dir=$install_directory
if [[ -z $install_directory ]]; then
native_base_dir=$(GetNativeInstallDirectory)
fi
install_bin="${native_base_dir}/bin"
ReadGlobalJsonNativeTools
if [[ ${#native_assets[@]} -eq 0 ]]; then
echo "No native tools defined in global.json"
exit 0;
else
native_installer_dir="$scriptroot/native"
for tool in "${!native_assets[@]}"
do
tool_version=${native_assets[$tool]}
installer_name="install-$tool.sh"
installer_command="$native_installer_dir/$installer_name"
installer_command+=" --baseuri $base_uri"
installer_command+=" --installpath $install_bin"
installer_command+=" --version $tool_version"
echo $installer_command
if [[ $force = true ]]; then
installer_command+=" --force"
fi
if [[ $clean = true ]]; then
installer_command+=" --clean"
fi
$installer_command
if [[ $? != 0 ]]; then
echo "Execution Failed" >&2
exit 1
fi
done
fi
if [[ $clean = true ]]; then
exit 0
fi
if [[ -d $install_bin ]]; then
echo "Native tools are available from $install_bin"
echo "##vso[task.prependpath]$install_bin"
else
echo "Native tools install directory does not exist, installation failed" >&2
exit 1
fi
exit 0
+135
View File
@@ -0,0 +1,135 @@
param(
[Parameter(Mandatory=$true)][string] $Operation,
[string] $AuthToken,
[string] $CommitSha,
[string] $RepoName,
[switch] $IsFeedPrivate
)
$ErrorActionPreference = "Stop"
Set-StrictMode -Version 2.0
. $PSScriptRoot\tools.ps1
# Sets VSS_NUGET_EXTERNAL_FEED_ENDPOINTS based on the "darc-int-*" feeds defined in NuGet.config. This is needed
# in build agents by CredProvider to authenticate the restore requests to internal feeds as specified in
# https://github.com/microsoft/artifacts-credprovider/blob/0f53327cd12fd893d8627d7b08a2171bf5852a41/README.md#environment-variables. This should ONLY be called from identified
# internal builds
function SetupCredProvider {
param(
[string] $AuthToken
)
# Install the Cred Provider NuGet plugin
Write-Host "Setting up Cred Provider NuGet plugin in the agent..."
Write-Host "Getting 'installcredprovider.ps1' from 'https://github.com/microsoft/artifacts-credprovider'..."
$url = 'https://raw.githubusercontent.com/microsoft/artifacts-credprovider/master/helpers/installcredprovider.ps1'
Write-Host "Writing the contents of 'installcredprovider.ps1' locally..."
Invoke-WebRequest $url -OutFile installcredprovider.ps1
Write-Host "Installing plugin..."
.\installcredprovider.ps1 -Force
Write-Host "Deleting local copy of 'installcredprovider.ps1'..."
Remove-Item .\installcredprovider.ps1
if (-Not("$env:USERPROFILE\.nuget\plugins\netcore")) {
Write-Host "CredProvider plugin was not installed correctly!"
ExitWithExitCode 1
}
else {
Write-Host "CredProvider plugin was installed correctly!"
}
# Then, we set the 'VSS_NUGET_EXTERNAL_FEED_ENDPOINTS' environment variable to restore from the stable
# feeds successfully
$nugetConfigPath = "$RepoRoot\NuGet.config"
if (-Not (Test-Path -Path $nugetConfigPath)) {
Write-Host "NuGet.config file not found in repo's root!"
ExitWithExitCode 1
}
$endpoints = New-Object System.Collections.ArrayList
$nugetConfigPackageSources = Select-Xml -Path $nugetConfigPath -XPath "//packageSources/add[contains(@key, 'darc-int-')]/@value" | foreach{$_.Node.Value}
if (($nugetConfigPackageSources | Measure-Object).Count -gt 0 ) {
foreach ($stableRestoreResource in $nugetConfigPackageSources) {
$trimmedResource = ([string]$stableRestoreResource).Trim()
[void]$endpoints.Add(@{endpoint="$trimmedResource"; password="$AuthToken"})
}
}
if (($endpoints | Measure-Object).Count -gt 0) {
# Create the JSON object. It should look like '{"endpointCredentials": [{"endpoint":"http://example.index.json", "username":"optional", "password":"accesstoken"}]}'
$endpointCredentials = @{endpointCredentials=$endpoints} | ConvertTo-Json -Compress
# Create the environment variables the AzDo way
Write-LoggingCommand -Area 'task' -Event 'setvariable' -Data $endpointCredentials -Properties @{
'variable' = 'VSS_NUGET_EXTERNAL_FEED_ENDPOINTS'
'issecret' = 'false'
}
# We don't want sessions cached since we will be updating the endpoints quite frequently
Write-LoggingCommand -Area 'task' -Event 'setvariable' -Data 'False' -Properties @{
'variable' = 'NUGET_CREDENTIALPROVIDER_SESSIONTOKENCACHE_ENABLED'
'issecret' = 'false'
}
}
else
{
Write-Host "No internal endpoints found in NuGet.config"
}
}
#Workaround for https://github.com/microsoft/msbuild/issues/4430
function InstallDotNetSdkAndRestoreArcade {
$dotnetTempDir = "$RepoRoot\dotnet"
$dotnetSdkVersion="2.1.507" # After experimentation we know this version works when restoring the SDK (compared to 3.0.*)
$dotnet = "$dotnetTempDir\dotnet.exe"
$restoreProjPath = "$PSScriptRoot\restore.proj"
Write-Host "Installing dotnet SDK version $dotnetSdkVersion to restore Arcade SDK..."
InstallDotNetSdk "$dotnetTempDir" "$dotnetSdkVersion"
'<Project Sdk="Microsoft.DotNet.Arcade.Sdk"/>' | Out-File "$restoreProjPath"
& $dotnet restore $restoreProjPath
Write-Host "Arcade SDK restored!"
if (Test-Path -Path $restoreProjPath) {
Remove-Item $restoreProjPath
}
if (Test-Path -Path $dotnetTempDir) {
Remove-Item $dotnetTempDir -Recurse
}
}
try {
Push-Location $PSScriptRoot
if ($Operation -like "setup") {
SetupCredProvider $AuthToken
}
elseif ($Operation -like "install-restore") {
InstallDotNetSdkAndRestoreArcade
}
else {
Write-Host "Unknown operation '$Operation'!"
ExitWithExitCode 1
}
}
catch {
Write-Host $_
Write-Host $_.Exception
Write-Host $_.ScriptStackTrace
ExitWithExitCode 1
}
finally {
Pop-Location
}
+142
View File
@@ -0,0 +1,142 @@
#!/usr/bin/env bash
set -e
# Sets VSS_NUGET_EXTERNAL_FEED_ENDPOINTS based on the "darc-int-*" feeds defined in NuGet.config. This is needed
# in build agents by CredProvider to authenticate the restore requests to internal feeds as specified in
# https://github.com/microsoft/artifacts-credprovider/blob/0f53327cd12fd893d8627d7b08a2171bf5852a41/README.md#environment-variables.
# This should ONLY be called from identified internal builds
function SetupCredProvider {
local authToken=$1
# Install the Cred Provider NuGet plugin
echo "Setting up Cred Provider NuGet plugin in the agent..."...
echo "Getting 'installcredprovider.ps1' from 'https://github.com/microsoft/artifacts-credprovider'..."
local url="https://raw.githubusercontent.com/microsoft/artifacts-credprovider/master/helpers/installcredprovider.sh"
echo "Writing the contents of 'installcredprovider.ps1' locally..."
local installcredproviderPath="installcredprovider.sh"
if command -v curl > /dev/null; then
curl $url > "$installcredproviderPath"
else
wget -q -O "$installcredproviderPath" "$url"
fi
echo "Installing plugin..."
. "$installcredproviderPath"
echo "Deleting local copy of 'installcredprovider.sh'..."
rm installcredprovider.sh
if [ ! -d "$HOME/.nuget/plugins" ]; then
echo "CredProvider plugin was not installed correctly!"
ExitWithExitCode 1
else
echo "CredProvider plugin was installed correctly!"
fi
# Then, we set the 'VSS_NUGET_EXTERNAL_FEED_ENDPOINTS' environment variable to restore from the stable
# feeds successfully
local nugetConfigPath="$repo_root/NuGet.config"
if [ ! "$nugetConfigPath" ]; then
echo "NuGet.config file not found in repo's root!"
ExitWithExitCode 1
fi
local endpoints='['
local nugetConfigPackageValues=`cat "$nugetConfigPath" | grep "key=\"darc-int-"`
local pattern="value=\"(.*)\""
for value in $nugetConfigPackageValues
do
if [[ $value =~ $pattern ]]; then
local endpoint="${BASH_REMATCH[1]}"
endpoints+="{\"endpoint\": \"$endpoint\", \"password\": \"$authToken\"},"
fi
done
endpoints=${endpoints%?}
endpoints+=']'
if [ ${#endpoints} -gt 2 ]; then
# Create the JSON object. It should look like '{"endpointCredentials": [{"endpoint":"http://example.index.json", "username":"optional", "password":"accesstoken"}]}'
local endpointCredentials="{\"endpointCredentials\": "$endpoints"}"
echo "##vso[task.setvariable variable=VSS_NUGET_EXTERNAL_FEED_ENDPOINTS]$endpointCredentials"
echo "##vso[task.setvariable variable=NUGET_CREDENTIALPROVIDER_SESSIONTOKENCACHE_ENABLED]False"
else
echo "No internal endpoints found in NuGet.config"
fi
}
# Workaround for https://github.com/microsoft/msbuild/issues/4430
function InstallDotNetSdkAndRestoreArcade {
local dotnetTempDir="$repo_root/dotnet"
local dotnetSdkVersion="2.1.507" # After experimentation we know this version works when restoring the SDK (compared to 3.0.*)
local restoreProjPath="$repo_root/eng/common/restore.proj"
echo "Installing dotnet SDK version $dotnetSdkVersion to restore Arcade SDK..."
echo "<Project Sdk=\"Microsoft.DotNet.Arcade.Sdk\"/>" > "$restoreProjPath"
InstallDotNetSdk "$dotnetTempDir" "$dotnetSdkVersion"
local res=`$dotnetTempDir/dotnet restore $restoreProjPath`
echo "Arcade SDK restored!"
# Cleanup
if [ "$restoreProjPath" ]; then
rm "$restoreProjPath"
fi
if [ "$dotnetTempDir" ]; then
rm -r $dotnetTempDir
fi
}
source="${BASH_SOURCE[0]}"
operation=''
authToken=''
repoName=''
while [[ $# > 0 ]]; do
opt="$(echo "$1" | awk '{print tolower($0)}')"
case "$opt" in
--operation)
operation=$2
shift
;;
--authtoken)
authToken=$2
shift
;;
*)
echo "Invalid argument: $1"
usage
exit 1
;;
esac
shift
done
while [[ -h "$source" ]]; do
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
source="$(readlink "$source")"
# if $source was a relative symlink, we need to resolve it relative to the path where the
# symlink file was located
[[ $source != /* ]] && source="$scriptroot/$source"
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
. "$scriptroot/tools.sh"
if [ "$operation" = "setup" ]; then
SetupCredProvider $authToken
elif [ "$operation" = "install-restore" ]; then
InstallDotNetSdkAndRestoreArcade
else
echo "Unknown operation '$operation'!"
fi
@@ -0,0 +1,4 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<Project>
<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
</Project>
+27
View File
@@ -0,0 +1,27 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. -->
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net472</TargetFramework>
<ImportDirectoryBuildTargets>false</ImportDirectoryBuildTargets>
</PropertyGroup>
<ItemGroup>
<!-- Clear references, the SDK may add some depending on UsuingToolXxx settings, but we only want to restore the following -->
<PackageReference Remove="@(PackageReference)"/>
<PackageReference Include="Microsoft.DotNet.IBCMerge" Version="$(MicrosoftDotNetIBCMergeVersion)" Condition="'$(UsingToolIbcOptimization)' == 'true'" />
<PackageReference Include="Drop.App" Version="$(DropAppVersion)" ExcludeAssets="all" Condition="'$(UsingToolVisualStudioIbcTraining)' == 'true'"/>
</ItemGroup>
<PropertyGroup>
<RestoreSources></RestoreSources>
<RestoreSources Condition="'$(UsingToolIbcOptimization)' == 'true'">
https://devdiv.pkgs.visualstudio.com/_packaging/dotnet-core-internal-tooling/nuget/v3/index.json;
</RestoreSources>
<RestoreSources Condition="'$(UsingToolVisualStudioIbcTraining)' == 'true'">
$(RestoreSources);
https://devdiv.pkgs.visualstudio.com/_packaging/VS/nuget/v3/index.json;
</RestoreSources>
</PropertyGroup>
<!-- Repository extensibility point -->
<Import Project="$(RepositoryEngineeringDir)InternalTools.props" Condition="Exists('$(RepositoryEngineeringDir)InternalTools.props')" />
</Project>
+27
View File
@@ -0,0 +1,27 @@
[CmdletBinding(PositionalBinding=$false)]
Param(
[string] $verbosity = "minimal",
[bool] $warnAsError = $true,
[bool] $nodeReuse = $true,
[switch] $ci,
[switch] $prepareMachine,
[Parameter(ValueFromRemainingArguments=$true)][String[]]$extraArgs
)
. $PSScriptRoot\tools.ps1
try {
if ($ci) {
$nodeReuse = $false
}
MSBuild @extraArgs
}
catch {
Write-Host $_
Write-Host $_.Exception
Write-Host $_.ScriptStackTrace
ExitWithExitCode 1
}
ExitWithExitCode 0
+58
View File
@@ -0,0 +1,58 @@
#!/usr/bin/env bash
source="${BASH_SOURCE[0]}"
# resolve $source until the file is no longer a symlink
while [[ -h "$source" ]]; do
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
source="$(readlink "$source")"
# if $source was a relative symlink, we need to resolve it relative to the path where the
# symlink file was located
[[ $source != /* ]] && source="$scriptroot/$source"
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
verbosity='minimal'
warn_as_error=true
node_reuse=true
prepare_machine=false
extra_args=''
while (($# > 0)); do
lowerI="$(echo $1 | awk '{print tolower($0)}')"
case $lowerI in
--verbosity)
verbosity=$2
shift 2
;;
--warnaserror)
warn_as_error=$2
shift 2
;;
--nodereuse)
node_reuse=$2
shift 2
;;
--ci)
ci=true
shift 1
;;
--preparemachine)
prepare_machine=true
shift 1
;;
*)
extra_args="$extra_args $1"
shift 1
;;
esac
done
. "$scriptroot/tools.sh"
if [[ "$ci" == true ]]; then
node_reuse=false
fi
MSBuild $extra_args
ExitWithExitCode 0
+389
View File
@@ -0,0 +1,389 @@
<#
.SYNOPSIS
Helper module to install an archive to a directory
.DESCRIPTION
Helper module to download and extract an archive to a specified directory
.PARAMETER Uri
Uri of artifact to download
.PARAMETER InstallDirectory
Directory to extract artifact contents to
.PARAMETER Force
Force download / extraction if file or contents already exist. Default = False
.PARAMETER DownloadRetries
Total number of retry attempts. Default = 5
.PARAMETER RetryWaitTimeInSeconds
Wait time between retry attempts in seconds. Default = 30
.NOTES
Returns False if download or extraction fail, True otherwise
#>
function DownloadAndExtract {
[CmdletBinding(PositionalBinding=$false)]
Param (
[Parameter(Mandatory=$True)]
[string] $Uri,
[Parameter(Mandatory=$True)]
[string] $InstallDirectory,
[switch] $Force = $False,
[int] $DownloadRetries = 5,
[int] $RetryWaitTimeInSeconds = 30
)
# Define verbose switch if undefined
$Verbose = $VerbosePreference -Eq "Continue"
$TempToolPath = CommonLibrary\Get-TempPathFilename -Path $Uri
# Download native tool
$DownloadStatus = CommonLibrary\Get-File -Uri $Uri `
-Path $TempToolPath `
-DownloadRetries $DownloadRetries `
-RetryWaitTimeInSeconds $RetryWaitTimeInSeconds `
-Force:$Force `
-Verbose:$Verbose
if ($DownloadStatus -Eq $False) {
Write-Error "Download failed"
return $False
}
# Extract native tool
$UnzipStatus = CommonLibrary\Expand-Zip -ZipPath $TempToolPath `
-OutputDirectory $InstallDirectory `
-Force:$Force `
-Verbose:$Verbose
if ($UnzipStatus -Eq $False) {
# Retry Download one more time with Force=true
$DownloadRetryStatus = CommonLibrary\Get-File -Uri $Uri `
-Path $TempToolPath `
-DownloadRetries 1 `
-RetryWaitTimeInSeconds $RetryWaitTimeInSeconds `
-Force:$True `
-Verbose:$Verbose
if ($DownloadRetryStatus -Eq $False) {
Write-Error "Last attempt of download failed as well"
return $False
}
# Retry unzip again one more time with Force=true
$UnzipRetryStatus = CommonLibrary\Expand-Zip -ZipPath $TempToolPath `
-OutputDirectory $InstallDirectory `
-Force:$True `
-Verbose:$Verbose
if ($UnzipRetryStatus -Eq $False)
{
Write-Error "Last attempt of unzip failed as well"
# Clean up partial zips and extracts
if (Test-Path $TempToolPath) {
Remove-Item $TempToolPath -Force
}
if (Test-Path $InstallDirectory) {
Remove-Item $InstallDirectory -Force -Recurse
}
return $False
}
}
return $True
}
<#
.SYNOPSIS
Download a file, retry on failure
.DESCRIPTION
Download specified file and retry if attempt fails
.PARAMETER Uri
Uri of file to download. If Uri is a local path, the file will be copied instead of downloaded
.PARAMETER Path
Path to download or copy uri file to
.PARAMETER Force
Overwrite existing file if present. Default = False
.PARAMETER DownloadRetries
Total number of retry attempts. Default = 5
.PARAMETER RetryWaitTimeInSeconds
Wait time between retry attempts in seconds Default = 30
#>
function Get-File {
[CmdletBinding(PositionalBinding=$false)]
Param (
[Parameter(Mandatory=$True)]
[string] $Uri,
[Parameter(Mandatory=$True)]
[string] $Path,
[int] $DownloadRetries = 5,
[int] $RetryWaitTimeInSeconds = 30,
[switch] $Force = $False
)
$Attempt = 0
if ($Force) {
if (Test-Path $Path) {
Remove-Item $Path -Force
}
}
if (Test-Path $Path) {
Write-Host "File '$Path' already exists, skipping download"
return $True
}
$DownloadDirectory = Split-Path -ErrorAction Ignore -Path "$Path" -Parent
if (-Not (Test-Path $DownloadDirectory)) {
New-Item -path $DownloadDirectory -force -itemType "Directory" | Out-Null
}
if (Test-Path -IsValid -Path $Uri) {
Write-Verbose "'$Uri' is a file path, copying file to '$Path'"
Copy-Item -Path $Uri -Destination $Path
return $?
}
else {
Write-Verbose "Downloading $Uri"
# Don't display the console progress UI - it's a huge perf hit
$ProgressPreference = 'SilentlyContinue'
while($Attempt -Lt $DownloadRetries)
{
try {
Invoke-WebRequest -UseBasicParsing -Uri $Uri -OutFile $Path
Write-Verbose "Downloaded to '$Path'"
return $True
}
catch {
$Attempt++
if ($Attempt -Lt $DownloadRetries) {
$AttemptsLeft = $DownloadRetries - $Attempt
Write-Warning "Download failed, $AttemptsLeft attempts remaining, will retry in $RetryWaitTimeInSeconds seconds"
Start-Sleep -Seconds $RetryWaitTimeInSeconds
}
else {
Write-Error $_
Write-Error $_.Exception
}
}
}
}
return $False
}
<#
.SYNOPSIS
Generate a shim for a native tool
.DESCRIPTION
Creates a wrapper script (shim) that passes arguments forward to native tool assembly
.PARAMETER ShimName
The name of the shim
.PARAMETER ShimDirectory
The directory where shims are stored
.PARAMETER ToolFilePath
Path to file that shim forwards to
.PARAMETER Force
Replace shim if already present. Default = False
.NOTES
Returns $True if generating shim succeeds, $False otherwise
#>
function New-ScriptShim {
[CmdletBinding(PositionalBinding=$false)]
Param (
[Parameter(Mandatory=$True)]
[string] $ShimName,
[Parameter(Mandatory=$True)]
[string] $ShimDirectory,
[Parameter(Mandatory=$True)]
[string] $ToolFilePath,
[Parameter(Mandatory=$True)]
[string] $BaseUri,
[switch] $Force
)
try {
Write-Verbose "Generating '$ShimName' shim"
if (-Not (Test-Path $ToolFilePath)){
Write-Error "Specified tool file path '$ToolFilePath' does not exist"
return $False
}
# WinShimmer is a small .NET Framework program that creates .exe shims to bootstrapped programs
# Many of the checks for installed programs expect a .exe extension for Windows tools, rather
# than a .bat or .cmd file.
# Source: https://github.com/dotnet/arcade/tree/master/src/WinShimmer
if (-Not (Test-Path "$ShimDirectory\WinShimmer\winshimmer.exe")) {
$InstallStatus = DownloadAndExtract -Uri "$BaseUri/windows/winshimmer/WinShimmer.zip" `
-InstallDirectory $ShimDirectory\WinShimmer `
-Force:$Force `
-DownloadRetries 2 `
-RetryWaitTimeInSeconds 5 `
-Verbose:$Verbose
}
if ((Test-Path (Join-Path $ShimDirectory "$ShimName.exe"))) {
Write-Host "$ShimName.exe already exists; replacing..."
Remove-Item (Join-Path $ShimDirectory "$ShimName.exe")
}
& "$ShimDirectory\WinShimmer\winshimmer.exe" $ShimName $ToolFilePath $ShimDirectory
return $True
}
catch {
Write-Host $_
Write-Host $_.Exception
return $False
}
}
<#
.SYNOPSIS
Returns the machine architecture of the host machine
.NOTES
Returns 'x64' on 64 bit machines
Returns 'x86' on 32 bit machines
#>
function Get-MachineArchitecture {
$ProcessorArchitecture = $Env:PROCESSOR_ARCHITECTURE
$ProcessorArchitectureW6432 = $Env:PROCESSOR_ARCHITEW6432
if($ProcessorArchitecture -Eq "X86")
{
if(($ProcessorArchitectureW6432 -Eq "") -Or
($ProcessorArchitectureW6432 -Eq "X86")) {
return "x86"
}
$ProcessorArchitecture = $ProcessorArchitectureW6432
}
if (($ProcessorArchitecture -Eq "AMD64") -Or
($ProcessorArchitecture -Eq "IA64") -Or
($ProcessorArchitecture -Eq "ARM64")) {
return "x64"
}
return "x86"
}
<#
.SYNOPSIS
Get the name of a temporary folder under the native install directory
#>
function Get-TempDirectory {
return Join-Path (Get-NativeInstallDirectory) "temp/"
}
function Get-TempPathFilename {
[CmdletBinding(PositionalBinding=$false)]
Param (
[Parameter(Mandatory=$True)]
[string] $Path
)
$TempDir = CommonLibrary\Get-TempDirectory
$TempFilename = Split-Path $Path -leaf
$TempPath = Join-Path $TempDir $TempFilename
return $TempPath
}
<#
.SYNOPSIS
Returns the base directory to use for native tool installation
.NOTES
Returns the value of the NETCOREENG_INSTALL_DIRECTORY if that environment variable
is set, or otherwise returns an install directory under the %USERPROFILE%
#>
function Get-NativeInstallDirectory {
$InstallDir = $Env:NETCOREENG_INSTALL_DIRECTORY
if (!$InstallDir) {
$InstallDir = Join-Path $Env:USERPROFILE ".netcoreeng/native/"
}
return $InstallDir
}
<#
.SYNOPSIS
Unzip an archive
.DESCRIPTION
Powershell module to unzip an archive to a specified directory
.PARAMETER ZipPath (Required)
Path to archive to unzip
.PARAMETER OutputDirectory (Required)
Output directory for archive contents
.PARAMETER Force
Overwrite output directory contents if they already exist
.NOTES
- Returns True and does not perform an extraction if output directory already exists but Overwrite is not True.
- Returns True if unzip operation is successful
- Returns False if Overwrite is True and it is unable to remove contents of OutputDirectory
- Returns False if unable to extract zip archive
#>
function Expand-Zip {
[CmdletBinding(PositionalBinding=$false)]
Param (
[Parameter(Mandatory=$True)]
[string] $ZipPath,
[Parameter(Mandatory=$True)]
[string] $OutputDirectory,
[switch] $Force
)
Write-Verbose "Extracting '$ZipPath' to '$OutputDirectory'"
try {
if ((Test-Path $OutputDirectory) -And (-Not $Force)) {
Write-Host "Directory '$OutputDirectory' already exists, skipping extract"
return $True
}
if (Test-Path $OutputDirectory) {
Write-Verbose "'Force' is 'True', but '$OutputDirectory' exists, removing directory"
Remove-Item $OutputDirectory -Force -Recurse
if ($? -Eq $False) {
Write-Error "Unable to remove '$OutputDirectory'"
return $False
}
}
if (-Not (Test-Path $OutputDirectory)) {
New-Item -path $OutputDirectory -Force -itemType "Directory" | Out-Null
}
Add-Type -assembly "system.io.compression.filesystem"
[io.compression.zipfile]::ExtractToDirectory("$ZipPath", "$OutputDirectory")
if ($? -Eq $False) {
Write-Error "Unable to extract '$ZipPath'"
return $False
}
}
catch {
Write-Host $_
Write-Host $_.Exception
return $False
}
return $True
}
export-modulemember -function DownloadAndExtract
export-modulemember -function Expand-Zip
export-modulemember -function Get-File
export-modulemember -function Get-MachineArchitecture
export-modulemember -function Get-NativeInstallDirectory
export-modulemember -function Get-TempDirectory
export-modulemember -function Get-TempPathFilename
export-modulemember -function New-ScriptShim
+168
View File
@@ -0,0 +1,168 @@
#!/usr/bin/env bash
function GetNativeInstallDirectory {
local install_dir
if [[ -z $NETCOREENG_INSTALL_DIRECTORY ]]; then
install_dir=$HOME/.netcoreeng/native/
else
install_dir=$NETCOREENG_INSTALL_DIRECTORY
fi
echo $install_dir
return 0
}
function GetTempDirectory {
echo $(GetNativeInstallDirectory)temp/
return 0
}
function ExpandZip {
local zip_path=$1
local output_directory=$2
local force=${3:-false}
echo "Extracting $zip_path to $output_directory"
if [[ -d $output_directory ]] && [[ $force = false ]]; then
echo "Directory '$output_directory' already exists, skipping extract"
return 0
fi
if [[ -d $output_directory ]]; then
echo "'Force flag enabled, but '$output_directory' exists. Removing directory"
rm -rf $output_directory
if [[ $? != 0 ]]; then
echo Unable to remove '$output_directory'>&2
return 1
fi
fi
echo "Creating directory: '$output_directory'"
mkdir -p $output_directory
echo "Extracting archive"
tar -xf $zip_path -C $output_directory
if [[ $? != 0 ]]; then
echo "Unable to extract '$zip_path'" >&2
return 1
fi
return 0
}
function GetCurrentOS {
local unameOut="$(uname -s)"
case $unameOut in
Linux*) echo "Linux";;
Darwin*) echo "MacOS";;
esac
return 0
}
function GetFile {
local uri=$1
local path=$2
local force=${3:-false}
local download_retries=${4:-5}
local retry_wait_time_seconds=${5:-30}
if [[ -f $path ]]; then
if [[ $force = false ]]; then
echo "File '$path' already exists. Skipping download"
return 0
else
rm -rf $path
fi
fi
if [[ -f $uri ]]; then
echo "'$uri' is a file path, copying file to '$path'"
cp $uri $path
return $?
fi
echo "Downloading $uri"
# Use curl if available, otherwise use wget
if command -v curl > /dev/null; then
curl "$uri" -sSL --retry $download_retries --retry-delay $retry_wait_time_seconds --create-dirs -o "$path" --fail
else
wget -q -O "$path" "$uri" --tries="$download_retries"
fi
return $?
}
function GetTempPathFileName {
local path=$1
local temp_dir=$(GetTempDirectory)
local temp_file_name=$(basename $path)
echo $temp_dir$temp_file_name
return 0
}
function DownloadAndExtract {
local uri=$1
local installDir=$2
local force=${3:-false}
local download_retries=${4:-5}
local retry_wait_time_seconds=${5:-30}
local temp_tool_path=$(GetTempPathFileName $uri)
echo "downloading to: $temp_tool_path"
# Download file
GetFile "$uri" "$temp_tool_path" $force $download_retries $retry_wait_time_seconds
if [[ $? != 0 ]]; then
echo "Failed to download '$uri' to '$temp_tool_path'." >&2
return 1
fi
# Extract File
echo "extracting from $temp_tool_path to $installDir"
ExpandZip "$temp_tool_path" "$installDir" $force $download_retries $retry_wait_time_seconds
if [[ $? != 0 ]]; then
echo "Failed to extract '$temp_tool_path' to '$installDir'." >&2
return 1
fi
return 0
}
function NewScriptShim {
local shimpath=$1
local tool_file_path=$2
local force=${3:-false}
echo "Generating '$shimpath' shim"
if [[ -f $shimpath ]]; then
if [[ $force = false ]]; then
echo "File '$shimpath' already exists." >&2
return 1
else
rm -rf $shimpath
fi
fi
if [[ ! -f $tool_file_path ]]; then
echo "Specified tool file path:'$tool_file_path' does not exist" >&2
return 1
fi
local shim_contents=$'#!/usr/bin/env bash\n'
shim_contents+="SHIMARGS="$'$1\n'
shim_contents+="$tool_file_path"$' $SHIMARGS\n'
# Write shim file
echo "$shim_contents" > $shimpath
chmod +x $shimpath
echo "Finished generating shim '$shimpath'"
return $?
}
+117
View File
@@ -0,0 +1,117 @@
#!/usr/bin/env bash
source="${BASH_SOURCE[0]}"
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
. $scriptroot/common-library.sh
base_uri=
install_path=
version=
clean=false
force=false
download_retries=5
retry_wait_time_seconds=30
while (($# > 0)); do
lowerI="$(echo $1 | awk '{print tolower($0)}')"
case $lowerI in
--baseuri)
base_uri=$2
shift 2
;;
--installpath)
install_path=$2
shift 2
;;
--version)
version=$2
shift 2
;;
--clean)
clean=true
shift 1
;;
--force)
force=true
shift 1
;;
--downloadretries)
download_retries=$2
shift 2
;;
--retrywaittimeseconds)
retry_wait_time_seconds=$2
shift 2
;;
--help)
echo "Common settings:"
echo " --baseuri <value> Base file directory or Url wrom which to acquire tool archives"
echo " --installpath <value> Base directory to install native tool to"
echo " --clean Don't install the tool, just clean up the current install of the tool"
echo " --force Force install of tools even if they previously exist"
echo " --help Print help and exit"
echo ""
echo "Advanced settings:"
echo " --downloadretries Total number of retry attempts"
echo " --retrywaittimeseconds Wait time between retry attempts in seconds"
echo ""
exit 0
;;
esac
done
tool_name="cmake-test"
tool_os=$(GetCurrentOS)
tool_folder=$(echo $tool_os | awk '{print tolower($0)}')
tool_arch="x86_64"
tool_name_moniker="$tool_name-$version-$tool_os-$tool_arch"
tool_install_directory="$install_path/$tool_name/$version"
tool_file_path="$tool_install_directory/$tool_name_moniker/bin/$tool_name"
shim_path="$install_path/$tool_name.sh"
uri="${base_uri}/$tool_folder/$tool_name/$tool_name_moniker.tar.gz"
# Clean up tool and installers
if [[ $clean = true ]]; then
echo "Cleaning $tool_install_directory"
if [[ -d $tool_install_directory ]]; then
rm -rf $tool_install_directory
fi
echo "Cleaning $shim_path"
if [[ -f $shim_path ]]; then
rm -rf $shim_path
fi
tool_temp_path=$(GetTempPathFileName $uri)
echo "Cleaning $tool_temp_path"
if [[ -f $tool_temp_path ]]; then
rm -rf $tool_temp_path
fi
exit 0
fi
# Install tool
if [[ -f $tool_file_path ]] && [[ $force = false ]]; then
echo "$tool_name ($version) already exists, skipping install"
exit 0
fi
DownloadAndExtract $uri $tool_install_directory $force $download_retries $retry_wait_time_seconds
if [[ $? != 0 ]]; then
echo "Installation failed" >&2
exit 1
fi
# Generate Shim
# Always rewrite shims so that we are referencing the expected version
NewScriptShim $shim_path $tool_file_path true
if [[ $? != 0 ]]; then
echo "Shim generation failed" >&2
exit 1
fi
exit 0
+117
View File
@@ -0,0 +1,117 @@
#!/usr/bin/env bash
source="${BASH_SOURCE[0]}"
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
. $scriptroot/common-library.sh
base_uri=
install_path=
version=
clean=false
force=false
download_retries=5
retry_wait_time_seconds=30
while (($# > 0)); do
lowerI="$(echo $1 | awk '{print tolower($0)}')"
case $lowerI in
--baseuri)
base_uri=$2
shift 2
;;
--installpath)
install_path=$2
shift 2
;;
--version)
version=$2
shift 2
;;
--clean)
clean=true
shift 1
;;
--force)
force=true
shift 1
;;
--downloadretries)
download_retries=$2
shift 2
;;
--retrywaittimeseconds)
retry_wait_time_seconds=$2
shift 2
;;
--help)
echo "Common settings:"
echo " --baseuri <value> Base file directory or Url wrom which to acquire tool archives"
echo " --installpath <value> Base directory to install native tool to"
echo " --clean Don't install the tool, just clean up the current install of the tool"
echo " --force Force install of tools even if they previously exist"
echo " --help Print help and exit"
echo ""
echo "Advanced settings:"
echo " --downloadretries Total number of retry attempts"
echo " --retrywaittimeseconds Wait time between retry attempts in seconds"
echo ""
exit 0
;;
esac
done
tool_name="cmake"
tool_os=$(GetCurrentOS)
tool_folder=$(echo $tool_os | awk '{print tolower($0)}')
tool_arch="x86_64"
tool_name_moniker="$tool_name-$version-$tool_os-$tool_arch"
tool_install_directory="$install_path/$tool_name/$version"
tool_file_path="$tool_install_directory/$tool_name_moniker/bin/$tool_name"
shim_path="$install_path/$tool_name.sh"
uri="${base_uri}/$tool_folder/$tool_name/$tool_name_moniker.tar.gz"
# Clean up tool and installers
if [[ $clean = true ]]; then
echo "Cleaning $tool_install_directory"
if [[ -d $tool_install_directory ]]; then
rm -rf $tool_install_directory
fi
echo "Cleaning $shim_path"
if [[ -f $shim_path ]]; then
rm -rf $shim_path
fi
tool_temp_path=$(GetTempPathFileName $uri)
echo "Cleaning $tool_temp_path"
if [[ -f $tool_temp_path ]]; then
rm -rf $tool_temp_path
fi
exit 0
fi
# Install tool
if [[ -f $tool_file_path ]] && [[ $force = false ]]; then
echo "$tool_name ($version) already exists, skipping install"
exit 0
fi
DownloadAndExtract $uri $tool_install_directory $force $download_retries $retry_wait_time_seconds
if [[ $? != 0 ]]; then
echo "Installation failed" >&2
exit 1
fi
# Generate Shim
# Always rewrite shims so that we are referencing the expected version
NewScriptShim $shim_path $tool_file_path true
if [[ $? != 0 ]]; then
echo "Shim generation failed" >&2
exit 1
fi
exit 0
+130
View File
@@ -0,0 +1,130 @@
<#
.SYNOPSIS
Install native tool
.DESCRIPTION
Install cmake native tool from Azure blob storage
.PARAMETER InstallPath
Base directory to install native tool to
.PARAMETER BaseUri
Base file directory or Url from which to acquire tool archives
.PARAMETER CommonLibraryDirectory
Path to folder containing common library modules
.PARAMETER Force
Force install of tools even if they previously exist
.PARAMETER Clean
Don't install the tool, just clean up the current install of the tool
.PARAMETER DownloadRetries
Total number of retry attempts
.PARAMETER RetryWaitTimeInSeconds
Wait time between retry attempts in seconds
.NOTES
Returns 0 if install succeeds, 1 otherwise
#>
[CmdletBinding(PositionalBinding=$false)]
Param (
[Parameter(Mandatory=$True)]
[string] $ToolName,
[Parameter(Mandatory=$True)]
[string] $InstallPath,
[Parameter(Mandatory=$True)]
[string] $BaseUri,
[Parameter(Mandatory=$True)]
[string] $Version,
[string] $CommonLibraryDirectory = $PSScriptRoot,
[switch] $Force = $False,
[switch] $Clean = $False,
[int] $DownloadRetries = 5,
[int] $RetryWaitTimeInSeconds = 30
)
# Import common library modules
Import-Module -Name (Join-Path $CommonLibraryDirectory "CommonLibrary.psm1")
try {
# Define verbose switch if undefined
$Verbose = $VerbosePreference -Eq "Continue"
$Arch = CommonLibrary\Get-MachineArchitecture
$ToolOs = "win64"
if($Arch -Eq "x32") {
$ToolOs = "win32"
}
$ToolNameMoniker = "$ToolName-$Version-$ToolOs-$Arch"
$ToolInstallDirectory = Join-Path $InstallPath "$ToolName\$Version\"
$Uri = "$BaseUri/windows/$ToolName/$ToolNameMoniker.zip"
$ShimPath = Join-Path $InstallPath "$ToolName.exe"
if ($Clean) {
Write-Host "Cleaning $ToolInstallDirectory"
if (Test-Path $ToolInstallDirectory) {
Remove-Item $ToolInstallDirectory -Force -Recurse
}
Write-Host "Cleaning $ShimPath"
if (Test-Path $ShimPath) {
Remove-Item $ShimPath -Force
}
$ToolTempPath = CommonLibrary\Get-TempPathFilename -Path $Uri
Write-Host "Cleaning $ToolTempPath"
if (Test-Path $ToolTempPath) {
Remove-Item $ToolTempPath -Force
}
exit 0
}
# Install tool
if ((Test-Path $ToolInstallDirectory) -And (-Not $Force)) {
Write-Verbose "$ToolName ($Version) already exists, skipping install"
}
else {
$InstallStatus = CommonLibrary\DownloadAndExtract -Uri $Uri `
-InstallDirectory $ToolInstallDirectory `
-Force:$Force `
-DownloadRetries $DownloadRetries `
-RetryWaitTimeInSeconds $RetryWaitTimeInSeconds `
-Verbose:$Verbose
if ($InstallStatus -Eq $False) {
Write-Error "Installation failed"
exit 1
}
}
$ToolFilePath = Get-ChildItem $ToolInstallDirectory -Recurse -Filter "$ToolName.exe" | % { $_.FullName }
if (@($ToolFilePath).Length -Gt 1) {
Write-Error "There are multiple copies of $ToolName in $($ToolInstallDirectory): `n$(@($ToolFilePath | out-string))"
exit 1
} elseif (@($ToolFilePath).Length -Lt 1) {
Write-Error "$ToolName was not found in $ToolFilePath."
exit 1
}
# Generate shim
# Always rewrite shims so that we are referencing the expected version
$GenerateShimStatus = CommonLibrary\New-ScriptShim -ShimName $ToolName `
-ShimDirectory $InstallPath `
-ToolFilePath "$ToolFilePath" `
-BaseUri $BaseUri `
-Force:$Force `
-Verbose:$Verbose
if ($GenerateShimStatus -Eq $False) {
Write-Error "Generate shim failed"
return 1
}
exit 0
}
catch {
Write-Host $_
Write-Host $_.Exception
exit 1
}
@@ -0,0 +1,102 @@
<Project Sdk="Microsoft.DotNet.Helix.Sdk" DefaultTargets="Test">
<PropertyGroup Condition="'$(AGENT_OS)' == 'Windows_NT'">
<WorkItemCommand>%HELIX_CORRELATION_PAYLOAD%\performance\scripts\benchmarks_ci.py --csproj %HELIX_CORRELATION_PAYLOAD%\performance\$(TargetCsproj)</WorkItemCommand>
<CliArguments>--dotnet-versions %DOTNET_VERSION% --cli-source-info args --cli-branch %PERFLAB_BRANCH% --cli-commit-sha %PERFLAB_HASH% --cli-repository https://github.com/%PERFLAB_REPO% --cli-source-timestamp %PERFLAB_BUILDTIMESTAMP%</CliArguments>
<Python>py -3</Python>
<CoreRun>%HELIX_CORRELATION_PAYLOAD%\Core_Root\CoreRun.exe</CoreRun>
<BaselineCoreRun>%HELIX_CORRELATION_PAYLOAD%\Baseline_Core_Root\CoreRun.exe</BaselineCoreRun>
<HelixPreCommands>$(HelixPreCommands);call %HELIX_CORRELATION_PAYLOAD%\performance\tools\machine-setup.cmd</HelixPreCommands>
<ArtifactsDirectory>%HELIX_CORRELATION_PAYLOAD%\artifacts\BenchmarkDotNet.Artifacts</ArtifactsDirectory>
<BaselineArtifactsDirectory>%HELIX_CORRELATION_PAYLOAD%\artifacts\BenchmarkDotNet.Artifacts_Baseline</BaselineArtifactsDirectory>
<ResultsComparer>%HELIX_CORRELATION_PAYLOAD%\performance\src\tools\ResultsComparer\ResultsComparer.csproj</ResultsComparer>
<DotnetExe>%HELIX_CORRELATION_PAYLOAD%\performance\tools\dotnet\$(Architecture)\dotnet.exe</DotnetExe>
<Percent>%25%25</Percent>
<XMLResults>%HELIX_WORKITEM_ROOT%\testResults.xml</XMLResults>
</PropertyGroup>
<PropertyGroup Condition="'$(AGENT_OS)' != 'Windows_NT' and '$(RunFromPerfRepo)' == 'false'">
<BaseDirectory>$HELIX_CORRELATION_PAYLOAD</BaseDirectory>
<PerformanceDirectory>$(BaseDirectory)/performance</PerformanceDirectory>
</PropertyGroup>
<PropertyGroup Condition="'$(AGENT_OS)' != 'Windows_NT' and '$(RunFromPerfRepo)' == 'true'">
<BaseDirectory>$HELIX_WORKITEM_PAYLOAD</BaseDirectory>
<PerformanceDirectory>$(BaseDirectory)</PerformanceDirectory>
</PropertyGroup>
<PropertyGroup Condition="'$(AGENT_OS)' != 'Windows_NT'">
<WorkItemCommand>$(PerformanceDirectory)/scripts/benchmarks_ci.py --csproj $(PerformanceDirectory)/$(TargetCsproj)</WorkItemCommand>
<CliArguments>--dotnet-versions $DOTNET_VERSION --cli-source-info args --cli-branch $PERFLAB_BRANCH --cli-commit-sha $PERFLAB_HASH --cli-repository https://github.com/$PERFLAB_REPO --cli-source-timestamp $PERFLAB_BUILDTIMESTAMP</CliArguments>
<Python>python3</Python>
<CoreRun>$(BaseDirectory)/Core_Root/corerun</CoreRun>
<BaselineCoreRun>$(BaseDirectory)/Baseline_Core_Root/corerun</BaselineCoreRun>
<HelixPreCommands>$(HelixPreCommands);chmod +x $(PerformanceDirectory)/tools/machine-setup.sh;. $(PerformanceDirectory)/tools/machine-setup.sh</HelixPreCommands>
<ArtifactsDirectory>$(BaseDirectory)/artifacts/BenchmarkDotNet.Artifacts</ArtifactsDirectory>
<BaselineArtifactsDirectory>$(BaseDirectory)/artifacts/BenchmarkDotNet.Artifacts_Baseline</BaselineArtifactsDirectory>
<ResultsComparer>$(PerformanceDirectory)/src/tools/ResultsComparer/ResultsComparer.csproj</ResultsComparer>
<DotnetExe>$(PerformanceDirectory)/tools/dotnet/$(Architecture)/dotnet</DotnetExe>
<Percent>%25</Percent>
<XMLResults>$HELIX_WORKITEM_ROOT/testResults.xml</XMLResults>
</PropertyGroup>
<PropertyGroup Condition="'$(UseCoreRun)' == 'true'">
<CoreRunArgument>--corerun $(CoreRun)</CoreRunArgument>
</PropertyGroup>
<PropertyGroup Condition="'$(UseBaselineCoreRun)' == 'true'">
<BaselineCoreRunArgument>--corerun $(BaselineCoreRun)</BaselineCoreRunArgument>
</PropertyGroup>
<PropertyGroup Condition="'$(WorkItemCommand)' != ''">
<WorkItemCommand>$(Python) $(WorkItemCommand) --incremental no --architecture $(Architecture) -f $(_Framework) $(PerfLabArguments)</WorkItemCommand>
</PropertyGroup>
<PropertyGroup Condition="'$(_Framework)' != 'net461'">
<WorkItemCommand>$(WorkItemCommand) $(CliArguments)</WorkItemCommand>
</PropertyGroup>
<ItemGroup>
<HelixCorrelationPayload Include="$(CorrelationPayloadDirectory)">
<PayloadDirectory>%(Identity)</PayloadDirectory>
</HelixCorrelationPayload>
</ItemGroup>
<PropertyGroup>
<PartitionCount>5</PartitionCount>
</PropertyGroup>
<ItemGroup>
<Partition Include="$(BuildConfig).Partition0" Index="0" />
<Partition Include="$(BuildConfig).Partition1" Index="1" />
<Partition Include="$(BuildConfig).Partition2" Index="2" />
<Partition Include="$(BuildConfig).Partition3" Index="3" />
<Partition Include="$(BuildConfig).Partition4" Index="4" />
</ItemGroup>
<PropertyGroup Condition="'$(Compare)' == 'true'">
<FailOnTestFailure>false</FailOnTestFailure>
</PropertyGroup>
<!--
Partition the Microbenchmarks project, but nothing else
-->
<ItemGroup Condition="$(TargetCsproj.Contains('MicroBenchmarks.csproj'))">
<HelixWorkItem Include="@(Partition)">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<PreCommands Condition="'$(Compare)' == 'true'">$(WorkItemCommand) --bdn-artifacts $(BaselineArtifactsDirectory) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(BaselineCoreRunArgument) --partition-count $(PartitionCount) --partition-index %(HelixWorkItem.Index)"</PreCommands>
<Command>$(WorkItemCommand) --bdn-artifacts $(ArtifactsDirectory) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(CoreRunArgument) --partition-count $(PartitionCount) --partition-index %(HelixWorkItem.Index)"</Command>
<PostCommands Condition="'$(Compare)' == 'true'">$(DotnetExe) run -f $(_Framework) -p $(ResultsComparer) --base $(BaselineArtifactsDirectory) --diff $(ArtifactsDirectory) --threshold 2$(Percent) --xml $(XMLResults);$(FinalCommand)</PostCommands>
<Timeout>4:00</Timeout>
</HelixWorkItem>
</ItemGroup>
<ItemGroup Condition="!$(TargetCsproj.Contains('MicroBenchmarks.csproj'))">
<HelixWorkItem Include="$(BuildConfig).WorkItem">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<PreCommands Condition="'$(Compare)' == 'true'">$(WorkItemCommand) --bdn-artifacts $(BaselineArtifactsDirectory) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(BaselineCoreRunArgument)"</PreCommands>
<Command>$(WorkItemCommand) --bdn-artifacts $(ArtifactsDirectory) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(CoreRunArgument)"</Command>
<PostCommands Condition="'$(Compare)' == 'true'">$(DotnetExe) run -f $(_Framework) -p $(ResultsComparer) --base $(BaselineArtifactsDirectory) --diff $(ArtifactsDirectory) --threshold 2$(Percent) --xml $(XMLResults)</PostCommands>
<Timeout>4:00</Timeout>
</HelixWorkItem>
</ItemGroup>
</Project>
@@ -0,0 +1,106 @@
Param(
[string] $SourceDirectory=$env:BUILD_SOURCESDIRECTORY,
[string] $CoreRootDirectory,
[string] $BaselineCoreRootDirectory,
[string] $Architecture="x64",
[string] $Framework="netcoreapp5.0",
[string] $CompilationMode="Tiered",
[string] $Repository=$env:BUILD_REPOSITORY_NAME,
[string] $Branch=$env:BUILD_SOURCEBRANCH,
[string] $CommitSha=$env:BUILD_SOURCEVERSION,
[string] $BuildNumber=$env:BUILD_BUILDNUMBER,
[string] $RunCategories="coreclr corefx",
[string] $Csproj="src\benchmarks\micro\MicroBenchmarks.csproj",
[string] $Kind="micro",
[switch] $Internal,
[switch] $Compare,
[string] $Configurations="CompilationMode=$CompilationMode"
)
$RunFromPerformanceRepo = ($Repository -eq "dotnet/performance") -or ($Repository -eq "dotnet-performance")
$UseCoreRun = ($CoreRootDirectory -ne [string]::Empty)
$UseBaselineCoreRun = ($BaselineCoreRootDirectory -ne [string]::Empty)
$PayloadDirectory = (Join-Path $SourceDirectory "Payload")
$PerformanceDirectory = (Join-Path $PayloadDirectory "performance")
$WorkItemDirectory = (Join-Path $SourceDirectory "workitem")
$ExtraBenchmarkDotNetArguments = "--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --stopOnFirstError true"
$Creator = $env:BUILD_DEFINITIONNAME
$PerfLabArguments = ""
$HelixSourcePrefix = "pr"
$Queue = "Windows.10.Amd64.ClientRS4.DevEx.15.8.Open"
if ($Framework.StartsWith("netcoreapp")) {
$Queue = "Windows.10.Amd64.ClientRS5.Open"
}
if ($Compare) {
$Queue = "Windows.10.Amd64.19H1.Tiger.Perf.Open"
$PerfLabArguments = ""
$ExtraBenchmarkDotNetArguments = ""
}
if ($Internal) {
$Queue = "Windows.10.Amd64.19H1.Tiger.Perf"
$PerfLabArguments = "--upload-to-perflab-container"
$ExtraBenchmarkDotNetArguments = ""
$Creator = ""
$HelixSourcePrefix = "official"
}
$CommonSetupArguments="--frameworks $Framework --queue $Queue --build-number $BuildNumber --build-configs $Configurations"
$SetupArguments = "--repository https://github.com/$Repository --branch $Branch --get-perf-hash --commit-sha $CommitSha $CommonSetupArguments"
if ($RunFromPerformanceRepo) {
$SetupArguments = "--perf-hash $CommitSha $CommonSetupArguments"
robocopy $SourceDirectory $PerformanceDirectory /E /XD $PayloadDirectory $SourceDirectory\artifacts $SourceDirectory\.git
}
else {
git clone --branch master --depth 1 --quiet https://github.com/dotnet/performance $PerformanceDirectory
}
if ($UseCoreRun) {
$NewCoreRoot = (Join-Path $PayloadDirectory "Core_Root")
Move-Item -Path $CoreRootDirectory -Destination $NewCoreRoot
}
if ($UseBaselineCoreRun) {
$NewBaselineCoreRoot = (Join-Path $PayloadDirectory "Baseline_Core_Root")
Move-Item -Path $BaselineCoreRootDirectory -Destination $NewBaselineCoreRoot
}
$DocsDir = (Join-Path $PerformanceDirectory "docs")
robocopy $DocsDir $WorkItemDirectory
# Set variables that we will need to have in future steps
$ci = $true
. "$PSScriptRoot\..\pipeline-logging-functions.ps1"
# Directories
Write-PipelineSetVariable -Name 'PayloadDirectory' -Value "$PayloadDirectory" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'PerformanceDirectory' -Value "$PerformanceDirectory" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'WorkItemDirectory' -Value "$WorkItemDirectory" -IsMultiJobVariable $false
# Script Arguments
Write-PipelineSetVariable -Name 'Python' -Value "py -3" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'ExtraBenchmarkDotNetArguments' -Value "$ExtraBenchmarkDotNetArguments" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'SetupArguments' -Value "$SetupArguments" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'PerfLabArguments' -Value "$PerfLabArguments" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'BDNCategories' -Value "$RunCategories" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'TargetCsproj' -Value "$Csproj" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'Kind' -Value "$Kind" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'Architecture' -Value "$Architecture" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'UseCoreRun' -Value "$UseCoreRun" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'UseBaselineCoreRun' -Value "$UseBaselineCoreRun" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'RunFromPerfRepo' -Value "$RunFromPerformanceRepo" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'Compare' -Value "$Compare" -IsMultiJobVariable $false
# Helix Arguments
Write-PipelineSetVariable -Name 'Creator' -Value "$Creator" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'Queue' -Value "$Queue" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'HelixSourcePrefix' -Value "$HelixSourcePrefix" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name '_BuildConfig' -Value "$Architecture.$Kind.$Framework" -IsMultiJobVariable $false
exit 0
+216
View File
@@ -0,0 +1,216 @@
#!/usr/bin/env bash
source_directory=$BUILD_SOURCESDIRECTORY
core_root_directory=
baseline_core_root_directory=
architecture=x64
framework=netcoreapp5.0
compilation_mode=tiered
repository=$BUILD_REPOSITORY_NAME
branch=$BUILD_SOURCEBRANCH
commit_sha=$BUILD_SOURCEVERSION
build_number=$BUILD_BUILDNUMBER
internal=false
compare=false
kind="micro"
run_categories="coreclr corefx"
csproj="src\benchmarks\micro\MicroBenchmarks.csproj"
configurations=
run_from_perf_repo=false
use_core_run=true
use_baseline_core_run=true
while (($# > 0)); do
lowerI="$(echo $1 | awk '{print tolower($0)}')"
case $lowerI in
--sourcedirectory)
source_directory=$2
shift 2
;;
--corerootdirectory)
core_root_directory=$2
shift 2
;;
--baselinecorerootdirectory)
baseline_core_root_directory=$2
shift 2
;;
--architecture)
architecture=$2
shift 2
;;
--framework)
framework=$2
shift 2
;;
--compilationmode)
compilation_mode=$2
shift 2
;;
--repository)
repository=$2
shift 2
;;
--branch)
branch=$2
shift 2
;;
--commitsha)
commit_sha=$2
shift 2
;;
--buildnumber)
build_number=$2
shift 2
;;
--kind)
kind=$2
shift 2
;;
--runcategories)
run_categories=$2
shift 2
;;
--csproj)
csproj=$2
shift 2
;;
--internal)
internal=true
shift 1
;;
--compare)
compare=true
shift 1
;;
--configurations)
configurations=$2
shift 2
;;
--help)
echo "Common settings:"
echo " --corerootdirectory <value> Directory where Core_Root exists, if running perf testing with --corerun"
echo " --architecture <value> Architecture of the testing being run"
echo " --configurations <value> List of key=value pairs that will be passed to perf testing infrastructure."
echo " ex: --configurations \"CompilationMode=Tiered OptimzationLevel=PGO\""
echo " --help Print help and exit"
echo ""
echo "Advanced settings:"
echo " --framework <value> The framework to run, if not running in master"
echo " --compliationmode <value> The compilation mode if not passing --configurations"
echo " --sourcedirectory <value> The directory of the sources. Defaults to env:BUILD_SOURCESDIRECTORY"
echo " --repository <value> The name of the repository in the <owner>/<repository name> format. Defaults to env:BUILD_REPOSITORY_NAME"
echo " --branch <value> The name of the branch. Defaults to env:BUILD_SOURCEBRANCH"
echo " --commitsha <value> The commit sha1 to run against. Defaults to env:BUILD_SOURCEVERSION"
echo " --buildnumber <value> The build number currently running. Defaults to env:BUILD_BUILDNUMBER"
echo " --csproj The relative path to the benchmark csproj whose tests should be run. Defaults to src\benchmarks\micro\MicroBenchmarks.csproj"
echo " --kind <value> Related to csproj. The kind of benchmarks that should be run. Defaults to micro"
echo " --runcategories <value> Related to csproj. Categories of benchmarks to run. Defaults to \"coreclr corefx\""
echo " --internal If the benchmarks are running as an official job."
echo ""
exit 0
;;
esac
done
if [ "$repository" == "dotnet/performance" ] || [ "$repository" == "dotnet-performance" ]; then
run_from_perf_repo=true
fi
if [ -z "$configurations" ]; then
configurations="CompliationMode=$compilation_mode"
fi
if [ -z "$core_root_directory" ]; then
use_core_run=false
fi
if [ -z "$baseline_core_root_directory" ]; then
use_baseline_core_run=false
fi
payload_directory=$source_directory/Payload
performance_directory=$payload_directory/performance
workitem_directory=$source_directory/workitem
extra_benchmark_dotnet_arguments="--iterationCount 1 --warmupCount 0 --invocationCount 1 --unrollFactor 1 --strategy ColdStart --stopOnFirstError true"
perflab_arguments=
queue=Ubuntu.1804.Amd64.Open
creator=$BUILD_DEFINITIONNAME
helix_source_prefix="pr"
if [[ "$compare" == true ]]; then
extra_benchmark_dotnet_arguments=
perflab_arguments=
# No open queues for arm64
if [[ "$architecture" = "arm64" ]]; then
echo "Compare not available for arm64"
exit 1
fi
queue=Ubuntu.1804.Amd64.Tiger.Perf.Open
fi
if [[ "$internal" == true ]]; then
perflab_arguments="--upload-to-perflab-container"
helix_source_prefix="official"
creator=
extra_benchmark_dotnet_arguments=
if [[ "$architecture" = "arm64" ]]; then
queue=Ubuntu.1804.Arm64.Perf
else
queue=Ubuntu.1804.Amd64.Tiger.Perf
fi
fi
common_setup_arguments="--frameworks $framework --queue $queue --build-number $build_number --build-configs $configurations"
setup_arguments="--repository https://github.com/$repository --branch $branch --get-perf-hash --commit-sha $commit_sha $common_setup_arguments"
if [[ "$run_from_perf_repo" = true ]]; then
payload_directory=
workitem_directory=$source_directory
performance_directory=$workitem_directory
setup_arguments="--perf-hash $commit_sha $common_setup_arguments"
else
git clone --branch master --depth 1 --quiet https://github.com/dotnet/performance $performance_directory
docs_directory=$performance_directory/docs
mv $docs_directory $workitem_directory
fi
if [[ "$use_core_run" = true ]]; then
new_core_root=$payload_directory/Core_Root
mv $core_root_directory $new_core_root
fi
if [[ "$use_baseline_core_run" = true ]]; then
new_baseline_core_root=$payload_directory/Baseline_Core_Root
mv $baseline_core_root_directory $new_baseline_core_root
fi
ci=true
_script_dir=$(pwd)/eng/common
. "$_script_dir/pipeline-logging-functions.sh"
# Make sure all of our variables are available for future steps
Write-PipelineSetVariable -name "UseCoreRun" -value "$use_core_run" -is_multi_job_variable false
Write-PipelineSetVariable -name "UseBaselineCoreRun" -value "$use_baseline_core_run" -is_multi_job_variable false
Write-PipelineSetVariable -name "Architecture" -value "$architecture" -is_multi_job_variable false
Write-PipelineSetVariable -name "PayloadDirectory" -value "$payload_directory" -is_multi_job_variable false
Write-PipelineSetVariable -name "PerformanceDirectory" -value "$performance_directory" -is_multi_job_variable false
Write-PipelineSetVariable -name "WorkItemDirectory" -value "$workitem_directory" -is_multi_job_variable false
Write-PipelineSetVariable -name "Queue" -value "$queue" -is_multi_job_variable false
Write-PipelineSetVariable -name "SetupArguments" -value "$setup_arguments" -is_multi_job_variable false
Write-PipelineSetVariable -name "Python" -value "$python3" -is_multi_job_variable false
Write-PipelineSetVariable -name "PerfLabArguments" -value "$perflab_arguments" -is_multi_job_variable false
Write-PipelineSetVariable -name "ExtraBenchmarkDotNetArguments" -value "$extra_benchmark_dotnet_arguments" -is_multi_job_variable false
Write-PipelineSetVariable -name "BDNCategories" -value "$run_categories" -is_multi_job_variable false
Write-PipelineSetVariable -name "TargetCsproj" -value "$csproj" -is_multi_job_variable false
Write-PipelineSetVariable -name "RunFromPerfRepo" -value "$run_from_perf_repo" -is_multi_job_variable false
Write-PipelineSetVariable -name "Creator" -value "$creator" -is_multi_job_variable false
Write-PipelineSetVariable -name "HelixSourcePrefix" -value "$helix_source_prefix" -is_multi_job_variable false
Write-PipelineSetVariable -name "Kind" -value "$kind" -is_multi_job_variable false
Write-PipelineSetVariable -name "_BuildConfig" -value "$architecture.$kind.$framework" -is_multi_job_variable false
Write-PipelineSetVariable -name "Compare" -value "$compare" -is_multi_job_variable false
+234
View File
@@ -0,0 +1,234 @@
# Source for this file was taken from https://github.com/microsoft/azure-pipelines-task-lib/blob/11c9439d4af17e6475d9fe058e6b2e03914d17e6/powershell/VstsTaskSdk/LoggingCommandFunctions.ps1 and modified.
# NOTE: You should not be calling these method directly as they are likely to change. Instead you should be calling the Write-Pipeline* functions defined in tools.ps1
$script:loggingCommandPrefix = '##vso['
$script:loggingCommandEscapeMappings = @( # TODO: WHAT ABOUT "="? WHAT ABOUT "%"?
New-Object psobject -Property @{ Token = ';' ; Replacement = '%3B' }
New-Object psobject -Property @{ Token = "`r" ; Replacement = '%0D' }
New-Object psobject -Property @{ Token = "`n" ; Replacement = '%0A' }
New-Object psobject -Property @{ Token = "]" ; Replacement = '%5D' }
)
# TODO: BUG: Escape % ???
# TODO: Add test to verify don't need to escape "=".
function Write-PipelineTelemetryError {
[CmdletBinding()]
param(
[Parameter(Mandatory = $true)]
[string]$Category,
[Parameter(Mandatory = $true)]
[string]$Message,
[Parameter(Mandatory = $false)]
[string]$Type = 'error',
[string]$ErrCode,
[string]$SourcePath,
[string]$LineNumber,
[string]$ColumnNumber,
[switch]$AsOutput)
$PSBoundParameters.Remove("Category") | Out-Null
$Message = "(NETCORE_ENGINEERING_TELEMETRY=$Category) $Message"
$PSBoundParameters.Remove("Message") | Out-Null
$PSBoundParameters.Add("Message", $Message)
Write-PipelineTaskError @PSBoundParameters
}
function Write-PipelineTaskError {
[CmdletBinding()]
param(
[Parameter(Mandatory = $true)]
[string]$Message,
[Parameter(Mandatory = $false)]
[string]$Type = 'error',
[string]$ErrCode,
[string]$SourcePath,
[string]$LineNumber,
[string]$ColumnNumber,
[switch]$AsOutput)
if(!$ci) {
if($Type -eq 'error') {
Write-Host $Message -ForegroundColor Red
return
}
elseif ($Type -eq 'warning') {
Write-Host $Message -ForegroundColor Yellow
return
}
}
if(($Type -ne 'error') -and ($Type -ne 'warning')) {
Write-Host $Message
return
}
if(-not $PSBoundParameters.ContainsKey('Type')) {
$PSBoundParameters.Add('Type', 'error')
}
Write-LogIssue @PSBoundParameters
}
function Write-PipelineSetVariable {
[CmdletBinding()]
param(
[Parameter(Mandatory = $true)]
[string]$Name,
[string]$Value,
[switch]$Secret,
[switch]$AsOutput,
[bool]$IsMultiJobVariable=$true)
if($ci) {
Write-LoggingCommand -Area 'task' -Event 'setvariable' -Data $Value -Properties @{
'variable' = $Name
'isSecret' = $Secret
'isOutput' = $IsMultiJobVariable
} -AsOutput:$AsOutput
}
}
function Write-PipelinePrependPath {
[CmdletBinding()]
param(
[Parameter(Mandatory=$true)]
[string]$Path,
[switch]$AsOutput)
if($ci) {
Write-LoggingCommand -Area 'task' -Event 'prependpath' -Data $Path -AsOutput:$AsOutput
}
}
<########################################
# Private functions.
########################################>
function Format-LoggingCommandData {
[CmdletBinding()]
param([string]$Value, [switch]$Reverse)
if (!$Value) {
return ''
}
if (!$Reverse) {
foreach ($mapping in $script:loggingCommandEscapeMappings) {
$Value = $Value.Replace($mapping.Token, $mapping.Replacement)
}
} else {
for ($i = $script:loggingCommandEscapeMappings.Length - 1 ; $i -ge 0 ; $i--) {
$mapping = $script:loggingCommandEscapeMappings[$i]
$Value = $Value.Replace($mapping.Replacement, $mapping.Token)
}
}
return $Value
}
function Format-LoggingCommand {
[CmdletBinding()]
param(
[Parameter(Mandatory = $true)]
[string]$Area,
[Parameter(Mandatory = $true)]
[string]$Event,
[string]$Data,
[hashtable]$Properties)
# Append the preamble.
[System.Text.StringBuilder]$sb = New-Object -TypeName System.Text.StringBuilder
$null = $sb.Append($script:loggingCommandPrefix).Append($Area).Append('.').Append($Event)
# Append the properties.
if ($Properties) {
$first = $true
foreach ($key in $Properties.Keys) {
[string]$value = Format-LoggingCommandData $Properties[$key]
if ($value) {
if ($first) {
$null = $sb.Append(' ')
$first = $false
} else {
$null = $sb.Append(';')
}
$null = $sb.Append("$key=$value")
}
}
}
# Append the tail and output the value.
$Data = Format-LoggingCommandData $Data
$sb.Append(']').Append($Data).ToString()
}
function Write-LoggingCommand {
[CmdletBinding(DefaultParameterSetName = 'Parameters')]
param(
[Parameter(Mandatory = $true, ParameterSetName = 'Parameters')]
[string]$Area,
[Parameter(Mandatory = $true, ParameterSetName = 'Parameters')]
[string]$Event,
[Parameter(ParameterSetName = 'Parameters')]
[string]$Data,
[Parameter(ParameterSetName = 'Parameters')]
[hashtable]$Properties,
[Parameter(Mandatory = $true, ParameterSetName = 'Object')]
$Command,
[switch]$AsOutput)
if ($PSCmdlet.ParameterSetName -eq 'Object') {
Write-LoggingCommand -Area $Command.Area -Event $Command.Event -Data $Command.Data -Properties $Command.Properties -AsOutput:$AsOutput
return
}
$command = Format-LoggingCommand -Area $Area -Event $Event -Data $Data -Properties $Properties
if ($AsOutput) {
$command
} else {
Write-Host $command
}
}
function Write-LogIssue {
[CmdletBinding()]
param(
[ValidateSet('warning', 'error')]
[Parameter(Mandatory = $true)]
[string]$Type,
[string]$Message,
[string]$ErrCode,
[string]$SourcePath,
[string]$LineNumber,
[string]$ColumnNumber,
[switch]$AsOutput)
$command = Format-LoggingCommand -Area 'task' -Event 'logissue' -Data $Message -Properties @{
'type' = $Type
'code' = $ErrCode
'sourcepath' = $SourcePath
'linenumber' = $LineNumber
'columnnumber' = $ColumnNumber
}
if ($AsOutput) {
return $command
}
if ($Type -eq 'error') {
$foregroundColor = $host.PrivateData.ErrorForegroundColor
$backgroundColor = $host.PrivateData.ErrorBackgroundColor
if ($foregroundColor -isnot [System.ConsoleColor] -or $backgroundColor -isnot [System.ConsoleColor]) {
$foregroundColor = [System.ConsoleColor]::Red
$backgroundColor = [System.ConsoleColor]::Black
}
} else {
$foregroundColor = $host.PrivateData.WarningForegroundColor
$backgroundColor = $host.PrivateData.WarningBackgroundColor
if ($foregroundColor -isnot [System.ConsoleColor] -or $backgroundColor -isnot [System.ConsoleColor]) {
$foregroundColor = [System.ConsoleColor]::Yellow
$backgroundColor = [System.ConsoleColor]::Black
}
}
Write-Host $command -ForegroundColor $foregroundColor -BackgroundColor $backgroundColor
}
+172
View File
@@ -0,0 +1,172 @@
#!/usr/bin/env bash
function Write-PipelineTelemetryError {
local telemetry_category=''
local function_args=()
local message=''
while [[ $# -gt 0 ]]; do
opt="$(echo "${1/#--/-}" | awk '{print tolower($0)}')"
case "$opt" in
-category|-c)
telemetry_category=$2
shift
;;
-*)
function_args+=("$1 $2")
shift
;;
*)
message=$*
;;
esac
shift
done
if [[ "$ci" != true ]]; then
echo "$message" >&2
return
fi
message="(NETCORE_ENGINEERING_TELEMETRY=$telemetry_category) $message"
function_args+=("$message")
Write-PipelineTaskError $function_args
}
function Write-PipelineTaskError {
if [[ "$ci" != true ]]; then
echo "$@" >&2
return
fi
local message_type="error"
local sourcepath=''
local linenumber=''
local columnnumber=''
local error_code=''
while [[ $# -gt 0 ]]; do
opt="$(echo "${1/#--/-}" | awk '{print tolower($0)}')"
case "$opt" in
-type|-t)
message_type=$2
shift
;;
-sourcepath|-s)
sourcepath=$2
shift
;;
-linenumber|-ln)
linenumber=$2
shift
;;
-columnnumber|-cn)
columnnumber=$2
shift
;;
-errcode|-e)
error_code=$2
shift
;;
*)
break
;;
esac
shift
done
local message="##vso[task.logissue"
message="$message type=$message_type"
if [ -n "$sourcepath" ]; then
message="$message;sourcepath=$sourcepath"
fi
if [ -n "$linenumber" ]; then
message="$message;linenumber=$linenumber"
fi
if [ -n "$columnnumber" ]; then
message="$message;columnnumber=$columnnumber"
fi
if [ -n "$error_code" ]; then
message="$message;code=$error_code"
fi
message="$message]$*"
echo "$message"
}
function Write-PipelineSetVariable {
if [[ "$ci" != true ]]; then
return
fi
local name=''
local value=''
local secret=false
local as_output=false
local is_multi_job_variable=true
while [[ $# -gt 0 ]]; do
opt="$(echo "${1/#--/-}" | awk '{print tolower($0)}')"
case "$opt" in
-name|-n)
name=$2
shift
;;
-value|-v)
value=$2
shift
;;
-secret|-s)
secret=true
;;
-as_output|-a)
as_output=true
;;
-is_multi_job_variable|-i)
is_multi_job_variable=$2
shift
;;
esac
shift
done
value=${value/;/%3B}
value=${value/\\r/%0D}
value=${value/\\n/%0A}
value=${value/]/%5D}
local message="##vso[task.setvariable variable=$name;isSecret=$secret;isOutput=$is_multi_job_variable]$value"
if [[ "$as_output" == true ]]; then
$message
else
echo "$message"
fi
}
function Write-PipelinePrependPath {
local prepend_path=''
while [[ $# -gt 0 ]]; do
opt="$(echo "${1/#--/-}" | awk '{print tolower($0)}')"
case "$opt" in
-path|-p)
prepend_path=$2
shift
;;
esac
shift
done
export PATH="$prepend_path:$PATH"
if [[ "$ci" == true ]]; then
echo "##vso[task.prependpath]$prepend_path"
fi
}
@@ -0,0 +1,45 @@
param(
[Parameter(Mandatory=$true)][int] $BarBuildId, # ID of the build which assets should be downloaded
[Parameter(Mandatory=$true)][string] $DropLocation, # Where the assets should be downloaded to
[Parameter(Mandatory=$true)][string] $MaestroApiAccessToken, # Token used to access Maestro API
[Parameter(Mandatory=$false)][string] $MaestroApiEndPoint = "https://maestro-prod.westus2.cloudapp.azure.com", # Maestro API URL
[Parameter(Mandatory=$false)][string] $MaestroApiVersion = "2019-01-16" # Version of Maestro API to use
)
. $PSScriptRoot\post-build-utils.ps1
try {
Write-Host "Installing DARC ..."
. $PSScriptRoot\..\darc-init.ps1
$exitCode = $LASTEXITCODE
if ($exitCode -ne 0) {
Write-PipelineTaskError "Something failed while running 'darc-init.ps1'. Check for errors above. Exiting now..."
ExitWithExitCode $exitCode
}
# For now, only use a dry run.
# Ideally we would change darc to enable a quick request that
# would check whether the file exists that you can download it,
# and that it won't conflict with other files.
# https://github.com/dotnet/arcade/issues/3674
# Right now we can't remove continue-on-error because we ocassionally will have
# dependencies that have no associated builds (e.g. an old dependency).
# We need to add an option to baseline specific dependencies away, or add them manually
# to the BAR.
darc gather-drop --non-shipping `
--dry-run `
--continue-on-error `
--id $BarBuildId `
--output-dir $DropLocation `
--bar-uri $MaestroApiEndpoint `
--password $MaestroApiAccessToken `
--latest-location
}
catch {
Write-Host $_
Write-Host $_.Exception
Write-Host $_.ScriptStackTrace
ExitWithExitCode 1
}
Loaded 100 of 6411 files, more files were not shown because too many files have changed in this diff. Show more