Backport of commit a9cb57cc13
* System.Web/System.Web.Handlers/AssemblyResourceLoader.cs: AssemblyResourceLoader/ScriptResourceHandler must
always generate the same URL for every assembly+resource pair, or otherwise the browser would re-fetch
the resource in situations where it is not desired (e.g. during an async request to the server to update
a panel).
The generated URLs are not encrypted using real encryption, just hashed.
In addition, the handler code got modernized a bit.
* System.Web.Extensions/System.Web.UI/ScriptManager.cs: scriptStartupBlock is a 3.5+ thing
* System.Web.Extensions_1.0/Makefile: use the 1.0 Microsoft AJAX library for this compat assembly
* System.Web/System.Web.Util/MachineKeySectionUtils.cs: made GetValidationKey public
Backport of commit 21d2c6aedb
* Makefile: Compile tests with TEST defined (to include System.Web.Util.
MachineKeySectionUtils unit tests)
* System.Web.dll.sources: Move MachineKeySectionUtils.cs from System.
Web.Configuration_2.0 to System.Web.Util
* System.Web_test.dll.sources: Move MachineKeySectionUtilsTest.cs from
System.Web.Configuration_2.0 to System.Web.Util
* System.Web.Configuration_2.0/MachineKeySection.cs: Adjust using
clauses. Uncomment some code. Fix TripleDES versus 3DES for Validation
under NET_4_0. Remove 'private' on fields/methods.
* System.Web.Handlers/AssemblyResourceLoader.cs: Adjust using clauses
* System.Web.Security/MembershipHelper.cs: Adjust using clauses
* System.Web.Security/RolePrincipal.cs: Adjust using clauses
* System.Web.SessionState_2.0/SessionId.cs: Adjust using clauses
* System.Web.UI/LosFormatter.cs: Adjust using clauses.
* System.Web.Util/MachineKeySectionUtils.cs: Moved from System.Web.
Configuration_2.0. Rename namespace and remove 'internal' on type
declaration
* Test/System.Web.Util/MachineKeySectionUtilsTest.cs: Moved from Test/
System.Web.Configuration/MachineKeySectionTest.cs. Add test case for
TripleDES versus 3DES
Backport of commit a22389fde2
Normalization of cryptographic uses in asp.net
* System.Web.Configuration_2.0/MachineKeyRegistryStorage.cs:
Remove key length check and generic key generation.
* System.Web.Configuration_2.0/MachineKeySection.cs: Add support for 4.0
ValidationAlgorithm and the use of custom algorithms (validation and
decryption). Allow the use of any, valid, key length (based on the
algorithm). Let each algorithm creates its own key (e.g. special needs,
default length...)
* System.Web.Configuration_2.0/MachineKeySectionUtils.cs: Remove key
generation (from random) code and 192bits key length hack (won't work
with custom algorithms). Add support for new (4.0) algorithms, including
custom ones. Provide uniform/shared code to Encrypt/Decrypt, Sign/Verify
and EncryptSign/VerifyDecrypt using MachineKeySection data.
* System.Web.Configuration_2.0/MachineKeyValidation.cs: Add new (4.0)
values.
* System.Web.Configuration_2.0/MachineKeyValidationConverter.cs: Add
support for new (4.0) algorithms.
* System.Web.Handlers/AssemblyResourceLoader.cs: Use the new common
cryptographic code and base64 the encrypted data.
* System.Web.Security/FormsAuthentication.cs: Use the new common
cryptographic code and base64 the signed and/or encrypted data.
* System.Web.Security/MembershipHelper.cs: Use the new common
cryptographic code - this should be 100% compatible with existing data.
* System.Web.Security/RolePrincipal.cs: Use the new common cryptographic
code.
* System.Web.Security/SqliteMembershipProvider.cs: Adapt code for
internal API change.
2010-07-23 Veerapuram Varadhan <[email protected]>
** Fixes#623451
* DataColumnCollection.cs (MoveColumn): Fix shifting of
DataColumn according to the direction of movement.
2010-07-23 Veerapuram Varadhan <[email protected]>
** Fixes#565616 - Based on Patch by Hubert FONGARNAND
* DataContainer.cs (GetContainerData): If typecode is string,
call Convert.ToString() irrespective of whether value is
IConvertible or not.
2010-07-03 Veerapuram Varadhan <[email protected]>
** Fixes#609935
* TdsMetaParameter.cs (Prepare): Use GetActualSize() instead of
* Size
property to calculate the length of a nvarchar param.
svn path=/branches/mono-2-4/mcs/; revision=159855
** Fixes#581679
* DataRelationCollection.cs (Add, Remove): Use DataRelation obj
instead of this when raising OnCollectionChang(ing, ed) events.
svn path=/branches/mono-2-4/mcs/; revision=159449
** Fixes#613087
* Tds70.cs (BuildPreparedParameters, BuildProcedureCall): Set
* default
precision to 18 as used by MS.Net when connecting to SqlServer
7.0.
svn path=/branches/mono-2-4/mcs/; revision=158954
* HttpWebRequest.cs: set content length to -1 on redirect. Reset
'FinishedReading' on redirects. Fixes bug #593596.
svn path=/branches/mono-2-4/mcs/; revision=155606
** Fixes#591443
* DataColumn.cs (Clone): Use property to clone Expression as it
* builds
compiled expression also, if any.
svn path=/branches/mono-2-4/mcs/; revision=155218
* DeflateStream.cs: always use Cdecl, since the library is compiled
using that calling convention in windows too.
svn path=/branches/mono-2-4/mcs/; revision=155014
* zlib-helper.c: now that we don't use Z_SYNC_FLUSH, there might be
unflushed input in zstream, so always call Z_FINISH.
svn path=/branches/mono-2-4/mono/; revision=154997
Backport of r154764: It's "initializer".
* configure.in: Fix typo.
This commit is licensed under the MIT X11 license.
svn path=/branches/mono-2-4/mono/; revision=154767
* System.Web.UI/PageParser.cs:
* System.Web.UI/Page.cs:
* System.Web.Configuration/PagesConfiguration.cs:
* System.Web.Compilation/PageCompiler.cs: default for
EnableViewStateMac is true. Allow setting it from a @Page
directive.
svn path=/branches/mono-2-4/mcs/; revision=154496
* HttpWebRequest.cs: when PreAuthenticate is true, don't remove the
existing authorization related headers until we know we have a
replacement. Fixes bug #591633.
svn path=/branches/mono-2-4/mcs/; revision=154346
* loader.c (mono_method_get_marshal_info): Fix the handling of dynamic methods
broken by the last change.
svn path=/branches/mono-2-4/mono/; revision=153976
* loader.c: The marshal specs are freed at the end of the call
but it explicitly frees the strings as well as the container,
so we need to dup them too to avoid referencing free'd memory.
svn path=/branches/mono-2-4/mono/; revision=153975
* mini-ppc.c (mono_arch_emit_exceptions): Avoid an assert in ppc_patch () for
some large methods with lots of exception handlers. Fixes#440924.
svn path=/branches/mono-2-4/mono/; revision=153955
* FtpWebResponse.cs:
* FtpWebRequest.cs: for non-data operations, make sure we send the
QUIT command upon completion when KeepAlive is false.
Fixes bug #589305.
svn path=/branches/mono-2-4/mcs/; revision=153827
* StreamReader.cs: if the detected encoding is different from the
provided to the constructor, adjust the decoded buffer size if
needed. Fixes bug #589236.
svn path=/branches/mono-2-4/mcs/; revision=153801
* object-internals.h (_G_BOOLEAN_EXPR): Fix the definition of this to explicitly
convert to a boolean, recent gcc versions compile this differently.
svn path=/branches/mono-2-4/mono/; revision=153374
* branch-opts.c (mono_if_conversion): Disable one of the cases when deadce
is disabled. Fixes#582322.
* iltests.il.in: Add a test.
svn path=/branches/mono-2-4/mono/; revision=153221
* processes.c: made ShellExecuteEx actually work when the file name to
execute is quoted. Display a message intead of blindly ignoring the
result of g_shell_parse_argv(). Fixes bug #385497.
svn path=/branches/mono-2-4/mono/; revision=153210
* shared.c (shm_semaphores_init): Applied patch from Cal Page
([email protected]). Fix support for USE_SHM.
svn path=/branches/mono-2-4/mono/; revision=153134
* marshal.c (mono_delegate_to_ftnptr): Use mono_gc_alloc_fixed () for
allocating the location holding the this argument to prevent
'too many root sets' errors.
svn path=/branches/mono-2-4/mono/; revision=152518
* marshal.c: Fix the embedding of object pointers into JITted code in
the native-to-managed wrappers by allocating some GC tracked memory, and
embedding the address of that.
svn path=/branches/mono-2-4/mono/; revision=152516
* Normalization.cs: Implement algorithmic Hangul decomposition; Calling
string.Normalize on Korean characters now works properly (bnc#480152).
This reduces the number of errors in 'make test' from 27k to 5.1k.
* StringNormalizationTestSource.cs:
* Makefile: Use the local, working copy of Normalization etc,so as to make
modifying Normalization.cs and then testing your changes with 'make test'
possible. Also, fix building/running of tests, patch by Alexander
Kojevnikov.
* NormalizationTableUtil.cs : Backport fix some wrong ranges in
mapIdxToComposite. This fixes some Arabic normalization (and more), and
fixes generating NormalizationGenerated.cs.
svn path=/branches/mono-2-4/mcs/; revision=152308
* tramp-arm.c: Use blx instead of mov pc, reg to improve support for thumb.
* mini-arm.c (mono_arm_thumb_supported): New helper function.
svn path=/branches/mono-2-4/mono/; revision=152179
* class.c (mono_class_get_cctor): Fix support for dynamic classes, which doesn't
have has_cctor set. Fixes#575946.
svn path=/branches/mono-2-4/mono/; revision=151945
* StreamWriter.cs:
* FileStream.cs: if flushing fails when disposing the stream, make
sure it is closed before throwing the exception. Fixes bug #579146.
svn path=/branches/mono-2-4/mcs/; revision=151763
* SoapDocumentationHandler.cs: use IndexOf() instead of LastIndexOf()
when removing the querystring from the url.
svn path=/branches/mono-2-4/mcs/; revision=151756
* mini-trampolines.c (common_call_trampoline): Fix a problem where the callsite
was not patched if the callee needed an rgctx trampoline.
svn path=/branches/mono-2-4/mono/; revision=150691
* class.c (make_generic_param_class): Initialize interface offsets since we
set klass->inited. Fixes#574819.
svn path=/branches/mono-2-4/mono/; revision=150561
* ComboBox.cs: When the normal drop down window is closed, make sure
that the auto complete list -if any- is closed as well, instead of
stay open without need.
svn path=/branches/mono-2-4/mcs/; revision=150030
top, by calling the raw XplatUI.SetZOrder for it, since we can't
properly call BringToFront on it as it is parentless. This fixes an
issue when using this feature with ComboBox's own parentless listbox.
Fixes the remaining bits of #489339.
2010-01-21 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=150026
* XplatUIDriver:
* XplatUICarbon:
* XplatUIWin32:
* XplatUIX11.cs:
* XplatUIStructs: Implement support for different kind of audible
alerts in Windows, and update the requiered classes.
* MessageBox.cs:
* TextBoxBase.cs: Update calls to XplatUI.AudibleAlert.
Fixes#473725.
2010-01-21 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=150022
MaxDropDownHeight property - also rename our field 'count' to
'visible_items_count' to avoid confusion as much as possible.
Fixes an issue with several items, showing an incorrect layout.
2010-01-21 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=150020
* RichTextBox.cs: SelectedText should set Modified to true. Observe
that this is happening just here, not for the Text property, and
neither for the TextBoxBase impl.
Fixes#569950.
svn path=/branches/mono-2-4/mcs/; revision=150016
* exceptions-amd64.c (mono_arch_notify_pending_exc): Avoid a crash if the
thread has not fully started yet.
svn path=/branches/mono-2-4/mono/; revision=150015
* SmtpClient.cs: rethrow inner exception so that
AsyncCompletedEventArgs.Error gets the right value on error. Patch
by Dimitar Dobrev.
svn path=/branches/mono-2-4/mcs/; revision=149985
* branch-opts.c (mono_branch_optimize_exception_target): Stop the optimization
if a clause is skipped because it uses the exception object, since it could
have caught the exception.
* exceptions.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=149708
* mini-amd64.c (emit_call_body): Always use near calls when AOTing even if
NOMAP32BIT or optimize_for_xen is set.
svn path=/branches/mono-2-4/mono/; revision=149674
* HttpWebRequest.cs: when the server returns several different
authentication methods, pick the one that works.
Fixes bug #562043.
svn path=/branches/mono-2-4/mcs/; revision=149502
* monitor.c (ves_icall_System_Threading_Monitor_Monitor_wait): Don't close the
wait handle if the wait is interrupted, since it is still in mon->wait_list, and
we can't remove it from it since we don't hold the lock.
(mon_new): Free the orphaned events here when a mon structure is added to the
freelist. Fixes#561239. Thanks to Mike Rieker <[email protected]> for tracking
this down.
svn path=/branches/mono-2-4/mono/; revision=149336
* ToolStripMenuItem.cs: Put the Checked/CheckState logic in a single
place and synchronize the events properly. Fixes a lack of
coordination between the events - which should be fired together.
svn path=/branches/mono-2-4/mcs/; revision=149292
* method-to-ir.c (mono_emit_method_call_full): Avoid the virt->nonvirt
optimization if the called method is gshared and marshalbyref, since gshared
methods can' have wrappers. Fixes#569390.
* generics.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=149288
* TrackBar.cs: Move our events code to a single method, allowing it to
optionally fire the Scroll event. This way we both avoid the
duplicated calls to OnScroll and also will be able to fire Scroll
*before* OnValueChanged in other places.
Fixes#568026.
svn path=/branches/mono-2-4/mcs/; revision=149270
2010-01-07 Sebastien Pouliot <[email protected]>
* Convert.cs: Fix line endings in ToBase64String (bug #568778)
and also the default line length. Code changed to not require
a BinaryReader over a MemoryStream to reduce memory requirements.
[Backport r149171]
In System.Security.Cryptography:
2010-01-07 Sebastien Pouliot <[email protected]>
* ToBase64Transform.cs: Static-ify some methods to make it easier
to use from System.Convert
[Backport r149171]
svn path=/branches/mono-2-4/mcs/; revision=149173
* RadioButton.cs: When drawing, if Appearance is Button use the old
normal routine in the theme engine, instead of using the one in 2.0,
since this last one doesn't support proper rendering of the control as
a button.
Fixes#567904.
svn path=/branches/mono-2-4/mcs/; revision=149074
* GroupBoxRenderer.cs: Properly use SystemColors.GrayText to draw to
text of the group box if it is disabled.
Fixes#567847.
svn path=/branches/mono-2-4/mcs/; revision=149011
* locales.c (construct_culture_from_specific_name): Applied patch from
José Antonio Sánchez Lázaro <[email protected]>. Fix a crash if a culture was
not found. Fixes#567900.
svn path=/branches/mono-2-4/mono/; revision=148970
2009-12-24 Sebastien Pouliot <[email protected]>
* CookieContainerTest.cs: Split many tests into smaller test
cases. Add test cases for DefaultPerDomainCookieLimit and
DefaultCookieLimit. Remove all, but one 1.x, [Category
("NotWorking")] since everything works now.
In System.Net:
2009-12-24 Sebastien Pouliot <[email protected]>
* Cookie.cs: Re-work ToString to be useable in more cases. Fix
some issues found by Gendarme.
* CookieContainer.cs: Fix 2.0 NonWorking (and new) unit tests.
Implement removing oldest cookies when limits are reached.
* CookieCollection.cs: Fix sort to be closer to MS implementation
(but still not 100% identical). Fix some issues found by Gendarme
svn path=/branches/mono-2-4/mcs/; revision=148893
* File.cs (ReadAllBytes): We cannot assume that a single call to
Read will return all the data we require.
[Backport r148822]
svn path=/branches/mono-2-4/mcs/; revision=148824
2009-12-19 Zoltan Varga <[email protected]>
* String.cs: Fix the various IndexOf and LastIndexOf methods so they handle
"" and a non-zero startIndex correctly. Fixes#566106.
In Test/System:
2009-12-19 Zoltan Varga <[email protected]>
* StringTest.cs: Add tests for IndexOf ("", startIndex, count).
svn path=/branches/mono-2-4/mcs/; revision=148791
* method-to-ir.c (mono_method_to_ir): Add support for CALLI with unmanaged
signatures. Fixes#565143.
* jit-icalls.c (mono_get_native_calli_wrapper): New JIT icall.
svn path=/branches/mono-2-4/mono/; revision=148686
* zlib-helper.c: when finishing uncompressing a buffer, we might need
more than one call to deflate with Z_FINISH since the uncompressed
data can take more space than the allocated buffer.
Fixes the IPY+Chiron test case.
svn path=/branches/mono-2-4/mono/; revision=148594
2009-12-16 Rodrigo Kumpera <[email protected]>
* reflection.c (mono_type_get_object): If the type is VAR or MVAR check
if the owner class has not been finished before returning reflection_info.
Fixes#565127.
Backport of r148575.
svn path=/branches/mono-2-4/mono/; revision=148580
* reflection.c (mono_custom_attrs_from_param): Avoid a crash if a dynamic
param doesn't have custom attributes. Fixes#565117.
svn path=/branches/mono-2-4/mono/; revision=148562
* driver.c: Applied patch from Matt McClellan ([email protected]). Add a check
for 2 parameter sched_setaffinity in older glibc versions. Fixes
#564000.
svn path=/branches/mono-2-4/mono/; revision=148127
* configure.in: Applied patch from Matt McClellan ([email protected]). Add a check
for 2 parameter sched_setaffinity in older glibc versions. Fixes
#564000.
svn path=/branches/mono-2-4/mono/; revision=148126
2009-12-01 Rodrigo Kumpera <[email protected]>
* reflection.c (fieldref_encode_signature): For some reason 2.4 doesn't
behave like 2.8 on this part. So add an extra guard for the token kind.
Fixes#563909.
svn path=/branches/mono-2-4/mono/; revision=148100
Applied patch from Laurent Etiemble ([email protected]).
* mono/metadata/assembly.c: When opening an assembly image, pass the real
names in addition to the runtime generated one.
* mono/metadata/image.h: Add a function to take the real name of the assembly
image.
* mono/metadata/image.c: If a real name has been passed to load an assembly,
use it instead of the runtime generated one.
Code is contributed under MIT/X11 license.
svn path=/branches/mono-2-4/mono/; revision=147742
* marshal.c (emit_marshal_vtype): Do the klass == date_time_class checks
before the other checks to prevent problems if the DateTime class is blittable.
Hopefully fixes#559600.
svn path=/branches/mono-2-4/mono/; revision=147739
* mini.c (mini_method_compile): Call handle_exception_clauses () in the same
place it was called before too.
svn path=/branches/mono-2-4/mono/; revision=147626
* mini.c (mini_method_compile): Call handle_exception_clauses earlier so
the local optimization passes can take its result into account. Fixes
#559876.
* exceptions.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=147605
This patch is contributed under the terms of the MIT/X11 license
* cpu-ppc64.md (load_memindex): Add loadi8_memindex.
svn path=/branches/mono-2-4/mono/; revision=147601
2009-12-01 Rodrigo Kumpera <[email protected]>
* metadata.c (inflated_method_in_image): Avoid calling
mono_method_signature () if the method does not already have a signature.
Backport of r125724.
svn path=/branches/mono-2-4/mono/; revision=147165
* mini-arm.c (mono_arch_lowering_pass): Fix an assert which is hit when
the instruction following an OP_FCOMPARE is optimized away.
svn path=/branches/mono-2-4/mono/; revision=147104
* appdomain.c (create_exceptions): New helper function extracted from
mono_runtime_init () to precreate objects used during exception handling.
(mono_runtime_init): Call it.
(mono_domain_create_appdomain_internal): Ditto. Fixes#555264.
svn path=/branches/mono-2-4/mono/; revision=147059
* Random.cs: Fix case where the diff between min and max
is very large in Next(int,int). Fix bug #558593
[Backport r146993]
svn path=/branches/mono-2-4/mcs/; revision=146995
* tramp-ppc.c (mono_arch_create_generic_class_init_trampoline_full): These
receive their argument in MONO_ARCH_VTABLE_REG, not in the first argument reg.
svn path=/branches/mono-2-4/mono/; revision=146605
function in XplatUICarbon. Currently it throws
NotImplementedException which will kill a WinForms application showing
a dialog box.
Patch by Erik Ylvisaker ([email protected]).
2009-11-18 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=146409
in the same cell as specified *and* not editing is wrong.
2009-11-18 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=146408
specified row is the extra cell we use to add new ones.
2009-11-18 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=146407
same as the current one, since we could need to activate the edition
in the current row. Also, when beginning the edition, do nothing if,
basides having an empty source, we are sure we don't have the new
cell, which could obviously start it.
Fixes other bits of #323154.
2009-11-18 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=146406
data source, don't set CurrentRow if the source is empty, as there's
no need to do anything else in the first place, and second, the logic
in the CurrentRow setter (public property) will add a new row by
default in this case (that is, when the source is empty).
Fixes part of #323154.
2009-11-18 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=146405
color is SystemColors.ControlText, as this system color detection
should be done *completely*. This is specially important when
detecting colors in systems running Gtk+ and dark themes.
2009-11-18 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=146404
* DataGrid.cs: Add a new internal property to get the maximum possible
visible rows in the grid. We cannot use VisibleRowCount since this
value can, depending on the scroll position, return a +1 or -1 value,
so we need an absolute way to know whether we need a scroll bar or
not. Also, update VLargeChange to avoid code duplication.
Fixes a vertical scroll mismatch happening trying to add a new row
while the scrollbar has reached its maximum value.
svn path=/branches/mono-2-4/mcs/; revision=146403
* DefaultWatcher.cs: patch by James P. Mitchel III.
The change corrects an instance of unsynchronized access to shared
state and is probably the intent of the original code.
svn path=/branches/mono-2-4/mcs/; revision=146292
* DataGridTextBoxColumn.cs:
* DataGrid.cs: Position the cursor in the add row should *not* show
yet another new row - that will happen till we get any real input data
from the user. When that happens, we will also mark the new row as
ready to commit - otherwise, when the cursor moves to a different row,
the just added row will be discarded. This is exactly what .Net seems
to do.
svn path=/branches/mono-2-4/mcs/; revision=145946
depend on the number of visible rows, instead of trying to re-use the
value of VisibleRowCount, which is the value of *current* visible
rows, and can easily end messed up if new rows are added/removed.
2009-11-11 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=145945
edit - this could seriously mess up our current edit cycle, specially
when adding new rows.
2009-11-11 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=145944
this way we let the user tell us whether we should handle the key or
not.
Fixes#543717.
2009-11-11 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=145943
copy of the indexes, as any direct write access to the source will cause to
reset the entire selection - also, do the linear de-selection in
reverse order to avoid any index mismatch in the source, due to out of
synchronization removing the rows.
2009-11-11 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=145942
* DataGrid.cs: Don't use this add-pending behaviour to try to add a
new row until we have the first input char - it was helping us to fix
other issues we have/had, but it's not matching .net.
2009-11-11 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=145941
supposed to be borderless, return the TopMargin value - usually in
borderless mode it has a value of 0, but in the ToolStrip controls we
need to set the margin manually.
Fixes#551214.
2009-11-11 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=145940
but in this class we are handling it ourselved, thus we need to have
the same calls, and we were missing the call to MouseClick.
Patch by Eric Petit <[email protected]>.
2009-11-11 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=145937
* ComboBox.cs: When setting Text and data source is being used, if the
passed value is not matching any of the items in the source, don't
pass it to GetItemText, since it's useless, as GetItemText expects a
valid item.
Fixes#546009.
svn path=/branches/mono-2-4/mcs/; revision=145935
* mini-arm.c (handle_thunk): Add a domain argument to control the domain
where the thunk memory should be allocated from. Fixes appdomain unloading
on arm.
svn path=/branches/mono-2-4/mono/; revision=145571
2009-11-04 Rodrigo Kumpera <[email protected]>
* reflection.c (fieldref_encode_signature): If field_image is NULL then
the token is already properly encoded. Fixs 4.0 build.
Backport of r145396.
svn path=/branches/mono-2-4/mono/; revision=145413
2009-11-03 Rodrigo Kumpera <[email protected]>
* reflection.c (fieldref_encode_signature): Add new field_image parameter
to indicate which assembly to use when resolving a custom-mod.
Fixes handling of volatile fields used across assemblies as reported in #551513.
Backport of r145337.
svn path=/branches/mono-2-4/mono/; revision=145363
2009-11-03 Rodrigo Kumpera <[email protected]>
* simd-intrinsics.c (load_simd_vreg): Add extra argument to signal if
the value was loaded from memory.
* simd-intrinsics.c (simd_intrinsic_emit_setter): Store back to memory if
the value was loader from there.
* simd-intrinsics.c (simd_intrinsic_emit_shuffle): Fail correctly for Shuffle
without constant swizzle.
Backport of r145283.
svn path=/branches/mono-2-4/mono/; revision=145339
* Thread.cs (set_CurrentUICulture): Delay setting in_currentculture
to true until after the null check and the return statement.
[Backport r145215]
svn path=/branches/mono-2-4/mcs/; revision=145216
* mono-perfcounters.c: add the "_Total" instance for CPU counters.
Until now, we only had the per-cpu(core) counters.
2009-10-30 Gonzalo Paniagua Javier <[email protected]>
* mono-proclib.c: hz is only multiplied by the number of cpus when
requesting "_Total".
Fixes bug #523520.
svn path=/branches/mono-2-4/mono/; revision=145136
[merge -r 142756:144751 from trunk, which basically contains ListView related
bug fixes, specially large speed ups for VirtualMode].
2009-10-23 Carlos Alberto Cortez <[email protected]>
* ListView.cs: When retrieving an item in virtual mode, as part of the
process calculate its layout, instead of trying to do it later.
* ListViewItem.cs: There's no need to try to infer whether we need to
compute layout or not anymore - we just do it every time we are
returning an item.
This way we should be fixing View changes with cached items, which
were storing the previous value, and not updating their contents
properly.
2009-10-23 Carlos Alberto Cortez <[email protected]>
* ColumnHeader.cs: Remove the double linear search in the Index
property, by removing the call to Contains, which is not needed.
Also, Columns collection can never be null.
2009-10-23 Carlos Alberto Cortez <[email protected]>
* ColumnHeader.cs: When calculating the width and height of the
column, try to expand to the right and use all the free space if we
are the last column *and* the resize mode is set to -2/header content.
Fixes#544716.
2009-10-14 Carlos Alberto Cortez <[email protected]>
* ListView.cs: When retrieving the top item, take into account the
offset represented by the header control, to retrieve the proper
value. Patch by Christoph von Wittich (Christoph at ApiViewer.de)
Fixes the remaining bits of #543773.
2009-10-14 Carlos Alberto Cortez <[email protected]>
* ListView.cs: TopItem setter should set the value as the top, not
only ensuring its visibility.
Fixes part of #543773.
2009-10-12 Carlos Alberto Cortez <[email protected]>
* ListView.cs: For virtual mode, when navigating the items using keyboard,
don't use the matrix of positions, and instead calculate the positions
based on the number of cols and rows, taking advantage of the fixed
positions of items. Use the same idea to implement FirstVisibleIndex,
so we avoid iterating over all the items. Patch by Stephen Robinson
mono at esar.org.uk.
Fixes part of #467418.
2009-10-12 Dick Porter <[email protected]>
* Splitter.cs: Adjust offsets when more than one splitter is
present in a control. Fixes bug 509472.
2009-10-07 Carlos Alberto Cortez <[email protected]>
* ListView.cs: When computing the value for groups height don't use
text_size field, since in LargeIcon view it sometimes contains a
double height value - use Font.Height directly, and also improve the
padding value.
* ThemeWin32Classic: The same as above.
This way the space between the group header, the line, and the items
area is not that big in LargeIcon view.
2009-10-04 Carlos Alberto Cortez <[email protected]>
* ListView.cs: When retrieving the fixed positions for the items in
virtual mode, use the row value to compute the coords of the item,
instead of the col value, as opposed to SmallIcon/LargeIcon views.
2009-09-29 Carlos Alberto Cortez <[email protected]>
* ListView.cs: The location of the items should be computed on the fly
in virtual mode - that decreased speed overall, but reduces the load
time.that decreased speed overall, but reduces the load time. Also,
handle the cases where we were using data structures we don't need to
use/create for this mode.
Fixes part of #467418.
svn path=/branches/mono-2-4/mcs/; revision=145116
* CompareInfo.cs: Fix bug in length calculation in one of the (too
many) Compare overloads
[Partial backport of r145023]
svn path=/branches/mono-2-4/mcs/; revision=145024
* method-to-ir.c (mono_method_to_ir): Use EMIT_NEW_LOAD_MEMBASE_TYPE to
load vtypes instead if OP_LOADV_MEMBASE in the implementation of
CONSTRAINED. Fixes#550964.
* generics.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=145009
* MarshalByRefObject.cs: In InitializeLifetimeService, if a lease
exists for the object return it, instead of always creating
a new one. Fixes bug #544357.
svn path=/branches/mono-2-4/mcs/; revision=144964
* shared.c (_wapi_shm_file): Avoid creating a .wapi directory here, create
it in _wapi_shm_file_open (), since platforms using posix shm don't need it.
svn path=/branches/mono-2-4/mono/; revision=144858
* shared.c: Fall back to file based shared storage if shm_open () fails
because /dev/shm is not mounted.
svn path=/branches/mono-2-4/mono/; revision=144857
* shared.c: Add an alternative implementation using shared memory instead of
files. This fixes problems where the mono process would spin up the disk
every x secs on laptops. Fixes#434566, #415373 and #321949.
svn path=/branches/mono-2-4/mono/; revision=144856
* Configuration.cs: make this work again with bundled configuration
files. Fixes bug #495957. Patch from Tor Lillqvist.
svn path=/branches/mono-2-4/mcs/; revision=144724
* CodeNamespaceImportCollection.cs: Properly update the internal
keys hashtable when there are changes in the items.
svn path=/branches/mono-2-4/mcs/; revision=144650
* WaitHandle.cs: Add missing validations for 'millisecondsTimeout'
in Wait[One|Any|All]. Also call the overloaded (bool) methods for
WaitAll to reduce code duplication.
[Backport r144529]
svn path=/branches/mono-2-4/mcs/; revision=144533
* class.c (mono_class_create_from_typedef): Initialize class->element_class
before the interfaces to avoid crashes later if class initialization fails.
Fixes#548417.
svn path=/branches/mono-2-4/mono/; revision=144485
* ApplicationHost.cs: set the shadow copy options calling the methods
in AppDomain, instead of setting them in a copy of the setup
information.
svn path=/branches/mono-2-4/mcs/; revision=144480
* ServerContext.cs:
* SslServerStream.cs: add new parameter that forces sending the
CertificateRequest record. Make sure we raise the client certificate
validation event when it is requested or required.
svn path=/branches/mono-2-4/mcs/; revision=144461
* assembly.c (mono_assembly_load_reference): Fix leak when 'status'
code is known. (parse_public_key) Remove duplicate (unneeded) NULL
check since 'pubkey' can't be NULL at this stage
* icall.c (ves_icall_System_Array_FastCopy): Add comment about
the check. (ves_icall_Type_GetInterfaceMapData) Remove duplicate
initialization of 'iter'
[Backport r144403 + part of r141170 (assembly.c)]
svn path=/branches/mono-2-4/mono/; revision=144406
* mini-exceptions.c (mini_jit_info_table_find): New helper function which
searches all the domains of the current thread.
* exceptions-<ARCH>.c: Use it. Fixes#539394.
svn path=/branches/mono-2-4/mono/; revision=144377
* image.c (mono_image_close): Atomically decrement the reference count and
remove the image from the hash tables, to prevent another thread from seeing a
dying MonoImage. Fixes#541194.
svn path=/branches/mono-2-4/mono/; revision=144375
* System.Windows.Forms_test.dll.sources: Add a new test file.
2009-03-30 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=144313
[merge -r 132698:142738 from trunk]
2009-08-28 Carlos Alberto Cortez <[email protected]>
* TextBoxTest.cs: Improve the ModifiedTest test.
2009-08-28 Atsushi Enomoto <[email protected]>
* DataGridViewCellTest.cs : nunit test upgrade to modern style.
2009-08-19 Carlos Alberto Cortez <[email protected]>
* ToolStripDropDownItemTest.cs: New test file.
2009-08-10 Carlos Alberto Cortez <[email protected]>
* DataGridTest.cs: Don't use DataGrid.Rows.Add() for our latest test,
since it is 2.0. Use DataGrid.NewRow() instead.
2009-08-10 Carlos Alberto Cortez <[email protected]>
* DataGridTest.cs: New test for the interaction between DataSource and
TableStyles.
2009-08-03 Carlos Alberto Cortez <[email protected]>
* GridColumnStylesCollectionTest.cs: New test for #465019. Also make
public the test class, so it is *actually* loaded by nunit.
2009-07-24 Carlos Alberto Cortez <[email protected]>
* ToolStripItemCollectionTest.cs: New test for Find.
2009-07-17 Carlos Alberto Cortez <[email protected]>
* RadioButtonTest.cs: Update the Checked test to not depend on
Form.Show, since we need to check the same behaviour even if no handle
has been created yet.
2009-06-16 Ivan N. Zlatev <[email protected]>
* DataGridViewTest.cs: Duplicate test label fix.
2009-06-07 Carlos Alberto Cortez <[email protected]>
* DataObjectTest.cs: New assertions for the text functionality.
2009-06-06 Carlos Alberto Cortez <[email protected]>
* ListBindingHelperTest.cs: New assertion for GetListItemType, as well
as a new helper collection class.
2009-06-01 Carlos Alberto Cortez <[email protected]>
* ClipboardTest.cs: New test for serializable types.
2009-05-11 Carlos Alberto Cortez <[email protected]>
* ToolStripDropDownTest.cs: New test to assure the Height atfer
calculating the layout depends on ToolStripItem.GetPreferredHeight.
2009-05-08 Carlos Alberto Cortez <[email protected]>
* ToolStripControlHost.cs: New tests for DefaultSize and
OnHostedControlResize members.
2009-05-08 Andrés G. Aragoneses <[email protected]>
* ToolStripMenuItemTest.cs: Improve test, and remove the
NotWorking attribute. Also remove the 'var' keywords, doh!
2009-05-08 Andrés G. Aragoneses <[email protected]>
* ToolStripMenuItemTest.cs: Simplify test.
2009-05-08 Andrés G. Aragoneses <[email protected]>
* ToolStripMenuItemTest.cs: Add yet another non-passing test
(wors in MS.NET).
2009-05-06 Andrés G. Aragoneses <[email protected]>
* ToolStripMenuItemTest.cs: add tests for Owner and OwnerItem.
2009-05-06 Andrés G. Aragoneses <[email protected]>
* ToolStripMenuItemTest.cs: more accurate test, and fix build
(namespace clash).
2009-05-06 Andrés G. Aragoneses <[email protected]>
* ToolStripMenuItemTest.cs: Add a test for GetCurrentParent
(passes on MS.NET). Related to a11y bugs #485524 and #479397.
2009-05-04 Andrés G. Aragoneses <[email protected]>
* TabControlTest.cs: More accurate test for bug#499887 showing
the SelectedIndex at the moment of the event (passes on MS.NET).
2009-04-30 Andrés G. Aragoneses <[email protected]>
* TabControlTest.cs: Added test for bug#499887.
svn path=/branches/mono-2-4/mcs/; revision=144312
[merge -r 132698:142738 from trunk to 2-4 branch. Some changes were already
there, so also keep this Changelog sane]
2009-10-17 Carlos Alberto Cortez <[email protected]>
* ListView.cs: When calculating the layout for Details view, don't ask
for the items *at all* in case we are in virtual mode. This should
re-enable the proper behaviour of virtual mode.
2009-10-17 Andrés G. Aragoneses <[email protected]>
* ToolBar.cs, ToolBarButton.cs: Add new UIA events to know
when a button gets focus, firing the events from the ToolBar.
r: jpobst
2009-10-17 Carlos Alberto Cortez <[email protected]>
* ComboBox.cs: When calculating the height of the ComboListBox,
specially for the 2.0 profile, use MaxDropDownItems if the
DropDownHeight property hasn't been set, and use the later if it has
been set. This way we support both properties.
Fixes#493308.
2009-10-17 Carlos Alberto Cortez <[email protected]>
* XplatUIX11.cs, X11Clipboard.cs: Text and Rtf formats must be
separated, and we cannot fallback on Text if Rtf is requested but not
present.
* Clipboard.cs: Actually use the format specified by our user when
putting data.
2009-10-17 Carlos Alberto Cortez <[email protected]>
* XplatUIX11.cs: When handling the SelectionRequest event, use
SelectionRequestEvent instead of SelectionEvent, so we get the right
data for the app asking for clipboard data. Set the member of
SelectioneEvent.property to indicate the place where we are storing
the information as well - this is specially important for gnome/kde
apps using the TARGETS atom to ask for the supported permission before
actually asking for a specific format.
Fixes#489393.
2009-10-17 Jonathan Pobst <[email protected]>
* ToolStripDrowDown.cs: Remove some hardcoded values and assumptions.
* ToolStripDropDownButton.cs: This should use a ToolStripDropDownMenu,
not a ToolStripDropDown.
* ToolStripItem.cs: Don't use the item margins on a ToolStripDropDown.
2009-09-26 Jonathan Pobst <[email protected]>
* TreeNode.cs: When we invalidate a node, make sure we start at
0, instead of the node's Bounds.Left, which does not include
the +/-, checkbox, or stateimages.
[Fixes bug #542481]
2009-09-24 Ivan N. Zlatev <[email protected]>
* DataGridView.cs: Compare the name and not displayname of properties
when checking if the column is already bound.
2009-09-21 Carlos Alberto Cortez <[email protected]>
* RichTextBox.cs: For SelectedRtf, after inserting the stream, adjust
the position of the caret by adding the needed chars represented by the new line chars,
according to the system, using rich *or* hard new lines as needed. Also do a
check to be sure we don't move the cursor position beyond the limits
of our text. This should avoid problems with text being pasted,
regarding the position of the caret.
2009-09-16 Carlos Alberto Cortez <[email protected]>
* RichTextBox.cs: When SelectedRtf is set, and we are in the 0
position in the x axis, force to re-use any already available line,
even if it is not empty. This way pasting text into our textbox in the
beginning for non empty lines should work fine.
2009-09-14 Carlos Alberto Cortez <[email protected]>
* RichTextBox.cs: When we are inserting a flow of rtf text, and we are
*not* loading it from a file, try to re-use a line if already
available, since the default behaviour of the parser is to create new
lines for the document.
This should fix a regressions we found after the last fix for #513030.
2009-09-14 Tom Hindle <[email protected]>
* ToolStripOverflow.cs: Fixes#536036 by adding null ptr check.
2009-09-11 Ivan N. Zlatev <[email protected]>
* PropertyGrid.cs: Hide the splitter when the help is hidden.
2009-09-11 Ivan N. Zlatev <[email protected]>
* InternalWindowManager.cs: Call Invalidate-Update instead of
Refresh for MS compitability. Note also that Refresh is virtual
and several controls override it in order to provide data refresh
functionallity on top of the redraw and they do not expect this
extra refresh call.
* Control.cs: In Refresh Invalidate the control and all children
insead of calling Refresh for each of them.
[Fixes bug #538336]
2009-09-11 Ivan N. Zlatev <[email protected]>
* PropertyGrid.cs: Always set the help panel properties on the
internal control, because they are inherited and can change with
the parent.
[Fixes bug #525305]
2009-09-08 Carlos Alberto Cortez <[email protected]>
* RichTextBox.cs: When processing rtf, don't add a new line if we
already have one for that position. This way we avoid overriding by
mistake our lines when copying/pasting.
Fixes#513030.
2009-09-07 Carlos Alberto Cortez <[email protected]>
* TextControl.cs: When inserting new lines, look for the end of file
char, and remove chars after it. This is unlikely to happeng either
loading a file, pasting text or pressing a char, but can happen using
the TextBox.Text property.
Fixes#535884.
2009-09-06 Carlos Alberto Cortez <[email protected]>
* Line.cs: In DeleteCharacters, cache line.Length for every tag, since
tag.Start changes will modify it indirectly and then we would end up
with wrong values.
Fixes#512521.
2009-09-03 Ivan N. Zlatev <[email protected]>
* BindingSource.cs: Implement support for chained data sources.
* ListBindingHelper.cs: Add support for ICurrencyManagerProvider and
clean up.
[Fixes part of bug #536547]
2009-09-01 Carlos Alberto Cortez <[email protected]>
* RichTextBox.cs: When saving the text to a file using SaveFile use
Environment.NewLine to separate the lines. This way we should be
saving the files according to the system.
Fixes the remaining part of #511515.
2009-08-31 Carlos Alberto Cortez <[email protected]>
* RichText.cs: Remove some unix new line characters and use
Environment.NewLine. Fixes part of #511515.
2009-08-28 Carlos Alberto Cortez <[email protected]>
* TextBoxBase.cs: Modified should *not* be modified from the Text
property, as our new tests show. It should be to false, however, in
Append and Clear; and Paste, Cut, Undo, and direct user input should set it
to true. Also, as opposed to what the .net docs say -but proven by our
tests-, the changes should be generating a ModifiedChanged event
(thus we set the property, instead of the field).
Fixes#511267.
2009-08-27 Ivan N. Zlatev <[email protected]>
* DataGridView.cs: Fire the CellDoubleClicked event.
[Fixes bug #533430]
2009-08-27 Ivan N. Zlatev <[email protected]>
* DataGridView.cs: Add support for column DataGridViewAutoSizeColumnMode
DisplayedCells and DisplayedCellsExceptHeader.
[Fixes bug #533435]
2009-08-27 Carlos Alberto Cortez <[email protected]>
* TextControl.cs: When removing a simple char, actually record the
action in the undo manager. This way we both support undoing the
removal of chars using backspace/delete, as well as keeping data
integrity when other undo tasks are performed.
Fixes#531983.
2009-08-24 Carlos Alberto Cortez <[email protected]>
* Control.cs: Remove the ancient code in ResetText, which was setting
the internal field to String.Empty, instead of doing it for our Text
property, as .net does (which also causes a TextChanged event and all
the other related routines).
Fixes#531587.
2009-08-24 Carlos Alberto Cortez <[email protected]>
* TreeNodeCollection.cs: Correctly implement Contains by using a
linear search - there's no possible way to use a binary search, since
the node instances are not implementing IComparable, nor have a
specific order.
Fixes#529927.
2009-08-24 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs: If we are *not* changing a row
already added to the source, and thus we are adding a new
row instead, try to move to the previous row when Esc is
pressed -if possible-.
Fixes some bits of #322974.
2009-08-24 Carlos Alberto Cortez <[email protected]>
* DataGridTextBoxColumn.cs:
* DataGrid.cs: Moving the cell to the add row (the last one) should
not immediately add a new row - this should happen until the very
first change happens in that textbox.
Fixes part of #322974.
2009-08-19 Carlos Alberto Cortez <[email protected]>
* ToolStripDropDown.cs: When assigning the owner item, use its Font as
well.
2009-08-17 Carlos Alberto Cortez <[email protected]>
* ToolStripItem.cs: When the owner changes its Font, call the
OnFontChanged event, so we let our users know that we likely have a
new font - since Font is an ambient property.
* ToolStripDropDownItem.cs: When our Font changes, propagate that
information to our DropDown control, if any.
Fixes#531515.
2009-08-17 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs:
* ThemeWin32Classic.cs: When the user clicks on a new cell, we should reset any
previous selection, just like .net does. Also, in the cases where a
cell is being edited and it keeps the selected status, use the normal
colors for it, and use the selected colors for the rest of the columns of
that row.
Fixes the remaining bits of #323051.
2009-08-16 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs: When getting ProcessKeyPreview fired, call Edit() if we
are not editing already - so the edition is actually active on our
column style textbox. Also, it seems the code handling process the
grid keys is repeated, but instead of removing it, just comment it for
now.
Fixes part of #323051.
2009-08-13 Carlos Alberto Cortez <[email protected]>
* AsyncMethodResult.cs: Store a exception field in case the called
method actually caused an exception. This way we can throw it later.
* XplatUIDriver.cs: Check if the async method result has an exception
- throw it if needed.
The idea is that Control.Invoke throws the exception from the thread
that called it, not the main MWF thread.
Patch by Tom Spink <[email protected]>. Fixes#497175.
2009-08-12 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs: In mouse move we need to shift the selection in case
the pointer is on the row headers.
Fixes#323052.
2009-08-11 Ivan N. Zlatev <[email protected]>
* SplitContainer.cs: Avoid updating the splitter distance if it hasn't
moved. Updating the distance was causing a re-layout which was resetting
the clicks counter and preventing DoubleClick from every firing.
[Fixes bug #521387]
2009-08-11 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs: When a new TableStyle is added, don't create new
columns for it unless it is empty - this is the correct way to both
respect the columns if they were provided by our user, or create them
for him in case the column collection is empty.
Fixes#323111.
2009-08-10 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs: Actually call BindColumns in the handler for
ListManager.MetaDataChanged, since the current code is already taking
into account the scenario when a custom table style is used - this was
confusing us before, and that's why we commented the call to
BindColumns. Also call CallAreasAndInvalidate, to properly reflect the
changes as needed.
Fixes#465021.
2009-08-10 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs: When setting the data source, if we have a user
provided table style available, force a complete bind in case the
column styles for that table style is empty.
2009-08-09 Ivan N. Zlatev <[email protected]>
* DataGridViewCell.cs: Handle null and DBNull values.
2009-08-07 Rodrigo Kumpera <[email protected]>
* ListBindingHelper.cs: Fix the 1.0 build by making this type available
under that profile.
2009-08-07 Ivan N. Zlatev <[email protected]>
* CurrencyManager.cs: Remove duplicate code.
2009-08-07 Ivan N. Zlatev <[email protected]>
* DataGridView.cs, DataGridViewCell.cs, DataGridViewColumn.cs:
Massive population performance boost. From seconds to ms.
[Fixes bug #528887]
2009-08-04 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs: When handling mouse down on a column, don't do any sort
even if the list supports it if we are empty. This way we avoid an exc
sorting the empty list, and keep the UI compatible with .net.
2009-08-04 Carlos Alberto Cortez <[email protected]>
* DataGrid.cs: In Edit () check we have any row before trying to use
the current row. Fixes a IOOR exc with an empty data grid.
2009-08-03 Carlos Alberto Cortez <[email protected]>
* DataGridColumnStyle.cs: Don't call CheckValidDataSource when setting
the owner DataGrid - even if this seems to be the right thing to do,
.net is not doind this check at this point, but in later operations.
Fixes#465019.
2009-07-28 Mike Gorse <[email protected]>
* ToolStripMenuItem.cs: Added UIA CheckOnClickChanged event.
2009-07-28 Carlos Alberto Cortez <[email protected]>
* Application.cs: Make FilterMessage internal for 1.1. Fixes the 1.1 build.
2009-07-28 Carlos Alberto Cortez <[email protected]>
* XplatUIX11.cs:
* XplatUIWin32.cs: We need to filter the messages using
Application.FilterMessage for our DoEvents implementations. Observe
that I don't like the idea of XplatUI call the upper level Application
class, but at this point is easier and simpler to do this call - based
on the fact it's only one simple call.
Fixes#516735.
2009-07-28 Carlos Alberto Cortez <[email protected]>
* TreeNodeCollection.cs: When removing the selected node, set the
SelectedNode value of TreeView to null if there aren't more nodes left -
this is better than to clear the selected node in Clear, since we need
to handle the situation in the Remove methods as well.
Fixes#525002.
2009-07-24 Carlos Alberto Cortez <[email protected]>
* ToolStripItemCollection.cs: Find should do a case insensitive
search, and should throw an ArgumentNullException if the parameter is
an empty string.
2009-07-23 Carlos Alberto Cortez <[email protected]>
* PropertyGrid.cs: Use click handlers for each ToolStripButton instead
of using a global handler for the ToolStrip. This way the buttons can
be recovered and can have its PerformClick method called properly.
Fixes#522454.
2009-07-20 Carlos Alberto Cortez <[email protected]>
* X11Dnd.cs: Implement support for XdndActionList, so we can get the
complete list of the supported actions in the drag source, and use the
action passed in the Position message only as a fallback. This will
help us with dnd operations with non winforms apps.
Fixes#402158.
2009-07-20 Carlos Alberto Cortez <[email protected]>
* ToolStripItemCollection.cs: Use a List<> instead of an ArrayList in
Find. This should fix the exception we were getting when trying to
convert the ArrayList to an array of objects (since we were losing the
type parameter).
Fixes#519944.
2009-07-17 Carlos Alberto Cortez <[email protected]>
* RadioButton.cs: Setting Checked when none of the sibligs is checked
should happen *not* in GotFocus, but in the Enter event. This is
specially important since we should get that Checked behaviour even if
no handle is created yet - and thus, no actual GotFocus call happens at
the time.
Fixes#520764.
2009-07-16 Carlos Alberto Cortez <[email protected]>
* ComboBox.cs: Adjust manually the top border for out internal
ComboBox, since removing the border from it leaves it without any
margin. This is not noticeable in a default ComboBox, but it is in an
instance shown on top of ToolStrip.
Fixes the remaining part of #507462.
2009-07-13 Carlos Alberto Cortez <[email protected]>
* TextBoxBase.cs: Expose the margin top width as a property, to keep
the code clean.
* ToolStripTextBox.cs: Since we are actually using no border in the
default TextBox impl, and we are drawing the border ourselves, we need
to manually set the top margin.
Fixes part of #507462.
2009-07-06 Carlos Alberto Cortez <[email protected]>
* PrintPreviewDialog.cs: Record when left was pressed, so we can
simulate Tab+Alt when moving the focus throughout our buttons and
controls.
Fixes the remaining bits of #509142.
2009-07-05 Carlos Alberto Cortez <[email protected]>
* TabControl.cs: When computing the width of each tab page, use the
page's Font instead of the tab control one.
Fixes#514368.
2009-07-03 Carlos Alberto Cortez <[email protected]>
* MenuAPI.cs: When handling the Keys.Left key, don't close the menu if
the current menu is specifically a ContextMenu (this is what .net does
as well). This way we also avoid a crash caused by MenuTracker trying
to use the menu when it was already hidden.
2009-07-03 Carlos Alberto Cortez <[email protected]>
* PrintPreviewDialog.cs: Remove the code used to handle the
DropDown menu, since we are now doing it by default in ToolBar, and
just call the base impl as needed.Also, deactivate the dropdown menu
before moving the focus to a different button in our toolbar, as .net
does.
* ContextMenu.cs:
* MenuAPI.cs: Make as internal the needed bits to deactivate a
ContextMenu, and also to keep some beauty in our api.
2009-07-02 Carlos Alberto Cortez <[email protected]>
* ToolBar.cs: When handling the key down message, if we are on a
drop down button, either show the DropDownMenu or pass the key to its
ProcessCmdKey method as needed.
Fixes the remaining bits of #509985.
2009-06-29 Carlos Alberto Cortez <[email protected]>
* ToolBar.cs: Isolate the event logic related to OnButtonClick. Also
set current_item when navigating with the keyboard, so we can use it
properly later. Finally, handle both Enter and Space to fire
OnButtonClick *only*, without any other impact, as .net does.
Fixes part of #509985.
2009-06-29 Carlos Alberto Cortez <[email protected]>
* MenuAPI.cs: Close any active menu when we get a simple Alt.
Fixes#509299.
2009-06-26 Carlos Alberto Cortez <[email protected]>
* ToolBar.cs: In OnButtonClick only change the Pushed value for
buttons with toogle style. We were previously doing it for
DropDownButton's buttons, but that's not what .net is doing.
Fixes#510030.
2009-06-26 Atsushi Enomoto <[email protected]>
* XplatUICarbon.cs : support multi-byte text input.
Fixed bug #501276.
2009-06-22 Carlos Alberto Cortez <[email protected]>
* ListBox.cs: When creating DrawItemEventArgs, pass either
Theme.ColorHighlightText or ForeColor depending on the selected state
of our item, as .net does.
Fixes#512115.
2009-06-22 Carlos Alberto Cortez <[email protected]>
* ComboBox.cs: When handling WM_CHAR, process the message first, and
send it to the textbox only if it wasn't handled.
Fixes#507459.
2009-06-18 Jonathan Pobst <[email protected]>
* ComboBox.cs: Only do my big sort at the end of AddRange if
the combobox is actually set to Sorted.
2009-06-18 Tom Hindle <[email protected]>
* XplatUIX11.cs: Enabled Text to coexist with custom data formats.
Fixes#511849.
2009-06-18 Carlos Alberto Cortez <[email protected]>
* ListBox.cs: When calculating the scrollbars for non MultiColumn
mode, force the use of the horizontal scrollbar only if
ScrollAlwaysVisible is true as well.
Fixes#513029.
2009-06-17 Jonathan Pobst <[email protected]>
* ComboBox.cs: When using AddRange on a sorted combobox, don't
try to use our inefficient sorted insert method, just append
it and sort the whole thing at then end.
[Fixes bug #511247]
2009-06-16 Carlos Alberto Cortez <[email protected]>
* ToolBar.cs: Expose as internal the code used to show a dropdown menu.
* PrintPreviewDialog.cs: Handle the down/up arrow keys for our
DropDown element.
Fixes#509152.
2009-06-16 Ivan N. Zlatev <[email protected]>
* DataGridView.cs: Scrolling fixes.
[Fixes bug #512816]
2009-06-16 Ivan N. Zlatev <[email protected]>
* DataGridView.cs, DataGridViewRowCollection.cs: Clean up a bit and
optimize for batch adding rows.
2009-06-16 Ivan N. Zlatev <[email protected]>
* DataGridView.cs: Avoid calling ReBind twice during the initial data
binding.
[Fixes bug #512807]
2009-06-16 Ivan N. Zlatev <[email protected]>
* DataGridView.cs: Suppress invalidation during data binding.
[Fixes part of bug #512807]
2009-06-15 Carlos Alberto Cortez <[email protected]>
* PrintPreviewDialog.cs: Tune the navigation among the buttons and
controls that are part of our ToolBar, so we can mimic the behaviour
observed in .Net, by handling also the arrow keys and doing the
preprocess for them too.
Fixes the remaining bits of #509142.
2009-06-12 Carlos Alberto Cortez <[email protected]>
* ToolBar.cs: Expose the current item as internal.
* PrintPreviewDialog.cs: Tune the TabStop property for
PrintPreviewControl/ToolBar so we match the .net scenario regarding
Tab navigation. Also implement support to navigate throughout the
items in the ToolBar.
Fixes#509142.
2009-06-09 Ivan N. Zlatev <[email protected]>
* DataGridViewComboBoxCell.cs, DataGridViewComboBoxColumn.cs:
Implement items syncing in the non-databound scenario.
[Fixes bug #494031]
2009-06-09 Ivan N. Zlatev <[email protected]>
* DataGridView.cs: Call OnCellValidating and OnCellValidated and
handle the Cancel accordingly.
[Fixes bug #506838]
2009-06-09 Ivan N. Zlatev <[email protected]>
* DataGridViewBand.cs: Fix a typo in DefaultHeaderCellType.
[Fixes bug #506796]
2009-06-09 Ivan N. Zlatev <[email protected]>
* DataGridViewColumnCollection.cs, DataGridViewRowCollection.cs,
DataGridView.cs: Fire CollectionChangeAction.Refresh collection
changed when Clearing the collections so that the DataGridView
can know and reset the current cell.
[Fixes bug #492549]
2009-06-09 Ivan N. Zlatev <[email protected]>
* BindingSource.cs: In ResetBindings use the ListChangedEventArgs ctor
with the PropertyDescriptor parameter instead of index, because the
latter will set some irelevant indices. Fixes a bug uncovered by recent
fix to ListChangedEventArgs.
2009-06-09 Carlos Alberto Cortez <[email protected]>
* DataObject.cs: When looking for any specific format, do a case
insensitive search, as .net does.
Fixes#509199.
2009-06-09 Ivan N. Zlatev <[email protected]>
* CurrencyManager.cs: In AllowNew firstly check if the list is a
IBindingList and proxy to AllowNew. IBindingList has slightly differet
logic and eventhough it's an IList IsReadOnly should not be used in this
case as it might be True but AllowNew could be True as well.
Fixes a bug uncovered by a fix to the Array class.
2009-06-08 Carlos Alberto Cortez <[email protected]>
* ListBindingHelper.cs: In GetListItemType do a null check when
looking for IList.Item, since the impl could be explicit, and thus
private. Fix by Florent Fayolle (p.ricca at odyssee-ingenierie.com).
Fixes the remaining part of #507120
2009-06-07 Carlos Alberto Cortez <[email protected]>
* DataObject.cs: Map StringFormat/Text/UnicodeText formats properly,
to match them in all the cases, as this is exactly what .net does.
Fixes#510728.
2009-06-06 Carlos Alberto Cortez <[email protected]>
* ListBindingHelper.cs: In GetListItemType handle gracefully the case
where an instance of IEnumerator returns a null value for its Current
property. Fix by Florent Fayolle (p.ricca at odyssee-ingenierie.com).
Fixes#507120.
2009-06-05 Carlos Alberto Cortez <[email protected]>
* ComboBox.cs: Properly detect whether we need to use our vertical
scrollbar or not, specially for DropDownList/DropDown styles,
depending on the value of DropDownHeight.
Fixes#508541.
2009-06-01 Carlos Alberto Cortez <[email protected]>
* ToolTip.cs: Call the base implementation in Dispose, but do it
before anything else to avoid a regression. This way we do the default
routines related to any System.ComponentModel.Container.
Fixes#508586.
2009-06-01 Carlos Alberto Cortez <[email protected]>
* Clipboard.cs:
* XplatUIX11.cs:
* DataFormats.cs: Implement support for serializable types in our
clipboard.
Fixes#357642.
2009-05-25 Carlos Alberto Cortez <[email protected]>
* ColorDialog.cs: Actually add the help button to the form, so it can
be visible.
Fixes#478555.
2009-05-25 Carlos Alberto Cortez <[email protected]>
* PrintPreviewDialog.cs: Don't use Dock.Fill for the
PrintPreviewControl, since it will be hidden in the top by our
toolbar. Use manual location and anchoring instead.
Fixes#474889.
2009-05-25 Carlos Alberto Cortez <[email protected]>
* FileDialog.cs: When saving the size of the dialog, use the
ClientSize instead of Size, so we have always the same size for the
form. Patch by Alex Shulgin.
Fixes#503064.
2009-05-25 Carlos Alberto Cortez <[email protected]>
* MessageBox.cs: When showing the dialog call XplatUI.AudibleAlert to
show a beep, similar to what .net does.
Fixes#473725.
2009-05-23 Carlos Alberto Cortez <[email protected]>
* ContainerControl.cs:
* MenuStrip.cs
* ToolStrip.cs: Implicit mnemonic processing should happen for every
ToolStrip child, not only for MenuStrip, so we are going to do that in
ToolStrip.ProcessMnemonic, where we already had that exactly
functionality, but we are only just checking that either this instance
is a ToolStripDropDownMenu instance or Alt has been pressed. Finally
remove the extra code, since we are not going to use it now.
Fixes the remaining bits of #503663.
2009-05-21 Neville Gao <[email protected]>
* ContextMenu.cs: Cleaned up UIA properties.
2009-05-20 Dick Porter <[email protected]>
* XplatUICarbon.cs: Add more locking around MessageQueue
manipulations.
2009-05-18 Carlos Alberto Cortez <[email protected]>
* DateTimePicker.cs: Call Focus in HideMonthCalendar to avoid
duplication of code, as well as actually getting the focus back in
*any* scenario where the drop down is closed.
2009-05-18 Tom Hindle <[email protected]>
* ScrollableControl.cs: Ignore setting properties HScroll and
VScroll when AutoScroll is true.
[Fixes bug #500213]
2009-05-18 Jonathan Pobst <[email protected]>
* ToolStripRenderer.cs: Apply patch from Thomas Goldstein to make
disabled graphics look closer to the ones that .Net produces.
[Fixes bug #473660]
2009-05-18 Carlos Alberto Cortez <[email protected]>
* DateTimePicker.cs: When calculating the max width for the year part,
use the current value, since *all* the possible values are exactly a 4
digits number. This way we avoid a ArgumentOutOfRangeException trying
to check against different values.
Fixes#500917.
2009-05-15 Carlos Alberto Cortez <[email protected]>
* MessageBox.cs: When handling ProcessDialogChar, check that
CancelButton is not null before trying to use it, to avoid a null ref
exception. We don't need to do that on the ok/yes buttons, since they
always exist.
Fixes#503935.
2009-05-15 Carlos Alberto Cortez <[email protected]>
* ListBox.cs: Handle the key down event in WndProc instead of doing it
in an event handler, as we need to avoid any operation in case
the user has handled it in its own OnKeyDown handler, and this can't
be achieved since our handler would be the first one always.
* FontDialog.cs: Update the calls since our method handling key down
has been renamed.
Fixes#503469.
2009-05-15 Carlos Alberto Cortez <[email protected]>
* Application.cs: We should dismiss the active ToolStrip when we
receive a WM_SYSKEYDOWN message, instead of WM_SYSKEYUP, so the next
keyboard short cut can be properly processed by another menu item.
Fixes part of #503663.
2009-05-13 Andreia Gaita <[email protected]>
* HtmlDocument.cs: If the objects are strings, wrap them in ""
2009-05-13 Andreia Gaita <[email protected]>
* HtmlDocument.cs: Fix InvokeScript call (duh).
2009-05-11 Carlos Alberto Cortez <[email protected]>
* TextBox.cs: Expose IsAutoCompleteAvailable as internal.
* ComboBox.cs: If auto complete is being used, it is needed to update
the actual value of the combo box, doing it immediately if the user
presses Enter, or doing it when our combo box loses focus. Finally,
when handling Enter and Escape keys for the combobox, don't try to
hide the listbox if it is not visible in the first place.
Fixes part of #489339.
2009-05-11 Carlos Alberto Cortez <[email protected]>
* ToolStripDropDownMenu.cs: Use the height returned by
ToolStripItem.GetPreferredHeight to calculate our own height.
2009-05-10 Carlos Alberto Cortez <[email protected]>
* TreeNode.cs: When setting Checked, do a double null check, since the
current node can still get a null parent handling
TreeView.OnAfterCheck.
Fixes#502567.
2009-05-10 Carlos Alberto Cortez <[email protected]>
* Control.cs: When assigning ContextMenu, do a null check before
assigning its container field.
2009-05-08 Brad Taylor <[email protected]>
* DateTimePicker.cs: Add a UIA-specific property to ensure that if
is_checkbox_checked is changed, we won't break.
2009-05-08 Andrés G. Aragoneses <[email protected]>
* ToolStripItem.cs: Prevent NRE when our holder is a
ToolStripDropDownButton and we get Select()ed.
2009-05-08 Carlos Alberto Cortez <[email protected]>
* ToolStripControlHost.cs: DefaultSize must return the current size of
the Control, not the value returned by GetPreferredSize. Also connect
a handle to the control Resize event, and use it to fire
OnHostedControlReize.
Fixes the remaining bits of #483146.
2009-05-08 Carlos Alberto Cortez <[email protected]>
* ToolStripDropDown.cs: When performing the layout, use
ToolStripItem.GetPreferredSize ().Height instead of
ToolStripItem.Height, since we are already using it that way in this
same method.
Fixes part of ##483146.
2009-05-08 Brad Taylor <[email protected]>
* DateTimePicker.cs: Wrap UIA specific code in NET_2_0 wrappers. Send
OnUIASelectionChanged when ShowCheckbox is true and the checkbox
recieves focus. Part of fix for #502029.
2009-05-06 Mike Gorse <[email protected]>
* FileDialog.cs: Add UIAFocusedItemChanged to PopupButtonPanel.
Add PerformClick and PerformDoubleClick to PopupButton.
Fixes#499851.
2009-05-04 Andrés G. Aragoneses <[email protected]>
* TabControl.cs: call Focus() to emit GotFocus event at the
proper time when SelectionIndex changes. Fixes#499887.
2009-05-03 Carlos Alberto Cortez <[email protected]>
* MonthCalendar.cs: In SetBoundsCore always do the bounds check to
have valid values, even if BoundSpecified is not including
Size/Height/Width - this is useful when we are in a control using Dock
or Anchor.
Fixes part of #483146.
2009-04-27 Carlos Alberto Cortez <[email protected]>
* ComboBox.cs: When losing the focus, if our textbox is not null,
close its auto complete list, if any.
Fixes part of #489339.
2009-04-27 Andrés G. Aragoneses <[email protected]>
* ListView.cs: Make OnColumnClick +internal to be used by a11y.
2009-04-27 Brad Taylor <[email protected]>
* ToolStripButton.cs: Emit an internal event when CheckOnClick is
changed.
2009-04-26 Carlos Alberto Cortez <[email protected]>
* ToolStripDropDownItem.cs: When assigning a new
ToolStripDropDownMenu, let it know we are its OwnerItem. This way the
Capture duties performed by Application/ToolStripManager are handled
nicely and we don't end up in an inconsisten stat.
Fixes#492815.
svn path=/branches/mono-2-4/mcs/; revision=144311
ToolStripDropDownMenu, let it know we are its OwnerItem. This way the
Capture duties performed by Application/ToolStripManager are handled
nicely and we don't end up in an inconsisten stat.
Fixes#492815.
2009-10-14 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=144123
* ToolStrip.cs: Even if we are not exactly a MenuStrip instance, close
any ToolStripDropDownItem when receiving a mouse down event in an
empty area.
svn path=/branches/mono-2-4/mcs/; revision=144122
2009-10-13 Martin Baulig <[email protected]>
* debug-mini.c (mono_debugger_trampoline_compiled): Add
`const guint8 *trampoline' argument; send both the old and the new
notification.
2009-10-13 Martin Baulig <[email protected]>
* mono-debug-debugger.h (MonoDebuggerEvent): Renamed
`MONO_DEBUGGER_EVENT_TRAMPOLINE' into
`MONO_DEBUGGER_EVENT_OLD_TRAMPOLINE' and added a new
`MONO_DEBUGGER_EVENT_TRAMPOLINE'.
* mono-debug.h (MONO_DEBUGGER_MINOR_VERSION): Bump to 80.2.
svn path=/branches/mono-2-4/mono/; revision=144054
In tools/xbuild:
2009-10-12 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: For referenced projects,
when trying to get the deploy items, ensure that the split
lists of project references are available.
(SplitProjectReferencesByExistent): New.
Set DependsOnTargets appropriately.
2009-10-12 Ankit Jain <[email protected]>
* SolutionParser.cs: Handle non-existing project files, and
project file load errors. Raise warnings instead of failing.
* xbuild/Microsoft.Common.targets: Handle non-existant
Project references, skip instead of failing.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
2009-10-12 Ankit Jain <[email protected]>
* ResolveAssemblyReference.cs: Remove unnecessary tab in the warning
messages.
2009-10-12 Ankit Jain <[email protected]>
* MSBuild.cs (Execute): Handle build errors.
In class/Microsoft.Build.Tasks:
2009-10-12 Ankit Jain <[email protected]>
* Makefile: Add reference to Microsoft.Build.Engine .
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-10-12 Ankit Jain <[email protected]>
* Target.cs (TargetFile): New. Gives the name of the file
containing the target definition.
* BuildEngine.cs (.ctor): Add a 'taskfile' parameters, and
return this for ProjectFileOfTaskNode.
* BuildTask.cs (LogTaskStarted):
(LogTaskFinished): Use parentTarget.ProjectFileOfTaskNode for
the event.
(InitializeTask): Set BuildEngine's task file to parent target's
TargetFile.
* Engine.cs (LogProjectStarted): Incase of default targets, set
TargetNames to String.Empty .
* TargetBatchingImpl.cs (LogTargetStarted):
(LogTargetFinished): Use target.TargetFile for the event.
* ConsoleLogger.cs: Keep a stack of project/target/task being
executed. And corresponding list of errors and warnings.
(EventsToString): Stringifies the current "stack", to be used
as key to the table of errors/warnings and for show messages
at the end of the build.
2009-10-12 Ankit Jain <[email protected]>
* Project.cs (Load): Add argument checks.
In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
2009-10-12 Ankit Jain <[email protected]>
* TaskLoggingHelper.cs: Use the buildEngine.ProjectFileOfTaskNode
in the event args.
2009-10-12 Ankit Jain <[email protected]>
* ToolTask.cs (ExecuteTool): Don't set toolOutput to null.
(HandleTaskExecutionErrors): toolOutput can be null.
Set toolOutput to null here.
svn path=/branches/mono-2-4/mcs/; revision=143970
In tools/xbuild:
2009-10-11 Ankit Jain <[email protected]>
* Main.cs: Add support for emitting messages in color.
Taking relevant code from mcs/report.cs . Using ANSI
color codes here instead of Console.ForegroundColor
because of a bug in Console.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-10-11 Ankit Jain <[email protected]>
* ConsoleLogger.cs (no_colors): Rename to ..
(use_colors): .. this. Fix the case when XBUILD_COLORS
is not set.
2009-10-11 Ankit Jain <[email protected]>
* ConsoleLogger.cs: Use ColorSetter and ColorResetter .
Support 'XBUILD_COLORS' to set colors for errors, warnings,
events and messages.
2009-10-10 Ankit Jain <[email protected]>
* ConsoleLogger.cs (ProjectFinishedHandler): Once projectFailed
becomes true, don't reset it. We are looking for "atleast one
project failed".
svn path=/branches/mono-2-4/mcs/; revision=143905
2009-10-09 Ankit Jain <[email protected]>
* Exec.cs (AddCommandLineCommands): Add '/q' for cmd.exe, to
turn 'echo off'. And make sure the script file on windows, has
a '.bat' extension, otherwise cmd.exe opens it in a text editor.
2009-10-09 Ankit Jain <[email protected]>
Fix bug #545703.
* Exec.cs (Command): On unix, change CRLF to CR.
svn path=/branches/mono-2-4/mcs/; revision=143882
* certmgr.cs: Don't throw if we're missing an argument. Fix by
Romain Tartiere (bug #464765). Updated help to specify that
"option type" is mandatory in some cases.
[Backport from HEAD to fix#544518]
svn path=/branches/mono-2-4/mcs/; revision=143814
* class-internals.h, generic-sharing.c: New RGCTX info type for
getting a remoting invoke with check wrapper.
Backport of r137640.
2009-07-09 Mark Probst <[email protected]>
* method-to-ir.c: When doing a call which might be remote from
shared generic code to other shared code with open type arguments,
get the remoting invoke wrapper from the RGCTX and do an indirect
call to it.
Backport of r137640.
svn path=/branches/mono-2-4/mono/; revision=143791
In tools/xbuild:
* xbuild/Microsoft.Common.targets: Don't get list of files
to deploy, for 'Private' project references.
Fix target named for *CopyDeploy*.
In tools/xbuild/tests:
* standalone/Project1: Add a new Lib5 project, and add
private references to various projects.
Update final-outputs.txt .
* standalone/Project01/Lib5/*: New.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
* ResolveAssemblyReference.cs: Don't resolve any dependencies for
assemblies resolved from {PkgConfig}. Honor parent's CopyLocal for
dependencies.
svn path=/branches/mono-2-4/mcs/; revision=143742
* SortedList.cs: Add version checking to the Key/Value enumerators +
implement support for Reset (). Fixes#483985.
svn path=/branches/mono-2-4/mcs/; revision=143738
In tools/xbuild:
2009-10-08 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.tasks: Add RemoveDuplicates task.
In class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks:
2009-10-08 Ankit Jain <[email protected]>
* TestMessageLogger.cs (CheckLoggedAny): New.
2009-10-08 Ankit Jain <[email protected]>
* RemoveDuplicatesTest.cs: New.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
2009-10-08 Ankit Jain <[email protected]>
* MSBuild.cs (Execute): Don't share target output items,
always create a copy.
2009-10-08 Ankit Jain <[email protected]>
* RemoveDuplicates.cs: Use item's ItemSpec as the key.
2009-10-07 Ankit Jain <[email protected]>
* ManagedCompiler.cs (HandleTaskExecutionErrors): Log error if
required.
2009-10-06 Ankit Jain <[email protected]>
* Exec.cs (ExecuteTool): Use DeleteTempFile instead of File.Delete
(HandleTaskExecutionErrors): Log error, if required.
* MSBuild.cs: Don't log error.
* Warning.cs: Don't log if @text is empty.
In class/Microsoft.Build.Tasks:
2009-10-08 Ankit Jain <[email protected]>
* Microsoft.Build.Tasks_test.dll.sources: Added
RemoveDuplicatesTest.cs
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
2009-10-08 Ankit Jain <[email protected]>
* ProjectTest.cs (TestBatchedMetadataRefInOutput): New.
In class/Microsoft.Build.Engine/Test/various:
2009-10-08 Ankit Jain <[email protected]>
* Items.cs (TestItemsWithWildcards): New.
2009-10-08 Ankit Jain <[email protected]>
* Items.cs (TestItems5): Fix to work correctly on windows
and unix.
(TestReservedMetadata): New.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-10-08 Ankit Jain <[email protected]>
* DirectoryScanner.cs: Use Path.GetPathRoot, instead of
directly using DirectoryInfo ("z:"), that doesn't return
a dir info for "z:".
2009-10-08 Ankit Jain <[email protected]>
* DirectoryScanner.cs: Handle absolute paths. Fix to work
correctly on windows. Change order of adding paths to match
msbuild, useful to have.
2009-10-08 Ankit Jain <[email protected]>
* TaskBatchingImpl.cs (ParseTaskAttributes): Parse attributes
of the 'Output' element also.
* TaskEngine.cs (PublishOutput): Honor condition on 'Output' also.
2009-10-07 Ankit Jain <[email protected]>
* ConsoleLogger.cs: Mark build as failed, if any project failed.
2009-10-06 Ankit Jain <[email protected]>
* ConsoleLogger: Improve error reporting. Don't count failed task,
target or project as another error. Show "errors" after "warnings",
more useful to the user.
* Project.cs (BuildTarget): Log error instead of using CWL.
In class/Microsoft.Build.Utilities/Mono.XBuild.Utilities:
2009-10-08 Ankit Jain <[email protected]>
* ReservedNameUtils.cs: Fix 'RootDir', 'Directory'.
(WithTrailingSlash): New.
Update to use the new WithTrailingSlash method.
In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
2009-10-06 Ankit Jain <[email protected]>
* ToolTask.cs (Execute): HandleTaskExecutionErrors is called only
if exitCode != 0.
(ExecuteTool): Move logging of exitcode to HandleTaskExecutionErrors.
Remove MonoTODOs.
* TaskLoggingHelper.cs (LogMessageFromText): New.
(LogMessage): Refactor to use above.
svn path=/branches/mono-2-4/mcs/; revision=143737
* CryptoStreamTest.cs: Make latest test cases compilable using
older 2.4 mcs (which does not support automatically implemented
properties and implicitly typed arrays)implicitly typed arrays
svn path=/branches/mono-2-4/mcs/; revision=143664
* RealProxy.cs: for a custom proxy, retrieve the OutArgs before
allowing EndInvoke to proceed because after that, OutArgs will throw
because there is no method. Fixes remoting2 and remoting3 tests.
svn path=/branches/mono-2-4/mcs/; revision=143662
* GatewayIPAddressInformationCollection.cs:
* IPInterfaceProperties.cs: implement GatewayAddresses for linux.
Original patch by Christoph von Wittich.
Fixes bug #544640.
svn path=/branches/mono-2-4/mcs/; revision=143527
* object.c (mono_method_return_message_restore): Handle the case
where the argument is an instance of a generic type. Fixes
#544446.
Backport of r143506.
2009-10-06 Mark Probst <[email protected]>
* bug-544445.cs: New test.
* Makefile.am: Test added.
Backport of r143506.
svn path=/branches/mono-2-4/mono/; revision=143508
* RTF.cs: If the rtf specified a code page outside the valid values,
fallback to the default one.
Fixes#503174.
svn path=/branches/mono-2-4/mcs/; revision=143479
* DateTimePicker.cs: Call Focus in HideMonthCalendar to avoid
duplication of code, as well as actually getting the focus back in
*any* scenario where the drop down is closed.
svn path=/branches/mono-2-4/mcs/; revision=143478
use the current value, since *all* the possible values are exactly a 4
digits number. This way we avoid a ArgumentOutOfRangeException trying
to check against different values.
Fixes#500917.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143477
* ComboBox.cs: If auto complete is being used, it is needed to update
the actual value of the combo box, doing it immediately if the user
presses Enter, or doing it when our combo box loses focus. Finally,
when handling Enter and Escape keys for the combobox, don't try to
hide the listbox if it is not visible in the first place.
Fixes part of #489339.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143476
close its auto complete list, if any.
Fixes part of #489339.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143475
* Control.cs, ContextMenuStrip.cs, ToolStripMenuItem.cs: Only process any
shortchut in ToolStripMenuItem.ProcessCmdKey if the control generating the
event is the same as the owner of the menu item. Also set properly
SourceControl for ContextMenuStrip, as well as add an internal field to
contain the control that owns the ContextMenuStrip (we need to know this
even before the public property is assigned).
Fixes bits of #393775.
svn path=/branches/mono-2-4/mcs/; revision=143474
* ListBox.cs: The default instance StringFormat field used to draw our
items should use the StringFormatFlags.NoWrap value, so it doesn't try
to put in a different line the text that doesn't fit our bounds, but
show it partially.
Fixes#475581.
svn path=/branches/mono-2-4/mcs/; revision=143472
* CheckedListbox.cs: When executing OnItemClick check that the index
is different to -1 before trying to retrieve an item using that value.
Fixes a ArgumentOutOfRangeException thrown when the horizontal
scrollbar was visible but not needed, and then a clicked was received
on its area.
svn path=/branches/mono-2-4/mcs/; revision=143471
* ListView.cs: In EnsureVisible avoid any direct access to items if we
are using virtual mode - otherwise use the bounds stored in a specific
item in a given index. This is specially important when using groups
or when items are re-arranged, since the position in the items
collection can be different than that one being displayed.
Fixes the rest of #491978.
svn path=/branches/mono-2-4/mcs/; revision=143470
internally the value of selected_index to -1, to avoid trying to
access the previous one when trying to set the new one (and was
already removed from the collection). This is what .net seems to do
too.
Fixes#490937.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143469
GetRftText in our clipboard formats list, instead of using the
generical Text format.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143468
internal source provided by ComboBox, and also remove some repeated
checks.
Fixes#489339.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143467
* X11Clipboard.cs: Move internal ClipboardStruct from X11Structs to
its own file, since it is adding some functionality and thus is not a
simple struct as before.
* XplatUIX11.cs: Add support to store different formats that could
have been specified by the user when puting data in the Clipboard -
this is important when more than one format is supported (such plain
text and rtf text). Update in the needed places, as well as simplify
the code.
Fixes#489625.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143465
SelectionRequestEvent instead of SelectionEvent, so we get the right
data for the app asking for clipboard data. Set the member of
SelectioneEvent.property to indicate the place where we are storing
the information as well - this is specially important for gnome/kde
apps using the TARGETS atom to ask for the supported permission before
actually asking for a specific format.
Fixes#489393.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143460
* ToolStrip.cs: When disposing, iterate over the items in reverse
order, since disposing the items modifies the collection.
* ToolStripItem.cs: Remove from the owner when disposing.
Fixes#485769.
svn path=/branches/mono-2-4/mcs/; revision=143459
* DomainUpDown.cs: When ReadOnly is true, all the text entered by the
user should use a different handling, trying to use every pressed char
as a unique and only one prefix to compare against the items. Also,
refactor some input check code to avoid duplication.
Fixes#458607.
svn path=/branches/mono-2-4/mcs/; revision=143456
* Form.cs: When calling ProcessCmdKey, just after checking for any
MainMenu, check if there's an active ContextMenu that is *not* owned
by the form - this is needed when a non-focusable control owns a
ContextMenu but its ProcessCmdKey method can't be called since it
can't receive any input.
Fixes#477655.
svn path=/branches/mono-2-4/mcs/; revision=143453
* RichTextBox.cs: LoadFile(string path) should pass by default
RichTextBoxStreamType.RichText, without caring about the detection or
extension of the file.
svn path=/branches/mono-2-4/mcs/; revision=143450
the very specific *real* position where the mouse was pressed, using
GetItemAtDisplayIndex for that purpose, instead of directly accessing
Items - this is specially useful when groups with Details view is
used. This is what we do in other places when using groups.
Fixes part of #478689.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143449
the existence of the column headers, as well as using this information
to adjust the vscrollbar value, so items never get hidden by the
column headers.
Fixes#478498.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143448
* TextBox.cs: Some code lifting for AutoComplete's support. First,
when handling non-navigation keys, save the original Text typed by the
user, and don't motify it BEFORE. This was a design mistake, since the
re-assignation happens only when navigating the append/suggest list,
not while creating the matches. Also, process the Delete key just like
the backspace one. Finally, when handling WM_CHAR, ignore both Escape
and Enter keys.
Fixes some missing bits of #469967.
svn path=/branches/mono-2-4/mcs/; revision=143446
* TextBox.cs: When handling WndProc with autocomplete activated,
event if the new text is not causing any change in the look up
algorithm, save it as we normally do when numbers and letters.
Fixes#469967.
svn path=/branches/mono-2-4/mcs/; revision=143427
invalidate also the previous selected node bounds.
Fixes#464191.
2009-10-05 Carlos Alberto Cortez <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=143424
* TreeView.cs: When handling the MouseMove event, check if
focused_node and selected_node fields are null - usually they are non
null, since we have always a selected node, but canceling selection by
handling BeforeSelect event leaves the two of them as null.
Fixes#470451.
svn path=/branches/mono-2-4/mcs/; revision=143423
* TreeView.cs: When drawing the node's image, check that the index
specified by the node is valid for the ImageList.
Fixes#471094.
svn path=/branches/mono-2-4/mcs/; revision=143422
In tools/xbuild:
2009-10-03 Ankit Jain <[email protected]>
Fix bug#542461.
* xbuild/Microsoft.Common.targets (KeyOriginatorFile): Set to
$(AssemblyOriginatorKeyFile), if SignAssembly is true.
Use it for satellite assemblies also.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-10-03 Ankit Jain <[email protected]>
* Project.cs (OS): New.
(InitializeProperties): Set 'OS' as a pre-defined property, set to
'Windows_NT', 'Unix' or 'OSX' depending on the platform.
svn path=/branches/mono-2-4/mcs/; revision=143318
* mini-sparc.c (mono_arch_emit_setret): Emit long return values using OP_LMOVE.
(mono_arch_create_vars): Instead of allocating a stack slot by hand, allocate
a variable to hold the stack slot used by the int<->float conversion opcodes.
svn path=/branches/mono-2-4/mono/; revision=143309
* HtmlSelectBuilder.cs: <option> allows the value of the 'selected'
attribute to be a boolean or the string "selected", which is treated
as "true".
svn path=/branches/mono-2-4/mcs/; revision=143107
* Hashtable.cs: MS (at least latest and greatest) does not always
serialized the HashCodeProvider. Ignoring the error when the field
is not found.
svn path=/branches/mono-2-4/mcs/; revision=143101
* BuildManager.cs: load/set the global resources assembly for
precompiled and merged sites correctly.
svn path=/branches/mono-2-4/mcs/; revision=143095
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
2009-10-01 Ankit Jain <[email protected]>
* ImportTest.cs (TestAdd1): Add tests for multiple imports.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-10-01 Ankit Jain <[email protected]>
* Project.cs (AddImport): Show the correct source file name, when
the import is in the main project file.
2009-10-01 Ankit Jain <[email protected]>
Fix bug #543299.
* Import.cs (.ctor): Evaluate and set EvaluatedProjectPath to
the full path of the imported project here itself, instead of ..
(Evaluate): .. here.
* ImportCollection.cs (Add): Use import.EvaluatedProjectPath .
(Contains): New.
* Project.cs (AddImport): Don't process if condition is false.
Warn if a circular reference is detected, and ignore the import.
svn path=/branches/mono-2-4/mcs/; revision=143087
A fix for bug #542959
* delegate.cs: Emit correct delegate instance variable when there
are static and non-static overloads.
svn path=/branches/mono-2-4/mcs/; revision=142979
* BinaryFormatter.cs: NoCheckDeserialize() was using PeekChar() on a
reader when it should only read 1 byte. Also BinaryReader.PeekChar()
tries to set the position of hte stream back to where it was before
the read, which does not work well with broken Stream
implementations like BZip2InputStream (reports CanSeek is true when
it really can't seek). Now we do a Read() and then pass the value we
read on to the next methods.
* MessageFormatter.cs:
* ObjectReader.cs: added overloads that take a BinaryElement instead
of reading it from the reader. Only for the methods used in
NoCheckDeserialize.
Fixes bug #503435.
svn path=/branches/mono-2-4/mcs/; revision=142966
* InotifyWatcher.cs: fixes bug #322330. Patch by Alexander Kojevnikov.
This patch fixes the issues reported by the OP and in my previous
comment. In particular:
Hunks 1 and 4 remove the new_name_needed flag, it's not used
anywhere and only adds confusion.
Hunk 2 skips DeleteSelf event for sub-directories, they receive the
Delete event anyway.
Hunk 3 makes sure that we use a combination of Deleted+Created
notifications instead of a single Renamed notification, if the watched item
has been moved from one directory to another. This is because RenamedEventArgs
supports only one directory name: FullPath is always directory+name,
OldFullPath is always directory+old_name.
Hunk 5 updates relevant InotifyData instances with the new directory
name. Without this, notifications always use the original folder names.
The last hunk may be a bit slow as it needs to iterate on all the
InotifyData instances. On the other hand, we are already doing it on the
Delete event (lines 560:568) and by default inotify allows only 8192 watches
per user.
svn path=/branches/mono-2-4/mcs/; revision=142960
* DefaultValueAttribute.cs: Implement the cctor which takes
a Type and a string for the SL2 case.
* CategoryAttribute.cs: Fix a typo in the CategoryAttribute.Asynchronous
ctor and fix some SL2 specific naming changes for the default properties.
svn path=/branches/mono-2-4/mcs/; revision=142890
In tools/xbuild:
2009-09-29 Ankit Jain <[email protected]>
* SolutionParser.cs (Insert): Show project name in case of a cyclic
dependency.
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
2009-09-29 Ankit Jain <[email protected]>
* ProjectTest.cs (TestPropertiesFromImportedProjects): New.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
* GroupingCollection.cs (Evaluate): Mark internal.
* Project.cs (AddImport): Only evaluate the properties,
till before the import.
svn path=/branches/mono-2-4/mcs/; revision=142873
* mono-compiler.h (MONO_INTERNAL): Disable this on solaris as it produces a
millions of warnings during compilation.
svn path=/branches/mono-2-4/mono/; revision=142869
* mini-sparc.c (mono_arch_allocate_vars): Use mono_class_from_mono_type ()
instead of using type->data.klass as the later doesn't work with generics.
svn path=/branches/mono-2-4/mono/; revision=142868
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
2009-09-29 Ankit Jain <[email protected]>
* Exec.cs: Write the commands, which can be multiline,
to a temporary file, and execute that with "cmd.exe /c"
on windows and "sh" on non-windows.
(LogToolCommand): Override, and emit the commands instead
of the actual args passed to the shell.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-09-29 Ankit Jain <[email protected]>
* Project.cs (DoLoad): Don't use XmlReader.Create, for loading
the project xml, as returned Xml*Reader normalizes the newlines.
Instead directly use the TextReader with XmlDocument.Load ().
In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
2009-09-29 Ankit Jain <[email protected]>
* ToolTask.cs (ExecuteTool): Use LogToolCommand, instead of
directly logging.
(LogToolCommand): Implement.
svn path=/branches/mono-2-4/mcs/; revision=142793
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
2009-09-28 Ankit Jain <[email protected]>
* WriteLinesToFiles.cs (Execute): Handle empty list of
lines.
In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
2009-09-28 Ankit Jain <[email protected]>
* ToolTask.cs (ProcessOuputTool): Move logging of tool
output from here to ..
(ExecuteTool): .. here. As, ProcessOuputTool can be
overridden.
svn path=/branches/mono-2-4/mcs/; revision=142743
In tools/xbuild:
2009-09-27 Ankit Jain <[email protected]>
* SolutionParser.cs: Implement support for WebSite projects. These
projects lack a project file, so properties like references are read
from the .sln file, and targets are generated for build/clean etc.
2009-09-26 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: Remove _ValidateEssentialProperties
from BuildDependsOn, which was a hack. It will get invoked from the
InitialTargets now.
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
2009-09-26 Ankit Jain <[email protected]>
* TargetTest.cs (TestOverridingTargets): New.
2009-09-26 Ankit Jain <[email protected]>
* ProjectTest.cs (TestInitialTargetsWithImports):
(TestDefaultTargets):
(TestDefaultTargetsWithImports):
(TestNoDefaultTargetsWithImports):
(TestNoDefaultTargets): New tests.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-09-27 Ankit Jain <[email protected]>
* ConditionParser.cs: Show the condition being parsed in the
exception message.
2009-09-26 Ankit Jain <[email protected]>
* Expression.cs: Allow '-' in item, property and metadata names.
2009-09-26 Ankit Jain <[email protected]>
* Project.cs (Evaluate): Split into this and ..
(PrepareForEvaluate): .. this.
(AddImport): Evaluate the current set of properties/items etc,
before processing the imported project. Honor the Condition
for the Import.
(ProcessProjectAttributes): Update MSBuildProjectDefaultTargets
property.
* GroupingCollection.cs (Evaluate): Don't evaluate Imports here.
* BuildItemGroup.cs (Evaluate): Evaluate only once.
* BuildPropertyGroup.cs (Evaluate): Evaluate only once.
2009-09-26 Ankit Jain <[email protected]>
* Project.cs: Get InitialTargets from the imported projects also.
The combined list of targets are executed, in the order they were
found.
DefaultTargets are also read in from imported projects, and the first
non-empty DefaultTargets found is used.
svn path=/branches/mono-2-4/mcs/; revision=142685
* mini-sparc.c (mono_arch_create_vars): Make the component vars of a long ret
variable volatile. Fixes#541577.
* basic-calls.cs: Add a new test.
* basic-long.cs: Remove tests which are now in basic-calls.cs.
svn path=/branches/mono-2-4/mono/; revision=142652
* BinderTest.cs: Added SelectMethod/BindToMethod tests for methods
with byref arguments.
* Binder.cs: Only allow a type to match its byref version for
BindToMethod (and not for SelectMethod).
* TypeTest.cs: Enabled test that was failing due to regression.
svn path=/branches/mono-2-4/mcs/; revision=142638
In tools/xbuild:
* Makefile(EXTRA_DISTFILES): Add Microsoft.WebApplication.targets
2009-09-25 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: Emit list of files written
during the build, even if the build fails.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
* Project.cs (BuildTarget): Handle skipped targets.
svn path=/branches/mono-2-4/mcs/; revision=142632
In tools/xbuild:
2009-09-25 Ankit Jain <[email protected]>
Fix bug #534992.
* xbuild/Microsoft.Common.targets: Add support for copying
app.config to AssemblyName.config
* xbuild/Microsoft.Common.tasks: Add FindAppConfigFile task.
2009-09-24 Ankit Jain <[email protected]>
* Parameters.cs (ParseArguments): If no project file is specified,
then look for a .sln or *proj file in the current directory.
2009-09-24 Ankit Jain <[email protected]>
* Makefile: Create dir for WebApplication.targets .
* Microsoft.Common.targets (_ValidateEssentialProperties): New.
(BuildDependsOn): Add _ValidateEssentialProperties, temporary.
This should actually work via InitialTargets, which will be fixed
in a subsequent commit. Add PrepareForRun.
(PrepareForRun): New.
* xbuild/Microsoft.WebApplication.targets: New.
2009-09-23 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: Add 'Rebuild' target.
Also, set DefaultTargets to "Build".
In tools/xbuild/tests:
2009-09-25 Ankit Jain <[email protected]>
* standalone/Project01: Add app.config to project Lib1.
Remove Project01.sln.proj . Update final-outputs.txt .
In class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks:
2009-09-25 Ankit Jain <[email protected]>
* FindAppConfigFileTest.cs: New.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
2009-09-25 Ankit Jain <[email protected]>
* FindAppConfigFile.cs: New.
2009-09-24 Ankit Jain <[email protected]>
* ReadLinesFromFile.cs (Execute): Don't do anything, if
file is non-existant.
2009-09-24 Ankit Jain <[email protected]>
* ToolTaskExtension.cs (HasLoggedErrors): Override.
2009-09-23 Ankit Jain <[email protected]>
* MSBuild.cs (BuildInParallel): Add missing property.
2009-09-10 Ankit Jain <[email protected]>
* AssemblyResolver.cs: Move the SearchLogger to be a list of
strings, so that it can be emitted with correct indentation.
(SearchLogger): Remove.
(LogSearchMessage): New.
(LogSearchLoggerMessages): New.
* ResolveAssemblyReference.cs: Track api changes.
In class/Microsoft.Build.Tasks:
2009-09-25 Ankit Jain <[email protected]>
* Microsoft.Build.Tasks.dll.sources: Added
FindAppConfigFile.cs
* Microsoft.Build.Tasks_test.dll.sources: Added
FindAppConfigFileTest.cs
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-09-25 Ankit Jain <[email protected]>
* Project.cs (DoLoad): If a VS2003 project is detected, then throw
InvalidProjectFileException with useful error.
2009-09-24 Ankit Jain <[email protected]>
* Project.cs (Load): Emit the .sln.proj file only if env var
XBUILD_EMIT_SOLUTION is set.
2009-09-24 Ankit Jain <[email protected]>
* Project.cs (GetKeyForTarget): Make target name, case insensitive.
2009-09-24 Ankit Jain <[email protected]>
* Project.cs (InitializeProperties): Set 'MSBuildProjectDefaultTargets'
reserved property.
In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
2009-09-24 Ankit Jain <[email protected]>
* ToolTask.cs (HasLoggedErrors): Add missing property.
2009-09-23 Ankit Jain <[email protected]>
* TaskLoggingHelper.cs (LogErrorFromException): Add missing overload.
2009-09-10 Ankit Jain <[email protected]>
* TaskLoggingHelper.cs (FormatString): Use the unformatted string
even if the args array was empty.
svn path=/branches/mono-2-4/mcs/; revision=142611
* DataGridView.cs: Compare the name and not displayname of properties
when checking if the column is already bound.
svn path=/branches/mono-2-4/mcs/; revision=142537
* EnumConverter.cs: Fix conversion of 0 flag values.
* EnumConverterTests.cs: Add a test to verify behaviour when converting
a 0 flag value.
[Fixes bug #541402]
svn path=/branches/mono-2-4/mcs/; revision=142535
2009-09-22 Sebastien Pouliot <[email protected]>
* CryptoStreamTest.cs: Add (nunit-ized) test cases provided by
Santa Marta (via Atsushi) as repro for bugs #539288 and #539229
2009-09-22 Sebastien Pouliot <[email protected]>
* CryptoStreamTest.cs: Convert to newer nunit syntax
In System.Security.Cryptography:
2009-09-23 Sebastien Pouliot <[email protected]>
* CryptoStream.cs: Fix [Input|Output]BlockSize for custom streams.
Patches by Santa Marta (via Atsushi).
[Fix bug #539288 and #539229]
[Backport r142435]
svn path=/branches/mono-2-4/mcs/; revision=142476
* method-to-ir.c: Applied patch from Rodrigo Kumpera. Allow an i8 argument
to NEWARR.
* iltests.il.in: Add a new test.
svn path=/branches/mono-2-4/mono/; revision=142260
2009-09-17 Rodrigo Kumpera <[email protected]>
Backport of r127430.
* appdomain.c:
* generic-sharing.c:
* object.c:
* reflection.c: Adjust locking order to the new semantics where the loader lock
comes first.
Backport of r126758/126783.
* reflection.c (mono_reflection_lookup_dynamic_token): This function might be called without
the loader lock which is required to guard MonoImage:tokens.
In mini:
2009-09-17 Rodrigo Kumpera <[email protected]>
Backport of r127430.
* mini.c: Adjust locking order to the new semantics where the loader lock
comes first.
svn path=/branches/mono-2-4/mono/; revision=142152
* mini-exceptions.c (mono_handle_exception_internal): Store the computed
lmf before calling filter clauses as well. Fixes#539550.
* exceptions.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=142030
* System.Net.Configuration/DefaultProxyHandler.cs:
* System.Net/WebRequest.cs: handle upper and lowercase HTTP_PROXY and
the Any address.
Fixes bug #537283.
svn path=/branches/mono-2-4/mcs/; revision=141982
* DesignSurface.cs: Prevent a NRE in Flush by cheching if the
designer loader is null.
[Fixes bug #538929]
svn path=/branches/mono-2-4/mcs/; revision=141889
* AsyncResult.cs: lock when setting the 'completed' field and use the
property instead of the 'handle' field.
svn path=/branches/mono-2-4/mcs/; revision=141861
* InternalWindowManager.cs: Call Invalidate-Update instead of
Refresh for MS compitability. Note also that Refresh is virtual
and several controls override it in order to provide data refresh
functionallity on top of the redraw and they do not expect this
extra refresh call.
* Control.cs: In Refresh Invalidate the control and all children
insead of calling Refresh for each of them.
[Fixes bug #538336]
svn path=/branches/mono-2-4/mcs/; revision=141745
* PropertyGrid.cs: Always set the help panel properties on the
internal control, because they are inherited and can change with
the parent.
[Fixes bug #525305]
svn path=/branches/mono-2-4/mcs/; revision=141734
* DocumentDesigner.cs: Changing the ISelectionService at run time was a
bad idea, so wrap it inside the extended UISelectionService instead.
svn path=/branches/mono-2-4/mcs/; revision=141682
* DesignSurface.cs: Provide the default implementation of the
ISelectionService in the DesignSurface service container.
* DocumentDesigner.cs: If there is already a ISelectionService registered
in the ServiceContainer but it's not an IUISelectionService (WinForms
specific) then replace it with one.
[Fixes bug #538037]
svn path=/branches/mono-2-4/mcs/; revision=141681
In class/Microsoft.Build.Engine/Test/various:
* Items.cs (TestItems2a):
(TestInheritedMetadataFromItemRefs):
(TestInheritedMetadataFromItemRefs2):
(TestMetadataFromItemReferences): New.
2009-09-08 Ankit Jain <[email protected]>
* Items.cs (TestItems5):
(TestItems6): Remove 'NotWorking' attribute.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
* BuildItem.cs (Evaluate): Metadata from "Include" should be,
preserved, so use ConvertTo ITaskItem, rather than string.
Ensure that the new items have the metadata from references _in_
Include, and the metadata of _this_ builditem.
* DirectoryScanner.cs (Includes): Change to a array of ITaskItem.
(MatchedFilenames): Rename to ..
(MatchedItems): .. this, and change type of array of ITaskItem.
Ensure that metadata of items in Includes are retained in the
final matched items.
* BuildItemGroup.cs (ConvertoToITaskItemArray): Add 'separator'
param. If separator is present, then just return a "Join'ed"
string as the single task item.
* ItemReference.cs: Track api changes.
* BuildProperty.cs (ConvertToITaskItemArray): Split the value,
as we need separate task items.
In class/Microsoft.Build.Utilities/Mono.XBuild.Utilities:
* ReservedNameUtils.cs (RelativeDir): Add a trailing \ .
In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
* ToolTask.cs (LogEventsFromTextOutput): Log message even if its not
identified as an error or a warning.
svn path=/branches/mono-2-4/mcs/; revision=141670
* DataView.cs (OnRowChanged/OnRowDeleted): Raise appropriate events iff
view is affected. This silence of the numerous Add/Change events that were
getting raised from DataView.
(ToTable): Use appropriate index to generated DataTable in case of
RowFilter / Sort conditions.
* DataRow.cs (AcceptChanges/RejectChanges): Raise appropriate Changing events
svn path=/branches/mono-2-4/mcs/; revision=141655
* ParentControlDesigner.cs, ControlDesigner.cs, UISelectionService.cs,
IUISelectionService.cs: Support IToolboxService control creation via
point-(resize)-click.
[Fixes part of bug #537604]
svn path=/branches/mono-2-4/mcs/; revision=141613
* DesignSurface.cs: Don't be so strict and allow for the users
to get the View even if the DesignSurface wasn't properly initialized
with a DesignerLoader. MS compatibility.
[Fixes bug #537131]
svn path=/branches/mono-2-4/mcs/; revision=141407
* processes.c (CreateProcess): Return false and set the error to
ERROR_OUTOFMEMORY when a process handle cannot be created.
(ShellExecuteEx): Propagate an ERROR_OUTOFMEMORY error code. Fixes part of
#536776.
svn path=/branches/mono-2-4/mono/; revision=141382
* threadpool.c: make the Sleep() alertable to prevent delays exiting
applications that take less than 2s to execute.
Bug #524984 fixed.
svn path=/branches/mono-2-4/mono/; revision=141364
* WebConnection.cs: if the request has already finished reading, don't
throw ObjectDisposedException here, just return as if nothing
happened. Fixes bug #312968.
svn path=/branches/mono-2-4/mcs/; revision=141348
* WebConnection.cs: if the request has already finished reading, don't
throw ObjectDisposedException here, just return as if nothing
happened. Fixes bug #312968.
svn path=/branches/mono-2-4/mcs/; revision=141347
* DataColumnPropertyDescriptor.cs, DataView.cs: Not browsable if Hidden.
[Fixes the second part of bug #536547]
svn path=/branches/mono-2-4/mcs/; revision=141276
* BindingSource.cs: Implement support for chained data sources.
* ListBindingHelper.cs: Add support for ICurrencyManagerProvider and
clean up.
[Fixes part of bug #536547]
svn path=/branches/mono-2-4/mcs/; revision=141275
* marshal.c (emit_marshal_array): Call conv.ovf.i on the array parameter
argument, since NEWARR expects a native int. Fixes#481559.
svn path=/branches/mono-2-4/mono/; revision=141270
* DB2CLIWrapper.cs: changed libname to 'db2'. Use 'int' instead of
'IntPtr' for most of the SQL handles. Only SQLPOINTER is 64 bits in
64-bit machines.
svn path=/branches/mono-2-4/mcs/; revision=141089
* exceptions-x86.c (throw_exception): Fix the previous change by substracting
the alignment for the value of sp.
svn path=/branches/mono-2-4/mono/; revision=141070
In class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks:
* TaskBatchingTest.cs: Add new tests for metadata refs found
in places other than task attributes.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
* ResolveAssemblyReference.cs (ResolveReference): targetFrameworkDirectories
can be null.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-09-01 Ankit Jain <[email protected]>
Fix bug #534965.
* Project.cs (BuildTarget): Move caching of target outputs to ..
* Target.cs: .. here. Move LogTargetSkipped also here.
Ensure that caching happens for target dependencies also.
2009-09-01 Ankit Jain <[email protected]>
* DirectoryScanner.cs (Scan): Ignore empty entries in includes and
excludes.
2009-09-01 Ankit Jain <[email protected]>
* Expression.cs (ParseOptions): New enum. Replace the bool params
of exression.Parse with this. Add option to control expansion of
metadata references.
(CopyToExpressionCollection): Track api changes.
Update all expr.Parse calls to use the new enum.
* BuildItem.cs, BuildProperty.cs, BuildTask.cs, Import.cs,
Target.cs, TargetBatchingImpl.cs, UsingTask.cs: Track api changes.
* BatchingImplBase.cs: Track api changes. Allow metadata refs
in task attributes.
* ConditionFactorExpression.cs: Allow metadata refs in conditions.
* ItemReference.cs: Allow metadata in transforms.
* TaskEngine.cs: Allow metadata refs.
* MetadataReference.cs (.ctor): Add a 'original string' param.
svn path=/branches/mono-2-4/mcs/; revision=141066
* Uri.cs (ParseNoExceptions): Don't look for '@' in absolute unix paths.
2009-09-01 Andres Aragoneses <[email protected]>
* UriTest.cs: New tests from #533572.
(backported from trunk r141020)
svn path=/branches/mono-2-4/mcs/; revision=141052
* CustomizableFileSettingsProvider.cs: reset the property value
instead of using the DefaultValue.
* SettingsPropertyValue.cs: new Reset() method.
* ApplicationSettingsBase.cs: Reset happens in Reload().
Patch by Andrew Kurochka that fixes bug #532180.
svn path=/branches/mono-2-4/mcs/; revision=140951
* WebConnection.cs: HEAD response does not have a body even if the
response is an error. Fixes buf #535102.
svn path=/branches/mono-2-4/mcs/; revision=140924
* method-to-ir.c (mono_method_to_ir): When calling a gshared method,
call a generic class init trampoline if needed. Fixes#519336.
* generics.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=140919
In class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks:
* CopyTest.cs (TestCopy_EmptySources): New.
(TestCopy_EmptyDestFolder): New.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
* AssignCulture.cs, AssignTargetPath.cs,
CallTarget.cs, CombinePath.cs, Copy.cs,
CreateItem.cs, CreateManifestResourceName.cs,
Delete.cs, Error.cs, FindUnderPath.cs,
GenerateResource.cs, MSBuild.cs, MakeDir.cs,
Message.cs, RemoveDir.cs, RemoveDuplicates.cs,
ResolveAssemblyReference.cs, Touch.cs,
WriteLinesToFiles.cs: Add null checks and array
length checks.
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
* BuildItemTest.cs (TestSetMetadata5a): New.
* ProjectTest.cs: Add tests for different property types
with required attribute. Also, check the values - null or
empty array.
* TestTasks.cs: Add new tasks for above.
In class/Microsoft.Build.Engine/Test/various:
* Items.cs: Add tests for property/item evaluation.
In class/Microsoft.Build.Engine/Test/resources:
* TestTasks.cs: Add new tasks for different property types
with required attribute. Also, emit whether the value was
null or a zero length array.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
* Expression.cs (ExpressionOptions): New.
Introduce a ExpressionOptions argument to all ConvertTo*
methods. Implement the rule: in evaluation phase, expand
all items completely, but dont expand item refs in properties.
At other times, expand the item refs in the properties.
See comments in Expression.cs, for a full explanation.
* BuildItem.cs: Track api changes.
* BuildItemGroup.cs: Likewise.
* BuildProperty.cs: Track api changes. Handle self-references.
* BuildTask.cs: Track api changes.
* IReference.cs: Add ExpressionOptions param.
* ItemReference.cs: Track api changes.
* PropertyReference.cs: Likewise.
* MetadataReference.cs: Likewise.
* ExpressionCollection.cs: Track api changes. Add support for
converting all primitive types and DateTime, instead of a fixed
few.
* Project.cs (GetMetadataBatched): Use the evaluated metadata.
* TaskBatchingImpl.cs: Handle the case when batching is required,
but no items are available.
* TaskEngine.cs: Throw on unsupported types. Correctly handle
properties in case of empty values.
svn path=/branches/mono-2-4/mcs/; revision=140914
In tools/xbuild:
* xbuild/Microsoft.Common.targets: Remove dummy
@(_TargetPathItem), since we support item refs with transforms
as a property value.
2009-08-26 Ankit Jain <[email protected]>
In class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks:
* CreateItemTest.cs (TestVariableExpansion): Update test to
use a transform with a item reference in a property.
2009-08-26 Ankit Jain <[email protected]>
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
* Expression.cs: Correctly handle a item reference with transform
when allowItems is false. If item ref is ignored, then the transform
will get incorrectly matched as a metadata ref.
* ItemReference.cs (.ctor): Add a @original_string param.
2009-08-26 Ankit Jain <[email protected]>
* Utilities.cs (UnescapeFromXml): New. From md.
* BuildProperty.cs (.ctor): Unescape xml codes from the InnerXml
of the property element.
2009-08-26 Ankit Jain <[email protected]>
svn path=/branches/mono-2-4/mcs/; revision=140705
* statement.cs: avoid nullref when the return value of GetEnumerator()
does not contain any MoveNext() method.
svn path=/branches/mono-2-4/mcs/; revision=140629
* Fixes **522465 - based on the work by [email protected]
* Tds70.cs (FormatParameter): For double, use "round-trip" format
specifier in order to be sure of a successful conversion.
svn path=/branches/mono-2-4/mcs/; revision=140609
* DataViewManager.cs (CollectionToListChangeEventArgs) : Use IsAssignableFrom
instead of type comparison.
svn path=/branches/mono-2-4/mcs/; revision=140598
** Fixes#521951
* DataViewManager.cs (CollectionToListChangeEventArgs) : Use a corresponding
DataTable/DataRelation obj instead of only DataRelation.
svn path=/branches/mono-2-4/mcs/; revision=140595
In tools/xbuild:
2009-08-21 Ankit Jain <[email protected]>
Fix bug #531926
* xbuild/Microsoft.Common.targets: Add $(ConfigurationName)
and $(PlatformName) default values.
Move CoreCompile to a Compile target with corresponding
Before/After hooks and *DependsOn.
Add Pre/PostBuildEvents handling.
2009-08-20 Ankit Jain <[email protected]>
Fix bug #532264.
* Main.cs: Dont generate .sln.proj, project.Load can handle
.sln directly now. Show stack trace for exceptions if logger
verbosity is > normal
* SolutionParser.cs (ParseSolution): Add a param for a raise
warning delegate. Use Dictionary.TryGetValue, key might not
be present.
2009-08-20 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets (ResolveReferences*): Add
a *DependsOn property and Before/After hooks. Change output
of ResolvedFiles to @(ReferencePath).
* xbuild/Microsoft.CSharp.targets (Csc): Use @(ReferencePath)
for references.
2009-08-19 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets (ResolveAssemblyReference):
Make SearchPaths get value from a property (AssemblySearchPaths)
to allow it to be overridden.
2009-08-18 Ankit Jain <[email protected]>
* SolutionParser.cs (ParseSolution): Project reference in a project
file, but not found in .sln file is ignored. Also, add dependencies
specified in the .sln file.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
2009-08-18 Ankit Jain <[email protected]>
* TaskLoggingHelperExtensios.cs (.ctor): Mark internal.
2009-08-18 Ankit Jain <[email protected]>
* PcFileCache.cs (PackageInfo): Mark internal.
2009-08-18 Ankit Jain <[email protected]>
* AssemblyResolver.cs (FindInTargetFramework): Perform case insensitive
assembly name comparison. Use the new AssemblyNamesCompatible api.
(AssemblyNamesCompatible): Add new overload with a 'ignoreCase' param.
2009-08-17 Ankit Jain <[email protected]>
* AssemblyResolver.cs (TargetFrameworkAssemblies..ctor): Make assembly
name lookups for target framework assemblies, case insensitive. Helps
with cases like "System.configuration", which vs.net is known to emit.
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
2009-08-18 Ankit Jain <[email protected]>
* ProjectTest.cs (TestCaseSensitivityOfProjectElements): New.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-08-21 Ankit Jain <[email protected]>
* Engine.cs (EndProjectBuild): Use the @succeeded argument
instead of hardcoding 'true'.
* Target.cs (Build): Add an overload to return executeOnErrors
value for the target executed. If building dependencies fails,
and executeOnErrors is true, then execute OnError tasks.
Add the new param to ..
(BuildDependencies): this, ..
(DoBuild): and this.
(GetDependencies): Improve error message and variable name.
(ExecuteOnErrors): Honor OnError tag's Condition also.
* TaskBatchingImpl.cs (Run): Correctly set executeOnErrors param.
2009-08-20 Ankit Jain <[email protected]>
Fix bug #532264
* Project.cs (Load): Add support for loading .sln files.
2009-08-20 Ankit Jain <[email protected]>
* BuildTask.cs (Execute): Use task_logger only after the task
has been initialized. Catch and report task loading errors.
* Target.cs (DoBuild): Dont rethrow the exception, and emit
the stacktrace as a low importance message.
2009-08-18 Ankit Jain <[email protected]>
* BatchingImplBase.cs: Make the item name lookups and metadata be case
insensitive.
* TaskDatabase.cs: Likewise.
* TaskEngine.cs: Make property name looks, case insensitive.
In class/Microsoft.Build.Engine:
2009-08-20 Ankit Jain <[email protected]>
* Microsoft.Build.Engine.dll.sources: Add tools/xbuild/SolutionParser.cs
svn path=/branches/mono-2-4/mcs/; revision=140370
2009-08-20 Sebastien Pouliot <[email protected]>
* SmtpClient.cs: Honor ServicePointManager.
ServerCertificateValidationCallback when provided
[Backport r140347]
In System.Net.Security:
2009-08-20 Sebastien Pouliot <[email protected]>
* SslStream.cs : Always use/provide a X509Chain even if this
duplicates some of the old/existing logic of Mono.Security.
This makes it possible to provide a callback using
ServicePointManager.ServerCertificateValidationCallback
[Backport r140359]
svn path=/branches/mono-2-4/mcs/; revision=140363
* TlsServerCertificate.cs: If no usage information is available then
assume it's ok for SSL since we'll (later) check that the CN contains
a host name (that match the server) and such a certificate wouldn't
be much useful for anything but SSL/TLS. Fix the new stmp.gmail.com
certificate usage failure.
[Backport r140358]
svn path=/branches/mono-2-4/mcs/; revision=140360
* generic-sharing.c: Replace the templates lock with the loader
lock because of very hard to resolve deadlock issues.
Backport of r139118.
svn path=/branches/mono-2-4/mono/; revision=140272
In tools/xbuild:
Fix bug #530368.
* SolutionParser.cs (AddProjectTargets): If a project name matches one
of the targets that we emit (Build/Clean etc), then rename to
"Solution:<project name>".
2009-08-14 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets (AllowUnsafeBlocks): Don't set any
default value.
(OutputPath): Set a default value.
(DeployOutputFiles): Copy only if something available to copy.
2009-08-14 Ankit Jain <[email protected]>
* SolutionParser.cs (ProjectInfo.Dependencies): Change to a dictionary
to keep track of corresponding ProjectInfo objects.
(ParseSolution): Refactor to populate the ProjectInfo.Dependencies
dictionary. Use AddBuildLevels to emit build levels to allow
parallel builds.
(AddProjectTargets): Dependency's projectInfo is directly available now.
(AddBuildLevels): New. Emit items named BuildLevelN, where each level
has projects that can be built in parallel. Lower levels represent
dependencies for higher levels.
(AddSolutionTargets): Instead of using CallTarget, directly use MSBuild
task with the new BuildLevelN stuff. Also tell the user about disabled
projects or missing project configs.
(TopologicalSort): New.
(Insert): New. Based on code from monodevelop.
In tools/xbuild/tests:
* standalone/Project01: Update .sln.proj file.
svn path=/branches/mono-2-4/mcs/; revision=139956
In tools/xbuild:
2009-08-14 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets (ResolveAssemblyReference): Add
'{PkgConfig}' to SearchPaths.
2009-07-31 Ankit Jain <[email protected]>
* ErrorUtilities.cs (ShowUsage): Implement.
2009-07-30 Ankit Jain <[email protected]>
Fix bug #484771.
* xbuild/Microsoft.Common.targets (ResolveAssemblyReference): Add support
for $(OutDir).
2009-07-30 Ankit Jain <[email protected]>
* ErrorUtilities.cs: Set version to Consts.MonoVersion .
2009-07-30 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets (ResolveAssemblyReference): Output
ResolvedFiles to @(ReferencePath), required for IDE integration.
2009-07-30 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: Implement 'Clean' target. Currently
just handles clean for a full build.
2009-07-28 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: Add missing 'SkipUnchangedFiles=true'
for the Copy tasks.
(CopyDeployFiles*): Fix typos, Add inputs/outputs for the
PreserveNewest case and remove for copy always case.
2009-07-23 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: Oops, forgot to remove some
debug stuff.
2009-07-23 Ankit Jain <[email protected]>
* Makefile: Create a lib/mono/xbuild directory for xbuild
extensions.
2009-07-23 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets (AssignProjectConfigurations): New.
(ResolveProjectReferences): Add dependency on AssignProjectConfigurations
target. Also, set the config and platform properties for the msbuild task
being invoked.
* xbuild/Microsoft.Common.tasks: Add AssignProjectConfiguration .
2009-07-22 Ankit Jain <[email protected]>
* xbuild/Microsoft.VisualBasic.targets (Vbc.References): Remove
"@(ChildProjectReferences)" as it gets resolved earlier
and is part of @(ResolvedFiles).
2009-07-22 Ankit Jain <[email protected]>
* xbuild.Microsoft.CSharp.targets (Csc.References): Remove
"@(ChildProjectReferences)" as it gets resolved earlier
and is part of @(ResolvedFiles).
In tools/xbuild/tests:
2009-07-30 Ankit Jain <[email protected]>
* standalone/Project01/final-outputs.txt: Update to include obj/
dir also, and sort the list.
2009-07-23 Ankit Jain <[email protected]>
* standalone/Project01: Change config mappings a bit to mix them up,
like Debug->Release etc. Update .proj file and final-outputs.txt.
2009-07-22 Ankit Jain <[email protected]>
* standalone/Project01: Add references to two "external" assemblies
with dependencies.
* standalone/Project01/Program.cs: Add references in code to the new
assemblies, to ensure that they are required for compilation.
In class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks:
2009-07-23 Ankit Jain <[email protected]>
* AssignProjectConfigurationTest.cs: New.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
2009-08-14 Ankit Jain <[email protected]>
* PcFileCache.cs: New. From monodevelop.
* AssemblyResolver.cs (ResolvePkgConfigReference): New. Use PcFileCache
to resolve assembly references.
(AssemblyNamesCompatible): If SpecificVersion is false, then compare
only simple names.
(GetResolvedReference): Rename default_value to default_copy_local_value.
(Cache): New.
(PcFileCacheContext): New.
(SearchPath): Add 'PkgConfig' to the enum.
* ResolveAssemblyReference.cs: Add support for '{PkgConfig}'. Update
messages.
* ResolvedReference.cs (FoundInSearchPathToString): Create from ..
(FoundInSearchPathAsString): .. this. Change this to a property to
allow custom "found in .. " messages.
2009-07-31 Ankit Jain <[email protected]>
* MSBuild.cs (Execute): Log error if the file doesn't exist.
2009-07-30 Ankit Jain <[email protected]>
* ResolvedReference.cs (.ctor): Set 'OriginalItemSpec' and 'ResolvedFrom',
required for IDE integration.
* AssemblyResolver.cs (GetResolvedReference): All the original metadata
should be retained. Track api changes.
2009-07-30 Ankit Jain <[email protected]>
* ReadLinesFromFile.cs (Execute): Log a warning instead of an error
if unable to read from the file. Fix a null check. Always return
true.
2009-07-30 Ankit Jain <[email protected]>
* Delete.cs (Execute): Log a message when deleting a file.
2009-07-28 Ankit Jain <[email protected]>
* Exec.cs (AddCommandLineCommands): First word from @command is treated
as exec name, and rest as arguments. Extract arguments here.
(ExecuteTool): Don't ignore params.
(GenerateFullPathToTool): Extract first word as tool name.
(HandleTaskExecutionErrors): Honor IgnoreExitCode property.
(LogEventsFromTextOutput): Log as messages.
* ManagedCompiler.cs (HandleTaskExecutionErrors): Implement.
2009-07-23 Ankit Jain <[email protected]>
* AssignProjectConfiguration.cs (Execute): Implement.
2009-07-22 Ankit Jain <[email protected]>
Fix bug #517974.
* ResolvedReference.cs (AssemblyName): New.
(IsPrimary): New. Primary (eg. specified in the project file) or
dependent reference.
(FoundInSearchPathAsString): New.
* AssemblyResolver.cs (GetResolvedReference): Add a 'assembly name'
param for the new field in ResolvedReference.
(AssemblyNamesCompatible): Fix the check for public key token.
Track api changes.
* ResolveAssemblyReference.cs: Keep track of resolved assemblies,
prevent duplicate references and other files.
Process dependencies after resolving all the primary references.
Search for dependencies in parent assembly's dir first and then
the specified search paths.
Detect assembly version conflicts and try to resolve.
Improve logged messages.
(PrimaryReference): New.
(ResolveAssemblyReferenceHelper.AddUniqueFile): New extension method.
2009-07-16 Ankit Jain <[email protected]>
Fix bug #519922.
* AssemblyResolver.cs (FindInDirectory): Try the @reference as a
filename as it is, or with different @file_extensions.
If @reference is a assembly name, then look for *.@file_extensions
for target assembly.
(GetAssemblyNameFromFile): Log FileNotFoundException and BadImageFormatException
separately, instead of a single unclear message.
Change all uses of Assembly.GetAssemblyName with GetAssemblyNameFromFile
which does the required error checking and logging.
In class/Microsoft.Build.Tasks:
2009-08-14 Ankit Jain <[email protected]>
* Microsoft.Build.Tasks_test.dll.sources: Added
PcFileCache.cs from md.
2009-07-23 Ankit Jain <[email protected]>
* Microsoft.Build.Tasks_test.dll.sources: Added
AssignProjectConfigurationTest.cs .
2009-07-22 Ankit Jain <[email protected]>
* Makefile: Add System.Core .
* Microsoft.Build.Tasks.dll.sources: Added
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
2009-07-30 Ankit Jain <[email protected]>
* EngineTest.cs (TestNewProject): Disable. Invalid for
v3.5 profile.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-08-09 Miguel de Icaza <[email protected]>
* ConsoleLogger.cs: Change the format of the error and warnings
strings to work when invoked inside Emacs by not rendering the
column if available, by using lowercase "error"/"warning" strings
instead of camelcased versions and to not have unnecessary padding.
2009-07-31 Ankit Jain <[email protected]>
* ConsoleLogger.cs: Keep track of all the errors and warnings
and show them at the end.
2009-07-31 Ankit Jain <[email protected]>
* Target.cs (Build): Log a message if a target is skipped.
(LogMessage): New.
* BuildTask.cs (Execute): Log error if task execution fails.
2009-07-30 Ankit Jain <[email protected]>
* Engine.cs (.ctor): Set default BinPath. Currently this assumes
v2.0, this will change when multi-targeting lands.
2009-07-30 Ankit Jain <[email protected]>
* Project.cs (InitializeProperties) Set 'MSBuildProjectFile' and
'MSBuildProjectName' properties.
2009-07-28 Ankit Jain <[email protected]>
* TaskEngine.cs (Prepare): Fix formatting mistake.
* ConsoleLogger.cs: Emit "-- FAILED" also when project/target building
fails. Also, emit result of project at Normal verbosity level.
2009-07-23 Ankit Jain <[email protected]>
Fix bug #511370.
* Project.cs (ExtensionsPath): New.
(InitializeProperties): Set "MSBuildExtensionsPath" property.
In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
2009-07-28 Ankit Jain <[email protected]>
* ToolTask (.ctor): Initialize Timeout value.
(Execute): Use HandleTaskExecutionErrors to determine task result. Set
exitCode to the result of ExecuteTool and let HandleTaskExecutionErrors
determine final result of the task.
(RealExecute): Rename to ..
(ExecuteTool): .. this. @responseFileCommands could be empty.
Use specified timeout value for the executing tool.
Rename 'compilerOutput' to 'toolOutput'. Cleanup resources in the
finally block. Move processing of stdout/stderr output to ..
(ProcessOutputFile): .. here and ..
(LogEventsFromTextOutput): .. here.
(HandleTaskExecutionErrors): Implement.
(DeleteTempFile): Implement.
svn path=/branches/mono-2-4/mcs/; revision=139900
* HttpWebRequest.cs:
* WebConnectionStream.cs: if there's an error writing the headers from
a buffered request, propagate the error instead of hiding it and
causing a different one later (ie, ObjectDisposedException instead of
the original WebException). This happened when posting without
Content-Length set to an HTTPS url without validating the server
certificate.
svn path=/branches/mono-2-4/mcs/; revision=139884
Backport of r139815.
* class.c: Add mono_class_get_field_from_name_full which does
the same as mono_class_get_field_from_name but does check field
signature as well.
* class-internals.h: Export mono_class_get_field_from_name_full as
part of the internal API.
* loader.c (field_from_memberref): Search fields by name and signature
as it's valid to have two fields with same name but different types.
Fixes#528055.
svn path=/branches/mono-2-4/mono/; revision=139817
* threads.c: Store the thread start argument in a hash table instead of
registering it as a root, as libgc doesn't support unregistering roots
under windows, leading to 'too many root sets' errors when many threads
are created.
svn path=/branches/mono-2-4/mono/; revision=139249
* BuildManager.cs: precompilation setup failed if the precompiled
virtual directory was / and it was deployed somewhere else.
svn path=/branches/mono-2-4/mcs/; revision=139094
* icall.c (ves_icall_System_Reflection_FieldInfo_internal_from_handle_type): Fix the second argument, its a MonoType* not a MonoClass*.
svn path=/branches/mono-2-4/mono/; revision=139056
* WebClient.cs: rethrow WebExceptions instead of creating a new one
with less information on the actual error.
Fixes bug #526069.
svn path=/branches/mono-2-4/mcs/; revision=138856
* DbCommandBuilder.cs (CreateDeleteCommand, CreateUpdateCommand): Add the
nullcheck-param into the respective command's parameter list. Fixes
build breaks. Individual provider's CommandBuilder classes from 2.0
profile onwards use the base version of methods to maintain these commands.
(Get*Command): Cleanup code duplication
* DbDataAdapter (Update): Use SourceColumnNullMapping property to handle
nullcheckparams. Fixes#522624. Patch by
Gert Driesen <[email protected]>.
svn path=/branches/mono-2-4/mcs/; revision=138679
* BuildManager.cs: precompilation setup failed if the precompiled
virtual directory was / and it was deployed somewhere else.
svn path=/branches/mono-2-4/mcs/; revision=138577
* WebConfigurationManager.cs: avoid possible infinite loop when the
path starts with ~ and 1 file check.
svn path=/branches/mono-2-4/mcs/; revision=138494
* WebConnectionStream.cs: when sending a 0-length POST, ignore further
writes instead of throwing.
Fixes bug #524049.
svn path=/branches/mono-2-4/mcs/; revision=138448
* zlib-helper.c: don't try to finish the z_stream if it has not been
used. This fixes all the tests after the latest change.
svn path=/branches/mono-2-4/mono/; revision=138273
* Aes.cs: Use the fully qualified name since this is not a type known
in the default corlib (2.0 or 1.x).
[Fix bug #523687]
[Backport r138249]
svn path=/branches/mono-2-4/mcs/; revision=138250
* ConfigurationElement.cs: don't skip xml nodes when reading 2
ConfigurationElement in a row. Patch by Greg Smolyn that fixes bug
#521231.
svn path=/branches/mono-2-4/mcs/; revision=138143
* mono-proclib.c: fix reading processor usage for a process. Patch
from Jacob Gladish that fixes bug #523052.
svn path=/branches/mono-2-4/mono/; revision=138139
* System.Web.Mvc/DefaultModelBinder.cs: applied workaround for gmcs
bug which is fixed in trunk but not in the 2.4 branch(es)
svn path=/branches/mono-2-4/mcs/; revision=138087
* gdipFunctions.cs: Fix XVisualIDFromVisual to return an IntPtr
since 64 bits X servers will return a 64 bits value.
* gdipStructs.cs: Fix XVisualInfo to use IntPtr on fields that
are 64 bits on 64 bits X servers.
* Graphics.cs: Adjust CopyFromScreenX11 to work with IntPtr so the
screenshot code can work on both 32 and 64 bits X servers.
[Fix bug #521718]
[Backport r137982]
svn path=/branches/mono-2-4/mcs/; revision=137983
* SortedList.cs: the IComparar.Compare arguments were reversed.
Fixes bug #521750. Patch by Kevin Fitzgerald.
svn path=/branches/mono-2-4/mcs/; revision=137915
* ApplicationShutdownReason.cs: add new 3.5 value.
* ParserErrorCollection.cs: add setter for ParserError.
Patch from Daniel Gagne.
svn path=/branches/mono-2-4/mcs/; revision=137912
* Changelog: Rename this to ChangeLog.
* Mono.Simd/Mono.Simd/ArrayExtensions.cs: Don't ignore the 'offset'
parameter in the GetVector () methods. Fixes#521692.
svn path=/branches/mono-2-4/mcs/; revision=137826
* x86/x86-codegen.h: Applied patch from Marian Salaj <[email protected]>.
Fix encoding of PMINSW and PMINSD. Fixes#521662.
svn path=/branches/mono-2-4/mono/; revision=137823
* ProcessStartInfo.cs: HaveEnvVars is enabled by just using the
EnvironmentVariables property. Bug #520650 fixed.
svn path=/branches/mono-2-4/mcs/; revision=137731
* WebClient.cs: implement GetWebRequest and GetWebResponse. Use them
instead of SetupRequest and ProcessResponse.
svn path=/branches/mono-2-4/mcs/; revision=137674
* HttpWebRequestTest.cs: use different ports for different tests since
the shutdown might take a little bit and tests might conflict.
svn path=/branches/mono-2-4/mcs/; revision=137668
backport of 137653.
* HashSet.cs (ICollection<T>.Add): fix for bug #520760. Do not throw
when adding duplicates.
svn path=/branches/mono-2-4/mcs/; revision=137654
* method-to-ir.c: When doing a call which might be remote from
shared generic code to other shared code with open type arguments,
abort generic code sharing for that method.
2009-07-09 Mark Probst <[email protected]>
Backport of r137640.
* generic-xdomain.2.cs: Test case for generic marshal-by-ref
objects.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=137649
* WebConfigurationManager.cs: when caching configuration and sections,
use the configuration file directory instead of the incoming request
path.
svn path=/branches/mono-2-4/mcs/; revision=137633
* AssemblyResourceLoader.cs: MS sets cacheability to public. Add
Last-Modified header and return 304 if validating max-age=0 or
If-Modified-Since succeeds.
svn path=/branches/mono-2-4/mcs/; revision=137577
* WebClient.cs: set the content length when uploading values. This
allows reusing the connection.
* WebConnectionStream.cs: SetHeaders() takes ownership of the buffer
and does not need to copy it any more. WriteRequest() wasn't always
setting 'requestWritten' to true.
* HttpWebRequest.cs: change in SetHeaders call.
2009-07-06 Gert Driesen <[email protected]>
* WebConnectionStream.cs: Move and improve argument checks to match MS.
Modified CanRead and CanWrite to return false when instance is disposed.
svn path=/branches/mono-2-4/mcs/; revision=137498
* WebConnection.cs: provide better error message when there's an error
writing.
* WebConnectionStream.cs: don't nullify the buffer until
CheckFinalStatus() decides that there are no more authentication
retries or redirects.
svn path=/branches/mono-2-4/mcs/; revision=137333
* HttpsClientStream.cs: if there's only an ICertificatePolicy and no
ServerCertificateValicationCallback, don't fail.
svn path=/branches/mono-2-4/mcs/; revision=137330
* X509Certificate2.cs:
* X509Chain.cs: changes to make everything compile with latest changes
and fixed typo in IsChainComplete().
svn path=/branches/mono-2-4/mcs/; revision=137260
* HttpsClientStream.cs: invoke the ServerCertificateValidationCallback
in the 2.0 profile. If there's a CertificatePolicy, it is run before
the 2.0 callback.
svn path=/branches/mono-2-4/mcs/; revision=137256
* ServicePointManager.cs: implement ServerCertificateValidationCallback.
* DefaultCertificatePolicy.cs: if there's a SCVC registered, don't do
normal error checking.a
svn path=/branches/mono-2-4/mcs/; revision=137254
* HttpWebRequest.cs: avoid duplicating Accept-Encoding if GetHeaders()
is called twice.
* WebConnectionStream.cs: don't send a 0 content length for non-write
requests.
svn path=/branches/mono-2-4/mcs/; revision=137245
* ContentControlBuilderInternal.cs: detect missing
ContentPlaceHolderID attribute when parsing instead of throwing a
nullref later on.
svn path=/branches/mono-2-4/mcs/; revision=137118
* mini-exceptions.c (get_generic_context_from_stack_frame): Fix the case
when the generic instance is an instantiation of a subclass of the
methods class. Fixes#517166.
svn path=/branches/mono-2-4/mono/; revision=137083
* gc.c (mono_gc_run_finalize): Avoid finalizing dynamic methods during
shutdown, they can still be referenced by the other dying objects.
Fixes#514506.
svn path=/branches/mono-2-4/mono/; revision=137077
* WebConnectionStream.cs: when buffering the response, we have to set
the internal length and regenerate the headers.
svn path=/branches/mono-2-4/mcs/; revision=137042
* SocketResponder.cs: the listener might be closed right before
Accept() is called and in that case we get an EINVAL.
* WebClientTest.cs: copy WebClientTest from HEAD.
svn path=/branches/mono-2-4/mcs/; revision=137039
* HttpWebRequest.cs: don't send Content-Length header when SendChunked
is enabled.
* WebConnectionStream.cs: send the headers immediately when possible.
When writing the request before a Close(), if there was an exception
it was lost.
svn path=/branches/mono-2-4/mcs/; revision=137020
* HttpConnection.cs:
* HttpListenerResponse.cs: force closing the socket when the response
is aborted.
svn path=/branches/mono-2-4/mcs/; revision=137017
* DateTime.cs: if the DateTimeOffset is out of bounds, let Parse
report the error. Fix stupid harmless typo.
* DateTimeOffset.cs: report error if the UTC date/time is out of
bounds.
svn path=/branches/mono-2-4/mcs/; revision=136929
* WebAsyncResult.cs: new field that tells us if the request is being
written automatically because we reached the content length.
* WebConnection.cs:
* WebConnectionStream.cs: make sure we only access the NetworkStream
while we own it. Automatically write the request when we reach
ContentLength number of bytes. Kill the write buffer as soon as
possible. Don't use the buffer at all when chunked encoding is
enabled.
Fixes bugs #515931 and #510642.
svn path=/branches/mono-2-4/mcs/; revision=136901
* WebConnection.cs: 'socket' and 'Data' where being changed by 2
threads at the same time when there were queued requests and the
current one was aborted in Connect().
* HttpWebRequest.cs: 'aborted' is now an int and we use Interlocked to
access it. Added WebConnection field used when aborting the request.
Fixes bug #514591 for good.
svn path=/branches/mono-2-4/mcs/; revision=136754
enumeration contains multiple names with the same value.
Fixes#515030.
* Test/DocTest-v1.cs: Add test for #515030.
* Test/en.expected/Mono.DocTest/Color.xml,
Test/en.expected.since/Mono.DocTest/Color.xml,
Test/html.expected/Mono.DocTest/Color.html,
Test/msxdoc-expected.importslashdoc.xml,
Test/en.expected.importslashdoc/Mono.DocTest/Color.xml: Flush.
svn path=/branches/mono-2-4/mcs/; revision=136731
* mini-ops.h: Use TARGET_X86 and TARGET_AMD64 instead of __i386__ and
__x86_64__ to fix cross-compilation. Fixes#515050.
svn path=/branches/mono-2-4/mono/; revision=136582
* WebConnectionStream.cs: close the underlying socket if there's an
exception when closing the stream. Fixes bug #514996.
svn path=/branches/mono-2-4/mcs/; revision=136573
* WebConnectionStream.cs: Keep count of all bytes written, and perform
write overflow check in both buffered and non-buffered writing (if
not using chunked transfer encoding). Fixes bug #510642.
svn path=/branches/mono-2-4/mcs/; revision=136571
* WebConnection.cs: make sure we don't open a new socket if the
request is aborted before we establish the connection. Fixes bug
#514591.
* HttpWebRequest.cs: new property to return abort status. Invoke the
abort handler before doing anything else when Abort() is called for
the first time.
svn path=/branches/mono-2-4/mcs/; revision=136517
* DateTimeTest.cs: add test for parsing a negative timezone.
* DateTimeOffsetTest.cs: several tests for Parse.
svn path=/branches/mono-2-4/mcs/; revision=136429
* AppDomainSetup.cs: update attribute.
* TermInfoDriver.cs: ensure we are initialized in CheckWindowDimensions().
* DateTimeOffset.cs: Implement Parse().
* DateTime.cs: add 'zzz' to the list of default time formats. Return a
DateTimeOffset from _DoParse. Fixed the offset minutes when the
timezone is specified as a negative one.
* Console.cs: updates for MoveBufferArea().
* AppDomainManager.cs: implement EntryAssembly.
* AppDomain.cs: update attribute.
svn path=/branches/mono-2-4/mcs/; revision=136427
* EndPointListener.cs: call CheckIfRemove() after removing a regular
prefix. Fixes bug #513849.
* EndPointManager.cs: make sure we use the right lock when one prefix
of a collection fails to be added and we need to remove all of the
prefixes.
Clear the ip_to_endpoints hashtable if there are no more prefixes
listening on that address.
svn path=/branches/mono-2-4/mcs/; revision=136321
* branch-opts.c (mono_merge_basic_blocks): Fix the case when bbn
falls through to its next bblock. Fixes#513931.
* iltests.il: Add a test.
svn path=/branches/mono-2-4/mono/; revision=136304
2009-06-15 Rodrigo Kumpera <[email protected]>
Backport of r136134.
* class.c (mono_class_from_typeref): If the enclosing type is not
found return null instead of crashing. Fixes#508487.
In tests:
2009-06-15 Rodrigo Kumpera <[email protected]>
Backport of r136135.
* load-exceptions.cs: Add regression test for #508487.
* t-missing.cs: Add nested type.
svn path=/branches/mono-2-4/mono/; revision=136145
* HttpWebRequest.cs: for unknown methods, always send the request once
we are connected even if there's no writeStream. Fixes bug #513087.
svn path=/branches/mono-2-4/mcs/; revision=136137
In tools/xbuild:
* xbuild/Microsoft.Common.targets (ProjectDir): Fix typo.
* xbuild/Microsoft.Common.targets (IntermediateAssembly): Change to
an Item list to match msbuild.
* xbuild/Microsoft.CSharp.targets (IntermediateAssembly): Update for
above changes.
In class/Microsoft.Build.Engine/Test/various:
* Items.cs (TestItemsInTarget3a): Add another case for valid whitespace
around an item ref.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
Fix bug #512535.
* ExpressionCollection.cs (ConvertToITaskItemArray): Whitespace around a
itemref is allowed if the prev/next element is ";".
svn path=/branches/mono-2-4/mcs/; revision=136004
* ContentControlBuilderInternal.cs: detect missing
ContentPlaceHolderID attribute when parsing instead of throwing a
nullref later on.
svn path=/branches/mono-2-4/mcs/; revision=135961
* XPathExpression.cs: Backport to Mono 2.4 the bug fix
for multithreaded applications that use XPath.
This was the fix for #477049 which also fixes#505678
svn path=/branches/mono-2-4/mcs/; revision=135813
* HttpWebRequest.cs: ProtocolViolationException is not thrown in
certain cases since 2.0. Fixes bug #508027.
svn path=/branches/mono-2-4/mcs/; revision=135768
* HttpWebRequest.cs: follow MS docs when throwing
ProtocolViolationException at the beginning of an asynchronous
operation. Fixes bug #465613.
svn path=/branches/mono-2-4/mcs/; revision=135759
* FtpWebRequest.cs: avoid exception when the reply from the server
contains just response code. Fixes bug #510852.
svn path=/branches/mono-2-4/mcs/; revision=135696
Backport of 135171.
* threads.c (ves_icall_System_Threading_Thread_Sleep_internal):
Check if the thread was interrupted and proccess it straight away.
Makes abortion much more responsive.
Backport of 135170.
* threads.c (mono_thread_execute_interruption): Use atomic cas with
MonoThread::interruption_requested to match it's counterpart.
Fixes a hang in abort-stress-1 on a 2 core x86.
svn path=/branches/mono-2-4/mono/; revision=135666
2009-06-08 Martin Baulig <[email protected]>
* debug-mini.c
(MonoDebuggerExceptionAction): Moved into debug-mini.h.
(_mono_debugger_throw_exception): Don't make this static.
(_mono_debugger_unhandled_exception): Likewise.
(mono_debugger_handle_exception): Moved to mini-exceptions.c
* debug-mini.c
(MonoDebuggerExceptionAction): Moved here from debug-mini.c.
(_mono_debugger_throw_exception): Add function prototype.
(_mono_debugger_unhandled_exception): Likewise.
* mini-exceptions.c
(mono_handle_exception_internal): Added `MonoJitInfo **out_ji'
arg; return the first exception handler if the exception is caught
and we're running inside the debugger.
(mono_debugger_handle_exception): Moved here from debug-mini.c;
improve exception handle inside runtime-invoke, check whether the
exception is actually caught in the method being invoked and not
by the runtime-invoke-wrapper.
svn path=/branches/mono-2-4/mono/; revision=135636
2009-03-31 Rodrigo Kumpera <[email protected]>
* Code.cs (CILLabel): Add new constructor to signal that
a label is an absolute il offset. This is required by exception
handling declarations that use offsets and not labels.
In ilasm/codegen:
2009-05-27 Rodrigo Kumpera <[email protected]>
* TypeDef.cs: Add field method_list to preserve definition
order of methods when emiting the PE file.
2009-04-20 Ankit Jain <[email protected]>
Fix bug #494221
* MethodDef.cs (BeginLocalsScope): New.
(EndLocalsScope): New.
(AddLocals):
(GetNamedLocal): Support scoping for .locals
* MethodDef.cs (GetNamedLocalSlot): Return -1 if local var not found.
2009-03-31 Rodrigo Kumpera <[email protected]>
* MethodDef.cs (WriteCode): Emit labels which use offsets as absolute PEAPI
CilLabels.
In ilasm/scanner:
* StringHelper.cs (startIdChars): New. Set of chars that can start an
identifier.
(Start): Use startIdChars instead of idchars.
Fix bug #487155.
* StringHelper.cs: Handle octal values in strings.
Patch from Stephen Gennard ([email protected])
In ilasm/parser:
Fix bug #494221.
* ILParser.jay (scope_block_begin): Mark begin .locals scope.
(scope_block): Mark end .locals scope.
* ILParser.jay (instr): Handle unidentified local var id.
2009-03-31 Rodrigo Kumpera <[email protected]>
* ILParser.jay: Fix integer labels in handler blocks.
svn path=/branches/mono-2-4/mcs/; revision=135623
In tools/xbuild:
* xbuild/Microsoft.Common.targets: Use ResolveAssemblyReference
to find satellite assemblies, dependent assemblies, dependent
files, copy local files etc.
Add targets to fetch all this info for all referenced projects,
and copy them to the target locations. Also, copy the debug (.mdb)
files. Honor, "CopyToOutputDirectory" metadata.
* Parameters.cs (ProcessProperty): Handle invalid syntax.
* SolutionParser.cs (AddGeneralSettings): Don't hardcode the default
config/platform. Move to ..
(AddDefaultSolutionConfiguration): .. here.
(AddCurrentSolutionConfigurationContents): Use the first solution target
as the default config/platform or use Debug/anycpu if no config is available.
In tools/xbuild/tests:
* standalone/Project01: New. Solution with interdependent multiple projects,
with deploy files, satellite assemblies etc.
In class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks:
* CreateCSharpManifestResourceNameTest.cs (TestInvalidCulture): New.
* CscTest.cs (TestDefineConstants): Update DefineConstants to include
spaces also.
* AssignTargetPathTest.cs: Update tests to not depend on a fixed
root (C:\) or cur dir.
In class/Microsoft.Build.Tasks:
* Microsoft.Build.Tasks_test.dll.sources: Added
ResolvedReference.cs
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
* AssignCulture.cs (TrySplitResourceName): Reset culture arg to null
if returning false.
* CreateCSharpManifestResourceName.cs: Set culture to null if the
culture was invalid.
* ResolvedReference.cs: New.
* AssemblyResolver.cs (GetResolvedReference): New. Honor's the
'Private' metadata and sets CopyLocal.
(SearchPath): New. Used to track how the reference was resolved.
(IsStrongNamed): Fix potential null ref.
All the assembly resolution methods now return ResolvedReference
instead of strings, to aid in proper CopyLocal behavior and
dependency resolution.
* ResolveAssemblyReference.cs: Add support for finding related files,
satellite files, resolving dependencies, copy local files.
Resolve files specified in "AssemblyFiles" param also, used to resolve
project references and dependencies.
* Csc.cs (AddResponseFileCommands): Split DefineConstants on space also.
* AssignTargetPath.cs (Execute): Expand incoming path to absolute
path, and correctly extract relative path (skipping over the preceding
dir separator).
* Copy.cs (CopyFile): Don't copy if the source and dest are the same.
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
* ProjectTest (TestBuildSolutionProject): New. Disabled for now.
* Consts.cs (RunningOnMono): Make public.
* TargetTest (TestTargetOutputsIncludingMetadata): New.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
* Target.cs (Outputs): Use ITaskItem[] for conversion, to retain
the metadata.
svn path=/branches/mono-2-4/mcs/; revision=135620
* marshal.c metadata.c: Applied patch from Ulrich Weigand
<[email protected]>: Free the wrappers of inflated generic methods when
the inflated method is freed. Fixes#508389.
The code is contributed under the MIT/X11 license.
svn path=/branches/mono-2-4/mono/; revision=135435
* OracleParameter.cs: Infer size only for 2.0 profile when only
value is passed. Fixes test failure under 1.1 profile.
svn path=/branches/mono-2-4/mcs/; revision=135429
In tools/xbuild:
2009-05-20 Jonathan Chambers <[email protected]>
* SolutionParser.cs (ParseSolution): Ignore vcproj projects in solutions
and issue warning.
2009-04-27 Ankit Jain <[email protected]>
* xbuild/Microsoft.VisualBasic.targets: Update to use
CreateVisualBasicManifestResourceName task, and fix compiler params.
2009-04-25 Daniel Nauck <[email protected]>
Fix bug #484649:
* LoggerInfo.cs: fixed the parsing of the /logger: argument as described in
http://msdn.microsoft.com/en-us/library/ms164311.aspx
Added logger class detection if it's not explicit specified in the argument.
2009-03-19 Ankit Jain <[email protected]>
Fix bug #484773.
* Main.cs (Execute): Check whether the project file exists or not.
* Parameters.cs (ParseArguments): Handle absolute paths too.
2009-03-13 Ankit Jain <[email protected]>
* Main.cs (Execute): Build the project/sln with current directory set to
the project file's dir.
* SolutionParser.cs (ParseSolution): Project paths are relative to
solution directory.
2009-03-06 Ankit Jain <[email protected]>
Fix bug #481336.
* SolutionParser.cs (AddWarningForMissingProjectConfiguration): New.
(AddProjectTargets): Emit warning for missing project configurations.
2009-02-26 Ankit Jain <[email protected]>
* xbuild/Microsoft.CSharp.targets (Csc): Fix "Resources" argument to use
ManifestNonResxWithCultureOnDisk instead of ManifestResourceWithNoCultureOnDisk.
2009-02-26 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: Make targets extensible. Add
before/after hooks.
2009-02-25 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets: Use obj/$(Config) as the default intermediate
output path, instead of just obj/
2009-02-25 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets (CopyNonResxEmbeddedResources): New.
(GenerateSatelliteAssemblies): Update to use the new ManifestNonResxWithCultureOnDisk
instead of NonResxWithCulture.
* xbuild/Microsoft.CSharp.targets (Csc): Fix "Resources" argument to use
the new on disk file names instead of original filenames.
2009-02-25 Ankit Jain <[email protected]>
* xbuild/Microsoft.Common.targets (GetTargetPath): Add a path separator.
2009-02-25 Ankit Jain <[email protected]>
* SolutionParser.cs (ParseSolution): Report warning instead of error
for unknown global sections.
2009-02-21 Ankit Jain <[email protected]>
* xbuild/xbuild.rsp: Add descriptive comments.
2009-02-21 Ankit Jain <[email protected]>
* Parameters.cs (LoadResponseFile): Handle comments.
2009-02-20 Ankit Jain <[email protected]>
* SolutionParser.cs (ParseSolution): Ignore solution folders.
2009-02-20 Ankit Jain <[email protected]>
* SolutionParser.cs (ParseSolution): Ignore GlobalSection named
'NestedProjects'.
2009-02-20 Ankit Jain <[email protected]>
* SolutionParser.cs (ParseProjectConfigurationPlatforms): Report missing
project guids as Warnings and not errors. Report every missing guid only
once.
2009-02-20 Ankit Jain <[email protected]>
* SolutionParser.cs (projectRegex): Use '\s' to match whitespace.
2009-02-19 Jonathan Chambers <[email protected]>
* xbuild.csproj: Add.
* xbuild.sln: Add.
2009-02-13 Jonathan Chambers <[email protected]>
* SolutionParser.cs: Make Guid Regex case insensitive.
Handle project dependencies. The solution has explicit
dependencies, but we have to open projects for implicit
dependencies (via ProjectReferences).
2009-02-13 Jonathan Chambers <[email protected]>
* Main.cs: Add support for .sln files.
* SolutionParser.cs: Class for generating project file
from solution file.
* xbuild.exe.sources: Added SolutionParser.cs.
2009-02-02 Ankit Jain <[email protected]>
* Microsoft.CSharp.targets: Add targets to generate resource ids.
* Microsoft.Common.targets: Add targets for generating resources,
generate and deploy satellite assemblies, resolve project and assembly
references. All intermediate build output goes into a 'obj/' dir by
default. 'Clean' target enabled.
In class/Microsoft.Build.Tasks/Test/Microsoft.Build.Tasks:
2009-05-29 Ankit Jain <[email protected]>
* TestMessageLogger.cs: Add counts for project/build start/finish
events.
2009-04-27 Ankit Jain <[email protected]>
* CreateVisualBasicManifestResourceNameTest.cs: New.
2009-03-03 Ankit Jain <[email protected]>
* CscTest.cs (DefineConstants): Add some extra semi-colons,
that should get removed on output.
(DefineConstants2): New. Test effectively empty define constants.
2009-02-25 Ankit Jain <[email protected]>
* CreateCSharpManifestResourceNameTest.cs (CheckResourceNames):
Refactor a bit to improve error reporting.
Update to use Path.Combine instead of hardcoding "\".
2009-02-24 Ankit Jain <[email protected]>
* TestMessageLogger.cs (CheckLoggedMessageHead): Move here from
* TaskBatchingTest.cs: .. here. Track api change.
2009-02-21 Ankit Jain <[email protected]>
* CopyTest.cs: New.
2009-01-31 Ankit Jain <[email protected]>
* TaskBatchingTest.cs (*): Add tests for target/task events.
(TestTargetBatching*): New tests for target batching.
* TestMessageLogger.cs: Add counts for target/task started/finished
events.
(NormalMessageCount): New.
In class/Microsoft.Build.Tasks/Test/resources:
2009-04-27 Ankit Jain <[email protected]>
* Sample.vb: New.
In class/Microsoft.Build.Tasks/Microsoft.Build.Tasks:
2009-04-27 Ankit Jain <[email protected]>
* CreateCSharpManifestResourceName.cs (GetResourceIdFromFileName): Move
to ..
* CreateManifestResourceName.cs: .. here.
* CreateVisualBasicManifestResourceName.cs: Implement.
2009-04-27 Ankit Jain <[email protected]>
* Vbc.cs (AddResponseFileCommands): Escape DefineConstants as it can
contain double quotes itself. Fix /doc switch.
(EscapeDoubleQuotes): New.
2009-03-22 Daniel Nauck <[email protected]>
* GenerateResource.cs: Set BasePath property of
ResXResourceReader class.
See: http://lists.ximian.com/pipermail/mono-devel-list/2009-March/031459.html
2009-03-19 Ankit Jain <[email protected]>
Fix bugs #323833 and #484384.
* AssemblyResolver.cs (GatherGacAssemblies): Handle duplicate entries.
These seem to be old copies of the assemblies with old keys. Pick
the one with the latest timestamp.
2009-03-03 Ankit Jain <[email protected]>
Fix bug #480856.
* Csc.cs (AddResponseFileCommands): Split DefineConstants on ';'.
2009-02-26 Ankit Jain <[email protected]>
* MakeDir.cs (Execute): Don't create+log if dir already exists.
2009-02-25 Ankit Jain <[email protected]>
* AL.cs (Execute): Use ToolTask.Execute instead of doing our own.
2009-02-25 Ankit Jain <[email protected]>
* AssemblyResolver.cs:
* ResolveAssemblyReference.cs: Honor SpecificVersion. Emit detailed error
messages incase assembly resolution fails. Make specific version
strict.
2009-02-25 Ankit Jain <[email protected]>
* ManagedCompiler.cs (AddResponseFileCommands): Use LogicalName for
embedded resources, wherever available.
* CreateCSharpManifestResourceName.cs (GetResourceIdFromFileName): Use
Path.Combine instead of hardcoding "\".
2009-02-25 Ankit Jain <[email protected]>
* MSBuild.cs (Execute): Reset current directory back after every
project's execution.
2009-02-21 Ankit Jain <[email protected]>
Fix bug #458916.
* Copy.cs: CopiedFiles and DestinationFiles should have target paths
instead of source. Also, the metadata should get retained from source
items. Based on a patch by Jeffrey Richardson <[email protected]>
Refactor a bit to remove code duplication.
2009-02-21 Ankit Jain <[email protected]>
* MSBuild.cs (SplitPropertiesToDictionary): Split into exactly 2 parts.
2009-02-11 Leszek Ciesielski <[email protected]>
* ResolveAssemblyReference.cs : AllowedRelatedFileExtensions stub
2009-02-02 Ankit Jain <[email protected]>
* MSBuild.cs (Execute): Disable incorrect 'rebaseOutputs' behavior.
2009-02-02 Ankit Jain <[email protected]>
* ResolveAssemblyReference.cs: Honor SearchPaths and the special
items like '{HintPathFromItem}', '{TargetFrameworkDirectory}' etc.
* AssemblyResolver.cs: Add api for more specific search, like search
in a directory, target frameworks, gac etc.
2009-02-01 Ankit Jain <[email protected]>
* CallTarget.cs: Copy all items from target to TargetOutputs.
2009-02-01 Ankit Jain <[email protected]>
* Csc.cs (AddResponseFileCommands):
* ManagedCompiler.cs (AddResponseFileCommands): 'AddModules' and
'AdditionalLibPaths' can be empty.
2009-01-30 Ankit Jain <[email protected]>
* Copy.cs (Execute): Use for loop instead of enumerators.
sourceFiles and destinationFiles can be null, handle that.
Create new directory if required.
2009-01-27 Ankit Jain <[email protected]>
* Delete.cs (Execute): Skip non-existant files.
In class/Microsoft.Build.Tasks:
2009-05-14 Ankit Jain <[email protected]>
Fix tests on monobuild
* Makefile (EXTRA_DISTFILES): Add Test/resources/Sample.vb
2009-04-28 Raja R Harinath <[email protected]>
* Makefile (NAME_SUFFIX): New.
(LIBRARY_NAME): Use it.
(TEST_MCS_FLAGS): Don't mention name of library. Use NAME_SUFFIX
as appropriate when referring to other msbuild dlls.
2009-04-27 Ankit Jain <[email protected]>
* Microsoft.Build.Tasks_test.dll.sources: Added
CreateVisualBasicManifestResourceNameTest.cs .
2009-04-25 Jonathan Chambers <[email protected]>
* Makefile: Adjust assembly name for 3.5 profile.
2009-02-21 Ankit Jain <[email protected]>
* Microsoft.Build.Tasks_test.dll.sources: Added CopyTest.cs
In class/Microsoft.Build.Engine/Test/Microsoft.Build.BuildEngine:
2009-05-29 Ankit Jain <[email protected]>
* EngineTest.cs (TestGlobalProperties*): New tests
and some helper methods.
* ProjectTest.cs (TestResetBuildStatus): Reset twice. Update
the event counts.
2009-05-15 Marek Sieradzki <[email protected]>
* BuildItemTest.cs:
* BuildPropertyGroupTest.cs:
* BuildPropertyGroupCollectionTest.cs:
* BuildPropertyTest.cs:
* BuildItemGroupTest.cs:
* EngineTest.cs:
* InternalLoggerExceptionTest.cs:
* ProjectTest.cs: Don't compare exception messages.
2009-05-12 Ankit Jain <[email protected]>
* ProjectTest.cs (TestAssignment1):
* UsingTaskTest.cs (TestTaskName):
(TestAssemblyNameOrAssemblyFile1):
(TestAssemblyNameOrAssemblyFile2): Don't compare exception messages.
2009-03-27 Jonathan Chambers <[email protected]>
* BuildChooseTest.cs: Enable tests.
* Microsoft.Build.Engine.Test.csproj: Update post build step.
2009-03-26 Jonathan Chambers <[email protected]>
* BuildTaskTest.cs (TestTaskInNamespace): Add test for Task in namespace.
2009-02-24 Ankit Jain <[email protected]>
* UsingTaskTest.cs (TestLazyLoad{1,2,3}): New.
(TestAssemblyNameOrAssemblyFileConditionFalse): New.
(TestDuplicate1): New.
* TargetTest (CheckLoggedMessageHead): Moved to TestMessageLogger,
use that.
2009-02-15 Jonathan Chambers <[email protected]>
* BuildChooseTest.cs (TestValueXml): Add tests for Choose.
Currently not working.
2009-02-12 Jonathan Chambers <[email protected]>
* BuildPropertyTest.cs (TestValueXml): New.
2009-02-01 Ankit Jain <[email protected]>
* ProjectTest.cs (TestBuild[23]): Check number of task started/finished
events.
(TestResetBuildStat): Remove "NotWorking".
(TestBuild4): Likewise. Check number of task started/finished events.
* TargetTest.cs (TestTargetOutputs1): New.
2009-01-30 Ankit Jain <[email protected]>
* ProjectTest.cs (TestRequiredTask_*): New.
(TestBatchedMetadataRef5): New.
2009-01-29 Ankit Jain <[email protected]>
* BuildItemTest.cs (TestBuildItemTransform): New.
In class/Microsoft.Build.Engine/Test/various:
2009-05-29 Ankit Jain <[email protected]>
* Conditions.cs (TestHasTrailingSlash1): New.
(TestUnknownFunction): New.
2009-05-15 Marek Sieradzki <[email protected]>
* Items.cs
* Conditions.cs: Don't check exception messages.
2009-02-23 Ankit Jain <[email protected]>
* Items.cs (TestItemsInTarget8): New.
(TestItemsInTarget9): New.
2009-02-20 Ankit Jain <[email protected]>
* Conditions.cs (TestCondition11): New. Test unquoted item/property
references in conditions.
In class/Microsoft.Build.Engine/Test/resources:
2009-03-26 Jonathan Chambers <[email protected]>
* TestTasks.cs (NamespacedOutputTestTask): New.
2009-02-24 Ankit Jain <[email protected]>
* TestTasks.cs (Another.SameTask): New.
(Other.SameTask): New.
2009-01-30 Ankit Jain <[email protected]>
* TestTasks.cs (RequiredTestTask): Rename to ..
(RequiredTestTask_TaskItems): .. this.
(RequiredTestTask_*): New types.
2009-01-29 Ankit Jain <[email protected]>
* TestTasks.cs (BatchingTestTask.TaskItemsOutput): New.
In class/Microsoft.Build.Engine/Microsoft.Build.BuildEngine:
2009-05-29 Ankit Jain <[email protected]>
Correctly handle global properties. Correctly log
project/build events.
* BuildPropertyGroup.cs (Clone): Implement.
* Engine.cs (globalProperties): Rename to ..
(global_properties): .. this.
(currentlyBuildingProjectsStack): New. Used to correctly
log and raise project/build start/finish events.
(BuildProjectFile): Override any project global properties
with explicitly specified ones, here in the param @globalProperties.
Mark project for reevaluation, which will update the engine's
global properties also.
Reset both engine and project's old global properties at the end.
(UnregisterAllLoggers): Log build finished only if we are currently
building.
(StartBuild): Rename to ..
(StartProjectBuild): .. this. Keeps track of the projects being built
in the new stack, and logs project and build events accordingly.
(EndProjectBuild): New. Uses the stack to keep track of projects
finishing builds, and raises project and build events accordingly.
(LogProjectStarted): Move here from Project.cs
(LogProjectFinished): Likewise.
* Project.cs (Build): Log start of project build.
Set current directory to the project file's dir, and reset at end.
(BuildInternal): Don't log here, its done in Build.
(BuildTarget): Already built targets are keyed by the set of global
properties that they were built with.
(GlobalPropertiesToString): New.
(ResetBuildStatus): 'building' must be true to allow built targets to be reset.
(RemoveBuiltTargets): Initialize builtTargetKeys in .ctor
(Evaluate): Remove built targets only if we are currently building and
build settings are None.
Merge project's global properties with those of the parent engine.
Add missing properties from engine's global properties.
(LogTargetSkipped): Fix format string, add the reqd argument.
2009-05-29 Ankit Jain <[email protected]>
* ConditionFunctionExpression.cs: Add 'HasTrailingSlash' function.
(HasTrailingSlash): New.
2009-05-12 Ankit Jain <[email protected]>
* Project.cs (.ctor): Init timeOfLastDirty.
2009-05-05 Miguel de Icaza <[email protected]>
* Contribution from Martin Brenn to fix#498154.
2009-04-27 Ankit Jain <[email protected]>
Fix bug #497839.
* Engine.cs (BuildProjectFile): Set project's GlobalProperties to the
one passed as argument.
2009-04-27 Ankit Jain <[email protected]>
* TaskEngine.cs (Prepare): Emit a useful error message property value
can't be converted to required type.
2009-04-27 Ankit Jain <[email protected]>
* ExpressionCollection.cs (ConvertToObject): Allow true/on/yes
as valid true values for bool, and corresponding for false.
2009-03-27 Jonathan Chambers <[email protected]>
* BuildWhen.cs: Add basic implementation.
* BuildChoose.cs: Add basic implementation.
* BuildItem.cs (AddEvaluatedItem): Add BuiltItem to
EvaluatedItemsIgnoringCondition.
* GroupingCollection.cs: Add evaluation of BuildChoose items.
2009-03-26 Jonathan Chambers <[email protected]>
* TaskDatabase.cs (RegisterTask): Search for class by name
if task was not found using GetType (which uses namespace).
2009-02-26 Ankit Jain <[email protected]>
* Target.cs: Handle target with no tasks. Log errors.
2009-02-24 Ankit Jain <[email protected]>
Lazily load UsingTask tasks.
* UsingTask.cs (Evaluate): Register 'this' with task database,
but don't load it yet. Register only if condition evaluates to true.
Move the load logic to ..
(Load): .. here. Register with the specified task database.
* TaskDatabase.cs (RegisterUsingTask): Store the UsingTask instance
in a table keyed by task name, but don't load it yet.
(GetTypeFromClassName): Try to load UsingTask if task is not already
loaded. Move loading logic to ..
(GetTypeFromClassNameInternal): .. here.
(CopyTasks): Copy the usingTasks table also.
2009-02-23 Ankit Jain <[email protected]>
* BuildItem.cs (AddMetadata): Allow overwriting older values.
2009-02-22 Ankit Jain <[email protected]>
* BuildItem.cs: Iterate over XmlElements childnodes with XmlNode
instead of XmlElement. Eg. XmlComment
2009-02-21 Ankit Jain <[email protected]>
* Utilities.cs (FromMSBuildPath): Copy from monodevelop.
* Project.cs (Load): Use FromMSBuildPath on the path.
(InitializeProperties): Set "MSBuildToolsPath" also.
2009-02-20 Ankit Jain <[email protected]>
Fix#449683.
* ConditionTokenizer.cs: Handle unquoted item references (with or w/o
transforms) in conditions.
* ConditionParser.cs: Parse unquoted item, property references.
eg. Condition = " @(Foo->'%(Extension)') == '.exe' "
* Token.cs (Token.ToString): Override.
(TokenType.Transform): Uncomment.
2009-02-12 Jonathan Chambers <[email protected]>
* BuildProperty.cs: Value corresponds to XmlElement.InnerXml
no XmlElement.InnerText. This allows properties to be additional
xml elements.
2009-02-01 Ankit Jain <[email protected]>
* BuildEngine.cs (BuildProjectFile): Use
BuildSettings.DoNotResetPreviouslyBuiltTargets for building projects.
* Engine.cs (BuiltTargetsOutputByName): New. Table of targets already
built. Move logging of project start/finish to ..
* Project.cs: .. here. Build a target only if hasn't been built already.
Keep track of target outputs, and return those even if an already built
target has been invoked again.
Honor BuildSettings.None and DoNotResetPreviouslyBuiltTargets .
2009-01-31 Ankit Jain <[email protected]>
* BatchingImpl.cs: Split into ..
* BatchingImplBase.cs: .. this,
* TaskBatchingImpl.cs: .. this ..
* TargetBatchingImpl.cs: .. and this. Implement target batching here.
* Target.cs (DoBuild): Use TargetBatchingImpl for building.
(Log*): Move to TargetBatchingImpl .
(BuildTasks): New.
(Engine): New.
2009-01-30 Ankit Jain <[email protected]>
* TaskEngine.cs (GetObjectFromString): Empty value is allowed only for
arrays.
2009-01-29 Ankit Jain <[email protected]>
* BuildItem.cs (child_items): Change type from BuildItemGroup to
List<BuildItem>.
(HasParent): Rename to ..
(HasParentItem): .. this.
(ParentItemGroup): Add setter.
* BuildItemGroup.cs (.ctor): Add overload with @project param.
(AddNewItem):
(AddItem): Correctly set the ParentItemGroup for new build items.
(ParentProject): Add setter.
* Project.cs: Set the project for new BuildItemGroup instances.
* TaskEngine.cs (PublishItemGroup): Likewise.
In class/Microsoft.Build.Engine:
2009-02-21 Ankit Jain <[email protected]>
* Import.cs (GetFullPath): Use Utilities.FromMSBuildPath .
2009-02-19 Jonathan Chambers <[email protected]>
* Microsoft.Build.Engine.csproj: Add.
* Microsoft.Build.Engine.Test.csproj: Update.
2009-01-31 Ankit Jain <[email protected]>
* Microsoft.Build.Engine_test.dll.sources: Replace BatchingImpl.cs with
BatchingImplBase.cs, TargetBatchingImpl.cs and TaskBatchingImpl.cs
In class/Microsoft.Build.Utilities:
2009-04-25 Jonathan Chambers <[email protected]>
* Makefile: Adjust assembly name for 3.5 profile.
2009-02-25 Ankit Jain <[email protected]>
* Microsoft.Build.Utilities.dll.sources: Add ProcessService.cs,
ProcessWrapper.cs, IAsyncOperation.cs and IProcessAsyncOperation.cs
In class/Microsoft.Build.Utilities/Microsoft.Build.Utilities:
2009-04-24 Ankit Jain <[email protected]>
* ToolTask.cs (RealExecute): Handle TypeLoadExceptions, compiler
crashes and report them. Borrow some tricks from md.
(LogEventsFromTextOutput): Ignore known non-error messages. Don't
log unknown lines, crashes get handled elsewhere.
2009-04-08 Ankit Jain <[email protected]>
Fix bug #491828.
* ToolTask.cs (LogEventsFromTextOutput): Log even in case of
unrecognized errors.
2009-02-25 Ankit Jain <[email protected]>
* ProcessService.cs, IAsyncOperation.cs, IProcessAsyncOperation.cs,
ProcessWrapper.cs: Brought in from monodevelop.
* ToolTask.cs: Use the new ProcessService to execute the tool. Honor
SkipTaskExecution (). Use response files, but log the contents of the
response file instead of "@foo.rsp". Support environmentOverrides.
(LogEventsFromTextOutput): Add null check.
* Exec.cs (GetWorkingDirectory): Use the workingDirectory property.
2009-02-20 Ankit Jain <[email protected]>
Fix bug #475438.
* ToolTask.cs (RealExecute): Check whether the target executable exists.
Log any execution errors.
svn path=/branches/mono-2-4/mcs/; revision=135336
* OracleParameterTest.cs: Mark tests for bug #424908 as NotWorking
as it requires some more thorough debugging.
svn path=/branches/mono-2-4/mcs/; revision=135315
* HttpConnection.cs: unbind the context after every read for keep-alive
connections.
Bug #502274 fixed.
svn path=/branches/mono-2-4/mcs/; revision=135242
* OracleParameter.cs: If a non-zero size is passed, update
the size member but sizeSet is updated only when a non-null
value is passed.
svn path=/branches/mono-2-4/mcs/; revision=135236
* BuildManager.cs: allow deployment of precompiled applications under
any virtual path, not just the default one used when precompiling.
Fixes bug #483268.
svn path=/branches/mono-2-4/mcs/; revision=135232
* marshal.c (mono_marshal_get_runtime_invoke): Emit the right kind
of ldind opcode for generic instances so we don't fail for direct wrappers.
Fixes#508538.
svn path=/branches/mono-2-4/mono/; revision=135138
* collection.c (_wapi_collection_init): If pthread_create() fails,
try again with larger and then with no stack size set. Fixes
#470336.
Backport of r134985.
svn path=/branches/mono-2-4/mono/; revision=134986
Backport of r134810.
* icall.c (ves_icall_Type_GetMethodsByName): Virtual methods should be
discarded based on their most specific definition so we set the method_slots
array before checking if the method is acceptable or not.
Fixes#506757.
svn path=/branches/mono-2-4/mono/; revision=134944
Backport of r134723.
* class.c (mono_class_setup_fields): Don't mark simd types as having
16 bytes alignment as the whole runtime doesn't support.
svn path=/branches/mono-2-4/mono/; revision=134724
Backport of r134713/134715.
* basic.cs: Add regression test for #506915.
* method-to-ir.c (mono_method_to_ir): When doing the ldobj+stobj
optimization we must check the bb of the first byte of stobj as
it's the only one set in cil_offset_to_bb.
Fixes#506915.
svn path=/branches/mono-2-4/mono/; revision=134719
Backport of r134536.
* mini-x86.c (mono_arch_emit_call): The decompose code now supports
decomposing 8 bytes structs into a LCALL.
* mini-x86.c (emit_move_return_value): We no longer push the vtype
pointer for where to store the returned regs.
* decompose.c (mono_decompose_vtype_opts): Fix the comment to properly
state the concern.
Fixes#471747, #471751 and #4734530 (in fact, it's a bunch of dups).
svn path=/branches/mono-2-4/mono/; revision=134538
A fix for bug #504667
* class.cs: Check for static class using parent container instead of
parent type.
svn path=/branches/mono-2-4/mcs/; revision=134524
A fix for bug #495112
* class.cs (IsUnmanagedType): Handle recursive unmanaged types using
local cache.
svn path=/branches/mono-2-4/mcs/; revision=134522
Backport of r134470.
* local-propagation.c (mono_local_cprop): Avoid local propagation
across paired add/sub if the first instruction dest reg is it's
source reg. For example:
int_add_imm R12 <- R12 [1] clobbers: 1
int_sub_imm R42 <- R12 [1] clobbers: 1
The cprop pass would wrongly const prop + 1 to int_sub_imm which doesn't
maintain the math identify.
Fixes#505375.
svn path=/branches/mono-2-4/mono/; revision=134472
* RouteCollection.cs: when there is no named route, try the current
route before going through the list. The known values (default or
not) for the current route are merged with the values provided when
attempting to match.
Example:
Html.RouteLink ("Text", new { page = 5 });
when the current path is /some/path-here and the route is:
routes.MapRoute("RouteName", "some/{one}-{two}/{page}",
new { controller = "Some", action = "Index", page = 1});
svn path=/branches/mono-2-4/mcs/; revision=134273
** Fixes#325464 - ToolItems.xsd
* CustomDataClassGenerator.cs (CreateDataSetTableMembers): Prefix a "_" to
member names when it is same as that of the dataset. Fixes the CS0542 error
during compilation of the generated source.
svn path=/branches/mono-2-4/mcs/; revision=134264
** Fixes#424908
* OracleParameter.cs: Make sure size and sizeSet are properly
updated whenever value changes.
svn path=/branches/mono-2-4/mcs/; revision=134194
** Fixes rest of #497715 - Patch by Jonas Larsson <[email protected]>
* TdsMetaParameter.cs: Add support for XML type. For now, handle
XML type as just NVarchar.
backport of r134079
svn path=/branches/mono-2-4/mcs/; revision=134080
* UrlPattern.cs: if the pattern is line {a}/{b} and {b} is substituted
by an empty string, remove the '/' too.
svn path=/branches/mono-2-4/mcs/; revision=134027
* Dns.cs: made GetHostAddresses and friends internal for 1.x
* EndpointPermission.cs: use GetHostAddresses.
svn path=/branches/mono-2-4/mcs/; revision=133950
* UdpClient.cs: if possible, avoid DNS lookups when the host name is
an IP address. Related to bug #502866.
svn path=/branches/mono-2-4/mcs/; revision=133945
* CustomizableFileSettingsProvider.cs: make sure 'values' is
initialized in Reset(). Fixes bug #436592.
svn path=/branches/mono-2-4/mcs/; revision=133867
* DateTimePicker.cs: Add a UIA-specific property to ensure that if
is_checkbox_checked is changed, we won't break.
svn path=/branches/mono-2-4/mcs/; revision=133816
* DateTimePicker.cs: Wrap UIA specific code in NET_2_0 wrappers. Send
OnUIASelectionChanged when ShowCheckbox is true and the checkbox
recieves focus. Part of fix for #502029.
svn path=/branches/mono-2-4/mcs/; revision=133782
* Connection.cs: if the socket is already disconnected, Shutdown will
fail with a SocketException... Also, catch *all* the possible
exceptions since the socket.Close method could also throw
ObjectDisposedException.
Fixes bug #449092.
svn path=/branches/mono-2-4/mcs/; revision=133735
* src/gtimer-win32.c (g_timer_elapsed): Avoid re-querying freq by
just saving it in a static variable. Also modified microseconds
calculation to avoid overflow.
svn path=/branches/mono-2-4/mono/; revision=133723
backport of r133710.
* XElement.cs (Load (XmlReader,LoadOptions)): prevent a NRE if
the provided XmlReader doesn't have existing settings.
Fixes#501589.
svn path=/branches/mono-2-4/mcs/; revision=133712
Backport of r133651.
* aot-compiler.c aot-runtime.c: Use our own hash function instead of
g_str_hash () which can change.
svn path=/branches/mono-2-4/mono/; revision=133654
* io-layer/events.c: fix event_signal and namedevent_signal to actually signal
the handle.
* metadata/icall-def.h:
* metadata/threads-types.h:
* metadata/threads.c: added internal call for WaitHandle.SignalAndWait.
svn path=/branches/mono-2-4/mono/; revision=133631
* Lease.cs: Don't use ArrayList.Remove() to remove sponsors because
it will end calling Equals, which may crash if the sponsor is not
available anymore. Just compare references.
svn path=/branches/mono-2-4/mcs/; revision=133623
* RealProxy.cs: If async dispatch crashes, don't propagate the
exception. The exception will be raised when calling EndInvoke.
svn path=/branches/mono-2-4/mcs/; revision=133622
* ToolStripDropDown.cs: In OnVisibleChanged, if we have an OwnerItem,
fire OnDropDownOpened/OnDropDownClosed depending on the new
visibility. This also ensures that any direct access to this instance
will fire the mentioned events for the OwnerItem.
* ToolStripDropDownItem.cs: Remove the invocations to
OnDropDownOpened/OnDropDownClosed, since they are handled in
ToolStripDropDown, as well as updating the
OnDropDownHide/OnDropDownShow calls to be in the right order.
Fixes#496139.
svn path=/branches/mono-2-4/mcs/; revision=133554
* MaskedTextBox.cs: If Insert is pressed, change the internal
overwrite mode for our default value.
Fixes some bits of #477395.
svn path=/branches/mono-2-4/mcs/; revision=133552
* MaskedTextBox.cs: When setting Text use the very precise algorithm
that .net uses: iterate over every char of the new value, trying to
use every char, and use a normal call to MaskedTextProvider.Replace
call if RejectInputOnFirstFailure is true. Fire OnMaskInputRejected
in case of error in both cases, as well.
Fixes#477408.
svn path=/branches/mono-2-4/mcs/; revision=133551
* MaskedTextBox.cs: Handle OnKeyDown to properly process the Delete
key. Also create a new method to avoid code duplication between
OnKeyDown and OnKeyPress.
Fixes#477388.
svn path=/branches/mono-2-4/mcs/; revision=133550
* MaskedTextBox.cs: In OnKeyPress the IsOverwriteMode check is
actually inversed, so put it the right way. Also, don't automatically
look for the next editable item after adding a new one, but way for
the next insertion (this is what .net does) - this is not needed when
MaskedTextProvider.InsertAt is called however, since it already looks for the
next editable position.
Fixes the remaining bits of #477383.
svn path=/branches/mono-2-4/mcs/; revision=133549
* MaskedTextBox.cs: In OnKeyPress handle backspace by calling
MaskedTextProvider.RemoveAt method. Also for setting the SelectionStart
property after the text was modified, adjust the testPosition value
depending on what method was called.
Fixes part of #477383.
svn path=/branches/mono-2-4/mcs/; revision=133548
* Ping.cs: we just need the address(es), not a host entry. This avoids
querying the DNS server(s) when the target is an IP address.
svn path=/branches/mono-2-4/mcs/; revision=133460
* debug-debugger.c (debugger_insert_source_breakpoint): Don't call
mono_debugger_insert_method_breakpoint() since the class init
handler we're inserting at the top of the method already gives us
a notification.
svn path=/branches/mono-2-4/mono/; revision=133424
* Tds.cs (InitExec): Move initialization of state variables here. Useful
in case of asynchronous queries.
svn path=/branches/mono-2-4/mcs/; revision=133362
* Tds.cs (ExecuteQuery): Reset all the variables related to LoadData when
performing queries with SequentialAccess set to true. Fixes incorrect
handling of data retrieval when consecutive queries are run with
SequentialAccess set to true.
svn path=/branches/mono-2-4/mcs/; revision=133361
* Tds.cs (ExecuteQuery): Reset SequentialAccess read state variables
in order to avoid blocking forever when two consecutive queries are
executed with SequetialAccess set to true.
svn path=/branches/mono-2-4/mcs/; revision=133360
* SqliteConnection.cs: implement Dispose for 2.0. It was leaking an fd
in using().
Bug #499864 fixed.
svn path=/branches/mono-2-4/mcs/; revision=133255
* sockets.c: don't display a warning when connect() fails because the
socket was closed in another thread.
svn path=/branches/mono-2-4/mono/; revision=133032
* mini.c (mini_method_compile): Use TARGET_<ARCH> defines instead of
__<arch>__ defines in the JIT code.
svn path=/branches/mono-2-4/mono/; revision=132980
* HttpUtility.cs: the collection returned from ParseQueryString knows
how to convert the key/value pairs to a string.
svn path=/branches/mono-2-4/mcs/; revision=132947
* TdsConnectionPool.cs: if GetConnection() fails to create a
connection, try again several times and then throw. Improved
ResetConnectionPool() so that it does not immediately close
connections in use. Don't re-add connections that have been closed.
* Tds.cs: Connected tests the socket connection too. Made Disconnect()
not throw.
* TdsComm.cs: set more socket options (timeout and NoDelay) and have a
single entry point for reading from the stream.
svn path=/branches/mono-2-4/mcs/; revision=132940
2009-03-31 Martin Baulig <[email protected]>
* debug-debugger.c (debugger_remove_breakpoint): Call
mono_debugger_remove_class_init_callback ().
2009-03-31 Martin Baulig <[email protected]>
* mono-debug-debugger.c
(mono_debugger_register_class_init_callback): Also register the
class init callback if the class is already initialized to make
things work with shadow copied assemblies.
svn path=/branches/mono-2-4/mono/; revision=132891
* cominterop.c (ves_icall_System_Runtime_InteropServices_Marshal_ReleaseComObjectInternal):
changed to match .Net behaviour of not aborting on additional calls to ReleaseComObject.
svn path=/branches/mono-2-4/mono/; revision=132873
* ConsoleTraceListener.cs: add an internal constructor that takes a
string argument. Used when 'initializeData' is set.
* DiagnosticsConfigurationHandler.cs: try internal constructors when
the assembly is System.
Fixes bug #498853.
svn path=/branches/mono-2-4/mcs/; revision=132869
2009-04-25 Miguel de Icaza <[email protected]>
* StreamReader.cs (DataAvailable): New internal function to work
around the fact that StreamReaders are now blocking on Peek(), and
that our own Console.TermInfoDriver used Peek() as a way of
probing if there was data on a stream before to avoid blocking. o
2009-04-25 Miguel de Icaza <[email protected]>
* TermInfoDriver.cs: Use the new StreamReader.DataAvailable to
load all the data that was added into the `stdin' stream when we
did the `Read'.
svn path=/branches/mono-2-4/mcs/; revision=132671
Backport of r129367
* Convert.cs (ToType): Control whether this internal function will
call an IConvertible.ToType method or not.
Classes and structs implementing IConvertible in mscorlib (the
only callers that can access Convert.ToType) must pass false to
avoid a infinite recursion problem and callers from the public
Convert API must call it with true.
This fixes the regression reported in #485377 that was introduced
by the fix for #481687.
* Int16.cs, UInt64.cs, Double.cs, Enum.cs, SByte.cs, UInt16.cs,
Byte.cs, Decimal.cs, Int32.cs, String.cs, Int64.cs, Char.cs,
Boolean.cs, Single.cs, UInt32.cs: Update the call sites.
svn path=/branches/mono-2-4/mcs/; revision=132668
* threads.c (mono_thread_suspend_all_other_threads): Handle the case when
the a thread does not suspend within 100ms.
* monitor.c (mono_monitor_try_enter_internal): Handle SuspendRequested
in addition to StopRequested as well.
svn path=/branches/mono-2-4/mono/; revision=132494
* Microsoft.CSharp/CSharpCodeCompiler.cs:
* Microsoft.VisualBasic/VBCodeCompiler.cs: better error when there's a
problem running the specified exec.
svn path=/branches/mono-2-4/mcs/; revision=132391
* method-to-ir.c (mono_method_to_ir): Force init_locals to be TRUE
to prevent asserts in various passes. Fixes#497220.
svn path=/branches/mono-2-4/mono/; revision=132365
* HttpSoapWebServiceHandler.cs: provide the full stack trace instead
of just the Message to aid in debugging web service problems.
Bug #496758 fixed.
svn path=/branches/mono-2-4/mcs/; revision=132336
**** Backport of r131819 ****
* MonoSymbolWriter.cs: Move `ISourceFile', `ICompileUnit' and
`IMethodDef' into MonoSymbolFile.cs. This allows us to use the
symbol reader part without MonoSymbolWriter.cs.
svn path=/branches/mono-2-4/mcs/; revision=131820
**** Backport of r131801 ****
* MonoSymbolTable.cs
(LineNumberTable.DW_LNE_MONO__extensions_start): New const.
(LineNumberTable.DW_LNE_MONO__extensions_end): New const.
(LineNumberTable.DoRead): Ignore unknown extended opcodes if
they're within the Mono extension range.
svn path=/branches/mono-2-4/mcs/; revision=131806
**** Backport of r131800 ****
* debug-mono-symfile.c
(mono_debug_symfile_lookup_location): Don't print a warning for
unknown extended opcodes if they're within 0x40 and 0x7f.
svn path=/branches/mono-2-4/mono/; revision=131803
* HttpUtility.cs: the collection returned from ParseQueryString knows
how to convert the key/value pairs to a string.
svn path=/branches/mono-2-4/mcs/; revision=131600
A fix for bug #493887
* statement.cs: Don't skip string multi-section with default or
null label when populating string hashtable.
svn path=/branches/mono-2-4/mcs/; revision=131590
* include/private/gc_locks.h (GC_test_and_set): Merge a change from libgc
7.1's libatomic-ops to fix the ppc build with gcc 4.4.
svn path=/branches/mono-2-4/mono/; revision=131472
* BuildManager.cs: enabled recursion checking for page
targets. Also, if a built item is skipped because it has been
compiled recursively, add its assembly to the list of referenced
assemblies for the batch being currently compiled.
svn path=/branches/mono-2-4/mcs/; revision=131466
an improvement, but doesn't fix all problems. In particular, some
assemblies will depend upon other assemblies to load (e.g. 3rd party
assemblies) but these dependent assemblies shouldn't be documented.
Add support for -r:ASSEMBLY and -L:DIRECTORY arguments to allow the
user to manually add to the assembly search path so that assemblies
can be found. Assemblies added via -r will NOT be documented.
svn path=/branches/mono-2-4/mcs/; revision=131446
shared amongst all AssemblyDefinitions to resolve assembly/type
references with Cecil. Otherwise, if we have deeply nested
directories with cross-directory assembly dependencies, then Cecil
won't find the necessary assemblies (e.g. b/bin/Debug/b.dll has a
type which inherits from a/bin/Debug/a.dll -- here, we'll have two
separate AssemblyDefinitions, and when b.dll's AssemblyDefinition
tries to resolve types from a.dll, it fails).
See: http://lists.ximian.com/pipermail/mono-devel-list/2009-April/031646.html
svn path=/branches/mono-2-4/mcs/; revision=131366
* FtpWebRequest.cs: send REST after PASV to avoid some servers
forgetting aboout it.
Bug #491590 fixed.
svn path=/branches/mono-2-4/mcs/; revision=131181
A fix for bug #492329
* expression.cs (New): Load variable when assigning type parameter
to ref variable.
svn path=/branches/mono-2-4/mcs/; revision=131103
* AssemblyResourceLoader.cs: MS sets cacheability to public. Add
Last-Modified header and return 304 if validating max-age=0 or
If-Modified-Since succeeds.
svn path=/branches/mono-2-4/mcs/; revision=131054
backport of 130961.
* Enumerable.cs (Cast): fix for when casted enumerator is already
of the appropriate type.
svn path=/branches/mono-2-4/mcs/; revision=130962
backport of r130884 and r130886.
* Dictionary.cs (ValueCollection.CopyTo): fix for copying to
an object array. Based on a patch by Tobias Grimm <[email protected]>.
Fixes bug #328036.
svn path=/branches/mono-2-4/mcs/; revision=130887
* socket-io.c: don't fail if the SocketOptionsFlag has Partial or
* MaxIOVectorLength enabled, just ignore them.
Fixes bug #349688.
svn path=/branches/mono-2-4/mono/; revision=130614
* mini-exceptions.c (get_generic_info_from_stack_frame): Avoid returning
a managed object which is later put into a GList. Return its class instead.
* mini.c (mono_allocate_stack_slots_full): Avoid sharing ref and non-ref
stack slots when using sgen.
svn path=/branches/mono-2-4/mono/; revision=130475
* marshal.c (mono_marshal_load_type_info): Fill out info->min_align.
(mono_class_native_size): Use klass->marshal_info->min_align instead of
klass->min_align, since klass->min_align contains the managed alignment,
while the native alignment can be different, like for longs on x86.
Fixes#469135.
* class-internals.h (MonoMarshalType): Add a min_align field.
svn path=/branches/mono-2-4/mono/; revision=130473
* appdomain.c:
* console-io.[ch]: added new mono_console_init() to make sure that
file descriptors 0, 1 and 2 are opened.
Bug #489019 fixed.
svn path=/branches/mono-2-4/mono/; revision=130425
* DefaultWsdlHelpGenerator.aspx: disable the test form
when only Soap is supported.
Bug #342073 fixed.
svn path=/branches/mono-2-4/mono/; revision=130401
* marshal.c (emit_marshal_object): Generate code to throw an exception
instead of throwing it. Fixes#488670.
Conflicts:
mono/metadata/ChangeLog
svn path=/branches/mono-2-4/mono/; revision=130259
stat.f_bavail * stat.f_frsize, NOT f_bavail*f_bsize, as on some
platforms (Solaris) bsize is the preferred block I/O size, while
f_frsize is the *actual* filesystem block size. Thus, to get proper
disk under Solaris, we need to s/f_bsize/f_frsize/g.
svn path=/branches/mono-2-4/mcs/; revision=130056
Backport of r129824.
* mini-amd64.c (mono_arch_compute_omit_fp): Add another check to avoid hitting
the stack_alloc_size < (1 << 16) assertion in emit_prolog ().
svn path=/branches/mono-2-4/mono/; revision=129825
Backport of r129461.
This patch is contributed under the terms of the MIT/X11 license
* Makefile.am (test_platform): Enable testbundle for ppc.
svn path=/branches/mono-2-4/mono/; revision=129463
Backport of r129460.
This patch is contributed under the terms of the MIT/X11 license
* mkbundle.cs (WriteSymbol): Use .p2align 5 instead of .align 32
to get consistent results on all platforms.
svn path=/branches/mono-2-4/mcs/; revision=129462
r129416:
- When checking if an elf file is valid, avoid mapping it in
memory until we know it's usable (avoids virtual memory
fragmentation issues).
- Correctly handle duplicated entries in /proc/self/maps.
svn path=/branches/mono-2-4/mono/; revision=129418
* appdomain.c: if the assembly name is a shadow-copied file, return
TRUE from mono_is_shadow_copy_enabled but don't actually do anything
in mono_make_shadow_copy.
* icall.c: if the assembly name is a shadow-copied file, replace it
with the original assembly path.
Bug #484244 fixed. NUnit tests for corlib can be run without
--noshadow now.
svn path=/branches/mono-2-4/mono/; revision=129214
* appdomain.c: if the assembly name is a shadow-copied file, return
TRUE from mono_is_shadow_copy_enabled but don't actually do anything
in mono_make_shadow_copy.
* icall.c: if the assembly name is a shadow-copied file, replace it
with the original assembly path.
Bug #484244 fixed. NUnit tests for corlib can be run without
--noshadow now.
svn path=/branches/mono-2-4/mono/; revision=129212
2009-03-12 Dean Brettle <[email protected]>
* nBrowser/Build.cs: made Browser() method thread-safe and moved the
actual tree creation to a private InitializeTree() method for clarity.
svn path=/branches/mono-2-4/mcs/; revision=129179
* InotifyWatcher.cs: don't send events when a directory is created
unless it matches the pattern. Fixes bug #484082.
svn path=/branches/mono-2-4/mcs/; revision=129113
Backport of r128849 + r128490.
* domain-internals.h (struct _MonoDomain): Add new hash tables mapping
between GCHandles of type WeakTrackResurrection and the objects they
point to.
* gc.c: Partly implement the sematics of GCHandles of type
WeakTrackResurrection: these handles should only be cleared after the
finalizer of the object they are pointing to has ran.
* domain-internals.h (struct _MonoDomain): Add a separate lock for the
finalize_objects_hash.
* gc.c: Use the separate lock to access the finalize_objects_hash field.
svn path=/branches/mono-2-4/mono/; revision=129104
* mini-x86.c (mono_arch_output_basic_block): Use different
registers in case the ones we want to overwrite are used by the
other operand. Fixes regression in #480807.
Backport of r129058.
svn path=/branches/mono-2-4/mono/; revision=129064
Backport of r129009.
* reflection.c (ensure_complete_type): New helper function to call
type resolve handlers for unfinished dynamic types.
(resolve_object): Call it for MonoClassFields. Fixes#483852.
svn path=/branches/mono-2-4/mono/; revision=129010
Backport of r128924.
* mini-s390x.c: Fix support for vtypes whose addresses are passed on the
stack.
svn path=/branches/mono-2-4/mono/; revision=128926
Contributed under the terms of the MIT/X11 license by Steven
Munroe <[email protected]>.
* mini-ppc.c: Correct handling of OP_LOADI4_MEMINDEX for ppc64.
Fixes#483462.
Backport of r128904.
svn path=/branches/mono-2-4/mono/; revision=128905
* mini-trampolines.c (mono_create_jump_trampoline): If the method
is shared generic code, return the trampoline, even if the method
has already been compiled. Fixes#479763.
* mini.c, mini.h: New function
mono_jit_find_compiled_method_with_jit_info() which is the same as
mono_jit_find_compiled_method() but also returns the jit info.
Backport of r128723.
2009-03-09 Mark Probst <[email protected]>
* generic-sharing.c (instantiate_other_info): Always return a jump
trampoline for method code.
Backport of r128723.
2009-03-09 Mark Probst <[email protected]>
* bug-479763.2.cs: New test.
* Makefile.am: Test added.
Backport of r128723.
svn path=/branches/mono-2-4/mono/; revision=128903
* class.cs: Use correct common base type for unmanaged delayed
check.
* rootcontext.cs: Wrap unhandled exception.
svn path=/branches/mono-2-4/mcs/; revision=128854
* ResourceSet.cs: for custom resource sets without a reader, pretende
that's we've already read the stream.
svn path=/branches/mono-2-4/mcs/; revision=128815
* arm/tramp.c: Include a change from the debian patches. Avoid #include-ing
a file in the middle of a function.
svn path=/branches/mono-2-4/mono/; revision=128784
* method-to-ir.c (mono_method_to_ir): Only force the vtable var
for methods which actually have one. For all other methods, make
sure the this argument var is live the whole method.
* mini.c (mini_method_compile): Every shared method has a
this/vtable/mrgctx info. Fixes#480807.
Backport of r128720.
svn path=/branches/mono-2-4/mono/; revision=128724
* mono.def : Removing missing methods to remove link errors for
MSVC build.
Code is contributed under MIT/X11 license.
svn path=/branches/mono-2-4/mono/; revision=128712
Contributed under the terms of the MIT/X11 license by Steven
Munroe <[email protected]>.
* mini-ppc.c, mini-ppc.h: Implement TLS for PPC64.
Backport of r127060.
2009-03-05 Mark Probst <[email protected]>
Contributed under the terms of the MIT/X11 license by Steven
Munroe <[email protected]>.
* mono-compiler.h: MONO_THREAD_VAR_OFFSET for PPC(64).
Backport of r127060.
svn path=/branches/mono-2-4/mono/; revision=128711
2009-03-04 Martin Baulig <[email protected]>
* debug-mini.c: Clean up the exception API and add documentation.
(mono_debugger_handle_exception): New public method; this is
called when throwing an exception or encountering an unhandled one.
(mono_debugger_call_exception_handler): Formerly known as
mono_debugger_handle_exception(); this is used to tell the
debugger that we're about to invoke an exception handler.
svn path=/branches/mono-2-4/mono/; revision=128614
2009-03-04 Martin Baulig <[email protected]>
* debug-mini.c (mono_debugger_runtime_invoke): Moved here from
../metadata/mono-debug-debugger.c; save and reset exception state.
2009-03-02 Martin Baulig <[email protected]>
* debug-mini.c: Moved the debugger exception handling here from
../metadata/mono-debug-debugger.c.
* debug-mini.h
(MonoDebuggerExceptionAction): New exception typedef.
* debug-mini.c
(MonoDebuggerThreadInfo): Added `MonoObject *last_exception'.
* exceptions-amd64.c
(mono_amd64_throw_exception): Use the new debugger exception
handling code.
* mini-exceptions.c
(mono_handle_exception_internal): Don't call
mono_debugger_unhandled_exception() here.
2009-03-04 Martin Baulig <[email protected]>
* mono-debug.h
(mono_debugger_runtime_invoke): Removed.
* mono-debug-debugger.c
(mono_runtime_invoke): Moved into ../mini/debug-mini.c.
2009-03-02 Martin Baulig <[email protected]>
* mono-debug.h
(mono_debugger_unhandled_exception): Removed.
(mono_debugger_handle_exception): Removed.
(mono_debugger_throw_exception): Removed.
* mono-debug.h (MONO_DEBUGGER_MINOR_VERSION): Bump to 1.
* mono-debug.c
(mono_debug_debugger_version): Bump to 5.
* mono-debug-debugger.c: Moved the exception handling code to
../mini/debug-mini.c
svn path=/branches/mono-2-4/mono/; revision=128613
* method-to-ir.c: Don't inline methods that use JMP. Fixes
#481403.
Backport of r128552.
2009-03-04 Mark Probst <[email protected]>
* bug-481403.il: New test.
* Makefile.am: Test added.
Backport of r128552.
svn path=/branches/mono-2-4/mono/; revision=128560
* BaseParser.cs:
* PageParser.cs:
* ControlBuilder.cs:
* TemplateParser.cs:
* Page.cs:
* SimpleWebHandlerParser.cs: settings that have to be in
machine.config or the root level web.config now call
GetWebApplicationSection.
svn path=/branches/mono-2-4/mcs/; revision=128274
* Enum.cs (FindName): Use a hash table for looking up names instead of
a linear search for enums with a lot of values.
svn path=/branches/mono-2-4/mcs/; revision=128268
* Socket.cs: instead of clearing the sockets form the output and then
adding them back, we just remove the ones that have not been signaled.
Fixes bug #354090 and bug #476138.
svn path=/branches/mono-2-4/mcs/; revision=128260
* MonoProperty.cs (GetValue): Optimize getters for properties without arguments.
2008-02-26 Rodrigo Kumpera <[email protected]>
* MonoProperty.cs (GetValue): Optimize getters for properties without arguments.
The optimization is to create a pair of chained delegates that duplicate the workings
on MethodBase::Invoke without all the aditional overhead and without doing two
managed/native transitions.
Simple Getter performance is up to 17x faster.
This patch reduces contention on domain and domain jit code hash locks, which
can be very hot on asp.net applications.
svn path=/branches/mono-2-4/mcs/; revision=128174
* appdomain.c: make the check to avoid copying when the assembly is
already shadow copied actually work.
svn path=/branches/mono-2-4/mono/; revision=128126
* WebConfigurationManager.cs: generate a hash from the string hsah
codes instead of concatenating them.
svn path=/branches/mono-2-4/mcs/; revision=128122
- s/TEST_FILES/MAN_TEST_FILES/g: $(TEST_FILES) is used by the normal
build process, so the local definition is lost (and thus ignored).
Result: Test/* isn't actually copied. Oops. Changing to
MAN_TEST_FILES allows things to be copied.
- Fix the filenames within $(MAN_TEST_FILES) so `make dist-local'
works without error.
- Fixes#479753.
svn path=/branches/mono-2-4/mcs/; revision=128120
* String.cs (FormatHelper): If all the arguments are strings, compute an
initial length for the stringbuilder to avoid reallocations.
svn path=/branches/mono-2-4/mcs/; revision=128116
Backport of r127929.
* Enum.cs (GetInfo): Add a global cache in addition to the thread-local
caches to accomodate short living threads like threadpool threads.
svn path=/branches/mono-2-4/mcs/; revision=127930
* DataGridViewCell.cs: Invalidate the datagrid when the cell is selected
or deselected.
[Fixes bug #479124]
svn path=/branches/mono-2-4/mcs/; revision=127893
backport of 127755.
* Expression.cs (IsNumber): actually decimal is rather a special
case, and not a primitive number.
svn path=/branches/mono-2-4/mcs/; revision=127756
Backport of r127665.
* tramp-ppc.c (mono_arch_create_trampoline_code): Store the
correct frame pointer in the LMF. Should fix#478394.
svn path=/branches/mono-2-4/mono/; revision=127666
* FtpWebResponse.cs: return a Null stream when there's no response to
be read.
* FtpWebRequest.cs: provide the error returned by the server in the
exception.
* WebClient.cs: set the correct method when doing a FTP upload.
Fixes bug #478451.
svn path=/branches/mono-2-4/mcs/; revision=127641
* marshal.c (mono_marshal_get_runtime_invoke): Fix _another_ bug sharing
runtime invoke wrappers, this time it is string ctor wrappers, which
pass a dummy string as 'this' instead of their obj argument. Fixes
#478473.
svn path=/branches/mono-2-4/mono/; revision=127638
* method-to-ir.c (mono_method_to_ir): Don't assert if string ctors
are called from runtime invoke wrappers.
svn path=/branches/mono-2-4/mono/; revision=127636
in System.Reflection:
2008-02-21 Jb Evain <[email protected]>
* Module.cs: add a new virtual GetModuleVersionId method,
and make the properties .MvId and ModuleVersionId call it.
This way, we can override it in ModuleBuilder.
Part of the fix for #471302.
in System.Reflection.Emit:
2008-02-21 Jb Evain <[email protected]>
* ModuleBuilder.cs: override GetModuleVersionId
so that we can get the module guid from Module.ModuleVersionId.
Part of the fix for #471302.
svn path=/branches/mono-2-4/mcs/; revision=127632
backport of r127628.
* MonoType.cs (InvokeMember): don't pass a null args to
Binder.BindToMethod. Fix for #471275.
svn path=/branches/mono-2-4/mcs/; revision=127629
* System.Web/HttpWriter.cs: new Response property and WriteUTF8Ptr
method.
* System.Web/HttpResponseStream.cs: added support for writing from an
IntPtr. copied the memcpy method from String.cs.
* System.Web.Compilation/BuildManager.cs: updated comment.
* System.Web.UI/ResourceBasedLiteralControl.cs: new Control. It's just
like a LiteralControl but will render itself from the bytes pointed to
by an IntPtr and not create any string from the underlying data unless
needed.
* System.Web.UI/TemplateControl.cs: implemented a bunch of methods
that are used from the precompiled assemblies for a web project. The
most notable change needed is to be able to read a win32 resource from
the dll of the control. The resource is a concatenation of literals
with plain text for the control and a specialized LiteralControl is
generated from different chunks of the resource.
* System.Web.UI/HtmlTextWriter.cs: new method that returns the
HttpWriter in use.
* System.Web.dll.sources: added new file.
* System.Web.Util/ICalls.cs: new internal call to get a pointer to the
win32 resource associated with the control's assembly.
svn path=/branches/mono-2-4/mcs/; revision=127580
* cil-coff.h:
* icall-def.h:
* icall.c: add new GetUnmanagedResourcePtr that returns a pointer to a
win32 resource loaded from a PE file.
* image.c: fix mono_image_lookup_resource.
svn path=/branches/mono-2-4/mono/; revision=127575
A fix for bug #477447
* statement.cs: Add reference to correct parent storey when this
is accessible from deep children storey (more than 1 level).
svn path=/branches/mono-2-4/mcs/; revision=127528
* DataGridViewCell.cs: Use strict equality comparison in order to
prevent superfluous CellValueChanged events.
svn path=/branches/mono-2-4/mcs/; revision=127452
* FtpWebRequest.cs: avoid errors when creating a temporary Uri to get
the local path.
* WebClient.cs: when setting up the request for downloading, use the
default method. Fixes bug #477611.
svn path=/branches/mono-2-4/mcs/; revision=127451
* DataGridView.cs: Do not reset the columns when the data list changes,
but only the rows. Fixes multiple bugs related to sorting, custom
column styles being reset and more.
svn path=/branches/mono-2-4/mcs/; revision=127435
* System.Web/HttpApplicationFactory.cs: check of global.asax was precompiled.
* System.Web.UI/MasterPage.cs: the items in ContentPlaceHolders are lowercase.
* System.Web.Compilation/TemplateControlCompiler.cs: lowercase place holder names
* System.Web.Compilation/BuildManager.cs: initial support for
precompilation. No 'updatable', please.
svn path=/branches/mono-2-4/mcs/; revision=127353
Backport of r127347.
* marshal.c (mono_ftnptr_to_delegate): Convert a NULL ftnptr to a null
delegate. Fixes#477396.
svn path=/branches/mono-2-4/mono/; revision=127349
backport of r127279.
* marshal.c (cominterop_get_managed_wrapper_adjusted) :
Adding exception handling for all CCW calls.
Code is contributed under MIT/X11 license.
svn path=/branches/mono-2-4/mono/; revision=127280
Backport of r127232.
* marshal.c (emit_marshal_boolean): Add null checks to the new
native->managed marshalling code. Fixes#476247.
svn path=/branches/mono-2-4/mono/; revision=127233
Backport of r125348.
* marshal.c (mono_marshal_get_runtime_invoke): Disable sharing for
methods taking vtype/byref arguments, to fix yet another bug caused by
the sharing of runtime invoke wrappers. Partly fixes#471259.
svn path=/branches/mono-2-4/mono/; revision=127080
Backport of r125349.
* marshal.c (mono_marshal_free_dynamic_wrappers): New function for
freeing wrappers of dynamic methods.
* loader.c (mono_free_method): Call it. Fixes#463323.
svn path=/branches/mono-2-4/mono/; revision=127076
Backport of r125349.
* marshal.c (mono_marshal_free_dynamic_wrappers): New function for
freeing wrappers of dynamic methods.
* loader.c (mono_free_method): Call it. Fixes#463323.
svn path=/branches/mono-2-4/mono/; revision=127075
Backport of r126958.
* reflection.c (clear_cached_object): New helper function.
(mono_method_clear_object): New function to clear the cached reflection
objects for a dynamic method.
* object.c (mono_runtime_free_method): Call mono_method_clear_object ().
Partly fixes # 463323.
svn path=/branches/mono-2-4/mono/; revision=127074
Backport of r126983 + r127069.
* ssa.c (visit_inst): Fix a crash if the instruction following a switch
was optimized away.
Backport of r126980.
* mini-x86.c (mono_arch_get_vcall_slot): Handle yet another
code sequence which matches a non-virtual call. Fixes#472654.
Backport of r124419.
* mini-amd64.c (mono_arch_get_vcall_slot): Handle yet another
code sequence which matches a non-virtual call.
svn path=/branches/mono-2-4/mono/; revision=127071
2009-02-16 Rodrigo Kumpera <[email protected]>
Backport of r127032.
* loader.c (method_from_memberref): Don't abort if the array
method is not found. A regular loader failure is more informative
and correct.
Fixes#474271.
svn path=/branches/mono-2-4/mono/; revision=127061
Backport of r125679.
Contributed under the terms of the MIT/X11 license by Steven
Munroe <[email protected]>.
* mini-ppc.c (mono_arch_output_basic_block): Generate better code
for LOADI4_MEMBASE. Use addi instead of addic if it's not
necessary.
svn path=/branches/mono-2-4/mono/; revision=127059
Backport of r125676.
Contributed under the terms of the MIT/X11 license by Steven
Munroe <[email protected]>.
* exceptions-ppc.c (mono_arch_get_restore_context): Code size
comparison fix.
* tramp-ppc.c (mono_arch_create_generic_class_init_trampoline):
The trampoline can be longer on PPC64.
svn path=/branches/mono-2-4/mono/; revision=127056
Backport of r125672.
Contributed under the terms of the MIT/X11 license by Steven
Munroe <[email protected]>.
* mini-ppc.c: Compiler warning fixes and trivial code
simplifications.
svn path=/branches/mono-2-4/mono/; revision=127055
Backport of r125443.
Contributed under the terms of the MIT/X11 license by Steven
Munroe <[email protected]>.
* ppc/ppc-codegen.h: Make operand order and case consistent
(assembler order) for ppc_load_reg_update, ppc_load_multiple_regs,
ppc_store_multiple_regs, ppc_lwz, ppc_lhz, ppc_lbz,
ppc_stw,ppc_sth, ppc_stb, ppc_stwu, ppc_lbzu, ppc_lfdu, ppc_lfsu,
ppc_lfsux, ppc_lfsx, ppc_lha, ppc_lhau, ppc_lhzu, ppc_lmw,
ppc_lwzu, ppc_stbu, ppc_stfdu, ppc_stfsu, ppc_sthu, ppc_stmw. Use
"i" or "ui" instead of "d" for immediated operands to immediate
arthimetic and logical instructions in macros ppc_addi, ppc_addis,
ppc_ori, ppc_addic, ppc_addicd, ppc_andid, ppc_andisd.
[__mono_ppc64__]: Make operand order and case consistent
(assembler order) for ppc_load_multiple_regs,
ppc_store_multiple_regs. Simplify the DS form and make them
consistent with D forms for ppc_load_reg, ppc_load_reg_update,
ppc_store_reg, ppc_store_reg_update. ppc_ld, ppc_lwa, ppc_ldu,
ppc_std, ppc_stdu. Define ppc_lwax and ppc_lwaux.
2009-02-16 Mark Probst <[email protected]>
Backport of r125443.
Contributed under the terms of the MIT/X11 license by Steven
Munroe <[email protected]>.
* exceptions-ppc.c (restore_regs_from_context): Correct operand
order (offset then base reg) for ppc_load_multiple_regs.
(emit_save_saved_regs) Correct operand order for
ppc_store_multiple_regs.
(mono_arch_get_call_filter): Correct operand order for
ppc_load_multiple_regs.
* mini-ppc.c (emit_memcpy): Fix operand order for
ppc_load_reg_update and ppc_store_reg_update.
(mono_arch_output_basic_block): Correct operand order for ppc_lha.
(mono_arch_emit_epilog): Correct operand order for
ppc_load_multiple_regs.
* tramp-ppc.c (mono_arch_create_trampoline_code): Correct operand
order for ppc_store_multiple_regs and ppc_load_multiple_regs.
svn path=/branches/mono-2-4/mono/; revision=127054
A fix for bug #475965
* generics.cs: Check generic parameter type after extracting from
Expression<T>.
svn path=/branches/mono-2-4/mcs/; revision=127041
Backport of r126897.
* method-to-ir.c (mini_emit_ldelema_1_ins): If the array index is a long,
convert it to an in32. Fixes#475859.
* arrays.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=126900
Backport of r126737.
* mini-s390x.c (mono_arch_output_basic_block): Fix the shift amounts in
OP_LCONV_TO_U2.
* basic-long.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=126742
Backport of r126738. This is a safer variant of the
trunk for the 2.4 branch. The default in emit_marshal_boolean
for this version is I1.
* object-internals.h : Fixing a typo in the
MonoReflectionComVisibleAttribute struct.
* marshal.c (cominterop_com_visible): Check the implemented
interfaces for ComImport.
* marshal.c (cominterop_get_native_wrapper_adjusted): For COM calls
assume that bools should be treated as VARIANTBOOLs.
* marshal.c (emit_marshal_boolean): Adding cases for
MARSHAL_ACTION_MANAGED_CONV_IN and MARSHAL_ACTION_MANAGED_CONV_OUT.
* marshal.c (mono_marshal_emit_managed_wrapper): Adding calls to
emit_marshal MARSHAL_ACTION_MANAGED_CONV_IN and OUT for bools.
* marshal.c (cominterop_get_ccw): For COM calls assume that bools
should be treated as VARIANTBOOLs.
Code is contributed under MIT/X11 license.
svn path=/branches/mono-2-4/mono/; revision=126740
Backport of r126737.
* mini-s390x.c (mono_arch_output_basic_block): Fix the shift amounts in
OP_LCONV_TO_U2.
* basic-long.cs: Add a test.
svn path=/branches/mono-2-4/mono/; revision=126739
* generic-sharing.c: Fixed a locking bug: The loader lock has to
be taken before the templates lock. Fixes part of #473150.
svn path=/branches/mono-2-4/mono/; revision=126715
* io.c: EXDEV when moving directories fails now without creating a
file in the destination.
Fixes bug #326983.
svn path=/branches/mono-2-4/mono/; revision=126691
Backport of r126668.
* ssa.c (fold_ins): Use MONO_IS_JUMP_TABLE () and MONO_JUMP_TABLE_FROM_INS ()
for processing jump tables. Fixes#473787.
svn path=/branches/mono-2-4/mono/; revision=126669
Backport of r126631.
* class.c, class-internals.h: mono_method_get_context_general()
combines the functionality of mono_method_get_context() and
mini_method_get_context().
* generic-sharing.c, domain-internals.h:
mono_method_construct_object_context() and
mono_domain_lookup_shared_generic() moved from mini.
* icall.c (ves_icall_InternalInvoke): Handle the case where the
method doesn't have the correct instantiation because it's shared
generic code. Fixes#473999.
2009-02-11 Mark Probst <[email protected]>
Backport of r126631.
* mini-generic-sharing.c: mini_method_get_context() just calls
mono_method_get_context_general() now.
* mini.c, mini.h: Moved get_object_generic_inst(),
construct_object_context_for_method() and
mono_domain_lookup_shared_generic() to metadata/generic-sharing.c.
2009-02-11 Mark Probst <[email protected]>
Backport of r126631.
* bug-473999.2.cs: New test.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=126635
Backport of 126604.
* branch-opts.c (mono_if_conversion): Handle the case where the merged
basic block fell through to its successor bblock without a branch. Fixes
#474718.
* iltests.il.in: Add a test.
svn path=/branches/mono-2-4/mono/; revision=126606
Backport of r126596.
* socket-io.c (ves_icall_System_Net_Sockets_Socket_Accept_internal):
For Win32, add additional break conditions for accept.
Code is contributed under MIT/X11 license.
svn path=/branches/mono-2-4/mono/; revision=126598
Backport of r126467.
* mini-x86.c (mono_arch_context_get_int_reg): Handle all registers
individually. Fixes#473482.
2009-02-10 Mark Probst <[email protected]>
Backport of r126467.
* bug-473482.2.cs: New test.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=126469
* AppDomain.cs: this fixes the remoting tests.
Zoltan found out that there was a domain improperly using shadow
copy.
svn path=/branches/mono-2-4/mcs/; revision=126431
* Dns.cs: BeginGetHostAddresses - renamed argument to match MS,
reject "any" IP addresses. BeginGetHostEntry - renamed argument
to match MS, reject "any" IP addresses. GetHostEntry - reject
"any" IP addresses. GetHostAddresses - reject "any" IP addresses.
GetHostByName - use "hostName" as paramname in ANE.
svn path=/branches/mono-2-4/mcs/; revision=126295
* HttpClientTransportSink.cs: if we get an WebException that does not
have a response, dispatch it to the sink.
svn path=/branches/mono-2-4/mcs/; revision=126289
* DataGridView.cs: End or if end fails then cancel the current edit
operation before clearing the data source.
svn path=/branches/mono-2-4/mcs/; revision=126215
* socket-io.c: when requesting all the local ips, if there are no
interfaces up and running, MS returns 127.0.0.1.
svn path=/branches/mono-2-4/mono/; revision=126204
* Dns.cs: empty string for host (also 0.0.0.0) is just passed to the
runtime, which will then retrieve the local IP addresses. Fixes bug
#386637 part 2/2.
svn path=/branches/mono-2-4/mcs/; revision=126163
* StreamReader.cs: when a LF ends a decoded buffer and is not followed
by a CR in the next decoded buffer, we didn't flush the string.
Fixes bug #445326.
svn path=/branches/mono-2-4/mcs/; revision=126132
* FtpWebRequest.cs: some servers have a comment after the directory
name. Fixes bugs #471149 and #471216.
svn path=/branches/mono-2-4/mcs/; revision=126102
* WebConnectionStream.cs: set the content length to 0 when the
response is not supposed to have any content.
svn path=/branches/mono-2-4/mcs/; revision=126091
Backport of r126054.
* marshal.c (get_runtime_invoke_type): Avoid sharing enum types since they
need to be boxed.
svn path=/branches/mono-2-4/mono/; revision=126055
Backport of r125887.
* object.c (mono_object_get_virtual_method): Properly inflate
generic methods. Fixes#472692.
2009-02-05 Mark Probst <[email protected]>
Backport of r125887.
* jit-icalls.c (mono_helper_compile_generic_method): Don't inflate
the method we get from mono_object_get_virtual_method() because
that function does it properly, now.
2009-02-05 Mark Probst <[email protected]>
Backport of r125887.
* bug-472692.2.cs: New test.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=125910
* DataGridViewRowCollection.cs, DataGridView.cs: Fix row insertation:
- Use ArrayList.Insert instead of the Item property so that the item
is actually inserted and not an existing item replaced.
- Call DataGridView.OnRowsAddedInternal and drop internal from
OnRowsAdded for binary compitability. This also fixes several
redrawing issues.
[Fixes bug #472968]
svn path=/branches/mono-2-4/mcs/; revision=125901
Backport of r125849.
* class.c (mono_class_create_from_typedef): The CLR supports SystemF
recursive types such as List<T>:Cons<T,List<T>> so when doing the lookup
for the parent type, the created type must be ready to be used on a generic
instantiation.
We fill this_arg/byval_arg if the parent is a generic instance to make sure
we won't have duplicated entries in generic_inst_cache.
Fixes#469553.
svn path=/branches/mono-2-4/mono/; revision=125851
Backport of r125839.
* mini-exceptions.c (ves_icall_get_frame_info): Account for the
fact that mono_find_jit_info() sometimes returns the context
corresponding to the jit info in new_ctx. Fixes#472600.
2009-02-05 Mark Probst <[email protected]>
Backport of r125839.
* bug-472600.2.cs: New test.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=125850
Backport of 125697.
* mini-exceptions.c (mono_setup_altstack): Use a more reasonable altstack
size on systems with 64k pages. Fixes#471389.
svn path=/branches/mono-2-4/mono/; revision=125698
* WebConnection.cs:
* HttpWebRequest.cs: calling Abort is safe now if the request has been
read entirely.
svn path=/branches/mono-2-4/mcs/; revision=125635
Backport of r125603.
* verify.c (is_compatible_boxed_valuetype): When checking if the boxed
valuetype is compatible with target type, check by inheritance as a
VT is not really compatible with System.ValueType, for example.
* verify.c (do_invoke_method): Improve error message.
* verify.c (do_box_value): If boxing a nullable, use the type argument
on stack instead.
* verify.c (do_newobj): Improve error message.
Fixes#469549.
2009-02-03 Rodrigo Kumpera <[email protected]>
In tests/verifier:
Backport of r125604.
* valid_boxed_vt_compatible_with_sys_vt_or_sys_enum.il:
Regression test for #469549.
2009-02-03 Rodrigo Kumpera <[email protected]>
svn path=/branches/mono-2-4/mono/; revision=125606
* DataGridViewRowCollection.cs, DataGridView.cs: Move row completion
code in the row collection code, so that the completion happens before
the CollectionChanged event, also better encapsulation.
[Fixes bug #471987]
svn path=/branches/mono-2-4/mcs/; revision=125587
2009-02-03 Rodrigo Kumpera <[email protected]>
Backport of r125581.
* verify.c (mono_delegate_signature_equal): Make it possible to check
first-arg-bound delegates to static method.
* verify.c (verify_delegate_compatibility): Correctly verify delegates to
static methods with the first arg bound.
Fixes#469529.
In tests/verifier:
Backport of r125582.
* unverifiable_delegate_with_bad_bound_first_arg_to_static_method.il:
* mono/tests/verifier/valid_ldfnt_delegates_of_static_methods.il:
Regression test for #469529.
2009-02-03 Rodrigo Kumpera <[email protected]>
svn path=/branches/mono-2-4/mono/; revision=125586
Backport of r125539.
* verify.c: Added stack_slot_full_name to provide decent and more meanfull
errors.
* verify.c (is_compatible_boxed_valuetype): Be less restrictive when not
under strict mode. Any type, when boxed can be seen as a reference type.
Fixes#469528.
2009-02-03 Rodrigo Kumpera <[email protected]>
In tests/verifier:
2009-02-03 Rodrigo Kumpera <[email protected]>
Backport of r125540.
* valid_valuetype_boxed_types_are_merge_compatible.il:
Regression test for #469528.
svn path=/branches/mono-2-4/mono/; revision=125561
* CommittableTransaction.cs (CommitCallback): Handle the case
where the callback is invoked before BeginCommit ends due to the
async call ending synchronously.
svn path=/branches/mono-2-4/mcs/; revision=125490
2009-02-03 Rodrigo Kumpera <[email protected]>
Backport of r125458.
* object.h: The lower bound of an array is a signed integer value.
Introduce mono_array_lower_bound_t typedef. It should be used instead of
gint32 as under MONO_BIG_ARRAYS it will be a gint64.
* icall.c: Cast MonoArrayBounds::length to a signed value so correctly
calculate the upper bound.
Fixes#471252.
In mini:
2009-02-03 Rodrigo Kumpera <[email protected]>
Backport of r125459.
* arrays.cs: Test for Get/SetValue of array with negate lower bounds.
svn path=/branches/mono-2-4/mono/; revision=125461
* DataGridView.cs: When editing is finished do not remove the editing
row, because it has already become a real one. Instead add a new one.
[Fixes bug #471754]
svn path=/branches/mono-2-4/mcs/; revision=125445
Backport of r125402.
* icall.c (type_from_name): Ignore reflection frames to find out the real caller.
Fixes#471255.
svn path=/branches/mono-2-4/mono/; revision=125404
Backport of r125388.
* generic-sharing.c (lookup_or_register_other_info): Make sure the
loader lock is not taken while the templates lock is held. Fixes
#471089.
svn path=/branches/mono-2-4/mono/; revision=125391
* ToolBar.cs: Add new UIAPerformClick method to be called by
UIAutomationWinforms when someone calls Invoke() on the
ToolBarButtonProvider. (Backport of r125354.) r: jpobst
svn path=/branches/mono-2-4/mcs/; revision=125358
* DataGridView.cs, DataGridViewColumnCollection.cs: Ensure that the
binding is cleared prior to setting it to null. Fixes a regression
causing exceptions when the DataSource is set to null and then set
again to a data source.
svn path=/branches/mono-2-4/mcs/; revision=125272
Backport of r125172, r125205 and r125206
* basic-calls.cs: Test for the weird crash found on arm.
* cpu-arm.md: Increase the size of storer8_membase_reg and
loadr8_membase_reg to 24 bytes to accomodate the extra add.
* mini-arm.c (mono_arch_output_basic_block): Under FPA, when emitting
OP_STORER8_MEMBASE_REG and OP_LOADR8_MEMBASE_REG, add the original
reg to LR otherwise we'll be loading/storing from just the offset.
* cpu-arm.md: Increase the size of storer8_membase_reg to 20 bytes
as it might use decomposed ops.
svn path=/branches/mono-2-4/mono/; revision=125207
Backport of r125077-79
* exceptions-arm.c (mono_arch_find_jit_info): The frame layout on arm have
separate frame and stack pointers, so we must use FP to find the register
spill area.
The FP reg is retrieved from the MonoContext::regs array.
* mini-arm.c (mono_arch_output_basic_block): Emit two cond ops for OP_FBGE
as FPA requires it.
* mini-arm.c (mono_arch_emit_setret): Emit OP_FMOVE for methods that
return R4 and R8 when not running under softfloat.
Fixes basic-calls.exe
svn path=/branches/mono-2-4/mono/; revision=125116
A fix for bug #470767
* statement.cs: Introduced BlockScopeExpression, needed when
expression tree conversion has to emit scope variables.
svn path=/branches/mono-2-4/mcs/; revision=125096
* HttpApplicationFactory.cs: fix check that avoids lock. Keep one
HttpApplication instance ready to be returned in an instance variable
to avoid a few locks.
svn path=/branches/mono-2-4/mcs/; revision=124949
* XplatUIX11.cs: We should use utf8 handling clipboard transference
with other x11 applications, and use utf16 when handling clipboard
data in the class library. Update the related points as well.
Fixes#468683.
svn path=/branches/mono-2-4/mcs/; revision=124920
* DataGridViewCell.cs: Format strings according to the supplied
CellStyle.Format.
[Fixes bug #470384]
svn path=/branches/mono-2-4/mcs/; revision=124878
Backport of r124869.
* Uri.cs (IsWellFormedUriString): Changing IsWellFormedUriString
to not throw an exception but return false instead.
Contributed under MIT/X11 license.
svn path=/branches/mono-2-4/mcs/; revision=124870
* DataGridView.cs: Reset the hover cell if it gets moved due to row(s)
addition or removal. Fixes multiple crashes in OnMouseMove.
svn path=/branches/mono-2-4/mcs/; revision=124868
* TreeNode.cs: NextVisibleNode and PrevVisibleNode properties don't
take into account the fact that OpenTreeNodeEnumerator needs to call
MoveNext/MovePrevious to actually put the passed node as the one
retrieved in Current. This way this property should work as really
expected in .net.
Fixes part of #467225.
svn path=/branches/mono-2-4/mcs/; revision=124802
* TreeView.cs: When calculating the scrollbars, don't use
TreeNode.Bounds, since it still can have the values of the previous
-and now invalid- layout -which depends on TreeView.skipped_nodes, and
could not have been updated as well-, and use the actual number of
visible number of nodes to compute the height needed to contain all
the nodes. Also reset the value of vbar to 0 when disabled - this way
we make sure that, when re-enabled, it will update the visible area of
the treeview, even if the previous value before disabling it is the
same as now. Finally don't do anything for the vbar.ValueChanged
handler - for the case wheer we manually set the value but don't the
vbar is disabled already.
Fixes part of #467225.
svn path=/branches/mono-2-4/mcs/; revision=124801
* TreeView.cs: In CollapseAll, set vbar to the maximum value, instead
of trying to set as top node the highest parent of the previous
top node. Moving to the bottom of the TreeView after a call
to CollapseAll is exactly what .net does. This should avoid some
nasty issue when CollapseAll is called and we don't need the
vertical scroll bar.
svn path=/branches/mono-2-4/mcs/; revision=124800
Backport of r124712.
* method-to-ir.c (emit_stloc_ir): Only apply the reg-reg move
optimization if the top of stack is the last instruction in the
bblock. Otherwise it might have been used after its definition.
Fixes#469742.
2009-01-27 Mark Probst <[email protected]>
Backport of r124712.
* bug469742.2.il: New test.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=124715
* Backport of r123987.
* method-to-ir.c (method-to-ir.c): Add support for the constrained prefix
on type variables in AOTed code.
svn path=/branches/mono-2-4/mono/; revision=124691
* XplatUIX11.cs: Fire Timer.Tick even if there is no MainForm for the
current context.
[Fixes bug #469239]
svn path=/branches/mono-2-4/mcs/; revision=124669
* WebBrowser.cs: fix initial value of ScrollbarsEnabled, so they
won't be disabled by default.
[Backported from r124596, fixes#468690]
svn path=/branches/mono-2-4/mcs/; revision=124615
Backport of r124582.
* mini-s390x.c: Remove a stray declaration of emit_sig_cookie () to fix
the s390x build.
svn path=/branches/mono-2-4/mono/; revision=124583
* DataGridView.cs: Do not be too smart about selecting the first cell
when the first row is added as this is not what MS does. Fixes the
failing unit tests.
svn path=/branches/mono-2-4/mcs/; revision=124566
A fix for bug #469019
* anonymous.cs: Use all parent type parameters when instantiating
nested generic storey.
svn path=/branches/mono-2-4/mcs/; revision=124533
A fix for bug #469244
* cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
instance inside a conditional expression.
svn path=/branches/mono-2-4/mcs/; revision=124489
* HttpWebRequest.cs: added locking in SetResponseData for the case
when we get an error response before BeginGetResponse has been
called.
svn path=/branches/mono-2-4/mcs/; revision=124453
* HttpResponse.cs: make sure config is not null here.
* HttpApplication.cs: add a timer (-d:PIPELINE_TIMER) for the pipeline.
Handle timeouts for OutputPage() too.
svn path=/branches/mono-2-4/mcs/; revision=124396
* HttpApplicationFactory.cs: set/reset the context for the application
when creating/disposing. Dispose() out of the lock.
svn path=/branches/mono-2-4/mcs/; revision=124394
* BuildManager.cs: if dependencyCache already contains the virtual
path, replace its corresponding file set (in AddToCache). This can
happen only if the requested virtual path compilation resulted in
errors and the compilation has been retried. Fixes bug #46268
svn path=/branches/mono-2-4/mcs/; revision=124326
Backport of r124022 and r124301.
* metadata.c (mono_metadata_generic_param_equal): Owner as well as
image must match. Only compare the image if the owner is NULL.
Fixes the AOT failures.
svn path=/branches/mono-2-4/mono/; revision=124305
Backport of r124266.
* metadata.c (mono_metadata_load_generic_params): Initialize the
MonoGenericParam structure using memset so the image field is initialized
as well.
svn path=/branches/mono-2-4/mono/; revision=124268
Backport of r124260.
* Stopwatch.cs: Reorder the calculations in Elapsed and ElapsedMilliseconds
to avoid overflow. Fixes#468570. Patch by Yoni Shalom <[email protected]>.
svn path=/branches/mono-2-4/mcs/; revision=124262
Backport of r124246.
* mini-exceptions.c (ves_icall_get_frame_info): Fetch the generic
info from the (correct) context.
2009-01-22 Mark Probst <[email protected]>
Backport of r124246.
* generic-stack-traces2.2.cs: Another generic sharing test for
stack traces.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=124249
Backport of r124059.
* appdomain-unload-callback.cs: New test for the AppDomain::DomainUnload
deadlock.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=124072
Backport of r124068.
* appdomain.c (mono_domain_unload): Change the InterlockedIncrement to
a plain store.
2009-01-21 Rodrigo Kumpera <[email protected]>
Backport of r124058.
* domain-internals.h: Add new appdomain state MONO_APPDOMAIN_UNLOADING_START
which signals that the unloading has started but all appdomain services must
remain operational.
* appdomain.c (mono_domain_unload): The initial state for unloading now
is unloading_start and we switch to unloading after the managed call to
AppDomain::DomainUnload has finished.
The new unloading state has to be created because managed code in the
DomainUnload event can depend on things like the threadpool still working.
The domain must remain fully functional while the event executes.
This shown as an issue due to Process::WaitForExit, which waits for
async reads of stdout and stderr to complete. Since those are processed
in the threadpool the code deadlocks because the DomainUnload callback
waits for the async read finished event, which should have been set by a
threadpool job but has been discarded due to the domain been in unload
state.
svn path=/branches/mono-2-4/mono/; revision=124071
Backport of r124065.
* class.c (mono_class_setup_vtable_general): In the generic instance
optimization, set method->slot for abstract virtual methods. Fixes part of
#467834.
svn path=/branches/mono-2-4/mono/; revision=124067
Backport or r124060.
* mini.h
(MonoCompile): Added `disable_deadce_vars' to disable removing
unused variables.
* mini.c
(mini_method_compile): Set `cfg->disable_deadce_vars' when running
inside the debugger.
* liveness.c (mono_analyze_liveness): Don't remove any unused
variables if `cfg->disable_deadce_vars' is set.
svn path=/branches/mono-2-4/mono/; revision=124061
UIACheckChanged, UIARadioCheckChanged, UIAEnabledChanged, and
UIATextChanged events.
* Managed.Windows.Forms/System.Windows.Forms/Form.cs: Add UIAMenuChanged
event.
* Managed.Windows.Forms/System.Windows.Forms/Menu.cs:
* Managed.Windows.Forms/System.Windows.Forms/MenuAPI.cs: Note which
internal APIs are being used by UIA.
svn path=/branches/mono-2-4/mcs/; revision=124055
Backport of r124028.
* method-to-ir.c: Only apply exception constructor optimization if
the the method actually belongs to an exception class. Fixes
#467456.
2009-01-21 Mark Probst <[email protected]>
Backport of r124028.
* bug-467456.cs: New test case.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=124031
Backport of r124022.
* metadata.c (mono_metadata_generic_param_equal): Owner as well as
image must match.
2009-01-21 Mark Probst <[email protected]>
Backport of r124022.
* generic-unloading.2.cs, generic-unloading-sub.2.cs: Test case
for unloading images whose MonoGenericInst's are still in use.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=124025
Backport of r123989.
* mini-trampolines.c (mono_delegate_trampoline): Put back the previous
change inside a #ifdef __mono_ppc64__.
svn path=/branches/mono-2-4/mono/; revision=123990
Backport of r123958.
* reflection.c (resolve_object): For fields, inflate the class and
then get the field in the inflated class.
svn path=/branches/mono-2-4/mono/; revision=123964
Backport of r123917.
* method-to-ir.c: Force the vtable variable in shared generic code
for the case that they might show up on a stack trace where they
are needed.
* mini-exceptions.c: Save and use generic sharing info as well as
IP in stack traces to resolve shared generic instantiations.
2009-01-20 Mark Probst <[email protected]>
Backport of r123917.
* object-internals.h (struct _MonoException): Added a comment
explaining the new use of trace_ips.
2009-01-20 Mark Probst <[email protected]>
Backport of r123917.
* generic-stack-traces.2.cs: Generic sharing test for stack
traces.
* Makefile.am: Test added.
svn path=/branches/mono-2-4/mono/; revision=123946
Backport of r123914.
* mini-trampolines.c (mono_delegate_trampoline): Revert the change which
added a mono_get_addr_from_ftnptr () as it breaks the ia64 build.
svn path=/branches/mono-2-4/mono/; revision=123927
AC_ARG_WITH(large-heap, [ --with-large-heap=yes,no Enable support for GC heaps larger than 3GB (defaults to no)], [large_heap=$withval], [large_heap=no])
AC_ARG_WITH(large-heap, [ --with-large-heap=yes,no Enable support for GC heaps larger than 3GB], [large_heap=$withval], [large_heap=no])
if test "x$large_heap" = "xyes"; then
echo "FOO"
CPPFLAGS="$CPPFLAGS -DLARGE_CONFIG"
@@ -858,7 +808,7 @@ if test x$platform_win32 = xno; then
AC_MSG_CHECKING([if big-arrays are to be enabled])
AC_ARG_ENABLE(big-arrays, [ --enable-big-arrays Enable the allocation and indexing of arrays greater than Int32.MaxValue], enable_big_arrays=$enableval, enable_big_arrays=no)
AC_ARG_ENABLE(big-arrays, [ --enable-big-arrays Enable the allocation and indexing of arrays greater than Int32.MaxValue], enable_big_arrays=$enableval, enable_big_arrays=no)
if test "x$enable_big_arrays" = "xyes" ; then
if test "x$ac_cv_sizeof_void_p" = "x8"; then
AC_DEFINE(MONO_BIG_ARRAYS,1,[Enable the allocation and indexing of arrays greater than Int32.MaxValue])
AC_ARG_WITH(malloc_mempools,[ --with-malloc-mempools=yes,no Use malloc for each single mempool allocation (only for runtime debugging, defaults to no)],[
AC_ARG_WITH(malloc_mempools,[ --with-malloc-mempools=yes,no Use malloc for each single mempool allocation (only for runtime debugging, defaults to NO)],[
if test x$with_malloc_mempools = xyes; then
MALLOC_MEMPOOLS=yes
AC_DEFINE(USE_MALLOC_FOR_MEMPOOLS,1,[Use malloc for each single mempool allocation])
fi
])
DISABLE_MCS_DOCS=no
AC_ARG_WITH(mcs_docs,[ --with-mcs-docs=yes,no If you want to build the documentation under mcs (defaults to yes)],[
if test x$with_mcs_docs != xyes; then
DISABLE_MCS_DOCS=yes
fi
])
dnl
dnl Consistency settings
dnl
if test x$cross_compiling = xyes -o x$enable_mcs_build = xno; then
DISABLE_MCS_DOCS=yes
docs_dir=""
else
docs_dir=docs
fi
AC_SUBST(docs_dir)
AM_CONDITIONAL(HAVE_OPROFILE, test x$OPROFILE = xyes)
AC_CONFIG_COMMANDS([quiet], [for i in `find mono libgc support -name Makefile.in | sed -e 's/Makefile.in/Makefile/g'`; do if test -f $i; then $srcdir/scripts/patch-quiet.sh $i; fi; done], [shell=$SHELL])
/// <param name="useNames">If set to false, the function will not use known entities name. Default is true.</param>
/// <param name="entitizeQuotAmpAndLtGt">If set to true, the [quote], [ampersand], [lower than] and [greather than] characters will be entitized.</param>
/// Always returns string.Empty in the case of HtmlNavigator implementation.
/// </summary>
publicoverridestringXmlLang
{
get
{
InternalTrace(null);
return_nametable.GetOrAdd(string.Empty);
}
}
#endregion
#regionPublicMethods
/// <summary>
/// Creates a new HtmlNavigator positioned at the same node as this HtmlNavigator.
/// </summary>
/// <returns>A new HtmlNavigator object positioned at the same node as the original HtmlNavigator.</returns>
publicoverrideXPathNavigatorClone()
{
InternalTrace(null);
returnnewHtmlNodeNavigator(this);
}
/// <summary>
/// Gets the value of the HTML attribute with the specified LocalName and NamespaceURI.
/// </summary>
/// <param name="localName">The local name of the HTML attribute.</param>
/// <param name="namespaceURI">The namespace URI of the attribute. Unsupported with the HtmlNavigator implementation.</param>
/// <returns>The value of the specified HTML attribute. String.Empty or null if a matching attribute is not found or if the navigator is not positioned on an element node.</returns>
/// Moves to the first sibling of the current node.
/// </summary>
/// <returns>true if the navigator is successful moving to the first sibling node, false if there is no first sibling or if the navigator is currently positioned on an attribute node.</returns>
publicoverrideboolMoveToFirst()
{
if(_currentnode.ParentNode==null)
{
InternalTrace(">false");
returnfalse;
}
if(_currentnode.ParentNode.FirstChild==null)
{
InternalTrace(">false");
returnfalse;
}
_currentnode=_currentnode.ParentNode.FirstChild;
InternalTrace(">true");
returntrue;
}
/// <summary>
/// Moves to the first HTML attribute.
/// </summary>
/// <returns>true if the navigator is successful moving to the first HTML attribute, otherwise, false.</returns>
publicoverrideboolMoveToFirstAttribute()
{
if(!HasAttributes)
{
InternalTrace(">false");
returnfalse;
}
_attindex=0;
InternalTrace(">true");
returntrue;
}
/// <summary>
/// Moves to the first child of the current node.
/// </summary>
/// <returns>true if there is a first child node, otherwise false.</returns>
publicoverrideboolMoveToFirstChild()
{
if(!_currentnode.HasChildNodes)
{
InternalTrace(">false");
returnfalse;
}
_currentnode=_currentnode.ChildNodes[0];
InternalTrace(">true");
returntrue;
}
/// <summary>
/// Moves the XPathNavigator to the first namespace node of the current element.
/// Always returns false for the HtmlNavigator implementation.
/// </summary>
/// <param name="scope">An XPathNamespaceScope value describing the namespace scope.</param>
/// <returns>Always returns false for the HtmlNavigator implementation.</returns>
/// Moves to the node that has an attribute of type ID whose value matches the specified string.
/// </summary>
/// <param name="id">A string representing the ID value of the node to which you want to move. This argument does not need to be atomized.</param>
/// <returns>true if the move was successful, otherwise false. If false, the position of the navigator is unchanged.</returns>
publicoverrideboolMoveToId(stringid)
{
InternalTrace("id="+id);
HtmlNodenode=_doc.GetElementbyId(id);
if(node==null)
{
InternalTrace(">false");
returnfalse;
}
_currentnode=node;
InternalTrace(">true");
returntrue;
}
/// <summary>
/// Moves the XPathNavigator to the namespace node with the specified local name.
/// Always returns false for the HtmlNavigator implementation.
/// </summary>
/// <param name="name">The local name of the namespace node.</param>
/// <returns>Always returns false for the HtmlNavigator implementation.</returns>
publicoverrideboolMoveToNamespace(stringname)
{
InternalTrace("name="+name);
returnfalse;
}
/// <summary>
/// Moves to the next sibling of the current node.
/// </summary>
/// <returns>true if the navigator is successful moving to the next sibling node, false if there are no more siblings or if the navigator is currently positioned on an attribute node. If false, the position of the navigator is unchanged.</returns>
/// <returns>true if there is a parent node, otherwise false.</returns>
publicoverrideboolMoveToParent()
{
if(_currentnode.ParentNode==null)
{
InternalTrace(">false");
returnfalse;
}
_currentnode=_currentnode.ParentNode;
InternalTrace(">true");
returntrue;
}
/// <summary>
/// Moves to the previous sibling of the current node.
/// </summary>
/// <returns>true if the navigator is successful moving to the previous sibling node, false if there is no previous sibling or if the navigator is currently positioned on an attribute node.</returns>
publicoverrideboolMoveToPrevious()
{
if(_currentnode.PreviousSibling==null)
{
InternalTrace(">false");
returnfalse;
}
_currentnode=_currentnode.PreviousSibling;
InternalTrace(">true");
returntrue;
}
/// <summary>
/// Moves to the root node to which the current node belongs.
This license governs use of the accompanying software. If you use the software, you accept this license. If you do not accept the license, do not use the software.
1. Definitions
The terms “reproduce,” “reproduction,” “derivative works,” and “distribution” have the same meaning here as under U.S. copyright law.
A “contribution” is the original software, or any additions or changes to the software.
A “contributor” is any person that distributes its contribution under this license.
“Licensed patents” are a contributor’s patent claims that read directly on its contribution.
2. Grant of Rights
(A) Copyright Grant- Subject to the terms of this license, including the license conditions and limitations in section 3, each contributor grants you a non-exclusive, worldwide, royalty-free copyright license to reproduce its contribution, prepare derivative works of its contribution, and distribute its contribution or any derivative works that you create.
(B) Patent Grant- Subject to the terms of this license, including the license conditions and limitations in section 3, each contributor grants you a non-exclusive, worldwide, royalty-free license under its licensed patents to make, have made, use, sell, offer for sale, import, and/or otherwise dispose of its contribution in the software or derivative works of the contribution in the software.
3. Conditions and Limitations
(A) No Trademark License- This license does not grant you rights to use any contributors’ name, logo, or trademarks.
(B) If you bring a patent claim against any contributor over patents that you claim are infringed by the software, your patent license from such contributor to the software ends automatically.
(C) If you distribute any portion of the software, you must retain all copyright, patent, trademark, and attribution notices that are present in the software.
(D) If you distribute any portion of the software in source code form, you may do so only under this license by including a complete copy of this license with your distribution. If you distribute any portion of the software in compiled or object code form, you may only do so under a license that complies with this license.
(E) The software is licensed “as-is.” You bear the risk of using it. The contributors give no express warranties, guarantees or conditions. You may have additional consumer rights under your local laws which this license cannot change. To the extent permitted under your local laws, the contributors exclude the implied warranties of merchantability, fitness for a particular purpose and non-infringement.
(F) If you distribute the software or derivative works with programs you develop, you agree to indemnify, defend, and hold harmless all contributors from any claims, including attorneys’ fees, related to the distribution or use of your programs. For clarity, you have no such obligations to a contributor for any claims based solely on the unmodified contributions of that contributor.
(G) If you make any additions or changes to the original software, you may only distribute them under a new namespace. In addition, you will clearly identify your changes or additions as your own.
/// Advances the enumerator to the next element of the collection.
/// </summary>
/// <returns>true if the enumerator was successfully advanced to the next element; false if the enumerator has passed the end of the collection.</returns>
publicboolMoveNext()
{
_index++;
return(_index<_items.Count);
}
/// <summary>
/// Sets the enumerator to its initial position, which is before the first element in the collection.
Read-only data is data which is not modified after creation, like the
actual binary metadata in the metadata tables.
There are three kinds of threads with regards to read-only data:
- readers
- the creator of the data
- the destroyer of the data
Most threads are readers.
- synchronization between readers is not neccesary
- synchronization between the writers is done using locks.
- synchronization between the readers and the creator is done by not exposing
the data to readers before it is fully constructed.
- synchronization between the readers and the destroyer: TBD.
1.2 Deadlock prevention plan
----------------------------
Hold locks for the shortest time possible. Avoid calling functions inside
locks which might obtain global locks (i.e. locks known outside this module).
1.3 Locks
----------
1.3.1 Simple locks
------------------
There are a lot of global data structures which can be protected by a 'simple' lock. Simple means:
- the lock protects only this data structure or it only protects the data structures in a given C module.
An example would be the appdomains list in domain.c
- the lock is only held for a short amount of time, and no other lock is acquired inside this simple lock. Thus there is
no possibility of deadlock.
1.3.2 The class loader lock
---------------------------
This locks is held by the class loading routines in class.c and loader.c. It
protects the various caches inside MonoImage which are used by these modules.
1.3.3 The domain lock
---------------------
Each appdomain has a lock which protects the per-domain data structures.
1.3.4 The locking hierarchy
---------------------------
It is useful to model locks by a locking hierarchy, which is a relation between locks, which is reflexive, transitive,
and antisymmetric, in other words, a lattice. If a thread wants to acquire a lock B, while already holding A, it can only
do it if A < B. If all threads work this way, then no deadlocks can occur.
Our locking hierarchy so far looks like this:
<DOMAIN LOCK>
\
<CLASS LOADER LOCK>
\ \
<SIMPLE LOCK 1> <SIMPLE LOCK 2>
1.4 Notes
----------
Some common scenarios:
- if a function needs to access a data structure, then it should lock it itself, and do not count on its caller locking it.
So for example, the image->class_cache hash table would be locked by mono_class_get().
- there are lots of places where a runtime data structure is created and stored in a cache. In these places, care must be
taken to avoid multiple threads creating the same runtime structure, for example, two threads might call mono_class_get ()
with the same class name. There are two choices here:
<enter mutex>
<check that item is created>
if (created) {
<leave mutex>
return item
}
<create item>
<store it in cache>
<leave mutex>
This is the easiest solution, but it requires holding the lock for the whole time which might create a scalability problem, and could also lead to deadlock.
<enter mutex>
<check that item is created>
<leave mutex>
if (created) {
return item
}
<create item>
<enter mutex>
<check that item is created>
if (created) {
/* Another thread already created and stored the same item */
<free our item>
<leave mutex>
return orig item
}
else {
<store item in cache>
<leave mutex>
return item
}
This solution does not present scalability problems, but the created item might be hard to destroy (like a MonoClass).
- lazy initialization of hashtables etc. is not thread safe
Loaded 100 of 6572 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.