mirror of
https://github.com/BepInEx/mono.git
synced 2026-11-17 11:21:39 -10:00
We were seeing the following unhandled exception on Jenkins: ```` Unhandled exceptions: 1) MonoTests.System.ServiceModel.OperationContextTest.Current : System.NullReferenceException: Object reference not set to an instance of an object at System.ServiceModel.Channels.NetTcp.TcpReplyChannel.OnClose (TimeSpan timeout) [0x00000] in /media/ssd/jenkins/workspace/test-mono-mainline/label/debian-armhf/mcs/class/System.ServiceModel/System.ServiceModel.Channels.NetTcp/TcpReplyChannel.cs:141 at System.ServiceModel.Channels.CommunicationObject.Close (TimeSpan timeout) [0x0001c] in /media/ssd/jenkins/workspace/test-mono-mainline/label/debian-armhf/mcs/class/System.ServiceModel/System.ServiceModel.Channels/CommunicationObject.cs:140 at System.ServiceModel.Channels.CommunicationObject.Close () [0x00000] in /media/ssd/jenkins/workspace/test-mono-mainline/label/debian-armhf/mcs/class/System.ServiceModel/System.ServiceModel.Channels/CommunicationObject.cs:131 at System.ServiceModel.Dispatcher.ListenerLoopManager.TryReceiveRequestDone (IAsyncResult result) [0x00027] in /media/ssd/jenkins/workspace/test-mono-mainline/label/debian-armhf/mcs/class/System.ServiceModel/System.ServiceModel.Dispatcher/ChannelDispatcher.cs:583 ``` This happens because multiple threads can call OnClose() and so `client` can be null. Fixed this by taking code from HttpReplyChannel.OnClose which handled this already and also fixed the race condition there (the checks need to happen under a lock).
160 lines
4.5 KiB
C#
160 lines
4.5 KiB
C#
//
|
|
// TcpReplyChannel.cs
|
|
//
|
|
// Author:
|
|
// Atsushi Enomoto <[email protected]>
|
|
//
|
|
// Copyright (C) 2009 Novell, Inc. http://www.novell.com
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining
|
|
// a copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to
|
|
// permit persons to whom the Software is furnished to do so, subject to
|
|
// the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be
|
|
// included in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
|
|
// LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
|
|
// OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
|
|
// WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
//
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using System.Net;
|
|
using System.Net.Sockets;
|
|
using System.ServiceModel;
|
|
using System.Text;
|
|
using System.Threading;
|
|
|
|
namespace System.ServiceModel.Channels.NetTcp
|
|
{
|
|
internal class TcpReplyChannel : InternalReplyChannelBase
|
|
{
|
|
TcpClient client;
|
|
TcpChannelInfo info;
|
|
TcpBinaryFrameManager frame;
|
|
|
|
public TcpReplyChannel (ChannelListenerBase listener, TcpChannelInfo info, TcpClient client)
|
|
: base (listener)
|
|
{
|
|
this.client = client;
|
|
this.info = info;
|
|
}
|
|
|
|
public MessageEncoder Encoder {
|
|
get { return info.MessageEncoder; }
|
|
}
|
|
|
|
public override RequestContext ReceiveRequest (TimeSpan timeout)
|
|
{
|
|
if (timeout <= TimeSpan.Zero)
|
|
throw new ArgumentException (String.Format ("Timeout value must be positive value. It was {0}", timeout));
|
|
|
|
DateTime start = DateTime.Now;
|
|
|
|
// FIXME: use timeout
|
|
if (client == null)
|
|
client = ((TcpChannelListener<IReplyChannel>) Manager).AcceptTcpClient (timeout);
|
|
NetworkStream ns = client.GetStream ();
|
|
frame = new TcpBinaryFrameManager (TcpBinaryFrameManager.SingletonUnsizedMode, ns, true) { Encoder = this.Encoder };
|
|
|
|
// FIXME: use timeout
|
|
if (!frame.ProcessPreambleRecipient ())
|
|
return null;
|
|
frame.ProcessPreambleAckRecipient ();
|
|
|
|
var msg = frame.ReadUnsizedMessage (timeout);
|
|
|
|
Logger.LogMessage (MessageLogSourceKind.TransportReceive, ref msg, info.BindingElement.MaxReceivedMessageSize);
|
|
|
|
// LAMESPEC: it contradicts the protocol explanation at section 3.1.1.1.1 in [MC-NMF].
|
|
// Moving ReadEndRecord() after context's WriteUnsizedMessage() causes TCP connection blocking.
|
|
frame.ReadEndRecord ();
|
|
return new TcpRequestContext (this, msg);
|
|
}
|
|
|
|
class TcpRequestContext : InternalRequestContext
|
|
{
|
|
public TcpRequestContext (TcpReplyChannel owner, Message request)
|
|
: base (owner.Manager)
|
|
{
|
|
this.owner = owner;
|
|
this.request = request;
|
|
}
|
|
|
|
TcpReplyChannel owner;
|
|
Message request;
|
|
|
|
public override Message RequestMessage {
|
|
get { return request; }
|
|
}
|
|
|
|
public override void Abort ()
|
|
{
|
|
Close (TimeSpan.Zero);
|
|
}
|
|
|
|
public override void Close (TimeSpan timeout)
|
|
{
|
|
}
|
|
|
|
public override void Reply (Message message, TimeSpan timeout)
|
|
{
|
|
Logger.LogMessage (MessageLogSourceKind.TransportSend, ref message, owner.info.BindingElement.MaxReceivedMessageSize);
|
|
|
|
DateTime start = DateTime.Now;
|
|
owner.frame.WriteUnsizedMessage (message, timeout);
|
|
// FIXME: consider timeout here too.
|
|
owner.frame.WriteEndRecord ();
|
|
}
|
|
}
|
|
|
|
public override bool TryReceiveRequest (TimeSpan timeout, out RequestContext context)
|
|
{
|
|
try {
|
|
DateTime start = DateTime.Now;
|
|
context = ReceiveRequest (timeout);
|
|
return context != null;
|
|
} catch (Exception ex) {
|
|
// FIXME: log it?
|
|
// Console.WriteLine (ex);
|
|
context = null;
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public override bool WaitForRequest (TimeSpan timeout)
|
|
{
|
|
throw new NotImplementedException ();
|
|
}
|
|
|
|
bool close_started;
|
|
object close_lock = new object ();
|
|
|
|
protected override void OnClose (TimeSpan timeout)
|
|
{
|
|
lock (close_lock) {
|
|
if (close_started)
|
|
return;
|
|
close_started = true;
|
|
}
|
|
|
|
client.Close ();
|
|
client = null;
|
|
base.OnClose (timeout);
|
|
}
|
|
|
|
protected override void OnOpen (TimeSpan timeout)
|
|
{
|
|
}
|
|
}
|
|
}
|