Drop-OSS/archived-wry-cef
1
0
Fork 0
mirror of https://github.com/Drop-OSS/wry-cef.git synced 2026-01-30 20:55:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Allow downloads by default on linux/macos to match windows behavior (#1602)

Browse Source
This commit is contained in:
Fabian-Lars
2025-08-15 15:25:11 +02:00
committed by GitHub
parent 5399823a1e
commit 1456f8e33a
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changes/allow-downloads-default.md Normal file
View File

@@ -0,0 +1,5 @@
---
wry: patch
---
Enabled all downloads by default to match WebView2 and browser behavior on all platforms. To disable this, provide a custom `download_started_handler`.

6
src/lib.rs
View File

@@ -585,6 +585,8 @@ pub struct WebViewAttributes<'a> {
/// second is a mutable `PathBuf` reference that (possibly) represents where the file will be downloaded to. The latter
/// parameter can be used to set the download location by assigning a new path to it, the assigned path _must_ be
/// absolute. The closure returns a `bool` to allow or deny the download.
///
/// [`Self::default()`] sets a handler allowing all downloads to match browser behavior.
pub download_started_handler: Option<Box<dyn FnMut(String, &mut PathBuf) -> bool + 'static>>,
/// A download completion handler to manage downloads that have finished.
@@ -718,7 +720,7 @@ impl Default for WebViewAttributes<'_> {
ipc_handler: None,
drag_drop_handler: None,
navigation_handler: None,
download_started_handler: None,
download_started_handler: Some(Box::new(|_, _| true)),
download_completed_handler: None,
new_window_req_handler: None,
clipboard: false,
@@ -1159,6 +1161,8 @@ impl<'a> WebViewBuilder<'a> {
/// second is a mutable `PathBuf` reference that (possibly) represents where the file will be downloaded to. The latter
/// parameter can be used to set the download location by assigning a new path to it, the assigned path _must_ be
/// absolute. The closure returns a `bool` to allow or deny the download.
///
/// By default a handler that allows all downloads is set to match browser behavior.
pub fn with_download_started_handler(
mut self,
download_started_handler: impl FnMut(String, &mut PathBuf) -> bool + 'static,