mirror of
https://github.com/Frumph/comic-easel.git
synced 2026-07-21 17:05:32 -04:00
[GH-ISSUE #21] Make Comic Easel compatible with Loco Translate by merging comiceasel-en_US and en_US .po and .mo files #20
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JN-Squire on GitHub (Jul 17, 2016).
Original GitHub issue: https://github.com/Frumph/comic-easel/issues/21
I got a lot of interest lately about Comic Easel from French comic authors, translators and readers, so I translated comiceasel-en_US PO and MO files with the best and most complete free tool I have on hand: Loco translate. (French is my native language)
The thing is, since the lang directory don't have any POT file, Loco Translate only dectect strings from comiceasel-en_US files, not the different ones put in the en_US files. As a result, it's currently impossible to translate fully the plugin in any language and publish comics to non-English readers with it! :(
For fixing this bug, and since, the POT file doesn't seem essential for Loco Translate, I suggest first to merge comiceasel-en_US and en-US PO and MO files.
@Frumph commented on GitHub (Jul 17, 2016):
Updated the comiceasel-en_US/mo/po files, if you want to add french ones they should be comiceasel-fr_FR/mo/po and if they have 'wordpress in your language' configured it will use them; the WPLANG define in the wp-config.php file
@Frumph commented on GitHub (Jul 17, 2016):
https://github.com/Frumph/comic-easel/tree/master/lang
the lang directory does have language files ;/
@JN-Squire commented on GitHub (Jul 17, 2016):
@Frumph Thanks for the update. :)
I'll test this version as soon as I see the update on the comics dashboard (the translation is hosted by the author and I don't have rights to access the server besides the Dashboard).
@JN-Squire commented on GitHub (Sep 30, 2016):
@Frumph I just finished to test properly the new file with Loco Translate 2.0. The end result is I only got 6 translated strings. After diving a bit into the .PO file, it looks like the problem comes from the
#@line used for every string ("Text Domain" for Loco Translate). It is either displayed#@ comiceaselor#@ comic-easel. I think the#@line needs to be consistent thorough the file in order set it up properly. My suggestion is to use#@ comic-easelsince the name of the plugin is made from to separated words.@Frumph commented on GitHub (Sep 30, 2016):
it's comiceasel, fixing the one singular one that says comic-easel right now AND about 10-15 that don't have a reference, will update in a couple hours after going to park
@Frumph commented on GitHub (Sep 30, 2016):
and found about 15 strings that have trailing spaces that I need to fix in the code ;/ will do that too
@Frumph commented on GitHub (Sep 30, 2016):
okay update made (not to live servers)