Frumph/comic-easel
1
0
Fork 0
mirror of https://github.com/Frumph/comic-easel.git synced 2026-07-22 01:15:22 -04:00
Code Issues 10 Packages Projects Releases 3 Wiki Activity

[GH-ISSUE #23] According to GlotPress, CE is "not properly prepared for localization" (failed import) #21

New Issue
Closed
opened 2026-06-06 22:29:06 -04:00 by yindo · 5 comments
yindo commented 2026-06-06 22:29:06 -04:00
Owner
Copy Link
Copy Source

Originally created by @JN-Squire on GitHub (Jan 4, 2017).
Original GitHub issue: https://github.com/Frumph/comic-easel/issues/23

So I discovered GlotPress and figured it would be much easier to create and maintain localizations of the plugin with this tool (for now). But it displays the following error:
image

The help page says "it usually means that something is wrong with the text domain" and talks about getting details through a Slack channel.

So in order to solve this bug, I suggest we get first the details of the failed import @Frumph : do you think you could do it? It would be really helpful.

Originally created by @JN-Squire on GitHub (Jan 4, 2017). Original GitHub issue: https://github.com/Frumph/comic-easel/issues/23 So I discovered [GlotPress](https://translate.wordpress.org/) and figured it would be much easier to create and maintain [localizations of the plugin with this tool](https://translate.wordpress.org/projects/wp-plugins/comic-easel) (for now). But it displays the following error: ![image](https://cloud.githubusercontent.com/assets/818639/21501639/c5542806-cc49-11e6-8f5b-b84b36c31c44.png) The [help page](https://make.wordpress.org/meta/handbook/documentation/translations/#this-plugin-is-not-properly-prepared-for-localization-%e2%80%93-help) says "it usually means that something is wrong with the text domain" and talks about getting details through a Slack channel. So in order to solve this bug, I suggest we get first the details of the failed import @Frumph : do you think you could do it? It would be really helpful.
yindo closed this issue 2026-06-06 22:29:06 -04:00
yindo commented 2026-06-06 22:29:06 -04:00
Author
Owner
Copy Link
Copy Source

@Frumph commented on GitHub (Jan 5, 2017):

Does it say "why" it doesn't think it's not properly prepared for localization .. cause codestyle localization is loading it just fine

<!-- gh-comment-id:270755893 --> @Frumph commented on GitHub (Jan 5, 2017): Does it say "why" it doesn't think it's not properly prepared for localization .. cause codestyle localization is loading it just fine
yindo commented 2026-06-06 22:29:06 -04:00
Author
Owner
Copy Link
Copy Source

@JN-Squire commented on GitHub (Feb 24, 2017):

Yes it does.
I just figured how to find the info in the #meta-language-packs channel in the WlordPress Slack group. Here is the screenshot of what happened at the import:
slack_2017-02-24_15-55-39

It looks like to needs a special kind of text domain declaration in the file header.

According to the Translations FAQ,

Please follow the instructions in the plugin developer handbook to internationalize all your strings, taking careful note to have a “Text Domain:” in your plugin header that matches the slug of your plugin.

So fixing this bug probably implies to change the "Text Domain" (currently "@ comiceasel" in MO and PO files if I got it right) in ComicEasel plugin header to "comic-easel"?

<!-- gh-comment-id:282312987 --> @JN-Squire commented on GitHub (Feb 24, 2017): Yes it does. I just figured how to find the info in the #meta-language-packs channel in the WlordPress Slack group. Here is the screenshot of what happened at the import: ![slack_2017-02-24_15-55-39](https://cloud.githubusercontent.com/assets/818639/23307985/dbacdcc2-faa9-11e6-81e0-f3a04940f875.png) It looks like to needs a special kind of text domain declaration in the file header. According to the [Translations FAQ](https://make.wordpress.org/meta/handbook/documentation/translations/#how-do-i-internationalize-my-plugin-how-do-i-set-a-text-domain), > Please follow the instructions in the plugin developer handbook to internationalize all your strings, **taking careful note to have a “Text Domain:” in your plugin header that matches the slug of your plugin**. So fixing this bug probably implies to change the "Text Domain" (currently "@ comiceasel" in MO and PO files if I got it right) in ComicEasel plugin header to "comic-easel"?
yindo commented 2026-06-06 22:29:06 -04:00
Author
Owner
Copy Link
Copy Source

@Frumph commented on GitHub (Feb 24, 2017):

Okay, will add.

<!-- gh-comment-id:282450387 --> @Frumph commented on GitHub (Feb 24, 2017): Okay, will add.
yindo commented 2026-06-06 22:29:06 -04:00
Author
Owner
Copy Link
Copy Source

@JN-Squire commented on GitHub (Mar 7, 2017):

@Frumph There, I edited the files. Now we will only know if the requirements are meet once it gets imported in the WordPress repository.
Edit: Since an update on WordPress.org seems needed in order to test the fix, I also updated the readme.txt file. Trying to be careful, I mentioned the GlotPress compatibility is experimental.

<!-- gh-comment-id:284731807 --> @JN-Squire commented on GitHub (Mar 7, 2017): @Frumph There, I [edited the files](https://github.com/Frumph/comic-easel/commit/b3e3f01c6da68e073f5166e90131b723e1ced125). Now we will only know if the requirements are meet once it gets imported in the WordPress repository. Edit: Since an update on WordPress.org seems needed in order to test the fix, I also updated the readme.txt file. Trying to be careful, I mentioned the GlotPress compatibility is experimental.
yindo commented 2026-06-06 22:29:06 -04:00
Author
Owner
Copy Link
Copy Source

@Frumph commented on GitHub (Mar 8, 2018):

added to github, seemed it didnt stick

<!-- gh-comment-id:371640368 --> @Frumph commented on GitHub (Mar 8, 2018): added to github, seemed it didnt stick
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
TODO
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Frumph/comic-easel#21
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?