more concise naming

This commit is contained in:
Dmitry Stepanov
2025-03-10 20:30:17 +03:00
parent 60152bca0d
commit 78859c6d55
17 changed files with 55 additions and 59 deletions
+1 -1
View File
@@ -250,7 +250,7 @@ impl Toolbar {
inner_type_name: std::any::type_name::<N>().to_string(),
handle: Default::default(),
inner_type_id: TypeId::of::<N>(),
derived_type_ids: N::derived_entity_list().to_vec(),
derived_type_ids: N::derived_types().to_vec(),
children: vec![],
};
@@ -235,7 +235,7 @@ impl<T: Reflect> Control for HandlePropertyEditor<T> {
vec![SelectedHandle {
handle: self.value.into(),
inner_type_id: TypeId::of::<T>(),
derived_type_ids: T::derived_entity_list().to_vec(),
derived_type_ids: T::derived_types().to_vec(),
}],
));
}
+1 -1
View File
@@ -167,7 +167,7 @@ impl<T: Reflect> From<Handle<T>> for SelectedHandle {
fn from(value: Handle<T>) -> Self {
Self {
inner_type_id: TypeId::of::<T>(),
derived_type_ids: T::derived_entity_list().to_vec(),
derived_type_ids: T::derived_types().to_vec(),
handle: value.into(),
}
}
+6 -6
View File
@@ -66,12 +66,12 @@ macro_rules! define_two_args_node {
file!()
}
fn derived_entity_list() -> &'static [TypeId] {
fn derived_types() -> &'static [TypeId] {
&[]
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {
@@ -230,12 +230,12 @@ impl<T: EntityId> Reflect for NotNode<T> {
file!()
}
fn derived_entity_list() -> &'static [TypeId] {
fn derived_types() -> &'static [TypeId] {
&[]
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {
+3 -3
View File
@@ -460,7 +460,7 @@ fn gen_impl(
std::any::type_name::<Self>()
}
fn derived_entity_list() -> &'static [std::any::TypeId] {
fn derived_types() -> &'static [std::any::TypeId] {
static ARRAY: std::sync::LazyLock<Vec<std::any::TypeId>> = std::sync::LazyLock::new(|| vec![
#types
]);
@@ -468,8 +468,8 @@ fn gen_impl(
&ARRAY
}
fn query_derived_entity_list(&self) -> &'static [std::any::TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [std::any::TypeId] {
Self::derived_types()
}
fn doc(&self) -> &'static str {
+4 -4
View File
@@ -88,15 +88,15 @@ impl<T: Reflect> Reflect for Handle<T> {
file!()
}
fn derived_entity_list() -> &'static [TypeId]
fn derived_types() -> &'static [TypeId]
where
Self: Sized,
{
T::derived_entity_list()
T::derived_types()
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {
+3 -3
View File
@@ -104,15 +104,15 @@ where
file!()
}
fn derived_entity_list() -> &'static [TypeId]
fn derived_types() -> &'static [TypeId]
where
Self: Sized,
{
&[]
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
#[inline]
+9 -9
View File
@@ -204,11 +204,11 @@ pub trait Reflect: ReflectBase {
where
Self: Sized;
fn derived_entity_list() -> &'static [TypeId]
fn derived_types() -> &'static [TypeId]
where
Self: Sized;
fn query_derived_entity_list(&self) -> &'static [TypeId];
fn query_derived_types(&self) -> &'static [TypeId];
fn type_name(&self) -> &'static str;
@@ -1140,15 +1140,15 @@ macro_rules! blank_reflect {
file!()
}
fn derived_entity_list() -> &'static [std::any::TypeId]
fn derived_types() -> &'static [std::any::TypeId]
where
Self: Sized,
{
&[]
}
fn query_derived_entity_list(&self) -> &'static [std::any::TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [std::any::TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {
@@ -1213,13 +1213,13 @@ macro_rules! delegate_reflect {
file!()
}
fn derived_entity_list() -> &'static [std::any::TypeId] {
fn derived_types() -> &'static [std::any::TypeId] {
// TODO
&[]
}
fn query_derived_entity_list(&self) -> &'static [std::any::TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [std::any::TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {
@@ -1448,6 +1448,6 @@ mod test {
#[test]
fn test_derived() {
let base = Base;
assert_eq!(base.query_derived_entity_list(), &[TypeId::of::<Derived>()])
assert_eq!(base.query_derived_types(), &[TypeId::of::<Derived>()])
}
}
+3 -3
View File
@@ -304,14 +304,14 @@ macro_rules! impl_reflect_inner_mutability {
file!()
}
fn derived_entity_list() -> &'static [std::any::TypeId] {
fn derived_types() -> &'static [std::any::TypeId] {
// TODO: This seems to be impossible to implement because of `?Sized` trait bound
// up above.
&[]
}
fn query_derived_entity_list(&self) -> &'static [std::any::TypeId] {
T::derived_entity_list()
fn query_derived_types(&self) -> &'static [std::any::TypeId] {
T::derived_types()
}
fn type_name(&$self) -> &'static str {
+4 -4
View File
@@ -374,15 +374,15 @@ where
file!()
}
fn derived_entity_list() -> &'static [TypeId]
fn derived_types() -> &'static [TypeId]
where
Self: Sized,
{
T::derived_entity_list()
T::derived_types()
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
#[inline]
+6 -10
View File
@@ -233,9 +233,7 @@ where
// Handle derived entities handles.
entity.as_handle_mut(&mut |handle| {
if let Some(handle) = handle {
if handle
.query_derived_entity_list()
.contains(&TypeId::of::<N>())
if handle.query_derived_types().contains(&TypeId::of::<N>())
&& handle.reflect_is_some()
&& !self.try_map_reflect(handle)
{
@@ -375,9 +373,7 @@ where
entity.as_handle_mut(&mut |handle| {
if let Some(handle) = handle {
if do_map
&& handle
.query_derived_entity_list()
.contains(&TypeId::of::<N>())
&& handle.query_derived_types().contains(&TypeId::of::<N>())
&& handle.reflect_is_some()
&& !self.try_map_reflect(handle)
{
@@ -1596,12 +1592,12 @@ mod test {
self.0.deref_mut().field_mut(name, func)
}
fn derived_entity_list() -> &'static [TypeId] {
fn derived_types() -> &'static [TypeId] {
&[]
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
}
@@ -1867,7 +1863,7 @@ mod test {
fn derived_type_ids(&self, handle: Handle<Self::Node>) -> Option<Vec<TypeId>> {
self.nodes
.try_borrow(handle)
.map(|n| n.0.deref().query_derived_entity_list().to_vec())
.map(|n| n.0.deref().query_derived_types().to_vec())
}
fn actual_type_name(&self, handle: Handle<Self::Node>) -> Option<&'static str> {
+1 -1
View File
@@ -1829,7 +1829,7 @@ impl BaseSceneGraph for Graph {
fn derived_type_ids(&self, handle: Handle<Self::Node>) -> Option<Vec<TypeId>> {
self.pool
.try_borrow(handle)
.map(|n| Box::deref(&n.0).query_derived_entity_list().to_vec())
.map(|n| Box::deref(&n.0).query_derived_types().to_vec())
}
fn actual_type_name(&self, handle: Handle<Self::Node>) -> Option<&'static str> {
+3 -3
View File
@@ -533,12 +533,12 @@ impl Reflect for Node {
file!()
}
fn derived_entity_list() -> &'static [TypeId] {
fn derived_types() -> &'static [TypeId] {
&[]
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {
+3 -3
View File
@@ -71,12 +71,12 @@ impl Reflect for Limb {
file!()
}
fn derived_entity_list() -> &'static [TypeId] {
fn derived_types() -> &'static [TypeId] {
&[]
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {
+3 -3
View File
@@ -671,12 +671,12 @@ impl Reflect for Script {
file!()
}
fn derived_entity_list() -> &'static [TypeId] {
fn derived_types() -> &'static [TypeId] {
&[]
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {
+1 -1
View File
@@ -3253,7 +3253,7 @@ impl BaseSceneGraph for UserInterface {
fn derived_type_ids(&self, handle: Handle<Self::Node>) -> Option<Vec<TypeId>> {
self.nodes
.try_borrow(handle)
.map(|n| n.0.query_derived_entity_list().to_vec())
.map(|n| n.0.query_derived_types().to_vec())
}
fn actual_type_name(&self, handle: Handle<Self::Node>) -> Option<&'static str> {
+3 -3
View File
@@ -283,12 +283,12 @@ impl Reflect for UiNode {
file!()
}
fn derived_entity_list() -> &'static [TypeId] {
fn derived_types() -> &'static [TypeId] {
&[]
}
fn query_derived_entity_list(&self) -> &'static [TypeId] {
Self::derived_entity_list()
fn query_derived_types(&self) -> &'static [TypeId] {
Self::derived_types()
}
fn type_name(&self) -> &'static str {