Commit Graph

2392 Commits

Author SHA1 Message Date
Pierre de La Morinerie
7b38eec70f docs: add a style guide for code
Inspired by pokecrystal style guide.
2023-03-18 22:56:14 +01:00
Pierre de La Morinerie
88bd16594d
Merge pull request #515 from zladx/daid-patch-1
Use proper constants where the select key is checked for opening the map.
2023-03-17 20:55:45 +01:00
daid
6948fc6c16
Update bank0.asm 2023-03-17 20:32:49 +01:00
daid
1a667a50c5
Update bank0.asm 2023-03-17 20:29:39 +01:00
Pierre de La Morinerie
aa860e6963
Merge pull request #514 from zladx/Physic-flags-checks
Two physics flags checks
2023-03-17 12:29:49 +01:00
daid
20e4c27076
Update bank3.asm 2023-03-17 11:24:19 +01:00
Pierre de La Morinerie
097c7a145a
Merge pull request #512 from daid/master
Document function at 0B2F, which is used to backup overworld objects to WRAM bank 2.
2023-03-15 14:58:18 +01:00
Pierre de La Morinerie
fc6890c992 BackupObjectInRAM2 documentation 2023-03-15 14:56:56 +01:00
Pierre de La Morinerie
a38dee8846 Uppercase backupObjectInRAM2 2023-03-15 14:56:56 +01:00
Daid
d7c7db0531 Document function at 0B2F 2023-03-15 07:36:36 +00:00
Kelsey Higham
a549429a14
Add speakers to dialog lines (#509) 2023-03-14 07:34:56 -07:00
Pierre de La Morinerie
94549f763a
Merge pull request #511 from KelseyHigham/palettes
label and apply `rgb` macro to palettes
2023-03-14 09:35:40 +01:00
Kelsey Higham
62194568d8
correct data 2023-03-13 17:34:34 -07:00
Kelsey Higham
01260e10d8
apply rgb macro to inventory palettes 2023-03-13 16:47:30 -07:00
Kelsey Higham
1a865ba86a
apply rgb macro to photo album palettes 2023-03-13 16:04:53 -07:00
Kelsey Higham
c7935a8d79
label and rgb macro palettes 2023-03-13 16:00:28 -07:00
Pierre de La Morinerie
6f23d03910
Merge pull request #508 from zladx/entity-physics-2
Add comments about ENTITY_PHYSICS constants
2023-01-10 21:19:06 +01:00
Tobias V. Langhoff
a8f9e42bad Add comments about ENTITY_PHYSICS constants 2023-01-10 20:58:37 +01:00
Tobias V. Langhoff
3a10385479
Merge pull request #502 from zladx/entity-physics 2023-01-10 15:47:24 +01:00
Tobias V. Langhoff
239661ec21 Magnifying Glass -> Magnifying Lens
Both are used in the text, but "Magnifying Lens" seems like the official name
2023-01-10 09:57:54 +01:00
Tobias V. Langhoff
87c66708e0 Document ENTITY_PHYSICS_* flags 2023-01-10 09:57:53 +01:00
Pierre de La Morinerie
953d5b5613
Merge pull request #505 from zladx/entities-work
entities: identify some unlabeled entities
2023-01-03 12:14:33 +01:00
Pierre de La Morinerie
f306029d10
Update src/code/entities/_handlers.asm
Co-authored-by: Tobias V. Langhoff <tobias@langhoff.no>
2023-01-03 12:13:47 +01:00
Pierre de La Morinerie
7b078db7f0 src: attempt to document entity 8C and 8D 2022-12-16 21:03:28 +01:00
Pierre de La Morinerie
d6e2226589 entities: label hookshot bridge 2022-12-16 21:03:28 +01:00
Pierre de La Morinerie
3d85e269fc entities: resolve more constants 2022-12-16 21:03:28 +01:00
Kelsey Higham
a41dea8315
Document title screen attribute map (#504) 2022-12-16 04:03:07 -08:00
daid
099189ed39
Merge pull request #500 from daid/master
Label two shovel related memory locations.
2022-12-11 15:45:02 +01:00
daid
aae890fc44
Update src/constants/memory/wram.asm
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2022-12-11 15:44:18 +01:00
daid
09e386c02e
Update src/constants/memory/wram.asm
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2022-12-11 15:44:06 +01:00
Tobias V. Langhoff
ab2a0796d9
Merge pull request #503 from zladx/optimization-patches 2022-12-09 10:30:34 +01:00
Tobias V. Langhoff
ba85ed8e55 Split out optimizations from PATCH_3 -> OPTIMIZATIONS_3 2022-12-09 10:29:33 +01:00
Tobias V. Langhoff
93246fc5d2 Split optimizations out into separate patches
- Optimizations from __PATCH_0__ -> __OPTIMIZATIONS_1__
- Rename __PATCH_9__ to __OPTIMIZATIONS_2__
2022-12-08 23:44:53 +01:00
Tobias V. Langhoff
4d38063189
Merge pull request #501 from zladx/hearts-stuff 2022-12-08 17:35:31 +01:00
Tobias V. Langhoff
4a019b4f4d Various changes related to hearts
- Split recalculation of maximum hearts out from __PATCH_4__ into __RECALCULATE_MAX_HEARTS__
- Document routines that clamp/recalculate maximum hearts
- Rename everything related to "MaxHealth" to "MaxHearts" for consistency
- Document the routine that draws hearts in the file menu
- Misc

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2022-12-08 16:41:49 +01:00
Daid
7473726644 Label two shovel related memory locations. 2022-12-07 19:24:14 +00:00
Tobias V. Langhoff
a694e3b570
Merge pull request #499 from zladx/sram 2022-12-07 16:02:14 +01:00
Tobias V. Langhoff
e09f24ecf2 Change "ExternalRAM" to "SRAM" for consistency
Also:
- Clarify that enabling SRAM is needed for reading too, not just writing
- Label some other saving stuff according to existing documentation
2022-12-07 15:09:33 +01:00
Tobias V. Langhoff
f003b5ec3b
Merge pull request #498 from zladx/ignore-case-aligning-comments 2022-12-06 22:51:25 +01:00
Tobias V. Langhoff
70f15958e3 Normalize case when aligning comments 2022-12-06 18:17:38 +01:00
Tobias V. Langhoff
caf10e322b
Merge pull request #470 from zladx/special-item-handling
Document handling of special cases when using items
2022-12-06 17:41:46 +01:00
Tobias V. Langhoff
e5afe6d848
Update src/constants/memory/wram.asm
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2022-12-06 17:40:50 +01:00
Tobias V. Langhoff
6cfad213ff Document handling of special cases when using items 2022-12-06 15:34:11 +01:00
Tobias V. Langhoff
1f3f04c8c1
Merge pull request #497 from zladx/mbc-constants 2022-12-06 14:34:44 +01:00
Tobias V. Langhoff
adba0ada8a Use callhl macros, fix "ruppee" typo 2022-12-06 14:32:54 +01:00
Tobias V. Langhoff
3e6b6dfdf8 Generalize MBC constants
- Use hardware.inc constants where possible
- Rename MBC3SelectBank to rSelectROMBank (LADX doesn't use MBC3)
2022-12-06 14:01:09 +01:00
Tobias V. Langhoff
f09515e981
Merge pull request #496 from zladx/hide-sprites 2022-12-06 01:30:49 +01:00
Pierre de La Morinerie
e59f578fec
Merge pull request #490 from zladx/credits-debug-tools
credits: document some of the debug tools
2022-12-06 01:12:27 +01:00
Tobias V. Langhoff
963dbc9f2a
Merge pull request #494 from zladx/dialog-constants 2022-12-05 22:27:31 +01:00
Pierre de La Morinerie
270a229b8d credits: document some of the debug tools 2022-12-05 22:08:54 +01:00