Heretek-AI/GDevelop-Heretek
1
0
Fork 0
mirror of https://github.com/Heretek-AI/GDevelop-Heretek.git synced 2026-10-12 02:02:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Correctly detect project manager open to fix some stall guided lessons (#5246)

Browse Source
This commit is contained in:
AlexandreS
2023-04-20 13:34:54 +02:00
committed by GitHub
parent 6c27c3dcf8
commit c712ab3163
3 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
newIDE/app/resources/inAppTutorials/flingGame.json
+6 -6
View File
@@ -153,7 +153,7 @@
"id": "OpenPropertiesManager",
"elementToHighlightId": "#main-toolbar-project-manager-button",
"nextStepTrigger": {
"presenceOfElement": "div[role=\"presentation\"]:not([aria-hidden=true]) #project-manager-tab-game-settings"
"presenceOfElement": "div[role=\"presentation\"]:is([data-open=true], :not([aria-hidden=true])) #project-manager-tab-game-settings"
},
"tooltip": {
"description": {
@@ -169,7 +169,7 @@
}
},
{
"elementToHighlightId": "div[role=\"presentation\"]:not([aria-hidden=true]) #project-manager-tab-game-settings",
"elementToHighlightId": "div[role=\"presentation\"]:is([data-open=true], :not([aria-hidden=true])) #project-manager-tab-game-settings",
"nextStepTrigger": {
"presenceOfElement": "#project-manager-tab-game-properties"
},
@@ -1290,7 +1290,7 @@
"id": "OpenPropertiesManagerForExtension",
"elementToHighlightId": "#main-toolbar-project-manager-button",
"nextStepTrigger": {
"presenceOfElement": "div[role=\"presentation\"]:not([aria-hidden=true]) #project-manager-tab-extensions"
"presenceOfElement": "div[role=\"presentation\"]:is([data-open=true], :not([aria-hidden=true])) #project-manager-tab-extensions"
},
"tooltip": {
"title": {
@@ -1315,7 +1315,7 @@
}
},
{
"elementToHighlightId": "div[role=\"presentation\"]:not([aria-hidden=true]) #project-manager-tab-extensions",
"elementToHighlightId": "div[role=\"presentation\"]:is([data-open=true], :not([aria-hidden=true])) #project-manager-tab-extensions",
"nextStepTrigger": {
"presenceOfElement": "#project-manager-extension-search-or-create"
},
@@ -3330,7 +3330,7 @@
{
"elementToHighlightId": "#main-toolbar-project-manager-button",
"nextStepTrigger": {
"presenceOfElement": "div[role=\"presentation\"]:not([aria-hidden=true]) #project-manager-tab-game-settings"
"presenceOfElement": "div[role=\"presentation\"]:is([data-open=true], :not([aria-hidden=true])) #project-manager-tab-game-settings"
},
"tooltip": {
"title": {
@@ -5367,7 +5367,7 @@
{
"elementToHighlightId": "#main-toolbar-project-manager-button",
"nextStepTrigger": {
"presenceOfElement": "div[role=\"presentation\"]:not([aria-hidden=true]) #project-manager-tab-game-settings"
"presenceOfElement": "div[role=\"presentation\"]:is([data-open=true], :not([aria-hidden=true])) #project-manager-tab-game-settings"
},
"tooltip": {
"description": {
newIDE/app/src/InAppTutorial/InAppTutorialOrchestrator.js
+1 -1
View File
@@ -186,7 +186,7 @@ const interpolateElementId = (
) {
const splittedElementId = elementId.split(':');
const sceneKey = splittedElementId[1];
return `div[role="presentation"]:not([aria-hidden=true]) #project-manager [id^="scene-item"][data-scene="${
return `div[role="presentation"][data-open="true"] #project-manager [id^="scene-item"][data-scene="${
data[sceneKey]
}"]`;
} else if (
newIDE/app/src/MainFrame/index.js
+4
View File
@@ -179,6 +179,7 @@ import {
import CustomDragLayer from '../UI/DragAndDrop/CustomDragLayer';
import CloudProjectRecoveryDialog from '../ProjectsStorage/CloudStorageProvider/CloudProjectRecoveryDialog';
import CloudProjectSaveChoiceDialog from '../ProjectsStorage/CloudStorageProvider/CloudProjectSaveChoiceDialog';
import { dataObjectToProps } from '../Utils/HTMLDataset';
const GD_STARTUP_TIMES = global.GD_STARTUP_TIMES || [];
@@ -2983,6 +2984,9 @@ const MainFrame = (props: Props) => {
keepMounted: true,
}}
onClose={toggleProjectManager}
{...dataObjectToProps({
open: projectManagerOpen ? 'true' : undefined,
})}
>
<DrawerTopBar
title={