Heretek-AI/GDevelop-Heretek
1
0
Fork 0
mirror of https://github.com/Heretek-AI/GDevelop-Heretek.git synced 2026-10-12 02:02:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix editor crashes after modifying custom object extensions (#8626)

Browse Source
This commit is contained in:
D8H
2026-05-20 18:33:18 +02:00
committed by GitHub
parent 749a78650b
commit e3f3a1ffac
2 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Core/GDCore/IDE/EventsBasedObjectVariantHelper.cpp
+8 -10
View File
@@ -53,18 +53,20 @@ void EventsBasedObjectVariantHelper::ComplyVariantsToEventsBasedObject(
continue;
}
// Change object types
auto &object = objects.GetObject(objectName);
if (object.GetType() != defaultObject->GetType()) {
// Do not try to factorize `objects.GetObject(objectName)` because the
// object may be removed.
if (objects.GetObject(objectName).GetType() != defaultObject->GetType()) {
// Keep a copy of the old object.
auto oldObject = objects.GetObject(objectName);
objects.RemoveObject(objectName);
objects.InsertObject(*defaultObject,
defaultObjects.GetObjectPosition(objectName));
object.CopyWithoutConfiguration(oldObject);
auto &newObject = objects.InsertObject(
*defaultObject, defaultObjects.GetObjectPosition(objectName));
newObject.CopyWithoutConfiguration(oldObject);
objects.AddMissingObjectsInRootFolder();
}
// Copy missing behaviors
auto &object = objects.GetObject(objectName);
for (const auto &pair : defaultBehaviors) {
const auto &behaviorName = pair.first;
const auto &defaultBehavior = pair.second;
@@ -141,11 +143,7 @@ void EventsBasedObjectVariantHelper::ComplyVariantsToEventsBasedObject(
auto &defaultObjectGroups =
eventsBasedObject.GetDefaultVariant().GetObjects().GetObjectGroups();
auto &objectGroups = variant->GetObjects().GetObjectGroups();
auto objectGroupsCount = objectGroups.Count();
// Clear groups
for (size_t index = 0; index < objectGroupsCount; index++) {
objectGroups.Remove(objectGroups.Get(0).GetName());
}
objectGroups.Clear();
// Copy groups
for (size_t index = 0; index < defaultObjectGroups.Count(); index++) {
objectGroups.Insert(defaultObjectGroups.Get(index), index);
Core/GDCore/Project/ObjectGroupsContainer.h
+2 -3
View File
@@ -4,8 +4,8 @@
* reserved. This project is released under the MIT License.
*/
#ifndef GDCORE_OBJECTGROUPSCONTAINER_H
#define GDCORE_OBJECTGROUPSCONTAINER_H
#pragma once
#include <algorithm>
#include <memory>
#include <vector>
@@ -195,4 +195,3 @@ class GD_CORE_API ObjectGroupsContainer {
} // namespace gd
#endif // GDCORE_OBJECTGROUPSCONTAINER_H