Timothy Nikkel
6cf9261d16
Bug 1880054. Simplify some imagelib event target code. r=gfx-reviewers,lsalzman
...
This code was added before we decided to do fission, when we wanted to separate out different sites that were in the same process so we could prioritize them better. We are not going down that path so we can simplify this code. There should be no change in functionality with this patch, just simpler code.
Differential Revision: https://phabricator.services.mozilla.com/D201705
2024-02-25 04:54:33 +00:00
Jens Stutte
edb9c1b473
Bug 1797688 - Part 4: Bail out from IDecodingTask::NotifyProgress and NotifyDecodeComplete InOrBeyond(XPCOMShutdownThreads). r=xpcom-reviewers,mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D160622
2022-11-01 14:08:44 +00:00
Olli Pettay
ee4d895567
Bug 1734811 - consider to use higher priority for the imglib tasks r=tnikkel
...
Depends on D127935
Differential Revision: https://phabricator.services.mozilla.com/D127936
2021-10-08 19:29:37 +00:00
Andrew Osmond
081e8ef9c8
Bug 1732115 - Part 3. Refactor decoder pipeline to partially use Unoriented/OrientedPixel. r=tnikkel
...
Rather than change every use of IntSize/Rect/Point in image/, this patch
attempts to draw the line at the relevant parts of the decoding pipeline
to prevent confusion about which size and orientation we are working
with.
Differential Revision: https://phabricator.services.mozilla.com/D126381
2021-10-06 14:41:17 +00:00
Timothy Nikkel
67dd73fd6d
Bug 1719108. Check in a few places in imagelib if it's too late in shutdown to dispatch runnables. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D119712
2021-07-13 20:31:57 +00:00
Cameron McCormack
b18a79b4a3
Bug 1616411 - Part 3: Make RasterImage deal with and apply image orientation. r=tnikkel
...
This makes EXIF orientation metadata honored by default.
Introduce OrientedPixel and UnorientedPixel typed rects and sizes and
use them throughout RasterImage so that we don't confuse which we want.
The reason for doing this rather than having the imgLoader wrap every
RasterImage it creates with an OrientedImage is that returning the
wrapper messes with various notifications, as OrientedImage is not an
ImageResource.
(It would be even better if the JPEG decoder could decode to imgFrames
handling the EXIF orientation itself, but that's a more complicated
change.)
Differential Revision: https://phabricator.services.mozilla.com/D70273
2020-04-17 02:57:30 +00:00
Csoregi Natalia
ee575ba419
Backed out 8 changesets (bug 1616411) for webgl failures on test_2_conformance__textures__misc__texture-upload-size.html. CLOSED TREE
...
Backed out changeset 03dd88d53439 (bug 1616411)
Backed out changeset cfee2ce9405d (bug 1616411)
Backed out changeset 0a323c33506f (bug 1616411)
Backed out changeset 1a25353a07b0 (bug 1616411)
Backed out changeset dc64af52b5f8 (bug 1616411)
Backed out changeset 0f54b1b12105 (bug 1616411)
Backed out changeset 4dee3e753e8e (bug 1616411)
Backed out changeset 034a30a6b088 (bug 1616411)
2020-04-16 05:43:16 +03:00
Cameron McCormack
6df98b4a90
Bug 1616411 - Part 3: Make RasterImage deal with and apply image orientation. r=tnikkel
...
This makes EXIF orientation metadata honored by default.
Introduce OrientedPixel and UnorientedPixel typed rects and sizes and
use them throughout RasterImage so that we don't confuse which we want.
The reason for doing this rather than having the imgLoader wrap every
RasterImage it creates with an OrientedImage is that returning the
wrapper messes with various notifications, as OrientedImage is not an
ImageResource.
(It would be even better if the JPEG decoder could decode to imgFrames
handling the EXIF orientation itself, but that's a more complicated
change.)
Differential Revision: https://phabricator.services.mozilla.com/D70273
2020-04-16 00:34:29 +00:00
Andreas Farre
bafa3f4262
Bug 1620594 - Part 5: Use GetMainThreadSerialEventTarget instead of SystemGroup::EventTargetFor. r=nika
...
This patch also tries to remove the event target entirely if it would
default to the main thread on a null event target.
Depends on D67634
Differential Revision: https://phabricator.services.mozilla.com/D67635
2020-04-07 15:17:07 +00:00
Jean-Yves Avenard
8243c6f5ef
Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel
...
And with some tidying some comments and removing stray #include "gfxPrefs.h"
Differential Revision: https://phabricator.services.mozilla.com/D31468
2019-05-26 14:31:53 +00:00
Gurzau Raul
938877e121
Backed out 31 changesets (bug 1552643, bug 1550422) for xpcshell crash on a CLOSED TREE.
...
Backed out changeset e30c1aa75529 (bug 1552643)
Backed out changeset caadcd7e02d3 (bug 1552643)
Backed out changeset aa7086ab09be (bug 1552643)
Backed out changeset 0b4029671710 (bug 1550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422
2019-05-25 09:07:49 +03:00
Jean-Yves Avenard
fc3febfda2
Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel
...
And with some tidying some comments and removing stray #include "gfxPrefs.h"
Differential Revision: https://phabricator.services.mozilla.com/D31468
2019-05-24 11:37:50 +00:00
Gurzau Raul
8d7b43d90a
Backed out 28 changesets (bug 1550422) for marionette AssertionError and failing browser_policy_hardware_acceleration.js on a CLOSED TREE.
...
Backed out changeset 5dd10a365ba9 (bug 1550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422155042215504221550422
2019-05-23 05:59:44 +03:00
Jean-Yves Avenard
846a72c649
Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel
...
And with some tidying some comments and removing stray #include "gfxPrefs.h"
Differential Revision: https://phabricator.services.mozilla.com/D31468
2019-05-22 12:46:30 +00:00
Olli Pettay
0d4dba6adb
Bug 1519567, use medium high priority queue for imglib notifications, r=tnikkel
2019-03-01 15:11:56 +02:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Andrew Osmond
38813726fd
Bug 1503935 - Fix some WebP decoder implementation bugs. r=tnikkel
...
First we did not handle the SourceBufferIterator::WAITING state which
can happen when we get woken up but there is no data to read from the
SourceBufferIterator. StreamingLexer handled this properly by yielding
with NEED_MORE_DATA, and properly scheduling the decoder to resume. This
patch does the same in the WebP decoder.
Second nsWebPDecoder::GetType was not implemented. This meant it would
return DecoderType::UNKNOWN, and would fail to recreate the decoder if
we are discarding frames and need to restart from the beginning. In
addition to implementing that method, this patch also corrects an assert
in DecoderFactory::CloneAnimationDecoder which failed to check for WebP
as a supported animated decoder.
This patch also modestly improves the logging output and library method
checks.
Differential Revision: https://phabricator.services.mozilla.com/D10624
2018-11-01 19:26:14 -04:00
Andrew Osmond
496abfa2a1
Bug 1359833 - Part 2. IDecodingTask should use the event target from ProgressTracker for main thread runnables. r=tnikkel
2017-07-19 14:15:11 -04:00
Bill McCloskey
f79edeabc9
Bug 1339289 - Give names to a lot of common runnables (r=ehsan)
...
MozReview-Commit-ID: 5IdvK6kgoAW
2017-02-15 12:30:01 -08:00
Seth Fowler
ed50277add
Bug 1293472 (Part 3) - Store animated images in the surface cache as a sequence of frames, rather than each frame getting its own cache entry. r=dholbert,edwin,njn
2016-08-18 15:42:48 -07:00
Andrew Osmond
cb953c2b66
Bug 1293577 - Part 2. Add mutex to MetadataDecodingTask to protect from decoding races. r=seth
2016-08-18 10:23:42 -04:00
Andrew Osmond
dee397cfc1
Bug 1293577 - Protect the image decoding task path with a mutex to avoid race conditions. r=seth
2016-08-10 07:35:07 -04:00
Seth Fowler
c11b85f5a0
Bug 1291071 (Part 6) - Stop passing a decoder to FinalizeDecoder() and rename it NotifyDecodeComplete(). r=edwin
2016-08-05 18:50:32 -07:00
Seth Fowler
4f4921678b
Bug 1291071 (Part 5) - Pass the decoder's final status explicitly to FinalizeDecoder(). r=edwin
2016-08-05 18:50:31 -07:00
Seth Fowler
251ed225e5
Bug 1291071 (Part 3) - Pass telemetry explicitly to FinalizeDecoder. r=edwin
2016-08-05 18:50:27 -07:00
Seth Fowler
3cae096c3c
Bug 1291071 (Part 2) - Pass decoder progress explicitly to FinalizeDecoder. r=edwin
2016-08-05 18:50:25 -07:00
Seth Fowler
fd4149ef5a
Bug 1291071 (Part 1) - Pass ImageMetadata explicitly to FinalizeDecoder. r=edwin
2016-08-05 18:50:24 -07:00
Seth Fowler
0b15273908
Bug 1291071 (Part 1) - Move an assertion from RasterImage::FinalizeDecoder() to IDecodingTask::NotifyDecodeComplete(). r=edwin
2016-08-05 18:50:22 -07:00
Seth Fowler
cb009c3612
Bug 1291045 (Part 7) - Replace DecodingTask with DecodedSurfaceProvider. r=dholbert,edwin
2016-08-05 18:46:24 -07:00
Seth Fowler
7e7b5765b2
Bug 1291045 (Part 5) - Expose the IDecodingTask notification helpers for use in other files. r=edwin
2016-08-05 18:46:19 -07:00
Seth Fowler
2c64c4a4f9
Bug 1291045 (Part 3) - Handle interactions with the SurfaceCache in DecodingTask. r=dholbert,edwin
2016-08-05 18:46:13 -07:00
Seth Fowler
35e9d64ec9
Bug 1291045 (Part 2) - Pass the image into NotifyProgress() and NotifyDecodeComplete() explicitly. r=edwin
2016-08-05 18:46:12 -07:00
Seth Fowler
77d123ca25
Bug 1291045 (Part 1) - Use a different IDecodingTask for animated images. r=dholbert,edwin
2016-08-05 18:46:10 -07:00
Daniel Holbert
5b19d7b1bb
Bug 1292632 part 2: Add missing "using" decl for IntRect in IDecodingTask.cpp. r=seth
...
MozReview-Commit-ID: 6OeckqKu7k7
2016-08-05 17:09:47 -07:00
Seth Fowler
fc09aac126
(No bug) - Improve comment in IDecodingTask.cpp. r=me
2016-08-01 17:51:04 -07:00
Seth Fowler
cb1acecf4d
Bug 1289957 (Part 2) - Notify RasterImage about new frames in NotifyProgress() and remove OnAddedFrame(). r=edwin
2016-07-28 00:12:50 -07:00
Andrew Osmond
21a5312f01
Bug 1283462 - Fix race condition when notifying on image decoding progress. r=seth
2016-07-22 11:04:09 -04:00
Seth Fowler
09f83a51f9
Bug 1287691 (Part 4) - Leave notifying decoding progress for each frame to DecodingTask. r=edwin
2016-07-20 02:30:39 -07:00
Seth Fowler
60b6148b2d
Bug 1287691 (Part 1) - Expose yielding to decoding tasks. r=edwin
2016-07-20 02:30:33 -07:00
Makoto Kato
c4a50472e0
Backed out 4 changesets (bug 1287691) due to Windows build failure
...
MozReview-Commit-ID: KgV3nU9a64F
2016-07-20 11:03:59 +09:00
Seth Fowler
1f573d3fd9
Bug 1287691 (Part 4) - Leave notifying decoding progress for each frame to DecodingTask. r=edwin
2016-07-19 17:15:01 -07:00
Seth Fowler
57735f70e8
Bug 1287691 (Part 1) - Expose yielding to decoding tasks. r=edwin
2016-07-19 17:15:01 -07:00
Seth Fowler
8b1954cb87
Bug 1282259 - Run IDecodingTasks instead of Decoders directly in image::DecodePool. r=dholbert
2016-06-29 13:46:27 -07:00
Timothy Nikkel