firefox/testing/web-platform/tests/css/css-layout-api/multicol-fieldset-crash.https.html at 0917ddfc802da24cab5d63f0fcccdbe34494de6f - firefox - Free-Git: For Devs Not Bully

HeyPuter/firefox

0 Fork 0

mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00

Files

T

Morten Stenshorne 87ec3977c6 Bug 1717489 [wpt PR 29448] - Properly disallow custom layout + multicol, attempt 2., a=testonly

Automatic update from web-platform-tests
Properly disallow custom layout + multicol, attempt 2.

CL:2964675 wasn't enough for fieldsets that attempted both multicol and
custom layout, since the column properties are inherited by the
anonymous fieldset contents wrapper (while custom layout isn't
inherited).

Move checks from CreateOrDestroyMultiColumnFlowThreadIfNeeded() to a
separate method, so that the fieldset code can call it and make sure
that we don't let the anonymous wrapper inherit column properties in
custom layout.

Also add a DCHECK to catch any remaining bugs like this earlier (when
building the layout tree, rather than in paint).

Bug: 1221885
Change-Id: Ibdf07cea4932e165fd15ccf131c1ab06984d7dd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2975442
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#894578}

--

wpt-commits: eff11175076d956b4067cd6ebcc6e24fe6ee09b3
wpt-pr: 29448

2021-06-26 22:33:18 +00:00

9 lines

302 B

HTML

Raw Blame History

 <!DOCTYPE html>
 <link rel="author" title="Morten Stenshorne" href="mailto:[email protected]">
 <link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1221885">
 <div style="columns:2;">
   <fieldset style="display:layout(child-layout); columns:2;">
     BOO!
   </fieldset>
 </div>