1 Contributions
Subho Halder edited this page 2017-03-06 16:51:11 +05:30

Pull Requests

  • Before raising a PR search if there is a similar PR raised already
  • Make your changes to your local fork, and raise PR against it.
  • Try to summarize the changes being proposed in the PR.

Commits

  • A commit should represent one logical unit of change/addition. If you are a frequent committer, squash your commits before pushing. Maintain a clean project history tree.
  • When composing commit messages (read this in entirety):
    • Separate subject from body with a blank line
    • Limit the subject line to 50 characters
    • Capitalize the subject line
    • Do not end the subject line with a period
    • Use the imperative mood in the subject line
    • Wrap the body at 72 characters
    • Use the body to explain what & why vs. how