Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-17 07:15:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1652870 - permit DUMP_SYMS to be used when doing Android builds; r=mhentges

Browse Source 
It's not immediately obvious to me why we limit this check based on target;
I guess once upon a time there was no ELF or Mach-O support, so we wanted to
ensure people didn't shoot themselves in the foot.  If that's the case,
testing indicates that Mach-O support isn't quite ready for prime-time and
we haven't got all the bits straightened out for our normal Linux builds.
So we're just going to enable it for Android here.

Differential Revision: https://phabricator.services.mozilla.com/D83560
This commit is contained in:
Nathan Froyd 2020-07-15 12:58:52 +00:00
parent 49e2835914
commit 0a32331ddf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
toolkit/moz.configure
View File

@ -1967,7 +1967,7 @@ set_define('MOZ_RUST_FXA_CLIENT', True, when=rust_fxa_client)
# ============================================================== # ==============================================================
check_prog('DUMP_SYMS', ['dump_syms'], allow_missing=True, paths=toolchain_search_path, check_prog('DUMP_SYMS', ['dump_syms'], allow_missing=True, paths=toolchain_search_path,
when=compile_environment & target_is_windows) when=compile_environment & (target_is_windows | target_is_android))
check_prog('PDBSTR', ['pdbstr.exe'], allow_missing=True, paths=toolchain_search_path, check_prog('PDBSTR', ['pdbstr.exe'], allow_missing=True, paths=toolchain_search_path,