Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 21:01:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

no bug - reviews doc: Add some missing groups + polish r=glob DONTBUILD

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D64373

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Sylvestre Ledru 2020-02-26 16:01:08 +00:00
parent 53f7daba4b
commit 6b925c7d59
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/contributing/reviews.rst
View File

@ -5,7 +5,7 @@ Getting reviews
Thorough code reviews are one of Mozilla's ways of ensuring code quality. Thorough code reviews are one of Mozilla's ways of ensuring code quality.
Every patch must be reviewed by the module owner of the code, or one of their designated peers. Every patch must be reviewed by the module owner of the code, or one of their designated peers.
To request a review, you will need to specify a review group. If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI. To request a review, you will need to specify a review group (starts with #). If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI.
If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf. If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf.
Getting attention: If a reviewer doesn't respond within a week, or so of the review request: Getting attention: If a reviewer doesn't respond within a week, or so of the review request:
@ -39,6 +39,9 @@ Review groups
* - #firefox-source-docs-reviewers * - #firefox-source-docs-reviewers
- Documentation files and its build - Documentation files and its build
- `Member list <https://phabricator.services.mozilla.com/project/members/118/>`__ - `Member list <https://phabricator.services.mozilla.com/project/members/118/>`__
* - #firefox-style-system-reviewers
- Firefox style system
- `Member list <https://phabricator.services.mozilla.com/project/members/90/>`__
* - #firefox-ux-team * - #firefox-ux-team
- User experience (UX) - User experience (UX)
- `Member list <https://phabricator.services.mozilla.com/project/members/91/>`__ - `Member list <https://phabricator.services.mozilla.com/project/members/91/>`__
@ -48,6 +51,9 @@ Review groups
* - #geckoview-reviewers * - #geckoview-reviewers
- Changes to GeckoView - Changes to GeckoView
- `Member list <https://phabricator.services.mozilla.com/project/members/92/>`__ - `Member list <https://phabricator.services.mozilla.com/project/members/92/>`__
* - #intermittent-reviewers
- Test manifest changes
- `Member list <https://phabricator.services.mozilla.com/project/members/110/>`__
* - #linter-reviewers * - #linter-reviewers
- tools/lint/* - tools/lint/*
- `Member list <https://phabricator.services.mozilla.com/project/members/119/>`__ - `Member list <https://phabricator.services.mozilla.com/project/members/119/>`__
@ -79,5 +85,5 @@ Review groups
- Changes related to WebIDL - Changes related to WebIDL
- `Member list <https://phabricator.services.mozilla.com/project/members/112/>`__ - `Member list <https://phabricator.services.mozilla.com/project/members/112/>`__
To create a new group, fill a `new bug in Conduit::Phabricator <https://bugzilla.mozilla.org/enter_bug.cgi?product=Conduit&component=Administration>`__. To create a new group, fill a `new bug in Conduit::Administration <https://bugzilla.mozilla.org/enter_bug.cgi?product=Conduit&component=Administration>`__.
See `bug 1613306 <https://bugzilla.mozilla.org/show_bug.cgi?id=1613306>`__ as example. See `bug 1613306 <https://bugzilla.mozilla.org/show_bug.cgi?id=1613306>`__ as example.