Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 06:43:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1932284 - Revert url verifications in UI tests r=ohorvath

Browse Source 
28 UI tests started to fail all of a sudden after [[ https://phabricator.services.mozilla.com/D229397#change-b6xmo9pT7DsO | this ]] change landed.

The failures were caused by the change that was done to **verifyUrl**.
  - The change wasn't needed, as Ben didn't take use of it anywhere
  - _url.host in that format will return null, if the protocol isn't added to the url it can't be parsed properly

Since these sort of changes weren't on our radar and since Ben doesn't need them in his new UI tests, I've reverted back the change related to **verifyUrl**
If we want to make that sort of changes when verifying the url's I can refactor the function and the existing UI tests in a separate diff.

All UI tests successfully passed 1x on Firebase ✅

In the [[ https://phabricator.services.mozilla.com/D229397#7933912 | try ]] mentioned here, only the new UI test ran,  and that's why the other failures flew under the radar

Differential Revision: https://phabricator.services.mozilla.com/D229589
This commit is contained in:
AndiAJ 2024-11-20 10:22:17 +00:00
parent 1896a9a633
commit 6d9c02e321
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt
View File

@ -72,7 +72,6 @@ import org.mozilla.fenix.helpers.click
import org.mozilla.fenix.helpers.ext.waitNotNull
import org.mozilla.fenix.settings.SupportUtils
import org.mozilla.fenix.tabstray.TabsTrayTestTag
import java.net.URI
import java.time.LocalDate
class BrowserRobot {
@ -89,7 +88,6 @@ class BrowserRobot {
fun verifyUrl(url: String) {
sessionLoadedIdlingResource = SessionLoadedIdlingResource()
var _url = URI(url)
registerAndCleanupIdlingResources(sessionLoadedIdlingResource) {
// Check if toolbar is displayed
@ -112,7 +110,7 @@ class BrowserRobot {
assertUIObjectExists(
itemWithResIdContainingText(
"$packageName:id/mozac_browser_toolbar_url_view",
_url.host,
url.replace("http://", ""),
),
)
}