mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-02-17 06:09:19 +00:00
6d9c02e321
28 UI tests started to fail all of a sudden after [[ https://phabricator.services.mozilla.com/D229397#change-b6xmo9pT7DsO | this ]] change landed. The failures were caused by the change that was done to **verifyUrl**. - The change wasn't needed, as Ben didn't take use of it anywhere - _url.host in that format will return null, if the protocol isn't added to the url it can't be parsed properly Since these sort of changes weren't on our radar and since Ben doesn't need them in his new UI tests, I've reverted back the change related to **verifyUrl** If we want to make that sort of changes when verifying the url's I can refactor the function and the existing UI tests in a separate diff. All UI tests successfully passed 1x on Firebase ✅ In the [[ https://phabricator.services.mozilla.com/D229397#7933912 | try ]] mentioned here, only the new UI test ran, and that's why the other failures flew under the radar Differential Revision: https://phabricator.services.mozilla.com/D229589
An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:
https://firefox-source-docs.mozilla.org/contributing/directory_structure.html
For information on how to build Firefox from the source code and create the patch see:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.
Nightly development builds can be downloaded from:
https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
- or -
https://www.mozilla.org/firefox/channel/desktop/#nightly
Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.