Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-04 07:40:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1786465 - Fix code to silence static-analysis warnings; r=dom-storage-reviewers,jesup

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D156889
This commit is contained in:
Jan Varga 2022-09-11 12:00:17 +00:00
parent 85731c0de9
commit 75a3688522
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dom/fs/shared/FileSystemHelpers.h
View File

@ -74,13 +74,13 @@ class Registered {
} }
} }
Registered() {} Registered() = default;
Registered(const Registered& aOther) : mObject(aOther.mObject) { Registered(const Registered& aOther) : mObject(aOther.mObject) {
mObject->Register(); mObject->Register();
} }
Registered(Registered&& aOther) = default; Registered(Registered&& aOther) noexcept = default;
MOZ_IMPLICIT Registered(RefPtr<T> aObject) : mObject(std::move(aObject)) { MOZ_IMPLICIT Registered(RefPtr<T> aObject) : mObject(std::move(aObject)) {
if (mObject) { if (mObject) {
@ -109,7 +109,7 @@ class Registered {
return *this; return *this;
} }
Registered<T>& operator=(Registered<T>&& aRhs) { Registered<T>& operator=(Registered<T>&& aRhs) noexcept {
RefPtr<T> oldObject = std::move(mObject); RefPtr<T> oldObject = std::move(mObject);
mObject = std::move(aRhs.mObject); mObject = std::move(aRhs.mObject);
aRhs.mObject = nullptr; aRhs.mObject = nullptr;

2
dom/fs/test/gtest/FileSystemMocks.h
View File

@ -46,7 +46,7 @@ GTEST_API_ ::testing::AssertionResult CmpHelperSTREQ(const char* s1_expression,
namespace mozilla::dom::fs { namespace mozilla::dom::fs {
inline std::ostream& operator<<(std::ostream& aOut, inline std::ostream& operator<<(std::ostream& aOut,
const FileSystemEntryMetadata aMetadata) { const FileSystemEntryMetadata& aMetadata) {
return aOut; return aOut;
} }