Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 12:25:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1392745: verify mid presence in inactive m-section r=mjf

Browse Source 
MozReview-Commit-ID: 7XISDzZCirr

--HG--
extra : rebase_source : a786be541a31edac05647fe2ee4d0c63c982d3d0
This commit is contained in:
Nils Ohlmeier [:drno] 2017-08-22 14:22:52 -07:00
parent 240ea1983a
commit 776005a2ec
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
media/webrtc/signaling/gtest/jsep_session_unittest.cpp
View File

@ -1003,10 +1003,14 @@ protected:
ValidateDisabledMSection(const SdpMediaSection* msection)
{
ASSERT_EQ(1U, msection->GetFormats().size());
// Maybe validate that no attributes are present except rtpmap and
// inactive? How?
auto& attrs = msection->GetAttributeList();
ASSERT_TRUE(attrs.HasAttribute(SdpAttribute::kMidAttribute));
ASSERT_TRUE(attrs.HasAttribute(SdpAttribute::kDirectionAttribute));
ASSERT_EQ(SdpDirectionAttribute::kInactive,
msection->GetDirectionAttribute().mValue);
// attribute list is missing a length function to check if these are
// all the attributes in it
if (msection->GetMediaType() == SdpMediaSection::kAudio) {
ASSERT_EQ("0", msection->GetFormats()[0]);
const SdpRtpmapAttributeList::Rtpmap* rtpmap(msection->FindRtpmap("0"));