Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 13:55:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't do unneeded work in nsImageFrame::AttributeChanged. Bug 261723, r+sr=roc

Browse Source
This commit is contained in:
bzbarsky%mit.edu 2004-09-30 19:23:40 +00:00
parent 61feb80622
commit e0dc15e288
2 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
layout/generic/nsImageFrame.cpp
View File

@ -1780,12 +1780,11 @@ nsImageFrame::AttributeChanged(nsPresContext* aPresContext,
nsresult rv = nsSplittableFrame::AttributeChanged(aPresContext, aChild,
aNameSpaceID, aAttribute,
aModType);
if (NS_OK != rv) {
if (NS_FAILED(rv)) {
return rv;
}
// XXXldb Shouldn't width and height be handled by attribute mapping?
if (nsHTMLAtoms::width == aAttribute || nsHTMLAtoms::height == aAttribute || nsHTMLAtoms::alt == aAttribute)
{ // XXX: could check for new width == old width, and make that a no-op
if (nsHTMLAtoms::alt == aAttribute)
{
mState |= NS_FRAME_IS_DIRTY;
mParent->ReflowDirtyChild(aPresContext->PresShell(), (nsIFrame*) this);
}

7
layout/html/base/src/nsImageFrame.cpp
View File

@ -1780,12 +1780,11 @@ nsImageFrame::AttributeChanged(nsPresContext* aPresContext,
nsresult rv = nsSplittableFrame::AttributeChanged(aPresContext, aChild,
aNameSpaceID, aAttribute,
aModType);
if (NS_OK != rv) {
if (NS_FAILED(rv)) {
return rv;
}
// XXXldb Shouldn't width and height be handled by attribute mapping?
if (nsHTMLAtoms::width == aAttribute || nsHTMLAtoms::height == aAttribute || nsHTMLAtoms::alt == aAttribute)
{ // XXX: could check for new width == old width, and make that a no-op
if (nsHTMLAtoms::alt == aAttribute)
{
mState |= NS_FRAME_IS_DIRTY;
mParent->ReflowDirtyChild(aPresContext->PresShell(), (nsIFrame*) this);
}