Commit Graph

686894 Commits

Author SHA1 Message Date
Nicolas Silva
00a1d72d5c Bug 1607697 - Pass-by-value clippy lints for some small structures. r=Gankro
Differential Revision: https://phabricator.services.mozilla.com/D59116

--HG--
extra : moz-landing-system : lando
2020-01-08 15:41:12 +00:00
Nicolas Silva
e78fd8f034 Bug 1607697 - Address clippy lints about nested branches. r=Gankro
Differential Revision: https://phabricator.services.mozilla.com/D59115

--HG--
extra : moz-landing-system : lando
2020-01-08 15:40:57 +00:00
Nicolas Silva
889e5a96f2 Bug 1607697 - Address unwrap_or_else(callback) and functions in callback clippy lints. r=Gankro
I don't think it makes much of a difference but clippy is quite vocal about it.

Differential Revision: https://phabricator.services.mozilla.com/D59114

--HG--
extra : moz-landing-system : lando
2020-01-08 15:40:47 +00:00
Nicolas Silva
e766dafdba Bug 1607697 - Allow excessive precision in debug color constants. r=Gankro
Addresses a clippy lint.

Differential Revision: https://phabricator.services.mozilla.com/D59113

--HG--
extra : moz-landing-system : lando
2020-01-08 15:40:35 +00:00
Nicolas Silva
e150242967 Bug 1607697 - Remove leading zeros in dither matrix litterals. r=Gankro
Addresses a clippy lint.

Differential Revision: https://phabricator.services.mozilla.com/D59112

--HG--
extra : moz-landing-system : lando
2020-01-08 15:44:49 +00:00
Nicolas Silva
677406e7b7 Bug 1607697 - Address some clippy lints in WebRender API. r=Gankro
Differential Revision: https://phabricator.services.mozilla.com/D59101

--HG--
extra : moz-landing-system : lando
2020-01-08 15:40:15 +00:00
Yaron Tausky
877a273a69 Bug 1603976 - Warn when getting session storage data for discarded browsing context r=dom-workers-and-storage-reviewers,sg,janv
Under some (yet) unclear conditions it's possible for a content
process to send session storage data for a browsing context that's
already been discarded. This leads to an assertion failure when
deserializing the IPC message. This commit works around this issue
by sending the browsing context's ID over IPC and issuing a warning
instead of asserting that the browsing context still exists.

Differential Revision: https://phabricator.services.mozilla.com/D59096

--HG--
extra : moz-landing-system : lando
2020-01-08 15:38:34 +00:00
Alexandre Poirot
ac81342020 Bug 1598022 - Make TargetList follow devtools.contenttoolbox.fission preference. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D53985

--HG--
extra : moz-landing-system : lando
2020-01-08 15:30:44 +00:00
Alexandre Poirot
8ce8885c9b Bug 1598022 - Make listRemoteFrames to return only remote frames. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D59087

--HG--
extra : moz-landing-system : lando
2020-01-08 15:30:36 +00:00
Alexandre Poirot
9b215e2345 Bug 1598022 - Revisit TargetList.startListening in order to bundle in the type being listened. r=jdescottes
Before, each callsite had to mention which type it would like to listen to.
But at the same time, TargetList was gating this listening via the devtools fission preference.
It sounds easier if all the logic to define if we are listening to additional targets
and which types is written in one place.

Differential Revision: https://phabricator.services.mozilla.com/D57009

--HG--
extra : moz-landing-system : lando
2020-01-08 15:30:34 +00:00
Henrik Skupin
210002ad71 Bug 1596136 - [remote] "Emulation.setUserAgentOverride" should only affect the current target. r=remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D58164

--HG--
extra : moz-landing-system : lando
2020-01-08 14:04:55 +00:00
Henrik Skupin
2248eb2510 Bug 1596136 - [remote] Remove openTab() and openWindow() helpers from target tests head.js. r=remote-protocol-reviewers,ato
Bug 1605722 already added those helpers to the global head.js file.
As such they can be removed from the target's head.js file.

Differential Revision: https://phabricator.services.mozilla.com/D58163

--HG--
extra : moz-landing-system : lando
2020-01-08 13:26:42 +00:00
Emilio Cobos Álvarez
f210527c4f Bug 1607595 - Manual fixups, and remove mozilla::IsBaseOf. r=froydnj
This is manual, but hopefully trivial.

Differential Revision: https://phabricator.services.mozilla.com/D59014

--HG--
extra : moz-landing-system : lando
2020-01-08 14:52:18 +00:00
Emilio Cobos Álvarez
e363a41bd4 Bug 1607595 - Remove uses of mozilla::IsBaseOf. r=froydnj
Automatically generated by:

$ rg 'IsBaseOf<' | cut -d : -f 1 | xargs sed -i 's/mozilla::IsBaseOf</std::is_base_of</g'
$ rg 'IsBaseOf<' | cut -d : -f 1 | xargs sed -i 's/IsBaseOf</std::is_base_of</g

Differential Revision: https://phabricator.services.mozilla.com/D59013

--HG--
extra : moz-landing-system : lando
2020-01-08 14:52:10 +00:00
Michal Novotny
40a21eea5b Bug 1519126 - Intermittent GECKO(1168) | Assertion failure: !chunk->IsReady() r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D58533

--HG--
extra : moz-landing-system : lando
2020-01-08 14:09:33 +00:00
Emilio Cobos Álvarez
0c05013f04 Bug 1607701 - Remove unused old version of proc-macro2 from the workspace hack. r=froydnj
This also removes an old version of unicode-xid :)

Differential Revision: https://phabricator.services.mozilla.com/D59090

--HG--
extra : moz-landing-system : lando
2020-01-08 13:43:50 +00:00
Christoph Kerschbaumer
8335b185aa Bug 1585533: Add debug statements to fix intermittent test failure on fission for test_upgrade_insecure_reporting.html. r=jkt
Differential Revision: https://phabricator.services.mozilla.com/D59099

--HG--
extra : moz-landing-system : lando
2020-01-08 13:38:56 +00:00
Daniel Varga
9991e5cc37 Bug 1581862 - Updated disable for browser_windowProxy_transplant.js on macosx when Fission is not enabled. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D59081

--HG--
extra : moz-landing-system : lando
2020-01-08 11:04:31 +00:00
Gijs Kruitbosch
b4664fb355 Bug 1604780 - fix full size thumbnail functionality so we don't draw a 0x0 canvas, r=dao
In WindowsPreviewPerTab, requestPreview calls resetCanvasPreview and then updateCanvasPreview.
https://searchfox.org/mozilla-central/rev/a92ed79b0bc746159fc31af1586adbfa9e45e264/browser/modules/WindowsPreviewPerTab.jsm#294-295

The former sets the preview canvas' size to 0x0. In updateCanvasPreview, we then ask to captureToCanvas,
and we end up in _captureRemoteThumbnail, which uses the passed aWidth and aHeight to size the destination
canvas. Unfortunately, those are 0. We should ignore this size when the fullScale argument is passed, and
in that case just use the content width and height directly instead.

Differential Revision: https://phabricator.services.mozilla.com/D59060

--HG--
extra : moz-landing-system : lando
2020-01-08 12:50:23 +00:00
Julian Descottes
360d17dcf8 Bug 1604491 - Additional cleanup in browser-toolbox/window.js r=ochameau
Depends on D58237

Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eabbe90d1384eaafeb37dd9038e52e8973fc60a

Differential Revision: https://phabricator.services.mozilla.com/D58238

--HG--
extra : moz-landing-system : lando
2020-01-08 12:16:20 +00:00
Julian Descottes
ebdb7a2d0f Bug 1604491 - Remove Toolbox::setBrowserToolbox, use host type to check if BrowserToolbox r=ochameau
Depends on D58236

Differential Revision: https://phabricator.services.mozilla.com/D58237

--HG--
extra : moz-landing-system : lando
2020-01-08 12:16:02 +00:00
Julian Descottes
502a2faa1f Bug 1604491 - Implement host raise/setTitle for browsertoolbox host r=ochameau
Depends on D58235. Move browsertoolbox host logic directly to browsertoolbox host

Differential Revision: https://phabricator.services.mozilla.com/D58236

--HG--
extra : moz-landing-system : lando
2020-01-08 12:58:55 +00:00
Julian Descottes
986ddfa2b7 Bug 1604491 - Rename CUSTOM DevTools host to BROWSERTOOLBOX r=ochameau
Only renaming methods/variables/files here.

Differential Revision: https://phabricator.services.mozilla.com/D58235

--HG--
rename : devtools/client/framework/test/browser_toolbox_custom_host.js => devtools/client/framework/test/browser_toolbox_browsertoolbox_host.js
extra : moz-landing-system : lando
2020-01-08 11:28:12 +00:00
Nicolas B. Pierron
4d28336850 Bug 1607146 - Make annotateOOMSizeCallback a relaxed atomic value. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D58944

--HG--
extra : moz-landing-system : lando
2020-01-08 13:26:13 +00:00
Emilio Cobos Álvarez
e7783b322a Bug 1607557 - Make labels and button inline level. r=Gijs
<xul:description> doesn't respect `display` and effectively behaves like
`display: flow-root` unless it has the `value` attribute.

<xul:label> and <xul:button> are expected to be inline level when in HTML
blocks.

The former fixes the about dialog. The later fixes the session restore page,
which in today's nightly shows the two buttons in different lines.

I could try to write more targeted fixes if you want, and probably switching to
html layout while at it.

<label> can be display: inline, at least in the about dialog. And the
<xul:button> in the restore session page can be <html:buttons> (inline-blocks).

But then again the involved elements always create specific layout boxes
disregarding display, so this patch does effectively the same.

Differential Revision: https://phabricator.services.mozilla.com/D59093

--HG--
extra : moz-landing-system : lando
2020-01-08 12:17:07 +00:00
Brian Grinstead
c777fd4ce8 Bug 1607181 - eagerly set [smoothscroll] on arrowscrollbox instead of waiting for the getter to be called;r=dao
The XBL implementation set the attribute in the constructor if it wasn't already:
- https://hg.mozilla.org/mozilla-central/file/94eaa02e0ea1725512893cd5139b1d200fcf4fdd/toolkit/content/widgets/scrollbox.xml#l34.

In the Custom Element conversion this check was moved into the getter, which isn't called until a scrollbutton is clicked,
which meant that we'd get non-smooth scrolling if just mousewheeling the button. I can't find any reason for intentionally
changing that in the bug or review, so I think it was just an oversight.

Differential Revision: https://phabricator.services.mozilla.com/D58985

--HG--
extra : moz-landing-system : lando
2020-01-08 13:15:32 +00:00
pbz
9f91b02a4c Bug 1591748 - Added test for oa strip permission list. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D58832

--HG--
extra : moz-landing-system : lando
2020-01-08 12:17:05 +00:00
pbz
2945018d83 Bug 1591748 - nsPermissionMgr: Added principal oa strip permission list for userContext and privateBrowsing. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D58831

--HG--
extra : moz-landing-system : lando
2020-01-08 13:06:28 +00:00
Brian Hackett
f258769124 Bug 1607297 - Don't include file contents from the firefox install directory in recordings, r=jlast.
Differential Revision: https://phabricator.services.mozilla.com/D58874

--HG--
extra : moz-landing-system : lando
2020-01-08 12:46:19 +00:00
Nicolas Chevobbe
2ee7537e3e Bug 1597955 - Remove ConsoleTable methods for pre-Firefox 72 backward compatibility. r=rcaliman.
This removes all the now unnecessary props, methods and functions
we had to support pre-72 servers.

Differential Revision: https://phabricator.services.mozilla.com/D59083

--HG--
extra : moz-landing-system : lando
2020-01-08 11:30:37 +00:00
Patrick Brosset
bc984989e9 Bug 1605342 - Let RDM's metaviewport handling ride the trains r=bradwerth
After the gradual rollout of the feature in 72, we can turn it on for all users

Differential Revision: https://phabricator.services.mozilla.com/D58943

--HG--
extra : moz-landing-system : lando
2020-01-07 22:01:56 +00:00
Henrik Skupin
15e30b89a5 Bug 1607461 - [remote] Implement Network.setCacheDisabled. r=remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D58996

--HG--
extra : moz-landing-system : lando
2020-01-08 12:40:49 +00:00
Martin Stransky
654ba476fb Bug 1607721 [Wayland] Check default nsWaylandDisplay for an actual display type, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D59098

--HG--
extra : moz-landing-system : lando
2020-01-08 12:30:48 +00:00
Henrik Skupin
986231c6dc Bug 1596601 - [remote] Skip some more crashing Puppeteer unit tests. r=remote-protocol-reviewers,ato
Depends on D59006

Differential Revision: https://phabricator.services.mozilla.com/D59088

--HG--
extra : moz-landing-system : lando
2020-01-08 12:14:57 +00:00
Henrik Skupin
c01d481fbf Bug 1596601 - [remote] Add place-holder for Page.setInterceptFileChooserDialog. r=remote-protocol-reviewers,ato
This feature is experimental and not required to get implemented
on our end as of now. As such adding a place-holder will be enough.

Differential Revision: https://phabricator.services.mozilla.com/D59006

--HG--
extra : moz-landing-system : lando
2020-01-08 11:01:17 +00:00
alexandru.ionescu
afa20661a0 Bug 1607254 Add firefox warm page load tests back on mozilla-central r=davehunt,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D59095

--HG--
extra : moz-landing-system : lando
2020-01-08 12:20:37 +00:00
Sylvestre Ledru
7ce533a642 Bug 1607592 - Disable some unused NSPR files in the Firefox build r=kaie
Differential Revision: https://phabricator.services.mozilla.com/D59012

--HG--
extra : moz-landing-system : lando
2020-01-08 11:47:30 +00:00
Carolina
3d5136ed5a Bug 1595133 - Moved repetead functions to head.js.r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D57663

--HG--
extra : moz-landing-system : lando
2020-01-08 11:36:09 +00:00
Andreas Tolfsen
e221feba47 bug 1607500: remote: preserve task name in add_agent_task() r=remote-protocol-reviewers,whimboo
Similarly to bug 1603451, the name of the function passed to the
specialised add_agent_task() is lost because of the anonymous
function wrapper inside.

Differential Revision: https://phabricator.services.mozilla.com/D58967

--HG--
extra : moz-landing-system : lando
2020-01-08 08:34:46 +00:00
Emma Malysz
290bc505ff Bug 1607441, ensure pinned tabs order is correct by updating their position attribute r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D59068

--HG--
extra : moz-landing-system : lando
2020-01-08 10:48:43 +00:00
Andy Wingo
df9949d6ea Bug 1603140 - Add multi-value return epilogue to baseline compiler r=lth
This commit enables multi-value returns in baseline-to-baseline calls.

Differential Revision: https://phabricator.services.mozilla.com/D57092

--HG--
extra : moz-landing-system : lando
2020-01-08 10:15:57 +00:00
Mirko Brodesser
935aed6418 Bug 1600267: part 17) Call ComparePoints instead of ComparePoints_Deprecated in nsFrameSelection. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58916

--HG--
extra : moz-landing-system : lando
2020-01-08 10:15:46 +00:00
Mirko Brodesser
9ba8ea8e7a Bug 1600267: part 16) Call ComparePoints instead of ComparePoints_Deprecated in AccessibleCaretManager. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58915

--HG--
extra : moz-landing-system : lando
2020-01-08 10:22:19 +00:00
Mirko Brodesser
629b1f630b Bug 1600267: part 15) Call ComparePoints instead of ComparePoints_Deprecated in TextServicesDocument. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D58913

--HG--
extra : moz-landing-system : lando
2020-01-08 10:22:19 +00:00
Mathieu Leplatre
6127fc1ca7 Bug 1569281 - Fix intermittent failure on Normandy Recipe Runner tests r=mythmon,mconley
Differential Revision: https://phabricator.services.mozilla.com/D57984

--HG--
extra : moz-landing-system : lando
2020-01-07 21:01:00 +00:00
Mirko Brodesser
5675fea9e5 Bug 1600267: part 14) Call ComparePoints instead of ComparePoints_Deprecated in WSRunScanner. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D58912

--HG--
extra : moz-landing-system : lando
2020-01-08 09:49:11 +00:00
Mirko Brodesser
7410ac5cd6 Bug 1600267: part 13) Call ComparePoints instead of ComparePoints_Deprecated in HTMLEditor. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D58911

--HG--
extra : moz-landing-system : lando
2020-01-08 09:49:11 +00:00
Nicolas Chevobbe
7f2f52e294 Bug 1607448 - Properly wait for messages to be evaluated in browser_webconsole_reverse_search_keyboard_navigation. r=Honza.
Without this patch, sometimes the result messages were
added as the toolbox was closing, which emits very long
messages from the ignore middleware, making parsing logs
almost impossible.

Differential Revision: https://phabricator.services.mozilla.com/D58950

--HG--
extra : moz-landing-system : lando
2020-01-08 09:48:55 +00:00
Tetsuharu OHZEKI
d05bf2278f Bug 1597410 - Fix uses of nsIDocShellTreeItem in mozilla::dom::Document::IsThirdPartyForFlashClassifier in dom/base/Document.cpp. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D58952

--HG--
extra : moz-landing-system : lando
2020-01-08 09:37:33 +00:00
Itiel
62d46e9ea1 Bug 1607580 - Make the download folder box height the same as the Browse... button r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D59011

--HG--
extra : moz-landing-system : lando
2020-01-08 09:43:21 +00:00