- Cleaned up some comments.
- Changed some const nsACString& parameter types to nsCString to accept r-value
and l-value nsCStrings.
Differential Revision: https://phabricator.services.mozilla.com/D58877
--HG--
extra : moz-landing-system : lando
Add a script block to prevent reflow observers from running the scripts,
which may flush layout, until the end of DidDoReflow().
Specifically, Document::MaybeInitializeFinalizeFrameLoaders() can flush
layout somewhere down in the stack as bug 1606492 comment 0 shows.
Adding a script block can force it to schedule its runnable to run at
the end of DidDoReflow().
Also, HandlePostedReflowCallbacks() can flush layout. It's better to check
`mIsDestroying` before proceeding.
Differential Revision: https://phabricator.services.mozilla.com/D59015
--HG--
extra : moz-landing-system : lando
Nowadays, ColumnSetFrame is an inner frame under ColumnSetWrapperFrame.
It always has "block-size: auto", so `aReflowInput.ComputedBSize()`
always equals to NS_UNCONSTRAINEDSIZE.
Also, -moz-column-content no longer has "max-block-size: 100%", so
NS_FRAME_CONTAINS_RELATIVE_BSIZE can never be set on ColumnSetFrame when
constructing ReflowInputs for ColumnSetFrame's children in
`ReflowInput::InitResizeFlags`. Removing the bit is not needed, either.
Differential Revision: https://phabricator.services.mozilla.com/D58732
--HG--
extra : moz-landing-system : lando
Simply remove "max-block-size: 100%" for -moz-column-set and
-moz-column-content breaks abspos-breaking-dynamic-{001,002,003}.html.
We need to reflow ColumnSetWrapper's children whenever
ColumnSetWrapper's block-size or max-block-size is changed because both
size affect the available block-size for ColumnSetWrapper's children.
We set `NS_FRAME_CONTAINS_RELATIVE_BSIZE` for ColumnSetWrapperFrame so
that it will set itself dirty in `selfDirty` in
`nsBlockFrame::ReflowDirtyLines`, and mark its lines dirty if
`aState.mReflowInput.IsBResize()` is true.
Differential Revision: https://phabricator.services.mozilla.com/D58731
--HG--
extra : moz-landing-system : lando
Note that this also implicitly adds support for the view-source+srcdoc configuration, and setting of the BaseURI, which were both in the nsDocShell version but not the others.
Differential Revision: https://phabricator.services.mozilla.com/D57887
--HG--
extra : moz-landing-system : lando
It's possible that `self` is the last pointer holding the media cache, so we have to ensure releasing `self` on main thread because media cache should always be destroyed on main thread only.
Differential Revision: https://phabricator.services.mozilla.com/D58900
--HG--
extra : moz-landing-system : lando
Now that we have UTF8String in the WebIDL, we can remove quite a few of the
conversions. Do that, and lift the remaining string conversions up as needed.
Also deindent Servo_ComputeColor while touching it.
Most of the remaining copies are because either bug 1606994, or because they're
WebIDL attributes that we still need to serialize back as UTF-16 (bug 1606995).
Differential Revision: https://phabricator.services.mozilla.com/D58687
--HG--
extra : moz-landing-system : lando
Automatic update from web-platform-tests
HTML: attempt to make COEP test less flaky
Hopefully addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1605382.
--
wpt-commits: e8fdcbaf22bf28238bb126d84bc960fe9625fe02
wpt-pr: 21021
Automatic update from web-platform-tests
[webnfc] Add several wpt tests
This CL adds several wpt tests for Web NFC:
- Test push operation fails when data transfer fails
- Verify pushed message for empty record type
- Test reading message with multiple records should succeed
Bug: 520391
Change-Id: Iadb13f6cebaf30514ba7bef65a69302b368e4359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982271
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#728434}
--
wpt-commits: 3488a5a845bec08943f66974e9f0df4ffe96774a
wpt-pr: 20921
Automatic update from web-platform-tests
Revert LayoutInline::CollectLineBoxRects
This patch reverts |LayoutInline::CollectLineBoxRects| not to
use |NGInlineCursor|, by manually merging parts of r706815
<crrev.com/c/1862534> and r710694 <crrev.com/c/1888624>.
|NGInlineCursor| is rapidly changing that reverting is not
easy. This patch reverts not to use it for |getClientRects|
and a few other callers.
Testing more on culled inline box indicates that the phase 1
of LayoutNG regressed some cases from legacy, and
|NGInlineCursor| work regressed further. We might want to fix
when NGFragmentItem ships, but better not to change the
behavior until then.
Bug: 1036358
Change-Id: I47a60f5d3a505d4b43eba0d8b5adc64e02cbcd28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971632
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728433}
--
wpt-commits: 280816c7465a6593f06f9f5651a70eb857f9f774
wpt-pr: 20892
Automatic update from web-platform-tests
Fix validity.valueMissing tests (#21031)
These changes fix expectations for validity.valueMissing and validity.valid for disabled/readonly textual elements. This fixes#21007.
--
wpt-commits: 31e82ba312dea8b0011237fd696d3c87c2015d65
wpt-pr: 21031
Automatic update from web-platform-tests
Use mozlog logger in FontInstaller
This is the right thing to do, and prevents a race where we try to log
after the stdout capture queue is closed
Differential Revision: https://phabricator.services.mozilla.com/D56567
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1598561
gecko-commit: 2a0e33dbb9c83f2444361497e86e7af7d69fef44
gecko-integration-branch: autoland
gecko-reviewers: maja_zf
--
Remove unused import
--
wpt-commits: fd7d1aaf7d490d8d0e9f039db02a530891112c5a, d24e7e551416c0adb313fd51070c6db4762949b8
wpt-pr: 20997
Automatic update from web-platform-tests
Handle multicol intrinsic inline-size changes.
This was broken both in legacy multicol and with
LayoutNGBlockFragmentation.
Legacy: We stored the intrinsic size in the column sets, in addition to
in the flow thread. There was no good reason for this, and it caused
trouble once something caused the intrinsic size of the multicol
container to change, since the column sets would never be marked dirty
again. Just set the intrinsic size of column sets to 0 to fix this.
LayoutNGBlockFragmentation: The flow thread is still created even if NG
block fragmentation is enabled, but the flow thread is invisible to NG,
so when calculating the intrinsic size of nodes in a subtree, we'll skip
the flow thread - which means that it will never be marked clean. Skip
to the containing block of the flow thread when marking preferred
logical widths dirty.
This fixes the remaining part of the demo in bug 1037790 - when trying
to reduce column-count to 1. Without this fix, the multicol container
would remain too wide.
Bug: 1037790
Change-Id: I89c7cbeb3132162b6c52ae30e98a0da21cd34ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985770
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728401}
--
wpt-commits: e30880f3341ca022f7009af13eb871872d02caaf
wpt-pr: 21009
Automatic update from web-platform-tests
Recalculate flow thread intrinsic size when parent needs it.
If the multicol container gets marked for intrinsic size recalculation,
its flow thread child might need to recalculate its intrinsic size as
well (the intrinsic inner size of a multicol container is stored in the
flow thread), although it may not have been marked as such. This
situation occurs when column-count changes.
Re-use the NeedsPreferredWidthsRecalculation() mechanism to fix this,
instead of inventing something new.
This fixes most of the demo in bug 1037790, except when attempting to
reduce column-count to 1.
https://chromium-review.googlesource.com/c/chromium/src/+/1985770/1
will fix that.
Bug: 1037790
Change-Id: I9d42448f8cc7a5b170c98a59bcde7a916cea22db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985769
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728390}
--
wpt-commits: 52ad8a87fb72bcf6950c20cced0d87f34e26dc81
wpt-pr: 21010
Automatic update from web-platform-tests
Editorial: start using blocklist
As per https://whatwg.org/style-guide.
(Some tools/third_party/ is also guilty of this, but is likely harder to change.)
--
wpt-commits: 3e77495f7f1920daa0c706e7b287dee0ef3279e2
wpt-pr: 21024
Automatic update from web-platform-tests
[image-orientation] Move tests to WPT and add additional tests
Move all the web_tests for image-orientation to external/wpt.
Update the testing methods to wpt standards.
Adjust the test images to be ammenable to ref tests, though fuzzy matching
is still required.
Round out the test suite for <img> tags, content images and image documents.
Bug: 158753
Change-Id: Iff393f350cbecfc66a91811c72b0ee6274289e5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980505
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728358}
--
wpt-commits: 04d020981550e59c6cd9dc5376b8630998d878ec
wpt-pr: 21034
Automatic update from web-platform-tests
Change ChooseFileSystemEntriesType to be lowercase, dash-delimited
Per the spec [1], the ChooseFileSystemEntriesType should be lowercase,
dash-delimited, such as `save-file`.
[1]: https://wicg.github.io/native-file-system/#api-choosefilesystementries
Bug: 1020715
Change-Id: Iafc02db7344c70589cf007a7d66b9cd3f9dda6a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981515
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cr-Commit-Position: refs/heads/master@{#728357}
--
wpt-commits: aa9924b906248e22f80da61a606ee8c473cadf38
wpt-pr: 20917
Automatic update from web-platform-tests
Add fake world test helper, misc other changes
Clean up and changes required to bring in WPT tests for hit test API.
- minor clean up in webxr-test.js - store input_sources_ in a map,
add 2 setter methods since the mojo properties were renamed but keep
the old setters for back-compat
- add webxr_test_constants_fake_world.js with logic to create a valid
FakeXRWorld with given dimensions and a constant VALID_FAKE_WORLD
- move transform-related asserts to webxr_test_asserts.js, change
all variables storing the assert functions to `const`, add semicolons
- add `DVLOG(3)`s in XRHitTestSource and XRSession
Changes:
Change-Id: I98ac5ed09cda877afb24e28df09ee4cd818d56f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986326
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728287}
--
wpt-commits: c5f090c0e768bccdc6b0c7711c4adc2d3311c230
wpt-pr: 21029
Automatic update from web-platform-tests
[LayoutInstability] Fix failures in tests shifting in/out of viewport
Currently, some tests work under the assumption that the height of the
viewport is exactly 600px. While this is true for tests running on our
bots, it's not true for tests running on WPT.fyi. Thus, this assumption
is removed from those tests.
Bug: 1036013
Change-Id: I34b057730e22bc208cbb958d179195445def8b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984678
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728280}
--
wpt-commits: 63f94078836eba226cdf0460b09482c8f9a6ae5d
wpt-pr: 21030
Automatic update from web-platform-tests
Fix test flakiness in reverse-running-animation
The animation was often finishing before the screenshot resulting in a
failure. Extended the duration of the animation and starting the
animation from the midpoint should address the flakiness without
needlessly extending the run time of the test.
Bug: 1029543
Change-Id: I32e7794ff77a3b26e7d7f260f80d4b00bbc9d6f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986212
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728253}
--
wpt-commits: b00f0cedac3a1e6dd42beb5884b303eac03e6c4b
wpt-pr: 21012
Automatic update from web-platform-tests
HTTP: 0x00 in a header value
Tests to complement those written in https://github.com/web-platform-tests/wpt/pull/10424.
--
wpt-commits: 38ecde806a5f1710d9e5beba700cef7352f7570e
wpt-pr: 21019
Automatic update from web-platform-tests
[css-pseudo] Move all ::marker style adjustments into StyleAdjuster
LayoutNGListItem was applying some style adjustments to markers, like
'white-space: pre' to preserve trailing spaces in outside markers.
But this was only affecting markers with 'content: normal', and the
changes weren't exposed in getComputedStyle().
This patch moves these adjustments into StyleAdjuster, so that all
markers are affected equally.
BUG=457718
TEST=external/wpt/css/css-pseudo/marker-content-018.html
The test fails in legacy because the 'content' property is not supported
yet in ::marker.
There is a new failure in marker-supported-properties.html because now
'white-space' will compute to 'pre' in outside markers, even if you
specify a different value. But normal markers were already enforcing
'pre' at used value time anyways.
Change-Id: I6d8b8ec7fb26cb04402032924f87b2c3b8fdb9cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985966
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#728176}
--
wpt-commits: a3111814fa0e9de6e2decd443d170a6e88304164
wpt-pr: 21011
Automatic update from web-platform-tests
html: Fix form constraints validator (#21014)
This commit applies two fixes to the validator:
1. Reapply the conditions for each clone of the element created in
iterate_over.
This fixes valueMissing.html's "[select] Selected the option with
value equals to 1" test, that was failing on all browsers.
2. Fix the expectation for validationMessage when the element is
disabled. This fixes#20825.
--
wpt-commits: bc5671c220564dd1fcc6c6a36dd20aaa0ba5e771
wpt-pr: 21014
