Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 06:45:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
471,623 Commits 615 Branches 98 Tags 5.8 GiB
05a14131e5
Commit Graph

666 Commits

Author SHA1 Message Date
Andrew Comminos
906ea4c271 Bug 1197059 - Disable JasPer support in GDK-PixBuf. r=karlt 2015-08-28 17:15:27 -04:00
Ryan VanderMeulen
91d401abec Backed out changeset 376965bcb1f7 (bug 1197059) for Valgrind leaks. 2015-08-27 19:20:32 -04:00
Andrew Comminos
1d59f8d210 Bug 1197059 - Disable JasPer support in GDK-PixBuf. r=karlt 2015-08-27 18:35:14 -04:00
Masayuki Nakano
0d22745cda Bug 895274 part.3 Make the enum of event messages a named enum IGNORE IDL r=smaug 2015-08-26 21:56:59 +09:00
Chris Peterson
7d28169642 Bug 1198128 - Fix -Wshadow warnings in widget/gtk. r=karlt 2015-08-23 17:55:09 -07:00
Lee Salzman
c864a9b192 Bug 1194397 - Force gdk_window_ensure_native on gdk window creation. r=acomminos 
--HG--
extra : rebase_source : 5c40a4fc9f3bef1d1034609e2e6e5f03dc36c88b
 2015-08-25 18:42:40 -04:00
Brian Birtles
3ae8210730 Fix bustage from changeset 5c5dc6f367ac (bug 1026803) r=bustage on CLOSED TREE 
--HG--
extra : rebase_source : 34d0ad10e3cd76e558ce8792672e3a6289a84edb
 2015-08-24 15:24:42 +02:00
Brian Birtles
2a6e6986a9 Bug 1026803 part 8 - Add ability for CurrentX11TimeGetter to perform an asynchronous request of the current time; r=karlt 
--HG--
extra : rebase_source : 0f0fa181535e5c0f132cbefc9bc6d3ae2bb69c50
 2015-08-12 10:35:38 +09:00
Brian Birtles
68ca603000 Bug 1026803 part 7 - Store the CurrentX11TimeGetter as a member object on nsWindow; r=karlt 
In preparation for making CurrentX11TimeGetter capable of performing an
asynchronous request of the current time, this patch revises the lifetime of
such objects so that they are stored on nsWindow.

--HG--
extra : rebase_source : 486c81ad5e64ee6420907babcc97262412ff5caa
 2015-08-11 17:13:44 +09:00
Brian Birtles
9a127183cd Bug 1026803 part 5 - Convert CurrentXXXTimeGetter classes from functors to helper classes; r=karlt 
Previously the CurrentX11TimeGetter and CurrentWindowsTimeGetter classes acted
as functors with a single operator() method. In preparation for handling clock
skew, this patch refactors these two helper classes into regular classes with
two named methods:

  GetCurrentTime which matches the existing operator() method, and

  GetTimeAsyncForPossibleBackwardsSkew which will be used when possible
  backwards skew is detected to fetch the current time asynchronously.

Some renaming is also included to match the expanded role of these classes.

--HG--
extra : rebase_source : 4d46e09bd09cbb0dbffcb0aa46742157384d37e8
 2015-02-19 14:10:00 +09:00
Brian Birtles
1f60d5ca37 Bug 1026803 part 4 - Convert GTK native event times to timestamps; r=karlt 
This patch adds a helper class to widgets/gtk/nsWindow.cpp similar to the one in
widgets/windows/nsWindow.cpp and uses it to convert native event times to
mozilla::TimeStamp objects on events returned by this class.

This is similar to the operations performed for Windows native event times that
were added in bug 77992.

--HG--
extra : rebase_source : a6c4769e7da88bb4644edf8954c923a88e1c04fd
 2015-08-11 16:40:34 +09:00
Masayuki Nakano
66f2c27305 Bug 895274 part.1 Rename WidgetEvent::message to WidgetEvent::mMessage r=smaug 2015-08-22 10:34:51 +09:00
Andrew Comminos
bf63f14959 Bug 1187203 - Implement GtkInfoBar appearance style on GTK3. r=karlt 2015-08-21 16:38:15 -04:00
Masayuki Nakano
a8be9560f4 Bug 1189396 part.3 Make IMENotification::SelectionChangeData useful even outside of IMENotification r=smaug 2015-08-22 01:43:41 +09:00
Mike Conley
5eee8c5286 Bug 1184604 - Lazily override printer output format on Linux if not already set. r=karlt 
GTK versions prior to 2.24 incorrectly advertise themselves as able to print PDFs,
even when they can't. We were wholesale setting the output format to PostScript for
these older GTK versions, without giving the user the opportunity to override
it. We now lazily determine whether or not the output should be in PostScript,
which should give the user the opportunity to override.

--HG--
extra : commitid : A30C51CukFd
extra : rebase_source : 8800e463753a554902cc22fe6e973dfdab1d7c0d
extra : amend_source : 43b58fd7c2c1605351cbb24d216fb5f781625a3a
 2015-07-31 13:53:49 -04:00
Masayuki Nakano
c45505d74b Bug 299603 part.8 Rename aLastDispatchedData with aCompositionString in IMContextWrapper::CreateTextRangeArray() r=m_kato 2015-08-19 16:37:39 +09:00
Masayuki Nakano
a115b2e0b3 Bug 299603 part.7 IMContextWrapper::CreateTextRange() should convert the caret offset from offset in characters to offset in UTF-16 r=m_kato 2015-08-19 16:37:39 +09:00
Masayuki Nakano
90cbd5150d Bug 299603 part.6 Guess the meaning of each clause in the composition string with caret position r=m_kato 2015-08-19 16:37:39 +09:00
Masayuki Nakano
3cbdc83c7d Bug 299603 part.3 IMContextWrapper::SetTextRange() shold set the style of the range which is specified by the IME r=m_kato 2015-08-19 16:37:39 +09:00
Masayuki Nakano
7d2b010aeb Bug 299603 part.2 IMContextWrapper::SetTextRange() should initialize the range offsets and fail if the range is collapsed r=m_kato 2015-08-19 16:37:39 +09:00
Masayuki Nakano
d943ae3d8c Bug 299603 part.1 IMContextWrapper should have a method to initialize a TextRange r=m_kato 2015-08-19 16:37:39 +09:00
Xidorn Quan
f63a930fb6 Bug 1190316 - Apply fullscreen transition on only the target monitor. r=roc 
--HG--
extra : source : b3015229dd6997970ce2634b6fcf393f2f702e85
 2015-08-13 08:53:53 +10:00
Nick Robson
49e872dc7e Bug 1075089 - Move popup menu frame offset to LookAndFeel and fix default offset for OS X. r=Enn 
--HG--
extra : rebase_source : 7817fea6ea95e9dfc486f797114e1cfb778d5230
 2015-08-04 16:41:00 -04:00
Gabor Krizsanits
8996db91c1 Bug 863512 - Fixing xul dnd panels for linux. r=enndeakin 2015-08-05 13:19:44 +02:00
Andrew Comminos
90d3c44131 Bug 1189028 - Draw a toplevel popup behind popup menus on GTK3. r=karlt 2015-08-06 14:20:00 -04:00
Lee Salzman
0c7ff08984 Bug 1184009 - Limit gtk file picker preview source sizes. r=acomminos 2015-08-07 12:24:22 -04:00
Petr Jasicek
e19231c364 Bug 1160154 - Decrease padding between icons in the personal toolbar with Gtk3 by using "image-button" css style class. r=karlt 
CLOSED TREE

--HG--
extra : rebase_source : b8c2ed8403294ac2b1931141794f184af2a11cbd
 2015-08-07 01:09:00 -04:00
Lee Salzman
7ac4d202b1 Bug 1190935 - Fix race condition in gtk window EndRemoteDrawingInRegion. r=nical 2015-08-06 11:02:03 -04:00
Masayuki Nakano
61074e4e20 Bug 1191213 nsBaseWidget::NotifyWindowMoved() shouldn't notify IME when native IME handler doesn't have focus r=m_kato 2015-08-06 15:57:58 +09:00
Birunthan Mohanathas
7315345693 Bug 1191100 - Remove XPIDL signature comments in .cpp files. r=ehsan 
Comment-only so DONTBUILD.
 2015-08-04 16:17:36 -07:00
Carsten "Tomcat" Book
060e1dcfe0 Backed out changeset 7edc58c272f1 (bug 1075089) for causing OS X 10.6 marionette failures in test_single_finger_desktop.py testSingleFingerMouse.test_double_tap on a CLOSED TREE 2015-07-31 14:49:40 +02:00
Andrew Comminos
5bd79fe54d Bug 1187237 - Correct range slider drawing on GTK3. r=karlt 
--HG--
extra : rebase_source : 0f3a2416b4ca08c913b51303f69e06b8cd859324
 2015-07-30 11:29:00 +02:00
Nick Robson
58f8aa5dac Bug 1075089 - Moved popup menu frame offset to LookAndFeel, fixed default offset for OS X. r=enn 2015-07-30 15:00:00 +02:00
Mike Conley
20ee63d181 Bug 1145916 - [e10s] Defer starting a GTK Print Job during printer enumeration until the next tick. r=karlt 
Before, we were calling nsDeviceContextSpecGTK::StartPrintJob within the
gtk_enumerate_printers callback function as soon as we found the printer
we wanted to print from. This was causing the GTK printing backend to get
confused about what the capabilities of the selected printer were when running
in the content process, due to https://bugzilla.gnome.org/show_bug.cgi?id=753041.
This moves the call to StartPrintJob to the next tick of the event loop.

--HG--
extra : commitid : CZ5P0hh51QC
extra : rebase_source : 279c6c56a2a22b42d5bbf094fd976a4d8f9c8031
 2015-07-27 17:11:46 -04:00
Andrew Comminos
c14fa3aed4 Bug 1188138 - Prevent default buttons from being drawn twice on GTK3. r=karlt 2015-07-27 15:08:00 -04:00
Andrew Comminos
caa85e1906 Bug 1186661 - Draw drag and drop alpha pixmap correctly on GTK3. r=karlt 2015-07-28 07:13:00 -04:00
Andrew Comminos
4800e74696 Bug 1186661 - Use monitors-changed signal to update screen manager on GTK. r=karlt 2015-07-25 19:07:00 -04:00
Andrew Comminos
482e0ca788 Bug 1187649 - Free constructed widget path in nsLookAndFeel on GTK. r=karlt 2015-07-28 06:28:00 -04:00
Carsten "Tomcat" Book
9f95ffe014 Backed out changeset ac04ab483fba (bug 1187649) for bustage on a CLOSED TREE 2015-07-28 13:05:48 +02:00
Andrew Comminos
0dbd6187d5 Bug 1187649 - Free constructed widget path in nsLookAndFeel on GTK. r=karlt 2015-07-27 11:21:00 +02:00
Mike Hommey
6a956c6f97 Bug 1187533 - Change how Gtk+2 plugin-container is started on Gtk+3 builds. r=billm 
The current situation looks like this: Firefox launches the plugin-container
with two environment variables set:
  LD_LIBRARY_PATH=$FIREFOX_DIR:$LD_LIBRARY_PATH
  LD_PRELOAD=$FIREFOX_DIR/libmozgtk2.so:$LD_PRELOAD

libxul.so has a dependency on libmozgtk.so (without "2"), but libmozgtk2.so
has a SONAME of libmozgtk.so, so ld.so recognizes libmozgtk2.so as a
dependency of libxul.so, and uses it instead of the actual libmozgtk.so,
making the plugin-container use Gtk+2 instead of Gtk+3 to load Gtk+2 plugins.

Now, ASan sets things up in shared libraries such that they needs a symbol
from the executable binary. So in the case of plugin-container, the
plugin-container executable itself contains some ASan symbols such as
__asan_init_v3. libmozgtk2.so, OTOH, contains an undefined weak reference to
that symbol, like all other Firefox shared libraries.

Since libmozgtk2.so is LD_PRELOADed, it is loaded _before_ the
plugin-container executable, and __asan_init_v3 can't be resolved.

Disabling ASan for libmozgtk2.so would be a possibility, but the build system
doesn't really know how to do that, and filtering out -fsanitize=address
can be fragile.

The alternative possibility, implemented here, is to change the library
loading strategy, renaming libmozgtk2.so to gtk2/libmozgtk.so, and setting
the following environment variable when Firefox launches the plugin-container:
  LD_LIBRARY_PATH=$FIREFOX_DIR/gtk2:$FIREFOX_DIR:$LD_LIBRARY_PATH
 2015-07-28 08:19:13 +09:00
Makoto Kato
51adbe4deb Bug 1181000 - Use logical pixel to set IME candidate window. r=karlt 2015-07-27 14:37:02 +09:00
Masayuki Nakano
b38c1b7f77 Bug 1186017 part.2 Rename GetBoolName() in IMContextWrapper.cpp to ToChar() r=kerlt 2015-07-27 08:23:04 +09:00
Masayuki Nakano
b45368f471 Bug 1186017 part.1 Rename nsGtkIMModule to mozilla::widget::IMContextWrapper r=m_kato+kerlt 
--HG--
rename : widget/gtk/nsGtkIMModule.cpp => widget/gtk/IMContextWrapper.cpp
rename : widget/gtk/nsGtkIMModule.h => widget/gtk/IMContextWrapper.h
 2015-07-27 08:23:04 +09:00
Xidorn Quan
7ec583cc8f Bug 1160014 part 6 - Implement fullscreen transition for GTK. r=roc 
--HG--
extra : source : ae8bf45b7efcd297ad92039b5ea6985dbfa725e9
 2015-07-24 09:45:00 +10:00
Mike Hommey
9ca903bc81 Bug 1063359 - Unconditionally use -Wl,--no-as-needed when building with GNU ld/gold. r=mshal 2015-07-24 06:49:49 +09:00
Lee Salzman
b54a311fe2 Bug 1184009 - Limit image preview sizes. r=acomminos 2015-07-21 13:16:44 -04:00
Masayuki Nakano
9d9bd4c975 Bug 1184449 part.1 IMENotifiation::SelectionChangeData should store selected string r=smaug 2015-07-22 12:40:32 +09:00
Wes Kocher
ff3207dea9 Backed out changeset b3d392163411 (bug 1160014) (Linux part), too CLOSED TREE 2015-07-21 16:54:09 -07:00
Xidorn Quan
1828b64f06 Bug 1160014 part 6 - Implement fullscreen transition for GTK. r=roc 
--HG--
extra : source : 2bcd5eb4c07c7ec201a8a023756d3bba18575cdd
 2015-07-22 09:07:46 +10:00
Masayuki Nakano
0c318e2eff Bug 1176959 nsGtkIMModule shouldn't commit composition when a selection change is notified but it was caused by selection set event r=m_kato 2015-07-17 13:27:32 +09:00
Andrew Comminos
3792527c55 Bug 1182972 - Fallback to GTK monitor scale factor when mGdkWindow is null. r=karlt 2015-07-15 20:26:00 -04:00
Andrew Comminos
ab856f24b0 Bug 1173907 - Don't use gtk_render_activity for drawing progress chunks on GTK versions above 3.13.7. r=karlt 2015-07-15 11:47:00 -04:00
Andrew Comminos
10a8163b58 Bug 1179780 - Render opaque scrollbar troughs in the root viewport on GTK3. r=karlt 
--HG--
extra : rebase_source : 2fe41b3c52e1b692e1a18b3c8123fc87569f9a57
 2015-07-14 07:35:00 -04:00
Karl Tomlinson
b90e0e52f5 bug 1182972 no need to pass member variable bounds to NativeResize r=acomminos 
--HG--
extra : rebase_source : 5ede1fde53d0747571256e137656c84806f17dbf
 2015-07-14 15:24:56 +12:00
Karl Tomlinson
00d0625ec1 bug 1182972 remove mNeedsMove/mNeedsResize logic; instead process changes immediately r=acomminos 
--HG--
extra : rebase_source : 11e93975d7334a065c5305ab126f50be0feaedca
 2015-07-14 15:23:47 +12:00
Karl Tomlinson
3c97c275f9 bug 1182972 create NativeMove helper method r=acomminos 
--HG--
extra : rebase_source : 7a2eb54a0f1892a498251b4553b5f67794fcc365
 2015-07-13 14:29:05 +12:00
Karl Tomlinson
055a5d09a9 bug 1182972 remove unused aRepaint parameter from NativeResize methods r=acomminos 
--HG--
extra : rebase_source : 8b3f01e7c32e8cb5dc125fdd756e983538a4943d
 2015-07-13 13:57:23 +12:00
Andrew Comminos
ce4cdce4b8 Bug 1178799 - Filter X11 SelectionRequest events with an invalid requestor on GTK3. r=karlt 
--HG--
extra : rebase_source : cd7370af74195ad1c7736c8148d537e3a47bd4d1
 2015-07-13 08:58:00 -04:00
Birunthan Mohanathas
a8939590de Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
 2015-07-13 08:25:42 -07:00
Michael Layzell
dbe075d5b8 Bug 1180993 - Part 3: Correct use sites of functions which return already_AddRefed. r=ehsan 2015-07-10 08:36:00 -04:00
Andrew Comminos
21488f9240 Bug 1174248 - Workaround unico theme engine resizer bug on GTK3. r=karlt 2015-07-08 08:40:00 -04:00
Dragana Damjanovic
7987d2203e Bug 905127 - Part 2 - remove unnecessary nsNetUtil.h includes r=jduell 2015-07-06 07:55:00 +02:00
Emanuel Hoogeveen
7d1e52f2ff Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell 2015-07-07 04:17:00 +02:00
Andrew Comminos
c186e55d71 Bug 1180971 - Fix X11 SHM invalidation regions on HiDPI with GTK3. r=karlt 
--HG--
extra : rebase_source : 62d7a80d791cdd7685ae32178610b815745524c5
 2015-07-06 16:57:00 +02:00
Andrew Comminos
3b68c90816 Bug 1180008 - Define gtk_window_get_window_type in mozgtk. r=karlt 
--HG--
extra : rebase_source : a40f50fa12d8d86f62d77cd815c05616ac3136c3
 2015-07-06 08:26:00 +02:00
Andrew Comminos
1b154e598d Bug 1176109 - Don't attach menu popups to menubars on GTK3. r=karlt 
--HG--
extra : rebase_source : c4edc3f54caa32b7641cd5895732daa7755e7e28
 2015-07-06 21:55:00 +02:00
Andrew Comminos
e47140908b Bug 983843 - Switch to GtkOffscreenWindow for drag source widget, fixing ghost tabs on some GTK versions. r=karlt 
--HG--
extra : rebase_source : 278ba83eed30b1ff7d0824822a6ab6518f3313f7
 2015-06-17 12:20:00 +02:00
Karl Tomlinson
41e62ce1ec bug 1180008 don't measure size of decorations for override-redirect windows r=acomminos 
--HG--
extra : rebase_source : fee0440498753be5b2c011d7915eb044cff90963
 2015-04-21 19:52:00 +12:00
Karl Tomlinson
578ad122af bug 1180008 use mGdkWindow instead of finding it from gtk_widget_get_window(mShell) r=acomminos 
Since https://hg.mozilla.org/mozilla-central/rev/9541dbf6e020#l2.184
there is only one GdkWindow per nsWindow.

The mGdkWindow pointer is cleared in OnContainerUnrealize() before the shell
widget destruction completes:
https://hg.mozilla.org/mozilla-central/annotate/50b95032152c/widget/gtk/nsWindow.cpp#l2480

--HG--
extra : rebase_source : fe6da6f16514bbb18f3ab65da3b21a2816bc23a0
 2015-04-21 19:06:41 +12:00
Karl Tomlinson
ff72a52865 bug 1180008 provide gtk_window_get_window_type for old GTK versions r=glandium 
--HG--
extra : rebase_source : c1d1f1778f27152ce2e6470b44d77939f97cb777
 2015-04-21 18:17:24 +12:00
Andrew Comminos
3bdf142d83 Bug 1177171 - Round widget coordinates on GTK3. r=karlt 
--HG--
extra : rebase_source : ac32281d7251453c5075fc0dc22c7461af5f32f6
 2015-06-29 11:50:00 -04:00
Nathan Froyd
974d8120f2 Bug 1161627 - part 2 - machine-convert TemporaryRef<T> to already_AddRefed<T>; r=ehsan 
This conversion was done with the script:

  find . -name '*.cpp' -o -name '*.h' -o -name '*.mm' -o -name '*.idl' | \
    egrep -v 'cairo-win32-refptr.h|RefPtr.h|TestRefPtr.cpp' | \
    xargs sed -i -e 's/mozilla::TemporaryRef</already_AddRefed</g' \
                 -e 's/TemporaryRef</already_AddRefed</g'

Manual fixups were performed in the following instances:

- We handled mfbt/RefPtr.h manually so as to not convert TemporaryRef itself
  into already_AddRefed.

- The following files had explicit Move() calls added to make up for the lack
  of a copy constructor on already_AddRefed:

  dom/base/ImageEncoder.cpp
  dom/media/MediaTaskQueue.{h,cpp}
  dom/media/webaudio/PannerNode.cpp

- A redundant overload for MediaTaskQueue::Dispatch was deleted.

- A few manual fixups were required in mfbt/tests/TestRefPtr.cpp.

- Comments, using declarations, and forward declarations relating to
  TemporaryRef in dom/canvas/ and gfx/layers/ were changed to refer to
  already_AddRefed.
 2015-06-17 10:00:52 -04:00
Andrew Comminos
69949017a1 Bug 1175171 - Deallocate GTK's KeymapWrapper on shutdown. r=karlt 
--HG--
extra : rebase_source : 5ff0e22c28e8349902d4ca0146b63d604a0abd58
 2015-06-26 11:28:00 -04:00
Andrew Comminos
7a31276561 Bug 1131978 - Acknowledge GDK's scale factor in scale calculation. r=karlt 2015-06-26 10:19:00 +02:00
Makoto Kato
2eaace5db3 Bug 1176843 - Don't query caret rect on layout change. r=masayuki 2015-06-26 00:08:29 -07:00
Botond Ballo
5c454a43e7 Bug 1177024 - Fix clang warnings-as-errors in GTK3 build. r=karlt 
--HG--
extra : source : 22ae9b52ec5b25fab359ff32e04072df6412662e
 2015-06-21 15:27:07 -04:00
Andrew Comminos
c32ccdaa18 Bug 1171696 - Require room for scrollbar sliders and draw troughs only when there is room for a slider or buttons on GTK. r=karlt 
--HG--
extra : rebase_source : 3c9d3ce76209e5ae82164d0271cf93509f4be856
 2015-06-17 07:27:00 -04:00
Masayuki Nakano
9805b3e4d3 Bug 1175382 TextRangeArray::TargetClauseOffset() and TextRangeArray::TargetClauseLength() shouldn't be public and same name methods of WidgetCompositionEvent should be used r=m_kato 2015-06-18 13:43:18 +09:00
Andrea Marchesini
45578e03fa Bug 1170794 - Improve the length check of the input in nsUnicode*::GetMaxLength, r=dveditz 2015-06-17 12:21:39 +01:00
Karl Tomlinson
603b1ace02 bug 147419 remove ununsed plexName colorspace resolutionName and downloadFonts r=roc 
This was only used to write to and read from otherwise unused preferences.

--HG--
extra : rebase_source : a538569807b8340dae3fe9f0cbfc68334e20ccc9
 2015-06-11 09:34:27 +12:00
Karl Tomlinson
71e6f82be1 bug 147419 remove meaningless GetPrintMethod() r=roc 
--HG--
extra : rebase_source : bd89c4f495cd14a190bb65aaea2e23e54591ca5d
 2015-06-16 11:02:34 +12:00
Karl Tomlinson
bb37b9da4d bug 147419 remove print(|.<modulename>)(|.printer_<printername>).filename pref reading code r=roc 
There are no default pref values, and even if some have been set, the value
is subsequently overridden by the print.print_to_filename pref, which exists
if saved from a previous nsPrintSettingsGTK.

--HG--
extra : rebase_source : 6912584e537d77d4efb1b1c3716d6c38bda3899e
 2015-06-10 19:11:49 +12:00
Karl Tomlinson
4c5d983774 bug 147419 use GTK default paper size and orientation r=roc 
In the nsPrintSettingsGTK constructor, gtk_paper_size_new(nullptr) gets the
system default paper size from the locale and gtk_page_setup_new() sets
default orientation to portrait.

These are subsequently overridden by prefs if any have been saved from
a previous nsPrintSettingsGTK.

--HG--
extra : rebase_source : 37b626bb0ed93454f6adc8916dbc674cf37ed4fe
 2015-06-10 18:51:46 +12:00
Karl Tomlinson
a19a1f0d0c bug 147419 remove ununsed nsIPrintSettings::printCommand and print_command prefs r=roc 
These was used only to write to and read from each other.

--HG--
extra : rebase_source : ef49678652f829fe23611fb2294a22c3ffd91cf1
 2015-06-10 18:10:28 +12:00
Andrew Comminos
d9685f25c8 Bug 1167239 - Make GTK button activity require hover. r=karlt 
--HG--
extra : rebase_source : 880240867939e93cd91eec3d11029c70baf8c077
 2015-06-16 07:58:00 -04:00
Andrew Comminos
6021357a72 Bug 1171011 - Use only document padding for MOZ_GTK_ENTRY in XUL. r=karlt 2015-06-10 12:38:00 -04:00
Hubert Figuière
40a12f2005 Bug 1174374 - gdk_cursor_new() is deprecated in 3.16. Use gdk_cursor_new_for_display(). r=karlt 
--HG--
extra : transplant_source : %DF%15%81%18%1A%93D%ADQ%BDO%3EN4%F7%3E%F9%8B%3C%0D
 2015-06-12 22:38:20 -04:00
Makoto Kato
0597055c59 Bug 1120851 - Set candidate window position for prediction even if no composition. r=masayuki 2015-06-15 16:01:39 +09:00
Daniel Holbert
632bb46230 Bug 1174287: Use mozilla:: prefix for namespaced classes in nsGtkIMModule.h. r=Ms2ger 2015-06-12 14:19:41 -07:00
Hubert Figuière
1c7aad3a06 Bug 1168527 - Variable was re-declared causing a bustage on gcc 5. r=lsalzman 2015-06-12 14:19:34 -04:00
Andrew Comminos
40b78be093 Bug 1168527 - Replay clips into the system cairo on GTK3. r=lsalzman 
--HG--
extra : rebase_source : 013e1811f6b3fa1f599531153c292d7a5136f087
extra : histedit_source : 7c3f596514ea87840a0bd231b247b119ed9d3048
 2015-06-09 13:46:09 -04:00
Andrew Comminos
1013161996 Bug 1167356 - Handle return value of DataSourceSurface::Map wherever possible. r=Bas 
--HG--
extra : rebase_source : fe4fcb9c3a89e2573e6fde423ed8d96f31e00f14
 2015-06-11 13:06:23 -04:00
Masayuki Nakano
107d7e94f3 Bug 1130937 part.3 nsGtkIMModule should adjust candidate window position when layout is changed r=m_kato 2015-06-11 19:50:15 +09:00
Masayuki Nakano
f2a58d2261 Bug 1130937 part.2 nsGtkIMModule should set candidiate window position to bottom left of the target clause in vertical writing mode r=m_kato 2015-06-11 19:50:15 +09:00
Masayuki Nakano
91ed158c1d Bug 1130937 part.1 nsGtkIMModule should cache selection r=m_kato 2015-06-11 19:50:15 +09:00
Mike Hommey
4b28879d7b Fixup for bug 1129873 for bustage of GTK+3 builds on elm. r=karlt. DONTBUILD. 2015-06-11 13:21:02 +09:00
Xidorn Quan
7699870266 Bug 1161802 part 1 - Add FullscreenChanged callback in WidgetListener. r=roc 
--HG--
extra : source : dcfb961149d8c8e56ff787fa812dc781a491ee53
 2015-06-10 23:13:12 +12:00
Jan Horak
1f0864644b Bug 1129873 - [GTK3] Implement wrapper to GtkAppChooserDialog to allow using native application chooser. r=karlt 2015-06-08 04:41:00 -04:00
Jonathan Kew
f05c9dee41 Bug 1113206 patch 2: Disable use of Cocoa and Gtk native-theme dropdown rendering that doesn't play well with vertical writing mode. r=roc 2015-06-08 07:21:42 +01:00
Andrew Comminos
bcf78111e1 Bug 1171029 - Only omit legacy scroll events on GTK3. r=karlt 
--HG--
extra : rebase_source : c4badf1f606bbb5cf0052265f38514acc3eee63c
 2015-06-03 07:47:00 -04:00
Martin Stransky
649e670ec4 Bug 1169233 - Get grey (inactive) text color from menu labels. r=karlt 2015-05-29 05:40:00 -04:00
Martin Stransky
3626e5799b Bug 1169232 - [gtk3] Add background class to tooltip window to get correct background color. r=karlt 2015-06-01 05:01:00 -04:00
Eric Rahm
75c4bebb79 Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj 
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
 2015-06-03 15:25:57 -07:00
Eric Rahm
67f6de2a30 Bug 1165515 - Part 9: Remove instances of using numeric log levels 1-5. rs=froydnj 2015-06-03 15:22:35 -07:00
Eric Rahm
cc58068318 Bug 1165515 - Part 5: Convert instances of PR_LOG_ALWAYS. r=froydnj 
Most instances were converted to PR_LOG_INFO, some to PR_LOG_DEBUG, and some
to PR_LOG_ERROR.
 2015-06-03 15:22:30 -07:00
Carsten "Tomcat" Book
5471309381 Backed out 14 changesets (bug 1165515) for linux x64 e10s m2 test failures 
Backed out changeset d68dcf2ef372 (bug 1165515)
Backed out changeset 7c3b45a47811 (bug 1165515)
Backed out changeset b668b617bef2 (bug 1165515)
Backed out changeset d0916e1283a2 (bug 1165515)
Backed out changeset ac4dc7489942 (bug 1165515)
Backed out changeset e9632ce8bc65 (bug 1165515)
Backed out changeset c16d215cc7e4 (bug 1165515)
Backed out changeset e4d474f3c51a (bug 1165515)
Backed out changeset d87680bf9f7c (bug 1165515)
Backed out changeset b3c0a45ba99e (bug 1165515)
Backed out changeset 9370fa197674 (bug 1165515)
Backed out changeset 50970d668ca1 (bug 1165515)
Backed out changeset ffa4eb6d24b9 (bug 1165515)
Backed out changeset 5fcf1203cc1d (bug 1165515)

--HG--
extra : rebase_source : 6fb850d063cbabe738f97f0380302153e3eae97a
 2015-06-02 13:05:56 +02:00
Eric Rahm
a9afd68cef Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj 
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
 2015-06-01 22:17:33 -07:00
Eric Rahm
fb40eb5516 Bug 1165515 - Part 9: Remove instances of using numeric log levels 1-5. rs=froydnj 2015-06-01 22:17:26 -07:00
Eric Rahm
28978ade8c Bug 1165515 - Part 5: Convert instances of PR_LOG_ALWAYS. r=froydnj 
Most instances were converted to PR_LOG_INFO, some to PR_LOG_DEBUG, and some
to PR_LOG_ERROR.
 2015-06-01 22:17:21 -07:00
Wes Kocher
4e9f80ed2e Backed out 14 changesets (bug 1165515) for b2g mochitest-6 permafail CLOSED TREE 
Backed out changeset 9b97e2aa2ed9 (bug 1165515)
Backed out changeset 150606c022a2 (bug 1165515)
Backed out changeset 4e875a488349 (bug 1165515)
Backed out changeset 467e7feeb546 (bug 1165515)
Backed out changeset d6b6cc373197 (bug 1165515)
Backed out changeset 0615265b593c (bug 1165515)
Backed out changeset fafd1dce9f08 (bug 1165515)
Backed out changeset d1df869245f9 (bug 1165515)
Backed out changeset 6876a7c63611 (bug 1165515)
Backed out changeset b7841c94a9a3 (bug 1165515)
Backed out changeset e5e3617f7c73 (bug 1165515)
Backed out changeset 39be3db95978 (bug 1165515)
Backed out changeset 0ec74176f8de (bug 1165515)
Backed out changeset 5b928dd10d71 (bug 1165515)
 2015-06-01 17:57:58 -07:00
Eric Rahm
f82c0e7caf Bug 1165515 - Part 13-2: Replace usage of PRLogModuleLevel and PR_LOG_*. rs=froydnj 
This is straightforward mapping of PR_LOG levels to their LogLevel
counterparts:
  PR_LOG_ERROR   -> LogLevel::Error
  PR_LOG_WARNING -> LogLevel::Warning
  PR_LOG_WARN    -> LogLevel::Warning
  PR_LOG_INFO    -> LogLevel::Info
  PR_LOG_DEBUG   -> LogLevel::Debug
  PR_LOG_NOTICE  -> LogLevel::Debug
  PR_LOG_VERBOSE -> LogLevel::Verbose

Instances of PRLogModuleLevel were mapped to a fully qualified
mozilla::LogLevel, instances of PR_LOG levels in #defines were mapped to a
fully qualified mozilla::LogLevel::* level, and all other instances were
mapped to us a shorter format of LogLevel::*.

Bustage for usage of the non-fully qualified LogLevel were fixed by adding
|using mozilla::LogLevel;| where appropriate.
 2015-06-01 14:31:01 -07:00
Eric Rahm
4095cdb19f Bug 1165515 - Part 9: Remove instances of using numeric log levels 1-5. rs=froydnj 2015-06-01 14:31:00 -07:00
Eric Rahm
0a502beb23 Bug 1165515 - Part 5: Convert instances of PR_LOG_ALWAYS. r=froydnj 
Most instances were converted to PR_LOG_INFO, some to PR_LOG_DEBUG, and some
to PR_LOG_ERROR.
 2015-06-01 14:31:00 -07:00
Andrew Comminos
80f348519c Bug 1168578 - Use widget state in GTK3 toggles' style context. r=karlt 
--HG--
extra : rebase_source : ed8c384d7d2c7ac1f89b4fb1356f2189fa1ac7b2
 2015-05-27 14:27:00 -04:00
Lee Salzman
688f2ebbdc Bug 1168495 - Restrict updated region to fall within GTK window. r=jrmuizel 
--HG--
extra : rebase_source : 4c34f469e4cb9b5afcabd336615181b3be0bd5de
 2015-05-26 14:09:18 -04:00
Daniel Holbert
97501a00b6 Bug 1166741 followup: Guard GTK file-picker member-var decl/init statements with same #ifdef that its usages are guarded with, to avoid -Wunused-private-field warning. r=karlt 2015-05-26 22:40:28 -07:00
Michael Layzell
3f98e94e29 Bug 1168219 - Make nsIWidget::Configuration::mChild a smart pointer. r=vlad 2015-05-25 14:45:00 -04:00
Andrew Comminos
eb37553168 Bug 1166741 - Workaround for GTK3 bug where file choosers' delegate refcount is not incremented. r=karlt 2015-05-22 06:36:00 +02:00
Eric Rahm
3925a960aa Bug 1165515 - Part 1: Convert PR_LOG to MOZ_LOG. r=froydnj 2015-05-21 13:22:04 -07:00
Lee Salzman
edfe5219aa Bug 1165513 - Translate GTK3 widgets with snapped pixel coordinates into identity space. r=jrmuizel 2015-05-19 17:08:35 -04:00
Eric Rahm
4879ae86f4 Bug 1165518 - Part 2: Replace prlog.h with Logging.h. rs=froydnj 2015-05-19 11:15:34 -07:00
Martin Stransky
8eed535eb8 Bug 1144745 - scale border returned by GetWidgetBorder(), r=karlt 
--HG--
extra : rebase_source : c67f901457dfe3ba6979fbbf4f1db75f96632666
 2015-04-28 06:22:00 +02:00
Lee Salzman
4476c73a98 Bug 1159273 - Allow loading of tree cairo and system cairo at the same time. r=glandium 2015-05-13 12:04:03 +09:00
Lee Salzman
5dff60ce8c Bug 1159273 - call g_type_init in nsAppShell::Init. r=glandium 2015-05-13 12:04:03 +09:00
Lee Salzman
54aee35d35 Bug 1159273 - Fix out-dated Cairo usage that may fail to build or work properly when system Cairo is involved. r=jrmuizel 2015-05-13 12:00:30 +09:00
Lee Salzman
e38cad0b37 Bug 1127752 - fixes for using Skia and OMTC with GTK3. r=jrmuizel 2015-05-13 11:54:17 +09:00
Kartikaya Gupta
fd5c9ccd70 Bug 1161634 - Allow synthesizing native mouse-scroll events on Linux. r=karlt 2015-05-11 17:21:34 -04:00
Eric Rahm
15f7146909 Bug 1162293 - Part 1: Remove instances of #ifdef PR_LOGGING. r=froydnj 
PR_LOGGING is now always defined, we can remove #ifdefs checking for it.
 2015-05-07 09:43:38 -07:00
Martin Stransky
c6e6e47ede Bug 1161056 - Gtk3 - use sMozWindowBackground colors for combobox background. r=karlt 
--HG--
extra : rebase_source : 695ccb6a3ac30d3a1dc2512f68fc74468b9e779a
 2015-05-05 09:08:00 -04:00
Carsten "Tomcat" Book
1c5956542b Backed out changeset 18474e89292a (bug 1161634) for m4 perma failures on a CLOSED TREE 2015-05-06 17:07:23 +02:00
Kartikaya Gupta
edf33626d4 Bug 1161634 - Allow synthesizing native mouse-scroll events on Linux. r=karlt 2015-05-06 08:36:54 -04:00
Blake Kaplan
0fa6a41d07 Bug 1158791 - Try harder to avoid Gtk-Critical errors in xpcshell tests. r=karlt 2015-05-04 10:12:43 -07:00
Anthony Tseng
6fe5a1137f Bug 1158425 - Rename _SYNTH event names. r=smaug 
--HG--
extra : rebase_source : 533cc7e18cf7f92d95a146d61f7aa2da7c0b8e48
 2015-05-01 22:06:00 -04:00
Martin Stransky
27ead4e7d8 Bug 1073117 - Add support for has_tab_gap notebook style. r=karlt 
--HG--
extra : rebase_source : 1755623794079eb9fa8b4c7a17bd07f6f10a0dfe
 2015-04-30 01:31:00 -04:00
Masayuki Nakano
295d41e441 Bug 1117087 Don't reset IM context when nsGtkIMContext receives selection change during dispatching compositionstart r=m_kato 2015-05-04 02:02:50 +09:00
Martin Stransky
b90a86d529 Bug 1144745 - moves gdk_screen_get_monitor_scale_factor() call to nsScreenGtk :: GetGtkMonitorScaleFactor(). r=karlt 
--HG--
extra : rebase_source : 34677048032e7b9e5c95dcd4f4bdf15e71fe232a
 2015-04-23 12:35:00 -04:00
Lee Salzman
936b4a2716 Bug 1158154 - Add gtk_window_set_auto_startup_notification to mozgtk stubs. r=nical 2015-04-24 16:09:46 +02:00
Jonathan Kew
3ffbad09c7 Bug 1028716 part 3 - Widget updates to support the extended set of -moz-orient values. r=roc 2014-06-24 19:26:13 +01:00
Andrea Marchesini
ade2831035 Bug 1156632 - Remove unused forward class declarations - patch 6 - the rest of the tree, r=ehsan 2015-04-22 08:29:24 +02:00
Nicolas Silva
cfff5e52c5 Bug 1155621 - Make nsIntRect and nsIntPoint typedefs of mozilla::gfx::IntRect and mozilla::gfx::IntPoint. r=Bas 2015-04-21 17:04:57 +02:00
Kartikaya Gupta
5cf2d407fd Bug 1146349 - Make the native event synthesization functions in DOMWindowUtils async. r=smaug 2015-04-14 11:36:36 -04:00
Olli Pettay
c3dca4be1e Backout Bug 930793 because of talos regressions,r=backout 
--HG--
extra : rebase_source : bf5d4de1b80e114d3e2172a205bf850f68019d38
 2015-04-13 19:02:27 +03:00
Andrew Comminos
fcb63f206e Bug 1144745 - Scale GTK widgets properly on HiDPI r=karlt 
--HG--
extra : rebase_source : 808693d0ef8a64e71adff1317ec0eddb83ee99af
 2015-03-29 18:06:00 +02:00
Olli Pettay
eb314fb48f Bug 930793 - Remove favor performance mode, r=avih,roc 
--HG--
extra : rebase_source : a112b660baa240afd5f0022cd869c96b59418789
 2015-04-12 23:08:55 +03:00
Alexandru Tifrea
750f1d8d1c Bug 966395 - Correctly propagate the input language's direction on OSX. r=masayuki/mrbkap 
Gtk patch written by mrbkap@mozilla.com, with r=roc
 2015-04-10 15:18:05 -07:00
Olli Pettay
aad5b35ad2 Bug 936092, initial DnD support for e10s, r=enndeakin,karlt 
--HG--
extra : rebase_source : 070a9902f23d8b47e48ac0f972213815f8e4302c
 2015-04-08 21:48:11 +03:00
Ryan VanderMeulen
1b034b250f Backed out changesets 33d37539c4ab and 55524bdeb708 (bug 936092) for suspicion of causing e10s test_bug417418.html asserts on Linux. 
CLOSED TREE
 2015-04-08 13:52:21 -04:00
Olli Pettay
efdecf747e Bug 936092, initial DnD support for e10s, r=enndeakin,karlt 
--HG--
extra : rebase_source : f0b1b0fa95dfa5fe16c09ebbc38618cf7c96654f
 2015-04-08 18:30:03 +03:00
Blake Kaplan
037f44e3b3 Bug 1152066 - Remove ugly dynamic loading code now that we can assume this symbol exists. r=roc 2015-04-07 16:53:30 -07:00
Nicolas Silva
0b1f75bea0 Bug 1132854 - Remove the gfx::ToIntSize conversion helper. r=Bas 2015-04-07 16:08:57 +02:00
Mike Hommey
b077d9624d Bug 1134920 - Use moz_xmalloc/moz_xrealloc/free instead of nsMemory::Alloc/Realloc/Free. r=nfroyd 2015-04-01 13:51:45 +09:00
Mats Palmgren
25fa3a4765 Bug 1148971 - Make nsITheme::GetMinimumWidgetSize return a LayoutDeviceIntSize result instead of the unit-less nsIntSize type. r=roc 2015-03-30 11:36:14 -04:00
Mats Palmgren
5b0f58f5ef Bug 1149041 - Make nsIWidget::SizeConstraints use LayoutDeviceIntSize instead of unit-less nsIntSize. r=roc 2015-03-30 11:35:25 -04:00
Carsten "Tomcat" Book
5c532881b3 Backed out changeset 513192eb7df4 (bug 1148971) for causing bc2 memory leaks 2015-03-30 15:04:09 +02:00
Carsten "Tomcat" Book
191c9180a5 Backed out changeset 9534a3d38191 (bug 1149041) 2015-03-30 15:03:19 +02:00
Mats Palmgren
2e8393adc7 Bug 1149041 - Make nsIWidget::SizeConstraints use LayoutDeviceIntSize instead of unit-less nsIntSize. r=roc 2015-03-30 10:37:34 +00:00
Mats Palmgren
2121f47090 Bug 1148971 - Make nsITheme::GetMinimumWidgetSize return a LayoutDeviceIntSize result instead of the unit-less nsIntSize type. r=roc 2015-03-30 10:37:33 +00:00
Andrea Marchesini
e6f385fb3d Bug 1148527 - Indentation fix after bug 1145631, r=ehsan 2015-03-27 18:52:19 +00:00
George Wright
72153ad282 Bug 1066531 - Delay tab switching until content is ready in e10s mode r=mconley,mstange 2015-03-16 14:30:41 -04:00
Martin Stransky
d5d0a26ffd Bug 1073117 - Fixed Theme issues with GTK 3.14 - GtkButtons - use border style 
property for focus rendering. Don't follow interior-focus which is always true in Gtk 3.14.
r=karlt

--HG--
extra : amend_source : fc72b41020825cd0242cd25cced8d7349f2541ce
 2015-03-25 11:41:21 -07:00
Martin Stransky
4c6394bb77 Bug 1073117 - Theme issues with GTK 3.14 - fix gtk button and entry size, r=karlt 
Inner borders and focus theming has been removed in Gtk 3.14 so we can't use them to calculate button size.
The size should be computed as border + padding.

--HG--
extra : amend_source : 0bdb2077cf2b005cd97163144fc3261a677e1349
 2015-03-25 11:41:01 -07:00
Martin Stransky
a0ccc190f2 Bug 1144643 - Render tooltips as transparent on Gtk3. r=karlt 
--HG--
extra : rebase_source : 23085532b27350ca71cbe18db071628388003f33
 2015-03-18 07:14:00 -04:00
Martin Stransky
e50e738087 Bug 1143686 - Gtk3 - Render scrollbar thumb with margin. r=karlt 2015-03-16 08:00:00 -04:00
Ehsan Akhgari
883849ee32 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj 
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
 2015-03-21 12:28:04 -04:00
Wes Kocher
571bb95717 Backed out changeset 6ef7ca8f1db3 (bug 1066531) so I can get at a patch that caused near-permafailing bc3 2015-03-20 17:17:19 -07:00
George Wright
ab018a486f Bug 1066531 - Delay tab switching until content is ready in e10s mode r=mconley,mstange 2015-03-20 15:09:58 -04:00
Masayuki Nakano
24de1c747a Bug 1143197 part.2 Assume that composition is committed if a call of gtk_im_context_reset() causes composition string becomes empty r=m_kato 2015-03-20 01:52:25 +09:00
Masayuki Nakano
76e86981d8 Bug 1143197 part.1 Use current IM context at handling key events rather than active IM context r=m_kato 2015-03-20 01:52:24 +09:00
Kevin Brosnan
b0a157386d Bug 1141207 add gtk_print_settings_foreach to mozgtk.c. r=karlt 2015-03-09 14:42:00 +01:00
Masayuki Nakano
eeb282726e Bug 1140832 Don't call gtk_im_context_reset() during "delete_surrounding" notification r=m_kato 2015-03-17 16:07:02 +09:00
David Anderson
5a00237f5b Ensure input events account for APZ transforms on Gtk. (bug 1143567 part 2, r=kats) 
--HG--
extra : rebase_source : da172b76d9a5c2e41d3d0c0e8a2b5b9732c00fef
 2015-03-16 16:29:55 -07:00
Daniel Holbert
4c88a11a9a Bug 1128934 followup: Add "mozilla::" namespace prefix to fix build bustage (hidden by unified builds on some systems) in nsWindow.h. rs=nical 
CLOSED TREE
 2015-03-09 11:12:20 -07:00
Daniel Holbert
ce800c7542 Bug 1082579 followup: Forward-declare 'PrintData' as 'class' instead of 'struct', since ipdl apparently converts 'struct' to 'class'. rs=mconley 
CLOSED TREE
 2015-03-09 10:52:18 -07:00
Nicolas Silva
999b7333fe Bug 1128934 - Avoid calling GetClientBounds from BasicComposior. r=roc, karlt 2015-02-14 12:37:32 +01:00
Mike Conley
24affce8d1 Bug 1090448 - nsDeviceContextSpecG should not use GtkPrinter until the print job is ready. r=karlt. 
In the multi-process case, we might need to query the system (and maybe the
network) for a printer with a name matching the one we're looking for. In
order to not spin an event loop at dangerous times (since searching for printers
is either asynchronous, or requires an event loop), we defer searching for
the printer until we've already finished reflowing and rendering the document
to be printed.

--HG--
extra : rebase_source : 5cd11982e47d3f7cb61fe697e54e310fe1a8d244
 2015-03-05 16:05:33 -05:00
Mike Conley
7ce830fbd1 Bug 1090448 - Add GTK-specific PrintData fields and serialization / deserialization. r=karlt. 
--HG--
extra : rebase_source : d4ce821c07419f06fbe4fc68faf59d57552a160c
 2015-03-05 11:17:18 -05:00
Mike Conley
af483c60ef Bug 1090448 - Add initial serialization and deserialization capabilities for nsPrintOptionsGTK. r=karlt. 
--HG--
extra : rebase_source : a94ccb0de26a198b961855cfef3192ef2fdd4a41
 2015-01-30 20:54:43 -05:00
dvander@alliedmods.net
bbb91f19dc Factor out how APZ-aware events are dispatched from widgets. (bug 1126090 part 2, r=kats) 2015-03-06 14:26:59 -08:00
Martin Stransky
d15abcbc8c Bug 635134 - Adds X11 run-time check for Gtk3 backend. r=karlt 
--HG--
extra : rebase_source : 18486b689a7ff1560830e63900af1d60348ccabb
 2015-03-05 03:56:00 +01:00
Masayuki Nakano
27d34fdbd2 Bug 1119609 part.3 Implement converting methods from key/code value to key/code name index r=smaug 2015-02-19 15:50:19 +09:00
David Anderson
8b68b8e3e8 Add weak reference support to nsBaseWidget. (bug 1133150, r=roc) 2015-02-17 22:27:53 -08:00
Carsten "Tomcat" Book
4ae7286acb Backed out changeset d81339c7ac52 (bug 1128934) 2015-02-17 14:32:11 +01:00
David Zbarsky
e63a6defd2 Bug 1125040: Use LayoutDeviceIntPoint for synthesizing native events on widgets r=botond 2015-02-15 13:52:28 -05:00
Nicolas Silva
b930f4e186 Bug 1128934 - Avoid calling GetClientBounds from BasicComposior. r=roc, karlt 2015-02-14 12:37:32 +01:00
Martin Stransky
d975c07099 Bug 1097897 - Add HiDPI support (scale) for Gtk2 and update and fix calculation of scaled screen borders. r=karlt 2015-02-10 02:14:00 -05:00
Andrew Comminos
a2fb3116d7 Bug 1126094 - Adds high resolution display support to GdkScreen. r=karlt 
--HG--
extra : rebase_source : e537c0be8ce98c46b81cb7e7e7cffb46c16e2c81
 2015-01-26 17:21:00 +01:00
Nicholas Nethercote
242708cf72 Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo. 
--HG--
extra : rebase_source : 488e401ff87e31a2074c4108c4df0572d9536667
 2015-02-09 14:34:50 -08:00
Andrew McCreight
d3826daa16 Back out Bug 1127201 (part 2) for various problems. 2015-02-06 15:04:32 -08:00
Robert O'Callahan
7a165b59ca Bug 1129774. Part 5: Remove aContext parameter from nsIWidget::Create. r=jmathies 
--HG--
extra : rebase_source : 517ff800c0307e69465a37da7e52605d2fcda0d1
 2015-02-05 20:35:25 +13:00
Robert O'Callahan
282e59cd87 Bug 1129774. Part 3: Remove aContext parameter from BaseCreate and make it nonvirtual. r=jmathies 
--HG--
extra : rebase_source : 9fd0a3e071b7d3ad273667f144889938bc5d9dc4
 2015-02-05 18:18:30 +13:00
Nicholas Nethercote
d34f0301b8 Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo. 
--HG--
extra : rebase_source : 99182e70335d2b5ff95f8c528ae992d37294be3a
 2015-02-04 20:05:36 -08:00
David Zbarsky
c73ec42d2d Bug 1125040: Use LayoutDeviceIntPoint for nsIWidget::WidgetToScreen r=botond 2015-02-04 15:21:03 -05:00
Masatoshi Kimura
14190d843b Bug 1126269 - Part 1: Remove nsError.h dependency from C sources in widget/gtk. r=roc 2015-01-30 08:53:46 +09:00
Jim Mathies
f93fc49262 Bug 1095754 - Add platform widget support for providing widget identifiers used in remote widget tracking and hookl this up on gtk and Windows. r=roc 2015-01-29 13:41:57 -06:00
Jim Mathies
aa597c8906 Bug 1095754 - Transfer bounds information from native plugin widgets to GTK socket widgets when the native plugin widget bounds update. r=roc 2015-01-29 13:41:57 -06:00
Jim Mathies
7c8119a5cf Bug 1126164 - Avoid setting clip regions on plugin windows if the same clip region was already set. r=roc 2015-01-28 09:15:54 -06:00
Masayuki Nakano
dd277f3277 Bug 917322 part.7 TextEventDispatcher should manage if it has composition r=smaug 2015-01-28 15:27:31 +09:00
Andrew Comminos
cc7d995512 Bug 975919 - Add support for HiDPI on GTK 3.10+. r=karlt 2015-01-20 23:53:00 -05:00
Daniel Holbert
dea860b3f7 Bug 1123836: Remove mostly-unused GetPath() impls from nsDeviceContextSpec[Qt,Android,G] classes. r=karlt 2015-01-21 14:09:34 -08:00
Daniel Holbert
95a73f1e45 Bug 1123844: Add MOZ_OVERRIDE annotations (and a few 'virtual' annotations) where appropriate, for headers used in widget/gtk. r=karlt 2015-01-20 13:39:44 -08:00
David Anderson
5364eafbb8 Dispatch scroll wheel events through APZ on Gtk. (bug 1119743, r=nical) 
--HG--
extra : rebase_source : c90e3ff64555bb8e121c1605628e2854ea10c823
 2015-01-12 19:45:10 -08:00
Neil Deakin
a744e9625f Bug 1102039, Ensure that the popup's widget visibility is updated after rollup, allows popups to disappear at the start of the minimize animation rather than after, r=tn 2015-01-07 20:52:20 -05:00
Ehsan Akhgari
860da94550 Bug 1114999 - Part 2: Apply MOZ_NO_ADDREF_RELEASE_ON_RETURN to all smart pointer arrow operators that can return refcounted objects; r=jrmuizel 2015-01-06 16:30:03 -05:00
maciej.a.kaminski@gmail.com
85263abb94 Bug 467405. Avoid getting file info for non-regular files in the gtk file picker. This avoids firefox hanging if the file picker is pointed at a directory with a pipe in it. r=jst,roc 2014-12-20 23:49:18 -08:00
Martin Stransky
0504bfc33a Bug 1073117 - [gtk3] Use GTK_STYLE_CLASS_VIEW style for selected text rendering. r=karlt 
It also merges some duplicated colors and adds GTK_STATE_FLAG_FOCUSED for selected text.
 2014-12-08 01:35:00 -05:00
Martin Stransky
81e1b1a96e Bug 1073117 - Add new GTK_STATE_FLAG_CHECKED for checkbox rendering. r=karlt 2014-12-02 07:14:00 -05:00
Martin Stransky
8142810dd2 Bug 1101582 - [GTK3] - Use window background color for ThreeDFace,ButtonFace. r=karlt 
This fixes missing borders on non-natively-styled textareas.
 2014-11-27 04:08:00 +01:00
Masayuki Nakano
d73bc31eb2 Bug 1077345 part.13 nsGtkIMModule should use NS_COMPOSITION_COMMIT* event r=m_kato 2014-11-25 14:02:34 +09:00
Jonathan Kew
6a598abe4a Bug 1077515 - part 11 - Remap arrow keys for vertical writing mode in the Gtk widget code. r=roc 2014-11-22 14:39:04 +00:00
Vladimir Vukicevic
54548bfc2b Bug 1036597 - extend widget's MakeFullScreen method to take an optional nsIScreen indicating the target; r=karlt 2014-07-09 12:29:28 -07:00
Martin Stransky
a822f9a7f4 Bug 1097592 - Don't use PR_FindFunctionSymbolAndLibrary to avoid app freeze, r=karlt 2014-11-14 06:32:00 +01:00
Jim Mathies
a323270a8b Bug 669200 - Various widget changes to support two new types of plugin widget. r=roc 2014-11-12 14:59:19 -06:00
Masayuki Nakano
a9a96ad464 Bug 1097238 nsGtkIMModule::DispatchCompositionEventsForCommit() should start composition if there is no composition but committing non-empty string r=m_kato 2014-11-12 17:52:19 +09:00
Masayuki Nakano
9d0dbe7124 Bug 1083067 part.10 nsGtkIMModule should use NS_INLINE_DECL_REFCOUNTING r=m_kato 2014-11-10 18:07:45 +09:00
Masayuki Nakano
6e1c43d928 Bug 1083067 part.9 Remove nsGtkIMModule::IsVirtualKeyboardOpened() because it always returns false r=m_kato 2014-11-10 18:07:44 +09:00
Masayuki Nakano
ab614290a2 Bug 1083067 part.8 Create nsGtkIMModule::GetActiveContext() which prefers a composition context if there is r=m_kato 2014-11-10 18:07:44 +09:00
Masayuki Nakano
e36fb76f17 Bug 1083067 part.7 Rename GetContext() to GetCurrentContext() for making clearer the meaning of its result r=m_kato 2014-11-10 18:07:44 +09:00
Masayuki Nakano
1689c1524c Bug 1083067 part.6 Make nsGtkIMModule::CreateTextRangeArray() stateless r=m_kato 2014-11-10 18:07:43 +09:00
Masayuki Nakano
2b4f40fa0b Bug 1083067 part.5 Each IM signal handlers should take GtkIMContext which is being handled r=m_kato 2014-11-10 18:07:43 +09:00
Masayuki Nakano
04082d22be Bug 1083067 part.4 Use IMEContext::MaybeEditable() instead of nsGtkIMModule::IsEditable() r=m_kato 2014-11-10 18:07:43 +09:00
Masayuki Nakano
83a07ac4b6 Bug 1083067 part.3 Remove nsGtkIMModule::CommitCompositionBy() r=m_kato 2014-11-10 18:07:42 +09:00
Masayuki Nakano
b680838344 Bug 1083067 part.2 Remove aIsCommit of nsGtkIMModule::DispatchCompositionChangeEvent() r=m_kato 2014-11-10 18:07:42 +09:00
Masayuki Nakano
1c506a8eb6 Bug 1083067 part.1 Create nsGtkIMModule::DispatchCompositionEventsForCommit() r=m_kato 2014-11-10 18:07:42 +09:00
Mike Conley
5368b2ecee Bug 1082579 - Introduce PPrinting.ipdl and proxies for opening printing UI. r=blassey. 
--HG--
extra : rebase_source : 69ac7840ef72055911daa0ff482236b57f563aba
 2014-10-28 11:59:08 -04:00
Jan Beich
99488d1681 Bug 1089023 - Unbreak GTK3 build after bug 1087732. r=jwatt 2014-10-25 10:08:00 +02:00
Jonathan Watt
ec0e4590cc Bug 1087732 - Get rid of the gfxContext::GetCairo call in nsNativeThemeGTK::DrawWidgetBackground. r=mattwoodrow 2014-10-24 08:26:27 +01:00
Mason Chang
5a78692b60 Bug 1085696. Part 2 Move widget/shared to /widget. r=roc 
--HG--
rename : widget/shared/NativeKeyToDOMCodeName.h => widget/NativeKeyToDOMCodeName.h
rename : widget/shared/NativeKeyToDOMKeyName.h => widget/NativeKeyToDOMKeyName.h
rename : widget/shared/VsyncDispatcher.cpp => widget/VsyncDispatcher.cpp
rename : widget/shared/VsyncDispatcher.h => widget/VsyncDispatcher.h
rename : widget/shared/WidgetEventImpl.cpp => widget/WidgetEventImpl.cpp
rename : widget/shared/nsShmImage.cpp => widget/nsShmImage.cpp
rename : widget/shared/nsShmImage.h => widget/nsShmImage.h
rename : widget/shared/x11/keysym2ucs.c => widget/x11/keysym2ucs.c
rename : widget/shared/x11/keysym2ucs.h => widget/x11/keysym2ucs.h
rename : widget/shared/x11/moz.build => widget/x11/moz.build
 2014-10-23 10:16:47 -07:00
Mason Chang
8180f9229c Bug 1085696. Part 1 Move widget/xpwidget to /widget. r=roc 
--HG--
rename : widget/xpwidgets/ContentHelper.cpp => widget/ContentHelper.cpp
rename : widget/xpwidgets/ContentHelper.h => widget/ContentHelper.h
rename : widget/xpwidgets/GfxDriverInfo.cpp => widget/GfxDriverInfo.cpp
rename : widget/xpwidgets/GfxDriverInfo.h => widget/GfxDriverInfo.h
rename : widget/xpwidgets/GfxInfoBase.cpp => widget/GfxInfoBase.cpp
rename : widget/xpwidgets/GfxInfoBase.h => widget/GfxInfoBase.h
rename : widget/xpwidgets/GfxInfoCollector.cpp => widget/GfxInfoCollector.cpp
rename : widget/xpwidgets/GfxInfoCollector.h => widget/GfxInfoCollector.h
rename : widget/xpwidgets/GfxInfoWebGL.cpp => widget/GfxInfoWebGL.cpp
rename : widget/xpwidgets/GfxInfoWebGL.h => widget/GfxInfoWebGL.h
rename : widget/xpwidgets/GfxInfoX11.cpp => widget/GfxInfoX11.cpp
rename : widget/xpwidgets/GfxInfoX11.h => widget/GfxInfoX11.h
rename : widget/xpwidgets/InputData.cpp => widget/InputData.cpp
rename : widget/xpwidgets/PuppetWidget.cpp => widget/PuppetWidget.cpp
rename : widget/xpwidgets/PuppetWidget.h => widget/PuppetWidget.h
rename : widget/xpwidgets/ScreenProxy.cpp => widget/ScreenProxy.cpp
rename : widget/xpwidgets/ScreenProxy.h => widget/ScreenProxy.h
rename : widget/shared/SharedWidgetUtils.cpp => widget/SharedWidgetUtils.cpp
rename : widget/xpwidgets/WidgetUtils.cpp => widget/WidgetUtils.cpp
rename : widget/xpwidgets/nsAppShellSingleton.h => widget/nsAppShellSingleton.h
rename : widget/xpwidgets/nsBaseAppShell.cpp => widget/nsBaseAppShell.cpp
rename : widget/xpwidgets/nsBaseAppShell.h => widget/nsBaseAppShell.h
rename : widget/xpwidgets/nsBaseClipboard.cpp => widget/nsBaseClipboard.cpp
rename : widget/xpwidgets/nsBaseClipboard.h => widget/nsBaseClipboard.h
rename : widget/xpwidgets/nsBaseDragService.cpp => widget/nsBaseDragService.cpp
rename : widget/xpwidgets/nsBaseDragService.h => widget/nsBaseDragService.h
rename : widget/xpwidgets/nsBaseFilePicker.cpp => widget/nsBaseFilePicker.cpp
rename : widget/xpwidgets/nsBaseFilePicker.h => widget/nsBaseFilePicker.h
rename : widget/xpwidgets/nsBaseScreen.cpp => widget/nsBaseScreen.cpp
rename : widget/xpwidgets/nsBaseScreen.h => widget/nsBaseScreen.h
rename : widget/xpwidgets/nsBaseWidget.cpp => widget/nsBaseWidget.cpp
rename : widget/xpwidgets/nsBaseWidget.h => widget/nsBaseWidget.h
rename : widget/xpwidgets/nsClipboardHelper.cpp => widget/nsClipboardHelper.cpp
rename : widget/xpwidgets/nsClipboardHelper.h => widget/nsClipboardHelper.h
rename : widget/xpwidgets/nsClipboardProxy.cpp => widget/nsClipboardProxy.cpp
rename : widget/xpwidgets/nsClipboardProxy.h => widget/nsClipboardProxy.h
rename : widget/xpwidgets/nsColorPickerProxy.cpp => widget/nsColorPickerProxy.cpp
rename : widget/xpwidgets/nsColorPickerProxy.h => widget/nsColorPickerProxy.h
rename : widget/xpwidgets/nsContentProcessWidgetFactory.cpp => widget/nsContentProcessWidgetFactory.cpp
rename : widget/xpwidgets/nsFilePickerProxy.cpp => widget/nsFilePickerProxy.cpp
rename : widget/xpwidgets/nsFilePickerProxy.h => widget/nsFilePickerProxy.h
rename : widget/xpwidgets/nsHTMLFormatConverter.cpp => widget/nsHTMLFormatConverter.cpp
rename : widget/xpwidgets/nsHTMLFormatConverter.h => widget/nsHTMLFormatConverter.h
rename : widget/xpwidgets/nsIWidgetListener.cpp => widget/nsIWidgetListener.cpp
rename : widget/xpwidgets/nsIdleService.cpp => widget/nsIdleService.cpp
rename : widget/xpwidgets/nsIdleService.h => widget/nsIdleService.h
rename : widget/xpwidgets/nsNativeTheme.cpp => widget/nsNativeTheme.cpp
rename : widget/xpwidgets/nsNativeTheme.h => widget/nsNativeTheme.h
rename : widget/xpwidgets/nsPrimitiveHelpers.cpp => widget/nsPrimitiveHelpers.cpp
rename : widget/xpwidgets/nsPrimitiveHelpers.h => widget/nsPrimitiveHelpers.h
rename : widget/xpwidgets/nsPrintOptionsImpl.cpp => widget/nsPrintOptionsImpl.cpp
rename : widget/xpwidgets/nsPrintOptionsImpl.h => widget/nsPrintOptionsImpl.h
rename : widget/xpwidgets/nsPrintSession.cpp => widget/nsPrintSession.cpp
rename : widget/xpwidgets/nsPrintSession.h => widget/nsPrintSession.h
rename : widget/xpwidgets/nsPrintSettingsImpl.cpp => widget/nsPrintSettingsImpl.cpp
rename : widget/xpwidgets/nsPrintSettingsImpl.h => widget/nsPrintSettingsImpl.h
rename : widget/xpwidgets/nsScreenManagerProxy.cpp => widget/nsScreenManagerProxy.cpp
rename : widget/xpwidgets/nsScreenManagerProxy.h => widget/nsScreenManagerProxy.h
rename : widget/xpwidgets/nsTransferable.cpp => widget/nsTransferable.cpp
rename : widget/xpwidgets/nsTransferable.h => widget/nsTransferable.h
rename : widget/xpwidgets/nsXPLookAndFeel.cpp => widget/nsXPLookAndFeel.cpp
rename : widget/xpwidgets/nsXPLookAndFeel.h => widget/nsXPLookAndFeel.h
 2014-10-23 10:16:45 -07:00
Masayuki Nakano
2cc4765075 Bug 1084302 Fix wrong aIsCommit argument values of DispatchCompositionChangeEvent() calls in DeleteText() r=karlt 2014-10-17 04:38:21 +09:00
Masayuki Nakano
02e8cdd26f Bug 1083098 Allow to handle GTK composition events if given IM context is same as one of our own IM contexts for cleaning up composition state which is being committed asynchronously r=karlt 2014-10-24 02:17:15 +09:00
Eric Rahm
7fffd05532 Bug 806819 - Part 4: Add files that were excluded from unified builds back in. r=ehsan 2014-10-08 13:19:14 -07:00
Eric Rahm
8d715a7fe4 Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan 2014-10-08 13:17:32 -07:00
Masayuki Nakano
d028544b2b Bug 960871 part.9 Rename methods and classes which handled WidgetTextEvent r=smaug 2014-10-07 19:01:49 +09:00
Masayuki Nakano
6072e74d01 Bug 960871 part.8 Rename variable names of NS_COMPOSITION_CHANGE event r=smaug 2014-10-07 19:01:49 +09:00
Masayuki Nakano
9011740f12 Bug 960871 part.6 Use WidgetCompositionEvent for NS_COMPOSITION_CHANGE instead of WidgetTextEvent r=smaug 2014-10-07 19:01:48 +09:00
Masayuki Nakano
09a5b86212 Bug 960871 part.4 Rename NS_TEXT_TEXT to NS_COMPOSITION_CHANGE and fix comments which mention text events r=smaug 2014-10-07 19:01:47 +09:00
Masayuki Nakano
aafe327f6d Bug 960871 part.2 Rename WidgetCompositionEvent::data to WidgetCompositionEvent::mData r=smaug 2014-10-07 19:01:46 +09:00
Masayuki Nakano
ea79d5919e Bug 960871 part.1 Rename WidgetTextEvent::theText to WidgetTextEvent::mData r=smaug 2014-10-07 19:01:46 +09:00
Wes Kocher
445e1466e9 Backed out 5 changesets (bug 806819) for WinXP test failures on a CLOSED TREE 
Backed out changeset 009ae35b0c67 (bug 806819)
Backed out changeset 5a57f87f5061 (bug 806819)
Backed out changeset f06cd735b5b3 (bug 806819)
Backed out changeset e25a2a8d4af4 (bug 806819)
Backed out changeset 70a167982c3f (bug 806819)
 2014-10-06 16:32:50 -07:00
Eric Rahm
53a247fb00 Bug 806819 - Part 4: Add files that were excluded from unified builds back in. r=ehsan 
--HG--
extra : rebase_source : 49a3f57d94fc94702f1604175c4e206091b67197
 2014-10-06 13:11:24 -07:00
Eric Rahm
80d2b8bba6 Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan 
--HG--
extra : rebase_source : c96eea1c12ea8c19314393f0e8b4b57a4316a61d
 2014-10-06 13:08:20 -07:00
Masayuki Nakano
43ed4f17bf Bug 975383 part.4 Remove compositionupdate dispatchers in nsGtkIMModule of GTK r=karlt 2014-10-03 15:33:48 +09:00
Eric Rahm
7928574529 Bug 1076417 - nsNativeThemeGTK.h is missing an include guard. r=roc 
--HG--
extra : rebase_source : 7f24f20b6602cf5b044fac87ccc1a72cc6d7f934
 2014-10-01 19:01:21 -07:00
Masayuki Nakano
1cc2ff10cb Bug 1065835 part.6 Remove NOTIFY_IME_OF_CURSOR_POS_CHANGED and nsGtkIMModule should handle NOTIFY_IME_OF_SELECTION_CHANGE instead r=smaug+ehsan+karlt 2014-09-26 09:05:13 +09:00
Masayuki Nakano
c98d550934 Bug 1065835 part.5 nsGtkIMModule doesn't need to synthesize composition events for committing composition synchronously since TextComposition now supports it r=karlt 2014-09-26 09:05:13 +09:00
Benoit Jacob
9047e55dd0 Bug 1025802 - Replace a MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE by MOZ_CRASH - r=mattwoodrow 2014-09-24 13:43:00 -04:00
Timothy Arceri
9968e0942d b=1068964 Remove gtk_check_version for GTK 2 r=karlt 
Remove gtk_check_version() checks for GTK 2 as the minimum
version now covers all cases

--HG--
extra : rebase_source : b94f981abe0b0561f6223ae2949559152e46f13e
 2014-09-22 18:16:37 +10:00
Christoph Kerschbaumer
16086dd4a6 Bug 1038756: Callsites creating a channel in /widget/gtk/ (r=roc) 2014-09-21 09:42:14 -07:00
Karl Tomlinson
0176167cc4 backout 2a782a973a3d for error: unused variable 'container' b=1068964 CLOSED TREE 2014-09-22 16:00:52 +12:00