Commit Graph

720165 Commits

Author SHA1 Message Date
Stephen A Pohl
09651af1bd Bug 1640195: Address UX feedback for non-native widget styling. r=geckoview-reviewers,emilio,agi
Differential Revision: https://phabricator.services.mozilla.com/D76509
2020-07-30 17:02:02 +00:00
Justin Wood
847dc95734 Bug 1653050 - Allow optimizing by replacement existing (pending/unscheduled) cached tasks. r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D83280
2020-07-30 16:14:15 +00:00
Nathan Froyd
143348fef5 Bug 1223932 - delete GuardObjectNotifier usages from the JS rust bindings;
Automated removals don't catch uses in Rust bindings!

Differential Revision: https://phabricator.services.mozilla.com/D85424
2020-07-30 16:54:43 +00:00
Agi Sferro
3b4ead5ae4 Bug 1656078 - Handle negative FONT_SCALE values. r=owlish
Differential Revision: https://phabricator.services.mozilla.com/D85337
2020-07-30 16:48:32 +00:00
Drew Willcoxon
b7916828ff Bug 1647896 - Add local search mode one-offs for history, bookmarks, and tabs. r=harry,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D85237
2020-07-30 16:12:46 +00:00
Steven MacLeod
2855b53b55 Bug 1587418 - check shortcuts permission using WindowContext. r=farre
We now use the cached value of the shortcuts permission from
`WindowContext` if we cannot get a `Browser`. This will now work
when calling from a child where the top-level document is OOP.

Differential Revision: https://phabricator.services.mozilla.com/D84183
2020-07-29 13:39:02 +00:00
Steven MacLeod
baee2f562d Bug 1587418 - cache shortcuts permission on WindowContext. r=farre
We now cache the shortcuts permission in a synced field on
`WindowContext`. This will allow checking the permission quickly and
without IPC when Fission is enabled and the top-level document is
in another process.

Differential Revision: https://phabricator.services.mozilla.com/D84182
2020-07-30 12:26:24 +00:00
Chun-Min Chang
1d1f60a518 Bug 1642729 - P6: Save images in a dictionary r=gcp
Saving the temporary files under a dictionary without
world/group-execute permissions

Differential Revision: https://phabricator.services.mozilla.com/D85076
2020-07-29 15:59:58 +00:00
Chun-Min Chang
34fc308ee7 Bug 1642729 - P5: Set the permission of the temporary file to 600 r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D85075
2020-07-29 15:59:56 +00:00
Chun-Min Chang
d97fe95469 Bug 1642729 - P4: Load URL without user-specific data r=ckerschb
The URL specifying the track image should be loaded without any
user-specific data like cookie headers, or HTTP Auth credentials.

Differential Revision: https://phabricator.services.mozilla.com/D83695
2020-07-29 15:59:54 +00:00
Chun-Min Chang
6a3cd37f74 Bug 1642729 - P3: Only fetch image from http(s) URL r=ckerschb
The URL specifying the track image is only valid if its scheme is http
or https.

Differential Revision: https://phabricator.services.mozilla.com/D83694
2020-07-29 15:59:46 +00:00
Chun-Min Chang
bf7aa89c86 Bug 1642729 - P2: Move same utils in SMTC and MPRIS backend to MediaControlUtils.h r=alwu
The duplicated util helpers between WindowsSMTCProvider and
MPRISServiceHandler could be merged and moved to MediaControlUtils

Differential Revision: https://phabricator.services.mozilla.com/D82806
2020-07-29 15:59:44 +00:00
Chun-Min Chang
d8390d6682 Bug 1642729 - P1: Set track image to MPRIS r=alwu
Select an image from the media-session's artwork and load it to MPRIS.

In current implementation, the image specified by an URL would be
downloaded to a local file, and the path of that local file would be set
to MPRIS "mpris:artUrl" property.

Differential Revision: https://phabricator.services.mozilla.com/D80303
2020-07-29 15:59:36 +00:00
Matthew Gaudet
1a195db021 Bug 1656276 - Enable test262 proxy tests for private fields r=anba
Differential Revision: https://phabricator.services.mozilla.com/D85420
2020-07-30 16:06:05 +00:00
Perry Jiang
da8e648cb4 Bug 1655103 - remove unused ServiceWorkerManager methods r=dom-workers-and-storage-reviewers,ttung
Differential Revision: https://phabricator.services.mozilla.com/D84846
2020-07-29 08:40:06 +00:00
Chris H-C
45df602b5e Bug 1655835 - Remove unused Telemetry CaptureStack r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D85281
2020-07-30 10:31:30 +00:00
Nathan Froyd
e3ebda1914 Bug 1223932 - delete guard object uses from the tree; r=jwalden
CLOSED TREE

We don't need these macros anymore, for two reasons:

1. We have static analysis to provide the same sort of checks via `MOZ_RAII`
   and friends.
2. clang now warns for the "temporary that should have been a declaration" case.

The extra requirements on class construction also show up during debug tests
as performance problems.

This change was automated by using the following sed script:

```
# Remove declarations in classes.
/MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER/d
/MOZ_GUARD_OBJECT_NOTIFIER_INIT/d

# Remove individual macros, carefully.
{
  # We don't have to worry about substrings here because the closing
  # parenthesis "anchors" the match.
  s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM)/)/g;
  s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)/)/g;
  s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)/)/g;
  s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL)/)/g;

  # Remove the longer identifier first.
  s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_TO_PARENT//g;
  s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM//g;
}

# Remove the actual include.
\@# *include "mozilla/GuardObjects.h"@d
```

and running:

```
find . -name \*.cpp -o -name \*.h | grep -v 'GuardObjects.h' |xargs sed -i -f script 2>/dev/null
mach clang-format
```

Differential Revision: https://phabricator.services.mozilla.com/D85168
2020-07-30 14:22:38 +00:00
Imanol Fernandez
0c20e550e5 Bug 1655006 - Implement WebXR nativeFramebufferScaleFactor. r=jgilbert,kip,daoshengmu
Clamp the requested XRWebGLLayer framebuffer size to ensure it's not too small to see or larger than the max native resolution.

Differential Revision: https://phabricator.services.mozilla.com/D84799
2020-07-29 10:00:53 +00:00
Jamie Nicol
e3085373f9 Bug 1656210 - Update glslopt version to fix FreeBSD/Dragonfly build. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D85394
2020-07-30 15:23:03 +00:00
Mihai Alexandru Michis
a911a108d0 Backed out changeset ac9c811bc427 (bug 1223932) for causing spidermonkey rust failures.
CLOSED TREE
2020-07-30 18:23:21 +03:00
Mark Banner
c8578acd2d Bug 1656007 - Move URLBAR_SELECTED_RESULT_TYPES to UrlbarUtils since it is not used in BrowserUsageTelemetry. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D85302
2020-07-30 14:27:50 +00:00
Mark Banner
7b5f150a6a Bug 1656007 - Move URLBAR_SELECTED_RESULT_METHODS to UrlbarTestUtils as it is only used in tests. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D85301
2020-07-30 15:04:20 +00:00
Julian Descottes
b6490f5a49 Bug 1582594 - Wait for flexbox store update after selection in browser_markup_flex_display_badge r=rcaliman
This test is highly intermittent locally, and it seems to be spiking on try since bug 1633727.
The issue is that we try to click on the "flex" badge too quickly after selecting the node, before the flexbox store has had time to update.

Differential Revision: https://phabricator.services.mozilla.com/D85403
2020-07-30 14:37:31 +00:00
Andrei Oprea
a439d088f5 Bug 1655452 - Snippet error state redirects to wrong retry scene r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D85132
2020-07-30 14:17:12 +00:00
Nathan Froyd
bec9f9b93a Bug 1223932 - delete guard object uses from the tree; r=jwalden
We don't need these macros anymore, for two reasons:

1. We have static analysis to provide the same sort of checks via `MOZ_RAII`
   and friends.
2. clang now warns for the "temporary that should have been a declaration" case.

The extra requirements on class construction also show up during debug tests
as performance problems.

This change was automated by using the following sed script:

```
# Remove declarations in classes.
/MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER/d
/MOZ_GUARD_OBJECT_NOTIFIER_INIT/d

# Remove individual macros, carefully.
{
  # We don't have to worry about substrings here because the closing
  # parenthesis "anchors" the match.
  s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM)/)/g;
  s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)/)/g;
  s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)/)/g;
  s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL)/)/g;

  # Remove the longer identifier first.
  s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_TO_PARENT//g;
  s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM//g;
}

# Remove the actual include.
\@# *include "mozilla/GuardObjects.h"@d
```

and running:

```
find . -name \*.cpp -o -name \*.h | grep -v 'GuardObjects.h' |xargs sed -i -f script 2>/dev/null
mach clang-format
```

Differential Revision: https://phabricator.services.mozilla.com/D85168
2020-07-30 14:22:38 +00:00
Chris H-C
99dccc791c Bug 1650282 - Ignore NSS Shutdown leaks in telemety marionette tests r=raphael
Differential Revision: https://phabricator.services.mozilla.com/D84174
2020-07-30 13:40:57 +00:00
Yura Zenevich
86b660210e Bug 1653186 - fix highlighter in about:addons (ensure that the highlighter markup nodes are created using the correct window/document). r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D85191
2020-07-30 14:00:11 +00:00
Yura Zenevich
e9437a481d Bug 1650094 - making the box model highlighter work in the browser toolbox. r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D81476
2020-07-30 14:00:03 +00:00
Yura Zenevich
e65360bcf3 Bug 1648161 - update code paths where canvas helper was expected to insert synchronously. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D82416
2020-07-30 13:59:53 +00:00
Yura Zenevich
c894b69ce1 Bug 1648161 - use accessible highlighter instead of xul-accessible highlighter in browser toolbox. Remove xul-accessible highlighter altogether. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D80005
2020-07-30 13:59:36 +00:00
Nika Layzell
d0686776d2 Bug 1648955 - Check parent WC is in-proc rather than parent BC nsDocShell to tree, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D85309
2020-07-30 12:27:12 +00:00
Brindusan Cristian
ead144d750 Backed out 7 changesets (bug 1654295) for mochitest failures at test_ioutils.html. CLOSED TREE
Backed out changeset 5759d0505c0e (bug 1654295)
Backed out changeset 08bc2a5eefd0 (bug 1654295)
Backed out changeset eef5969a2e21 (bug 1654295)
Backed out changeset 6bac11641ad3 (bug 1654295)
Backed out changeset c94e94a51e94 (bug 1654295)
Backed out changeset 8dd9ad718cf9 (bug 1654295)
Backed out changeset 44191218e308 (bug 1654295)
2020-07-30 16:11:00 +03:00
alexandru.ionescu
dc48118989 Bug 1655739 google-docs and google-sheets to record with mitm5 r=Bebe,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D85369
2020-07-30 12:20:32 +00:00
Sebastian Streich
530412c9cf Bug 1655719 - Make Type:SaveAsDownload subject to mixedContentBlocking r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D85267
2020-07-30 12:26:49 +00:00
Jan de Mooij
e731da409b Bug 1655940 part 1 - Optimize New{Array,String,RegExpString}Iterator intrinsics in CacheIR and Warp. r=anba
Differential Revision: https://phabricator.services.mozilla.com/D85274
2020-07-30 12:20:06 +00:00
Tom Schuster
6e7b4b3543 Bug 1645902 - Optimize UnsafeSetReservedSlot in CacheIR and Warp. r=anba
Reusing StoreFixedSlot is hard because it uses the TypeUpdate IC and doesn't
return |undefined|.

Initial patch written by evilpie.

Differential Revision: https://phabricator.services.mozilla.com/D79751
2020-07-30 12:11:47 +00:00
Jan de Mooij
294414b086 Bug 1655982 - Remove redundant skip-if from TypedObject jit-test. r=bc
The directory has a directives.txt with the same skip-if. The mixed quotes also
broke jit-tests on Android.

Differential Revision: https://phabricator.services.mozilla.com/D85365
2020-07-30 12:11:47 +00:00
Nicolas Chevobbe
6949d7f72c Bug 1655951 - Fix browser/browser_jsterm_evaluation_context_selector_pause_in_debugger.js failure. r=jdescottes.
It seems that the test was failing because the focus wasn't on the console by
the time we were trying to evaluate the input, so the Enter keypress wasn't
registered and the input not evaluated.
This is fixed by focusing the console input in `keyboardExecuteAndWaitForMessage`,
before hitting Enter.

Differential Revision: https://phabricator.services.mozilla.com/D85368
2020-07-30 08:58:56 +00:00
Jonathan Kew
95e0f6f509 Bug 1655364 - Rename gfxShapedText::SetGlyphs to SetDetailedGlyphs and make it just set glyph information, not clobber character-type flags. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D85187
2020-07-30 11:48:06 +00:00
Dão Gottwald
e59131518d Bug 1655946 - Add X-Target-URL header to top site attribution requests. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D85272
2020-07-30 11:39:08 +00:00
Tooru Fujisawa
188db27510 Bug 1648574 - Support lazy function. r=nbp
Differential Revision: https://phabricator.services.mozilla.com/D85363
2020-07-30 11:01:52 +00:00
Dragana Damjanovic
d16e97fa44 Bug 1655782 - Turn on the QPACK dynamic table. r=michal
Differential Revision: https://phabricator.services.mozilla.com/D85176
2020-07-30 06:40:37 +00:00
alexandru.ionescu
a89b49b236 Bug 1655841 Temporarily disable confidence/replayed/not-replayed metrics r=Bebe,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D85367
2020-07-30 07:09:55 +00:00
Andrew Osmond
335feeb874 Bug 1654262 - Ship WebRender to Intel gen7.5 gt1-3 laptop users. r=nical
Also, lower the minimum driver version from 24.20.100.6286 to
23.20.16.4973.

Differential Revision: https://phabricator.services.mozilla.com/D85359
2020-07-30 07:50:34 +00:00
Joel Maher
be5ab044f2 Bug 1656191 - fix wpt tests for osx 10.14.6. r=jgraham
fix wpt tests for osx 10.14.6

Differential Revision: https://phabricator.services.mozilla.com/D85387
2020-07-30 10:24:28 +00:00
Tarek Ziadé
cb00bce720 Bug 1655956 - removed unused perf tuning code r=sparky
Removes unused API and add missing coverage

Differential Revision: https://phabricator.services.mozilla.com/D85285
2020-07-29 17:35:35 +00:00
Mihai Alexandru Michis
78c470dbaa Backed out changeset 3c88adc13a06 (bug 1655364) for causing assertion failures regarding glyphs.
CLOSED TREE
2020-07-30 13:25:04 +03:00
Henrik Skupin
994f0d8317 Bug 1651297 - [marionette] Improve debug logging for paintComplete in reftests. r=marionette-reviewers,jgraham,maja_zf
Depends on D84525

Differential Revision: https://phabricator.services.mozilla.com/D84526
2020-07-30 10:00:19 +00:00
Henrik Skupin
00975680ca Bug 1651297 - [web-platform-tests] Mark description and extension metadatadisplay-schema tests as intermittent fail on windows7 debug. r=jfkthame
Depends on D82656

Differential Revision: https://phabricator.services.mozilla.com/D84525
2020-07-22 15:20:09 +00:00
Henrik Skupin
9fea18565b Bug 1651297 - [web-platform-tests] Use "about:blank" instead of "about:newtab" for newly opened tabs. r=jgraham
Differential Revision: https://phabricator.services.mozilla.com/D82656
2020-07-22 15:08:11 +00:00