Commit Graph

654427 Commits

Author SHA1 Message Date
Jeff Walden
0ae75c0f53 Bug 1556900 - Make |ScriptSource::uncompressedData| more cautious about verifying the type of the contained data before returning a pointer. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D33733

--HG--
extra : moz-landing-system : lando
2019-06-05 00:58:58 +00:00
Jeff Walden
82d9632938 Bug 1556900 - Move |ScriptSource::binASTMetadata_| into the |BinAST| arm of |ScriptSource::data|, reducing the size of |ScriptSource| by a pointer. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D33732

--HG--
extra : moz-landing-system : lando
2019-06-05 00:58:44 +00:00
Daniel Varga
fc4ca9bf41 Backed out changeset 421f9e16c210 (bug 1526818) for linting failure at /builds/worker/checkouts/gecko/browser/components/urlbar/UrlbarProviderUnifiedComplete.jsm on a CLOSED TREE 2019-06-05 03:53:07 +03:00
Daniel Varga
3bc762bcf1 Backed out changeset d64cb52ebf88 (bug 1543812) for xpcshell failure at parser/xml/test/unit/test_sanitizer.js. On a CLOSED TREE 2019-06-05 03:50:16 +03:00
Chris Pearce
0ebe8e14ac Bug 1552145 - Change HLS seek to seek before seek target and drop frames until next keyframe. r=jya
The Java ExoPlayer that we use for HLS support on Android does an accurate
seek, that is, it seeks to the frame at the seek target. This may not be a
keyframe, which we can start decoding at. So change the HLS seek to seek 2
seconds behind the seek target, and drop all frames up to the next keyframe.
This means that after a seek the HLSDemuxer will output a keyframe, and
hopefully (but we can't guarantee of course) it will lie behind the actual seek
target.

We also need to purge the GeckoHlsVideoRenderer's queue of frames which it
is holding onto in order to determine their durations, otherwise after a seek,
we'll get output from this queue of frames. That is, after a seek we would still
get a few frames from the old playback position.

This seek case is particularly problematic as we aggressively shutdown decoders
when the media is paused, including right after the load reaches
loadedmetadata, and we need to seek in order to recover from going dormant.

Differential Revision: https://phabricator.services.mozilla.com/D33254

--HG--
extra : moz-landing-system : lando
2019-06-04 22:20:49 +00:00
Omkar Konaraddi
8b54554246 Bug 1526818 - QuantumBar: Expose an autocomplete.properties bundle from UrlbarUtils r=adw
Differential Revision: https://phabricator.services.mozilla.com/D33726

--HG--
extra : moz-landing-system : lando
2019-06-05 00:28:40 +00:00
Brian Grinstead
af79f6a5c1 Bug 1556857 - Return true in AttributeChangeRequiresSubtreeRestyle whenever lwtheme attrs change in any chrome doc, not just those with XUL document elements r=emilio
In preparation for an <html> root node in browser.xhtml, we need to react to lwtheme changes correctly.

Differential Revision: https://phabricator.services.mozilla.com/D33693

--HG--
extra : source : afa5d3807c8b5810203718e158fa4b185e109f55
2019-06-04 20:43:51 +00:00
Lina Cambridge
ede2c0b68a Bug 1552621 - Include optional steps in Sync engine telemetry. r=tcsc,tdsmith
Before this commit, we used event telemetry to record timing and counts
for the different steps of a bookmark merge (fetching the local tree,
new local contents, remote tree, and new remote contents; merging;
applying; fetching outgoing records; and notifying observers).

This has several limitations. We need to store all numbers as strings,
include a "flow ID" to tag events from the same merge, and collect
failure reasons twice. We also can't correlate these events to the
existing engine telemetry, meaning we can't see other stats for that
engine, or for the entire sync. Finally, we need to run separate
queries on these events for analysis, instead of extending our
existing engine dashboards.

This approach also feels like an abuse of event telemetry, so this
commit adds a "steps" field for each engine in the Sync ping. Each step
has a name, time taken, and additional named counts, like the number of
items in the tree, or merged structure stats.

Currently, only the `buffered-bookmarks` engine records these steps.

Differential Revision: https://phabricator.services.mozilla.com/D33411

--HG--
extra : moz-landing-system : lando
2019-06-04 20:08:07 +00:00
Lina Cambridge
efa5e0cc06 Bug 1552621 - Record bookmark validation telemetry for the buffered engine. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D33410

--HG--
extra : moz-landing-system : lando
2019-06-04 20:08:51 +00:00
Lina Cambridge
0c9500bf00 Bug 1552621 - Record shutdown blocker progress in the bookmarks mirror. r=markh,tcsc
This commit introduces a `mozISyncedBookmarksMirrorProgressListener`
interface for capturing telemetry and updating shutdown blocker state
after each step of the merge, instead of waiting until the end. This
also means we can also record events for interrupted and failed merges,
and pass validation data through to the Sync ping.

Shutdown hang crash reports now have a `steps` field, indicating the
sequence of completed steps and when they were recorded. If the last
step in the hang report is `fetchLocalTree`, we know the merger is
blocked on `fetchNewLocalContents`. If the last step is
`fetchNewLocalContents`, the merger is stuck at `fetchRemoteTree`,
since that's the next step after `fetchNewLocalContents`.

This commit also implements `Driver::record_telemetry_event` to
dispatch progress callback runnables to the main thread.

Differential Revision: https://phabricator.services.mozilla.com/D31950

--HG--
extra : moz-landing-system : lando
2019-06-03 23:04:37 +00:00
Daniel Varga
80149d9771 Backed out 4 changesets (bug 1551902) for browser-chrome failure at browser/base/content/test/trackingUI/browser_trackingUI_cryptominers.js. On a CLOSED TREE
Backed out changeset 762ba28bc409 (bug 1551902)
Backed out changeset 4c8afa61cbec (bug 1551902)
Backed out changeset 212cfe3c1893 (bug 1551902)
Backed out changeset 29cbb321a610 (bug 1551902)
2019-06-05 02:48:37 +03:00
Daniel Varga
667d23bec1 Backed out changeset afa5d3807c8b (bug 1556857) for mochitest failure at builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:268. On a CLOSED TREE 2019-06-05 02:24:07 +03:00
Timothy Nikkel
37a94d2f98 Bug 1556360. Release nsIconChannel on main thread. r=aosmond
It will cause releasing nsLoadGroup which doesn't like being released off main thread.

Differential Revision: https://phabricator.services.mozilla.com/D33590

--HG--
extra : moz-landing-system : lando
2019-06-04 22:46:59 +00:00
Makoto Kato
fc2204cf13 Bug 1556617 - Remove old mozilla.widget.* prefs from GV. r=geckoview-reviewers,esawin
`mozilla.widget.*` was used by old Fennec (Maemo/GTK2). But Android widget doesn't reference this.

### `mozilla.widget.disable-native-theme`

This preference is unused on Android widget. This is for GTK and Windows.  Reftests on Android are disabled by `layout/reftests/reftest.list`.

### `mozilla.widget.force-24bpp`

This is unused on Android. This is GTK only.

### `mozilla.widget.use-buffer-pixmap`

No one uses this preference.

Differential Revision: https://phabricator.services.mozilla.com/D33609

--HG--
extra : moz-landing-system : lando
2019-06-04 14:50:27 +00:00
Mike Hommey
281c7a2177 Bug 1556662 - Fix a typo in change from bug 1469091. r=dmajor
In a branch for `isinstance(obj, (HostSources, HostGeneratedSources))`,
`isinstance(obj, GeneratedSources)` is clearly not going to match
anything. `isinstance(obj, HostGeneratedSources)` is what was intended.

Differential Revision: https://phabricator.services.mozilla.com/D33603

--HG--
extra : moz-landing-system : lando
2019-06-04 11:39:44 +00:00
Connor Brewster
da4ad436ef Bug 1556590 - Display root render task instead of last render task in WebRender debugger r=gw
Differential Revision: https://phabricator.services.mozilla.com/D33582

--HG--
extra : moz-landing-system : lando
2019-06-04 20:52:29 +00:00
Jan-Ivar Bruaroey
612f805223 Bug 1552571: Optimize GetUserMediaWindowListener's source listener iteration and ownership. r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D31687

--HG--
extra : moz-landing-system : lando
2019-06-04 22:39:14 +00:00
Omkar Konaraddi
f0d5ea37a3 Bug 1534552 - Properly document selection resetting in UrlbarInput::_loadURL r=adw
Differential Revision: https://phabricator.services.mozilla.com/D33713

--HG--
extra : moz-landing-system : lando
2019-06-04 22:33:44 +00:00
Nicholas Nethercote
48fb92c3c5 Bug 1556268 - Remove aboutCompartments.xhtml. r=mccr8
about:compartments hasn't resolved for a long time.

Differential Revision: https://phabricator.services.mozilla.com/D33431

--HG--
extra : moz-landing-system : lando
2019-06-02 23:05:01 +00:00
Brian Grinstead
77639078e9 Bug 1556857 - Return true in AttributeChangeRequiresSubtreeRestyle whenever lwtheme attrs change in any chrome doc, not just those with XUL document elements r=emilio
In preparation for an <html> root node in browser.xhtml, we need to react to lwtheme changes correctly.

Differential Revision: https://phabricator.services.mozilla.com/D33693

--HG--
extra : moz-landing-system : lando
2019-06-04 20:43:51 +00:00
Dale Harvey
6066384ce3 Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D30135

--HG--
extra : moz-landing-system : lando
2019-06-04 17:33:06 +00:00
Nihanth Subramanya
523e69c325 Bug 1551902 - Add a test for the toggle switch in the protections panel. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D32982

--HG--
extra : moz-landing-system : lando
2019-06-04 21:48:43 +00:00
Nihanth Subramanya
0306ad135b Bug 1551902 - ContentBlocking: Set hasException attribute in onLocationChange. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D32981

--HG--
extra : moz-landing-system : lando
2019-06-04 21:48:30 +00:00
Nihanth Subramanya
7ef288a488 Bug 1551902 - Hide protections panel when focus is lost. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D32980

--HG--
extra : moz-landing-system : lando
2019-06-04 21:48:03 +00:00
Nihanth Subramanya
6b2d4c647f Bug 1551902 - Implement Tracking Protection toggle section in Protections Panel. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D32952

--HG--
extra : moz-landing-system : lando
2019-06-04 21:47:20 +00:00
Narcis Beleuzu
3c50127358 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-06-05 00:51:07 +03:00
Narcis Beleuzu
790ffc99ca Merge inbound to mozilla-central. a=merge 2019-06-05 00:43:34 +03:00
Andrew Sutherland
4e20ede87a Bug 1533802 - Sticky nesting for C++, Rust, JS r=kats
These are the changes from https://github.com/mozsearch/mozsearch/pull/212
(including the typo fixes requested today.

Differential Revision: https://phabricator.services.mozilla.com/D33701

--HG--
extra : moz-landing-system : lando
2019-06-04 20:49:34 +00:00
Nihanth Subramanya
203396c6e0 Bug 1555562 - Make sure LocalStorageManager::PrecacheStorage() passes in the real storage principal. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33559

--HG--
extra : moz-landing-system : lando
2019-06-04 21:13:40 +00:00
Ehsan Akhgari
b79f2aaa94 Bug 1556859 - Remove SessionStorage::Clone(); r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33703

--HG--
extra : moz-landing-system : lando
2019-06-04 21:09:03 +00:00
Omkar Konaraddi
99ef8907db Bug 1536816 - Remove the TODO comment in UrlbarInput::handleCommand. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D33694

--HG--
extra : moz-landing-system : lando
2019-06-04 20:54:18 +00:00
Henrik Skupin
edc64f91af Bug 1335085 - [marionette] Simplify focus handling for window classes in firefox-puppeteer. r=webdriver-reviewers,ato
Depends on D33690

Differential Revision: https://phabricator.services.mozilla.com/D33691

--HG--
extra : moz-landing-system : lando
2019-06-04 21:02:46 +00:00
Henrik Skupin
7fce583895 Bug 1335085 - [marionette] Fix "WebDriver:SwitchToWindow" for tab and window focus switching. r=webdriver-reviewers,ato
Selecting a different tab is asynchronous, and as such Marionette has
to wait for the "TabSelect" event to be emitted. Further the chrome
window also needs to be focused.

Depends on D33689

Differential Revision: https://phabricator.services.mozilla.com/D33690

--HG--
extra : moz-landing-system : lando
2019-06-04 20:42:28 +00:00
Henrik Skupin
ff16db3723 Bug 1335085 - [marionette] Make use of "WebDriver:NewWindow" in firefox-puppeteer. r=webdriver-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D33689

--HG--
extra : moz-landing-system : lando
2019-06-04 20:41:12 +00:00
Daniel Varga
2289134635 Backed out changeset 96ea626be10a (bug 1553472) fot devtools failure at devtools/client/framework/test/browser_toolbox_zoom_popup.js. On a CLOSED TREE 2019-06-04 20:45:54 +03:00
Ehsan Akhgari
8349684af8 Bug 1556093 - Use the storage principal when constructing a PBackgroundLocalStorageCache actor; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33557

--HG--
extra : moz-landing-system : lando
2019-06-04 17:02:21 +00:00
Francis Houle
6ab927ce7f Bug 1552806 - Remove 'tabs' mention from setup page intro text. r=jdescottes,flod
Differential Revision: https://phabricator.services.mozilla.com/D33114

--HG--
extra : moz-landing-system : lando
2019-06-04 16:21:04 +00:00
Jim Porter
f665b313f3 Bug 1552017 - Expand the kinds of URLs that can cancel content JS when navigating; r=smaug
This patch makes several changes to the kinds of URLs where we can cancel
content JS when navigating between them:

 1) When navigating directly to a URL (e.g. by typing something into the
    location bar and hitting Enter), we allow canceling content JS if the URLs
    differ in any way *except* their ref ("#"). To help with this, we also
    attempt to fix up the URL (e.g. by prepending "http://" to it).

 2) When navigating through history, we allow canceling content JS if the
    `prePath` part of the URLs differ. Most notably, this allows canceling
    content JS when one of the URLs is an `about:` page (e.g. when hitting the
    Home button).

 3) We explicitly disallow cancelling content JS if the currently-running JS
    is trusted or if the page being navigated away from is anything but
    http(s): or file:.

 4) We also disallow cancelling content JS for windows that are still being
    created (e.g. when creating a new tab or window via `window.open`). For
    more background on this, see the comments about `mCreatingWindow` in
    dom/ipc/BrowserParent.h.

 5) We ensure that, when attempting to cancel JS, the tab ID of the
    currently-running script matches the original tab that requested the
    cancellation. This avoids a race condition in which a particular JSContext
    has already moved on to executing another tab's JS by the time we hit our
    interrupt callback.

Differential Revision: https://phabricator.services.mozilla.com/D31875

--HG--
extra : moz-landing-system : lando
2019-06-04 16:19:27 +00:00
Dale Harvey
bd3dac3bc5 Bug 1556424 - Dont await init() on init() installed engines. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D33577

--HG--
extra : moz-landing-system : lando
2019-06-04 16:44:29 +00:00
Bogdan Tara
ae2ef98e40 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-06-04 19:08:56 +03:00
Bogdan Tara
0152d321a5 Merge inbound to mozilla-central. a=merge 2019-06-04 19:05:52 +03:00
Nikki Sharpley
2959e634d5 Bug 1556772 - Remove test for EqualTimeChunker class as it no longer exists r=jgraham
The EqualTimeChunker class no longer exists but the test remains. This patch
removes the test for the aforementioned class.

Differential Revision: https://phabricator.services.mozilla.com/D33659

--HG--
extra : moz-landing-system : lando
2019-06-04 16:04:00 +00:00
Jan Varga
4ccc2c149c Bug 1556730 - QM: Add IsShuttingDown checks to temporary storage initialization; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D33636
2019-06-04 15:44:11 +02:00
Bogdan Tara
af987b940c Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2019-06-04 19:10:28 +03:00
Neil Deakin
77fbcce9dc Bug 1443683, followup to fix drag feedback images, re-add lines that got lost in the last patch, r=nika
--HG--
extra : rebase_source : 322f8303af5af63d426caa473725d6f93c3b66b0
2019-06-04 08:51:23 -04:00
Ionut Goldan
88660df881 Bug 1556695 - Remove pinned Chromium revision on OSX r=perftest-reviewers,davehunt
Differential Revision: https://phabricator.services.mozilla.com/D33612

--HG--
extra : moz-landing-system : lando
2019-06-04 12:32:35 +00:00
Julian Descottes
eedc5b96dd Bug 1556434 - Use JSON reporter for DevTools jest tests on Try r=nchevobbe,Ola
This should be less fragile to catch regressions on try.

Differential Revision: https://phabricator.services.mozilla.com/D33515

--HG--
extra : moz-landing-system : lando
2019-06-04 12:29:43 +00:00
Valentin Gosu
29b6418ffd Bug 1533877 - Add test for that navigating popups to a null policy fails, even if the opener is closed r=annevk
Differential Revision: https://phabricator.services.mozilla.com/D32975

--HG--
extra : moz-landing-system : lando
2019-06-04 12:25:32 +00:00
Valentin Gosu
f9ee2f312f Bug 1533877 - Add provisional fetch tests for Cross-Origin r=annevk
Differential Revision: https://phabricator.services.mozilla.com/D32974

--HG--
extra : moz-landing-system : lando
2019-06-04 12:25:17 +00:00
Valentin Gosu
77919eb166 Bug 1533877 - Add tests that you can navigate a top level window to a different policy r=annevk
Differential Revision: https://phabricator.services.mozilla.com/D32973

--HG--
extra : moz-landing-system : lando
2019-06-04 12:25:04 +00:00