Commit Graph

666387 Commits

Author SHA1 Message Date
Masayuki Nakano
0bc1ae3058 Bug 1572685 - part 5: Move HTMLEditRules::mRestoreContentEditableCount to TopLevelEditSubActionData r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D42100

--HG--
extra : moz-landing-system : lando
2019-08-20 01:50:34 +00:00
Masayuki Nakano
7b09e44b5c Bug 1572685 - part 4: Move HTMLEditRules::mDidEmptyParentBlocksRemoved to TopLevelEditSubActionData r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D42099

--HG--
extra : moz-landing-system : lando
2019-08-20 01:50:21 +00:00
Masayuki Nakano
8f2394e050 Bug 1572685 - part 3: Move HTMLEditRules::mDidRangedDelete to TopLevelEditSubActionData r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D42098

--HG--
extra : moz-landing-system : lando
2019-08-20 01:50:04 +00:00
Masayuki Nakano
396a69a2bc Bug 1572685 - part 2: Move HTMLEditRules::mDidExplicitlySetInterLine to TopLevelEditSubActionData r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D42097

--HG--
extra : moz-landing-system : lando
2019-08-20 01:50:02 +00:00
Masayuki Nakano
992c1c0972 Bug 1572685 - part 1: Move HTMLEditRules::mDidDeleteSelection into AutoEditActionDataSetter r=m_kato
Most member variables of `HTMLEditRules` are temporary used while between
`BeforeEdit()` and `AfterEdit()` are called or `WillDoAction()` and
`DidDoAction()` are called.

The former means the data should be stored during top-level edit sub-action
is set.  Therefore, this patch creates a struct, `TopLevelEditSubActionData`
and make it a member of `AutoEditActionDataSetter`.  Then, makes
`EditorBase::TopLevelEditActionDataRef()` return reference of it.

And also this patch moves `HTMLEditRules::mDidDeleteSelection` into it.

Differential Revision: https://phabricator.services.mozilla.com/D42096

--HG--
extra : moz-landing-system : lando
2019-08-20 01:50:00 +00:00
Abdoulaye O. Ly
2071196eb3 Bug 1571080 - [Fission] Port form validation to JSWindowActor. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D40483

--HG--
rename : browser/modules/FormValidationHandler.jsm => browser/actors/FormValidationParent.jsm
extra : moz-landing-system : lando
2019-08-19 18:20:19 +00:00
dleblanccyr
7a290c37fd Bug 1573473 - Creates global function to make strings kebab-case. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41818

--HG--
extra : moz-landing-system : lando
2019-08-19 22:45:57 +00:00
Logan Smyth
3660d8e202 Bug 1572209 - Part 3: Upgrade MC Devtools build logic to use Babel 7.x for compilation. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42573

--HG--
rename : devtools/client/debugger/.babelrc => devtools/client/debugger/babel.config.js
extra : moz-landing-system : lando
2019-08-20 00:57:18 +00:00
Logan Smyth
0cff9d331e Bug 1572209 - Part 2: Upgrade debugger source-file processing to use Babel 7. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42572

--HG--
extra : moz-landing-system : lando
2019-08-20 00:56:33 +00:00
Logan Smyth
d2095a0055 Bug 1572209 - Part 1: Rebuild worker bundles to pick up some missing logic. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42571

--HG--
extra : moz-landing-system : lando
2019-08-20 00:55:49 +00:00
arthur.iakab
1d06495330 Backed out 3 changesets (bug 1560042) for causing browser-chrome failures on browser_temporary_permissions.js CLOSED TREEE
Backed out changeset 0fb712c93395 (bug 1560042)
Backed out changeset ada7b53d87d6 (bug 1560042)
Backed out changeset cdae11ea2306 (bug 1560042)
2019-08-20 04:04:18 +03:00
Logan Smyth
12ea9cfff0 Bug 1575096 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D42577

--HG--
extra : moz-landing-system : lando
2019-08-20 00:37:58 +00:00
Cosmin Sabou
ce32d49397 Backed out changeset 165672f8816b (bug 1529591) for geolocation related test failures. 2019-08-20 03:43:02 +03:00
Cosmin Sabou
1426dda56b Backed out changeset b0ad994d07d0 (bug 1574040) for debugger failures.
--HG--
rename : devtools/client/debugger/src/utils/threads.js => devtools/client/debugger/src/utils/workers.js
2019-08-20 03:41:14 +03:00
Bianca Danforth
780679ebf7 Bug 1542035 - Add read-only support for extension storage.local in addon debugger r=miker,rpl
* Add a new extensionStorage actor to enable inspection of data stored by an extension using the WebExtension storage.local API in the Storage panel client.
* The actor is only listed when the developer toolbox is targeting an extension process. For multi-process Firefox (e10s), this applies to only the toolbox accessed in about:debugging.
* The actor is gated behind a preference: devtools.storage.extensionStorage.enabled. This preference is set to false by default.
* The Storage panel displays storage item values as strings. If a storage item value is not JSON-stringifiable, it will be displayed in the table as "Object".
* It should be noted that extension storage.local’s storage backend is in the process of migrating from a JSON file to IndexedDB as of Firefox 66 for performance reasons. This actor only works for extensions that have migrated to the IndexedDB storage backend.
* In-line comments referencing Bugs 1542038 and 1542039 indicate places where the implementation may differ for local storage versus the other storage areas in the actor.

Differential Revision: https://phabricator.services.mozilla.com/D34415

--HG--
extra : moz-landing-system : lando
2019-08-19 20:16:50 +00:00
Jason Laster
f88768528b Bug 1574040 - Generalize the Debugger's worker redux management. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D42238

--HG--
rename : devtools/client/debugger/src/utils/workers.js => devtools/client/debugger/src/utils/threads.js
extra : moz-landing-system : lando
2019-08-20 00:21:32 +00:00
Bryce Seager van Dyk
6becef12e3 Bug 1571081 - Make MediaKeys correctly specify a NS_INTERFACE_MAP_ENTRY for nsISupports. r=mccr8
Bug 1522547 overlooked the need for specifying map entries for both nsISupports
and nsIDocumentActivity and only had the latter. This changeset adds the missing
nsISupports case.

Differential Revision: https://phabricator.services.mozilla.com/D42563

--HG--
extra : moz-landing-system : lando
2019-08-19 21:45:41 +00:00
Markus Stange
a18d35ca15 Bug 1491448 - Set the appropriate opaque region on the native layer. r=mattwoodrow
This can be verified by starting Firefox with the environment variables
CA_LAYER_SURFACE=0 CA_COLOR_OPAQUE=1
Transparent parts of the window will be red, and opaque parts will be green.

With this patch, the main browser window will be opaque except for the vibrant
areas, i.e. the tab bar and any open sidebars, which will be transparent.
Full screen video will be opaque.

Differential Revision: https://phabricator.services.mozilla.com/D40555

--HG--
extra : moz-landing-system : lando
2019-08-19 22:55:09 +00:00
Markus Stange
e65a6a7df9 Bug 1491448 - Maintain an internal opaque region in nsChildView that can be accessed from any thread. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D40554

--HG--
extra : moz-landing-system : lando
2019-08-19 22:55:47 +00:00
Markus Stange
32ec0f3341 Bug 1491448 - Add NativeLayer::SetOpaqueRegion and implement it for NativeLayerCA by assembling opaque and transparent sublayers to cover the regions. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D40553

--HG--
extra : moz-landing-system : lando
2019-08-19 22:54:26 +00:00
Carolina
c0250f29fb Bug 1572368 - Enables about:certificate by default.r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41525

--HG--
extra : moz-landing-system : lando
2019-08-19 23:27:12 +00:00
Glenn Watson
0239393a23 Bug 1574838 - Allow generating dirty regions from picture caching dependency lists. r=kvark
Previously, additional dependencies (such as opacity bindings and
transforms) were stored in a simple hash set, which meant they
could not be correlated with primitive bounding rects (and thus
could not be used to derive dirty rects of a tile).

Now, by scanning the primitive list which contains the bounding
rect, we can also find additional dependencies for that primitive.
This will be used in future to create exact dirty rects (for
debugging / regression testing) and allow us to generate a
dependency descriptor for a split or merged tile from an existing
descriptor.

This patch also fixes a case where opacity bindings could result
in unnecessary invalidations, by retaining the opacity bindings
state across display lists.

Differential Revision: https://phabricator.services.mozilla.com/D42473

--HG--
extra : moz-landing-system : lando
2019-08-19 21:16:53 +00:00
Sam Foster
78f014349d Bug 1560042 - Part 3: Update matching login and remove empty-username login when persisting changes from update doorhanger. r=MattN
* Add an extra param to promptToChangePassword to indicate whether a duped/superceded login should be deleted
* Add a raft of tests for promptToChangePassword as it applies to generated passwords and auto-saved logins

Differential Revision: https://phabricator.services.mozilla.com/D40115

--HG--
extra : moz-landing-system : lando
2019-08-19 23:24:09 +00:00
Sam Foster
02dcabde89 Bug 1560042 - Part 2: Add test coverage for empty-username/doorhanger case. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D41295

--HG--
extra : moz-landing-system : lando
2019-08-19 23:15:02 +00:00
Sam Foster
5f98ea8c88 Bug 1560042 - Part 1: Share verifyLogins test helper, new cleanupDoorhanger helper. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D41083

--HG--
extra : moz-landing-system : lando
2019-08-19 23:14:52 +00:00
longsonr
f5f9ccf882 Bug 1572904 - refactor cycle collection code after DOMSVGAngle r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D42453

--HG--
extra : moz-landing-system : lando
2019-08-19 19:10:03 +00:00
Mike Hommey
2e9307d967 Bug 1574761 - Avoid race condition creating old-configure. r=nalexander
This is not something that happens under normal circumstances, but it
can happen when you go fancy and run multiple configures in parallel
with different objdirs, and old-configure doesn't exist in the first
place ; then one configure may overwrite old-configure while another is
starting to execute it, resulting in the latter nor executing
old-configure completely.

Differential Revision: https://phabricator.services.mozilla.com/D42428

--HG--
extra : moz-landing-system : lando
2019-08-19 23:21:27 +00:00
Garvan Keeley
4f07263f06 Bug 1529591 - Check Mac system geo permission prior to showing request permission dialog. r=jdm
Differential Revision: https://phabricator.services.mozilla.com/D42540

--HG--
extra : moz-landing-system : lando
2019-08-19 20:42:17 +00:00
Jason Laster
e2e22e8792 Bug 1575007 - Update pause messages while replaying. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D42542

--HG--
extra : moz-landing-system : lando
2019-08-19 18:25:42 +00:00
Markus Stange
529ee470f1 Bug 1573343 - Destroy mFullWindowRenderTarget in a different place. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D42415

--HG--
extra : moz-landing-system : lando
2019-08-19 22:41:27 +00:00
Markus Stange
d417bf03ed Bug 1573343 - Use std::any_of to compute hasContentPaint. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D41681

--HG--
extra : moz-landing-system : lando
2019-08-19 22:41:07 +00:00
Markus Stange
66fc92f4e1 Bug 1573343 - Stop using LayoutDevice units in BasicCompositor. r=mattwoodrow
ScreenPixels would be a more appropriate unit. But inside BasicCompositor everything
is in the same coordinate space anyway so we're not getting much benefit from the
units. This patch eliminates a lot of .ToUnknown*() calls.

Differential Revision: https://phabricator.services.mozilla.com/D41680

--HG--
extra : moz-landing-system : lando
2019-08-19 22:40:55 +00:00
Markus Stange
cc120aa3b7 Bug 1573343 - Make the aInvalidRegion parameter of EndRemoteDrawing a const reference rather than a regular reference. r=mattwoodrow
There's no point in mutating it, and nobody does.

Differential Revision: https://phabricator.services.mozilla.com/D41679

--HG--
extra : moz-landing-system : lando
2019-08-19 22:40:39 +00:00
Markus Stange
9fd442a1aa Bug 1573343 - Fix two comments in BasicCompositor. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D41678

--HG--
extra : moz-landing-system : lando
2019-08-19 22:40:17 +00:00
Markus Stange
a5236f2abb Bug 1573343 - Remove an unnecessary null check and turn an emptiness check into an assertion. r=mattwoodrow
The null is unnecessary because mDrawTarget is already null-checked above:
If mTarget is non-null, then mDrawTarget = mTarget so mDrawTarget is non-null.
If mTarget is null, then we would enter a branch that had another null check
for mDrawTarget.

As for the assertion: When rendering to an external target (reftests),
LayerManagerComposite always sets the invalid region to the entire window, so it
should never be empty here.

Differential Revision: https://phabricator.services.mozilla.com/D41677

--HG--
extra : moz-landing-system : lando
2019-08-19 22:40:05 +00:00
Markus Stange
4491f22f3b Bug 1573343 - Add mDrawTargetBounds to clarify the position of mDrawTarget in window space. r=mattwoodrow
There was an interesting "ExpandToEnclose(IntPoint(0, 0))" call in
CreateRenderTargetForWindow that snuck in some surprising behavior that this
change makes a bit more visible.

Differential Revision: https://phabricator.services.mozilla.com/D41676

--HG--
extra : moz-landing-system : lando
2019-08-19 22:39:45 +00:00
Markus Stange
8b68a014ae Bug 1573343 - Pass a precise clear region to CreateRenderTargetForWindow. r=mattwoodrow
In the past, BeginFrame would clip mDrawTarget to the invalid region and then have
CreateRenderTargetForWindow clear a rectangle. So it was effectively clearing a
region, but only if BeginFrame's region clip happened to be set on the correct
DrawTarget. In the case where a back buffer was used, this was not the case:
The clip would be on mDrawTarget but the clear would happen on the back buffer
draw target. So we were clearing more than necessary.

Now we limit clearing to the invalid region even if a back buffer is used.

Differential Revision: https://phabricator.services.mozilla.com/D41675

--HG--
extra : moz-landing-system : lando
2019-08-19 22:39:26 +00:00
Markus Stange
a829cf1409 Bug 1573343 - Apply the translation in CreateRenderTargetForWindow instead of in BeginFrame. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D41674

--HG--
extra : moz-landing-system : lando
2019-08-19 22:39:12 +00:00
Markus Stange
19c25b1d89 Bug 1573343 - Move draw target clearing out of GetBackBufferDrawTarget. r=mattwoodrow
On Windows, where the DrawTarget is rewrapped in a Cairo/pixman DrawTarget,
this will now cause Cairo/pixman to be used for the clear.

Differential Revision: https://phabricator.services.mozilla.com/D41673

--HG--
extra : moz-landing-system : lando
2019-08-19 22:39:00 +00:00
Markus Stange
2dbe70d234 Bug 1573343 - Reset the transform in a better place. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D41672

--HG--
extra : moz-landing-system : lando
2019-08-19 22:38:35 +00:00
Markus Stange
f182a073c1 Bug 1573343 - Always create the back buffer sized to the widget's client size. r=mattwoodrow
This should be equivalent to what we had before but clearer.
Before this patch, we would reallocate the back buffer if
 - the back buffer was larger than the client size (meaning the window had shrunk) or
 - the invalid region didn't fit in the back buffer.
Whenever the window is resized, we have a frame where the invalid region covers
the entire window, and thus size would be equal clientSize in that frame.
So effectively, the back buffer size was always kept in sync with the client size.

Differential Revision: https://phabricator.services.mozilla.com/D41671

--HG--
extra : moz-landing-system : lando
2019-08-19 22:38:28 +00:00
Ehsan Akhgari
c771ae8334 Bug 1572240 - Part 6: Remove nsIPermissionManager.testPermissionOriginNoSuffix; r=baku
This is now dead code which will be kept alive by the vtable,
and introduces needless overhead inside the permission manager.

Differential Revision: https://phabricator.services.mozilla.com/D42207

--HG--
extra : moz-landing-system : lando
2019-08-19 14:38:47 +00:00
Ehsan Akhgari
05feeeb79b Bug 1572240 - Part 5: Use the principal-based version of the permission manager APIs in Gecko when checking the content blocking allow list; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D42206

--HG--
extra : moz-landing-system : lando
2019-08-19 14:38:45 +00:00
Ehsan Akhgari
68aa0ff3f4 Bug 1572240 - Part 4: Stop minting new URIs and principals in ContentBlockingAllowList._basePrincipalForAntiTrackingCommon; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D42205

--HG--
extra : moz-landing-system : lando
2019-08-19 14:38:38 +00:00
Ehsan Akhgari
575c480fc5 Bug 1572240 - Part 3: Introduce nsIHttpChannelInternal.contentBlockingAllowListPrincipal; r=michal
Differential Revision: https://phabricator.services.mozilla.com/D42204

--HG--
extra : moz-landing-system : lando
2019-08-19 19:38:50 +00:00
Ehsan Akhgari
e06a6e7ca6 Bug 1572240 - Part 2: Introduce nsIBrowser.contentBlockingAllowListPrincipal; r=baku
This patch also includes some spot fixes for the storage principal
support on the XUL browser element.

Differential Revision: https://phabricator.services.mozilla.com/D42203

--HG--
extra : moz-landing-system : lando
2019-08-19 14:38:34 +00:00
Ehsan Akhgari
7b2ff7275b Bug 1572240 - Part 1: Introduce Document.contentBlockingAllowListPrincipal; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D42202

--HG--
extra : moz-landing-system : lando
2019-08-19 14:38:32 +00:00
Geoff Lankow
b1ff557a85 Bug 1572819 - Enable toolkit/mozapps/extensions/test/xpcshell/test_system_update_enterprisepolicy.js for Thunderbird; r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D42083

--HG--
extra : moz-landing-system : lando
2019-08-19 16:44:10 +00:00
Toshihito Kikuchi
d5a7d77f4f Bug 1573051 - Use both SHParseDisplayName and CreateUri to validate a uri. r=aklotz
For launching with an external protocol handler on Windows, we validate a uri
before sending it to `ShellExecute`, by converting a string into `PIDL` using
`SHParseDisplayName` and extract a string back from PIDL using
`IShellFolder::GetDisplayNameOf`.  The problem was that if a fragment, a
string following a hash mark (#), is always dropped after this validation.
This is caused by the intended design of Windows.

A proposed fix is to use `CreateUri` for validation, which is used behind
`IShellFolder::GetDisplayNameOf`.  However, we also keep `SHParseDisplayName`
because there are cases where `CreateUri` succeeds while `SHParseDisplayName`
fails such as a non-existent `file:` uri and we want to keep the same
validation result for those cases.

Adding `CreateUri` broke MinGW build because of our toolkit issue.  We use
dynamic linking for MinGW build in the meantime.

This patch adds a new unittest to make sure the new validation logic
behaves the same as the old one except the fragment issue.

Differential Revision: https://phabricator.services.mozilla.com/D42041

--HG--
extra : moz-landing-system : lando
2019-08-19 22:10:32 +00:00
Rob Wood
f0e1ae6b1f Bug 1574943 - Temporarily move geckoview cold page-load tests to tier2 and run on central/try only r=perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D42524

--HG--
extra : moz-landing-system : lando
2019-08-19 16:01:33 +00:00