Commit Graph

709115 Commits

Author SHA1 Message Date
Julian Descottes
0eaaeb886a Bug 1621337 - Check if existingTargets is still defined when processing listWorkerChanged r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D74699
2020-05-22 06:46:31 +00:00
Butkovits Atila
8a87d1b582 Backed out changeset 09ccf334001b (bug 1592416) for causing bug 1640077 to fail. 2020-05-22 09:37:16 +03:00
wesj
2863da4ad0 * Bug 651482 - Allow decoding bitmaps with 52 and 56 byte info headers. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D75803
2020-05-22 03:35:15 +00:00
Glenn Watson
5be60824bc Bug 1637953 - Fix picture caching with redundant nested scroll roots r=Bert,jrmuizel
Some pages created nesting levels of scroll roots where the outer
scroll frames are redundant (the scrollable size is zero if the
content rect is the same as the frame rect).

In these cases, it is of no benefit to select these as a scroll
root for picture cache tiles.

Differential Revision: https://phabricator.services.mozilla.com/D75451
2020-05-21 23:11:14 +00:00
Bogdan Tara
404a84e0a6 Backed out changeset ee9c7714e513 (bug 1639606) for browser_download_open_with_internal_handler.js failures CLOSED TREE
DONTBUILD
2020-05-22 07:04:45 +03:00
Bogdan Tara
107fbafd77 Backed out 2 changesets (bug 1639563) for gfx related bustages CLOSED TREE
DONTBUILD
Backed out changeset b2c8de065886 (bug 1639563)
Backed out changeset 43abf0a9602a (bug 1639563)
2020-05-22 06:55:28 +03:00
Tom Prince
2bf24e6359 Bug 1639955: Use prefix for geckodriver toolchain artifacts; r=aki
We originally switched it to use just `public/` becuase iscript broke with the
extra path, but that broke out-of-tree consumers. Now that iscript is fixed,
switch it back.

Differential Revision: https://phabricator.services.mozilla.com/D76409
2020-05-22 03:38:32 +00:00
Tom Prince
9703222150 Bug 1639955: Include toolchain-artifact in the cached-task digest; r=aki
Differential Revision: https://phabricator.services.mozilla.com/D76410
2020-05-22 03:38:29 +00:00
Timothy Nikkel
aa2d21ce1a Bug 1637067. Add reftest, adjust fuzz expectations of existing test. r=jrmuizel
The existing test compares a 3d scene to a "hand drawn" version of the scene using 2d primitives and was never expected to match perfectly, but instead just provide something to compare against better than saying it's not a blank page.

The new test looks visually identical, the fuzz is around the edges of the text.

Depends on D75289

Differential Revision: https://phabricator.services.mozilla.com/D75636
2020-05-20 08:16:04 +00:00
Timothy Nikkel
7f4d96d4cd Bug 1637067. Make the StackingContextHelper constructor handle transforms that cannot be drawn 2d the same as ChooseScale. r=jrmuizel
In StackingContextHelper::StackingContextHelper we want to handle the case of "no passed in transform" differently from "passed in transform but it cannot be drawn 2d". This is a little tricky because ChooseScale always has a transform passed in: in the non-wr case it is a scaling matrix by the parent scale. We could call ChooseScale if canDraw2D is false and get the same value for mScale but we also need to keep mInheritedTransform in sync.

This issue arose before: https://bugzilla.mozilla.org/show_bug.cgi?id=1449958#c3

And we want to be careful not to regress that bug, that bug was concerning content without a transform, so we should be good.

The testcase has a parent element with rotateY(-80deg) and a child element with rotateY(80deg), the combined transform is flat with no scaling even though each transform individually would have a very small x scale. There's no way to choose a good scale by looking at each transform individually, and since we only currently store transforms as 2d matrices we can't look at the full combined transform in order to choose a scale. Thus we must use a unit scale, like ChooseScale does.

Differential Revision: https://phabricator.services.mozilla.com/D75289
2020-05-20 08:16:04 +00:00
Timothy Nikkel
ad331835d3 Bug 1637067. Use the same kind of preserve3d in the StackingContextHelper constructor as in ChooseScale. r=jrmuizel
transform_style is set to frame->Extend3DContext, but ChooseScale uses frame->Combines3DTransformWithAncestors()

Differential Revision: https://phabricator.services.mozilla.com/D75288
2020-05-20 08:16:03 +00:00
Chris AtLee
4c1292f8f8 Bug 1637381: Fix reference to old tarball for win64-clang-tidy r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D76420
2020-05-22 01:12:56 +00:00
Jared Wein
c9919e67e4 Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-22 02:09:45 +00:00
Aaron Klotz
9c0c057f3c Bug 1639391: Do not call nsWindow::GetAttention for top-level windows being shown during session restore; r=mhowell
When we call nsWindow::Show but Firefox is not foreground, we show the window
and also flash it on the taskbar to get the user's attention.

This is really annoying when restoring a session with `N` windows, as the
user's taskbar ends up with all `N` of them stuck in a flashed state until the
user goes through and manually activates every single window.

There are several ways I thought of to address this, but I think the
simplest one is just to track whether or not we're in the middle of restoring a
session and skip flashing when we are doing so.

Differential Revision: https://phabricator.services.mozilla.com/D76406
2020-05-22 01:49:11 +00:00
Justin Wood
d582323fcb Bug 1640057 - Make condition profile fetch use the correct directory (en-US from shippable). r=aki
Fixes bustage from 1623355.

Differential Revision: https://phabricator.services.mozilla.com/D76424
2020-05-22 01:47:28 +00:00
Bogdan Tara
a55b39863b Backed out changeset 7cdd5e64521e (bug 1456626) for build crash on nsJARChannel::OpenLocalFile CLOSED TREE 2020-05-22 05:06:32 +03:00
Mike Hommey
dcc0980530 Bug 1636574 - Fixup for configure lint happiness.
Differential Revision: https://phabricator.services.mozilla.com/D76423
2020-05-22 01:24:09 +00:00
Emilio Cobos Álvarez
78ecaad89c Bug 1638574 - Allow to use widl when cross-compiling clang-cl builds. r=glandium
This avoids having to have clang-cl.exe and ml64.exe in the path.

This requires a WIDL patch[1] and one other tweak, but it's working
other than that.

While at it, allow to pass extra flags to midl / widl. This is useful to
test with a local widl for example, to pass the right include paths.

[1]: https://www.winehq.org/pipermail/wine-devel/2020-May/166368.html

Differential Revision: https://phabricator.services.mozilla.com/D75680
2020-05-22 01:16:59 +00:00
Junior Hsu
b966699767 Bug 1638172 - avoid name hiding for handling multipart channel in HttpChannelChild, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D75445
2020-05-21 23:32:31 +00:00
Mike Hommey
f2056ea3ec Bug 1636574 - Do not actually inject early options from mozconfig. r=rstewart
The configure sandbox has a list of arguments to handle, and removes
each of them when it resolves the corresponding options through e.g. a
`@depends`. When the configure sandbox is finished, what's supposed to
be left is unknown options.

The mozconfig injections adds elements to that list of arguments to
handle. The problem is that by the time the mozconfig injection happens,
some early options have already been handled by the sandbox and won't be
re-handled. Which means by the end of configure, the arguments are still
there, and the sandbox throws an error because it thinks they are for
unknown options.

Things were actually working before bug 1264527, essentially because we
had an explicit list of mozconfig variables that would be injected, and
that didn't include those early options.

So what we now do is to not actually inject those early options from
mozconfig.

Differential Revision: https://phabricator.services.mozilla.com/D76276
2020-05-21 15:28:13 +00:00
Mike Hommey
da55054404 Bug 1639569 - Define PYTHON3 in old-configure. r=firefox-build-system-reviewers,rstewart
Differential Revision: https://phabricator.services.mozilla.com/D76260
2020-05-21 15:28:25 +00:00
Emma Malysz
149939bbfc Bug 1456626, use dedicated background thread for nsJARChannel::asyncOpen to avoid blocking r=valentin,michal,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D73065
2020-05-22 00:57:54 +00:00
Lina Cambridge
1e4bad34ca Bug 1638927 - Replace lazy_static with once_cell in XULStore. r=froydnj
TSan returns false positives for `lazy_static`. While we could
blocklist it, `once_cell` has equivalent functionality, but with a more
modern API, so let's use it instead.

Depends on D75864

Differential Revision: https://phabricator.services.mozilla.com/D76342
2020-05-22 00:40:25 +00:00
Lina Cambridge
f2aad2aa4c Bug 1638927 - Replace dedicated XULStore persistence thread with background tasks. r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D75864
2020-05-22 00:56:28 +00:00
J.C. Jones
18fcf86435 Bug 1636656 - land NSS 527a1792be4e UPGRADE_NSS_RELEASE, r=kjacobs
2020-05-20  Benjamin Beurdouche  <bbeurdouche@mozilla.com>

	* lib/freebl/freebl_base.gypi:
	Bug 1638289 - Fix multiple definitions of SHA2 on ppc64le. r=kjacobs

	[527a1792be4e] [tip]

Differential Revision: https://phabricator.services.mozilla.com/D76415
2020-05-22 00:48:57 +00:00
Barret Rennie
f5258e1188 Bug 1603185 - Collect per tab unique site origin telemetry r=Dexter,Gijs,nika
Top-level content WindowGlobalParents now keep track of the site origins of the
documents in their document tree. When the WindowGlobalParent is torn down, the
maximum of the number of unique site origins is submitted for telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D71493
2020-05-22 00:34:17 +00:00
Mathieu Leplatre
b25d0ae2e5 Bug 1639224 - Verify signature if local timestamp is in the future r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76249
2020-05-22 00:27:06 +00:00
Cosmin Sabou
3a5c48b16c Bug 1639815 - Fix for win asan build bustages. r=glandium
CLOSED TREE
2020-05-22 03:23:16 +03:00
Cosmin Sabou
2fb40db9fc Backed out changeset 578ecaa1f863 (bug 1638313) for devtools failures on browser_net_filter-01.js. 2020-05-22 03:20:47 +03:00
Mathieu Leplatre
8965849d47 Bug 1639684 - Report server_error on HTTP 5XX when polling for changes r=rdalal
Differential Revision: https://phabricator.services.mozilla.com/D76242
2020-05-21 23:59:58 +00:00
Mike Hommey
6ba1065508 Bug 1639815 - Move --enable-strip and --enable-install-strip to python configure. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D76291
2020-05-21 23:51:58 +00:00
Mike Hommey
711ffb4939 Bug 1639815 - Move --disable-icf to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76290
2020-05-21 22:38:47 +00:00
Mike Hommey
03b3bd5a35 Bug 1639815 - Move --enable-dtrace to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76289
2020-05-21 22:38:47 +00:00
Mike Hommey
114f6b0f27 Bug 1639815 - Move --enable-cpp-rtti to python configure. r=froydnj
This only moves the option, but still leaves it to the old-configure code to
add the appropriate flags to CXXFLAGS.

Differential Revision: https://phabricator.services.mozilla.com/D76288
2020-05-21 22:38:46 +00:00
Mike Hommey
79feb07ead Bug 1639815 - Move --enable-readline to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76287
2020-05-21 22:38:46 +00:00
Mike Hommey
0e16889c8a Bug 1639815 - Move --with-sixgill to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76286
2020-05-21 22:38:46 +00:00
Mike Hommey
af5718ca89 Bug 1639815 - Move --with-qemu-exe and --with-cross-lib to python configure. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D76285
2020-05-21 22:38:46 +00:00
Lee Salzman
91d6189dd9 Bug 1639563 - sanitize WR fonts. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D76360
2020-05-21 23:30:02 +00:00
Lee Salzman
0cdb66e17e Bug 1639563 - factor out gfxOTSContext into reusable header file. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D76358
2020-05-21 21:12:37 +00:00
Bogdan Tara
6bd3bb7800 Backed out changeset d9a39c63e40e (bug 1624909) for Pivot.h related bustages CLOSED TREE 2020-05-22 02:58:12 +03:00
Ted Campbell
449d84be72 Bug 1639898 - Use volatile in CheckCanonicalNaN. r=iain
This ensures we compute the NaN at runtime instead of compile time since this
is this test is aimed at JIT compatibility. In practice, these should be the
same, plus/minus the sign bit.

Differential Revision: https://phabricator.services.mozilla.com/D76344
2020-05-21 23:49:50 +00:00
Ted Campbell
e47629d3e9 Bug 1639898 - Cleanup NaN code for JS::Value. r=iain
- Add more comments
- Add ValueToDouble helper methods
- Assert GenericNaN is compatible
- Fixup the WrappedPtrOperations for JS::Value

Differential Revision: https://phabricator.services.mozilla.com/D76339
2020-05-21 22:23:26 +00:00
Morgan Reschenberg
7a58efe041 Bug 1624909: Create and maintain radio siblings array for position information. r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D72751
2020-05-21 23:36:13 +00:00
Bogdan Tara
d389f72e6d Backed out changeset 440612f47d83 (bug 1638172) for HttpChannelParent.cpp related bustages CLOSED TREE 2020-05-22 02:21:35 +03:00
Emilio Cobos Álvarez
e485c5c372 Bug 1630919 - Do not throttle an effect due to opacity if the frame is animating opacity itself. r=hiro
When transitioning visibility and opacity at the same time, we create
two effects, one animating opacity, and one visibility.

We're incorrectly throttling the visibility animation due to opacity,
because _that_ effect is not animating opacity, but the other one is and
thus doesn't get throttled.

Use HasAnimationOfOpacity() to check for this case. This is slightly
sketchy, because the first time we get through there we may not even
have started the opacity animation yet. However it kinda works, because
the fact that there's a (non-throttled, because of the
aEffect.HasOpacityChange()) opacity animation means that we'll tick both
of them, and unthrottle them next frame.

This seems better than the alternative which is never throttling
animations in opacity: 0 roots.

Differential Revision: https://phabricator.services.mozilla.com/D76405
2020-05-21 23:12:26 +00:00
Junior Hsu
6c3aa3878c Bug 1638172 - avoid name hiding for handling multipart channel in HttpChannelChild, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D75445
2020-05-21 23:02:38 +00:00
Punam Dahiya
2ae36886d1 Bug 1638101 - Multistage about:welcome Get Started and Import Settings UI r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D75880
2020-05-21 22:54:59 +00:00
Masayuki Nakano
7a8b3653f6 Bug 1639824 - Make OKInputPaneManager warn only when TryShow() and TryHide() fail, we're active and we get unexpected result r=m_kato
I see a lot of "IInputPane2::TryHide is failure" warnings while WPT for editing
API runs.

According to MSDN, they return true only when the application is foreground and
the input panel hasn't been the requested state yet.  Therefore, it should
check whether the foreground window is our process or not, and whether the
input pane state is expected or not before warning.

* https://docs.microsoft.com/en-us/uwp/api/windows.ui.viewmanagement.inputpane.tryshow?view=winrt-18362
* https://docs.microsoft.com/en-us/uwp/api/windows.ui.viewmanagement.inputpane.tryhide?view=winrt-18362

Differential Revision: https://phabricator.services.mozilla.com/D76295
2020-05-21 15:40:41 +00:00
Junior Hsu
6ff998ce0c Bug 1638313 - Let devtool show CORS rejected requests correctly, r=necko-reviewers,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D76255
2020-05-21 22:41:44 +00:00
Lee Salzman
c452d01a0d Bug 1639385 - add memory reporter for NativeFontResource data. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D76259
2020-05-21 20:32:10 +00:00