This test was failing because we need to set an additional
pref to make our Windows 10 test infra support touch events,
and because some elements it was testing got renamed.
MozReview-Commit-ID: 4h2YxFzRrGp
--HG--
extra : rebase_source : 588eab64df3235fe66641c5ba398ac95c3abfe3b
nsINode::GetSelectionRootContent() uses nsIEditor since nsContentUtils::GetHTMLEditor() returned nsIEditor. Therefore, it needed to use GetEditorRootContent() to retrieve the editor root element as nsIContent*.
Now, it can use HTMLEditor and HTMLEditor::GetRoot() returns the editor root element as nsIContent* directly. So, it should use HTMLEditor instead.
MozReview-Commit-ID: I937a5TuxVD
--HG--
extra : rebase_source : 5c00be8b590ca3d4d4290a69eef1e2e177ee069d
nsGenericHTMLElement::GetAssociatedEditor() retrieves TextEditor if the element is <input type="text"> or something, or <textarea>, or if it's editable, HTMLEditor associated to the document. So, this method can return TextEditor (HTMLEditor is a subclass of TextEditor).
MozReview-Commit-ID: BvpFPaPLY70
--HG--
extra : rebase_source : 69edbe17aeb1ac72a8f8d247e5baca998569250e
nsContentUtils::GetHTMLEditor() currently returns nsIEditor* since editor of doc shell may be any type of editors such as TextEditor or editor object which is implemented by JS. However, nsIEditor is now a builtin class. So, it can return HTMLEditor.
MozReview-Commit-ID: 3YoFOplZa7W
--HG--
extra : rebase_source : 46f42d23babd64bf0a5003e66e8fe3b9e0bd7166
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1387941
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: 421a553799b6e71c2bf7a0f5bba4082060445533
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1ade80b1376d7e773397564d48b88a99549628fd
nsHTMLDocument retrieves its associated editor from nsIEditingSession and nsIDocShell. So, both of them have methods returning HTMLEditor*. Therefore, nsHTMLDocument should treat all of them as HTMLEditor.
MozReview-Commit-ID: 5zPH708Vev3
--HG--
extra : rebase_source : 09e87fab64bc3e8a00300bc3109e45a1b8c8b797
nsIHTMLDocument::TearingDownEditor() takes nsIEditor as an argument. However, it's not used in it. So, we can remove it.
MozReview-Commit-ID: KUmIsnVGB6H
--HG--
extra : rebase_source : ddd344b9df18e0b33d54d2f99e6335449f55df81
nsEditingSession should treat editor as HTMLEditor in its internal handling.
MozReview-Commit-ID: 51SfY4oeq3p
--HG--
extra : rebase_source : 90535267e62de17755fff9f21b6a0f74244d849a
Some users of HTMLEditor retrieve pointer to editors with nsIEditingSession::GetEditorForWindow() but it returns nsIEditor. So, there should be a method which returns HTMLEditor*.
MozReview-Commit-ID: Bzc1LIlTSDF
--HG--
extra : rebase_source : f6fb3e5852809487883e3e6fedda9580206b2cb5
This commit:
- Makes the window controls have exactly the same height as tabs when the
menubar is hidden, and have the same height as the menubar when it is shown.
This requires us to remove the menubar height before flushing layout in
case it is shown, since we need its original height for the calculation.
- Removes the top margin between the menu bar and the window border
that was present on Windows 10 and makes it apply on Windows 7 only.
The border was causing miscalculations of the window control height,
which could have been handled in browser-tabsintitlebar.js, but since
it's not part of the Photon spec we decide to remove it entirely.
- Makes window control height calculations ignore vertical tabs toolbar
margins. The only margin it has right now is -1px and the calculation
code doesn't work right with negative margins.
MozReview-Commit-ID: HJXxUUJFX8x
--HG--
extra : rebase_source : fdb5db7e5b410cb45cef054d5cbec41048211f75
This patch changes UpdateAnimationOnlyStyles to only flush animation styles if
there are throttled animation styles that could affect hit-testing and renames
the function to UpdateAnimationStylesForHitTesting at the same time.
For GeckoRestyleManager, the original UpdateAnimationOnlyStyles which flushes
animation styles if there are any pending animation styles, is renamed to
UpdateAnimationStyles for consistency.
MozReview-Commit-ID: 89UleXjI2OE
--HG--
extra : rebase_source : cac59f9d48b096aee718f89ffe203d38d39027fd
From https://bugzilla.mozilla.org/show_bug.cgi?id=1389937. Reviewed by Xidorn there. Waiting until try server is back up and running before landing this, though.
Source-Repo: https://github.com/servo/servo
Source-Revision: b0422b89108301495520de88f2765c78f429692d
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5c80f87c9194ffee54a7a1d5488b5b0ccd0bea56
We convert a perspective function into a ComputedMatrix, but we apply the
perspective length to a wrong matrix item. We should put it into m34,
instead of m43. m43 is for translate parameter Z.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1389023](https://bugzilla.mozilla.org/show_bug.cgi?id=1389023).
- [X] These changes do not require tests because we have many transform tests in Gecko already. However, those tests may not be enough, so we should add more in Gecko later.
Source-Repo: https://github.com/servo/servo
Source-Revision: cd1251082511a44ef9ad020b7196336bca812a49
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : fd5b13ac29076c2aed7c0c7778932ed7cfbd8b8d
Since we made -moz-appearance animatable, append to the moz prefixed properties
test.
MozReview-Commit-ID: 9tdouU1umEB
--HG--
extra : rebase_source : 79e9639360461452249ce54ff538294f25b6cd4f
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
<!-- Either: -->
- [X] There are tests for these changes. The test code is patch part 2 in https://bugzilla.mozilla.org/show_bug.cgi?id=1382138
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: f93c6dfbd54f1ec40a0feba12932ef5aac379624
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 98467479ffc5ff76f72403be82321be487380d65
Now, clip-path can animate as basic-shape in CSS Transitions.
However, the serialization of computed value both Gecko and Servo is
difference. Also, the serialization of Servo is correct.
Therefor, add the expected value for Servo.
MozReview-Commit-ID: 5hr2PRlLnPd
--HG--
extra : rebase_source : 417faa4d8819cd8d1fd2c7c79df1f54efdc2086b
When Gecko started to support Cocoa widget, we needed to use NSInputManager.
That allowed applications to access only focused IME context. Therefore, commit
composition request handler for Cocoa is designed as handling asynchronosly if
it's requested when the window is not active or is being inactivated.
Additionally, the asynchronous handling isn't perfect. We hit some MOZ_ASSERT()
now in some places. E.g., in SelectedRange(), it doesn't assume that it's
called during deactive.
On the other hand, NSInputManager was alreay obsolete and we already stopped using it
(bug 810225). Instead, we're using NSTextInputContext and it allows applications
to access IME anytime. Therefore, if we make IMEInputHandler handles commit/cancel
composition requests synchronsly, that behaves same as the other platforms. So, we
can get rid of macOS specific issue completely.
MozReview-Commit-ID: X7aWmGq95x
--HG--
extra : rebase_source : a472a03e3ef6f424fe73c2d438b8326bed80278d
When a remote process has focus and it loses focus,
IMEStateManager::OnChangeFocusInternal() sends NOTIFY_IME_OF_BLUR via
IMEStateManager::NotifyIMEOfBlurForChildProcess(). Therefore,
sFocusedIMETabParent and sFocusedIMEWidget are set to nullptr here. So, if a
window becomes active, REQUEST_IME_TO_COMMIT_COMPOSITION in
IMEStateManager::OnChangeFocusInternal() won't work because
IMEStateManager::NotifyIME() ignores the request because of coming from wrong
process.
Therefore, IMEStateManager::OnChangeFocusInternal() needs to send
REQUEST_TO_COMMIT_COMPOSITION with proper process information which is only
stored by TextComposition instance.
MozReview-Commit-ID: KNEvOoQtK1E
--HG--
extra : rebase_source : 2d0c9297a6ffd3e7883130c80deec0479212148e
This patch changes the event to listen on the search textbox from "command" to
"input", which means the code will run with every keystroke, instead of once
a few keystrokes after a timeout. It will make the search very responsive.
However, with that change, each keystroke will be blocked by the search function,
which go through the entire DOM of the page. This patch fixes that by making the
search function async. The search will now check the execution time with
Performance API, and give way when it blocks the page for more than 1/60 sec.
Further care was taken to make sure page won't flash unchecked content while
the loop go through the entire DOM. The elements to be checked can't be hidden
because of the JS bindings, so CSS rules are set to ensure they are kept
visually hidden. Unfortunately, CSS cannot change XUL layout so they still
occupies page space.
Additional check was made to make sure the search function skips hidden elements,
if the previous query is a substring of the search query. This is done so that
search function does not unhide and hide these elements, and causes the search
result to flash as the user types.
MozReview-Commit-ID: BwBoJmTperw
--HG--
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_1.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_5.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_2.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_6.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_3.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_7.js
rename : browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_4.js => browser/components/preferences/in-content-new/tests/browser_search_subdialogs_within_preferences_8.js
extra : rebase_source : 2f1b6cd9f50d79c24dcddc22c61c50d347ddf3f0
