Commit Graph

713840 Commits

Author SHA1 Message Date
Hubert Boma Manilla
12ac6882be Bug 1644275 - Add a new Channel map r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D79137
2020-06-18 14:44:12 +00:00
Hubert Boma Manilla
1718c07f68 Bug 1622925 - Wait for navigate to make sure the page title is available r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D79836
2020-06-18 14:44:36 +00:00
Dan Minor
8b02726f4f Bug 1645675 - Fix DTMF call return values in AudioConduit; r=ng
Differential Revision: https://phabricator.services.mozilla.com/D79723
2020-06-18 02:35:50 +00:00
Emilio Cobos Álvarez
16ca2c98df Bug 1642591 - Fix image/test/unit/test_private_channel.js. r=tnikkel
This test fails already on central if you change this line:

  https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/image/test/unit/test_private_channel.js#93

by:

  Ci.nsIReferrerInfo.EMPTY

Because the previous part of the test populates the image cache. The
test wants to check that the channel for the image load is properly
flagged as private and thus that the http cache is partitioned
appropriately, thus clearing the image caches seems sane.

While at it, also fix it so that we send a valid image instead of base64
text, though that change is not technically needed so feel free to ask
me to remove it.

Differential Revision: https://phabricator.services.mozilla.com/D79848
2020-06-18 14:07:03 +00:00
Emilio Cobos Álvarez
3800ba91c7 Bug 1642591 - Remove two subtests that are no longer expected to pass. r=mayhemer
I feel a bit torn about these because they test real (if obscure) issues
with the speculative loader... But it's not clear to me it's worth it to
add plumbing to only check referrer policy if the load is speculative,
and our behavior matches Chrome in the following test-case[1][2].

[1]: https://crisal.io/tmp/meta_referrer.html
[2]: https://crisal.io/tmp/referrer.php?source

Differential Revision: https://phabricator.services.mozilla.com/D79861
2020-06-18 14:09:29 +00:00
Emilio Cobos Álvarez
6bb08bd490 Bug 1646056 - Use const references as keys instead of raw pointers for PreloadHashKey. r=mayhemer
Feels a bit more natural for the callers this way. This should have no
behavior change.

Differential Revision: https://phabricator.services.mozilla.com/D79831
2020-06-18 14:06:34 +00:00
Emilio Cobos Álvarez
939c7c466b Bug 1642591 - Don't make referrer policy a cache miss for sub-resource {pre,}loads. r=mayhemer,tnikkel
For preload we're already effectively not using it, I think, due to
bug 1642325.

For images, this matches the spec, see earlier comments in this bug and
https://bugzilla.mozilla.org/show_bug.cgi?id=1174921#c17.  I think it
makes sense for other sub-resources to align as well.

Differential Revision: https://phabricator.services.mozilla.com/D79812
2020-06-18 14:06:20 +00:00
Cosmin Sabou
17e54eff48 Backed out changeset 7e39d1eed06b (bug 1639284) for xpcshell failures on test_blocklist_severities.js. CLOSED TREE 2020-06-18 17:29:29 +03:00
Markus Stange
bb1165b99c Bug 1646216 - Don't call CommitToScreen() on the main thread while another thread is compositing. r=jrmuizel
The compositor / renderer thread puts stuff on the screen by mutating
NativeLayers and then calling NativeLayerRoot::CommitToScreen().
The main thread also calls NativeLayerRoot::CommitToScreen() sometimes.

If we hit the main thread code in the middle of a composition, the NativeLayer
state is inconsistent, so we shouldn't commit it to the screen until the
composition is finished.

Differential Revision: https://phabricator.services.mozilla.com/D79924
2020-06-17 18:30:58 +00:00
Markus Stange
c5cf53e63b Bug 1642603 - Make TransformAndClipBounds stop discarding the corner positions of empty rectangles. r=kip
Differential Revision: https://phabricator.services.mozilla.com/D79582
2020-06-17 18:54:46 +00:00
Cosmin Sabou
6822e213d4 Backed out changeset f26dbc8340cf (bug 1646348) for assertion failures on core/platform.cpp. CLOSED TREE 2020-06-18 17:18:25 +03:00
Emilio Cobos Álvarez
090e3d2409 Bug 1646224 - Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame
This avoids arbitrary precision loss when computing REM units and so on,
which is particularly important if we ever change the base of our app
units (but useful regardless).

Differential Revision: https://phabricator.services.mozilla.com/D79928
2020-06-18 13:55:03 +00:00
Simon Giesecke
9a81912985 Bug 1644163 - Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Replace. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78695
2020-06-18 08:03:02 +00:00
Simon Giesecke
c2985d448f Bug 1644163 - Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Assign. r=froydnj
This also extracts new private member functions AssignOwned and AssignNonDependent.

Furthermore, it fixes an inconsistency for the dependent case: Formerly,
this caused the substring tuple to be materialized into a linear string
infallibly, although the function was a fallible one. It only assigned the
resulting string fallibly, but this would never have failed, since the
allocation already happened before.

Differential Revision: https://phabricator.services.mozilla.com/D78694
2020-06-18 08:03:09 +00:00
Simon Giesecke
1a9edbd8d5 Bug 1644163 - Avoid traversing a nsTSubstring tuple twice to determine its length and dependency on a buffer in Append. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78693
2020-06-18 08:02:52 +00:00
Honza Bambas
be42b32114 Bug 1631327 - Do not fail IPC when predictor service fails to be obtained because of a rare possibiliy of reentrancy in XPCOM component manager, r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D80044
2020-06-17 18:23:18 +00:00
Lars T Hansen
e5f6671ee6 Bug 1645638 - split very large test cases. r=rhunt
The combination of the following factors causes the test cases to OOM
on 32-bit systems due to a lack of object code space:

* --ion-eager
* very many distinct call sites with one IC cache per call site
* one distinct callee per call site that holds onto a distinct wasm
  module
* each wasm module claiming at least one wasm page's worth of code
* IC caches that hold onto the individual functions that are called

Just split the test cases to work around this rare problem.

Differential Revision: https://phabricator.services.mozilla.com/D79988
2020-06-18 13:27:04 +00:00
Nick Alexander
2a0de542af Bug 1635273 - Make FT_LCD_FILTER_H a relative rather than absolute path. r=froydnj
This helps get sccache hits across source directories.

The previous presentation guaranteed the version of `ftlcdfil.h` in
the tree, while this unorthodox presentation only ensures that the
`freetype2` directory has parent `modules`.  This is at least unlikely
to occur in random `/usr/include` directories.

If this turns out to be an issue it would be possible to copy
`ftlcdfil.h` into the object directory, potentially with a unique
name, and then reference that (with a relative path).

Differential Revision: https://phabricator.services.mozilla.com/D73759
2020-06-18 13:40:40 +00:00
Mathieu Leplatre
986bc3704b Bug 1639284 - Store records, timestamp and metadata in one IndexedDB transaction r=Gijs,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D78246
2020-06-18 09:47:43 +00:00
Paul Adenot
e6c3203e23 Bug 1646348 - Fix audio thread registration in GraphDriver.cpp. r=achronop
Differential Revision: https://phabricator.services.mozilla.com/D80000
2020-06-18 13:23:09 +00:00
Jason Orendorff
db6abc151f Bug 1646009 - Enable AggregateError in all branches, along with Promise.any. r=jwalden.
Differential Revision: https://phabricator.services.mozilla.com/D80115
2020-06-18 11:54:41 +00:00
Butkovits Atila
44b8ac984c Backed out changeset e33817395845 (bug 1529610) as requested by dev. CLOSED TREE 2020-06-18 15:38:56 +03:00
Butkovits Atila
34722d7f3a Backed out 2 changesets (bug 1645937) for gv-junit failures on VerticalClippingTest. CLOSED TREE
Backed out changeset e0f3090a46a4 (bug 1645937)
Backed out changeset c1021d851157 (bug 1645937)
2020-06-18 14:59:18 +03:00
pbz
c90e24b52a Bug 1645632 - Include webrtc window streams when handling webrtcLegacyIndicator click. r=johannh
Bug 1636207 updated webrtcUI.getActiveStreams to support getting window streams. This updates
the call sites in the legacy webrtc indicator, so we get all streams. In the affected call sites
the streams are used to find and focus the parent window and show the permissions doorhanger.

Differential Revision: https://phabricator.services.mozilla.com/D80030
2020-06-18 11:42:05 +00:00
Alexandre Poirot
e5f625b56e Bug 1646143 - Use instantiable classes for resource watchers. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D79882
2020-06-18 10:34:37 +00:00
Alexandre Poirot
31a7c42e44 Bug 1644772 - Avoid an exception when we fail detaching a SW on destroy. r=jdescottes
No idea if that is the real reason why the Browser Toolbox failed opening.
It isn't clear how WorkerTarget detach is implied in toolbox opening?

Differential Revision: https://phabricator.services.mozilla.com/D79159
2020-06-18 10:12:04 +00:00
Kagami Sascha Rosylight
02e4819dbc Bug 1645003 - Return pointer from GetPrimaryOrCaretFrameForNodeOffset and its deps r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D80063
2020-06-18 10:26:47 +00:00
Eden Chuang
85349a441f Bug 1642149 - P1 Fix the web-platform-test html/cross-origin-embedder-policy/require-corp.https.html r=necko-reviewers,valentin
Current HttpBaseChannel::ProcessCrossOriginResourcePolicyHeader does not implement the [[ https://wicg.github.io/cross-origin-embedder-policy/#corp-check | corp-check ]] 3.2.1.2.

Differential Revision: https://phabricator.services.mozilla.com/D77594
2020-06-18 10:01:15 +00:00
Eden Chuang
8c86a3e215 Bug 1642149 - P2 ImportScript() in workers must respect the coressponding COEP header r=dom-workers-and-storage-reviewers,perry
When loading a sub-script in workers, the corresponding COEP must be set on the channel's nsILoadInfo, such that its CORP header can be checked as expected.

Differential Revision: https://phabricator.services.mozilla.com/D77720
2020-06-18 10:02:51 +00:00
Eden Chuang
400b4664ad Bug 1642531 - Instead of using RequestMode, using ResponseType for CORP checking in cache APIs r=dom-workers-and-storage-reviewers,perry
According to https://github.com/w3c/ServiceWorker/pull/1516, Replacing RequestMode by ResponseType for CORP checking in cache.match() and cache.matchAll().

Differential Revision: https://phabricator.services.mozilla.com/D77747
2020-06-18 10:02:53 +00:00
Eden Chuang
eaf8e5f228 Bug 1622375 - remove expected results for wpt service-worker/registration-mime-types.https.html r=dom-workers-and-storage-reviewers,sg
Fission should be supported for this test.
Rollback the updated for service-worker/registration-mime-types.https.html in https://hg.mozilla.org/mozilla-central/rev/7dba29552629#l128.1

Differential Revision: https://phabricator.services.mozilla.com/D79601
2020-06-18 10:48:33 +00:00
Kartikaya Gupta
44c15927f5 Bug 1645937 - Add reftest. r=tnikkel
Depends on D80054

Differential Revision: https://phabricator.services.mozilla.com/D80055
2020-06-18 08:56:53 +00:00
Kartikaya Gupta
2def21e66e Bug 1645937 - With containerless scrolling we always want this clip on the layer. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D80054
2020-06-18 10:51:03 +00:00
Cosmin Sabou
7b22576061 Backed out changeset b2ce549cea27 (bug 1642708) for causing build bustages on PermissionDelegateHandler.cpp. CLOSED TREE 2020-06-18 13:38:29 +03:00
Ted Campbell
96a9254c16 Bug 1646575 - Update BinAST web-platform test expectations. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D80130
2020-06-18 05:32:57 +00:00
Ted Campbell
821280cceb Bug 1642708 - Add missing StaticPrefs_dom.h include in DocumentLoadListener r=necko-reviewers,nika,valentin
Differential Revision: https://phabricator.services.mozilla.com/D80074
2020-06-18 08:13:14 +00:00
Cosmin Sabou
3b4176468a Backed out 3 changesets (bug 1644163) for mochitest asan failures. CLOSED TREE
Backed out changeset 954c49edcc76 (bug 1644163)
Backed out changeset 8d78185301f1 (bug 1644163)
Backed out changeset 338bd5525594 (bug 1644163)
2020-06-18 13:20:43 +03:00
Mark Banner
766c586f50 Bug 1646650 - App-provided search engines are being saved with full data in the search engine cache. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D80155
2020-06-18 09:58:20 +00:00
Mark Banner
b5a78533f6 Bug 1642952 - Modern search engine configuration no longer needs to 'rebuild' the cache on startup. r=daleharvey
For the modern configuration, the rebuild and non-rebuild cache paths are virtually identical - we now load the app-provided engines, then the user engines. The non-rebuild cache route also applies WebExtensions found by the add-on manager whilst we're starting up, but we can apply that to the rebuild cache route as well.

Differential Revision: https://phabricator.services.mozilla.com/D80056
2020-06-18 09:58:20 +00:00
Paul Adenot
ae68ef21b3 Bug 1646660 - Disable cheaper processing made in bug 1628779. r=achronop
Differential Revision: https://phabricator.services.mozilla.com/D80156
2020-06-18 09:43:28 +00:00
Jan de Mooij
dc606a6f67 Bug 1646035 - Fix return type for Uint32Array loads in Warp. r=evilpie
As long as only int32 values are read, use an int32-only stub. If the Uint32
value doesn't fit in an int32 support loading doubles.

Differential Revision: https://phabricator.services.mozilla.com/D79962
2020-06-18 07:54:52 +00:00
Alexandre Poirot
1a2600afe4 Bug 1646409 - Remove unecessary gBrowser.selectedTab = BrowserTestUtils.addTab(gBrowser); in devtools tests. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D80152
2020-06-18 09:48:11 +00:00
Kershaw Chang
dbc3a9628c Bug 1643382 - P2: Clean background channel after redirect is completed r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D79255
2020-06-18 09:28:46 +00:00
Kershaw Chang
f24e554671 Bug 1643382 - P1: BackgroundDataBridgeChild and HttpBackgroundChannelChild don't need to be a cycle r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D79254
2020-06-18 09:28:33 +00:00
Kagami Sascha Rosylight
0c5130e3a4 Bug 1643192 - Use git log to get base ref r=glandium
Since there are still needs for .base_ref(), this uses git log way to get base commit.

Differential Revision: https://phabricator.services.mozilla.com/D78183
2020-06-18 06:39:55 +00:00
Simon Giesecke
2c863dcd11 Bug 1646391 - Simplify ReverseIterator. r=froydnj
The following simplifications are made:
* Unnecessary function template arguments are removed.
* Unnecessary copy constructor definitions are removed (making the types
  movable where possible).
* Iterators are moved where possible rather than copied.
* Unnecessary MOZ_IMPLICIT on a constructor with two arguments is removed.

Differential Revision: https://phabricator.services.mozilla.com/D80015
2020-06-18 07:49:16 +00:00
Florin Strugariu
c1f5273a81 Bug 1645037 - Don not alert for moxproxy not-replayed, and replayed metrics r=perftest-reviewers,kimberlythegeek,igoldan
Differential Revision: https://phabricator.services.mozilla.com/D79293
2020-06-18 08:54:15 +00:00
Joel Maher
d427386633 Bug 1642157 - mark 2 svg animation tests as backlog (tier-2) due to not supported. r=birtles
mark 2 svg animation tests as backlog (tier-2) due to not supported

Differential Revision: https://phabricator.services.mozilla.com/D79824
2020-06-17 23:39:23 +00:00
Jan de Mooij
1bdfd74b3f Bug 1646041 - Fix assertion failure for pending loop headers in OSR phi specialization code. r=iain
Differential Revision: https://phabricator.services.mozilla.com/D79968
2020-06-17 14:21:00 +00:00
Sebastian Hengst
8816956ea7 Bug 1645562 - set the-textarea-element/textarea-newline-bidi.html to fuzzy on Windows 7 debug. a=permapass DONTBUILD
Passes on autoland, fails on central. ¯\_(ツ)_/¯
2020-06-18 01:41:23 +02:00