Commit Graph

90 Commits

Author SHA1 Message Date
akshita
3136f3fd8a Bug 1622676 - Made dom/base flake8 compliant.r=championshuttler,sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D108310
2021-03-24 15:26:06 +00:00
James Graham
7814585840 Bug 1695263 - Vendor in a copy of wptserve that's still Python 2 compatible, r=marionette-reviewers,whimboo
Upstream wptserve just switched to Python 3 only. That's fine for
web-platform-tests, but it turns out that some marionette harness
tests are also using wptserve and are still on Python 2.

Since fixing marionette harness turns out to be non-trivial and this
blocks other wpt work, this patch does the following:

* Temporarily vendors the last wptserve revision that works with
  Python 2 in to testing/web-platform/mozilla/tests/tools/wptserve_py2

* Configures the mach virtualenv to use that copy for Python 2 modules
  only.

* Configures the test packaging system to also put that copy in the
  common tests zip. Requirements files are updated to use either the
  Python 2 version or the Pyhton 3 version as required.

Differential Revision: https://phabricator.services.mozilla.com/D106764
2021-03-03 10:03:05 +00:00
nimroot
63383bd794 Bug 1622681 - Remove dom/encoding from flake8 excludes. r=sylvestre DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D102637
2021-01-21 20:50:40 +00:00
Ricky Stewart
fbe2b42f80 Bug 1673700 - Don't use double quotes around strings in definition of fork_interpose r=firefox-build-system-reviewers,glandium
The definition of `patch_main()` has behavior that kicks in only on Windows and for Python 2. Unfortunately, not all of our `mach` commands have been migrated to Python 3, so this still matters.

Bug 1654103 replaced the single-quoted strings in this function with double-quoted strings. This should be fine, except that we call into `multiprocessing.forking.main()` with some monkey-patching that is meant to fix a Windows-specific bug (see bug 1316140). We don't do any clever serialization or anything here and we end up just passing that source to `multiprocessing.forking.main()` which aggregates that source code [dumbly](https://github.com/python/cpython/blob/2.7/Lib/multiprocessing/forking.py#L259), wrapping everything in double-quotes again and passing it to `_subprocess.CreateProcess()`, which ends up failing if the source contains strings formatted with double quotes.

We could revert bug 1654103 and exempt this file from linting, but that is overkill given that this file otherwise contains useful stuff. Instead we move everything to another file, exempt that file from linting, and update `util.py` accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D94909
2020-10-29 15:47:14 +00:00
Andrew Halberstadt
eee3c55923 Bug 1671422 - [mozlog] Add group durations to errorsummary.log, r=marco
Durations are measured in ms, and are computed by subtracting the timestamp of
the first 'test_start' action from the last 'test_end' for each manifest.

Differential Revision: https://phabricator.services.mozilla.com/D94178
2020-10-21 18:23:19 +00:00
Philipp Fischbeck
8d351c89b3 Bug 1622686 - Make testing/web-platform flake8 compliant. r=sylvestre,jgraham
This also enables py3 linting for testing/web-platform. The external testing/web-platform/tests is excluded from linting.

Differential Revision: https://phabricator.services.mozilla.com/D90744
2020-09-29 14:22:49 +00:00
Philipp Fischbeck
24588e8d85 Bug 1622683 - Make dom/websocket flake8 and pylint compliant. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D88809
2020-08-31 14:42:21 +00:00
Philipp Fischbeck
7c1c23dbfc Bug 1622680 - Make dom/canvas flake8 compliant. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D88734
2020-08-30 10:20:51 +00:00
Geoff Brown
217bbab384 Bug 1654090 - Replace testing/mochitest/pywebsocket with pywebsocket3; r=jmaher
Update testing/mochitest/pywebsocket with the latest version available: pywebsocket3
is python 3 compatible. This keeps the basic structure of the old pywebsocket, but
changes the directory name to pywebsocket3 to reflect the project renaming.

Differential Revision: https://phabricator.services.mozilla.com/D84455
2020-07-22 02:06:38 +00:00
Geoff Brown
2046699f13 Bug 1654319 - Remove some flake8 exclusions; r=jmaher
Remove some exclusions so that more files are linted. These exclusions had
been made to allow for code that was not py3 compatible, but with recent
py3 efforts, the exclusions can be removed. (Linting subsequently found
a few small issues which needed to be fixed.)

Differential Revision: https://phabricator.services.mozilla.com/D84393
2020-07-21 17:10:51 +00:00
Chris AtLee
d1fb386dae Bug 1555560: Add support for black formatting with mozlint; r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D33125
2020-07-08 22:08:08 +00:00
Mihai Alexandru Michis
5f385df474 Backed out 2 changesets (bug 1555560) for causing multiple lint failures.
CLOSED TREE

Backed out changeset bd9460ac6e48 (bug 1555560)
Backed out changeset f2896032ced6 (bug 1555560)
2020-07-09 01:04:18 +03:00
Chris AtLee
7f8f324f06 Bug 1555560: Add support for black formatting with mozlint; r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D33125
2020-07-08 19:35:49 +00:00
Sylvestre Ledru
c5d947b77f Bug 1646421 - flake8 followup, remove the noqa as it breaks the test
Instead, ignore this specific test for this file

Differential Revision: https://phabricator.services.mozilla.com/D80374
2020-06-20 12:21:27 +00:00
Steve Fink
14bc264f47 Bug 1642121 - Remove directory dependence of GDB init files. r=nalexander
I wrote this patch to address two problems:

  1. if I do `mach run` from a directory other than $topsrcdir, $objdir, or
     $objdir/dist/bin, then .gdbinit will not be loaded.
  2. Debugging the firefox binary will never load the JS prettyprinters in any
     case.

I believe this patch fixes other problems as well, such as .gdbinit_python not being found, and the gdbpp pretty-printers not getting loaded in various situations.

The main changes of this patch are:

  1. Move .gdbinit into build/ (and $objdir/build/) to delay it from getting
     loaded until the search path is configured.
  2. Move libxul.so-gdb.py into the correct directory.
  3. Use either libxul.so-gdb.py or js-gdb.py to configure the correct
     search path then load .gdbinit, and have .gdbinit load all of the
     pretty-printers (Gecko and JS).
  4. Use a single preprocessed file to configure the source directory. Use
     relative paths within the objdir for everything else.

Differential Revision: https://phabricator.services.mozilla.com/D77589
2020-06-16 15:45:43 +00:00
Noemi Erli
e73a8dbb70 Backed out changeset df0d6b993ad6 (bug 1642121) for causing build bustages 2020-06-15 06:44:42 +03:00
Steve Fink
7fc47d901c Bug 1642121 - Remove directory dependence of GDB init files. r=nalexander
I wrote this patch to address two problems:

  1. if I do `mach run` from a directory other than $topsrcdir, $objdir, or
     $objdir/dist/bin, then .gdbinit will not be loaded.
  2. Debugging the firefox binary will never load the JS prettyprinters in any
     case.

I believe this patch fixes other problems as well, such as .gdbinit_python not being found, and the gdbpp pretty-printers not getting loaded in various situations.

The main changes of this patch are:

  1. Move .gdbinit into build/ (and $objdir/build/) to delay it from getting
     loaded until the search path is configured.
  2. Move libxul.so-gdb.py into the correct directory.
  3. Use either libxul.so-gdb.py or js-gdb.py to configure the correct
     search path then load .gdbinit, and have .gdbinit load all of the
     pretty-printers (Gecko and JS).
  4. Use a single preprocessed file to configure the source directory. Use
     relative paths within the objdir for everything else.

Differential Revision: https://phabricator.services.mozilla.com/D77589
2020-06-15 03:27:49 +00:00
Sylvestre Ledru
599808ffb1 Bug 1644665 - flake8: remove client.py from the exclude list DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D79418
2020-06-12 08:39:27 +00:00
chocos
d54fbc708f Bug 1622678 - Remove dom/browser-element to make it flake8 compliant.r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D78616
2020-06-08 07:50:18 +00:00
Greg Tatum
4d20207a95 Bug 1628073 - Remove the view_gecko_profile.py tool; r=sparky,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D74294
2020-05-22 13:19:58 +00:00
sumagnadas
74de3ae4a1 Bug 1622687 - toolkit/crashreporter/: Make it flake8 compliant r=gsvelto,rstewart
Made the files in toolkit/crashreporter flake8 compliant
And some finishing touches in the symbolstore.py file for readability

Differential Revision: https://phabricator.services.mozilla.com/D68691
2020-04-16 14:40:31 +00:00
Daniel Varga
3a42a4012c Backed out changeset 78a429af0ec5 (bug 1622687) for build bustage
CLOSED TREE
2020-03-30 23:32:19 +03:00
sumagnadas
dc9c74f709 Bug 1622687 - Fixed files in toolkit/crashreporter to make it flake8 compliant. r=froydnj
Changed .flake8 file to include the changes for flake8 compliance

Differential Revision: https://phabricator.services.mozilla.com/D68691

--HG--
extra : moz-landing-system : lando
2020-03-30 16:10:03 +00:00
nemesisBR
9e5deb3526 Bug 1622682 : removed unused imports and variables. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D67011

--HG--
extra : moz-landing-system : lando
2020-03-22 23:08:05 +00:00
Mihai Alexandru Michis
7681b5f08e Backed out changeset a5ce9219be07 (bug 1622682) for causing lint failures.
CLOSED TREE
2020-03-18 14:24:18 +02:00
nemesisBR
3593b5b85d Bug 1622682 : removed unused imports and variables. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D67011

--HG--
extra : moz-landing-system : lando
2020-03-17 23:01:09 +00:00
Tarek Ziadé
dc72ba77ca Bug 1597336 - add a fxa+sync scenario r=lina,markh
This patch adds a scenario that ends up syncing the generated profile into FxSync.

Differential Revision: https://phabricator.services.mozilla.com/D53789

--HG--
extra : moz-landing-system : lando
2020-02-23 23:17:23 +00:00
Csoregi Natalia
1ece026f40 Backed out changeset aa296c08a667 (bug 1597336) for browser-chrome failures on browser_all_files_referenced.js. CLOSED TREE 2020-02-23 12:26:50 +02:00
Tarek Ziadé
f2659ce7c3 Bug 1597336 - add a fxa+sync scenario r=lina,markh
This patch adds a scenario that ends up syncing the generated profile into FxSync.

Differential Revision: https://phabricator.services.mozilla.com/D53789

--HG--
extra : moz-landing-system : lando
2020-02-23 07:48:19 +00:00
Tom Prince
ecd3506c24 Bug 1611023: [taskgraph] Fix python3 flake8 errors in taskgraph; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D60782

--HG--
extra : moz-landing-system : lando
2020-01-23 03:35:31 +00:00
Razvan Maries
4a6468a68a Backed out changeset 69687a23245e (bug 1603804) for Lint failure. CLOSED TREE
--HG--
rename : python/lldbutils/README.txt => third_party/python/lldbutils/README.txt
rename : python/lldbutils/lldbutils/__init__.py => third_party/python/lldbutils/lldbutils/__init__.py
rename : python/lldbutils/lldbutils/content.py => third_party/python/lldbutils/lldbutils/content.py
rename : python/lldbutils/lldbutils/general.py => third_party/python/lldbutils/lldbutils/general.py
rename : python/lldbutils/lldbutils/gfx.py => third_party/python/lldbutils/lldbutils/gfx.py
rename : python/lldbutils/lldbutils/layout.py => third_party/python/lldbutils/lldbutils/layout.py
rename : python/lldbutils/lldbutils/utils.py => third_party/python/lldbutils/lldbutils/utils.py
2019-12-19 20:16:17 +02:00
Jonathan Watt
8e978a5ef3 Bug 1603804. Move third_party/python/lldbutils to python/lldbutils. r=ahal
This undoes the mistaken move of this directory into third_party that happened
as part of bug 1346025.

The .flake8 changes are required because lldbutils used to be excluded from
linting by virtue of being inside third_party, but would otherwise be subject
to it after this move. Fixing the existing lint errors will happen in:

  - https://bugzilla.mozilla.org/show_bug.cgi?id=1605144
  - https://bugzilla.mozilla.org/show_bug.cgi?id=1605145

Differential Revision: https://phabricator.services.mozilla.com/D57141

--HG--
rename : third_party/python/lldbutils/README.txt => python/lldbutils/README.txt
rename : third_party/python/lldbutils/lldbutils/__init__.py => python/lldbutils/lldbutils/__init__.py
rename : third_party/python/lldbutils/lldbutils/content.py => python/lldbutils/lldbutils/content.py
rename : third_party/python/lldbutils/lldbutils/general.py => python/lldbutils/lldbutils/general.py
rename : third_party/python/lldbutils/lldbutils/gfx.py => python/lldbutils/lldbutils/gfx.py
rename : third_party/python/lldbutils/lldbutils/layout.py => python/lldbutils/lldbutils/layout.py
rename : third_party/python/lldbutils/lldbutils/utils.py => python/lldbutils/lldbutils/utils.py
extra : moz-landing-system : lando
2019-12-19 16:37:46 +00:00
Tom Prince
edb7bc90b0 Bug 1596775: Add flake8 skip for python3.8;
Differential Revision: https://phabricator.services.mozilla.com/D57056
2019-12-13 06:44:20 +02:00
Stephen Donner
61478a4536 Bug 1583197. Rename 'cold' conditioned profile to 'settled'. r=tarek
Differential Revision: https://phabricator.services.mozilla.com/D54241

--HG--
rename : testing/condprofile/condprof/scenarii/cold.py => testing/condprofile/condprof/scenarii/settled.py
extra : moz-landing-system : lando
2019-11-26 09:06:32 +00:00
Andrew Halberstadt
a3466c3c3c Bug 1583353 - [manifestparser] Support manifests in the 'pathprefix' filter, r=egao
Allows 'paths' passed into the pathprefix filter to be manifests. Any path that
ends with '.ini' is considered a manifest.

Depends on D51899

Differential Revision: https://phabricator.services.mozilla.com/D51900

--HG--
extra : moz-landing-system : lando
2019-11-08 18:58:09 +00:00
Rob Wood
be2b8eab04 Bug 1520463 - Raptor python unit tests: add support for python 3 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D48768

--HG--
extra : moz-landing-system : lando
2019-10-21 20:26:15 +00:00
Bogdan Tara
4736ee716a Backed out changeset a4ed297ed157 (bug 1520463) for raptor failures complaining about StringIO 2019-10-19 15:02:15 +03:00
Rob Wood
cec1bc2e1d Bug 1520463 - Raptor python unit tests: add support for python 3 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D48768

--HG--
extra : moz-landing-system : lando
2019-10-18 17:48:52 +00:00
Ms2ger
30b4e2a534 Bug 1194860 - Remove dom/imptests; r=jgraham
This leaves the testharness files, because they are used in various mochitests.

Differential Revision: https://phabricator.services.mozilla.com/D49132

--HG--
extra : moz-landing-system : lando
2019-10-15 08:22:15 +00:00
shindli
56880b8b3b Backed out changeset 8fb923925923 (bug 1194860) for causing perma mda3 failures in dom/media/webaudio/test/test_convolverNodeChannelInterpretationChanges.html CLOSED TREE
--HG--
extra : histedit_source : f6827f0392c7d385c8a78cb2ec2458cf679afa4a
2019-10-14 19:27:08 +03:00
Ms2ger
6d1c58e46c Bug 1194860 - Remove dom/imptests; r=jgraham
This leaves the testharness files, because they are used in mochitest-chrome
tests in dom/animation/test.

Differential Revision: https://phabricator.services.mozilla.com/D49132

--HG--
extra : moz-landing-system : lando
2019-10-14 15:13:32 +00:00
shindli
8aa10c0b78 Backed out changeset 73cbc0f61053 (bug 1194860) for causing lint failure in /builds/worker/checkouts/gecko/dom/imptests/testharness.js CLOSED TREE 2019-10-14 16:43:11 +03:00
Ms2ger
ea25c9e00d Bug 1194860 - Remove dom/imptests; r=jgraham
This leaves the testharness files, because they are used in mochitest-chrome
tests in dom/animation/test.

Differential Revision: https://phabricator.services.mozilla.com/D49132

--HG--
extra : moz-landing-system : lando
2019-10-14 12:59:10 +00:00
Andrew Halberstadt
91116caeac Bug 1587206 - [lint.flake8] Enable E117 across the tree, r=sylvestre
Prevents over-indentation.

Depends on D48611

Differential Revision: https://phabricator.services.mozilla.com/D48612

--HG--
extra : moz-landing-system : lando
2019-10-10 18:51:45 +00:00
Andrew Halberstadt
142851700b Bug 1587206 - [lint.flake8] Enable F811 across the tree, r=sylvestre
This prevents redefinition of unused variables.

Depends on D48610

Differential Revision: https://phabricator.services.mozilla.com/D48611

--HG--
extra : moz-landing-system : lando
2019-10-10 18:51:20 +00:00
Andrew Halberstadt
061e947540 Bug 1587206 - [lint.flake8] Enable F633 across the tree, r=sylvestre
This prevents '>>' with print statements. Since this syntax is still valid in
Python 2, I exluded dirs that contain this error rather than fix them.

Depends on D48609

Differential Revision: https://phabricator.services.mozilla.com/D48610

--HG--
extra : moz-landing-system : lando
2019-10-10 18:50:52 +00:00
Andrew Halberstadt
2b0d90e3ad Bug 1587206 - [lint.flake8] Enable F632 across the tree, r=sylvestre
This ensures we use ==/!= to strings and ints (instead of is/is not).

Differential Revision: https://phabricator.services.mozilla.com/D48609

--HG--
extra : moz-landing-system : lando
2019-10-10 18:50:33 +00:00
Andrew Halberstadt
c97b9eb681 Bug 1567642 - [lint.flake8] Skip remaining flake8 under Python 3 lint issues r=gbrown
Depends on D45417

Differential Revision: https://phabricator.services.mozilla.com/D46352

--HG--
extra : moz-landing-system : lando
2019-09-24 14:46:38 +00:00
Tarek Ziadé
b1507c0416 Bug 1581818 - Make sure client.py stays Python 2 compatible r=stephendonner
We need to keep util.py python 2 compatible. The Python 3 helper class
that's used to generate conditioned profiles is moved to its own
module and we're reactivating util.py in flake8

Differential Revision: https://phabricator.services.mozilla.com/D46259

--HG--
extra : moz-landing-system : lando
2019-09-18 15:16:57 +00:00
Tarek Ziadé
5dd9d5bcd0 Bug 1562870 - generate conditioned profiles r=gbrown,bc,aerickson
Generates "conditioned" profiles.

Differential Revision: https://phabricator.services.mozilla.com/D38211

--HG--
extra : moz-landing-system : lando
2019-09-16 19:44:35 +00:00