This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.
This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.
Differential Revision: https://phabricator.services.mozilla.com/D226397
The components weren't used anywhere. We can also remove selectors and rules that were targetting
classes only used in this file.
Differential Revision: https://phabricator.services.mozilla.com/D227837
Generate and read ktlintFormat report instead of ktlint when running `./mach lint -l android-{fenix|focus|ac} --fix}` to accurately report the existing errors/warnings
Also fixes the issue where running AC linter from fenix directory would immediately output ✖ 0 problems (0 errors, 0 warnings, 0 fixed) without running the linter but the linter would run normally if run from root folder or AC subdirectory
Differential Revision: https://phabricator.services.mozilla.com/D226850
For long touch scrolls that change direction, using the start point of
the touch scroll as the origin to calculate the angle of the scroll is
problematic for determine the axis that should be locked. Maintain a
list of recent touch gesture points and calculate the gesture angle from
the most recent touch gesture points.
Differential Revision: https://phabricator.services.mozilla.com/D219228
Add a minimum size parameter to the RecentEventsBuffer, for the scenario
in which we would prefer data from stale events to that of the fallback.
Differential Revision: https://phabricator.services.mozilla.com/D220141
It looks like the profiler gtests became more flaky over time on 32-bit
platforms and they are starting to fail due to OOM errors. We don't really
need to test them, so let's disable them all together.
Differential Revision: https://phabricator.services.mozilla.com/D227803
This provides a way to make type-dependent statements appear as-if they
were located at the template call site.
During the analysis of the template, this first registers all type-dependent
function call locations in ForwardedTemplateLocations (we don't have more
information at this point).
Then when analyzing the template instantiations, we link the actual
type-resolved statements to the template instantiation.
Then when emitting the analysis data for a template call, we also (recursively)
emit all the analysis data for the forwarded items at the call site.
Differential Revision: https://phabricator.services.mozilla.com/D228449
This is adding the RemotePermissionService xpcom js service for the purpose of
importing default permission manager entries from remote settings. This service
will be initialized by the permission manager after it has read all its
permissions from disk and is fully initialized.
When being initialized, the service will at first get all the current default
remote permissions from the remote settings client, and add them as default
permissions through the `AddDefaultFromPrincipal` method added in D222650. An
event listener is then also set up to keep the default entries in the permission
manager in sync with remote settings.
All of this is guarded behind a whitelist in the the `ALLOWED_PERMISSION_VALUES`
variable, ensuring only specific permission types and values can be imported
through this mechanism.
Differential Revision: https://phabricator.services.mozilla.com/D222649
This method will later be used to import default permissions from remote
settings through the remote permission manager.
Differential Revision: https://phabricator.services.mozilla.com/D222650
Allow default permissions to be deleted by adding a new permission with same
origin and type, and value UNKNOWN_ACTION, analogous to how normal permissions
currently already get deleted. This can then later be used by the remote
permission service (D222649) to remove default permissions it previously added
if they have been removed in remote settings.
Also add brackets to make clang-tidy happy.
Differential Revision: https://phabricator.services.mozilla.com/D222651
This makes sure default permissions are always restored when a previously
overriding user permission gets deleted with AddInternal.
Differential Revision: https://phabricator.services.mozilla.com/D222652
This just simplifies the code for later use and should not change any behaviour
beside the following:
If `permissions.manager.defaultsUrl` is customized and contains a legacy `host`
entry, removes the history lookup to determine known origins for a given host.
Instead, only entries for http:// and https:// on the default ports will be
added. This is because with the changes in this patch,
`UpgradeHostToOriginAndInsert` is moved off the main thread, and a history
lookup is only allowed on the main thread.
Also rename `mDefaultEntries` to `mDefaultEntriesForImport` to better reflect
what this array is actually for: Storing the defaults so that they can be
(re-)imported into the permission manager, and not being the primary location
where the default permissions are stored.
Differential Revision: https://phabricator.services.mozilla.com/D222654
Adapt the color of the text and arrow, especially on hover.
This covers accordion in the rules view, the layout panel and the debugger.
Differential Revision: https://phabricator.services.mozilla.com/D228149
This adds a new variable with the same colors than the variable one that we can use as a drop-in replacement.
For some cases, we could reuse the existing --theme-body-emphasized-background.
The Debugger ResultList style could be simplified as it should always have either 'small' or 'big' class, which
were both setting a background color for selected item, overriding the declaration that was using --theme-accordion-header-background.
Differential Revision: https://phabricator.services.mozilla.com/D228148
This patch adds a `closedGroups` array to the SessionRestore state, and
adds functionality that ensures closed tab groups end up in the closed
groups array and that closed tab counts respect closed groups.
This does not update `undoClosedTab` or any related methods. Attempting
to restore a closed tab group will result in an error.
Differential Revision: https://phabricator.services.mozilla.com/D226397
Automatic update from web-platform-tests
AudioWorkletGlobalScope has valid currentFrame during construction.
AudioWorkletGlobalScope is created with 0 currentFrame count,
which make currentTime as 0 even though audio context has
non zero currentTime.
The fix is to pass the currentFrame info during creation through
AudioWorkletObjectProxy.
Bug: 372866278
Change-Id: I717744005588ebc571862367662b0ac2cdb947ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5958713
Commit-Queue: Sunggook Chue <sunggch@microsoft.com>
Reviewed-by: Michael Wilson <mjwilson@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379851}
--
wpt-commits: e8a72984ccc7c002dc2fae8de3123467037dd04f
wpt-pr: 49033
Automatic update from web-platform-tests
Fix nested <option> traversals
Multiple crashes were occurring due to inconsistencies between option
traversals. OptionList was not considering nested <option>s to be
associated with the select. However, HTMLOptionElement::InsertedInto and
HTMLOptionElement::OwnerSelectElement were considering nested <option>s
to be associated with selects.
This patch makes the traversals consistent by disallowing nested
<option>s from creating associations with <select> elements.
Fixed: 376786406
Change-Id: Ia6e4cc7d028033885b452efe03687638446350ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5990895
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379764}
--
wpt-commits: db9eb64fa751348cc5dd43a890d0a257a9e1259d
wpt-pr: 49029
Automatic update from web-platform-tests
View transition layered capture: determine geometry based on box model
Instead of capturing the border offset, we capture the following
layout sizes to determine sizing, in addition to the border box:
- padding box
- content box
- The box-sizing property
- In layered capture mode, we use the content box size as the
reference box for positioning the snapshot, so that padding take
effect.
- The ::view-transition-image-pair pseudo-element now has
position:relative so that it gets affected by padding. It has the
content box size.
- The width/height of the group is determined by the box-sizing
property, and it receives the computed padding.
Bug: 375395117
Change-Id: I18fe5126fbfac58b0619043cc5521ea1f280e457
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953705
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379706}
--
wpt-commits: 07dfce3f1885843deaa9a2ecd978317f7f25e9ab
wpt-pr: 49027
Automatic update from web-platform-tests
[line-clamp] [text-box-trim] Trim the last line before clamp inside nested blocks
When `text-box-trim: trim-end` is used together with `line-clamp`, it
should trim the block-end leading of the last line before clamp, the
one with the ellipsis. This worked when that last line before clamp is
directly contained by the line-clamp container, but it doesn't when it
is inside a nested block element.
The reason for this is that, although for `InlineNode`s,
`ConstraintSpace::ShouldTextBoxTrimNodeEnd` is always set if the
parent `BlockNode` is as well; for `BlockNode`s, that flag is only set
for nodes that are the last in-flow child node of its parent.
This means that, for line-clamp, there is no flag to tell a child
`BlockNode` that it is fine to trim if there's a clamp point inside
it, even if it wouldn't be fine to trim in its last formatted line.
This patch therefore adds a `ShouldTextBoxTrimInsideWhenLineClamp`
field to `ConstraintSpace` to indicate this.
Bug: 40336192, 40254880
Change-Id: I1690ab296dd9686a09f4b9f06a7d86d8998d9446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5987915
Commit-Queue: Andreu Botella <abotella@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379720}
--
wpt-commits: 23f125f385523d1e5f9777ceba49b225848b81cc
wpt-pr: 49018
