We are seeing a pretty broad distribution of results for the applink tests.
This bug increases the number of browsertime iterations from 10 to 14.
Differential Revision: https://phabricator.services.mozilla.com/D80363
Introduces a gkrust Cargo feature `glean_with_gecko` and `with_gecko` on fog
and glean. This feature signifies the presence of gecko symbols in the build.
Use this feature to implement needs_ipc() which asks Gecko which process type
we're running as.
Differential Revision: https://phabricator.services.mozilla.com/D79744
Introducing FOGIPC, the central clearinghouse for the C++ layer between
PContent and FOG's Rust impl.
Gotta add tests.
Differential Revision: https://phabricator.services.mozilla.com/D79742
This isn't 100% of a solution yet as the main process has no way of turning
a MetricId into a StringMetric (we're gonna a need a table. Maybe several.)
which we'll need before we can replay.
Also, there's no serialization or communication yet, which I guess is a bigger
deal.
Oh, and no detection of which process we're even on.
Differential Revision: https://phabricator.services.mozilla.com/D79741
Temporarily on PContent instead of managed by PBackground, there's one
parentbound message for occasionally uplifting Glean data from child processes
and one childbound message for forcing the immediate flush of Glean data in the
async return.
Can't write gtests for this as ContentChild and ContentParent include things
that aren't present in gtest.
Differential Revision: https://phabricator.services.mozilla.com/D78077
No longer called. This was done as an optimization for OOP iframes, but
it affects the scrollport so it's clearly not sound (the visible rect
shouldn't affect the layout scroll port).
If very tall OOP iframes are a problem somehow, it's something that we
need to deal with in another place. It was, in fact, removed for
top-level remote iframes because of bug 1554861 and other regressions.
Depends on D80731
Differential Revision: https://phabricator.services.mozilla.com/D80732
After the above, I don't think this is needed anymore, because we
shouldn't be looking at the widget size from layout.
It also shouldn't cause more reflows on desktop at least, because of the
early out in ResizeReflowIgnoreOverride before calling
SimpleResizeReflow().
Differential Revision: https://phabricator.services.mozilla.com/D80731
No behavior change actually (as instant is the default behavior), but I
just noticed it while debugging these.
Depends on D80723
Differential Revision: https://phabricator.services.mozilla.com/D80724
This should be equivalent because:
* Content viewer size and widget size should eventually be the same always
(modulo mid-resize, see bug 1645954).
* Only the root content document has a widget on android (the puppet widget).
* Only the root content document has a dynamic toolbar.
* We were only calling this on the root document, which has no parent pres
context (at least with e10s). Without e10s we could have a chrome
prescontext (not sure it that ends up being a parent in the pres context
chain), but we should never change the resolution of that one, so I think
aScaleContentViewerSize is just useless.
This avoids having two sources of truth by always checking the content viewer
size without subtracting the dynamic toolbar max size.
Differential Revision: https://phabricator.services.mozilla.com/D80723
This message dates from bug 1177128, the commit where this bootstrapper was added. At the time of writing that was certainly true, but today it doesn't appear to be true in any meaningful way. There's certainly an expectation that installing MozillaBuild and running `mach bootstrap` will get your machine ready to build Firefox; or at least, if it doesn't, it prints out some error messages telling you to do extra stuff, like we see in bug 1644794 for example. Therefore, I don't see how this message is relevant at all any more.
Differential Revision: https://phabricator.services.mozilla.com/D80730
I still don't know why this is happening, but this should make the problem a release mode assertion failure rather than an illegal memory access.
Differential Revision: https://phabricator.services.mozilla.com/D80866
Automatic update from web-platform-tests
Streams: fix IDL tests
The new idlharness tests for Streams (#22982) did not correctly instantiate all tested interfaces. This PR fixes them.
--
wpt-commits: e32f3a1e058335c5f4ad705b208f8e4610ad7b6c
wpt-pr: 24267
Automatic update from web-platform-tests
[mathml] Improve mathml/relations/html5-tree/dynamic-childlist-00*.html results
These tests add children to mspace, but mspace does not allow children. Nevertheless the internal framework, using Element.getBoundingClientRect, assert based on these disallowed children which get bounding boxes that are empty rects.
To fix this, special case mspace and only check size and that the children are empty and positioned at (0, 0).
Bug: 6606
Change-Id: Ic78720547f7e4909cf63ceeb92b3bfbf22d7e15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256212
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#781296}
--
wpt-commits: a3c3821c5083d2fda1d00fa2a2fc577a2e2ec66e
wpt-pr: 24287
Automatic update from web-platform-tests
Test imports under more than 3 levels in different modules
--
wpt-commits: db6a91fe60f12f16540dff758abb20ee00be9d89
wpt-pr: 24284
Automatic update from web-platform-tests
Fix endianness problem in wasm-module-builder.js
--
wpt-commits: 5a8e4a343124e9ab4e9424b9ef096d7ae345080f
wpt-pr: 24308
Automatic update from web-platform-tests
Update html5lib from 1.0.1 to 1.1
--
Update html5lib from 1.0.1 to 1.1
--
wpt-commits: 469df8293287e713b4b8e1bfffea14395039b132, a877800a7788203dba2d0228bfd8f466fc821e6e
wpt-pr: 24303
Automatic update from web-platform-tests
Use the correct layout invalidation root in StyleEngine::InvalidateStyleAndLayoutForFontUpdates
The function currently uses the LayoutObject of the documentElement as
the layout invalidation root, which is incorrect because there can be
objects not in its subtree. For example, a modal dialog.
This patch fixes it by using the LayoutView, the root of the layout
tree, as the layout invalidation root.
Bug: 1092411
Change-Id: Ic2475fe1fc9fd9029699a410b4f03a9f3812e240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255738
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781132}
--
wpt-commits: 80aec473c19f40c879df56657c9c4ee6ed8959ca
wpt-pr: 24295
Automatic update from web-platform-tests
Use same/cross-site terminology for split cache WPT and minor changes
Changes the use of same/cross-origin to same/cross-site to reflect the
change in the approach. Accordingly, names helper files more
appropriately. Also makes the ordering of tests more natural and adds
descriptive names to each test.
Bug: 1092991
Change-Id: If9bebebea8b0b51db2d4f8c1c3ab1ddf1e2fb233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248867
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781090}
--
wpt-commits: 9e1358f2d09a75340b8e4b572e19f52e864f2790
wpt-pr: 24173
Automatic update from web-platform-tests
Revert "Don't reset computed 'float' for flex and grid items"
This reverts commit 906abd41e4f6c786a1927f6edd69d6926e20317b.
Reason for revert: A DCHECK was getting hit, causing a crash: https://bugs.chromium.org/p/chromium/issues/detail?id=1097595#c4
Original change's description:
> Don't reset computed 'float' for flex and grid items
>
> Floated flex and grid items have their 'float' incorrectly computed to
> "none". This change fixes this by adjusting IsFloating() for flex and
> grid items inside LayoutBox::UpdateFromStyle() instead of inside
> StyleAdjuster::AdjustStyleForDisplay().
>
> Beyond this, legend elements are not allowed to be rendered legends
> if they are floating. However, if legends are flex items, we
> adjust IsFloating() to be false. This causes legends to be
> used as rendered legends when they are flex items, even if they
> were styled as a float.
>
> This is fixed by checking ComputedStyle::IsFloating() instead
> of LayoutObject::IsFloating() when finding the rendered legend in
> order to get its non-adjusted floating value.
>
> Bug: 875235,350505
> Change-Id: Ia1e7f7c244cc0c443cd58be42854866884b7f7e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157889
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Commit-Queue: Alison Maher <almaher@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#763988}
TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org,almaher@microsoft.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 875235, 350505, 1097595
Change-Id: I5e5ff8a93d1e1e46908f9b640b9564e70345e9e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256772
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#780995}
--
wpt-commits: 9f6b1348c4216fb3597f1ebab3f4b06091cd7ab9
wpt-pr: 24296
