This whitelisting is not as mangled as the old one, so hopefully it
will be more resilient to changes in the Rust compiler. I moved them
to the top level white list, because like with the JS leaks we are
mostly focused on C++ leaks. Any interesting Rust leak is probably due
to a C++ leak.
Differential Revision: https://phabricator.services.mozilla.com/D28727
--HG--
extra : moz-landing-system : lando
Define the Variant::addTagToHash method, which perturbs a hash value according
to the variant's current alternative's tag. This makes it easier to avoid
collisions in variants in which different alternatives might hash similarly.
Tests included.
Differential Revision: https://phabricator.services.mozilla.com/D28768
--HG--
extra : moz-landing-system : lando
This is not strictly required in mozilla-central, as `mach` sets
the encoding of the output to UTF-8.
Differential Revision: https://phabricator.services.mozilla.com/D28861
--HG--
extra : moz-landing-system : lando
We can reconstruct the CDP error and print a better error message
using RemoteAgentError. This is better than the current output,
which in a lot of cases will be "CDP Exception: [object Object]".
A possible future improvement to this involves extending the CDP
protocol to send the individual components of the error individually,
so that we don't have to parse the string.
Differential Revision: https://phabricator.services.mozilla.com/D28703
--HG--
extra : moz-landing-system : lando
There are two concepts of targets in CDP: the target web document,
and the Target domain. The remote/targets/ subfolder is related
to the first, which should have bugs filed under Remote Protocol ::
Agent, covered by the preceding rule.
DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D28689
--HG--
extra : moz-landing-system : lando
Patch unfortunately has to add a few domain stubs so that mach does
not complain about not finding any files associated with these new
bug components.
Differential Revision: https://phabricator.services.mozilla.com/D28688
--HG--
extra : moz-landing-system : lando
The gist of the problem I introduced with the framebuffer coordinate system is that we provided the window rect (effectively) twice:
1. when computing the document rectangle (and Y-inverting it)
2. when rendering
If between these points the window got resized (during scene building), we end up with our document aligned to bottom left corner.
The user expects content to still be aligned to the top left, so that's what is visible as a bug.
The change here switched scene building to only care about device coordinate space, restraining the framebuffer coordinates to be mostly
an implementation detail of the renderer/device (the way it was originally meant to be, when introduced). This way the current window size
is only considered once during rendering.
Differential Revision: https://phabricator.services.mozilla.com/D28731
--HG--
extra : moz-landing-system : lando
the requestSecurityCode allows merchants to opt out of requiring a CVV from a credit card.
Differential Revision: https://phabricator.services.mozilla.com/D28777
--HG--
extra : moz-landing-system : lando
Pick commits:
3570749 - wasapi: tie monitor lifetime with notification client lifetime. BMO 1545279 (#505)
162625a - test: add option to get the posotion of a stream (#504)
Differential Revision: https://phabricator.services.mozilla.com/D28796
--HG--
extra : moz-landing-system : lando
The className was making the color purple, although we want it to be red.
Removing the className makes it red.
Differential Revision: https://phabricator.services.mozilla.com/D28616
--HG--
extra : moz-landing-system : lando
Prior to this patch, Wasm/Baseline's stackmap creation logic failed to take
into account reftyped locals which are not also parameters. This patch fixes
that. It also adds a new test that reliably exposes the failure on all 4
primary targets. The test case also runs on Ion, and it appears that Wasm/Ion
does not suffer from an analogous problem.
Differential Revision: https://phabricator.services.mozilla.com/D28654
--HG--
extra : rebase_source : 893bb5ad7e2028a29385f4624472d63defe3af19
The tests are instrumented to automatically set the remote.enabled
preference as part of their manifests. In the case of xpcshell,
it is also technically not need it as they do not trigger the
command-line-handler.js code path.
DONTBUILD
If we use the downloaded manifest then any bug that leads to an error in the manifest
may be propogated forward. Instead force the manifest to be built from scratch in CI.
Differential Revision: https://phabricator.services.mozilla.com/D28809
This patch moves remaining public `enum` of `nsIPresShell` to `mozilla`
namespace in `mozilla/PresShellForwards.h` and make them `enum class`es.
Additionally, some methods which use the moving `enum`s from `nsIPresShell`
to `PresShell`.
Differential Revision: https://phabricator.services.mozilla.com/D28607
--HG--
extra : moz-landing-system : lando
This patch moves some `enum` in `nsIPresShell` which are in public scope into
`mozilla` namespace and change them as `enum class`es.
Unfortunately, only "where to scroll" enum is just defines constants of
percentages of scroll destination. Therefore, this patch makes only them
as `static const`.
Differential Revision: https://phabricator.services.mozilla.com/D28606
--HG--
extra : moz-landing-system : lando
This patch creates new header, `mozilla/PresShellForwards.h`. It should have
all forward declarations of global class/struct in `nsIPresShell.h` and
`mozilla/PresShell.h`.
Additionally, this moves all `enum`s and `constant`s in them into the new file
with changing them to `enum class`es.
This will make other headers which require only specific types in the header
files not include them.
Differential Revision: https://phabricator.services.mozilla.com/D28605
--HG--
extra : moz-landing-system : lando
We needed to handle the case where closePictureInPicture was being called on a window
that had already been closed but not yet GC'd.
Depends on D26807
Differential Revision: https://phabricator.services.mozilla.com/D27001
--HG--
extra : moz-landing-system : lando
Ensure the button to copy all changes remains in view even when the Changes panel is overflowing vertically.
Differential Revision: https://phabricator.services.mozilla.com/D28487
--HG--
extra : moz-landing-system : lando
Button elements are not user-selectable by default as defined by User Agent stylesheet defaults: https://www.w3.org/TR/css-ui-4/#issue-74a40dd9
However, by using the Selection.selectAllChildren() API, button elements do get a selection highlight (their text contents don't get copied to the clipboard; that is expected). See Bug 1546366.
Until bug 1546366 is addressed, this patch ensures that button elements in DevTools never get a selection highlight by unsetting any applied styles with the `::selection` pseudo-element.
Differential Revision: https://phabricator.services.mozilla.com/D28627
--HG--
extra : moz-landing-system : lando
The Context 0.1 format specifies that the (de)compression of nodes is determined by:
- its node type;
- its parent type;
- the index in the parent node;
- whether the node is an element of an array.
This patch modifies the parser generator to pass the information during parsing.
Differential Revision: https://phabricator.services.mozilla.com/D28534
--HG--
extra : moz-landing-system : lando
