`InspectorUtils.getRuleBodyTextOffset` was returning bytes position, and we
were using them directly in Javascript `substring`, which causes problem
with non-ascii chars.
Instead of returning offsets to compute the rule string, we directly return
the string from InspectorUtils which is easier to work with.
Differential Revision: https://phabricator.services.mozilla.com/D204523
The next patch modifies `getRuleText` so it only returns the text, and no
longer the offset at which the rule starts.
The only consumer of the returned offset was in `StyleRuleActor#setRuleText`,
so we migrate this directly to a InspectorUtils method to avoid mixing JS string
indexes with Rust bytes position.
Differential Revision: https://phabricator.services.mozilla.com/D204522
Automatic update from web-platform-tests
Update testharnessreport-servo.js with new props
--
wpt-commits: d7608c3f616a39fd032d28d84a23d46274fdd58b
wpt-pr: 45403
Automatic update from web-platform-tests
[SAA] Test Cache Storage Fetch w/ Cookies
Let's validate that the correct cookies are included in cache storage
fetches, which is to say we use the cookies the current window has
access to at the time the fetch is done.
Bug: 40282415
Change-Id: If6de86f0781668e67f75e22c0c7812a31b7404cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5403529
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279781}
--
wpt-commits: a2c70cbd735e9bf8de024552285f00a62e4a1865
wpt-pr: 45406
Automatic update from web-platform-tests
[layout] Mitigate flex crash.
We recently enabled some correctness for flex-wrap intrinsic-sizing:
https://chromium-review.googlesource.com/c/chromium/src/+/5388584
However the fixes were slightly too broad. We aren't (yet) producing
a layout-result for baseline-alignment purposes within the flex-wrap intrinsic sizing logic.
For the moment mitigate this by ignoring alignment (how it was working
previously).
Bug: 331646698, 40206065
Change-Id: I216481b4d2746cb514a6ee186a57512af03ba5fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402803
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279695}
--
wpt-commits: 33c3fe9690d0e6e028b6a91af29295dc863fe79b
wpt-pr: 45392
Automatic update from web-platform-tests
Reduce number of test_no_interpolation tests between sizing keywords.
This removes some excessive tests that were making the tests slow.
Bug: 313072
Change-Id: I3ce49ce634930849798df74e4a40bdf4656c4b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5398737
Auto-Submit: David Baron <dbaron@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279693}
--
wpt-commits: 80ab23edeb5ff7917624258aa148997125851282
wpt-pr: 45358
Automatic update from web-platform-tests
[Invokers] Reland: Only dispatch invoke for built-ins or actions containing '-'
(This relands
https://chromium-review.googlesource.com/c/chromium/src/+/5366502 after
fixing timeout issues in
https://chromium-review.googlesource.com/c/chromium/src/+/5372478 and
new failing tests from
https://chromium-review.googlesource.com/c/chromium/src/+/5374369)
This change refactors the `HandleInvokeInternal` calls to use an enum
class of known attribute values including a `kCustom` key which can determine if the invoke action meets the criteria for being
a "custom" action - that is it includes a dash (see
b40ba866cc).
This also updates the tests to reflect this; only actions with a `-`, or
otherwise known actions, will dispatch an event. All other actions do
not, and must be manually dispatched. This does not preclude web authors
from manually dispatching said events.
Bug: 40947660
Change-Id: Ia704e73e50bf65b01286a148bd5b810241f0c664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5393265
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Keith Cirkel <chromium@keithcirkel.co.uk>
Commit-Queue: Keith Cirkel <chromium@keithcirkel.co.uk>
Cr-Commit-Position: refs/heads/main@{#1279659}
--
wpt-commits: 6103651d84bab72f06c3711c1945f86089d75bb4
wpt-pr: 45341
Automatic update from web-platform-tests
[digital credential] Move IdentityRequestProvider to a separate dict
In this CL, we further decouple the Digital Credential API [1] from
the FedCM API [2] by moving the protocol/request parameters into its
own dictionary that is only accessible by the Digital Credential API
but not from FedCM, and vice versa, so that the appropriate
parameters are parsed (or discarded) in each of these two APIs.
[1] https://wicg.github.io/digital-identities/
[2] https://fedidcg.github.io/FedCM/
Bug: 1416939
Change-Id: I322bcac9fb38eb52e3466162753e000146d652fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386528
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279609}
--
wpt-commits: 3bfcd2d3f1d691fe9ae88bcf9db5d0eef0c71715
wpt-pr: 45397
Automatic update from web-platform-tests
Drop redundant alpha channel keyword resolution
The next expression/block will handle this case as well since it has a
"wider" environment.
This block will also mean that a 'alpha' channel keyword is always
accepted in the alpha position, since it's not guarded by a check for if
RCS is used.
Bug: 41490164
Change-Id: I6a33df6082e39f99eaf75250e439898a9404be69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5392801
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1279392}
--
wpt-commits: 21726d3bece0cdfec3c2881ce23c392cbd336055
wpt-pr: 45340
Automatic update from web-platform-tests
webnn: Migrated resample2d unit tests to WPTs.
This CL is migrating resample2d unit tests to WPTs by removing
MLGraphBuilderTest.Resample2dTest and MLGraphTestMojo.Resample2dTest
tests. It's also fixing axes validation issue.
Bug: 327337526 328026885
Change-Id: Ia0ae3fe2515040f37d84fef048ba558991a248c3
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5382118
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Feng Dai <feng.dai@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Auto-Submit: Feng Dai <feng.dai@intel.com>
Cr-Commit-Position: refs/heads/main@{#1279384}
--
wpt-commits: fdf65900f894eddf21fa68b807b305bce2a405fa
wpt-pr: 45211
Automatic update from web-platform-tests
Add web platform tests for max trusted bidding/scoring signals URL length.
Add web platform tests for both maxTrustedBiddingSignalsURLLength and
maxTrustedScoringSignalsURLLength by checking if any merged URL length
exceeds any of the signals' URL length limit.
Bug: 324416012
Change-Id: Icf4ea75992307b3a02048eccfb0dbf4bd708a7f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5385994
Commit-Queue: Tianyang Xu <xtlsheep@google.com>
Reviewed-by: mmenke <mmenke@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279285}
--
wpt-commits: acabb88c580459224955c8c0fa0bddd6fd701f30
wpt-pr: 45262
Automatic update from web-platform-tests
Blink: Set access policy to protected mode in Drag Drop events
As per spec
https://html.spec.whatwg.org/multipage/dnd.html#concept-dnd-p
The correct access restriction for most drag events
after "dragstart" is the protected mode.
which allows enumerating the types/kind of data in the drag store.
DataTransferAccessPolicy::kImageWritable is
no longer in use and is removed.
Bug: 1345474
Change-Id: Ibcbe4f61f5846ba49b590d235324f2784370d005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5341049
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Rakesh Goulikar <ragoulik@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1279266}
--
wpt-commits: ccd60d5c5888226332acc8482fa60728e1e185f1
wpt-pr: 44905
Automatic update from web-platform-tests
[FedCM] Always notify opener that we're done loading
If FencedFrameConfig does not exist, we never send the
message to the opener.
That leads to a test timeout, which is unfortunate.
Instead, rearrange this code so that we always add the onload listener.
Noticed this while running
credential-management/fedcm-login-status/cross-origin-status.https.html
Bug: 331237776
Change-Id: Id47677cf591337c3a548c10e33ad29f56985d882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402337
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279256}
--
wpt-commits: b313ed0b09d7b7aca6132707ff8fbec4a0e08890
wpt-pr: 45388
Automatic update from web-platform-tests
Support default datalist in appearance:bikeshed <select>
This patch makes <select> with appearance:bikeshed work when the author
does not provide a child <datalist> element to slot in. It also adds a
::select-fallback-datalist pseudo-element which matches the fallback
<datalist> in the UA shadowroot.
Bug: 1511354
Change-Id: I4e91ab8a528a5a9235c2cf8a3a20a5d869b0878c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5368740
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279219}
--
wpt-commits: c7b3871ef4819f0130e4fd290a43aa3a3073bd8e
wpt-pr: 45224
Automatic update from web-platform-tests
[css-anchor-position] Basic support for position-visibility: no-overflow
https://github.com/w3c/csswg-drafts/issues/7758#issuecomment-1965540529
no-overflow hides the abspos if it overflows its inset-modified
containing block (after exhausting all position-try options, if
relevant). Note this value would apply even when using regular
abspos or fixedpos.
PaintLayer::SetInvisibleForPositionVisibility to track if the layer
needs to be invisible for any position-visibility constraint. The
function is called when the abspos needs to be invisible due to
no-overflow. The layer, as well certain descendant layers [1] in
containing block hierarchy will be skipped during hit-testing and
paint.
[1] We should skip all descendant layers in containing block
hierarchy, but this CL fails to skip self-painting descendant layers
if the layer is not a stacking context. The issue will be addressed
in a followup.
Bug: 329703412
Change-Id: Iee50ef89fbdb6a4c514b1940c45b0d9c41220383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5398471
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279183}
--
wpt-commits: f1d83c9438a4efaf226ec445d23d88bb1bc708ad
wpt-pr: 45364
Automatic update from web-platform-tests
screen wake lock: Set "allow" attribute in more Permissions Policy tests (#45373)
Contrary to the old Feature Policy spec, in the Permissions Policy both the
header and the "allow" attribute are checked, and even when the header
access to a given feature it might still fail if the "allow" attribute is
not set accordingly (it defaults to "src").
In the tests being changed here, we explicitly set the attribute to make
sure that the Permissions Policy checks are failing because of the header
values, not because of a lack of an "allow" attribute that would have
otherwise permitted access to the feature.
--
wpt-commits: 25fdec3c95e308d6c844022fedd2fcbb6b2b5703
wpt-pr: 45373
Unfortunately, we returned a `CompositionEvent` for
`Document.createEvent("textevent")` because we had a text event which we stopped
exposing to the web and was replaced with `eCompositionChange` event.
Therefore, this change could potentially have a compatibility risk.
Differential Revision: https://phabricator.services.mozilla.com/D200120
