The unittest does not verify that the input is forwarded to the output of the
CrossGraphReceiver because it is not easy to get the corresponding
MockCubebStream. This has been left as future work.
Depends on D85557
Differential Revision: https://phabricator.services.mozilla.com/D85558
Use the newly added functionality in MockCubeb to verify that the input is
forwarded to the output.
Depends on D85556
Differential Revision: https://phabricator.services.mozilla.com/D85557
With this patch, AudioGenerator is used to create a sine tone audio input to a
duplex stream. In parallel, the AudioVerifier is used to verify that this sine
tone exists in the output (on demand).
This is the first approach. Fancier generators/verifiers can be future work.
Depends on D85554
Differential Revision: https://phabricator.services.mozilla.com/D85555
This is useful in order to be used by the low-level part of the stack
(MockCubeb) where the buffers contain interleaved channels.
Depends on D85553
Differential Revision: https://phabricator.services.mozilla.com/D85554
The existing AudioGenerator takes over the job of AudioToneGenerator.
AudioToneVerifier becomes AudioVerifier to match the naming pattern.
In order to reuse the functionality for other tests.
Depends on D85552
Differential Revision: https://phabricator.services.mozilla.com/D85553
In addition to that remove it from the exclude list of the whitespace sanity check assuming that the dos EOL had made it fail.
Differential Revision: https://phabricator.services.mozilla.com/D85552
Sets autoland to use the 'bugbug' test manifest loader. This is being enabled
as part of a temporary trial to see the impact it has on sheriffing.
Depends on D90159
Differential Revision: https://phabricator.services.mozilla.com/D90160
When rejecting promises in ChromiumCDMProxy we pass an exception to MediaKeys to
represent the error that took place. However, if we do not have a any keys the
exception is not passed anywhere. Since these exceptions will assert on
destruction that they were handled we need to explicitly suppress the exception
when we don't have MediaKeys to avoid firing asserts.
The case we hit this issue in is during browser shutdown, so I think it makes
sense to ignore the exception. This is not a case of simply ignoring an
exception when it can be handled, this is that we're in a state where various
machinery is becoming unavailable and where it makes sense to not try and send
the exception any further.
Differential Revision: https://phabricator.services.mozilla.com/D90156
Including SymbolType.h in AtomMarking.h pulls in a ton of vm includes. This
dependency can be moved to the -inl.h which used rarely.
Differential Revision: https://phabricator.services.mozilla.com/D90103
Currently HelperThreads.h defines all the internals of the helper thread
system, but most of this is only neeed by HelperThreads.cpp itself. This patch
splits that out into a separate file so that HelperThreads.h defines an API for
the helper thread system.
Differential Revision: https://phabricator.services.mozilla.com/D90101
This is only used by ubinode and doesn't need to be in the public API. I
removed ZoneSet/CompartmentSet which are otherwise unneeded.
Differential Revision: https://phabricator.services.mozilla.com/D90100
When rejecting promises in ChromiumCDMProxy we pass an exception to MediaKeys to
represent the error that took place. However, if we do not have a any keys the
exception is not passed anywhere. Since these exceptions will assert on
destruction that they were handled we need to explicitly suppress the exception
when we don't have MediaKeys to avoid firing asserts.
The case we hit this issue in is during browser shutdown, so I think it makes
sense to ignore the exception. This is not a case of simply ignoring an
exception when it can be handled, this is that we're in a state where various
machinery is becoming unavailable and where it makes sense to not try and send
the exception any further.
Differential Revision: https://phabricator.services.mozilla.com/D90156
Including SymbolType.h in AtomMarking.h pulls in a ton of vm includes. This
dependency can be moved to the -inl.h which used rarely.
Differential Revision: https://phabricator.services.mozilla.com/D90103
Currently HelperThreads.h defines all the internals of the helper thread
system, but most of this is only neeed by HelperThreads.cpp itself. This patch
splits that out into a separate file so that HelperThreads.h defines an API for
the helper thread system.
Differential Revision: https://phabricator.services.mozilla.com/D90101
This is only used by ubinode and doesn't need to be in the public API. I
removed ZoneSet/CompartmentSet which are otherwise unneeded.
Differential Revision: https://phabricator.services.mozilla.com/D90100
Remote Settings still support search shortcuts for the time being but it's considered an obsolete feature that we don't intend to use.
Differential Revision: https://phabricator.services.mozilla.com/D90122
In ScrollFrameHelper::ScrollToImpl we suppress repainting scrollbars when calling UpdateScrollbarPosition if we've decided not to schedule a paint (because we are sending a pending scroll update instead). Otherwise we repaint which is what we are trying to avoid.
The desktop zooming scrollbars code added a call to UpdateScrollbarPosition in SetVisualViewportOffset because the vv offset is what determines the scrollbar position, no longer the layout scroll position. This means that we can trigger a repaint via that path, and there is a test that checks that we don't.
This patch moves the SetVisualViewportOffset call to just after the code that determines if we need to schedule a paint (it was just before it), and then add the AutoScrollbarRepaintSuppression class.
Differential Revision: https://phabricator.services.mozilla.com/D89902
This fixes a few causes of firing EndDownload twice:
1. firing it from OnDataAvailable if the download was already canceled when the
method was initially invoked, rather than if we are ourselves wanting to
cancel the download because we encountered issues inside OnDataAvailable.
2. firing it from FinishDownload, dispatched from SerializeNextFile, after the
download has already been ended elsewhere.
3. calling Cancel() multiple times.
It also adds some code to avoid the re-entrancy on the Promise code that the
bug was originally filed for, and a diagnostic assert to check if there are any
other cases of repeated EndDownload calling that we've missed.
As a driveby, it adds a few thread assertions to help with code clarity.
Differential Revision: https://phabricator.services.mozilla.com/D90186
By moving it to nsImageLoadingContent we don't need to pass a reference
to the current request and can just use the member.
The weird reference-passing was introduced in bug 987140 and broke in
bug 1534608.
Also make it return a CSSIntSize rather than an nsSize, since it's what
it returns, nsSize is supposed to be in app units, not in CSS pixels :-)
Differential Revision: https://phabricator.services.mozilla.com/D90036
