Commit Graph

726292 Commits

Author SHA1 Message Date
Razvan Maries
2332c87b6a Bug 1661612 - Disabled browser_net_persistent_logs.js on all platforms. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D90016
2020-09-14 13:54:21 +00:00
Emilio Cobos Álvarez
f3927b672a Bug 1665125 - Make print background settings infallible. r=bobowen
This makes callers simpler.

Differential Revision: https://phabricator.services.mozilla.com/D90285
2020-09-15 16:19:20 +00:00
Kirk Steuber
4724b9dd94 Bug 1659157 - Add testing for allowed app sources telemetry r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D89191
2020-09-09 17:35:32 +00:00
Kirk Steuber
6f0c1a1b97 Bug 1659157 - Collect allowed app install source data and submit to telemetry r=Gijs,chutten,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D89190
2020-09-10 20:16:04 +00:00
Kirk Steuber
cfb1ccb642 Bug 1659157 - Add scalar to track allowed app installation sources on Windows r=RT
Differential Revision: https://phabricator.services.mozilla.com/D89189
2020-09-14 17:15:22 +00:00
Csoregi Natalia
aa6fe0f0a5 Backed out changeset cfd8edb05103 (bug 1664541) for gecko decision task bustage. CLOSED TREE 2020-09-15 19:15:55 +03:00
Gregory Mierzwinski
6a23cf6532 Bug 1664541 - Add package-lock.json to browsertime resources. r=perftest-reviewers,kimberlythegeek
Differential Revision: https://phabricator.services.mozilla.com/D89953
2020-09-15 15:48:06 +00:00
Tooru Fujisawa
2e3005ac3c Bug 1665015 - Use SystemAllocPolicy for ObjLiteralWriterBase and ObjLiteralAtomVector. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D90243
2020-09-15 14:54:10 +00:00
Ricky Stewart
b9f69c11b9 Bug 1663786 - Remove "copy" support from virtualenv handling r=ahal
This is unused.

Differential Revision: https://phabricator.services.mozilla.com/D89509
2020-09-10 12:54:49 +00:00
Ricky Stewart
4822d7dd4c Bug 1663755 - Remove inherit-from-parent-environment implementation r=ahal
This was originally meant to allow `virtualenv`s to use packages from a parent Python environment without having to re-install them. This turned out to not pan out as we would have liked, so we're going another way to solve the same problem. Bug 1660351 walked back a bunch of this logic; this patch deletes the rest of it.

Differential Revision: https://phabricator.services.mozilla.com/D89492
2020-09-11 22:14:41 +00:00
Ricky Stewart
233f65df7c Bug 1664567 - Set MOZ_OBJDIR in builder scripts for CI r=glandium
Without setting this variable, the call to `mach python` in `taskcluster/scripts/builder/build-linux.sh` will create a `virtualenv` in the default location -- on Linux in CI, that's `obj-x86_64-pc-linux-gnu`. Everything else about the build is going to end up in `obj-build`, so just set `MOZ_OBJDIR` appropriately to point to that directory.

Doing so enables us to land bug 1663755, as it causes the logic added to `symbols_archive.py` as part of bug 1654994 to behave as expected.

Differential Revision: https://phabricator.services.mozilla.com/D89975
2020-09-15 14:25:03 +00:00
Bob Owen
d837bfd892 Bug 1665007: Double the memory we allow for DeviceCapabilities arrays for safety. r=jfkthame
This also doubles the memory we allocate for DEVMODEs, when that value has been
returned from the other uses of DocumentProperties, because apparently some
drivers do not return the correct size.

Differential Revision: https://phabricator.services.mozilla.com/D90251
2020-09-15 15:05:52 +00:00
Luca Greco
a67ba2fcd8 Bug 1663125 - Fix registered service workers missing after restart and cover it with a marionette test. r=asuth,whimboo,marionette-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90189
2020-09-15 14:54:12 +00:00
Jim Mathies
a7cd484171 Bug 1664620 - Fixup test failures when credit card autofill is disabled (second set of changes). r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D90187
2020-09-15 14:27:19 +00:00
Andreas Pehrson
d739a3f0fc Bug 1656438 - Fix bustage. r=bustage-fix CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D90282
2020-09-15 15:51:27 +00:00
Emilio Cobos Álvarez
4490a1b6b1 Bug 1665001 - Ensure unwriteable margins are zero for print reftests. r=bobowen
It seems on OSX the default is somehow not zero. This matches
equivalent code for regular paged reftests in
layout/tools/reftest/reftest-content.js

MANUAL PUSH: Orange fix

CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D90280
2020-09-15 17:37:41 +02:00
Jed Davis
55e7808524 Bug 1664944 - GC the unused cached-font flags in GTK nsLookAndFeel. r=stransky
These appear to have been unused since bug 1384701.

Differential Revision: https://phabricator.services.mozilla.com/D90190
2020-09-15 14:25:55 +00:00
Hubert Boma Manilla
b6435b8ee8 Bug 1663979 - Theme support for messages raw section r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D90260
2020-09-15 14:49:06 +00:00
Andreas Pehrson
0591d5325d Bug 1656438 - Tighten estimated frequency check by accounting for drift factor. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D89987
2020-09-15 14:41:25 +00:00
Andreas Pehrson
d88af83716 Bug 1656438 - Make integer types explicit and unsigned in AudioDriftCorrection and friends. r=padenot
In particular, this patch gets rid of signed integers where negative values
don't make sense anyway.

Differential Revision: https://phabricator.services.mozilla.com/D89777
2020-09-15 14:42:28 +00:00
Andreas Pehrson
98fd9bf78d Bug 1656438 - Rework the audio drift correction logic. r=padenot
This patch simplifies the logic by reducing the number of paths, from two to
one method that changes the correction. This method now weighs the calculated
correction by 60% and the previous correction by 40% when setting the new value,
to provide a negative feedback loop that stabilizes around the desired amount of
buffering.

This leads to a smoother output with less noticable changes in the correction
value, while still reaching the desired amount of buffering quickly.

Tests are updated with new expectations accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D89776
2020-09-15 14:42:25 +00:00
Andreas Pehrson
25c51b36e8 Bug 1656438 - Remove logic that ignores correction changes that are too small. r=padenot
The removed logic complicates tests, as the correction code does not always
strive to reach the desired buffering level. If the changes are small enough the
buffer continues to shrink or grow until we get close to the edge and then a
much more abrupt correction change is applied, something noticable by ear.

Differential Revision: https://phabricator.services.mozilla.com/D89775
2020-09-15 14:42:23 +00:00
Andreas Pehrson
ad73c3b7a4 Bug 1656438 - Avoid overflowing the internal AudioResampler ring buffer. r=padenot
Depends on D89773

Differential Revision: https://phabricator.services.mozilla.com/D89774
2020-09-15 11:57:14 +00:00
Andreas Pehrson
df5c09c288 Bug 1656438 - Handle null chunks in AudioVerifier. r=padenot
Depends on D89772

Differential Revision: https://phabricator.services.mozilla.com/D89773
2020-09-15 11:57:07 +00:00
Andreas Pehrson
6bdac502bc Bug 1656438 - Run all MockCubebStreams off the same fake audio thread to avoid unwanted drift. r=padenot
With this patch, there is a fake audio thread present on a MockCubeb context as
soon as one MockCubebStream is running under that context. When the last running
MockCubebStream is stopped, the fake audio thread is joined and unset.

This adds a tad bit of complexity but results in zero unwanted drift between
MockCubebStreams under the same MockCubeb context. This is essential for stable
CrossGraphTrack tests.

A side effect of this is that the drift factor of a MockCubebStream does not
affect the interval at which data is processed, but rather the amount of data
processed each interval.

This patch also allows us to process data with virtually no wait time between
iterations (as opposed to wall-time 10ms-waits), for (much) speedier tests.

Differential Revision: https://phabricator.services.mozilla.com/D89772
2020-09-15 14:42:20 +00:00
Andreas Pehrson
c543f24c3a Bug 1656438 - Remove unused LOG macro from MockCubeb.h. r=padenot
Depends on D89770

Differential Revision: https://phabricator.services.mozilla.com/D89771
2020-09-15 11:56:50 +00:00
Andreas Pehrson
ef40851a44 Bug 1656438 - Add license info to MockCubeb.h. r=padenot
Depends on D89769

Differential Revision: https://phabricator.services.mozilla.com/D89770
2020-09-15 11:56:43 +00:00
Andreas Pehrson
ab120121e2 Bug 1656438 - Rid MockCubeb.h of using namespace lines. r=padenot
Depends on D89768

Differential Revision: https://phabricator.services.mozilla.com/D89769
2020-09-15 11:56:35 +00:00
Andreas Pehrson
cb51a3625a Bug 1656438 - Spell check and nits. r=padenot
Depends on D89767

Differential Revision: https://phabricator.services.mozilla.com/D89768
2020-09-15 11:56:28 +00:00
Andreas Pehrson
51f32e0fa7 Bug 1656438 - Test odd rates in TestAudioDriftCorrection. r=padenot
Depends on D89766

Differential Revision: https://phabricator.services.mozilla.com/D89767
2020-09-15 11:56:20 +00:00
Andreas Pehrson
ca44745d51 Bug 1656438 - Add a warning when running out of resampler buffer. r=padenot
Depends on D89765

Differential Revision: https://phabricator.services.mozilla.com/D89766
2020-09-15 11:56:12 +00:00
Andreas Pehrson
7d1e1b8572 Bug 1656438 - Guard against making drift worse when the desired buffer is large. r=padenot
The resampled source clock can become negative with a large desired buffer and
a small current buffer. This patch clamps it above 1 so we never drift-correct
in the wrong direction.

Differential Revision: https://phabricator.services.mozilla.com/D89765
2020-09-15 14:42:18 +00:00
Andreas Pehrson
e74236a8b6 Bug 1656438 - Verify that the current buffer is close to the desired buffer in length. r=padenot
Depends on D89763

Differential Revision: https://phabricator.services.mozilla.com/D89764
2020-09-15 11:55:57 +00:00
Andreas Pehrson
37067e3c55 Bug 1656438 - Get rid of NUM_OF_FRAMES from MockCubeb. r=padenot
This allows us to configure the number of frames more dynamically, and update it
on the fly to simulate drift.

Differential Revision: https://phabricator.services.mozilla.com/D89763
2020-09-15 14:42:16 +00:00
Andreas Pehrson
482c467669 Bug 1656438 - Update the resampler after a fixed duration instead of a fixed number of iterations. r=padenot
This makes the tests more similar to real-world scenarios, where the duration of
an iteration may vary.

Differential Revision: https://phabricator.services.mozilla.com/D89762
2020-09-15 14:42:13 +00:00
Andreas Pehrson
e1b75a875c Bug 1656438 - Fix the unit of the desired buffering. r=padenot
Comments mention 5ms, but code says it's 50ms.

Differential Revision: https://phabricator.services.mozilla.com/D89761
2020-09-15 14:42:11 +00:00
Andreas Pehrson
c8c26f0a4d Bug 1656438 - Take the desired buffering as parameter in ClockDrift, AudioResampler, and friends. r=padenot
This makes us able to write tests for different buffer lengths.

Differential Revision: https://phabricator.services.mozilla.com/D89760
2020-09-15 14:42:09 +00:00
Andreas Pehrson
4d7b23d775 Bug 1656438 - Report pre-buffer as current buffer size before receiving data in DynamicResampler. r=padenot
Without this patch we return 0, and that can be misinterpreted by
AudioDriftCorrection so it thinks we have drifted a lot. This becomes more
obvious with a large desired buffer.

Differential Revision: https://phabricator.services.mozilla.com/D89759
2020-09-15 14:42:06 +00:00
Andreas Pehrson
38e987ad7e Bug 1656438 - Make const DynamicResampler members public. r=padenot
Depends on D89757

Differential Revision: https://phabricator.services.mozilla.com/D89758
2020-09-15 11:55:07 +00:00
Andreas Pehrson
7c067607e0 Bug 1656438 - Test CrossGraph ports with a multi-second buffer. r=padenot
The buffer size is exposed as a pref, so it better have a bit of test coverage.

Differential Revision: https://phabricator.services.mozilla.com/D89757
2020-09-15 14:42:04 +00:00
Andreas Pehrson
1346d4bb48 Bug 1656438 - Elaborate on CrossGraphPort tests. r=padenot
This patch lets us pass in a drift factor to allow for testing of the drift
correction code. It also enables output verification for the CrossGraph tests.

Differential Revision: https://phabricator.services.mozilla.com/D89756
2020-09-15 14:42:01 +00:00
Andreas Pehrson
5366c0d06e Bug 1656438 - Prune chunks after 50ms without imagining the samplerate. r=padenot
In a CrossGraphReceiver there is 100ms worth of buffering in AudioChunks.
Without this patch the graph will buffer 2400 frames in each track before
removing data from them. If a graph contains a CrossGraphReceiver and runs at a
sample rate lower than 24000Hz, that CrossGraphReceiver will run out of chunks
and an assertion failure happens at best.

Differential Revision: https://phabricator.services.mozilla.com/D89755
2020-09-15 14:41:58 +00:00
Andreas Pehrson
d85a980ee9 Bug 1656438 - Do output verification in the gtest body. r=padenot
Depends on D89753

Differential Revision: https://phabricator.services.mozilla.com/D89754
2020-09-15 11:54:37 +00:00
Andreas Pehrson
9962c2e6af Bug 1656438 - Only raise the FramesProcessedEvent once there is no silence. r=padenot
Because an audio driver starts out with its fallback driver running the graph,
we might use unnecessary amounts of silence for the verification. Especially
with the `GoFaster()` mode turned on, as the fallback driver's thread runs
rarely compared to how often we are feeding the graph audio data from the
MockCubebStream.

Differential Revision: https://phabricator.services.mozilla.com/D89753
2020-09-15 14:41:56 +00:00
Andreas Pehrson
0d8d6e6a2d Bug 1656438 - Remove MockCubeb::GetCurrentStream. r=padenot
It is a fragile and timing-sensitive way of getting the stream.

Differential Revision: https://phabricator.services.mozilla.com/D89752
2020-09-15 14:41:54 +00:00
Andreas Pehrson
4b2a2e6ed7 Bug 1656438 - Remove dependency on GMPTestMonitor in TestAudioTrackGraph.cpp. r=padenot
Depends on D89749

Differential Revision: https://phabricator.services.mozilla.com/D89751
2020-09-15 11:54:14 +00:00
Andreas Pehrson
09e83dfc41 Bug 1656438 - Simplify TestAudioTrackGraph.CrossGraphPort. r=padenot
Depends on D89748

Differential Revision: https://phabricator.services.mozilla.com/D89749
2020-09-15 11:54:06 +00:00
Andreas Pehrson
899f122462 Bug 1656438 - Simplify TestAudioTrackGraph.SourceTrack. r=padenot
Depends on D89747

Differential Revision: https://phabricator.services.mozilla.com/D89748
2020-09-15 11:53:59 +00:00
Andreas Pehrson
102d6e1cc5 Bug 1656438 - Simplify TestAudioTrackGraph.ErrorStateCrash. r=padenot
Depends on D89746

Differential Revision: https://phabricator.services.mozilla.com/D89747
2020-09-15 11:53:52 +00:00
Andreas Pehrson
ec3f42e3a3 Bug 1656438 - Simplify TestAudioTrackGraph.NotifyDeviceStarted. r=padenot
Depends on D89745

Differential Revision: https://phabricator.services.mozilla.com/D89746
2020-09-15 11:53:44 +00:00