This is in preparation for adding the rapid add/remove test from bug 1295761.
Changes:
- Added `tree.exists(item)` to fix an issue where `selectTreeItem()` was caled for an item that did not exist and then waited for an `store-objects-updated` event. It only ever received this event due to errors when writing tests.
- Renamed `StorageUI.onUpdate()` to `StorageUI.onEdit()` and changed it's event name to `store-objects-edit`.
- Changed tests to use `store-objects-edit` where appropriate.
MozReview-Commit-ID: IAem8Penrf9
--HG--
extra : rebase_source : b818f8647958ad0688954fe5028f8d57aa119c33
This currently happens in the browser console. The packet we receive
for console.count calls does not have the counter property which we
usually consume to display the counter label and data.
Here we prevent adding such messages, before a follow-up fix which should
be about adding those information in the packet.
For the record, it was not working either in the old frontend.
MozReview-Commit-ID: 1SiFgAHIziI
--HG--
extra : rebase_source : 46eb71dc69acf56df6577ebbb396365d395ae62a
In about:debugging's browser_addon_reload.js test, we would request a reload
without waiting for it to reply. This led to the RDP connection closing before
the reply could be sent, triggering later errors.
For better test correctness, we now emit an event on reply and the test waits to
receive it before proceeding.
MozReview-Commit-ID: Jfps7MJ6Pzo
--HG--
extra : rebase_source : 2287c729062e3ed9a1f4527b192a672cff8c18c6
By moving only the rejections that actually still apply into each test and out
of the shared head file, we are much more likely to notice new instances and
catch them when writing and editing tests in the future.
Bug 1018184 can be used to actually resolve these issues.
MozReview-Commit-ID: Qb71PsuutB
--HG--
extra : rebase_source : 7056bbf9fcd76ffe00015119d811db0bd788aa59
Remove the last sync promises from the server.
This causes server replies to be sent later than before, potentially later
enough that the connection has since been closed. We now throw errors in such
cases.
MozReview-Commit-ID: 2x213g7poH5
--HG--
extra : rebase_source : 2b83c32aa79e2365159ee20f4839a5ac645559b4
This required to add a couple new cases for require-hacker.
MozReview-Commit-ID: 9Qon1PNjdF7
--HG--
extra : rebase_source : 53808af32a325c1985443b9a26953b4065f7c835
So far, we are drawing the entire line area, and then cutting out the various
margin boxes from each item, in order to show where justify-content applies.
This is dangerous because that means clearing pixels in a canvas where we're
drawing tons of other stuff, and it's easy to accidentally clear unwanted
things.
Instead, now we just draw the justify-content where needed only.
MozReview-Commit-ID: LJN6Fl1by4l
Those ensures that we do handle them properly and that the state
is cleaned up as expected when they are removed.
MozReview-Commit-ID: 9PNuaHcFxSv
--HG--
extra : rebase_source : f6f7555e26dc6174c18732685ec161920bc4d51a
Add a redux action to handle the event and clear private messages from the store.
A new `cleanState` function was extracted from `limitTopLevelMessage` so we can
use it in this case.
MozReview-Commit-ID: Hp6o9iZAbZ7
--HG--
extra : rebase_source : 1427c9f47bd078353fdaa61d94a394155d31ab61
Populate this from the different packet types and update stubs.
MozReview-Commit-ID: 4rrZBRdtOa4
--HG--
extra : rebase_source : 55458ef7f104803089391ebb8143342111c92ba3
This was caused by an innerHTML assignment. Switching to replaceWith + cloneNode
does the trick.
MozReview-Commit-ID: 4pnIijKoJHU
--HG--
extra : rebase_source : 9a960a74c38b51c8ad549187549b383b916aa45e
After moving shared-head.js, linting is activated because the new path is not
ignored.
MozReview-Commit-ID: GCLDfgJ7WCb
--HG--
extra : rebase_source : 598b89a4216e3876831afcfd885464f2b4e75244
Move frame-script-utils.js into shared/test since it is a test only file. In
addition, it's removed from jar.mn so it won't be part the file we ship. Test
manifests can use the absolute path syntax to make it accessible in new
directories.
MozReview-Commit-ID: 5sKYvv2rsJs
--HG--
rename : devtools/client/shared/frame-script-utils.js => devtools/client/shared/test/frame-script-utils.js
extra : rebase_source : 8c4d77c37cacdae36d17102b4dbf1222ec1fbd8a
Use `loadFrameScriptUtils` from shared-head as a central utility for loading the
frame script utils helper. This means less stray references to the utils file's
path across our tests.
As part of this, I went ahead and converted Canvas Debugger, Shader Editor, and
Web Audio Editor to shared-head, as that seemed like the best path to reduce
duplication.
(I left one extra path reference in profiler-mm-utils.js as-is, since it's a
module, so shared-head is not easily usable there.)
MozReview-Commit-ID: AKbZt8Jo0GM
--HG--
extra : rebase_source : e70b29153ef8d96d7026bc3abd0fb0d2306849bc
