Not a huge amount needed changing in this one... changed paths, removed references to bug numbers, switched to async / await and used the new method to check for messages.
MozReview-Commit-ID: 2pefVnMozXq
--HG--
extra : rebase_source : fe4b0fc52bf8a60d566314920baa75aaf8458d9d
There wasn't anything done for this kind of resources, so the URL looked
like resource://devtools/shared/base-loader.js -> resource://devtools/path/to/file.js
and was causing issue in the onClick handler.
MozReview-Commit-ID: GUJOpjDX1zG
--HG--
extra : rebase_source : 745ab61678772acdc7794719ae1c3d85ee1475c4
Add a defaultURL the debuggee window will navigate too in the config (new
feature of devtools-launchpad).
MozReview-Commit-ID: 2ppGG6paFnP
--HG--
extra : rebase_source : 70b513b11cecd8f1a4238ddf7bbfd2e30ae94867
Rebased due to failing tests on try... built on a failing base.
MozReview-Commit-ID: BiC1pWeml2N
--HG--
extra : rebase_source : 4e57102655d930737950dd571b16632c412e0a3d
Turns out that this is a redux issue that was fixed by the redux update (1441147).
Of course, it is bad practice to manipulate state from a non-react component but if there is no warning we can let it go.
MozReview-Commit-ID: 9Ssus7ypvm2
--HG--
extra : rebase_source : 599dfbdcc2a97c6936499b3088400c069c98e022
This test will cause timeout once we have a microtask checkpoint at the end of
a callback (bug 1193394). Fortunately the test is for the old debugger UI that
we don't ship anymore, so we can just skip it.
MozReview-Commit-ID: AjB1YSNyToD
--HG--
extra : rebase_source : 382dd2533a78cafa41ab4eeea5475d97f65ff6b9
The overlay elements with children of editMenuOverlay.xul are moved into
include files (editMenuCommands.inc.xul and editMenuKeys.inc.xul). For
the other single elements in the overlay, the attributes are inlined
wherever they are used.
MozReview-Commit-ID: 792cuzUvQxT
--HG--
extra : rebase_source : 58e4c05bde16cee873d37c6198de102d048499c2
Importing this object is unnecessary after the updates to the WebIDL console from Bug 1425574
and the follow-ups blocking Bug 1430810. There are still callers that access Console.jsm
to create custom ConsoleAPI objects, but those will be handled separately.
MozReview-Commit-ID: 9ojFxtkpPId
--HG--
extra : rebase_source : 971bf99f709b8d2afe300f3693665724f747aa5e
We keep the XBL binding around for <content>, <constructor>, and <destructor>. This can
eventually be migrated to a Custom Element once we have platform support, but in the meantime
this is a way to get the many thousands of LOC into a JS class.
MozReview-Commit-ID: 1dCQp527yF9
--HG--
extra : rebase_source : 26b833413bab71168aa15e03f0f3803884be3f6b
extra : amend_source : 150cef6748ca8a9e819de0c674fac5966dd574cf
This is enough to get the stylo-enabled build green.
There's still some orange in WPT with stylo disabled (due to interfaces not
exposed and that) that I'll update tomorrow.
Will send a different patch on top of this for that, though I'll land together.
MozReview-Commit-ID: CsN5CM93RUz
This patch does a few things:
1) It removes the symantecRoot and symantec_affected certs from build/pgo/certs'
DB.
2) It upgrades that DB from the old format to SQLite (and this 8/3 to 9/4).
3) It adds a new cert "imminently_distrusted" to that DB for the bc test.
4) It changes the Subject of the immient distrust test to only have the CN
field: this is because certutil reorders C to come after CN, and just like
with the real Symantec certs, I had put C first. So rather than deal with
importing the end entity for the pgo tests, I decided to just make things
simple and change the tested subject.
5) Finally, it re-enables the test that was disabled in Bug 1434300.
MozReview-Commit-ID: Bt2RKyInJje
--HG--
rename : build/pgo/certs/cert8.db => build/pgo/certs/cert9.db
rename : build/pgo/certs/key3.db => build/pgo/certs/key4.db
extra : rebase_source : efceb67ae16f0af617bbd8bec201d52eee0f467d
The hack caused bytecode for block declaration instantiation to be assigned the
location of the first statement inside the block. Unfortunately it made the
source view of the debugger client seem out of sync with the Scopes panel: when
paused after hitting a breakpoint on that line or stepping there, the source
panel showed our location as being inside the block, but the Scopes panel did
not show a block scope.
Two server tests required fixes (also r=jimb, in a separate patch in the same
bug).
test_stepping-08.js assumes that stepping into a function stops at the first
statement in the function. This is usually true. However, now we are removing a
hack, such that our actual behavior for this *particular* function is to stop
at the opening curly brace. This causes the test to fail, without anything
really being broken.
The test is intended to test the interaction of stepping and breakpoints, so
the fix that stays truest to the purpose of the test is to change the debuggee
here to a function with no prologue instructions, so that we don't stop at the
opening brace.
test_blackboxing-01.js is a similar story.
--HG--
extra : rebase_source : 7afc6cc039f313889ee08cdd93ce114691efa1e9
extra : histedit_source : dc274b7cefbb96574c8207a78db05d80238d291d
The onclick handler of the toolbox close button looked like this... spot the deliberate mistake:
```
onClick: () => {
closeToolbox();
focusButton(closeButtonId);
},
```
So we were closing the toolbox and then trying to focus the toolbox's close button.
There is also an obvious race condition with setState inside the toolbox controller not using a callback even though the next line calls a function that uses this.state, which could cause intermittent issues.
MozReview-Commit-ID: 9VRcZw4RvE5
--HG--
extra : rebase_source : 17c21aafe5a72042c23472342c53fd730784a5ae
This is as simple as an upgrade can be. Everything still appears to work but we should ensure try is green before landing.
MozReview-Commit-ID: KjH6nnuK4EY
--HG--
rename : devtools/client/shared/vendor/REDUX_UPGRADING => devtools/client/shared/vendor/REDUX_UPGRADING.md
extra : rebase_source : 12c88e1cad10fc08fcfb2cb829f9969b83b37ca1
I believe this fixes all warnings except for one. This warning appears the first time the memory panel is selected:
"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types
in MemoryApp (created by Connect(MemoryApp))
in Connect(MemoryApp) (created by bound createElementWithValidation)
in bound createElementWithValidation
in Provider"
This appears to be an issue with `devtools/client/memory/app.js` but I will log a new bug for this.
MozReview-Commit-ID: 341zdQyfgrN
--HG--
extra : rebase_source : ce25569407b89a7547e4db688373b202d17d2475
We'll stop dispatching keypress event for non-printable keys and key
combinations at least in web content. This means that widget of
devtools/client cannot be tested with loading them into tabs with mochitest
browser chrome. Fortunately, they are cleanly independent from other module's
keypress event listeners. So, we can make they use keydown event to handle
non-printable keys and key combinations.
MozReview-Commit-ID: 6fNSsGi9VbQ
--HG--
extra : rebase_source : d8c201d2233dd1c08a87ad5123aaa2942af643d7
To accomplish this, the added aria-pressed attribute turns the buttons into toggle buttons, and the one that is visually selected, gets the "true" attribute value, others are "false". That way, the screen reader and other assistive technologies will indicate that this is the selected or pressed button.
MozReview-Commit-ID: L2lcw2wOyYw
--HG--
extra : rebase_source : 1c0ad241319f50c34c120ce05b85e795e9a5b080
This will make it easier to include xul chunks with the preprocessor.
MozReview-Commit-ID: F3aF6CqqcSK
--HG--
extra : rebase_source : ccd0cb99ac9f1114d28cd749ec439c907d13836f
The prefix property was already on the packet, so all we had to
do was to support it. Which means:
- retrieve the property in the packet and pass it to the message
- when prefix exists, add a dom element with a custom style
- search in prefix when filtering.
We add a couple of mocha tests with a stub packet to make sure we
handle those cases like we should.
MozReview-Commit-ID: KFkt685AdfE
--HG--
extra : rebase_source : d73e96545400d5bb83c51953d1b75ac8e03ca959
This whole test neede rewriting. Beginning with the new console frontend we no longer block the object inspector in the browser console when `devtools.chrome.enabled === false`.
MozReview-Commit-ID: 9H5FvIbkYzk
--HG--
rename : devtools/client/webconsole/new-console-output/test/mochitest/browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js => devtools/client/webconsole/new-console-output/test/mochitest/browser_jsterm_hide_when_devtools_chrome_enabled_false.js
extra : rebase_source : a649b20be57d394ff24c5f2bafaf1d2b8687ff40
The prefix property was already on the packet, so all we had to
do was to support it. Which means:
- retrieve the property in the packet and pass it to the message
- when prefix exists, add a dom element with a custom style
- search in prefix when filtering.
We add a couple of mocha tests with a stub packet to make sure we
handle those cases like we should.
MozReview-Commit-ID: KFkt685AdfE
--HG--
extra : rebase_source : 71f13c07921b1d60df1a0c113d1e3fb440923ec2
The first time RDM is opened after this, show a notification explaining that a
reload is needed to apply certain emulation features.
MozReview-Commit-ID: 26GMbhT5MUo
--HG--
extra : rebase_source : 069ab687830faf29e5fe37b408628c0cd85e1464
This adds a menu to the RDM global toolbar to allow the user to control whether
the page reloads in response to various state changes.
This also changes the default behavior to _not_ reload, so that we avoid losing
changes that might have been made in DevTools.
MozReview-Commit-ID: 86h5cB5dify
--HG--
extra : rebase_source : ebb4f86da4407772704a9fc06b4083b39cf61290
The first time RDM is opened after this, show a notification explaining that a
reload is needed to apply certain emulation features.
MozReview-Commit-ID: 26GMbhT5MUo
--HG--
extra : rebase_source : 6b043a6465687ccae23eb2cf0619b3e82ca62c5f
This adds a menu to the RDM global toolbar to allow the user to control whether
the page reloads in response to various state changes.
This also changes the default behavior to _not_ reload, so that we avoid losing
changes that might have been made in DevTools.
MozReview-Commit-ID: 86h5cB5dify
--HG--
extra : rebase_source : 0d1598bd0ad066eaffdc23d4c970c64f368afa04
We also add a test to make sure we have the expected context menu
on log and network message in the browser console.
MozReview-Commit-ID: E2woQj5clJF
--HG--
extra : rebase_source : a3de488ed61e8124ad743983eeb23791df911716
Currently, if you open the Inspector on some page, then enter RDM, the Inspector
will "reboot" (reload all panels) because it believes the document has reloaded.
However, it's not really true in this case. Instead, it's an artifact of the
pagehide / pageshow events that are triggered when swapping frames like RDM
does. Bug 1438697 adds a chrome-only property that we then use here to
distinguish this case.
MozReview-Commit-ID: Ks42QayVnij
--HG--
extra : rebase_source : 91739a5db2774073e723b1daf43bc5242755fc43
The browser console test for imminent distrust relies upon certs inserted
into build/pgo/certs/cert8.db and key3.db [1], and seemed angry when adding new
certs with certutil bumping those to cert9 and key4 formats. Since time is
getting to be of-the-essence with Bug 1434300, I've filed Bug 1439378 to re-
enable this test post-landing.
[1] https://hg.mozilla.org/mozilla-central/rev/98b1272e170c
MozReview-Commit-ID: I4SIiqc5AqH
--HG--
extra : rebase_source : 06295cbed14f2a793162073e707e14026ea69625
We weren't doing the right transform for cached messages, and thus
we weren't creating the ConsoleMessage with the correct properties.
This is now fixed and a mocha test is added to make sure we don't
regress on this.
MozReview-Commit-ID: ACOCPF06GK2
--HG--
extra : rebase_source : 029fe31b7343f4032ea48a8629bae8d8c0a87e62
It is totally valid to declare an empty style in styled console.log.
But we were appending a space after a string with empty style because
we were checking that the style wasn't falsy, and empty string is falsy.
We fix that by checking against undefined.
A test is added to make sure we don't regress that.
MozReview-Commit-ID: EOQ49Gt0Cr9
--HG--
extra : rebase_source : bf711afa76dd784d3cf1f973c47e4aa139d5bc5e
In the old frontend `this.window.close` worked since webconsole.xul was used for both the web console
and browser console. The new frontend is implemented in HTML (webconsole.html) but for the browser console
we wrap that in a XUL document (browserconsole.xul) to support window management and other XUL features.
So when the HTML frontend receieves cmd/ctrl+w, we now call the `close` function for the XUL window instead.
MozReview-Commit-ID: 5j9rimTC2f8
--HG--
extra : rebase_source : dc1b444b22a2c8214e4dbf21a3a4972be2249fc5
The browser console test for imminent distrust relies upon certs inserted
into build/pgo/certs/cert8.db and key3.db [1], and seemed angry when adding new
certs with certutil bumping those to cert9 and key4 formats. Since time is
getting to be of-the-essence with Bug 1434300, I've filed Bug 1439378 to re-
enable this test post-landing.
[1] https://hg.mozilla.org/mozilla-central/rev/98b1272e170c
MozReview-Commit-ID: I4SIiqc5AqH
--HG--
extra : rebase_source : 6cac70e494c284314bf62d2e0c856a0d9a98831e
Track connection status at various points during Browser Toolbox startup. If
connecting takes a long time or triggers an error, the status panel is revealed
with the most recent message displayed.
MozReview-Commit-ID: H8240rv3KRe
--HG--
extra : rebase_source : 7c2c10c710095ede7d1b9c1ac87ca21bd3deb969
To fix this, we fallback to viewSource when we don't have access to the toolbox,
which is what was done in the old frontend.
MozReview-Commit-ID: JCcprTlViMi
--HG--
extra : rebase_source : ab13b539938a6572ebd9ceaedc23f954f4cb2be2
The mocha test are broken because we mock Services.pref,
and the assumptions we make in the mock are no longer valid.
Since we do have a fully functional replacement for Services
in devtools-modules, let's use it in our test.
Which means we need to introduce a mock for localStorage,
since it's what the devtools-modules Services uses, and helper
functions to replace what was in the Services mock.
MozReview-Commit-ID: KLHERfSa1Il
--HG--
extra : rebase_source : b1b5bc2d35624677fc241194ab1a49502cafe31d
This allow us to manage different sets of preferences for
the console and the browser console. The util object is
passed to the actions through a custom thunk middleware.
MozReview-Commit-ID: 6IQLBqX7KMN
--HG--
extra : rebase_source : 9dc60df24d0514c8bd0aac7655483eb3d026a16a
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.
MozReview-Commit-ID: De4enbjux3T
--HG--
extra : rebase_source : 2296b84bff8e22f01eeb48cd8614fac5db11136a
Along with removing the view source standalone windows and prefs this patch:
1) Re-structures several of the view source tests that were only testing the old
standalone windows to now test view source in tab.
2) Adds support viewSourceUtils.viewSource() to open a browser window when there
aren't any open (for browser toolbox view source).
3) Cleans up some of the API for viewSourceUtils and removes the old deprecated
ways of calling it.
MozReview-Commit-ID: DI6sgZwbCf
--HG--
extra : rebase_source : 64677186122f74ab95912d5f3f173cf37472458a
