Extracted a shared helper to open the browser context menu and choose
the 'inspect element' item. This helper works with e10s.
Adapted it a little bit so it waits for the right events in order to
make sure the inspector is ready.
This also involved modifying inspectNode in nsContextMenu.js to make it
wait until the node was selected and the node was ready.
Used this in browser_inspector_initialization.js,
browser_rules_content_02.js and browser_markup_keybindings_04.js
Also removed a now useless inspector-updated event that was trigger from
the animation-inspector panel in some situation. This was left behind
from a long time ago but didn't serve any purpose anymore.
MozReview-Commit-ID: 5bFHxxrwxhL
--HG--
extra : rebase_source : cb30c7e47605f59674f2344dba10af814172333d
testing/marionette/EventUtils.js has been converted to a JS module in
testing/marionette/event.js and its API has changed. It was originally
a copy of testing/mochitest/tests/SimpleTest/EventUtils.js, and it should
be fine to use the original instead.
MozReview-Commit-ID: Exi9d5rEeOz
--HG--
extra : histedit_source : 999974c56edeecb1313d2b1050c8911473c02292
extra : rebase_source : 77656e161e67423cd44d2071e4118e824cc64363
extra : commitid : 5SGljZj56xm
extra : source : 18d54b8d4ae8348d62070b57574858f0824474ad
extra : amend_source : 968c4d6c4959f5ba502b846294aabe40296d6541
EventUtils.js previously allowed you to override the Window object
reference through passing it as an optional argument to its functions.
This change fixes certain uses of implicit globals that reside on Window.
MozReview-Commit-ID: EJT8iIs85ej
--HG--
extra : rebase_source : b7b226c441f7a59a0325f70995ec05a652ab20ed
extra : source : 98b6d0c053c03b848d2b6f5d1a9a97dbb74d9ed1
extra : histedit_source : 4f4761ebd4158cc86a60c28c820ff2c128603352
There should be no functional changes here.
MozReview-Commit-ID: 360y6vHYuC3
--HG--
extra : histedit_source : 3a058d33224c85f8896ea91978ef9443a64f6342
extra : rebase_source : 778e0e5ac135aa3be86aef149d82ec9a55d8c247
extra : commitid : B1JkBddKDeG
extra : source : 30c8ec933737ed7fde559d50815d3f7222067e3d
extra : amend_source : c92cd096caf9914e9cecf1ed3fe58e404f5b7477
extra : intermediate-source : c29a348930a4e07be3c359b937271ece23a5929d
This does not appear to be in use.
MozReview-Commit-ID: B4M335Lb1UM
--HG--
extra : histedit_source : 241a896d0701c529cf56636eff567211198839cb
extra : rebase_source : 0b30f291ed1aee3f4073f2fea47ac4d9c6a6a576
extra : commitid : I8NVDyxCC0e
extra : source : 22321e6b65e987a76e42f880c8aa5a0427052259
extra : intermediate-source : 3b9e9a027fa7f020ac80c060938488f53f61049c
This change removes almost all the remaining uses of loadSubScript and
global scope pollution. The only remaining use is for common.js, which
is resolved by a later bug for evaluating scripts.
MozReview-Commit-ID: 96h0yLElauq
--HG--
extra : histedit_source : 70f70a8aeffef3fca18addfa3fca575a9128e11a
extra : rebase_source : c251c58a7a086c606d3d3941adfeee26ecc49504
extra : commitid : 8XlX4zVZQUN
extra : source : 6bb93562a57656e6cc744c3c901a5ec80f9ec4d8
extra : intermediate-source : ad5bf32d8fef351a0bc4d6249bd16a34aa83f548
To simplify the dependency chain and reduce the number of duplicate
functions in Marionette, a number of functions have been removed from
interactions.js and added to elements.js. This makes them more easily
re-usable and works around a circular dependency issue.
MozReview-Commit-ID: TZc3VZzHqM
--HG--
extra : histedit_source : 06b82234371ca8cd6bb0ede9cbf03f848fc66d82
extra : rebase_source : da99b4329baba3fa8a604b9b2952692568b96a75
extra : commitid : BTgnO71SGbB
extra : source : 5da7628c376765842c013f90566d4264f9e9312a
extra : intermediate-source : 68a6dda373d2efffd8cf76103a80f1003c969093
Through some very clever hacking of the arguments to each of the atoms,
we are able to contain this in a JS module: Atoms normally extract their
arguments directly from the function scoped `arguments' variable, but
by explicitly naming `window' as the last argument in the functions'
prototype we are able to set the `window' variable used inside.
This is obviously a big hack, but it encapsulates the atoms and we are
moving away from atoms in the long term.
MozReview-Commit-ID: KGO77fjRN2d
--HG--
extra : histedit_source : aaa2005b8872127d8314fd6ad5c15b91d09555b9
extra : rebase_source : 1dbc1d1b97c6ca3abc3e9b78ce54c0a5a5883f6e
extra : commitid : 6AkmEPFP2Y4
extra : source : ee7ee24cc65e1b0b316963cc7963425f254e67cc
extra : intermediate-source : e41a5b41859a904042168dbbc9e5b983a5688b98
testing/marionette/sendkeys.js has been merged into the
new testing/marionette/event.js module, together with
testing/marionette/EventUtils.js.
There is a lot of functionality still left in this module that we can
probably remove, as it is not in use by Marionette.
MozReview-Commit-ID: GrjNuK9VPjp
--HG--
rename : testing/marionette/EventUtils.js => testing/marionette/event.js
extra : histedit_source : f2fea53f3c7a5f49d1f0ef6f2bef4b98aa3566f2
extra : rebase_source : 6094b11b4325b279dc40b844df327d61a9b90ca6
extra : commitid : GvNeDeClc50
extra : source : 4b2a5ee7199efd86e2b8db1f80c492378649f8dc
extra : intermediate-source : 048d7007075192bad292d312d65920b27aaf6a1f
error.wrap acts as a no-op if it is passed a prototype which is already
of the WebDriverError prototypal chain.
MozReview-Commit-ID: Gd9kUEvsgNv
--HG--
extra : histedit_source : a6e620e3e4b6bfa4e1d77df48eaab59ffbc3cdce
extra : rebase_source : a94ae7fff63530a4cc4d1875bb4894657834ecb0
extra : commitid : HObqpKV7a9s
extra : source : d75ad1397656e43d22d0d69211df9fce3a667f0d
extra : intermediate-source : eff85dc0eaa9da4c4dff306cdb9a7474df29ccf1
Generally, Error prototypes that are not based on WebDriverError must
be wrapped so that they can be serialised across the AsyncMessageChannel.
MozReview-Commit-ID: EtkpEOBhrST
--HG--
extra : histedit_source : c35a686b6b9cea4ae50d0d63223f4cdde6f6e4a2
extra : rebase_source : 4aad87845982cc81fec375ae9f63223a58003aec
extra : commitid : 825ScXhXQSy
extra : source : 1f5e37f8e44641e5434d8393f307f2ea4e80cdc6
extra : intermediate-source : dc6460e0f336c151be27bd124935b52361ea9557
Due to a previous programming error, error.isError only recognised
the base Error prototype. It must also test for the other built-in
prototypes, such as TypeError et al.
MozReview-Commit-ID: HLkiOAg0Jl1
--HG--
extra : histedit_source : 77fd0e6b6471b18528c27954e6348f93fc520d64
extra : rebase_source : 0e6d2085c37f2a2646c560b10e0c35eead6fcd3a
extra : commitid : F50Xhg2Q86e
extra : source : aec0a01666851a1e03dcb139e1766bae0c1b0fd7
extra : intermediate-source : 36526a2e8b0071b9f51cc30d5b6e0b5c345ec437
