Data review request comment:
1. What questions will you answer with this data?
We want to know when the user exit on-boarding. So we can start to A/B testing on other contextual hints. We don't want to overlap them.
2. Why does Mozilla need to answer these questions? Are there benefits for users?
We need this information to know if users had done on-boarding
3. What alternative methods did you consider to answer these questions? Why were they not sufficient?
I can't think of any.
4. Can current instrumentation answer these questions?
No
5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
I can't find one for Android
6. How long will this data be collected? Choose one of the following:
We want to permanently monitor this data. (Joe Cheng)
5. What populations will you measure?
All Fennec users
6. Which release channels?
All channels
7.Which countries?
All countries
8. Which locales?
All locales
9. Any other filters? Please describe in detail below.
No
10.Please provide a general description of how you will analyze this data.
We'd like to use Leanplum to cross-reference those events
11.Where do you intend to share the results of your analysis?
We'll use it internally
MozReview-Commit-ID: 2s7Hnc97dhp
--HG--
extra : rebase_source : 81736b5222490347fbc275fc8c8c06a4a2ee19c5
/builds/worker/workspace/build/src/layout/xul/nsMenuFrame.cpp r=backout a=backout on a CLOSED TREE
--HG--
extra : amend_source : e09bf154093728898ad2c27dd185108f9ff3b009
We no longer call the function directly. It has been replaced by
nsStyleDisplay::GetTransitionCombinedDuraion(uint32_t).
MozReview-Commit-ID: 9wZExWPmnyG
--HG--
extra : rebase_source : dff6b4e686578e7c79e16148ab3ab63b40444be7
This is also a prerequisite to use repeated values for the used value.
Note that each count should never be zero since their initial value is 1 and
we never set zero length property value to the member.
MozReview-Commit-ID: 44ZMhopuK6o
--HG--
extra : rebase_source : 6284b2b5beb43bf78c16e0c39e95ec0e5118ed14
This is a prerequisite to use repeated values for the used value of the each
animation property instead of the computed values.
In a subsequent patch in this patch series, the timing function will be replaced
with the one which may be a repeated value in computed animation timing function values list.
MozReview-Commit-ID: GOKHE3MH0Ue
--HG--
extra : rebase_source : ecc270eddb648d2915292ec3e219f4e349c6047c
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1420928
Source-Repo: https://github.com/servo/servo
Source-Revision: 97e39797418486196e9685931e01a3d1b563f93e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : b6829e2a84c8b6d7cd037d6b7cacd40769caca7b
<!-- Please describe your changes on the following line: -->
---
Makes Contain::parse slightly simpler, as discussed in #19682
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#19682 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because refactoring
Source-Repo: https://github.com/servo/servo
Source-Revision: 0393f9d231ce146761ed6b6b635ac040adfb07f3
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 80573b78a8a266eec84f2b72ac157491219425c8
It is bad to modify the array while iterating it.
MozReview-Commit-ID: JbpoRmM7GqP
--HG--
extra : rebase_source : 92523a0741aa6014808b182954f653fce54161fd
