Commit Graph

687528 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
2951992c4e Bug 1608729 - Initialize some variable in nsWindow.cpp. r=stransky
GCC warns about it and it's right. There's code null-checking the return value
of this function, so we should either initialize it or assert it's never null.

Depends on D59648

Differential Revision: https://phabricator.services.mozilla.com/D59649

--HG--
extra : moz-landing-system : lando
2020-01-13 06:37:04 +00:00
Emilio Cobos Álvarez
8b5f68f4e9 Bug 1608729 - Initialize some variables in WebGLProgram. r=jgilbert
Otherwise GCC warns about the variable being possibly uninitialized, and it's
right if you could ever have a shader with a wrong type.

Depends on D59647

Differential Revision: https://phabricator.services.mozilla.com/D59648

--HG--
extra : moz-landing-system : lando
2020-01-13 19:59:47 +00:00
Emilio Cobos Álvarez
baa5b9f495 Bug 1608729 - TestThreadUtils isn't counting copies correctly. r=froydnj
The increments are incrementing the pointers, not the values.

This was caught by a GCC warning.

Depends on D59646

Differential Revision: https://phabricator.services.mozilla.com/D59647

--HG--
extra : moz-landing-system : lando
2020-01-13 14:15:17 +00:00
Emilio Cobos Álvarez
7c6f58b638 Bug 1608729 - Don't warn about multistatement macros with GCC. r=froydnj
It generates a lot of noise and we don't want to fix them. In particular, all
the cycle collector macros are like this.

Differential Revision: https://phabricator.services.mozilla.com/D59646

--HG--
extra : moz-landing-system : lando
2020-01-13 14:54:39 +00:00
Alex Henrie
e71e6666f8 Bug 1608002 - Link to CancelSynchronousIo at compile time. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D59269

--HG--
extra : moz-landing-system : lando
2020-01-13 18:49:36 +00:00
Connor Brewster
865f8216ac Bug 1607746 - Part 2: Clean up passing filter mode to shader r=nical
I removed the old opacity filter path in the brush_blend shader and cleaned up the filter mode
constants in the shader so there are less magic numbers. This should help if/when we move more
filters to their own shaders.

Depends on D59610

Differential Revision: https://phabricator.services.mozilla.com/D59611

--HG--
extra : moz-landing-system : lando
2020-01-13 16:05:59 +00:00
Eric Rahm
78ee6675cf Bug 1606187 - Part 2b: Update users of nsClassHashtable to handle UniquePtr differences r=KrisWright,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D59042

--HG--
extra : moz-landing-system : lando
2020-01-13 19:18:56 +00:00
Eric Rahm
5ff63a5642 Bug 1606187 - Part 2a: Switch nsClassHashtable over to UniquePtr r=KrisWright,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D59041

--HG--
extra : moz-landing-system : lando
2020-01-13 19:18:43 +00:00
Eric Rahm
a4d08e88db Bug 1606187 - Part 1: Add a DataType conversion helper to nsBaseHashtable r=froydnj,KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D59040

--HG--
extra : moz-landing-system : lando
2020-01-13 19:18:43 +00:00
Tom Schuster
b0fa2a9846 Bug 1606084 - Add ErrorToSource. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D59627

--HG--
extra : moz-landing-system : lando
2020-01-13 03:13:49 +00:00
Nika Layzell
8238c2e745 Bug 1607573 - Part 4: Drop the 'Outer' from GetFrameElementOuter, r=bzbarsky
No longer necessary since the nsGlobalWindow{Inner,Outer}-split.

Differential Revision: https://phabricator.services.mozilla.com/D59551

--HG--
extra : moz-landing-system : lando
2020-01-10 19:39:31 +00:00
Nika Layzell
c76e93dad5 Bug 1607573 - Part 3: Remove GetRealFrameElementOuter in favor of GetFrameElement, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D59550

--HG--
extra : moz-landing-system : lando
2020-01-10 19:39:01 +00:00
Nika Layzell
808bb3e060 Bug 1607573 - Part 2: Remove nsPIDOMWindowInner::GetFrameElement, r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D59549

--HG--
extra : moz-landing-system : lando
2020-01-10 19:32:49 +00:00
Nika Layzell
9375a3b254 Bug 1607573 - Part 1: Change GetRealFrameElementOuter to use BrowsingContext, r=bzbarsky
This does not fix consumers of GetRealFrameElementOuter, which may still act
incorrectly, as the frame element will not be available in cross-process
situations, but removes a user of the docshell tree.

This has a small behaviour change, in that it causes 'window.realFrameElement'
to return 'null' when run within an <iframe mozbrowser>. A quick inspection of
use-sites suggested that this would not be an issue, and it appears to pass a
try run.

Differential Revision: https://phabricator.services.mozilla.com/D59398

--HG--
extra : moz-landing-system : lando
2020-01-10 19:22:29 +00:00
Razvan Maries
116a3d4df1 Backed out changeset 7c414004b82a (bug 1603356) for dt failures. CLOSED TREE 2020-01-13 21:04:23 +02:00
Razvan Maries
09822f93ec Backed out 4 changesets (bug 1608089) for build bustages. CLOSED TREE
Backed out changeset 67fdb2aebe67 (bug 1608089)
Backed out changeset c143928209fb (bug 1608089)
Backed out changeset ad9edb807ff5 (bug 1608089)
Backed out changeset 0774435321f8 (bug 1608089)
2020-01-13 21:03:09 +02:00
Rob Rico
7aa0f559cc Bug 1604066 - Removing Return on Void Statement in PerformanceOberserver::ReportUnsupportedTypesErrorToConsole() r=sylvestre
Depends on D59654

Differential Revision: https://phabricator.services.mozilla.com/D59714

--HG--
extra : moz-landing-system : lando
2020-01-13 18:13:37 +00:00
Jason Orendorff
0b525fb66a Bug 1608089 - Part 4: Convert JSOp to an enum class. r=jandem.
The new opcode names are like `JSOp::InitHiddenProp`. This patch creates
aliases with all of the old names, like `JSOP_INITHIDDENPROP`, to keep existing
code working.

Differential Revision: https://phabricator.services.mozilla.com/D59363

--HG--
extra : moz-landing-system : lando
2020-01-13 18:40:05 +00:00
Jason Orendorff
17ef6cc343 Bug 1608089 - Part 3: Add CamelCase and snake_case identifiers to FOR_EACH_OPCODE. r=jandem.
The snake-case identifiers will be handy in Rust. The plan is to write a script
to import FOR_EACH_OPCODE as a similar Rust macro.

Differential Revision: https://phabricator.services.mozilla.com/D59362

--HG--
extra : moz-landing-system : lando
2020-01-13 18:39:37 +00:00
Jason Orendorff
ad394d20b0 Bug 1608089 - Part 2: Make JSOP_LIMIT an int constant rather than a JSOp value. r=jandem.
The change to PendingEdge is OK because this default value is never used; the
field's accessor asserts that *this was created using one of the constructors
that requires an explicit JSOp from the caller.

Differential Revision: https://phabricator.services.mozilla.com/D59361

--HG--
extra : moz-landing-system : lando
2020-01-13 18:38:26 +00:00
Jason Orendorff
87338c7f13 Bug 1608089 - Part 1: Add explicit casts between JSOp and uint8_t. r=jandem.
Later we will turn JSOp into an enum class that requires these casts.

In places where we are overwriting a previously written bytecode,
this casts to jsbytecode rather than uint8_t, following the prevailing
style.

Differential Revision: https://phabricator.services.mozilla.com/D59359

--HG--
extra : moz-landing-system : lando
2020-01-13 18:37:04 +00:00
Razvan Maries
55782f1de7 Backed out 37442417fc24 (Bug 1602863) as per edwin's request. CLOSED TREE 2020-01-13 20:31:03 +02:00
Vijay Budhram
14dafe4e16 Bug 1606203 - Update expiration for telemetry fxa_app_menu and fxa_avatar_menu to never r=loines
Differential Revision: https://phabricator.services.mozilla.com/D59450

--HG--
extra : moz-landing-system : lando
2020-01-13 18:00:47 +00:00
Emilio Cobos Álvarez
9846fd9184 Bug 1599206 - Don't serialize implicit tracks for grid-template properties, as they make the computed style not round-trip. r=mats
Do this only on nightly for now since we're about to enter the soft freeze.

(No test updates yet, as try is still running, and I need to figure out how to
import Oriol's changes into WPT, but I wanted to ensure that you were fine with
this)

Differential Revision: https://phabricator.services.mozilla.com/D54595

--HG--
extra : moz-landing-system : lando
2020-01-13 16:52:18 +00:00
pbz
0d701e5564 Bug 1596836 - Remove block image UI from pageInfo media tab. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D59718

--HG--
extra : moz-landing-system : lando
2020-01-13 17:30:26 +00:00
Michael Cooper
1469d0cf85 Bug 1606883 - Remove legacy method of fetching Normandy recipes directly from the server r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D58651

--HG--
extra : moz-landing-system : lando
2020-01-13 17:24:50 +00:00
Edwin Takahashi
7b485ae170 Bug 1608251 - re-enable linux1804-64-ccov variant and migrate mochitest-webgl/awsy tests r=jmaher
Changes:

Re-enable the `test-linux1804-ccov/opt` variant.
Create a new `linux1804-ccov-tests` test set.

Add `awsy` to ubuntu1804 and remove it correspondingly from ubuntu1604.
Add `mochitest-webgl` tests to ubuntu1804 an remove it from ubunt1604.

Differential Revision: https://phabricator.services.mozilla.com/D59593

--HG--
extra : moz-landing-system : lando
2020-01-13 17:10:06 +00:00
J.C. Jones
1cbe67b6fb Bug 1606927 - land NSS a06bd0f6bbe8 UPGRADE_NSS_RELEASE, r=kjacobs
2020-01-11  Kai Engert  <kaie@kuix.de>

	* lib/softoken/lowpbe.c, lib/softoken/pkcs11.c:
	Bug 1606992 - Cache the most recent PBKDF2 password hash, to speed
	up repeated SDR operations. r=jcj
	[a06bd0f6bbe8] [tip]

Differential Revision: https://phabricator.services.mozilla.com/D59741

--HG--
extra : moz-landing-system : lando
2020-01-13 17:09:45 +00:00
Morgan Reschenberg
235c56836e Bug 1608348: List zoom preference in main.js to make preferences checkbox functional. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D59727

--HG--
extra : moz-landing-system : lando
2020-01-13 16:59:34 +00:00
Jason Laster
c14429ba13 Bug 1592725 - Enable async live stacks in Nightly and DevEdition. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D59435

--HG--
extra : moz-landing-system : lando
2020-01-13 09:14:38 +00:00
Mark Osborne
7afd921740 Bug 782547 - Focus on last focussed control after dialog closed; r=Jamie,NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D54464

--HG--
extra : moz-landing-system : lando
2020-01-13 14:08:43 +00:00
Siddhant085
d48342d7db Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-13 16:25:39 +00:00
Nathan Froyd
6bd7bafb72 Bug 1608847 - fix outdated comment in ipdl unit tests; r=mccr8
Apparently nobody ever checked the comment vs. the code.

Differential Revision: https://phabricator.services.mozilla.com/D59720

--HG--
extra : moz-landing-system : lando
2020-01-13 17:30:18 +00:00
Andrew McCreight
b50a606c57 Bug 1608533 - Whitelist libX11.so for LSan. r=decoder
Differential Revision: https://phabricator.services.mozilla.com/D59576

--HG--
extra : moz-landing-system : lando
2020-01-12 10:09:58 +00:00
Erica Wright
7d3b8242b0 Bug 1601051 - Navigating with the Tab key can select the learn more link only when visible. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D58644

--HG--
extra : moz-landing-system : lando
2020-01-10 22:39:17 +00:00
Jason Laster
3bec0a0325 Bug 1603356 - Enable Eager evaluation in Nightly. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D59539

--HG--
extra : moz-landing-system : lando
2020-01-13 17:05:34 +00:00
Marco Castelluccio
bf5648959c Bug 1608082 - Disable webdriver/tests/delete_session/delete.py as it is consistently timing out with the Windows coverage build. r=whimboo
Differential Revision: https://phabricator.services.mozilla.com/D59725

--HG--
extra : moz-landing-system : lando
2020-01-13 16:31:19 +00:00
Sebastian Hengst
c8876e8ab7 Bug 1599043 - Part 11: Set browser_protections_UI.js as expected to pass to fix unexpected pass. CLOSED TREE
Was previously set as failing in bug 1590696.
2020-01-13 18:43:53 +01:00
Connor Brewster
b4a3943712 Bug 1607746 - Part 1: Move opacity to its own shader in WebRender r=nical
Opacity is a common effect that is used and the opacit filter path is also used when a stacking
context has an opacity of < 1. The brush_blend shader is slow since it has support for a large
portion of CSS filters; however, opacity is used much more often than the rest of the filters.
This patch adds a simple shader for opacity effects which bypasses the extra overhead in the
brush_blend shader.

Differential Revision: https://phabricator.services.mozilla.com/D59610

--HG--
extra : moz-landing-system : lando
2020-01-13 16:05:57 +00:00
Mirko Brodesser
6ae59766f6 Bug 1608850: remove nsRange::IsNodeInSortedRanges which doesn't have a definition. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D59723

--HG--
extra : moz-landing-system : lando
2020-01-13 15:54:11 +00:00
Tom Ritter
8bc0e61a46 Bug 1607737 - Extend the evalUsage telemtry probe a couple versions r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D59427

--HG--
extra : moz-landing-system : lando
2020-01-13 13:13:02 +00:00
Henrik Skupin
6050750472 Bug 1590102 - [remote] Implement Network.deleteCookies. r=remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D59431

--HG--
extra : moz-landing-system : lando
2020-01-13 16:02:09 +00:00
Dorel Luca
9e9a23530e Merge mozilla-central to autoland 2020-01-13 17:59:55 +02:00
Daniel Varga
356ecac1d7 Merge autoland to mozilla-central. a=merge 2020-01-13 17:44:48 +02:00
Bastien Abadie
9aaea00808 Bug 1608840 - Add a CODE_REVIEW environment variable to source-test tasks when running for code-review reporting, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D59719

--HG--
extra : moz-landing-system : lando
2020-01-13 15:35:26 +00:00
Florian Quèze
c6318e5e30 Bug 1608841 - Remove obsolete browser_all_files_referenced.js whitelisted shield prefixes, r=Gijs.
Differential Revision: https://phabricator.services.mozilla.com/D59717

--HG--
extra : moz-landing-system : lando
2020-01-13 15:21:58 +00:00
Nathan Froyd
ddcacd94c7 Bug 1608753 - download the correct lucet package in bootstrap; r=emilio a=Aryx
We renamed the toolchain task in bug 1608428 and we forgot to update
bootstrap along with the renaming.

Differential Revision: https://phabricator.services.mozilla.com/D59699

--HG--
extra : source : 90754ce54f5b6b19f6929cd2d81d18974a90ecbc
extra : amend_source : 353def24f5e34fbb5ba368cab07ffb442ba2f7d7
2020-01-13 14:07:21 +00:00
Emilio Cobos Álvarez
aaecc96d81 Bug 1588791 - Make fission iframes honor and deal with the scrolling attribute. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D59630

--HG--
extra : moz-landing-system : lando
2020-01-13 11:30:44 +00:00
Emilio Cobos Álvarez
58cf568b3a Bug 1588791 - Cleanup threading of OwnerShowInfo. r=mattwoodrow
Right now we do the same thing in two pretty different code paths... That's not
great, so unify them.

Differential Revision: https://phabricator.services.mozilla.com/D59629

--HG--
extra : moz-landing-system : lando
2020-01-13 11:30:36 +00:00
Dorel Luca
7d72fc953f Backed out changeset 47f8d76aa4fc (bug 1603190) for Devtools failures in devtools/client/framework/test/browser_toolbox_view_source_02.js. CLOSED TREE 2020-01-13 13:29:55 +02:00