323 Commits

Author SHA1 Message Date
ffxbld
618ba07d34 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D71198
2020-04-16 16:16:14 +00:00
Lina Cambridge
f9abd62b34 Bug 1596322 - Add XPCOM bindings for Rust Sync engines. r=markh,tcsc,LougeniaBailey
This commit adds a new crate for bridging Rust Sync engines to Desktop,
and a `mozIBridgedSyncEngine` for accessing the bridge via JS.
Naturally, the bridge is called Golden Gate. 😊 For more information
on how to use it, please see `golden_gate/src/lib.rs`.

Other changes include:

* Ensuring the test Sync server uses UTF-8 for requests and responses.
* Renaming `mozISyncedBookmarksMirrorLogger` to `mozIServicesLogger`,
  and moving it into the shared Sync interfaces.

The `BridgedEngine` trait lives in its own crate, called
`golden_gate_traits`, to make it easier to eventually move into a-s.
`Interruptee` and `Interrupted` already exist in a-s, and are
duplicated in this crate for now.

Differential Revision: https://phabricator.services.mozilla.com/D65268

--HG--
extra : moz-landing-system : lando
2020-04-09 15:45:37 +00:00
ffxbld
c53603da3d No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D70364

--HG--
extra : moz-landing-system : lando
2020-04-09 13:55:34 +00:00
Bogdan Tara
5dcf5dcc85 Backed out changeset d8ef791a2165 (bug 1596322) for browser_all_files_referenced.js failures CLOSED TREE 2020-04-09 13:17:04 +03:00
Lina Cambridge
fcb1f70a45 Bug 1596322 - Add XPCOM bindings for Rust Sync engines. r=markh,tcsc,LougeniaBailey
This commit adds a new crate for bridging Rust Sync engines to Desktop,
and a `mozIBridgedSyncEngine` for accessing the bridge via JS.
Naturally, the bridge is called Golden Gate. 😊 For more information
on how to use it, please see `golden_gate/src/lib.rs`.

Other changes include:

* Ensuring the test Sync server uses UTF-8 for requests and responses.
* Renaming `mozISyncedBookmarksMirrorLogger` to `mozIServicesLogger`,
  and moving it into the shared Sync interfaces.

The `BridgedEngine` trait lives in its own crate, called
`golden_gate_traits`, to make it easier to eventually move into a-s.
`Interruptee` and `Interrupted` already exist in a-s, and are
duplicated in this crate for now.

Differential Revision: https://phabricator.services.mozilla.com/D65268

--HG--
extra : moz-landing-system : lando
2020-04-09 07:32:52 +00:00
Brindusan Cristian
bb29753b0d Backed out changeset 2b02e71f1780 (bug 1596322) for multiple xpcshell failures. CLOSED TREE 2020-04-09 03:39:56 +03:00
Lina Cambridge
186b7665c4 Bug 1596322 - Add XPCOM bindings for Rust Sync engines. r=markh,tcsc,LougeniaBailey
This commit adds a new crate for bridging Rust Sync engines to Desktop,
and a `mozIBridgedSyncEngine` for accessing the bridge via JS.
Naturally, the bridge is called Golden Gate. 😊 For more information
on how to use it, please see `golden_gate/src/lib.rs`.

Other changes include:

* Ensuring the test Sync server uses UTF-8 for requests and responses.
* Renaming `mozISyncedBookmarksMirrorLogger` to `mozIServicesLogger`,
  and moving it into the shared Sync interfaces.

The `BridgedEngine` trait lives in its own crate, called
`golden_gate_traits`, to make it easier to eventually move into a-s.
`Interruptee` and `Interrupted` already exist in a-s, and are
duplicated in this crate for now.

Differential Revision: https://phabricator.services.mozilla.com/D65268

--HG--
extra : moz-landing-system : lando
2020-04-08 20:18:37 +00:00
ffxbld
03d8a2f376 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D69815

--HG--
extra : moz-landing-system : lando
2020-04-06 13:52:26 +00:00
Gijs Kruitbosch
b9b9e096b9 Bug 1627179 - ensure we deal with transaction.abort() throwing r=leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D69511

--HG--
extra : moz-landing-system : lando
2020-04-03 13:17:38 +00:00
Gijs Kruitbosch
c8f180ee44 Bug 1624983 - follow-up: add missing Array.from call a=fix
CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D69440

--HG--
extra : amend_source : 2526a782e8884f6f7763ca41295323719954e1ba
2020-04-02 20:01:58 +00:00
Gijs Kruitbosch
b6fedc53eb Bug 1624983 - abort pending read transactions from the DB when quitting, r=asuth,leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D68465

--HG--
extra : moz-landing-system : lando
2020-04-02 14:40:33 +00:00
ffxbld
11eaff63b3 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D69379

--HG--
extra : moz-landing-system : lando
2020-04-02 14:01:33 +00:00
ffxbld
b15d2587f4 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D68798

--HG--
extra : moz-landing-system : lando
2020-03-30 14:02:50 +00:00
Cosmin Sabou
7dc93bf032 Backed out changeset 15a52d0bf116 (bug 1624983) for bc failures on browser_RecipeRunner.js
CLOSED TREE
2020-03-27 20:09:40 +02:00
Gijs Kruitbosch
4f3914f12d Bug 1624983 - abort pending read transactions from the DB when quitting, r=asuth,leplatrem
Differential Revision: https://phabricator.services.mozilla.com/D68465

--HG--
extra : moz-landing-system : lando
2020-03-27 16:05:00 +00:00
ffxbld
d1bfa2330a No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D68386

--HG--
extra : moz-landing-system : lando
2020-03-26 13:53:08 +00:00
Gijs Kruitbosch
0377d8eece Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth
By and large, this change accomplishes two things:
1. Run db.close() in finally clauses so that even if db access fails, we close
   our connections. It also tries to avoid waiting on other, non-DB operations
   before calling close, to avoid the DB connection needlessly hanging around.
2. Intercept all async database operations from the remote settings client to
   kinto and ensuring they complete before the end of `profile-before-change`.
   Any operations started after Services.startup.isShuttingDown (so after
   quit/restart is initiated by the user) will throw. Operations started
   beforehand are put in a set of operations, and remove themselves once
   complete. We AsyncShutdown block on that set of operations completing.

Differential Revision: https://phabricator.services.mozilla.com/D66995

--HG--
extra : moz-landing-system : lando
2020-03-24 14:55:41 +00:00
Andreea Pavel
3550cada92 Backed out changeset 3b7ccffc0546 (bug 1598924) for permafailing bug 1621759 on a CLOSED TREE 2020-03-23 21:37:55 +02:00
Gijs Kruitbosch
457afaaba0 Bug 1598924 - make remote settings handle shutdown gracefully, r=leplatrem,asuth
By and large, this change accomplishes two things:
1. Run db.close() in finally clauses so that even if db access fails, we close
   our connections. It also tries to avoid waiting on other, non-DB operations
   before calling close, to avoid the DB connection needlessly hanging around.
2. Intercept all async database operations from the remote settings client to
   kinto and ensuring they complete before the end of `profile-before-change`.
   Any operations started after Services.startup.isShuttingDown (so after
   quit/restart is initiated by the user) will throw. Operations started
   beforehand are put in a set of operations, and remove themselves once
   complete. We AsyncShutdown block on that set of operations completing.

Differential Revision: https://phabricator.services.mozilla.com/D66995

--HG--
extra : moz-landing-system : lando
2020-03-23 16:35:08 +00:00
ffxbld
688cc76dfc No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D67852

--HG--
extra : moz-landing-system : lando
2020-03-23 13:43:31 +00:00
Mathieu Leplatre
924826ecef Bug 1623481 - Fix intermittent failure on Remote Settings Database open r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D67454

--HG--
extra : moz-landing-system : lando
2020-03-20 09:46:44 +00:00
Mark Banner
c2e698bc85 Bug 1542269 - Make the modern search engine configuration be loaded from Remote Settings. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D55464

--HG--
extra : moz-landing-system : lando
2020-03-19 14:11:40 +00:00
ffxbld
8fdcf8990c No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D67475

--HG--
extra : moz-landing-system : lando
2020-03-19 13:43:29 +00:00
Mathieu Leplatre
d8a808669c Bug 1620185 - Fetch metadata and records in parallel r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D67142

--HG--
extra : moz-landing-system : lando
2020-03-17 20:26:01 +00:00
Mathieu Leplatre
24fcb6ab53 Bug 1620185 - Improve behaviour when signature is bad after retry r=glasserc
When the signature verification fails after retry we don't want to apply the changes, and if possible we want to leave the local data as it was before sync.

Differential Revision: https://phabricator.services.mozilla.com/D67139

--HG--
extra : moz-landing-system : lando
2020-03-17 20:24:01 +00:00
Mathieu Leplatre
c74311c266 Bug 1620185 - Import IndexedDB code from kinto.js r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66752

--HG--
extra : moz-landing-system : lando
2020-03-17 20:23:31 +00:00
Mathieu Leplatre
7ddb40d7b9 Bug 1620185 - Move DB to separate file r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66751

--HG--
extra : moz-landing-system : lando
2020-03-17 20:23:00 +00:00
Mathieu Leplatre
fbd73a9215 Bug 1620185 - Simplify CanonicalJSON of records r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66750

--HG--
extra : moz-landing-system : lando
2020-03-17 20:22:32 +00:00
Mathieu Leplatre
bc6e54afaa Bug 1620185 - Remove usage of .openCollection() in other modules r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66749

--HG--
extra : moz-landing-system : lando
2020-03-17 20:21:54 +00:00
Mathieu Leplatre
aaf32a2504 Bug 1620185 - Remove usage of .openCollection() r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66632

--HG--
extra : moz-landing-system : lando
2020-03-17 20:20:46 +00:00
Mathieu Leplatre
47e09d0ba8 Bug 1620185 - Remove usage of kinto.js collection instance r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66630

--HG--
extra : moz-landing-system : lando
2020-03-17 20:20:05 +00:00
Mathieu Leplatre
76e09115f9 Bug 1620185 - Remove usage of kinto.js collection methods r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66629

--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:38 +00:00
Mathieu Leplatre
fbc12fc39d Bug 1620185 - Reuse code from signature failure retry r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66412

--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:28 +00:00
Mathieu Leplatre
6d01f4e707 Bug 1620185 - Replace pullMetadata() with low level code r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66411

--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:23 +00:00
Mathieu Leplatre
5b64d20ae2 Bug 1620185 - Replace .sync() by underlying calls r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D66409

--HG--
extra : moz-landing-system : lando
2020-03-17 20:19:20 +00:00
ffxbld
5102396177 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D66963

--HG--
extra : moz-landing-system : lando
2020-03-16 13:48:38 +00:00
ffxbld
7207d7f765 No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D66614

--HG--
extra : moz-landing-system : lando
2020-03-12 17:07:37 +00:00
Mathieu Leplatre
9296f12f2b Bug 1621308 - Give up client sync early during shutdown r=glasserc
A significant amount of clients report OFFLINE_ERROR during shutdown.

Instead of adding a new uptake status to be reported when detecting offline during shutdown (eg. INTERRUPTED, not *_ERROR), we do nothing and give up immediately.

Differential Revision: https://phabricator.services.mozilla.com/D66271

--HG--
extra : moz-landing-system : lando
2020-03-10 19:10:18 +00:00
Florian Quèze
2c3a1ae0be Bug 1620630 - The OS.File worker should record markers indicating which operation it is performing on which file, r=Yoric.
Differential Revision: https://phabricator.services.mozilla.com/D65747

--HG--
extra : moz-landing-system : lando
2020-03-11 14:22:06 +00:00
Daniel Varga
df858c9057 Backed out changeset 6aaa835ae0eb (bug 1620630) for causing xpcshell failures at osfile/tests/xpcshell/test_osfile_closed.js
CLOSED TREE
2020-03-10 21:08:48 +02:00
Florian Quèze
5345d6fcbb Bug 1620630 - The OS.File worker should record markers indicating which operation it is performing on which file, r=Yoric.
Differential Revision: https://phabricator.services.mozilla.com/D65747

--HG--
extra : moz-landing-system : lando
2020-03-10 17:04:10 +00:00
Mark Banner
2c4e35b0a6 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509

--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Mathieu Leplatre
2d4875b904 Bug 1618491 - Detect shutdown during Remote Settings sync r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D65318

--HG--
extra : moz-landing-system : lando
2020-03-05 18:06:52 +00:00
ffxbld
39c3d77141 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D65516

--HG--
extra : moz-landing-system : lando
2020-03-05 17:17:28 +00:00
Mathieu Leplatre
da32d01a9d Bug 1619569 - Fix Uptake events test on beta merge r=glasserc
The test passes on nightly because the condition actually checks specifically for nightly. On non-nightly the test fails because although it mocks the channel with withFakeChannel, the code under test doesn't respect that.

Differential Revision: https://phabricator.services.mozilla.com/D65303

--HG--
extra : moz-landing-system : lando
2020-03-04 18:41:39 +00:00
Mathieu Leplatre
863b4989d3 Bug 1617942 - Close Remote Settings DB connections after use r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D64303

--HG--
extra : moz-landing-system : lando
2020-03-03 16:41:47 +00:00
Mathieu Leplatre
9448fcafc5 Bug 1617133 - Report error names to Telemetry on Nightly r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D64560

--HG--
extra : moz-landing-system : lando
2020-03-02 15:04:33 +00:00
Mathieu Leplatre
acd66bc75c Bug 1617133 - Reduce complexity of RemoteSettingsClient.maybeSync() r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D64559

--HG--
extra : moz-landing-system : lando
2020-02-28 17:06:17 +00:00
Mathieu Leplatre
ec2cc6b37b Bug 1617133 - Improve categorization of Remote Settings errors r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D64402

--HG--
extra : moz-landing-system : lando
2020-02-28 17:06:17 +00:00
ffxbld
2690d1d20f No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D64941

--HG--
extra : moz-landing-system : lando
2020-03-02 13:42:22 +00:00