Commit Graph

831486 Commits

Author SHA1 Message Date
Eitan Isaacson
31c0b1e98c Bug 1730095 - P1: Refactor text Mac marker tests. r=morgan
This change gives a bit more flexibility for isolating issues and seeing which specific marker offset is giving trouble when a test fails.

Depends on D168445

Differential Revision: https://phabricator.services.mozilla.com/D168446
2023-02-22 04:52:59 +00:00
James Teh
f826326f5f Bug 1816346 part 2: If we force an Accessible to be created due to transform/fixed/sticky despite it being presentational, make it a generic Accessible. r=nlapre
Otherwise, semantics are exposed (e.g. for a table), which completely defeats the author's intent that this be treated as presentational.

Differential Revision: https://phabricator.services.mozilla.com/D170165
2023-02-22 04:46:50 +00:00
James Teh
75092d8fb0 Bug 1816346 part 1: Fix the transform tree creation test in browser_test_simple_transform.js. r=nlapre
Previously, the test was retrieving an Accessible with a non-existent id and calling testAccessibleTree on it.
That meant we were calling testAccessibleTree with null, which is a no-op.
Now, we get the intended Accessible so that the test actually tests what it was supposed to test.
This is important to test a potential bug in the next patch.

Differential Revision: https://phabricator.services.mozilla.com/D170306
2023-02-22 04:46:50 +00:00
Butkovits Atila
9159bcd837 Backed out changeset 70a0f82267f1 (bug 1804794) for causing build bustages at ReflowInput.cpp. CLOSED TREE 2023-02-22 06:48:12 +02:00
Eitan Isaacson
8bf95c7d17 Bug 1814220 - Allow ignoring list item markers in TextLeafPoint::FindBoundary. r=Jamie
Refactor in FindBoundary to allow easier skipping of leaves in the loop.

Differential Revision: https://phabricator.services.mozilla.com/D168445
2023-02-22 04:17:31 +00:00
Shane Hughes
64bc2ac15b Bug 1815501 - Fix Feature Callout focus rings. r=jprickett
Fixes the border radius and color/style of the outline applied to
feature callouts when they are focused. Also applies the focus ring to
the callout's arrow with some CSS changes.

Differential Revision: https://phabricator.services.mozilla.com/D170524
2023-02-22 04:08:04 +00:00
Glenn Watson
986d097472 Bug 1818115 - Make FrameId be explicit u64 rather than usize r=gfx-reviewers,bradwerth
Simplifies some upcoming work to change how we store these when
updating primitive dependencies during picture cache updates.

Differential Revision: https://phabricator.services.mozilla.com/D170546
2023-02-22 03:59:32 +00:00
Mark Hammond
42a8237945 Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D170186
2023-02-22 03:58:11 +00:00
Norisz Fay
6a44184c86 Backed out changeset 63c1ac1ebbac (bug 1815501) for causing node failure on _feature-callout.scss CLOSED TREE 2023-02-22 05:24:41 +02:00
Shane Hughes
6427830303 Bug 1815501 - Fix Feature Callout focus rings. r=jprickett
Fixes the border radius and color/style of the outline applied to
feature callouts when they are focused. Also applies the focus ring to
the callout's arrow with some CSS changes.

Differential Revision: https://phabricator.services.mozilla.com/D170524
2023-02-22 02:40:48 +00:00
Butkovits Atila
d45ed2897d Backed out 2 changesets (bug 1816346) for causing failures at test_table.html. CLOSED TREE
Backed out changeset eeb78c17513c (bug 1816346)
Backed out changeset 22b32e106152 (bug 1816346)
2023-02-22 04:45:07 +02:00
Emily McDonough
75a6f4f11e Bug 1804794 - Do not allow CSS named page breaks except in specific subtrees. r=dholbert
This currently only includes block frames, grid containers, and flex
containers, and the document and pagination frames. It is possible more frames
will need to be added or more advanced checks in the future.

This adds some related tests to ignoring some subtrees, but are expected fails
until bug 1816570 is fixed.

Differential Revision: https://phabricator.services.mozilla.com/D169018
2023-02-22 02:29:31 +00:00
James Teh
4f47e992e7 Bug 1816346 part 2: If we force an Accessible to be created due to transform/fixed/sticky despite it being presentational, make it a generic Accessible. r=nlapre
Otherwise, semantics are exposed (e.g. for a table), which completely defeats the author's intent that this be treated as presentational.

Differential Revision: https://phabricator.services.mozilla.com/D170165
2023-02-22 02:17:56 +00:00
James Teh
193890e062 Bug 1816346 part 1: Fix the transform tree creation test in browser_test_simple_transform.js. r=nlapre
Previously, the test was retrieving an Accessible with a non-existent id and calling testAccessibleTree on it.
That meant we were calling testAccessibleTree with null, which is a no-op.
Now, we get the intended Accessible so that the test actually tests what it was supposed to test.
This is important to test a potential bug in the next patch.

Differential Revision: https://phabricator.services.mozilla.com/D170306
2023-02-22 02:17:55 +00:00
sotaro
75da1dd5d4 Bug 1817709 - Block video overlay with non-intel GPUs on Windows 10 r=jrmuizel,gfx-reviewers
Video overlay does not work well with non-intel GPUs on Windows 10. See Bug 1817269, Bug 1817617.

Differential Revision: https://phabricator.services.mozilla.com/D170311
2023-02-22 01:54:27 +00:00
Arturo Mejia
7e62be4d03 Bug 1801615 - Remove GeckoSession.SelectionActionDelegate.Selection.clientRect r=geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D170259
2023-02-22 01:39:28 +00:00
Ting-Yu Lin
cb1b4fb0eb Bug 1811548 Part 2 - Provide size overrides when creating ReflowInput for an overflow container flex item. r=dholbert
Testcase 001 and 002 test row-oriented and column-oriented flex container,
respectively. The "a" and "b" variant test `box-sizing:border-box` and
`box-sizing:content-box`, respectively.

Differential Revision: https://phabricator.services.mozilla.com/D170035
2023-02-22 01:34:07 +00:00
Ting-Yu Lin
d9b85a4a49 Bug 1811548 Part 1 - Don't evaluate physical available size when aContainerSize is provided. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D170034
2023-02-22 01:34:07 +00:00
Shane Hughes
a20de61ba5 Bug 1817018 - Remove Spotlight dismiss button in and out transitions. r=omc-reviewers,emcminn
Remove all the transition-in and transition-out animations from the
Spotlight dismiss button, leaving the dialog-initial and dialog-last
animations, anticipating that all our messages will either have a
dismiss button on every screen or on none of the screens.

Differential Revision: https://phabricator.services.mozilla.com/D170527
2023-02-21 23:42:10 +00:00
Butkovits Atila
d434d2fc49 Backed out changeset c33204e69e49 (bug 1743045) for causing failures at scroll-behavior-3.html. CLOSED TREE 2023-02-22 01:15:14 +02:00
Masayuki Nakano
806244c866 Bug 1815827 - part 6: Get rid of editor.use_div_for_default_newlines pref r=m_kato
Depends on D169764

Differential Revision: https://phabricator.services.mozilla.com/D169765
2023-02-21 22:54:26 +00:00
Masayuki Nakano
05f8285a93 Bug 1815827 - part 5: Get rid of editor.resizing.preserve_ratio pref r=m_kato
Depends on D169763

Differential Revision: https://phabricator.services.mozilla.com/D169764
2023-02-21 22:54:26 +00:00
Masayuki Nakano
2c9a95743d Bug 1815827 - part 4: Get rid of editor.positioning.offset pref r=m_kato
Depends on D169762

Differential Revision: https://phabricator.services.mozilla.com/D169763
2023-02-21 22:54:25 +00:00
Masayuki Nakano
893c30b69c Bug 1815827 - part 3: Get rid of editor.initialize_element_before_connect pref r=m_kato
Depends on D169761

Differential Revision: https://phabricator.services.mozilla.com/D169762
2023-02-21 22:54:25 +00:00
Masayuki Nakano
b29a944ac4 Bug 1815827 - part 2: Get rid of editor.hr_element.allow_to_delete_from_following_line pref r=m_kato
Depends on D169760

Differential Revision: https://phabricator.services.mozilla.com/D169761
2023-02-21 22:54:25 +00:00
Masayuki Nakano
3fa7da3abb Bug 1815827 - part 1: Get rid of editor.css.default_length_unit pref r=m_kato
Depends on D169759

Differential Revision: https://phabricator.services.mozilla.com/D169760
2023-02-21 22:54:24 +00:00
Masayuki Nakano
1ccf2c9f39 Bug 1815827 - part 0: Delete unnecessary editor pref telemetry probes r=chutten
Depends on D169758

Differential Revision: https://phabricator.services.mozilla.com/D169759
2023-02-21 22:54:24 +00:00
Masayuki Nakano
0dfc1d00f9 Bug 1810406 - Handle asynchronous composition without synthesized GDK_KEY_PRESS event r=m_kato
IME for ibus may send composition after filtering `GDK_KEY_PRESS` event
asynchronously.  In that case, IME or ibus usually synthesize `GDK_KEY_PRESS`
again for letting the application know what's being handled.  However, according
to the bug report, IME may send composition without synthesizing the
`GDK_KEY_PRESS` event.

Without this patch, `IMContextWrapper` dispatches only
`eContentCommandInsertText` event.  Then, it'll cause only a set of
`beforeinput` and `input` events.  Therefore, web apps may fail to do something
if they listen only composition and keyboard events only in Gecko.  For avoiding
Gecko only failure in this case, we should make `IMContentWrapper` handle the
composition with `GDK_KEY_PRESS` event in the queue which it has not handled
yet.  Then, web apps can work with `keydown` events whose `key` is `"Process"`.

Differential Revision: https://phabricator.services.mozilla.com/D170031
2023-02-21 22:51:43 +00:00
Masayuki Nakano
0df404cf45 Bug 1810406 - Make IMEContentObserver initialize its root element with the anonymous <div> if the editor is a TextEditor r=smaug
Although I cannot reproduce the bug in mochitest with
`nsIDOMWindowUtils.sendQueryContentEvent`, one of the problem in the web site
is, the frame of `<textarea>` is reframed at typing something.  Then, retrieving
computed style causes a flush **before** new `TextEditor` is recreated and
re-initialize `IMEContentObserver` with new anonymous contents.  At this time,
`IMEContentObserver` gets shadow root or document element from start container
of the first selection range which is in the text node in the anonymous `<div>`
instead of the anonymous `<div>` here:
https://searchfox.org/mozilla-central/rev/01d7150d99c3c175300560d33dcdeea3f6b7eb29/dom/events/IMEContentObserver.cpp#272,277-279

The reason is, `nsFrameSelection` has not been set to the independent selection
for the text control because `EditorBase::InitializeSelection` has not been
called via a call of `PostCreate` and of course, the selection ancestor limiter
has not been reset yet.
https://searchfox.org/mozilla-central/rev/01d7150d99c3c175300560d33dcdeea3f6b7eb29/editor/libeditor/EditorBase.cpp#5204,5212

Therefore, `nsINode::GetSelectionRootContent` crosses the native anonymous
subtree boundary and return a parent node of the text control because here
does not work as expected.
https://searchfox.org/mozilla-central/rev/01d7150d99c3c175300560d33dcdeea3f6b7eb29/dom/base/nsINode.cpp#583-593

`IMEContentObserver` should use `EditorBase::GetRoot()` instead of referring
`Selection` because it's stabler in any situation at that time.

Differential Revision: https://phabricator.services.mozilla.com/D170032
2023-02-21 22:51:42 +00:00
Nicolas Silva
7e1172fe66 Bug 1817829 - Vendor wgpu changes. r=webgpu-reviewers,teoxoy
Depends on D170494

Differential Revision: https://phabricator.services.mozilla.com/D170495
2023-02-21 22:36:52 +00:00
Nicolas Silva
7740df3fc7 Bug 1817829 - Vet wgpu and naga commits. r=supply-chain-reviewers,bholley
Depends on D170493

Differential Revision: https://phabricator.services.mozilla.com/D170494
2023-02-21 22:36:51 +00:00
Nicolas Silva
ead11be6ca Bug 1817829 - Update wgpu to revision 74303308cd6030071889e865c40aa638214ed938. r=webgpu-reviewers,teoxoy
Depends on D170492

Differential Revision: https://phabricator.services.mozilla.com/D170493
2023-02-21 22:36:51 +00:00
Nicolas Silva
1e1d5892c3 Bug 1817829 - Don't enable wgpu's renderdoc feature by default. r=webgpu-reviewers,supply-chain-reviewers,teoxoy
It is unclear that we want it enabled for all users and this way we don't have to audit the changes in renderdoc-sys.
We can and should revisit this in the future if we feel like it would be useful to ship with webgpu+renderdoc integration.

Differential Revision: https://phabricator.services.mozilla.com/D170492
2023-02-21 22:36:50 +00:00
Sergey Galich
679a013c0f Bug 1807223 - do not reuse generic autocomplete items r=credential-management-reviewers,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D170407
2023-02-21 22:06:41 +00:00
Dan Robertson
69572ca871 Bug 1743045 - Respect general.smoothScroll for programmatic scrolls. r=hiro
For programmatic scrolls, we should respect a users general.smoothScroll
preference. If smooth scrolls are disabled, programmatic scrolls with
behavior: "smooth" should be treated as instant programmatic scrolls.

Differential Revision: https://phabricator.services.mozilla.com/D170110
2023-02-21 22:02:11 +00:00
Norisz Fay
a7ceb10f1f Backed out changeset d82c03e04249 (bug 1359861) for causing xpcshell failure on test_BrowserUtils.js CLOSED TREE 2023-02-22 00:05:07 +02:00
Edgar Chen
a5808d350c Bug 1800895 - Add test for bug 1794622; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D162337
2023-02-21 21:53:56 +00:00
Iain Ireland
24ca603fc4 Bug 1817188: Only do structured clone when differential fuzzing r=jandem
The alias set that we use for MFuzzilliHash depends on suppressions in structured cloning that are only turned on when we do differential fuzzing. Changing the alias set based on differential fuzzing runs into problems with add vs addEffectful, so the simplest fix seems to be returning early if the suppressions aren't active.

Differential Revision: https://phabricator.services.mozilla.com/D170141
2023-02-21 21:48:47 +00:00
Pat McGhen
107ed64f10 Bug 1701865 - Add margin-inline-start to sectionFilters r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D170398
2023-02-21 21:40:29 +00:00
Andrew Osmond
b6515eab13 Bug 1814703 - Allow selecting between ARM and x86 clearkey on Windows ARM. r=azebrowski
On Windows ARM, we currently use the x86 version of the clearkey plugin.
We do however ship Firefox with the ARM version although prior to this
patch it was unused. Now if media.gmp-clearkey.allow-x64-plugin-on-arm64
is set to false, then we will attempt to load the ARM version of the
plugin. The pref remains true by default.

Differential Revision: https://phabricator.services.mozilla.com/D168707
2023-02-21 21:40:13 +00:00
Andrew Osmond
722fe75ab9 Bug 1814910 - Ensure we allow users to switch between ARM and x86 GMP plugins via balrog. r=azebrowski
We need to ensure the hash value is the same and remove the old binaries
if not because if we switch architectures without a version bump, we
will continue to use the old binary. Additionally we should also store
both ABI preferences for Windows ARM (x86 and aarch64) to ensure that if
we profile migrate, or update to a new version, we flush the plugins.

Differential Revision: https://phabricator.services.mozilla.com/D168809
2023-02-21 21:40:13 +00:00
CanadaHonk
ff90131cd0 Bug 1808688 - [bidi] Remove before request sent map spec assert r=jdescottes,webdriver-reviewers
Removed the "before request sent map" spec assert which is now unneeded
as to document invariants in the implementation.

Also updated WPT test expectations.

Differential Revision: https://phabricator.services.mozilla.com/D170335
2023-02-21 21:25:35 +00:00
Luca Greco
2726e94cab Bug 1807010 - Migrate ExtensionPermissions kvstore to a separate file path. r=willdurand,robwu
Differential Revision: https://phabricator.services.mozilla.com/D166046
2023-02-21 21:14:09 +00:00
Mark Hammond
f48ea32bf5 Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D170186
2023-02-21 21:04:10 +00:00
Butkovits Atila
f8a9ce74db Backed out changeset aaf82d1483ad (bug 1801019) for causing failures at browser_screenshots_telemetry_tests.js. CLOSED TREE 2023-02-21 23:04:05 +02:00
Steven Michaud
586ba286bf Bug 1814852 - Add support for dyld and __DATA_DIRTY,__crash_info to Breakpad. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D170383
2023-02-21 20:54:44 +00:00
Andrew Osmond
e69fa7da55 Bug 1818047 - Add prefs to control WebRender scissored cache clears. r=gfx-reviewers,jrmuizel
This patch adds two new prefs, gfx.webrender.scissored-cache-clears
.enabled and .force-enabled to control its status beyond the blocklist.
The former is true by default and allows one to turn the feature off by
flipping it to false. The latter allows one to force the feature on even
if the blocklist disables it. It also adds the status to the decision
log in about:support.

Differential Revision: https://phabricator.services.mozilla.com/D170507
2023-02-21 20:50:58 +00:00
Sarah Clements
bfe48d709b Bug 1815706 - Update history sidebar telemetry r=mak,mkaply
* fix sidebar click event handling
* Add scalar for total number of history entries per session
* Add test for scalar

Differential Revision: https://phabricator.services.mozilla.com/D169480
2023-02-21 20:33:56 +00:00
Yury Delendik
63dfc8fa10 Bug 1816000 - Keep FP valid at Wasm entry points. r=jandem
Currenty, FP can be invalid (FailFP) at the entries. For future modifications,
the FP has to be kept intact during throw handling/unwinding.

The patch replaces FailFP-hack with FailInstanceReg one. The InstanceReg pinned
register is always points to valid instance, including at the end of the call.
Using that property to signal when trap has occurred.

Differential Revision: https://phabricator.services.mozilla.com/D170105
2023-02-21 20:26:45 +00:00
Niklas Baumgardner
ab7aa855c8 Bug 1801019 - Add telemetry for screenshots component. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D164948
2023-02-21 19:59:09 +00:00