Using the {foo = null} = {} shorthand to generate default values exposed
as function scope variables is more readable, and arguably somewhat safer,
than the current approach.
MozReview-Commit-ID: Lxn0fpBSR3a
--HG--
extra : rebase_source : 63fa829657d726e8987a77b5add817a3b7d0b7d3
Whilst try...catch (e if foo) { ... } is a very nice construct, it has
not been standardised and we should avoid using non-web platform features.
MozReview-Commit-ID: 9qzHtBdlPfw
--HG--
extra : rebase_source : be27a3d647eba2d48721c77dabe12ca13278bda9
We try to delete the element entry by "id", which is not defined.
MozReview-Commit-ID: DXAOJAV1z9Q
--HG--
extra : rebase_source : 103209d203f64bb354e46fb4fb98225b8e7165a0
getContext and setContext are duplicated further up under the Marionette
serivce entries.
MozReview-Commit-ID: 2V5S2XG6wDw
--HG--
extra : rebase_source : 1f22adc294c063f014e3a0e884a01ed6a7fbe43e
To ensure a consistent return type from browser.Context#get, this patch
introduces a RangeError to be thrown if the weak reference to the window
is empty.
MozReview-Commit-ID: 2aNOG9Uht3I
--HG--
extra : rebase_source : e57f288544b011444c26f0d0ecd68979aa0caced
accessibility.service is allowed to return undefined, but we should
be explicit that this condition is allowed instead of relying on the
default value of the service variable assigned on the first line.
MozReview-Commit-ID: LrlnIba56v5
--HG--
extra : rebase_source : 1b66b6aa4393cb14b41bc67036d5d7296195be32
Returning a value from a finally-block will mask any errors thrown in
the try-block.
MozReview-Commit-ID: JBouChGmXYo
--HG--
extra : rebase_source : 9df23dc0ca8325384fb37c09141d330ab88927c3
We duplicate many keys in the PUA key lookup tables.
MozReview-Commit-ID: 9X7mZh3A0Qb
--HG--
extra : rebase_source : 3d1a41488ea3a813d2880be332545f854695bb23
In particular, XPCNativeWrapper should probably be made available
by default.
MozReview-Commit-ID: E1oYFyApbLi
--HG--
extra : rebase_source : 4e27ad6882bd4e43dadc97d4fd2a186e01510dfd
Instead of importing everything from the testing/marionette/error.js
module into the global scope, we need to be selective about what symbols
we want.
MozReview-Commit-ID: HZDAS0bs0GD
--HG--
extra : rebase_source : 14a300bb2cedc0716168d50846755a6faed83012
We want to ignore a certain subset of generated and legacy code
in testing/marionette, most notably testing/marionette/atom.js and
testing/marionette/legacyaction.js. Since the latter is scheduled for
removal, there is no need to spend extra time linting it.
MozReview-Commit-ID: OyRoM2uigG
--HG--
extra : rebase_source : 3ff2d45772358a12b526007910d980cfe6984a02
The eslint rules are based on the default, non-opinionated eslint rules
used throughout mozilla-central. The testing/marionette eslint rules
are a specialisation of these based on the current coding style used.
These should not be contradictory to the overall JS code style that can
be inferred from the existing code base.
MozReview-Commit-ID: 2rKabgXXnu4
--HG--
extra : rebase_source : 724544b60b71db7c7b093a1ed51ebc77bc66482d
Move HttpBackgroundChannelChild from main thread to socket transport thread.
Allow HttpChannelChild.mBgChild to be used on both main thread and STS thread under mutex protection.
MozReview-Commit-ID: 9WAXmJLr8HT
--HG--
extra : rebase_source : 774c71cec9d36412e2101719f5ca930a214f6472
Making ODA completely off-main-thread will make the order webRequest.onCompleted and CSS/JS execution unpredictable.
|window.requestIdleCallback| is used to fiddle the main thread event queue.
MozReview-Commit-ID: LIk0T96K6p1
--HG--
extra : rebase_source : 6a49660515d6b9fdb22a14174fb789e738d89f15
The implementations of browserAction, pageAction, and menu onClick
handlers now stash the current <browser> until we get a reply from
the extension process indicating that the handler has finished running.
We also have to take care to keep that <browser> around even if the
permissions api has to be loaded asynchronously.
MozReview-Commit-ID: BYJaiwdj40u
--HG--
extra : rebase_source : f0eb9522e532071a11c3424f8fffddf12300504f
Pinned tabs, when restored, load. This can have startup impact.
We should probably measure this.
To avoid impacting startup ourselves, do this when idle or after 60s from
session restore, whichever comes first.
MozReview-Commit-ID: EQzqqcz4IdL
--HG--
extra : rebase_source : 85158b6731862933027e90b1fe607a6794b68f52
If the tab was resumed before, it could start playing any autoplay media without user's
permission after session restore.
MozReview-Commit-ID: C3DHIIsLtJA
--HG--
extra : rebase_source : d415d26d9ddcc9cb2949eb3215aee74f4c85912c
When the block stauts of the window was changed, we would notify front-end side
to update the vaule, so that we can save it for session restore.
MozReview-Commit-ID: FyclKmAxZHf
--HG--
extra : rebase_source : 5ac8bb9d82279074939caed53dd79c072a5097bc
Since now we move the block/resume logic to front-end side, we can remove
the changing from bug1319771 and other related bugs which are used to ensure the
pinned tab should be blocked successfully after session restore.
MozReview-Commit-ID: Ixe7tOvCEhv
--HG--
extra : rebase_source : 4214c68b4c95df5c33bf1a68c9ffb84ee4c4d5aa
The "blocked" attribute is too general to indicate the real usage, so rename it
to "activemedia-blocked".
This attribute indicates that whether the tab has blocked the autoplay media.
MozReview-Commit-ID: 58U7DJSMtss
--HG--
extra : rebase_source : 762bfd2be06e21a964fd93076867b4f72a085adc
In gecko, it's possible to generate lots of animation ids per layer if animations are changed.
It also introduces lots of memory allocation/deallocation in CompositorAnimationStorage(HashTable).
Generate fixed animations id per layer should help the memory usage and reduce CPU time for memory allocation.
MozReview-Commit-ID: 1hWUD5gNBJH
--HG--
extra : rebase_source : bd3fcfed5caab5d8edfbd29a8e505daf9e8ff95f
The linker uses zlib. The linker is in mozglue, zlib is in libxul by
default. As a consequence, we made --with-system-zlib a requirement for
builds enabling the linker.
In the meanwhile, we added an option that makes zlib built in mozglue
for different needs, which, in fact, also allows to do that when the
linker is enabled.
So, allow to build without system zlib when the linker is enabled.
--HG--
extra : rebase_source : 873a87b17b306fc392018049e01cf794b63a6206
Since bug 1307886, we don't actually use szip anymore, and don't even
have the option to package Fennec using it. We can thus remove the
support for loading them, as well as on demand linkage.
The latter might mean we can remove the segfault handler, but it's
unclear whether this is currently working around other issues with
registering signal handlers, so we'll leave that to a followup.
--HG--
extra : rebase_source : ec23cd4e78f259a70f6690adc8dfabb557e8f304
