Commit Graph

61953 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
339814eda4 Bug 1427677: Get rid of nsContentUtils::HasDistributedChildren. r=bz
The whole function doesn't have much sense.

I killed its only DOM use in bug 1427511.

Now it only has two callers in nsCSSFrameConstructor, which basically only want
to know whether the children of the same node can have different flattened tree
parents.

So let's check that directly instead (checking whether the element has a binding
or a shadow root), and simplify a bit other surrounding code while at it.

Leave the XUL popup / menubar code doing the broken thing they were doing
beforehand, because it doesn't look to me like it's trivial to fix... They're
effectively assuming that the children of the menupopup end up in a single
insertion point, which is true, but doesn't need to be. Maybe they should walk
the DOM tree? Don't want to dig into that right now, since XUL insertion points
can be filtered and all that... Not fun.

Also, this removes the broken optimization that used to check
mParentFrame->GetContent()->HasChildren(), because it's pretty broken. It used
to be relevant before bug 653881, because <children> element used to not exist,
but now the insertion point at least needs to contain the <children> element all
the time.

There even used to be a XXX comment saying that the optimization didn't work,
which was removed in:

  https://hg.mozilla.org/mozilla-central/rev/2d8585ec74b3

We could still check for "no insertion points", and optimize that, but it
doesn't seem worth it.

MozReview-Commit-ID: L4lspkxKENr
2018-01-09 20:50:17 +01:00
Kartikaya Gupta
9881d74db7 Bug 1428765 - Fix scenario where display item clip chains hash to different values even though they are equal. r=mstange
MozReview-Commit-ID: KOBNjcuMUn

--HG--
extra : rebase_source : e9eff4dfe7b15bd46a9f02ae2555a96d76af4c37
2018-01-09 12:31:58 -05:00
Emilio Cobos Álvarez
7f790cf77a Bug 1428339: followup: Add missing include that busts some builds on a CLOSED TREE. r=me
MozReview-Commit-ID: AFaC5R2AZ8L
2018-01-09 17:50:39 +01:00
Emilio Cobos Álvarez
92b7f3d80f Bug 1425755: Add HTMLSlotElement to the bindgen-generated files on a CLOSED TREE. r=heycam
This allows to selector-match ::slotted.

MozReview-Commit-ID: ItELHkf2PMl
2018-01-09 17:33:08 +01:00
Henri Sivonen
381880a0e0 Bug 1428771 - Make UCS2_CHAR_IS_BIDI check for lead surrogates corresponding to U+1E800...U+1EFFF and rename to UTF16_CODE_UNIT_IS_BIDI. r=jfkthame
MozReview-Commit-ID: 9ZKF6SaN79n

--HG--
extra : rebase_source : 406f2647e65e2bdb97190b12564bafa6df39e6a8
2018-01-08 16:18:32 +02:00
Emilio Cobos Álvarez
63b7c47b72 Bug 1428339: Make attribute mapping work without a pres context. r=heycam
MozReview-Commit-ID: FisYWoArX0N

--HG--
extra : rebase_source : b47cd6960b9bb44fc4573b295068fec01339322a
2018-01-05 13:47:04 +01:00
Margareta Eliza Balazs
4687cec26a Backed out changeset 17660bff0c23 (bug 1423331) for 4 failures in layout/base/tests/test_reftests_with_caret.html r=backout on a CLOSED TREE 2018-01-09 17:49:00 +02:00
Margareta Eliza Balazs
5a9938931a Backed out changeset b047f4782ae2 (bug 1423331) for 4 failures in layout/base/tests/test_reftests_with_caret.html r=backout on a CLOSED TREE 2018-01-09 17:48:14 +02:00
Emilio Cobos Álvarez
70064701e8 Bug 1423331: Tests. r=mats
MozReview-Commit-ID: Ay4tUwSH0Iq

--HG--
extra : rebase_source : 7105701c7117b7b0826591187bf4b8879a805945
2017-12-17 02:48:49 +01:00
Emilio Cobos Álvarez
d563b8100b Bug 1423331: Prevent selection from leaking from blocks. r=mats
MozReview-Commit-ID: EFLXSQ8Zvze

--HG--
extra : rebase_source : 10b8ff4c0712e6880c69eafc49cf1a78d4dff4bd
2017-12-17 02:48:37 +01:00
Margareta Eliza Balazs
fe2caaa266 Merge inbound to mozilla-central r=merge a=merge 2018-01-09 11:52:55 +02:00
KuoE0
4c91f63774 Bug 1428960 - Use universal selector for -moz-dropdown-list r=heycam
-moz-dropdown-list is only allowed to use universal selector, so change
it back to universal selector.

MozReview-Commit-ID: 5E9Z98xIadh

--HG--
extra : rebase_source : fa6406cbe1b6bab582a1ee8dd2c7e89a4c66591e
2018-01-09 11:48:29 +08:00
KuoE0
e3413cd8d2 Bug 1425088 - (Part 3) Put the dropdown frame's placeholder into the principal child list of the combobox frame when content-select is enabled. r=mats
MozReview-Commit-ID: HJrltVmJCOj

--HG--
extra : rebase_source : 0ae4eefc39d43b1e8b08dfaa71aac264ab2d55bd
2018-01-05 17:50:38 +08:00
KuoE0
0bcba466df Bug 1425088 - (Part 2) Change the dropdown frame to a top-level absolute frame when content-select is enabled. r=mats
MozReview-Commit-ID: E77XdiELqhm

--HG--
extra : rebase_source : 19cc0bccf5dc4160e2b8dff9a710961d0cc38adc
2017-12-13 17:59:29 -06:00
Bogdan Tara
cd1c3cc5dd Merge mozilla-central to autoland, r=merge a=merge on a CLOSED TREE 2018-01-09 00:16:46 +02:00
Bogdan Tara
73b4d6b26a Merge inbound to mozilla-central r=merge a=merge 2018-01-09 00:05:31 +02:00
Andrea Marchesini
e10464a465 Bug 1419771 - Introduce DOMPrefs, a thread-safe access to preferences for DOM - part 22 - DOMPrefs initialized at startup, r=asuth 2018-01-08 14:05:07 +01:00
Andrea Marchesini
1b4b3007e5 Bug 1419771 - Introduce DOMPrefs, a thread-safe access to preferences for DOM - part 16 - Webkit/Blink directory picker enabled, r=asuth 2018-01-08 14:05:05 +01:00
Dorel Luca
04e91897cf Backed out 11 changesets (bug 1252998) for faling browser-chrome on browser/base/content/test/sanitize/browser_sanitize-offlineData.js
Backed out changeset a9ec63c01c50 (bug 1252998)
Backed out changeset a3e5299b882a (bug 1252998)
Backed out changeset aa511b206e21 (bug 1252998)
Backed out changeset 5875848a48ab (bug 1252998)
Backed out changeset 7fd2523680d1 (bug 1252998)
Backed out changeset a45e28e573a4 (bug 1252998)
Backed out changeset 92e8cc81b417 (bug 1252998)
Backed out changeset da38d133549e (bug 1252998)
Backed out changeset 5be23a98b47c (bug 1252998)
Backed out changeset 609093736110 (bug 1252998)
Backed out changeset f4955cf6447f (bug 1252998)

--HG--
rename : browser/base/content/test/sanitize/browser_purgehistory_clears_sh.js => browser/base/content/test/general/browser_purgehistory_clears_sh.js
rename : browser/base/content/test/sanitize/browser_sanitize-passwordDisabledHosts.js => browser/base/content/test/general/browser_sanitize-passwordDisabledHosts.js
rename : browser/base/content/test/sanitize/browser_sanitize-sitepermissions.js => browser/base/content/test/general/browser_sanitize-sitepermissions.js
rename : browser/base/content/test/sanitize/browser_sanitize-timespans.js => browser/base/content/test/general/browser_sanitize-timespans.js
rename : browser/base/content/test/sanitize/browser_sanitizeDialog.js => browser/base/content/test/general/browser_sanitizeDialog.js
2018-01-08 11:00:39 +02:00
Andrea Marchesini
1ac04372e5 Bug 1252998 - StorageActivityService - part 1 - Introduce StorageActivityService to monitor origin activities, r=asuth 2018-01-08 08:31:34 +01:00
Geoffrey Sneddon
8483ba3dd6 Bug 1427114 - Add missing ">" to unclosed meta element so WPT finds the test r=emilio
MozReview-Commit-ID: GOmRqqvgKsc

--HG--
extra : rebase_source : 6f147d518fcd103596a66e9e020c9f08d1c953d8
2018-01-06 22:30:42 +00:00
shindli
efed7156cc Merge mozilla-central to autoland. r=merge a=merge CLOSED TREE 2018-01-06 23:58:33 +02:00
shindli
ee57c0cd8a Merge inbound to mozilla-central r=merge a=merge 2018-01-06 23:46:15 +02:00
Emilio Cobos Álvarez
a68efc4059 Backout two changesets (Bug 1427677) until I prove they have no negative performance implication. r=backout
MozReview-Commit-ID: 3xuUAXVfEHd
2018-01-06 19:01:48 +01:00
Kartikaya Gupta
5a377242ca Bug 1422057 - Remove now-unnecessary ::Equals checks. r=mstange
Part of this is a backout of bug 1421054 which is no longer needed now
that we can assume equivalent clip items have identical pointer values.

MozReview-Commit-ID: BhnLVmVr4TX

--HG--
extra : rebase_source : b9bbb733fc69a0f15cd35d0265589aea257a5285
2018-01-06 09:52:59 -05:00
Kartikaya Gupta
bf9bed72dc Bug 1422057 - Deduplicate DisplayItemClipChain instances on creation. r=mstange
MozReview-Commit-ID: Fdr0m0uKxKR

--HG--
extra : rebase_source : 2c38e851ed261d67abffb8f1864fc9acd116da3e
2018-01-06 09:52:58 -05:00
Kartikaya Gupta
12596acf72 Bug 1422057 - Add hash function and boilerplate for deduplicating DisplayItemClipChain via std::set. r=mstange
MozReview-Commit-ID: I2eos3vwFF0

--HG--
extra : rebase_source : 79f99ef1d7fdc9a8f65703e880c66beea9b81de0
2018-01-06 09:52:58 -05:00
Kartikaya Gupta
25d94ecc40 Bug 1422057 - Adjust some logging-related things to be more useful. r=mstange
MozReview-Commit-ID: Idheevum5Fd

--HG--
extra : rebase_source : a441cc0b65c763763a4a417cc1d713cd771e467d
2018-01-06 09:52:57 -05:00
Emilio Cobos Álvarez
91be560d9c Bug 1427292: [css-display] Update display: contents on Unusual Elements to the spec. r=mats
This will pass[1] whenever the next WPT sync happens.

See: https://drafts.csswg.org/css-display/#unbox-html

[1]: https://github.com/w3c/web-platform-tests/blob/master/css/css-display/display-contents-unusual-html-elements-none.html

MozReview-Commit-ID: 19dqDSxVm7A
2018-01-06 21:52:51 +01:00
Emilio Cobos Álvarez
872ec24ce1 Bug 1428353: Allow undisplayed maps to be queried for elements out of the document. r=mats
MozReview-Commit-ID: 69lQNFk5vhG

--HG--
extra : rebase_source : 693f2537039045f765f8a40da84792bc1b60327f
2018-01-06 00:50:58 +01:00
Emilio Cobos Álvarez
7f7f3991e3 Bug 1427677: Get rid of nsContentUtils::HasDistributedChildren. r=bz
The whole function doesn't have much sense.

I killed its only DOM use in bug 1427511.

Now it only has two callers in nsCSSFrameConstructor, which basically only want
to know whether the children of the same node can have different flattened tree
parents.

So let's check that directly instead (checking whether the element has a binding
or a shadow root), and simplify a bit other surrounding code while at it.

Leave the XUL popup / menubar code doing the broken thing they were doing
beforehand, because it doesn't look to me like it's trivial to fix... They're
effectively assuming that the children of the menupopup end up in a single
insertion point, which is true, but doesn't need to be.

Maybe they should walk the DOM tree? Don't want to dig into that right now,
since XUL insertion points can be reordered and all that... Not fun.

MozReview-Commit-ID: L4lspkxKENr
2018-01-06 11:39:16 +01:00
Andreea Pavel
51d4c2d9ce Merge inbound to mozilla-central r=merge a=merge 2018-01-06 11:50:13 +02:00
Sebastian Hengst
6c6df154cd merge mozilla-central to mozilla-inbound. r=merge a=merge 2018-01-06 01:56:19 +02:00
Sebastian Hengst
d52c7b3231 merge inbound to central. r=merge a=merge 2018-01-06 00:27:10 +02:00
Emilio Cobos Álvarez
bab6ad290a Bug 1427824: Remove invalid assertion in presence of display: contents. r=bz
MozReview-Commit-ID: 4jFGHcD5wds

--HG--
extra : rebase_source : 23afb26dd3a93d4693def423a7ee3f3f95ed91a7
2018-01-05 19:12:42 +01:00
Emilio Cobos Álvarez
6b2dceda02 Bug 1427908: Never reenter synchronously into frame construction. r=bz
We remove async from the DOM all the time now since bug 1389743.

We could, before this patch, recurse into frame construction in a sync way, due
to the way we handle the weird insertion cases for <fieldset>, <details>, and
<mathml>.

This patch makes those also async, making the IssueSingleInsertNotifications
condition unnecessary.

MozReview-Commit-ID: LujPaYPwA4G

--HG--
extra : rebase_source : 3fc9dc9589a0c43f9f211e22873bf6b960d416f7
2018-01-03 05:51:12 +01:00
Kartikaya Gupta
c6e614c39a Bug 1413618 - Avoid possible division by zero. r=xidorn
MozReview-Commit-ID: JSTvMb3mM4P

--HG--
extra : rebase_source : 646429f399c47efef56ee9ae4e3b3bed410a9864
2018-01-08 05:59:08 -05:00
Boris Zbarsky
8a91a899cc Bug 1426525 part 4. Remove uses of 'ref' in XUL trees. r=gijs
MozReview-Commit-ID: He9RTzZMmSr
2018-01-05 13:48:39 -05:00
Coroiu Cristina
cf8d0654b4 Backed out 5 changesets (bug 1426525) for bustage at build/src/layout/xul/tree/nsTreeContentView.cpp r=backout on a CLOSED TREE
Backed out changeset 96efa1b6f4d5 (bug 1426525)
Backed out changeset 37fdd4a04f4e (bug 1426525)
Backed out changeset cee585723368 (bug 1426525)
Backed out changeset 85e218bf000c (bug 1426525)
Backed out changeset 501c70abf837 (bug 1426525)
2018-01-05 21:40:44 +02:00
Boris Zbarsky
d8f202f957 Bug 1426525 part 4. Remove uses of 'ref' in XUL trees. r=gijs
MozReview-Commit-ID: He9RTzZMmSr
2018-01-05 13:48:39 -05:00
Brad Werth
b61d32f5ef Bug 1423378 Part 1: Specially treat the explicit line names following a repeat auto-fit or auto-fill declaration to ensure they are always applied to the following line. r=mats
MozReview-Commit-ID: iFM5J6wRL6
2017-12-05 14:51:06 -08:00
Emilio Cobos Álvarez
0541db0072 Bug 1428164: followup: Simplify reftest reference. r=me
MozReview-Commit-ID: 8rgh0waQdAl
2018-01-05 11:59:23 +01:00
Emilio Cobos Álvarez
3e9fdd7ae2 Bug 1428164: Reftest. r=me
MozReview-Commit-ID: 5hm56QmtlnV
2018-01-05 11:57:49 +01:00
Emilio Cobos Álvarez
9cd802936b Bug 1428164: Restyle owned anon boxes after processing children. r=bz
MozReview-Commit-ID: 4QcJPY9hkSm
2018-01-05 11:57:47 +01:00
Tiberius Oros
0a895028f7 Merge inbound to mozilla-central r=merge a=merge 2018-01-05 11:57:58 +02:00
Andreea Pavel
b88f05e893 Backed out changeset 3a55b10a6974 (bug 106327) for build bustage on
/builds/worker/workspace/build/src/layout/xul/nsMenuFrame.cpp r=backout a=backout on a CLOSED TREE

--HG--
extra : amend_source : e09bf154093728898ad2c27dd185108f9ff3b009
2018-01-05 04:46:46 +02:00
Hiroyuki Ikezoe
ff1b1ade87 Bug 1420928 - Templatize functions that ensures nsStyleAutoArray length. r=boris
MozReview-Commit-ID: 7MvW9OCBkCP

--HG--
extra : rebase_source : 723092199ce780058b0f87bfd0c208987c847e47
2018-01-05 06:24:10 +09:00
Hiroyuki Ikezoe
9070574de9 Bug 1420928 - Drop StyleTransition::GetCombinedDuration. r=boris
We no longer call the function directly.  It has been replaced by
nsStyleDisplay::GetTransitionCombinedDuraion(uint32_t).

MozReview-Commit-ID: 9wZExWPmnyG

--HG--
extra : rebase_source : dff6b4e686578e7c79e16148ab3ab63b40444be7
2018-01-05 06:24:09 +09:00
Hiroyuki Ikezoe
3fe9a1ba97 Bug 1420928 - Reuse computed values for transition properties repeatedly if the computed values' length is less than transition-property length. r=boris
MozReview-Commit-ID: BptxzspwoP9

--HG--
extra : rebase_source : a1335be7d9750aadf23e33a7b12114eef53f2e64
2018-01-05 06:24:09 +09:00
Hiroyuki Ikezoe
13133e575b Bug 1420928 - Reuse computed values for animation properties repeatedly if the computed values' length is less than animation-name length. r=boris
MozReview-Commit-ID: DSmUlE9m0UI

--HG--
extra : rebase_source : 7fe6f42edf6da3d3dbb988c7d569272fdd6d56af
2018-01-05 06:24:09 +09:00