mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-26 03:35:33 +00:00
339814eda4
The whole function doesn't have much sense. I killed its only DOM use in bug 1427511. Now it only has two callers in nsCSSFrameConstructor, which basically only want to know whether the children of the same node can have different flattened tree parents. So let's check that directly instead (checking whether the element has a binding or a shadow root), and simplify a bit other surrounding code while at it. Leave the XUL popup / menubar code doing the broken thing they were doing beforehand, because it doesn't look to me like it's trivial to fix... They're effectively assuming that the children of the menupopup end up in a single insertion point, which is true, but doesn't need to be. Maybe they should walk the DOM tree? Don't want to dig into that right now, since XUL insertion points can be filtered and all that... Not fun. Also, this removes the broken optimization that used to check mParentFrame->GetContent()->HasChildren(), because it's pretty broken. It used to be relevant before bug 653881, because <children> element used to not exist, but now the insertion point at least needs to contain the <children> element all the time. There even used to be a XXX comment saying that the optimization didn't work, which was removed in: https://hg.mozilla.org/mozilla-central/rev/2d8585ec74b3 We could still check for "no insertion points", and optimize that, but it doesn't seem worth it. MozReview-Commit-ID: L4lspkxKENr |
||
|---|---|---|
| .. | ||
| base | ||
| build | ||
| doc | ||
| forms | ||
| generic | ||
| inspector | ||
| ipc | ||
| mathml | ||
| media | ||
| painting | ||
| printing | ||
| reftests | ||
| style | ||
| svg | ||
| tables | ||
| tools | ||
| xul | ||
| moz.build | ||