Commit Graph

7983 Commits

Author SHA1 Message Date
Simon Fraser
65cbd9e05b Bug 1643625 Clear up references to MAR_OLD_FORMAT in packaging tools r=nthomas
I think we don't need these checks any more.

Differential Revision: https://phabricator.services.mozilla.com/D78480
2020-06-11 22:23:10 +00:00
Sylvestre Ledru
74abdddf45 no bug - mozlint/clippy - Add smoosh to the clippy list r=arai
Differential Revision: https://phabricator.services.mozilla.com/D79297
2020-06-11 17:02:34 +00:00
Sylvestre Ledru
2ad15eb452 Bug 1644809 - mozlint/clippy handle the summary r=marco
Differential Revision: https://phabricator.services.mozilla.com/D79166
2020-06-11 12:29:10 +00:00
Sylvestre Ledru
1a628a1b02 Bug 1644799 - mozlint/clippy Add a debug message containing the clippy version r=marco
Differential Revision: https://phabricator.services.mozilla.com/D79161
2020-06-11 12:27:57 +00:00
Myeongjun Go
70a902e23f Bug 1641933 - [pefrdocs] add desciptions to perfdocs using single letter r=sparky,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D78614
2020-06-10 20:40:31 +00:00
Razvan Maries
ef73a88351 Backed out changeset 37a5223eda5f (bug 1643625) for Rpk bustages. CLOSED TREE 2020-06-09 18:30:01 +03:00
Ted Campbell
b3e185db5d Bug 1644218 - Add blinterp implementation tracking to profiler r=jandem,gerald
Introduce an IS_BLINTERP_FRAME flag to ProfilingStackFrame to distinguish C++
and Baseline interpreter frames. In the profile data this sets the
"implementation" to "blinterp".

Differential Revision: https://phabricator.services.mozilla.com/D78725
2020-06-09 12:27:15 +00:00
Simon Fraser
1422db5e20 Bug 1643625 Clear up references to MAR_OLD_FORMAT in packaging tools r=nthomas
I think we don't need these checks any more.

Differential Revision: https://phabricator.services.mozilla.com/D78480
2020-06-09 11:53:26 +00:00
Mitchell Hentges
300422099b Bug 1632429: Improves update-verify compatibility with python 3 r=nthomas
Depends on D77962

Differential Revision: https://phabricator.services.mozilla.com/D77964
2020-06-08 21:07:07 +00:00
Adam Gashlin
e34730166a Bug 1643188 - Require MOZ_PRODUCT_VERSION and MAR_CHANNEL_ID for update scripts. r=sfraser
Differential Revision: https://phabricator.services.mozilla.com/D78209
2020-06-05 08:58:53 +00:00
Adam Gashlin
c0a419ebb4 Bug 1643211 - Don't use BCJ on patches. r=sfraser
Differential Revision: https://phabricator.services.mozilla.com/D78213
2020-06-07 23:15:45 +00:00
Simon Giesecke
13502cf27c Bug 1642991 - Use RemoveElementsBy where easily possible. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D78055
2020-06-08 09:01:48 +00:00
Andrew Halberstadt
4c9338072f Bug 1633866 - [tryselect] Use 'bugbug' loader with |mach try auto|, r=marco
Enables manifest-scheduling with |mach try auto| pushes.

Differential Revision: https://phabricator.services.mozilla.com/D76525
2020-06-03 21:00:43 +00:00
Nazım Can Altınova
e3ea64b9cb Bug 1642677 - Remove the unneeded java sampler pause/unpause during the serialization. r=gerald
Now we are pausing the profiler just before capturing the profile data. Android
sampler will never be running when this code is being run

Depends on D78037

Differential Revision: https://phabricator.services.mozilla.com/D78038
2020-06-04 09:34:32 +00:00
Nazım Can Altınova
7409a37a20 Bug 1642677 - Make the profiler_{pause,resume} control android sampler as well. r=gerald
Depends on D78036

Differential Revision: https://phabricator.services.mozilla.com/D78037
2020-06-03 12:48:26 +00:00
championshuttler
b8d9ae4413 Bug 1643074 - Add a copy button to firefox docs to copy commands. r=firefox-source-docs-reviewers,ahal
Differential Revision: https://phabricator.services.mozilla.com/D78110
2020-06-03 19:22:03 +00:00
Tom Ritter
e86495e2a0 Bug 1642704 - Make ./mach try fuzzy --update install if fzf is not present r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D77856
2020-06-03 19:14:48 +00:00
Gregory Mierzwinski
cf5ee680a4 Bug 1642964 - Add small README file to tools/browsertime. r=tarek
This patch adds a small README file to the tools/browsertime folder to give people more information about its purpose and provides a link to the perftest wiki.

Depends on D78044

Differential Revision: https://phabricator.services.mozilla.com/D78045
2020-06-03 12:51:41 +00:00
Gregory Mierzwinski
44d2279d2e Bug 1642963 - Add bugzilla componenet to tools/browsertime code. r=tarek
This patch adds the Testing :: Raptor component to all files under `tools/browsertime`.

Differential Revision: https://phabricator.services.mozilla.com/D78044
2020-06-03 12:50:45 +00:00
Andrew McCreight
8eefcc3e76 Bug 1642631 - Make the message argument to Channel::Send() a UniquePtr. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D77876
2020-06-02 21:23:08 +00:00
Mitchell Hentges
9bc6040a9c Bug 1642517: Resolves |mach try scriptworker| py3 issue r=rstewart
When python2 interprets headers here, it will attempt to encode values into a string in a blanket fashion.

In this case, the `Accept` header is encoded into an invalid value, but it "works".

Python3 validates more strictly, and throws an error when an array is encountered as a value here. Formatting it
as a valid string instead resolves the problem.

Differential Revision: https://phabricator.services.mozilla.com/D77735
2020-06-02 13:54:33 +00:00
Christian Holler
4b5d643db0 Bug 1641169 - Update fuzzing interface documentation. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D77007
2020-06-02 12:52:19 +00:00
Bob Clary
5cd323cd6f Bug 1642044 - Python 3 tools/rb/fix_stacks.py r=gbrown
Depends on D77660

Differential Revision: https://phabricator.services.mozilla.com/D77661
2020-06-01 23:14:05 +00:00
Bob Clary
450ddd2d42 Bug 1642044 - Python 3 tools/rb/find_leakers.py r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D77660
2020-06-01 23:14:30 +00:00
Sylvestre Ledru
2d448bf2fb Bug 1640532 - Update codespell to 1.17.1 r=linter-reviewers,ahal
Depends on D76637

Differential Revision: https://phabricator.services.mozilla.com/D76638
2020-06-02 04:16:58 +00:00
Ricky Stewart
7bee84802f Bug 1641992 - Add argument to mach busted file to specify which component the bug should be filed against r=froydnj
With the addition of this change, a lone `mach busted file` will throw an error (since this should only ever be used by actual humans, and not in automation or anything, the backwards-compatibility breakage isn't a huge deal). Now it's expected to pass in `mach busted file $COMMAND`, where $COMMAND is the mach command that you were running when the error occurred, and we'll figure out which bugzilla component to file the bug against for you instead of directing it to `Firefox Build System :: General` regardless of whether the issue has *anything* to do with the build system. We preserve `mach busted file general` as a backup command that doesn't do any of this heavy logic.

Differential Revision: https://phabricator.services.mozilla.com/D77538
2020-06-01 16:23:48 +00:00
Nicolas Silva
380426b6a1 Bug 1641224 - Add webrender-perf try preset. r=kats
./mach try --preset webrender-perf runs the following tasks:

- test-linux64-shippable-qr/opt-raptor-motionmark-animometer-firefox-e10s
- test-linux64-shippable-qr/opt-talos-g1-e10s
- test-linux64-shippable-qr/opt-talos-g4-e10s
- test-linux64-shippable-qr/opt-talos-svgr-e10s
- test-linux64-shippable-qr/opt-talos-tp5o-e10s
- test-linux64-shippable-qr/opt-talos-webgl-e10s
- test-windows10-64-shippable-qr/opt-raptor-motionmark-animometer-firefox-e10s
- test-windows10-64-shippable-qr/opt-talos-g1-e10s
- test-windows10-64-shippable-qr/opt-talos-g4-e10s
- test-windows10-64-shippable-qr/opt-talos-svgr-e10s
- test-windows10-64-shippable-qr/opt-talos-tp5o-e10s
- test-windows10-64-shippable-qr/opt-talos-webgl-e10s

Differential Revision: https://phabricator.services.mozilla.com/D77265
2020-05-28 15:13:26 +00:00
Agi Sferro
582feb1629 Bug 1575999 - Always run javadoc tasks during lint. r=nalexander,esawin
Differential Revision: https://phabricator.services.mozilla.com/D77489
2020-06-01 15:58:03 +00:00
Agi Sferro
519207a6a8 Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp,esawin
`|mach lint -f treeherder|` expects lint to not fail ever, if a lint fails it's
just ignored. This means that when our javadoc errors out and fails the build
all lints are ignored.

To avoid that we add `failOnError = false` to the javadoc job so that we can
finish the build and actually report the errors.

This patch also adds gradle output `|mach lint|` to make it easier to
diagnose errors in the lint.

Differential Revision: https://phabricator.services.mozilla.com/D77373
2020-06-01 15:58:13 +00:00
Andrew Halberstadt
b2e6e5eb9d Bug 1641134 - [tryselect] Fix Python 3 compatibility issues with |mach try --pernosco|, r=mhentges
Differential Revision: https://phabricator.services.mozilla.com/D77364
2020-05-29 20:45:36 +00:00
Myeongjun Go
f747fd8867 Bug 1640684 - [perfdocs] Display all raptor tests for each suite in a list r=sparky,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D77461
2020-06-01 11:12:48 +00:00
Gregory Mierzwinski
115d1b4294 Bug 1641566 - Update in-tree browsertime to latest. r=tarek,perftest-reviewers,Bebe
Differential Revision: https://phabricator.services.mozilla.com/D77257
2020-05-29 12:24:33 +00:00
Mark Smith
9b6b44fb8b Bug 1641329 - Add -q option to MAR generation scripts r=nthomas
Differential Revision: https://phabricator.services.mozilla.com/D77138
2020-05-29 13:18:46 +00:00
Bogdan Tara
f863a91210 Backed out changeset 2548f39e1751 (bug 1641711) for lints.py failure CLOSED TREE 2020-05-29 12:37:18 +03:00
Agi Sferro
465a4e3f1a Bug 1641711 - Don't fail the build if javadoc fails. r=nalexander,snorp
`|mach lint -f treeherder|` expects lints to not fail ever, if a lint fails it's
just ignored. This means that when our javadoc errors out and fails the build
all lints are ignored.

To avoid that we add `failOnError = false` to the javadoc job so that we can
finish the build and actually report the errors.

This patch also adds gradle output `|mach lint|` to make it easier to
diagnose errors in the lint.

Differential Revision: https://phabricator.services.mozilla.com/D77373
2020-05-29 00:24:22 +00:00
Geoff Brown
06278cbfec Bug 1634603 - [tryselect] Fix 'mach try coverage'; r=marco
Use up-to-date URL for code-coverage information and fix miscellaneous bit-rot.

Differential Revision: https://phabricator.services.mozilla.com/D77270
2020-05-28 18:50:49 +00:00
Andrew McCreight
7482de916e Bug 1641090, part 5 - Make IDMap::Remove match nsTHashtable's behavior. r=nika
nsTHashtable::Remove doesn't assert if the item isn't present. Match that
behavior by removing the assert and putting it at all of the call sites.

This just turns IDMap::Remove into RemoveIfPresent, so merge them.

Differential Revision: https://phabricator.services.mozilla.com/D77166
2020-05-28 15:55:01 +00:00
Andrew McCreight
1fc2cdf98d Bug 1641090, part 4 - Make AddWithID compatible into Put. r=nika
This function is similar to the Put() method in nsTHashtable, but it lists the
key second and it asserts that the key is not already in the map. This patch
swaps the arguments and hoists the assertion out, where appropriate. Note that
there are a few places that were working around this assert, so for those places
don't include the assert.

Differential Revision: https://phabricator.services.mozilla.com/D77165
2020-05-28 15:54:59 +00:00
Csoregi Natalia
a90f898b91 Backed out changeset 14084268455c (bug 1639165) for multiple console related failures. CLOSED TREE 2020-05-28 17:08:41 +03:00
nchevobbe
64b135f38b Bug 1639165 - Don't log message from ContentChild when multiprocess browser toolbox is enabled. r=baku.
Differential Revision: https://phabricator.services.mozilla.com/D76792
2020-05-28 10:01:14 +00:00
Gerald Squelart
315b834a0e Bug 1586939 - Remove "_BASE" from most Base Profiler env-vars - r=gregtatum a=reland CLOSED TREE
Now both profilers are controlled by the same environment variables, e.g.
"MOZ_PROFILER_STARTUP" to run both profilers at startup.

The only remaining Base Profiler-specific commands are:
- MOZ_BASE_PROFILER_HELP, because the Base Profiler doesn't have the same
  capabilities as Gecko, so it may display different available features.
- MOZ_BASE_PROFILER_LOGGING, because the Base Profiler doesn't have access to
  MOZ_LOG (both the env-var and the C++ macros).

Differential Revision: https://phabricator.services.mozilla.com/D54449
2020-05-28 03:39:32 +00:00
Razvan Maries
cfc05656e9 Backed out 2 changesets (bug 1586939) for build bustages on ProtocolFuzzer.h. CLOSED TREE
Backed out changeset 1f66a6a498e5 (bug 1586939)
Backed out changeset 6e1337767992 (bug 1586939)
2020-05-28 07:38:04 +03:00
Gerald Squelart
3f2fbaa757 Bug 1586939 - Remove "_BASE" from most Base Profiler env-vars - r=gregtatum
Now both profilers are controlled by the same environment variables, e.g.
"MOZ_PROFILER_STARTUP" to run both profilers at startup.

The only remaining Base Profiler-specific commands are:
- MOZ_BASE_PROFILER_HELP, because the Base Profiler doesn't have the same
  capabilities as Gecko, so it may display different available features.
- MOZ_BASE_PROFILER_LOGGING, because the Base Profiler doesn't have access to
  MOZ_LOG (both the env-var and the C++ macros).

Differential Revision: https://phabricator.services.mozilla.com/D54449
2020-05-28 03:39:32 +00:00
Nicholas Nethercote
9404f0620e Bug 1636859 - Shut down the fix-stacks child process when fix_stacks.py exits. r=glandium
Hopefully this will avoid some intermittent failures that occur when
`fix-stacks` is deleted at the end of a test run.

Differential Revision: https://phabricator.services.mozilla.com/D76980
2020-05-28 00:34:30 +00:00
Greg Tatum
3802fc82a4 Bug 1640274 - Remove the unused TrackOptimizations profiler; r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D76854
2020-05-27 22:08:49 +00:00
Greg Tatum
ca8ec92461 Bug 1571086 - Remove privacy feature from the profiler; r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D76853
2020-05-27 22:07:57 +00:00
Toshihito Kikuchi
a2f2d585ea Bug 1509748 - Do not touch ntdll's PE header directly if EAF+ is enabled. r=mhowell,mstange
If EAF+ is enabled for firefox.exe, the process does not launch because we parse
the PE headers of ntdll.dll at startup, which is prohibited by EAF+.

With this patch, we skip two operations when EAF+ is enabled.

The first one is to cache ntdll's IAT at startup.  Because EAF+ is expected to
prevent an injected module from parsing PE headers and modifying IAT, we can skip
this caching safely.

The second one is to load ntdll's debug information for the profiler.  With this
patch, the profiler's callstack will not show a raw address instead of a symbol
name.  It's a bad side effect, but much better than startup crash.

Differential Revision: https://phabricator.services.mozilla.com/D76959
2020-05-27 21:48:35 +00:00
Gerald Squelart
cf61fd1e10 Bug 1641122 - Fix 32-bit Android profiler buffer size default - r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D77016
2020-05-27 19:41:46 +00:00
Dzmitry Malyshau
abaaa872a5 Bug 1634425 - Integrate WebGPU API tracing r=jgilbert
This is the logic of tracing the WebGPU API calls at the level of wgpu-core,
serialized into a folder of choosing on the user drive. Traces are extremely portable,
they can be shared (on BugZilla) and then replayed on the developer machine,
which can have a different architecture from the users machine.

The standalone player is introduced in `gfx/wgpu/player`, similar to WebRender's Wrench.

The output dir is controlled by "dom.webgpu.traceDir" pref. No tracing happens if it's empty.

Differential Revision: https://phabricator.services.mozilla.com/D73333
2020-05-27 16:49:03 +00:00
Bogdan Tara
6ed3c943f7 Backed out changeset f4ed4d3e0e9e (bug 1634425) for hazard failure on WebGPUParent.cpp CLOSED TREE 2020-05-27 01:12:40 +03:00