Commit Graph

563910 Commits

Author SHA1 Message Date
Brendan Dahl
357f877106 Bug 1399956 - Support synthesized scroll events. r=jrmuizel
Fixes test_bug1151667.html

MozReview-Commit-ID: 8lCHNTA8zIL
2017-10-16 16:15:45 -07:00
Brendan Dahl
45352c7de8 Bug 1399956 - Default to san-serif for headless font. r=jrmuizel
Fixes problem with the initial computed value of font-family
being empty and not matching the later value in
test_value_storage.html.

MozReview-Commit-ID: HOHvMZPP1GD
2017-10-16 16:15:45 -07:00
Brendan Dahl
18db282eaa Bug 1399956 - Add logging to headless widget. r=jrmuizel
Use similar logging to the various nsWindows to make
debugging easier.

MozReview-Commit-ID: 5AsaehQsOtA
2017-10-16 16:15:45 -07:00
Brendan Dahl
72ed58e8b8 Bug 1399956 - Add basic hard coded GTK theme in headless. r=jrmuizel
Many tests rely on the minimum size of widgets to
be set. Also, the precise size seems to matter for some
tests that have hard coded offsets.

MozReview-Commit-ID: BglZD1cKdY9
2017-10-16 16:15:45 -07:00
Brendan Dahl
d9e05f42d9 Bug 1399956 - Support synthesized mouse events. r=jrmuizel
Fixes:
 - test_pointerlock-api.html
 - test_group_mouseevents.html

MozReview-Commit-ID: 82RKzjJv9X1
2017-10-16 16:15:45 -07:00
Brendan Dahl
f2ed681b19 Bug 1399956 - Track top level windows in headless mode for window ordering. r=jrmuizel
This better emulates a window manager and triggers the
required activated/deactivated events on the proper windows as
they are closed or hidden.

MozReview-Commit-ID: 1A2JTp8i4VE
2017-10-16 16:15:45 -07:00
Kris Maglione
e74866a836 Bug 1405286: Part 4 - Don't overwrite existing state with finishedtransferringdata. r=mixedpuppy
In cases where data transfer finishes immediately after we close a request, we
can sometimes wind up overwriting that state information with
"finishedtransferringdata", which allows scripted callers to break certain
invariants and cause crashes.

MozReview-Commit-ID: Do3GttF3M9S

--HG--
extra : rebase_source : 22ef41b1655641fb5f73034d076f3bb6e148a626
extra : absorb_source : 5ca805e93d4d5feed9a5bd7e7f292104cd1bdd11
2017-10-14 20:01:18 -07:00
Kris Maglione
f0b1b98a83 Bug 1405286: Part 3 - Test that filterResponseData from cached onHeadersReceived doesn't crash. r=mixedpuppy
It currently isn't possible to suspend a channel from onHeadersReceived for a
cached response. And since it's not possible to add a new stream filter after
a response has started, adding a stream filter at that point will crash if the
channel is still registered.

This test is a basic sanity check for that scenario.

MozReview-Commit-ID: ALYUtxX7mci

--HG--
extra : rebase_source : 120889fd8f9edd097a7dae807b54eb3fd283f0f6
2017-10-14 19:25:35 -07:00
Kris Maglione
3967e13d94 Bug 1405286: Part 2 - Ensure ordered processing of StreamFilter events. r=mixedpuppy
Our current StreamFilter code doesn't behave well when data delivery is
targeted to a thread pool, rather than a single thread.

Thread pools don't guarantee ordered processing of events. It's theoretically
always possible for multiple events dispatched to a pool to be processed in
parallel, or even slightly out of order.

For the most part, this should only be a theoretical concern, unless several
data events are dispatched at the same time, and the pool has enough available
threads to service all of them (which is an unlikely scenario in this code).
However, when data delivery is targeted to a thread pool, the OnDataAvailable
callbacks do not have access to the thread pool itself, only the thread that
the callback was dispatched to. This means that after each OnDataAvailable
call, we likely store a new IO thread, and writes end up queued to a different
single thread depending on exactly when they happen.

Threads in thread pools often wind up executing long-running runnables, such
as synchronous IO or network operations. Which means that we introduce
arbitrary delays for some writes, and are likely to wind up with highly
arbitrary ordering.


This patch solves both of these problems by introducing strict event queue
ordering, and also dispatching IO events to the original explicit delivery
target, rather than whatever the current thread happened to be at the time of
the last data event.

MozReview-Commit-ID: 1SdYjS6ltqw

--HG--
extra : rebase_source : a92aeff88b21ad41f2eef71a732fdf60f447789a
2017-10-14 18:58:53 -07:00
Kris Maglione
635fc0e1ae Bug 1405286: Part 1 - Allow retrieving the delivery target from retargetable requests. r=dragana
After data delivery for a request has been retargeted, there's no reliable way
to get the appropriate event target to re-dispatch data events after
asynchronous processing.


While it's technically possible to retrieve the current thread from
OnDataAvailable callbacks and re-use that for later dispatch, that approach
has some issues:

1) It's not currently possible to reliably map the current thread to the
thread pool that owns it. That means that if data delivery is being targetted
to a thread pool, attempts to redispatch events to the previous delivery
thread might lead to long delays when one thread in a pool is blocked.

2) If a filter wishes to dispatch data events to the wrapped listeners before
it's recieved any data (as extensions StreamFilters sometimes do), there's no
way to determine the proper event target without waiting for initial data to
be received.


Simply returning the correct event target from the request solves both of
these problems.

MozReview-Commit-ID: CJxq7O4399R

--HG--
extra : rebase_source : db2f659ecad16daafdbcc108d7b1a51ea1af31f9
2017-10-14 18:30:38 -07:00
Sebastian Hengst
05889a48b5 Backed out changeset 3df6520e217f (bug 1408468) for failing shape highlighter related tests, e.g. xpcshell's devtools/server/tests/unit/test_shapes_highlighter_helpers.js. r=backout
--HG--
extra : amend_source : 7de8f44cf8e6efd015cfd9c21f0a817fdaeaf962
2017-10-17 00:34:11 +02:00
Sebastian Hengst
a32d6e8b12 Backed out changeset d9ab5b748c99 (bug 1408468) 2017-10-17 00:33:53 +02:00
Sebastian Hengst
379eb7d3d6 Backed out changeset a52945a497c8 (bug 1408562) for leak in dt1 job on Linux x64 asan. r=backout on a CLOSED TREE
--HG--
extra : amend_source : de81f48b29a820fb46ace77295911344902ed202
2017-10-17 00:05:09 +02:00
Kris Maglione
bb49a293fc Bug 1404198: Follow-up: Fix more OS-X build bustage on a CLOSED TREE r=bustage
--HG--
extra : amend_source : 2ab5881c9eae6b689a0c45c33b3faeb398b5eeaf
2017-10-16 14:56:50 -07:00
Gabriel Luong
45b8022b6e Bug 1408468 - Part 2: Fix eslint errors in shapes.js and doc_inspector_highlighter_csshapes_iframes.html. r=me CLOSED TREE 2017-10-16 17:38:40 -04:00
Kris Maglione
12085d8c3d Bug 1404198: Follow-up: Fix OS-X build bustage. r=bustage
MozReview-Commit-ID: EUSy85iEkCb

--HG--
extra : amend_source : af963cc82ac558bfde4e2538d853cceff0ba3b52
2017-10-16 14:30:31 -07:00
Kearwood Gilbert
f379b8fea9 Bug 1402871 - Change VREventObserver::mWindow to a RefPtr,r=dveditz
MozReview-Commit-ID: 79MlNMAvIQD

--HG--
extra : rebase_source : 717bed76ca218844d4308e616ee5a7bb2a59591c
2017-10-11 14:25:51 -07:00
Matthew Gregan
28e8f43756 Bug 1408821 - Allow FIONBIO ioctl from the content sandbox. r=jld
--HG--
extra : rebase_source : c6a1b525bc7d9207583200fd5d5059a8155b889f
2017-10-16 14:54:46 +13:00
Mike Park
e1f01572eb Bug 1408468 - Shapes highlighter handles for shapes in iframe cannot be clicked outside iframe. r=gl
MozReview-Commit-ID: 3J4J6vM96sj
2017-10-13 13:19:50 -04:00
Jonathan Watt
a13d2f1feb Bug 1409121 - Include the generated WebIDL and IPDL source files in Eclipse CDT. r=botond DONTBUILD NPOTB
MozReview-Commit-ID: Er2rCZs45N3

--HG--
extra : rebase_source : b10e2a66feae29380fe321d83d28586e474e5846
2017-09-29 20:07:40 +01:00
Kris Maglione
4a767c7e6e Bug 1404198: Part 2j - Switch to NS_NewTimer* everywhere else. r=njn
MozReview-Commit-ID: LmGIgfmNSmk

--HG--
extra : rebase_source : bf34e852beb0c8f6eafd09184c2e0cda95f95f83
2017-09-24 19:57:48 -07:00
Kris Maglione
60d080b412 Bug 1404198: Part 2i - Switch to NS_NewTimer* in dom. r=njn
MozReview-Commit-ID: 8Oei6TuXNbu

--HG--
extra : rebase_source : 31c583c699790cbcf302064146d313ee8126ef0c
2017-10-15 23:15:40 -07:00
Kris Maglione
9204ca3e99 Bug 1404198: Part 2h - Switch to NS_NewTimer* in gfx. r=njn
MozReview-Commit-ID: 3EUyHzdkbqH

--HG--
extra : rebase_source : 7d64b5b7ad0033e7ce6661be7993498fd9835060
2017-10-15 23:15:12 -07:00
Kris Maglione
9184710ae5 Bug 1404198: Part 2g - Switch to NS_NewTimer* in media. r=njn
MozReview-Commit-ID: 3ydSj5HfYzZ

--HG--
extra : rebase_source : 6d38da71d3c82b900b46e69c12ceb81202dd965d
2017-10-15 23:14:33 -07:00
Kris Maglione
6eccf17f33 Bug 1404198: Part 2f - Switch to NS_NewTimer* in toolkit. r=njn
MozReview-Commit-ID: 185rZ99R6zV

--HG--
extra : rebase_source : 5af93b6f4b115be6b970563aedc94ec8a65f527d
2017-10-15 23:14:00 -07:00
Kris Maglione
663e9cb7fa Bug 1404198: Part 2e - Switch to NS_NewTimer* in layout. r=njn
MozReview-Commit-ID: 2WxyAXpJ3Fg

--HG--
extra : rebase_source : 4166c82c86558f79a4b41566a9997584e5fc94cf
2017-10-15 23:13:31 -07:00
Kris Maglione
c2da8a30a3 Bug 1404198: Part 2d - Switch to NS_NewTimer* in widget. r=njn
MozReview-Commit-ID: G4S8q9DYPS0

--HG--
extra : rebase_source : 9c6da05bf2ef3cfee551879879330a85688b1f5d
2017-10-15 23:12:54 -07:00
Kris Maglione
d1f06996d7 Bug 1404198: Part 2c - Switch to NS_NewTimer* in necko. r=njn
MozReview-Commit-ID: 3YyyaBAEjHc

--HG--
extra : rebase_source : 8ea5a8adb4d134ae15041f86f0b185603ab9a989
2017-10-15 23:12:02 -07:00
Kris Maglione
f6ba082a01 Bug 1404198: Part 2b - Switch to NS_NewTimer* in xpcom. r=njn
MozReview-Commit-ID: BEtHEpOmT1E

--HG--
extra : rebase_source : dac8a182f1ad76df6715146e1da1279c02c0406f
2017-10-15 23:11:22 -07:00
Kris Maglione
3c7ea8250b Bug 1404198: Part 2a - Add non-virtual constructors for nsITimer. r=njn
MozReview-Commit-ID: 3I7MAquvMHj

--HG--
extra : rebase_source : 9fb92a49fb9b89aec738aca5f77ef3a612802df6
2017-10-15 23:10:17 -07:00
Kris Maglione
3876d40960 Bug 1404198: Part 1 - Add non-virtual constructor for nsIObject(Input|Output)Stream and update existing callers. r=njn
MozReview-Commit-ID: 3eoh6AwDJyz

--HG--
extra : rebase_source : 92b18b6ef07d276cac79ce735ca0b592cffbf87e
2017-10-04 20:06:28 -07:00
Jonathan Watt
d52de87818 Bug 1408795 - Disable Eclipse CDT's binary parser. r=botond DONTBUILD NPOTB
By default Eclipse CDT will scan the source tree for binaries so that it can
add those binaries to the list of things that it can run.  This scanning is a
constant interuption and can last several seconds.  Besides that, it's
currently useless for our setup since the only binaries that we're interested
in running are in the object directory (which it doesn't scan), and those are
set up during project generation.  (The only binaries found in the source tree
are a couple of uninteresting bundled libraries.)

CLOSED TREE

MozReview-Commit-ID: 2WaH8qceALq
2017-09-28 11:10:43 +01:00
Jonathan Watt
35625e155f Bug 1408795 - Disable Eclipse CDT's "scalability" mode for files with fewer than 15,000 lines. r=botond
By default, scalability mode is activated for files with 5,000 lines or more.
There are quite a few C++ files with more than 5,000 lines, and Eclipse seems
to work fine with them with scalability mode turned off (even
nsCSSFrameConstructor.cpp which is over 13,000 lines long).  Increasing the
number of lines before scalability mode is enabled allows Eclipse to handle
these files better.

MozReview-Commit-ID: 8mGYIHStHes
2017-09-28 10:57:30 +01:00
Jonathan Watt
a6c2da4491 Bug 1408795 - Have Eclipse CDT treat Objective-C files as C++. r=botond
Without this setting, eclipse will refuse to open Objective-C files (it will
defer to an external editor).  Adding *.mm to the file types that are treated
as C++ allows Eclipse to open them, and to provide some code assistance for
the bits of the files that it can understand.

MozReview-Commit-ID: ASeXesWxY4g
2017-09-28 10:36:53 +01:00
Jonathan Watt
c8b6a31ed6 Bug 1408795 - Enable Eclipse CDT's "Refresh using native hooks or polling" setting. r=botond
This setting allows Eclipse to notice when files it has open are changed
externally (such as by hg/git, for example).  It can then update the contents
that it has for the open files, avoiding annoying issues such as saving changes
after an `hg pull -u` resulting in either "Resource is out of sync" errors or
else clobbering of the changes hg made to files.

MozReview-Commit-ID: 8WmewM7lbHe
2017-09-28 10:12:47 +01:00
Jonathan Watt
2673974e60 Bug 1408795 - Prevent Eclipse CDT's blocking "Welcome" screen from showing on startup. r=botond
The blocking Welcome screen is quite confusing for a new user. It is not clear
where to find the Mozilla stuff they expect to see when opening Eclipse, or
that the user needs to close the entire content area to get to it. Besides that
the screen isn't very useful for Mozilla people who will find more relevant
help from searching the online documentation, and who won't be creating new
projects in the generated workspace, etc.

MozReview-Commit-ID: 8YssnonAR1d
2017-09-28 09:53:08 +01:00
Jonathan Watt
a95425e42c Bug 1408795 - Turn off Eclipse CDT's "Ensure newline at the end of file" setting. r=botond
The setting to ensure that there is a newline at the end of files when they
are saved is very annoying.  Besides adding unnecessary and unexpected cruft
to diffs, some parts of the codebase (some of the reftest directories for
example) have a policy of NOT having a newline at the end of their files.

MozReview-Commit-ID: IjIYxDsKS13
2017-09-28 09:37:10 +01:00
Jonathan Watt
c0331fe643 Bug 1408810 - Get the Eclipse CDT code formatter working again. r=botond
This makes us write the code formatter settings into the workspace settings
directory instead of the project settings directory.  This is preferable
since when users make settings changes they are more likely to work with the
workspace settings, so we should put them there.  Putting them there also
fixes a bug whereby the calls to _write_noindex/_remove_noindex would
overwrite the formatter settings file shortly after it had been created.

To get the formatter to show up in the UI we also need to set the formatter
settings as a one line pref value in the CDT UI settings.  This duplication
is what Eclipse does when a new formatter is manually added, and it's
necessary to get the formatter working correctly.

MozReview-Commit-ID: KP4w0VbNCF7
2017-09-27 19:43:16 +01:00
Boris Zbarsky
32ad6dfdd7 Back out bug 1354730 to reopen CLOSED TREE.
MozReview-Commit-ID: RzUofi384C
2017-10-16 14:34:23 -04:00
Boris Zbarsky
7ee7285acd Bug 1354730 followup. Update out-of-date assertions to fix bustage and reopen CLOSED TREE.
MozReview-Commit-ID: GTMSGnL3gsB
2017-10-16 13:18:14 -04:00
Neil Deakin
8c937c2917 Bug 1404999, force command updating to be enabled when a menu is opened, r=mconley 2017-10-16 11:44:59 -04:00
Joel Maher
b5c9bf0e08 Bug 1387827 - Disable 2 devtools tests on coverage builds for frequent timeouts. r=gbrown, a=test-only 2017-10-16 11:42:23 -04:00
David Major
fe61232e43 Bug 1409044 - Pass the tooltool authentication file in Spidermonkey builds. r=Callek 2017-10-16 11:43:34 -04:00
Boris Zbarsky
211cfa1cfd Bug 1354730. Disable named property object (aka global scope polluter) behavior for all Xrays. r=kmag
MozReview-Commit-ID: KmbXFfSzH0N
2017-10-16 10:58:09 -04:00
Jason Laster
ec2b8dcbf8 Bug 1408562 - Update Debugger frontend (10-13). r=jdescottes
MozReview-Commit-ID: K8MnQctGfsO

--HG--
extra : rebase_source : 19b8644b6be1428f5f91ab8d63939cc8a68f7081
2017-10-16 11:23:12 +02:00
Andrea Marchesini
eadfc30ba5 Bug 1404105 - Sanitize.js must check if QuotaManager returns an error before continuing with cleaning data, r=janv 2017-10-16 11:50:01 +02:00
Nick Thomas
e5c55921c4 Bug 1387622 - revert firefox-sha1 alias change, r=rail a=release DONTBUILD
MozReview-Commit-ID: 7BgcdEWCNfn

--HG--
extra : rebase_source : 38ac134fcb1db7863b45206364ca00b05fe10ebf
extra : source : 31949068fe2c9cf147f00df0b8ccda57d74a337f
2017-10-06 09:44:12 +13:00
Nick Thomas
031b5a567c Bug 1408197 - beetmover fix round 2, r=bustage a=release
MozReview-Commit-ID: D3g4ZSapaim

--HG--
extra : rebase_source : f743860849aaf53df6be06493de30cd4696a51f4
extra : intermediate-source : 03ac2dcd9553a8cd6bc87197bb375f4803e86498
extra : source : d96198d960f3cbc4d17eb9990c801c1903d454fd
2017-10-13 17:23:46 +13:00
Jonathan Kew
290894f3c9 Bug 1408782 - Force punycode display for IDNs with a <dotless-i, combining mark above> sequence. r=valentin 2017-10-16 10:19:52 +01:00
Sebastian Hengst
f7a833d4c3 merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-10-16 10:58:45 +02:00